| *** openstackgerrit has quit IRC | 00:01 | |
| *** naohirot has joined #openstack-ironic | 00:01 | |
| *** tsekiyama has quit IRC | 00:01 | |
| *** openstackgerrit has joined #openstack-ironic | 00:02 | |
| *** tsekiyama has joined #openstack-ironic | 00:03 | |
| lifeless | jlvillal: and now I can't reproduce the test suite failures :/ | 00:07 |
|---|---|---|
| jlvillal | lifeless: Which failures? | 00:07 |
| lifeless | jlvillal: your fixtures patch | 00:08 |
| jlvillal | lifeless: Do you mean the test failures on github? | 00:08 |
| lifeless | jlvillal: you had, and I reproduced, errors on master | 00:08 |
| lifeless | jlvillal: the travis thing was due to no .travis.yml yet... | 00:08 |
| * jlvillal had saw some ruby errors. | 00:08 | |
| lifeless | https://github.com/testing-cabal/fixtures/pull/14 | 00:08 |
| jlvillal | lifeless: Ah. Right! | 00:08 |
| lifeless | fixes that | 00:08 |
| lifeless | but there was a bunch of local errors | 00:09 |
| jlvillal | lifeless: Yeah, I remember my tox test failed. Something like README | 00:09 |
| lifeless | possibly fixed by my change to use mock in preference to unittest.mock | 00:09 |
| jlvillal | lifeless: So now, no errors? Maybe it was some other package. Or your fix :) | 00:09 |
| lifeless | anyhow https://travis-ci.org/testing-cabal/fixtures/builds/84210705 is green | 00:09 |
| *** zer0c00l has quit IRC | 00:09 | |
| jlvillal | lifeless: Thanks. That's good news :) | 00:09 |
| *** zer0c00l has joined #openstack-ironic | 00:09 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Add LOG.debug() if requested device type not found https://review.openstack.org/232283 | 00:10 |
| *** sdake_ has joined #openstack-ironic | 00:11 | |
| *** sdake has quit IRC | 00:11 | |
| *** tsekiyam_ has joined #openstack-ironic | 00:17 | |
| *** tsekiyama has quit IRC | 00:20 | |
| lifeless | jlvillal: https://github.com/testing-cabal/fixtures/pull/15 | 00:21 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Add trailing periods to exception messages https://review.openstack.org/232289 | 00:21 |
| *** achanda has quit IRC | 00:21 | |
| *** tsekiyam_ has quit IRC | 00:21 | |
| jlvillal | lifeless: Cool :) | 00:21 |
| lifeless | jlvillal: needs some six juice poured on it | 00:21 |
| *** mtanino has quit IRC | 00:22 | |
| jlvillal | lifeless: Ah. So I should re-spin it? | 00:22 |
| lifeless | jlvillal: six.reraise specifically | 00:22 |
| lifeless | jlvillal: yeah | 00:22 |
| lifeless | let me do a full revioew | 00:22 |
| lifeless | so I don't make you churn | 00:22 |
| jlvillal | lifeless: Okay. A task for tomorrow. | 00:22 |
| *** shadower has joined #openstack-ironic | 00:23 | |
| *** d0ugal has quit IRC | 00:24 | |
| *** achanda has joined #openstack-ironic | 00:26 | |
| lifeless | jlvillal: full review done, very easy changes | 00:28 |
| lifeless | jlvillal: if you don't get to it tomorrow, let me know and I'll do them and land it. | 00:28 |
| *** d0ugal has joined #openstack-ironic | 00:30 | |
| *** d0ugal is now known as Guest74554 | 00:30 | |
| *** achanda has quit IRC | 00:31 | |
| *** baoli_ has quit IRC | 00:32 | |
| *** baoli has joined #openstack-ironic | 00:32 | |
| *** achanda has joined #openstack-ironic | 00:36 | |
| *** achanda has quit IRC | 00:37 | |
| jlvillal | lifeless, I'll see if I can do it during my current two hour phone meeting :) | 00:37 |
| *** achanda has joined #openstack-ironic | 00:40 | |
| lifeless | jlvillal: \o/ meetings | 00:40 |
| lifeless | jlvillal: omg they sap my will to live | 00:40 |
| *** Sukhdev_ has quit IRC | 00:41 | |
| jlvillal | lifeless, I'm with you on that ;) | 00:41 |
| *** harlowja has quit IRC | 00:44 | |
| *** Nisha has quit IRC | 00:48 | |
| *** harlowja has joined #openstack-ironic | 00:59 | |
| jlvillal | lifeless, I updated pull-request. | 01:00 |
| *** dims has quit IRC | 01:00 | |
| lifeless | jlvillal: 1.4 released and on PyPI | 01:10 |
| jlvillal | lifeless, Thanks. Sorry I missed the import ordering and thanks for fixing it :) | 01:10 |
| lifeless | jlvillal: np | 01:10 |
| lifeless | jlvillal: not worth a round trip for trivia like that | 01:11 |
| jlvillal | :) | 01:11 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: iLO virtual media drivers to deploy without DHCP https://review.openstack.org/137567 | 01:23 |
| *** ijw_ has quit IRC | 01:27 | |
| *** baoli has quit IRC | 01:28 | |
| *** harshs has joined #openstack-ironic | 01:44 | |
| *** fandi has joined #openstack-ironic | 01:46 | |
| *** zhenguo_ has joined #openstack-ironic | 01:58 | |
| *** zhenguo_ is now known as zhenguo | 01:58 | |
| *** rloo has quit IRC | 01:59 | |
| *** baoli has joined #openstack-ironic | 02:01 | |
| jroll | devananda: wut. why is that using iscsi. that ain't right. do we maybe fall back to iscsi on partition images or something? (I hope not, I'll be real ragy) | 02:05 |
| *** sdake_ is now known as sdake | 02:15 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add db migration for tags table https://review.openstack.org/232308 | 02:28 |
| *** baoli has quit IRC | 02:29 | |
| *** sdake has quit IRC | 02:30 | |
| *** lazy_prince has joined #openstack-ironic | 02:39 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add db migration for tags table https://review.openstack.org/192576 | 02:39 |
| *** killer_prince has joined #openstack-ironic | 02:41 | |
| *** lazy_prince has quit IRC | 02:44 | |
| *** baoli has joined #openstack-ironic | 02:46 | |
| jroll | any oneview folks around? | 02:47 |
| jroll | this blueprint says the driver depends on a nova feature that isn't done yet: https://blueprints.launchpad.net/ironic/+spec/new-ironic-driver-for-oneview | 02:48 |
| jroll | I assume that isn't true? | 02:48 |
| *** sdake has joined #openstack-ironic | 03:02 | |
| *** tristanC has quit IRC | 03:10 | |
| * mrda doesn't know | 03:11 | |
| *** tristanC has joined #openstack-ironic | 03:12 | |
| * jlvillal doesn't know either | 03:12 | |
| *** mrmoje has joined #openstack-ironic | 03:14 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Baremetal provisioning in UEFI secure boot mode for iLO drivers https://review.openstack.org/231927 | 03:18 |
| *** Sukhdev has joined #openstack-ironic | 03:27 | |
| *** harshs has quit IRC | 03:28 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add db migration for tags table https://review.openstack.org/192576 | 03:41 |
| *** Nisha has joined #openstack-ironic | 03:43 | |
| *** rameshg87 has joined #openstack-ironic | 03:46 | |
| openstackgerrit | Shiina, Hironori proposed openstack/ironic: Fix typo in document https://review.openstack.org/232314 | 03:46 |
| *** amotoki has joined #openstack-ironic | 03:48 | |
| *** baoli has quit IRC | 03:49 | |
| *** VikasC has joined #openstack-ironic | 03:54 | |
| *** aweeks has quit IRC | 04:04 | |
| *** aweeks has joined #openstack-ironic | 04:05 | |
| *** Sukhdev has quit IRC | 04:07 | |
| *** JoshNang has quit IRC | 04:08 | |
| *** JoshNang has joined #openstack-ironic | 04:08 | |
| *** dims has joined #openstack-ironic | 04:10 | |
| *** aswadr has joined #openstack-ironic | 04:11 | |
| *** achanda has quit IRC | 04:11 | |
| *** killer_prince has quit IRC | 04:23 | |
| *** lazy_prince has joined #openstack-ironic | 04:39 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic-lib: Config drive support for whole disk images for iscsi based deploy https://review.openstack.org/230924 | 04:45 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Fix agent_ilo to remove floppy image https://review.openstack.org/232323 | 04:45 |
| *** morgan has quit IRC | 04:47 | |
| *** morgan has joined #openstack-ironic | 04:50 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic-lib: Config drive support for whole disk images for iscsi based deploy https://review.openstack.org/230924 | 04:59 |
| *** achanda has joined #openstack-ironic | 04:59 | |
| *** lazy_prince has quit IRC | 05:02 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Fix agent_ilo to remove floppy image https://review.openstack.org/232323 | 05:06 |
| *** harshs has joined #openstack-ironic | 05:12 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-python-agent: Add support for partition images in agent driver https://review.openstack.org/160224 | 05:19 |
| *** Marga_ has joined #openstack-ironic | 05:41 | |
| *** Marga_ has quit IRC | 05:42 | |
| *** Marga_ has joined #openstack-ironic | 05:42 | |
| *** mrmoje has quit IRC | 05:56 | |
| *** mrmoje has joined #openstack-ironic | 05:57 | |
| openstackgerrit | Martin André proposed openstack/ironic-python-agent: Reduce size of CoreOS ramdisk https://review.openstack.org/232338 | 05:59 |
| openstackgerrit | Martin André proposed openstack/ironic-python-agent: Update gitignore https://review.openstack.org/232345 | 06:07 |
| *** lazy_prince has joined #openstack-ironic | 06:14 | |
| *** harshs has quit IRC | 06:17 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for in-band cleaning in ISCSIDeploy https://review.openstack.org/220898 | 06:31 |
| *** Ng has quit IRC | 06:34 | |
| *** harshs has joined #openstack-ironic | 06:38 | |
| *** Ng has joined #openstack-ironic | 06:38 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Config drive support for whole disk images for iscsi based deploy https://review.openstack.org/225115 | 06:39 |
| *** teju has joined #openstack-ironic | 06:39 | |
| *** ukalifon1 has joined #openstack-ironic | 06:42 | |
| *** yog_ has joined #openstack-ironic | 06:43 | |
| *** jcoufal has joined #openstack-ironic | 06:49 | |
| *** pas-ha has joined #openstack-ironic | 06:55 | |
| *** harshs has quit IRC | 07:03 | |
| *** romainh has joined #openstack-ironic | 07:09 | |
| *** ndipanov has quit IRC | 07:11 | |
| *** Guest74554 is now known as d0ugal | 07:23 | |
| *** d0ugal has quit IRC | 07:23 | |
| *** d0ugal has joined #openstack-ironic | 07:23 | |
| *** ifarkas has joined #openstack-ironic | 07:25 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for in-band cleaning in ISCSIDeploy https://review.openstack.org/220898 | 07:33 |
| *** mrmoje has quit IRC | 07:44 | |
| *** dtantsur|afk is now known as dtantsur | 07:46 | |
| dtantsur | Morning Ironic | 07:46 |
| *** openstackstatus has quit IRC | 07:47 | |
| *** openstackstatus has joined #openstack-ironic | 07:48 | |
| *** ChanServ sets mode: +v openstackstatus | 07:48 | |
| *** subscope has joined #openstack-ironic | 07:54 | |
| *** MattMan has quit IRC | 07:57 | |
| *** MattMan has joined #openstack-ironic | 07:57 | |
| *** mbound has joined #openstack-ironic | 07:59 | |
| *** persia has quit IRC | 07:59 | |
| *** persia has joined #openstack-ironic | 08:00 | |
| openstackgerrit | Zhenguo Niu proposed openstack/python-ironicclient: Add more filters for chassis node-list https://review.openstack.org/222280 | 08:05 |
| *** derekh has joined #openstack-ironic | 08:05 | |
| *** achanda has quit IRC | 08:07 | |
| *** achanda has joined #openstack-ironic | 08:13 | |
| *** achanda has quit IRC | 08:15 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Update iSCSI drivers cleaning spec https://review.openstack.org/232409 | 08:25 |
| *** lucasagomes has joined #openstack-ironic | 08:26 | |
| *** mkovacik has joined #openstack-ironic | 08:29 | |
| *** jistr has joined #openstack-ironic | 08:40 | |
| openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Use requests lib in HTTPClient https://review.openstack.org/229286 | 08:46 |
| *** ndipanov has joined #openstack-ironic | 08:46 | |
| *** mrmoje has joined #openstack-ironic | 08:48 | |
| *** athomas has quit IRC | 08:56 | |
| lintan_ | Hi, jroll, mrda,jlvilla,devananda,rloo,TheJulia, I create an etherpad https://etherpad.openstack.org/p/Rewite_AMT_Driver to write down the current issues we have for AMT driver to make sure everyone are on the same page to discuss | 08:58 |
| *** athomas has joined #openstack-ironic | 08:59 | |
| openstackgerrit | Merged openstack/ironic: Fix irmc driver unit test https://review.openstack.org/231900 | 09:01 |
| openstackgerrit | Bob Ball proposed openstack/ironic: XenAPI: Add support for XenServer VMs https://review.openstack.org/231381 | 09:06 |
| *** marzif has joined #openstack-ironic | 09:07 | |
| *** pelix has joined #openstack-ironic | 09:11 | |
| vdrok | morning ironic | 09:11 |
| vdrok | morning dtantsur | 09:11 |
| dtantsur | morning vdrok | 09:12 |
| openstackgerrit | Dingyx proposed openstack/ironic-specs: lenovo driver proposal https://review.openstack.org/208319 | 09:16 |
| *** achanda has joined #openstack-ironic | 09:16 | |
| lucasagomes | vdrok, dtantsur morning | 09:19 |
| vdrok | morning lucasagomes | 09:19 |
| dtantsur | lucasagomes, o/ | 09:19 |
| *** achanda has quit IRC | 09:21 | |
| *** e0ne has joined #openstack-ironic | 09:23 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Fixes logging of failure in deletion of swift temporary object https://review.openstack.org/232440 | 09:36 |
| *** dtantsur is now known as dtantsur|brb | 09:36 | |
| sambetts | Morning dtantsur, lucasagomes vdrok | 09:40 |
| lucasagomes | sambetts, morning | 09:40 |
| sambetts | dtantsur, lucasagomes: Is there a list of IPAs non-python dependecies anywhere? | 09:41 |
| lucasagomes | sambetts, yea I think you can look at the DockerFile | 09:42 |
| lucasagomes | sambetts, https://github.com/openstack/ironic-python-agent/blob/master/Dockerfile#L16-L19 | 09:42 |
| sambetts | lucasagomes: Awesome :D I've managed to get a tiny core IPA image nearly working I think its just missing some dependecies | 09:43 |
| lucasagomes | :-) niceee | 09:45 |
| *** BobBall has joined #openstack-ironic | 09:48 | |
| *** BobBall is now known as Guest79848 | 09:49 | |
| *** Guest4559 has quit IRC | 09:52 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Use mount -t sysfs to avoid host /sys dependencies https://review.openstack.org/231658 | 09:54 |
| vdrok | sambetts, morning | 09:54 |
| *** naohirot has quit IRC | 09:57 | |
| *** romcheg has joined #openstack-ironic | 09:59 | |
| *** Guest79848 is now known as GnomeKing | 10:03 | |
| *** GnomeKing is now known as Bob_Ball | 10:03 | |
| *** romcheg has quit IRC | 10:05 | |
| *** romcheg has joined #openstack-ironic | 10:06 | |
| *** marzif has quit IRC | 10:10 | |
| *** Nisha has quit IRC | 10:11 | |
| *** kbyrne has quit IRC | 10:12 | |
| *** kbyrne has joined #openstack-ironic | 10:14 | |
| rameshg87 | lucasagomes: hi | 10:18 |
| rameshg87 | lucasagomes: when you get some time, please have a look at https://review.openstack.org/220898 . I got it implemented the stuff that were discussing yesterday. | 10:18 |
| *** persia has quit IRC | 10:26 | |
| *** persia has joined #openstack-ironic | 10:27 | |
| lucasagomes | rameshg87, hi there | 10:28 |
| rameshg87 | lucasagomes: hello, just wanted to let you know about the above ^^ . please take a look at it when you get free time.. | 10:28 |
| lucasagomes | will take a look | 10:28 |
| rameshg87 | lucasagomes: it seems we can detect if it's a bash ramdisk or not properly :) | 10:28 |
| lucasagomes | rameshg87, yeah we can't, it was architected that way | 10:29 |
| lucasagomes | to have no extra configuration when migrating from one ramdisk to another | 10:29 |
| rameshg87 | lucasagomes: no. I said "we can" | 10:29 |
| rameshg87 | :) | 10:29 |
| lucasagomes | oh | 10:29 |
| lucasagomes | rameshg87, once it boots right? | 10:29 |
| rameshg87 | lucasagomes: please have a look at above patch :) | 10:29 |
| lucasagomes | will do | 10:29 |
| rameshg87 | lucasagomes: yeah, once it boots | 10:29 |
| rameshg87 | lucasagomes: same way we were discussing yesterday. but it works. | 10:30 |
| lucasagomes | cool will take a look | 10:30 |
| *** sdake has quit IRC | 10:41 | |
| *** trown|outttypeww is now known as trown | 10:42 | |
| *** dtantsur|brb is now known as dtantsur | 10:45 | |
| dtantsur | morning sambetts | 10:45 |
| dtantsur | sambetts, another source of ipa dependencies: https://github.com/openstack/diskimage-builder/blob/master/elements/ironic-agent/package-installs.yaml | 10:45 |
| sambetts | o/ dtantsur | 10:45 |
| *** thrash|g0ne is now known as thrash | 10:49 | |
| *** teju has quit IRC | 10:51 | |
| *** rameshg87 has quit IRC | 11:09 | |
| openstackgerrit | Merged openstack/ironic: Add retries to ssh._get_hosts_name_for_node https://review.openstack.org/224828 | 11:17 |
| *** achanda has joined #openstack-ironic | 11:19 | |
| *** achanda has quit IRC | 11:26 | |
| *** tombee has left #openstack-ironic | 11:29 | |
| *** lucasagomes is now known as lucas-hungry | 11:30 | |
| *** jcoufal_ has joined #openstack-ironic | 11:32 | |
| *** jcoufal has quit IRC | 11:34 | |
| *** marzif has joined #openstack-ironic | 11:37 | |
| *** thiagop has joined #openstack-ironic | 11:39 | |
| *** jcoufal has joined #openstack-ironic | 11:40 | |
| thiagop | Good morning Ironic | 11:41 |
| *** jcoufal_ has quit IRC | 11:42 | |
| *** jcoufal has quit IRC | 11:46 | |
| *** jcoufal has joined #openstack-ironic | 11:47 | |
| *** VikasC has quit IRC | 11:47 | |
| openstackgerrit | Shinn'ya Hoshino proposed openstack/ironic: Fix a bug error by passwords only includes numbers https://review.openstack.org/220385 | 11:51 |
| *** baoli has joined #openstack-ironic | 11:53 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed openstack/ironic: Refactor disk partitioner code from ironic and use ironic-lib. https://review.openstack.org/184443 | 11:59 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Validate the input of properties of nodes. https://review.openstack.org/215505 | 12:00 |
| openstackgerrit | Merged openstack/ironic: Remove unused import of oslo_log https://review.openstack.org/232275 | 12:00 |
| sinval | morning | 12:00 |
| vdrok | morning sinval thiagop | 12:14 |
| thiagop | vdrok: o/ | 12:14 |
| jroll | lintan_: we started one yesterday :) https://etherpad.openstack.org/p/new-ironic-amt-driver I will merge the two | 12:14 |
| jroll | morning sinval thiagop vdrok dtantsur sambetts lucas-hungry and anyone else :) | 12:14 |
| thiagop | morning jroll | 12:15 |
| jroll | thiagop: hey, question | 12:15 |
| vdrok | morning jroll | 12:15 |
| jroll | this blueprint says the driver depends on a nova feature that isn't done yet: https://blueprints.launchpad.net/ironic/+spec/new-ironic-driver-for-oneview | 12:15 |
| jroll | that isn't still true, right? | 12:15 |
| lintan_ | cool | 12:15 |
| thiagop | jroll: no. We changed it on the spec. Maybe we forgot to do the same in the blueprint | 12:15 |
| jroll | thiagop: cool, thanks | 12:16 |
| * jroll updates | 12:16 | |
| jroll | thiagop: fixed | 12:16 |
| jroll | lintan_: etherpads are merged | 12:16 |
| lintan_ | thanks | 12:16 |
| *** afaranha has joined #openstack-ironic | 12:17 | |
| thiagop | jroll: aw, you can edit blueprints! Awesome. Thanks. | 12:17 |
| *** lucas-hungry is now known as lucasagomes | 12:18 | |
| lucasagomes | jroll, thiagop lintan_ morning | 12:19 |
| thiagop | lucasagomes: o/ | 12:19 |
| jroll | thiagop: if I can't edit blueprints, we're all in trouble :P | 12:19 |
| thiagop | jroll: lol | 12:20 |
| lintan_ | morning lucasagomes | 12:21 |
| TheJulia | good morning | 12:22 |
| thiagop | morning TheJulia | 12:24 |
| dtantsur | morning thiagop, jroll, TheJulia | 12:27 |
| jroll | mornin TheJulia | 12:27 |
| thiagop | morning dtantsur | 12:28 |
| *** dprince has joined #openstack-ironic | 12:28 | |
| *** amotoki has quit IRC | 12:29 | |
| *** thiagop is now known as thiagop-away | 12:32 | |
| *** thiagop-away is now known as thiagop-afk | 12:34 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: Power off the machine before set_boot_device https://review.openstack.org/232186 | 12:34 |
| thiagop-afk | Folks, I need some thoughts on^ | 12:35 |
| thiagop-afk | I've changed some contexts for the tests to pass. Don't know exactly the extent it changes the behavior compared to a real deployment | 12:36 |
| jroll | thiagop-afk: the iscsi driver with IPA also uses that base vendor interface | 12:37 |
| thiagop-afk | jroll: I couldn't find out how this one works yet. I thought iscsi and ipa were mutually exlusive (since they are both deploy interfaces) | 12:39 |
| thiagop-afk | jroll: I plan to put a devstack to work at the end of the day and run some of the integration tests to see what happens | 12:41 |
| jroll | thiagop-afk: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L745 | 12:41 |
| thiagop-afk | jroll: don't know if will show me something, though | 12:41 |
| jroll | ah yeah, they'll get run in that CI | 12:41 |
| jroll | the only thing is that set_boot_device will/might(?) be called twice there. might be problematic on certain HW | 12:42 |
| jroll | thiagop-afk: oh, and for the iscsi driver the boot device might be pxe :) | 12:42 |
| thiagop-afk | jroll: damn, I need to rethink that with ramesh then... | 12:45 |
| jroll | thiagop-afk: yeah, something to think about. I wonder if we could just call driver.boot.prepare_instance() there. like: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L836 | 12:47 |
| jroll | not sure though | 12:47 |
| *** sambetts has quit IRC | 12:51 | |
| *** sambetts has joined #openstack-ironic | 12:51 | |
| *** masterbound has joined #openstack-ironic | 12:56 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add agent_amt driver https://review.openstack.org/231665 | 12:57 |
| jroll | devananda: ^ fixed pep8 | 12:57 |
| jroll | devananda: I'd also love to know if that works at all, or if it's completely broken because lolwsman | 12:57 |
| ifarkas | dtantsur, hi, could you please review https://review.openstack.org/#/c/232044/ and https://review.openstack.org/#/c/214160/ ? | 12:58 |
| *** boris-42 has quit IRC | 12:58 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: [WIP] Split conductor manager into several files https://review.openstack.org/232517 | 12:58 |
| dtantsur | you folks are going to call me crzy for that ^^ :D | 12:58 |
| *** nicodemos has joined #openstack-ironic | 12:58 | |
| dtantsur | ifarkas, sure thing | 12:58 |
| ifarkas | dtantsur, thanks | 12:59 |
| *** mbound has quit IRC | 12:59 | |
| *** smoriya has quit IRC | 13:02 | |
| jroll | dtantsur: I've been wondering when someone was going to do that :) | 13:03 |
| dtantsur | hehe :) | 13:03 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Begin adding dev docs for writing methods https://review.openstack.org/232011 | 13:03 |
| dtantsur | jroll, could you give your initial opinion on the patch? | 13:03 |
| dtantsur | (tests are not moved/fixed yet) | 13:03 |
| jroll | dtantsur: oh, interesting | 13:04 |
| jroll | so, this isn't bad | 13:04 |
| jroll | but with o.vo and the @remoteable thing, I kind of think we should move (for example) do_node_update to a node.update() method with @remotable to make it go to a conductor | 13:05 |
| jroll | wdyt? | 13:05 |
| dtantsur | hmmm yeah, I think I get it.. but tbh update and destroy are not the biggest things out there | 13:06 |
| *** lazy_prince has quit IRC | 13:06 | |
| dtantsur | my primary goal here is to make these files manageable :) | 13:06 |
| jroll | right, but same for ports etc | 13:06 |
| jroll | so NodeAPI, PortAPI, could be moved to objects.Node/Port | 13:07 |
| *** jaypipes has joined #openstack-ironic | 13:08 | |
| dtantsur | oh hmm... | 13:09 |
| *** jaypipes has left #openstack-ironic | 13:09 | |
| jroll | dtantsur: I guess I do like this patch regardless, so long as we have a goal of getting rid of those classes at some point | 13:09 |
| jroll | I just wonder if all of those could be moved into objects | 13:10 |
| dtantsur | jroll, lets not do it in the same patch, as it will require a huuuge diff in tests :) | 13:10 |
| dtantsur | but yeah, many of these eventually can | 13:10 |
| jroll | node.vendor_passthru etc | 13:10 |
| jroll | yeah, tests will be fun | 13:10 |
| romcheg | Hi folks! | 13:11 |
| romcheg | lifeless: around? | 13:11 |
| dtantsur | romcheg, o/ | 13:11 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Begin adding dev docs for writing methods https://review.openstack.org/232011 | 13:15 |
| romcheg | dtantsur: how, it going? | 13:16 |
| dtantsur | romcheg, pretty good, and how are you? | 13:16 |
| romcheg | dtantsur: have you ever get a Bad checksum error from a python job? | 13:16 |
| romcheg | dtantsur: I'm pretty much fine, learning how to drive :) | 13:17 |
| dtantsur | romcheg, wow, never Oo | 13:17 |
| romcheg | dtantsur: I keep getting it for py34, for py27 everything works well http://logs.openstack.org/95/227895/6/check/gate-python-fuelclient-python34/a86780f/console.html | 13:18 |
| jroll | whoa, interesting | 13:18 |
| jroll | probably worth asking -infra | 13:18 |
| dtantsur | romcheg, I can only suspect https://bugs.launchpad.net/neutron/+bug/1504053 | 13:19 |
| openstack | Launchpad bug 1504053 in neutron "Fixtures 1.4.0 makes Py34 unit tests fail" [Critical,In progress] - Assigned to Ihar Hrachyshka (ihar-hrachyshka) | 13:19 |
| dtantsur | (does not look too similar, just because of py34) | 13:19 |
| romcheg | jroll: it also happens on my local environment, I was about to ask lifeless but he seems to be offline at this time | 13:20 |
| romcheg | dtantsur: nah, it doesn't | 13:20 |
| *** marzif has quit IRC | 13:20 | |
| dtantsur | romcheg, I would still try to downgrade fixtures just in case (if you even use it) | 13:21 |
| *** marzif has joined #openstack-ironic | 13:22 | |
| romcheg | dtantsur: nope :) | 13:22 |
| *** achanda has joined #openstack-ironic | 13:24 | |
| romcheg | dtantsur: it also fails ther same way for py26 | 13:24 |
| lucasagomes | romcheg, https://review.openstack.org/#/c/220713/ | 13:26 |
| *** achanda has quit IRC | 13:27 | |
| *** achanda has joined #openstack-ironic | 13:27 | |
| *** achanda has quit IRC | 13:27 | |
| dtantsur | wow, I like testr... | 13:28 |
| romcheg | lucasagomes: wow | 13:28 |
| lucasagomes | it's a workaround but yeah... worth testing | 13:28 |
| romcheg | I have no idea how it worked | 13:28 |
| romcheg | I mean, it works for me now, but looks like an elder sorcery :) | 13:29 |
| lucasagomes | heh yeah some black magic there | 13:30 |
| romcheg | lucasagomes: thank you so much! | 13:30 |
| lucasagomes | no worries | 13:30 |
| *** rloo has joined #openstack-ironic | 13:31 | |
| romcheg | ah, no, false alarm | 13:32 |
| romcheg | it doesn't | 13:32 |
| romcheg | ^) | 13:32 |
| lucasagomes | :-( | 13:32 |
| lucasagomes | romcheg, same error? | 13:32 |
| jlvillal | dtantsur, I'm a fan of refactoring if it makes things better :) | 13:32 |
| dtantsur | :) | 13:32 |
| romcheg | lucasagomes: yup | 13:33 |
| dtantsur | 2100 LoC in manager.py, 4500+ LoC in test_manager.py - something worth refactoring :) | 13:33 |
| lucasagomes | romcheg, https://review.openstack.org/#/c/227895/7/.testr.conf | 13:33 |
| jlvillal | Good morning Ironic. jroll lucasagomes dtantsur romcheg ifarkas and everyone else I missed | 13:33 |
| lucasagomes | it's not "/neutron/tests/unit" | 13:34 |
| jlvillal | dtantsur, yep:) | 13:34 |
| romcheg | lucasagomes: I know, I changed in my local env | 13:34 |
| romcheg | it worked locally with neutron :Đ’ | 13:34 |
| lucasagomes | lol | 13:34 |
| lucasagomes | wth | 13:34 |
| sambetts | o/ jlvillal | 13:34 |
| romcheg | I mean, it showed a failure but then it showed a success | 13:34 |
| lucasagomes | jlvillal, hi there | 13:34 |
| lucasagomes | romcheg, odd | 13:35 |
| jlvillal | sambetts, I missed your name! Good morning. | 13:35 |
| sambetts | jlvillal: Hows it going? :) | 13:37 |
| romcheg | they started failing after I used testtools | 13:37 |
| jlvillal | sambetts, Good. Just waking up :) | 13:38 |
| jroll | mornin jlvillal :) | 13:38 |
| jlvillal | :) | 13:38 |
| * sambetts hands jlvillal a coffee | 13:39 | |
| * jlvillal drinks coffee and thanks sambetts | 13:39 | |
| sambetts | I'm actually trying a new coffee today, in the UK we've got a mail order ground coffee company and I got a limited edition one from them, and its really good | 13:41 |
| *** marzif has quit IRC | 13:41 | |
| *** marzif has joined #openstack-ironic | 13:41 | |
| jroll | lucasagomes: did we do work to make capabilities a dict or am I imagining things? | 13:41 |
| lucasagomes | jroll, I remember someone said he/she would work on that? Not sure it's done | 13:42 |
| * lucasagomes checks | 13:42 | |
| jroll | lucasagomes: yeah, I don't see code to handle it | 13:42 |
| jroll | cool, I'm not crazy | 13:42 |
| lucasagomes | jroll, yeah, I think I had some old code here too... lemme check my tree | 13:42 |
| jroll | lucasagomes: no worries, just curious :) | 13:43 |
| lucasagomes | right | 13:43 |
| *** boris-42 has joined #openstack-ironic | 13:43 | |
| jlvillal | sambetts, sounds interesting. I'll be honest I usually drink Twinings Earl Grey tea. | 13:43 |
| jlvillal | loose leaf of course... | 13:44 |
| vdrok | morning romcheg and jlvillal | 13:44 |
| lucasagomes | jroll, we fixed that right https://bugs.launchpad.net/ironic/+bug/1493878 ? | 13:44 |
| openstack | Launchpad bug 1493878 in Ironic "SSL support for Ironic" [Medium,Triaged] | 13:44 |
| lucasagomes | we still could use the middleware but that would just complement what we already have | 13:44 |
| jlvillal | vdrok, Good morning | 13:44 |
| romcheg | vdrok: good evening! | 13:45 |
| vdrok | :) | 13:45 |
| jlvillal | dtantsur, Did anyone give you any ideas why the ironic-lib checks fail? | 13:46 |
| sambetts | jlvillal: Very up market :-p | 13:46 |
| jlvillal | sambetts, I get it from Amazon ;) | 13:46 |
| dtantsur | jlvillal, I think the gate was/is broken | 13:46 |
| * lucasagomes marked as duplicated with the other bug | 13:46 | |
| jlvillal | dtantsur, Thanks. I hope it is fixed now! | 13:47 |
| jroll | lucasagomes: yeah, that's fixed, I wish we tested that in the gate or something | 13:47 |
| lucasagomes | yeah, that would be good | 13:47 |
| BadCub | morning Ironicville | 13:51 |
| NobodyCam | good morning Ironicers | 13:51 |
| romcheg | NobodyCam: hi there! | 13:52 |
| jroll | morning NobodyCam, BadCub :) | 13:52 |
| NobodyCam | morning dtantsur lucasagomes sambetts vdrok jlvillal jroll devananda BadCub TheJulia | 13:52 |
| NobodyCam | wow romcheg | 13:52 |
| NobodyCam | how have you been | 13:52 |
| lucasagomes | NobodyCam, BadCub morning | 13:52 |
| rloo | morning everyone, NobodyCam, BadCub, romcheg, jroll, jlvillal, lucasagomes, sambetts, dtantsur | 13:52 |
| jlvillal | Woot, NobodyCam! :) | 13:52 |
| vdrok | morning NobodyCam and BadCub :) | 13:53 |
| lucasagomes | rloo, morning | 13:53 |
| NobodyCam | :) morning jroll lucasagomes jlvillal vdrok | 13:53 |
| jlvillal | Woo, rloo! :) | 13:53 |
| rloo | hi vdrok | 13:53 |
| NobodyCam | mornign rloo | 13:53 |
| jlvillal | s/Woo/Woot/ | 13:53 |
| rloo | jroll, lucasagomes: wrt capabilities & dictionaries, no implementation yet | 13:53 |
| vdrok | morning rloo | 13:53 |
| lucasagomes | rloo, :-( | 13:53 |
| lucasagomes | found the bug about it | 13:53 |
| BadCub | hiya jroll lucasagomes rloo vdrok jlvillal :) | 13:53 |
| romcheg | NobodyCam: I'm pretty fine, more or less settled in Poland now :) | 13:53 |
| rloo | jroll, lucasagomes: if i recall, there was a bug and someone was going to work on it, until someone else mentioned that there was a spec. | 13:53 |
| lucasagomes | https://bugs.launchpad.net/ironic/+bug/1421261 | 13:53 |
| openstack | Launchpad bug 1421261 in Ironic " node's properties['capabilities'] value should be a dictionary" [Wishlist,Triaged] - Assigned to Pranesh (praneshpg) | 13:53 |
| jlvillal | Hi BadCub :) | 13:53 |
| romcheg | NobodyCam: yourself? | 13:54 |
| lucasagomes | rloo, there's no action in the bug for I while | 13:54 |
| jroll | rloo: yeah, I'm not worried about it, was just surprised it wasn't done | 13:54 |
| lucasagomes | lemme do it, I think I can cook a quick patch for it | 13:54 |
| rloo | jroll: pranesh was going to work on it until someone pointed out the spec | 13:54 |
| jroll | thiagop-afk: sinval: reviewed the oneview thing, I think it's really close. lots of nits and a couple of concerns in there | 13:54 |
| dtantsur | morning NobodyCam, BadCub, rloo | 13:54 |
| BadCub | mornin romcheg dtantsur | 13:54 |
| jroll | lucasagomes: you may want to base that on top of the oneview driver, that driver uses/adds a bunch of capabilities stuff | 13:54 |
| sinval | jroll, thanks | 13:54 |
| lucasagomes | jroll, cool, yeah lemme just see how much work is needed for it | 13:55 |
| * BadCub has to run for the morning of conference calls lol | 13:55 | |
| * lucasagomes should be much | 13:55 | |
| lucasagomes | rloo, a spec? I wonder cause it should be a big change right? | 13:55 |
| jroll | lucasagomes: yeah, don't feel bad punting until later though | 13:55 |
| rloo | lucasagomes, jroll: https://review.openstack.org/#/c/182934/ | 13:55 |
| jroll | I think the spec was about making nova use it properly as a dict | 13:55 |
| lucasagomes | the tricky is to make it backward compat, we should ocntinue to support strings | 13:55 |
| lucasagomes | ah right | 13:55 |
| thiagop-afk | Thanks jroll. We'll look into that today. | 13:56 |
| jroll | lucasagomes: right | 13:56 |
| jroll | lucasagomes: rloo we should just skip the dict thing and split to another table | 13:56 |
| rloo | jroll, lucasagomes: you might want to look at that spec. jroll, your name is mentioned in one of the comments wrt doing something... | 13:56 |
| rloo | jroll: yeah, split to another table thingy. | 13:56 |
| jroll | ya | 13:56 |
| rloo | jroll: oh. so we're waiting for you I guess :) | 13:57 |
| lucasagomes | right, if we split to another table it would mean that capabilities wll be annother field for nodes? | 13:57 |
| lucasagomes | and not leave in properties? | 13:57 |
| lucasagomes | live* | 13:57 |
| rloo | jroll, lucasagomes: i think that makes sense, capabilities is just going to grow and take over the world | 13:57 |
| jroll | rloo: I'd be ecstatic if someone else did it :D | 13:57 |
| jroll | lucasagomes: yeah, I think so, though compatibility stuff is weird. we don't promise compat for things within properties, but we'd break nova real fast if we moved it :/ | 13:58 |
| rloo | jroll: oh, looking for volunteers? i could. | 13:58 |
| jroll | rloo: \o/ | 13:58 |
| lucasagomes | jroll, yeah... sounds much bigger than just being able to use it as a dict right now | 13:59 |
| jroll | rloo: this fits in with some of the nova refactoring, too... I'm trying to write that spec this week so maybe hold off on looking until monday :) | 13:59 |
| jroll | lucasagomes: yeah, but if we add dict compat, there's two things to maintain compatibility for :) | 13:59 |
| rloo | jroll: oh, i wasn't going to look at that before next week. i'm here today and then gone til tues. so want to look at existing specs/summit topics today. | 13:59 |
| jroll | cool, sounds good | 14:00 |
| *** ionutbalutoiu has joined #openstack-ironic | 14:00 | |
| *** marzif has quit IRC | 14:00 | |
| *** linggao has joined #openstack-ironic | 14:01 | |
| *** marzif has joined #openstack-ironic | 14:01 | |
| lucasagomes | jroll, right yeah | 14:01 |
| linggao | Hi jroll, can you let me know how to build images for agent_ipmitool driver? | 14:02 |
| *** marzif has quit IRC | 14:02 | |
| jroll | linggao: http://docs.openstack.org/developer/ironic/deploy/install-guide.html#building-or-downloading-a-deploy-ramdisk-image | 14:02 |
| jroll | stepping away for a bit | 14:03 |
| jlvillal | dtantsur, Nice, the requirements gate passed :) | 14:09 |
| dtantsur | \o/ | 14:09 |
| *** frontrunner has joined #openstack-ironic | 14:09 | |
| rloo | lucasagomes: wrt https://review.openstack.org/#/c/231695/ | 14:11 |
| rloo | lucasagomes: the current process is to put specs into approved/, and after it is implemented, move to <cycle>-implemented | 14:11 |
| linggao | jroll, thanks for the link. That link tells us how to build deploy kernel and ramdisk. But how to build the a user whole disk image? I understand that currently IPA only supprts whole disk image. Am I right? | 14:11 |
| rloo | lucasagomes: now we have our semver versioning so JayF thought it would be useful to group the implemented specs under their versions | 14:11 |
| lucasagomes | rloo, who will move it? The person who submitted the spec? Or release liaison? Other? | 14:12 |
| frontrunner | hi - noob here - i am trying to get started with kilo-ironic and this command is failing for me: chown -R ironic /tfptroot. Apparently the user does not exist. Suggestions? | 14:12 |
| rloo | lucasagomes: and a separate discussion in Monday's meeting was about how the spec files get moved around | 14:12 |
| rloo | lucasagomes: jroll moved them. | 14:12 |
| rloo | lucasagomes: i think devananda moved them in the past too | 14:12 |
| lucasagomes | ok, so PTL is responsable for it? | 14:12 |
| rloo | lucasagomes: i'm guessing 'release person' is responsible for it :) | 14:12 |
| lucasagomes | I was just wondering because it's quite a manual thing to do | 14:13 |
| rloo | lucasagomes: although i suspect anyone could propose moving a spec once it is implemented. most of us "don't care" to do it :) | 14:13 |
| lucasagomes | frontrunner, you have to create it | 14:13 |
| rloo | lucasagomes: yes, it is a manual thing and I don't want to move the actual file. it breaks external references | 14:13 |
| lucasagomes | Ironic assumes you already have a tftp listen to the /tftproot (or any other folder you confgured for ur tftp) | 14:13 |
| lucasagomes | rloo, sure right, yea link it etc... ok | 14:14 |
| jlvillal | frontrunner, How is it failing? | 14:14 |
| rloo | lucasagomes: 231695 doesn't move anything, just added links to the files. which is how i think we should handle them in the future. | 14:14 |
| jlvillal | frontrunner, You probably have to do: sudo chown -R ironic /tftproot/ | 14:14 |
| frontrunner | lucasgnome: are there docs that detail that anywhere? | 14:14 |
| lucasagomes | frontrunner, not as detailed as we would like but http://docs.openstack.org/developer/ironic/deploy/install-guide.html#pxe-setup | 14:15 |
| jlvillal | frontrunner, As a note the directory name as you posted it is wrong 'tfptroot' should be "tftproot" | 14:15 |
| jlvillal | frontrunner, Ignore that. | 14:16 |
| jlvillal | frontrunner, Actualy no I was correct. the 'p' and 't' are flipped | 14:16 |
| lucasagomes | rloo, ok, well if it was agreed already it's cool | 14:17 |
| thiagop-afk | jroll: we can low that polling attempts to 12 (~2min), would that be reasonable? Just to make it clear, if it receives a positive response (or exception), the retry will stop. | 14:18 |
| *** thiagop-afk is now known as thiagop | 14:20 | |
| *** ionutbalutoiu has quit IRC | 14:20 | |
| frontrunner | i don't recall having to create any of the other user accounts like: swift,keystone etc. i would have thought configuration was all similar. | 14:21 |
| *** ionutbalutoiu has joined #openstack-ironic | 14:21 | |
| jlvillal | frontrunner, What account do you mean? | 14:21 |
| jlvillal | frontrunner, As a note on my system it is located in /var/lib/tftproot/ | 14:21 |
| frontrunner | this fails: chown -R ironic /tftpboot | 14:22 |
| frontrunner | no such user | 14:22 |
| jlvillal | frontrunner, What user are you planning on running the ironic server as? | 14:23 |
| jlvillal | That user needs to own /tftpboot/ | 14:23 |
| frontrunner | jlvillal, i am just following the docs that say i need to run that ownership command | 14:24 |
| jlvillal | frontrunner, link please? Maybe we need to fix docs? | 14:24 |
| *** lazy_prince has joined #openstack-ironic | 14:24 | |
| frontrunner | jlvillal, just search for "chown" here: http://docs.openstack.org/developer/ironic/deploy/install-guide.html#pxe-setup | 14:25 |
| jlvillal | frontrunner, It says "for example..." | 14:27 |
| jlvillal | But above that it says as the user the ironic conductor will run as. | 14:27 |
| jlvillal | frontrunner, I admit it could be clearer. That the user should be created. | 14:27 |
| jlvillal | frontrunner, Make sure the tftp root directory exist and can be written to by the user the ironic-conductor is running as. For example: | 14:28 |
| *** achanda has joined #openstack-ironic | 14:28 | |
| jlvillal | Maybe it should say: For example if you have created the user ironic to run the ironic-conductor you would do this: | 14:29 |
| *** lazy_prince has quit IRC | 14:29 | |
| *** sdake has joined #openstack-ironic | 14:29 | |
| *** penick has joined #openstack-ironic | 14:30 | |
| *** lazy_prince has joined #openstack-ironic | 14:31 | |
| frontrunner | jlvillal, sorry, but i am primarily a Windows person. Who is this 'user'? all the other openstack services seem to run under user accounts that are the same name as the service. i am stuck at thinking that Ironic is a service that will access local files using the unix user account name "ironic". | 14:31 |
| *** mtanino has joined #openstack-ironic | 14:31 | |
| jlvillal | frontrunner, On unix you create users. # adduser ironic | 14:32 |
| jlvillal | For example would create the user ironic. | 14:32 |
| jlvillal | But yes I think it would be good to document that the user needs to be created instead of assuming people just know that. | 14:33 |
| frontrunner | jlvillal, is my problem that fact that all the other services have created their own user accounts and that this is the first service I have tried to setup that requires me to set that account up manually? | 14:33 |
| jlvillal | frontrunner, Maybe. I'm not sure how the other services install. | 14:34 |
| jroll | linggao: I think you just add the 'vm' element to your disk-image-builder command | 14:34 |
| frontrunner | jlvillal, i will add the command you suggest and try again - thanks! | 14:34 |
| jlvillal | frontrunner, I do think that people manually create the ironic user. | 14:34 |
| jroll | thiagop: it will never receive a positive response because you just shut down the server... | 14:35 |
| jlvillal | frontrunner, Sorry it has been difficult :( | 14:35 |
| linggao | jroll, thanks. We'll give it a try. | 14:35 |
| frontrunner | lol! | 14:35 |
| thiagop | jroll: that's the beauty of oneview, it responds | 14:35 |
| jroll | thiagop: no, the thing being retried, is trying to talk to the agent | 14:35 |
| jroll | thiagop: which is gone as soon as you power off | 14:35 |
| lucasagomes | jroll, just to confirm, we don't want to have capabilities as dict? | 14:36 |
| * lucasagomes got it working locally | 14:36 | |
| jroll | lucasagomes: if we're planning to move it to another table, it's just more code to handle compat for. I do want to allow the API to handle a dict, but do we want to deal with compat for storage? | 14:37 |
| *** e0ne has quit IRC | 14:37 | |
| *** achanda has quit IRC | 14:38 | |
| lucasagomes | jroll, right yeah if we are moving it out I agree it's just more code to keep compat | 14:41 |
| jroll | lucasagomes: I'm all about json in the API though :) | 14:41 |
| lucasagomes | until then the pos is that it makes it simpler to handle capabilities internally when manipulating it as dict | 14:41 |
| thiagop | jroll: to the agent? The retries are on pyhton-oneviewclient. | 14:41 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Split conductor manager into several files https://review.openstack.org/232517 | 14:41 |
| lucasagomes | jroll, sure me too, it's pretty hard to append/delete capabilities when it's a string | 14:41 |
| lucasagomes | it's a lot of "for's" | 14:42 |
| jroll | thiagop: reboot_and_finish_deploy calls a soft shutdown command on the agent | 14:42 |
| lucasagomes | even the code in nova has a for loop for it | 14:42 |
| jroll | lucasagomes: yeah :( | 14:42 |
| *** harshs has joined #openstack-ironic | 14:42 | |
| thiagop | jroll: aw, but that retry doesn't uses the max_polling_attempts on the OVDriver | 14:42 |
| jroll | thiagop: right, which is why I talked about maybe just documenting which settings | 14:43 |
| jroll | thiagop: because otherwise it's going to spend a while trying to tell the agent to shut down | 14:43 |
| jroll | thiagop: I'd rather just reimplement reboot_and_finish_deploy within reboot_to_instance for now, until we figure out how to rework that stuff | 14:44 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add node's properties/capabilities as dict support https://review.openstack.org/232571 | 14:44 |
| lucasagomes | jroll, ^ that's what is needed in any case... (missing the code in nova, but it's small too) | 14:44 |
| jroll | lucasagomes: oh, right, the API doesn't validate/manipulate that at all eh | 14:45 |
| jroll | :( | 14:45 |
| lucasagomes | no we don't | 14:45 |
| lucasagomes | jroll, good thing is that we have helper functions to manipulate the capabilities, so things are encapsulated | 14:48 |
| openstackgerrit | Merged openstack/ironic: Fix typo in document https://review.openstack.org/232314 | 14:48 |
| jroll | yeah | 14:49 |
| *** mkovacik has quit IRC | 14:50 | |
| *** harshs has quit IRC | 14:52 | |
| *** penick has quit IRC | 14:53 | |
| *** mtreinish has quit IRC | 14:54 | |
| *** mtreinish has joined #openstack-ironic | 14:54 | |
| *** e0ne has joined #openstack-ironic | 14:57 | |
| thiagop | is there a pipeline on zuul to run the same tests the gate runs without being an approved patch? | 14:57 |
| rloo | dumb question. What happens when a node in ACTIVE state is put in maintenance. What does the user see? | 14:57 |
| jroll | thiagop: the gate is a subset of the check jobs, at least for us | 14:58 |
| jroll | rloo: user sees nothing | 14:58 |
| rloo | jroll: so user can continue to use the node? | 14:58 |
| thiagop | rloo: on terminal? | 14:58 |
| jroll | rloo: when the instance is deleted, it will boot the agent and heartbeat forever until maintenance is removed, at which point it will clean | 14:58 |
| jroll | rloo: ep | 14:59 |
| jroll | yep | 14:59 |
| rloo | thiagop: what do you mean 'on terminal'? | 14:59 |
| lucasagomes | rloo, yeah he will be able to use it | 14:59 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Split conductor manager into several files https://review.openstack.org/232517 | 14:59 |
| thiagop | rloo: your question is about what the user see on terminal or on node-list? | 14:59 |
| *** achanda has joined #openstack-ironic | 14:59 | |
| rloo | jroll: a node is ACTIVE when it has been deployed to so a user is using it | 14:59 |
| lucasagomes | (if the reason why it's maintenance didn't actually bring the node down) | 14:59 |
| jroll | rloo: right | 14:59 |
| jroll | rloo: we do this all the time for about-to-fail hardware | 14:59 |
| rloo | jroll: if it is active/maintenance and we delete the instance, the user will lose access to their node? | 15:00 |
| jroll | rloo: yes | 15:00 |
| rloo | jroll: so when you do this do you inform the user that it is going down? | 15:00 |
| jroll | rloo: it's more like, they may report that a disk is dead/dying, we maintenance it immediately, and deal with replacement after they're done moving data etc | 15:01 |
| jroll | maintenance_reason: "customer reported drive failure oct 8 2015" | 15:01 |
| jroll | or something to that effect | 15:01 |
| rloo | jroll: ah. ok. so it isn't the case that node ACTIVE + maintenance, do something, remove maintenance, node is ACTIVE (NOT!) | 15:01 |
| *** achanda has quit IRC | 15:02 | |
| jroll | rloo: not sure what 'do something' is there, but yeah | 15:02 |
| rloo | jroll: well, someone suggested some manual clean (eg firmware update). | 15:02 |
| jroll | rloo: while active? | 15:03 |
| lucasagomes | that will bring down the node | 15:03 |
| rloo | jroll: yeah. | 15:03 |
| jroll | O_O | 15:03 |
| jroll | yeah I don't love that | 15:03 |
| rloo | jroll, lucasagomes: that's why i asked. presumably you could take the node down, do the upgrade, and reboot and the node can be active again? | 15:04 |
| jroll | rloo: it's technically possible, but holy cow | 15:04 |
| lucasagomes | rloo, right, yeah you can but the user won't be able to access it while it's down | 15:05 |
| lucasagomes | perhaps another way to do it would be to migrate the instance and data to a node which is already updated | 15:05 |
| dtantsur | I've heard the same idea about inspection btw | 15:05 |
| dtantsur | not that I like it.. | 15:05 |
| dtantsur | people wanted to reboot node in the inspection ramdisk, run some health checks, then either bring it back or kill it with fire | 15:05 |
| rloo | jroll, lucasagomes, dtantsur: ok, the easy thing for me to do now is 'this is outside the scope of my spec' but they seem like interesting ideas. | 15:05 |
| dtantsur | that's how I understood | 15:05 |
| jroll | yeah, there's also a virt driver bug fix from last cycle that operates under the assumption ram/disk/cpu can change while active | 15:05 |
| lucasagomes | tho that would be live migration... not sure how it would be done for bare metal | 15:06 |
| *** marzif has joined #openstack-ironic | 15:06 | |
| jroll | I mean, really, this is a pets vs cattle thing I think | 15:06 |
| jroll | and I do want to accept pets into our umbrella | 15:06 |
| lucasagomes | rloo, right, I think it depends on how to treat the machines in ur cluster | 15:06 |
| lucasagomes | each company may do it different | 15:07 |
| jroll | I'm just thinking about how this affects the state machine and having a sad | 15:07 |
| rloo | jroll: well, let's wait and see if someone submits a spec for that :) | 15:08 |
| lucasagomes | heh I'm not sure how Ironic would handle that tho... I mean, it sounds like we don't have much to do in this case | 15:08 |
| lucasagomes | unless it involves some cinder volumes and rebuilding the instance | 15:08 |
| jroll | rloo: yeah, I think it is outside the scope of this | 15:09 |
| jroll | lucasagomes: it would basically be adding ACTIVE -> MANUAL_CLEAN -> ACTIVE in the state machine :/ | 15:09 |
| rloo | jroll: did I really volunteer to do manual cleaning? :D | 15:09 |
| jroll | hehe | 15:09 |
| lucasagomes | lol | 15:09 |
| rloo | jroll: right. sort of. i was thinking we'd need a 'maintenance'-like state. | 15:09 |
| jroll | rloo: "managed"? :) | 15:10 |
| rloo | jroll: yeah. but manageable is taken and we have this maintenance flag which is diff... | 15:10 |
| jroll | right, was mostly joking | 15:10 |
| krotscheck | TheJulia: Thanks for the webclient reviews btw :) | 15:11 |
| lucasagomes | perhaps someone could: 1) get another machine, same specs that is working 2) evacuate the instance from machine 1 to the new machine | 15:11 |
| jroll | so here's my big question: does the *user* (the person with an instance) ever care to upgrade the firmware? | 15:12 |
| jroll | (probably yes, but I can't imagine why) | 15:12 |
| *** masterbound has quit IRC | 15:12 | |
| lucasagomes | yeah, it may depend... if the user is someone internal on the company and use that machine for, idk, test RAID | 15:13 |
| rloo | jroll: is it possible to get updated firmware that fixes some bug so the operators need to push that out to all hw? | 15:13 |
| lucasagomes | and that firmware version that feature does work | 15:13 |
| * lucasagomes made things up | 15:13 | |
| jroll | lucasagomes: then get a new test box :P | 15:13 |
| lucasagomes | jroll, yeah, I would say that too | 15:13 |
| jroll | rloo: the question is if there's a case where they need to roll that out ASAP | 15:13 |
| rloo | jroll, lucasagomes: people can always think of something. | 15:13 |
| jroll | yeah. | 15:14 |
| jroll | I can't tell people their use case is invalid | 15:14 |
| jroll | but it's a use case we never really planned for | 15:14 |
| rloo | jroll: dunno, i'm not an ops person. but if they did, ironic could be ready and waitin' :) | 15:14 |
| jroll | I think we should leave it out of this spec for sure | 15:14 |
| jroll | and talk about it more down the road | 15:14 |
| lucasagomes | which spec is that? | 15:14 |
| jroll | lucasagomes: manual clean | 15:14 |
| lucasagomes | ah... right, ok | 15:15 |
| jroll | https://review.openstack.org/#/c/231288/ | 15:15 |
| lucasagomes | yeah seems out of scope indeed (assuming manual cleaning == zapping) | 15:15 |
| rloo | jroll: yeah, i was going to add it as a usecase that is outside the scope of the spec, but i decided after this discussion not to mention it at all. | 15:15 |
| rloo | lucasagomes: assumption is correct. (mostly ==) | 15:15 |
| jroll | rloo: yeah, let's wait for later | 15:15 |
| lucasagomes | cool | 15:16 |
| TheJulia | krotscheck: no problem :) | 15:17 |
| *** Nisha has joined #openstack-ironic | 15:17 | |
| *** mbound has joined #openstack-ironic | 15:20 | |
| aarefiev | jroll: hi, could you take a look on https://review.openstack.org/#/c/221778/ when you have time, please | 15:21 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add db api layer for CRUD operations on node tags https://review.openstack.org/232598 | 15:21 |
| jroll | aarefiev: yes! added to my queue | 15:22 |
| *** david-ly_ has joined #openstack-ironic | 15:22 | |
| aarefiev | jroll: thanks | 15:22 |
| aarefiev | JayF, you might be interested in ^^ | 15:22 |
| *** david-lyle has quit IRC | 15:23 | |
| jroll | np | 15:23 |
| jroll | I want to try to hit that this cycle | 15:23 |
| jroll | also keystone v3 | 15:23 |
| aarefiev | jroll: it would be nice | 15:23 |
| *** david-ly_ is now known as david-lyle | 15:24 | |
| *** mbound has quit IRC | 15:24 | |
| *** mbound has joined #openstack-ironic | 15:26 | |
| thiagop | jroll: our other team here at the university is trying to beat down keystone domains | 15:27 |
| jroll | thiagop: \o/ | 15:27 |
| thiagop | jroll: almost there, and should ease things for us | 15:27 |
| thiagop | jroll: they're proposing a thing called "reseller" that makes projects acts like domains just for user management/segregation | 15:28 |
| thiagop | jroll: the entity itself will be just "project" | 15:29 |
| * jroll super confused now | 15:29 | |
| thiagop | jroll: that was tl:dr, you want the long version? | 15:29 |
| jroll | thiagop: is this an alternative to domains? | 15:30 |
| jroll | I thought you initially meant putting keystone domain support in ironic | 15:30 |
| *** amotoki has joined #openstack-ironic | 15:31 | |
| thiagop | jroll: that's keystone stuff. They'll remove the concept (and the entity) domain and stay only with projects | 15:31 |
| jroll | hm | 15:31 |
| jroll | eager to see I guess, but I don't want to get sidetracked right now | 15:31 |
| thiagop | (domainized) projects will be able to handle users and so on | 15:31 |
| thiagop | so your clients can manage users independently | 15:32 |
| thiagop | yeah, it is a different talk. Focus... | 15:32 |
| jroll | :) | 15:33 |
| *** ionutbalutoiu has quit IRC | 15:34 | |
| *** ionutbalutoiu has joined #openstack-ironic | 15:36 | |
| devananda | morning, all | 15:36 |
| thiagop | morning deva | 15:37 |
| thiagop | morning devananda * | 15:37 |
| NobodyCam | mornig devananda | 15:38 |
| vdrok | devananda, morning | 15:38 |
| jroll | ohai devananda | 15:38 |
| dtantsur | morning devananda | 15:39 |
| devananda | dtantsur: jroll: I dunno, I'm happy to say "that use case isn't supported. stop thinking of your servers like pets" | 15:42 |
| jroll | devananda: there's lots of people that use openstack with their pets | 15:43 |
| jroll | it's a valid use case, even if it's a bad thing to do | 15:43 |
| jroll | example: yahoo has many pets. do you want to turn away our potentially largest user? | 15:43 |
| devananda | the instance is the pet - not the hardware hosting it | 15:43 |
| dtantsur | devananda, I don't see anything "pettish" in the use case I mentioned, looks much more of cattle.. | 15:43 |
| jroll | devananda: how do you move that instance to new hardware? | 15:44 |
| dtantsur | i.e. machine misbehaves - figure out and kill it | 15:44 |
| devananda | dtantsur: maybe I misunderstood then. I thought flow was "take active instance, reboot into <ramdisk>, do <thing>, reboot into instance" | 15:44 |
| devananda | which could have multiple use cases | 15:44 |
| dtantsur | devananda, I'm not 100% sure, it wasn't my idea, but as I got it: we routinely check active instances this way to find and kill broken ones | 15:45 |
| devananda | it's the exact same process as rescue | 15:45 |
| dtantsur | yeah, rescue is probably what is needed here | 15:45 |
| devananda | dtantsur: whoa. ok, that's not what I thought you were referring to. since "checking" an active instance in this way interrupts it for some time | 15:45 |
| devananda | like, at lesat 2 POST cycles | 15:45 |
| * jroll points at https://review.openstack.org/#/c/171878/ | 15:46 | |
| devananda | jroll: thanks. reading | 15:46 |
| jroll | devananda: you've presumably seen this since you've updated it | 15:46 |
| *** dims has quit IRC | 15:46 | |
| dtantsur | I know :) maybe people are fine with it. or maybe they meant "when we get complaint from users about instance UUID is too slow" or something... | 15:46 |
| dtantsur | I didn't think much about it | 15:46 |
| openstackgerrit | Ruby Loo proposed openstack/ironic-specs: Manual cleaning https://review.openstack.org/231288 | 15:47 |
| devananda | jroll: right. yep | 15:48 |
| jroll | fwiw, this spec outlines how we already have this working in production | 15:48 |
| jroll | :D | 15:48 |
| devananda | the difference is, IIRC, as proposed there "rescue" is an operation initiated by the user when they require root file system access into an instance of theirs which is no longer accessible | 15:49 |
| devananda | eg, because they borked the network config | 15:49 |
| jroll | it leaves out the networking parts but yeah | 15:49 |
| jroll | right | 15:49 |
| jroll | it doesn't solve every use case in the previous conversation | 15:49 |
| jroll | or maybe none of them | 15:49 |
| devananda | as opposed to the case where an instance is perfectly healthy, but the operator wants to update all the firmware on the host without affecting the instance | 15:50 |
| jroll | I just wanted to point it out because dtantsur said we need rescue mode | 15:50 |
| devananda | well, yea, the networking parts should be updated based on the neutron integration work, I suspect | 15:50 |
| jroll | yeah | 15:50 |
| devananda | but I dont think the flow will change much - -just a couple spots will hook into neutron | 15:50 |
| jroll | easy peasy; put it on the rescue network (which might be the same as the provisioning network) until it pings back, then flip it to tenant network(s) | 15:50 |
| devananda | yup | 15:51 |
| devananda | jroll: so, question, do ya'll as operators ever "rescue" an otherwise healthy instance without the user having requested some intervention? | 15:51 |
| jroll | and the ramdisk will need to update network config from configdrive and/or metadata | 15:51 |
| jroll | devananda: no, we never touch user instances unless they ask us to | 15:51 |
| devananda | thought so | 15:51 |
| jroll | (except to set maintenance mode if they report problems) | 15:51 |
| jroll | oh, for fraud/non-payment of course | 15:52 |
| jroll | and for* | 15:52 |
| devananda | and if you were informed by, say, your hardware supplier, of a problem in the firmware -- how would you go about updating that? my concern is this... | 15:52 |
| jroll | right, we haven't encountered that yet. we've let all of our updates thus far roll through as machines come back | 15:54 |
| devananda | if you-the-operator flip an instance into rescue mode (even during a sanctioned maintenance window) you've got access to their data | 15:54 |
| jroll | no ases where we've NEEDED to update | 15:54 |
| aarefiev | lucasagomes: fyi https://bugs.launchpad.net/python-ironicclient/+bug/1504197 it's bug in requests/urllib3 | 15:54 |
| openstack | Launchpad bug 1504197 in python-ironicclient "keystoneclient.exceptions.RequestTimeout" [Critical,New] - Assigned to Lucas Alvares Gomes (lucasagomes) | 15:54 |
| *** kozhukalov has joined #openstack-ironic | 15:54 | |
| jroll | devananda: no, we don't | 15:54 |
| devananda | oh? | 15:54 |
| lucasagomes | aarefiev, oh | 15:54 |
| jlvillal | Anybody want to abandon this patch? https://review.openstack.org/151864 Person is no longer working on Ironic. | 15:54 |
| lucasagomes | aarefiev, do we have a patch for that? | 15:54 |
| aarefiev | lucasagomes: it would be fixed here https://review.openstack.org/#/c/213310/ | 15:55 |
| lucasagomes | aarefiev, right, in any case it's odd that we depend on keystone failing for out tests | 15:55 |
| lucasagomes | with ConnectionError etc | 15:55 |
| lucasagomes | we could mock that | 15:55 |
| devananda | jlvillal: done | 15:55 |
| jlvillal | devananda, Thank you. | 15:55 |
| jroll | devananda: I guess we could do that in theory with admin powers via nova api, and get access. or manually get an agent running there by playing with switch configs and ipmi. but we don't do either of those afaik... managed support stuff might do the former on behalf of a customer | 15:56 |
| aarefiev | lucasagomes: yep, agree with you, | 15:56 |
| devananda | jroll: cool. | 15:56 |
| lucasagomes | aarefiev, I will mock those erros for our tests | 15:57 |
| jroll | devananda: 'nova rescue' returns a password to access the instance, that's the only way to gain access while rescued | 15:57 |
| *** dims has joined #openstack-ironic | 15:57 | |
| devananda | jroll: right. | 15:57 |
| aarefiev | lucasagomes: cool | 15:57 |
| devananda | jroll: I meant in the hypothetical case where ironic supported some sort of operator-initiated "roll out a new firmware" thing | 15:57 |
| jroll | devananda: yeah, that would be massively painful for us to do, and we could not do it while an instance is active | 15:58 |
| *** subscope has quit IRC | 15:58 | |
| devananda | jroll: *nod* that's what I would expect, thanks | 15:58 |
| jroll | np | 15:58 |
| *** dims_ has joined #openstack-ironic | 15:59 | |
| *** yog_ has quit IRC | 16:02 | |
| *** dims has quit IRC | 16:02 | |
| *** ukalifon1 has quit IRC | 16:03 | |
| *** praneshp has joined #openstack-ironic | 16:04 | |
| *** tsekiyama has joined #openstack-ironic | 16:04 | |
| *** e0ne has quit IRC | 16:05 | |
| praneshp | lucasagomes: ping | 16:07 |
| *** marzif has quit IRC | 16:08 | |
| *** marzif has joined #openstack-ironic | 16:08 | |
| *** ionutbalutoiu has quit IRC | 16:09 | |
| lucasagomes | praneshp, pong | 16:09 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/python-ironicclient: Mock keystone call to avoid test failure https://review.openstack.org/232633 | 16:09 |
| lucasagomes | aarefiev, ^ | 16:09 |
| lucasagomes | jroll, rloo if you guys are around mind taking a look at ^ too? That fixes the python-ironicclient gate | 16:10 |
| jroll | ha | 16:10 |
| * jroll didn't know it was broken | 16:10 | |
| * dtantsur too | 16:10 | |
| rloo | lucasagomes: looking since jroll is laughing | 16:10 |
| * lucasagomes puts back the old exception | 16:10 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/python-ironicclient: Mock keystone call to avoid test failure https://review.openstack.org/232633 | 16:10 |
| *** pas-ha has quit IRC | 16:11 | |
| lucasagomes | jroll, yeah I didn't know until recently too :-) see https://review.openstack.org/#/q/status:open+project:openstack/python-ironicclient,n,z | 16:12 |
| jroll | lucasagomes: nice. +2 | 16:14 |
| praneshp | lucasagomes: I was still hoping to work on https://bugs.launchpad.net/ironic/+bug/1421261/ | 16:15 |
| openstack | Launchpad bug 1421261 in Ironic " node's properties['capabilities'] value should be a dictionary" [Undecided,In progress] - Assigned to Lucas Alvares Gomes (lucasagomes) | 16:15 |
| lucasagomes | praneshp, right, yeah I put a small patch up for that | 16:15 |
| lucasagomes | but see the conversation me and jroll had above | 16:15 |
| rloo | lucasagomes, jroll, praneshp: I thought we had discussed not making that change | 16:15 |
| praneshp | lucasagomes: there is a spec from jroll (and another patch) that I was waiting to see | 16:15 |
| lucasagomes | rloo, yeah, we should mark the bug as invalid then | 16:16 |
| lucasagomes | praneshp, right, I think that we want to split the capabilities into another table so it would be indexable | 16:16 |
| rloo | lucasagomes: well, i didn't want to mark it as invalid until we actually approved the new direction | 16:16 |
| lucasagomes | rloo, fair enuff | 16:16 |
| praneshp | lucasagomes: okay. | 16:17 |
| rloo | lucasagomes: if it causes confusion, we could make it invalid. and change it later if we need to. | 16:17 |
| dtantsur | we can mark it as Opinion | 16:18 |
| lucasagomes | dtantsur, ++ | 16:18 |
| *** ifarkas has quit IRC | 16:18 | |
| praneshp | lucasagomes: let me know if I can help with that patch, thanks for the change :) | 16:19 |
| rloo | lucasagomes: can we WIP or -2 your patch? | 16:19 |
| lucasagomes | praneshp, cool! np | 16:19 |
| lucasagomes | rloo, sure | 16:19 |
| rloo | lucasagomes: you choose :) | 16:20 |
| lucasagomes | I put WIP in the commit message, lemme WIP it for real | 16:20 |
| rloo | thx lucasagomes | 16:20 |
| *** w_ has joined #openstack-ironic | 16:20 | |
| *** olaph has quit IRC | 16:21 | |
| rloo | getting commute out of the way. back later. | 16:22 |
| *** rloo has quit IRC | 16:22 | |
| *** w__ has joined #openstack-ironic | 16:27 | |
| *** harshs has joined #openstack-ironic | 16:31 | |
| *** w_ has quit IRC | 16:31 | |
| *** mbound has quit IRC | 16:37 | |
| *** jistr has quit IRC | 16:38 | |
| jroll | devananda: see my email? you have time to update that patch today? | 16:40 |
| *** ijw has joined #openstack-ironic | 16:43 | |
| *** Marga_ has quit IRC | 16:46 | |
| *** ijw has quit IRC | 16:47 | |
| *** romainh has left #openstack-ironic | 16:48 | |
| jlvillal | devananda: FYI sdague released 0.3.0 of his amt library today. | 16:52 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Enable radosgw support in ironic https://review.openstack.org/229389 | 16:53 |
| *** jcoufal has quit IRC | 16:54 | |
| *** derekh has quit IRC | 16:55 | |
| devananda | jroll: yah. will give it a shot between meetings | 16:55 |
| jroll | thanks | 16:55 |
| devananda | jlvillal: neat! are you updating the review that pulls it in? | 16:56 |
| devananda | we also now have the agent_amt driver that jroll proposed and I fixed yesterday | 16:56 |
| devananda | plus my agent_amttool driver on github | 16:56 |
| jroll | devananda: so yeah, does that one work for you? | 16:56 |
| * jroll assumes not | 16:56 | |
| jlvillal | devananda: I will work some more on my WIP patch. | 16:56 |
| devananda | oh, speaking of which, the maintainer of amtterm package is willing to take my patch. just need to clean it up and send it to him | 16:56 |
| devananda | jroll: yea, it did, after my changes | 16:56 |
| devananda | oddly | 16:57 |
| devananda | but it did | 16:57 |
| jroll | devananda: oh, cool, I thought agents didn't work for you with our in tree driver | 16:57 |
| devananda | they didn't in the past :-/ | 16:57 |
| jroll | huh. | 16:57 |
| jroll | yay! | 16:57 |
| devananda | I do not know why, yesterday, it decided to work | 16:57 |
| devananda | right? :) | 16:57 |
| jroll | I'm going to go with pebkac in the past :) | 16:57 |
| devananda | so we now have 3 amt drivers .... | 16:57 |
| *** degorenko has quit IRC | 16:57 | |
| openstackgerrit | Dan Prince proposed openstack/ironic: Add an iboot reboot_delay setting https://review.openstack.org/232664 | 16:58 |
| NobodyCam | 3 uggh | 16:58 |
| jroll | devananda: drivers as in setup.cfg or as in implementations? | 16:59 |
| jlvillal | jroll: I think implementations, but didn't look at setup.cfg | 17:03 |
| jroll | well | 17:04 |
| jroll | once we land the sdague/amt implementation, we can nuke the other two :) | 17:04 |
| *** trown is now known as trown|lunch | 17:04 | |
| NobodyCam | jroll: ++ | 17:05 |
| dtantsur | did someone think about having a team drinking in Tokyo? I'm especially interested in possible days | 17:07 |
| * jlvillal arrives on Saturday. So Sunday onward would be good for him. | 17:09 | |
| dtantsur | I arrive on Monday morning | 17:10 |
| jlvillal | dtantsur: I wanted that extra day to try to adapt to time change... | 17:10 |
| jroll | dtantsur: ++ I get in the thursday before | 17:10 |
| jroll | dtantsur: and core party is tuesday fwiw | 17:10 |
| dtantsur | yeah; and general party on Wed IIRC | 17:10 |
| *** thiagop is now known as thiagop-afk | 17:11 | |
| jroll | right on | 17:11 |
| *** ndipanov has quit IRC | 17:11 | |
| dtantsur | have to run home now, was delayed by a meeting :) see you tomorrow | 17:11 |
| *** w__ is now known as olaph | 17:11 | |
| *** penick has joined #openstack-ironic | 17:12 | |
| thiagop-afk | night dtantsur | 17:12 |
| jlvillal | dtantsur: paka paka | 17:12 |
| lucasagomes | folks I'm going to call it a day | 17:12 |
| lucasagomes | came to the office and gotta get the train back home yet | 17:12 |
| TheJulia | goodnight lucasagomes | 17:12 |
| lucasagomes | have a great night! | 17:12 |
| jroll | gnight lucasagomes, dtantsur \o | 17:12 |
| lucasagomes | see ya | 17:12 |
| jlvillal | lucasagomes: Adios (yeah it's not Portuguese I know) | 17:12 |
| lucasagomes | jlvillal, hah | 17:12 |
| *** tsekiyama has quit IRC | 17:12 | |
| lucasagomes | jlvillal, you can say "adeus" for us | 17:12 |
| lucasagomes | it's almost the same | 17:13 |
| jlvillal | lucasagomes: I will try to remember :) | 17:13 |
| lucasagomes | cool, see ya! | 17:13 |
| *** dtantsur is now known as dtantsur|afk | 17:14 | |
| *** dims has joined #openstack-ironic | 17:15 | |
| thiagop-afk | night dtantsur|afk | 17:18 |
| *** dims has quit IRC | 17:18 | |
| * krotscheck has successfully published a javascript library to npm. | 17:18 | |
| krotscheck | So. | 17:18 |
| *** dims_ has quit IRC | 17:19 | |
| krotscheck | If I wanted to have a discussion on "Hey, let's figure out a sane naming convention for openstack-published javascript libraries", where would I have that? | 17:19 |
| krotscheck | Probably the list? | 17:19 |
| *** lucasagomes has quit IRC | 17:19 | |
| *** Marga_ has joined #openstack-ironic | 17:20 | |
| *** achanda has joined #openstack-ironic | 17:20 | |
| *** praneshp has quit IRC | 17:21 | |
| TheJulia | krotscheck: yeah, most likely | 17:26 |
| krotscheck | TheJulia: Danke. | 17:27 |
| *** rloo has joined #openstack-ironic | 17:30 | |
| *** baoli has quit IRC | 17:32 | |
| *** shadower has quit IRC | 17:32 | |
| *** lazy_prince has quit IRC | 17:33 | |
| *** baoli has joined #openstack-ironic | 17:34 | |
| *** marzif has quit IRC | 17:35 | |
| *** athomas has quit IRC | 17:37 | |
| *** ijw has joined #openstack-ironic | 17:37 | |
| *** athomas has joined #openstack-ironic | 17:37 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP: AMT stuff https://review.openstack.org/227581 | 17:38 |
| *** e0ne has joined #openstack-ironic | 17:40 | |
| *** ijw has quit IRC | 17:43 | |
| *** athomas has quit IRC | 17:45 | |
| *** trown|lunch is now known as trown | 17:48 | |
| jlvillal | Cool, Ironic has the 2nd highest code-coverage behind python-jenkins :) http://demo.ronaldbradford.com/cover/ | 17:52 |
| sinval | \o/ | 17:52 |
| jlvillal | But it doesn't have a lot of projects there.... | 17:53 |
| *** harshs has quit IRC | 17:55 | |
| *** Sukhdev has joined #openstack-ironic | 17:58 | |
| *** nicodemos_ has joined #openstack-ironic | 18:03 | |
| *** nicodemos_ has quit IRC | 18:04 | |
| lifeless | romcheg: hi | 18:09 |
| *** dims has joined #openstack-ironic | 18:09 | |
| romcheg | lifeless: I need some help with testrepository | 18:10 |
| lifeless | romcheg: shoot, whats up ? | 18:11 |
| *** tsekiyama has joined #openstack-ironic | 18:13 | |
| jlvillal | lifeless: Can I assert something in a fixture addCleanup() function? | 18:14 |
| lifeless | jlvillal: yes | 18:14 |
| jlvillal | Basically I want to make sure that LOG.logger.disabled is still 0 after the tests run. | 18:14 |
| lifeless | jlvillal: an exception raised from a cleanup will fail the test and capture a second exception | 18:14 |
| jlvillal | lifeless: Should the handler be a class method or a stand-alone function or it doesn't matter? What gets passed to addCleanup() | 18:15 |
| lifeless | jlvillal: the signature is (callable, *args, **kwargs) | 18:15 |
| jlvillal | lifeless: Thanks | 18:15 |
| lifeless | jlvillal: so whatever you want | 18:15 |
| lifeless | (x.y, True, keyword=False) | 18:16 |
| lifeless | will run x.y(True, keyword=False) at cleanup time | 18:16 |
| *** ijw has joined #openstack-ironic | 18:16 | |
| jlvillal | lifeless: Can I also put the check into self.cleanUp()? Instead of using addCleanup() | 18:17 |
| * jlvillal thinks yes | 18:17 | |
| lifeless | jlvillal: you can but why | 18:17 |
| lifeless | jlvillal: self.cleanUp has all the machinery for ensuring all the cleanups run | 18:17 |
| lifeless | jlvillal: you're about 99% more likely to make a mistake overriding it | 18:17 |
| lifeless | than using a cleanup | 18:17 |
| jlvillal | Ah, okay. Then better to do addCleanup() | 18:18 |
| jlvillal | lifeless: Thanks | 18:18 |
| *** tsekiyama has quit IRC | 18:18 | |
| romcheg | lifeless: sorry phone's battery got discharged I had to run home from a bar :) | 18:21 |
| romcheg | lifeless: I'm trying to migrate from py.test to testr but I get Bad checksum on py26 and py34 environments | 18:23 |
| romcheg | lifeless: py27 works fine | 18:23 |
| romcheg | lifeless: that's the patch https://review.openstack.org/#/c/227895/ | 18:24 |
| romcheg | lifeless: it seemed to work before I switched to testtools from unittest2 | 18:24 |
| openstackgerrit | Dan Prince proposed openstack/ironic: Add an iboot reboot_delay setting https://review.openstack.org/232664 | 18:26 |
| *** amotoki has quit IRC | 18:26 | |
| lifeless | romcheg: bad checksum - do you use eventlet? | 18:27 |
| *** mrmoje has quit IRC | 18:27 | |
| romcheg | no, it's just a command line tool | 18:27 |
| lifeless | the | cat thing is to fix a bug with evenlet on python 3 | 18:28 |
| lifeless | won't be needed for you | 18:28 |
| *** pelix has quit IRC | 18:28 | |
| romcheg | lifeless: I was trying different options | 18:28 |
| lifeless | don't use setup.py testr, use setup.py test | 18:28 |
| lifeless | pbr glues that into testrepository automatically | 18:29 |
| lifeless | [separately, I've got a discussion going on at the moment about unwinding that so that testrepository is on the outside, but jumping the gun would be disadvantageous for you, so we'll ignore that] | 18:29 |
| *** tsekiyama has joined #openstack-ironic | 18:30 | |
| *** tsekiyama has quit IRC | 18:30 | |
| *** tsekiyama has joined #openstack-ironic | 18:31 | |
| romcheg | changed to setup.py test but that didn't help | 18:32 |
| romcheg | [if it was supposed to help] | 18:32 |
| lifeless | romcheg: sure, I'm just replicating now | 18:32 |
| lifeless | romcheg: it worked fine for me, though the test suite is very noisy on stdout | 18:33 |
| lifeless | romcheg: which I suspect means you're hooking into events/logging/etc - so one possible cause of a checksum error is that you're splitting a packet on stdout | 18:33 |
| romcheg | lifeless: that's another question, both OS_STDERR_CAPTURE and OS_STDOUT_CAPTURE are set in .tests.conf | 18:33 |
| romcheg | .testr.conf | 18:34 |
| romcheg | lifeless: we indeed mock stdout for some of the tests, but that seems to work on py27 | 18:35 |
| lifeless | romcheg: the oslotest base class redirects all of stdout and stderr - its a heavy hammer, but solves a number of issues like this | 18:35 |
| lifeless | (in particular we get output linked back to the causing test) | 18:36 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Detect when log messages are mis-formatted https://review.openstack.org/232257 | 18:36 |
| romcheg | lifeless: so your suggestion is to use oslotest, not testtools directly? | 18:36 |
| lifeless | http://git.openstack.org/cgit/openstack/oslotest/tree/oslotest/base.py#n102 | 18:37 |
| *** penick has quit IRC | 18:37 | |
| lifeless | romcheg: you can just use the fixture you want | 18:37 |
| lifeless | romcheg: no need to change your base classes or anything IMO | 18:37 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Detect when log messages are mis-formatted https://review.openstack.org/232257 | 18:37 |
| romcheg | lifeless: so what is your suggestion to fight this bad checksum? | 18:42 |
| romcheg | and why does it work on py27? | 18:42 |
| *** e0ne has quit IRC | 18:44 | |
| *** romcheg has quit IRC | 18:45 | |
| *** romcheg has joined #openstack-ironic | 18:45 | |
| * jlvillal likes that romcheg does his coding from the bar ;) | 18:45 | |
| lifeless | romcheg: oh, it sounded like it was happening on 2.7 as well | 18:46 |
| romcheg | lifeless: nope, tests pass for py27 both on gates and on my local env | 18:46 |
| lifeless | romcheg: ok let me try with py34 | 18:47 |
| romcheg | lifeless: kk | 18:47 |
| romcheg | jlvillal: bars usually provide infinite amount of fuel for coding :) | 18:47 |
| jlvillal | :D | 18:47 |
| *** e0ne has joined #openstack-ironic | 18:49 | |
| *** jefabo has joined #openstack-ironic | 18:50 | |
| *** jefabo has left #openstack-ironic | 18:50 | |
| *** jefabo has joined #openstack-ironic | 18:51 | |
| lifeless | romcheg: how many tests do you expect to see ? | 18:53 |
| romcheg | lifeless: hmm, good question | 18:54 |
| lifeless | I see 304 | 18:54 |
| lifeless | so I think they're all running | 18:54 |
| lifeless | when I generate a stream by hand and feed it to testr load its ok | 18:55 |
| romcheg | yes, they seem to run | 18:55 |
| romcheg | 304 seems to be the correct number | 18:55 |
| romcheg | something gets bad after they run | 18:55 |
| romcheg | and that something doesn't happen on py27 | 18:56 |
| lifeless | so fuelclient.tests.unit.v2.lib.test_task.TestTaskFacade.test_task_show runs last | 19:00 |
| lifeless | when I run non-parallel | 19:00 |
| lifeless | no error when I run just that test | 19:01 |
| lifeless | time to bisect | 19:01 |
| lifeless | what I've done is | 19:01 |
| lifeless | . .tox/bin/py34/activate | 19:01 |
| lifeless | testr list-tests > l1 | 19:01 |
| lifeless | (gets me a list of tests - there's stdout chatter at the top I prune) | 19:01 |
| lifeless | now I'm taking 1/2 at a time into a new file and doing | 19:02 |
| lifeless | testr run --load-list l2 | 19:02 |
| *** mkovacik has joined #openstack-ironic | 19:02 | |
| lifeless | happens with just the latter half; chop again | 19:02 |
| *** harshs has joined #openstack-ironic | 19:03 | |
| *** sambetts has quit IRC | 19:04 | |
| lifeless | romcheg: fuelclient.tests.unit.v2.cli.test_node.TestNodeCommand.test_node_set_name | 19:04 |
| lifeless | romcheg: that causes the failure when run on its own | 19:04 |
| lifeless | testr run fuelclient.tests.unit.v2.cli.test_node.TestNodeCommand.test_node_set_name | 19:05 |
| *** penick has joined #openstack-ironic | 19:05 | |
| lifeless | or if your tox.ini is wired up - tox -epy34 -- fuelclient.tests.unit.v2.cli.test_node.TestNodeCommand.test_node_set_name | 19:05 |
| romcheg | lifeless: that testuses some unicode values that get to stdout | 19:06 |
| romcheg | lifeless: perhaps that causes issues | 19:06 |
| lifeless | romcheg: if they are valid unicode it shouldn't; but if they are bogus, it could be matching the subunit frame header which is a non-utf8 sequence | 19:07 |
| jlvillal | dprince: And now I realize I did that on the wrong channel :( | 19:07 |
| *** sambetts has joined #openstack-ironic | 19:07 | |
| lifeless | but I don't see it when I run it outside of testr, which is tricky - unwrapping layers is my first debugging tool, and when the layer causes the issue - ugh | 19:07 |
| romcheg | lifeless: if stdout was captured, perhaps that would resolve the issue | 19:08 |
| lifeless | just trying that | 19:08 |
| romcheg | lifeless: there is OS_STDOUT_CAPTURE=1 in .testr.conf, shouldn't that work? | 19:08 |
| dprince | jlvillal: you had the openstack-i right... :) | 19:08 |
| lifeless | romcheg: no, as I linked before you need the code that looks at the variable to be active | 19:09 |
| romcheg | ah, got it | 19:09 |
| lifeless | romcheg: which you can do either by nheriting from oslotest's base class, or using the fixture directly | 19:09 |
| jlvillal | dprince: Yep, that much :) | 19:09 |
| lifeless | romcheg: ah, you're stll on the broken mock | 19:14 |
| lifeless | romcheg: you'll need to fix that too, your tests are currently broken | 19:14 |
| romcheg | really? | 19:14 |
| lifeless | yes, test-requirements has mock < 1.1.0 | 19:14 |
| romcheg | I've used mock from Kilo's global requirements | 19:14 |
| lifeless | and mock < 1.1.0 has silent failure modes | 19:15 |
| romcheg | https://github.com/openstack/requirements/blob/stable/kilo/global-requirements.txt#L246 | 19:15 |
| lifeless | where you can assert anything you want and it won't error | 19:15 |
| lifeless | yes | 19:15 |
| lifeless | I know, kilo is like that because fixing kilo wasn't worth it. Look at liberty. | 19:15 |
| romcheg | basically because we ship this fuel client with Kilo | 19:15 |
| lifeless | or master. | 19:15 |
| lifeless | nevertheless, kilo's mock is broken | 19:15 |
| romcheg | I'll fix this | 19:15 |
| romcheg | but does that cause a problem? | 19:16 |
| romcheg | *the problem | 19:16 |
| lifeless | I'm http://paste.openstack.org/show/475782/ | 19:16 |
| lifeless | it may be something else like a stevedore change | 19:16 |
| lifeless | nope, shouldn't be, we have 1.3 installed | 19:17 |
| romcheg | or pbr | 19:17 |
| lifeless | shouldn't be - but I see you have the < 1.0 clamp there as well - thats incomptible with liberty | 19:18 |
| lifeless | (and this whole thing is why we've stopped using < and <= in global-requirements | 19:18 |
| openstackgerrit | Ruby Loo proposed openstack/ironic-specs: Manual cleaning https://review.openstack.org/231288 | 19:18 |
| *** tsekiyama has quit IRC | 19:18 | |
| *** tsekiyama has joined #openstack-ironic | 19:20 | |
| *** aswadr has quit IRC | 19:22 | |
| romcheg | lifeless: I applied oslotest's base class | 19:24 |
| romcheg | and it seemed to resolve the issue | 19:24 |
| romcheg | so perhaps that is something related to unicode | 19:25 |
| lifeless | romcheg: could be, but its *very* weird that the error is only thrown at the end of the stream | 19:26 |
| romcheg | lifeless: I've got another problem that running py26 after py34 fails with "db type could not be determined" sometimes | 19:27 |
| romcheg | removing .testrepository/ helps | 19:28 |
| lifeless | romcheg: yes, thats because the dbm module in Python 2.6 vs 3.x is mutually incompatible on disk | 19:28 |
| romcheg | lifeless: is that an old problem that can be fixed by updating testr? | 19:28 |
| romcheg | got it | 19:28 |
| lifeless | romcheg: its why I started my thread about not having testr within the venv | 19:28 |
| lifeless | romcheg: because its a metarunner, it can live outside the venv and always run with a consistent python version | 19:28 |
| romcheg | lifeless py26->py34 work | 19:29 |
| lifeless | romcheg: https://review.openstack.org/#/c/218070/ | 19:29 |
| lifeless | romcheg: py27 -> py34 will error | 19:29 |
| *** baoli has quit IRC | 19:29 | |
| lifeless | romcheg: py34 -> py26 will error | 19:29 |
| romcheg | py26->py27->py34 just worked | 19:29 |
| lifeless | romcheg: its maddening as hell when you also have to deal with macosX | 19:29 |
| lifeless | romcheg: yeah | 19:29 |
| romcheg | lifeless: and yes, I'm on mac atm | 19:30 |
| *** romainh has joined #openstack-ironic | 19:31 | |
| *** baoli has joined #openstack-ironic | 19:34 | |
| lifeless | romcheg: ok so that might be why it works. its v confusing | 19:35 |
| *** dprince has quit IRC | 19:38 | |
| *** e0ne has quit IRC | 19:42 | |
| romcheg | lifeless: thanks a lot! | 19:44 |
| *** sambetts has quit IRC | 19:46 | |
| *** tsekiyama has quit IRC | 19:48 | |
| *** tsekiyama has joined #openstack-ironic | 19:49 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Initial support for installation of ironic-inspector https://review.openstack.org/229930 | 19:49 |
| *** baoli has quit IRC | 19:51 | |
| *** baoli has joined #openstack-ironic | 19:52 | |
| *** sambetts has joined #openstack-ironic | 19:52 | |
| *** baoli has quit IRC | 19:53 | |
| *** Nisha has quit IRC | 19:55 | |
| *** dprince has joined #openstack-ironic | 19:57 | |
| lifeless | romcheg: anyhow sorry | 20:06 |
| lifeless | romcheg: family interrupt, back | 20:06 |
| lifeless | romcheg: sounds like you're past the glitch? | 20:07 |
| romcheg | lifeless: looks like that | 20:07 |
| lifeless | I had http://paste.ubuntu.com/12718159/ as my local fiddles, just as a comparison | 20:08 |
| *** tsekiyama has quit IRC | 20:08 | |
| romcheg | at least https://review.openstack.org/#/c/227895 has already got all +1s | 20:08 |
| romcheg | I've done some polishing to it so it's waiting one more time | 20:08 |
| *** tsekiyama has joined #openstack-ironic | 20:09 | |
| romcheg | lifeless: we'll see how it works on fuel client and start moving to testr all fuel-* projects | 20:09 |
| lifeless | ok thats bizarre, I captured the output with | tee output | 20:10 |
| *** tsekiyama has quit IRC | 20:10 | |
| lifeless | and testr showed the parser error | 20:10 |
| lifeless | but other subunit handlers are not | 20:11 |
| lifeless | I'm going to dig into this later, for now filing a bug on testrepository | 20:11 |
| *** tsekiyama has joined #openstack-ironic | 20:11 | |
| *** tsekiyama has quit IRC | 20:12 | |
| *** garthb has joined #openstack-ironic | 20:12 | |
| romcheg | lifeless: I also discovered oslo_debug_helper that allows to avoid all the butt-pain with debugging | 20:13 |
| *** tsekiyama has joined #openstack-ironic | 20:14 | |
| *** Sukhdev has quit IRC | 20:14 | |
| lifeless | romcheg: its a workaround, we haven't yet implemented the cluster-aware stdin/stdout interface | 20:14 |
| lifeless | romcheg: rpdb works fine though, if you can use that | 20:14 |
| *** tsekiyama has quit IRC | 20:15 | |
| romcheg | lifeless: I've explored the internals a little and it looks like you'll have to completely re-write communication | 20:15 |
| lifeless | romcheg: (but its a fine workaround) | 20:15 |
| lifeless | romcheg: hmm, a little, its not so hard - the subunit stream glue for bidirectional routing is already in place | 20:16 |
| romcheg | lifeless: I mean, pipes which are in use, won't allow to deal with pdb | 20:16 |
| lifeless | romcheg: so there's a couple of implementation routes | 20:16 |
| lifeless | romcheg: but yes, some careful glue is needed | 20:16 |
| *** loli has joined #openstack-ironic | 20:16 | |
| lifeless | romcheg: (mainly to deal with the stdout monkeypatching of oslotest in fact - since when thats active stdout isn't useful) | 20:17 |
| *** sdake has quit IRC | 20:17 | |
| *** tsekiyama has joined #openstack-ironic | 20:18 | |
| *** Sukhdev has joined #openstack-ironic | 20:20 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Detect when log messages are mis-formatted https://review.openstack.org/232257 | 20:20 |
| lifeless | jlvillal: is that still needed, the fixtures release found bugs in neutron :) | 20:21 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Detect when log messages are mis-formatted https://review.openstack.org/232257 | 20:22 |
| jlvillal | lifeless: Woot! :) | 20:22 |
| jlvillal | I'm not 100% sure.... | 20:22 |
| jlvillal | lifeless: Was neutron happy with you? ;) | 20:22 |
| lifeless | romcheg: https://bugs.launchpad.net/testrepository/+bug/1504310 | 20:23 |
| openstack | Launchpad bug 1504310 in Testrepository "packet parsing error with fuelclient test suite" [High,Triaged] | 20:23 |
| lifeless | jlvillal: happy is perhaps not the word | 20:23 |
| romcheg | lifeless: thanks! | 20:23 |
| lifeless | jlvillal: https://review.openstack.org/#/c/232265/ | 20:23 |
| *** sdake has joined #openstack-ironic | 20:23 | |
| jlvillal | lifeless: Thanks | 20:24 |
| lifeless | jlvillal: plus https://review.openstack.org/#/c/232519/ | 20:25 |
| jlvillal | lifeless: Probably valid errors, I hope. | 20:26 |
| lifeless | jlvillal: I'm asking at the moment, but I believe so | 20:26 |
| lifeless | jlvillal: e.g. stuff that would error in prod | 20:26 |
| jlvillal | lifeless: Yep | 20:26 |
| *** tsekiyama has quit IRC | 20:28 | |
| *** tsekiyama has joined #openstack-ironic | 20:28 | |
| *** loli has left #openstack-ironic | 20:28 | |
| *** penick has quit IRC | 20:31 | |
| *** dprince has quit IRC | 20:34 | |
| openstackgerrit | Merged openstack/python-ironicclient: Mock keystone call to avoid test failure https://review.openstack.org/232633 | 20:36 |
| *** tsekiyama has quit IRC | 20:36 | |
| *** tsekiyama has joined #openstack-ironic | 20:37 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Initial addition of an inspection module https://review.openstack.org/232745 | 20:37 |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: WIP: Additional inspection role and adding role to NV job script https://review.openstack.org/232746 | 20:37 |
| *** penick has joined #openstack-ironic | 20:38 | |
| *** rvasilets___ has joined #openstack-ironic | 20:42 | |
| jlvillal | rloo, jroll: Talking about developer documentation before. Not sure if you have seen Neutron's http://docs.openstack.org/developer/neutron/devref/index.html | 20:45 |
| rloo | jlvillal: oh. hadn't seen that before. hmm. maybe i'll switch and do dev for neutron | 20:46 |
| jlvillal | LOL :) | 20:46 |
| jlvillal | I was thinking steal it for ideas ;) | 20:46 |
| rloo | jlvillal: not stealing. admiring and mimic'ing. i think jroll said he was going to do it but i'm sure he would like volunteers. (I am not for various reasons) | 20:47 |
| rloo | jlvillal: 'do it' meaning propose something for ironic. | 20:47 |
| jlvillal | rloo: I have seen jroll's initial patch. Looks like a good start and room to grow. | 20:48 |
| rloo | jlvillal: i haven't had a chance to look at it. trying to focus on specs but it is so hard. | 20:49 |
| * jlvillal thinks he should spend more time reviewing specs but gets caught up in the code reviews. | 20:50 | |
| jlvillal | rloo: spec reviewing is difficult... | 20:51 |
| rloo | jlvillal: yup. harder than code reviewing. but code reviewing would be a lot harder w/o specs! | 20:51 |
| jlvillal | True that. | 20:51 |
| *** ig0r_ has joined #openstack-ironic | 20:58 | |
| openstackgerrit | shravya Gaddam proposed openstack/ironic: The Key ucs_hostname has been changed to ucs_address in the documentation for UCS driver. https://review.openstack.org/232752 | 20:59 |
| *** ig0r_ has quit IRC | 21:03 | |
| *** ig0r_ has joined #openstack-ironic | 21:05 | |
| *** trown is now known as trown|outttypeww | 21:05 | |
| *** Sukhdev has quit IRC | 21:09 | |
| *** ig0r_ has quit IRC | 21:10 | |
| jroll | rloo: I would love volunteers :) | 21:12 |
| * jroll takes a peak at neutron docs | 21:13 | |
| jroll | WOW | 21:13 |
| jroll | I want that. | 21:13 |
| *** tsekiyama has quit IRC | 21:14 | |
| rloo | jroll: copy/paste! | 21:14 |
| jroll | lol | 21:14 |
| rloo | jroll: if you don't have a volunteer by summit time, I'll ask/find someone to volunteer to do this | 21:15 |
| *** tsekiyama has joined #openstack-ironic | 21:15 | |
| jroll | rloo: yeah, I mean, I plan to do it incrementally | 21:16 |
| jroll | when someone asks a question, respond with a docs patch :) | 21:16 |
| rloo | jroll: forget about summit time. I'll just send email and see if someone volunteers. | 21:16 |
| jroll | heh | 21:16 |
| jroll | rloo: I want everyone to contribute, really | 21:16 |
| rloo | jroll: you're busy/going to be busy with other things. we should be able to get someone to volunteer/copy/paste from neutron/nova or wherever. | 21:16 |
| jroll | rloo: if someone is going to work full time on a thing, we have more important things | 21:16 |
| rloo | jroll: what we need is a table of contents or something, a framework, so people know where to add stuff. | 21:17 |
| rloo | jroll: writing doc is not that easy. | 21:17 |
| jroll | rloo: yeah | 21:17 |
| rloo | jroll: and organizing it | 21:17 |
| jlvillal | jroll: I was also impressed with that Neutron doc | 21:18 |
| jroll | rloo: we don't have enough people working on other important things as it is though :( | 21:18 |
| rloo | jlvillal, jroll: i also wonder how much of that neutron stuff could just be pushed higher up to the openstack dev documentation | 21:18 |
| rloo | jroll: i wonder if there are folks lurking out there that want to contribute. | 21:18 |
| jroll | rloo: yeah, that's another question. need to read it. | 21:18 |
| jlvillal | Hmmm. Interesting. | 21:18 |
| jroll | indeed :) | 21:18 |
| rloo | jroll: i just skimmed liberty etherpad from the fri contributor. one of the comments was 'what can i do to help out' or something like that. | 21:19 |
| jroll | that's good | 21:19 |
| rloo | jroll: if i remember, i will send out email on monday. i don't want to send today cuz i won't respond to anything til next week anyway. | 21:20 |
| jroll | rloo: sounds good, though remember others can reply :) | 21:20 |
| rloo | jroll: yeah, but also don't feel like writing email now :) | 21:21 |
| rloo | jroll: oh, and i forgot. i'm not back til tues. so i'll wait til then. | 21:22 |
| jroll | fair enough :) | 21:22 |
| jroll | that reminds me. I have an email to write. hopefully before you leave so you can respond. | 21:22 |
| rloo | jroll: ha ha. about 40 more minutes. although i may look again later tonight. | 21:24 |
| jroll | rloo: it's a softball, I promise | 21:25 |
| * jroll sends very shortly | 21:25 | |
| *** nicodemos has quit IRC | 21:27 | |
| *** sdake has quit IRC | 21:28 | |
| openstackgerrit | Merged openstack/ironic-lib: Updated from global requirements https://review.openstack.org/231229 | 21:33 |
| *** harshs has quit IRC | 21:38 | |
| rloo | NobodyCam: any reason why you didn't +A https://review.openstack.org/#/c/228195/ | 21:41 |
| *** jvmario has quit IRC | 21:45 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: WIP: Additional inspection role and adding role to NV job script https://review.openstack.org/232746 | 21:46 |
| *** mariojv has joined #openstack-ironic | 21:46 | |
| jlvillal | rloo: NobodyCam was first +2. cinerama was 2nd. | 21:47 |
| rloo | jlvillal: oh, i must be tired. I'll leave it for them to deal with :) | 21:48 |
| jlvillal | :) | 21:48 |
| *** Sukhdev has joined #openstack-ironic | 21:48 | |
| TheJulia | rloo: nobodycam likes to wait 24 hours or so after +2ing to +a | 21:49 |
| TheJulia | oh, and yes | 21:49 |
| TheJulia | order | 21:49 |
| jlvillal | JoshNang: Still reviewing :) | 21:49 |
| rloo | TheJulia: oh, that makes sense :D | 21:49 |
| rloo | TheJulia: I'd do it but i have no idea why the order matters! | 21:50 |
| TheJulia | rloo: lol | 21:50 |
| *** mariojv has quit IRC | 21:51 | |
| *** mariojv has joined #openstack-ironic | 21:52 | |
| JoshNang | jlvillal: :D had a free second and wanted to see what manual cleaning evolved into | 21:52 |
| *** romainh has left #openstack-ironic | 21:53 | |
| *** linggao has quit IRC | 21:53 | |
| *** thrash is now known as thrash|g0ne | 21:55 | |
| JayF | JoshNang: !! | 21:55 |
| JoshNang | \o/ | 21:55 |
| JayF | JoshNang: you finally realized your mistake and are coming back? GREAT! | 21:55 |
| JayF | :P | 21:55 |
| jroll | hahaha | 21:56 |
| JoshNang | :P | 21:56 |
| jroll | JayF: "free second" when working for a startup does tend to mean you quit... | 21:57 |
| JoshNang | though writing all this node.js makes me miss python.. | 21:57 |
| jroll | oh my, I'm sorry | 21:57 |
| *** mariojv has quit IRC | 21:58 | |
| *** mariojv has joined #openstack-ironic | 21:58 | |
| *** mariojv has quit IRC | 22:00 | |
| jlvillal | JoshNang: node.js? Well luckily you already know Javascript :) | 22:02 |
| rloo | JoshNang: surprise! manual cleaning is all yours if you want it! | 22:02 |
| *** mariojv has joined #openstack-ironic | 22:02 | |
| rloo | jlvillal: did you read email from dev list recently? | 22:04 |
| jlvillal | rloo: I did. I am honored to be nominated :) | 22:04 |
| rloo | gotta go. back later maybe! | 22:04 |
| rloo | jlvillal: :) | 22:04 |
| thiagop-afk | Congrats jlvillal! | 22:06 |
| thiagop-afk | vdrok you too! | 22:06 |
| *** thiagop-afk is now known as thiagop | 22:06 | |
| jlvillal | thiagop-afk: Thank you :) | 22:06 |
| *** harshs has joined #openstack-ironic | 22:07 | |
| JoshNang | jlvillal: yeah, which is handy. but node is it's own beast compared to frontend JS | 22:08 |
| JoshNang | rloo: nahhh i wouldn't want to deprive you of all the fun! | 22:09 |
| *** tsekiyam_ has joined #openstack-ironic | 22:13 | |
| *** tsekiyama has quit IRC | 22:14 | |
| krtaylor | jlvillal, well deserved, I was actually surprised that you were not core already | 22:20 |
| JoshNang | jlvillal: oh! congrats! vdrok too! | 22:21 |
| jlvillal | krtaylor: Thank you, but I'm not sure about that ;) We have some really good cores on Ironic. If I get to be one also, it will be an honor. | 22:21 |
| jlvillal | JoshNang: Thanks! | 22:22 |
| jlvillal | krtaylor: I meant, not sure you should think I was a core already, that is :) | 22:22 |
| jroll | I like how rloo commented on the email but didn't reply :P | 22:22 |
| jlvillal | :) | 22:22 |
| * jlvillal continues to read Nova functional testing code.... | 22:23 | |
| * TheJulia determines it is time to call it a night | 22:25 | |
| jlvillal | TheJulia: Good night! | 22:26 |
| thiagop | good night TheJulia | 22:32 |
| rloo | jroll, jlvillal: I'm back for a few minutes. Need to think about my reply. I mean, I have to be honest right? | 22:35 |
| jlvillal | rloo: Absolutely! | 22:36 |
| rloo | jlvillal: well, the truth is, I don't send many emails using that account/interface and it takes me a few secs/mins to remember how to reply etc. | 22:40 |
| jlvillal | :) I have emails going two different places. One I read the email on for the most part. And then my work, where I usually reply or send from. | 22:41 |
| jlvillal | Thanks rloo :) | 22:42 |
| rloo | jlvillal: thank YOU! :D | 22:42 |
| openstackgerrit | Merged openstack/bifrost: Install ironicclient after installing the shade library https://review.openstack.org/228195 | 22:44 |
| rloo | btw, jlvillal, dtantsur|afk: did you know about gerrit-dash-creator? https://github.com/stackforge/gerrit-dash-creator | 22:45 |
| rloo | dtantsur|afk: ok, i'm guessing you know cuz i see ironic-inspector & ironic there :) | 22:46 |
| jlvillal | rloo: I do. And I think dtantsur|afk does. I had submitted a patch awhile ago to make it more automatic | 22:46 |
| rloo | jlvillal: oh, you know about it too. good. | 22:46 |
| jlvillal | But then they wanted changes and it got put at the bottom of my list. | 22:46 |
| jlvillal | rloo: I think mrda did an update to it recently | 22:47 |
| jlvillal | To add all the new projects | 22:47 |
| rloo | jlvillal: yeah, looks like 16 days ago. | 22:47 |
| rloo | jlvillal: i should have looked first before mentioning it! | 22:47 |
| jlvillal | rloo: :) | 22:48 |
| *** rvasilets___ has quit IRC | 22:51 | |
| *** praneshp has joined #openstack-ironic | 23:08 | |
| *** rloo has quit IRC | 23:13 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 23:17 |
| *** dims has quit IRC | 23:23 | |
| thiagop | Folks, I'm going home finally | 23:26 |
| thiagop | have a great night everyone | 23:26 |
| *** harshs has quit IRC | 23:26 | |
| *** thiagop has quit IRC | 23:26 | |
| *** harshs has joined #openstack-ironic | 23:27 | |
| *** garthb has quit IRC | 23:29 | |
| *** mbound has joined #openstack-ironic | 23:34 | |
| *** tsekiyam_ has quit IRC | 23:35 | |
| *** mtanino has quit IRC | 23:37 | |
| *** dims has joined #openstack-ironic | 23:40 | |
| *** harshs has quit IRC | 23:44 | |
| *** smoriya has joined #openstack-ironic | 23:51 | |
| *** harlowja has quit IRC | 23:52 | |
| *** harlowja has joined #openstack-ironic | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!