| *** dims_ has quit IRC | 00:17 | |
| *** alexpilotti has joined #openstack-ironic | 00:17 | |
| *** shadower has quit IRC | 00:23 | |
| *** shadower has joined #openstack-ironic | 00:23 | |
| *** alexpilotti has quit IRC | 00:23 | |
| *** naohirot has joined #openstack-ironic | 00:37 | |
| *** alexpilotti has joined #openstack-ironic | 00:39 | |
| *** alexpilotti has quit IRC | 00:44 | |
| *** alexpilotti has joined #openstack-ironic | 00:59 | |
| *** alexpilotti has quit IRC | 01:04 | |
| *** sinh has joined #openstack-ironic | 01:05 | |
| sinh | so a quick question. . i get the gist of how ironic deploys but is it possible to ironic into an existing provisioning system like FAI? | 01:05 |
|---|---|---|
| sinh | or customize the pxe file if there is one? | 01:05 |
| *** baoli has joined #openstack-ironic | 01:08 | |
| *** david-lyle has quit IRC | 01:13 | |
| *** alexpilotti has joined #openstack-ironic | 01:18 | |
| *** alexpilotti has quit IRC | 01:25 | |
| *** baoli has quit IRC | 01:32 | |
| *** baoli has joined #openstack-ironic | 01:34 | |
| *** baoli has quit IRC | 01:35 | |
| *** baoli has joined #openstack-ironic | 01:37 | |
| *** alexpilotti has joined #openstack-ironic | 01:40 | |
| *** Marga_ has joined #openstack-ironic | 01:42 | |
| *** david-lyle has joined #openstack-ironic | 01:44 | |
| *** alexpilotti has quit IRC | 01:45 | |
| *** alexpilotti has joined #openstack-ironic | 02:00 | |
| *** praneshp_ has joined #openstack-ironic | 02:03 | |
| *** alexpilotti has quit IRC | 02:05 | |
| *** praneshp has quit IRC | 02:05 | |
| *** praneshp_ is now known as praneshp | 02:05 | |
| *** achanda has joined #openstack-ironic | 02:20 | |
| *** alexpilotti has joined #openstack-ironic | 02:20 | |
| *** dimsum__ has joined #openstack-ironic | 02:21 | |
| *** alexpilotti has quit IRC | 02:25 | |
| *** mestery has quit IRC | 02:37 | |
| *** mestery has joined #openstack-ironic | 02:38 | |
| *** dimsum__ has quit IRC | 02:40 | |
| *** alexpilotti has joined #openstack-ironic | 02:40 | |
| *** amotoki has joined #openstack-ironic | 02:41 | |
| *** alexpilotti has quit IRC | 02:45 | |
| *** amotoki has quit IRC | 02:50 | |
| *** amotoki has joined #openstack-ironic | 02:55 | |
| *** alexpilotti has joined #openstack-ironic | 03:01 | |
| *** alexpilotti has quit IRC | 03:05 | |
| *** yuanying has quit IRC | 03:13 | |
| *** amotoki has quit IRC | 03:17 | |
| *** alexpilotti has joined #openstack-ironic | 03:21 | |
| *** achanda has quit IRC | 03:22 | |
| *** alexpilotti has quit IRC | 03:26 | |
| *** amotoki has joined #openstack-ironic | 03:29 | |
| *** davideagnello has quit IRC | 03:32 | |
| *** david-lyle has quit IRC | 03:32 | |
| *** smoriya has joined #openstack-ironic | 03:35 | |
| *** baoli has quit IRC | 03:37 | |
| *** alexpilotti has joined #openstack-ironic | 03:41 | |
| *** david-lyle has joined #openstack-ironic | 03:44 | |
| *** alexpilotti has quit IRC | 03:45 | |
| *** Marga_ has quit IRC | 03:46 | |
| *** Marga_ has joined #openstack-ironic | 03:47 | |
| *** david-lyle has quit IRC | 03:48 | |
| *** david-lyle has joined #openstack-ironic | 03:53 | |
| *** saripurigopi has joined #openstack-ironic | 03:54 | |
| *** Nisha_away has joined #openstack-ironic | 03:58 | |
| *** rameshg87 has joined #openstack-ironic | 03:59 | |
| *** alexpilotti has joined #openstack-ironic | 04:01 | |
| *** david-lyle has quit IRC | 04:02 | |
| *** alexpilotti has quit IRC | 04:06 | |
| *** david-lyle has joined #openstack-ironic | 04:06 | |
| *** achanda has joined #openstack-ironic | 04:09 | |
| *** saripurigopi has quit IRC | 04:10 | |
| *** david-lyle has quit IRC | 04:12 | |
| *** dimsum__ has joined #openstack-ironic | 04:21 | |
| *** alexpilotti has joined #openstack-ironic | 04:21 | |
| *** david-lyle has joined #openstack-ironic | 04:22 | |
| *** alexpilotti has quit IRC | 04:26 | |
| *** amit213 has quit IRC | 04:28 | |
| *** amit213 has joined #openstack-ironic | 04:28 | |
| *** david-lyle has quit IRC | 04:29 | |
| *** alexpilotti has joined #openstack-ironic | 04:32 | |
| *** alexpilotti has quit IRC | 04:36 | |
| *** baoli has joined #openstack-ironic | 04:38 | |
| *** baoli has quit IRC | 04:43 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy https://review.openstack.org/228020 | 04:47 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy https://review.openstack.org/228020 | 04:49 |
| *** alexpilotti has joined #openstack-ironic | 04:52 | |
| *** Nisha_away is now known as Nisha | 04:55 | |
| *** alexpilotti has quit IRC | 04:56 | |
| *** pradipta has joined #openstack-ironic | 05:09 | |
| *** alexpilotti has joined #openstack-ironic | 05:12 | |
| *** UForgotten has quit IRC | 05:14 | |
| *** UForgotten has joined #openstack-ironic | 05:15 | |
| *** alexpilotti has quit IRC | 05:16 | |
| *** alexpilotti has joined #openstack-ironic | 05:31 | |
| *** alexpilotti has quit IRC | 05:37 | |
| *** sdake has joined #openstack-ironic | 06:06 | |
| *** sdake has quit IRC | 06:10 | |
| *** sdake has joined #openstack-ironic | 06:11 | |
| *** lsmola has joined #openstack-ironic | 06:13 | |
| *** penick has quit IRC | 06:16 | |
| *** ishant has joined #openstack-ironic | 06:19 | |
| *** alexpilotti has joined #openstack-ironic | 06:22 | |
| *** alexpilotti has quit IRC | 06:26 | |
| *** sdake has quit IRC | 06:27 | |
| *** aarefiev_ has quit IRC | 06:28 | |
| *** aarefiev has joined #openstack-ironic | 06:30 | |
| *** sdake has joined #openstack-ironic | 06:31 | |
| *** links has joined #openstack-ironic | 06:35 | |
| *** alexpilotti has joined #openstack-ironic | 06:42 | |
| *** jcoufal has joined #openstack-ironic | 06:46 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Config drive support for whole disk images for iscsi based deploy https://review.openstack.org/225115 | 06:46 |
| *** alexpilotti has quit IRC | 06:47 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Do not use matchers for trivial assertions https://review.openstack.org/224560 | 06:48 |
| *** yog_ has joined #openstack-ironic | 06:50 | |
| *** alexpilotti has joined #openstack-ironic | 07:02 | |
| *** achanda has quit IRC | 07:03 | |
| *** amotoki_ has joined #openstack-ironic | 07:05 | |
| *** romainh has joined #openstack-ironic | 07:06 | |
| *** alexpilotti has quit IRC | 07:07 | |
| *** amotoki_ has quit IRC | 07:09 | |
| *** ifarkas has joined #openstack-ironic | 07:19 | |
| *** alexpilotti has joined #openstack-ironic | 07:22 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy https://review.openstack.org/228020 | 07:26 |
| *** alexpilotti has quit IRC | 07:27 | |
| lifeless | jlvillal: I've responded on https://review.openstack.org/#/c/224560/ | 07:33 |
| lifeless | jlvillal: please do ping me directly - I get a tonne of gerrit mail, so may not see things like that merely by being copied on them as a reviewer | 07:34 |
| betherly | Morning all! | 07:36 |
| *** praneshp has quit IRC | 07:37 | |
| Nisha | betherly, morning | 07:38 |
| *** Guest38007 is now known as d0ugal | 07:41 | |
| *** d0ugal has quit IRC | 07:41 | |
| *** d0ugal has joined #openstack-ironic | 07:41 | |
| *** alexpilotti has joined #openstack-ironic | 07:43 | |
| *** lazy_prince has joined #openstack-ironic | 07:43 | |
| *** praneshp has joined #openstack-ironic | 07:46 | |
| betherly | Hi Nisha :) | 07:47 |
| *** alexpilotti has quit IRC | 07:48 | |
| *** dtantsur|afk is now known as dtantsur | 07:49 | |
| dtantsur | Morning Ironic, morning betherly | 07:49 |
| betherly | Hi dtantsur | 07:54 |
| *** MattMan has joined #openstack-ironic | 07:56 | |
| *** alexpilotti has joined #openstack-ironic | 08:03 | |
| *** arif-ali has quit IRC | 08:05 | |
| *** alexpilotti has quit IRC | 08:07 | |
| *** lucasagomes has joined #openstack-ironic | 08:08 | |
| *** arif-ali has joined #openstack-ironic | 08:09 | |
| *** e0ne has joined #openstack-ironic | 08:10 | |
| *** arif-ali has quit IRC | 08:16 | |
| *** athomas has joined #openstack-ironic | 08:17 | |
| *** arif-ali has joined #openstack-ironic | 08:19 | |
| Nisha | Hi betherly | 08:20 |
| lucasagomes | morning Ironic | 08:22 |
| *** masterbound has joined #openstack-ironic | 08:23 | |
| *** alexpilotti has joined #openstack-ironic | 08:23 | |
| betherly | hi lucasagomes | 08:23 |
| *** praneshp has quit IRC | 08:25 | |
| lucasagomes | hello :-) | 08:25 |
| *** jcoufal_ has joined #openstack-ironic | 08:25 | |
| *** Nisha has quit IRC | 08:27 | |
| *** alexpilotti has quit IRC | 08:27 | |
| *** david-lyle has joined #openstack-ironic | 08:28 | |
| *** jcoufal has quit IRC | 08:28 | |
| *** mgoddard has joined #openstack-ironic | 08:34 | |
| *** arif-ali has quit IRC | 08:34 | |
| dtantsur | morning lucasagomes :) | 08:36 |
| lucasagomes | dtantsur, morning! | 08:36 |
| lucasagomes | loads of emails to catch up | 08:36 |
| dtantsur | I can imagine | 08:36 |
| dtantsur | and damn, people write such long essays for their TC election, I spent the whole morning reading them >_< | 08:37 |
| *** jistr has joined #openstack-ironic | 08:38 | |
| *** arif-ali has joined #openstack-ironic | 08:39 | |
| *** alexpilotti has joined #openstack-ironic | 08:43 | |
| *** arif-ali has quit IRC | 08:47 | |
| *** alexpilotti has quit IRC | 08:48 | |
| *** david-lyle has quit IRC | 08:51 | |
| *** arif-ali has joined #openstack-ironic | 08:51 | |
| openstackgerrit | Merged openstack/ironic: Move unit tests to correct directory https://review.openstack.org/229196 | 08:56 |
| *** enikanorov has quit IRC | 08:59 | |
| *** jistr has quit IRC | 09:00 | |
| *** david-lyle has joined #openstack-ironic | 09:00 | |
| *** jistr has joined #openstack-ironic | 09:01 | |
| *** alexpilotti has joined #openstack-ironic | 09:03 | |
| *** pelix has joined #openstack-ironic | 09:07 | |
| *** david-lyle has quit IRC | 09:07 | |
| *** alexpilotti has quit IRC | 09:08 | |
| *** pelix has quit IRC | 09:14 | |
| *** alexpilotti has joined #openstack-ironic | 09:14 | |
| *** pelix has joined #openstack-ironic | 09:16 | |
| *** marzif has joined #openstack-ironic | 09:18 | |
| *** alexpilotti has quit IRC | 09:19 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Enforce all flake8 rules except E129 https://review.openstack.org/230557 | 09:20 |
| *** david-lyle has joined #openstack-ironic | 09:23 | |
| *** vdrok has quit IRC | 09:25 | |
| *** david-lyle has quit IRC | 09:27 | |
| *** vdrok has joined #openstack-ironic | 09:28 | |
| *** david-lyle has joined #openstack-ironic | 09:30 | |
| *** priteau has joined #openstack-ironic | 09:31 | |
| *** dtantsur is now known as dtantsur|brb | 09:32 | |
| *** alexpilotti has joined #openstack-ironic | 09:34 | |
| *** marzif has quit IRC | 09:37 | |
| *** athomas has quit IRC | 09:37 | |
| *** alexpilotti has quit IRC | 09:39 | |
| sambetts | Morning lucasagomes dtantsur betherly Nisha and anyone else I've missed | 09:41 |
| sambetts | lucasagomes: How was your vacation? | 09:41 |
| *** athomas has joined #openstack-ironic | 09:42 | |
| lucasagomes | sambetts, hey man. It was pretty awesome | 09:44 |
| lucasagomes | some parts of iceland makes you feel like you're in another planet | 09:45 |
| lucasagomes | it's insane | 09:45 |
| *** mbound has joined #openstack-ironic | 09:46 | |
| *** masterbound has quit IRC | 09:46 | |
| lifeless | lucasagomes: iceland? awesome | 09:51 |
| *** david-lyle has quit IRC | 09:54 | |
| *** alexpilotti has joined #openstack-ironic | 09:54 | |
| lucasagomes | lifeless, yea, just came back from there | 09:54 |
| *** degorenko has joined #openstack-ironic | 09:54 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic-lib: Config drive support for whole disk images for iscsi based deploy https://review.openstack.org/230924 | 09:54 |
| lucasagomes | lifeless, it's great, I also want to go back there on summer time when not so many roads are closed | 09:55 |
| openstackgerrit | Shinn'ya Hoshino proposed openstack/ironic: Fix a bug error by passwords includes just numbers https://review.openstack.org/220385 | 09:56 |
| sambetts | lucasagomes: Oh man I'm so jelly, I really want to go now | 09:57 |
| *** alexpilotti has quit IRC | 09:59 | |
| lucasagomes | sambetts, ++ do it! I'm going to upload some photos later on so I can send you the link | 09:59 |
| sambetts | :D awesome! I wonder what motorcycle rental is like out there, I'd love to do that route on a bike | 10:00 |
| *** david-lyle has joined #openstack-ironic | 10:01 | |
| *** e0ne has quit IRC | 10:10 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Config drive support for whole disk images for iscsi based deploy https://review.openstack.org/225115 | 10:11 |
| *** alexpilotti has joined #openstack-ironic | 10:13 | |
| *** e0ne has joined #openstack-ironic | 10:14 | |
| *** romcheg has joined #openstack-ironic | 10:15 | |
| *** david-lyle has quit IRC | 10:16 | |
| openstackgerrit | Merged openstack/ironic: Add agent inspection support for IPMI and SSH drivers https://review.openstack.org/229862 | 10:16 |
| lucasagomes | sambetts, the route 1? I think it's possible but you def should go on summer | 10:18 |
| sambetts | lucasagomes: Yeah :D maybe next summer! | 10:18 |
| *** david-lyle has joined #openstack-ironic | 10:19 | |
| *** alexpilotti has quit IRC | 10:20 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor iLO drivers to use new boot interface https://review.openstack.org/229274 | 10:21 |
| *** saripurigopi has joined #openstack-ironic | 10:22 | |
| *** marzif has joined #openstack-ironic | 10:28 | |
| *** david-lyle has quit IRC | 10:29 | |
| *** david-lyle has joined #openstack-ironic | 10:32 | |
| *** alexpilotti has joined #openstack-ironic | 10:35 | |
| *** romcheg has quit IRC | 10:37 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor iscsi_ilo driver to use new boot interface https://review.openstack.org/216538 | 10:37 |
| *** alexpilotti has quit IRC | 10:40 | |
| *** david-lyle has quit IRC | 10:42 | |
| *** dtantsur|brb is now known as dtantsur | 10:46 | |
| dtantsur | morning sambetts | 10:46 |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-specs: Add service managment API https://review.openstack.org/230939 | 10:47 |
| sambetts | o/ dtantsur | 10:47 |
| *** david-lyle has joined #openstack-ironic | 10:49 | |
| *** naohirot has quit IRC | 10:51 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor iLO driver console interface into new module https://review.openstack.org/229284 | 10:53 |
| *** david-lyle has quit IRC | 10:53 | |
| *** baoli has joined #openstack-ironic | 10:54 | |
| *** alexpilotti has joined #openstack-ironic | 10:55 | |
| *** david-lyle has joined #openstack-ironic | 10:56 | |
| *** smoriya has quit IRC | 10:57 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-specs: Add service managment API https://review.openstack.org/230939 | 10:57 |
| *** baoli has quit IRC | 10:58 | |
| *** alexpilotti has quit IRC | 10:59 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor agent_ilo driver to use new boot interface https://review.openstack.org/217102 | 11:04 |
| *** marzif has quit IRC | 11:05 | |
| *** marzif has joined #openstack-ironic | 11:05 | |
| *** david-lyle has quit IRC | 11:07 | |
| *** david-lyle has joined #openstack-ironic | 11:08 | |
| *** jcoufal_ is now known as jcoufal | 11:09 | |
| *** marzif has quit IRC | 11:10 | |
| *** marzif has joined #openstack-ironic | 11:11 | |
| *** alexpilotti has joined #openstack-ironic | 11:14 | |
| *** david-lyle has quit IRC | 11:18 | |
| *** alexpilotti has quit IRC | 11:18 | |
| *** david-lyle has joined #openstack-ironic | 11:25 | |
| * rameshg87 goes home | 11:32 | |
| *** rameshg87 has quit IRC | 11:33 | |
| TheJulia | Good morning | 11:33 |
| *** lucasagomes is now known as lucas-hungry | 11:33 | |
| lucas-hungry | TheJulia, good morning | 11:33 |
| * lucas-hungry goes grab some food | 11:33 | |
| *** alexpilotti has joined #openstack-ironic | 11:34 | |
| *** alexpilotti has quit IRC | 11:39 | |
| *** amotoki_ has joined #openstack-ironic | 11:43 | |
| *** alexpilotti has joined #openstack-ironic | 11:54 | |
| *** alexpilotti has quit IRC | 11:59 | |
| *** nicodemos has joined #openstack-ironic | 12:00 | |
| *** trown|outttypeww is now known as trown | 12:00 | |
| *** e0ne has quit IRC | 12:01 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add retries to ssh._get_hosts_name_for_node https://review.openstack.org/224828 | 12:01 |
| *** amotoki_ has quit IRC | 12:03 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Driver composition reform https://review.openstack.org/188370 | 12:04 |
| *** athomas has quit IRC | 12:11 | |
| *** marzif has quit IRC | 12:12 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Correct typo in install role README https://review.openstack.org/230742 | 12:12 |
| *** marzif has joined #openstack-ironic | 12:12 | |
| *** e0ne has joined #openstack-ironic | 12:13 | |
| *** amotoki_ has joined #openstack-ironic | 12:13 | |
| *** alexpilotti has joined #openstack-ironic | 12:13 | |
| *** athomas has joined #openstack-ironic | 12:16 | |
| *** alexpilotti has quit IRC | 12:19 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Support setting vlan in config drive https://review.openstack.org/216431 | 12:20 |
| *** marzif has quit IRC | 12:21 | |
| *** thrash|g0ne is now known as thrash | 12:24 | |
| *** ishant has quit IRC | 12:29 | |
| *** saripurigopi has quit IRC | 12:31 | |
| *** romcheg has joined #openstack-ironic | 12:35 | |
| *** alexpilotti has joined #openstack-ironic | 12:35 | |
| *** lucas-hungry is now known as lucasagomes | 12:37 | |
| *** alexpilotti has quit IRC | 12:39 | |
| *** jcoufal_ has joined #openstack-ironic | 12:40 | |
| *** amotoki__ has joined #openstack-ironic | 12:42 | |
| *** Marga_ has quit IRC | 12:42 | |
| *** jcoufal has quit IRC | 12:43 | |
| *** amotok___ has joined #openstack-ironic | 12:45 | |
| *** amotok___ is now known as amotok_ | 12:45 | |
| *** amotoki_ has quit IRC | 12:46 | |
| *** amotok_ is now known as amotoki_ | 12:46 | |
| *** amotoki__ has quit IRC | 12:48 | |
| *** amotoki_ has quit IRC | 12:49 | |
| *** Marga_ has joined #openstack-ironic | 12:54 | |
| *** baoli has joined #openstack-ironic | 12:54 | |
| *** alexpilotti has joined #openstack-ironic | 12:55 | |
| *** Marga_ has quit IRC | 12:57 | |
| *** Marga_ has joined #openstack-ironic | 12:57 | |
| *** alexpilotti has quit IRC | 13:00 | |
| *** [1]cdearborn has joined #openstack-ironic | 13:02 | |
| *** rloo has joined #openstack-ironic | 13:07 | |
| *** dimsum__ is now known as dims | 13:08 | |
| *** amotoki_ has joined #openstack-ironic | 13:13 | |
| *** alexpilotti has joined #openstack-ironic | 13:16 | |
| jlvillal | Good morning Ironic | 13:18 |
| dtantsur | morning jlvillal | 13:19 |
| sambetts | o/ jlvillal | 13:19 |
| jlvillal | Hi :) | 13:19 |
| *** willsama has joined #openstack-ironic | 13:19 | |
| openstackgerrit | Sinval Vieira Mendes Neto proposed openstack/python-oneviewclient: Refactoring python-oneviewclient to use domain models of OneView as objects https://review.openstack.org/230988 | 13:20 |
| *** alexpilotti has quit IRC | 13:20 | |
| *** romcheg has quit IRC | 13:22 | |
| lucasagomes | jlvillal, hi there! morning | 13:22 |
| *** links has quit IRC | 13:22 | |
| openstackgerrit | Sinval Vieira Mendes Neto proposed openstack/python-oneviewclient: Refactoring python-oneviewclient to use domain models of OneView as objects https://review.openstack.org/230988 | 13:22 |
| openstackgerrit | Sinval Vieira Mendes Neto proposed openstack/python-oneviewclient: Refactoring to use domain models of OneView as objects https://review.openstack.org/230988 | 13:23 |
| *** gabriel has quit IRC | 13:24 | |
| *** chlong has joined #openstack-ironic | 13:26 | |
| *** 7GHABCFAO has joined #openstack-ironic | 13:27 | |
| *** 6A4AANKQ6 has joined #openstack-ironic | 13:27 | |
| * TheJulia raises an eyebrow | 13:28 | |
| sambetts | Hello TheJulia's eyebrow o/ | 13:28 |
| TheJulia | good morning sambetts | 13:29 |
| *** jasondotstar|afk is now known as jasondotstar | 13:32 | |
| *** amotoki has quit IRC | 13:32 | |
| *** superdan is now known as dansmith | 13:34 | |
| *** mgoddard has quit IRC | 13:35 | |
| rloo | hello ironickers, jlvillal, sambetts, TheJulia. Welcome back lucasagomes! | 13:35 |
| * rloo wonders why TheJulia raises an eyebrow | 13:35 | |
| jlvillal | rloo, Good morning | 13:36 |
| lucasagomes | rloo, hello there! Thanks | 13:36 |
| *** alexpilotti has joined #openstack-ironic | 13:36 | |
| rloo | jlvillal: wrt https://review.openstack.org/230682, thx. although not sure when doc8 will be added to ironic | 13:36 |
| jlvillal | rloo, As an FYI, I got a patch merged to make sure 'pep8' job runs on docs only changes. In preparation for your possible doc8 change. | 13:36 |
| rloo | jlvillal: (found a problem with doc8 and need to chase it down one day) | 13:37 |
| jlvillal | Hah. Both talking about same thing :) | 13:37 |
| rloo | jlvillal: :) | 13:37 |
| jlvillal | rloo, Well it is ready when you do :) Thanks. | 13:37 |
| rloo | jlvillal: yup, so good for thinking about it. | 13:37 |
| jlvillal | Thanks | 13:37 |
| *** gabriel has joined #openstack-ironic | 13:38 | |
| *** 6A4AANKQ6 has left #openstack-ironic | 13:40 | |
| jroll | morning jlvillal, dtantsur, sambetts, rloo, TheJulia, and welcome back lucasagomes \o/ | 13:40 |
| TheJulia | good morning jroll | 13:40 |
| *** alexpilotti has quit IRC | 13:40 | |
| rloo | morning jroll | 13:40 |
| dtantsur | morning rloo, jroll, TheJulia | 13:41 |
| lucasagomes | jroll, hi there! morning | 13:41 |
| TheJulia | rloo: good morning, and just something reminded me of my days long ago of being an operator on an irc network. | 13:41 |
| rloo | hiya dtantsur | 13:42 |
| rloo | TheJulia: :) | 13:42 |
| jroll | TheJulia: heh, ident of 'romcheg', seems ok (he used to work on ironic) | 13:42 |
| jroll | but yeah red flags :P | 13:43 |
| TheJulia | jroll: yup :) | 13:43 |
| 7GHABCFAO | Who is that human who summoned me?! | 13:43 |
| jroll | 7GHABCFAO: hi roman :D | 13:43 |
| *** 7GHABCFAO is now known as romcheg | 13:43 | |
| romcheg | Hi folks :) | 13:43 |
| dtantsur | hehe, hi romcheg, long time no see | 13:43 |
| rloo | ha ha. Hiya romcheg! | 13:43 |
| romcheg | Indeed! How are you doing? | 13:44 |
| dtantsur | getting ready for the summit | 13:45 |
| lucasagomes | romcheg, hey there, all is well! How it's going? | 13:46 |
| lucasagomes | romcheg, still working with openstack? | 13:46 |
| romcheg | In general I'm doing pretty well, but today I spent about 20 hrs in a train | 13:47 |
| romcheg | lucasagomes: Yes, but I'm focused on Fuel and it's components. Trying to push it under big tent as hard as I can | 13:47 |
| jlvillal | jroll, Morning | 13:47 |
| lucasagomes | romcheg, I see, cool stuff | 13:47 |
| lucasagomes | romainh, are you going to tokyo? | 13:47 |
| romcheg | Sometimes folks ask me to review Ironic-related patches | 13:48 |
| romcheg | nope | 13:48 |
| romcheg | According to our policy one gets funded for a summit if they have an accepted paper | 13:48 |
| *** mgoddard has joined #openstack-ironic | 13:49 | |
| lucasagomes | I see | 13:49 |
| lucasagomes | :-( | 13:49 |
| dtantsur | so few people got talks accepted this time... | 13:49 |
| romcheg | Usually talks are kind of marketing b**it | 13:50 |
| romcheg | Is it gonna be better or worse this time? :) | 13:50 |
| *** gabriel has quit IRC | 13:50 | |
| lucasagomes | hope so, I'm more interested in the design summit anyway | 13:51 |
| MattMan | Hey lucasagomes , just reading the schedule for LinuxCon in Dublin and I see quite a few OpenStack related one... Monty Taylor doing an Ironic talk at 2pm today... I'm not there, hadn't planned it... | 13:54 |
| dtantsur | romcheg, well, it's more of "customers story" thing, so it depends on how you classify it :) | 13:54 |
| lucasagomes | MattMan, hi there! Yeah there's a couple of talks going on | 13:55 |
| jroll | mordred doing an ironic talk? :o | 13:55 |
| lucasagomes | MattMan, I'm not in the conference either, I came back from a trip yesterday so... | 13:55 |
| * TheJulia is now curious | 13:55 | |
| lucasagomes | but I'm meeting mordred and other folks tonight | 13:55 |
| romcheg | dtantsur: usually that sounds like "become our customer stories" to me :) | 13:55 |
| lucasagomes | so I will ask about it :-) | 13:55 |
| MattMan | http://events.linuxfoundation.org/events/linuxcon-europe/program/schedule | 13:55 |
| jroll | http://events.linuxfoundation.org/events/linuxcon-europe/program/schedule | 13:55 |
| jroll | heh | 13:55 |
| jroll | monty's specifically http://sched.co/3y3l | 13:56 |
| *** alexpilotti has joined #openstack-ironic | 13:56 | |
| MattMan | Also one on inspector: http://sched.co/3xTo | 13:56 |
| dtantsur | heh, and inspector talk by Yuiko is also in | 13:56 |
| dtantsur | oops | 13:56 |
| jroll | \o/ | 13:57 |
| *** openstackstatus has joined #openstack-ironic | 13:57 | |
| *** ChanServ sets mode: +v openstackstatus | 13:57 | |
| lucasagomes | :-) nice one | 13:57 |
| * lucasagomes can see the convention centre from his apartment | 13:57 | |
| lucasagomes | it's like 2 blocks away | 13:57 |
| jroll | nice | 13:58 |
| jroll | you should bug people to grab lunch/drinks | 13:59 |
| MattMan | 10min bus ride for em | 13:59 |
| MattMan | s/em/me | 13:59 |
| sambetts | man I hadn't realised that there was going to be a thing in Dublin, otherwise I would have popped over | 14:00 |
| lucasagomes | jroll, yeah we are going to grab dinner tonight | 14:00 |
| jroll | neat | 14:00 |
| lucasagomes | and for that reason I'm going to miss the meeting as well :-/ | 14:00 |
| jroll | ha, no worries | 14:00 |
| *** alexpilotti has quit IRC | 14:01 | |
| *** gabriel has joined #openstack-ironic | 14:01 | |
| lucasagomes | sambetts, :-( | 14:02 |
| jroll | no meeting agenda today :o | 14:03 |
| *** links has joined #openstack-ironic | 14:05 | |
| * jlvillal thinks Dublin sounds very happening this week :) | 14:05 | |
| * jlvillal tries to remember what he did on hexchat to change color of channel tab when a message alert came in for him... | 14:08 | |
| NobodyCam | good morning Ironicers | 14:10 |
| NobodyCam | morning rloo jroll jlvillal sambetts dtantsur jvmario devananda lucasagomes | 14:11 |
| jlvillal | NobodyCam, Good morning | 14:11 |
| dtantsur | morning NobodyCam | 14:11 |
| NobodyCam | WB lucasagomes | 14:11 |
| NobodyCam | :) morning dtantsur jlvillal :) | 14:12 |
| NobodyCam | arrrg gots to restart brb, | 14:12 |
| jroll | morning NobodyCam :) | 14:12 |
| NobodyCam | :) | 14:12 |
| lucasagomes | NobodyCam, hi there! Thanks much | 14:13 |
| *** alexpilotti has joined #openstack-ironic | 14:16 | |
| mordred | jroll: yup. I think I mostly did not say wrong things | 14:16 |
| mordred | devananda: I did not wind up doing the demo - I could not get vagrant to behave well enough | 14:17 |
| *** thiagop has joined #openstack-ironic | 14:17 | |
| *** Nisha_away has joined #openstack-ironic | 14:18 | |
| thiagop | Good morning, Ironic | 14:18 |
| romainh | lucasagomes: nope | 14:19 |
| jroll | mordred: hooray! | 14:20 |
| lucasagomes | romainh, oh, wrong ping! I meant to ping romcheg. Sorry for that | 14:21 |
| lucasagomes | thiagop, mordred morning | 14:21 |
| thiagop | Hey lucasagomes, welcome back! | 14:21 |
| *** alexpilotti has quit IRC | 14:21 | |
| lucasagomes | thanks! | 14:21 |
| thiagop | Had a good (freezing) time on Iceland? | 14:21 |
| romainh | lucasagomes: hehe no problem :) | 14:22 |
| lucasagomes | thiagop, I did yes! It was pretty awesome over there | 14:23 |
| thiagop | lucasagomes: awesome | 14:23 |
| thiagop | lucasagomes: if you have a slot to take a look on the OneView driver, I'd appreciate | 14:26 |
| thiagop | :) | 14:26 |
| lucasagomes | thiagop, will do! | 14:26 |
| thiagop | Ramesh did a thorough review last week | 14:26 |
| *** mtanino has joined #openstack-ironic | 14:26 | |
| NobodyCam | gots to luv the windows updates | 14:28 |
| NobodyCam | morning mordred :) | 14:28 |
| *** mgoddard_ has joined #openstack-ironic | 14:29 | |
| mordred | morning NobodyCam | 14:29 |
| NobodyCam | :) | 14:29 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Allow empty password for ipmitool console https://review.openstack.org/229904 | 14:30 |
| *** mgoddard has quit IRC | 14:32 | |
| *** alexpilotti has joined #openstack-ironic | 14:36 | |
| lucasagomes | NobodyCam, :O windows? | 14:36 |
| *** yuikotakada has joined #openstack-ironic | 14:37 | |
| NobodyCam | corp box stuff :( | 14:37 |
| rloo | morning NobodyCam! | 14:38 |
| NobodyCam | morning rloo :) | 14:38 |
| *** chlong has quit IRC | 14:38 | |
| *** garthb has joined #openstack-ironic | 14:38 | |
| *** alexpilotti has quit IRC | 14:41 | |
| *** mjturek1 has joined #openstack-ironic | 14:42 | |
| *** amotoki_ has quit IRC | 14:43 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Refactor deploy_utils methods https://review.openstack.org/222264 | 14:47 |
| *** mjturek1 has quit IRC | 14:48 | |
| *** amotoki_ has joined #openstack-ironic | 14:48 | |
| *** mjturek1 has joined #openstack-ironic | 14:49 | |
| *** tsekiyama has joined #openstack-ironic | 14:50 | |
| *** yog_ has quit IRC | 14:52 | |
| *** EmilienM has quit IRC | 14:55 | |
| *** EmilienM has joined #openstack-ironic | 14:55 | |
| NobodyCam | oh Mondays... | 14:55 |
| *** david-ly_ has joined #openstack-ironic | 14:56 | |
| *** alexpilotti has joined #openstack-ironic | 14:56 | |
| *** david-lyle has quit IRC | 14:57 | |
| *** david-ly_ is now known as david-lyle | 14:57 | |
| *** Nisha_away has quit IRC | 14:58 | |
| *** mjturek2 has joined #openstack-ironic | 15:00 | |
| *** mjturek1 has quit IRC | 15:00 | |
| *** alexpilotti has quit IRC | 15:01 | |
| *** nicodemos has quit IRC | 15:01 | |
| sambetts | o/ NobodyCam | 15:01 |
| TheJulia | good morning NobodyCam | 15:01 |
| *** yuikotakada has quit IRC | 15:02 | |
| *** david-ly_ has joined #openstack-ironic | 15:03 | |
| *** david-lyle has quit IRC | 15:03 | |
| *** david-ly_ is now known as david-lyle | 15:04 | |
| *** mgoddard_ has quit IRC | 15:14 | |
| *** mgoddard has joined #openstack-ironic | 15:15 | |
| *** alexpilotti has joined #openstack-ironic | 15:17 | |
| NobodyCam | :) | 15:17 |
| jvmario | \o | 15:19 |
| NobodyCam | mornig jvmario :) | 15:21 |
| *** alexpilotti has quit IRC | 15:21 | |
| jlvillal | lifeless, Will do on pinging you on IRC when I make comment in patchset. Thanks. | 15:23 |
| jlvillal | Hi jvmario | 15:24 |
| jlvillal | NobodyCam, You are not alone in Windows. My corp laptop is Windows also. The rest of my work boxes are all Linux though. | 15:24 |
| NobodyCam | jlvillal: yep:) | 15:25 |
| * jroll hasn't had a windows box, work or otherwise, since 2012 :D | 15:26 | |
| NobodyCam | jroll: I even have a personal laptop with windows on it... it my AlienWare.. just makes for easier gamming | 15:27 |
| NobodyCam | :-p | 15:27 |
| jroll | heh yeah | 15:27 |
| jroll | lots of games on linux these days though :D | 15:27 |
| NobodyCam | lol yea, def getting much better | 15:28 |
| sambetts | my desktop beast for gaming etc is windows, but I run a linux VM on top of it for literally everything else | 15:29 |
| *** mjturek2 has quit IRC | 15:29 | |
| NobodyCam | sambetts: +++ | 15:29 |
| * dtantsur didn't have windows at home since 2006 and at work since 2013 | 15:30 | |
| NobodyCam | I runa vm for git work on the windows box | 15:30 |
| * lucasagomes doesn't use windows for a long time | 15:30 | |
| NobodyCam | lol | 15:30 |
| * NobodyCam offers outlook to everyone | 15:30 | |
| * sambetts has to much money invested in steam to not use windows for gaming | 15:30 | |
| NobodyCam | sambetts: ++++ | 15:30 |
| * NobodyCam git clones a fresh cup of coffee | 15:31 | |
| * dtantsur goes afk until the meeting | 15:31 | |
| *** dtantsur is now known as dtantsur|brb | 15:31 | |
| jroll | sambetts: lots of linux on steam :P | 15:31 |
| openstackgerrit | Merged openstack/ironic: Update help string on tftp_root option https://review.openstack.org/222313 | 15:32 |
| sambetts | jroll: yeah its so much better now, unfortunatly a lot of the ones I play aren't likely to be ported :( | 15:32 |
| jroll | yeah :/ | 15:32 |
| jroll | I was always a console person until recently | 15:33 |
| jroll | so I didn't have a bunch of windows-only to start | 15:33 |
| jroll | civ 5 and cities:skylines are on linux, that's more than enough time to kill there :P | 15:33 |
| lucasagomes | yeah for gamers I think it's still hard to not use windows indeed | 15:34 |
| NobodyCam | I tried one of the flash based online games on linux and while it worked. the performance was not quite there for flash | 15:35 |
| jroll | flash :( | 15:36 |
| jroll | dtantsur|brb: you may be interested in https://review.openstack.org/#/c/228733/11/doc/source/policies/bugs.rst | 15:36 |
| lucasagomes | yeah flash is quite sad to use independent of the platform | 15:36 |
| *** alexpilotti has joined #openstack-ironic | 15:37 | |
| sambetts | I don't know how good the driver support/efficiencies are for graphics cards on linux these days :/ I know it was getting better last time I checked, I need to look up some benchmarks | 15:40 |
| *** dims has quit IRC | 15:40 | |
| *** alexpilotti has quit IRC | 15:42 | |
| *** Nisha_away has joined #openstack-ironic | 15:42 | |
| *** lucasagomes has quit IRC | 15:43 | |
| *** lucasagomes has joined #openstack-ironic | 15:44 | |
| *** mgoddard_ has joined #openstack-ironic | 15:45 | |
| jlvillal | jroll, There are a few outstanding patches for ironic-lib that you might want to get in before doing a release. | 15:46 |
| jroll | jlvillal: already did it last week https://review.openstack.org/#/c/230036/ | 15:46 |
| jroll | but we can release whenever, we'll do one when those drop | 15:46 |
| *** dims has joined #openstack-ironic | 15:47 | |
| *** dims has quit IRC | 15:47 | |
| jlvillal | jroll, Okay. Yeah we have a couple patches that need to be in before we can use ironic-lib. Because the signature for one function changed. | 15:47 |
| jroll | jlvillal: sure, but we can start the work | 15:47 |
| *** Guest96374 has joined #openstack-ironic | 15:47 | |
| jroll | but yeah | 15:47 |
| *** ijw_ has joined #openstack-ironic | 15:47 | |
| jroll | let's make sure to get those done | 15:47 |
| *** Guest96374 has quit IRC | 15:48 | |
| *** david-ly_ has joined #openstack-ironic | 15:48 | |
| *** david-lyle has quit IRC | 15:48 | |
| jlvillal | jroll, The important ones (in my opinion) already have one +2 on them | 15:48 |
| *** dims_ has joined #openstack-ironic | 15:48 | |
| *** mgoddard has quit IRC | 15:48 | |
| jlvillal | https://review.openstack.org/#/q/project:openstack/ironic-lib+status:open,n,z | 15:49 |
| jroll | ok | 15:49 |
| jroll | yeah I will get to them | 15:49 |
| * jroll has a long review list today | 15:49 | |
| jlvillal | :( | 15:49 |
| *** david-ly_ is now known as david-lyle | 15:49 | |
| *** Marga_ has quit IRC | 15:50 | |
| jroll | /shrug | 15:51 |
| jroll | it is what it is | 15:51 |
| *** ijw has quit IRC | 15:51 | |
| greghaynes | TheJulia: Hey, I was running in to http://paste.ubuntu.com/12690228/ last night when using bifrost, look familiar? | 15:53 |
| *** Sukhdev has joined #openstack-ironic | 15:54 | |
| *** liliars has joined #openstack-ironic | 15:56 | |
| *** davideagnello has joined #openstack-ironic | 15:56 | |
| TheJulia | greghaynes: very | 15:57 |
| TheJulia | greghaynes: you need latest ironicclient I think | 15:57 |
| *** alexpilotti has joined #openstack-ironic | 15:57 | |
| TheJulia | I guess I need to increment the required version in shade at this point | 15:58 |
| greghaynes | TheJulia: sweeg | 15:59 |
| greghaynes | TheJulia: does bifrost no pip install -U that? | 15:59 |
| TheJulia | no, playbook does but you can select where from in that case | 15:59 |
| TheJulia | really, I need to do it in shade | 16:00 |
| TheJulia | since it was a shade change that identified that issue | 16:00 |
| greghaynes | yea, that definitely needs to be done too | 16:00 |
| *** mgoddard has joined #openstack-ironic | 16:00 | |
| *** mgoddard_ has quit IRC | 16:00 | |
| *** mitchjameson has joined #openstack-ironic | 16:01 | |
| *** alexpilotti has quit IRC | 16:01 | |
| TheJulia | greghaynes: https://review.openstack.org/231070 | 16:03 |
| *** hemna_ has joined #openstack-ironic | 16:04 | |
| *** bnemec has joined #openstack-ironic | 16:11 | |
| lucasagomes | is it OK to add something to the meeting even tho I won't be there? (re https://review.openstack.org/#/c/225556/) | 16:12 |
| lucasagomes | I think we are better off having the disk label explicit rather than implicit for that case | 16:12 |
| TheJulia | I tend to agree, nothing says a user image can't chagne everything up once it is running. | 16:13 |
| jroll | lucasagomes: I mean, I'm generally ok with that, but on this one I'd like your opinion in the meeting | 16:14 |
| jroll | you know a lot about these things | 16:14 |
| lucasagomes | jroll, right, ok I will leave for the next meeting then | 16:14 |
| lucasagomes | so we can discuss it through | 16:14 |
| * lucasagomes adds to his todo | 16:14 | |
| lucasagomes | or we can discuss it here in IRC as well | 16:15 |
| rloo | lucasagomes: my concern with discussing at a meeting is that mrda authored it and he can't attend meetings | 16:15 |
| lucasagomes | rloo, yeah that's true | 16:15 |
| jroll | well | 16:15 |
| lucasagomes | there's a co-author there but I don't know him | 16:15 |
| jroll | mrda took the patch over from the co-author | 16:15 |
| rloo | lucasagomes: you've -1 | 16:15 |
| rloo | d it | 16:15 |
| lucasagomes | let's have the dicussion in the patch anyway | 16:15 |
| rloo | lucasagomes: yeah, discuss in patch. | 16:15 |
| jroll | +1 | 16:15 |
| rloo | lucasagomes: if it doesn't get resolved in patch, then maybe dev email? | 16:16 |
| NobodyCam | wow the agenda is kinda empty today | 16:16 |
| *** hemna_ has quit IRC | 16:16 | |
| lucasagomes | rloo, ++ | 16:16 |
| lucasagomes | I will keep an eye on it | 16:16 |
| rloo | btw, jroll, NobodyCam: I don't think Columbus Day is a holiday on the west coast, right? | 16:16 |
| rloo | lucasagomes: thx | 16:16 |
| NobodyCam | ??? not sure | 16:17 |
| Nisha_away | lucasagomes, hi | 16:17 |
| lucasagomes | Nisha_away, hi there | 16:17 |
| *** alexpilotti has joined #openstack-ironic | 16:17 | |
| *** Nisha_away is now known as Nisha | 16:17 | |
| rloo | NobodyCam: it is next Monday. if you aren't sure, it probably isn't :) | 16:18 |
| jroll | rloo: I don't believe I get columbus day off, if that's the question :) | 16:18 |
| devananda | good morning, all | 16:18 |
| jroll | ohai devananda | 16:18 |
| lucasagomes | devananda, morning | 16:18 |
| devananda | mordred: bummer. also i think it is working well for me as of this morning | 16:18 |
| devananda | mordred: how did it go otherwise? | 16:18 |
| rloo | jroll: yeah, that's the question. if I recall, I think it was a holiday in MA. | 16:18 |
| NobodyCam | morning devananda | 16:18 |
| rloo | good morning devananda | 16:19 |
| jroll | rloo: I think it depends on the company really | 16:19 |
| Nisha | lucasagomes, i was going through your commenst on https://review.openstack.org/#/c/228020/14/doc/source/drivers/ilo.rst | 16:19 |
| lucasagomes | Nisha, yup | 16:20 |
| Nisha | lucasagomes, one of the comment is on swift command output | 16:20 |
| rloo | jroll: http://www.doe.mass.edu/resources/holidays.html | 16:20 |
| *** marzif has joined #openstack-ironic | 16:20 | |
| mordred | devananda: it went well! was well receieved I thnk - had a couple of good interactions with folks | 16:20 |
| thiagop | morning devananda | 16:20 |
| rloo | jroll: no worries, just wanted to know if the monday meeting might be cancelled next week but i don't think so :) | 16:20 |
| mordred | devananda: including a human I connected with NobodyCam | 16:20 |
| lucasagomes | Nisha, yeah, that's mostly a nit. It looks a bit odd when rendered. Perhaps using that "code-block" tag from RST may make it a bit better | 16:21 |
| lucasagomes | or separating the output from the actual command in two boxes | 16:21 |
| Nisha | lucasagomes, means command in one block and output in anothere? | 16:21 |
| lucasagomes | Nisha, yeah | 16:21 |
| *** alexpilotti has quit IRC | 16:22 | |
| Nisha | ok :) | 16:22 |
| jroll | rloo: nah, I'll be here :) | 16:22 |
| *** pradipta has quit IRC | 16:22 | |
| devananda | mordred: great! | 16:23 |
| *** trown is now known as trown|lunch | 16:24 | |
| devananda | mordred: fwiw, I just pushed 2 commits up - https://github.com/devananda/bifrost/commits/nuc-demo-branch - is working with the walkthrough now | 16:24 |
| devananda | only manual step was the ssh-keygen. which is silly since that's easy to fix | 16:24 |
| mordred | devananda: ++ | 16:25 |
| devananda | curiousity poll -- how many folks in here have a NUC with AMT support? | 16:25 |
| jroll | I don't but I would like to | 16:26 |
| * lucasagomes does not | 16:26 | |
| * sambetts does not either | 16:26 | |
| *** jcoufal_ has quit IRC | 16:26 | |
| *** jistr has quit IRC | 16:26 | |
| jroll | devananda: curiousity poll; why do you ask? :) | 16:26 |
| *** jcoufal has joined #openstack-ironic | 16:26 | |
| lucasagomes | I have a dell optplex 7010 that supports AMT (tho I haven't tested AMT with it) | 16:26 |
| devananda | mordred and I spent some time yesterday getting the demo I gave at the Liberty summit and OSCON working again | 16:27 |
| devananda | (yes, it had bit-rotted this quickly) | 16:27 |
| jlvillal | devananda: I have one | 16:27 |
| devananda | but it would be great to have others step through the walkthrough and a) see if it works for them b) iron it down to something more repeatable | 16:28 |
| mordred | ++ | 16:28 |
| *** e0ne has quit IRC | 16:28 | |
| jlvillal | devananda: I think TheJulia has an AMT system also. I know mrda has one. | 16:28 |
| devananda | great | 16:28 |
| jroll | devananda: what parts bitrotted? | 16:28 |
| jlvillal | devananda: mrda wrote up a blog article on it: http://lifelog.michaeldavies.org/ Two parts | 16:28 |
| sambetts | jroll: I just tried to create a bit.do shortened link for the ironic review dashboard link, turns out the link it too long, they cap at 2048 chars for the link, and the dashboard link is 2070ish | 16:28 |
| jroll | sambetts: x.x | 16:29 |
| devananda | jroll: https://github.com/devananda/ironic/commit/f05b237bb4d2b7afde139cdeeb84462a0cf316ef | 16:29 |
| *** jcoufal has quit IRC | 16:29 | |
| sambetts | jroll: I wondered if it was the same thing you encountered for bit.ly | 16:29 |
| devananda | jroll: and some configs in bifrost needed to be changed from VM-based defaults | 16:29 |
| jroll | devananda: wait wtf | 16:29 |
| devananda | https://github.com/devananda/bifrost/commits/nuc-demo-branch | 16:30 |
| devananda | jroll: inorite??? | 16:30 |
| jroll | devananda: how does that break | 16:30 |
| jroll | bug pls | 16:30 |
| jroll | :( | 16:30 |
| devananda | jroll: yup | 16:30 |
| devananda | we broke my out of tree driver with liberty :( | 16:30 |
| jroll | devananda: I guess we need to backprot too eh | 16:30 |
| jroll | but like | 16:30 |
| jroll | how | 16:30 |
| devananda | jroll: like, it blows up because there's no driver.boot member | 16:31 |
| lucasagomes | ew x.x | 16:31 |
| * lucasagomes thought the split was backward compat | 16:31 | |
| jroll | ugh, yeah | 16:32 |
| jroll | I want to see tracebacks :/ | 16:32 |
| devananda | sure thing | 16:32 |
| jroll | devananda: pxe or agent or both? | 16:32 |
| devananda | jroll: doesn't matter | 16:32 |
| devananda | it's not about the driver/module/* code | 16:32 |
| devananda | traceback coming up .... | 16:32 |
| jroll | devananda: well, I'm wondering if its blowing up in AgentDeploy or whatever | 16:32 |
| jroll | k | 16:32 |
| devananda | rolled back to before that fix, then tried to delete the instance I deployed previously | 16:35 |
| devananda | http://paste.openstack.org/show/475353/ | 16:35 |
| devananda | the ConductorManager is trying to access methods that don't exist because there is no task.driver.boot | 16:35 |
| devananda | same thing happens during deploy | 16:35 |
| jroll | File "/usr/local/lib/python2.7/dist-packages/ironic/drivers/modules/agent.py", line 281, in clean_up | 16:36 |
| jroll | task.driver.boot.clean_up_ramdisk(task) | 16:36 |
| jroll | not conductor manager | 16:36 |
| jroll | so our in-tree deploy drivers are not compatible with out-of-tree drivers | 16:36 |
| jroll | :( | 16:36 |
| devananda | ooh right | 16:37 |
| devananda | yes | 16:37 |
| *** alexpilotti has joined #openstack-ironic | 16:37 | |
| devananda | liberty agent deploy driver is not compatible with pre-liberty power drivers any longer | 16:38 |
| devananda | is a better way of putting it | 16:38 |
| jroll | I suspect that's true for other deploy drivers, but yeah | 16:38 |
| lucasagomes | oh yeah | 16:38 |
| lucasagomes | it was expected tho, right? | 16:38 |
| jroll | I think it's more that we didn't consider it | 16:39 |
| jroll | devananda: do you mind updating release notes and sending a mail about it? | 16:39 |
| devananda | jroll: not at all | 16:39 |
| jroll | thanks much | 16:39 |
| devananda | just gathering a traceback from deploy now, too | 16:39 |
| jroll | devananda: and maybe fix it, if it isn't a massive patch | 16:40 |
| *** mbound has quit IRC | 16:41 | |
| *** alexpilotti has quit IRC | 16:42 | |
| *** ijw_ has quit IRC | 16:43 | |
| *** aswadr has joined #openstack-ironic | 16:44 | |
| *** achanda has joined #openstack-ironic | 16:50 | |
| *** romainh has left #openstack-ironic | 16:51 | |
| *** penick has joined #openstack-ironic | 16:52 | |
| *** mitchjameson has quit IRC | 16:55 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Add notes to functions which are in ironic-lib https://review.openstack.org/231092 | 16:56 |
| NobodyCam | three minutes... | 16:57 |
| *** trown|lunch is now known as trown | 16:57 | |
| *** vdrok_ has joined #openstack-ironic | 16:57 | |
| NobodyCam | jroll: you planning on running the meeting? | 16:57 |
| jroll | NobodyCam: yes | 16:58 |
| *** alexpilotti has joined #openstack-ironic | 16:58 | |
| NobodyCam | :) | 16:58 |
| NobodyCam | easy agenda today | 16:58 |
| *** dtantsur|brb is now known as dtantsur | 16:58 | |
| devananda | jroll: https://bugs.launchpad.net/ironic/+bug/1502980 | 16:59 |
| openstack | Launchpad bug 1502980 in Ironic "Liberty release of deploy drivers break compat with out-of-tree power drivers" [Undecided,New] | 16:59 |
| jroll | thanks | 16:59 |
| *** xek has joined #openstack-ironic | 17:00 | |
| openstackgerrit | greghaynes proposed openstack/bifrost: Fix fail if network_interface contains '-' https://review.openstack.org/230779 | 17:01 |
| greghaynes | TheJulia: ^ I think that answers and fixes your question | 17:01 |
| TheJulia | merci | 17:02 |
| *** alexpilotti has quit IRC | 17:02 | |
| *** ijw has joined #openstack-ironic | 17:02 | |
| *** mkovacik has quit IRC | 17:04 | |
| *** romcheg has quit IRC | 17:05 | |
| davidlenwell | o/ | 17:07 |
| lucasagomes | Nisha, http://lists.openstack.org/pipermail/openstack-dev/2015-October/075986.html | 17:08 |
| lucasagomes | sending here since I won't be around the open discussion | 17:08 |
| Nisha | lucasagomes, :) thanks | 17:09 |
| lucasagomes | np | 17:09 |
| *** marzif has quit IRC | 17:09 | |
| Nisha | lucasagomes, i didnt mean that | 17:09 |
| *** thiagop has quit IRC | 17:09 | |
| *** liliars has quit IRC | 17:09 | |
| *** sinval has quit IRC | 17:10 | |
| dtantsur | Nisha, I guess answer for you is: at the summit we discuss things requiring discussion. Does you spec require discussion? | 17:10 |
| mgoddard | Hi all, can anyone tell me what the current state of UI for Ironic is? Tuskar-ui provides an interface but seems to have gone a little quiet. Is there a plan, spec or implementation in the works? | 17:11 |
| dtantsur | mgoddard, folks are working on a thing called ironic-webclient | 17:11 |
| dtantsur | mgoddard, https://github.com/openstack/ironic-webclient | 17:12 |
| lucasagomes | Nisha, oh... ok, you mean the ones that didn't get approved? | 17:12 |
| Nisha | I had read this mail. My ques was if any spec which didnt go thru in Liberty if they are not added to the Mitaka etherpad, will they be discussed there in summit? and will they have priroties set for Mitaka release | 17:12 |
| dtantsur | mgoddard, Tuskar UI undergoes rethinking right now, so I don't have an idea how it ends up | 17:12 |
| Nisha | yeah | 17:12 |
| lucasagomes | I think you don't need to resubmit it because we do not separate specs by the cycle name | 17:12 |
| lucasagomes | so if the spec is proposing something under approved/ it should be grand | 17:12 |
| mgoddard | dtantsur, thanks. Looks interesting. I take it it's not integrated with Horizon? Looks like it's in NodeJS | 17:13 |
| NobodyCam | have a good night lucasagomes | 17:13 |
| jlvillal | lucasagomes: Ciao! | 17:13 |
| lucasagomes | NobodyCam, thanks, see ya tomorrow | 17:13 |
| lucasagomes | sorry I can't stay in the meeting toda | 17:13 |
| dtantsur | mgoddard, IIRC krotscheck is a person to ask (sorry if I'm wrong) | 17:13 |
| lucasagomes | today* | 17:13 |
| Nisha | lucasagomes, we dont need to add it to mitaka etherpad also? | 17:13 |
| *** tsekiyama has quit IRC | 17:13 | |
| jroll | Nisha: we don't talk about specs at the summit, just because they exist. if you need to talk about a spec during the summit, please add it to the etherpad | 17:13 |
| NobodyCam | :) | 17:14 |
| krotscheck | eh? wha? | 17:14 |
| NobodyCam | we got covered lucasagomes | 17:14 |
| dtantsur | Nisha, and "please review the spec" is not a discussion ;) | 17:14 |
| Nisha | jroll, ok. | 17:14 |
| Nisha | dtantsur, no i didnt mean that | 17:14 |
| lucasagomes | Nisha, not sure... I don't think we have a mitaka etherpad anyway | 17:14 |
| lucasagomes | ok gone | 17:14 |
| *** lucasagomes is now known as lucas-dinner | 17:14 | |
| krotscheck | mgoddard: I write nothing in node. Node is the engine that runs the build tools, but the output is static javascript, html, and css. | 17:14 |
| lucas-dinner | Nisha, catch up with you about it later | 17:14 |
| jroll | lucas-dinner: https://etherpad.openstack.org/p/mitaka-ironic-design-summit-ideas | 17:14 |
| krotscheck | mgoddard: As for integration, check with betherly - she's bridging the gap. | 17:15 |
| dtantsur | jroll, this is for summit, not the mitaka priorities Nisha asked for | 17:15 |
| Nisha | lucas-dinner, https://etherpad.openstack.org/p/mitaka-ironic-design-summit-ideas | 17:15 |
| krotscheck | mgoddard: Any other questions? | 17:15 |
| jroll | oh, I thought we were talking about summit | 17:15 |
| * lucas-dinner is also confused | 17:15 | |
| dtantsur | Nisha, maybe that's the source of confusion: summit ideas != mitaka priorities | 17:15 |
| lucas-dinner | yeah I thought it was something like the spreadsheet we have for patches | 17:15 |
| lucas-dinner | not summit design ideas | 17:15 |
| lucas-dinner | anyhoo... | 17:15 |
| mgoddard | krotscheck: thanks. how mature is the project? WIP or done? | 17:16 |
| Nisha | ohk :) i just wanted to understand if priorities for Mitaka cycle gets decided just based on summit discussions | 17:16 |
| *** e0ne has joined #openstack-ironic | 17:17 | |
| Nisha | i may be wrong, but wanted to unerstand :) | 17:17 |
| krotscheck | mgoddard: When is anything in openstack not WIP? | 17:17 |
| dtantsur | lol | 17:17 |
| krotscheck | mgoddard: It's not feature complete yet if that's what you're asking. We could use some additional reviewers to move things along :) | 17:17 |
| betherly | mgoddard: I am in process of writing the horizon panel at the moment | 17:17 |
| *** alexpilotti has joined #openstack-ironic | 17:18 | |
| *** thiagop has joined #openstack-ironic | 17:20 | |
| mgoddard | krotschek: WIPaaS | 17:21 |
| mgoddard | actually quite like that :) | 17:21 |
| mgoddard | betherly, krotscheck: any docs, or specs etc for the work? | 17:22 |
| *** alexpilotti has quit IRC | 17:22 | |
| *** penick has quit IRC | 17:24 | |
| krotscheck | mgoddard: Somethin like this? etherpad.openstack.org/p/ironic-webclient-use-cases | 17:24 |
| *** praneshp has joined #openstack-ironic | 17:24 | |
| mgoddard | krotscheck: thanks, looks useful. | 17:25 |
| mgoddard | thanks for the help all, I'll be back with more questions as and when they come up. | 17:26 |
| *** Marga_ has joined #openstack-ironic | 17:26 | |
| *** openstackgerrit has quit IRC | 17:31 | |
| *** openstackgerrit has joined #openstack-ironic | 17:32 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy https://review.openstack.org/228020 | 17:37 |
| *** alexpilotti has joined #openstack-ironic | 17:37 | |
| *** amotoki_ has quit IRC | 17:38 | |
| lifeless | jlvillal: thanks :) | 17:41 |
| *** alexpilotti has quit IRC | 17:43 | |
| *** vdrok_ has quit IRC | 17:44 | |
| rloo | thiagop: wrt the meeting, about emails and communication. wanted to follow up. and I didn't mean to pick on you at the meeting. | 17:44 |
| rloo | thiagop: do the emails on openstack-dev work for you? | 17:45 |
| *** liliars has joined #openstack-ironic | 17:46 | |
| jroll | yeah, this seems to be a common problem | 17:46 |
| jroll | I have no idea how to communicate to everyone at the same time, outside of the ML, but lots of people miss things on the ML | 17:47 |
| thiagop | rloo: no problem. The e-mails do not really work for me since I take care of two teams and a lot of pressing concerns here | 17:47 |
| thiagop | rloo: specially in the past 15 days | 17:47 |
| rloo | thiagop: what would work for you? or is it just that you're so busy so that what works is for you to ask questions when you have a question? | 17:48 |
| thiagop | rloo: It's me really, not a e-mail problem | 17:48 |
| jroll | thiagop: what I did a while ago was filter "[openstack-dev] [ironic]" to a specific folder that alerts me | 17:48 |
| jroll | idk if that would help | 17:48 |
| TheJulia | /win/win 1 | 17:48 |
| TheJulia | doh | 17:49 |
| rloo | thiagop: ok, let us know if you have any ideas. there isn't that much chatter and I'd actually like to see more chatter on the dev list! | 17:49 |
| jroll | ++ | 17:49 |
| NobodyCam | that looks like a win win | 17:49 |
| jroll | thiagop: I'd also love to find out how I can communicate things to you (or others that don't/can't read the mailing list) better | 17:49 |
| thiagop | jroll: Thanks (there is also a problem with my thunderbird here. I just doesn't work with my nvidia card...) | 17:50 |
| thiagop | rloo: I will, thanks | 17:50 |
| *** ijw has quit IRC | 17:50 | |
| *** dtantsur is now known as dtantsur|afk | 17:51 | |
| *** Sukhdev has quit IRC | 17:51 | |
| rloo | jlvillal, jroll: wrt ironic-lib, which of these need to be approved before we can do the ironic-using-lib exercise? https://review.openstack.org/#/q/project:openstack/ironic-lib+status:open,n,z | 17:52 |
| jroll | rloo: the jlvillal patches that are not wip, and we may as well pick up the global-requirements thing | 17:52 |
| jlvillal | rloo: jroll: I think: https://review.openstack.org/230071 and https://review.openstack.org/230201 | 17:52 |
| openstackgerrit | Merged openstack/ironic-lib: Updated from global requirements https://review.openstack.org/230462 | 17:53 |
| *** ijw has joined #openstack-ironic | 17:53 | |
| jroll | so yeah just those two now heh | 17:53 |
| jlvillal | rloo: jroll: And the 2nd one has a +A, but it depends on the first one. | 17:53 |
| jroll | oh cool | 17:53 |
| rloo | jlvillal: ok, i'll look at the first. has two +2 already. | 17:53 |
| * jroll grabs some food | 17:53 | |
| jlvillal | rloo: Thank you | 17:54 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy https://review.openstack.org/228020 | 17:54 |
| *** sinval has joined #openstack-ironic | 17:54 | |
| *** pelix has quit IRC | 17:54 | |
| *** alexpilotti has joined #openstack-ironic | 17:54 | |
| jlvillal | rloo: jroll: On a tangential note: https://review.openstack.org/231092 Which adds NOTES to the functions that are in ironic but will be moved/deleted because they are in ironic-lib. | 17:55 |
| rloo | jlvillal: thx for that patch. i'd rather not have to add it in, vs just making ironic use the lib ASAP | 17:56 |
| jlvillal | rloo: Understood. Depends how fast we are :) | 17:56 |
| rloo | jlvillal: yup. | 17:57 |
| sambetts | jlvillal: I was looking at that proxies patch and thinking the same thing I just hadn't got round to commenting :-P | 17:58 |
| jlvillal | sambetts: :) | 17:58 |
| * jlvillal was very happy when he discovered requests :) | 17:58 | |
| *** alexpilotti has quit IRC | 17:59 | |
| thiagop | requests is beautiful | 17:59 |
| jlvillal | :) | 17:59 |
| sambetts | :) yup | 17:59 |
| *** puranamr has joined #openstack-ironic | 17:59 | |
| sambetts | right, I'm calling it a night, see everyone tomorrow o/ | 18:00 |
| TheJulia | goodnight sambetts | 18:00 |
| thiagop | night sambetts | 18:00 |
| *** openstackgerrit has quit IRC | 18:01 | |
| *** Marga_ has quit IRC | 18:01 | |
| *** openstackgerrit has joined #openstack-ironic | 18:02 | |
| *** Marga_ has joined #openstack-ironic | 18:02 | |
| jlvillal | sambetts: bye! | 18:02 |
| NobodyCam | night sambetts | 18:07 |
| devananda | on fixing the boot interface, I have two ideas: | 18:11 |
| rloo | jlvillal: while you were looking at ironic-lib, did you notice that this is different from what is in ironic: https://github.com/openstack/ironic-lib/blob/123414e327d991bbe71d72637af3b84e434c3c4b/ironic_lib/disk_utils.py#L275 | 18:11 |
| jlvillal | rloo: checking... | 18:11 |
| jlvillal | rloo: Yes. I did. I believe it is correct. | 18:11 |
| devananda | 1. wrap calls made from the PXEDeploy and AgentDeploy driver such that they detect a lack of task.driver.boot -- and then they go instantiate it with PXEBoot() | 18:11 |
| devananda | ^ would change code in both of those classes | 18:12 |
| jlvillal | rloo: In ironic they call a function which is the two lines there. I think. Let me double check. | 18:12 |
| rloo | jlvillal: ok thx. (that's what i mean by 'if the refactoring stuck to copy/paste it'd be easier to eyeball/verify) | 18:12 |
| *** [1]cdearborn has quit IRC | 18:12 | |
| jlvillal | rloo: Yep | 18:12 |
| jlvillal | rloo: I wrote a script on Friday to help me compare functions. So I feel pretty good that things match up. But good to get a 2nd/3rd opinion | 18:13 |
| devananda | 2. implement a sort of mock in drivers/base.py, instantiate it in the *base* class's .boot interface. when that mock is accessed, it would immediately instantiate a PXEBoot() and replace itself with that | 18:13 |
| devananda | ^ shouldn't require changes to any drivers, and has the added benefit of maybe working for another out of tree driver that used a deploy driver besides agent or pxe | 18:14 |
| devananda | thoughts? ^ | 18:14 |
| *** tsekiyama has joined #openstack-ironic | 18:14 | |
| *** alexpilotti has joined #openstack-ironic | 18:14 | |
| jroll | devananda: I think I like (1) (but do it for all deploy drivers using the boot interface), because I think the latter may break out of tree deploy drivers? | 18:16 |
| jroll | devananda: e.g. a deploy driver that does the pxe booting stuff in its deploy thing | 18:16 |
| devananda | jroll: ah, good point. suddenly having a .boot interface might not be good for such a driver | 18:17 |
| jroll | devananda: ya | 18:17 |
| *** puranamr has quit IRC | 18:18 | |
| *** cdearborn has joined #openstack-ironic | 18:18 | |
| *** alexpilotti has quit IRC | 18:19 | |
| crinkle | TheJulia: in https://review.openstack.org/#/c/216431/5..6/playbooks/library/network_metadata.py should line 75 also be module.params['vlan_id'] instead of 'ipv4_vlan_id' ? | 18:20 |
| crinkle | greghaynes: ^ | 18:20 |
| *** lazy_prince has quit IRC | 18:20 | |
| greghaynes | very possibly | 18:20 |
| greghaynes | crinkle: if you want to fix / make changes to that patch | 18:21 |
| greghaynes | crinkle: go for it | 18:21 |
| crinkle | okay, wanted to see if it was unintentional or if i was misreading it | 18:21 |
| greghaynes | im not sure that would cause the bug youre seeing | 18:22 |
| greghaynes | but I havent fully re-paged-in my change | 18:22 |
| devananda | jroll: fwiw, that will result in node-validate listing the boot interface as "not supported" | 18:23 |
| crinkle | greghaynes: it would cause network_info.json to not have the vlan link | 18:23 |
| crinkle | greghaynes: though glean still seemed to get vlan info from somewhere, still trying to work that out | 18:23 |
| *** mjturek1 has joined #openstack-ironic | 18:24 | |
| jroll | devananda: hm, that might be ok since really it isn't supported | 18:24 |
| jroll | devananda: I'm also curious why boot interface matters to the user at all | 18:24 |
| openstackgerrit | Colleen Murphy proposed openstack/bifrost: Support setting vlan in config drive https://review.openstack.org/216431 | 18:24 |
| devananda | jroll: it may be fine | 18:25 |
| *** dims_ has quit IRC | 18:27 | |
| rloo | boot interface isn't a core interface, it is standard. so it doesn't matter that it is not supported. | 18:27 |
| devananda | rloo: yah. except within the PXEDeploy and AgentDeploy drivers | 18:28 |
| *** thiagop has quit IRC | 18:28 | |
| rloo | devananda: right. | 18:28 |
| devananda | huh. so instantiating the PXEBoot() interface from within the AgentDeploy driver, since it relies on there being *something* at driver.boot, is going to lead to some interesting behavior | 18:29 |
| openstackgerrit | Merged openstack/ironic-lib: Sync the make_partitions function with ironic https://review.openstack.org/230071 | 18:29 |
| devananda | node-validate will show "boot: not supported" and then later on it will show "boot: True" | 18:29 |
| openstackgerrit | Merged openstack/ironic-lib: Add more info level logs to disk_utils.work_on_disk() method https://review.openstack.org/230201 | 18:29 |
| devananda | ok - this should not be happening during the call to deploy. that's too late -- it should happen during driver init | 18:30 |
| *** penick has joined #openstack-ironic | 18:30 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Remove outdated bifrost-setup-nodes role https://review.openstack.org/231130 | 18:30 |
| jroll | devananda: you said what I was going to say as I read it :P | 18:30 |
| devananda | except __init__ is a function of the out of tree driver -- and task.driver is *passed into* the AgentDeploy methods | 18:31 |
| devananda | urgh :( | 18:31 |
| devananda | i can't do this in AgentDeploy.__init__ | 18:31 |
| *** thiagop has joined #openstack-ironic | 18:32 | |
| openstackgerrit | Merged openstack/ironic: Fix conductor deregistration on non init conductor https://review.openstack.org/225573 | 18:32 |
| devananda | so I guess AgentDeploy.[validate,prepare,cleanup] all need to live-edit the passed-in task.driver object ... | 18:32 |
| devananda | yay | 18:33 |
| openstackgerrit | Colleen Murphy proposed openstack/bifrost: Support setting vlan in config drive https://review.openstack.org/216431 | 18:33 |
| jlvillal | rloo: jroll: I think we could release ironic-lib now. Not sure if you agree. | 18:33 |
| rloo | jlvillal: i took a quick look at the get_image_mb() I asked you about. I don't see that they are the same (ironic vs ironic-lib) | 18:34 |
| *** alexpilotti has joined #openstack-ironic | 18:34 | |
| rloo | jlvillal: oh wait, i could be wrong. i didn't look enough. | 18:35 |
| jlvillal | rloo: In common/images.py | 18:36 |
| jlvillal | rloo: converted_sizes() | 18:36 |
| rloo | jlvillal: yeah, sorry. i just looked at common/images.py :) | 18:36 |
| jlvillal | rloo: No worries. But you had me worried for a moment ;) | 18:36 |
| rloo | jlvillal, jroll: i think we should release the lib, and then get that ironic patch updated: https://review.openstack.org/#/c/184443/ | 18:37 |
| jlvillal | +1 | 18:37 |
| rloo | and in the meantime, keep an eye on code changes to ironic. | 18:37 |
| TheJulia | crinkle: good catch | 18:38 |
| *** alexpilotti has quit IRC | 18:39 | |
| rloo | jlvillal: the ironic+lib patch hasn't been updated since May :-( https://review.openstack.org/#/c/184443/ | 18:43 |
| jlvillal | rloo: Yeah :( I was thinking about starting a new patch. | 18:44 |
| *** links has quit IRC | 18:44 | |
| jroll | isn't ramesh supposed to be doing this work? | 18:44 |
| jlvillal | jroll: I think so, but not sure if he has time. | 18:44 |
| rloo | jroll: that's what I thought. I thought he was supposed to have gotten an updated patch to us last week. | 18:44 |
| jroll | yeah | 18:44 |
| jlvillal | I was thinking about just starting to do small chunks at a time. | 18:45 |
| jroll | I just would rather have jlvillal focus on testing stuff if ramesh is handling this | 18:45 |
| *** mitchjameson has joined #openstack-ironic | 18:45 | |
| jlvillal | Okay. I can do either. | 18:45 |
| rloo | jroll: I don't care who handles it, as long it is one person and we don't have several doing the same time. | 18:45 |
| jroll | rloo: yeah, that's another reason | 18:45 |
| rloo | jroll: am thinking we should send email to ramesh/syed. if they can't do a patch by tomorrow, we should get someone else to do it. | 18:45 |
| *** marzif has joined #openstack-ironic | 18:46 | |
| rloo | jroll: syed spent a lot of time on this I think so i'd like it if he finishes if he wants to. | 18:46 |
| jlvillal | I think syed no longer works on Ironic | 18:46 |
| rloo | jlvillal: oh. | 18:46 |
| jlvillal | But can't hurt to email them both. | 18:46 |
| jroll | jlvillal: yeah, send an email on the list pls | 18:46 |
| jroll | and coordinate between whoever | 18:47 |
| jlvillal | Will do. | 18:47 |
| jroll | thanks | 18:47 |
| rloo | jroll: you think the list, vs just emailing them directly? | 18:48 |
| * jlvillal leans toward direct email. | 18:48 | |
| *** morgabra_ is now known as morgabra | 18:48 | |
| jroll | rloo: I like the list, so 1) others can know what's going on; 2) others can chip in to help if they see we need people working on it | 18:49 |
| jlvillal | Okay | 18:50 |
| rloo | jroll: in this case, it seems like i just want to get the status from some people and don't think it is worth 'spamming' the list for that. | 18:50 |
| rloo | jroll: i would agree that if we want folks to chip in, asking on the list is good. | 18:50 |
| jroll | sure | 18:51 |
| jroll | it sounds like 'planning work' to me, which I prefer to do in the open | 18:51 |
| jroll | but whatever yall think is best | 18:51 |
| jlvillal | I'll go with direct email just to see what their status is and plans. | 18:51 |
| *** mitchjameson has quit IRC | 18:52 | |
| rloo | jroll: well it isn't planning in the sense that syed was working on it. planning would be more like why we don't even have a spec or bug or something about what ironic-lib was when we created it... ;) | 18:52 |
| *** Nisha has quit IRC | 18:53 | |
| jroll | rloo: heh | 18:53 |
| *** alexpilotti has joined #openstack-ironic | 18:53 | |
| *** marzif has quit IRC | 18:54 | |
| *** marzif has joined #openstack-ironic | 18:55 | |
| jlvillal | rloo: jroll: Email sent and you were on CC list | 18:55 |
| jroll | thanks | 18:56 |
| * jlvillal goes to get some lunch.... | 18:56 | |
| *** alexpilotti has quit IRC | 18:58 | |
| *** dims_ has joined #openstack-ironic | 18:58 | |
| *** dims_ has quit IRC | 18:58 | |
| *** dims_ has joined #openstack-ironic | 18:59 | |
| *** gabriel-bezerra has joined #openstack-ironic | 19:00 | |
| *** Marga_ has quit IRC | 19:00 | |
| *** gabriel has quit IRC | 19:00 | |
| *** Marga_ has joined #openstack-ironic | 19:00 | |
| *** Marga_ has quit IRC | 19:01 | |
| *** Marga_ has joined #openstack-ironic | 19:02 | |
| *** baoli has quit IRC | 19:02 | |
| *** dims_ has quit IRC | 19:03 | |
| *** puranamr has joined #openstack-ironic | 19:05 | |
| openstackgerrit | Dan Prince proposed openstack/ironic: Fix log formatting issue in agent base https://review.openstack.org/231140 | 19:05 |
| *** penick has quit IRC | 19:06 | |
| *** e0ne has quit IRC | 19:06 | |
| *** [1]cdearborn has joined #openstack-ironic | 19:06 | |
| *** puranamr has quit IRC | 19:07 | |
| *** penick has joined #openstack-ironic | 19:08 | |
| *** cdearborn has quit IRC | 19:11 | |
| *** Sukhdev has joined #openstack-ironic | 19:12 | |
| openstackgerrit | Stephanie Miller proposed openstack/bifrost: Use parameterized include for repeated git tasks https://review.openstack.org/230598 | 19:12 |
| *** alexpilotti has joined #openstack-ironic | 19:13 | |
| *** alexpilotti has quit IRC | 19:18 | |
| *** achanda has quit IRC | 19:25 | |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Configuration Resource https://review.openstack.org/229055 | 19:27 |
| krotscheck | That should break everything | 19:28 |
| krotscheck | And by everything I mean nothing | 19:28 |
| NobodyCam | krotscheck: :p | 19:28 |
| *** sdake has joined #openstack-ironic | 19:30 | |
| *** achanda has joined #openstack-ironic | 19:31 | |
| *** alexpilotti has joined #openstack-ironic | 19:34 | |
| jlvillal | rloo, Bugs like this patch fixes: https://review.openstack.org/231140 Makes me thing checking for log messages in unit tests is not a bad idea. | 19:36 |
| rloo | jlvillal: I don't deny that it would be useful. but... do we do a test for every log message? | 19:36 |
| *** marzif has quit IRC | 19:37 | |
| jlvillal | rloo, Probably not every log message, that will be difficult to accomplish. But encourage adding tests for them, would be good. | 19:38 |
| rloo | jlvillal: I'm not convinced we want to encourage adding tests for them. i really hate inconsistent things unless there is a good reason. | 19:38 |
| *** alexpilotti has quit IRC | 19:38 | |
| rloo | jlvillal: like, will we now have reviewers -1'ing because there are no tests for log msgs? | 19:39 |
| jlvillal | To me the good reason is we have seen multiple cases of log messages broken, because they aren't tested. | 19:39 |
| rloo | jlvillal: then that may be a good case to say we should test all log messages. | 19:39 |
| jlvillal | Maybe an item for discussion. | 19:40 |
| jlvillal | Okay, I've got to go walk back to work with some extra walking thrown in for good health :) | 19:40 |
| rloo | jlvillal: enjoy your walk! | 19:40 |
| *** vrl has joined #openstack-ironic | 19:43 | |
| *** mitchjameson has joined #openstack-ironic | 19:44 | |
| *** alexpilotti has joined #openstack-ironic | 19:44 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 19:48 |
| *** baoli has joined #openstack-ironic | 19:48 | |
| *** baoli has quit IRC | 19:48 | |
| *** alexpilotti has quit IRC | 19:48 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 19:49 |
| *** baoli has joined #openstack-ironic | 19:49 | |
| *** dims_ has joined #openstack-ironic | 19:53 | |
| *** achanda has quit IRC | 19:54 | |
| *** dims_ has quit IRC | 19:57 | |
| *** sdake has quit IRC | 19:59 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: To run a unit test with ostestr use -r https://review.openstack.org/231156 | 19:59 |
| *** Sukhdev has quit IRC | 20:02 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: To run a specific unit test with ostestr use -r https://review.openstack.org/231156 | 20:03 |
| jlvillal | rloo: ^^^ just updated the commit message. To use 'specific' | 20:04 |
| rloo | jlvillal: thx. it isn't more than 50 char is it? | 20:04 |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 20:04 |
| *** alexpilotti has joined #openstack-ironic | 20:04 | |
| jlvillal | rloo 47 :) | 20:05 |
| rloo | jlvillal: phew. | 20:05 |
| jlvillal | heh | 20:05 |
| *** penick has quit IRC | 20:09 | |
| *** alexpilotti has quit IRC | 20:10 | |
| *** ifarkas has quit IRC | 20:10 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 20:14 |
| *** e0ne has joined #openstack-ironic | 20:15 | |
| *** dims_ has joined #openstack-ironic | 20:16 | |
| *** dims_ has quit IRC | 20:16 | |
| openstackgerrit | Sinval Vieira Mendes Neto proposed openstack/python-oneviewclient: Refactoring python-oneviewclient to use domain models of OneView as objects https://review.openstack.org/230988 | 20:16 |
| *** dims_ has joined #openstack-ironic | 20:16 | |
| *** baoli has quit IRC | 20:24 | |
| lifeless | jlvillal: so does pavel irc? | 20:24 |
| *** alexpilotti has joined #openstack-ironic | 20:25 | |
| *** penick has joined #openstack-ironic | 20:25 | |
| *** achanda has joined #openstack-ironic | 20:25 | |
| jlvillal | lifeless: I'm not sure.. | 20:25 |
| lifeless | jlvillal: (The more I think about that patch, the more uncomfortable with it I feel: there's a raft of features that make OpenStack testing sustainable, and if he's on a pogrom to unwind them all, we're going to suffer majorly | 20:25 |
| lifeless | jlvillal: so I'd like to debug whats *actually* behind his thing and sort it out asap | 20:25 |
| jlvillal | lifeless: My theory is that he thought he was just cleaning up. At least that is my hope. And didn't realize the benefit of the assertThat with regards to failures | 20:26 |
| lifeless | jlvillal: thats entirely possible | 20:27 |
| lifeless | jlvillal: we see lots of not-bugfixing not-feature work churn, it makes me a little sad | 20:27 |
| lifeless | (I consider techdebt bug-fixing) | 20:27 |
| jlvillal | lifeless: I sent him an email asking what his IRC nick is. | 20:27 |
| lifeless | jlvillal: cool | 20:27 |
| jlvillal | lifeless: He works at Mirantis, but not sure what time zone. | 20:28 |
| lifeless | yeah, could be east coast, or europe | 20:28 |
| lifeless | I can overlap with Europe's morning sufficiently with a little effort | 20:28 |
| jlvillal | lifeless: As long as you are here. Any suggestions on resources to learn about doing functional testing? | 20:28 |
| jlvillal | lifeless: Trying to decrypt how nova does theirs to learn more. | 20:28 |
| jlvillal | We want to add it to ironic. | 20:29 |
| lifeless | righto | 20:29 |
| lifeless | mtreinish: ^ links plox? | 20:29 |
| *** alexpilotti has quit IRC | 20:29 | |
| lifeless | jlvillal: AIUI its something like this: a devstack plugin to do your service setup and configs to turn everything unrelated off | 20:29 |
| mtreinish | what's up | 20:29 |
| mtreinish | oh, functional testing | 20:30 |
| lifeless | jlvillal: then tempest-lib gets you the tempest core code to write your tests in | 20:30 |
| jlvillal | Yep :) | 20:30 |
| *** achanda has quit IRC | 20:30 | |
| mtreinish | lifeless: well that's one thing it can do, but nova actually doesn't have tests like that | 20:30 |
| rloo | jroll: qq. wrt 'manual cleaning' as opposed to zapping. it seemed easier to create a new LP/spec (cuz of title etc) than to try to update the zapping spec. You good with that? | 20:30 |
| jlvillal | mtreinish: We are starting from scratch. So what would be the preferred way would be good to know. | 20:30 |
| jlvillal | We are investigating using mimic, but need it to be Python 3 compatible first, before we can get it into the global-requirements. | 20:31 |
| lifeless | jlvillal: what sort of tests do you want to be able to write? End to end stuff, or just 'the service is running as a service and we talk to it over a socket' or .... | 20:31 |
| mtreinish | jlvillal, lifeless: the nova testing spins up services as needed on demand, like for api testing it has a fixture to setup a db and the api service itself | 20:31 |
| jlvillal | lifeless: Pretty much as stand-alone as possible. No other services running. We have integration tests already. | 20:31 |
| lifeless | jlvillal: if you're using mimic, its almost by definition not a functional test :) | 20:31 |
| *** achanda has joined #openstack-ironic | 20:31 | |
| jlvillal | So I envision functional testing as being between unit tests and integration tests. | 20:31 |
| jlvillal | lifeless: Well mimic could mimic nova, keystone, etc... | 20:32 |
| mtreinish | jlvillal: then yeah the nova functional tests are what you'll want to look at | 20:32 |
| lifeless | mtreinish: yeah, I like that model - we did that in LP, brings up a whole cluster just with Fixture objects | 20:32 |
| lifeless | mtreinish: are they using testresources to optimise stuff, or class setup (eek) or ? | 20:32 |
| jlvillal | lifeless: mtreinish: Speaking of which. How do you define functional tests? There seem to be multiple opinions out there. | 20:33 |
| lifeless | jlvillal: oh gosh, there are soooo many definitions | 20:33 |
| jlvillal | That isn't helping! ;) | 20:33 |
| lifeless | jlvillal: so Google define tests by the covered code | 20:33 |
| lifeless | jlvillal: small, medium, large | 20:33 |
| jlvillal | I was hoping there was an 'OpenStack' definition. | 20:33 |
| jlvillal | I read things and functional tests sound like unit tests. Functional tests test functions was one definition I read in a book. | 20:34 |
| lifeless | jlvillal: I'll defer to mtreinish - my sense is that we don't have a concrete hard line... | 20:34 |
| mtreinish | jlvillal: there isn't an openstack definition, when I use it I mean basically what you did | 20:34 |
| jlvillal | mtreinish: Service runs as stand-alone as possible? | 20:34 |
| lifeless | jlvillal: to me, a functional test is essentially a test that is dependent on global state and/or side effects | 20:34 |
| mtreinish | yeah | 20:34 |
| jlvillal | In between unit testing and integration. | 20:34 |
| mtreinish | and a tighter coupling to the code under test | 20:34 |
| lifeless | jlvillal: so the service could be in-process, or a separate process, its still suffers that downside | 20:35 |
| mtreinish | like the nova api tests inspect the db to see things are in the right state after a call | 20:35 |
| jlvillal | krtaylor: lekha ^^^^^ | 20:35 |
| * lekha reads scrollback | 20:35 | |
| jlvillal | mtreinish: lifeless: Thanks. good to know we are not off-track. | 20:35 |
| lifeless | tests that rely on mock.patch are functional tests too IMO :) | 20:35 |
| mtreinish | lifeless: as for your question, I don't actually remember the specifics of how it was implemented | 20:36 |
| mtreinish | I'm pretty sure it's not testresources though | 20:36 |
| jlvillal | mtreinish: So any docs or other resources on how to setup functional testing ala nova? | 20:36 |
| lifeless | but that is truely a different discussion, today is not the day to shift the dial on *that* | 20:36 |
| mtreinish | jlvillal: err, I'm not sure, I'd have to check the nova repo | 20:36 |
| mtreinish | jlvillal: but you can always ask sdague, he did most of that work | 20:36 |
| jlvillal | mtreinish: Okay. I've been reading the code. One file leads to another file... :) Yak-shaving! :) | 20:36 |
| lifeless | mmm yaks | 20:36 |
| jlvillal | mtreinish: Thanks. I might ping sdague. | 20:37 |
| lifeless | ok, its time for me to finish up this testr feature work... ping me if you need me, I'm going nose-to-grindstone | 20:37 |
| jlvillal | lifeless: Thanks. No reply yet to my email. | 20:37 |
| lifeless | cheers | 20:38 |
| *** achanda has quit IRC | 20:38 | |
| *** mikal_ is now known as mikal | 20:39 | |
| *** alexpilotti has joined #openstack-ironic | 20:43 | |
| lekha | jlvillal: so the functional tests are different from the tempest tests as they validate the db and mock identity, glance and such | 20:44 |
| jlvillal | lekha: Okay. | 20:44 |
| lekha | jlvillal: sorry, I meant that as a question for clarification | 20:45 |
| jlvillal | Ah. | 20:45 |
| jlvillal | lekha: I think so. Be interested to get mtreinish input too. But functional I think should be as isolated as we can make it from other OpenStack services. | 20:45 |
| jroll | jlvillal: re: log message breakage stuff. that indicates to me a failure to test the code path. not the log message itself. | 20:46 |
| jlvillal | jroll: Well the log message it self is what fails. | 20:46 |
| jlvillal | jroll: https://review.openstack.org/231140 | 20:47 |
| mtreinish | jlvillal: yeah, I would imagine it being as isolated as possible | 20:47 |
| jroll | jlvillal: the log.debug call raises an exception. which means we aren't running that code in unit tests | 20:47 |
| jroll | rloo: I like the idea of keeping history or whatever, but I don't mind if you spin a new spec/bp | 20:47 |
| jlvillal | jroll: I didn't look at the details. I thought they had just mocked log.debug. So it would have worked. | 20:48 |
| *** achanda has joined #openstack-ironic | 20:48 | |
| jroll | jlvillal: we almost never mock log.* | 20:48 |
| rloo | jroll: if i keep history, i have to keep the bp/title as 'implement-zapping-states' :-( I want to eradicate 'zap'. | 20:48 |
| jroll | rloo: yeah, do whatever works for you | 20:48 |
| jroll | rloo: I care more about the results :) | 20:48 |
| rloo | jroll: I am pointing a pointer in the spec, to the zap-spec-review. | 20:48 |
| jroll | ++ | 20:48 |
| rloo | jroll: well, i want to do it so it works with our "process" ;) | 20:49 |
| lekha | jlvillal:mtreinish: hmm, I am curious to know if the tempest tests were run against something like Mimic i.e. by mocking the services it relies on, how different it would be from the functional tests (other the db validations) | 20:49 |
| jroll | rloo: I hold shipping code above any and all process :) | 20:49 |
| rloo | jroll: heh. so the first thing as PTL, jroll promises to get rid of specs all together. and the crowd CHEERS! :D | 20:50 |
| *** alexpilotti has quit IRC | 20:50 | |
| jroll | oh god | 20:50 |
| rloo | in case anyone takes that out of context, I WAS JOKING | 20:50 |
| jroll | rloo: we also have to remotely know what features we're shipping :D | 20:50 |
| mtreinish | lekha: isn't mimic an openstack api mock? so what would you be trying to test by running tempest against a fake openstack? | 20:51 |
| *** [1]cdearborn has quit IRC | 20:52 | |
| *** xek has quit IRC | 20:52 | |
| *** persia has quit IRC | 20:53 | |
| lekha | mtreinish: we would deploy and run ironic with its config pointing to mimic for identity and other services; and have the tempest tests run against the deployed ironic and mimic for other openstack services | 20:54 |
| *** persia has joined #openstack-ironic | 20:54 | |
| *** persia has quit IRC | 20:54 | |
| *** persia has joined #openstack-ironic | 20:54 | |
| mtreinish | lekha: well 2 things the ironic api itself isn't really validated that much by tempest, most of the testing from tempest comes by using ironic as a nova driver | 20:56 |
| mtreinish | the other is I'm not sure what that really buys you, because the point of functional testing is just to isolate the deployment story | 20:56 |
| mtreinish | but to actually do deeper validation of things working correctly | 20:56 |
| mtreinish | and just mocking where ironic calls things over the wire might be part of that, but it's not the biggest part of it | 20:57 |
| mtreinish | and tempest is only ever going to hit the api service from outside | 20:57 |
| jlvillal | jroll: I added a "raise ValueError()" after the log message and my unit tests fail. So it seems like that code path is being exercised. But the call to log.debug does not cause an error. Reading the bug to figure out more details. | 20:59 |
| jroll | jlvillal: wat, well then. | 21:00 |
| jroll | jlvillal: rloo you said I should release ironic-lib ya? | 21:00 |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 21:00 |
| rloo | jroll: yup | 21:00 |
| jlvillal | +1 from me on ironic-lib release | 21:00 |
| *** achanda has quit IRC | 21:00 | |
| jroll | thanks | 21:00 |
| * jroll does it | 21:00 | |
| lekha | mtrenish: ok, I am new to tempest and OpenStack in general but I am thinking that the baremetal admin api tests in tempest are validating all the api calls | 21:01 |
| openstackgerrit | Sinval Vieira Mendes Neto proposed openstack/python-oneviewclient: Refactoring python-oneviewclient to use domain models of OneView as objects https://review.openstack.org/230988 | 21:02 |
| mtreinish | lekha: some of them, but it's very limited in what it does | 21:02 |
| jroll | ironic-lib 0.3.0: https://review.openstack.org/#/c/231185/ | 21:02 |
| jroll | mtreinish: lekha: one of the big goals of this functional testing is to fix the bug where many api calls aren't tested | 21:02 |
| *** Sukhdev has joined #openstack-ironic | 21:03 | |
| lekha | mtrenish: I see us having to duplicate all the api call testing in the functional tests, the only difference being everything will be run against mocks. So, I am wondering why not expand what we have in tempest and have that run against Mimic | 21:04 |
| *** penick has quit IRC | 21:04 | |
| jroll | lekha: so I think I said this before, but | 21:05 |
| lekha | mtreinish: And running against Mimic gives us the option to 1. run tests way faster than running anything over the wire, 2. not have to setup devstack 3. the ability to test negative scenarios like a server going into error | 21:05 |
| *** achanda has joined #openstack-ironic | 21:05 | |
| *** alexpilotti has joined #openstack-ironic | 21:05 | |
| jroll | lekha: IMO the best thing to do is 1) write functional tests in the ironic tree using tempest-lib; 2) remove our tests from tempest repo; 3) allow running those tests in both a devstack environment and a mimic environment | 21:06 |
| mtreinish | fwiw, tempest doesn't care what the server is it's talking against as long as it exposes the right apis | 21:07 |
| lekha | mtreinish: while I say that I understand what is currently in tempest will not cover everything for functional tests and will need to be worked on more. For eg the db testing | 21:07 |
| mtreinish | if mimic is good enough for that then that's fine | 21:07 |
| mtreinish | I just don't think that's the right solution for functional testing | 21:07 |
| mtreinish | because you're coming at it from a top down approach and concentrating on de-duplicating effort | 21:08 |
| mtreinish | rather than actually figuring out the best way to test things and construct things to do that | 21:08 |
| *** trown is now known as trown|outttypeww | 21:08 | |
| lekha | mtreinish: ok, how about we look at this only from the api testing part of the functional tests | 21:08 |
| lekha | jroll: sounds good to me | 21:08 |
| *** zigo has quit IRC | 21:09 | |
| lekha | jlvillal: krtaylor : what are your thoughts | 21:09 |
| *** zigo has joined #openstack-ironic | 21:10 | |
| *** alexpilotti has quit IRC | 21:10 | |
| jlvillal | lekha: I myself would defer to mtreinish. Since he knows much more about the testing than I do. I don't think I know enough to make an informed decision. | 21:11 |
| * jlvillal wants to learn and be able to make an informed decision. | 21:12 | |
| lekha | jlvillal: fair enough :) | 21:12 |
| jlvillal | lekha: I'm trying to learn about fixtures. It is new for me. | 21:15 |
| jlvillal | https://pypi.python.org/pypi/fixtures | 21:15 |
| lekha | jlvillal: ha, not something I have used in the past either | 21:16 |
| jlvillal | jroll: I think maybe I understand why no error. We use the FakeLogger fixture in the code. So the log messages probably just go to /dev/null. | 21:17 |
| jlvillal | ironic/tests/unit/base.py | 21:17 |
| jlvillal | By code I mean the unit test code. | 21:17 |
| jroll | jlvillal: still don't know why that wouldn't error out but hey | 21:17 |
| jlvillal | lifeless: Do you know how the FakeLogger works? | 21:18 |
| * jlvillal thinks so since he wrote the code :) | 21:18 | |
| *** mrda has joined #openstack-ironic | 21:18 | |
| mrda | Morning Ironic | 21:18 |
| jlvillal | mrda: Morning | 21:18 |
| mrda | hey jlvillal | 21:19 |
| NobodyCam | morning mrda :) | 21:20 |
| mrda | hey NobodyCam | 21:21 |
| thiagop | morning mrda | 21:21 |
| mrda | hi thiagop | 21:21 |
| *** priteau has quit IRC | 21:22 | |
| *** Marga__ has joined #openstack-ironic | 21:23 | |
| *** Marga__ has quit IRC | 21:24 | |
| *** Marga__ has joined #openstack-ironic | 21:24 | |
| lifeless | jlvillal: probably | 21:24 |
| lifeless | jlvillal: whatsup ? | 21:24 |
| jlvillal | We had an issue where a bad call to log.debug() does not raise an exception during unit testing | 21:25 |
| jlvillal | But does in productions | 21:25 |
| lifeless | jlvillal: which one ? | 21:25 |
| jlvillal | lifeless: Patch to fix: https://review.openstack.org/#/c/231140/ Extra comma | 21:25 |
| jlvillal | lifeless: Bug report: https://bugs.launchpad.net/ironic/+bug/1503008 | 21:26 |
| openstack | Launchpad bug 1503008 in Ironic "TypeError: format requires a mapping (agent_base_vendor.py)" [High,In progress] - Assigned to Dan Prince (dan-prince) | 21:26 |
| *** alexpilotti has joined #openstack-ironic | 21:26 | |
| jlvillal | lifeless: It would be nice if we catched those things with unit tests | 21:26 |
| lifeless | so FakeLogger still renders | 21:26 |
| *** Marga_ has quit IRC | 21:26 | |
| *** marzif has joined #openstack-ironic | 21:26 | |
| lifeless | it should be catching it | 21:26 |
| jlvillal | lifeless: The code path is exercised as I put a 'raise ValueError()' on the line below the log and that failed my unit tests. | 21:26 |
| jlvillal | So call me confused. | 21:27 |
| lifeless | jlvillal: what is a test that failed when you did that? | 21:27 |
| jlvillal | lifeless: one moment | 21:27 |
| jlvillal | lifeless: Four tests failed. This is one: ironic.tests.unit.drivers.modules.test_agent_base_vendor.TestBaseAgentVendor.test_configure_local_boot_set_boot_device_fail | 21:28 |
| *** marzif has quit IRC | 21:29 | |
| jlvillal | lifeless: http://paste.openstack.org/show/475376/ | 21:29 |
| *** marzif has joined #openstack-ironic | 21:29 | |
| *** alexpilotti has quit IRC | 21:30 | |
| lifeless | thought so | 21:36 |
| lifeless | jlvillal: http://paste.openstack.org/show/475378/ | 21:36 |
| thiagop | Folks, I'm calling it a day | 21:36 |
| lifeless | jlvillal: the logging module hides errors formatting exceptions | 21:36 |
| thiagop | see you tomorrow | 21:36 |
| * jlvillal looks | 21:36 | |
| *** thiagop has quit IRC | 21:36 | |
| jlvillal | lifeless: That doesn't seem good for our unit testing :( | 21:36 |
| lifeless | jlvillal: see how when I put a try/except around the bad thing that my except clause doesn't run at all | 21:37 |
| lifeless | jlvillal: well, its a thing about logging that is - I don't like it myself, but it is what it is | 21:37 |
| lifeless | jlvillal: the good thing is that it won't break in production either... it will fail to log, but not interrupt actual code | 21:37 |
| lifeless | [or thats the theory behind it] | 21:37 |
| jlvillal | lifeless: Okay. Yeah, I'm not happy about it. But good to know it won't break production code. | 21:38 |
| jlvillal | lifeless: Thanks for your help! | 21:38 |
| lifeless | jlvillal: so what we could do in principle | 21:38 |
| lifeless | jlvillal: is have FakeLogger (or perhaps a related thing) hook into that bit and make it into errors | 21:38 |
| jlvillal | lifeless: That would be useful, IMHO. | 21:39 |
| lifeless | jlvillal: you might start by filing a wishlist bug on pad.lv/p/python-fixtures | 21:39 |
| jlvillal | lifeless: Will do | 21:39 |
| lifeless | jlvillal: if someone wanted to get a POC together I could review and get that landed and in a release pronto | 21:39 |
| jlvillal | lifeless: Okay. I've never looked at the code, so not sure how long it would take if I worked on it. | 21:40 |
| lifeless | jlvillal: FakeLogger is tiny - https://github.com/testing-cabal/fixtures/blob/master/fixtures/_fixtures/logger.py#L97 | 21:41 |
| jlvillal | lifeless: Any hints on how to make it detect that the logging module has done an exception? | 21:42 |
| *** penick has joined #openstack-ironic | 21:42 | |
| jlvillal | lifeless: https://bugs.launchpad.net/python-fixtures/+bug/1503049 | 21:43 |
| openstack | Launchpad bug 1503049 in Python Fixtures "Have FakeLogger detect bad calls to logger" [Undecided,New] | 21:43 |
| *** baoli has joined #openstack-ironic | 21:43 | |
| lifeless | https://docs.python.org/2/library/logging.html#logging.Formatter.format | 21:45 |
| *** alexpilotti has joined #openstack-ironic | 21:46 | |
| *** vrl has quit IRC | 21:46 | |
| jlvillal | lifeless: yeah. handleError... | 21:46 |
| jlvillal | lifeless: Also raiseExceptions module level attribute. | 21:47 |
| openstackgerrit | Merged openstack/bifrost: Make pip installs work as intended https://review.openstack.org/228022 | 21:49 |
| *** alexpilotti has quit IRC | 21:50 | |
| *** e0ne has quit IRC | 21:51 | |
| lifeless | jlvillal: no, thats a different layer in the glue :/ | 21:52 |
| lifeless | jlvillal: I mean, yes, this thing bubbles up to emit | 21:52 |
| jlvillal | lifeless: I was starting to figure that out... Still looking. | 21:53 |
| lifeless | jlvillal: but even with raiseExceptions true, callers don't see the error | 21:53 |
| jlvillal | lifeless: Yeah. I discovered when you set it to False nothing gets printed at all. | 21:53 |
| jlvillal | lifeless: Going to explore the handler. | 21:53 |
| *** e0ne has joined #openstack-ironic | 21:54 | |
| lifeless | jlvillal: I've put some notes in the bug | 21:55 |
| jlvillal | lifeless: Thanks | 21:55 |
| *** Marga__ has quit IRC | 21:58 | |
| *** harlowja has quit IRC | 21:59 | |
| *** Marga_ has joined #openstack-ironic | 21:59 | |
| *** penick has quit IRC | 21:59 | |
| openstackgerrit | Merged openstack/bifrost: Initial support to collect node facts like UUID https://review.openstack.org/228179 | 21:59 |
| *** thrash is now known as thrash|g0ne | 22:00 | |
| *** Marga__ has joined #openstack-ironic | 22:00 | |
| *** Marga_ has quit IRC | 22:01 | |
| *** e0ne has quit IRC | 22:01 | |
| openstackgerrit | Merged openstack/bifrost: Make use of host fact collection for name based inventories https://review.openstack.org/228180 | 22:02 |
| lifeless | jlvillal: ok, I'm going head down again | 22:02 |
| jlvillal | lifeless: Thank you much | 22:02 |
| lifeless | jlvillal: if you put something together or want a hand or whatnot, just ping | 22:02 |
| jlvillal | lifeless: Will do! | 22:02 |
| lifeless | (fixtures code is on github, just a PR there is the way to submit) | 22:03 |
| *** penick has joined #openstack-ironic | 22:03 | |
| *** marzif has quit IRC | 22:04 | |
| *** chlong has joined #openstack-ironic | 22:10 | |
| *** achanda has quit IRC | 22:14 | |
| *** openstackgerrit has quit IRC | 22:16 | |
| *** rcarrillocruz has quit IRC | 22:17 | |
| *** openstackgerrit has joined #openstack-ironic | 22:17 | |
| *** achanda has joined #openstack-ironic | 22:18 | |
| jlvillal | Anyone else have any issues bringing in os-testr >=0.4.1 when doing tox? Maybe it is just me and my devpi server | 22:18 |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Remove excess fact data from being returned to Ansible https://review.openstack.org/228181 | 22:18 |
| *** rcarrillocruz has joined #openstack-ironic | 22:20 | |
| *** Sukhdev has quit IRC | 22:22 | |
| *** tsekiyama has quit IRC | 22:23 | |
| *** Sukhdev has joined #openstack-ironic | 22:23 | |
| *** baoli has quit IRC | 22:25 | |
| *** tsekiyama has joined #openstack-ironic | 22:25 | |
| jroll | JayF: would you be interested in taking over https://review.openstack.org/#/c/191505/ | 22:26 |
| jroll | or jvmario ^ | 22:26 |
| devananda | jroll: so we had a unit test that asserted that, if driver.boot was None, nothing would call PXEBoot.clean_up_ramdisk -- and there was an explicit if: statement to make that happen | 22:27 |
| devananda | *make that not get called | 22:27 |
| devananda | so now i'm wondering what out of tree driver might be impacted by my fix | 22:27 |
| jroll | devananda: lemme guess, driver.boot.__cls__ == 'mock.Mock' | 22:27 |
| jroll | oh | 22:28 |
| jroll | devananda: pointer to that test? | 22:28 |
| devananda | jroll: https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/test_agent.py#L527 | 22:30 |
| jvmario | jroll: sure, i don't mind | 22:30 |
| jroll | <3 | 22:30 |
| devananda | and https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L429 | 22:31 |
| jroll | devananda: how is this broken, then? | 22:31 |
| *** jamielennox|away is now known as jamielennox | 22:31 | |
| devananda | added as a fix for https://bugs.launchpad.net/ironic/+bug/1491704 | 22:32 |
| openstack | Launchpad bug 1491704 in Ironic "agent_ilo fails to bring up the instance" [High,Fix released] - Assigned to Nisha Agarwal (agarwalnisha1980) | 22:32 |
| jroll | devananda: oh, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L281 | 22:33 |
| jroll | FUN | 22:33 |
| devananda | yah | 22:34 |
| devananda | jroll: just search there for "driver.boot" | 22:34 |
| devananda | anyhow, I have a fix, about to push it | 22:34 |
| jroll | cool, ty | 22:34 |
| jroll | that's gonna make for another backport eh :( | 22:35 |
| *** achanda has quit IRC | 22:35 | |
| *** alexpilotti has joined #openstack-ironic | 22:35 | |
| *** alexpilotti has quit IRC | 22:40 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Fix AgentDeploy compatibility with pre-Liberty drivers https://review.openstack.org/231215 | 22:40 |
| devananda | jroll: for stable/liberty - yah | 22:41 |
| jroll | yeah | 22:41 |
| * jroll WIP's 4.2.1 release patch | 22:41 | |
| devananda | i already tagged the bug as liberty-backport-potential | 22:41 |
| jroll | thanks | 22:41 |
| jlvillal | lifeless: As an FYI, the tox tests are failing for me with a clean checkout of fixtures. Have you seen any issues? | 22:42 |
| lifeless | jlvillal: huh, hadn't at the last release, presumably an ecosystem change | 22:43 |
| *** praneshp has quit IRC | 22:43 | |
| lifeless | jlvillal: FAIL: README | 22:44 |
| lifeless | for instance? | 22:44 |
| jlvillal | lifeless: What I am seeing: http://paste.openstack.org/show/475380/ | 22:44 |
| lifeless | yeah, same | 22:44 |
| jlvillal | lifeless: But I did figure out a way to patch fixtures to raise the exception. I was working on adding unit tests and .... | 22:45 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: Adds more functional tests for commands https://review.openstack.org/224247 | 22:45 |
| lifeless | I'll poke later today. ignore them, they are not related to the logging fixture | 22:45 |
| jlvillal | lifeless: pretty simple. Just add a class derived from StreamHandler() and define handleError to just raise the error from sys.exc_info() | 22:45 |
| *** praneshp has joined #openstack-ironic | 22:46 | |
| lifeless | cool | 22:47 |
| *** jobewan has joined #openstack-ironic | 22:48 | |
| *** harlowja has joined #openstack-ironic | 22:48 | |
| *** dims__ has joined #openstack-ironic | 22:49 | |
| *** dims__ has quit IRC | 22:49 | |
| jroll | devananda: yeah, I think that's going to break things, specifically things that inherit from AgentDeploy | 22:50 |
| devananda | jroll: only if those things don't instantiate a boot interface | 22:52 |
| jroll | devananda: like the liberty iLO driver :( | 22:52 |
| devananda | my goal here was to only affect a DriverClass that sets driver.deploy == AgentDeploy but does not set any driver.boot | 22:52 |
| devananda | urgh | 22:52 |
| jroll | yeah, this one is tough :/ | 22:53 |
| devananda | damn. yea. | 22:53 |
| *** dims_ has quit IRC | 22:53 | |
| devananda | why doesn't that show up in unit tests? | 22:53 |
| *** aswadr has quit IRC | 22:54 | |
| *** willsama has quit IRC | 22:54 | |
| jroll | idk | 22:54 |
| jroll | it might be testing the wrong thing | 22:54 |
| jroll | assert_called_once_with, would that fail if there were two calls? | 22:54 |
| jroll | thinking if this, for instance, rebooted it twice | 22:55 |
| devananda | yes | 22:55 |
| devananda | it would fail | 22:55 |
| devananda | assertTrue(thing.called) would pass, however | 22:55 |
| *** alexpilotti has joined #openstack-ironic | 22:56 | |
| jroll | right | 22:56 |
| jroll | this could just be theoretical | 22:56 |
| jroll | for example, I think this call would be fine https://github.com/openstack/ironic/blob/stable/liberty/ironic/drivers/modules/ilo/deploy.py#L652 | 22:56 |
| jroll | I'm curious how this worked without a boot interface https://github.com/openstack/ironic/blob/stable/liberty/ironic/drivers/modules/ilo/deploy.py#L718 | 22:58 |
| devananda | jroll: ilo does not actually inherit from AgentDeploy | 22:58 |
| jroll | oh, neat | 22:58 |
| jlvillal | lifeless: pull request sent | 22:58 |
| devananda | it imports agent.py and calls several helper functions, and there's IloVirtualMediaAgentVendorInterface(agent.AgentVendorInterface) | 22:58 |
| jroll | does inherit from AgentVendorInterface though | 22:58 |
| jroll | yeqah | 22:58 |
| devananda | right | 22:58 |
| jroll | I don't see how that works at all though | 22:58 |
| jroll | oh, it just doesn't clean up | 22:59 |
| jroll | so suddenly it will clean up; that might be ok | 22:59 |
| *** alexpilotti has quit IRC | 23:00 | |
| jlvillal | lifeless: On the bad news front. It doesn't catch the error in Ironic :( | 23:02 |
| *** david-ly_ has joined #openstack-ironic | 23:04 | |
| *** david-lyle has quit IRC | 23:04 | |
| jobewan | can someone give me an example of ahc-match using regex? | 23:06 |
| jroll | ahc-match? | 23:07 |
| *** baoli has joined #openstack-ironic | 23:12 | |
| jlvillal | jobewan: What do you mean? | 23:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/231228 | 23:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/231229 | 23:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/231230 | 23:14 |
| openstackgerrit | Merged openstack/bifrost: CORS configuration support https://review.openstack.org/223589 | 23:14 |
| *** penick has quit IRC | 23:15 | |
| openstackgerrit | Merged openstack/bifrost: Wrap configuration playbook to multi-line format https://review.openstack.org/228266 | 23:15 |
| Sukhdev | jroll: Ping | 23:15 |
| jroll | hi | 23:15 |
| Sukhdev | I have paste for you with n-cpu logs when I issue nova delete of BM instance - please see here - http://paste.openstack.org/show/475382/ | 23:16 |
| Sukhdev | jroll: the instance gets deleted correctly, but, the neutron port does not get deleted - | 23:17 |
| *** dims_ has joined #openstack-ironic | 23:17 | |
| jobewan | I don't have "total", in my node facts: ie: ('memory', 'total','size','ge(64000000000)') . So... I'm trying to identify via ('memory', 'regexp(bank:?:0)', 'size', '34358689792') | 23:17 |
| jobewan | err, sorry regexp(bank:.:0) | 23:18 |
| jroll | jobewan: is this an ironic question or some other tool? I've never seen syntax like that | 23:19 |
| jroll | Sukhdev: so it says it's deallocating the network, then querying for device_id=b22221d0-568c-4981-9edf-62680ec3ae23 | 23:19 |
| jroll | Sukhdev: so maybe device_id changed or was not set? | 23:19 |
| jobewan | It's ahc-tools, but it uses ironic discovery data to classify nodes based on rules. I figured someone here may have dealt w/ this, but I can check somewhere else. Here is the doc: http://docs.openstack.org/developer/tripleo-docs/advanced_deployment/profile_matching.html | 23:21 |
| jroll | ah | 23:22 |
| jroll | jobewan: trown|outttypeww and dtantsur|afk would know more, but they both seem to be afk, I'd send an email or file a bug or something? | 23:22 |
| jroll | or try #tripleo | 23:22 |
| jobewan | sounds good man, thanks! | 23:22 |
| *** jobewan has quit IRC | 23:23 | |
| *** tsekiyama has quit IRC | 23:23 | |
| Sukhdev | jroll: I think this explains - I think lazy_prince sets the device_id as the node_id | 23:24 |
| *** penick has joined #openstack-ironic | 23:25 | |
| jroll | Sukhdev: ah | 23:25 |
| Sukhdev | jroll: look at line 256 - https://review.openstack.org/#/c/139687/27/ironic/networks/neutron_plugin.py | 23:28 |
| Sukhdev | jroll: I think this may be causing the issue | 23:29 |
| jroll | Sukhdev: that's host_id not device_id | 23:29 |
| jroll | device_id should be the instance ID | 23:29 |
| * jroll checks nova code | 23:29 | |
| Sukhdev | jroll: I meant to say line 255 - device_id is set to node.uuid | 23:32 |
| jroll | Sukhdev: oops, you're right | 23:33 |
| jroll | yeah that should be removed | 23:33 |
| *** tsekiyama has joined #openstack-ironic | 23:34 | |
| *** alexpilotti has joined #openstack-ironic | 23:35 | |
| *** achanda has joined #openstack-ironic | 23:36 | |
| openstackgerrit | Merged openstack/bifrost: Remove excess fact data from being returned to Ansible https://review.openstack.org/228181 | 23:36 |
| *** alexpilotti has quit IRC | 23:40 | |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Dynamically reconfiguring resources https://review.openstack.org/228571 | 23:42 |
| krotscheck | moar covearagegegege | 23:43 |
| Sukhdev | jroll: correct - let me play with a bit and see what comes up | 23:43 |
| *** achanda has quit IRC | 23:43 | |
| krotscheck | one of the webclient libs how has 100% coverage :D | 23:43 |
| krotscheck | And with that I'm out. | 23:48 |
| jlvillal | krotscheck: Nice. And good night. | 23:49 |
| *** dims_ has quit IRC | 23:50 | |
| *** mgoddard_ has joined #openstack-ironic | 23:51 | |
| *** mgoddard has quit IRC | 23:52 | |
| *** mgoddard__ has joined #openstack-ironic | 23:52 | |
| *** lucas-dinner has quit IRC | 23:52 | |
| *** alexpilotti has joined #openstack-ironic | 23:55 | |
| *** baoli has quit IRC | 23:55 | |
| *** mgoddard_ has quit IRC | 23:56 | |
| lifeless | jlvillal: gnurgle | 23:57 |
| openstackgerrit | Merged openstack/ironic-webclient: Add note about nodejs-legacy to README https://review.openstack.org/230691 | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!