Monday, 2015-09-28

*** naohirot has joined #openstack-ironic00:06
*** Marga_ has joined #openstack-ironic00:10
*** achanda has quit IRC00:12
*** Marga_ has quit IRC00:15
*** Sukhdev has joined #openstack-ironic00:21
*** shadower has quit IRC00:23
*** shadower has joined #openstack-ironic00:23
*** ijw has quit IRC00:28
*** ijw has joined #openstack-ironic00:45
*** ijw has quit IRC00:49
*** ijw has joined #openstack-ironic00:50
*** alexpilotti has quit IRC00:59
*** Sukhdev has quit IRC01:03
*** david-lyle has joined #openstack-ironic01:03
*** Marga_ has joined #openstack-ironic01:11
*** achanda has joined #openstack-ironic01:13
*** Marga_ has quit IRC01:16
*** Sukhdev has joined #openstack-ironic01:17
*** Sukhdev has quit IRC01:21
*** rameshg87 has joined #openstack-ironic01:21
*** Sukhdev has joined #openstack-ironic01:23
*** Sukhdev has quit IRC01:24
*** Sukhdev has joined #openstack-ironic01:25
*** Sukhdev has quit IRC01:26
*** dims_ has quit IRC01:28
*** baoli has joined #openstack-ironic01:29
*** Sukhdev has joined #openstack-ironic01:30
*** cinerama` has joined #openstack-ironic01:34
*** Sukhdev has quit IRC01:35
*** lintan_ has joined #openstack-ironic01:35
*** NobodyCa1 has joined #openstack-ironic01:37
*** Sukhdev has joined #openstack-ironic01:37
*** cinerama has quit IRC01:38
*** baoli has quit IRC01:38
*** lintan has quit IRC01:38
*** NobodyCam has quit IRC01:38
*** [1]cdearborn has quit IRC01:39
*** dimsum__ has joined #openstack-ironic01:40
openstackgerritMerged openstack/ironic-inspector: Add a warning about sudoers file  https://review.openstack.org/22793501:43
*** Sukhdev has quit IRC01:51
*** Haomeng has quit IRC01:52
*** Sukhdev has joined #openstack-ironic01:53
*** Marga_ has joined #openstack-ironic01:54
*** Marga_ has quit IRC01:57
*** Marga_ has joined #openstack-ironic01:57
*** penick has joined #openstack-ironic02:06
*** penick has quit IRC02:07
*** Sukhdev has quit IRC02:29
*** dimsum__ has quit IRC02:48
*** karimb has quit IRC02:50
*** dimsum__ has joined #openstack-ironic03:09
*** dims_ has joined #openstack-ironic03:10
*** bnemec has quit IRC03:12
*** Sukhdev has joined #openstack-ironic03:14
*** dimsum__ has quit IRC03:14
*** baoli has joined #openstack-ironic03:16
*** dimsum__ has joined #openstack-ironic03:25
*** dimsum__ has quit IRC03:27
*** dims_ has quit IRC03:28
*** achanda has quit IRC03:32
*** achanda has joined #openstack-ironic03:33
*** baoli has quit IRC03:39
*** achanda has quit IRC03:41
*** Nisha has joined #openstack-ironic03:45
*** praneshp has joined #openstack-ironic03:53
*** VikasC has joined #openstack-ironic04:10
*** amotoki has joined #openstack-ironic04:27
*** dimsum__ has joined #openstack-ironic04:27
*** ijw has quit IRC04:33
*** dimsum__ has quit IRC04:34
*** persia has quit IRC04:39
*** persia has joined #openstack-ironic04:40
*** mdbooth has quit IRC04:44
*** mdbooth has joined #openstack-ironic04:49
*** pradipta has joined #openstack-ironic04:57
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes operation  for multi-nodes-operations  https://review.openstack.org/22830104:58
*** toabctl has quit IRC05:01
*** toabctl has joined #openstack-ironic05:04
*** achanda has joined #openstack-ironic05:12
*** praneshp_ has joined #openstack-ironic05:34
*** praneshp has quit IRC05:37
*** praneshp_ is now known as praneshp05:37
*** deray has joined #openstack-ironic05:46
*** Marga_ has quit IRC05:49
*** Marga_ has joined #openstack-ironic05:52
*** boris-42 has joined #openstack-ironic05:56
*** ijw has joined #openstack-ironic06:00
*** lazy_prince has joined #openstack-ironic06:05
*** vinbs has joined #openstack-ironic06:09
*** chenke has joined #openstack-ironic06:09
*** chenke has left #openstack-ironic06:10
*** marzif has joined #openstack-ironic06:19
*** ijw_ has joined #openstack-ironic06:30
*** dimsum__ has joined #openstack-ironic06:31
*** ijw has quit IRC06:32
*** dimsum__ has quit IRC06:36
*** ukalifon1 has joined #openstack-ironic06:38
*** marzif has quit IRC06:39
openstackgerritYuiko Takada proposed openstack/ironic-inspector: Support IPA for devstack-plugin  https://review.openstack.org/22356306:46
*** e0ne has joined #openstack-ironic06:49
*** yuikotakada has joined #openstack-ironic06:52
yuikotakadagood morning, Ironic06:52
*** itsuugo has joined #openstack-ironic06:56
*** achanda has quit IRC06:56
*** deray has quit IRC06:57
*** e0ne has quit IRC06:59
*** deray has joined #openstack-ironic06:59
*** achanda has joined #openstack-ironic06:59
*** ifarkas has joined #openstack-ironic07:00
*** Sukhdev has quit IRC07:01
*** achanda has quit IRC07:02
*** e0ne has joined #openstack-ironic07:03
*** e0ne has quit IRC07:05
*** ijw_ has quit IRC07:07
*** e0ne has joined #openstack-ironic07:09
*** pradipta has quit IRC07:09
*** ukalifon1 has quit IRC07:11
openstackgerritNisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy  https://review.openstack.org/22802007:13
*** benhur_marcel has quit IRC07:13
*** yog_ has joined #openstack-ironic07:15
*** itsuugo has quit IRC07:16
*** praneshp has quit IRC07:16
*** praneshp has joined #openstack-ironic07:16
*** itsuugo has joined #openstack-ironic07:17
*** chlong has quit IRC07:17
*** mbound has joined #openstack-ironic07:20
*** dtantsur|afk is now known as dtantsur07:20
dtantsurMorning Ironic, hi yuikotakada07:20
yuikotakadadtantsur, hi :)07:20
*** ijw has joined #openstack-ironic07:31
*** MattMan has joined #openstack-ironic07:45
*** chenke has joined #openstack-ironic07:50
*** jamielennox is now known as jamielennox|away07:50
*** MattMan is now known as MattManHome07:51
*** MattManHome has quit IRC07:53
*** e0ne has quit IRC07:57
*** romainh has joined #openstack-ironic07:57
*** MattManHome has joined #openstack-ironic07:58
chenkedoes openstack allow a tenant member to boot a baremetal node?07:59
*** praneshp has quit IRC07:59
*** e0ne has joined #openstack-ironic08:01
dtantsurchenke, I think it depends on Nova, no? Nova rules must be the same for virtual and baremetal instances08:01
chenkedtantsur, could you tell which part of nova control it, i want to check it08:04
betherlygood morning ironic :)08:05
*** athomas has joined #openstack-ironic08:11
*** derekh has joined #openstack-ironic08:12
*** derekh has quit IRC08:12
*** mgoddard has joined #openstack-ironic08:12
openstackgerritYuiko Takada proposed openstack/ironic-inspector: Support IPA for devstack-plugin  https://review.openstack.org/22356308:12
*** derekh has joined #openstack-ironic08:13
*** mrmoje has joined #openstack-ironic08:23
rameshg87dtantsur: hi, what's the next step for ironic-lib ?08:23
rameshg87dtantsur: are we waiting to enable gate jobs to start using ironic-lib ?08:23
dtantsurchenke, I'm not sure about nova access control, sorry. you may ask on #openstack-nova though08:23
dtantsurrameshg87, so, as we have ironic-lib dsvm gate working now, we can just start to switch :)08:23
dtantsurI don't have time for it right now, so anyone is free to propose a change08:24
rameshg87dtantsur: oh we have started to use ironic-lib, great :)08:24
chenkedtantsur, tku. i have found it and it's working08:24
dtantsurrameshg87, no, we haven't, that's the next step08:24
rameshg87dtantsur: let me check with faizan who was working on it, otherwise I will pick up08:24
dtantsurwe're just covered that side by the gate08:25
rameshg87dtantsur: I meant gate started using ironic-lib08:25
dtantsurah, right08:25
rameshg87dtantsur: yeah I meant that only :)08:25
dtantsurrameshg87, http://logs.openstack.org/56/225556/1/check/gate-tempest-dsvm-ironic-lib-src-nv/2d967e9/ :)08:25
dtantsurwe need to make it voting btw08:25
dtantsurprobably before we actually switch08:25
* dtantsur brb08:26
rameshg87yeah, and we might need to wait and see a few runs08:26
*** rameshg87 has left #openstack-ironic08:26
*** rameshg87 has joined #openstack-ironic08:26
*** mrmoje has quit IRC08:29
*** dimsum__ has joined #openstack-ironic08:33
*** digimonde has joined #openstack-ironic08:34
*** mrmoje has joined #openstack-ironic08:34
dtantsurrameshg87, to see a few runs we need a few patches :)08:35
dtantsuroh, and morning, betherly08:36
* rameshg87 counts on openstack proposal bot08:36
dtantsuryeah, once the reqs freeze is over (probably tomorrow)08:36
rameshg87dtantsur: yeah, meanwhile I will check and decide on the refactoring of ironic to use ironic-lib08:37
dtantsurcool08:37
rameshg87dtantsur: I think faizan told he has patch almost ready08:37
dtantsuroh, really? that's awesome08:37
rameshg87he has moved to different project btw, that's why we don't see him on irc08:37
dtantsuroh, I see08:37
rameshg87but he is still interested in finishing this off08:37
dtantsurrameshg87, could you update the whiteboard with your findings? we have a section about ironic-lib08:37
rameshg87dtantsur: sure08:38
*** dimsum__ has quit IRC08:38
*** pelix has joined #openstack-ironic08:42
betherlyo/ dtantsur :)08:46
openstackgerritNaohiro Tamura proposed openstack/ironic: Add hardware inspection module for iRMC driver  https://review.openstack.org/19648008:49
openstackgerritMerged openstack/ironic-inspector: Add explicit dependencies on Alembic and SA  https://review.openstack.org/22791708:50
*** karimb has joined #openstack-ironic09:00
*** mrmoje has quit IRC09:03
*** mrmoje has joined #openstack-ironic09:04
sambettsMorning ironic, Hey yuikotakada, dtantsur o/09:09
*** achanda has joined #openstack-ironic09:10
yuikotakadasambetts, o/09:11
dtantsurmorning sambetts09:12
*** sdake has joined #openstack-ironic09:15
*** dtantsur is now known as dtantsur|brb09:16
*** vinbs has quit IRC09:21
*** vinbs has joined #openstack-ironic09:22
* rameshg87 goes home09:24
*** rameshg87 has quit IRC09:24
sambettsDid we manage to release on Friday dtantsur|brb? Or did we wait?09:25
sambettsyuikotakada: What OS do you test inspector on?09:25
yuikotakadasambetts: I? using Ubuntu :)09:26
sambettsyuikotakada: Using devstack?09:26
yuikotakadasambetts: yup09:26
*** zhenguo has quit IRC09:26
sambettsyuikotakada: I've run into a weird issue with DNSmasq, I don't know if you've seen it, but my devstack won't pass because my DNS stops resolving correctly half way through09:27
*** karimb has quit IRC09:28
yuikotakadasambetts, during stack.sh running?09:28
*** ijw has quit IRC09:28
sambettsyuikotakada: yup09:28
*** ijw has joined #openstack-ironic09:29
yuikotakadasambetts, I'm not suret wheter it's same case with yours, but I've ever seen such issue09:29
yuikotakadasambetts, in my case, it was resolved by fixing /etc/resolv.conf. have you try it?09:30
sambettsyuikotakada: so in my case it seems like dnsmasq was installed before I'm running stack.sh, and so resolv.conf is pointing at 127.0.0.1 and when inspector starts dnsmasq it causes a conflict, Does your resolv.conf point at 127.0.0.1? or somewhere else?09:32
*** ijw has quit IRC09:33
*** e0ne has quit IRC09:33
yuikotakadasambetts, no, I've commented out 127.0.0.1 and written DNS server's IP address.09:33
sambettsyuikotakada: Ah, ok, are you on ubuntu server or desktop doing that?09:35
yuikotakadasambetts, on ubuntu server09:35
*** dimsum__ has joined #openstack-ironic09:36
sambettsok cool, I'll try that and it should be good then, I wonder if thats a step we need to add to our develop docs for people running ubuntu dev envs09:36
*** yog_ has quit IRC09:37
*** e0ne has joined #openstack-ironic09:38
sambettsdtantsur|brb: ^09:39
yuikotakadasambetts, good luck :) I'm not sure but maybe I faced this issue otherwise when not using Ironic Inspector09:39
*** yog_ has joined #openstack-ironic09:40
*** mrmoje has quit IRC09:40
*** mrmoje has joined #openstack-ironic09:42
*** mrmoje has quit IRC09:42
*** mrmoje has joined #openstack-ironic09:42
sambetts:/ weird I've never hit it before until I tried running inspector in my lab09:44
*** dimsum__ has quit IRC09:45
yuikotakadasambetts: mm? does it mean sake of inspector...??09:46
yuikotakadaI'll go home, see you!09:47
*** yuikotakada has quit IRC09:47
sambettsI think it might have something to do with there being a copy of DNSmasq being run by the system and being run by inspecotr colliding09:47
sambettscya!09:47
*** dimsum__ has joined #openstack-ironic09:51
*** jaypipes has joined #openstack-ironic09:52
*** achanda has quit IRC09:55
*** amotoki has quit IRC09:55
*** naohirot has quit IRC09:57
*** romcheg has joined #openstack-ironic09:57
*** bcornec has joined #openstack-ironic10:00
*** huats has quit IRC10:01
*** huats has joined #openstack-ironic10:02
*** romainh has quit IRC10:10
*** romcheg has quit IRC10:14
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-specs: Support node group operations  https://review.openstack.org/22837910:17
*** Nisha has quit IRC10:22
*** mgoddard has quit IRC10:28
*** romcheg has joined #openstack-ironic10:30
*** mgoddard has joined #openstack-ironic10:30
*** bcornec has quit IRC10:30
*** jlvillal has quit IRC10:31
*** jlvillal has joined #openstack-ironic10:31
*** bcornec has joined #openstack-ironic10:31
*** ukalifon has joined #openstack-ironic10:40
sambettslucasagomes: ping10:43
*** e0ne has quit IRC10:44
*** e0ne has joined #openstack-ironic10:49
*** chenke has quit IRC10:51
*** e0ne has quit IRC10:57
*** ukalifon has quit IRC11:00
*** e0ne has joined #openstack-ironic11:01
*** romcheg has quit IRC11:06
*** deray has quit IRC11:06
*** dtantsur|brb is now known as dtantsur11:13
dtantsursambetts, I was planning to release around now11:13
dtantsurapparently I forgot, that we have a holiday today11:13
dtantsurI even managed to cause alarm in the office by coming there >_<11:13
sambettsdtantsur: oh! Whoops! I've just tested inspector with devstack in my env, unfortunatly I  could only do it with the pxe_ssh drivers because of experimental stuff on my switches, but that all went through sucessfully, so I say we cut the release and then you can go back to holidaying11:16
dtantsurawesome!11:16
dtantsurI hope I don't get fired for causing an alarm... I'm supposed to know how to disable the damned thing, but I forgot.11:17
sambettsI'd hope not!11:18
sambettsDid you see mine and yuikos convo?11:18
dtantsursambetts, yeah, I see now. that's what I suspected11:25
dtantsursorry, so stressed now, barely able to think :(11:26
sambetts:( get the release going, and go home and have a drink, you shouldn't be stressed on a holiday11:29
*** lazy_prince has quit IRC11:35
dtantsursambetts, I'm already home, I wouldn't be able to work with alarm above me... though probably someone would come to give me a punch11:37
dtantsuranyway yeah, I'll find some drink first11:37
sambettsdtantsur: :-P11:37
dtantsursambetts, in the meanwhile, could you go through the README and see if we don't leave something no longer correct there?11:38
sambettsI'll have a read through :)11:39
*** e0ne has quit IRC11:43
*** chlong has joined #openstack-ironic11:43
dtantsurso, after some becherovka I'm starting to think again11:44
dtantsursambetts, yeah, it's a good point to add ubuntu dnsmasq work around to our README11:44
dtantsuryou can also attach the link that I gave you on Friday, lemme find it again11:45
sambettsdtantsur: Unfortunatly that link does seem to work for ubuntu server :/11:45
dtantsurah, server... ok, then add what you feel appropriate please :)11:46
*** itsuugo has quit IRC11:47
*** e0ne has joined #openstack-ironic11:47
*** romcheg has joined #openstack-ironic11:47
*** romainh has joined #openstack-ironic11:50
*** VikasC has quit IRC11:52
*** jamielennox|away is now known as jamielennox11:52
*** nicodemos has joined #openstack-ironic11:57
*** itsuugo has joined #openstack-ironic12:03
dtantsurjroll, do you think https://bugs.launchpad.net/nova/+bug/1449062 affects us?12:03
openstackLaunchpad bug 1449062 in Glance "qemu-img calls need to be restricted by ulimit (CVE-2015-5162)" [High,In progress] - Assigned to nikhil komawar (nikhil-komawar)12:03
*** romcheg has quit IRC12:09
*** trown|outttypeww is now known as trown12:11
trowndtantsur: lol @ setting off the alarm12:11
trownthat sounds awful12:11
dtantsurit was... I'm very depressed now12:11
*** mbound has quit IRC12:12
dtantsurand morning trown12:12
trownbtw I tested with packaged inspector over the weekend, and dbsync and rootwrap both worked for me12:12
trowngood morning :)12:12
*** trown is now known as trown|mtg12:16
sambettstrown|mtg: thats great news!12:21
*** trown|mtg is now known as trown12:21
*** baoli has joined #openstack-ironic12:22
*** mrmoje has quit IRC12:23
*** mrmoje has joined #openstack-ironic12:24
*** lazy_prince has joined #openstack-ironic12:29
*** jamielennox is now known as jamielennox|away12:33
openstackgerritSam Betts proposed openstack/ironic-inspector: Add troubleshooting section for Ubuntu DNS issues  https://review.openstack.org/22843712:35
openstackgerritShinn'ya Hoshino proposed openstack/ironic: Fix a bug error by passwords includes just numbers  https://review.openstack.org/22038512:41
dtantsursambetts, is there anything else you want to fix in readme?12:42
*** dimsum__ is now known as dims12:45
*** derekh has quit IRC12:45
sambettsdtantsur: I read through it and there is really anything else, the only bit that I wasn't sure of was the bit at the top that says you need a "special ramdisk" because now with IPA you technically don't12:46
dtantsurmmmm12:46
dtantsursambetts, we might fix it when we deprecated bash ramdisk the next cycle...12:46
dtantsurthough feel free to propose a better wording :)12:47
trowns/special// ?12:48
trownI think it is probably fine either way though...IPA is special too :)12:48
sambettsyeah thats what I was thinking, but its not urgent :-P12:48
*** itsuugo has quit IRC12:51
*** dtantsur_ has joined #openstack-ironic12:56
*** dtantsur has quit IRC12:57
*** derekh has joined #openstack-ironic12:58
*** rloo has joined #openstack-ironic13:01
*** dtantsur_ has quit IRC13:01
*** baoli has quit IRC13:04
*** baoli has joined #openstack-ironic13:05
*** karimb has joined #openstack-ironic13:06
*** dtantsur has joined #openstack-ironic13:06
*** [1]cdearborn has joined #openstack-ironic13:09
*** [1]cdearborn has quit IRC13:14
*** cdearborn has joined #openstack-ironic13:14
*** dims_ has joined #openstack-ironic13:15
*** dims has quit IRC13:17
*** cdearborn has quit IRC13:20
*** mbound has joined #openstack-ironic13:22
*** mbound has quit IRC13:22
*** mbound has joined #openstack-ironic13:23
*** cdearborn has joined #openstack-ironic13:23
jrolldtantsur: I don't think that qemu-img bug affects us, do you?13:26
jrollI don't see '--output' in the code anywhere13:26
dtantsurjust making sure :)13:26
jrollheh13:26
jrollwell, it's early, please do sanity check me :P13:26
dtantsurjroll, congrats on your PTLship and g'morning13:26
jrollthanks :D13:27
jrollmornin'13:27
BadCubMOrning folks!13:27
BadCubCongrats jroll !!!!!13:27
dtantsuractually I'm on holiday, just waiting for sambetts to go over our readme, then releasing inspector, then going out13:27
dtantsurmorning BadCub!13:27
jrolldtantsur: reminder we have a meeting today, if you'd like to come. I know you tend to forget13:27
jrollright, ok13:27
jrollBadCub: thanks \o/ g'morning13:28
dtantsurjroll, yeah, I'll try not to forget, thanks :)13:28
jrollI mean, feel free to forget given it's a holiday :P13:28
*** mgoddard1 has joined #openstack-ironic13:31
dtantsurI already forgot about holiday, as you can see in the scrollback, so enough with forgetting for today13:31
rloodtantsur: just don't forget to update the subteam statuses for the meeting today :)13:32
rloohi everyone13:32
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - RPC  https://review.openstack.org/20624313:32
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - API  https://review.openstack.org/20624413:32
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - net  https://review.openstack.org/20624513:32
openstackgerritOm Kumar proposed openstack/ironic: Update the deploy drivers with network flipping logic  https://review.openstack.org/21326213:32
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - DB  https://review.openstack.org/20623213:32
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - objs  https://review.openstack.org/20623813:32
openstackgerritOm Kumar proposed openstack/ironic: Add network provider interface and implementations  https://review.openstack.org/13968713:32
*** mgoddard has quit IRC13:33
*** vinbs has quit IRC13:33
*** alexpilotti has joined #openstack-ironic13:37
dtantsurmorning rloo13:37
openstackgerritSam Betts proposed openstack/ironic-inspector: Add troubleshooting section for Ubuntu DNS issues  https://review.openstack.org/22843713:38
rloohi dtantsur! enjoy your vacation.13:38
dtantsurifarkas, mind reviewing ^^ please?13:38
dtantsurrloo, thanks :) it's just a holiday, not vacation though13:38
ifarkasdtantsur, sure!13:38
*** sambetts is now known as sambetts_afk13:38
rloodtantsur: oh. too bad it isn't vacation ;)13:39
*** romcheg has joined #openstack-ironic13:41
*** mmnelemane has joined #openstack-ironic13:41
dtantsuryeah13:43
*** sdake_ has joined #openstack-ironic13:44
*** sdake has quit IRC13:47
openstackgerritMerged openstack/ironic-inspector: Add troubleshooting section for Ubuntu DNS issues  https://review.openstack.org/22843713:48
*** achanda has joined #openstack-ironic13:49
*** sdake_ has quit IRC13:50
trownmorning rloo ifarkas jroll BadCub13:51
trowncongrats on PTL jroll13:51
*** achanda has quit IRC13:51
jrollmorning trown, thank you!13:52
rloomorning trown13:52
jrollg'morning rloo :)13:52
rloohey, morning jroll.13:52
*** jaypipes has quit IRC13:53
rloojroll: I was thinking, you have to get another J* person on ironic.13:53
dtantsur++13:53
jrollrloo: hmmmm13:53
jrollidk if I know another J13:53
jrollmaybe we can make mariojv into jvmario13:54
rloojroll: ha ha. I'd good with that but not sure if mariojv is!13:54
jroll:P13:55
* dtantsur makes an inspector release13:57
NobodyCa1good morning Ironicers13:57
dtantsurNobodyCa1, morning13:57
NobodyCa1morning dtantsur13:57
*** NobodyCa1 is now known as NobodyCam13:58
*** sdake has joined #openstack-ironic13:58
jrollNobodyCam: morning \o13:59
*** itsuugo has joined #openstack-ironic13:59
NobodyCamgood morning jroll14:00
NobodyCamand congratz :)14:00
*** itsuugo has quit IRC14:01
*** baoli has quit IRC14:01
jrollthanks :)14:01
NobodyCam:)14:01
rloojroll: thank you for offering to be PTL. and congrats ;)14:02
jrollthis isn't 100% final but sounds like it's just minor details: https://wiki.openstack.org/wiki/Mitaka_Release_Schedule14:02
jrollrloo: heh, thank you :)14:02
*** baoli has joined #openstack-ironic14:02
rloojroll: the only one we care about is March 14-18? Mitaka RC1 candidate?14:03
jrollrloo: yep, I'd also like to have a conversation at some point (not now) about when we soft freeze or whatever14:03
rloojroll: well, I guess the three, Feb 22 final libraries; Feb 29 ironicclient.14:03
jrollgiven the global-requirements freeze and such was mildly annoying14:04
jrollah yes14:04
rloojroll: it would be good when mitaka schedulre is final, that we have corresponding dates for ironic so folks can plan (or not as they wish)14:05
jrollrloo: yeah, let's make a wiki page there14:06
jrollsimilar to https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule14:06
rloojroll: whoa. I hadn't seen Nova's wiki before. I like the 'how do i get my code merged?' section. we should have one that is more complicated than that!14:08
*** mmnelemane has quit IRC14:08
*** alexpilotti has quit IRC14:08
jrollrloo: haha, yeah I want to build a devref out for things like this14:09
rloojroll: i was joking but actually there is some good information there.14:09
rloojroll: this is good too 'Why are the reviewers being mean to me?'14:10
jrollrloo: I know you were joking about the complicated bits :P14:10
jrollrloo: especially "TODO - need more details "14:10
rloojroll: :D14:10
*** absubram has quit IRC14:16
jlvillaldtantsur, rloo jroll NobodyCam and everyone else, Good morning14:18
dtantsurmorning jlvillal14:18
jroll\o morning jlvillal14:19
rloomorning jlvillal14:22
*** achanda has joined #openstack-ironic14:22
jlvillalI was wondering if this had already been looked at: https://github.com/mjg59/firmware_config14:24
jlvillalA Python library for changing firmware settings14:24
*** tsekiyama has joined #openstack-ironic14:24
jlvillalCurrently supports Dell, IBM, and Cisco.14:24
jlvillalLooks like it was a former Nebula project. Sounded somewhat interesting for Ironic.14:25
jrollseems familiar14:25
jrollno tests :|14:25
jlvillalThe author was at the Ironic dinner at the Summit. Matthew Garret.14:25
* jlvillal just thought it looked a little interesting.14:26
*** mtanino has joined #openstack-ironic14:26
jrollyeah14:28
jrollidk, going to have to call it from each driver anyway14:28
jrollso I'm not sure the common interface gives us much14:28
jlvillalProbably true14:29
NobodyCammornign jlvillal :)14:31
NobodyCammornign rloo14:31
NobodyCamgah deff a monday for /me14:31
NobodyCam:-p14:32
*** e0ne has quit IRC14:32
jlvillalNobodyCam, :)14:32
*** e0ne has joined #openstack-ironic14:34
dtantsurjroll, could you please review https://review.openstack.org/#/c/225092 if you have a minute?14:35
*** dims has joined #openstack-ironic14:35
*** dims_ has quit IRC14:35
jrolldtantsur: ya, gimme a few14:35
dtantsurthanks14:35
rloogood morning NobodyCam14:35
jrollmmmmmm, we don't have a grenade job, do we?14:35
*** sambetts_afk has quit IRC14:35
*** sambetts has joined #openstack-ironic14:36
dtantsurtrown, once/if https://review.openstack.org/#/c/225092 lands we should make a release of ironic-python-agent, I guess14:36
jrolllooking at https://github.com/openstack/governance/blob/master/reference/tags/assert_follows-standard-deprecation.rst14:36
jrollone of the last requirements implies grenade14:36
jroll:|14:36
dtantsuroh, good thing to have14:37
trowndtantsur: oh, nice one, I will check that out14:37
trownthat is the last bit to have feature parity with the old ramdisk14:38
jrolldtantsur: Why have this intermediate step of putting this in another file? Could wrap stdout in a StringIO object if it's just to get the file-like object.14:38
jrollwas going to leave that comment, but figure I just ask here14:39
*** achanda has quit IRC14:40
*** garthb has joined #openstack-ironic14:43
jrollsambetts: thanks :D14:47
dtantsurlemme remember, there was a reason14:47
jrolllol14:48
sambettsjroll: irssi glitched out...14:48
NobodyCammorning sambetts14:48
*** digimonde has quit IRC14:48
sambettsMorning NobodyCam o/14:48
NobodyCamjroll: got any time free to take a look at a back port? https://review.openstack.org/#/c/228031 ???14:49
jrollO_o already14:49
NobodyCamlol14:49
dtantsurjroll, there was something wrong about tarfile, it has a pretty weird interface. If it bothers you, I can try to fix14:50
dtantsurjust leave a comment, I'll fix/not fix it tomorrow, wanna get out for some time :)14:50
jrolldtantsur: I left a comment, I'll try to look again later and decide if I care :)14:51
dtantsurthanks!14:51
*** dtantsur is now known as dtantsur|afk14:51
jrolldtantsur: I think you can use stringio to get what tarfile wants, though14:51
jrollanyway, catch you later :)14:51
dtantsur|afk:)14:52
*** liliars has quit IRC14:53
*** nicodemos has quit IRC14:55
*** nicodemos has joined #openstack-ironic14:56
*** nicodemos has quit IRC14:57
*** pradipta has joined #openstack-ironic14:58
openstackgerritJarrod Johnson proposed stackforge/pyghmi: Fix attempt to get LED against System X  https://review.openstack.org/22848514:58
*** greghaynes has joined #openstack-ironic14:59
*** absubram has joined #openstack-ironic14:59
sambettsjroll: I've got some cisco specfic ironic stuff I would like to put it upstream under openstack/, I don't intend to put it under the ironic umbrella so that its our responsbility and ironic shouldn't have to worry about it at all, but I wanted to make sure that you don't mind it carrying the ironic name, I was thinking about calling it something along the lines of ironic-cisco-contrib or cisco-i15:05
sambettsronic-contrib WDYT?15:05
jrollsambetts: seems fine to me, I like cisco-ironic-contrib personally15:06
jrollsambetts: I'm not super opposed to it being in the ironic umbrella (depending what it is ofc), we already have like prolianttools or whatever there15:06
*** bcornec has quit IRC15:07
rloojroll: actually, i would like some clarification as to what gets put under the ironic umbrella. are we ok with having XYZtools from every hardward vendor? (and what is the distinction between that and https://wiki.openstack.org/wiki/Ironic#other_vendor-specific_tools?15:10
jrollrloo: I agree, we need to work that out and document it15:11
sambettsjroll, rloo: I'll leave it out initially I think, I can always move it in after if we decide it fits :)15:13
jroll++15:13
sambetts:)15:13
sambettsthanks !15:13
jrollnp, thank you!15:13
*** mrmoje has quit IRC15:15
jrollstepping away for a bit15:15
*** mariojv is now known as jvmario15:16
*** thiagop has quit IRC15:18
*** mgoddard1 has quit IRC15:19
*** solid-sinval has quit IRC15:19
*** absubram has quit IRC15:25
openstackgerritCarmelo Ragusa proposed openstack/ironic: Added operator documentation for ironic portgroups  https://review.openstack.org/22849615:26
openstackgerritJarrod Johnson proposed stackforge/pyghmi: Fix attempt to get LED against System X  https://review.openstack.org/22848515:32
*** mgoddard has joined #openstack-ironic15:35
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - RPC  https://review.openstack.org/20624315:36
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - API  https://review.openstack.org/20624415:36
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - net  https://review.openstack.org/20624515:36
openstackgerritOm Kumar proposed openstack/ironic: Update the deploy drivers with network flipping logic  https://review.openstack.org/21326215:36
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - DB  https://review.openstack.org/20623215:36
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - objs  https://review.openstack.org/20623815:36
openstackgerritOm Kumar proposed openstack/ironic: Add network provider interface and implementations  https://review.openstack.org/13968715:36
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-specs: Support node group operations  https://review.openstack.org/22837915:37
openstackgerritWilliam Stevenson proposed openstack/ironic: Added operator documentation for ironic portgroups  https://review.openstack.org/22849615:39
*** ifarkas has quit IRC15:41
NobodyCamjroll: I assume you'll want to run the meeting today?15:44
openstackgerritJarrod Johnson proposed stackforge/pyghmi: Fix attempt to fetch firmware on System X  https://review.openstack.org/22850715:44
*** dims has quit IRC15:46
*** dims has joined #openstack-ironic15:46
natoriousI was thinking about writing up a blueprint for SEL monitoring ironic integration.  Like store a small history in an ironic table maybe?15:50
natoriouscould use snmp or conductor polling etc15:51
*** trown is now known as trown|lunch15:53
*** Sukhdev has joined #openstack-ironic15:54
*** yog_ has quit IRC15:55
jrollNobodyCam: idk, I guess :P15:58
*** mitchjameson has joined #openstack-ironic15:58
*** wlehman has joined #openstack-ironic15:59
NobodyCamjroll: lol15:59
NobodyCamI happy to.. but you know... first meeting as ptl and all :-p16:00
*** wlehman has quit IRC16:00
*** wlehman has joined #openstack-ironic16:00
jrollNobodyCam: yeah, idk "officially" when the transition is, now or at end of liberty16:00
jrollalso is deva out today?16:00
jrolloh first day at IBM, I guess he probably is16:00
NobodyCamthis is his first day at new Co. so not sure he'll be around a whole lot today16:01
NobodyCam:)16:01
jrollyeah :P16:02
jrollI can run it16:02
*** wlehman has quit IRC16:04
*** willsama has joined #openstack-ironic16:05
*** rameshg87 has joined #openstack-ironic16:08
*** stendulker has joined #openstack-ironic16:09
devanandaI'm semi-here. slow wifi inthis cafe16:10
devanandawill disappear in ~ 2 hours, but I can make the meeting16:11
NobodyCamw00t and good mornig devananda16:13
jroll\o morning16:13
rameshg87morning folks16:14
rameshg87jroll: congrats !! :)16:14
jrollrameshg87: thanks :D16:14
openstackgerritMerged openstack/ironic: Fix string formatting issues  https://review.openstack.org/22286216:15
NobodyCammorning rameshg8716:17
rameshg87NobodyCam: o/16:17
NobodyCamdevananda: got a free minute for a back port review? https://review.openstack.org/#/c/22803116:17
*** cinerama` is now known as cinerama16:18
* rameshg87 is not attending team meeting today and will have to leave now 16:20
*** rameshg87 has quit IRC16:20
NobodyCamdang he's quick16:20
NobodyCamlol16:20
stendulkermorning all16:21
NobodyCammorning stendulker16:21
stendulkerCongratulations jroll !!16:21
stendulkerNobodyCam: o/16:22
jrollstendulker: good morning, thanks :)16:22
NobodyCam:)16:22
*** e0ne has quit IRC16:22
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added repository field.  https://review.openstack.org/22797916:22
*** e0ne has joined #openstack-ironic16:24
devanandajroll: re https://review.openstack.org/#/c/226606/3 - why create placeholders for these 4 specs, but not the 8 other completed ones?16:28
jrolldevananda: apparently we failed with the other ones then?16:28
jrollor decided not to do so and I missed it16:28
jlvillaljroll: About how fast can a RackSpace bare metal node be provisioned?16:29
natoriousjlvillal: ~2:3016:30
jrolljlvillal: like 2-3 minutes16:30
jroll8 minutes worst case16:30
jlvillaljroll: Cool! :)16:30
devanandajroll: decided not to do it AFAIK16:30
jrolldevananda: well then16:30
jrolljlvillal: the fast ones are thanks to arsenal16:31
*** baoli has quit IRC16:31
jlvillaljroll: Thanks16:31
jrollwant links? :P16:31
jrollhttps://github.com/rackerlabs/arsenal and an updated version of https://review.openstack.org/#/c/161832/16:32
*** baoli has joined #openstack-ironic16:32
*** romcheg has quit IRC16:32
openstackgerritMario Villaplana proposed openstack/ironic: Allow vendor drivers to acquire shared tasks  https://review.openstack.org/22605816:39
*** willsama has quit IRC16:39
*** bnemec has joined #openstack-ironic16:40
*** achanda has joined #openstack-ironic16:40
*** Nisha has joined #openstack-ironic16:40
*** afaranha has joined #openstack-ironic16:42
*** praneshp has joined #openstack-ironic16:42
*** sdake_ has joined #openstack-ironic16:46
*** sdake has quit IRC16:49
*** davideagnello has joined #openstack-ironic16:52
*** romcheg has joined #openstack-ironic16:52
*** achanda has quit IRC16:54
*** penick has joined #openstack-ironic16:54
*** trown|lunch is now known as trown16:55
*** derekh has quit IRC16:55
jlvillaljroll: Thanks for the links16:55
jrollyeah np16:55
jrollrloo: oh he did switch to jvmario hahaha :P16:56
*** dtantsur|afk is now known as dtantsur16:57
jvmario:)16:57
rloothx jvmario! :D16:57
jrollj* reigns again :P16:57
jvmariolol16:58
NobodyCamlol16:58
NobodyCam++++16:58
dtantsurlool16:58
jvmariostill need to set up irc alerting for that nick.16:58
jrollnow we have to convince JayF to lowercase so we can drop the [Jj]16:58
JayFnope16:58
NobodyCamhahahaha16:58
dtantsurjroll, re dependency on 'hardware': you definitely don't want it in your requirements.txt :)16:58
jrolldtantsur: ...why16:59
dtantsurit has a crazy set of dependencies, many of them are not in g-r16:59
NobodyCamone minute until meeting16:59
jrollsigh16:59
JayFUser reg.  : Apr 19 04:18:12 2004 (11y 23w 3d ago) JayF/JasonF on Freenode :) Don't think I'm changing now :)16:59
jrollheh16:59
*** sinval has joined #openstack-ironic16:59
rlooJayF: that's ok Jason.17:00
*** penick has quit IRC17:00
krotscheckCan we get some core love on betherly's patch chain? https://review.openstack.org/#/c/223051/17:00
*** romainh has left #openstack-ironic17:00
krotscheckThey've been sitting for 2 weeks now17:00
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - RPC  https://review.openstack.org/20624317:01
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - API  https://review.openstack.org/20624417:01
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - net  https://review.openstack.org/20624517:01
openstackgerritOm Kumar proposed openstack/ironic: Update the deploy drivers with network flipping logic  https://review.openstack.org/21326217:01
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - DB  https://review.openstack.org/20623217:01
openstackgerritOm Kumar proposed openstack/ironic: Add portgroups to support LAG interfaces - objs  https://review.openstack.org/20623817:01
openstackgerritOm Kumar proposed openstack/ironic: Add network provider interface and implementations  https://review.openstack.org/13968717:01
jrollkrotscheck: meeting starting now17:01
*** mitchjameson has quit IRC17:03
*** penick has joined #openstack-ironic17:04
*** praneshp has quit IRC17:04
*** liliars has joined #openstack-ironic17:06
*** mbound has quit IRC17:07
*** willsama has joined #openstack-ironic17:09
*** pradipta has quit IRC17:09
*** jaypipes has joined #openstack-ironic17:09
*** mgoddard has quit IRC17:10
openstackgerritMerged stackforge/pyghmi: Fix attempt to fetch firmware on System X  https://review.openstack.org/22850717:11
*** mgoddard has joined #openstack-ironic17:11
lazy_princeSukhdev: https://review.openstack.org/#/c/139687/24/ironic/networks/neutron_plugin.py L99,L10017:11
lazy_princeare they okay..?17:11
openstackgerritMerged stackforge/pyghmi: Fix attempt to get LED against System X  https://review.openstack.org/22848517:11
Sukhdevlazy_prince: looking - hang on17:13
Sukhdevlazy_prince: it is device_owner - not device_owners17:14
lazy_princeokay.. will patch it.. but before i do, anything else that needs to change..?17:14
lazy_princeand please leave comment on the patch17:15
Sukhdevlazy_prince: just verify that "compute:baremetal" works - there may be attribute matching issue between neutron/ironic -17:15
Sukhdevlazy_prince: I will test it later today and will let you know -17:16
*** r-daneel has joined #openstack-ironic17:16
Sukhdevlazy_prince: Also, wanted to check with you regarding the tenant ID issue -17:16
lazy_princehmm.. I will have to push the testing for tomorrow... as its already late.. but if you can do that and leave a comment on the patch, that would be awesome..17:17
lazy_princesure.. go ahead..17:17
*** MattManHome has left #openstack-ironic17:17
SukhdevIn your ML2 driver, do you actually check the tenant ID in the create_port() call?17:17
Sukhdevand, if you check, you will notice that the tenant ID is of a service tenant, not the admin - even though the call is made in the admin context17:18
Sukhdevlazy_prince: This will impact those ML2 drivers which check for tenant IDs - the once that do not care will not notice this issue17:20
lazy_princeaha.. so thats your concern.. I will look into this and have more data for you..17:20
*** bnemec has quit IRC17:20
Sukhdevlazy_prince: I wonder if, in your ML2 driver, you care for it - hence may not be seeing it as an issue17:20
lazy_princeactually, we dont...17:21
Sukhdevlazy_prince: ah ha - thats why you do not see the issue17:21
Sukhdevlazy_prince: since we are solving this in a generic fashion so that all ML2 drivers work fine, we need to address this issue -17:22
lazy_princewill try updating it and see if my mech driver fails..17:22
*** karimb has quit IRC17:22
lazy_princewill get back to you on this tomorrow..17:23
Sukhdevlazy_prince: here is what you need to check - match the tenant ID of the tenant who created the network with the tenant ID of the tenant who is trying to plumb a port on it - then you will see the mismatch17:23
lazy_princeokay.. sure.. will do that..17:24
Sukhdevlazy_prince: cool - I am usually on the IRC, if you do not find me, shoot me an email - this way, we can get this resolved rather quickly17:24
lazy_princesure..17:24
Sukhdevlazy_prince: Also, I will log the comment on the patch based upon my testing later today17:24
lazy_princesure..17:25
Sukhdevlazy_prince: have a good night17:26
openstackgerritOm Kumar proposed openstack/ironic: Added operator documentation for ironic portgroups  https://review.openstack.org/22849617:30
*** bnemec has joined #openstack-ironic17:32
jrollbetherly: hey, what's your gerrit email?17:35
*** pelix has quit IRC17:35
betherlye.r.elwell@gmail.com jroll17:35
jrollthanks17:35
jrollbetherly: krotscheck welcome to +2-land17:36
*** harshs has joined #openstack-ironic17:36
krotscheck....mwa ha haaaa17:36
krotscheckbetherly: Ease off on +2ing all my patches, I'm going to get yours landed and then rebase all of mine, because there will be conflicts.17:36
*** alexpilotti has joined #openstack-ironic17:36
*** Marga_ has quit IRC17:37
betherlythanks jroll17:37
jrollnp, ty!17:37
betherlykrotscheck: will do let me know when youre ready for me to come invade with +2ness17:38
krotscheckYou got it17:38
*** stendulker has quit IRC17:38
openstackgerritMerged openstack/ironic-webclient: Added descriptive comments to index.html JS files  https://review.openstack.org/22305117:42
NobodyCamawesome first meeting jroll .... Thank you... lol17:43
dtantsurok folks, I'm still on holiday, and some cooking is awaiting me right now17:43
dtantsurso see you tomorrow :)17:43
openstackgerritMerged openstack/ironic-webclient: Removed unused css file  https://review.openstack.org/22306817:43
betherly+1 NobodyCam thanks jroll17:43
devanandatime to go into the office -- bbiafh17:44
jrollheh thanks17:44
NobodyCamnight dtantsur17:44
Nishadevananda, one query ...17:44
Nishajroll, devananda, " and then we could link to it in docs and/or wiki"... so if there is a document patch proposed after stable/Liberty(4.2) i.e. in 4.3 then it needs to be backported as a patch on 4.2 for it to be present on Liberty branch17:44
*** lazy_prince has quit IRC17:44
*** dtantsur is now known as dtantsur|afk17:45
*** yuriyz has quit IRC17:45
jrollNisha: what's your question?17:45
jrollNisha: FWIW docs.openstack.org comes from master, not a release, for better or worse17:45
Nishabut anyone just cloning release branch say stable/kilo, then the docs will be of that branch only, correct?17:46
TheJuliaNisha: yes17:47
*** athomas has quit IRC17:48
*** Sukhdev has quit IRC17:48
TheJuliaNisha: I think of it as a snapshot frozen in time, that we can update if absolutely required.17:48
*** praneshp has joined #openstack-ironic17:48
jlvillaljroll: Getting back to you on Grenade jobs. Can I get some pointers on what you would like me to investigate?17:49
*** yuriyz has joined #openstack-ironic17:49
jrolljlvillal: keeping in mind that I have no idea where we stand on it - grenade is a thing that can test upgrading openstack from (for example) juno to kilo, running tempest on both17:49
NishaTheJulia, i agree. But the feature is in 4.2 (stable/Liberty) and doc would be in 4.3 (assuming)17:49
jrolljlvillal: adam_g had started working on it, but I don't see it running, I would like it running and voting :)17:50
jrolljlvillal: digging some links...17:50
jlvillaljroll: Thanks17:51
* jlvillal also misses adam_g :)17:51
jrolljlvillal: yeah, so it's an experimental job at the moment, not sure what needs to be done to promote it to non-voting and then voting https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L225817:52
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added code coverage output directory to eslintignore  https://review.openstack.org/21520917:53
*** achanda has joined #openstack-ironic17:54
*** Sukhdev has joined #openstack-ironic17:54
jlvillaljroll: I will look. Thank you.17:55
jrolljlvillal: awesome, thanks!17:55
jrolljlvillal: we should also consider release to release (not cycles) but maybe down the road17:56
jlvillalrelease = 4.1.0 , 4.2.0?  Cycles = time frame?17:56
jlvillaljroll: ^^17:56
jlvillalOr cycles = liberty, mitaka?17:57
*** baoli has quit IRC17:57
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Removed libs from eslintignore  https://review.openstack.org/21521417:57
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added coverage threshold failure  https://review.openstack.org/21381617:57
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Removed X-Client header  https://review.openstack.org/21440617:58
jrolljlvillal: the existing job tests against cycles (liberty, mitaka)17:58
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Updated eslint rules.  https://review.openstack.org/21579517:58
*** Sukhdev has quit IRC17:58
jrolljlvillal: and I'd like to also test e.g. 4.2 -> 4.3, at some point down the road17:58
*** mrmoje has joined #openstack-ironic17:59
jlvillaljroll: Thanks for the clarification17:59
jrolljlvillal: it might even just be a config for the 'previous' version, idk17:59
*** achanda has quit IRC17:59
*** Marga_ has joined #openstack-ironic18:00
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Removed gitignore files for previous build system  https://review.openstack.org/21518018:00
*** athomas has joined #openstack-ironic18:00
*** bnemec has quit IRC18:02
*** sinval has quit IRC18:03
*** liliars has quit IRC18:03
*** afaranha has quit IRC18:04
*** gabriel-bezerra has quit IRC18:04
krtaylorjlvillal, what if we set a time to get the test/QA folks together to chat on needs/priorities?18:04
jlvillalkrtaylor: I like the idea. I think lekha, you, and I are all in the US timezones.18:05
krtaylortest/QA subteam kinda thing  - it would be go for discussions at summit18:05
lekhajlvillal: krtaylor : wfm18:06
krtaylorwell, that was easy  :)18:06
jlvillalkrtaylor: lekha I think it would be good to chat on IRC before the summit. But if we can chat at the summit too that would be better18:06
krtayloragreed18:06
lekha+118:06
krtaylorjlvillal, do you have a test/QA etherpad set up?18:07
jlvillalkrtaylor: lekha: I could chat today from 14:00-16:00 Pacific Time, if you all were free18:07
jlvillalkrtaylor: I don't know of one. I have the Wiki entry, but etherpad would be better for brainstorming.18:07
jlvillalOr could chat tomorrow...18:07
*** mbound has joined #openstack-ironic18:07
lekhajlvillal: wfm. do we need 2 hours?18:08
jlvillallekha: No, I was giving a range of time I was available :)18:09
krtaylorjlvillal, I'll take that todo, and I could today at 15:00 pacific, tomorrow is better for me18:09
sambettsRight I'm calling it a night, congrats again jroll, see everyone tomorrow18:09
jlvillalsambetts: Ciao18:09
sambettscya jlvillal18:09
sambettso/18:09
NobodyCamnight sambetts18:09
sambettso/ NobodyCam18:09
jlvillalkrtaylor: lekha: I like 15:00 pacific today if okay? But krtaylor if tomorrow much better, could do then also.18:10
lekhajlvillal: krtaylor: today at 3 wfm. I am free for the most part tomorrow too18:10
krtaylorlets try then, I'll be offline until then though18:11
krtaylormeet up her at 3 pacific/5 central18:11
krtaylorhere too18:11
jlvillalkrtaylor: Sounds good. But I can also do tomorrow too.18:11
jlvillalSee you then :)18:11
krtaylorcool, lunch then, bbiab18:11
lekhajlvillal: krtaylor: talk to you all at 318:12
*** mbound has quit IRC18:13
jvmariois there something wrong with the gate right now? i want to verify that the failure here is actually because of a problem in the patch: https://review.openstack.org/#/c/22605818:13
jlvillaljvmario: Could be an intermittent error. The whiteboard has that job failing occasionally18:14
jvmariothanks - it didn't look like it was related, but i was touching the agent base driver code18:15
jlvillalhttps://etherpad.openstack.org/p/IronicWhiteBoard18:16
jlvillaljvmario: ^^^18:16
jvmarioty18:16
jlvillaljvmario: You could do a:  recheck bug: #139309918:17
openstackbug 1393099 in OpenStack-Gate "test_baremetal_server_ops fails with timeout waiting for provision_state to change" [Undecided,Confirmed] https://launchpad.net/bugs/139309918:17
jvmarioi will do that18:17
*** gabriel-bezerra has joined #openstack-ironic18:17
jlvillaljroll: rloo: I saw mtreinish proposed: https://review.openstack.org/#/c/228105/  Sounds reasonable as I think he knows much more about the test stuff than me. Not sure if you have looked.18:18
*** mbound has joined #openstack-ironic18:18
*** sinval has joined #openstack-ironic18:18
*** afaranha has joined #openstack-ironic18:18
rloojlvillal: if you know what ostestr is, you know more than me!18:18
*** liliars has joined #openstack-ironic18:19
jlvillalrloo: heh!18:19
jlvillalrloo: I have learned it is os-testr aka OpenStack testr18:20
rloojlvillal: ah, I was wondering. I haven't had time to look at that patch. trying to clean up/catch up on other stuff now that we have stable/liberty.18:21
jlvillalrloo: No worries. I have pinged mtreinish to see if I can learn more. Thanks.18:21
jrolljlvillal: yeah, I was going to say I think it's a testr wrapper18:21
rloothx jlvillal.18:21
jrolljlvillal: I will vote the same direction you vote :)18:22
* jroll tags himself on review18:22
jlvillal:)18:22
*** mestery_afk is now known as mestery18:22
*** gabriel-bezerra has quit IRC18:23
*** sinval has quit IRC18:24
openstackgerritRuby Loo proposed openstack/ironic: Replace six.iteritems() with .items()  https://review.openstack.org/22856818:24
*** afaranha has quit IRC18:24
*** liliars has quit IRC18:25
*** baoli has joined #openstack-ironic18:26
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Split storage components into individual files  https://review.openstack.org/22740818:27
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added $$resourceCache service.  https://review.openstack.org/22744418:27
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Expanded clean command.  https://review.openstack.org/22740418:27
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added phantomjs as dependency  https://review.openstack.org/22740518:27
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Upgraded bower dependencies  https://review.openstack.org/22740618:27
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added "gulp package" to pretest  https://review.openstack.org/22740718:27
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Include fontawesome fonts  https://review.openstack.org/22857018:27
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: [WIP] Split resources into individual files  https://review.openstack.org/22857118:27
openstackgerritRuby Loo proposed openstack/python-ironicclient: Replace six.iteritems() with .items()  https://review.openstack.org/22857218:27
*** sdake has joined #openstack-ironic18:29
*** mrmoje has quit IRC18:30
*** sdake_ has quit IRC18:31
*** mrmoje has joined #openstack-ironic18:31
*** krtaylor has quit IRC18:33
*** ijw has joined #openstack-ironic18:45
*** sambetts has quit IRC18:52
*** sambetts has joined #openstack-ironic18:54
*** achanda has joined #openstack-ironic18:56
*** boris-42 has quit IRC18:59
*** penick has quit IRC18:59
*** achanda has quit IRC19:00
*** baoli has quit IRC19:01
*** penick has joined #openstack-ironic19:05
*** athomas has quit IRC19:06
*** harshs has quit IRC19:09
openstackgerritMario Villaplana proposed openstack/ironic-python-agent: Adds more functional tests for commands  https://review.openstack.org/22424719:10
*** itsuugo has joined #openstack-ironic19:11
*** Marga_ has quit IRC19:17
*** Marga_ has joined #openstack-ironic19:17
*** Sukhdev has joined #openstack-ironic19:19
*** ijw has quit IRC19:28
*** e0ne has quit IRC19:28
*** e0ne has joined #openstack-ironic19:41
*** baoli has joined #openstack-ironic19:44
*** baoli has quit IRC19:45
*** baoli has joined #openstack-ironic19:45
*** mjturek1 has quit IRC19:49
*** liliars has joined #openstack-ironic19:49
*** sinval has joined #openstack-ironic19:49
*** jlvillal has quit IRC19:51
*** jlvillal has joined #openstack-ironic19:51
openstackgerritNisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy  https://review.openstack.org/22802019:51
*** mjturek1 has joined #openstack-ironic19:53
openstackgerritNisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy  https://review.openstack.org/22802019:55
*** achanda has joined #openstack-ironic19:56
*** gabriel-bezerra has joined #openstack-ironic19:57
*** achanda has quit IRC20:01
*** karimb has joined #openstack-ironic20:05
openstackgerritNisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy  https://review.openstack.org/22802020:05
*** JoshNang_ has joined #openstack-ironic20:10
*** david-lyle has quit IRC20:14
*** JoshNang has quit IRC20:17
*** JoshNang has joined #openstack-ironic20:17
*** JoshNang has quit IRC20:18
*** JoshNang_ is now known as JoshNang20:18
*** baoli has quit IRC20:21
*** sdake_ has joined #openstack-ironic20:25
*** sdake has quit IRC20:28
*** harshs has joined #openstack-ironic20:28
openstackgerritJohn L. Villalovos proposed openstack/ironic: Prepare for functional testing  https://review.openstack.org/22861220:31
openstackgerritJohn L. Villalovos proposed openstack/ironic: Prepare for functional testing  https://review.openstack.org/22861220:32
jlvillaljroll: ^^^ Moving the directories around. Will break all in-flight patches when it merges20:33
NobodyCamuggh20:34
*** digimonde has joined #openstack-ironic20:34
jlvillalNobodyCam: Sorry about that :(20:34
NobodyCamkinda needs doing20:35
*** Sukhdev has quit IRC20:35
NobodyCamwe'll need to message that alot20:36
NobodyCamso folks know20:36
*** boris-42 has joined #openstack-ironic20:37
jlvillalNobodyCam: Okay. I think people will just need to rebase their changes for the most part. But it will fail in Jenkins. Not sure how much announcements we should do.20:37
*** sdake_ is now known as sdake20:38
NobodyCamwe'll get [devananda|jroll]'s input20:38
NobodyCambrb20:38
NobodyCamgot run and grab a pack of smokes20:38
*** romcheg2 has joined #openstack-ironic20:39
*** achanda has joined #openstack-ironic20:39
*** romcheg has quit IRC20:40
*** sdake has quit IRC20:42
*** sdake has joined #openstack-ironic20:43
*** romcheg2 has quit IRC20:43
*** romcheg has joined #openstack-ironic20:45
*** mrmoje has quit IRC20:54
jrolljlvillal: fuuuuun.20:55
jrolljlvillal: probably no better time than now to do it, honestly20:55
* NobodyCam is back20:55
jrollobviously we aren't trying to land anything ASAP today20:56
jlvillaljroll: Whenever you would like to do it, works for me :)20:56
jrolljlvillal: can you send a mail to the list that's it happening real soon now (tm) and look out?20:57
jlvillaljroll: Will do20:57
jrollthat way people can start rebasing and stuff if they want20:57
jrollthanks!20:57
*** Nisha has quit IRC20:59
*** Sukhdev has joined #openstack-ironic21:01
*** trown is now known as trown|outttypeww21:02
*** kevinbenton has quit IRC21:03
jlvillaljroll, NobodyCam: Email sent: http://lists.openstack.org/pipermail/openstack-dev/2015-September/075674.html21:04
*** kevinbenton has joined #openstack-ironic21:04
jroll\o/ thank you sir21:04
jrollnow we just land it asap, I think?21:04
jrollbefore any new files get added21:05
NobodyCamjlvillal: awesome thank you :)21:06
jlvillalNobodyCam: At least that is my theory that moving the files will break in-flight patches that touch test code. I'm not 100% sure on that.  Maybe git handles it magically :)21:07
NobodyCam:) I believe your right21:07
NobodyCam:)21:07
jlvillal:)21:07
jlvillallekha: FYI: https://review.openstack.org/22861221:09
*** david-lyle has joined #openstack-ironic21:09
lekhajlvillal: thanks, looking21:10
jrolljlvillal: I so want to just land this without actually reviewing it :P21:10
jlvillaljroll: lol. Sorry it is so big :(  There are a lot of 'import ironic.tests.blahblah' in there21:10
jrollyeah, no worries21:11
* jroll flipping through quickly21:11
openstackgerritRuby Loo proposed openstack/ironic: Fix some iBoot strings  https://review.openstack.org/22862921:12
*** kevinbenton has quit IRC21:14
NobodyCamjlvillal: is there a bug / blueprint we could ref on that review?21:16
jlvillalNobodyCam: No, I can create one though. Should I?21:17
jlvillalIf so.  Bug or blueprint?21:17
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Automatic library concatenation  https://review.openstack.org/22863021:17
jlvillalNobodyCam: Actually I do have a bug?21:17
NobodyCam:)21:17
jrollhm, on second thought should probably write a spec for this21:18
jroll-221:18
* jroll runs away21:18
NobodyCamlol21:18
NobodyCamjroll: but if there is a open bug21:18
NobodyCam...21:18
jrollit's a joke21:19
jroll:D21:19
NobodyCamoh ...21:19
NobodyCamlol21:19
NobodyCamdarn you monday ... give my brain back21:19
jrollI mean, the bug is terrible, it says "ironic doesn't have functional testing"21:20
jlvillalNobodyCam: https://bugs.launchpad.net/ironic/+bug/149167021:20
openstackLaunchpad bug 1491670 in Ironic "ironic does not have functional testing" [Wishlist,Triaged]21:20
jrolldoesn't add much value here21:20
NobodyCamahh ok21:20
jrollthere's no patches in the gate right now btw21:21
rlooI don't see what's wrong with that bug.21:23
rlooAt least the bug can be used to 'collect' all the patches related to getting functional testing working?21:24
jrollyeah, I suppose, I just meant it doesn't add any detail to that patch specifically21:25
*** sdake_ has joined #openstack-ironic21:25
rloojroll: true. but i'd say that is true for 50% of our bugs.21:25
jrolljlvillal: maybe you should add a partial-bug for record keeping21:25
jrollrloo: :(21:25
jlvillaljroll: Will do21:25
rloojroll: ok, maybe i inflated that number21:26
*** karimb has quit IRC21:26
openstackgerritJohn L. Villalovos proposed openstack/ironic: Prepare for functional testing  https://review.openstack.org/22861221:27
jrollthanks21:27
*** sdake__ has joined #openstack-ironic21:27
jlvillaljroll: NobodyCam: Partial-Bug added to commit message.21:27
jrolljlvillal: now it's assigned to you, you have to do all the work21:28
*** sdake has quit IRC21:28
jlvillalWoo hoo!  Wait...what? ;)21:28
jlvillalLuckily lekha and krtaylor want to work on it too! :)21:28
*** itsuugo has quit IRC21:29
jrollheh21:30
jrolldmitry has a point about base.py but I say we refactor that later21:30
jrollI don't see too many methods that would be useful in a functional env there21:30
*** sdake_ has quit IRC21:30
jlvillalAt the moment I don't have enough information to know if it would be useful. So I would rather move it now and if needed can refactor things in the future.21:32
jrollyep +121:32
jlvillalSo I guess I am agreeing with you :)21:32
jrolltis why there's a checkmark there :P21:32
jlvillal:)21:33
*** thrash is now known as thrash|g0ne21:33
jlvillaljroll: rloo: as a note on that 'os-testr' patch. It does produce much much much more output than the old method.  For example: http://logs.openstack.org/05/228105/1/check/gate-ironic-python27/f5aaad0/console.html.gz21:38
jlvillalWhich can be a good thing. It does show any stdout/stderr messages even on success.21:39
jlvillalWhich I could see making debugging unit tests easier.21:39
rloothx jlvillal. will need to take a look at that but maybe not today21:39
jlvillalrloo: No hurry21:40
*** penick has quit IRC21:40
*** sdake__ is now known as sdake21:41
*** bapalm_ has quit IRC21:41
*** bapalm has joined #openstack-ironic21:42
*** digimonde has quit IRC21:43
*** willsama has quit IRC21:46
*** kevinbenton has joined #openstack-ironic21:47
jrolljlvillal: ruby caught a thing there, I believe it's just for docs but worth picking up if you need to spin this again21:51
jrollfollow-up patch is fine too21:51
*** romcheg has quit IRC21:51
jlvillaljroll: looking...21:52
jlvillaljroll: I'm leaning towards a follow-up patch, but can easily fix it now and push new change...21:56
jrolljlvillal: I'd wait21:56
jlvillalWill do. Thanks21:56
jlvillallekha: Let's wait for krtaylor to show up...22:00
lekhajlvillal: sure, was just about to ping you all22:00
jlvillallekha: Yeah, I didn't see him listed. If he doesn't show up we can reschedule for tomorrow.22:01
jlvillalAt least I can reschedule :)22:01
lekhajlvillal: ok, wfm22:01
*** krtaylor has joined #openstack-ironic22:02
*** harshs has quit IRC22:03
lekhajlvillal: krtaylor is here now :)22:03
krtaylorjlvillal, lekha -> here is an etherpad for Test/QA discussion22:05
krtaylorhttps://etherpad.openstack.org/p/mitaka-ironic-test-qa22:05
jlvillalkrtaylor: Thanks22:05
lekhakrtaylor: thanks22:05
krtaylorsure, np22:05
krtaylorI'll put a few things there that I was thinking about, namely terms for starters22:06
jlvillalSo we can discuss it here or over in #openstack-ironic-meeting22:06
jlvillalI vote for here22:06
lekhakrtaylor: are you one of the devs on ironic22:06
jlvillalUnless we get disturb people too much.22:06
jlvillals/we get/we/22:07
krtaylorI'm good either way22:08
jlvillalSo I've done a patch to move the unit tests to ironic/tests/unit/ and created ironic/tests/functional/22:08
jlvillalThis matches up with other projects.22:08
jrollit's always quiet in the afternoon, go ahead here :)22:08
krtaylorlekha, yes, starting with testing on Power, PowerKVM CI and unit testing22:08
jlvillaljroll: Thanks22:09
krtaylorthanks jroll !22:09
lekhacool22:09
lekhaI was looking at functional tests for nova-client and nova to get an idea of how others do it22:09
jlvillalSo lekha was mentioning being able to use mimic and then we can run the functional tests inside the developer's tox environment.22:09
krtaylorlekha,  another question I have - where/when do we start talking about required CI for platforms and drivers22:10
lekhayes, am thinking we should have the option to run functional tests against mimic as well as devstack22:10
jlvillalWhich I really like the idea. Sounds lightweight, fast, and easy for developer's to use.22:10
* krtaylor ducks22:10
jrollkrtaylor++22:11
krtaylorok, so terms  :) by functional, you mean unit?22:11
jlvillalkrtaylor: No...22:11
jlvillalWe have unit tests.22:11
krtaylorthats where a lot of confusion is22:11
*** cdearborn has quit IRC22:11
jlvillalFunctional tests from what I believe we mean is to run the ironic-conductor and ironic-api and have as few external dependencies as possible.22:12
lekhakrtaylor: by functional I mean testing all the ironic api calls to start with, by mocking all the dependecies and using fake drivers22:12
jlvillalSo no Nova, keystone, glance, swift, etc...22:12
krtaylorso, traditionally in other projects, there are tests in <project>/test and then in the tempest tree22:12
krtaylorthis is a third model?22:12
jlvillalkrtaylor: But I do think 'functional' is not a good name but it seems like OpenStack uses it across multiple projects.22:12
krtaylorright22:12
jrollI like to think of it as unit, functional, integration22:13
lekhakrtaylor: tempest is more like end to end right?22:13
jlvillalkrtaylor: Nova has nova/test/unit/ nova/test/functional/22:13
jlvillals/test/tests/22:13
jrollfunctional means like, stand up ironic and poke it; integration means put ironic in devstack with everything else and pretend to be a user22:13
krtaylorso maybe we call functional-> stand alone?22:13
krtaylorright, tempest is with devstack - that is traditionally integration22:14
krtaylorjlvillal, yes, there is a move to push testing back to the projects22:14
jrolljlvillal: side note: as part of this effort, it might be worth looking at pulling our tempest stuff out of tempest and putting them in our tree via tempest_lib (feel free to ignore this as I'm probably getting ahead of things here)22:14
krtaylorreduce gate testing, that testing will become periodic22:14
*** harshs has joined #openstack-ironic22:15
krtaylorjroll, good point22:15
* lekha looksat the tempest tests for ironic22:15
* krtaylor goes to etherpad to put some of these topics there22:15
jlvillalkrtaylor: Another reason I think is that they want the projects to own their tests.22:15
jlvillalTempest tests are off in some other repo that the project don't control.22:16
jlvillaljroll: Yep on using tempest_lib,  Something to add to the list22:16
*** dims has quit IRC22:17
krtaylorjlvillal, correct, but that is stalled because it needs to be reported and how/when to do that22:18
krtaylorso we need a way to discuss this, agree to what to call each set of testing  :)22:19
lekhacan we talk about what we have today and at what points are they run22:19
jlvillalI think we should try to come up with a good definition of what we consider functional testing in the Etherpad.  Somewhere between unit and integration testing.22:19
*** ijw has joined #openstack-ironic22:19
lekhalike when are the tempest tests run?22:19
lekhasorry, I am pretty new to the OpenStack way of things22:20
jlvillallekha: What do you mean by 'when'? When people submit patches they get run.22:20
lekhaso the tempest test run then as well? just that they run against devstack22:20
jlvillallekha: Yep22:21
jlvillallekha: For example here is my patch and Jenkins has finished running: https://review.openstack.org/#/c/228612/22:21
jlvillalYou can see *-tempest-* jobs in the jenkins list22:21
lekhayea see it22:21
krtayloryes, that is upstream CI or infra CI for the project22:22
krtaylorit runs pipelines of tests defined in tempest22:22
krtaylorcheck and gate22:22
lekhagot it22:22
krtaylorfor each patch22:22
*** ijw_ has joined #openstack-ironic22:23
krtayloralso for each patch there are third party CI systems running tests and reporting back as comments22:23
jlvillalcheck being on patch submission.  gate is after a patch has been +2ed, +1 from Jenkins, and +1 (aka +A) for Workflow.22:23
krtaylorexactly22:23
jlvillalAnd as far as I know usually third party CI votes do not stop a patch from getting merged. At least not in Ironic22:24
krtaylorok, so we agree on CI and tempest :)22:24
krtaylorjlvillal, yes, that is a per project decision22:24
*** ijw has quit IRC22:24
lekhaok22:24
krtaylorsome projects allow voting, others do not22:24
krtaylorcomments only22:25
krtaylorthird party CI does not gate ever to my knowledge22:25
krtaylorvote, but not gate22:26
krtaylorok, so back to functional22:26
jlvillalOkay22:26
krtaylorthis would be a set of tests that do a full ironic integration, stand alone (non-devstack), that could be used for periodic tests22:27
krtayloroops, that was a question, not a statement22:27
lekhakrtaylor: I would think we should be able to run these against devstack or mimic22:28
jlvillalThat sounds about right to me.22:28
lekhajenkins could be setup to run against both.22:28
jlvillallekha: Isn't the integration test taking care of devstack?22:28
jlvillalof using devstack?22:28
*** benhur_marcel has joined #openstack-ironic22:29
jlvillallekha: Just curious what you mean by 'using devstack'?  Having ironic communicate with Nova, glance, cinder, etc....?22:29
lekhayes22:29
jlvillalThat sounds like it stops being functional testing and becomes integration testing. Which already exists.22:29
* jlvillal is happy for jroll or others to pipe in :)22:29
jrollwhat'd I do22:30
krtaylorexactly22:30
lekhaHmm, I thought tempest was doing beyond just verifying the ironic api. but does seem so22:30
lekhanot*22:30
krtaylorthats why I was confused :)22:30
jrolllet's back up a bit22:30
jrollour tempest tests also run against Nova with the ironic driver22:30
krtaylortempest (integration) tests api and nova22:30
jrollthe "tempest baremetal" tests just poke the ironic api, with neutron/glance/etc hooked up22:30
krtayloryes22:30
jrollbut we also run other tempest tests (like boot a server)22:31
krtaylorwith the ssh driver22:31
jrollright22:31
krtaylorso one question, is that good enough? is the idea to have the other drivers do their testing and cover the other paths?22:32
jrollso thinking about devstack vs not devstack22:32
jrollI would think there would be some test config "USE_MIMIC"22:32
jrollthe same tests could run with or without that22:33
jrollso USE_MIMIC=True tox -e functional  - could run on a dev machine22:33
lekhajroll: thanks, thats the point I was trying to make22:33
jrolland we'd USE_MIMIC=False in the gate22:33
* krtaylor needs to read more about mimic22:33
krtayloris that just a tox wrapper or different environment?22:34
jrollkrtaylor: I like to think of it as an API mock for openstack services22:34
jlvillalWhen I like at Nova they have 'gate-nova-tox-functional'  Which runs in about 12-13 minutes22:34
jlvillals/like/look/22:34
jlvillalWhen I look at Nova they have 'gate-nova-tox-functional'  Which runs in about 12-13 minutes22:34
jlvillalSo my assumption is no devstack.22:34
lekhajlvillal: I see that they are using some fakes from the unit tests22:35
jrollyep, I assume they use fake drivers too22:35
jlvillalTo me functional means no other services. So I think no devstack.22:35
krtaylorjlvillal, where is that? in the nova tree?22:35
jlvillalnova/tests/functional/22:35
jlvillalkrtaylor: https://review.openstack.org/#/c/221848/ Here is a nova job22:36
krtaylorjlvillal, I agree with your definition of functional22:36
* krtaylor reads22:36
jlvillalBut I would want us to agree on what functional means.22:36
jlvillalTo me it sounds like integration tests use devstack. I think for functional we should stay out of devstack space.22:36
jlvillalBut would like to hear other opinions.22:36
*** penick has joined #openstack-ironic22:37
krtaylorto me, that is all just unit tests22:37
lekhajlvillal: well that is fine. We can writes tests that can be run without devstack. But you should be able to run these same tests with the actual dependecies as well right. Its like one set of tests serving both purposes22:37
krtaylorbut we can split unit and functional if it has a purpose22:37
jlvillalkrtaylor: Well we define unit tests as testing just methods for the most part.22:37
krtayloragree functional/unit = no devstack, run from checking out code, integration (tempest) = devstack22:38
jlvillalkrtaylor: But I understand that some books call functional testing as testing functions/methods.22:38
jlvillalOne of the reasons I was confused when I started searching on 'functional testing'22:38
krtaylorexactly  :)22:39
jrollI'd say we start with that definition - it shouldn't be much work to make a config to do the 'functional' testing againstr devstack22:39
krtaylorbut, thats ok, because both are run from the tests directory using tox or mimic?22:39
krtaylorwithout devstack22:39
jlvillalkrtaylor: So I suggest we forget what books and other people say are functional testing. And try to use the OpenStack term :)22:39
jrollbasically the config would be "don't start services, they're already running. don't use mimic either."22:39
jrollso start with "no devstack" and then get there eventually22:40
*** e0ne has quit IRC22:40
krtaylorI think we agree! woot!22:40
jlvillaljroll: Okay. I am good with start with 'no devstack'22:40
lekha+122:40
jrolllekha: random interesting idea - be able to mock a service like ironic-conductor that talks over a queue rather than http :)22:40
*** benhur_marcel has quit IRC22:40
* krtaylor heads over to etherpad to record 22:41
jrolland vice versa22:41
* jlvillal is glad to find out he was not the only one confused by the term 'functional testing' Since everyone who said it to him seemed to implied it was very well known and he should know it :)22:41
lekhajroll: we could do that, even maybe as part of another system like mimic. The idea of mimic was to add plugins and build the service catalog but we have been adding one off services as well22:41
jrolllekha: yeah, just a random idea I thought of :)22:42
lekhajlvillal: krtaylor : so we decided no devstack. That means we do all our testing against mimic?22:42
jrollthinking of a test like "hit this api, assert this message was put on the queue"22:42
jlvillallekha: To start with that sounds like a good plan. But I would like to get an idea of how Nova does it also. Maybe we can steal some ideas from them. Since they do not use mimic.22:43
jlvillallekha: Though I think mimic sounds like it might be better than what they do :)22:44
lekhajroll: doable, and sounds interesting.22:44
lekhajlvillal:22:44
krtaylorso for functional, I think we can define what it means, but standalone (without devstack)22:45
*** Sukhdev has quit IRC22:45
krtayloryes, I don't know why we need mimic, you all will have to headshape me for that one22:45
jlvillalkrtaylor: lekha wrote mimic so she can tell you best.22:46
jlvillalkrtaylor: It can pretend to be nova, or glance, etc...22:46
lekhajlvillal: krtaylor: Mimic replaces the nova , glance or any other openstack api22:46
lekhaIt is easy to use, by just replacing the keystone url with that of mimic's22:47
krtaylorbut the api service doesnt need to be tested, it is just stubbed out, or am I missing something22:47
* jlvillal has a hard stop on the hour.22:47
krtaylorjlvillal, me too22:48
*** benhur_marcel has joined #openstack-ironic22:48
lekhakrtaylor:mimic will be helping fake api services22:48
krtaylorlekha, that is tested in CI with devstack or stubbed out in unit tests22:49
jrollkrtaylor: ironic talks to glance/neutron/???22:49
jrollso yeah, we could use mimic or stub it out22:50
lekhajlvillal: krtaylor : while I am saying this about mimic, I am not sure what nova uses today to point the benefits of using mimic over that22:50
jlvillalMe either22:50
krtaylorsure, no I understand that, but nova doesnt test that part, it is up to dependencies that are tested elsewhere22:50
krtayloranyway, thats a minor point22:50
krtaylorregardless, to simplify, I think we just need to add tests to ironic/tests/*22:51
*** alexpilotti has quit IRC22:51
jrollI definitely like mimic from a client testing standpoint, fwiw, idk about server testing22:51
jlvillalironic/tests/functional/*22:51
lekhasure22:51
krtaylorI was going to start looking at test coverage functional or not22:51
jrollwe also need some $thing to stand up services22:51
jrollkrtaylor: I believe we have coverage running for unit tests22:51
jlvillalkrtaylor: What do you mean? How much of the code is actually run by our tests?22:52
jrollthough I'm not sure how, given we don't have a tox -e cover :) I've seen numbers22:52
* jlvillal remembers someone publishing statistics on that.22:52
krtayloroooh, good, thats saves me some time :)22:52
lekha+1 on reporting coverage22:52
jlvillalI think it was over 90% if I recall22:52
krtayloryeah, thats kinda needed as a baseline22:52
jlvillaljroll: Where you the one who posted the link about code coverage?22:52
jlvillals/Where/Were/22:53
jrolljlvillal: yeah22:53
* jlvillal should read his messages before he hits enter22:53
jrolllemme see what I can dig up22:53
krtaylorhehheh22:53
lekha:)22:53
jrollthere's a cross project thing to actually make a web page reporting it, but I believe we already have coverage reports uploading somewhere22:53
* jroll digs around the internet22:54
jlvillalkrtaylor: But it sounds like that there might be a use for adding a 'tox -ecover' at some point...  Maybe...22:54
jrollhttps://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L227422:55
jrollwe do run a report, it gets uploaded to infra22:55
jrollthis has a goal of publishing it https://review.openstack.org/#/c/221494/322:55
krtaylorjroll, this is good, I'll dive in here and digest this, thanks!22:57
jrollnp :)22:57
krtaylorok, cool, this helps me understand what we mean by functional - something that sits between unit and integration22:58
*** Sukhdev has joined #openstack-ironic22:58
krtaylorunfortunately I need to drop for a bit22:58
jlvillallekha: krtaylor Let's call it a meeting :)22:58
jlvillalThanks all!22:58
krtayloragreed22:58
jlvillalAnd jroll too :)22:58
lekhajlvillal: krtaylor : ok. thanks all22:58
krtaylorthanks everybody!22:59
jrollnp, thanks for working on this :)22:59
*** Sukhdev has quit IRC23:03
*** krtaylor has quit IRC23:05
*** Sukhdev has joined #openstack-ironic23:09
*** ijw_ has quit IRC23:10
*** ijw has joined #openstack-ironic23:11
*** jamielennox|away is now known as jamielennox23:13
*** bnemec has joined #openstack-ironic23:14
*** bnemec has quit IRC23:18
*** bnemec has joined #openstack-ironic23:18
*** Sukhdev has quit IRC23:25
*** Sukhdev has joined #openstack-ironic23:26
*** rloo has quit IRC23:33
*** harshs has quit IRC23:34
*** harshs has joined #openstack-ironic23:35
*** Sukhdev has quit IRC23:40
*** krtaylor has joined #openstack-ironic23:43
*** harshs has quit IRC23:45
*** garthb has quit IRC23:58
*** achanda has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!