Wednesday, 2015-09-23

devanandaI'd love the docs to be done and in the release -- but it matters more that they're online soon00:00
rloodevananda: ok, since no one can really use RAID now anyway, I won't consider those a high priority then.00:02
devanandaand I don't think we should even be considering a feature-release of the client at this point in Liberty just to add RAID support there00:02
devanandawell, and there's that ...00:02
rloodevananda: oh, too late to release a client00:02
devanandaif I understand it (and I'm not sure that I do) -- I would call the feature incomplete00:03
rloodevananda: yeah, if doc + client are part of the feature.00:03
devanandaeven though the REST interface is there, it's not really functional (because of zapping), the client doesn't support it, and it's not documented???00:04
devanandayea, it's not done00:04
rlooso maybe you/jroll can change the milestone on that BP00:04
*** tsekiyam_ has joined #openstack-ironic00:04
devanandajroll: would you agree with my assesment?00:05
*** jerrygb_ has joined #openstack-ironic00:05
*** mtanino has quit IRC00:07
*** tsekiyama has quit IRC00:08
*** jerrygb_ has quit IRC00:08
*** tsekiyam_ has quit IRC00:09
*** jerrygb has quit IRC00:09
openstackgerritJosh Gachnang proposed openstack/ironic-python-agent: Allow hardware managers to override clean step priority  https://review.openstack.org/18996900:09
*** naohirot has joined #openstack-ironic00:13
jrolldevananda: "generic raid interface" seems done to me, and needs a followup to be useful00:16
*** Guest18166 is now known as dims_00:17
jrollthe weird thing is there isn't RAID-specific code to be done to expose this through zapping00:17
jrollalso rloo: ^00:19
rloojroll: there is. just not generic raid.00:19
rloojroll: oh wait. zapping. thinking...00:19
devanandaso the spec lists zapping as a dependency00:19
devanandais it _not_ ?00:20
jrollrloo: I think the 'manual clean steps' are there, just need a way to trigger them00:20
rloodevananda, jroll: it is a dependency because yeah, as jroll says00:20
devanandajroll: right, so, the *interface* is done. but it's not usable00:20
jrollyar00:21
rlooright. which is why i wanted to try to get it into automated cleaning but we nixed that today.00:21
jrollit's a weird situation00:22
jrollwe basically decided to re-architect both of the ways it could be triggered00:22
jrollthis week.00:22
jrollso it should probably be untargeted, marked unimplemented or whatever00:22
rloowell... not sure we decided to rearchitect the automated cleaning part; we just couldn't resolve some issues in a timely fashion.00:22
*** shadower has quit IRC00:23
jrolland when zapping is marked done, it is done00:23
rloounless we decide to rearchitect cleaning which was one of the proposals...00:23
*** shadower has joined #openstack-ironic00:23
jrolllol00:23
jrollI'm not sure what we decided, other than defer to later00:23
jroll:)00:23
rloojroll: oh, i think it is going to be a duel between you and lucas. i'm taking bets now :)00:23
jrollhah00:24
jrolldevananda: it is untargeted, marked as 'good progress'00:25
* jroll pours one out for RAID00:25
devanandacool00:25
devanandaalso sad00:25
devanandathat is a cool feature :(00:25
rloojroll: maybe i should go through all the targetted features and punch holes in them to untarget them from L*00:25
jrolldevananda: also, zapping will just add the ability to trigger it, we still need drivers and/or agents to support it :D00:25
jrollrloo: :|00:26
rlooI'm so sad too. all that time reviewing the code ... (and I'm sure ramesh is even sadder)00:26
devanandajroll: yup yup. and docs and CLI support00:26
*** saripurigopi has joined #openstack-ironic00:26
devanandaand functional tests o.000:26
jrollhehe00:26
devanandajroll: were you preparing a patch to move completed specs to liberty/  ?00:27
jrolldevananda: it's on my todo list, if that counts00:27
devanandanp. I got it00:27
jroll\o/00:27
jrollI kinda wanna land the rest of the boot interface00:27
jroll(I say that without looking at the code first)00:28
*** ijw has quit IRC00:28
*** lucas-dinner has quit IRC00:28
devanandaI kinda do too00:28
devanandaexcept those patches are huge00:28
rloojroll: I looked earlier today. there were 4 patches. i couldn't do it.00:28
devanandatwo patches are ~1k lines each :(00:29
rlooI'm reviewed out wrt large patches. Need a break.00:29
jrollouch00:29
jrollmaybe not, then00:29
*** garthb has quit IRC00:30
devanandahuh .. wasn't this implemented before 4.1 ? http://specs.openstack.org/openstack/ironic-specs/specs/approved/enroll-node-state.html00:30
jrollyes00:31
devanandak. i'll bump that too, separate patch00:31
jrollI don't love this moving to liberty/ thing because it's super manual and we miss things like that00:31
jroll:(00:31
devanandalook at what nova's doing. I like this more, fwiw00:31
devananda(or dislike it less?)00:32
devanandait's manual, which means it's prone to error00:32
jrollwell, it looks like they do roughly the same thing, but at end-of-cycle?00:32
jrollI like their priorities docs in the specs repo00:33
jrollalso, our summit proposal list is still pretty short00:33
jrollhttps://etherpad.openstack.org/p/mitaka-ironic-design-summit-ideas00:33
jrollcan't decide if people aren't proposing things or we just don't have much to talk about or?00:33
jrollexactly 2.5 of these are user facing features, curious what that's indicitive of00:34
jroll(I totally butchered that word)00:34
jroll(maybe)00:34
devanandajroll: it's been light every previous cycle too00:34
devanandamaybe raise it at the meeting on monday00:35
jrollI feel like not this light, but idk00:35
jrollyeah00:35
devanandamost of that 'pad was done live during the meeting last week, I think00:35
rlooi don't think we run out of things to talk about at the summit00:35
jrollindeed00:36
jrollrloo: of course, it just feels less feature-heavy00:36
devanandarloo: no, but I don't htink we've done a great job planing / organizing them very well ahead of time00:36
rloodevananda: ++00:36
devanandaor perhaps the priorities spreadsheet is actually accurate and we all just have a bunch of work to do? :)00:36
jrollheh00:36
jrollbrb00:37
*** davideagnello has quit IRC00:37
devanandarloo: given the discussion around RAID this week, perhaps we should have a session on that00:37
rlooI feel like we didn't even accomplish what we discussed at last summit. i want to review those notes.00:37
devanandarloo: ++00:37
devanandaI know we didn't accomplish a lot of it00:37
rloore-architecting cleaning might be a topic if we can't resolve it before then.00:37
*** davideagnello has joined #openstack-ironic00:37
devanandaI think the midcycles have been more helpful than the summit for our design discussions for a while now00:37
rlooi wonder what the other projects think. summit vs mid-cycles. how to get the most out of summits, etc...00:40
openstackgerritDevananda van der Veen proposed openstack/ironic-specs: Update spec file locations for 4.2 / Liberty  https://review.openstack.org/22660600:41
*** achanda has quit IRC00:41
devanandajroll: oh weird! that publish job is not deleting old spec files??00:43
devanandaboth of these exist00:43
devanandahttp://specs.openstack.org/openstack/ironic-specs/specs/liberty-implemented/enroll-node-state.html00:43
devanandahttp://specs.openstack.org/openstack/ironic-specs/specs/approved/enroll-node-state.html00:43
devanandagit shows the correct things -- it was moved already -- http://git.openstack.org/cgit/openstack/ironic-specs/tree/specs/approved00:44
jrolldevananda: I have no clue, great question00:44
* devananda files a bug to track it, since it's late and I need to make dinner soon00:45
jrollI should also drop for the night00:48
*** ijw has joined #openstack-ironic00:48
jrollsee you tomorrow devananda, rloo00:48
devanandag'night!00:48
rloojroll: night00:48
*** davideagnello has quit IRC00:49
*** davideagnello has joined #openstack-ironic00:49
*** Sukhdev has quit IRC00:50
devanandahttps://bugs.launchpad.net/ironic/+bug/149870800:52
openstackLaunchpad bug 1498708 in Ironic "Implemented specs are moved but an old copy remains" [Low,Triaged]00:52
devanandaok - i'm out for the night as well... see ya tmw!00:52
*** ijw has quit IRC01:03
rloobye devananda. I'm going too. ciao everyone else :)01:04
*** rloo has left #openstack-ironic01:04
*** priteau has joined #openstack-ironic01:09
*** praneshp has quit IRC01:10
*** achanda has joined #openstack-ironic01:11
*** priteau has quit IRC01:14
*** puranamr has joined #openstack-ironic01:15
*** [1]cdearborn has quit IRC01:17
*** chenglch has joined #openstack-ironic01:32
*** puranamr has quit IRC01:40
*** jerrygb has joined #openstack-ironic01:44
*** jerrygb has quit IRC01:45
*** saripurigopi has quit IRC01:45
*** jerrygb has joined #openstack-ironic01:45
*** harshs has quit IRC01:53
*** dims_ has quit IRC01:57
*** baoli has joined #openstack-ironic01:57
*** dims_ has joined #openstack-ironic01:57
*** dims_ has quit IRC02:10
*** dims_ has joined #openstack-ironic02:13
*** dims__ has joined #openstack-ironic02:18
*** dims_ has quit IRC02:18
*** dims__ has quit IRC02:23
*** bizarrochristy has quit IRC02:29
openstackgerritMerged openstack/ironic: Make end-points discoverable via Ironic API  https://review.openstack.org/20589502:36
*** baoli has quit IRC02:37
*** baoli has joined #openstack-ironic02:38
*** early has quit IRC02:47
*** harshs has joined #openstack-ironic02:51
*** early has joined #openstack-ironic02:55
*** bizarrochristy has joined #openstack-ironic03:06
*** naohirot has quit IRC03:06
*** bizarrochristy has quit IRC03:07
*** boris-42 has quit IRC03:09
*** david-lyle has joined #openstack-ironic03:13
*** baoli has quit IRC03:32
*** olaph has quit IRC03:36
*** olaph has joined #openstack-ironic03:43
*** ijw has joined #openstack-ironic03:44
*** Marga__ has quit IRC03:46
*** Marga_ has joined #openstack-ironic03:46
*** dims_ has joined #openstack-ironic03:47
*** vinbs has joined #openstack-ironic03:48
*** ijw has quit IRC03:49
*** Marga_ has quit IRC03:50
*** shuquan has joined #openstack-ironic03:53
*** dims_ has quit IRC03:54
*** jcrubio has joined #openstack-ironic03:56
*** jerrygb has quit IRC03:56
*** garthb has joined #openstack-ironic03:57
*** shuquan has quit IRC03:58
*** jcrubio has quit IRC04:02
*** Marga_ has joined #openstack-ironic04:02
*** jcrubio has joined #openstack-ironic04:02
*** jcrubio has left #openstack-ironic04:03
*** naohirot has joined #openstack-ironic04:04
*** ijw has joined #openstack-ironic04:09
*** ijw has quit IRC04:09
*** ijw has joined #openstack-ironic04:09
*** rameshg87 has joined #openstack-ironic04:10
*** achanda has quit IRC04:17
*** jlk has joined #openstack-ironic04:20
*** jlk has quit IRC04:20
*** jlk has joined #openstack-ironic04:20
*** harshs has quit IRC04:26
*** Haomeng|2 has quit IRC04:34
*** Marga_ has quit IRC04:36
*** Marga_ has joined #openstack-ironic04:37
*** achanda has joined #openstack-ironic04:48
*** garthb has quit IRC04:55
*** praneshp has joined #openstack-ironic04:56
*** harshs has joined #openstack-ironic04:59
*** praneshp_ has joined #openstack-ironic05:06
*** praneshp has quit IRC05:09
*** praneshp_ is now known as praneshp05:09
openstackgerritNaohiro Tamura proposed openstack/ironic-python-agent: Fix default ironic api port number  https://review.openstack.org/22662605:11
*** Sukhdev has joined #openstack-ironic05:11
*** Sukhdev has quit IRC05:17
*** harshs_ has joined #openstack-ironic05:29
*** Haomeng has joined #openstack-ironic05:29
*** harshs has quit IRC05:30
*** harshs_ is now known as harshs05:30
openstackgerritRamakrishnan G proposed stackforge/proliantutils: Add logging for RIS and RIBCL modules  https://review.openstack.org/21963605:44
*** harshs_ has joined #openstack-ironic05:47
*** boris-42 has joined #openstack-ironic05:47
*** Sukhdev has joined #openstack-ironic05:48
*** harshs has quit IRC05:49
*** harshs_ is now known as harshs05:49
*** dims_ has joined #openstack-ironic05:50
*** harshs has quit IRC05:53
*** dims_ has quit IRC05:55
*** jerrygb has joined #openstack-ironic06:08
*** jerrygb has quit IRC06:12
*** Sukhdev has quit IRC06:28
*** romainh has joined #openstack-ironic06:40
*** yog_ has joined #openstack-ironic06:52
*** karimb has joined #openstack-ironic06:54
openstackgerritRamakrishnan G proposed stackforge/proliantutils: Add logging for RIS and RIBCL modules  https://review.openstack.org/21963607:02
*** praneshp has quit IRC07:09
*** achanda has quit IRC07:14
*** karimb has quit IRC07:15
*** karimb has joined #openstack-ironic07:16
*** karimb has quit IRC07:27
openstackgerritMerged stackforge/proliantutils: Add logging for RIS and RIBCL modules  https://review.openstack.org/21963607:31
*** karimb has joined #openstack-ironic07:32
*** ifarkas has joined #openstack-ironic07:32
openstackgerritShivanand Tendulker proposed openstack/ironic-python-agent: Fixes config drive creation failure in UEFI boot mode  https://review.openstack.org/21509707:36
*** dims_ has joined #openstack-ironic07:52
*** getvasanth has joined #openstack-ironic07:53
*** dims_ has quit IRC07:59
*** athomas has joined #openstack-ironic07:59
*** dtantsur|afk is now known as dtantsur07:59
dtantsurMorning Ironic07:59
getvasanthGood Monring dtantsur :)08:03
*** BobBall_AWOL is now known as BobBall08:04
*** derekh has joined #openstack-ironic08:13
*** lazy_prince has joined #openstack-ironic08:14
*** MattMan has joined #openstack-ironic08:14
*** lucas-dinner has joined #openstack-ironic08:19
*** lucasagomes has joined #openstack-ironic08:19
*** stendulker has joined #openstack-ironic08:20
*** priteau has joined #openstack-ironic08:22
*** romcheg has joined #openstack-ironic08:38
*** romcheg has quit IRC08:43
vdrokmorning ironic08:44
dtantsurvdrok, o/08:44
vdrokmorning dtantsur and getvasanth :)08:44
getvasanthvdrok: good morning08:45
*** pelix has joined #openstack-ironic08:46
*** athomas has quit IRC08:52
lucasagomesvdrok, dtantsur getvasanth good morning08:57
*** athomas has joined #openstack-ironic08:58
dtantsurlucasagomes, o/08:59
*** romcheg has joined #openstack-ironic09:05
vdrokmorning lucas-dinner09:06
vdrokor lucasagomes :)09:07
dtantsurunfortunately, it's not time for dinner :)09:07
lucasagomesoh hah not dinnering anymore09:07
lucasagomeslol09:07
*** lucas-dinner has quit IRC09:07
lucasagomesboom09:07
lucasagomesthat's my brother09:07
vdrok:D09:08
*** jerrygb has joined #openstack-ironic09:08
*** getvasanth has quit IRC09:10
openstackgerritMerged openstack/python-ironicclient: Added unit test cases for command-line shell  https://review.openstack.org/21365409:10
*** dims_ has joined #openstack-ironic09:11
dtantsurifarkas, morning! could you review https://review.openstack.org/#/c/225173 please? it's required to close our last bp for 2.2.009:13
*** jerrygb has quit IRC09:13
ifarkasdtantsur, sure, will do!09:13
*** e0ne has joined #openstack-ironic09:15
mrdahey all - I've put a patch up for the Ironic review dashboard so that it includes all ironic projects.  If you care about such things, here's the review: https://review.openstack.org/#/c/226592/ (just because you won't know about it unless I promote it in channel :)09:17
rameshg87mrda: so will all these projects start getting listed in the same ironic inbox ?09:21
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407909:21
xekdansmith, jroll, lucasagomes, ^09:22
lucasagomesthanks09:22
lucasagomesmrda, a-ha thanks for that!09:24
*** getvasanth has joined #openstack-ironic09:26
*** alexpilotti has joined #openstack-ironic09:32
*** vinbs has quit IRC09:33
sambettsMorning everyone o/09:36
*** vinbs has joined #openstack-ironic09:37
dtantsurmorning sambetts!09:38
lucasagomessambetts, hey there, morning09:44
*** dims_ has quit IRC09:44
sambettso/ dtantsur, lucasagomes hows it going?09:45
lucasagomessambetts, all is well! Few days away from holidays o/09:46
lucasagomessambetts, how are you?09:46
dtantsurpretty good, getting closer to the release09:46
sambettslucasagomes: Nice! You going anywhere?09:47
mrdarameshg87: yeah, they will all be grouped together (specs handled differently though)09:47
sambettslucasagomes: I'm pretty good thanks :)09:47
lucasagomessambetts, yeah, I'm going to Iceland09:47
lucasagomesgoing to drive around there and be away from technology for a couple of days09:47
rameshg87mrda: but will not that bundle all the project together09:47
sambettsdtantsur: Awesome :D09:48
sambettslucasagomes: That sounds sweet! I've never been to iceland before09:48
*** saripurigopi has joined #openstack-ironic09:48
dtantsurlucasagomes, oh Iceland, sounds really interesting09:48
rameshg87mrda: idk if it's only me, but personally I don't prefer that :)09:48
mrdarameshg87: Sure. It does this already for ironic server, client, and ipa09:48
lucasagomessambetts, dtantsur yea, I've never been there before either. But man, there's so many things to do09:48
mrdarameshg87: this just adds ironic-lib, inspector, webclient and bifrost09:49
lucasagomesreally 10 days is not enough, I don't know how many are required if you really want to see everything there09:49
rameshg87mrda: ironic server, client, ipa are part of core bucket. but webclient and birforst seem too distant09:49
*** e0ne has quit IRC09:49
sambettslucasagomes: you going to drive out to that huge volcano ? I think thats in Iceland09:49
mrdarameshg87: my motivation was to get ironic-lib in there, but the question remains for inspector, webclient and bifrost09:49
rameshg87mrda: yeah ironic-lib too I agree09:50
mrdarameshg87: so review comments welcomed :)09:50
saripurigopiHello Ironic09:50
*** e0ne has joined #openstack-ironic09:50
lucasagomessambetts, I'm going to do the "route 1" there, it pass some vulcanos but not sure about the biggest there09:50
rameshg87mrda: but inspector, webclient and bifrost in that list seems not good for me ..09:50
* lucasagomes will check09:50
rameshg87mrda: anyway I will add comments09:50
lucasagomessambetts, https://en.wikipedia.org/wiki/Route_1_%28Iceland%2909:50
mrdarameshg87: thanks09:50
rameshg87it's a personal choice anyway :)09:50
lucasagomesif possible I wanna do the golden circle thing as well (may take 1 full day)09:51
sambettslucasagomes: Oh man that looks so cool!09:51
lucasagomesyeah, looking fwd to it!09:52
* lucasagomes thinks we should have a midcycle in iceland one day :-)09:52
lucasagomesimagine that!09:52
sambettslucasagomes: Would certainly be different :-P09:53
lucasagomesyeah09:53
dtantsur:)09:55
*** naohirot has quit IRC10:01
*** dims_ has joined #openstack-ironic10:09
*** ndipanov has quit IRC10:09
*** ndipanov has joined #openstack-ironic10:11
*** degorenko has quit IRC10:13
stendulkerlucasagomes: Good morning ! Did you get a chance to look at the hybrid image thing?10:18
*** trown|outttypeww is now known as trown10:19
*** degorenko has joined #openstack-ironic10:19
lucasagomesstendulker, oh #@!% I haven't, will look at it now10:20
lucasagomesI forgot it10:20
stendulkerlucasagomes: oh ok..10:20
lucasagomesstendulker, I will do some tests on it now, sorry for that10:20
lucasagomesit's the core os images right?10:21
stendulkerlucasagomes: yes10:21
*** chenglch has quit IRC10:21
stendulkerlucasagomes: It worked in uefi mode with gdisk10:22
lucasagomesstendulker, oh, so we can replace parted with gdisk I suppose?10:22
stendulkerlucasagomes: OpenSUSE does not...10:22
lucasagomeswe already have an interface for image partitioning10:22
lucasagomesouch10:22
stendulkerlucasagomes: Yes. I did that.10:22
lucasagomesok...10:22
stendulkerlucasagomes: Have raised review withgdisk implementation. But can't claim its universal solution.10:23
lucasagomesI see, yeah parted doesn't seem to be either10:23
lucasagomesthat kinda sucks :-/10:24
stendulkerlucasagomes: Interestingly, openSUSE had worked with parted and does not work with gdisk10:24
lucasagomesit makes also me think about the propose we had before about having the configdrive in a loop device10:24
lucasagomesI still think it's a valid thing10:24
stendulkercoreos works with gdisk but not with parted10:24
lucasagomestho not all people may agree with me10:24
lucasagomesfwiw https://review.openstack.org/#/c/173142/10:24
stendulkerlucasagomes: looking into spec...10:25
lucasagomesstendulker, yeah most cores didn't agree with it10:26
* trown is super jealous10:26
lucasagomesI don't like the idea of injecting/editing stuff into user's images. But IMHO it's a valid case10:26
trownof the iceland trip that is...just realized I was lost in the scrollback10:26
lucasagomesas optional10:26
lucasagomestrown, heh yeah, but don't be man. You should plan one trip to there as well10:27
trownlucasagomes: there is no such thing as a vacation with kids :P10:27
stendulkerlucasagomes: your proposal looks good... it would solve all these issues where different distros would have used their own partitioning tools10:27
trownat least not little ones10:28
stendulkerlucasagomes: which may not be compatible with the deploy ramdisk distro partition tools10:28
lucasagomesstendulker, it's not actually mine10:28
lucasagomesbut yeah I think it's a fair solution for certain situations where partition is not an option10:28
stendulkerlucasagomes: oh yes..10:28
lucasagomeswhich can exist, like this one you're facing right now10:28
lucasagomesor deploying an image with MBR with 4 primary partitions already created10:29
lucasagomessuch things are valid situations where creating another partition is either impossible or not ideal10:29
lucasagomesIMHO10:29
stendulkerlucasagomes: May be it should be an option10:29
stendulkerlucasagomes: For images where partitioning fails, user can opt for loop device10:29
lucasagomestrown, oh, yeah you gotta wait them grow a little more10:29
lucasagomestrown, how old are they?10:30
lucasagomesstendulker, yeah, we can bring it up again with the rest of the people10:30
lucasagomesif you think that's a valid solution10:30
lucasagomesJayF, devananda ^10:30
trownlucasagomes: one is 1.5 and there is not another ... yet10:31
stendulkerlucasagomes: loop device is a valid option to get around such situations. Moreover with UEFI support increasing we may see more hybrid images10:31
lucasagomesstendulker, yup, tho the UEFI case surprises me a bit10:32
stendulkerlucasagomes: HYbrid images makes sense for operators as well wherein they need not main tain uefi only or bios only images10:32
lucasagomesif it was only UEFI with GPT I don't see much problems there10:32
lucasagomesthe hybrid seems complicated10:32
lucasagomesin theory GPT is hybrid but reality is diff AFAICT10:32
stendulkerlucasagomes: UEFI only images works fine with parted/gdisk.. tested using ubuntu uefi whole disk image10:32
lucasagomessome BIOS simple doesn't work with the private MBR of gpt10:32
lucasagomesbut hey...10:32
lucasagomestrown, nice one!10:33
*** trown is now known as trown|relocating10:34
lucasagomesstendulker, btw this is a good read about it http://www.rodsbooks.com/gdisk/bios.html10:34
stendulkerlucasagomes: sure10:36
lucasagomesstendulker, so yeah I think I would suggest you to comment on that spec let the author knows you are also good with the change10:41
lucasagomesand it would solve some of ur problems10:41
lucasagomesand bring up the discussion again with the rest of the community10:42
*** vinbs has quit IRC10:42
*** vinbs has joined #openstack-ironic10:44
*** Nisha has joined #openstack-ironic10:46
*** lucasagomes has quit IRC10:48
openstackgerritMerged openstack/ironic-inspector: Add missing plugins for introspection rules  https://review.openstack.org/22517310:51
stendulkerlucasagomes: sure, will do10:53
*** lucasagomes has joined #openstack-ironic10:53
stendulkerlucasagomes: thank you10:54
lucasagomesnp10:54
* lucasagomes connection just dropped :-(10:54
*** lucasagomes_ has joined #openstack-ironic11:00
*** lucasagomes_ has quit IRC11:01
openstackgerritMerged openstack/ironic-inspector: Allow empty lookup attributes if node_not_found_hook is provided  https://review.openstack.org/22566811:02
dtantsurmerge, merge, MERGE!!11:02
dtantsur:D11:02
*** ukalifon1 has joined #openstack-ironic11:04
dtantsurifarkas, sambetts, looking at https://launchpad.net/ironic-inspector/+milestone/2.2.0 I think we have good chances of finishing today, except for rootwrap patch. I think I'll update it myself, if I don't hear from Yuiko in a couple of hours, wdyt?11:05
ifarkasdtantsur, sounds good11:05
sambettsdtantsur: Yup sounds good to me :D11:06
dtantsuragreed :) I'd really like to see it all green by today evening11:07
sambettsdtantsur: What do you think about getting the alembic patch in for 2.2.0?11:07
sambettsI think it'll make people upgrading from 2.1.0 to 2.2.0 easier, because they'll need to add the rules tables, or will current model system just add rules anyway?11:08
dtantsursambetts, I think we're on track with it, just need 2nd +2. Some people will probably hate us for complicating upgrade just before Liberty final, but I guess it's worth it11:09
dtantsursambetts, with the current model, it will create missing table. However, as most people will anyway have to upgrade from discoverd, which is anyway painful....11:09
sambettsdtantsur: ah yes :/ I guess all peoples tooling will be written for the old binaries11:10
dtantsurI wonder if we need some kind of upgrade docs to cover it. At least cover discoverd-kilo to inspector-liberty11:11
*** lucasagomes is now known as lucas-hungry11:15
sambettsdtantsur: hmmm, its not dramically different in the way its run is it, so its most likely just ironic-discoverd is now ironic-inspector right? I guess theres the deprecated configs and stuff too :/11:15
dtantsursambetts, and client got split away, and plugin interface was changed, and deprecated API call was dropped11:16
sambettsdtantsur: XD I lose track of how many changes we made11:17
* dtantsur too11:17
sambettsCan we generate a change log between 1.1.0 and 2.2.0 from launchpad?? hmmmm ...11:18
*** baoli has joined #openstack-ironic11:23
*** ramineni_ has joined #openstack-ironic11:24
*** stendulker has quit IRC11:25
*** shakamunyi has quit IRC11:25
*** ramineni_ has left #openstack-ironic11:25
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Use rootwrap to execute iptables instead of requiring root  https://review.openstack.org/22393011:28
* rameshg87 goes home11:29
*** rameshg87 has quit IRC11:29
dtantsursambetts, ifarkas, the last patch is up ^^11:29
sambettsNice!11:29
dtantsurtrown|relocating, have a look at that change ^^ please, it might be important for packaging11:29
ifarkasdtantsur, excellent! I will do reviews later on11:30
dtantsurthanks11:30
*** saripurigopi has quit IRC11:32
*** baoli_ has joined #openstack-ironic11:33
*** jerrygb has joined #openstack-ironic11:35
*** baoli has quit IRC11:36
*** jerrygb has quit IRC11:39
*** jerrygb has joined #openstack-ironic11:48
*** getvasanth has quit IRC11:49
*** krtaylor has quit IRC12:01
*** achanda has joined #openstack-ironic12:03
*** ukalifon1 has quit IRC12:04
*** trown|relocating is now known as trown12:12
*** krtaylor has joined #openstack-ironic12:13
*** e0ne has quit IRC12:13
*** achanda has quit IRC12:18
*** lucas-hungry is now known as lucasagomes12:19
*** ukalifon has joined #openstack-ironic12:22
*** ionutbalutoiu has joined #openstack-ironic12:23
*** zhenguo has quit IRC12:24
*** caiobo has quit IRC12:29
ionutbalutoiuHello, guys! I'm doing some work with Ironic, focusing on the deployment of the service in standalone mode. I have a question: How does Ironic scale out ? Let's say you have 100 nodes each having their own services (ironic-api, ironic-conductor, dhcp server and tftp server). All nodes communicate with a central database. Are there any concerns I should be are of ?12:29
dtantsurionutbalutoiu, hi! you probably want to wait until jroll and JayF come online, they're operating ironic on scale12:35
ionutbalutoiuSure.12:36
dtantsurionutbalutoiu, I personally didn't quite get the question: do you want to have one ironic conductor per one node it manages?12:36
ionutbalutoiuI was planning to do that. I'm not sure how does ironic-conductor scales out.12:36
dtantsurionutbalutoiu, highly depends on a driver you're planning to use. even with the simplest pxe_ipmitool driver, one conductor can manage dozens of nodes12:37
dtantsurionutbalutoiu, using agent_ipmitool will reduce load on conductor (somewhat increasing network traffic).12:38
*** uggla_ has joined #openstack-ironic12:38
uggla_Hello12:38
dtantsurionutbalutoiu, if you have hardware supporting virtual media (only HP iLO and Fujitsu IIRC now), that will allow you to scale even better12:38
dtantsuruggla_, o/12:39
dtantsurionutbalutoiu, but one conductor per one baremetal node is not what you probably want in any case12:39
lucasagomesionutbalutoiu, scaling out the conductor should be simple, Ironic will already distribute the workload across the conductors dynamically12:40
lucasagomesionutbalutoiu, for api can put it behind a HA proxy12:40
dtantsurionutbalutoiu, also if you don't use virtual media, use iPXE, not PXE12:40
lucasagomesionutbalutoiu, and yeah, as dtantsur says. One conductor is capable of managing many nodes at the same time with different drivers and all12:41
ionutbalutoiulucasagomes, tantsur, if the node with the single conductor fails, I will probably have problems. As far as I understand, I can have multiple conductors managing the same pool of nodes and Ironic distributes the workload. lucasagomes, do you know how Ironic does this distribution ?12:44
lucasagomesionutbalutoiu, yes we use a distributed hashing algorithm. So you can have multiple conductors able to manage the same types of nodes (based on the driver they use)12:45
lucasagomesbut there's always 1 conductor managing each node and it's dynamic12:45
lucasagomesif that conductor dies, ironic will rebalance the ring and another conductor able to manage nodes with that driver will take over that node12:45
lucasagomesconductors can join and leave the cluster and Ironic will dynamically balance ir12:46
lucasagomesit*12:46
ionutbalutoiuWhen a conductor comes up, it is registered in the database and Ironic is aware of it.12:48
lucasagomesionutbalutoiu, the module is this one if you are interested https://github.com/openstack/ironic/blob/297f14469d23dd793de625251366380cc648fdb2/ironic/common/hash_ring.py12:48
lucasagomesionutbalutoiu, yes, a conductor comes up and register itself in the database along with the drivers it have enabled12:49
lucasagomesso when a request comes to the API to a specific node the ironic-api service will know how to route that message to a conductor that is able to manage that node12:49
lucasagomesit uses the node uuid as a hash12:50
lucasagomesand there's a hash ring per driver type12:50
*** rloo has joined #openstack-ironic12:51
*** albertoffb has joined #openstack-ironic12:53
ionutbalutoiuThat's pretty cool. So, I shouldn't be worried about high availability. From what I understand, Ironic already takes care of it in a scenario with multiple ironic-conductors and a central database.12:54
*** Nisha has quit IRC12:54
lucasagomesionutbalutoiu, yes, HA for the ironic conductor is embedded in it12:54
lucasagomesionutbalutoiu, you should care about the API, but that's pretty standard12:54
lucasagomesput it behind a HA proxy or something12:54
ionutbalutoiuYep. That was clear already. Thank-you guys. :)12:54
lucasagomesyw12:55
lucasagomesionutbalutoiu, there's a couple of videos on youtube from previous summits where devananda (and maybe others) have talked about how it works12:55
lucasagomesyou may want to check12:55
lucasagomesironic was designed that way so this feature is been around since the beginning12:56
lucasagomesionutbalutoiu, here https://www.youtube.com/watch?v=vjGPuBfZ87A#t=103112:57
ionutbalutoiulucasagomes, Awesome! I'll check them out for sure. Thanks12:57
lucasagomescool np12:57
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407912:58
ionutbalutoiuI do have another question if you don't mind guys.12:58
lucasagomesionutbalutoiu, ask away12:58
*** rbudden has joined #openstack-ironic12:58
ionutbalutoiuSo, we have only neutron as dhcp_provider for Ironic, right? But if using I'm using it in standalone, I have to take care of the dhcp reservation and such.12:59
lucasagomesionutbalutoiu, yes, dhcp providers (as we call it) is pluggable. But currently we only have 2 plugins in tree "neutron" and "none" (which is no-op)13:00
ionutbalutoiuI'm trying to write a dhcp_provider using dhcpd from Linux to be used by Ironic in standalone.13:00
lucasagomesionutbalutoiu, so if you use "none" you may be looking at using a static PXE configuration file that will boot the deploy images onto the node13:01
lucasagomesbut you can also implement an interface for another dhcp server you may have13:01
lucasagomesionutbalutoiu, right13:01
lucasagomesionutbalutoiu, https://github.com/openstack/ironic/blob/master/ironic/dhcp/base.py13:01
lucasagomesI'm not sure how mature is that interface, because we only have 1 implementation right now13:01
lucasagomesso it would be good to have more :-)13:02
ionutbalutoiuCool, life's good. But I don't get any trigger for any of the methods when a node is deleted.13:02
ionutbalutoiuEverytime I create an Ironic node, I make an a dhcp reservation for it and reload the dhcpd service.13:03
* lucasagomes checks that bit13:04
ionutbalutoiuI would like to delete the dhcp reservation when the node is deleted and reload the dhcpd service again. But unfortunately I don't get any trigger on delete.13:05
trowndtantsur: no more packaging changes after the alembic patch for a bit ok :P13:05
dtantsurtrown, rootwrap change is pretty trivial: adds one more executable and one more configuration file. after it we no longer need to run inspector as root, which is a good thing IMO13:07
trowndtantsur: ya rootwrap one is not so bad, alembic requires more puppet though13:08
trownbut both are good changes13:08
dtantsurtrown, https://launchpad.net/ironic-inspector/+milestone/2.2.0 is all we want to land before 2.2. doesn't look like we have anything else concerning13:08
lucasagomesionutbalutoiu, that sucks :-( yeah I skimmed a bit here it seems that we just call update_dhcp() in prepare_instance() or prepare_ramdisk()13:09
lucasagomesionutbalutoiu, that may because nova will delete the neutron network for us (when used with neutron)13:09
lucasagomesand none well... it doesn't do anything13:09
*** [1]cdearborn has joined #openstack-ironic13:09
ionutbalutoiuyep, neutron takes care of deleting the dhcp reservation when an instance is deleted13:09
lucasagomesionutbalutoiu, perhaps that's something that needs to be added to that interface, at the clean_up() methods we should call some sort of delete13:09
lucasagomesionutbalutoiu, yeah... see, that's why we need more dhcp implementations13:10
ionutbalutoiulucasagomes, yep I agree, that would be good.13:10
lucasagomesionutbalutoiu, mind opening a bug about it please?13:10
trowndtantsur: cool, pretty close on all of those13:10
ionutbalutoiulucasagomes, not at all.13:10
lucasagomesionutbalutoiu, thanks much!13:10
lucasagomesionutbalutoiu, the fix should be straight forward, the same way we have prepare_{instance, ramdisk}() methods for the boot interfaces such as pxe13:11
openstackgerritVasyl Saienko proposed openstack/ironic-specs: Using multicast for image transfer  https://review.openstack.org/22557013:11
lucasagomeswe also have the clean_up_{instance, ramdisk}() methods where the delete hooks should be called13:11
lucasagomesthey both get the "task" object as parameter which gives you access to the whole node and all it's ports objects13:12
ionutbalutoiulucasagomes, I agree. At the moment, I have the implementation so when a node is created I do the clean_up(). Hackish, but does the job for the moment.13:13
openstackgerritVasyl Saienko proposed openstack/ironic-specs: Using multicast for image transfer  https://review.openstack.org/22557013:14
ionutbalutoiulucasagomes, still I will have the dhcp reservations until a node is created, no matter how many nodes are deleted meanwhile.13:14
lucasagomesionutbalutoiu, cool! That would be great if you could polish it a bit and submit upstream :-)13:14
* lucasagomes will gladly review it13:14
ionutbalutoiulucasagomes, Sure, I need to finish the implementation when the clean_up() method is merged. :)13:16
lucasagomes++ thanks again13:16
*** thiagop has joined #openstack-ironic13:16
ionutbalutoiulucasagomes, I'm going to open the bug. Thank-you for all your help.13:16
thiagopMorning folks13:17
lucasagomesionutbalutoiu, yvw, cheers for looking into it13:17
lucasagomesthiagop, morning13:17
thiagoplucasagomes: o/13:18
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407913:18
*** dims_ has quit IRC13:21
*** dims_ has joined #openstack-ironic13:21
*** alexpilotti has quit IRC13:22
openstackgerritMerged openstack/ironic-inspector: Use rootwrap to execute iptables instead of requiring root  https://review.openstack.org/22393013:22
dtantsur\o/  3 patches to go13:23
*** olaph has quit IRC13:28
openstackgerritLucas Alvares Gomes proposed openstack/python-ironicclient: Allow 'abort' verb for node-set-provision-state  https://review.openstack.org/20218413:28
sambettsdtantsur: w00p!13:30
*** vinbs has quit IRC13:31
*** bradjones has quit IRC13:35
ifarkasdtantsur, 3? not just 2?13:38
dtantsurifarkas, now only 2 left: https://review.openstack.org/225658 and https://review.openstack.org/22366513:39
*** ukalifon has quit IRC13:39
dtantsur:)13:39
ifarkasdtantsur, same here :-)13:39
ionutbalutoiulucasagomes, Bug submitted: https://bugs.launchpad.net/ironic/+bug/149892313:39
openstackLaunchpad bug 1498923 in Ironic "No clean up method for the dhcp provider base class" [Undecided,New]13:39
lucasagomesionutbalutoiu, thanks!13:40
*** olaph has joined #openstack-ironic13:41
*** lsmola has quit IRC13:41
dtantsursambetts, ooops! alembic patch needs rebasing13:42
sambettsdtantsur: :-P i can guess its because of the setup.cfg changes made my rootwrap13:42
dtantsuryeah, I suppose so13:42
sambettsdtantsur: just toxing then I'll git review13:45
dtantsurthanks13:45
openstackgerritSam Betts proposed openstack/ironic-inspector: Add alembic migrations for the inspector database  https://review.openstack.org/22366513:46
dtantsurawesome! I'll wait for Jenkins before re +213:46
sambetts:D13:49
*** lsmola has joined #openstack-ironic13:50
*** e0ne has joined #openstack-ironic13:51
*** romcheg has quit IRC13:55
liliarshi ionutbalutoiu, lucasagomes :) so if I understood the situation correctly, I may have had a similar issue, but not using ironic standalone; sometimes when deleting an instance in error state (if I recall correctly), the neutron-port wouldn't be deleted as expected, and in a next deployment I would get "port already in use" or something14:00
liliarshad to delete the neutron-port manually so I could still use the same node-port for deployment; it's not a regular behaviour so I don't know if it was any network failure from my side (?) or a bug on the code (nova or ironic); not sure if other folks have experienced this too14:00
lucasagomesliliars, oh, and you're using nova as well?14:01
sambettslucasagomes: I think one of my colleages saw that too at one point recently14:02
lucasagomesI haven't seem that particularly, but it wouldn't surprise me if that happens when deleting a node in error state14:03
*** jerrygb has quit IRC14:03
*** afaranha has quit IRC14:03
*** romcheg has joined #openstack-ironic14:03
liliarslucasagomes, yes using nova14:04
lucasagomessambetts, right, and where did it fail? At deployment time ("deploy error") or instance tear down (I think it's just "error") ?14:04
lucasagomesliliars, ^14:04
lucasagomesyou remember?14:04
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements  https://review.openstack.org/22680514:05
openstackgerritMerged openstack/python-ironicclient: Set a default endpoint value of None  https://review.openstack.org/22647514:06
liliarslucasagomes, deployment time; when I tried a new deployment with the same node/node-port then I got the "port already in use" error; and when I checked the neutron ports list, the port was really still there14:06
*** jerrygb has joined #openstack-ironic14:07
lucasagomesliliars, right, yeah odd looking at the nova code it seems to call _unprovision() for nodes in error state https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L909-L91014:08
lucasagomesliliars, sambetts yeah I will have to investigate more see if I can reproduce that14:08
lucasagomesI dunno off the top of my head14:08
lucasagomesbut it's good to know it's possible14:08
* lucasagomes would be good to have a bug about it too, but will need some more info for that14:08
lucasagomesthinks it would be good*14:09
xekdansmith, jroll, lucasagomes, jenkins just finished on https://review.openstack.org/22407914:10
sambettsYeah, I didn't get much more info, other than he asked me if I had ever seen it happen before, I put it down to his env (because he was having other weird issues anyway), so I didn't dig much deeper14:10
lucasagomesyeah that's fair enuff, and good that at least there's a workaround for that (deleting the port)14:12
openstackgerritMerged openstack/ironic-inspector: Convert eDeploy data so that rules can process it  https://review.openstack.org/22516814:13
sambettslucasagomes: Yeah, its a fairly simple fix :)14:13
*** mtanino has joined #openstack-ironic14:13
rloohi iroKnickers14:13
rlooanyone know if yuiko is around these days?14:14
rloodtantsur: ^^ ?14:14
dansmithxek: I guess I never saw a decision from jroll14:15
liliarslucasagomes, yeah I'm sure about the neutron-port not being deleted at some point, but not really sure about the exact scenario;  I'm gonna try to reproduce it too (: thanks14:15
thiagopmorning rloo14:16
*** romcheg has quit IRC14:16
liliarsmorning rloo14:16
dtantsurrloo, hi! haven't seen you for some time, and she wasn't reviewing code as well14:16
rloohi thiagop, liliars14:16
*** afaranha has joined #openstack-ironic14:16
rloodtantsur: am wondering if she's on vaca. ok, there's a bug/patch she's working on that we'd like in, so maybe i'll finish it.14:17
sambettsrloo: Last thursday was the last time I saw her on here14:17
rloosambetts: thx.14:18
TheJuliadevananda: Woud you be awesome and add me to the bifrost-release group?14:18
TheJulias/Woud/Would14:18
*** harshs has joined #openstack-ironic14:18
lucasagomesliliars, thank you for looking into it14:19
lucasagomesrloo, TheJulia morning14:19
rloohiya lucasagomes, morning TheJulia. (Could deva be more awesome than he already is?)14:20
TheJuliagood morning lucasagomes, good morning rloo14:20
sambettso/ TheJulia14:21
TheJulia(That is quite a question.... I suspect there is always room for increased awesomeness, then again there are certain curses that go along with being awesome.....)14:21
thiagopxek: wow, I'm really trying to review this indirection_api thing, but it's complex14:22
*** romcheg has joined #openstack-ironic14:25
jrollionutbalutoiu: some scale notes: at rackspace onmetal we run around 250 nodes per conductor, if that's a helpful number. we also manage dhcp/tftp outside of ironic with static configs, and serve the ramdisk over http rather than glance14:26
jrollmorning everyone14:26
thiagopmorning jroll14:27
dtantsurjroll, morning14:27
rlooTheJulia: :D14:27
ionutbalutoiujroll, morning. Cool stuff. :)14:27
xekjroll, afternoon ;)14:27
rloomorning jroll14:27
jrollso active today \o/14:28
jrollxek: this channel is UGT :D http://www.total-knowledge.com/~ilya/mips/ugt.html14:28
sambettso/ jroll14:28
lucasagomesjroll, morning14:28
jrolldansmith: I think I am going to land that, would love a quick review from you if you have bandwidth14:29
* jroll also reviews14:29
xekjroll, :D14:30
rloojroll: question about the 'topic' parameter.14:30
dansmithjroll: okay cool14:30
jrollrloo: mhmmm?14:30
rloojroll: wrt xek's patch. I'm fine deleting that, or not. but if not, the comment doesn't say much to me.14:30
rloojroll: topic isn't used. so what? should it be used, should it be deleted?14:31
lucasagomestopic for RPC? that's how we route messages from API to a specific conductor14:32
rloojroll: 'FIXME(xek): The topic argument is actually never used.'. What's the fix?14:32
lucasagomeswhy it's not being used?14:32
* lucasagomes checks the patch14:32
rloolucasagomes: https://review.openstack.org/#/c/224079/17/ironic/conductor/rpcapi.py14:32
jrolllucasagomes: because these don't need to be a specific conductor14:32
lucasagomesjroll, so it will default to the generic topic?14:33
jrolllucasagomes: yes, and any conductor will pick it up AIUI14:33
rloolucasagomes: right.14:33
lucasagomes(the one not using the cond. hostname)14:33
lucasagomesok14:33
rloolucasagomes, jroll: the FIXME comment doesn't make sense to me.14:33
jrollwhat I'm wondering is if some conductors are on version X, and some are on Y, where Y > X, if there's a case to be had there14:33
jrollI don't think there is14:34
rloolucasagomes, jroll: it may not be used 'now' cuz it is None, but it IS used, just that it is None. If it wasn't None, it'd be used.14:34
lucasagomescctxt = self.client.prepare(topic=topic or self.topic, version='1.31')14:34
lucasagomesseems it's being used?14:34
lucasagomesat least within that function scope14:34
jrollright, so the FIXME is it could be prepare(self.topic...)14:34
rloolucasagomes: exactly. that's why the comment doesn't make sense.14:34
jrollit's not used by any callers14:34
rloojroll: that's a dangerous thing to say cuz code changes and a caller could use it.14:35
lucasagomeswell that's outside that execution body14:35
lucasagomesin that method POV it's used14:35
rlooif we don't want to use it, as dan sez, we should delete it14:35
jrollrloo: right, it's more that a caller shouldn't be using it14:36
rlooif we think we want to use it, we should leave it and update the comment.14:36
rloojroll: i don't think we can say 'we have this argument but please don't use it'14:36
jrollyeah, it's silly14:36
jrollhere's what I'm wondering:14:36
lucasagomesrloo, bad interfaces14:36
jrollif API makes a call to a specific conductor for a node14:36
jrolland then needs to translate that response14:37
lucasagomesbut, if we have to pass topic and we don't want it to be used14:37
jrollshould it go to any conductor or that specific one?14:37
jrollI think any conductor is fine in all cases14:37
rloojroll: why does it matter which conductor?14:37
lucasagomeswe perhaps could put a fix me there and error out if "topic is not None"14:37
jrollI'm wondering if there's a case where it's not fine14:37
jrollwhere conductors have different versions14:37
jrollbut maybe we just say different versions of conductors isn't supported14:37
lucasagomesjroll, hmm yeah, well when an upgrade is going on14:37
lucasagomesyou may have different versions of conductors at the same time14:38
jrollright14:38
rloojroll: that's an interesting point.14:39
lucasagomesalso if topic should not be used, perhaps it should be indicated in the docstring14:39
lucasagomes"not used by this method"14:39
jrollI guess it's more like, I don't want to change this method signature later if we decide we need it14:39
jrollbut I'm 99% sure we don't need it14:39
devanandag'morning, all14:39
rloomy suggestion then is to leave topic in (cuz it doesn't hurt) but change the comment14:39
sambettsMorning devananda14:40
rloomornin' devananda14:40
thiagopgood morning devananda14:40
xekrloo, maybe to something like "FIXME: currently no caller of this method is using the topic argument"14:40
TheJuliagood morning devananda14:40
lucasagomesrloo, ++14:41
lucasagomesxek, I think it's fine to just delete that comment to be honest14:41
lucasagomesdevananda, morning14:41
rloojroll, lucasagomes: :param topic: RPC topic. Defaults to self.topic. In most cases, the default should be used since any conductor should be able to handle this.14:41
jrolllucasagomes: I agree, no need for a FIXME14:41
rlooxek ^^14:41
jrollrloo++14:41
xeklucasagomes, I already run tox on the code without the topic, so it's fine either way14:42
lucasagomesxek, right, I mean it has a use14:42
lucasagomeseven if the current callers are not using it14:42
rlooxek: the point is that the FIXME comment is confusing cuz there isn't anything to fix.14:42
lucasagomesso the FIXME makes no sense there14:42
thiagopxek: If you'll send another patch, I'd vote for better exception messages14:43
lucasagomesbut code wise it seems good14:43
devanandajroll: what if different conductors have different drivers loaded?14:43
xeklucasagomes, rloo, jroll, ok, I'm adding the above param description and deleting the fixme comment14:43
thiagopxek: let me know if you'll send another one14:43
*** r-daneel has joined #openstack-ironic14:43
lucasagomesxek, thanks14:43
jrolldevananda: that shouldn't matter for object version translation, right?14:43
rloothx xek!14:43
*** aarefiev has quit IRC14:43
jrolldevananda: maybe later, if we object-ify driver things, idk14:44
devanandajroll: right14:44
devanandathe subresources like driver-info, driver-internal-info14:44
devanandaarchitecturally speaking, I think it could matter, though it may not today14:44
jrollyeah, so I think leaving it is a good idea14:44
jrollour conductor isn't just an orchestration thing like nova's14:45
devanandaright14:45
dansmithjroll: xek: why are we still adding this method with a topic argument?14:45
devanandanova's conductor is more of a database proxy14:45
devanandawhereas our API service accesses the DB directly when it can14:45
jrolldansmith: because conductors can be tied to a given node, and may have different drivers loaded14:46
dansmithdevananda: our api accesses the db directly as well, and our conductor does more than db proxy, it also runs longer tasks14:46
jrolldansmith: no topic argument is probably ok now but I don't want to change the method signature later if we need it14:46
dansmithjroll: but we never pass anything but None14:46
xekdansmith, It would be actually pretty cool to support the scenario when conductors run with different versions14:46
jrolldansmith: *today*, yes14:46
devanandadansmith: in some situations, there may be only one conductor which can evaluate certain methods for a node, such as validating the driver_info14:46
dtantsurmorning, devananda14:46
dansmithjroll: this isn't on-the-wire api, so I'm not sure why we wouldn't just add it once it's required, if that day comes, but okay14:47
jrolldansmith: true14:48
rloodansmith: there are pros/cons to both approaches. One other thing is that all the other RPC calls (I think) have that topic argument, and if we remove it, i can just see someone submitting a patch to add it in.14:48
*** harshs_ has joined #openstack-ironic14:48
dansmithrloo: well, that patch would be silly, in the absence of some use of it :)14:48
dansmiththe other thing is,14:48
dansmithI'm not really sure how you're going to go from an arbitrary object to the topic that you need to send the request to14:49
rloodansmith: yeah. but folks have a short memory. whatever we do, we need to comment.14:49
dansmithso I think there's likely more machinery around this required to make it work anyway14:49
*** aarefiev has joined #openstack-ironic14:49
jrolldansmith: yeah that was my next question :)14:49
dansmithrloo: I meant, I would hope that nobody would +2 a patch to add a thing that is not used :)14:49
rloodansmith: so would I but really, have you never seen a +2 for something that maybe shouldn't?14:49
*** harshs has quit IRC14:50
*** harshs_ is now known as harshs14:50
rloodansmith: besides, why add all that extra overhead of someone submitting a patch and reviewers looking at it. nip it in the bud.14:50
*** garthb has joined #openstack-ironic14:50
dansmithrloo: of course, accidents happen, but I can't say I've seen something approved where someone added an argument to a function for no reason.. but, whatever, I'm not opposed to comments of course :)14:50
jrolldansmith: look at you all persuasive, I think I agree with you now14:52
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407914:52
jrollthe main point being we'll need more infra to sanely pass a topic14:52
dansmithyep14:52
rloodansmith: I have seen +2, and either it wasn't documented and the others knew or didn't. but i had to ask why and the initial answer was cuz it was inconsistent. the next was 'it could be used', and the following was 'i'd like to use it in case blah'. I'm not quite sure if that case blah has shown up yet but i think the patch was approved.14:52
dansmithrloo: heh, fair enough..14:53
dansmithanyway, I don't really have a voice here, I'm just throwing in my two cents.. happy to +1 it as is if that's the consensus14:53
rloodansmith: well, you do have a voice and we are listening. I'm happy either way, just want it to be clear in the code/comments.14:55
xekrloo, I addressed your other nits14:55
rloothx xek, looking...14:55
dansmithrloo: I just meant "I ain't tryin' to tell ya'll how to run yer project" :)14:56
*** mgoddard has quit IRC14:56
rloodansmith: OH. yeah, that's probably a good thing. Although I'd listen to that too, if it is an improvement :)14:56
jrolldansmith: get off our lawn :D14:57
dansmith:)14:57
* xek pushed ctrl+C when jroll seemed to change his mind but didn't make it14:57
jrolllol14:57
jrollxek: I think we probably should remove it for now, and add it when we need it14:57
rlooxek, ha ha. you copied dan's 'oslo.messaging fu' !14:57
rloojroll: ++14:58
dansmithrloo: you told him to and he followed directions :)14:58
jrollxek: can you do that so I don't have to waste a -1 on that patchset?14:59
jrollsorry for the run-around :(14:59
xekjroll, ok14:59
rloodansmith: guess i wasn't explicit enough. at least it was only 'fu'.14:59
jrollI'm running low on -1s for this cycle14:59
jrollneed to find someone to borrow from14:59
rloojroll: you serious? you want to remove topic?14:59
thiagopI'd like to read more about how this rolling update feature is supposed to work. Any reading suggestions?14:59
jrollrloo: yeah, to be useful it's going to take quite a bit of work15:00
*** mgoddard has joined #openstack-ironic15:00
rloojroll: ok. dansmith gets his wish.15:00
jrollheh15:00
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407915:01
openstackgerritMerged openstack/ironic-python-agent: Fix default ironic api port number  https://review.openstack.org/22662615:04
rlooxek: I commented. I did mention that I wanted a comment either way.15:06
*** romcheg has quit IRC15:08
*** bizarrochristy has joined #openstack-ironic15:09
*** karimb has quit IRC15:09
*** karimb has joined #openstack-ironic15:09
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407915:10
xekrloo, rloo ^15:11
rlooxek, you are fast. i just commented on 'fu', but that isn't a big deal cuz it is associated with dan.15:11
*** romcheg has joined #openstack-ironic15:12
*** penick has joined #openstack-ironic15:14
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements  https://review.openstack.org/22680515:14
dansmithrloo: heh15:15
rloodansmith: I feel like I have only so many 'nit' credits ;)15:16
dansmithheh15:16
*** uggla_ has quit IRC15:17
xekhttp://www.urbandictionary.com/define.php?term=google-fu - oslo.messaging fu should be right up there15:17
*** amotoki has quit IRC15:17
rlooxek: wow, didn't realize that existed.15:18
rlooxek: ahh, for kung fu. Ok, that's probably what dansmith meant then, not the other fu. It is OK then!15:19
dansmithrloo: oh, yeah, sorry.. a lot of people mess it up by using "foo", but ${thing}-fu means "skills at $thing"15:19
*** garthb has quit IRC15:20
*** garthb has joined #openstack-ironic15:20
rloodansmith: i'm not 'up' on american slang.15:20
dansmithheh15:20
*** amotoki has joined #openstack-ironic15:20
*** lazy_prince has quit IRC15:22
*** tsekiyama has joined #openstack-ironic15:24
*** harshs has quit IRC15:26
*** puranamr has joined #openstack-ironic15:35
*** Sukhdev has joined #openstack-ironic15:38
*** yog_ has quit IRC15:46
*** penick has quit IRC15:46
*** e0ne has quit IRC15:47
*** puranamr has quit IRC15:47
*** e0ne has joined #openstack-ironic15:48
*** Nisha has joined #openstack-ironic15:48
*** puranamr has joined #openstack-ironic15:50
*** bizarrochristy has quit IRC15:52
*** ijw has quit IRC15:56
*** yuriyz has quit IRC15:57
*** sdake has joined #openstack-ironic15:57
*** garthb_ has joined #openstack-ironic16:00
*** trown is now known as trown|lunch16:00
*** ukalifon1 has joined #openstack-ironic16:00
*** ukalifon1 has left #openstack-ironic16:00
*** yuriyz has joined #openstack-ironic16:01
*** lazy_prince has joined #openstack-ironic16:01
openstackgerritKurt Taylor proposed openstack/ironic: Unit test environment setup clarification  https://review.openstack.org/22644516:02
*** mgoddard has quit IRC16:02
*** garthb has quit IRC16:02
*** mgoddard has joined #openstack-ironic16:03
*** sdake has quit IRC16:04
openstackgerritRuby Loo proposed openstack/ironic: Use standard locale when executing 'dd' command  https://review.openstack.org/21647816:06
*** sdake_ has joined #openstack-ironic16:07
devanandaTheJulia: added you to bifrost-release. anyone else I should include?16:08
TheJuliadevananda: not at this time, thank you!16:10
*** karimb has quit IRC16:10
*** sdake has joined #openstack-ironic16:11
*** bizarrochristy has joined #openstack-ironic16:12
xekjroll, lucasagomes, rloo, looks like tempest is timing out on  boot_instance() https://jenkins07.openstack.org/job/gate-tempest-dsvm-ironic-pxe_ssh/2016/console16:13
dtantsuroh, so ironic-inspector is not the only broken?16:13
jrollxek: that's an occassional failure we have, unless something just broke16:13
dtantsur2 of our patches just timed out when booting a node16:13
jrollogod16:13
jrollno16:13
jrollpls16:13
dtantsurI first thought we broke something in inspector, but everything before nova boot looks sane16:14
dtantsuranyone knows how to decode http://logs.openstack.org/05/226805/2/check/gate-ironic-inspector-dsvm/31ff507/logs/ironic-bm-logs/baremetalbrbm_0_console.txt.gz16:14
dtantsur?16:14
*** sdake_ has quit IRC16:14
lucasagomes:-(16:14
lucasagomesdamn we had many gate breakages recently :-/16:15
jrolldtantsur: I'm not sure it gives any useful info right now, I've been meaning to fix that16:15
jrolldtantsur: that basically means it didn't boot up right, see normal output: http://logs.openstack.org/01/226201/3/check/gate-tempest-dsvm-ironic-agent_ssh/6774602/logs/ironic-bm-logs/baremetalbrbm_0_console.txt.gz16:16
jrollI think it just hangs when it fails16:16
jrollsame junk, and then it boots16:17
*** amit213 has quit IRC16:17
*** amit213 has joined #openstack-ironic16:17
rloojroll, lucasagomes, xek, dtantsur: it's been timing out 'randomly'. i have a note in the etherpad about it.16:18
jrollyeah16:18
lucasagomesright16:18
dtantsurok, I'll check locally if latest inspector has some problems...16:18
jrolldtantsur: I don't know what inspector changes you could make that would make ramdisk boot hang like that :P16:19
jrolland also affect normal pxe_ssh job16:20
dtantsurwe definitely couldn't affect normal pxe_ssh job :) we could break something around our firewall logic, but I don't see any errors in logs...16:20
*** romainh has left #openstack-ironic16:20
sambettsnoo :(16:21
dtantsurbut all changes passed the gate, so I really doubt...16:21
*** Sukhdev has quit IRC16:29
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: devstack: allow nodes to be already MANAGEABLE in exercise  https://review.openstack.org/22687316:29
*** garthb_ has quit IRC16:30
*** garthb has joined #openstack-ironic16:30
*** Sukhdev has joined #openstack-ironic16:31
dtantsurhmm, I've updated inspector on my devstack, and nova boots nodes correctly16:35
dtantsurI'll figure out tomorrow, if it does not self-heal16:35
dtantsurc u16:35
*** dtantsur is now known as dtantsur|afk16:35
*** praneshp has joined #openstack-ironic16:39
sambettsdtantsur|afk: cya later16:40
*** nicodemos has joined #openstack-ironic16:41
*** Sukhdev has quit IRC16:43
*** Sukhdev has joined #openstack-ironic16:46
*** Sukhdev has quit IRC16:47
*** puranamr has quit IRC16:47
*** derekh has quit IRC16:49
devanandajroll: any new thoughts today on the last 4 patches for the boot iface refactoring?16:53
*** Sukhdev has joined #openstack-ironic16:53
jrolldevananda: I haven't looked, given the size I'm inclined to continue to do so16:53
devanandaI started reviewing 216538 but ran out of steam a few hundred lines in16:53
jrollprecisely16:53
devananda +1711, -2094 is, frankly, too much to be landing the day before a release -- even if it is almost all just driver code16:54
*** Sukhdev has quit IRC16:54
rloojroll, devananda: I agree. Should defer it.16:54
jrollyep16:54
devanandacall the boot interface done, and indicate which drivers were updated in the release notes -- and that it's fully backwards compatible at this stage?16:55
*** romcheg has quit IRC16:56
jrolldevananda: I'm good with that16:56
* devananda annotates the BP16:58
jrollwoo, 3 bugs left16:58
lucasagomesfolks I'm going to call it a day16:58
*** harshs has joined #openstack-ironic16:58
lucasagomeshave a good night everyone16:59
JoshNango/16:59
*** penick has joined #openstack-ironic17:00
*** lucasagomes is now known as lucas-dinner17:00
thiagopnight lucas-dinner17:00
thiagopnight dtantsur|afk17:00
devanandag'night, lucas-dinner17:00
jrollsee ya lucas-dinner \o17:03
*** trown|lunch is now known as trown17:04
jrollrloo: one note on the dd patch, tests are likely going to fail there17:07
rloojroll: ohhhhhhhhhhhhhhhhhh17:07
rloojroll: why?17:07
rloojroll: do we run the tests on OSs with diff lang?17:08
jrollrloo: see the comment, mock cares about argument order17:08
rloojroll: I wondered about that but it passed on my box. in 2.7. maybe 3.4 won't.17:08
jrollreally? weird17:09
*** achanda has joined #openstack-ironic17:10
rloojroll: maybe it is smarter than we think, and know that key=value args can be in any order17:10
jrollrloo: maybe, if it does I think that's new :)17:11
*** jxiaobin has quit IRC17:11
thiagopare you talking about 216478?17:12
jrollyes17:12
thiagopI was looking into that bug and it seems that the problem is after the dd (just by the log, couldn't reproduce that)17:12
jrollreally?17:14
jrollhrm17:14
thiagopthe thing does do logout and delete from iscsiadm17:14
rloothiagop: you mean the actual bug? not the patch?17:14
thiagoprloo: yep17:15
*** ijw has joined #openstack-ironic17:15
*** e0ne has quit IRC17:16
jrollthiagop: damn, you're right17:16
thiagopI'm guessing this error is because python is trying to output something that isn't ascii on the logs17:16
thiagopdon't know where, though17:16
jrollwhich is why making everything use standard locale fixed it for yuiko17:17
rloothiagop: $#@#% If I have to read every bug in detail... :-(17:17
thiagopI'm suspecting of get_disk_identifier17:17
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407917:17
thiagopjust gut feeling17:17
rloothiagop, jroll: i think the bug should be punted then.17:18
thiagoprloo: that's why we're here :)17:18
jrollyeah probably17:18
thiagopto read what you folks are too tired to read17:18
jrollI'm not putting my machine into japanese to test it :D17:18
rloothiagop: :) I'd want someone to reproduce/test.17:18
*** praneshp has quit IRC17:18
rloothiagop: and thank you very much. I would love more reviewers.17:19
*** ijw has quit IRC17:20
jrollman, I wonder if we do have gate problems, this patch also failed all the tempest tests17:20
devanandajroll: I saw some gate failures for tempest timeouts yesterday17:20
devanandathings taking >5min to spawn17:20
jrollorly17:21
jrollwhat I've seen so far looks like VMs hanging at boot17:21
devanandaok - BP updated and two new ones created for tracking the followup in Mitaka for ilo / irmc17:21
jroll\o/17:21
devanandajroll: oh?17:21
jrolldevananda: yeah, it's a random failure we have17:22
devanandaawesome17:22
jrollit's well known17:22
*** lazy_prince has quit IRC17:25
*** garthb has quit IRC17:26
rlooI have to admit though, I've NEVER seen it fail so much. Usually 1, sometimes 2 tests fail. But all of them? https://review.openstack.org/#/c/216478/17:26
*** garthb has joined #openstack-ironic17:26
*** ijw has joined #openstack-ironic17:26
jrollrloo: right, that's what worries me17:26
* devananda updates the title of https://bugs.launchpad.net/ironic/+bug/148828917:26
openstackLaunchpad bug 1488289 in Ironic "Ironic fails to deploy instance with pxe_ipmitool driver on system with Japanese locale" [High,In progress] - Assigned to Yuiko Takada (takada-yuiko)17:26
rloothx devananda17:27
devanandawow, no kidding17:27
thiagopI'll try to lauch an instance here to test it17:27
rloojroll: wondering if some other changes have slowed things down enough...17:27
thiagoprloo: ^17:27
rloothx thiagop17:27
thiagopnot sure if my cloud will help17:27
thiagopit's damn slow these days17:28
thiagop(not sure if I'll need to read japanese)17:31
devanandajudging by the nearly empty baremetalbrbm_0_console.txt file -- yea, the VM hung and didn't start in each of those failures17:32
*** afaranha has left #openstack-ironic17:32
jrolldevananda: yeah, exactly17:33
*** Nisha has quit IRC17:35
*** Big-Boss has joined #openstack-ironic17:35
jrollFYI, removed the milestone from that locale bug17:35
jrollso 2 left.17:35
*** Big-Boss is now known as bigboss17:35
*** bigboss has left #openstack-ironic17:36
thiagop^ dahell?!17:36
thiagoplol17:36
jrollheh17:37
*** pelix has quit IRC17:38
*** sinval has quit IRC17:39
rloojroll: one of those bugs left is IPA and it has two +2. I left it for you.17:39
JayFrloo: which one? do you know17:39
jrollJayF: https://review.openstack.org/#/c/215097/17:39
jrollwhich I would love your eyes on17:39
JayFoh it's /that one/17:39
jroll:)17:39
JayFthe scary partitioning one17:39
*** solid-sinval has joined #openstack-ironic17:39
JayFthat is going to break the world in a thousand edge cases17:40
rlooJayF: https://bugs.launchpad.net/ironic/+bug/148688717:40
openstackLaunchpad bug 1486887 in Ironic "Config drive creation fails in UEFI boot mode for whole disk image " [High,In progress] - Assigned to Shivanand Tendulker (stendulker)17:40
devanandajroll: ack. it sounds like a very serious bug. I'd support backporting if the fix turns out to be simple17:40
jrolldevananda: +117:40
jrolldevananda: I think the fix will be simple, getting to the fix and verifying it will be the hard part17:40
devanandaright17:41
devanandagetting others to validate both the bug and the fix17:41
devanandajroll: on https://bugs.launchpad.net/ironic/+bug/1493816 it sounded from your conversation with dansmith like even the work in progress here won't close the bug17:41
openstackLaunchpad bug 1493816 in Ironic "Rolling-upgrade: lack of indirection API" [High,In progress] - Assigned to Grzegorz Grasza (xek)17:41
dansmithdevananda: it will solve the lack of an indirection api17:42
dansmithdevananda: which from the subject of the bug seems reasonable17:42
jroll+117:42
dansmithdevananda: yeah, I think the bug is closed by this patch17:42
devanandadansmith: perhaps I misunderstood then. does this fix give ironic rolling upgrade capabilities?17:42
dansmithall of rolling upgrades isn't, but the bug doesn't address the whole scope17:42
dansmithdevananda: no, it's necessary but not sufficient17:43
devanandaok. so what exactly is not working as desired now which this bug corrects?17:43
* devananda rereads it17:43
devanandaahh. it will allow a rolling upgrade *to* mitaka17:43
devanandagotcha17:43
dansmithit won17:43
dansmithwon't do that all by itself17:44
dansmithbut it's a necessary step.. it removes one kind of failure17:44
dansmithyou remove this, you get a little farther along the path so you can see what the next issue is that you need to fix17:44
devanandagotcha, thanks17:45
* devananda updates bug wording slightly to clarify17:45
*** e0ne has joined #openstack-ironic17:56
thiagopThis bug on the UEFI boot, is it targeted to IPA instead of Ironic?17:56
thiagopthe patch is for IPA, the bug is targeted to Ironic17:57
thiagopweird17:57
rloothiagop: the ascii codec error?17:57
thiagophttps://bugs.launchpad.net/ironic/+bug/148688717:57
openstackLaunchpad bug 1486887 in Ironic "Config drive creation fails in UEFI boot mode for whole disk image " [High,In progress] - Assigned to Shivanand Tendulker (stendulker)17:57
rloothiagop: oh. yeah, that's ipa.17:57
thiagopwrt ascii error, stacking...17:57
rloothiagop: we don't (didn't) have ability to target bugs to IPA.17:58
*** krtaylor has quit IRC17:58
jrollthiagop: ipa shares a launchpad with ironic (for now)17:58
thiagopaw, ok. Thanks for clarification.17:58
rloothiagop: but I think jroll or someone else is going to fix that :)17:58
jrollyeah, soon17:59
jrollnext week maybe17:59
thiagopxek: I can send the patch with the i18n thing if you're too busy18:00
*** garthb has quit IRC18:03
*** garthb has joined #openstack-ironic18:03
*** praneshp has joined #openstack-ironic18:03
*** olaph has quit IRC18:04
*** e0ne has quit IRC18:06
jrollstepping away for a while18:06
*** Nisha has joined #openstack-ironic18:08
*** olaph has joined #openstack-ironic18:09
*** krtaylor has joined #openstack-ironic18:11
*** e0ne has joined #openstack-ironic18:13
*** olaph has quit IRC18:23
*** achanda has quit IRC18:26
* betherly is heading out for supper - laters all18:26
TheJuliagoodnight betherly18:26
thiagopnight betherly18:27
*** dims__ has joined #openstack-ironic18:28
*** vishwanathj has joined #openstack-ironic18:29
*** achanda has joined #openstack-ironic18:30
*** dims_ has quit IRC18:31
JayFjroll: https://review.openstack.org/#/c/215097/10/ironic_python_agent/shell/copy_configdrive_to_disk.sh,cm line 6418:32
JayFjroll: partprobe issues in gate make me go hrm as to how well this will be tested18:32
*** Sukhdev has joined #openstack-ironic18:34
*** amotoki has quit IRC18:35
*** romcheg has joined #openstack-ironic18:39
jrollJayF: we don't have UEFI in gate, so yeah it won't be tested :(18:46
JayFyeah I just landed it18:46
JayFI feel very mehhh about it, we def need to test the hell outta that agent downstream before deploying it18:47
JayFbut just because I think code is spooky doesn't mean it's wrong or shouldn't land18:47
JayFprobably means more I'm paranoid about breaking things ;)18:47
jrollheh, yeah18:48
jrollthough paranoia is welcome a day before a release :)18:48
jrollparanoia without an alternative, though, is always hard18:48
*** ionutbalutoiu has quit IRC18:48
*** e0ne has quit IRC18:49
JayFyeah exactly why I landed it18:49
JayFI don't have factual reasions it shouldn't hand18:49
JayFland18:49
JayF3 people I trust say it should (author & 2x+2s)18:50
*** penick has quit IRC18:51
jrollso... just the indirection api thing18:52
jrollwoo18:52
rloojroll: I think we have problems at the gate: https://review.openstack.org/#/c/224079/18:54
jrollyep.18:54
jrollnow how the %^&*% do we debug this18:54
rloojroll, devananda: gate isn't failing randomly any more18:54
rloojroll: i was hoping you'd know.18:55
jrollI'm going to poke around18:55
jrollit isn't a DIB problem, we can rule that out18:55
*** penick has joined #openstack-ironic19:06
*** Marga_ has quit IRC19:06
*** Marga_ has joined #openstack-ironic19:08
*** e0ne has joined #openstack-ironic19:12
*** Marga_ has quit IRC19:13
*** dims__ has quit IRC19:24
*** e0ne has quit IRC19:24
*** dims_ has joined #openstack-ironic19:25
*** Nisha has quit IRC19:26
jrollblahhhhhhhhhhhhh19:26
jrolltrying to reproduce this locally now19:27
jrolldon't see anything super suspicious19:27
rcarrillocruzhmm, folks , do we do any kind of schema validation for node uuid ?19:28
rcarrillocruzi'm about to enroll a node19:28
rcarrillocruzand turns out the GUID is all set to zeroes19:29
rcarrillocruz:/19:29
rcarrillocruzdunno what to put , in case i should stick to some convention db wise...19:29
TheJuliarcarrillocruz: it can be blank19:30
TheJuliaironic will assign a uuid then19:30
rcarrillocruzoh19:30
rcarrillocruzexcellent19:30
rcarrillocruzthx :-)19:30
TheJulianp19:31
*** penick has quit IRC19:31
TheJuliarcarrillocruz: did you ever figure out why your node names were not getting populated?19:31
rcarrillocruzno, i have to come back to this , probably on friday19:32
rcarrillocruzi just finished a 35 blades provision + bootstrap19:32
thiagopwow19:33
rcarrillocruzbut fwiw19:33
rcarrillocruzhttp://paste.openstack.org/show/473799/19:33
rcarrillocruzand as i told you, i do have 'name' populated on baremetal.json19:33
rcarrillocruzdunno, i have my bifrost pinned to a commit19:33
rcarrillocruzwill put that in the launchpad bug report19:33
rcarrillocruzbleh19:34
rcarrillocruzTheJulia:19:34
rcarrillocruzi just got 'failed: [lolserver.domain.lol -> localhost] => {"failed": true}19:34
rcarrillocruzmsg: A uuid or name value must be defined to use this module'19:34
rcarrillocruzi set the uuid to null19:34
rcarrillocruzshould i set to blank19:34
rcarrillocruz?19:34
* rcarrillocruz goes try19:35
TheJuliayeah, you shouldn't have any reference if it is to use name19:35
*** derekh has joined #openstack-ironic19:36
TheJuliaoddly enough, if your not getting name through the inventory, then that might be problematic for you :)19:36
rcarrillocruzyeah, i'm having lots of fun :-)19:36
rcarrillocruzgreping uuid to get hostname from baremetal.json19:36
rcarrillocruz*not* fun19:36
*** Sukhdev has quit IRC19:37
TheJulia:(19:37
*** Marga_ has joined #openstack-ironic19:37
rcarrillocruzdoh19:38
rcarrillocruzso19:38
rcarrillocruzblank it complains19:38
rcarrillocruz"" complains19:38
rcarrillocruznull complains19:38
rcarrillocruznot putting uuid field for the node complains about not having uuid19:38
rcarrillocruzso it seems i really need to have a uuid19:39
rcarrillocruzeven if it's made up19:39
TheJuliathat doesn't seem right, filing a bug for that19:40
jrollWELP http://ipxe.org/err/040ee119:41
*** penick has joined #openstack-ironic19:41
*** achanda has quit IRC19:41
TheJuliarcarrillocruz: you know what, I think I may have just reproduced your lacking name issue as well19:41
TheJuliajroll: *pours a whisky and passes it over*19:42
rcarrillocruz:S19:42
rcarrillocruzok19:42
rcarrillocruzuuidgen to the rescue19:43
* rcarrillocruz googled19:43
jrollTheJulia: thanks, much needed19:44
TheJuliarcarrillocruz: I'm going ahead and creating a bug for both since they are likely rooted in same/similar places, and there has to be one or the other realistically19:46
rcarrillocruzsweet, thanks19:46
trownjroll: that looks like we did not get DHCP19:46
trownjust going by the error name anyways EADDRNOTAVAIL_CONFIG19:47
jrollyeah19:47
jrollthere's a dhcp-related neutron change, going to revert it and restack19:47
trownsuppose if I read the additional notes...it says it right there19:48
jrollso either neutron broke us19:49
jrollor there's suddenly a new package supplying our pxe rom or ipxe rom19:49
*** Marga_ has quit IRC19:50
trownthe second seems less likely19:50
jrollyeah19:50
jrollbut the former is a v6-only change, it seems19:51
jrollanyway, we'll know shortly19:51
jrolltesting with a revert now19:51
jrollwtb 'ironic boot-me-an-agent $uuid'19:51
jrollJoshNang: ^ last feature before you leave? :D19:51
jrollmost of the infra is there19:52
*** athomas has quit IRC19:53
jrollthis would be terrible if it's a neutron bug, that was the last commit before they cut stable/liberty, lol19:53
*** olaph has joined #openstack-ironic19:55
trownjroll: just checked dpkg from working(http://logs.openstack.org/36/210436/3/check/gate-tempest-dsvm-ironic-pxe_ssh-dib/85a6e53/logs/) and non-working(http://logs.openstack.org/36/210436/3/check/gate-tempest-dsvm-ironic-pxe_ssh-dib/1ba2ec1/logs/)19:58
trownboth have the same version of ipxe19:58
jrollohey, it is neutron, joy19:58
*** ukalifon1 has joined #openstack-ironic20:00
rloojroll: neutron folks must be happy that we're testing their stuff20:03
jroll>.>20:03
openstackgerritJim Rollenhagen proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407920:04
jroll^ added depends-on for extra verification20:04
rloojroll: we don't know for sure though?20:05
jrollrloo: I mean, I reproduced locally, then reverted the neutron patch as such https://review.openstack.org/#/c/226969/20:06
jrolland post-revert it worked fine20:06
TheJuliarcarrillocruz: bug 1499057, if you want to provide any additional detail/context, it might be helpful but I think i got the essentials20:06
openstackbug 1499057 in bifrost "Bifrost inventory parsing issues" [High,Triaged] https://launchpad.net/bugs/149905720:06
*** ukalifon1 has left #openstack-ironic20:06
rloojroll: oh, that's good to know!20:06
rcarrillocruz++20:06
jroll:)20:06
trownjroll: cool I will put that on the DIB patch that I was using to troubleshoot too20:06
trownthat gives two datapoints20:07
jrollcool20:07
jrollbrb20:07
openstackgerritJulia Kreger proposed openstack/bifrost: WIP: Ansible 2.0 compatibility **DO NOT MERGE**  https://review.openstack.org/19683220:08
*** derekh has quit IRC20:16
*** sdake_ has joined #openstack-ironic20:23
*** nicodemos has quit IRC20:23
*** sdake has quit IRC20:25
*** trown is now known as trown|mtg20:27
*** albertoffb has quit IRC20:34
*** achanda has joined #openstack-ironic20:42
*** MattMan has left #openstack-ironic20:42
*** Sukhdev has joined #openstack-ironic20:43
*** liliars has quit IRC20:45
*** lucas-dinner has quit IRC20:46
*** achanda has quit IRC20:47
*** achanda has joined #openstack-ironic20:49
*** achanda has quit IRC20:55
*** eglute has quit IRC20:55
*** achanda has joined #openstack-ironic20:55
*** eglute has joined #openstack-ironic20:55
*** puranamr has joined #openstack-ironic20:57
thiagopI'm calling it a day20:57
thiagopgood night folks20:57
thiagopsee you tomorrow20:57
*** thiagop has quit IRC20:57
*** harshs has quit IRC21:01
*** penick has quit IRC21:01
openstackgerritJulia Kreger proposed openstack/bifrost: Ansible 2.0 compatibility  https://review.openstack.org/19683221:03
*** penick has joined #openstack-ironic21:04
*** harshs has joined #openstack-ironic21:04
openstackgerritJim Rollenhagen proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407921:05
jroll^ depends-on for a fix rather than a revert21:05
jrollthe revert did pass tempest jobs21:06
openstackgerritRuby Loo proposed openstack/ironic: Add 'abort' to state machine diagram  https://review.openstack.org/22699721:07
*** trown|mtg is now known as trown21:08
trownjroll: ya it passed here too https://review.openstack.org/#/c/210436/21:08
jrollyeah21:08
jrollneutron folks are cool with landing the revert if needed, as they don't want to hold our release up21:09
*** penick has quit IRC21:09
*** trown is now known as trown|outttypeww21:10
rloojroll: seems like they should land the revert. that change could have broken things for someone else?21:12
*** puranamr has quit IRC21:12
rloojroll: or is it a bug on our side?21:13
jrollrloo: well, they're fixing the actual bug21:13
jrollnah it's their side21:13
rloojroll: yeah, assuming no-dhcp == not allocated or whatever.21:13
jrollsomething like that21:13
jrollkevinbenton explained it to me in -neutron, I don't fully understand it21:14
rloojroll: as long as they understand it :)21:14
jrollthat's the goal21:14
jroll:P21:14
*** Marga_ has joined #openstack-ironic21:21
*** ndipanov has quit IRC21:25
rloojroll: I didn't -1 (and I don't care right now): https://review.openstack.org/#/c/224079/21..23/ironic/conductor/rpcapi.py21:25
jrollrloo: oh, good one21:25
jrollrloo: I -1'd, I'll come back to it after I see how tests do21:27
rloojroll: ok. guess i should have done that then.21:28
jrollnah it's alright21:28
jrollI feel your pain21:28
rloojroll: :) I hate being the bad 'guy'21:28
jrollheh21:28
*** achanda has quit IRC21:32
mrdaMorning Ironic21:35
*** achanda has joined #openstack-ironic21:36
rloomorning mrda21:38
mrdahi rloo21:38
jrollmornin' mrda21:39
mrdahey jroll21:39
*** harshs has quit IRC21:51
*** harshs has joined #openstack-ironic21:54
*** achanda has quit IRC21:57
*** sdake_ has quit IRC21:59
openstackgerritRuby Loo proposed openstack/ironic: Update install guide to reflect 4.2.0 release  https://review.openstack.org/22702922:00
*** achanda has joined #openstack-ironic22:00
rloojroll, devananda: ^^ that should be updated before the release is cut. Not quite sure what it should say.22:01
jrollrloo: good catch, thanks. left a -1 for you :)22:02
rloojroll: I don't know either. I think there was a wiki or something about it but I didn't pay attention. sigh, let me see if i can find it.22:02
jrollrloo: every project has their own thing now22:03
jrollnova is 12.0.0, glance is maybe 10.0.0 or something22:03
jrollthere's no "number" for liberty as a whole22:03
rloojroll: so every project changed? I didn't know that!22:03
jrollyep :)22:03
jrollrloo: though we're somewhat unique in that we don't bump the major version each cycle22:03
*** alexpilotti has joined #openstack-ironic22:04
*** vdrok has quit IRC22:04
*** vdrok has joined #openstack-ironic22:05
rloojroll: http://superuser.openstack.org/articles/confused-about-the-openstack-release-cycle-check-out-this-handy-chart22:05
jrollrloo: huh. I'll ask the release team22:06
rloojroll: so '4.2.0 (Liberty release)' I think22:06
jrollI think so too22:06
jrollthough that notes 2015.222:06
rloojroll: i think that was a copy/paste from something that wasn't updated. this article doesn't use 2015.2.22:07
*** [1]cdearborn has quit IRC22:08
jrollrloo: yeah, indeed22:08
jrollI agree22:08
*** garthb has quit IRC22:10
*** penick has joined #openstack-ironic22:10
*** garthb has joined #openstack-ironic22:10
openstackgerritRuby Loo proposed openstack/ironic: Update install guide to reflect 4.2.0 release  https://review.openstack.org/22702922:11
rloojroll: gotta go. Doesn't quite seem right still ^^ but better.22:12
jrollrloo: cool, I have release notes patch coming later. have a good night :)22:12
*** openstackgerrit has quit IRC22:16
*** openstackgerrit has joined #openstack-ironic22:17
openstackgerritJim Rollenhagen proposed openstack/ironic: Add 4.2.0 release notes  https://review.openstack.org/22703322:17
jrolldevananda: rloo ^22:17
jrolldevananda: are you still working a patch to move specs around?22:17
*** priteau has quit IRC22:19
*** mestery has quit IRC22:21
*** mestery has joined #openstack-ironic22:22
jrollwell, I figured out how to set a topic if we're using a remotable method22:29
jrollthis is going to be fun22:29
jrollheh22:29
jrolldansmith: is deleting an RPC method something that should ever be done? just curious22:30
jrolllike, eventually we want to transition the do_node_update rpc call to node.update()22:31
dansmithjroll: you can delete it if you bump the major version22:31
*** bizarrochristy has quit IRC22:31
jrolleww22:31
dansmithbumping the major comes with caveats of course22:31
jrollyeah22:31
dansmithwe try to bump our "busy" rpc apis once every couple releases at least22:31
dansmithso we can drop stuff like that22:31
jrollI'm curious what caveats other than we'd need to deprecate for a couple cycles22:31
dansmiththat, basically22:32
dansmithso, the way this works is,22:32
jrollbut we'll never support like, L API and N conductor22:32
dansmithyou support both versions on the server side across the release boundary, but always send the newer version22:32
dansmiththen after the release you can drop support for the older one once you know that you won't have a two-cycles-old client talking to you (since that's the rule)22:32
dansmithnot a huge deal, but it can be confusing the first time you do it22:33
jrollyep22:33
jrollmakes sense22:33
jrollthanks22:33
devanandajroll: I proposed and WIPd it22:34
jrolldevananda: ok cool, thanks22:35
*** jamielennox is now known as jamielennox|away22:35
jrolldansmith: I'm also curious where this object manifest comes from, but maybe that's a lesson for another day22:35
jrollI feel like there may be lots of magic involved22:35
devanandajroll: re: release notes, mind if I update with the list of in tree drivers updated?22:36
devanandaI'd rather be precise than say "most"22:36
jrolldevananda: sure, I never mind people picking up my patches :)22:37
devanandadansmith: two-cycle-boundary rule makes sense for nova, but less so for swift / ironic22:37
devanandajroll: :)22:37
jrolldevananda: an 'except' list may be easier22:37
jrolldevananda: the way I see it, a two-cycle-boundary is always more than enough for us22:37
jroll"playing it safe"22:37
jrollas you always remind me, there's people that will only run stable branch22:38
devanandaI do not necessarily agree22:38
devanandabut I agree for now :)22:38
jrolldevananda: you think we may need *longer*?22:38
devanandain my ideal world, the distros would maintain LTS-style releases, ie, need 2 year support for upgrades22:38
devanandabut none of openstack is there yet22:39
jrolloh god22:39
jrollyeah22:39
jrollI think we'd need the rest of openstack doing it22:39
devanandaso -- two-cycle boundary is good for now. I just bring this up cause you said "always"22:39
jrollheh22:39
jroll"today"22:39
devananda:)22:39
dansmithdevananda: we do one cycle boundary22:40
dansmithdevananda: like L->M only22:40
dansmithjroll: there is a method in o.vo that walks a given object, figures out which objects are related, gathers the versions and that's the manifest22:40
jrollaha22:41
dansmiththe rule has always been N->N+1 and no more22:41
dansmithi.e. no skipping releases22:41
dansmithand honestly, I can't imagine skipping releases is on the horizon for anyone in openstack22:41
jrollheh, we don't have obj_make_compatible in ironic22:42
jrollso much infra missing for this22:42
dansmithyep22:42
dansmithit's been a lot of effort in nova to get to where we are22:42
jrolltotally22:42
jrollwhy can't we just subclass o.vo and have everything work, cmon22:43
jroll:)22:43
*** dims__ has joined #openstack-ironic22:43
* jroll learning way too much about objects this week22:43
dansmithyeah, sorry :)22:43
*** w_ has joined #openstack-ironic22:43
jrolldansmith: I'd love to hear a 'what we would do if we started over' talk on this, btw22:43
JayFjroll: "use go"22:44
jrollso we don't copy/paste a bunch of cruft etc22:44
* JayF ducks22:44
jroll>.>22:44
*** alexpilotti has quit IRC22:44
jrollJayF: legitimate argument for a completely different problem set :)22:44
JayFjroll: "I trade this problem set in for another problem set, please"22:44
dansmithjroll: for ironic or objects?22:45
jrollJayF: sure, we can trade, please review this objects code22:45
jrolldansmith: ouch22:45
jrollobjects.22:45
dansmithjroll: no, I mean.. for ironic objects or o.vo?22:45
*** dims_ has quit IRC22:46
jrolldansmith: for the 'user' of o.vo22:46
*** olaph has quit IRC22:46
dansmithwell, I got to correct several mistakes when we cut o.vo out of nova22:46
dansmithfundamental things we should have done differently from the beginning but just didn't know22:46
dansmithso that was good22:46
dansmithironic pulled the stuff out of nova and ran with it,22:46
jrolldansmith: so like, for microversions, y'all have this cool decorator thing rather than if statements that makes life easy22:46
jrollwhich I still want to switch ironic over to22:47
dansmithand didn't really benefit from the same level of experience we were gaining because ironic had other things on its mind22:47
jrollthinking more code things like that, you know?22:47
dansmithso, the fact that you used objects from the start is a huge win over things like cinder who are retrofitting22:47
jrollnod22:47
JayFDid we use objects from the start? I thought comstud converted that stuff over in Icehouse22:47
jrollbearhands got all ragey every time he saw us using the dict stuff22:47
JayFalthough I guess Icehouse is probably "22:47
dansmithbut yeah, going through the code as little as I have, I definitely have a list of things to work on22:47
jrollJayF: it was like half there when he started22:47
JayFjroll: aha22:48
openstackgerritMario Villaplana proposed openstack/ironic: Allow vendor drivers to acquire shared tasks  https://review.openstack.org/22605822:48
dansmithjroll: well, very early at least22:48
jrollyep22:48
*** jerrygb has quit IRC22:55
openstackgerritJim Rollenhagen proposed openstack/ironic: Implement indirection_api  https://review.openstack.org/22407922:57
jroll^ translated some things, going to +222:57
*** trown|outttypeww is now known as trown23:01
trownjroll: the path forward for the neutron issue is the fix?23:01
trownas opposed to the revert?23:01
jrolltrown: I believe so, it has a +223:01
jrollother folks are looking at it23:02
trownok, thanks I will switch the DIB patch depends23:02
jrollcool23:02
*** Sukhdev has quit IRC23:03
*** olaph has joined #openstack-ironic23:04
*** w_ has quit IRC23:06
*** olaph has quit IRC23:09
*** garthb has quit IRC23:13
openstackgerritJim Rollenhagen proposed openstack/ironic-python-agent: Fixes config drive creation failure in UEFI boot mode  https://review.openstack.org/21509723:14
jroll^ added depends-on and re-approved23:15
*** penick has quit IRC23:21
openstackgerritDevananda van der Veen proposed openstack/ironic: Add 4.2.0 release notes  https://review.openstack.org/22703323:21
devanandaoops. forgot to hit review ...23:21
devanandajroll: ^ also re-ordered the notes so that deprecation warning is at the top23:22
jrollcool thanks23:22
devanandashutting down for a bit, gotta catch a bus23:23
jrolldevananda: also, curious what you think is best here https://review.openstack.org/22702923:23
jrollheh ok, later23:23
* devananda looks23:23
devanandaheh23:24
devanandawell23:24
devanandaperhaps we should remove any mention of release name23:24
jrollI'm fine with that too23:24
jrollthough23:24
jrollmany users just know it by name, not version23:24
jroll(I assume)23:24
devanandaand just say "is contualy updated and reflects the latest available code"23:25
devanandaand then work with the docs team to publish the docs as they were at each release point23:25
jrollthen people ask where the docs for liberty are :)23:25
jrollyeah23:25
devanandaright, well, yea23:25
devanandaat the moment, that is neither the docs for kilo nor liberty23:25
devanandaso it's wrong now, and it's wrong with that patch23:25
jrollwell, it isn't wrong23:25
jrollit says it should be accurate for kilo23:25
devanandabut it's not23:26
devanandait's kilo + delta23:26
openstackgerritStephanie Miller proposed openstack/bifrost: gcc can also be missing on deb distros  https://review.openstack.org/22704723:26
jrollI guess23:26
jrollI tend to think the setup guide would work for Kilo23:26
openstackgerritJim Rollenhagen proposed openstack/ironic: Add 4.2.0 release notes  https://review.openstack.org/22703323:27
jrolldevananda: ^ one quick update23:27
jrollfeel free to look later though23:27
devanandajroll: eg, http://docs.openstack.org/developer/ironic/webapi/v1.html#api-versions-history23:27
jrollyeah23:27
*** penick has joined #openstack-ironic23:28
devananda++ on the doc link23:28
devanandaok, gotta run23:28
jrollsee ya23:28
*** achanda has quit IRC23:33
*** romcheg has quit IRC23:35
*** bizarrochristy has joined #openstack-ironic23:44
openstackgerritRuby Loo proposed openstack/ironic: Update install guide to reflect 4.2 release  https://review.openstack.org/22702923:51
*** baoli_ has quit IRC23:51
jrollrloo: did you see the discussion above?23:51
*** jamielennox|away is now known as jamielennox23:52
rloojroll: oh, no. looking.23:54
jrollheh23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!