*** achanda has quit IRC | 00:04 | |
*** alexpilotti has quit IRC | 00:10 | |
*** alexpilo_ has joined #openstack-ironic | 00:11 | |
*** garthb has quit IRC | 00:13 | |
*** shoutm has quit IRC | 00:18 | |
*** shoutm has joined #openstack-ironic | 00:21 | |
*** shadower has quit IRC | 00:23 | |
*** shadower has joined #openstack-ironic | 00:23 | |
*** achanda has joined #openstack-ironic | 00:26 | |
*** Haomeng has joined #openstack-ironic | 00:28 | |
*** alexpilo_ has quit IRC | 00:30 | |
*** Haomeng|2 has quit IRC | 00:30 | |
*** alexpilotti has joined #openstack-ironic | 00:30 | |
*** jpeeler has left #openstack-ironic | 00:32 | |
*** shoutm_ has joined #openstack-ironic | 00:38 | |
*** shoutm has quit IRC | 00:40 | |
*** Sukhdev has quit IRC | 00:43 | |
rloo_afk | jroll: +2'd. Are you waiting for that to land? | 00:44 |
---|---|---|
jroll | rloo_afk: yes | 00:44 |
jroll | I was hoping NobodyCam was reviewing it | 00:44 |
rloo_afk | jroll: feel free to +2/+A. Or I can do it if you don't want to. | 00:44 |
jroll | can wait for tomorrow | 00:44 |
jroll | heh, it's my patch though :/ | 00:45 |
rloo_afk | jroll: up to you. devananda approved something he did, to get the release going. I don't see why we can't do a similar thing. | 00:45 |
jroll | I'd be fine with you +Aing, I won't +A it myself | 00:46 |
rloo_afk | jroll: done! | 00:46 |
*** dims__ has quit IRC | 00:46 | |
*** dims__ has joined #openstack-ironic | 00:47 | |
*** Ng has quit IRC | 00:48 | |
*** BadCub has quit IRC | 00:48 | |
*** eglute_s has quit IRC | 00:48 | |
*** natorious has quit IRC | 00:48 | |
*** wendar has quit IRC | 00:48 | |
*** wendar has joined #openstack-ironic | 00:49 | |
*** jamielennox has quit IRC | 00:49 | |
*** shoutm_ has quit IRC | 00:50 | |
*** shoutm has joined #openstack-ironic | 00:50 | |
*** comstud has quit IRC | 00:50 | |
*** jroll has quit IRC | 00:50 | |
*** mgagne has quit IRC | 00:50 | |
*** BadCub has joined #openstack-ironic | 00:51 | |
*** Ng has joined #openstack-ironic | 00:51 | |
*** natorious has joined #openstack-ironic | 00:53 | |
*** comstud has joined #openstack-ironic | 00:53 | |
*** jroll has joined #openstack-ironic | 00:53 | |
*** eglute has joined #openstack-ironic | 00:53 | |
*** mgagne has joined #openstack-ironic | 00:54 | |
*** jamielennox has joined #openstack-ironic | 00:54 | |
*** ijw_ has joined #openstack-ironic | 00:58 | |
*** zhenguo has joined #openstack-ironic | 01:03 | |
*** alexpilo_ has joined #openstack-ironic | 01:10 | |
*** alexpilotti has quit IRC | 01:10 | |
*** penick has joined #openstack-ironic | 01:10 | |
*** rloo_afk has quit IRC | 01:14 | |
*** yonglihe has joined #openstack-ironic | 01:15 | |
*** praneshp has quit IRC | 01:21 | |
*** chenglch has joined #openstack-ironic | 01:24 | |
*** hurgleburgler1 has quit IRC | 01:25 | |
*** hurgleburgler has joined #openstack-ironic | 01:26 | |
*** penick has quit IRC | 01:26 | |
*** baoli has joined #openstack-ironic | 01:28 | |
*** baoli has quit IRC | 01:31 | |
*** baoli has joined #openstack-ironic | 01:31 | |
*** saripurigopi has joined #openstack-ironic | 01:35 | |
*** baoli has quit IRC | 01:38 | |
openstackgerrit | Merged openstack/ironic: Add 4.1.0 release notes https://review.openstack.org/221517 | 01:43 |
*** smoriya has quit IRC | 01:44 | |
*** Haomeng|2 has joined #openstack-ironic | 01:51 | |
*** Haomeng has quit IRC | 01:53 | |
*** Marga__ has quit IRC | 02:00 | |
*** ijw_ has quit IRC | 02:07 | |
*** baoli has joined #openstack-ironic | 02:10 | |
*** baoli has quit IRC | 02:12 | |
*** baoli has joined #openstack-ironic | 02:12 | |
*** harshs has quit IRC | 02:18 | |
*** saripurigopi has quit IRC | 02:25 | |
*** baoli has quit IRC | 02:27 | |
*** sambetts has quit IRC | 02:29 | |
*** baoli has joined #openstack-ironic | 02:32 | |
openstackgerrit | Merged openstack/ironic: Add APIs for RAID configuration https://review.openstack.org/196007 | 02:32 |
*** baoli has quit IRC | 02:32 | |
*** sambetts has joined #openstack-ironic | 02:35 | |
*** ijw_ has joined #openstack-ironic | 02:37 | |
*** amotoki has joined #openstack-ironic | 02:38 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Refactor IRMCVirtualMediaAgentDeploy by applying new BootInterface https://review.openstack.org/221577 | 02:39 |
*** baoli has joined #openstack-ironic | 02:39 | |
*** shoutm has quit IRC | 02:55 | |
*** dims_ has joined #openstack-ironic | 02:56 | |
*** dims__ has quit IRC | 02:58 | |
*** shoutm has joined #openstack-ironic | 03:06 | |
*** baoli has quit IRC | 03:11 | |
*** Marga_ has joined #openstack-ironic | 03:15 | |
*** deray has joined #openstack-ironic | 03:17 | |
*** vvb has joined #openstack-ironic | 03:24 | |
*** saripurigopi has joined #openstack-ironic | 03:27 | |
saripurigopi | Good morning Ironic | 03:27 |
*** VikasC has joined #openstack-ironic | 03:32 | |
*** rameshg87 has joined #openstack-ironic | 03:38 | |
*** baoli has joined #openstack-ironic | 03:50 | |
*** achanda has quit IRC | 03:53 | |
*** baoli has quit IRC | 03:54 | |
*** saripurigopi has quit IRC | 03:56 | |
*** baoli has joined #openstack-ironic | 03:56 | |
*** alex_xu has quit IRC | 04:04 | |
*** alex_xu has joined #openstack-ironic | 04:05 | |
*** saripurigopi has joined #openstack-ironic | 04:09 | |
*** dims_ has quit IRC | 04:13 | |
*** baoli has quit IRC | 04:16 | |
*** alexpilo_ has quit IRC | 04:17 | |
*** alexpilotti has joined #openstack-ironic | 04:17 | |
*** achanda has joined #openstack-ironic | 04:28 | |
*** Sukhdev has joined #openstack-ironic | 04:28 | |
*** puranamr has joined #openstack-ironic | 04:32 | |
*** Marga_ has quit IRC | 04:41 | |
*** baoli has joined #openstack-ironic | 04:41 | |
*** baoli has quit IRC | 04:43 | |
*** ramineni has joined #openstack-ironic | 04:44 | |
*** ramineni1 has joined #openstack-ironic | 04:45 | |
*** ramineni2 has joined #openstack-ironic | 04:47 | |
*** ramineni has quit IRC | 04:48 | |
*** ramineni has joined #openstack-ironic | 04:49 | |
*** ramineni1 has quit IRC | 04:50 | |
*** ramineni1 has joined #openstack-ironic | 04:50 | |
*** ramineni2 has quit IRC | 04:52 | |
*** alexpilotti has quit IRC | 04:52 | |
*** alexpilotti has joined #openstack-ironic | 04:52 | |
*** ramineni has quit IRC | 04:53 | |
*** ramineni1 has quit IRC | 04:54 | |
*** Nisha has joined #openstack-ironic | 04:58 | |
*** shoutm has quit IRC | 05:01 | |
*** alexpilo_ has joined #openstack-ironic | 05:05 | |
*** alexpilotti has quit IRC | 05:05 | |
*** shoutm has joined #openstack-ironic | 05:05 | |
*** deray has quit IRC | 05:07 | |
openstackgerrit | gaoxiaoyong proposed openstack/ironic: Fix minor grammar error https://review.openstack.org/219551 | 05:12 |
*** chenke has quit IRC | 05:21 | |
*** chenke has joined #openstack-ironic | 05:21 | |
*** shoutm has quit IRC | 05:22 | |
*** puranamr has quit IRC | 05:23 | |
*** deray has joined #openstack-ironic | 05:24 | |
*** getvasanth has joined #openstack-ironic | 05:26 | |
*** puranamr has joined #openstack-ironic | 05:28 | |
*** ekarlso- has joined #openstack-ironic | 05:37 | |
*** ishant has joined #openstack-ironic | 05:41 | |
*** ramineni_ has joined #openstack-ironic | 05:49 | |
*** ekarlso- has quit IRC | 05:50 | |
openstackgerrit | Anusha Ramineni proposed openstack/ironic: Make end-points discoverable via Ironic API https://review.openstack.org/205895 | 05:51 |
*** puranamr has quit IRC | 05:53 | |
*** puranamr has joined #openstack-ironic | 05:54 | |
*** alexpilotti has joined #openstack-ironic | 06:03 | |
*** alexpilo_ has quit IRC | 06:03 | |
*** ukalifon has joined #openstack-ironic | 06:11 | |
*** shoutm has joined #openstack-ironic | 06:13 | |
*** puranamr has quit IRC | 06:21 | |
*** puranamr_ has joined #openstack-ironic | 06:22 | |
*** yog_ has joined #openstack-ironic | 06:22 | |
*** Sukhdev has quit IRC | 06:28 | |
*** praneshp has joined #openstack-ironic | 06:28 | |
*** ifarkas has joined #openstack-ironic | 06:36 | |
*** puranamr_ has quit IRC | 06:54 | |
*** puranamr has joined #openstack-ironic | 06:55 | |
*** lsmola has joined #openstack-ironic | 07:04 | |
*** coolsvap is now known as coolsvap|brb | 07:14 | |
*** romainh has joined #openstack-ironic | 07:16 | |
betherly | Morning ironic :) | 07:23 |
*** shoutm has quit IRC | 07:28 | |
*** shoutm has joined #openstack-ironic | 07:29 | |
*** shoutm_ has joined #openstack-ironic | 07:31 | |
*** achanda has quit IRC | 07:32 | |
*** shoutm has quit IRC | 07:33 | |
*** praneshp has quit IRC | 07:34 | |
*** achanda has joined #openstack-ironic | 07:36 | |
*** ijw_ has quit IRC | 07:40 | |
*** puranamr has quit IRC | 07:44 | |
*** karimb has joined #openstack-ironic | 07:45 | |
*** puranamr has joined #openstack-ironic | 07:46 | |
*** alexpilotti_ has joined #openstack-ironic | 07:48 | |
*** Haomeng has joined #openstack-ironic | 07:51 | |
*** Haomeng|2 has quit IRC | 07:53 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Implements take_over() for ilo drivers https://review.openstack.org/217068 | 07:58 |
*** achanda has quit IRC | 08:00 | |
*** achanda has joined #openstack-ironic | 08:02 | |
*** lucasagomes has joined #openstack-ironic | 08:04 | |
*** mbound has joined #openstack-ironic | 08:04 | |
*** achanda has quit IRC | 08:07 | |
*** mdbooth has joined #openstack-ironic | 08:11 | |
*** alexpilotti_ has quit IRC | 08:11 | |
*** alexpilotti_ has joined #openstack-ironic | 08:15 | |
*** yuriyz has quit IRC | 08:16 | |
*** priteau has joined #openstack-ironic | 08:17 | |
*** romcheg has joined #openstack-ironic | 08:18 | |
*** shoutm has joined #openstack-ironic | 08:21 | |
*** yuriyz has joined #openstack-ironic | 08:22 | |
*** shoutm_ has quit IRC | 08:24 | |
*** jcoufal has quit IRC | 08:31 | |
*** jistr has joined #openstack-ironic | 08:32 | |
sambetts | Morning ironicers, betherly o/ | 08:33 |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Introduce tempest-lib to functional tests https://review.openstack.org/216701 | 08:35 |
betherly | morning sambetts :) | 08:35 |
*** karimb has quit IRC | 08:38 | |
*** ijw_ has joined #openstack-ironic | 08:40 | |
*** puranamr_ has joined #openstack-ironic | 08:43 | |
*** derekh has joined #openstack-ironic | 08:44 | |
*** puranamr has quit IRC | 08:44 | |
*** ijw_ has quit IRC | 08:45 | |
vdrok | morning ironic | 08:46 |
vdrok | morning betherly, sambetts | 08:46 |
betherly | morning vdrok | 08:50 |
getvasanth | sinval: I got it working :) | 08:51 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Allow abort for CLEANWAIT states https://review.openstack.org/201552 | 08:52 |
lucasagomes | sambetts, vdrok betherly getvasanth g'morning :-) | 08:53 |
betherly | hey lucasagomes :) | 08:53 |
getvasanth | lucasagomes: good morning :) | 08:53 |
*** e0ne has joined #openstack-ironic | 08:54 | |
vdrok | morning lucasagomes, getvasanth | 08:54 |
*** jcoufal has joined #openstack-ironic | 08:55 | |
*** karimb has joined #openstack-ironic | 08:55 | |
getvasanth | vdrok: good morning | 08:56 |
Nisha | morning Ironicers | 08:56 |
*** karimb has quit IRC | 08:56 | |
*** karimb has joined #openstack-ironic | 08:56 | |
vdrok | morning Nisha :) | 08:56 |
*** betherly has quit IRC | 08:56 | |
*** karimb has quit IRC | 08:56 | |
zigo | jroll: There's still no tag for 4.1.0. Is it comming soon? | 08:56 |
Nisha | vdrok, o/ | 08:56 |
*** betherly has joined #openstack-ironic | 08:56 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Implements take_over() for ilo drivers https://review.openstack.org/217068 | 08:57 |
*** karimb has joined #openstack-ironic | 08:57 | |
*** karimb has quit IRC | 08:57 | |
*** karimb has joined #openstack-ironic | 08:57 | |
*** romcheg has quit IRC | 08:58 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for inband raid configuration agent ramdisk https://review.openstack.org/198238 | 08:58 |
Nisha | lucasagomes, vdrok, dtantsur|afk, rameshg87, Please review https://review.openstack.org/217068 , https://review.openstack.org/198656 | 09:02 |
rameshg87 | Nisha: sure. will take a look at it today. | 09:02 |
*** VikasC_ has joined #openstack-ironic | 09:02 | |
vdrok | has anyone seen this thing before? https://bugs.launchpad.net/ironic/+bug/1493748 | 09:03 |
openstack | Launchpad bug 1493748 in Ironic "Ironic sometimes is not able to find vm corresponding to a node when using virsh" [Undecided,New] - Assigned to Vladyslav Drok (vdrok) | 09:03 |
* rameshg87 doesn't use *ssh drivers | 09:04 | |
*** e0ne has quit IRC | 09:04 | |
*** e0ne has joined #openstack-ironic | 09:07 | |
*** romcheg has joined #openstack-ironic | 09:08 | |
*** Marga_ has joined #openstack-ironic | 09:16 | |
*** pelix has joined #openstack-ironic | 09:18 | |
*** chenke_ has joined #openstack-ironic | 09:20 | |
*** chenke has quit IRC | 09:20 | |
betherly | hi getvasanth and Nisha :) | 09:25 |
Nisha | betherly, hi | 09:26 |
getvasanth | betherly: hi | 09:26 |
*** dtantsur|afk is now known as dtantsur | 09:36 | |
dtantsur | Morning Ironic | 09:36 |
*** chenglch has quit IRC | 09:41 | |
*** ijw_ has joined #openstack-ironic | 09:41 | |
*** coolsvap|brb is now known as coolsvap | 09:42 | |
*** amotoki has quit IRC | 09:46 | |
*** ijw_ has quit IRC | 09:46 | |
*** karimb has quit IRC | 09:47 | |
*** naohirot has quit IRC | 09:55 | |
*** karimb has joined #openstack-ironic | 09:57 | |
sambetts | Hey dtantsur | 09:58 |
dtantsur | o/ | 09:58 |
sambetts | dtantsur, how does the IPA ramdisk trigger ironic out of deploy wait? | 10:00 |
sambetts | I'm trying to use the pre-built coreos IPA ramdisk and kernel with pxe_ipmitool and the node is getting to a "host-<ipaddresshere> login:" and then doesn't seem to do anything | 10:01 |
dtantsur | sambetts, via heartbeats IIRC. so on receiving heartbeat, ironic checks command statuses, then proceed | 10:01 |
dtantsur | hmm | 10:01 |
sambetts | dtantsur: how does the ramdisk know what ironics IP is to send a heartbeat? | 10:01 |
*** dims__ has joined #openstack-ironic | 10:02 | |
*** yuanying_ is now known as yuanying | 10:02 | |
dtantsur | sambetts, it is passed via kernel cmdline | 10:02 |
dtantsur | sambetts, also it's good to prepend systemd.journald.forward_to_console=yes to the kernel cmdline | 10:02 |
sambetts | how do I do that? | 10:03 |
dtantsur | lemme find | 10:03 |
betherly | morning dtantsur | 10:03 |
dtantsur | sambetts, https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L359 | 10:04 |
dtantsur | betherly, o/ | 10:04 |
dtantsur | lucasagomes, hey morning. could you please review https://review.openstack.org/#/c/205587/ again, if you have a second of time? | 10:04 |
openstackgerrit | Nisha Agarwal proposed stackforge/proliantutils: Fix ribcl to return correct number of processors https://review.openstack.org/221678 | 10:04 |
lucasagomes | dtantsur, hi there; will do very soon | 10:04 |
dtantsur | thanks a lot | 10:05 |
*** thrash|g0ne is now known as thrash | 10:11 | |
*** ishant has quit IRC | 10:11 | |
*** zhenguo has quit IRC | 10:11 | |
openstackgerrit | Nisha Agarwal proposed stackforge/proliantutils: Fix ribcl to return correct number of processors https://review.openstack.org/221678 | 10:13 |
*** ishant has joined #openstack-ironic | 10:13 | |
*** mdbooth has quit IRC | 10:13 | |
*** mdbooth has joined #openstack-ironic | 10:14 | |
openstackgerrit | Nisha Agarwal proposed stackforge/proliantutils: Make proliantutils return 1 size less than actual disk size https://review.openstack.org/221686 | 10:18 |
*** athomas has joined #openstack-ironic | 10:21 | |
*** Nisha has quit IRC | 10:22 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic-python-agent: Fixes config drive creation failure in UEFI boot mode https://review.openstack.org/215097 | 10:23 |
sambetts | dtantsur: is there a way to override the ipaddress that is passed to the kernel by ironic? My controller node has two IPs an external one for API stuff and one in my ironic network, but its passing the external one to the kernel which it can't talk to | 10:24 |
dtantsur | yeah, there's an option, lemme find | 10:24 |
*** logan2 has quit IRC | 10:24 | |
dtantsur | sambetts, maybe https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L441 | 10:25 |
sambetts | dtantsur: wouldn't that change the ip that ironic api listens on completely? | 10:26 |
dtantsur | sambetts, sorry, I think it's "my_ip" option actually | 10:26 |
*** ishant has quit IRC | 10:27 | |
sambetts | dtantsur: ah ok | 10:27 |
*** logan2 has joined #openstack-ironic | 10:28 | |
rameshg87 | dtantsur: sambetts: this one - https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L475 ? | 10:37 |
sambetts | dtantsur, rameshg87: I just found that :-P thanks anyway | 10:38 |
*** puranamr_ has quit IRC | 10:40 | |
*** ijw_ has joined #openstack-ironic | 10:42 | |
*** puranamr has joined #openstack-ironic | 10:42 | |
*** vvb has quit IRC | 10:43 | |
*** saripurigopi1 has joined #openstack-ironic | 10:46 | |
*** saripurigopi has quit IRC | 10:46 | |
*** ijw_ has quit IRC | 10:47 | |
sambetts | dtantsur, rameshg87: whoop that fixed my issues so far :D | 10:48 |
vdrok | dtantsur, lucasagomes, rameshg87 please take a look at this infra change - https://review.openstack.org/#/c/221086/ | 10:48 |
dtantsur | awesome! | 10:51 |
*** bradjones has quit IRC | 10:55 | |
rameshg87 | sambetts: \o/ | 10:57 |
rameshg87 | vdrok: we can skip even the pxe_ssh and other functional tests, right ? | 10:58 |
rameshg87 | oh dsvm* | 10:58 |
vdrok | rameshg87, yup, it's skipping them | 10:58 |
rameshg87 | vdrok: great .. thanks :) | 10:59 |
rameshg87 | dtantsur: regarding https://review.openstack.org/#/c/198238/21/ironic/drivers/modules/agent.py :520 | 11:01 |
rameshg87 | dtantsur: I just checked. if we decorate it with clean step | 11:01 |
rameshg87 | dtantsur: we can catch the situation if node.target_raid_config is set, but agent ramdisk doesn't support it (the one we are silently ignoring now) | 11:02 |
rameshg87 | dtantsur: but if agent ramdisk doesn't support raid - we should skip raid.delete_configuration() and raid.create_configuration() if node.target_raid_config is None | 11:02 |
rameshg87 | wdyt ? | 11:02 |
dtantsur | rameshg87, if should always skip these functions if node.target_raid_config is None, right? | 11:03 |
dtantsur | so just return early, and that's it | 11:03 |
dtantsur | if we have target_raid_config, and agent does not support raid, it's a failure | 11:03 |
rameshg87 | dtantsur: hmm no, a slight change | 11:04 |
rameshg87 | dtantsur: https://review.openstack.org/#/c/198238/21/ironic/drivers/modules/agent.py L541 | 11:04 |
rameshg87 | dtantsur: we throw an error if node.target_raid_config is missing today (that's because we knew today that agent ramdisk supports raid) | 11:04 |
rameshg87 | to sum up | 11:04 |
rameshg87 | node.target_raid_config is None and agent doesn't support raid - nop, silently come out | 11:05 |
dtantsur | no, that's not right | 11:05 |
dtantsur | you either always raise, or never | 11:05 |
dtantsur | upgrading agent ramdisk should not cause cleaning to start failing | 11:05 |
dtantsur | also, raising if target_raid_config is None makes it impossible to use RAID as a cleaning (not zapping) step | 11:06 |
dtantsur | I think it's also not correct | 11:06 |
dtantsur | rameshg87, ^^ | 11:06 |
rameshg87 | dtantsur: yes | 11:06 |
rameshg87 | dtantsur: but we raise only if target_raid_config is None and agent supports raid (operator forgot to put raid config) | 11:07 |
* rameshg87 constructs goes back to a truth table | 11:08 | |
dtantsur | rameshg87, no, operator just does not need raid, and he/she just update the ramdisk. | 11:08 |
rameshg87 | dtantsur: so let me get what are you suggesting ? | 11:08 |
rameshg87 | dtantsur: case #1 | 11:08 |
rameshg87 | node.target_raid_config is None and agent supports raid | 11:09 |
rameshg87 | what's your suggestion ? | 11:09 |
dtantsur | node.target_raid_config is None -> return | 11:09 |
dtantsur | node.target_raid_config is not None and agent does not support raid -> error | 11:09 |
rameshg87 | dtantsur: rloo had comment we should catch the case somewhere where operator forgot to put node.target_raid_config | 11:10 |
rameshg87 | dtantsur: even though I didn't have this in my first patch, I thought it was reasonable | 11:10 |
dtantsur | rameshg87, not before we can get into brain of the operator :) | 11:10 |
dtantsur | how do you distinguish between "this node does not need RAID" and "the operator forgot RAID" | 11:11 |
*** deray has quit IRC | 11:11 | |
rameshg87 | dtantsur: are you saying operator may be choose "not to have raid" even though agent ramdisk supports it ? | 11:12 |
dtantsur | of course | 11:12 |
rameshg87 | hmm..more interesting :D | 11:12 |
* rameshg87 goes into loops | 11:13 | |
rameshg87 | dtantsur: do you think better to go back to spec ? | 11:13 |
rameshg87 | and sort it out | 11:13 |
rameshg87 | ? | 11:14 |
dtantsur | rameshg87, do we have it even covered in the spec? :) | 11:14 |
rameshg87 | dtantsur: no, I never thought it would end up becoming this complex | 11:14 |
dtantsur | tbh, I don't see at as complex. we don't account for an operator forgetting to deploy on a node :) neither do we account for an operator forgetting to set target_raid_config | 11:15 |
*** e0ne has quit IRC | 11:16 | |
sambetts | I think this one of those problem of is something not on or broken, and the way to sort that out would be to have the not on value be different from the broken value, so in this case, if forgotten raid config is None then a node without raid should be "No" or False then its easy to work out if its a forgotten or not | 11:16 |
rameshg87 | dtantsur: similar anology might be we silently come out of deploy if operator forgot to give image_source | 11:17 |
dtantsur | I don't quite agree. RAID is an optional feature, you're trying to make it essentially mandatory (with opt-out) | 11:17 |
dtantsur | rameshg87, image_source is required, RAID is not | 11:17 |
rameshg87 | hmm..true | 11:18 |
dtantsur | rameshg87, if we make target config mandatory, we should ban users from using RAID is a cleaning step (which is unfortunate IMO) | 11:18 |
dtantsur | otherwise they'll shoot their legs pretty soon | 11:18 |
rameshg87 | dtantsur: we might need even a small hack for using raid as a cleaning step (we should be preserving target_raid_config after doing raid configuration during cleaning) | 11:19 |
dtantsur | mmm, what's the problem there? | 11:19 |
rameshg87 | dtantsur: operator sets node.target_raid_config, moves node from manage to available, node undergoes cleaning, raid is configured, node.target_raid_config is cleared, node becomes available | 11:20 |
rameshg87 | node.target_raid_config is cleared =====> https://github.com/openstack/ironic/blob/master/ironic/common/raid.py#L108 | 11:20 |
dtantsur | oh, now I got it | 11:21 |
rameshg87 | dtantsur: when node undergoes cleaning again, node.target_raid_config is None and so no more raid re configuration | 11:21 |
dtantsur | rameshg87, ok fine. lets drop both configuration values for these clean steps priorities, and make target_raid_config mandatory | 11:21 |
rameshg87 | raid as a clean step is not as straightforward as I initially thought :( | 11:21 |
dtantsur | rameshg87, I still think that if agent does not support raid, we must fail | 11:22 |
rameshg87 | dtantsur: and make raid available only for zapping ? | 11:22 |
dtantsur | yep. for now. | 11:22 |
openstackgerrit | Juliana Motira proposed stackforge/pyghmi: Add custom OEM NTP configuration for Lenovo TS https://review.openstack.org/221709 | 11:23 |
*** ramineni_ has left #openstack-ironic | 11:24 | |
rameshg87 | dtantsur: for zapping this is not an issue, as we know what all steps are there. | 11:24 |
dtantsur | rameshg87, yeah, and code might be simplified significantly then | 11:24 |
rameshg87 | dtantsur: so if operator explicitly said I want raid.create_configuration and we don't find it, zapping will anyway raise error. | 11:24 |
dtantsur | rameshg87, yes. both when target config is not set, and agent does not support raid, we should fail | 11:25 |
rameshg87 | dtantsur: yes .. | 11:25 |
rameshg87 | so I will remove it as configurable for now and make it available only for zapping | 11:25 |
dtantsur | rameshg87, please put tl;dr of this conversation to the commit message, so that people don't get surprised why we don't support cleaning (yet) | 11:26 |
dtantsur | thanks! | 11:26 |
lucasagomes | vdrok, good stuff! Thanks | 11:27 |
openstackgerrit | Juliana Motira proposed stackforge/pyghmi: Add custom OEM NTP configuration for Lenovo TS https://review.openstack.org/221709 | 11:29 |
dtantsur | lucasagomes, rameshg87, do you thin we could have a review jam for a proposed openstackclient plugin? Would be nice to get it in Liberty, wdyt? | 11:30 |
dtantsur | first patch: https://review.openstack.org/171672 | 11:30 |
rameshg87 | +1 | 11:30 |
rameshg87 | dtantsur: when, today ? | 11:30 |
dtantsur | we have to figure out when we have some time slot in common | 11:31 |
dtantsur | would be nice to get US folks too, if it's possible | 11:31 |
rameshg87 | yes, I am in. I am planning to come online again after a few hours. | 11:31 |
dtantsur | super! ping me/us when you're back | 11:32 |
* rameshg87 needs to leave now | 11:32 | |
*** puranamr_ has joined #openstack-ironic | 11:32 | |
rameshg87 | dtantsur: will ping back in about 3-4 hours | 11:32 |
* rameshg87 goes home | 11:32 | |
lucasagomes | dtantsur, yeah it would be good. There was a ML thread about it not long ago right? | 11:33 |
*** rameshg87 has quit IRC | 11:33 | |
*** puranamr has quit IRC | 11:33 | |
dtantsur | lucasagomes, yeah, but like all our ML threads it went into nothing :/ | 11:33 |
lucasagomes | :-/ | 11:33 |
dtantsur | I think we just find some time and review it | 11:34 |
*** saripurigopi1 has quit IRC | 11:35 | |
lucasagomes | sounds good | 11:37 |
*** logan2 has quit IRC | 11:38 | |
*** ijw_ has joined #openstack-ironic | 11:40 | |
*** logan2 has joined #openstack-ironic | 11:40 | |
*** lucasagomes is now known as lucas-hungry | 11:42 | |
*** ijw_ has quit IRC | 11:45 | |
sinval | getvasanth: Great news, there is a special configuration? | 11:47 |
*** dtantsur is now known as dtantsur|brb | 11:49 | |
*** logan2 has quit IRC | 11:50 | |
*** VikasC_ has quit IRC | 11:52 | |
dtantsur|brb | lucas-hungry, TheJulia, not installing Gtk on the DIB IPA ramdisk saves around 30MB of the compressed ramdisk \o/ | 11:53 |
openstackgerrit | Merged openstack/ironic: Add description how to restart ironic services in Fedora/RHEL7/CentOS7 https://review.openstack.org/220879 | 11:54 |
*** logan2 has joined #openstack-ironic | 11:54 | |
*** saripurigopi has joined #openstack-ironic | 11:55 | |
*** nicodemos has joined #openstack-ironic | 11:59 | |
*** e0ne has joined #openstack-ironic | 12:00 | |
*** dlpartain has joined #openstack-ironic | 12:02 | |
TheJulia | dtantsur|brb: nice! | 12:07 |
*** dlpartain has left #openstack-ironic | 12:11 | |
*** saripurigopi has quit IRC | 12:13 | |
*** trown|outttypeww is now known as trown | 12:13 | |
*** krtaylor has joined #openstack-ironic | 12:14 | |
*** e0ne has quit IRC | 12:15 | |
*** logan2 has quit IRC | 12:17 | |
*** logan2 has joined #openstack-ironic | 12:20 | |
*** athomas has quit IRC | 12:22 | |
*** puranamr has joined #openstack-ironic | 12:23 | |
*** puranamr_ has quit IRC | 12:23 | |
*** marzif has quit IRC | 12:25 | |
*** vgridnev has joined #openstack-ironic | 12:25 | |
*** marzif has joined #openstack-ironic | 12:25 | |
*** coolsvap has quit IRC | 12:27 | |
trown | dtantsur|brb: but then how will we have a GUI </sarcasm> | 12:27 |
*** saripurigopi has joined #openstack-ironic | 12:29 | |
*** e0ne has joined #openstack-ironic | 12:30 | |
*** coolsvap has joined #openstack-ironic | 12:30 | |
*** athomas has joined #openstack-ironic | 12:31 | |
getvasanth | sinval: the issue is with the image, i donwloaded the image from redhat : overcloud image | 12:32 |
getvasanth | sinval: the dib images fails, even if it is wholedisk or partition | 12:34 |
*** amotoki has joined #openstack-ironic | 12:37 | |
sinval | getvasanth: hum, what drivers did you tested? | 12:38 |
*** baoli has joined #openstack-ironic | 12:38 | |
*** logan2 has quit IRC | 12:41 | |
*** logan2 has joined #openstack-ironic | 12:42 | |
*** baoli has quit IRC | 12:42 | |
*** baoli has joined #openstack-ironic | 12:43 | |
*** lucas-hungry is now known as lucasagomes | 12:45 | |
lucasagomes | :D | 12:46 |
*** puranamr has quit IRC | 12:50 | |
*** VikasC has quit IRC | 12:51 | |
*** dims__ is now known as dims | 12:52 | |
*** zhenguo has joined #openstack-ironic | 12:59 | |
*** lucasagomes has quit IRC | 13:03 | |
*** saripurigopi has quit IRC | 13:10 | |
*** lucasagomes has joined #openstack-ironic | 13:15 | |
getvasanth | sinval: pxe_ipmitool | 13:18 |
sinval | getvasanth: nice, thank you very much o/ | 13:20 |
getvasanth | sinval: :) i am composing the information in a blog, will post it once done | 13:21 |
getvasanth | sinval: hope it will help others too | 13:22 |
sinval | getvasanth: great idea, please ping me when you finish it | 13:22 |
*** baoli has quit IRC | 13:22 | |
getvasanth | sinval: sure | 13:23 |
*** keekz_ is now known as keekz | 13:23 | |
jroll | morning all :) | 13:30 |
jroll | zigo: was waiting on patches to land, I'm proposing a release shortly / today | 13:30 |
* jroll didn't think about the implications of landing RAID APIs before 4.1, whoops | 13:31 | |
jroll | ram<tab> :( | 13:32 |
jroll | dtantsur|brb: lucasagomes morning :) you know if OOB raid config is done? I don't see other patches for it | 13:33 |
jroll | or is this all just the plumbing work and now drivers can support it | 13:33 |
lucasagomes | jroll, hi there! morning | 13:33 |
*** mbound has quit IRC | 13:33 | |
lucasagomes | ifarkas, ^ | 13:33 |
ifarkas | jroll, morning | 13:34 |
jroll | morning ifarkas :) | 13:34 |
ifarkas | jroll, lucasagomes not sure what raid config are you looking for. which driver? | 13:34 |
jroll | ifarkas: so, RAID APIs landed... I see patches for in-band with the agent | 13:35 |
jroll | so, my question is, are any drivers done with ramesh's raid work? | 13:35 |
jroll | or is all the plumbing complete for OOB raid, and now it can be added to drivers? | 13:35 |
*** romcheg has quit IRC | 13:36 | |
ifarkas | jroll, ahh, gotcha. I am planning to add that for drac later on but currently moving a bunch of stuff to dracclient library | 13:36 |
jroll | ifarkas: ok, thanks | 13:38 |
jroll | trying to figure out how to add this to release notes, or if I should bother | 13:39 |
jroll | I think I should bother | 13:39 |
*** dtantsur|brb is now known as dtantsur | 13:40 | |
dtantsur | jroll, I think only in-band RAID can get in (I actually hope it will) | 13:40 |
jroll | dtantsur: I hope it will too | 13:41 |
jroll | but I'm about to release 4.1 today | 13:41 |
jroll | which obviously won't have in-band raid config :) | 13:41 |
dtantsur | jroll, yeah, definitely not for 4.1 :( | 13:41 |
dtantsur | s/:(/:)/ | 13:41 |
jroll | heh | 13:41 |
jroll | have release notes patch coming shortly, then we can release when that lands | 13:41 |
ifarkas | jroll, ahh, gotcha. I am planning to add that for drac later on but currently moving a bunch of stuff to dracclient library | 13:42 |
ifarkas | jroll, sorry for sending again :-) | 13:42 |
*** romcheg has joined #openstack-ironic | 13:42 | |
jroll | ifarkas: heh, no worries | 13:42 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add RAID API to 4.1 release notes https://review.openstack.org/221761 | 13:43 |
jroll | dtantsur: lucasagomes ^^ | 13:43 |
dtantsur | jroll, I think we also have a file with release notes in root | 13:43 |
jroll | once this lands.... http://images.rapgenius.com/6ba6cb391a6f132b1d0e14fe7757f363.500x205x14.gif | 13:44 |
jroll | wat | 13:44 |
jroll | lrwxrwxrwx 1 jim jim 33 Sep 8 06:52 RELEASE-NOTES -> doc/source/releasenotes/index.rst | 13:44 |
jroll | symlink ftw \o/ | 13:44 |
dtantsur | ah good | 13:44 |
* lucasagomes reads | 13:46 | |
jroll | I wonder if we should wait for abortable cleaning now, lol | 13:46 |
lucasagomes | lol | 13:46 |
dtantsur | hehe | 13:46 |
*** baoli has joined #openstack-ironic | 13:46 | |
dtantsur | jroll, I think RAID has one more API endpoint, not sure if it's worth mentioning | 13:46 |
*** romainh has left #openstack-ironic | 13:47 | |
jroll | dtantsur: the states/ part? | 13:47 |
dtantsur | lemme find | 13:47 |
jroll | I was just going from the docs :/ | 13:47 |
lucasagomes | I wonder, cause right now it's non-op right? | 13:47 |
jroll | right | 13:47 |
dtantsur | jroll, https://review.openstack.org/#/c/196007/24/ironic/api/controllers/v1/driver.py | 13:47 |
jroll | mmmmmmmmmm. right. | 13:48 |
jroll | you know what. | 13:48 |
jroll | release notes landed before this raid api patch | 13:48 |
jroll | maybe we just tag at the release notes SHA and release this with 4.2 | 13:48 |
jroll | (to lucasagomes' point) | 13:48 |
lucasagomes | jroll, release before the raid stuff? | 13:50 |
dtantsur | jroll, just make sure not to miss bug fixes | 13:50 |
lucasagomes | that's not a bad idea, cause it's no-op now | 13:50 |
jroll | https://github.com/openstack/ironic/commits/master | 13:51 |
dtantsur | lgtm. after that only RAID and docs change landed | 13:51 |
*** r-daneel has joined #openstack-ironic | 13:51 | |
jroll | release at "Merge release notes blablabla" | 13:51 |
jroll | cool, thanks y'all | 13:52 |
jroll | https://review.openstack.org/#/c/221503/ | 13:52 |
jroll | abandoning the release notes update | 13:52 |
dtantsur | 4aa1c216e3360c9b4d8878985bcf267587de541f right? | 13:52 |
jroll | see that patch ^ | 13:53 |
jroll | tl;dr yes | 13:53 |
lucasagomes | that's the SHA in the patch | 13:53 |
*** ukalifon has quit IRC | 13:57 | |
*** shoutm has quit IRC | 13:58 | |
*** harshs has joined #openstack-ironic | 13:59 | |
openstackgerrit | Anton Arefiev proposed openstack/ironic-specs: Policy improvements https://review.openstack.org/221778 | 13:59 |
openstackgerrit | Anton Arefiev proposed openstack/ironic-specs: Policy improvements https://review.openstack.org/221778 | 14:00 |
zhenguo | dtantsur: is there a way to get the consumed memory by agent? | 14:03 |
dtantsur | zhenguo, to make agent report it, maybe. Anyway, asking a user definitely won't work :) | 14:07 |
zhenguo | dtantusr: in https://review.openstack.org/#/c/215254/, I know it's not easy for user to know the consumed memroy size by agent, but leave an option to user is a right way in ironic, right? now the default size is set to 512 which maybe not satisfy every agent :( | 14:07 |
zhenguo | dtantsur: if not ask user for that, how can we set a proper value in ironic. | 14:08 |
dtantsur | zhenguo, ask user is not an option at all, I'm not sure why you're referring to it | 14:08 |
dtantsur | zhenguo, if you feel like a better value, you can make agent return it with heartbeat. even it won't be precise, but it won't be completely random | 14:09 |
*** devanand1 is now known as devananda | 14:10 | |
zhenguo | dtantsur: sounds a good way to get that from heartbeat | 14:10 |
devananda | goood morning, all! | 14:10 |
jroll | devananda: welcome back \o/ | 14:10 |
dtantsur | devananda, morning, WELCOME BACK!! | 14:11 |
zhenguo | devananda: morning | 14:11 |
jroll | devananda: I haz gifts https://review.openstack.org/#/c/221503/2 | 14:11 |
dtantsur | devananda, we've rewritten the whole state machine from scratch, hope you don't mind | 14:11 |
dtantsur | :D | 14:11 |
* dtantsur runs away | 14:11 | |
devananda | dtantsur: awesome! | 14:11 |
jroll | dtantsur: cmon, if you're going to troll him, tell him 1.12 is the default in the new client | 14:11 |
dtantsur | oh damn, such a great idea | 14:12 |
devananda | dtantsur: as long as it's API compatible with Icehouse, that's fine. did you rewrite it in Go ? | 14:12 |
dtantsur | devananda, better, in Erlang | 14:12 |
devananda | nice | 14:12 |
dtantsur | devananda, now to less serious things: did you have a good time? | 14:13 |
devananda | i love it when food shows up at my door (ty amazon fresh) | 14:15 |
devananda | dtantsur: absolutely | 14:15 |
openstackgerrit | Anton Arefiev proposed openstack/ironic-specs: Policy improvements https://review.openstack.org/221778 | 14:17 |
dtantsur | jroll, oh, did I tell you a cool story? On F22 qemu-img package pulled in the Gtk+X11 libraries stack due the bug in 'configure' script | 14:17 |
dtantsur | jroll, I'm waiting for a package update making IPA DIB image 30 MB smaller :) | 14:17 |
dtantsur | devananda, cool! | 14:17 |
jroll | dtantsur: \o/ | 14:18 |
NobodyCam | good morning ironicers | 14:19 |
dtantsur | morning, NobodyCam | 14:19 |
NobodyCam | and welcome back devananda | 14:19 |
NobodyCam | morning dtantsur | 14:20 |
NobodyCam | :) | 14:20 |
jroll | heya NobodyCam :) | 14:20 |
NobodyCam | morning jroll :) | 14:20 |
NobodyCam | sorry switching to new (old) laptop for internal things... so I'm about 1/2 way through the move | 14:21 |
NobodyCam | :-p | 14:21 |
devananda | so - this week, I am moving into a new apartment. have < 10 days to be out of my current one. SO I will be a bit, well, distracted | 14:23 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add version info for pyghmi in driver-requirements.txt https://review.openstack.org/221317 | 14:23 |
jroll | easy pickins ^ | 14:23 |
devananda | ya'll should poke me with things that need my attention (which is generally true anyway) | 14:23 |
jroll | packaging folks pointed that one out to me | 14:23 |
*** lazy_prince has joined #openstack-ironic | 14:25 | |
*** dlpartain has joined #openstack-ironic | 14:25 | |
*** dlpartain has left #openstack-ironic | 14:25 | |
*** baoli has quit IRC | 14:32 | |
*** baoli has joined #openstack-ironic | 14:32 | |
*** baoli_ has joined #openstack-ironic | 14:34 | |
lucasagomes | devananda, hey hey wb! | 14:36 |
jroll | lucasagomes: wanna land 221317? | 14:37 |
lucasagomes | jroll, boom! | 14:37 |
jroll | yay thanks | 14:37 |
jroll | bbiab | 14:37 |
*** baoli has quit IRC | 14:38 | |
*** killer_prince has joined #openstack-ironic | 14:46 | |
*** karimb has quit IRC | 14:47 | |
*** killer_prince has quit IRC | 14:47 | |
*** killer_prince has joined #openstack-ironic | 14:48 | |
*** lazy_prince has quit IRC | 14:50 | |
*** bradjones has joined #openstack-ironic | 14:52 | |
*** bradjones has quit IRC | 14:52 | |
*** bradjones has joined #openstack-ironic | 14:52 | |
*** killer_prince has quit IRC | 14:53 | |
*** lazy_prince has joined #openstack-ironic | 14:55 | |
*** romcheg has quit IRC | 14:55 | |
*** romcheg1 has joined #openstack-ironic | 14:55 | |
jroll | 14:53:11 openstackgerrit | Merged openstack/releases: Release ironic 4.1.0 https://review.openstack.org/221503 | 14:58 |
jroll | \o/ | 14:59 |
lucasagomes | nice! | 14:59 |
lucasagomes | are you sending an email to the ML? | 14:59 |
NobodyCam | :) | 14:59 |
jroll | yeah, I will, checking with doug if there's still launchpad stuff etc happening first | 15:00 |
openstackgerrit | Merged openstack/bifrost: Allow Test VM RAM setting to be tunable https://review.openstack.org/221507 | 15:02 |
*** jistr is now known as jistr|call | 15:02 | |
*** baoli_ has quit IRC | 15:03 | |
*** baoli has joined #openstack-ironic | 15:04 | |
dhellmann | jroll : ironic 4.1.0 is released | 15:06 |
*** romainh has joined #openstack-ironic | 15:06 | |
NobodyCam | w00t | 15:06 |
NobodyCam | ty dhellmann | 15:06 |
jroll | dhellmann: awesome, thank you sir, shall I mail or is that something your team does? | 15:06 |
dhellmann | jroll, NobodyCam : the script for doing that doesn't generate a release announcement email, so it'd be great if you did it | 15:06 |
jroll | ok, cool, will do | 15:06 |
devananda | awesomeness - thanks! | 15:07 |
jroll | does that also go to an announcements list? | 15:07 |
jroll | I meant to ask about that with the ironic-lib email | 15:08 |
jroll | dhellmann: devananda ^ | 15:09 |
*** marzif has quit IRC | 15:10 | |
* devananda does not know | 15:10 | |
*** hurgleburgler has left #openstack-ironic | 15:11 | |
*** thrash has quit IRC | 15:12 | |
*** thrash has joined #openstack-ironic | 15:12 | |
*** Marga_ has quit IRC | 15:13 | |
dtantsur | jroll, yes, with reply-to dev list | 15:14 |
* dtantsur still does releases manually.... | 15:14 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Follow up to Ifdccb32035fa91fe8d8200c3090973c34d453801 https://review.openstack.org/221819 | 15:15 |
jroll | dtantsur: what's the announcement list | 15:15 |
jroll | ? | 15:15 |
dtantsur | jroll, openstack-announce@lists.openstack.org | 15:15 |
jroll | thanks | 15:16 |
lucasagomes | (-: | 15:17 |
*** rloo has joined #openstack-ironic | 15:17 | |
jroll | devananda: what are the chances you want to write this email? :P | 15:17 |
jroll | I know you had opinions on talking about 4.0 and 4.1 etc | 15:18 |
jroll | devananda: if you want to collaborate: https://etherpad.openstack.org/p/ironic-4-1-release | 15:18 |
*** vgridnev has quit IRC | 15:20 | |
devananda | jroll: happy to collaborate. need yout to fill me in on the last two weeks though | 15:20 |
jroll | devananda: https://github.com/openstack/ironic/commit/0284ac29b471c3a3680df9ec7ee8dbfb9eae9dbf | 15:20 |
jroll | release notes for 4.1 | 15:20 |
jroll | but I know you were waiting to talk about 4.0 in this email, and not sure what you wanted to say :) | 15:21 |
jroll | bleh, words are hard | 15:21 |
devananda | words are very hard | 15:21 |
NobodyCam | ++++^99999999 | 15:22 |
*** baoli_ has joined #openstack-ironic | 15:23 | |
*** baoli has quit IRC | 15:25 | |
*** mbound has joined #openstack-ironic | 15:25 | |
*** mbound has quit IRC | 15:27 | |
devananda | jroll: oh right, because there wasn't an announcement for 4.0.0 | 15:27 |
jroll | devananda: yaaaa. | 15:27 |
jroll | zigo was working on packaging that yesterday btw | 15:28 |
jroll | which reminds me | 15:28 |
jroll | zigo: 4.1.0 is now tagged :) | 15:28 |
*** vgridnev has joined #openstack-ironic | 15:28 | |
*** vgridnev has quit IRC | 15:30 | |
*** baoli_ has quit IRC | 15:30 | |
*** baoli has joined #openstack-ironic | 15:30 | |
devananda | jroll: the heading links on http://docs.openstack.org/developer/ironic/releasenotes/#first-semver-release seem poor | 15:31 |
devananda | i'm going to fix it real quick | 15:32 |
jroll | cool | 15:32 |
jroll | holy cow, we fixed 23 bugs in 4.1 | 15:32 |
jroll | that's amazing | 15:32 |
jroll | nice work everyone :D | 15:32 |
jroll | reference: https://launchpad.net/ironic/liberty/4.1.0 | 15:33 |
*** vgridnev has joined #openstack-ironic | 15:36 | |
*** garthb has joined #openstack-ironic | 15:38 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Split standard plugin tests from other processing tests https://review.openstack.org/221845 | 15:39 |
lucasagomes | w00t 23? cool | 15:40 |
lucasagomes | that's quite impressive | 15:40 |
jroll | devananda: you good with this email as-is? | 15:42 |
jroll | and do you want to send it, or me? :P | 15:42 |
jroll | lucasagomes: in 16 days :o | 15:42 |
lucasagomes | yeah | 15:43 |
devananda | jroll: doing one quick test of link generation | 15:43 |
*** vgridnev has quit IRC | 15:44 | |
devananda | ok - screw it, not working as I had hoped. | 15:44 |
*** harshs has quit IRC | 15:44 | |
devananda | jroll: works for me. I'm happy to send it | 15:46 |
*** shoutm has joined #openstack-ironic | 15:46 | |
jroll | devananda: alright, gopher it :) | 15:46 |
jroll | thanks! | 15:46 |
*** maurosr has quit IRC | 15:50 | |
*** thrash is now known as thrash|l00nch | 15:51 | |
*** maurosr has joined #openstack-ironic | 15:52 | |
*** Sukhdev has joined #openstack-ironic | 15:55 | |
*** jistr|call is now known as jistr | 15:55 | |
*** vvb has joined #openstack-ironic | 15:58 | |
*** ifarkas has quit IRC | 15:59 | |
*** yog_ has quit IRC | 16:00 | |
*** baoli_ has joined #openstack-ironic | 16:06 | |
*** puranamr has joined #openstack-ironic | 16:08 | |
*** baoli has quit IRC | 16:08 | |
*** romcheg1 has quit IRC | 16:09 | |
*** dims has quit IRC | 16:10 | |
*** dims has joined #openstack-ironic | 16:10 | |
devananda | humm, gmail doesn't make changing the reply-to easy on a per-email basis | 16:12 |
*** vvb has quit IRC | 16:12 | |
*** Marga_ has joined #openstack-ironic | 16:15 | |
*** getvasanth has quit IRC | 16:19 | |
*** puranamr has quit IRC | 16:21 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [WIP] Deprecate returning patches from plugins https://review.openstack.org/220987 | 16:21 |
lucasagomes | folks if you guys are interested, patches in Nova: https://review.openstack.org/#/c/221848/ and https://review.openstack.org/#/c/221057/ | 16:21 |
lucasagomes | microversion and lightweight logs/network usage | 16:22 |
jroll | devananda: I can send it if that helps | 16:22 |
*** puranamr has joined #openstack-ironic | 16:23 | |
dtantsur | see you tomorrow | 16:25 |
*** dtantsur is now known as dtantsur|afk | 16:25 | |
dtantsur|afk | mmm, before I go | 16:27 |
dtantsur|afk | devananda, jroll, lucasagomes, wdyt about a review jam soonish for the new openstackclient plugin? | 16:27 |
lucasagomes | dtantsur|afk, I'm fine with that, I will re-read that ML thread as well to see if something have been decided there | 16:27 |
jroll | dtantsur|afk: I want to focus on features for 4.2 first | 16:28 |
lucasagomes | I remember people pointing out that the osc client for ironic | 16:28 |
*** baoli_ has quit IRC | 16:28 | |
lucasagomes | should use the same commands that nova uses | 16:28 |
lucasagomes | for creating baremetal nodes and vms etc... | 16:28 |
dtantsur|afk | lucasagomes, I didn't comment back then, but it makes 0 sense at all | 16:28 |
dtantsur|afk | jroll, it's something really nice to land in liberty IMO | 16:28 |
*** baoli has joined #openstack-ironic | 16:28 | |
lucasagomes | dtantsur|afk, right, yeah I don't know. I never used the osc to be honest, I dunno it's guidelines | 16:29 |
jroll | dtantsur|afk: I agree, I just tend to care more about RAID and networking | 16:29 |
jroll | and we have... 10 days | 16:29 |
dtantsur|afk | fair enough | 16:29 |
dtantsur|afk | lucasagomes, nova and ironic are just too different, as we all know.. | 16:29 |
*** ijw_ has joined #openstack-ironic | 16:30 | |
lucasagomes | for those interested in the ML: http://lists.openstack.org/pipermail/openstack-dev/2015-September/073440.html | 16:31 |
* dtantsur|afk is really afk now | 16:31 | |
jroll | yeah, I've been meaning to reply to that | 16:31 |
* jroll jfdi | 16:32 | |
lucasagomes | jroll, what is ur take on that? | 16:32 |
jroll | lucasagomes: well, it's weird since we support standalone ironic | 16:32 |
jroll | but | 16:32 |
jroll | 'openstack server create' should just use nova | 16:33 |
jroll | it would be super complex to try to figure out if it's a standalone deployment or whatever | 16:33 |
jroll | but I think 'openstack baremetal' should be used for the baremetal service | 16:34 |
jroll | it's primarily to manage ironic | 16:34 |
jroll | not actually deploy things | 16:34 |
lucasagomes | yeah I will think over | 16:34 |
lucasagomes | I just feel a bit odd to opinionated on the matter since I don't know osc that much | 16:35 |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for inband raid configuration agent ramdisk https://review.openstack.org/198238 | 16:35 |
lucasagomes | or the reasoning around it's syntax and stuff | 16:35 |
jroll | right | 16:35 |
lucasagomes | if having "openstack baremetal <cmd>" prefix avoid things like having a parameter as --type <baremetal|vm|container> | 16:35 |
lucasagomes | I think it's a good thing | 16:35 |
*** rloo has quit IRC | 16:36 | |
* lucasagomes should read more about osc | 16:36 | |
* sambetts should do the same | 16:37 | |
*** rameshg87 has joined #openstack-ironic | 16:40 | |
openstackgerrit | Merged openstack/ironic-inspector: Revisit required provision states https://review.openstack.org/219247 | 16:41 |
*** athomas has quit IRC | 16:42 | |
*** jistr has quit IRC | 16:42 | |
*** amotoki has quit IRC | 16:43 | |
*** romainh has left #openstack-ironic | 16:44 | |
*** athomas has joined #openstack-ironic | 16:44 | |
*** harshs has joined #openstack-ironic | 16:44 | |
*** lsmola has quit IRC | 16:48 | |
jroll | lucasagomes: sent a thing | 16:48 |
openstackgerrit | Merged openstack/ironic: Add version info for pyghmi in driver-requirements.txt https://review.openstack.org/221317 | 16:48 |
jroll | I think it makes sense | 16:48 |
lucasagomes | jroll, cool, will take a look | 16:49 |
*** derekh has quit IRC | 16:49 | |
*** lazy_prince has quit IRC | 16:51 | |
devananda | osc doesn't make sense for a stand-alone Ironic installation | 16:52 |
sambetts | if your not using the other services, I guess not | 16:52 |
jroll | devananda: for why | 16:53 |
devananda | osc server create --flavor [foo|bar|baz] ... | 16:53 |
jroll | I mean, it doesn't gain you anything by having everything else integrated | 16:53 |
jroll | ok yeah, that doesn't make sense | 16:53 |
devananda | is how one should utilize osc for the creation of bare metal instances | 16:53 |
*** achanda has joined #openstack-ironic | 16:53 | |
jroll | devananda | "osc server" doesn't make sense for a stand-alone Ironic installation | 16:53 |
jroll | osc baremetal totally makes sense | 16:53 |
devananda | jroll: yes | 16:53 |
jroll | yeah, weird thread | 16:54 |
devananda | jroll: but also no. "osc baremetal" still requires keystone | 16:54 |
jroll | ........... | 16:54 |
jroll | it can't be used ever without it? | 16:54 |
devananda | last i looked, and IMBW, osc required only the keystone endpoint | 16:54 |
jroll | that's pretty lame, and I hope it changes | 16:54 |
devananda | and relies on the service names in keystone to discover the different services | 16:54 |
devananda | so yah. it makes literally no sense to use osc w/o keystone | 16:54 |
jroll | :| | 16:55 |
devananda | unless I completely read it wrong, or misremember it, both of which are possible | 16:55 |
jroll | osc baremetal still makes sense though | 16:55 |
jroll | just not for total standalone | 16:55 |
* devananda has not touched a computer in two weeks | 16:55 | |
jroll | great work | 16:55 |
lucasagomes | jroll, cool, nice disclaimer there | 16:55 |
morgan | i am going to guess in theory we could support direct talking to ironinc via osc with an auth plugin that just avoids the catalog lookup | 16:55 |
*** jistr has joined #openstack-ironic | 16:55 | |
devananda | "osc baremetal enroll" && "osc baremetal manage" && "osc baremetal get-me-a-console" ... or what ever | 16:55 |
devananda | those totally make sense for the management of resources within Ironic | 16:56 |
*** chenke__ has joined #openstack-ironic | 16:56 | |
lucasagomes | yeah the keystone bits can be annoying if they are required | 16:57 |
jroll | "that auth thing is so pesky" :P | 16:57 |
lucasagomes | heh | 16:57 |
morgan | who needs auth | 16:58 |
*** chenke_ has quit IRC | 16:59 | |
devananda | heh | 17:00 |
devananda | jroll: if you want to hit send on that announce, and your mail client makes reply-to: easier than mine -- go for it | 17:01 |
jroll | devananda: shore thing, so to: openstack-dev, openstack-announce; reply-to openstack-dev? | 17:01 |
devananda | sounds right | 17:01 |
jroll | cool | 17:01 |
devananda | I could poke gmail a bunch and do things, but meh | 17:01 |
devananda | thanks :) | 17:02 |
*** sdake has joined #openstack-ironic | 17:02 | |
*** puranamr has quit IRC | 17:02 | |
sdake | hi folks, any core reviewers around or developers familiar enough with ironic to answer my questions re integrating Kolla (deploying openstack in containers using ansible) with Ironic? | 17:02 |
sdake | we want to use ironic with the nova scheduler,but we want nova shcedule to be able to schedule both virt machines and bare metal | 17:03 |
JayF | I think that's possible; I won't be much help though as downstream we manage that by having our bare metal is a separate cell. | 17:03 |
*** rameshg87 has quit IRC | 17:04 | |
jroll | devananda: sent | 17:04 |
jroll | sdake: yeah, in general the two solutions are cells and host aggregates - however, I'm not sure how/if host aggregates can be configured with different scheduler instances | 17:05 |
sdake | would someone mind respondingto jeff on the mailing list | 17:06 |
sdake | so he has a record of the idea? | 17:06 |
sdake | http://lists.openstack.org/pipermail/openstack-dev/2015-September/073530.html | 17:06 |
sdake | another option we had thought about was to run a completely separate instance of nova | 17:06 |
*** trown is now known as trown|lunch | 17:07 | |
sdake | with a seprate rabbitmq network | 17:07 |
openstackgerrit | John L. Villalovos proposed openstack/bifrost: Fix minor grammar/spelling issue https://review.openstack.org/221883 | 17:07 |
sdake | different database name | 17:07 |
sdake | would that work? | 17:07 |
jroll | sdake: that should work, service catalog may get weird | 17:08 |
*** e0ne has quit IRC | 17:08 | |
NobodyCam | jlvillal: good catch | 17:08 |
jroll | I'm jumping into a meeting but I'll try to get to the list later | 17:08 |
jlvillal | NobodyCam: Thanks :) | 17:08 |
*** chenke_ has joined #openstack-ironic | 17:09 | |
sdake | jroll does nova have a way to override the service catalog to use? | 17:10 |
sdake | how would we register the api endpoint for example? | 17:10 |
jroll | sdake: no clue about that, sorry | 17:10 |
sdake | ok thanks | 17:10 |
jroll | the client can override it | 17:10 |
jroll | if you set the service name differently | 17:10 |
sdake | still if someone could respond to jpeeler's email above that would be helpful :) | 17:10 |
jroll | e.g. NOVA_SERVICE_NAME=cloudServersOpenStack | 17:11 |
jroll | I will ina bit | 17:11 |
jroll | idk how I missed that | 17:11 |
sdake | thanks jroll appreciate it | 17:11 |
jroll | np | 17:11 |
jlvillal | I just read that email :) | 17:11 |
sdake | dude, firehose, we all drink from it - it happens ;) | 17:11 |
jlvillal | I like the idea of Kolla. Sounds much better than devstack... | 17:11 |
*** chenke__ has quit IRC | 17:12 | |
*** athomas has quit IRC | 17:12 | |
* jlvillal feels embarrassed for spilling coffee on his mostly white shirt :( | 17:12 | |
*** alexpilotti has quit IRC | 17:12 | |
*** alexpilotti_ is now known as alexpilotti | 17:12 | |
*** alexpilo_ has joined #openstack-ironic | 17:13 | |
aweeks | jlvillal: I literally just spilled coffee all over myself too | 17:13 |
jroll | sdake: replied | 17:13 |
jlvillal | aweeks: It sucks doesn't it!!! | 17:13 |
aweeks | well, it was cold brew, with no cream or sugar, and dark clothes | 17:14 |
aweeks | it could be worse... | 17:14 |
jlvillal | aweeks: You got off easier than me. White shirt here.... And 1/2 & 1/2. | 17:15 |
sdake | thanks jroll | 17:15 |
openstackgerrit | Merged openstack/ironic: Use vendor mixin in IPMITool drivers https://review.openstack.org/218821 | 17:19 |
*** romcheg has joined #openstack-ironic | 17:21 | |
*** romcheg has left #openstack-ironic | 17:21 | |
*** pelix has quit IRC | 17:23 | |
sambetts | Night all o/ | 17:27 |
*** jistr has quit IRC | 17:28 | |
*** thrash|l00nch is now known as thrash | 17:28 | |
* jlvillal thinks it is pretty cool that he can control his NUC via AMT | 17:30 | |
*** Sukhdev has quit IRC | 17:30 | |
*** rloo has joined #openstack-ironic | 17:32 | |
*** raghu has joined #openstack-ironic | 17:32 | |
*** devlaps has joined #openstack-ironic | 17:32 | |
*** achanda has quit IRC | 17:34 | |
NobodyCam | night sambetts | 17:34 |
*** jcoufal has quit IRC | 17:34 | |
*** ijw_ has quit IRC | 17:34 | |
jlvillal | raghu: Hello | 17:35 |
*** rloo_ has joined #openstack-ironic | 17:35 | |
*** rloo has quit IRC | 17:37 | |
raghu | jlvillal: Hi John | 17:37 |
*** sdake_ has joined #openstack-ironic | 17:37 | |
jlvillal | raghu: Welcome. Thanks for your interest in functional testing. | 17:37 |
jlvillal | raghu: lekha is investigating doing functional testing for python-ironicclient using mimic. | 17:38 |
raghu | thanks John. glad to be part of the team | 17:38 |
*** achanda has joined #openstack-ironic | 17:38 | |
jlvillal | raghu: Not sure what level of knowledge you have about functional testing. Myself I am trying to learn more, as I am fairly new to it. | 17:38 |
jlvillal | raghu: And aarefiev is doing some work on functional testing, also with ironicclient. | 17:39 |
raghu | I have been doing testing for quite sometime in different roles.. | 17:39 |
jlvillal | raghu: Great! You can answer all my questions :) | 17:39 |
lekha | jlvillal: I was putting together a script that will let us run the existing functional tests for the ironic python client against mimic. I have not gotten back to it since. | 17:40 |
jlvillal | raghu: I've started a wiki page at: https://wiki.openstack.org/wiki/Ironic/Quality | 17:40 |
raghu | would that be something I can start with | 17:40 |
jlvillal | But need much more. | 17:40 |
jlvillal | raghu: If you have the time and would like to work on it, that would be great. | 17:40 |
lekha | jlvillal: This will require that all or most of the ironic API calls be mocked within mimic | 17:40 |
raghu | sure.. I can start to look at it John | 17:41 |
jlvillal | raghu: lekha: I guess we have to figure out what is the best way for us to do the functional testing. | 17:41 |
*** sdake has quit IRC | 17:41 | |
jlvillal | Do we want to use mimic? Do we want to run ironic and ironicclient at the same time and use them to test each other? Maybe using mimic in that case to mimic things like Nova, keystone, etc... | 17:42 |
jlvillal | I don't know the answers. | 17:42 |
jlvillal | lekha: thanks for the info. | 17:43 |
lekha | jlvillal: yea, I am not sure if folks have running ironic locally to be able to test this locally | 17:43 |
jlvillal | One stumbling block on using mimic is that they but a feature freeze in place. So we can't add mimic to the requirements right now :( | 17:43 |
jlvillal | s/but a/put a/ | 17:44 |
jlvillal | Hopefully the freeze gets lifted soon... | 17:44 |
lekha | jlvillal: yea :( also, mimic will let us test negative scenarios, as we can program it to behave as need be. | 17:45 |
jlvillal | lekha: raghu: So we have other projects to look to for ideas on the functional testing. We can use those ideas or not use them. Projects I'm thinking of are nova, novaclient, and ironic-inspector. | 17:45 |
*** sdake_ is now known as sdake | 17:45 | |
* jlvillal goes back to trying to setup his NUC to work with Ironic... | 17:48 | |
lekha | jlvillal: yea, I know enough (i think) about functional testing, but not sure how its being done currently in the other open stack projects. | 17:48 |
jlvillal | lekha: I'm guessing most of them use devstack | 17:49 |
raghu | jlvillal:lekha: Is that something we should start to look at | 17:49 |
raghu | like in get some information on how others are doing | 17:49 |
lekha | jvillal: My primary need would be to be able to run tests locally; not take too long to run them and be able to test negative cases | 17:49 |
jlvillal | raghu: Maybe you could look into ironic-inspector functional testing. See how it is done. | 17:50 |
lekha | raghu, jvillal: sure | 17:50 |
lekha | jlvillal^ | 17:50 |
jlvillal | raghu: There are resources here: dtantsur|afk, trown|lunch, and others I think. I don't know if they use devstack or not. I think no. | 17:50 |
jlvillal | raghu: lekha: I think ironic-inspector work might be of most interest to us. | 17:51 |
jroll | lekha: ++ for fast local tests | 17:51 |
jlvillal | raghu: Please update the Wiki with information you find. And sounds like the ability to do it locally and quickly would be a big plus :) | 17:52 |
jlvillal | raghu: Assuming you are willing to do the research... | 17:52 |
raghu | jlvillal: sure,no issues.. I am just trying to look for starting point | 17:53 |
raghu | :) | 17:53 |
jlvillal | raghu: Great! Thanks a lot. | 17:53 |
raghu | till now I have been a openstack user, | 17:53 |
jlvillal | raghu: I'm trying to become an OpenStack user/operator. Or at least learn more about that side of things. Thus why I am trying to setup a real bare-metal setup in my cube at the moment. I am a little distracted with that at the moment. | 17:54 |
*** shoutm has quit IRC | 17:55 | |
raghu | I have a setup that is running juno | 17:56 |
raghu | so will see how much I can use some of the things | 17:57 |
raghu | to get this | 17:57 |
openstackgerrit | Dan Smith proposed openstack/ironic: Fix object field type calling conventions https://review.openstack.org/221894 | 17:57 |
JayF | lucasagomes: re: guess_root_disk, I completely agree. That algo was cooked up by me and Russell explicitly for our OnMetal v1 use case and I'm amazed it's lasted this long | 17:59 |
*** praneshp has joined #openstack-ironic | 17:59 | |
*** dansmith has joined #openstack-ironic | 18:03 | |
jlvillal | guess_root | 18:03 |
*** trown|lunch is now known as trown | 18:04 | |
*** penick has joined #openstack-ironic | 18:06 | |
*** krtaylor has quit IRC | 18:13 | |
*** baoli_ has joined #openstack-ironic | 18:20 | |
*** e0ne has joined #openstack-ironic | 18:23 | |
*** baoli has quit IRC | 18:24 | |
rloo_ | hmm, simon is an OPEAM (Openstack PE Architect and Monitoring lead) | 18:25 |
rloo_ | oops, wrong channel (and nick) | 18:25 |
*** rloo_ is now known as rloo | 18:25 | |
rloo | hi JoshNang, where are we at wrt zapping? looks like RAID won't work w/o it. | 18:27 |
JoshNang | rloo: writing it right now. the changes are fairly minimal tbh | 18:28 |
NobodyCam | morning rloo :) | 18:28 |
rloo | JoshNang: thx JoshNang. I was going to write it today if you hadn't done it! | 18:28 |
rloo | hi NobodyCam | 18:28 |
JoshNang | :D | 18:28 |
*** puranamr has joined #openstack-ironic | 18:29 | |
NobodyCam | :) | 18:30 |
* devananda goes afk for a while - picking up keys to new apartment \o/ | 18:35 | |
NobodyCam | nice !!! enjoy !!!! | 18:36 |
*** blakec has joined #openstack-ironic | 18:39 | |
*** romcheg has joined #openstack-ironic | 18:43 | |
*** e0ne has quit IRC | 18:47 | |
openstackgerrit | Juliana Motira proposed stackforge/pyghmi: Add custom OEM domain name command for Lenovo ThinkServers https://review.openstack.org/221911 | 18:47 |
*** krtaylor has joined #openstack-ironic | 18:48 | |
JoshNang | what's the command to generate db migrations? | 18:50 |
JoshNang | oh! nvm, it's in tree at ironic/db/sqlalchemy/alembic/REAME | 18:51 |
JoshNang | README, even | 18:51 |
*** Sukhdev has joined #openstack-ironic | 18:55 | |
blakec | lucasgomes: querying current and future plans for https://review.openstack.org/#/c/178229/ ? | 18:57 |
blakec | "Override PXE kernel cmdline via Glance property" | 18:57 |
*** puranamr has quit IRC | 18:58 | |
blakec | There were a some conflicts after BootInterface. I have resolved them and been testing this feature | 18:58 |
*** krtaylor has quit IRC | 19:00 | |
openstackgerrit | Juliana Motira proposed stackforge/pyghmi: Add custom OEM domain name command for Lenovo ThinkServers https://review.openstack.org/221911 | 19:00 |
*** krtaylor has joined #openstack-ironic | 19:01 | |
rloo | jroll: wrt the ironic-neutron patches, this seems to be the first patch in the series, and it hasn't been updated since Sept 3: https://review.openstack.org/#/c/206232 | 19:03 |
rloo | jroll: any idea what the status is of those patches? | 19:03 |
*** cascone has quit IRC | 19:03 | |
jroll | rloo: urgh, lazy_prince has been working on them | 19:03 |
jroll | it's stupid test failures on the first few, I suppose I could update them | 19:04 |
jroll | I have some emails to write and then I'll do that | 19:04 |
jroll | gimme an hour maybe? | 19:04 |
rloo | jroll: ok thx. i'm not in a hurry. going to do something else. if zapping patch appears before i'm ready to look at the neutron ones, they'll have to wait again :-) | 19:05 |
jroll | rloo: no worries, sounds good :) | 19:05 |
*** cascone has joined #openstack-ironic | 19:06 | |
*** e0ne has joined #openstack-ironic | 19:07 | |
*** boris-42 has quit IRC | 19:10 | |
*** achanda has quit IRC | 19:13 | |
*** ukalifon1 has joined #openstack-ironic | 19:20 | |
dansmith | jlvillal: that patch passed tests.. do you guys defer to lintan first on all objects reviews? | 19:22 |
*** blakec has quit IRC | 19:23 | |
*** alexpilotti has quit IRC | 19:24 | |
*** liliars has quit IRC | 19:29 | |
*** e0ne has quit IRC | 19:32 | |
*** dtantsur|afk has quit IRC | 19:35 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/221929 | 19:37 |
*** dtantsur has joined #openstack-ironic | 19:40 | |
*** devlaps has quit IRC | 19:43 | |
*** ijw_ has joined #openstack-ironic | 19:46 | |
openstackgerrit | Ruby Loo proposed openstack/ironic: Cache the description of RAID properties https://review.openstack.org/221939 | 19:48 |
*** puranamr has joined #openstack-ironic | 19:56 | |
openstackgerrit | Merged openstack/ironic: Add retry options to iBoot power driver https://review.openstack.org/219051 | 19:56 |
jroll | dansmith: why do you get that impression, just curious | 19:57 |
dansmith | jroll: the last patch to objects stuff seemed to wait on him, and jlvillal added him to this one immediately | 19:58 |
jroll | ughhh, why | 19:58 |
jroll | he's done some of the objects transitions | 19:58 |
dansmith | jroll: it's cool, I was just wondering.. I didn't realize you guys had anyone actively working on the objects stuff, though maybe I should sync with him a bit | 19:58 |
jroll | but seems like we should trust you a bit | 19:58 |
jlvillal | dansmith: I just added lintan to it because he has been working on versionedobjects. Just to keep him in the loop | 19:58 |
jroll | yeah, it's hard, he's in china so timezones | 19:58 |
dansmith | jroll: well, you can definitely trust me on this one since it's obviously needed, but... | 19:59 |
dansmith | jroll: that was going to be my question.. when is he around? | 19:59 |
dansmith | 'cause I don't think I've overlapped with him yet | 19:59 |
dansmith | jlvillal: yep, all good, just curious | 19:59 |
jlvillal | dansmith: Usually sometime after 5pm Pacific Time. | 19:59 |
jlvillal | dansmith: He is in PRC. | 19:59 |
dansmith | jlvillal: okay, I nearly work east coast hours, so that'd explain it :) | 19:59 |
jlvillal | Ah, that would. | 20:00 |
jroll | ++ for west coasters working east coast hours | 20:00 |
*** boris-42 has joined #openstack-ironic | 20:00 | |
* jlvillal thinks jroll works east coaster and west coaster hours ;) | 20:00 | |
jroll | jlvillal: nah, I just happen to be on IRC later sometimes, doesn't mean I'm working | 20:00 |
dansmith | jlvillal: well, that's an easy trap to fall into.. start early and then end late :/ | 20:01 |
* jroll +2 | 20:01 | |
jlvillal | jroll: I do that too. Pay attention to things. | 20:01 |
jroll | jlvillal: I suppose, personally I have reasons other than work to be on IRC :) | 20:02 |
*** lucasagomes has quit IRC | 20:02 | |
jlvillal | jroll: Hmmm. I can't think of any for me :( | 20:02 |
jroll | my friends are weird | 20:02 |
jroll | :P | 20:02 |
jlvillal | Ain't nothing wrong with that! | 20:03 |
*** baoli_ has quit IRC | 20:03 | |
* rloo seems to recall jroll considering some of us as his friends. I wonder which ones are weird... | 20:03 | |
jroll | lol | 20:03 |
jroll | rloo: the ones that are still online at 10pm :P | 20:05 |
rloo | dansmith: qq on the versionedobject stuff. is it a high priority that we get things converted soon? like before liberty? | 20:05 |
rloo | jroll: phew, not me then :D | 20:05 |
dansmith | rloo: well, you guys are half on the library, which is a rather precarious place to be | 20:05 |
*** nicodemos has quit IRC | 20:05 | |
dansmith | rloo: recently we made a change in o.vo that broke you as a result of that | 20:06 |
dansmith | rloo: so I was just going through the current state of things to see what is left | 20:06 |
*** afaranha has quit IRC | 20:06 | |
dansmith | rloo: turns out there is quite a bit, and this particular change might've been confusing to fix, and had to be done before anything else could move | 20:06 |
*** raghu has quit IRC | 20:06 | |
dansmith | rloo: so, priority? I dunno, but the sooner we get some of this crufty stuff moved forward, the sooner we can get you out of this awkward spot | 20:07 |
rloo | dansmith: ok, thx. if others don't get to them this week, i'll look next week. we're trying to get features in this week. | 20:07 |
dansmith | rloo: the reason to continue working on that for liberty is to increase the longevity of your current release in terms of being less likely to break due to future releases of the library | 20:07 |
dansmith | rloo: sure, I wasn't trying to push for immediate review, I was just asking if I should be trying to sync up with lintan :) | 20:08 |
rloo | dansmith: makes sense. although if nothing breaks, we get so bored ;) | 20:08 |
dansmith | rloo: in that case, I can break some things... :) | 20:08 |
rloo | dansmith: no worries. if it was a high priority it makes sense to push for a review now! | 20:08 |
dansmith | aye | 20:09 |
rloo | dansmith: yup, go for it! I double dare you :D | 20:09 |
* dansmith gets out the baseball bat | 20:09 | |
* rloo ducks | 20:09 | |
dansmith | heh | 20:10 |
*** e0ne has joined #openstack-ironic | 20:11 | |
*** achanda has joined #openstack-ironic | 20:12 | |
*** lucasagomes has joined #openstack-ironic | 20:17 | |
*** achanda has quit IRC | 20:18 | |
*** lucasagomes has quit IRC | 20:21 | |
*** alexpilo_ has quit IRC | 20:22 | |
*** alexpilotti has joined #openstack-ironic | 20:23 | |
*** ukalifon1 has quit IRC | 20:25 | |
*** achanda has joined #openstack-ironic | 20:28 | |
openstackgerrit | Josh Gachnang proposed openstack/ironic: WIP: Add Zap states https://review.openstack.org/221949 | 20:29 |
JoshNang | jroll: ^ commit i was having trouble making the migration for | 20:30 |
jroll | JoshNang: well, where's the migration? :P | 20:31 |
JoshNang | jroll: i get the error trying to generate one :P | 20:31 |
jroll | JoshNang: note you didn't add anything to the schema | 20:31 |
jroll | oh heh | 20:31 |
JoshNang | ahh yeah models.py | 20:32 |
jroll | ironic-dbsync revision --message --autogenerate | 20:32 |
jroll | was your command? | 20:32 |
jroll | you mentioned 'upgrade', that's for running migrations | 20:32 |
jroll | but yeah you need models.py changes | 20:32 |
JoshNang | nope, that fails because my db isn't up to date yet | 20:32 |
jroll | ohhhh. | 20:32 |
JoshNang | so i ran ironic-dbsync to get it up to date | 20:33 |
jroll | can you like, dump schemas or something? | 20:33 |
jroll | or select * from alembic_version; | 20:33 |
JoshNang | empty set | 20:34 |
jroll | so you have an ironic db, right? | 20:34 |
JoshNang | right | 20:34 |
jroll | does nodes table have a schema or whatever? | 20:34 |
JoshNang | nope, none yet | 20:34 |
*** puranamr has quit IRC | 20:34 | |
jroll | ok, so you just did create database ironic | 20:34 |
jroll | hmmm | 20:34 |
JoshNang | yeah literally mysql -u root -e "create schema ironic" | 20:35 |
jroll | shouldn't it be 'create database ironic'? | 20:35 |
JoshNang | that's what i thought, but that's what we had in the dev docs | 20:35 |
jroll | huh, TIL | 20:35 |
JoshNang | i'm gonna dump it all and start again from master | 20:38 |
jroll | cool | 20:38 |
jroll | that's what I would do | 20:38 |
*** achanda has quit IRC | 20:49 | |
*** Sukhdev has quit IRC | 20:55 | |
JoshNang | jroll: that worked. weird. | 20:55 |
jroll | huh. cool! | 20:55 |
*** puranamr has joined #openstack-ironic | 20:57 | |
*** achanda has joined #openstack-ironic | 20:59 | |
*** krtaylor has quit IRC | 21:05 | |
*** sdake has quit IRC | 21:08 | |
*** trown is now known as trown|outttypeww | 21:14 | |
*** puranamr has quit IRC | 21:30 | |
openstackgerrit | Dan Smith proposed openstack/ironic: Replace metaclass registry with explicit opt-in registry from oslo https://review.openstack.org/221971 | 21:39 |
*** e0ne has quit IRC | 21:39 | |
dansmith | jlvillal: what do you type in gerrit to find lintan when adding him to a review | 21:40 |
dansmith | ? | 21:40 |
jlvillal | dansmith: lin.tan@intel.com or tan.lin@intel.com | 21:41 |
jlvillal | I always forget which comes first :) | 21:41 |
dansmith | okay go tit | 21:41 |
*** mestery has quit IRC | 21:41 | |
rloo | jroll: wrt https://review.openstack.org/#/c/206232/, I looked at part of it | 21:41 |
dansmith | um | 21:41 |
dansmith | "got it" | 21:41 |
jroll | heh | 21:42 |
jroll | rloo: oh my, so many comments :/ | 21:42 |
jroll | I'm getting concerned about landing this, this late | 21:42 |
rloo | jroll: what'd you expect? ;) There's only one 'serious' one but it can be punted I think. | 21:42 |
*** mestery has joined #openstack-ironic | 21:42 | |
*** tsekiyama has joined #openstack-ironic | 21:42 | |
rloo | jroll: I'd actually prefer not to land it. | 21:42 |
jroll | oh, cool | 21:42 |
jroll | yeah, I'm wondering now... | 21:43 |
rloo | jroll: after seeing so many folks touch/co-author this first patch. | 21:43 |
rloo | jroll: I think 7 patches to review/approve this week is unreasonable. and I don't really know that it helps much. | 21:43 |
jroll | there are people testing this in parallel, fwiw, but just testing it to make sure it works reliably is what scares me | 21:43 |
jroll | especially negative test cases... | 21:43 |
rloo | jroll: we can get it into ironic early in M*, even before the summit if folks care enough. | 21:43 |
jroll | yeah | 21:43 |
jroll | devananda: ^ thoughts | 21:43 |
jroll | ? | 21:43 |
*** puranamr has joined #openstack-ironic | 21:49 | |
mrda | Morning Ironic | 21:51 |
openstackgerrit | Josh Gachnang proposed openstack/ironic: Add Zapping states to node and API https://review.openstack.org/221949 | 21:53 |
JayF | I mean, it's worth noting that missing a "release" doesn't mean waiting 6m for Ironic anymore | 21:54 |
jlvillal | mrda: Good morning | 21:55 |
rloo | morning mrda | 21:56 |
JayF | JoshNang: ^ 221949 is going to conflict with Lucas' abort cleaning patch | 21:56 |
JayF | JoshNang: b/c you both bump the API version | 21:56 |
JayF | JoshNang: jfyi | 21:56 |
JayF | JoshNang: although that patch is sitting with a -1 from both me and Madasi | 21:56 |
JoshNang | JayF: thanks. i assume that's always going to happen :P | 21:56 |
JayF | if you haven't reviewed that one | 21:57 |
JayF | the abort cleaning | 21:57 |
*** Sukhdev has joined #openstack-ironic | 21:57 | |
JayF | you probably should | 21:57 |
JoshNang | i think i have, lemme check | 21:57 |
JayF | ah maybe so | 21:57 |
JoshNang | mm nope. we've talked about it and i've reviewed other clean abort patches, but not 201552 yet | 21:58 |
*** penick has quit IRC | 21:58 | |
JayF | there's an ipa patch for making erase_devices abortable, that's got a +2a from me already too | 21:59 |
*** priteau has quit IRC | 21:59 | |
*** Marga_ has quit IRC | 22:03 | |
*** Marga_ has joined #openstack-ironic | 22:03 | |
*** puranamr has quit IRC | 22:04 | |
*** krtaylor has joined #openstack-ironic | 22:04 | |
JoshNang | ahh that's the one i did review | 22:04 |
* JoshNang reviews as a break from writing zapping tests | 22:05 | |
*** sdake has joined #openstack-ironic | 22:05 | |
*** bradjones is now known as bradjones|away | 22:09 | |
mrda | Just FYI, dansmith's oslo.versionedobjects cleanup patch could do with some review love. Pretty straightforward. https://review.openstack.org/#/c/221894/ | 22:09 |
*** penick has joined #openstack-ironic | 22:11 | |
*** shoutm has joined #openstack-ironic | 22:12 | |
*** shoutm has quit IRC | 22:12 | |
*** ijw_ has quit IRC | 22:15 | |
devananda | jroll: your ^? was re: portgroups? | 22:20 |
jroll | devananda: yeah, that feature in general | 22:21 |
jroll | obviously the db schema isn't super risky | 22:21 |
jroll | but, if you've seen my plan for releasing things, soft feature freeze in 8 days and 4.2.0 in 15 days | 22:21 |
devananda | and a 7-patch-deep change right before that? | 22:22 |
jroll | and things aren't passing CI, and Om is still working out how some of the network flipping works, sooo | 22:22 |
devananda | hum | 22:22 |
jroll | right :( | 22:22 |
devananda | right. I'd totally not land this now | 22:22 |
jroll | this is going to make for a fun talk in tokyo | 22:22 |
devananda | soo... things like this are what featurebranches are (supposedly) good for | 22:22 |
devananda | let the work bake in a place where folks can collaborate on both dev and real testing of it | 22:23 |
devananda | then when it's actually ready, merge to master | 22:23 |
jroll | meh, it isn't hard to dev or test from gerrit | 22:23 |
devananda | becaues the change, on the surface, looks too big to land right before we release | 22:23 |
jroll | right | 22:23 |
devananda | it'snot about not using gerrit | 22:23 |
jroll | I mean, it touches all the things | 22:23 |
devananda | but about their dev cycle <=> our release cycle | 22:24 |
jroll | I honestly don't think feature branches bring much value | 22:24 |
jroll | meh, +A the chain all at once | 22:24 |
devananda | let's not digress into that conversation | 22:25 |
jroll | sure :) | 22:25 |
devananda | it sounds like we agree that landing this now is not a good idea | 22:25 |
*** ijw_ has joined #openstack-ironic | 22:25 | |
jroll | yeah | 22:25 |
jroll | bums me out man | 22:25 |
jroll | but what can you do | 22:25 |
devananda | land it and disable the feature? | 22:26 |
jroll | ehhh. | 22:26 |
openstackgerrit | Merged openstack/bifrost: Fix minor grammar/spelling issue https://review.openstack.org/221883 | 22:26 |
jroll | it's kind of all over the place | 22:26 |
jroll | like it touches the way we deploy and such | 22:26 |
jroll | like https://review.openstack.org/#/c/213262/ is all up in our drivers | 22:27 |
jroll | also https://review.openstack.org/#/c/139687/ | 22:28 |
jroll | refactors a lot of dhcp things and whatnot | 22:28 |
jroll | which may change, he's looking at a different way to do some of that | 22:28 |
devananda | https://review.openstack.org/#/c/139687/18 looks like the pivotal patch | 22:30 |
jroll | right | 22:31 |
devananda | also - where is the functional / tempest test coverage for this? | 22:31 |
jroll | Sukhdev's laptop? idk | 22:31 |
jroll | I forget who is supposed to be doing that | 22:31 |
devananda | so, we had discussed that in Seattle. i dont want to land it w/o an experimental job that's verifying that it works | 22:31 |
devananda | s/land/enable/ | 22:31 |
jroll | I agree | 22:31 |
* Sukhdev eavsdopping | 22:33 | |
Sukhdev | jroll devananda: just as FYI - I am running devstack as we speak with all the patches you listed in this chat along with others on the etherpad https://etherpad.openstack.org/p/ironic-neutron-mid-cycle | 22:35 |
Sukhdev | jroll devananda: and getting ready to kick of testing | 22:36 |
devananda | jroll: from my reading, it looks like default setting of network_provider=none will disable this feature | 22:39 |
jroll | devananda: I'm more concerned about 2000 lines of code that touches everything from db to objects to api to conductor to drivers | 22:40 |
devananda | Sukhdev: ? for you - if CONF.network_provider=none, how does an operator (a privileged user) know that they don't need to do anything with portgroups or neutron -- and if they do, it will just get ignored? | 22:41 |
*** puranamr has joined #openstack-ironic | 22:41 | |
devananda | jroll: is it changing existing objects or db models? yes, but not that much. most of this is just /adding/ new stuff | 22:42 |
devananda | it's A LOT to review, yes | 22:42 |
jroll | devananda: it's your call, ultimately. I'm concerned, rloo is concerned. I'm doubtful it will land even if it all works, with the CI failures and such | 22:43 |
devananda | jroll: I'm concerned too. just playing devil's advocate for a few minutes | 22:44 |
jroll | ok :) | 22:44 |
Sukhdev | devananda: I think this will go as a part of the documentation | 22:45 |
*** puranamr has quit IRC | 22:45 | |
devananda | Sukhdev: i mean, how will the user know? there's no mechanism here for feedback | 22:46 |
jroll | Sukhdev: have any docs been written at all? | 22:48 |
devananda | as a user, if I request some portgroups to be created, and I create some networks in Neutron, and i associate them and all that | 22:48 |
Sukhdev | devananda: are you saying, if the network_provider is set we need to generate some kind of notification back? | 22:49 |
devananda | and then I ask Ironic to perform a deployment and place my baremetal instance on my network -- and it doesn't do it ... well ... | 22:49 |
Sukhdev | jroll: Nothing yet - | 22:49 |
devananda | is that because I (the user) did something wrong? or because the cloud provider simply turned off this feature? I can't tell | 22:49 |
Sukhdev | jroll: based upon our meeting discussions, we decided that we will document the Ironic side in Ironic documents, once we have this working | 22:50 |
jroll | :( | 22:50 |
devananda | a corrolary issue -- what if all the network flipping is working great for Node A (which is the agent_ipmi driver) but not working for Node B (which is the foo_bar driver) | 22:50 |
devananda | how do I, the user, understand why this is? | 22:50 |
Sukhdev | devananda: good question | 22:52 |
jroll | yeah, I don't think we've done any edge case / negative testing here | 22:52 |
jroll | which is a bit concerning | 22:54 |
Sukhdev | jroll devananda: so, how do we move forward from here - we have some more time left - I am getting ready to do the positive test cases | 22:58 |
jroll | Sukhdev: so we have one week until soft freeze, two weeks until liberty release. there's 7 patches, 2k+ lines of code. they aren't passing CI. there's no CI jobs that use this feature. nobody has done any edge case testing. there's no docs. | 23:01 |
*** blakec has joined #openstack-ironic | 23:05 | |
*** rcarrillocruz has quit IRC | 23:05 | |
Sukhdev | jroll: well, most of the code is is in the API - which seems to be working - author or somebody has to do negative teasing - I did a bit of negative testing on the API and provided my feedback to Will, who'd is fixing it - | 23:05 |
Sukhdev | jroll: other patches are not that big | 23:05 |
jroll | Sukhdev: that is to say, I'm not sure it's going to land | 23:05 |
jroll | Sukhdev: this one is pretty huge, and talking to Om we still need to rethink some stuff in it https://review.openstack.org/#/c/139687/ | 23:06 |
jroll | that's the meat of it | 23:06 |
jroll | api/db isn't very risky, but also isn't useful without the rest | 23:06 |
jroll | I *really* don't want to block this but it does not look good at all | 23:07 |
*** achanda has quit IRC | 23:08 | |
*** rcarrillocruz has joined #openstack-ironic | 23:08 | |
Sukhdev | jroll: Om updated that patch few days ago - does it require further rethinking or the update is good enough? | 23:08 |
jroll | Sukhdev: I spoke with him monday, it needs rethinking | 23:08 |
jroll | because it completely breaks the world right now | 23:08 |
Sukhdev | jroll: Oh I see | 23:09 |
devananda | jroll: s/liberty release/liberty RC1/ | 23:09 |
jroll | devananda: sure, same idea, I don't want to backport a ton of fixes to stable/liberty | 23:09 |
devananda | right | 23:09 |
devananda | just being precise :) | 23:10 |
Sukhdev | jroll: We have few days - it will be good if we can work together to get this tested ASAP and make a decision next week as to whether to land it or not? | 23:10 |
openstackgerrit | Josh Gachnang proposed openstack/ironic: WIP: Add zapping to conductor https://review.openstack.org/221989 | 23:10 |
jroll | Sukhdev: I mean, I think it's safe to assume the code won't be working until next week... and then there's the part where we need very busy reviewers to review it all | 23:10 |
jroll | and I want to soft feature freeze next thursday | 23:11 |
*** david-lyle has quit IRC | 23:11 | |
jroll | so, 5-6 working days | 23:11 |
devananda | and then there's the part about having functional tests for things | 23:11 |
jroll | right, that's a thing | 23:11 |
jroll | and docs | 23:11 |
devananda | docs can be done during RC period, IMO | 23:11 |
jroll | but will they. | 23:12 |
devananda | or rather, polish on the docs can be * | 23:12 |
jroll | nobody has started on them | 23:12 |
devananda | we need a baseline level of docs to land with the code so that others can understand & test it | 23:12 |
*** david-lyle has joined #openstack-ironic | 23:12 | |
jroll | agree | 23:12 |
devananda | yeh. without some docs on "hey how do I actually set this up and use it" ... I would rather not land the code | 23:12 |
Sukhdev | devananda jroll: as we discussed in Seattle, we should try to get some or all of this merged - even if we do not announce it as a feature - so that the development can continue to progress | 23:12 |
jroll | Sukhdev: M dev will be open in 2 weeks, development can continue | 23:13 |
jroll | my main thing is we have a ton of other stuff that needs reviewing | 23:13 |
devananda | what jroll said | 23:13 |
jroll | this is going to eat valuable reviewer time | 23:13 |
jroll | devananda: so, unless you object, I think I'm going to -2 the first one | 23:17 |
*** achanda has joined #openstack-ironic | 23:20 | |
*** amit213 has quit IRC | 23:22 | |
*** amit213 has joined #openstack-ironic | 23:22 | |
*** david-lyle has quit IRC | 23:22 | |
*** david-lyle has joined #openstack-ironic | 23:23 | |
devananda | jroll: I do not object | 23:26 |
jroll | k | 23:27 |
jroll | rloo: ^ fyi, bumping that stuff to M | 23:32 |
rloo | jroll: thx | 23:35 |
jroll | rloo: thank you for raising concerns :) | 23:36 |
jroll | bbiab | 23:36 |
rloo | jroll: yw. i have a question though. i thought we wanted feature freeze the end of this week, not next week. if next week, that gives more time for (the other) features. | 23:37 |
*** shoutm has joined #openstack-ironic | 23:44 | |
*** Sukhdev has quit IRC | 23:45 | |
*** Sukhdev has joined #openstack-ironic | 23:45 | |
*** penick_ has joined #openstack-ironic | 23:48 | |
*** penick has quit IRC | 23:48 | |
*** penick_ is now known as penick | 23:48 | |
jroll | rloo: yeah, next week, the following week is the actual RC release | 23:55 |
rloo | jroll: that's good. I missed a week somehow; nice to get it back :) | 23:56 |
jroll | rloo: I hope I'm right when I say that | 23:57 |
rloo | jroll: won't hurt to go with that schedule | 23:58 |
jroll | ok | 23:58 |
jroll | I think that's what I said in email | 23:58 |
rloo | jroll: yeah, i looked at your email again. you don't explicitly say it, just something like 'don't merge anything risky after that date'. | 23:59 |
rloo | jroll: you should have said 'don't merge features' :) | 23:59 |
jroll | rloo: I said what I meant :P | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!