Tuesday, 2015-08-25

*** naohirot has joined #openstack-ironic00:01
naohirotgood morning ironic00:02
naohirotdevananda: jroll: I just looked at the IRC meeting summary, you are going to vacation.00:03
openstackgerritDavanum Srinivas (dims) proposed openstack/ironic: [WIP] remove tests that fail with latest o.vo  https://review.openstack.org/21647000:03
naohirotdevananda: jroll: I'd like to get your feed back about the soft reboot and inject nmi spec and poc.00:04
naohirotdevananda: jroll: spec is https://review.openstack.org/#/c/186700/00:04
jlvillalnaohirot: jroll is on vacation this week.  As an FYI00:04
naohirotdevananda: jroll: poc is https://review.openstack.org/#/c/207897/00:05
naohirotjlvillal: Yeah, I know. but it's kind of surprise because I switched the vendor implementaiton t00:06
*** lucas-dinner has quit IRC00:06
naohirotjlvillal: because I switched vendor implementation to generic implementation based on the core's decision, mainly jim.00:07
jlvillalnaohirot: Okay00:08
*** smoriya has joined #openstack-ironic00:11
jlvillalrloo: mrda: I think we might be in trouble with this oslo.versionedobjects release.00:13
jlvillaldansmith says it will be a lot of work for us to fix it properly in Ironic :(00:13
jlvillalAnd cinder and nova have been waiting for the release for their Liberty work.00:13
mrdaYeah sounds like it00:15
mrdaWe might have to revert oslo.versionedobjects for a while00:15
jlvillalmrda: I think they may push back on that. Not sure how that works.00:18
jlvillalmrda: They are pushing back on reverting release.00:22
* jlvillal wishes devananda was around00:22
*** shadower has quit IRC00:23
*** shadower has joined #openstack-ironic00:23
openstackgerritDan Smith proposed openstack/ironic: Revert "Migrate ObjectListBase to subclass from the Oslo one"  https://review.openstack.org/21647200:26
*** mtanino has quit IRC00:30
jlvillalrloo: devananda:  ^^^^^  Please look at that patch.  It is needed to unblock the gate.00:31
jlvillalmrda: Maybe you can ping some of the cores when they come online.  If rloo and devananda are not available to look at it.00:32
*** baoli has joined #openstack-ironic00:38
*** shoutm_ has joined #openstack-ironic00:43
*** zhenguo has joined #openstack-ironic00:43
mrdathanks jlvillal00:45
*** shoutm has quit IRC00:45
jlvillalmrda: Thanks to dansmith!00:46
mrdayup00:46
jlvillalmrda: Maybe you can get him an Ironic shirt.  And if you have more, maybe I could get one ;)00:46
*** BadCub has quit IRC00:46
*** Ng has quit IRC00:47
mrdajlvillal: I don't know of such things, except the ones I've made myself via cafepress :)00:47
*** zsmithnyc has quit IRC00:47
mrda(with the exception of pixie boots)00:47
*** Ng has joined #openstack-ironic00:47
jlvillaldarn!00:47
*** zsmithnyc has joined #openstack-ironic00:48
*** BadCub has joined #openstack-ironic00:48
*** praneshp has quit IRC00:48
*** shoutm_ has quit IRC01:03
*** shoutm has joined #openstack-ironic01:08
*** lintan__ has joined #openstack-ironic01:12
*** lazy_prince has joined #openstack-ironic01:17
openstackgerritTan Lin proposed openstack/ironic: Add a new field ListOfObjectField  https://review.openstack.org/21360101:18
*** dprince has quit IRC01:21
openstackgerritYuiko Takada proposed openstack/ironic: Fix ascii codec error  https://review.openstack.org/21647801:31
*** asd112z has joined #openstack-ironic01:35
*** tsekiyam_ has joined #openstack-ironic01:47
*** tsekiyama has quit IRC01:50
*** tsekiyam_ has quit IRC01:51
*** Haomeng has joined #openstack-ironic01:56
*** Haomeng|2 has quit IRC01:58
openstackgerritMerged openstack/python-ironic-inspector-client: Fix error message for unsupported API version  https://review.openstack.org/21200301:58
*** shoutm_ has joined #openstack-ironic02:01
*** rameshg87 has joined #openstack-ironic02:01
*** shoutm has quit IRC02:03
jlvillalHaomeng, rameshg87: The gate is broken02:08
jlvillalHaomeng, rameshg87: Believe this can fix things for now: https://review.openstack.org/21647202:08
* rameshg87 checks02:08
jlvillalrameshg87, Thank you02:08
rloojlvillal, mrda: so we need to revert?02:08
jlvillalrloo, https://review.openstack.org/216472 is a proposed fix from dansmith02:09
jlvillalrloo, Strong pushback on reverting the oslo.versionedobjects release.02:09
rameshg87jlvillal: I had seen somewhere we requested to remove that class itself02:09
lintan__what about remove ObjectListBase02:09
rloojlvillal: did you see lintan__'s suggestion?02:09
jlvillallintan__, If you can make a patch that fixes it, that would be great.02:09
rameshg87https://review.openstack.org/#/c/213601/02:10
jlvillalrameshg87, It fails unit tests02:10
rameshg87lintan__: ^^ this one, right ?02:10
rloojlvillal: there is a chicken/egg problem though. devananda asked that we didn't approve anything.02:10
rameshg87jlvillal: that patch doesn't implement the removal yet02:10
jlvillalrameshg87, Yeah.02:10
rameshg87jlvillal: only comments were added to remove it02:10
lintan__yes, I will remove the objectlist if all agree on that02:11
jlvillalAt the moment we have one patch that fixes the gate. If another patch can be done that fixes it better that sounds good too. Depends how long want to wait.02:11
jlvillalrloo, Yes, devananda's patch can't get merged until gate is fixed.02:11
*** achanda has joined #openstack-ironic02:11
jlvillalrloo, So yes chicken and egg.  Catch-22, etc... ;)02:11
rameshg87I am +1 on removing it as it's not used.02:12
rloolintan__: are you OK if we revert, then you do whatever changes later?02:12
lintan__what about this, let's remove the test of objectlist which block the gate, then remove the code02:12
jlvillallintan__, No02:12
jlvillaldansmith said that there are real issues.02:13
lintan__I am fine with this , rloo02:13
jlvillalThat removing the test is wrong.02:13
jlvillalWe had IRC conversation on #openstack-nova earlier.  Read today's log02:13
rloolintan__: i don't actually know what the issue is. so if you're fine with reverting (and if we revert, our stuff still works?), then that is probably easiest/safest to do.02:13
rloolintan__: could you please put your +1 (if it looks ok to you) on https://review.openstack.org/#/c/216472/02:14
lintan__rloo, that's because versionedobject increase to 0.8 and change some behaviors, which break Ironic's versionedobject02:15
lintan__OK02:15
rloolintan__: right, and it sounds like nova etc need 0.8, so we can't pin it to an older version02:15
rloolintan__: the NERVE of them. but what can we do...02:15
jlvillalrloo, dims did apologize for not testing on Ironic. Well that his test didn't work correctly and didn't actually pull in the new versionedobjects02:16
rlooeveryone, note that the only reason (well, only urgent reason i can think of) to get gate working sooner rather than later, is for devananda to be able to get the ironic release done.02:17
jlvillal+1, if a better fix can be done.  That works for me.02:17
lintan__+1 for me02:17
*** Marga_ has joined #openstack-ironic02:17
rloojlvillal: well, these things happen. reminds me as to why i don't like to jump on the bandwagon to use something that is newish.02:17
jlvillallintan__, You are the Ironic expert on versionedobjects.  So if you can give us guidance that would be great.02:18
rlooexcept that lintan__ may not know what 0.8 changes.02:18
* jlvillal knows almost nothing....02:18
*** baoli has quit IRC02:18
jlvillallintan__, Link to bug: https://bugs.launchpad.net/ironic/+bug/148827002:19
openstackLaunchpad bug 1488270 in Ironic "oslo.versionedobjects 0.8.0 release causing py27/py34 unittests to fail in ironic" [Critical,In progress] - Assigned to Dan Smith (danms)02:19
rlooanyway. i'm around off/on for another 40 min or so before i shut down, if you need +2. although ramesh and Haomeng seem to be around and devananda should be back...02:19
*** jcoufal has quit IRC02:20
*** baoli has joined #openstack-ironic02:21
*** zz_natorious is now known as natorious02:23
*** lintan__ has quit IRC02:28
*** lintan__ has joined #openstack-ironic02:35
mrdarloo, jlvillal, lintan__ I think the longer term point is for us to complete the migration to oslo.versionedobjects i.e. update how we use this library, using dims and dansmith as subject matter experts02:37
jlvillalmrda, +1.  I think lintan has been working on that.02:38
mrdajlvillal: yeah, and I appreciate his work!02:38
jlvillalBut now I think we have more urgency02:38
mrdaI think this bump in version will just hasten the need for that migration to complete02:38
mrdajlvillal: snap, yeah02:38
jlvillalmrda, Have a good day. I'm going to try to stop watching IRC :)02:39
rameshg87jlvillal: mrda: I still wonder why we are not removing it off. what if I (or someone else) throw a patch to fix that removes it02:39
mrdajlvillal: probably a good idea, have a nice night02:39
rameshg87jlvillal: mrda: would you guys prefer it over the revert patch ?02:39
mrdarameshg87: what do you mean by "removing it off"?02:40
jlvillalrameshg87, If it works, then it sounds like it might be a good idea.02:40
*** lazy_prince has quit IRC02:40
jlvillalmrda, I think it is the ListObject class.02:40
rameshg87jlvillal: mrda: removing ObjectListBase in ironic/objects/base.py02:40
jlvillalWe may not be using it.02:40
mrdaoh02:40
rameshg87mrda: the funny news is we have never used it in ironic02:40
mrdaShould we be using it though?02:40
rameshg87at least we don't use it now02:41
jlvillalrameshg87, I don't know enough to vote either way. Today was the first time I have looked at the code.02:41
mrdaIs it "oslo.versionedobjects best practice"?02:41
rameshg87mrda: I don't know the use case, but afaik most of the code in oslo was taken from nova when ironic was created02:41
jlvillallintan, probably knows. I thought he was going to look into a patch to remove it.02:41
lintanyes, I am working on that02:42
rameshg87mrda: may be it was ObjectListBase which was in it, was never used in ironic02:42
jlvillallintan, Great. rameshg87 ^^^02:42
rameshg87lintan: great ..02:42
mrdacool02:42
jlvillalrameshg87, lintan mrda I will leave it in your capable hands :)02:42
rameshg87so what about the revert patch https://review.openstack.org/#/c/216472/1 ?02:43
jlvillalrameshg87, Figure out which is the best way to proceed. I will leave that up to you.02:43
jlvillalI really don't know what way is best.02:43
jlvillalrameshg87, Hopefully devananda jumps on at some point. Since he didn't want any code merged until his patch merged. But now his patch is blocked by this issue...02:44
rameshg87jlvillal: okay :)02:44
rameshg87heh irony :)02:44
jlvillalhehe02:44
mrdairony in the ironic project, who would have thought? :)02:45
jlvillalGood night all02:45
mrdanight jlvillal02:45
rameshg87good night jlvillal02:45
mrdarameshg87: I'm thinking that 216472 should probably be taken02:46
mrdarameshg87: I'm just reviewing it more thoroughly - I'm assuming Dan brought that code in from somewhere...02:47
rameshg87mrda: but that's just a revert of https://review.openstack.org/#/q/3b08da311447289d60fb900dc69dff0fd004ca17,n,z, right ?02:47
rloonight jlvillal02:48
mrdarameshg87: yes02:48
rameshg87rloo: I will catch up with you tomorrow on https://review.openstack.org/#/c/196006/ since it's already late for you02:48
mrda...which looks very much like base.py in oslo.versionedobjects at some revision02:49
rloorameshg87: yes, tomorrow02:49
rloofor now, I think we should revert.02:49
mrdarloo: cool02:49
mrdarloo: thanks for staying up02:49
rloomrda. I +2'd it. Either rameshg87 can +2/approve, and/or you can wait to see when/what devananda thinks.02:50
*** achanda has quit IRC02:50
rameshg87rloo: I am still terribly confused.02:51
mrdarloo: thanks for that.02:51
rloorameshg87: with oslo.versionedojects 0.8, our unit test fails, which means our gate is broken.02:51
rameshg87rloo: yeah I understand the problem02:52
rloorameshg87: the fix for now is to revert our change that uses something from oslo.versionedobjects02:52
rameshg87rloo: but, we are spending so much on something that's not even used in ironic, than just removing it off.02:52
mrda...because we're half-way through upgrading to using oslo.versionedobjects how they're meant to be used02:52
rameshg87anyways not much point talking after this patch is ready to be merged02:52
rloorameshg87: so i don't know the details of the problem, and i don't know if the failure is *only* due to that class that we aren't using, or whether there is something else going on.02:52
*** hakimo_ has joined #openstack-ironic02:52
mrda...and oslo released the new version without testing it against ironic (but they tried, the test failed for them)02:53
rloorameshg87: so it seems safest right now, just to revert. cuz we know that it works/worked w/o that change.02:53
rameshg87okay, let's do it then ..02:53
openstackgerritTan Lin proposed openstack/ironic: Remove ObjectListBase  https://review.openstack.org/21360102:53
rloorameshg87: but again, can wait for devananda to make the call. assuming he returns but he said he would so i suspect he will.02:53
rameshg87lintan has a follow up patch anyway to remove it off - we can see if it still continues to work02:53
rameshg87lintan right on time ^^^ :)02:54
mrda:)02:54
rloorameshg87: so devananda wants to do a release of ironic, so the less we change the better.02:54
rloorameshg87: devananda told us not to approve any changes until (i don't have the link handy) merges, but I think it can't merge due to the gate being broken.02:55
rameshg87rloo: anyways I will leave it to him to +2 and +A the patch02:55
*** hakimo has quit IRC02:55
rloorameshg87: ok, that's fine. in the meantime, you and other cores know not to approve anything in ironic tree, right?02:56
rameshg87yeah I hear that now02:56
rameshg87ack02:56
rloociao everyone02:57
mrdathanks rloo02:57
*** rloo has quit IRC02:57
*** rameshg87 is now known as rameshg87-away02:58
*** achanda has joined #openstack-ironic03:01
zhenguorameshg87, Haomeng: as we discussed yesterday about configuring the consumed memory size by agent, any suggestion on the default size?03:05
Haomengzhenguo: I think defautl 1G should be ok, and we can have the configuration option for user to change if it is not enough03:05
zhenguoHaomeng: ok, got it. thanks03:06
Haomengzhenguo: the 1G input that is from our devstack script, it will create 1G ram vm as vm to provision os via ironic03:07
Haomengzhenguo: that is ipa driver03:07
Haomengzhenguo: but this is vm total ram size03:07
devanandaback03:08
Haomengzhenguo: the option we have is to reserve the ram for ipa os only, not including the image which download to ram disk03:08
zhenguoHaomeng: yes, so 1G will not be ok for devsctack env?03:08
* devananda reads scrollback03:08
devanandamrda: lots of scrollback for me to read ... can you tldr?03:09
Haomengzhenguo: I mean 1G is our devstack default configuration for ipa vm03:09
Haomengzhenguo: and dont worry about the default configuration, 512M should be fine for ipa os I think03:10
*** rameshg87 has joined #openstack-ironic03:10
Haomengzhenguo: so devstack 1G = 512M ram used by ipa os, and rest of them will be consumed by ram disk03:10
devanandajlvillal, NobodyCam, rameshg87-away - anyone around to summarize current status? or shall we wait until the morning?03:11
zhenguoHaomeng: ok, will update,03:11
Haomengzhenguo: ok, thanks03:11
*** rameshg87-away has quit IRC03:11
lintanhi devanada, as versionedobject library increase to 0.8, which break Ironic's versionedobject. So the solution is to using our own objectlist class like https://review.openstack.org/#/c/216472/03:16
devanandai found the whiteboard and the revert path03:16
devanandapatch03:16
devanandadhellmann: ping -- gate is stuck and, well, we can't land the tag now03:17
lintandevanada, but because Ironic didn't use objectlist at all, we can remove it in a follow patch03:17
devanandalintan: the problem is - we've already tagged the release to the current HEAD03:18
devanandaso landing something else now and THEN the release ... i do not know what that will do03:18
lintanit's tough....03:18
devanandalifeless: around? any ideas?03:20
devanandaI'm goiung to hold of funtil tomorrow, when I an get assistane from dhellmann or lifeless03:20
devanandaas I don't want to make their lives harder03:20
devanandaHaomeng, rameshg87 - please continue reviewing and +2'ing, but do not +A tonight03:21
devanandathanks03:21
rameshg87devananda: sure.03:21
Haomengdevananda: ok:)03:21
mrdahey devananda, you're up to speed now?03:23
*** links has joined #openstack-ironic03:24
*** asd112z has quit IRC03:31
*** davideagnello has quit IRC03:33
rameshg87Haomeng: mrda: lintan: have you guys ever tested a take over of a bare metal by another conductor ?03:45
*** shoutm_ has quit IRC03:48
rameshg87Haomeng: mrda: lintan: any idea why it isn't supported for nodes at 'wait call-back' ?03:52
mrdaooh, ok03:54
mrdaI haven't tested it, but that is totally something I *need* to test :)03:55
mrdaand if a node is at wait-callback, it would be wonderful if another conductor could take it over, but my guess is that it doesn't work03:55
rameshg87mrda: yeah take over in that sense is just caching the deploy kernel/ramdisk and creating the pxe config03:56
jlvillalrameshg87, Have you tried 'git grep'?03:56
rameshg87mrda: I don't see a reason why it isn't possible03:56
openstackgerritZhenguo Niu proposed openstack/ironic: Check image size before provisioning for agent driver  https://review.openstack.org/21525403:56
rameshg87jlvillal: for what ?03:56
mrdajlvillal: you need to stop working now :)03:57
jlvillalInstead of 'grep -R blah ironic/*' :)03:57
jlvillalrameshg87, ^^  I was looking at your comment: https://review.openstack.org/#/c/213601/3/ironic/objects/fields.py03:57
mrdajlvillal: I use 'ack-grep'.  It's grep on steriods and *so* much better03:57
jlvillalmrda, I will. I was just checking in and seeing what was going on.03:58
mrdarameshg87: I'm not sure at a code level why it's not possible03:58
jlvillalmrda, I have never heard of 'ack-grep'03:58
mrdajlvillal: http://beyondgrep.com/03:58
jlvillalmrda, Thanks03:58
rameshg87jlvillal: what difference does it make03:59
rameshg87?03:59
rameshg87even git grep returns me nothing actually03:59
mrdarameshg87: If it doesn't work for you, can I suggest raising a bug?  I think as a project we want this to work...03:59
jlvillalrameshg87, I like it because it won't try to search .git/ directories.  It is pretty fast too.03:59
*** shoutm has joined #openstack-ironic03:59
rameshg87mrda: yeah, I was plannign to raise a bug, but thought of first checking with a  few folks who know any reason why today it isn't04:00
mrdajlvillal: ack-grep doesn't search git dirs, temp files, binary files etc  It's awesome!  You should totally try it!04:00
rameshg87jlvillal: oh okay04:00
jlvillalmrda, I might :) 'git grep' has been working well for me. But ack-grep does sound like it would be useful in non-git tree situations for me.04:01
rameshg87jlvillal: honestly I didn't know anything could beat gnu grep :)04:01
mrdarameshg87: Thanks rameshg87, I'm not promising to solve it, but I'm happy to try and confirm it with a little (NUC-based) test network here at home.  I think it's something my overlords would want to work.04:01
rameshg87mrda: sure. will file a bug then.04:02
jlvillalrameshg87, Maybe give it a try some time :)04:02
rameshg87mrda: the only issue that I see is04:02
rameshg87mrda: take_over takes a little time to detect unless we shut it down in a gentle way04:02
rameshg87mrda: by that time the bare metal could have attempted to boot from pxe and would have failed04:03
rameshg87mrda: today the heart beat timeout is 60 seconds04:03
rameshg87mrda: so any bare metal taking less than 60 seconds to complete POST might not benefit04:03
mrdaright04:04
mrdaI didn't say it's necessarily easy, but it's an edge case that would be nice to have covered properly04:04
rameshg87mrda: yeah would be nice to have anyway04:04
rameshg87mrda: is it a feature or bug ? :)04:05
mrdarameshg87: I'd say bug :)04:09
*** ramineni has joined #openstack-ironic04:12
*** VikasC has joined #openstack-ironic04:14
*** ramineni1 has joined #openstack-ironic04:16
*** ramineni2 has joined #openstack-ironic04:17
*** puranamr has joined #openstack-ironic04:17
*** ramineni has quit IRC04:17
*** VikasC has quit IRC04:18
*** ramineni1 has quit IRC04:20
*** ramineni2 has quit IRC04:22
*** ramineni has joined #openstack-ironic04:25
*** saripurigopi has joined #openstack-ironic04:27
*** puranamr has quit IRC04:29
*** ramineni has quit IRC04:29
*** baoli has quit IRC04:35
*** bnemec has quit IRC04:42
*** Sukhdev has joined #openstack-ironic04:42
openstackgerritRamakrishnan G proposed openstack/ironic: Refactor agent driver with pxe boot interface  https://review.openstack.org/16652104:46
*** natorious is now known as zz_natorious04:47
*** rameshg871 has joined #openstack-ironic04:50
*** rameshg87 has quit IRC04:52
openstackgerritShivanand Tendulker proposed openstack/ironic: iLO driver documentation for UEFI secure boot  https://review.openstack.org/21652805:10
*** VikasC has joined #openstack-ironic05:15
*** lintan__ has quit IRC05:17
*** VikasC has quit IRC05:20
*** yog_ has joined #openstack-ironic05:20
saripurigopiMorning Ironic05:23
*** yog_ has quit IRC05:31
*** asd112z has joined #openstack-ironic05:32
openstackgerritTan Lin proposed openstack/ironic: Remove ObjectListBase  https://review.openstack.org/21360105:33
*** praneshp has joined #openstack-ironic05:34
*** davideagnello has joined #openstack-ironic05:36
*** praneshp_ has joined #openstack-ironic05:41
*** balajin_ has quit IRC05:41
Haomengsaripurigopi: morning:)05:43
*** praneshp has quit IRC05:43
*** praneshp_ is now known as praneshp05:43
saripurigopiHaomeng: o/05:43
*** balajin has joined #openstack-ironic05:45
*** asd112z has quit IRC05:51
*** yog_ has joined #openstack-ironic05:52
*** zhenguo has quit IRC05:53
openstackgerritShivanand Tendulker proposed openstack/ironic: Refactor iscsi_ilo driver to use new boot interface  https://review.openstack.org/21653805:56
*** links has quit IRC05:57
*** links has joined #openstack-ironic06:00
*** baoli has joined #openstack-ironic06:05
*** zhenguo has joined #openstack-ironic06:09
*** irenab has quit IRC06:11
*** BadCub has quit IRC06:12
*** boris-42 has quit IRC06:12
*** lekha has quit IRC06:13
*** BadCub has joined #openstack-ironic06:14
lifelessdevananda: hi, sup ?06:14
lifelessdevananda: oh - land the fix06:15
*** lekha has joined #openstack-ironic06:16
*** boris-42 has joined #openstack-ironic06:17
*** baoli has quit IRC06:20
*** ukalifon1 has joined #openstack-ironic06:20
*** yuanying has quit IRC06:25
*** yog_ has quit IRC06:31
*** Sukhdev has quit IRC06:34
*** irenab has joined #openstack-ironic06:38
*** lintan has quit IRC06:39
*** yuanying has joined #openstack-ironic06:44
*** rameshg871 has quit IRC06:45
*** shoutm has quit IRC06:49
*** lintan has joined #openstack-ironic06:49
*** yuikotakada has joined #openstack-ironic06:49
*** Nisha has joined #openstack-ironic06:51
*** shoutm has joined #openstack-ironic06:51
*** dtantsur|afk is now known as dtantsur06:54
dtantsurMorning Ironic06:54
*** davideagnello has quit IRC06:57
*** PradeepV has joined #openstack-ironic07:00
PradeepVHi Ironic07:02
saripurigopidtantsur: o/07:03
HaomengPradeepV: hi, sorry for late response, I am in away status for my night time:)07:03
Haomengdtantsur: o/07:03
yuikotakadaHi, Ironic :)07:03
HaomengPradeepV: so what is your last question, can you repeat07:03
dtantsuryuikotakada, o/07:04
dtantsurHaomeng, saripurigopi o/07:04
Haomengyuikotakada: o/07:04
Haomengdtantsur: :)07:04
yuikotakadadtantsur, Haomeng, o/07:04
*** ifarkas has joined #openstack-ironic07:05
PradeepVThank you Haomeng, at last i was able to bring up the flat network setup for deploying the ironic using agent driver, can we use the same whole disk image for agent driver also?07:07
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/21656207:07
HaomengPradeepV: yes, sure07:07
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements  https://review.openstack.org/21304807:07
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/21656307:07
HaomengPradeepV: cool07:07
PradeepVok Haomeng,is there any configuration changes for deploying the agent driver or is it similar to pxe driver?07:08
HaomengPradeepV: almostly same operations, and you can check the guide out to see the differences07:09
HaomengPradeepV: http://docs.openstack.org/developer/ironic/deploy/install-guide.html07:09
*** achanda has quit IRC07:10
HaomengPradeepV: there are some special for agent drivers, such as MD5 checksum of instance image is required07:11
PradeepVcan you send me the link for the guide07:12
*** achanda has joined #openstack-ironic07:14
*** praneshp has quit IRC07:20
*** achanda has quit IRC07:30
*** yog_ has joined #openstack-ironic07:30
openstackgerritMerged openstack/ironic-lib: Updated from global requirements  https://review.openstack.org/21304807:31
*** ndipanov has quit IRC07:38
*** lazy_prince has joined #openstack-ironic07:39
HaomengPradeepV: this one - http://docs.openstack.org/developer/ironic/deploy/install-guide.html07:48
*** baoli has joined #openstack-ironic07:58
*** ionutbalutoiu has joined #openstack-ironic08:00
*** yuikotakada has quit IRC08:02
*** baoli has quit IRC08:02
*** shoutm has quit IRC08:03
*** asd112z has joined #openstack-ironic08:03
*** Nisha_away has joined #openstack-ironic08:04
*** Nisha has quit IRC08:05
*** shoutm has joined #openstack-ironic08:05
*** asd112z has quit IRC08:08
*** ionutbalutoiu has quit IRC08:08
betherlymorning all :)08:11
*** jistr has joined #openstack-ironic08:12
*** rameshg87 has joined #openstack-ironic08:15
*** e0ne has joined #openstack-ironic08:17
*** derekh has joined #openstack-ironic08:24
*** romainh has joined #openstack-ironic08:24
*** karimb has joined #openstack-ironic08:25
Haomengbetherly: morning:)08:26
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: [WIP] Add introspection rules support  https://review.openstack.org/20837508:26
dtantsurbetherly, morning08:26
*** lucasagomes has joined #openstack-ironic08:31
openstackgerritDmitry Tantsur proposed openstack/ironic: Add deprecation warning to periodic tasks with parallel=False  https://review.openstack.org/21660408:31
betherly:)08:32
openstackgerritDmitry Tantsur proposed openstack/ironic: Add deprecation warning to periodic tasks with parallel=False  https://review.openstack.org/21660408:34
dtantsurdevananda, hi, I see you don't sleep :) Is it possible we get ^^ in Liberty?08:34
*** Nisha_away has quit IRC08:34
devanandahi!08:34
devanandamaybe?08:34
dtantsurhmm, I should have updated docs as well in this patch..08:35
devanandai'm trying to get 4.0.0 out now(), but I hope this is not the final cut for liberty. we have several things in flight right now, half done, which we should all finish soon08:35
devanandaand then roll into liberty, regardless of whether that is 4.1 or 5.0 or what ever08:35
lifelessdevananda: I replied btw - I think you should just land the unbreak patch08:37
devanandalifeless: ack. I have pushed that button now08:37
dtantsurcool08:37
devanandalifeless: how does that work for the release mechanisms?08:38
devanandado we go update openstack/releases with the new SHA ?08:38
lifelessdevananda: I wouldn't both08:38
*** Nisha_away has joined #openstack-ironic08:38
lifelessdevananda: the only reason your tree state matters at all is landing the patch to remove version=08:38
*** pelix has joined #openstack-ironic08:39
devanandalifeless: IIUC, someone installing a package of the SHA listed in openstack/releases, and pulling down 0.8.0 of oslo versioned objects, is going to find that it doesn't work08:39
lifelessyes, but if your release had happened, they'd still find that08:40
devanandasure08:40
devanandaand we'd do a 4.0.1 right away08:40
lifelessdevananda: so, since its not planned to be your final release08:40
lifelessI wouldn't sweat it08:40
*** romcheg has joined #openstack-ironic08:41
lifelessdevananda: also the fix is AIUI test only, so most users wouldn't notice08:41
lifelessdevananda: how many people run your tests from releases?08:41
devanandafair point08:41
*** pelix has quit IRC08:43
devanandaok - I'm going to go back to sleep now, and check on the gate again when I wake up :)08:43
rameshg87devananda: I can watch and give some rechecks if required. gn ;-)08:45
openstackgerritDmitry Tantsur proposed openstack/ironic: Add deprecation warning to periodic tasks with parallel=False  https://review.openstack.org/21660408:46
*** dtantsur is now known as dtantsur|brb08:47
openstackgerritYuriy Zveryanskyy proposed openstack/ironic: Add vendor interface to ipminative driver  https://review.openstack.org/21518508:55
openstackgerritDingyx proposed openstack/ironic-specs: lenovo driver proposal  https://review.openstack.org/20831908:56
*** max_lobur has joined #openstack-ironic09:00
*** max_lobur has quit IRC09:00
*** romcheg has quit IRC09:01
*** max_lobur has joined #openstack-ironic09:02
lucasagomesalright so our gate is broken :-( ?09:06
lucasagomesdamn oslo objects09:06
rameshg87lucasagomes: it will be fixed soon, the fixing patch is already in merge queue09:14
lucasagomesrameshg87, thanks, yeah it's in gate09:14
lucasagomestho gate's a bit slow09:14
*** romcheg has joined #openstack-ironic09:14
lucasagomesrameshg87, btw re elilo UEFI09:14
rameshg87yes09:15
lucasagomesrameshg87, the guy built the deploy ramdisk w/o dracut and it booted09:15
lucasagomesbut it fails when talking to Ironic09:15
lucasagomeswhen building the json09:15
lucasagomes<myllynen> Requesting Ironic API to deploy image09:15
lucasagomes<myllynen> Requesting Ironic API to comlete the deploy09:15
lucasagomes<myllynen> 500 Internal Server Error09:15
lucasagomes<myllynen> sigh09:15
lucasagomes<myllynen> error_message ... Invalid control character '\\\\\n' at line 1 column 163 (char 162)09:15
rameshg87eh, that's strange09:16
lucasagomesseems to be something around https://github.com/openstack/diskimage-builder/blob/master/elements/deploy-ironic/init.d/80-deploy-ironic#L154-L15509:16
lucasagomesrameshg87, yeah09:16
lucasagomeswas wondering if the elilo will replace that "ip=" kernel cmd line template we have https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/elilo_efi_pxe_config.template#L609:17
lucasagomesip=%I:{{pxe_options.tftp_server}}:%G:%M:%H::on"09:17
lucasagomesanyway... rameshg87 you haven't seem that right?09:17
rameshg87lucasagomes: no09:18
lucasagomesit's cool, I will help him to debug it09:18
rameshg87lucasagomes: we run internal jenkins nightly for pxe_ilo which uses elilo, so it's not broken09:18
lucasagomesrameshg87, right09:18
lucasagomesyeah it's odd09:18
*** MattMan has joined #openstack-ironic09:19
rameshg87lucasagomes: let me check if I can machine console of pxe_ilo uefi job09:19
lucasagomesrameshg87, ack thanks09:19
*** marzif has joined #openstack-ironic09:21
*** marzif has quit IRC09:31
*** marzif has joined #openstack-ironic09:31
*** ramineni has joined #openstack-ironic09:38
rameshg87lucasagomes: https://drive.google.com/file/d/0B5a_VAhX3Hz5RTM3LVp4WGo0NXM/view09:40
rameshg87lucasagomes: not sure if it will help, but you can refer those portions of elilo boot to compare and see if you see something strange09:41
lucasagomesrameshg87, ah thanks much!09:41
*** shoutm has quit IRC09:41
lucasagomesrameshg87, this is PXE booting ? Or virtual media?09:41
rameshg87lucasagomes: pxe booting with elilo09:41
lucasagomesoh I see the PXE part09:41
lucasagomesthanks09:41
rameshg87lucasagomes: elilo version also mattered09:42
rameshg87lucasagomes: faizan who worked on this had faced issues with versions < 3.16 iirc09:42
lucasagomesrameshg87, anything > 3.16 should do it?09:43
rameshg87yes09:43
lucasagomesgotcha rameshg87 thanks very much!09:43
*** max_lobur has quit IRC09:49
*** ndipanov has joined #openstack-ironic09:51
*** naohirot has quit IRC09:55
*** romainh has quit IRC10:00
Nisha_awaylucasagomes, rameshg87 please review https://review.openstack.org/198656 https://review.openstack.org/20190410:01
*** yog_ has quit IRC10:06
*** romcheg has quit IRC10:06
*** irenab has quit IRC10:18
*** pelix has joined #openstack-ironic10:28
*** romcheg has joined #openstack-ironic10:32
rameshg87lucasagomes: hi10:39
rameshg87lucasagomes: any thoughts on this bug that I had raised today morning ?  - https://bugs.launchpad.net/ironic/+bug/148831410:39
openstackLaunchpad bug 1488314 in Ironic "ironic doesn't support take_over for nodes in wait-call-back" [Undecided,New]10:39
lucasagomesrameshg87, hi there! Lemme check10:41
*** Nisha_away has quit IRC10:43
*** dtantsur|brb is now known as dtantsur10:43
lucasagomesrameshg87, yeah it seems right, if the node gets remapped in the ring and a new conductor gets the request to continue deploy10:44
lucasagomesit should have things cached from prepare()10:44
openstackgerritSatoru Moriya proposed openstack/ironic-specs: Volume connection information for Ironic nodes  https://review.openstack.org/20049610:44
rameshg87lucasagomes: yeah, I don't see a reason why it isn't possible10:44
lucasagomesrameshg87, perhaps it's something that continue_deploy should do? In case the images, pxe config etc is not present it should call prepare() for that node?10:45
lucasagomesrameshg87, yeah, seems totally possible10:45
rameshg87may be if time for bare metal POST < the heart beat timeout10:45
rameshg87the bare metal might attempt booting and fail10:45
rameshg87but we can always give a chance10:45
lucasagomesyeah10:45
rameshg87lucasagomes: yeah, okay10:45
rameshg87lucasagomes: another one10:46
rameshg87there is a window of gap between when the node gets remapped to different conductor (due to heartbeat timeout) and the periodic task sync local state is run10:46
rameshg87lucasagomes: any operation triggered within this timeframe (like reboot of instance) might fail because pxe configs are not generated10:47
rameshg87lucasagomes: is there anything I am missing ? I haven't tried out this scenario, but it seems possible it can happen.10:48
lucasagomesrameshg87, yeah no I think it can totally happen indeed10:48
lucasagomesI think few people see it because they usually use local boot10:48
lucasagomesor full disk image10:48
rameshg87lucasagomes: okay10:48
rameshg87lucasagomes: okay, will test and see if I can reproduce that issue locally10:49
lucasagomesthey only way to fix that I would say is somehow have all the conductors which has that driver enbaled to be to control all the nodes deployed with that driver10:49
rameshg87lucasagomes: but even then the neutron dhcp parameters would still point to the dead conductor10:50
rameshg87lucasagomes: and tftp fetch of kernel will fail unless take_over is completed10:50
rameshg87if it's a netboot though10:50
lucasagomesoh true10:51
rameshg87lucasagomes: another way is we can have someway to indicate that take_over hasn't happened and can trigger a take_over first when power on or reboot is triggered10:52
lucasagomesrameshg87, yeah, the problem is that we calculate the hash when the request comes10:52
rameshg87lucasagomes: yes10:52
lucasagomesor in that periodic task10:52
lucasagomeswe could try to trigger something when we detect that a conductor is dead10:53
rameshg87yeah may be10:53
rameshg87lucasagomes: anyways looks like an interesting thing to solve10:53
rameshg87:)10:53
lucasagomes++10:53
* rameshg87 begins setting up another conductor10:54
*** yog_ has joined #openstack-ironic10:54
*** romcheg has quit IRC10:57
*** smoriya has quit IRC11:00
openstackgerritMerged openstack/ironic: Remove ObjectListBase  https://review.openstack.org/21360111:02
*** asd112z has joined #openstack-ironic11:03
*** asd112z has quit IRC11:08
*** Marga_ has quit IRC11:10
*** adam_g has quit IRC11:12
*** dprince has joined #openstack-ironic11:19
rameshg87devananda: ^^^^ it's merged11:20
*** lucasagomes has quit IRC11:21
*** lucasagomes has joined #openstack-ironic11:22
*** romcheg has joined #openstack-ironic11:24
sambettsUGT Morning everyone o/11:25
lucasagomessambetts, morning11:28
dtantsursambetts, morning again :)11:29
sambetts:D11:29
openstackgerritRamakrishnan G proposed openstack/ironic: Refactor agent driver with pxe boot interface  https://review.openstack.org/16652111:30
* rameshg87 leaves for the day 11:31
*** rameshg87 has quit IRC11:31
TheJuliagood morning everyone11:33
*** saripurigopi has quit IRC11:34
dtantsurTheJulia, morning11:34
sambettsdtantsur: https://review.openstack.org/#/c/216670/11:35
dtantsursambetts, cool! do you have a link generated for it?11:35
sambettsdtantsur: I've not created a short url for it yet, I'm about to do it11:36
sambettsdtantsur: whats the best services for that do you think?11:36
dtantsursambetts, no idea, I used perm.ly ones11:37
openstackgerritYuriy Zveryanskyy proposed openstack/ironic: Add vendor interface to ipminative driver  https://review.openstack.org/21518511:37
sambettsdtantsur: cool, I'll look into it, and post it on the whiteboard once its done11:37
dtantsurthanks!11:38
*** ramineni has quit IRC11:38
*** Haomeng|2 has joined #openstack-ironic11:39
*** irenab has joined #openstack-ironic11:40
*** Marga_ has joined #openstack-ironic11:40
*** Haomeng has quit IRC11:42
*** lucasagomes is now known as lucas-hungry11:45
lucas-hungryTheJulia, morning11:45
*** zhenguo has quit IRC11:55
openstackgerritLucio Seki proposed stackforge/pyghmi: Add RAID drive and controller to ThinkServer inventory  https://review.openstack.org/21639811:57
*** shoutm has joined #openstack-ironic12:02
*** trown|outttypeww is now known as trown12:03
trowngood morning Ironic, and congrats Sam12:04
openstackgerritJulia Kreger proposed openstack/bifrost: Resync with openstack/requirements  https://review.openstack.org/21668112:14
openstackgerritLucio Seki proposed stackforge/pyghmi: Add RAID drive and controller to ThinkServer inventory  https://review.openstack.org/21639812:15
*** romcheg has quit IRC12:20
*** romainh has joined #openstack-ironic12:20
*** dlpartain has joined #openstack-ironic12:21
*** dlpartain has left #openstack-ironic12:21
*** romcheg has joined #openstack-ironic12:24
sambettstrown: Thanks :)12:40
*** baoli has joined #openstack-ironic12:44
*** [1]cdearborn has joined #openstack-ironic12:44
openstackgerritLucio Seki proposed stackforge/pyghmi: Add RAID drive and controller to ThinkServer inventory  https://review.openstack.org/21639812:44
*** lucas-hungry is now known as lucasagomes12:46
*** sinval has quit IRC12:47
*** nicodemos has joined #openstack-ironic12:48
*** baoli has quit IRC12:48
*** jjohnson2 has joined #openstack-ironic12:50
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/21656212:51
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: [WIP] Add introspection rules support  https://review.openstack.org/20837512:58
*** nicodemos has quit IRC13:00
openstackgerritMerged stackforge/pyghmi: Add RAID drive and controller to ThinkServer inventory  https://review.openstack.org/21639813:01
*** nicodemos has joined #openstack-ironic13:03
*** baoli has joined #openstack-ironic13:07
*** rloo has joined #openstack-ironic13:08
openstackgerritMerged openstack/ironic: Switch to post-versioning  https://review.openstack.org/21638813:09
rloohi everyone. and yay, ^^, does this mean we can approve?13:11
dtantsurrloo, I hope so.. and g'morning :)13:11
rloodtantsur: you go first :D13:12
*** baoli_ has joined #openstack-ironic13:14
*** zhenguo has joined #openstack-ironic13:16
*** baoli has quit IRC13:17
openstackgerritAnton Arefiev proposed openstack/python-ironicclient: Introduce tempest-lib to functional tests  https://review.openstack.org/21670113:18
*** davidlenwell has quit IRC13:19
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/21656213:20
*** davidlenwell has joined #openstack-ironic13:20
*** links has quit IRC13:23
*** mtanino has joined #openstack-ironic13:23
*** davideagnello has joined #openstack-ironic13:28
*** davideagnello has quit IRC13:28
*** thiagop has joined #openstack-ironic13:29
thiagopgood morning Ironicers13:29
*** absubram has joined #openstack-ironic13:32
*** absubram has quit IRC13:35
BadCubmorning Ironic13:36
thiagopmorning BadCub13:39
*** sinval has joined #openstack-ironic13:40
*** bapalm has quit IRC13:44
*** karimb has quit IRC13:46
dtantsurBadCub, thiagop, morning13:46
BadCubmorning thiagop and dtantsur13:47
*** bapalm_ is now known as bapalm13:51
rlooAnyone know if ramesh is around? I don't see him.13:52
*** karimb has joined #openstack-ironic13:52
rloomorning BadCub, thiagop.13:52
thiagoprloo: o/13:53
thiagopdtantsur BadCub  o/13:53
dtantsurrloo, I think he's sleeping :)13:54
BadCubmorning rloo13:54
rloodtantsur: already? :D. Guess I missed him again. Oh well.13:54
openstackgerritJohn Trowbridge proposed openstack/ironic-inspector: Store and expose introspection data  https://review.openstack.org/21315913:54
dtantsurrloo, I think they have around 8-9pm now13:54
rloodtantsur: I should have 'talked' to him last night but i was tired then. We'll connect at some point...13:55
thiagopjlvillal: Hiya13:55
thiagopjlvillal: are you there?13:55
rloodtantsur: it is actually regarding the RAID patch https://review.openstack.org/#/c/196006/2013:56
rloodtantsur: where he calls raid.validate() to check if the submitted config is OK13:57
rloodtantsur: don't know if you have any opinion on that. I disagree with calling .validate() cuz it could be doing more than checking the config.13:57
dtantsurrloo, what else do you think validate() could be doing?13:58
rloodtantsur: dunno. but it is driver specific. what if there was something in driver_info that it wanted?13:58
NobodyCamgood morning ironicers :)13:58
rloodtantsur: if validate ONLY validated the config, i'd be fine with it, but it isn't documented as saying that it only does that.13:59
trowno/ NobodyCam13:59
thiagopgood morning NobodyCam14:00
trowndtantsur: for the devstack/excercise.sh do you think it is even worth using those env variables, or should I just hardcode the URI in the CURL function?14:00
rloomorning NobodyCam14:00
NobodyCamgood morning trown thiagop rloo lucasagomes dtantsur sambetts jlvillal TheJulia jroll14:00
dtantsurtrown, I would starting with just hardcoding it, until we get inspector registered in keystone (which is a nice TODO btw)14:00
dtantsurNobodyCam, morning!14:01
lucasagomesNobodyCam, thiagop BadCub rloo trown good ugt morning14:01
NobodyCam:)14:01
thiagophiya lucasagomes14:01
trowno/ lucasagomes14:02
BadCubmorning lucasagomes14:03
*** ukalifon1 has quit IRC14:03
*** endorphin has joined #openstack-ironic14:07
rloohi lucasagomes14:08
NobodyCam:)14:08
jlvillalthiagop, Hello. I hope the review was okay :)14:10
jlvillalGood morning thiagop BadCub rloo dtantsur trown lucasagomes and everyone else I may have missed :)14:11
dtantsurjlvillal, morning!14:11
* jlvillal only reads the backlog so far...14:11
BadCubMorning jlvillal14:11
rloomorning jlvillal14:11
jlvillalI'm glad to see the gate is unbroken. Thanks for fixing it!14:11
thiagopjlvillal: much very ok! thank you very much. We're studying the possibility to remove that exception class to python-oneviewclient, but I was wondering about the messages anyway14:11
thiagopjlvillal: do you think "Server Hardware went to Error State when trying to change power state" fits better on OneViewErrorStateSettingPowerState?14:13
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Pass -w flag to iptables to make it wait for xtables lock  https://review.openstack.org/21672614:13
jlvillalthiagop, Just let me know if you have questions. And remember my review can be wrong too! :)14:13
jlvillalthiagop, looking...14:13
*** mtanino has quit IRC14:14
jlvillalthiagop, Yes, that makes much more sense to me than what is currently at https://review.openstack.org/#/c/191822/18/ironic/drivers/modules/oneview/exceptions.py14:15
thiagopjlvillal: ty ;)14:16
*** dlpartain has joined #openstack-ironic14:20
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal power state commands  https://review.openstack.org/17251714:20
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Introduce openstackclient plugin  https://review.openstack.org/17167214:20
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal port create  https://review.openstack.org/17246114:20
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Add provision state command  https://review.openstack.org/20611914:20
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Add maintenance mode command  https://review.openstack.org/21672714:20
thrashdtantsur: fixed a coupld of typos, and broke out provision state and maintenance mode to their own commands14:21
dtantsurcool!14:21
thrashlol... type in the sentence 'fixed a couple of typos'14:21
thrashand ANOTHER typo14:22
thrashrecursive typos!14:22
trownintypoception14:22
dtantsurI can't write typo correctly 4 times of 514:24
openstackgerritNaohiro Tamura proposed openstack/ironic: Generic power I/F for soft power off and cancel task  https://review.openstack.org/21673014:25
*** dlpartain has left #openstack-ironic14:28
*** tsekiyama has joined #openstack-ironic14:32
*** asd112z has joined #openstack-ironic14:32
*** asd112z has quit IRC14:33
*** asd112z has joined #openstack-ironic14:33
*** asd112z has quit IRC14:34
*** asd112z has joined #openstack-ironic14:34
openstackgerritNaohiro Tamura proposed openstack/ironic: Enhance ipmitool driver for soft power off and cancel task  https://review.openstack.org/21673814:34
*** PradeepV has quit IRC14:38
openstackgerritVladyslav Drok proposed openstack/ironic: Add credentials migration script  https://review.openstack.org/19321814:38
openstackgerritVladyslav Drok proposed openstack/ironic: Add pluggable credentials storage  https://review.openstack.org/18507414:38
*** mgoddard has quit IRC14:40
*** afaranha has joined #openstack-ironic14:41
openstackgerritNaohiro Tamura proposed openstack/ironic: Enhance iRMC driver for soft power off and cancel task  https://review.openstack.org/21674314:41
*** links has joined #openstack-ironic14:43
openstackgerritShivanand Tendulker proposed openstack/ironic-specs: Add Zapping support to iLO drivers  https://review.openstack.org/14540414:46
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Add cleanup in console utils tests  https://review.openstack.org/21674514:49
*** shoutm has quit IRC14:52
*** zz_natorious is now known as natorious14:53
*** amotoki has joined #openstack-ironic14:54
*** achanda has joined #openstack-ironic14:54
*** natorious is now known as zz_natorious14:54
*** zz_natorious is now known as natorious14:56
*** mtanino has joined #openstack-ironic15:02
*** nicodemos has quit IRC15:03
*** mgoddard has joined #openstack-ironic15:03
*** achanda has quit IRC15:04
*** ionutbalutoiu has joined #openstack-ironic15:07
devanandamorning, all15:11
NobodyCamgood morning devananda :)15:11
openstackgerritShivanand Tendulker proposed openstack/ironic: Fix ensures pass_deploy_info() always calls boot.prepare_instance()  https://review.openstack.org/21675615:12
*** [1]cdearborn has quit IRC15:12
*** linggao has joined #openstack-ironic15:13
zhenguodevananda: morning15:14
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Add cleanup in console utils tests  https://review.openstack.org/21674515:16
openstackgerritDoug Hellmann proposed openstack/ironic: format links in the readme to work with the release notes tools  https://review.openstack.org/21675815:17
rloomorning devananda. I hope we're OK to approve patches now15:25
devanandagmorning, rloo. there are a few things I am trying to clean up so we can do a 4.0.1 right away, after that, yes15:26
rloodevananda: ok. (/me hopes I didn't approve anything in ironic already.)15:27
zhenguodevananda: can you have a look at the updated nodes-tagging spec https://review.openstack.org/#/c/192935/ please after you finish the release work, it's stuck for a long time so I take it over and update.15:28
*** davideagnello has joined #openstack-ironic15:29
devanandazhenguo: thanks! however, I probably won't have time -- there's a lot to do before I leave for vacation in 2 days, and it's very unlikely we'll get around to that work in Liberty15:29
krotscheckCan whoever sees rameshg next ask him to respond to my comment on https://review.openstack.org/#/c/199769/ please?15:30
dtantsurdevananda, morning15:31
zhenguodevananda: ok, maybe we should move it to next.15:31
*** davideagnello has quit IRC15:34
* devananda recreates his venv15:34
*** zhenguo has quit IRC15:36
*** Marga_ has quit IRC15:42
*** jjohnson2 has quit IRC15:42
*** Marga_ has joined #openstack-ironic15:43
*** mgoddard has quit IRC15:43
*** meghal has joined #openstack-ironic15:44
*** lsmola has quit IRC15:44
*** links has quit IRC15:44
thiagopmorning devananda15:44
*** puranamr has joined #openstack-ironic15:45
*** puranamr has quit IRC15:46
*** puranamr has joined #openstack-ironic15:46
* devananda is having E_TOO_LITTLE_COFFEE issues15:47
*** puranamr has quit IRC15:47
*** puranamr has joined #openstack-ironic15:48
*** meghal has left #openstack-ironic15:48
*** meghal has joined #openstack-ironic15:48
rloojlvillal: wrt https://wiki.openstack.org/wiki/Nova-Ironic-Bugs, what is 'Fix proposed' vs eg 'Owned by Ironic team'?15:50
*** mgoddard has joined #openstack-ironic15:59
*** davideagnello has joined #openstack-ironic16:00
*** ifarkas has quit IRC16:02
thiagopjlvillal: in some of the exceptions, we intend to overwrite the message. Do you think we should remove the default message of them?16:03
*** mgoddard1 has joined #openstack-ironic16:04
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Fail introspection early if no lookup attributes can be detected  https://review.openstack.org/21677716:06
devananda** NOTICE ** everyone can resume normal reviewing / landing patches. We have switched to "post versioning" now on the server, much like the client used to be (and still is). <<< rloo NobodyCam dtantsur lucasagomes Haomeng|2 yuriyz ramesh^^^ jroll16:06
openstackgerritVladyslav Drok proposed openstack/ironic-specs: Add pluggable credentials storage  https://review.openstack.org/18605616:07
*** mgoddard has quit IRC16:07
dtantsurdevananda, \o/16:07
rloodevananda: yay!16:07
NobodyCamty devananda :)16:07
dtantsur(inspector has been on postversioning since 2.0.0)16:07
devanandaI'll be sending release notes for 4.0.0 after I get some food16:07
trownwoot16:08
devanandadtantsur: you are aware of the new (in liberty) release process and that it is in effect for inspector as well, I presume?16:08
devanandaie, post a CR to openstack/releases16:08
dtantsurdevananda, I'm aware only about the former, and the latter requires actions for me, IIRC16:08
dtantsur* from16:08
dtantsurit's not automatic, someone needs to fix ACL's, maybe launchpad16:09
devanandacool. I believe dhellmann does that. it's updated in the governance repo, so I suspect he's done it automatically, but good to check with him16:09
dtantsurdevananda, so I'm not sure it's in effect for inspector *now*, but I'll be definitely switching to it ASAP16:09
dtantsurdevananda, we've chatted on the ML. governance repo is a bit messy wrt inspector: python-ironic-inspector-client got release:managed without me knowing, inspector itself is still officially independent16:11
dtantsurI assume the easiest thing now is to sort it out after we release Liberty...16:11
*** marzif has quit IRC16:12
lucasagomes\o/16:13
*** endorphin has quit IRC16:14
openstackgerritVladyslav Drok proposed openstack/ironic-specs: Add pluggable credentials storage  https://review.openstack.org/18605616:15
dtantsurJoshNang, around? it's re https://review.openstack.org/#/c/215061/16:16
devanandadtantsur: I would think it's better to sort that out before liberty16:16
devanandaso that we can release inspector and ironic in as consistent a way as possible16:16
dtantsurdevananda, me too, if I had, say 36 hours in a day, or better a couple of clones :)16:16
JoshNangdtantsur: o/16:16
devanandaLOL. yea, well, if you figure that out, let me know. I need some too :)16:17
*** jistr has quit IRC16:17
devanandathis copy of me, however, needs breakfast ... bbiab16:17
dtantsurdevananda, so I'll put it on my todo list, and will *try* hard to sort it before liberty, ok? enjoy breakfast :)16:17
JoshNangdtantsur: ah yeah, that's reasonable.16:17
JoshNang(just saw your comment)16:17
dtantsurJoshNang, I think we should make lookup-less life possible, but it's a bit harder than just dropping it16:18
*** davideagnello has quit IRC16:18
dtantsurIIRC there's a (pretty contradictive) spec on it even16:18
*** jlk has left #openstack-ironic16:18
JoshNangheh yeah i talked about that spec a bunch at the midcycle16:18
*** puranamr has quit IRC16:19
openstackgerritThiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic  https://review.openstack.org/19182216:19
JoshNangbut yeah, we should be able to pass those configs in via the kernel commandline, but for now, yeah this makes sense16:19
*** e0ne has quit IRC16:20
JoshNangdtantsur: +216:23
dtantsursorry, my router decided that happily blinking is much funnier than giving me internets...16:24
dtantsurJoshNang, thanks!16:24
JoshNangheh no worries16:24
*** bnemec has joined #openstack-ironic16:25
*** marzif has joined #openstack-ironic16:28
openstackgerritJohn Trowbridge proposed openstack/ironic-inspector: Store and expose introspection data  https://review.openstack.org/21315916:33
trowndtantsur: whoops I did not see you did recheck16:34
dtantsurno problem :)16:35
trowndtantsur: I changed to hardcoded inspector url16:35
trownI think it failed building the ramdisk though16:36
dtantsuryeah16:38
*** romcheg has quit IRC16:44
jlvillalrloo: "Fix proposed' our bugs that show a patch has been submitted  (mrda)16:44
*** romcheg has joined #openstack-ironic16:45
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Clean up README  https://review.openstack.org/21679716:45
*** romcheg has quit IRC16:45
jlvillalrloo: 'Owned by Ironic team' our bugs that don't have a patch submitted (mrda)16:45
jlvillalIn theory...16:45
rloojlvillal: what is not owned by ironic team?16:45
rloojlvillal: I mean. Does the ironic team own all nova/ironic bugs?16:46
*** amotoki has quit IRC16:46
jlvillalrloo: No, we shouldn't own all of them. Some bugs are owned by people who don't contribute much to Ironic. They should go into that category.16:47
rloojlvillal: I don't understand the different subcategories. if they are meant to be mutually exclusive or just different ways of displaying the same info or ...16:47
rloojlvillal: so there could be 'Fix proposed' patches that are related to bugs owned by ironic team or not owned by ironic team?16:47
jlvillalrloo: We were trying to categorize things and hopefully stuff only went into one category.16:47
jlvillalThat was the initial plan.16:48
rloojlvillal: so which bugs are not owned by ironic team? (And how do you decide if they are owned... 'who don't contribute much'. hmm.16:48
*** mgoddard1 has quit IRC16:48
jlvillalHappy to take ideas on improvements.16:48
rloojlvillal:  really, i just want to know which are high priorities for us to look at :)16:48
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client: Make our README friendly to OpenStack release-tools  https://review.openstack.org/21679916:49
rloojlvillal: well, I'm just giving you feedback that I don't understand the subsections.16:49
*** adam_g has joined #openstack-ironic16:49
jlvillalrloo: Ah. mrda and I were planning on a more thorough scrub this afternoon. Go revisit bugs and see if things are changed. Some weeks we only look for new bugs.16:49
*** adam_g has quit IRC16:49
*** adam_g has joined #openstack-ironic16:49
rloojlvillal: 'Fix committed'. does that mean a patch was merged but the bug is still open/not fixed?16:50
jlvillalrloo: it means the fix was committed.  The bug could still be open or closed. We were trying to keep track of the things we have monitored.16:50
jlvillalInstead of just deleting it from the page when it was merged.16:50
jlvillalI will discuss with mrda today if we can figure out a better way to indicate high priority bugs.16:51
*** romainh has left #openstack-ironic16:51
rloojlvillal: 'the fix' == ? that the bug was fixed, or a patch with some fix was committed but it may eg be a partial fix?16:51
jlvillalrloo: Though we do put bugs that are ready for review into the Nova etherpad.16:51
jlvillalrloo: I think we were only doing bugs that had a 'closes-bug' comment.  I think.16:52
jlvillalHopefully partials didn't get into that list.16:52
rloojlvillal: so maybe i should just look at the nova etherpad? does this mean that if someone submits a patch for one of the bugs, they should let you/mrda know so you can update that etherpad?16:52
rloojlvillal: is the agreement between nova/ironic, that they will only look at the etherpad for patches?16:53
jlvillalrloo: That would be helpful for us. Which makes me think we should add that to the wiki page.16:53
jlvillalNova wants us (mrda and me) to review patches and put them on the Etherpad.16:53
*** mgoddard has joined #openstack-ironic16:53
*** jjohnson2 has joined #openstack-ironic16:54
jlvillalrloo: FYI: https://etherpad.openstack.org/p/liberty-nova-priorities-tracking16:54
jlvillalThere is a section for Ironic patches.16:54
rloojlvillal: perhaps an email to the community would help then, wrt the process. if nova folks will only look at the patches on that etherpad, it is in the interest of the patch submitters to have their patches listed there.16:54
jlvillalrloo: I think Nova will make an effort to look at the ones in the Etherpad. But I don't think they will only look at those ones.16:55
lucasagomesdevananda, rloo dtantsur NobodyCam wsme 0.8.0 was released and will break Ironic16:56
rloojlvillal: ok, but given that there is the etherpad and that some patches get listed there, it'd be good to know which ones/how/etc.16:56
jlvillalrloo: Okay. Thanks for the input. I will discuss it with mrda today and we can work on an email to send out.16:56
lucasagomesdevananda, rloo dtantsur NobodyCam I will put a fix right on before the mirror cache it16:56
*** romcheg has joined #openstack-ironic16:56
rloolucasagomes: ugh. you sure it will break?16:56
jlvillalrloo: Hopefully we can make things more obvious.16:56
lucasagomesrloo, yup just tested it locally16:56
jlvillalI think we need to describe our categories better.16:56
rloojlvillal: thx! (sorry, guess i should have looked at that wiki months ago.)16:57
rloolucasagomes: ok, let us know what to do :)16:57
rloolucasagomes: and thx for the heads up.16:58
lucasagomescool np16:58
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Update tests to reflect WSME 0.8 fixes  https://review.openstack.org/21680216:59
lucasagomesdevananda, rloo dtantsur ^^^16:59
lucasagomesNobodyCam, ^16:59
*** meghal has quit IRC16:59
*** derekh has quit IRC16:59
*** meghal has joined #openstack-ironic17:00
dtantsurlucasagomes, isn't it an API breaking change?17:00
jlvillalrloo: Thanks for the feedback. Much appreciated!17:01
*** meghal has quit IRC17:01
*** lazy_prince has quit IRC17:01
*** meghal has joined #openstack-ironic17:01
*** rameshg87 has joined #openstack-ironic17:02
lucasagomesdtantsur, well it was a bug in WSME17:03
lucasagomesdtantsur, it should not ignore fields that doesn't exist and says it created the object correctly17:03
dtantsurlucasagomes, still, following our definition of versioning we need to cover it by API version :)17:03
rameshg87rloo: hi17:03
lucasagomesnow it does the right thing17:03
lucasagomesdtantsur, that's an independent library... idk how we are capturing thta with API version17:04
rloohi rameshg8717:04
rloorameshg87:  you have a bit of time to discuss the raid stuff?17:04
dtantsurlucasagomes, it's not that I insist (and it's not that it's possible), obviously, but it might break people for real17:04
rloolucasagomes: where did those node.raid fields come from?17:04
rameshg87rloo: yeah, I came in for that17:04
*** karimb has quit IRC17:04
lucasagomesdtantsur, potentially yes17:04
rloorameshg87: oh, sorry you had to come in for that :-(17:04
lucasagomesrloo, some patch added it17:04
rameshg87rloo: oh no problem ..17:04
rameshg87was there something related to my patch going on already ?17:05
* rameshg87 reads back log17:05
lucasagomesrloo, https://review.openstack.org/#/c/155230/17:05
rloorameshg87: it is something else17:05
rameshg87okay17:06
rloolucasagomes: oh yeah. forgot that it got merged. sorry.17:06
dtantsurlucasagomes, so, to sum up my concern: previously people could provide unused fields, and everything seemed to work fine. It will break now.17:06
rloolucasagomes: but yeah, i was wondering if it will break our users (like dtantsur sez)17:06
lucasagomesdtantsur, nonexistent17:06
rloook rameshg87, about the validation of the target raid config.17:06
rameshg87rloo: so my concern was we cannot call common.raid.validate_configuration() directly because drivers can define new schemas17:07
lucasagomesdtantsur, rloo we will need to pin the WSME version then... but it's a legitimate bug in wsme that got fixed17:07
rameshg87rloo: so it would be odd if we raise some errors while accepting target_raid_config17:07
lucasagomesbefore it was error because if you do a POST {'driver': 'fake', 'foo': 'bar'} it would return 201 (Created)17:07
lucasagomeswhich is wrong because the field "foo" does not exist17:07
rameshg87rloo: and some other when we call the actual task.driver.raid.validate() - the actual driver's method which validates their custom raid schema17:08
rloorameshg87: what's the use of having common.raid.validate_configuration() if drivers can define new schemas?17:08
rameshg87rloo: it's a base implementation which we have accepted to be a norm17:08
*** e0ne has joined #openstack-ironic17:08
rameshg87rloo: in the spec we have iterated most of the people's points and captured as the default ironic would wish for17:08
dtantsurdevananda, I know you like talking about API compatibility :-P so we have some good discussion here ^^17:09
rameshg87rloo: but still open to accepting newer properties from drivers if they wish to add new17:09
dtantsurdevananda, tl;dr new wsme release starts to give an error on unexpected API fields17:09
rloorameshg87: in your opinion, is the raid.validate() meant to only validate the actual config?17:09
rameshg87rloo: may not be. if someone does raid configuration out of band, they might validate if they have the credentials of the bmc which does raid configuration. right ?17:10
rloorameshg87: right, that's what i was wondering.17:10
rloorameshg87: so maybe we need another method in the raid interface to only verify the config?17:10
rloorameshg87: IF we want to do any verification when the user submits the target raid config.17:11
rameshg87rloo: that's one option. validate() of the driver could call that method to do the verification of the config17:11
rameshg87rloo: another alternative is by type of exception.17:12
rameshg87rloo: how about if we define an exception class InvalidRaidConfig(InvalidParameterValue)17:12
rloorameshg87: you mean, call validate() and based on the exception returned?17:12
rloorameshg87: I don't like that. it is sort of a side effect of calling validate.17:12
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Update tests to reflect WSME 0.8 fixes  https://review.openstack.org/21680217:12
devanandadtantsur: reading scrollback ....17:13
rloorameshg87: if we think the drivers should all explicitly validate the config, we should have a method for that.17:13
rameshg87rloo: hmm..yeah then probably we will need to have a method defined in the RAIDInterface17:13
rameshg87rloo: and the base implementation of validate() should just call validate_raid_config()17:14
*** mestery has quit IRC17:14
rloorameshg87: yes, i think that is cleaner, more explicit.17:14
rameshg87rloo: and drivers are free to override and implement both validate() and validate_raid_config()17:14
rloorameshg87: yup.17:14
devanandaoh, awesome17:15
*** achanda has joined #openstack-ironic17:15
rameshg87rloo: okay, makes sense17:15
rameshg87rloo: let me propose an update to the spec17:15
rloorameshg87: thx. I am fine if you remove the validate part from that patch, and we approve it so you aren't blocked. (as long as others are fine too.)17:16
rameshg87rloo: and add the call to validate_interfaces part later on17:17
rameshg87rloo: but I don't want the API patch to be merged anyway, otherwise we might have different behaviours.17:17
rloorameshg87: oh, good point.17:17
rameshg87jroll: mind +2ing the patch now - https://review.openstack.org/#/c/215431/ :)17:18
lucasagomesdevananda, the fix for WSME 0.8 is this one https://review.openstack.org/21680217:18
rameshg87jroll: because I have another update to that spec coming up shortly :)17:18
lucasagomesdevananda, IMHO it's a legitimate bug in WSME that has been fixed17:19
rameshg87oh jroll is on vacation17:19
lucasagomesbut yeah, as dtantsur pointed out it may break users which are creating resources with nonexistent fields17:19
rameshg87devananda or lucasagomes, can someone please have a look at a spec update https://review.openstack.org/#/c/215431/17:19
lucasagomesrameshg87, :-( can I take a look at it tomorrow?17:19
openstackgerritDevananda van der Veen proposed openstack/ironic: add links for UEFI secure boot support to iLO driver documentation  https://review.openstack.org/21652817:19
rameshg87lucasagomes: sure no problem17:20
*** Nisha_away has joined #openstack-ironic17:20
rloorameshg87: or just modify that spec update to include the new method17:20
lucasagomesrameshg87, thank17:20
lucasagomesthanks17:20
*** r3mu5 has joined #openstack-ironic17:21
rameshg87rloo: eh, anyway 2 different things - hard to explain and hard to get for others17:21
rameshg87rloo: I would rather opt for a separate patch17:21
rloorameshg87: true. also hard to get people to review :)17:21
devanandalucasagomes: confirmed - your fix fixes the issues I was seeing this morning17:22
lucasagomesdevananda, cool, yeah I think it would be better to merge it before we actually get the gate broken17:22
*** absubram has joined #openstack-ironic17:22
lucasagomesit's not yet because the mirror wasn't updated17:22
devanandayep17:22
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: [WIP] Add introspection rules support  https://review.openstack.org/20837517:23
*** mestery has joined #openstack-ironic17:23
devanandaany other cores want to review lucas' patch real quick?17:24
NobodyCamI can look but do not have env to test atm....17:24
NobodyCamdevananda: ahh I see you comment :)17:24
rloodevananda: done17:24
* lucasagomes is trying to give a heads up to others projects using wsme17:25
*** davideagnello has joined #openstack-ironic17:25
NobodyCamrloo: lol your quick :) hehehe17:25
rlooNobodyCam: I had already looked at it!17:26
rlooNobodyCam: I meant to say, yeah, I'm super quick ;)17:26
*** trown is now known as trown|lunch17:27
*** thiagop has left #openstack-ironic17:27
*** thiagop has joined #openstack-ironic17:27
lucasagomesthanks folks17:28
lucasagomescdent will put an email to the ML alerting other projects about WSME 0.817:28
*** Nisha_away has quit IRC17:28
*** Nisha_away has joined #openstack-ironic17:28
dtantsursee you all tomorrow17:29
*** dtantsur is now known as dtantsur|afk17:29
lucasagomesdtantsur, g'night17:29
*** meghal has quit IRC17:30
*** meghal has joined #openstack-ironic17:30
openstackgerritSHIGEMATSU Mitsuhiro proposed openstack/bifrost: Generate network_info json using a module  https://review.openstack.org/21637217:30
thiagopgood night dtantsur|afk17:30
jlvillaldtantsur|afk: Ciao17:30
*** Nisha_away is now known as Nisha_17:34
NobodyCamnight dtantsur|afk17:34
*** meghal has quit IRC17:35
openstackgerritRamakrishnan G proposed openstack/ironic-specs: Add a new method validate_raid_config to RAIDInterface  https://review.openstack.org/21680917:35
rameshg87rloo: ^^^ when you got some time17:35
*** meghal has joined #openstack-ironic17:35
openstackgerritRamakrishnan G proposed openstack/ironic: Refactor agent driver with pxe boot interface  https://review.openstack.org/16652117:41
rloorameshg87: will look in a few minutes. thx!17:46
rameshg87rloo: thanks17:46
*** romcheg has quit IRC17:46
* rameshg87 leaves for the day17:46
*** rameshg87 has quit IRC17:46
lucasagomesI will call it a day too17:47
lucasagomesfolks have a great night!17:47
*** lucasagomes is now known as lucas-dinner17:47
thiagopgood night lucas-dinner17:47
NobodyCamhave a good nught lucas-dinner17:47
NobodyCamnight even :-p17:47
thiagopand ramesh too (though he's out before I can wish it)17:48
openstackgerritJohn L. Villalovos proposed openstack/ironic-python-agent: Add some comparison operators to Serializable class  https://review.openstack.org/21585418:01
*** marzif has quit IRC18:11
sambettsAlso calling it a night o/ see you all tomorrow18:12
thiagopnight sambetts18:12
*** rloo_ has joined #openstack-ironic18:15
NobodyCamnight sambetts18:16
*** rloo has quit IRC18:17
*** meghal has quit IRC18:17
*** tab has joined #openstack-ironic18:20
*** tab is now known as Guest5594618:20
*** Guest55946 has quit IRC18:20
*** jlk has joined #openstack-ironic18:21
*** tab___ has joined #openstack-ironic18:21
*** cdearborn has joined #openstack-ironic18:23
*** trown|lunch is now known as trown18:26
openstackgerritJohn L. Villalovos proposed openstack/ironic: Remove the ironic.config.sample file  https://review.openstack.org/21682918:27
rloo_jlvillal: wrt the .sample. seems like it comes up again and again. i like having it and we decided awhile ago to keep it.18:29
jlvillalrloo_: Oh, I didn't know that. I noticed that sometimes it gets updated and sometimes it doesn't18:30
jlvillalrloo_: So I liked what Nova did :)18:30
*** puranamr has joined #openstack-ironic18:30
rloo_jlvillal: it used to be gated and would get out of sync if some other package was updated. nova got frustrated and got rid of it. but we decided to not gate on it but still have it.18:30
rloo_jlvillal: i don't like what nova did, cuz now, if i want to generate nova's .sample, it takes time to do.18:31
rloo_jlvillal: you can't generate it w/o a dev environment. i don't think. i'm not sure, but i think some operators weren't happy about that.18:31
jlvillalrloo_: Okay. Thanks for the info. I had mentioned this idea on IRC a week or so ago. But nothing but crickets ;)18:32
*** mtanino_ has joined #openstack-ironic18:32
jlvillalSo I went for it!18:32
*** meghal has joined #openstack-ironic18:32
rloo_jlvillal: now i'm wondering how to document this for folks to know. since that .sample is generated i don't see how we can add a comment there.18:32
jlvillalrloo_: Maybe update the 'genconfig' job to add something at the top of the file after it is generated?18:33
thiagopthere isn't a command on tox to generate the nova.conf.sample?18:33
thiagop"tox -e genconfig"18:34
rloo_would it be enough to add a comment in the tox.ini file?18:34
*** mtanino has quit IRC18:34
jlvillalthiagop: There is a command.  You just said it :)18:35
thiagopjust nuts-checking myself18:35
jlvillalrloo_: I can see people never looking at tox.ini18:35
jlvillalIf they are looking at the config file18:36
rloo_jlvillal: how do folks know that the config is out of date then? I mean, why did you think of getting rid of it?18:37
*** rloo_ is now known as rloo18:38
jlvillalrloo: Well I knew because I did a 'tox -e genconfig' and then there was a diff18:38
rloojlvillal: the problem with adding a comment to the top of the .sample is that folks may not even read that.18:38
*** romcheg has joined #openstack-ironic18:38
jlvillalAnd if some oslo package makes changes, it can make the config out of date.18:39
rloojlvillal: how did you know to do a tox -e genconfig? you didn't look in tox.ini?18:39
rloojlvillal: do we have doc somewhere for generating the config?18:39
jlvillalrloo: I did yes.  But I'm saying someone who is looking at the config file as an example will have no idea.18:39
rloojlvillal: no idea that it might be out of sync?18:39
jlvillalrloo: Yes18:39
rloojlvillal: I'm only concerned with folks who want to delete the .sample.18:39
jlvillalrloo: And also, no idea on how to regenerate it.18:40
rloojlvillal: I mean, I don't want others to submit a patch to delete the .sample.18:40
jlvillalrloo: You lost me there.  Folks like me who proposed a patch to delete .sample?18:40
jlvillalAh :)18:40
rloojlvillal: if someone notices the .sample is out of sync, they can ask and hopefully someone on irc or mailing list can answer.18:40
rloojlvillal: yeah, cuz you said you didn't know that we wanted to keep it.18:41
jlvillalrloo: Maybe add a README file?  Like my patch does.18:41
jlvillalBut don't delete the sample18:41
jlvillalI could change my patch to do that.18:41
rloojlvillal: i don't want another README file.18:41
rloojlvillal: forget all that ^^. I'm going to move on to something else.18:42
jlvillalrloo: Works for me. Thanks. I'll just abandon my patch.18:43
*** Sukhdev has joined #openstack-ironic18:43
thiagop¯\_(ツ)_/¯18:44
* jlvillal now knows that means shrug :)18:45
devanandaoh hey, http://docs.openstack.org/developer/ironic/deploy/install-guide.html?highlight=enroll#enrollment does not mention the new default ENROLL state :(18:46
devanandadtantsur|afk: ^18:46
thiagopdevananda: I think there is a patch from NobodyCam to update that18:47
devanandaalso, there's no good writeup of the new workflow for me to link to in the release notes.18:47
devanandaoh?18:47
*** puranamr has quit IRC18:47
thiagopdevananda: #link https://review.openstack.org/#/c/209251/18:48
rloodevananda: ask and you shall receive...18:48
jlvillalIs our gate broken again?18:49
jlvillal:(18:49
rloojlvillal: ?18:49
jlvillalI just noticed a lot of jobs failed the check...18:49
rloojlvillal: unless the wsme got in before lucas' patch18:49
rloojlvillal: example?18:49
jlvillalrloo: https://review.openstack.org/#/c/216758/18:50
jlvillalrloo: I think it could be wsme18:50
thiagopI got some of that on my local tox too18:50
devanandaurhhh18:51
devanandayea, oslo rleease18:51
rloojlvillal: it is the wsme thing18:51
devanandanope18:51
devanandanow it's oslo.config and oslo.i18n18:51
thiagopUnknown attributes for argument node: chassis_id, target_raid_config, raid_config18:51
rloothiagop: that's the wsme thing18:51
devanandaoh never mind. I'm in the wrong venv18:51
rloothis is when we wish there was a a VIP queue for patches.18:52
jlvillalrloo: Okay. lucas-dinner patch is in the check queue and is queued not running yet. So we got some time before the gate will get fixed ....18:52
jlvillalrloo: +118:52
*** marzif has joined #openstack-ironic18:52
* thiagop grabs coffee to wait18:53
jlvillalrloo: And current gate queue is at 5+ hours...18:53
openstackgerritLilia Sampaio proposed openstack/ironic: OneView Driver for Ironic  https://review.openstack.org/19182218:53
rloojlvillal: can we just kill a bunch of patches cuz we know they will fail?18:53
rloojlvillal: i mean, take them out of the gate queue18:54
jlvillalrloo: I have no idea how to do that :(  And for sure I don't have the power.18:55
openstackgerritMerged openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/21656318:55
rloojlvillal: ha ha.18:55
* jlvillal thinks now is a good time for lunch...18:55
*** mtanino has joined #openstack-ironic18:58
thiagopjlvillal rloo you should be able to remove your own patches when you see a gate failing..18:59
thiagopthat would be useful...18:59
devanandarloo: upload a new revision to gerrit19:00
devanandarloo: even just a whitespace edit in the commit message should do it19:00
rloodevananda: won't that just cause the cycle to start over again?19:00
*** mtanino_ has quit IRC19:01
devanandano - it'll require another +A19:01
devanandaso it will go into the check queue, but not the gate queue19:01
thiagopalso, WIP shouldn't run tests19:01
thiagopor run in low priority at least19:01
devanandathiagop: anything you post to gerrit will always run tests19:01
rloodevananda: oh yeah. and have everyone kill me cuz they lost their +A.19:01
devanandarloo: :)19:01
*** Nisha_ has quit IRC19:01
rlooi dare you to do it devananda ;)19:02
*** Nisha has joined #openstack-ironic19:02
* rloo isn't in a hurry19:02
*** jlk has left #openstack-ironic19:07
openstackgerritDevananda van der Veen proposed openstack/ironic: Add release notes for 4.0.0  https://review.openstack.org/21684319:09
JayFSo 4.0.0 is released?19:09
JayFif so I'll let jroll know, he'll be excited - vacation or not19:09
NobodyCammorning JayF :)19:10
devanandatechnically the bits are already cut, but there are things being ironied out19:10
jlvillalrloo: devananda: lucas-dinner: NobodyCam: Updated the whiteboard about the gate being broken.19:10
devanandalike the fact the release didn' thave any release notes19:10
devanandajlvillal: ty19:10
*** yog_ has quit IRC19:11
devanandaJayF, rloo, NobodyCam, others ... do not land that release notes patch yet. dhellmann is working on some tooling to do it "right" (I dont know details yet) so he will be taking over that patch and/or working with ya'll to update it soon19:11
* JayF can't land it anyway :)19:11
devanandaer, I meant jroll ^ :L(19:11
rloodevananda: you want us to review but not land, or not review too?19:11
devananda:)19:11
devanandarloo: feel free to review - your eye to detail may spot things I didn't include19:12
devanandaalso this shouldn't include everyu little detail -- just the big things19:12
devanandawhich i htink i got :)19:12
*** thiagop has left #openstack-ironic19:14
*** thiagop has joined #openstack-ironic19:14
rloodevananda: our previous release notes had 'known issues' and 'upgrade notes'. this one just has the key features. is that ok?19:14
devanandarloo: we should probably do some of that too19:14
devanandahowever19:14
devanandathis isn't the liberty final release19:15
devanandathe biggest thing is: hey look, semver versioning!19:15
devanandabut then there are also all the other htings we did. and some that we haphazardly landed half-done so far19:15
devanandawhich we should finish up before Liberty, and then drop, say, 4.1.019:15
devanandaassuming no more incompatible changes (cause omg please no)19:15
rloodevananda: life would be so boring w/o incompatible changes19:16
rloodevananda: don't worry, we'll wait til you're back from vacation to mention the rest ;)19:17
devanandaI've added a section to the whiteboard with a few links and notes. I'm also super late for doing things I need to do before vacation now ... so I gotta run ...19:18
NobodyCamenjoy the running devananda :)19:18
devanandalol19:18
NobodyCam:)19:18
*** achanda has quit IRC19:28
*** pelix has quit IRC19:32
*** davideagnello has quit IRC19:36
*** davideagnello has joined #openstack-ironic19:36
*** jjohnson2 has quit IRC19:37
*** davideagnello has quit IRC19:37
*** mgoddard has quit IRC19:37
*** pelix has joined #openstack-ironic19:39
*** dims has joined #openstack-ironic19:43
openstackgerritNisha Agarwal proposed openstack/ironic: Remove the hard dependency of swift from ilo drivers  https://review.openstack.org/19865619:44
*** marzif_ has joined #openstack-ironic19:44
*** pelix has quit IRC19:46
*** marzif has quit IRC19:46
*** ionutbalutoiu has quit IRC19:51
*** ionutbalutoiu has joined #openstack-ironic19:52
*** ionutbalutoiu has quit IRC20:01
*** achanda has joined #openstack-ironic20:11
*** puranamr has joined #openstack-ironic20:22
*** jjohnson2 has joined #openstack-ironic20:30
*** e0ne has quit IRC20:35
*** Nisha has quit IRC20:39
*** Sukhdev has quit IRC20:43
openstackgerritJohn Trowbridge proposed openstack/ironic-inspector: Store and expose introspection data  https://review.openstack.org/21315920:46
thiagopfolks, I'm calling it a day20:58
thiagopsee you tomorrow20:59
*** thiagop has quit IRC20:59
*** bnemec has quit IRC21:05
*** bnemec has joined #openstack-ironic21:06
*** meghal has quit IRC21:07
*** meghal has joined #openstack-ironic21:07
*** tab___ has quit IRC21:08
*** jjohnson2 has quit IRC21:11
*** achanda has quit IRC21:15
*** trown is now known as trown|outttypeww21:15
openstackgerritJohn L. Villalovos proposed openstack/ironic: Stop providing 'message' property in IronicException  https://review.openstack.org/21536221:16
*** meghal has quit IRC21:16
*** achanda has joined #openstack-ironic21:17
*** dprince has quit IRC21:19
*** meghal has joined #openstack-ironic21:31
*** linggao has quit IRC21:34
*** davideagnello has joined #openstack-ironic21:37
*** davideagnello has quit IRC21:43
*** davideagnello has joined #openstack-ironic21:44
mrdaMorning Ironic21:45
NobodyCamgood morning mrda21:45
mrdahey NobodyCam21:45
NobodyCam:)21:45
*** e0ne has joined #openstack-ironic21:48
*** meghal has quit IRC21:49
openstackgerritJulia Kreger proposed openstack/bifrost: WIP: Ansible 2.0 compatibility **DO NOT MERGE**  https://review.openstack.org/19683221:51
*** natorious is now known as zz_natorious21:52
TheJuliaYeah, ansible 2.0 is not my friend21:53
*** meghal has joined #openstack-ironic21:54
*** meghal has quit IRC21:58
*** meghal has joined #openstack-ironic21:58
rloohey, morning mrda.22:01
mrdahey rloo22:01
rloomrda, i was looking over some of the nova-ironic bugs. Wondering what the status was for https://bugs.launchpad.net/nova/+bug/145987422:01
openstackLaunchpad bug 1459874 in OpenStack Compute (nova) "Ironic driver needs microversion support" [Low,In progress] - Assigned to Michael Davies (mrda)22:01
rloomrda: would be nice to get it into liberty. i dunno, we don't seem to have needed it but it worries me not to have it there, just in case.22:03
mrdarloo: I haven't done much on this yet (since thinking about it and raising it)22:03
mrdarloo: I agree. But given feature freeze, I don't think it'll make it. I think a better bet is easy Muppet22:03
mrdas/easy/early/22:04
rloomrda: guess they might consider it a feature. and it is low priority. oh well.22:04
JayFI just tossed a second +2 on this, anyone wanna take a look before I land it? https://review.openstack.org/#/c/215061 (IPA)22:04
mrdarloo: I'll push up something soon22:05
rloomrda: no worries. if we don't think it'll get into liberty, we can wait til M.22:06
rloomrda: I want to make sure that anything we really want in liberty/nova, we do/review soon.22:06
*** bnemec has quit IRC22:07
mrdarloo: thanks, I agree22:07
*** bnemec has joined #openstack-ironic22:09
rlooJayF: I looked. Left the +A honor for you :)22:09
JayFheh, you can feel free to +A22:09
JayFI don't get as much time to review nowadays so feels strange to approve things22:09
JayFalthough trying to get back into a cadence of doing some reviews, even if I don't have a bulk of time22:09
rloowelcome back JayF ;) Anyway, that's why I left the honour for you, since you so rarely do it!22:10
JayFhah22:10
JayFwell I was gone for 6 weeks, and I got manager'd back in May22:10
*** zz_natorious is now known as natorious22:10
JayFnow that I know somewhat what I'm doing hopefully I can stop being missing entirely from upstream :)22:10
NobodyCamJayF: it is nice to have you back in channel again though :)22:11
rlooJayF: there are a lot of specs that want your eyeballs...22:11
JayFI'm starting out with IPA stuff and working my way up :)22:11
JayFdon't wanna get too deep into any specs until I'm certain I can see them to the end22:11
jlvillalJayF: JoshNang mariojv : Any objections to making the IPA python34 tests voting?  gate-ironic-python-agent-python3422:14
JoshNangjlvillal: has it been stable?22:15
mariojvjlvillal: i've never actually been able to run those locally22:15
JayFI don't have enough recent context to object :)22:15
jlvillalLooking at some patches, it seems like it is passing.  It did catch an error on my patch :)22:15
*** absubram has quit IRC22:15
mariojvjlvillal: if it's stable when running at the gate, i'd vote yes. i think the errors i was seeing are just a problem with my local environment22:16
JoshNangyeah, same, i've had some bug locally where it "can't determine db type" and quits22:16
*** e0ne has quit IRC22:16
JoshNangbut ++ gate seems to be fine22:16
jlvillalJoshNang: I do rm .testrepository and then it works.22:17
jlvillalFor a while...22:17
JoshNangi've done that and got one run out of it..22:17
mariojvJoshNang: that's the same error i see22:17
jlvillalJoshNang: mariojv JayF: I'll see if I can do a patch to move it to voting.  Unless someone else wants to do it :)22:17
jlvillalmariojv: Do rm -rf .testrepository/22:18
mariojvjlvillal: that doesn't seem to help22:18
jlvillalmariojv: and it should work.22:18
jlvillalReally?22:18
mariojvyeah, i just tried it22:18
jlvillalIn the top directory22:18
mrda+1 rm the testr stuff and start over and the db error disappears22:18
* jlvillal goes to find his old patches related to gate voting 22:19
*** achanda has quit IRC22:19
SpamapSTheJulia: interesting thing I just ran into w/ Bifrost22:20
*** r3mu5 has left #openstack-ironic22:20
SpamapSTheJulia: my deploy network is 10.10.16.128/2622:20
NobodyCamoh do we hardcode a /24?22:20
NobodyCamheya SpamapS22:21
*** achanda has joined #openstack-ironic22:21
mariojvyeah, tried switching over to a regular master branch and rm'ing .testrepository, rm'ing .tox, 3.4 tests still fail with the db error22:23
jlvillalmariojv: :(22:24
JayFI'm going to try it22:24
jlvillalJoshNang: Does IPA have any releases?  stable? kilo?  etc... ?22:24
JayFjlvillal: we have never cut a release, and we've never made an incompatible change22:24
jlvillalJayF: Wonderful :)22:25
JayFjlvillal: whether or not that's the "right thing" has been an issue of some debate, but nobody has cared enough to do the legwork or push hard for it22:25
JoshNangjlvillal: there's a patch somewhere to tag releases22:25
jlvillalJayF: JoshNang: Just wondering if I needed to exclude the check from old releases.  Sounds like the answer is no.22:25
*** cdearborn has quit IRC22:26
TheJuliaSpamapS: I thought I made that configurable... but sounds like an issue :(22:26
SpamapSTheJulia: it is configurable22:27
SpamapSTheJulia: However, the code assumes deploying ipv4_subnet_mask == end network subnet mask.22:27
SpamapSTheJulia: my end network is a /2422:27
jlvillalJoshNang: JayF mariojv: https://review.openstack.org/#/c/216886/22:28
SpamapSTheJulia: also my gateway is different.22:28
SpamapSTheJulia: so we need a deploy_ipv4_* and an active_ipv4_*22:29
SpamapSNobodyCam: howdy22:29
TheJuliaSpamapS: That kind of makes sense22:31
SpamapSTheJulia: it's all caused by this weird vlan stuff22:32
SpamapSbeen fighting this network for 2 and a half years.22:32
SpamapSSo wish we could just have transit and a router and they'd let us do whatever we want.22:32
TheJuliayah22:33
TheJuliaSo what do you need from me in the short term to be successful?22:33
SpamapSTheJulia: oh, I think just reviews22:33
SpamapSTheJulia: working on patches already. :)22:33
TheJuliaawesome!22:33
SpamapSwill just split the current unqualified ipv4_* into two22:33
TheJulia10-422:34
SpamapSI COULD also just bring things up on 10.10.16.128/26 .. and layer the vlan25 stuff on later22:34
*** lucas-dinner has quit IRC22:34
SpamapSThat may actually be the shorter path22:35
SpamapSbut I'll try and get my patches done anyway22:36
NobodyCamSpamapS: TY :)22:36
jlvillalmariojv: As a note, I do not need to remove .testrepository after each run.  I did it once.  I may have done it more than once. But not each run.22:38
mariojvoh, ok22:38
jlvillalmariojv: I'm using Fedora 2222:39
jlvillalmariojv: Testing on my Ubuntu 14.04 system now......22:39
mariojvjlvillal: i'm on ubuntu 14.0422:40
*** puranamr has quit IRC22:41
*** puranamr has joined #openstack-ironic22:41
jlvillalmariojv: Works for me on Ubuntu 14.04 also.22:41
mariojvweird22:41
jlvillalmariojv: :(22:42
mariojvjlvillal: i'll try it out on a fresh vm, fresh clone later and see what happens22:44
jlvillalmariojv: Good luck22:44
mariojvit may well be something strange happening on my local setup22:44
mariojvjlvillal: do you know why removing .testrepository fixes the issue?22:45
*** Sukhdev has joined #openstack-ironic22:45
jlvillalmariojv: I'm guessing that is a database inside that directory.22:45
jlvillalmariojv: $ ls ~/openstack/ironic-python-agent/.testrepository/22:46
jlvillal0  1  2  failing  format  next-stream  times.dbm22:46
jlvillalProbably 'times.dbm'22:46
mariojvjlvillal: i think you're right22:48
mariojvjlvillal: https://ask.openstack.org/en/question/5310/db-type-could-not-be-determined/22:48
mariojvi was able to remove that file, then just run 3.4 tests, then run 2.7 tests, in that order22:48
jlvillalmariojv: Thanks for the link :)22:49
JayFpy34 tests won't pass locally for me, even though they will run22:49
JayFhah22:49
jlvillalmariojv: Great, you got it to work.  I was doing 'tox -v -v -epy34'22:49
jlvillalSo not doing py2722:49
jlvillalMaybe lifeless will fix the issue soon :)22:50
lifelesshmm ?22:50
lifelesswhats up ?22:50
mariojvlifeless: talking about bug https://bugs.launchpad.net/testrepository/+bug/1229445, we just ran into it22:51
openstackLaunchpad bug 1212909 in Testrepository "duplicate for #1229445 times.dbm incompatible based on Python version it was created with" [Critical,Triaged]22:51
lifelessoh - the testr thing. so I don't think the bug will get fixed directly22:51
lifelessinstead I'm pushing ahead on making it possible to put testr outside of tox22:51
lifelessrather than inside22:51
mrdalifeless: do you know why it gets occasionally tickled?22:51
lifelessI have a prototype working now that tests testr itself in 9 different python versions22:51
lifelessmrda: tox22:51
lifelessmrda: I dove down into it in the thread about this on the list a while back22:52
mrdaso it's a refresh of tox that causes this issue?22:52
mrdaok22:52
lifelessmrda: if a brief google doesn't find that for you, let me know22:52
lifelessmrda: different python versions have different db formats they support22:52
mrdaI'm assuming it's related to a library refresh or something that makes it suddenly appear22:52
mrdathanks22:52
lifelesstimes.dbm is shared across different python versions because the 'testr' that is being run is being installed inside the virtualenv22:52
mrda:)22:53
lifelessthe solution is to a) install testr globally and b) don't install it inside the venv22:53
mrdaright22:53
*** asd112z has quit IRC22:59
*** shoutm has joined #openstack-ironic23:01
openstackgerritMerged openstack/ironic-python-agent: Allow passing node UUID to lookup  https://review.openstack.org/21506123:02
*** davideagnello has quit IRC23:24
*** bitblt has joined #openstack-ironic23:28
*** bitblt has quit IRC23:28
*** marzif_ has quit IRC23:29
*** davideagnello has joined #openstack-ironic23:31
openstackgerritJulia Kreger proposed openstack/bifrost: Cleanup role meta definitions  https://review.openstack.org/21690523:42
openstackgerritJulia Kreger proposed openstack/bifrost: WIP: Ansible 2.0 compatibility **DO NOT MERGE**  https://review.openstack.org/19683223:46

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!