| *** logan2 has quit IRC | 00:01 | |
| *** naohirot has joined #openstack-ironic | 00:01 | |
| *** amotoki has joined #openstack-ironic | 00:03 | |
| *** logan2 has joined #openstack-ironic | 00:08 | |
| *** achanda has quit IRC | 00:12 | |
| *** jcoufal has quit IRC | 00:22 | |
| *** smoriya has joined #openstack-ironic | 00:36 | |
| *** Marga_ has joined #openstack-ironic | 00:44 | |
| *** Marga_ has quit IRC | 00:49 | |
| *** zhenguo has joined #openstack-ironic | 00:49 | |
| *** openstackgerrit has quit IRC | 00:51 | |
| *** openstackgerrit has joined #openstack-ironic | 00:52 | |
| *** gabriel-bezerra has quit IRC | 01:09 | |
| *** achanda has joined #openstack-ironic | 01:12 | |
| *** achanda has quit IRC | 01:18 | |
| *** natorious is now known as zz_natorious | 01:20 | |
| *** Marga_ has joined #openstack-ironic | 01:45 | |
| *** Marga_ has quit IRC | 01:49 | |
| *** kan__ has joined #openstack-ironic | 01:55 | |
| *** DCWilliams_VA has joined #openstack-ironic | 02:08 | |
| *** DCWilliams_VA has quit IRC | 02:08 | |
| *** Marga_ has joined #openstack-ironic | 02:42 | |
| *** Marga_ has quit IRC | 02:47 | |
| *** bnemec has quit IRC | 03:08 | |
| *** bnemec has joined #openstack-ironic | 03:10 | |
| *** kevinbenton has quit IRC | 03:35 | |
| *** qiaoerfu has joined #openstack-ironic | 03:37 | |
| *** Marga_ has joined #openstack-ironic | 03:43 | |
| *** Marga_ has quit IRC | 03:48 | |
| *** achanda has joined #openstack-ironic | 03:48 | |
| *** coolsvap|away is now known as coolsvap | 03:50 | |
| openstackgerrit | Satoru Moriya proposed openstack/ironic: [WIP] Add volume connection information to node table https://review.openstack.org/200983 | 04:02 |
|---|---|---|
| *** achanda has quit IRC | 04:07 | |
| *** puranamr has joined #openstack-ironic | 04:13 | |
| *** kevinbenton has joined #openstack-ironic | 04:14 | |
| *** lazy_prince has joined #openstack-ironic | 04:16 | |
| *** Nisha has joined #openstack-ironic | 04:19 | |
| *** Marga_ has joined #openstack-ironic | 04:25 | |
| *** puranamr has quit IRC | 04:27 | |
| *** saripurigopi has joined #openstack-ironic | 04:29 | |
| *** Marga_ has quit IRC | 04:30 | |
| *** saripurigopi has quit IRC | 04:33 | |
| *** bnemec has quit IRC | 04:36 | |
| *** saripurigopi has joined #openstack-ironic | 04:43 | |
| *** kevinbenton has quit IRC | 04:53 | |
| *** amotoki_ has joined #openstack-ironic | 04:53 | |
| *** Nisha_away has joined #openstack-ironic | 04:57 | |
| *** Nisha has quit IRC | 04:57 | |
| *** kevinbenton has joined #openstack-ironic | 04:59 | |
| *** achanda has joined #openstack-ironic | 05:01 | |
| *** pcaruana has quit IRC | 05:08 | |
| *** rameshg87 has joined #openstack-ironic | 05:13 | |
| *** krtaylor has quit IRC | 05:24 | |
| *** smoriya has quit IRC | 05:25 | |
| *** Marga_ has joined #openstack-ironic | 05:26 | |
| *** Marga_ has quit IRC | 05:31 | |
| *** Marga_ has joined #openstack-ironic | 05:31 | |
| *** Marga_ has quit IRC | 05:32 | |
| *** Marga_ has joined #openstack-ironic | 05:32 | |
| *** krtaylor has joined #openstack-ironic | 05:37 | |
| *** amotoki_ has quit IRC | 05:39 | |
| *** ukalifon1 has joined #openstack-ironic | 05:43 | |
| *** qiaoerfu has quit IRC | 05:49 | |
| *** qiaoerfu has joined #openstack-ironic | 05:49 | |
| *** saripurigopi has quit IRC | 05:52 | |
| *** saripurigopi has joined #openstack-ironic | 05:56 | |
| *** Kennan has joined #openstack-ironic | 06:03 | |
| *** Kennan2 has quit IRC | 06:03 | |
| *** Haomeng has quit IRC | 06:06 | |
| *** Pradvara has joined #openstack-ironic | 06:06 | |
| *** Marga_ has quit IRC | 06:10 | |
| Pradvara | When i am trying to bring up an instance throughbaremetal, an ip is assigned to the baremetal and instance is going to spawing state. During booting it is failing with error" TFTP Prefix: Unable to locate configuration file" | 06:10 |
| Pradvara | can anyone help on this | 06:11 |
| *** Haomeng has joined #openstack-ironic | 06:13 | |
| *** rwsu has joined #openstack-ironic | 06:14 | |
| *** Marga_ has joined #openstack-ironic | 06:15 | |
| *** rwsu has quit IRC | 06:16 | |
| *** puranamr has joined #openstack-ironic | 06:17 | |
| Pradvara | When i am trying to bring up an instance throughbaremetal, an ip is assigned to the baremetal and instance is going to spawing state. During booting it is failing with error" TFTP Prefix: Unable to locate configuration file" | 06:21 |
| Haomeng | Pradvara: did you run devstack to deploy the openstack env? | 06:23 |
| Pradvara | yes | 06:23 |
| Haomeng | Pradvara: so what OS you are runing, ubuntu? | 06:23 |
| Pradvara | yes, Ubuntu | 06:24 |
| Haomeng | Pradvara: there is tftp map that is required | 06:24 |
| Haomeng | Pradvara: but it will be auto-configured by devstack scripts | 06:24 |
| Pradvara | what would be the map location | 06:27 |
| Haomeng | Pradvara: can you check the dnsmasq process to see if neutron helped to prepare the baremeatl mac and dhcp options | 06:27 |
| Haomeng | Pradvara: run "ps -ef|grep dnsmasq" | 06:27 |
| Pradvara | stack@i-cont:~/devstack$ ps -ef|grep dnsmasq nobody 17756 1 0 Jul09 ? 00:00:05 dnsmasq --no-hosts --no-resolv --strict-order --bind-interfaces --interface=tapd68fddd4-7c --except-interface=lo --pid-file=/opt/stack/data/neutron/dhcp/5c7ee850-114f-475d-8e08-51a6b682e7ee/pid --dhcp-hostsfile=/opt/stack/data/neutron/dhcp/5c7ee850-114f-475d-8e08-51a6b682e7ee/host --addn-hosts=/opt/stack/data/neutron/dhcp/5c7ee850 | 06:29 |
| Haomeng | Pradvara: can show the content of --dhcp-optsfile, which should has your baremetal mac | 06:31 |
| *** puranamr has quit IRC | 06:32 | |
| Haomeng | Pradvara: sorry, should be --dhcp-hostsfile options file content | 06:32 |
| *** stendulker has joined #openstack-ironic | 06:35 | |
| Pradvara | stack@i-cont:/opt/stack$ more /opt/stack/data/neutron/dhcp/5c7ee850-114f-475d-8e08-51a6b682e7ee/host fa:16:3e:61:0c:a8,host-10-106-240-209.openstacklocal,10.106.240.209 stack@i-cont:/opt/stack$ | 06:37 |
| *** max_lobur has joined #openstack-ironic | 06:40 | |
| Haomeng | Pradvara: I think fa:16:3e:61:0c:a8 is your baremetal mac, and can you check if there is same mac name folder in this patch - /opt/stack/data/ironic/tftpboot/pxelinux.cfg/ which is used by tftp to get configurations | 06:41 |
| Pradvara | stack@i-cont:/opt/stack$ ironic port-list +--------------------------------------+-------------------+ | UUID | Address | +--------------------------------------+-------------------+ | f704390d-9659-4068-b8be-0e5db1b4013e | 00:25:b5:00:10:07 | +--------------------------------------+-------------------+ | 06:41 |
| *** pcaruana has joined #openstack-ironic | 06:42 | |
| *** amotoki_ has joined #openstack-ironic | 06:43 | |
| Haomeng | Pradvara: and can you check /var/log/syslog to grep tftp to see if we can find something | 06:46 |
| Pradvara | Jul 13 10:10:37 i-cont in.tftpd[21844]: tftp: client does not accept options Jul 13 10:17:12 i-cont in.tftpd[24445]: tftp: client does not accept options Jul 13 10:23:48 i-cont in.tftpd[26924]: tftp: client does not accept options Jul 13 10:29:26 i-cont in.tftpd[29113]: tftp: client does not accept options | 06:47 |
| Pradvara | Haomeng , i have separetly configured tftp server and created file /etc/xinetd.d/tftp | 06:47 |
| Pradvara | service tftp { socket_type = dgram protocol = udp port = 69 wait = yes user = stack server = /usr/sbin/in.tftpd server_args = --map-file /tftpboot/map-file /tftpboot disable = no bind = 10.106.240.165 } | 06:48 |
| Pradvara | is it correct | 06:48 |
| Pradvara | ? | 06:48 |
| Haomeng | Pradvara: did you configure them by manually? | 06:48 |
| Pradvara | yes | 06:48 |
| Haomeng | Pradvara: let me show my devstack | 06:48 |
| Haomeng | Pradvara: http://paste.openstack.org/show/370428/ | 06:48 |
| Haomeng | I think you missed tftpboot folder in server_args | 06:49 |
| Haomeng | Pradvara: is /tftpboot? | 06:49 |
| Haomeng | Pradvara: if yes, check /tftpboot folder to see if can find same mac name folder in this path | 06:49 |
| Haomeng | Pradvara: and if there is permision for stack user to access this /tftpboot folder | 06:50 |
| Haomeng | Pradvara: why do you manually set it, if you run devstack scripts, it can be auto-configurated as well | 06:50 |
| Pradvara | ok Haomeng, can you show me your local.conf file | 06:51 |
| Pradvara | i didnt see tftp server running initially | 06:51 |
| Haomeng | Pradvara: I just run with official local,conf which is shared in our ironic wiki - http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack | 06:52 |
| Haomeng | Pradvara: tftp server process is forked by xinetd | 06:52 |
| Haomeng | Pradvara: so if there is no tftp request, we can not see tftp process | 06:52 |
| Pradvara | i will try to change the server_args to /opt/stack/data/ironic/tftpboot/map-file | 06:53 |
| Haomeng | Pradvara: once some tftp request to server side, xinetd will fork in.tftpd process to handle tftp request | 06:53 |
| Haomeng | Pradvara: if you set your own tftpboot, just make sure the folder permision | 06:54 |
| *** achanda has quit IRC | 06:56 | |
| *** Nisha_away has quit IRC | 06:57 | |
| *** Nisha has joined #openstack-ironic | 06:57 | |
| Pradvara | on Haomeng | 07:01 |
| Pradvara | ok* | 07:01 |
| Haomeng | Pradvara: sudo chown -R stack /tftpboot | 07:02 |
| *** achanda has joined #openstack-ironic | 07:03 | |
| openstackgerrit | Tan Lin proposed openstack/ironic: Migrate ObjectListBase to subclass from the Oslo one https://review.openstack.org/201017 | 07:04 |
| Pradvara | http://paste.openstack.org/show/370520/ | 07:09 |
| Pradvara | Haomeng i have changed server_agrs to -v -v -v -v -v --map-file /opt/stack/data/ironic/tftpboot/map-file /opt/stack/data/ironic/tftpboot | 07:09 |
| Haomeng | Pradvara: ok | 07:09 |
| Haomeng | Pradvara: retry, should work this time | 07:10 |
| Pradvara | a file is created with node id /opt/stack/data/ironic/tftpboot/d284aac1-3ea4-4eb7-aceb-3a8a96863278$ | 07:10 |
| Pradvara | but i am getting the same error as "Unable to locate configuration file" | 07:11 |
| Haomeng | Pradvara: yes, that is created by ironic conductor for pxe to consume | 07:11 |
| Pradvara | yes | 07:11 |
| Pradvara | i have restarted the xinetd service | 07:12 |
| Haomeng | Pradvara: and can you check if there is same mac name folder in this patch - /opt/stack/data/ironic/tftpboot/pxelinux.cfg/ which is used by tftp to get configurations | 07:12 |
| Haomeng | Pradvara: and if /opt/stack/data/ironic/tftpboot is owned by stack user | 07:12 |
| Pradvara | drwxr-xr-x 5 stack libvirtd 4096 Jul 13 12:14 tftpboot | 07:13 |
| Pradvara | lrwxrwxrwx 1 stack stack 75 Jul 13 12:14 01-00-25-b5-00-10-07 -> /opt/stack/data/ironic/tftpboot/d284aac1-3ea4-4eb7-aceb-3a8a96863278/config | 07:13 |
| Haomeng | Pradvara: should be fine | 07:13 |
| Pradvara | 01-00-25-b5-00-10-07 is the baremetal mac address | 07:13 |
| Haomeng | Pradvara: that should be correct | 07:14 |
| Haomeng | Pradvara: did you run ironic with your baremetal first time, and no any successful case? | 07:14 |
| Haomeng | Pradvara: and after you change tftp server "server_agrs" options, did your restart xinet.d | 07:15 |
| Pradvara | yes | 07:15 |
| Pradvara | should we restart the neutron service | 07:16 |
| Haomeng | Pradvara: and we can do some tftp client operations by manually first | 07:16 |
| Haomeng | Pradvara: no | 07:16 |
| Haomeng | Pradvara: neutron will not manage tftp services | 07:16 |
| *** achanda has quit IRC | 07:16 | |
| Pradvara | ok, | 07:17 |
| Haomeng | Pradvara: can you run tftp client to get this file by manually - pxelinux.cfg/01-00-25-b5-00-10-07 which is pxe configuration file in your case | 07:17 |
| Haomeng | Pradvara: you can just run with " tftp localhost" | 07:18 |
| Haomeng | Pradvara: "tftp> get pxelinux.cfg/01-00-25-b5-00-10-07" | 07:18 |
| Haomeng | Pradvara: to do a test by manually to see if it works | 07:18 |
| Haomeng | Pradvara: if it works with your ubuntu tftp client, that means your baremetal pxe does not support such mac format | 07:20 |
| Pradvara | its getting timed out | 07:21 |
| Haomeng | Pradvara: so your tftp service has some issue to serve the tftp file accessing | 07:22 |
| Pradvara | should we install tftpd-hpa or tftp-hpa | 07:22 |
| Haomeng | Pradvara: did you change iptables by manually? | 07:22 |
| Pradvara | no | 07:22 |
| Haomeng | Pradvara: no, devstack will help use to auto-configurated | 07:22 |
| Haomeng | Pradvara: and can you check if tftp udp 69 port is in listening - netstat -an|grep 69|grep udp | 07:23 |
| Pradvara | i will check that Haomeng | 07:25 |
| Haomeng | Pradvara: ok | 07:25 |
| Pradvara | udp is not running on 69 i will check the smae | 07:26 |
| Haomeng | Pradvara: so check syslog to see why tftp service is not up | 07:26 |
| Pradvara | but the way your baremtal is a physical hardware or a VM | 07:26 |
| Haomeng | Pradvara: should have such line - udp 0 0 0.0.0.0:69 0.0.0.0:* | 07:27 |
| Haomeng | Pradvara: devstack will run virtsh to create some VMs as baremetal to be deployed by ironic | 07:27 |
| Haomeng | Pradvara: so for devstack env, it should be vm | 07:28 |
| Pradvara | ok, i am using a physical baremetal server to test the ironic | 07:28 |
| Haomeng | Pradvara: did you follow this - http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack | 07:28 |
| Pradvara | yes, i removed the VMs and configured the baremetal separately | 07:29 |
| *** viktors|weekend is now known as viktors | 07:29 | |
| Haomeng | Pradvara: devstack default is vxlan, our ironic does not support such vxlan if you run with real pyhsical machine | 07:30 |
| Pradvara | i configured a flat network separetely | 07:31 |
| Pradvara | changed the neutron configurations to flat | 07:32 |
| *** coolsvap is now known as coolsvap|afk | 07:32 | |
| Haomeng | Pradvara: great | 07:32 |
| Haomeng | Pradvara: so far, we need to check why tftp service is not start to listen udp 69 port,right? | 07:32 |
| Pradvara | yes Haomeng | 07:33 |
| Haomeng | Pradvara: ok, we can check syslog first I think | 07:33 |
| *** chlong-weekend is now known as chlong-afk | 07:33 | |
| Pradvara | canwe reconfigure the tftp service manually | 07:33 |
| Haomeng | Pradvara: and restart xinet.d to see some tftp service output | 07:33 |
| Haomeng | Pradvara: sure | 07:33 |
| Haomeng | just make sure the correct settings in xinet.d/tftp configuration | 07:33 |
| Haomeng | Pradvara: this is my tftp settings - http://paste.openstack.org/show/370428/ | 07:34 |
| Haomeng | Pradvara: and restart xinet.d , then to check syslog to see tftp service output | 07:34 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor pxe - New PXEBoot and ISCSIDeploy interfaces https://review.openstack.org/166513 | 07:35 |
| Pradvara | http://paste.openstack.org/show/370521/ | 07:36 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent driver with pxe boot interface https://review.openstack.org/166521 | 07:36 |
| Pradvara | this is the syslog | 07:36 |
| Haomeng | Pradvara: Error parsing attribute server - DISABLING SERVICE [file=/etc/xinetd.d/tftp] [line=8] | 07:36 |
| Haomeng | Pradvara: can you share your tftp configuration file content | 07:36 |
| Haomeng | Pradvara: looks like there is something wrong in Line 8 | 07:37 |
| Haomeng | Pradvara: and there is another reference for devstack local.conf to create flat network and support ironic to deploy real pyhsical server - https://github.com/Tan0/minicloud/blob/master/devstack_localrc/localrc_PRC | 07:38 |
| Haomeng | Pradvara: hope this can help you to set flat network + physical server with devstack | 07:39 |
| Haomeng | Pradvara: and to avoid to do these complex configurations including neutron net and subnets creations by manually, that will involve more configuration confilts and wrong settings | 07:40 |
| Pradvara | ok Haomeng | 07:40 |
| Haomeng | Pradvara: :) | 07:40 |
| Pradvara | thank you so much | 07:41 |
| Pradvara | will debug and get back | 07:41 |
| Haomeng | Pradvara: welcome, and good luck:) | 07:42 |
| Haomeng | Pradvara: :) | 07:43 |
| *** Kennan has quit IRC | 07:46 | |
| *** Kennan has joined #openstack-ironic | 07:46 | |
| *** max_lobur has quit IRC | 07:47 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add RAIDInterface for RAID configuration https://review.openstack.org/196003 | 07:49 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add RPCAPIs for RAID configuration https://review.openstack.org/196006 | 07:49 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add APIs for RAID configuration https://review.openstack.org/196007 | 07:49 |
| *** coolsvap|afk is now known as coolsvap | 07:56 | |
| *** yog__ has joined #openstack-ironic | 07:59 | |
| Haomeng | Pradvara: I remember a good reference for you - https://software.intel.com/en-us/articles/physical-server-provisioning-with-openstack , enjoy it:) | 08:01 |
| *** jistr has joined #openstack-ironic | 08:02 | |
| *** ndipanov has joined #openstack-ironic | 08:10 | |
| *** athomas has joined #openstack-ironic | 08:10 | |
| *** lucasagomes has joined #openstack-ironic | 08:12 | |
| *** dlpartain has joined #openstack-ironic | 08:15 | |
| *** romcheg has joined #openstack-ironic | 08:21 | |
| *** mgoddard has joined #openstack-ironic | 08:21 | |
| *** Marga_ has quit IRC | 08:25 | |
| *** Marga_ has joined #openstack-ironic | 08:26 | |
| openstackgerrit | Tan Lin proposed openstack/ironic: Migrate IronicObjectSerializer to subclass from oslo https://review.openstack.org/201038 | 08:31 |
| *** max_lobur has joined #openstack-ironic | 08:33 | |
| *** bizarrochristy has joined #openstack-ironic | 08:35 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-specs: Update the new state machine spec with CLEANWAIT https://review.openstack.org/200521 | 08:42 |
| *** dlpartain has left #openstack-ironic | 08:44 | |
| *** marzif__ has quit IRC | 08:45 | |
| *** amotoki_ has quit IRC | 08:46 | |
| *** persia has joined #openstack-ironic | 08:46 | |
| *** jamielennox has quit IRC | 08:46 | |
| *** dtantsur|afk is now known as dtantsur | 08:49 | |
| dtantsur | Morning Ironic | 08:50 |
| lucasagomes | dtantsur, morning | 08:59 |
| lucasagomes | the gate for python-ironicclient is broken due the mock release | 08:59 |
| * lucasagomes fixing | 08:59 | |
| dtantsur | oh.. | 08:59 |
| dtantsur | epic release :) | 08:59 |
| lucasagomes | heh unforgettable for sure | 09:01 |
| *** kozhukalov_ has joined #openstack-ironic | 09:01 | |
| rameshg87 | morning dtantsur lucasagomes and others | 09:04 |
| dtantsur | o/ | 09:04 |
| rameshg87 | I thought jlvillal fixed all those issues :) | 09:04 |
| rameshg87 | related to mocks in ironic code base | 09:05 |
| lucasagomes | rameshg87, good morning! | 09:06 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/python-ironicclient: Fix unittests due mock 1.1.0 release https://review.openstack.org/201043 | 09:06 |
| sambetts_ | Morning all o/ | 09:06 |
| lucasagomes | rameshg87, http://lists.openstack.org/pipermail/openstack-dev/2015-July/069156.html | 09:06 |
| lucasagomes | sambetts_, morning | 09:06 |
| rameshg87 | lucasagomes: yeah I just read that mail :) | 09:07 |
| *** sambetts_ is now known as sambetts | 09:07 | |
| *** kbyrne has quit IRC | 09:10 | |
| *** pelix has joined #openstack-ironic | 09:11 | |
| *** kbyrne has joined #openstack-ironic | 09:15 | |
| *** athomas has quit IRC | 09:17 | |
| jlvillal | lucasagomes, I think new mock issues ;) | 09:17 |
| lucasagomes | jlvillal, hi there. Yeah probably | 09:17 |
| lucasagomes | hope the new releases will be less painful | 09:18 |
| *** e0ne has joined #openstack-ironic | 09:19 | |
| sambetts | Man after reading through that email, so many tests must have been doing nothing, or not doing what people were expecting :-P | 09:19 |
| jlvillal | lucasagomes, From reading the email sounds like likely valid bugs in OpenStack code. | 09:20 |
| jlvillal | sambetts, One of the reasons I had been slowly adding 'autospec=True' to our code. | 09:20 |
| jlvillal | sambetts, To catch those kind of errors. | 09:20 |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add IPA support for iscsi_irmc driver https://review.openstack.org/181807 | 09:21 |
| *** rameshg87 has left #openstack-ironic | 09:25 | |
| *** rameshg87 has joined #openstack-ironic | 09:25 | |
| sambetts | jlvillal: :D woop | 09:26 |
| *** athomas has joined #openstack-ironic | 09:29 | |
| lucasagomes | jlvillal, true! Yeah there are very good things in the release | 09:32 |
| lucasagomes | like calling methods that doesn't exist, before it just passed | 09:32 |
| jlvillal | lucasagomes, I like that it only took a 4 line patch to fix Ironic client :) | 09:33 |
| lucasagomes | jlvillal, ++ | 09:34 |
| lucasagomes | tiny changes | 09:34 |
| lucasagomes | tho took me a while to figure out what was wrong there, the error message is horrible | 09:34 |
| lucasagomes | AssertionError: Expected call: get('fred:1234', expiration_time=None) | 09:34 |
| lucasagomes | Actual call: get('fred:1234', expiration_time=None) | 09:34 |
| lucasagomes | 'key' parameter lacking default value | 09:34 |
| *** e0ne is now known as e0ne_ | 09:36 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for inband raid configuration agent ramdisk https://review.openstack.org/198238 | 09:37 |
| jlvillal | lucasagomes, Agreed. Not very helpful error message :( | 09:39 |
| *** tiagogomes_ has quit IRC | 09:39 | |
| dtantsur | morning sambetts, jlvillal | 09:39 |
| jlvillal | dtantsur, Good morning from Moscow :) Off to St Petersburg this afternoon. | 09:40 |
| dtantsur | nice :) | 09:40 |
| *** jamielennox has joined #openstack-ironic | 09:46 | |
| sambetts | dtantsur: Morning :) | 09:50 |
| *** derekh has joined #openstack-ironic | 09:51 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: Enhance Power Interface for Soft Reboot and NMI https://review.openstack.org/186700 | 09:53 |
| *** naohirot has quit IRC | 09:54 | |
| *** alexpilotti has joined #openstack-ironic | 10:00 | |
| openstackgerrit | Merged openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/200902 | 10:03 |
| openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/200671 | 10:04 |
| *** foexle has joined #openstack-ironic | 10:04 | |
| *** e0ne_ is now known as e0ne | 10:05 | |
| *** marzif has joined #openstack-ironic | 10:07 | |
| *** pal has joined #openstack-ironic | 10:08 | |
| *** marzif_ has joined #openstack-ironic | 10:10 | |
| *** max_lobur1 has joined #openstack-ironic | 10:11 | |
| rameshg87 | lucasagomes: hi | 10:11 |
| lucasagomes | rameshg87, hi there | 10:12 |
| rameshg87 | lucasagomes: is it because of https://bugs.python.org/issue17015 that we need the fix https://review.openstack.org/#/c/201043/1/ironicclient/tests/unit/test_filecache.py ? | 10:12 |
| rameshg87 | lucasagomes: I was going through that change, works for me as well :) | 10:12 |
| rameshg87 | lucasagomes: but couldn't get why that change is required | 10:13 |
| lucasagomes | rameshg87, I don't know, I haven't looked into the python issues to be honest | 10:13 |
| *** max_lobur has quit IRC | 10:13 | |
| rameshg87 | lucasagomes: okay. | 10:13 |
| lucasagomes | I've seem the backports to mock 1.1.0 brought many new things and I just looked at what was failing in our tests and invesigated the problem on that context | 10:14 |
| lucasagomes | rameshg87, should I mention that python issue in the commit message or something? | 10:14 |
| rameshg87 | lucasagomes: yeah would be better to know why that change is required :) | 10:14 |
| rameshg87 | lucasagomes: I am wondering about for past 10-15 mins with that seeing why this change is required now | 10:15 |
| rameshg87 | lucasagomes: when the same method object can be referred with class object (spec=dogpile.cache.region.CacheRegion.set) or instance object (dogpile.cache.region.CacheRegion().set) | 10:15 |
| *** saripurigopi has quit IRC | 10:17 | |
| lucasagomes | rameshg87, yeah it's a bit obscure | 10:17 |
| lucasagomes | something wrong when introspecting the methods from a class object | 10:18 |
| rameshg87 | lucasagomes: yeah, and error message of course doesn't give any clue | 10:19 |
| rameshg87 | probably lifeless is he is around might have an idea | 10:20 |
| lucasagomes | rameshg87, yeah, at the beggining I looked the dogpile code | 10:20 |
| lucasagomes | I saw that the paramter key had no default value | 10:20 |
| lucasagomes | but I tried to pass it like assert_called_once_with(key=..., expiration_time=...) | 10:20 |
| lucasagomes | then it fails differently | 10:20 |
| rameshg87 | oh okay | 10:20 |
| lucasagomes | something like | 10:21 |
| lucasagomes | 'self' parameter lacking default value | 10:21 |
| lucasagomes | then you try to pass self=mock.ANY too | 10:21 |
| lucasagomes | and it fails with a different thing heh | 10:21 |
| rameshg87 | :D | 10:21 |
| lucasagomes | so creating the object instance makes sense | 10:21 |
| lucasagomes | but I don't know exactly how mock works to tell you why it's like that | 10:21 |
| lucasagomes | black magic | 10:21 |
| rameshg87 | :) | 10:22 |
| * rameshg87 is on his way to break this black magic | 10:22 | |
| rameshg87 | lucasagomes: ack, let me look around mock code to see what's happening :) | 10:22 |
| lucasagomes | rameshg87, ok hah lemme know! | 10:23 |
| lifeless | rameshg87: hmm ? | 10:23 |
| lifeless | whats up ? | 10:23 |
| rameshg87 | lifeless: hi there, after mock 1.1.0, something broke in python-ironicclient | 10:23 |
| rameshg87 | lifeless: https://review.openstack.org/#/c/201043/1/ironicclient/tests/unit/test_filecache.py | 10:23 |
| lucasagomes | lifeless, oh true you may know, this is the patch fixing the tests for python-ironicclient https://review.openstack.org/#/c/201043 | 10:24 |
| rameshg87 | lifeless: we were wondering why that change is required ? | 10:24 |
| lucasagomes | we are just talking about why that change would be needed | 10:24 |
| lifeless | changing it from an unbound method to a bound method | 10:24 |
| lifeless | the former isn't callable without a class instance normally | 10:25 |
| *** coolsvap is now known as coolsvap|away | 10:25 | |
| lifeless | so one possibility is that this is a bugfix. You can verify that by trying with unittest.mock from cPython 3.5. | 10:25 |
| lifeless | The other possibility is that this is a bug not covered by the mock test suite. If the old code works with unittest.mock from cPython 3.5, then it is a bug in the backport and we should: | 10:26 |
| lifeless | - add a test to cPython to lock the behaviour in | 10:26 |
| lifeless | - fix mock | 10:26 |
| rameshg87 | lifeless: so I was wondering if it was something related to https://bugs.python.org/issue17015 (noted in your mail), but from what you have said, it seems it isn't | 10:26 |
| lifeless | it might be | 10:28 |
| *** coolsvap|away is now known as coolsvap | 10:28 | |
| lifeless | funcsigs (the backport of inspect.signature) is somewhat flaky | 10:28 |
| lifeless | I had to fix a bug in it to do the 1.1 update at all | 10:28 |
| lifeless | and I can well believe there are more issues. But the basic process is: verify on 3.5's unittest.mock (or trunk), and then we'll backport | 10:29 |
| lifeless | mock aims to be 100 | 10:29 |
| lifeless | 100% identical to unittest.mock | 10:29 |
| rameshg87 | lifeless: ack | 10:29 |
| lifeless | that said | 10:30 |
| lifeless | the usage there seems a little unidiomatic; isn't it usual to just assign the thing you want rather than manually making new mocks? | 10:30 |
| lifeless | like- it looks like you're making things harder for yourself than they need to be | 10:31 |
| rameshg87 | lifeless: do you mean there was no need to even mock mock_cache.set ? | 10:32 |
| *** Marga_ has quit IRC | 10:34 | |
| lifeless | you used autospec | 10:34 |
| *** Marga_ has joined #openstack-ironic | 10:34 | |
| lifeless | all the methods on the thing you specced get filled out automatically | 10:34 |
| lifeless | https://docs.python.org/dev/library/unittest.mock.html#auto-speccing | 10:34 |
| lucasagomes | lifeless, oh | 10:36 |
| rameshg87 | lifeless: but if you meant we could autospec at L59, https://review.openstack.org/#/c/201043/1/ironicclient/tests/unit/test_filecache.py | 10:36 |
| *** Marga_ has quit IRC | 10:36 | |
| lucasagomes | lifeless, so I could just do "mock_cache.get.return_value = s" for example ? | 10:36 |
| *** Marga_ has joined #openstack-ironic | 10:36 | |
| lucasagomes | without assigning the .get = mock.... | 10:36 |
| lifeless | lucasagomes: well, if the thing you're patching is already an instance of teh appropriate type | 10:36 |
| lifeless | you don't need to do anything *at all* | 10:36 |
| lifeless | because thats what autospec is all about | 10:37 |
| rameshg87 | lucasagomes: yeah I think so | 10:37 |
| lucasagomes | I see | 10:37 |
| lifeless | mock will read the instance, and then you have a get method already specced | 10:37 |
| lucasagomes | I will put another patch-set for it then | 10:37 |
| rameshg87 | lifeless: but one question | 10:37 |
| rameshg87 | lifeless: https://review.openstack.org/#/c/201043/1/ironicclient/tests/unit/test_filecache.py L57 | 10:37 |
| lifeless | or you can pass in spec=thing-to-spec-from | 10:38 |
| lifeless | and you probably want to pass instance=True, since you want an instance-of, not the class | 10:38 |
| lifeless | [if you pass spec=] | 10:38 |
| lifeless | rameshg87: yes, the .set assignment in that line is also likely unneeded | 10:39 |
| lifeless | (or replaceable with a spec= parameter to the patch call | 10:39 |
| rameshg87 | lifeless: does autospec=True work there, because filecache.CACHE is set runtime on first invocation to _get_cache(), https://github.com/openstack/python-ironicclient/blob/master/ironicclient/common/filecache.py#L28 | 10:39 |
| rameshg87 | lifeless: yeah | 10:39 |
| lifeless | autospec fails open | 10:39 |
| lifeless | if the thing is None, you get a spec from None | 10:39 |
| lifeless | which you're adapting | 10:40 |
| lifeless | the thing to do there is to pass an explicit spec in | 10:40 |
| rameshg87 | lifeless: yeah | 10:40 |
| rameshg87 | lifeless: explicit spec set to dogpile.cache.region.CacheRegion probably | 10:40 |
| lifeless | but specing the type with instance=True will be cleaner than speccin the one method | 10:40 |
| lifeless | right | 10:40 |
| rameshg87 | lifeless: and remove off all the explicit mocks for get and set | 10:40 |
| lifeless | hope that steers you in the right direction. BTW it looks like tere is a bug in autospec somewhere, so if you hit a glitch, cross-check with 3.5 unittest.mock | 10:41 |
| lifeless | [see the list thread] | 10:41 |
| rameshg87 | lifeless: sure, will do .. | 10:41 |
| rameshg87 | thanks for your inputs :) | 10:41 |
| * rameshg87 will check it with python 3.5 | 10:41 | |
| *** coolsvap is now known as coolsvap|away | 10:43 | |
| *** e0ne is now known as e0ne_ | 10:43 | |
| *** e0ne_ is now known as e0ne | 10:43 | |
| rameshg87 | lucasagomes: do you also agree on those changes ? | 10:43 |
| lucasagomes | rameshg87, sounds good | 10:46 |
| rameshg87 | okay | 10:46 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/python-ironicclient: Fix unittests due mock 1.1.0 release https://review.openstack.org/201043 | 10:52 |
| lucasagomes | rameshg87, ^ | 10:52 |
| rameshg87 | lucasagomes: thanks | 10:56 |
| *** Nisha has quit IRC | 10:56 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Periodically checks the status of nodes in DEPLOYING state https://review.openstack.org/197141 | 10:57 |
| *** Nisha has joined #openstack-ironic | 10:57 | |
| *** e0ne is now known as e0ne_ | 11:01 | |
| *** lucasagomes is now known as lucas-hungry | 11:04 | |
| *** e0ne_ is now known as e0ne | 11:14 | |
| zhenguo | rameshg87 lucasagomes, can you help to review https://review.openstack.org/#/c/177642/ again | 11:15 |
| rameshg87 | zhenguo: sure .. | 11:18 |
| zhenguo | rameshg87: thanks :) | 11:18 |
| *** stendulker has quit IRC | 11:24 | |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/200670 | 11:26 |
| *** Marga_ has quit IRC | 11:28 | |
| lintan | hi dtantsur, | 11:31 |
| dtantsur | o/ | 11:31 |
| lintan | Could you have a look at this spec when you are free, my colleague update with your comments | 11:33 |
| lintan | dtantsur, :) | 11:33 |
| lintan | dtantsur, https://review.openstack.org/#/c/176109/ | 11:33 |
| dtantsur | "when you are free" sounds so good... :D I'll try to. | 11:34 |
| lintan | dtantsur, don't want to push you at all. It's too vendor specific. Anyway, thanks | 11:36 |
| TheJulia | good orning | 11:37 |
| TheJulia | morning | 11:37 |
| *** marzif_ has quit IRC | 11:37 | |
| *** achanda has joined #openstack-ironic | 11:37 | |
| TheJulia | clearly, i need coffee | 11:37 |
| *** trown|outttypeww is now known as trown | 11:37 | |
| *** marzif_ has joined #openstack-ironic | 11:37 | |
| *** Marga_ has joined #openstack-ironic | 11:43 | |
| *** Marga_ has quit IRC | 11:44 | |
| *** coolsvap|away is now known as coolsvap | 11:44 | |
| *** Marga_ has joined #openstack-ironic | 11:44 | |
| *** marzif_ has quit IRC | 11:49 | |
| *** marzif_ has joined #openstack-ironic | 11:50 | |
| *** achanda has quit IRC | 11:50 | |
| *** foexle has quit IRC | 11:52 | |
| *** dprince has joined #openstack-ironic | 11:53 | |
| *** pal has quit IRC | 11:55 | |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: IPA: Update proliant hardware manager https://review.openstack.org/198603 | 12:01 |
| * rameshg87 goes home | 12:03 | |
| *** rameshg87 has quit IRC | 12:04 | |
| *** lucas-hungry is now known as lucasagomes | 12:04 | |
| *** thrash|wknd is now known as thrash | 12:06 | |
| *** kozhukalov has joined #openstack-ironic | 12:13 | |
| *** achanda has joined #openstack-ironic | 12:15 | |
| *** e0ne is now known as e0ne_ | 12:33 | |
| lucasagomes | lifeless, mock 1.1.0 doesn't work with py26? | 12:33 |
| lucasagomes | 2015-07-13 10:54:35.538 | File "/home/jenkins/workspace/gate-python-ironicclient-python26/.tox/py26/lib/python2.6/site-packages/mock/mock.py", line 132 | 12:33 |
| lucasagomes | 2015-07-13 10:54:35.538 | _builtins = {name for name in dir(builtins) if not name.startswith('_')} | 12:33 |
| lucasagomes | we still run py26 in the python-ironicclient gate | 12:33 |
| lucasagomes | hmm | 12:33 |
| TheJulia | nope, doesn't work | 12:35 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/python-ironicclient: Fix unittests due mock 1.1.0 release https://review.openstack.org/201043 | 12:35 |
| * lucasagomes tries updating test-requirements on ^ | 12:36 | |
| lucasagomes | btw dtantsur jroll NobodyCam devananda ^ can you guys please keep an eye at it? It's that's fixing the gate for python-ironicclient | 12:36 |
| lucasagomes | TheJulia, good morning | 12:36 |
| TheJulia | good morning | 12:37 |
| dtantsur | ack | 12:37 |
| dtantsur | TheJulia, morning | 12:37 |
| jroll | lucasagomes: they pinned mock to 1.0.1 for py26 in g-r friday | 12:38 |
| jroll | oh yeah, you got it | 12:38 |
| lucasagomes | jroll, yeah I've updated the patch to have this change | 12:38 |
| jroll | morning lucasagomes TheJulia dtantsur :) | 12:38 |
| dtantsur | jroll, o/ | 12:38 |
| lucasagomes | jroll, thanks! | 12:38 |
| lucasagomes | and good morning | 12:38 |
| *** Marga_ has quit IRC | 12:45 | |
| *** e0ne_ is now known as e0ne | 12:46 | |
| *** absubram has quit IRC | 12:50 | |
| *** rloo has joined #openstack-ironic | 13:01 | |
| *** kkoski has joined #openstack-ironic | 13:03 | |
| *** pal has joined #openstack-ironic | 13:03 | |
| *** Marga_ has joined #openstack-ironic | 13:06 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Periodically checks the status of nodes in DEPLOYING state https://review.openstack.org/197141 | 13:18 |
| *** yog__ has quit IRC | 13:20 | |
| *** Pradvara has quit IRC | 13:21 | |
| *** cdearborn has joined #openstack-ironic | 13:23 | |
| *** kan__ has quit IRC | 13:24 | |
| NobodyCam | Goood morning Ironicers | 13:25 |
| dtantsur | NobodyCam, morning! | 13:25 |
| NobodyCam | morning dtantsur :) | 13:25 |
| jroll | ohai NobodyCam :) | 13:25 |
| lucasagomes | NobodyCam, morning | 13:26 |
| NobodyCam | morning jroll :) | 13:26 |
| NobodyCam | morning lucasagomes :) | 13:26 |
| *** vishwana_ has quit IRC | 13:28 | |
| lucasagomes | jroll, I think I will need a spec for the abortable cleaning states :-/ | 13:28 |
| lucasagomes | we will need a new api for it | 13:28 |
| jroll | lucasagomes: mmmmm | 13:28 |
| jroll | spec is probably a good idea | 13:28 |
| lucasagomes | cause, for DEPLOYING we currently use "deleted" | 13:29 |
| jroll | changing rest api, changing clean_step api | 13:29 |
| lucasagomes | DEPLOYWAIT* | 13:29 |
| jroll | yeah | 13:29 |
| lucasagomes | but deletion happens prior to clean so we don't actually have an API call that would suite | 13:29 |
| lucasagomes | jroll, right, yeah | 13:29 |
| * lucasagomes starts one | 13:29 | |
| jroll | yeah, we talked about this the other day :P | 13:29 |
| lucasagomes | yeah... sorry heh my mind is pretty slow today | 13:30 |
| jroll | all good | 13:30 |
| lucasagomes | came back yesterday late from a trip to a farm | 13:30 |
| * lucasagomes needs more sleep | 13:30 | |
| jroll | :/ | 13:30 |
| *** jjohnson2 has joined #openstack-ironic | 13:31 | |
| * TheJulia needs a lot more sleep | 13:37 | |
| NobodyCam | TheJulia: are you back home today or still traveling? | 13:42 |
| TheJulia | I'm not home home, but I'm working today | 13:45 |
| NobodyCam | :) | 13:45 |
| *** cdearborn has quit IRC | 13:47 | |
| openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: Provide time data in alert decode https://review.openstack.org/201140 | 13:50 |
| *** gabriel-bezerra has joined #openstack-ironic | 13:55 | |
| *** shakamunyi has joined #openstack-ironic | 13:59 | |
| *** barra204 has joined #openstack-ironic | 13:59 | |
| *** mgoddard1 has joined #openstack-ironic | 14:02 | |
| *** mtanino has joined #openstack-ironic | 14:03 | |
| *** mgoddard has quit IRC | 14:04 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC vendor passthru for soft reboot and NMI https://review.openstack.org/187082 | 14:05 |
| *** absubram has joined #openstack-ironic | 14:06 | |
| openstackgerrit | Merged openstack/bifrost: Disable cleaning by default in bifrost https://review.openstack.org/200566 | 14:07 |
| *** marzif_ has quit IRC | 14:09 | |
| *** marzif_ has joined #openstack-ironic | 14:10 | |
| TheJulia | Well that will make less people go "Ugh" when they realize cleaning | 14:10 |
| *** kozhukalov_ has quit IRC | 14:17 | |
| *** achanda has quit IRC | 14:18 | |
| *** cdearborn has joined #openstack-ironic | 14:21 | |
| *** barra204 has quit IRC | 14:25 | |
| rloo | hi ironickers, NobodyCam, TheJulia, jroll, lucasagomes, dtantsur | 14:25 |
| *** shakamunyi has quit IRC | 14:25 | |
| *** whydidyoustealmy has joined #openstack-ironic | 14:25 | |
| rloo | anyone know if ramesh is around? | 14:25 |
| *** shakamunyi has joined #openstack-ironic | 14:26 | |
| jroll | morning rloo :) I don't see him | 14:26 |
| dtantsur | rloo, o/ | 14:26 |
| rloo | jroll: no worries. he is sometimes responsive if I -1 his patch. | 14:26 |
| jroll | hehehe | 14:27 |
| *** Nisha has quit IRC | 14:29 | |
| NobodyCam | mornign rloo :) | 14:32 |
| *** whydidyoustealmy has quit IRC | 14:34 | |
| *** shakamunyi has quit IRC | 14:34 | |
| NobodyCam | just looking over the agenda, only two items there, this would be a perfect time to add your own topic | 14:35 |
| NobodyCam | :-p | 14:36 |
| *** pal has quit IRC | 14:39 | |
| lucasagomes | rloo, good morning! | 14:43 |
| openstackgerrit | Merged openstack/ironic-lib: Update mock assertion for mock 1.1 https://review.openstack.org/200844 | 14:47 |
| *** rameshg87 has joined #openstack-ironic | 14:50 | |
| rameshg87 | rloo: hi | 14:51 |
| rloo | hi rameshg87 | 14:52 |
| rameshg87 | rloo: is there anything that's pending to be addressed on https://review.openstack.org/#/c/166513/13 ? | 14:52 |
| rloo | rameshg87: oh, sorry. forgot to submit the comment. yes. | 14:52 |
| rloo | rameshg87: unless there's a good reason, i don't see why you need to change _parse_driver_info() | 14:53 |
| rameshg87 | rloo: okay, will take a look at it | 14:53 |
| *** alexpilotti has quit IRC | 14:54 | |
| rameshg87 | rloo: okay, I think there has been good enough misunderstanding on that part, we can discuss that now :) | 14:55 |
| rloo | rameshg87: let me know if you have questions | 14:55 |
| rameshg87 | rloo: in the previous patchset, I had kept the _parse_driver_info() exactly the same as previous | 14:55 |
| *** alexpilotti has joined #openstack-ironic | 14:55 | |
| rameshg87 | rloo: just that it was moved in the diff because it became below another method | 14:56 |
| rloo | rameshg87: if i compare to the original code, it isn't the same? | 14:56 |
| rloo | rameshg87: so move it back to where it was in the original code | 14:56 |
| rameshg87 | rloo: ah is that all you meant ? :) | 14:56 |
| *** alexpilotti has quit IRC | 14:56 | |
| rloo | rameshg87: there are a lot of changes in that patch. you can make it easier on the reviewers by not changing things that don't need to be changed | 14:57 |
| rameshg87 | rloo: yeah I agree on that. | 14:57 |
| rloo | rameshg87: i mean leave _parse_driver_info() alone. I am not convinced that you had it the same as the original -- although maybe it was cuz it was hard to do the diff cuz you moved it. | 14:57 |
| *** alexpilotti has joined #openstack-ironic | 14:57 | |
| rameshg87 | rloo: but I thought you were not fine with the current stuff because it returned the tftp paths for deploy_kernel, deploy_ramdisk. wasn't it ? | 14:57 |
| rloo | rameshg87: the original _parse_driver_info didn't do anything wrt tftp paths, did it? | 14:58 |
| * rameshg87 looks | 14:58 | |
| rameshg87 | rloo: ah no it didn't. I am sorry. | 14:59 |
| rloo | rameshg87: glad we clarified that! | 14:59 |
| *** alexpilotti has quit IRC | 14:59 | |
| rameshg87 | rloo: so now here is what you would like me to do if I am getting it right | 14:59 |
| rameshg87 | rloo: put back _parse_driver_info where it was because it doesn't need to be changed | 15:00 |
| rameshg87 | I will put it back to where it was and make sure we don't see any diffs there | 15:00 |
| rloo | rameshg87: yup, that's what I'd like to see | 15:00 |
| rameshg87 | rloo: but I still need to have 2 separate methods _get_deploy_image_info() and _get_instance_image_info() which will return the tftp paths for 2 types of images | 15:01 |
| rameshg87 | rloo: do you agree on that ? | 15:01 |
| rloo | rameshg87: yup | 15:01 |
| *** alexpilotti has joined #openstack-ironic | 15:01 | |
| rameshg87 | rloo: got it. let me do that right away. | 15:02 |
| *** mgoddard1 has quit IRC | 15:02 | |
| *** alexpilotti has quit IRC | 15:03 | |
| rloo | hi lucasagomes, wrt https://review.openstack.org/#/c/201043/ failing. what about undoing the change to test_requirements. There's another patch that updates that: https://review.openstack.org/#/c/200903/ | 15:03 |
| rloo | lucasagomes: although that one also fails pep8. hmm. | 15:03 |
| *** mgoddard has joined #openstack-ironic | 15:03 | |
| lucasagomes | rloo, 1 sec will take a look | 15:04 |
| lucasagomes | rloo, ouch why is 201043 failing pep8 >.< | 15:05 |
| *** alexpilotti has joined #openstack-ironic | 15:05 | |
| lucasagomes | so that's the problem we need to fix unittests and to fix it we need to change the test-requirements | 15:06 |
| rloo | lucasagomes: oh, i thought the unittests could be fixed w/o changing test-requirements. | 15:06 |
| trown | jroll: I think I remember you saying that you guys ran the agent as "always on"...is that right? | 15:06 |
| trown | jroll: also good morning | 15:06 |
| rloo | lucasagomes: but that still doesn't explain the pep8 ordering issue | 15:06 |
| lucasagomes | rloo, it can't because we have py26 in gate | 15:06 |
| lucasagomes | and mock 1.1.0 doesn't work with py26 | 15:06 |
| lucasagomes | rloo, yeah, the order seems correct to me | 15:07 |
| rloo | lucasagomes: oh right, the client uses py26 | 15:07 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/python-ironicclient: Fix unittests due mock 1.1.0 release https://review.openstack.org/201043 | 15:09 |
| lucasagomes | rloo, that should do it ^ | 15:09 |
| lucasagomes | tested locally with that script hey run in gate | 15:09 |
| lucasagomes | http://fpaste.org/243859/ | 15:09 |
| *** rvasilets has joined #openstack-ironic | 15:10 | |
| rloo | lucasagomes: ok, i'll trust you :) | 15:11 |
| *** alexpilotti has quit IRC | 15:11 | |
| lucasagomes | it will fail again if not :-) | 15:11 |
| rvasilets | Hi guys. I'm from Rally team I have finished first part of adding Ironic to Rally. Could you review it please? https://review.openstack.org/#/c/186064/ | 15:11 |
| lucasagomes | I just copied the script from https://raw.githubusercontent.com/hep-gc/glint-horizon/master/tools/requirements_style_check.sh and ran locally | 15:11 |
| jroll | trown: yes, our agents are always running, good morning :) | 15:12 |
| rloo | lucasagomes: but global requirements has it in the other order. and i don't know why test-requirements wants things in alphabetical order, that seems odd. | 15:12 |
| trown | jroll: do you setup external ipxe infra to do that? or some other patches to ironic? | 15:12 |
| jroll | trown: yeah, so we use external dhcp/ipxe/http for agent images | 15:13 |
| jroll | trown: and then maybe one small patch to power the node back on after teardown | 15:13 |
| trown | ah ok | 15:13 |
| lucasagomes | rloo, yeah, I copied the patch-set #3 from g-r | 15:13 |
| jroll | trown: so dhcp_provider=None is the main thing | 15:13 |
| *** pal has joined #openstack-ironic | 15:13 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor pxe - New PXEBoot and ISCSIDeploy interfaces https://review.openstack.org/166513 | 15:13 |
| lucasagomes | rloo, if that pass the pep8 test I will contact -infra to ask why, maybe we uncovered a bug | 15:14 |
| rloo | lucasagomes: good idea. guess i/we should hold off on approving that then? or approve it anyway? | 15:14 |
| lucasagomes | rloo, well gate is broken due that | 15:15 |
| rloo | lucasagomes: yeah, and we want to fix it so we can do development. so i'm game to approve. | 15:15 |
| lucasagomes | lemme ask infra now | 15:15 |
| lucasagomes | rloo, __ | 15:15 |
| lucasagomes | ++* | 15:15 |
| * rameshg87 will be back for the meeting | 15:15 | |
| *** rameshg87 has quit IRC | 15:15 | |
| *** rwsu has joined #openstack-ironic | 15:19 | |
| lucasagomes | rloo, perhaps we should stop doing https://github.com/openstack/python-ironicclient/blob/master/tox.ini#L28 ? | 15:19 |
| rloo | lucasagomes: why do we even run requirements_style_check for client? we don't do that for ironic. | 15:19 |
| lucasagomes | seems other clients are not doing it | 15:19 |
| lucasagomes | https://github.com/openstack/python-novaclient/blob/master/tox.ini#L23 | 15:19 |
| lucasagomes | https://github.com/openstack/python-glanceclient/blob/master/tox.ini#L18 | 15:20 |
| lucasagomes | rloo, yeah no idea | 15:20 |
| rloo | lucasagomes: we should delete that i think | 15:20 |
| lucasagomes | right yeah I think so too | 15:20 |
| lucasagomes | leave the order as in the g-r and remove that check | 15:21 |
| lucasagomes | rloo, lemme update the patch | 15:21 |
| rloo | lucasagomes: we should do that in a separate patch though | 15:21 |
| lucasagomes | hmm | 15:21 |
| lucasagomes | rloo, problem is if we try to change the other before it will fail gate because of the unittests | 15:22 |
| lucasagomes | rloo, what we can do is, get 201043 in with the reverse order... then put a new patch on top of it inverting the order and removing that test from tox.ini | 15:22 |
| rloo | lucasagomes: why not just remove the pep8 test first? | 15:23 |
| lucasagomes | rloo, cause it will fail unittests | 15:23 |
| lucasagomes | that 201043 is fixing | 15:23 |
| rloo | lucasagomes: here's the patch that added it: https://bugs.launchpad.net/glance/+bug/1285478 | 15:23 |
| openstack | Launchpad bug 1285478 in tuskar "Enforce alphabetical ordering in requirements file" [Low,Fix released] - Assigned to Fengqian (fengqian-gao) | 15:23 |
| rloo | lucasagomes: oh yeah. you're right. | 15:23 |
| lucasagomes | rloo, or we can do everything in 201043 | 15:23 |
| rloo | lucasagomes: yeah, invert it to get your patch to merge | 15:24 |
| rloo | lucasagomes: then we can do a patch to remove that pep8 test | 15:24 |
| lucasagomes | rloo, ack | 15:24 |
| rloo | lucasagomes: then use the bot's patch to update the requirements | 15:24 |
| lucasagomes | so the last patch-set is correct | 15:24 |
| lucasagomes | hope it won't fail in gate because of another test checking if the order == g-r order | 15:25 |
| lucasagomes | if so, we will have to fix it all in one patch | 15:25 |
| *** Sukhdev has joined #openstack-ironic | 15:25 | |
| rloo | lucasagomes: here's hoping ... ;) | 15:26 |
| lucasagomes | heh ++ | 15:26 |
| Sukhdev | devananda: when you have a moment, can you please look at this - https://review.openstack.org/#/c/188528/ | 15:29 |
| Sukhdev | devananda: and this one too - https://review.openstack.org/#/c/187829/ | 15:30 |
| trown | jroll: thanks, I will give that a go | 15:30 |
| *** puranamr has joined #openstack-ironic | 15:31 | |
| *** puranamr has quit IRC | 15:32 | |
| *** puranamr has joined #openstack-ironic | 15:34 | |
| rvasilets | lucasagomes, I'm from Rally team I have finished first part of adding Ironic to Rally. Could you review it please? https://review.openstack.org/#/c/186064/ | 15:35 |
| rvasilets | devananda, I'm from Rally team I have finished first part of adding Ironic to Rally. Could you review it please? https://review.openstack.org/#/c/186064/ | 15:36 |
| rvasilets | Sorry for duplication of message | 15:36 |
| lucasagomes | rvasilets, oh thanks! I will add it to my TODO and review soon (finish up something now) | 15:36 |
| rvasilets | I thought it must be target message | 15:36 |
| *** cinerama has quit IRC | 15:36 | |
| *** mordred has quit IRC | 15:36 | |
| *** mitz_ has quit IRC | 15:36 | |
| *** kragniz has quit IRC | 15:36 | |
| *** mariojv has quit IRC | 15:36 | |
| *** trown has quit IRC | 15:36 | |
| *** balajin_ has quit IRC | 15:36 | |
| *** derekh has quit IRC | 15:36 | |
| *** UForgotten has quit IRC | 15:36 | |
| *** zsmithnyc has quit IRC | 15:36 | |
| *** EntropyWorks has quit IRC | 15:36 | |
| *** mikal has quit IRC | 15:36 | |
| *** zer0c00l1 has quit IRC | 15:36 | |
| *** 18VAACHA6 has quit IRC | 15:36 | |
| rvasilets | lucasagomes, thak you very much | 15:36 |
| *** kragniz has joined #openstack-ironic | 15:37 | |
| *** mikal has joined #openstack-ironic | 15:37 | |
| *** balajin has joined #openstack-ironic | 15:37 | |
| *** dan_ has joined #openstack-ironic | 15:37 | |
| *** EntropyWorks has joined #openstack-ironic | 15:37 | |
| *** mariojv has joined #openstack-ironic | 15:37 | |
| *** UForgotten has joined #openstack-ironic | 15:37 | |
| *** mitz has joined #openstack-ironic | 15:37 | |
| *** cinerama has joined #openstack-ironic | 15:37 | |
| *** mordred has joined #openstack-ironic | 15:37 | |
| *** dan_ is now known as Guest10549 | 15:37 | |
| *** zer0c00l has joined #openstack-ironic | 15:38 | |
| *** trown has joined #openstack-ironic | 15:38 | |
| *** pcaruana has quit IRC | 15:38 | |
| devananda | morning, all | 15:39 |
| devananda | Sukhdev: adding to my list :) | 15:39 |
| *** derekh has joined #openstack-ironic | 15:39 | |
| NobodyCam | good morning devananda | 15:39 |
| devananda | rvasilets: cheers! yes | 15:39 |
| Sukhdev | devananda: cool - thanks - these are ready to go. | 15:40 |
| jroll | morning devananda :) | 15:40 |
| dtantsur | devananda, morning | 15:40 |
| rvasilets | devananda, thx | 15:40 |
| lucasagomes | devananda, good morning | 15:42 |
| Sukhdev | Dear Ironic core reviewers, we could use your few cycles for these Ironic/Neutron specs - https://review.openstack.org/#/c/188528/ and https://review.openstack.org/#/c/187829/ | 15:42 |
| *** morganfainberg has quit IRC | 15:51 | |
| *** morganfainberg has joined #openstack-ironic | 15:52 | |
| *** zsmithnyc has joined #openstack-ironic | 15:55 | |
| *** kkoski_ has joined #openstack-ironic | 15:58 | |
| *** kkoski has quit IRC | 15:58 | |
| sambetts | 16:39 < devananda> Sukhdev: adding to my list :) | 15:58 |
| sambetts | 16:39 < NobodyCam> good morning devananda | 15:58 |
| sambetts | what... why did that happen... | 15:58 |
| sambetts | sigh... sorry about that guys... | 15:59 |
| *** mitchjameson has joined #openstack-ironic | 16:00 | |
| NobodyCam | huh | 16:00 |
| NobodyCam | mornign sambetts | 16:00 |
| NobodyCam | lol | 16:00 |
| * lucasagomes will be back for the meeting | 16:03 | |
| *** lucasagomes is now known as lucas-brb | 16:03 | |
| * devananda escapes from a meeting, makes more coffee | 16:04 | |
| sambetts | NobodyCam: morning | 16:05 |
| NobodyCam | :) | 16:05 |
| sambetts | NobodyCam: middle click in my IRC client is both open a link and paste so it got confused :-P | 16:06 |
| NobodyCam | ahh _p | 16:06 |
| NobodyCam | heheh | 16:06 |
| *** stendulker has joined #openstack-ironic | 16:10 | |
| *** zhenguo has quit IRC | 16:13 | |
| NobodyCam | TheJulia: seems like this is stalling: https://review.openstack.org/#/c/199580/2 | 16:15 |
| TheJulia | Yeah :( | 16:20 |
| *** jrist has quit IRC | 16:20 | |
| jroll | NobodyCam: TheJulia: I mean, there's unanswered questions there... | 16:21 |
| *** e0ne has quit IRC | 16:21 | |
| *** mgarza_ has joined #openstack-ironic | 16:22 | |
| NobodyCam | jroll: ya ... maybe mordred will be able to post a answer | 16:23 |
| *** shakamunyi has joined #openstack-ironic | 16:25 | |
| *** whydidyoustealmy has joined #openstack-ironic | 16:25 | |
| *** jrist has joined #openstack-ironic | 16:26 | |
| *** max_lobur1 has quit IRC | 16:27 | |
| mordred | what did I do? | 16:27 |
| TheJulia | jroll: kind of what I was hoping and lost track of the review | 16:28 |
| *** pal has quit IRC | 16:31 | |
| *** achanda has joined #openstack-ironic | 16:31 | |
| NobodyCam | good morning mordred | 16:32 |
| NobodyCam | mordred: seems there is a question out on https://review.openstack.org/#/c/199580 | 16:33 |
| stendulker | NobodyCam, jroll: Hi | 16:35 |
| NobodyCam | mornign stendulker :) | 16:35 |
| stendulker | NobodyCam: Good Morning :) | 16:35 |
| NobodyCam | :) | 16:36 |
| jroll | hi stendulker :) | 16:36 |
| stendulker | NobodyCam, jroll : Can you please review this spec related to grub2 support for pxe in uefi boot mode and secure boot support for iLo pxe_ilo driver when you get time. https://review.openstack.org/#/c/174295/ | 16:37 |
| *** whydidyoustealmy has quit IRC | 16:37 | |
| *** shakamunyi has quit IRC | 16:37 | |
| stendulker | NobodyCam: Have addressed all your comments on the same. | 16:38 |
| NobodyCam | stendulker: awesome will take a look .. prob after the meeting | 16:38 |
| jroll | ^ same | 16:38 |
| NobodyCam | :) | 16:39 |
| stendulker | NobodyCam, jroll : Thank you :) | 16:39 |
| *** mitchjameson has quit IRC | 16:44 | |
| *** romcheg has quit IRC | 16:46 | |
| NobodyCam | thank you mordred :) for the answer on 199580 | 16:47 |
| *** alexpilotti has joined #openstack-ironic | 16:51 | |
| *** shakamunyi has joined #openstack-ironic | 16:52 | |
| *** whydidyoustealmy has joined #openstack-ironic | 16:52 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic-specs: Major overhaul of our version docs https://review.openstack.org/196320 | 16:55 |
| *** derekh has quit IRC | 16:55 | |
| *** lucas-brb is now known as lucasagomes | 16:56 | |
| *** ukalifon1 has quit IRC | 16:58 | |
| * devananda heads to the meeting room | 16:59 | |
| *** rameshg87 has joined #openstack-ironic | 17:00 | |
| *** alexpilotti has quit IRC | 17:02 | |
| *** zz_natorious is now known as natorious | 17:03 | |
| *** athomas has quit IRC | 17:04 | |
| *** pradipta has joined #openstack-ironic | 17:07 | |
| *** alexpilotti has joined #openstack-ironic | 17:08 | |
| *** mgoddard has quit IRC | 17:08 | |
| *** shakamunyi has quit IRC | 17:09 | |
| *** whydidyoustealmy has quit IRC | 17:09 | |
| *** shakamunyi has joined #openstack-ironic | 17:09 | |
| *** athomas has joined #openstack-ironic | 17:11 | |
| *** davideagnello has joined #openstack-ironic | 17:11 | |
| *** marzif_ has quit IRC | 17:13 | |
| *** kkoski_ has quit IRC | 17:15 | |
| *** mgoddard has joined #openstack-ironic | 17:15 | |
| *** kkoski has joined #openstack-ironic | 17:18 | |
| *** pradipta has quit IRC | 17:19 | |
| *** afaranha has joined #openstack-ironic | 17:21 | |
| *** kkoski has quit IRC | 17:22 | |
| *** trown is now known as trown|lunch | 17:23 | |
| *** Sukhdev has quit IRC | 17:25 | |
| *** kkoski has joined #openstack-ironic | 17:26 | |
| *** Sukhdev has joined #openstack-ironic | 17:26 | |
| *** natorious is now known as zz_natorious | 17:30 | |
| *** jistr has quit IRC | 17:31 | |
| *** mgoddard has quit IRC | 17:32 | |
| *** Marga_ has quit IRC | 17:33 | |
| *** alexpilotti has quit IRC | 17:37 | |
| *** chlong-afk has quit IRC | 17:38 | |
| *** ijw has quit IRC | 17:38 | |
| *** PG has joined #openstack-ironic | 17:41 | |
| *** UForgotten has quit IRC | 17:42 | |
| *** UForgotten has joined #openstack-ironic | 17:42 | |
| *** alexpilotti has joined #openstack-ironic | 17:45 | |
| *** pas-ha has joined #openstack-ironic | 17:53 | |
| pas-ha | all, please approve this bot commit https://review.openstack.org/#/c/188640/2 - without it py27 gate on stable/kilo will be wedged due to new "mock==1.1" release | 17:54 |
| *** alexpilotti has quit IRC | 17:54 | |
| jroll | pas-ha: waiting for tests... | 17:55 |
| dtantsur | not many people can approve stable/kilo.. | 17:55 |
| pas-ha | jroll, yes, gate is super slow today :( | 17:55 |
| jroll | oh that's stable/kilo | 17:55 |
| jroll | devananda: ^ all you sir | 17:55 |
| pas-ha | dtantsur, well at least make a hype around that :) so those with super stable powers notice | 17:56 |
| dtantsur | yeah, thanks :) | 17:56 |
| openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: 3 second default for acknowledged/retried alerts https://review.openstack.org/201275 | 17:58 |
| lucasagomes | I will call it a day folks, have a great night everyone! | 18:00 |
| * dtantsur too | 18:00 | |
| NobodyCam | night lucasagomes | 18:00 |
| dtantsur | g'night! | 18:00 |
| * rameshg87 too | 18:00 | |
| NobodyCam | night dtantsur | 18:00 |
| *** rameshg87 has quit IRC | 18:00 | |
| *** lucasagomes is now known as lucas-dinner | 18:00 | |
| NobodyCam | night ram | 18:00 |
| *** dtantsur is now known as dtantsur|afk | 18:00 | |
| devananda | g'night folks! | 18:00 |
| openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: 3 second default for acknowledged/retried alerts https://review.openstack.org/201275 | 18:01 |
| lucas-dinner | devananda, btw the patch making the pxe_ipa job voting just got approved | 18:01 |
| lucas-dinner | in case you have added it to ur todo | 18:01 |
| lucas-dinner | and rloo mind updating https://review.openstack.org/#/c/201043/ if needed? | 18:02 |
| lucas-dinner | that would be good to fix the gate asap, so feel free to edit that patch | 18:02 |
| lucas-dinner | and that's it. Night all! | 18:02 |
| *** stendulker has quit IRC | 18:02 | |
| rloo | lucas-dinner: will do. | 18:03 |
| devananda | lucas-dinner: \o/ | 18:05 |
| openstackgerrit | Merged stackforge/pyghmi: Provide time data in alert decode https://review.openstack.org/201140 | 18:05 |
| NobodyCam | brb | 18:08 |
| *** lazy_prince has quit IRC | 18:10 | |
| *** pelix has quit IRC | 18:28 | |
| *** rwsu has quit IRC | 18:29 | |
| *** slagle_ has joined #openstack-ironic | 18:31 | |
| *** slagle has quit IRC | 18:33 | |
| *** shakamunyi has quit IRC | 18:36 | |
| *** marios has quit IRC | 18:40 | |
| *** trown|lunch is now known as trown | 18:42 | |
| devananda | poll email sent. why does everything take 30 minutes? | 18:42 |
| *** shakamunyi has joined #openstack-ironic | 18:47 | |
| NobodyCam | :) | 18:48 |
| jroll | heh | 18:50 |
| *** pas-ha has quit IRC | 18:51 | |
| *** ekarlso has quit IRC | 18:56 | |
| *** ekarlso has joined #openstack-ironic | 18:58 | |
| *** Sukhdev has quit IRC | 18:59 | |
| *** kkoski has quit IRC | 18:59 | |
| *** kkoski has joined #openstack-ironic | 18:59 | |
| *** e0ne has joined #openstack-ironic | 19:02 | |
| NobodyCam | JoshNang: just checking whats you confidence level of the zapping support landing? | 19:05 |
| jroll | I'm personally 100% sure it will land | 19:05 |
| jroll | just not sure when :) | 19:05 |
| *** zz_natorious is now known as natorious | 19:06 | |
| *** karimb has joined #openstack-ironic | 19:06 | |
| NobodyCam | jroll: :) | 19:06 |
| JoshNang | ^ pretty much that | 19:08 |
| *** e0ne is now known as e0ne_ | 19:08 | |
| JoshNang | i know ramesh has offered to help a bunch with the actual implementation | 19:08 |
| *** Marga_ has joined #openstack-ironic | 19:09 | |
| NobodyCam | :) Ty | 19:09 |
| *** karimb has quit IRC | 19:13 | |
| JoshNang | one bit in the zapping CLI: for the --zap-steps flag, i have it down we'll take either either a filename or '--' for stdin. nova's --userdata will take either a string or a filename, and i'm pretty sure i've seen that in other OS CLIs. i'd rather not support taking a string, since the arg has to be properly formatted JSON, but then we're different than other CLIs. thoughts? | 19:13 |
| jroll | typically stdin is - (single dash) | 19:14 |
| JoshNang | (https://review.openstack.org/#/c/185122/ for reference) | 19:14 |
| *** natorious is now known as zz_natorious | 19:15 | |
| JoshNang | jroll: ah true | 19:15 |
| lifeless | lucas-dinner: nope; you should pin to <1.1 for 2.6 | 19:19 |
| jroll | lifeless: we've got it sorted by now :) | 19:19 |
| *** persia has quit IRC | 19:21 | |
| *** e0ne_ is now known as e0ne | 19:22 | |
| *** persia has joined #openstack-ironic | 19:23 | |
| *** bnemec has joined #openstack-ironic | 19:24 | |
| *** Sukhdev has joined #openstack-ironic | 19:31 | |
| *** persia has quit IRC | 19:45 | |
| *** marzif_ has joined #openstack-ironic | 19:52 | |
| *** rwsu has joined #openstack-ironic | 19:55 | |
| *** kkoski has quit IRC | 19:59 | |
| *** e0ne is now known as e0ne_ | 20:04 | |
| *** e0ne_ is now known as e0ne | 20:04 | |
| *** kkoski has joined #openstack-ironic | 20:06 | |
| *** ijw has joined #openstack-ironic | 20:06 | |
| *** persia has joined #openstack-ironic | 20:07 | |
| *** persia has quit IRC | 20:07 | |
| *** persia has joined #openstack-ironic | 20:07 | |
| *** puranamr has quit IRC | 20:14 | |
| *** rwsu has quit IRC | 20:16 | |
| *** alex_xu has quit IRC | 20:18 | |
| *** lifeless has quit IRC | 20:20 | |
| *** alex_xu has joined #openstack-ironic | 20:21 | |
| *** lifeless has joined #openstack-ironic | 20:21 | |
| *** pas-ha has joined #openstack-ironic | 20:23 | |
| *** ijw has quit IRC | 20:27 | |
| *** dguerri` is now known as dguerri | 20:27 | |
| *** ijw has joined #openstack-ironic | 20:28 | |
| *** ijw has quit IRC | 20:28 | |
| *** rwsu has joined #openstack-ironic | 20:29 | |
| *** athomas has quit IRC | 20:32 | |
| *** ijw has joined #openstack-ironic | 20:32 | |
| *** athomas has joined #openstack-ironic | 20:33 | |
| *** PG has quit IRC | 20:37 | |
| *** jxiaobin has quit IRC | 20:38 | |
| *** Marga__ has joined #openstack-ironic | 20:44 | |
| *** Marga_ has quit IRC | 20:44 | |
| *** puranamr has joined #openstack-ironic | 20:47 | |
| *** Marga__ has quit IRC | 20:49 | |
| *** Marga_ has joined #openstack-ironic | 20:50 | |
| *** dguerri is now known as dguerri` | 21:00 | |
| *** karimb has joined #openstack-ironic | 21:02 | |
| *** kkoski has quit IRC | 21:02 | |
| *** Marga__ has joined #openstack-ironic | 21:05 | |
| *** puranamr has quit IRC | 21:07 | |
| *** Marga_ has quit IRC | 21:07 | |
| *** puranamr has joined #openstack-ironic | 21:08 | |
| *** absubram has quit IRC | 21:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/201338 | 21:10 |
| *** dprince has quit IRC | 21:15 | |
| *** jjohnson2 has quit IRC | 21:15 | |
| *** trown is now known as trown|outttypeww | 21:15 | |
| rloo | jroll: is it OK that AgentVendorInterface.reboot_to_instance() doesn't have a lock? https://review.openstack.org/#/c/200153/4/ironic/drivers/modules/agent.py | 21:21 |
| *** coolsvap has quit IRC | 21:28 | |
| *** karimb has quit IRC | 21:30 | |
| *** karimb has joined #openstack-ironic | 21:31 | |
| *** Sukhdev has quit IRC | 21:31 | |
| *** coolsvap|away has joined #openstack-ironic | 21:33 | |
| *** e0ne has quit IRC | 21:35 | |
| jroll | rloo: it's only called from heartbeat, which implicitly has a lock | 21:39 |
| rloo | jroll: ah, thx for explaining. | 21:41 |
| jroll | rloo: it could probably use a require_exclusive_lock or something, /shrug | 21:42 |
| rloo | jroll: or a comment as to why it doesn't have one. in case some future thing doesn't invoke it from heartbeat. | 21:42 |
| jroll | yeah | 21:43 |
| *** Sukhdev has joined #openstack-ironic | 21:44 | |
| *** Marga__ has quit IRC | 21:46 | |
| *** puranamr has quit IRC | 21:54 | |
| *** puranamr has joined #openstack-ironic | 21:59 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-specs: Implement Zapping States https://review.openstack.org/185122 | 22:02 |
| *** jcoufal has joined #openstack-ironic | 22:02 | |
| *** jcoufal_ has joined #openstack-ironic | 22:04 | |
| SpamapS | TheJulia: before I fall down this rabbit hole I'm looking into.. have you done anything looking toward using the ubuntu-minimal elements for Bifrost? | 22:05 |
| SpamapS | TheJulia: I'm about to do that to work around the crazy massive root problem, so just curious. | 22:06 |
| TheJulia | SpamapS: I've done basic testing, however glean failed at /etc/hosts missing | 22:06 |
| TheJulia | SpamapS: review, play with https://review.openstack.org/#/c/200834/ | 22:07 |
| SpamapS | TheJulia: saw that and +1'd I think. :) | 22:07 |
| SpamapS | TheJulia: I can also just workaround it by adding an element that disables root growing. | 22:07 |
| *** jcoufal has quit IRC | 22:07 | |
| TheJulia | yeah, greg beat me to that issue :) | 22:07 |
| TheJulia | SpamapS: you can do that! I've been spinning on what the right path would be for growing/not growing in an ideal world | 22:08 |
| TheJulia | and gpt/uefi, but I have lots going on right now() so it is just a background thread at the moment | 22:09 |
| SpamapS | TheJulia: well I've been thinking about how we might make it an LVM-root.. but thats long term. | 22:09 |
| TheJulia | Yeah, I don't really want to get into the business of building crazy images, but I want to make things easy, so I suspect its going to be add-ons to dib to help make people's lives easier | 22:11 |
| *** jcoufal_ has quit IRC | 22:15 | |
| *** pas-ha has quit IRC | 22:17 | |
| *** alexpilotti has joined #openstack-ironic | 22:20 | |
| openstackgerrit | Merged openstack/python-ironicclient: Fix unittests due mock 1.1.0 release https://review.openstack.org/201043 | 22:23 |
| *** bnemec has quit IRC | 22:28 | |
| *** pas-ha has joined #openstack-ironic | 22:30 | |
| *** bradjones has quit IRC | 22:33 | |
| openstackgerrit | Merged openstack/ironic: Use DEPLOYWAIT while waiting for agent to write image https://review.openstack.org/200153 | 22:41 |
| *** shakamunyi has quit IRC | 22:45 | |
| *** marzif_ has quit IRC | 22:50 | |
| *** rwsu has quit IRC | 22:52 | |
| *** ijw has quit IRC | 23:00 | |
| *** ijw has joined #openstack-ironic | 23:00 | |
| *** zz_natorious is now known as natorious | 23:05 | |
| *** cdearborn has quit IRC | 23:11 | |
| *** mgarza_ has quit IRC | 23:12 | |
| *** Marga_ has joined #openstack-ironic | 23:17 | |
| *** chlong-afk has joined #openstack-ironic | 23:18 | |
| *** mdbooth has quit IRC | 23:19 | |
| *** Marga_ has quit IRC | 23:21 | |
| *** mdbooth has joined #openstack-ironic | 23:25 | |
| *** natorious is now known as zz_natorious | 23:26 | |
| *** achanda has quit IRC | 23:31 | |
| *** achanda has joined #openstack-ironic | 23:32 | |
| *** lucas-dinner has quit IRC | 23:35 | |
| *** chlong-afk has quit IRC | 23:36 | |
| *** achanda has quit IRC | 23:36 | |
| *** Sukhdev has quit IRC | 23:44 | |
| *** zer0c00l has left #openstack-ironic | 23:48 | |
| *** achanda has joined #openstack-ironic | 23:49 | |
| *** zer0c00l has joined #openstack-ironic | 23:49 | |
| *** zer0c00l has quit IRC | 23:53 | |
| *** zer0c00l has joined #openstack-ironic | 23:53 | |
| *** bradjones has joined #openstack-ironic | 23:58 | |
| *** bradjones has quit IRC | 23:58 | |
| *** bradjones has joined #openstack-ironic | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!