Thursday, 2015-04-09

BadCuband on that delicious note.... I think I am gonna head off to dinner :)00:00
aweeksjroll: to be clear, in your comment on the rescue spec, you're suggesting that we allow people to include it in other drivers (by setting self.rescue=agent.AgentRescue())?00:01
*** BadCub is now known as BadCub_Hiding00:01
aweeksif so, that's already supported00:01
pshigeif you like Japanese food, the autumn summit is a good chance for you.00:04
pshigeBadCub00:04
jrollaweeks: yeah, I realize it's supported, just to point it out00:09
aweeksjroll: cool, will mention that00:09
*** igordcard_ has quit IRC00:15
openstackgerritAlex Weeks proposed openstack/ironic-specs: Add implement-rescue-mode spec  https://review.openstack.org/17187800:17
*** mtanino has quit IRC00:22
*** kkoski has joined #openstack-ironic00:22
*** jmank has quit IRC00:22
*** Sukhdev has quit IRC00:23
*** kkoski has quit IRC00:23
*** chlong has joined #openstack-ironic00:25
*** kkoski has joined #openstack-ironic00:25
*** kkoski has quit IRC00:25
*** naohirot has joined #openstack-ironic00:31
pshigemorning naorhirot00:41
*** saripurigopi has joined #openstack-ironic00:47
naohirotgood morning pshige :)00:55
pshigeHodogaya!01:05
*** jxiaobin has quit IRC01:12
*** lazy_prince has quit IRC01:13
*** killer_prince has joined #openstack-ironic01:14
*** killer_prince is now known as lazy_prince01:14
*** Marga_ has quit IRC01:19
*** Marga_ has joined #openstack-ironic01:20
*** mtanino has joined #openstack-ironic01:21
*** stendulker has joined #openstack-ironic01:23
SpamapSjroll: FYI, now we're getting this as a fail instead: http://logs.openstack.org/37/137737/6/check-tripleo/check-tripleo-ironic-overcloud-precise-ha/68fa430/logs/seed_logs/nova-compute.txt.gz#_Apr__9_00_39_2901:25
SpamapSjroll: perhaps it's actually this:  http://logs.openstack.org/37/137737/6/check-tripleo/check-tripleo-ironic-overcloud-precise-ha/68fa430/logs/seed_logs/ironic-api.txt.gz#_Apr__9_00_01_2701:26
*** Haomeng|2 has joined #openstack-ironic01:32
*** Haomeng has quit IRC01:34
mrdaBadCub: Just FYI (after reading scrollback), if you have stuff that you'd like worked on while you North Americans sleep, and it's a Monday->Thursday yourtime, feel free to ping me in channel with review numbers etc. and I'll pick up when I check in if at all possible (especially during release periods)01:39
*** chenglch has joined #openstack-ironic01:44
jrollSpamapS: that seems odd01:45
jrollthat request didn't even make it to the api01:45
jrollwhere is the failure in the ir-api log from? what made that request?01:46
*** stendulker has quit IRC01:46
jrolltimestamps don't match at all with n-cpu01:46
greghayneswe dont ntp in tripleo-ci IIRC01:52
jrollmmm.01:56
jrollyou should do that :P01:56
greghaynesI doubt anyone will disagree with that statement01:56
*** harlowja is now known as harlowja_away02:03
*** davideagnello has quit IRC02:04
*** lazy_prince has quit IRC02:06
*** saripurigopi has quit IRC02:14
*** meghal has quit IRC02:17
*** Marga_ has quit IRC02:26
*** Marga_ has joined #openstack-ironic02:26
*** Marga_ has quit IRC02:31
*** ramineni has joined #openstack-ironic02:41
openstackgerritTan Lin proposed openstack/ironic: Improve AMT driver doc  https://review.openstack.org/16960602:47
openstackgerritYuiko Takada proposed stackforge/ironic-discoverd: Add unit tests for main.py  https://review.openstack.org/17145402:48
openstackgerritShivanand Tendulker proposed openstack/ironic: Nit fixes for boot_mode being overwritten  https://review.openstack.org/17172202:56
openstackgerritZhai, Edwin proposed openstack/ironic: Take place of metrics with meters in option  https://review.openstack.org/17191502:58
*** alex_xu has quit IRC03:08
BadCub_Hidingmrda: You rock! Thank you :) I usually keep everything organized on an etherpad. Right now all the goodies we have going are on: https://etherpad.openstack.org/p/IronicReviewDay03:19
BadCub_Hidingyeah pshige ?03:19
*** rloo has quit IRC03:20
*** Haomeng has joined #openstack-ironic03:22
pshigeBadCub: yes03:23
*** Haomeng|2 has quit IRC03:25
*** chenglch|2 has joined #openstack-ironic03:33
*** chenglch has quit IRC03:35
*** naohirot has quit IRC03:35
*** achanda has quit IRC03:38
*** achanda has joined #openstack-ironic03:43
*** achanda has quit IRC03:45
*** davideagnello has joined #openstack-ironic03:53
*** foexle_ has joined #openstack-ironic03:55
*** davideagnello has quit IRC03:57
*** foexle has quit IRC03:58
*** coolsvap|afk is now known as coolsvap04:00
*** achanda has joined #openstack-ironic04:01
*** saripurigopi has joined #openstack-ironic04:01
*** naohirot has joined #openstack-ironic04:01
*** achanda has quit IRC04:03
*** spandhe has quit IRC04:11
*** saripurigopi has quit IRC04:21
*** achanda has joined #openstack-ironic04:23
*** Haomeng|2 has joined #openstack-ironic04:28
*** Haomeng has quit IRC04:31
*** raginbajin has quit IRC04:32
*** raginbajin has joined #openstack-ironic04:35
*** achanda has quit IRC04:36
*** achanda has joined #openstack-ironic04:48
*** spandhe has joined #openstack-ironic04:54
*** spandhe_ has joined #openstack-ironic04:57
*** spandhe has quit IRC04:59
*** spandhe_ is now known as spandhe04:59
*** spandhe has quit IRC05:09
*** chlong has quit IRC05:09
*** saripurigopi has joined #openstack-ironic05:12
*** spandhe has joined #openstack-ironic05:37
*** jcoufal has joined #openstack-ironic05:59
*** mtanino has quit IRC06:07
*** alex_xu has joined #openstack-ironic06:40
*** ramineni1 has joined #openstack-ironic06:42
*** yog__ has joined #openstack-ironic06:43
*** ramineni has quit IRC06:44
*** ramineni1 has quit IRC06:46
*** ramineni has joined #openstack-ironic06:46
*** alex_xu has quit IRC06:47
*** alex_xu has joined #openstack-ironic06:51
*** pas-ha has joined #openstack-ironic06:59
*** ukalifon1 has joined #openstack-ironic07:04
*** jistr has joined #openstack-ironic07:15
*** dtantsur|afk is now known as dtantsur07:17
dtantsurMorning Ironic!07:17
devanandag'morning!07:18
devanandadtantsur: https://review.openstack.org/#/c/171334/8 could use your eyes (and +2/+A)07:18
devanandaI can tag the client release once this lands07:18
devanandawhich should unbreak everyone07:18
dtantsursure thing, morning devananda :)07:19
dtantsurare you in Europe or just staying late?07:19
devanandajust up late07:19
devanandacouldn't sleep .... so ...07:19
*** pas-ha has quit IRC07:23
*** pas-ha has joined #openstack-ironic07:25
openstackgerritMichael Davies proposed openstack/python-ironicclient: Cache negotiated api microversion for this server  https://review.openstack.org/17194607:27
devanandamrda: ohhai, you're awake still too :)07:28
mrdahey devananda07:29
mrdait's only 5pm here07:30
mrdaIf you want to give me quick feedback on that review, I'd appreciate it.  Just want to know if this is the kind of approach you envisaged for version caching07:30
mrdadevananda: ^^^07:30
* devananda is already reading 07:31
*** achanda has quit IRC07:31
dtantsurdevananda, I still get "Not Accepted". looks like you have to fix SessionClient which is actually used07:32
devanandadtantsur: in what situation do you get that?07:34
dtantsurdevananda, running the client :) `env/bin/ironic --ironic-api-version 1.7 node-list`07:35
devanandawe dont have a 1.7 versoin ...07:35
dtantsurI remember folks patching both places when api versions were introduced07:35
devanandaso that error is correct07:35
devanandatry 1.6 :)07:36
dtantsurdevananda, 1.6 is supported on the server07:36
mrda;)07:36
devanandadtantsur: right. so you should get an error if you explicitly request a version that isn't supported07:36
dtantsurdevananda, I mean, then just abandon your patch, error is correct ;)07:36
*** rameshg87 has joined #openstack-ironic07:36
rameshg87hello ironic07:36
dtantsurdevananda, yeah, but your patch is supposed to provide a meaningful error? anyway, my client does not touch code path you introduce07:36
*** rameshg87 is now known as rameshg87-away07:36
dtantsurrameshg87-away, o/07:37
devanandadtantsur: I think you're missing the point of the patch. right now, the client does not work if you point it at stable/juno, or at any version of the server *before* 1.607:37
devanandaliterally all of our stable/juno test runs have failed because of this since monday morning07:37
*** achanda has joined #openstack-ironic07:37
dtantsurdevananda, yes, and it won't work, because your code path is not touched (at least in my env)07:38
devanandaand tripleo-ci is (was?) broken because they're using an ironic-api service from somewhere mid cycle, which supports up to 1.407:38
devanandadtantsur: that's quite odd. it works fine in my env. so how is your env resulting i na different code path?07:38
dtantsurdevananda, let's ask differently: why do we have both HttpClient and SessionClient doing the same thing differently?07:39
devanandadtantsur: I have no idea. can we delete one of them?07:39
dtantsurI suppose so. because right now I found out that for whatever reason SessionClient is used for me07:39
devanandaah, I see07:42
devanandaironicclient/v1/client.py:        self.http_client = http._construct_http_client(*args, **kwargs)07:43
* mrda wanders off for dinner07:44
dtantsurdevananda, yep and https://github.com/openstack/python-ironicclient/blob/master/ironicclient/common/http.py#L372-L39207:44
devanandaI love that it's calling a private method in another module -- I think we should spend a bunch of time in Liberty cleaning up the client ...07:44
devanandayea. so if there's a keystone session supplied, it will use the SessionClient07:44
dtantsurso our client has a code path for SessionClient, I suggest you update it too07:44
devanandawhereas i'm testing without that. good catch07:44
*** achanda has quit IRC07:48
*** oomichi has joined #openstack-ironic07:50
openstackgerritMerged stackforge/ironic-discoverd: Add unit tests for main.py  https://review.openstack.org/17145407:57
*** jamielennox is now known as jamielennox|away08:01
*** oomichi has quit IRC08:06
*** spandhe has quit IRC08:06
*** derekh has joined #openstack-ironic08:13
mrda.08:13
* mrda agrees that the client needs work08:13
devanandadtantsur: dont suppose you want to take a stab at the SessionClient class?08:20
dtantsurdevananda, depends on whether you want to :)08:22
devanandaI just tried refactoring the _negotiate_supported_version method to be reusable, and then realized HTTPClient and SessionClient have completely different response and connection objects08:22
devanandaso i'm scrapping that work :-/08:22
devanandafor now i think we just need to duplicate the function in both classes08:22
devanandaeg, in HTTPClient, we have: resp.getheader('Headername'), and in SessionClient, we have: resp.headers.get('headername')08:23
devanandait's called "resp" in both places, but it's actually a different class ...08:23
*** lucasagomes has joined #openstack-ironic08:24
devanandadtantsur: it's 1:30am now, think i'm going to sleep, so feel free to give this a go :)08:25
dtantsurdevananda, ah ok, I will try to finish it by your wake up :)08:25
dtantsurg'night08:25
devanandag'night!08:25
*** rameshg87-away is now known as rameshg8708:26
rameshg87lucasagomes: hello08:27
*** andreykurilin_ has joined #openstack-ironic08:27
lucasagomesrameshg87, hi there08:27
rameshg87lucasagomes: i was just reading through eavesdrop y'day08:27
lucasagomesdevananda, g'night08:27
rameshg87lucasagomes: has someone started looking at the backward-compat thing fix for localboot status change ?08:27
lucasagomesrameshg87, I think greghaynes from tripleo have did part of it08:28
*** pradipta has joined #openstack-ironic08:28
rameshg87lucasagomes: i read something like it should "hey i am new ramdisk, so i will work in the newer way of wait"08:28
rameshg87lucasagomes: i can pick up something if something is left08:28
lucasagomesrameshg87, right, yeah that was one idea I've idk if the best08:28
lucasagomesbut a new ramdisk could pass some info to the pass_deploy_info to indicate that it's a new ramdisk08:28
rameshg87lucasagomes: yeah, just read that part ..08:29
lucasagomesso that it doesn't try to wait for the callback if that signal is not apssed08:29
lucasagomesbut idk anyone working on that08:29
rameshg87lucasagomes: but one question08:29
rameshg87lucasagomes: localboot was introduced in kilo, right ?08:29
* lucasagomes still have to catch up with what happen after I went to sleep08:29
lucasagomesrameshg87, yes08:29
rameshg87lucasagomes: and we haven't released yet08:29
lucasagomesrameshg87, right, yeah08:29
rameshg87lucasagomes: so does backward-compat really come into picture ?08:29
rameshg87lucasagomes: i mean are we trying to give backward compatibility for some unreleased code ?08:30
openstackgerritShivanand Tendulker proposed openstack/ironic: Nit fixes for boot_mode being overwritten  https://review.openstack.org/17172208:30
rameshg87lucasagomes: sure that it went in in k308:30
lucasagomesrameshg87, well when possible I would say yes, not everyone cares about the release08:30
lucasagomesI mean rax for example uses master Ironic08:30
rameshg87lucasagomes: hmm..yeah..i guessed08:30
lucasagomesif we can back backward compatibility on every merge instead of release I think it's good08:30
lucasagomeswe certainly should try to do the best thing08:31
rameshg87lucasagomes: okay, so backward-compat on every merge is important, is it ?08:31
lucasagomesIMO yes08:31
rameshg87lucasagomes: okay..that would be the most ideal for everyone08:31
mrdaoh wow, it's possible for me to overlap with lucasagomes now that the TZ has shifted due to DST :)08:31
lucasagomesmrda, hey buddy!08:31
*** athomas has joined #openstack-ironic08:31
rameshg87mrda: dst is applicable for you ?08:32
lucasagomesmrda, how r u?08:32
* rameshg87 checks08:32
* lucasagomes is now UTC +108:32
* rameshg87 is always UTC + 5.30 :)08:32
lucasagomes:-)08:33
mrdaHmmm, I think I've at +9.5 now08:34
mrdaI'm08:34
* mrda has just finished summer, and is heading for winter and long nights08:36
*** rpodolyaka1 has quit IRC08:41
*** rwsu has quit IRC08:41
tiagogomes_does anyone knows if Ironic needs parted with device-mapper support?08:42
*** stendulker has joined #openstack-ironic08:42
* mrda wanders off for good now, kids time08:44
lucasagomestiagogomes_, I don't think we need device-mapper support08:45
lucasagomeswe are doing basic partition using MBR08:45
tiagogomes_lucasagomes ok, ta08:45
*** saripurigopi has quit IRC08:45
lucasagomesnot using lvm or any base block logical devices08:45
lucasagomesnp08:45
*** ndipanov has joined #openstack-ironic08:46
*** edcragg has joined #openstack-ironic08:53
*** dtantsur is now known as dtantsur|brb08:58
lucasagomeswas the RC1 cut yesterday?09:09
*** pcaruana has joined #openstack-ironic09:17
*** coolsvap is now known as coolsvap|afk09:18
*** richard_maw has quit IRC09:22
*** coolsvap|afk is now known as coolsvap09:24
*** richard_maw has joined #openstack-ironic09:28
*** lynxman has quit IRC09:43
*** lynxman has joined #openstack-ironic09:44
*** rbogorodskiy has quit IRC09:44
*** dtantsur|brb is now known as dtantsur09:52
dtantsurno idea :)09:53
*** pelix has joined #openstack-ironic09:55
*** naohirot has quit IRC09:55
lucasagomeshttps://review.openstack.org/#/c/171759/ is now open for reviews09:56
*** saripurigopi has joined #openstack-ironic09:57
*** kalpase has joined #openstack-ironic10:00
*** jcoufal has quit IRC10:04
*** saripurigopi has quit IRC10:05
*** coolsvap is now known as coolsvap|afk10:06
*** saripurigopi has joined #openstack-ironic10:10
*** jcoufal has joined #openstack-ironic10:29
*** jcoufal has quit IRC10:36
*** jamielennox|away is now known as jamielennox10:42
*** kalpase has quit IRC10:52
*** kalpase has joined #openstack-ironic10:53
tiagogomes_hey, I got the following error "Error: The location 10241 is outside of the device /dev/sdc.\n'" after Ironic mounted the disk using iSCSI. Any ideas?10:57
dtantsurtiagogomes_, IIRC there was a problem with partitioner; tl;dr is that you should request root_gb a bit less than your actual hard drive10:58
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary  https://review.openstack.org/17133410:59
tiagogomes_dtantsur, will try, ta11:00
*** ramineni has quit IRC11:05
tiagogomes_dtantsur, it continued to fail. My actual drive is 8GB, my root_gb is 7GB11:05
* rameshg87 goes home 11:16
*** rameshg87 has quit IRC11:16
*** subscope has quit IRC11:17
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary  https://review.openstack.org/17133411:19
*** subscope has joined #openstack-ironic11:20
*** andreykurilin_ has quit IRC11:20
*** chenglch has joined #openstack-ironic11:21
*** chenglch|2 has quit IRC11:24
*** chenglch has quit IRC11:25
*** lucasagomes is now known as lucas-hungry11:27
*** kbs has quit IRC11:33
*** stendulker has quit IRC11:44
*** lucas-hungry is now known as lucasagomes11:48
lucasagomestiagogomes_, I think that's the GiB vs GB thing11:49
lucasagomes8 GB == 7.45058 GiB11:49
lucasagomes7 GiB == 7.51619 GB11:50
lucasagomesIronic uses GiB as the unit size11:50
*** Haomeng has joined #openstack-ironic11:51
* lucasagomes checks11:51
tiagogomes_lucasagomes, I already sorted out, after all my hard drive was less than 8BG11:52
tiagogomes_Gb11:53
*** Haomeng|2 has quit IRC11:53
*** jamielennox is now known as jamielennox|away11:53
lucasagomestiagogomes_, yeah11:53
lucasagomesok11:53
lucasagomessomeone have seem lintan around?11:54
*** pradipta has quit IRC11:57
tiagogomes_mm, I used disk image for creating a ubuntu image to deploy with ironic. Anyone knows the login credentials?12:05
*** dprince has joined #openstack-ironic12:07
dtantsurtiagogomes_, no idea. I suppose you should have used keypair instead12:08
dtantsurtiagogomes_, see middle part of http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack for details12:09
dtantsurlucasagomes, hey, could you review https://review.openstack.org/#/c/171211/ ? Imre is still out and I'd like to start pointing people at the "Troubleshooting" section12:10
TheJuliatiagogomes_: I think you have to use a dib element like stackuser or provide it a configdrive12:11
tiagogomes_mm, I am not using nova12:11
dtantsurthen ++ for stackuser, I guess...12:11
lucasagomesdtantsur, oh I will check it out, sorry i siad i would do it yesterday but I got busy into something12:11
lucasagomes1 sec will check it12:11
TheJuliatiagogomes_: or... create your own dib element to burn in whatever you want :)12:11
dtantsurlucasagomes, np, take your time :)12:11
dtantsurTheJulia, ... because bash scripting is the best of fun!12:12
dtantsur:D12:12
lucasagomestiagogomes_, no idea if it does create any user, I think there's a "stack" element that creates a stack user in the image12:12
dtantsurTheJulia, morning also :)12:12
* lucasagomes vaguely remembers that, not sure if it does exist anymore12:12
dtantsurtiagogomes_, lucasagomes, https://github.com/openstack/tripleo-image-elements/tree/master/elements/stackuser12:13
dtantsurnote that it's in tripleo-image-elements, not DIB itself12:13
*** ukalifon1 has quit IRC12:14
*** mtanino has joined #openstack-ironic12:18
*** kbs has joined #openstack-ironic12:19
tiagogomes_so I need to rebuild the image12:23
lucasagomestiagogomes_, yeah, well what you can do is mount the image in a loop device12:23
lucasagomeschroot in it and create the user12:23
lucasagomesor inject a key etc12:24
tiagogomes_ok12:24
tiagogomes_I used the ssh_pxe driver, but the boot order is still pxe first12:25
tiagogomes_shouldn't be local disk first?12:25
*** Haomeng|2 has joined #openstack-ironic12:27
*** Haomeng has quit IRC12:30
*** ramineni has joined #openstack-ironic12:37
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Add support for 'baremetal show' command  https://review.openstack.org/17173912:38
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Introduce openstackclient plugin  https://review.openstack.org/17167212:38
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implement the rest of the args for baremetal list  https://review.openstack.org/17169912:38
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implement baremetal delete command  https://review.openstack.org/17175112:38
openstackgerritJulia Kreger proposed openstack/ironic: Follow-up to "Add retry logic to _exec_ipmitool"  https://review.openstack.org/17177112:56
openstackgerritVictor Sergeyev proposed openstack/ironic: Cleanup DHCPFactory._dhcp_provider after tests  https://review.openstack.org/17203612:56
*** athomas has quit IRC12:57
*** mtanino has quit IRC13:01
*** rameshg87 has joined #openstack-ironic13:02
*** athomas has joined #openstack-ironic13:04
*** romcheg has joined #openstack-ironic13:06
*** lifeless has quit IRC13:07
*** trown|outttypeww is now known as trown13:07
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Add support for 'baremetal show' command  https://review.openstack.org/17173913:09
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Introduce openstackclient plugin  https://review.openstack.org/17167213:09
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implement the rest of the args for baremetal list  https://review.openstack.org/17169913:09
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implement baremetal delete command  https://review.openstack.org/17175113:09
* lucasagomes submits his first patch to neutron https://review.openstack.org/17204013:12
pshigeLucasagomes: cool !13:15
lucasagomes3 LOC :-)13:15
*** romcheg has quit IRC13:16
*** rloo has joined #openstack-ironic13:16
*** romcheg has joined #openstack-ironic13:19
openstackgerritVictor Sergeyev proposed openstack/ironic: Stop eventlet.greenthread.sleep mock patch  https://review.openstack.org/17204713:21
pshige1 LOC is enough to get power! :-)13:22
openstackgerritVictor Sergeyev proposed openstack/ironic: Cleanup DHCPFactory._dhcp_provider after tests  https://review.openstack.org/17203613:25
tiagogomes_I am seeing Calling http://192.168.199.12/latest/meta-data/instance-id failed: bad status code13:30
tiagogomes_what does this means?13:30
openstackgerritDmitry Tantsur proposed stackforge/ironic-discoverd: Delay failure from pre-processing hooks  https://review.openstack.org/17205113:32
tiagogomes_this is when the deployed image boots (I think)13:32
dtantsurI believe it's os-cloud-config trying to reach out to the metadata server (which you might or might not have), but I'm not aware of the details13:39
jrollmorning everyone :)13:39
jrollrameshg87: lucasagomes dtantsur this is the localboot / whole disk image fix: https://review.openstack.org/#/c/171767/13:40
jrolls/fix/hack/13:40
dtantsurjroll, morning13:40
dtantsuroh I like the s/fix/hack/ part :D13:40
jrollit is a hack :)13:42
rameshg87jroll: hey morning13:42
tiagogomes_I already asked this but the provision_state of the node which I deployed is 'on'. But the VM (I am using pxe_ssh driver) is still configure to boot from PXE13:42
dtantsuroh yeah, it looks like a hack... I suppose it should work though :)13:42
rameshg87morning everyone :)13:42
tiagogomes_Is this normal or something failed? Does the deployed image always needs a PXE server?13:43
rameshg87lucasagomes: did shoot this down first ? lucasagomes https://review.openstack.org/#/c/171767/3/ironic/drivers/modules/iscsi_deploy.py ?? :)13:43
dtantsurrameshg87, morning. it's funny that I say good morning to you both in my morning and in my evening :D13:43
tiagogomes_sorry, provision_state is 'active'13:43
rameshg87dtantsur: yeah it is :) good evening btw13:43
dtantsurgood afternoon rather... you don't sleep a lot, do you? :)13:44
*** saripurigopi has quit IRC13:44
jrolldtantsur: I tested it in devstack so it should work amirite13:44
tiagogomes_If I set it to boot from the hard disk, it doesn't boot :(13:44
jrolltiagogomes_: yes, the pxe driver boots the instance from pxe13:45
tiagogomes_jroll even after the deployment been made?13:45
jrollyes13:45
jrolltiagogomes_: there's a way to set the node up to boot from disk, I forget offhand what it is13:45
jrolllucasagomes: ^ ?'13:45
tiagogomes_so it retrieves the kernel and initramfs using tftp, but uses the local disk as rootfs?13:46
NobodyCamgood morning Ironic13:46
dtantsurNobodyCam, morning13:46
NobodyCammorning dtantsur :)13:46
jrolltiagogomes_: correct13:46
jrolltiagogomes_: there's a localboot option that can be set, but it must be set before deploy13:46
NobodyCammorning jroll and tiagogomes_13:46
jrollheya NobodyCam :)13:47
NobodyCam:)13:47
tiagogomes_morning NobodyCam13:47
NobodyCam:)13:48
openstackgerritVictor Sergeyev proposed openstack/ironic: Use mock patch decorator for eventlet.greenthread.sleep  https://review.openstack.org/17204713:48
*** jcoufal has joined #openstack-ironic13:48
rameshg87jroll: +2 with me :)13:49
tiagogomes_jroll ok, ta13:49
jrollwoot13:49
rameshg87dtantsur: it's like 7pm here13:49
jrollnp tiagogomes_ :)13:49
rameshg87dtantsur: what's your timezone ?13:49
dtantsurrameshg87, UTC+2 (with DST)13:49
dtantsurusually UTC+113:49
rameshg87okay13:50
rameshg87dtantsur: so our timezones are actually more closer13:50
NobodyCammorning rameshg87 :)13:50
rameshg87we don't have dst and i am always utc + 5.30 :)13:50
rameshg87morning NobodyCam13:50
dtantsurrameshg87, oh not having DST is awesome!13:50
rameshg87yeah more closer to the equator :)13:52
*** kkoski has joined #openstack-ironic13:52
*** openstackgerrit has quit IRC13:53
*** openstackgerrit has joined #openstack-ironic13:53
rameshg87jroll: i saw on irc yesterday13:53
rameshg87jroll: that we were discussing about the backward-compat thing on the localboot status report thing13:54
TheJuliaquick question if anyone knows without me having to dig into the api code, when in maintenance mode, is an api client prohibited from making changes to endpoints?13:54
rameshg87jroll: we wanted ramdisk to say to ironic that "i am a newer ramdisk and hence treat me like a newer ramdisk" kind of fix13:55
rameshg87jroll: are we planning to do that ?13:55
jrollTheJulia: do you mean making changes to the node? node-update etc should work, state transitions probably not13:55
rameshg87jroll: or rather are you planning ? :)13:55
jrollrameshg87: yes... /me finds patch13:55
*** rameshg87 is now known as rameshg87-brb13:56
jrollrameshg87-brb: https://review.openstack.org/#/c/171743/13:57
* lucasagomes reads13:57
* lucasagomes was afk13:57
*** ramineni has quit IRC13:57
TheJuliajroll: okay, that is what I was thinking, thanks!13:57
TheJuliathinking/hoping13:57
jrollTheJulia: np :)13:58
lucasagomesrameshg87-brb, you mean to give that a shoot?13:58
lucasagomestiagogomes_, http://docs.openstack.org/developer/ironic/deploy/install-guide.html#local-boot-with-partition-images14:00
lucasagomesthere's an explanation about how to do with and without nova there14:01
lucasagomesI think ur using it without nova right?14:01
tiagogomes_lucasagomes, yes, without nova, but with Ironic stable/juno14:04
lucasagomestiagogomes_, oh... local boot was introduced in K14:04
*** jerryz has joined #openstack-ironic14:04
NobodyCammornign lucasagomes and TheJulia14:04
lucasagomesI think in Juno, if u want to have local boot you may need to use the agent driver14:04
lucasagomesjroll, ^14:04
tiagogomes_lucasagomes no worries, I just wanted to be sure that the deployment succeed :)14:05
lucasagomestiagogomes_, with the agent driver you can deploy a full disk image which contains a bootloader14:05
*** BadCub_Hiding is now known as BadCub14:06
TheJuliaNobodyCam: good morning14:06
*** rameshg87-brb is now known as rameshg8714:06
BadCubMorning Folks14:06
NobodyCammorning BadCub :)14:06
NobodyCamTheJulia: :)14:06
rameshg87lucasagomes: initially you were against it no ? but may be we can fix it later, what do you think about that ?14:06
rameshg87jroll: actually i was assuming backward-compat was broken other way round also14:08
rameshg87jroll: if someone was using older dib and newer ironic14:08
rameshg87jroll: right now https://review.openstack.org/#/c/171743/2 solves issue with newer ramdisk and older ironic14:09
*** mtanino has joined #openstack-ironic14:09
rameshg87jroll: but what if they had older ramdisk and newer ironic ? the problem there is ironic will goto wait-call-back expecting ramdisk will post back, but it will never do.  do we want to fix that ?14:10
*** romcheg has left #openstack-ironic14:11
BadCubjroll: looks like we are almost approved on ^ Just needs a +A :p14:11
*** romcheg has joined #openstack-ironic14:11
*** rameshg871 has joined #openstack-ironic14:11
lucasagomesrameshg87, right. We could solve it 2 ways... or pass both boot_option and is_whole_disk_image info via kernel cmdline14:14
*** rameshg87 has quit IRC14:14
lucasagomesto the ramdisk14:14
lucasagomesor fool it saying it's netboot so it doesn't try to install the bootloader14:14
jrolllucasagomes: you are correct14:14
openstackgerritSteve Martinelli proposed openstack/python-ironicclient: Upgrade hacking to latest release  https://review.openstack.org/17207214:15
lucasagomesproblem with the former is that it will depend on some change in DIB14:15
lucasagomesand the second doesn't14:15
jroll(with the juno thing)14:15
lucasagomesjroll, cool thanks14:15
jrollrameshg871: lucasagomes, right my patch does the latter14:15
*** ramineni has joined #openstack-ironic14:15
rameshg871jroll: okay14:16
*** saripurigopi has joined #openstack-ironic14:16
*** pcaruana has quit IRC14:17
*** lifeless has joined #openstack-ironic14:18
*** rameshg871 is now known as rameshg8714:20
lucasagomesrameshg87, have you tested jroll's patch?14:21
openstackgerritDmitry Tantsur proposed stackforge/ironic-discoverd: README: Troubleshooting: mention DHCP logs and tcpdump  https://review.openstack.org/17207714:21
jrollI ran it in devstack, if that helps14:22
jrollbut not entirely sure I did it right14:22
jrollI managed to boot a whole disk image with pxe_ssh driver14:22
jroll¯\_(ツ)_/¯14:22
rameshg87lucasagomes: no i didn't.  i can try it once if you are not planning ...14:23
dtantsurfolks, review and testing is highly requested for https://review.openstack.org/#/c/171334/ that will allow us to stop breaking people once released :)14:24
lucasagomesrameshg87, if u can that will help, my env is a bit messed :-(14:24
* lucasagomes was dealing with some neutron ipxe problems14:25
* lucasagomes will rebuild it14:25
jrollcan we kill DIB support yet14:25
*** jcoufal has quit IRC14:26
rameshg87lucasagomes: yeah i will14:26
lucasagomesjroll, heh that's the plan :-)14:27
lucasagomesI mean not DIB14:27
lucasagomesbut the bash ramdisk14:27
rameshg87lucasagomes: will update in half an hour14:27
lucasagomesthanks rameshg8714:27
NobodyCamanyone seen this error before? http://logs.openstack.org/34/171334/10/check/gate-tempest-dsvm-neutron-src-python-ironicclient/be18c2e/console.html#_2015-04-09_13_15_17_71314:27
*** jcoufal has joined #openstack-ironic14:27
jrolllucasagomes: well yeah, bash ramdisk14:27
jrollNobodyCam: looks like the job timed out14:28
lucasagomesNobodyCam, nop :/14:28
NobodyCamthat the slow node thing?14:28
*** jcoufal has quit IRC14:29
lucasagomesI think the slow thing is https://review.openstack.org/#/c/171313/14:29
lucasagomesjroll, NobodyCam rameshg87 when you guys have a time mind taking a look at https://review.openstack.org/#/c/171759/14:30
jrollNobodyCam: no, the slowness thing times out during devstack setup thing... it isn't about slow gate nodes, it's about slow devstack14:30
rameshg87lucasagomes: ack..14:30
jrolllucasagomes: why do we need backwards compat?14:31
BadCubwe have 3 +2s on https://review.openstack.org/#/c/171767/ someone want to slap a +A on it?14:31
lucasagomesjroll, cause iPXE landed in juno14:31
lucasagomesjroll, and the boot.ipxe is static, so if they have it working with their juno version14:31
lucasagomeslooking at hexraw, we should not break it14:31
jrolloh I see14:31
NobodyCamoh wait this isn't even ironic nova appears to be using nova.virt.libvirt.driver14:31
lucasagomesnew nodes should still be able to be managed by the old boot.ipxe script14:32
rameshg87BadCub: jroll: do you folks want to wait for half an hour for https://review.openstack.org/#/c/171767/ ?14:32
jrolllucasagomes: right, didn't realize boot.ipxe wouldn't get laid down again14:32
rameshg87BadCub: jroll: i am just trying it out14:32
*** achanda has joined #openstack-ironic14:32
jrollrameshg87: I don't care as long as it makes rc114:32
BadCubjroll: ++ on ^14:33
BadCubwe gots a nice little list of stuff we need to get landed for rc1 now. :-) Good thing is nothing left on the to-do list14:34
lucasagomesBadCub, :-) good morning14:34
BadCublucasagomes: morning bud :-)14:35
BadCubrameshg87: yeah, I am good with waiting a few :-)14:37
*** achanda has quit IRC14:41
* BadCub needs more coffee14:41
*** ramineni1 has joined #openstack-ironic14:43
jrolllucasagomes: I'm still not sure I get this hexraw compat thing, does this patch change what is sent to neutron?14:43
openstackgerritDmitry Tantsur proposed stackforge/ironic-discoverd: Doublecheck node provision state on receiving data from ramdisk  https://review.openstack.org/17209414:43
lucasagomesjroll, no14:44
lucasagomesjroll, so for neutron we give a URL pointing to the boot.ipxe script14:44
lucasagomesin the ipxe script we expand some variables like ${mac} for the macaddress14:44
*** ramineni has quit IRC14:44
lucasagomesin order to avoid having a file names with ':' we were using ${mac:hexraw} so it would format the mac to remove the delimiters14:45
lucasagomeslike 11223344556614:45
lucasagomesbut hexraw is not a supported type on older versions of ipxe14:45
lucasagomeswhere hexhyp is, which format the mac to have a '-' delimiter14:45
lucasagomes11-22-33-44-5514:45
jrollsure14:45
jrollbut doesn't boot.ipxe get generated for every deploy?14:45
lucasagomesso I just changed the type, and I create the PXE config file with a '-' now14:46
* lucasagomes checks, I thought we copied it only once (in case it was not in the http root dir already)14:46
jrolllucasagomes: it's per-node, though14:47
jrollright?14:47
lucasagomesyes14:47
lucasagomesit's per node14:47
jrollso any old nodes, the file will be left alone14:47
*** ramineni has joined #openstack-ironic14:47
jrollany new ones it will be hexhyp style14:47
rameshg87shall we +A https://review.openstack.org/#/c/171767/ ?14:47
jrollrameshg87: does it work? :)14:47
lucasagomesjroll, oh :-( apparently we copy it everytime prepare() is called14:47
*** jerryz has quit IRC14:48
lucasagomeshttps://github.com/openstack/ironic/blob/a45d4797d2246e31c482f3e1713c883d86807f02/ironic/drivers/modules/pxe.py#L443-L44514:48
jrolllucasagomes: right, because it's per node14:48
lucasagomeshmmmmm14:48
lucasagomesyeah14:48
lucasagomeswonders if we need some other way to do it14:48
jrollso I don't think we need the backwards compat14:48
rameshg87jroll: yeah works for me :)14:48
lucasagomesperhaps should we just go and change the type14:48
lucasagomesyea14:48
jrollit's straightforward to test if it works, though it isn't clear to me what action would break it14:48
lucasagomesjroll, I will put a new patch-set up14:48
lucasagomesyeah it seems correct14:49
jrollawesome14:49
* jroll leaves a review so he remembers to come back14:49
lucasagomesjroll, I was wondering like. A node has X nodes deployed and an old boot.ipxe14:49
lucasagomesjroll, oh sorry14:49
lucasagomesit's not per node14:49
lucasagomesit's one per conductor14:49
lucasagomesjroll, we use the same script for all nodes14:49
*** ramineni1 has quit IRC14:49
jrolloh?14:50
lucasagomes1 per conductor14:50
jrollwait when does the mac get in there then?14:50
lucasagomesjroll, the mac is a link to the specific configuration of that node14:50
lucasagomesand the boot.ipxe uses the mac address to chainload from boot.ipxe to the specific configuration14:51
jrollOH14:51
jrollwait... when does the mac get there though?14:51
jrollif it's one per conductor14:51
jrollwhen is it expanded?14:51
lucasagomesso the request comes from boot.ipxe, the mac get expanded and it chainloads into the specific mac configuration14:51
BadCubbrb14:51
lucasagomesiPXE expand the ${mac} var14:51
jrollaha14:51
lucasagomesthe mac get's there when the node is deployed14:52
jroll+A then14:52
lucasagomeshttps://github.com/openstack/ironic/blob/a45d4797d2246e31c482f3e1713c883d86807f02/ironic/drivers/modules/pxe.py#L17214:52
lucasagomesjroll, I want to change it all making it dynamic14:52
lucasagomesbut only in L :/14:52
jrollyeah14:53
lucasagomesso instead of passing the boot.ipxe script, ipxe do a GET on a endpoint in the ironic api passing the mac14:53
lucasagomesand we just returns whatever the node has to boot14:53
*** jcoufal has joined #openstack-ironic14:54
jrollright14:54
jrolllucasagomes: I've also thought about making agent config dynamic that way14:55
jrollcloud-config can come from a URL14:55
lucasagomesthat would be awesome14:55
lucasagomesthere's some problem with wsme right now doing that14:55
lucasagomesI have a patch up but few reviews :-( (no cores)14:55
jrollso you don't have to rebuild the container to re-configure it14:55
jrollyeah14:55
jrollthough I don't know if this needs to be an attachment14:55
lucasagomesbut u need a raw answer no?14:55
lucasagomeslike not serialized14:56
jrolloh, right14:56
lucasagomesif you want to return type text with wsme14:56
jrollidk, maybe it can handle json?14:56
lucasagomesit will do like "string"14:56
jrollyeah, I remember your patch14:56
lucasagomesright, idk about cloud-config14:56
lucasagomesipxe can't14:56
lucasagomesAFAIK14:56
jrolldoesn't look like it14:57
lucasagomesyeah it expects a ipxe script to be server, like a static file14:57
lucasagomesserved*14:57
lucasagomesanyway I will investigate more in L14:57
jrollyeah, cloud-config expects yaml, so I think we'll need the raw response thing14:58
lucasagomesjroll, well you can create a yaml custom type for wsme I suspect14:58
lucasagomesand return that14:58
lucasagomestho it's a bit odd from our api pov14:58
lucasagomesit's a json api14:58
jrollmeh, it needs "#cloud-config" in the header etc14:59
jrollnot worth it14:59
lucasagomesoh14:59
lucasagomesyeah :/14:59
lucasagomesjroll, if that makes u happy I found a way to do it without that patch14:59
lucasagomesbut it's a bit hacky14:59
jrolllucasagomes: I don't have time to work on it any time soon :)14:59
lucasagomeswe have to edit the func._wsme_definition object14:59
lucasagomesfunc._wsme_definition.return_type = None for e.g15:00
lucasagomesyeah15:00
jrollyeah15:00
*** romcheg has quit IRC15:01
JayFdtantsur: put a comment on the open specs for liberty -115:02
*** achanda has joined #openstack-ironic15:02
JayFdtantsur: ^ if you'll look at it and respond that'd be awesome; I'm out today but will check back if there's a change needed there15:03
dtantsurJayF, IIRC putting specs to backlog is what we planned back then when we introduced specs.15:03
JayFdtantsur: a backlog spec is a specific thing that doesn't include implementation details15:04
JayFand those likely can change across releases anyway15:04
dtantsurnot necessary IMO15:04
jrollI mean, if we approved them, they are clearly something we want to do15:04
jrollwhether it has implementation details or not15:04
JayFI mean, I think it waters down the idea of the backlog15:04
JayFif it also becomes the spec graveyard15:04
dtantsurin some sense it already is15:05
jroll"shit we want to do but don't have time"15:05
dtantsurif people just put it there and forget about them15:05
JayFimo putting them in a separate place makes sense, and I'd hope that dir dies from attrition15:05
JayFbecause everyone pulls their k spec out and ports it to l15:05
JayFso we can do it for l15:05
jrollI think that applies to both the "true" backlog and unimplemented approved specs15:05
jrollsure15:05
jrollpeople can pull them out of the backlog15:05
dtantsurthat's the same as for backlog: we hope that they will be implemented15:05
JayFjroll: except we actually unit test and validate fields and such on the backlog15:05
JayFjroll: and that doesn't include anythign but the first two basic headlines15:06
*** jcoufal has quit IRC15:06
jrollI guess I don't have a strong opinion either way; I tend to agree with dtantsur15:06
jrollJayF: we fail tests for extra headers in the backlog?15:06
dtantsurI'd also wait for devananda to weigh in15:06
JayFdtantsur: backlog is "this is a good idea that we haven't fully hashed out yet". kilo-archive is "We wanted to do this but didn't succeed for $reasons"15:06
jrollJayF: you made that distinction in this patch15:07
jrollI disagree with that distinction.15:07
* rameshg87 calls it a day 15:07
JayFdtantsur: I'll clearly go along with whatever devananda thinks, but I don't think kilo specs should be lumped in15:07
rameshg87good night folks15:07
dtantsurfor me difference is vague actually. things in backlog are "We wanted to do this but didn't propose it fully for $reasons"15:07
rameshg87see you tomorrow15:07
BadCubg'night rameshg8715:07
dtantsurrameshg87, cu15:07
jrollnight rameshg87 :)15:07
NobodyCamnight rameshg8715:07
*** rameshg87 has quit IRC15:07
JayFjroll: to clarify; devananda made the distinction in IRC and I reflected it at his request in the doc :)15:07
jroll-.-15:07
JayFjroll: I had all kilo specs together before he asked me to put them somewhere else15:07
JayF*shrug*15:08
jrolldevananda should put those things on reviews so other people know what happened15:08
dtantsur++15:08
JayFI don't think this is something we'll hash out by talking though. If some executive decision is made on IRC; please put it in the review and I'll keep an eye out15:08
jrollJayF: to be clear, did he make the backlog/kilo-archive distinction, or the implemented/not-implemented distinction15:08
JayFjroll: ^ drop me a text if that patch ends up needing a change before it can land15:08
jrollJayF: or I can just fix it :)15:08
jrollgo play15:09
JayFjroll: or do that; but I'm willing to as well. I opened the pandora's box :P15:09
* JayF &15:09
*** achanda has quit IRC15:11
*** jistr is now known as jistr|mtg15:15
* BadCub reads scroll back15:15
BadCubwhat is it everyone wants to see on ^^?15:19
*** kozhukalov has joined #openstack-ironic15:20
NobodyCamanyone encountered this iscsi error before... I haven't seem it but wanted to see if others have: http://paste.openstack.org/show/ae4lRKaJWtLVhO5CQaI3/15:23
*** romcheg has joined #openstack-ironic15:25
BadCubdtantsur: jroll in regard to the archive. From what I interpret, the desire is to consolidate "backlog" and "kilo-archive" into a single unit?15:26
dtantsuryep15:27
jrollBadCub: yes15:27
*** jistr|mtg is now known as jistr15:27
BadCubreading through I see the logic there. I am good with that process myself as well.15:27
jrollBadCub: yeah, I'd like devananda to weigh in, I'm happy to update it if need be (jay is OOO today)15:28
* jroll bbiaf15:28
BadCubdevananda: is on vacation, so I doubt he is going to be around15:28
NobodyCamjroll: LOL JayF's doing tripleo things today15:29
* NobodyCam *ducks*15:29
NobodyCamhummm. my on;y concern would be that spec in backlog may not have gone thru a complete review process15:32
NobodyCamwhile archived specs have actually landed in kilo15:32
BadCubNobodyCam: good point15:32
jrollNobodyCam: lol15:34
NobodyCam:-p15:35
jrollNobodyCam: they need re-review anyway, at least to be moved to L15:35
BadCubSo we only have 2 specs in backlog. One of them is already approved and one is drafting15:35
BadCubhttps://blueprints.launchpad.net/ironic/+spec/exposing-hardware-capabilities is already listed on the pad for the Spec Cores and will most likely be in L. So that leaves one15:36
BadCubSo my question here is two part: With the amount of specs in said folder, why would it be confusing or detrimental to to keep the two-folder distinction at this time, and if there is a true benefit to consolidating the folders why not just do it? We are not talking about a huge amount of specs here.15:40
*** jistr has quit IRC15:40
NobodyCamreding the Driver Capabilities spec it makes sense to me.. but I don't yet have my spec reviewer hat on.15:40
jrollBadCub: I care this much |__|15:41
*** kalpase has left #openstack-ironic15:41
NobodyCamI'd be ok with merging them toghether15:41
NobodyCamlol15:41
jrollhave bikeshed; will paint15:41
BadCubNobodyCam: I have a section on the pad for unapproved specs. I will add ^ to that list.15:41
NobodyCamlol15:41
BadCubIt really does not seem to be a big deal in either case, and it would make kittens sad if we help off opening specs for L until next week over this15:43
dtantsurI don't care much as well, so I can revert my vote if people think so :)15:45
jrolldtantsur: do you feel strongly about this?15:45
BadCubs/help/held15:45
dtantsurjroll, not really15:45
dtantsurI can live with it ;)15:45
jrollI'm inclined to just merge it then15:45
BadCubjroll: I agree15:46
NobodyCam++15:46
*** ramineni has quit IRC15:46
BadCubdtantsur: I agree with your points on ^ less confusing is a major ++15:47
dtantsur+2. let's approve it and then think whether to move stuff to backlog15:47
NobodyCambrb15:47
jlvillaldtantsur: Question on: https://review.openstack.org/#/c/171334/10/ironicclient/common/http.py15:48
jrollwait, ramesh took off without test results for https://review.openstack.org/#/c/171767/ :(15:48
jrolllucasagomes: dtantsur ^15:48
lucasagomesjroll, oh, he said he tested and works15:48
lucasagomesperhaps we should +a that then15:48
dtantsurjroll, he left a comment15:48
jlvillaldtantsur: Is there a reason _parse_version_headers is not in VersionNegotiationMixin?  Seems like the same two functions are duplicated.15:48
NobodyCammorning jlvillal15:49
dtantsurjlvillal, they're a bit different, have a closer look15:49
jlvillaldtantsur: But maybe the request method is different and thus need two ways15:49
dtantsurand g'morning15:49
BadCubSo I was thinking of pulling the 'available" Spec Cores together next Wednesday to meet, go over some process things to make life easier and start eyeing specs. I think this is a good time to discuss this as well for future cycles15:49
lucasagomesdtantsur, I will go there and approve jroll's patch ack?15:49
BadCubif Wednesday is good for everyone15:49
jlvillalNobodyCam: Morning15:49
dtantsurlucasagomes, ++15:49
NobodyCamworks for /me15:49
*** ramineni has joined #openstack-ironic15:49
dtantsurBadCub, should be ok15:49
jrolldtantsur: lucasagomes: oh, why wouldn't he approve :/15:49
dtantsurno idea15:49
lucasagomesjroll, hmmmmm15:50
NobodyCambrb15:50
lucasagomesno idea, better wait?15:50
jrollBadCub: I also +2'd the "open L" thing, and I'm free wednesday afaik15:50
BadCubawesome15:50
jrolllucasagomes: idk, he's +2 on it15:50
lucasagomesjroll, hmm, idk... ok let's wait then15:50
NobodyCamlucasagomes: what patch?15:51
jlvillaldtantsur: Would it be horrific to have a common function which gets passed the accessor function?15:51
jlvillal:)15:51
lucasagomesNobodyCam, https://review.openstack.org/#/c/171767/15:51
BadCubjroll: ty :)15:51
dtantsurjlvillal, well, not very different as to me. you can go ahead and change it, if you feel like, I was kind of fixing the patch for devananda :)15:51
jlvillaldtantsur: Okay, let me look15:52
BadCubThank you NobodyCam for +2 on https://review.openstack.org/#/c/171334/15:52
dtantsurlucasagomes, lemme annoy you once more with https://review.openstack.org/#/c/171211/ (and https://review.openstack.org/#/c/172077/ too) if you don't mind :)15:53
lucasagomesI'm on the docs one :-) it's big15:53
*** Marga_ has joined #openstack-ironic15:53
*** Marga_ has quit IRC15:53
openstackgerritJim Rollenhagen proposed openstack/ironic: Address comments on I5cc41932acd75cf5e9e5b626285331f97126932e  https://review.openstack.org/17213015:54
*** Marga_ has joined #openstack-ironic15:54
jrolllucasagomes: ok, if you say so. follow-up patch here ^15:54
jrollidk why 3 +2's and "tested, wfm" would wait15:54
BadCubjroll: yeah, I was kinda curious there too15:55
jrollit's whatever15:55
lucasagomesI'm ok approving it15:55
NobodyCamlucasagomes: would https://review.openstack.org/#/c/171743/ affect https://review.openstack.org/#/c/17176715:55
lucasagomesNobodyCam, not really15:55
lucasagomeswait thinks ...15:55
lucasagomeshmmmmmm15:56
NobodyCami think it might15:56
* BadCub needs a smoke15:56
jrollNobodyCam: 171767 just makes whole disk images not enter that block that 171743 touches15:56
jrollI don't see why it would affect it15:56
dtantsurgoing now, see you tomorrow15:57
*** dtantsur is now known as dtantsur|afk15:57
jrollg'night15:57
BadCubg'night dtantsur|afk15:57
NobodyCamnight dtantsur|afk15:57
NobodyCamhumm15:57
* NobodyCam need more coffee15:57
NobodyCambrb15:57
lucasagomesjroll, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L612-L62615:59
lucasagomesI wonder if ur patch should also ignore that if is_whole_disk_image15:59
* lucasagomes is confused, I really need time to test such changes15:59
jrolllucasagomes: no, we don't want whole disk images to install the bootloader15:59
jrollthus they shouldn't wait for the bootloader to be installed16:00
lucasagomesohhh I see the is_whole_disk_image conditional now there16:00
lucasagomesyeah16:00
lucasagomesmakes sense16:00
lucasagomesok /me approves16:00
jrollyeah, I went to fix it there as well and it was already there :D16:00
lucasagomesNobodyCam, u want to test it first?16:01
* lucasagomes feels uncomfortable 16:01
jrollonly two people have tested it16:01
jroll:/16:01
jrollman, we should spend the entire liberty cycle writing tests for everything16:02
jrollalmost nothing is tested these days16:02
*** rwsu has joined #openstack-ironic16:02
lucasagomesyeah16:03
lucasagomeswe def need some gate tests for local boot/whole disk image16:03
lucasagomesipxe16:03
lucasagomesand so on16:03
jrollyep16:03
NobodyCam+++++16:04
NobodyCamlucasagomes: my OoO env is currently not working... I broke it somehow16:05
lucasagomesif we ditch the bash ramdisk, we at least won't need to test same stuff for both ramdisks16:05
lucasagomeswe get rid of all the bash ramdisks tests, and just IPA as the official and tested ramdisk16:05
lucasagomesright now the matrix will be too big with both ramdisks being official16:06
lucasagomesNobodyCam, oh, no idea16:06
lucasagomesNobodyCam, what's up?16:06
*** dttocs has joined #openstack-ironic16:06
NobodyCamlucasagomes: oh that was a reply to your "you wanta test it question"16:06
* BadCub thinks NobodyCam 's "Taco Dev machine" is giving up on life completely16:07
NobodyCamand I love to drop the bash ramdisc in L16:07
lucasagomesNobodyCam, oh I see16:07
lucasagomesNobodyCam, it's ok if I go ahead and approve it?16:08
NobodyCamI think so.16:08
lucasagomesx.x16:08
lucasagomeshah16:08
openstackgerritMerged openstack/ironic: Use hexhyp instead of hexraw iPXE type  https://review.openstack.org/17175916:11
*** derekh has quit IRC16:12
* BadCub runs out to hunt breakfast items16:13
* lucasagomes approved jrolls patch16:15
lucasagomesfolks I have to call it a day16:15
lucasagomesgotta catch the train back still16:15
lucasagomeshave a great night everyone16:15
NobodyCamnight lucasagomes16:16
*** lucasagomes has quit IRC16:16
NobodyCamjlvillal: you working on a new rev of 171334?16:17
NobodyCamalso doc patch with several +1's and a +2 https://review.openstack.org/#/c/16916216:20
*** ndipanov has quit IRC16:20
jlvillalNobodyCam: I was working on trying to refactor a little bit to reduce duplication16:25
NobodyCamjlvillal: +++16:25
*** ramineni1 has joined #openstack-ironic16:27
NobodyCamadam_g: mind if I make a minor edit to 171827?16:28
*** ramineni has quit IRC16:29
openstackgerritChris Krelle proposed openstack/ironic: Add notes about upgrading juno->kilo to docs  https://review.openstack.org/17182716:31
adam_gNobodyCam, ya, sure thanks16:33
NobodyCamI voted +2 on ^^^^ my patch only removed one word16:33
NobodyCamadam_g: :)16:33
NobodyCamthank oyu16:33
adam_g:P16:33
NobodyCamyou even16:33
*** athomas has quit IRC16:33
NobodyCambrb16:33
*** foexle_ has quit IRC16:34
*** harlowja_away is now known as harlowja16:35
*** ijw has joined #openstack-ironic16:41
*** yog__ has quit IRC16:49
*** davideagnello has joined #openstack-ironic16:53
* NobodyCam is back16:58
* BadCub is also back16:58
*** viktors is now known as viktors|afk17:02
adam_gnice http://lists.openstack.org/pipermail/openstack-dev/2015-February/056515.html17:04
NobodyCam:)17:06
BadCubsweet ^17:13
*** saripurigopi has quit IRC17:13
openstackgerritMerged openstack/ironic: Don't pass boot_option: local for whole disk images  https://review.openstack.org/17176717:13
*** openstack has quit IRC17:13
*** openstack has joined #openstack-ironic17:14
*** achanda has joined #openstack-ironic17:17
NobodyCamlol ... got luv dtantsur|afk refferences to "ancient ramdisks"17:18
*** pelix has quit IRC17:18
jrolleasy review: https://review.openstack.org/#/c/172130/17:20
*** Marga_ has quit IRC17:21
BadCubadded ^ to pad17:22
*** ramineni1 has quit IRC17:22
BadCubWe gots a bunch of things that need +2/+A on em, mostly docs :p17:23
*** Marga_ has joined #openstack-ironic17:24
NobodyCamjroll: BadCub 172130 ... Bam!17:25
BadCubcoolness17:25
NobodyCambrb17:27
*** meghal has joined #openstack-ironic17:29
*** Marga_ has quit IRC17:29
*** meghal has quit IRC17:30
openstackgerritVladyslav Drok proposed openstack/ironic: Update session headers during initialization of AgentClient  https://review.openstack.org/17215417:31
openstackgerritJosh Gachnang proposed openstack/ironic: Agent driver fails without Ironic-managed TFTP  https://review.openstack.org/17098417:51
*** Sukhdev has joined #openstack-ironic17:52
*** victorfeitosa has joined #openstack-ironic17:54
jrollBadCub: ^ is this one on the rc1 list?17:54
* BadCub looks17:54
BadCubNope17:54
BadCubit looks like it should be though17:54
BadCubjroll: targets the bug for ^ to rc1 and added to pad17:55
*** Marga_ has joined #openstack-ironic17:56
jrollthanks17:56
BadCubyw :)17:57
*** meghal has joined #openstack-ironic18:00
*** meghal has quit IRC18:05
*** edcragg has quit IRC18:06
*** Marga_ has quit IRC18:07
*** Marga_ has joined #openstack-ironic18:18
*** Marga_ has quit IRC18:20
*** Marga_ has joined #openstack-ironic18:20
NobodyCamjroll: would you happen to have some time to take a look at the pending doc patches?18:27
jrollNobodyCam: this afternoon I could18:27
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient: WIP: Unit tests for micro-versions.  Feedback wanted!  https://review.openstack.org/17216818:28
NobodyCam:) thats only 33 minutes away :-p18:28
jrollheh18:28
jlvillaljroll, BadCub:  ^^^^  Before I go off on a wild tangent, I thought I would get some initial feedback on the patch idea18:28
BadCubI need to go away for a while. NobodyCam can you take a look at ^18:29
jlvillalBadCub: NobodyCam: Thanks18:30
greghaynesjroll: you had success with https://review.openstack.org/#/c/171743/ ?18:30
jrollgreghaynes: I didn't test it, no18:31
greghaynesah18:31
jrolljlvillal: why would refactoring be a bad idea?18:32
jlvillaljroll: It was more on the unittests I was looking for feedback.  On the refactoring my only concern is it might be confusing to people passing a function around.18:33
*** ijw has quit IRC18:33
jlvillaljroll: I like the refactoring of the parse_versions.  Less sure on the http request function.18:33
jrolljlvillal: idk, seems sane. the accessor_func thing is a bit odd but whatever18:34
jlvillaljroll: That was my concern if it would confuse people or not.  So wasn't sure to refactor like that or leave it as is.18:34
jrolljlvillal: meh, it may take a sec but everyone should be able to figure that out18:35
openstackgerritMerged openstack/ironic: Follow-up to "Add retry logic to _exec_ipmitool"  https://review.openstack.org/17177118:37
openstackgerritRuby Loo proposed openstack/python-ironicclient: Consistent and more valid strings for Booleans  https://review.openstack.org/17023018:38
BadCubjlvillal: this is the follow-up to https://review.openstack.org/#/c/171334/ ?18:39
jlvillalBadCub: yes, I didn't want to touch the patch in progress.18:40
BadCubcool18:40
jlvillalBadCub: I figured I would to a follow-on patch18:40
jlvillals/to/do/18:40
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Add support for 'baremetal show' command  https://review.openstack.org/17173918:40
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Introduce openstackclient plugin  https://review.openstack.org/17167218:40
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implement the rest of the args for baremetal list  https://review.openstack.org/17169918:40
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implement baremetal delete command  https://review.openstack.org/17175118:40
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Add support for microversion  https://review.openstack.org/17217018:40
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal create  https://review.openstack.org/17217118:40
openstackgerritMerged openstack/ironic: Address comments on I5cc41932acd75cf5e9e5b626285331f97126932e  https://review.openstack.org/17213018:41
jlvillalGo Brad! :)18:41
* BadCub blinks18:41
* jlvillal wonders who is Brad P. Crochet?18:41
BadCubAll of those were added to the L pad yesterday as "Things of Interest"18:42
NobodyCamjlvillal: with that follow up patch could the -1 be removed from devananda's orginal patch?18:47
BadCubjlvillal: I added https://review.openstack.org/#/c/172168/1 to the pad :)18:48
jlvillalNobodyCam: Will do!18:53
jlvillalNobodyCam: Done18:53
NobodyCam:)18:54
*** meghal has joined #openstack-ironic18:55
BadCubcan we get another +2/+A on https://review.openstack.org/#/c/171334/ :)18:55
NobodyCamrloo: are around?18:55
rloohi NobodyCam18:55
NobodyCamhi rloo ... morning (afternoon)18:56
NobodyCamrloo: would you happen to have a free minute to look at ^^^^18:56
rlooalmost-afternoon-to-you NobodyCam ;)18:56
rlooNobodyCam: am in a meeting that should end soon (hopefully in the next 10 min). will look then.18:57
NobodyCamawesome TY rloo :)18:57
NobodyCamoh on another NOTE: I believe HP will again print up our team shirts18:57
NobodyCamworking with them now!!!18:57
rlooNobodyCam: sweet. I'm guessing this is with bear metal? :)18:58
NobodyCamshow we'll need a count of the sizes we'll need18:58
rlooNobodyCam: guess you'll have to look into the 'import' issue again.18:58
NobodyCamrloo: something very close ti: http://www.customink.com/lab?cid=45931546-15537897&pc=SDFU-40124&cm_mmc=sdfu-_-Winter2014-_-Day84-_-button18:58
BadCubNobodyCam: I have a sign-up sheet for t-shirts ready on a pad18:58
NobodyCamwoo hoo BadCub :)18:59
*** meghal has quit IRC18:59
BadCubI was just waiting to put it out until we got the "black" concept worked out18:59
rlooNobodyCam, BadCub: oh, black. even badder ;)18:59
NobodyCamyes looks like black shirts with white text / graphics18:59
BadCubrloo: yeah, the black prototype looked best, at least to me it did. But considering 99.8% of my entire wardrobe is black, I may be biased19:00
rlooBadCub: how boring. How about a RED one for you?19:01
NobodyCamlol19:01
BadCubrloo: red clashes with my tattoos LOL19:01
rlooBadCub: didn't realize people color-coordinated with their tatoos. Guess that makes sense :D19:02
*** kkoski has quit IRC19:02
BadCubrloo: it's all about complimenting one's art :D19:02
rlooNobodyCam: long-sleeve RED shirt for BadCub!19:02
NobodyCamhehehe19:03
* BadCub cringes at idea of long-sleeve and hides in corner19:03
*** meghal has joined #openstack-ironic19:03
*** Marga_ has quit IRC19:03
jrollI'll only take a long sleeve if it's a hoody19:03
NobodyCamjroll: ++ but not a hoody this time just a tee shirt19:04
NobodyCam:-p19:04
BadCubI have no hoodies :(19:04
TheJuliaif we're talking about red shirts, LIGHT RED may be an option...19:04
jrollNobodyCam: yeah, just hate long sleeve t-shirts :)19:05
* BadCub links light red to pink and runs away to another oom19:05
jrollTheJulia: so uh, pink?19:05
BadCubroom even19:05
*** Marga_ has joined #openstack-ironic19:05
NobodyCamlol19:05
jrollI can get behind a pink shirt19:05
TheJuliaI'm sure we could get JayF doing a sound clip about how LIGHT RED is not pink19:05
*** kkoski has joined #openstack-ironic19:06
jrollLOL19:06
jrollTheJulia: have you met jay in person?19:06
*** Marga_ has quit IRC19:06
NobodyCamor a new hbo show "pink is the new black"19:06
*** Marga_ has joined #openstack-ironic19:06
BadCubI just can't......do pink........19:07
TheJuliajroll: JayF and I met years ago in the Raleigh, NC area through mutual friends.  When we recognized each other in Paris, he kind did like a tackle hug kind of thing19:07
jrollTheJulia: lol, awesome :D19:08
NobodyCamlol about about broke my finger19:08
* rloo doesn't care for pink either. But a strong red, now, that's a different colour :)19:08
lifelessvery risky colour19:08
lifelessgot to watch out for aliens, explosions, poison, warp coil leaks...19:09
TheJuliaand never beam down to the planet first.19:09
BadCublol19:10
BadCubbrb19:10
*** victorfeitosa has quit IRC19:15
*** dttocs has quit IRC19:15
NobodyCamlol19:17
*** dprince has quit IRC19:20
*** meghal has quit IRC19:20
NobodyCambbaib19:21
*** ijw has joined #openstack-ironic19:23
*** Marga_ has quit IRC19:39
*** Marga_ has joined #openstack-ironic19:40
*** Marga_ has quit IRC19:40
*** Marga_ has joined #openstack-ironic19:40
*** ijw has quit IRC19:43
*** meghal has joined #openstack-ironic19:45
*** Marga_ has quit IRC19:45
*** kozhukalov has quit IRC19:50
*** Sukhdev has quit IRC19:52
pshigemorning Ironic19:54
BadCubheya pshige :)19:55
pshigeBadCub: hi19:55
pshige0455 JST in Japan :)19:55
NobodyCammorning pshige19:55
NobodyCamwow19:55
BadCubthat's early!19:56
pshigeNobodyCam: morning19:56
NobodyCam:)19:56
*** meghal1 has joined #openstack-ironic20:02
*** meghal has quit IRC20:02
*** meghal1 has quit IRC20:03
*** meghal has joined #openstack-ironic20:03
*** meghal has quit IRC20:03
*** meghal has joined #openstack-ironic20:04
*** davideagnello has quit IRC20:06
*** davideagnello has joined #openstack-ironic20:07
*** dttocs has joined #openstack-ironic20:07
NobodyCamI'm going to land https://review.openstack.org/#/c/171831 ? any objections to opening the L specs up?20:11
BadCubNobodyCam: ++20:12
*** bradjones has quit IRC20:13
pshigeno objection20:14
*** ijw has joined #openstack-ironic20:14
*** bradjones has joined #openstack-ironic20:17
NobodyCamBadCub: https://review.openstack.org/#/c/170984 +2'd20:18
BadCubNobodyCam: ty :)20:19
*** ijw has quit IRC20:21
NobodyCamhttps://review.openstack.org/#/c/171831 +a'd20:23
BadCubty :)20:23
*** achanda has quit IRC20:24
openstackgerritMerged openstack/ironic-specs: Open specs for Liberty  https://review.openstack.org/17183120:27
pshigecool !20:30
BadCubNow to get our rc1 list cleaned off and we are good_to_go :)20:31
jlvillaljroll: Question on: https://review.openstack.org/#/c/171334/10/ironicclient/common/http.py  L71  Can that return no version information in the header?20:31
jlvillalBadCub: ^^  Maybe you know?20:31
* BadCub looks20:31
jrolljlvillal: no idea, without digging through the code20:32
jlvillaljroll: Thanks20:32
jlvillalBadCub: I updated that with my question/comment20:33
rloojlvillal: I was wondering about that but I think it will return the version header, because I think that we only started returning 406 *after* we added the version stuff.20:33
rloojlvillal: but I've been too lazy to look at the log to verify the order in which we added the code20:34
jlvillalrloo: Ah, makes sense.20:34
rloojlvillal: are you looking at that patch now?20:34
rloojlvillal: cuz something doesn't make sense to me.20:34
jlvillalrloo: I just posted comment with question on patch.  So yes20:34
rloodo you understand the use of the implicit_api_version?20:34
jlvillalrloo: What's that?20:34
jlvillalrloo: I wonder if that really means explicit?  Let me look again.20:35
jlvillalrloo: never mind last comment20:35
rloojlvillal: so line 81 of that http file: https://review.openstack.org/#/c/171334/10/ironicclient/common/http.py20:35
*** Marga_ has joined #openstack-ironic20:36
rlooit seems to me that if the user explicitly specified the version and the client got a 406, we don't want to change the version/do anaother request20:36
rlooand i'm guessing that we have this code here so that we can spit out a msg to the user as to the valid min/max20:36
jlvillalrloo: Correct that is the goal from what I understand20:36
jlvillalrloo: If they ask for version 1.99 then fail.20:37
rloobut i may be tired, cuz if the user specifies a version say 1.5 and they get 406, then negotiate_version wil be called. what if negotiated_ver == 1.5.20:37
*** Marga_ has quit IRC20:38
*** igordcard_ has joined #openstack-ironic20:38
rloowon't it return 1.5 instead of raising an exception?20:38
jlvillalrloo: Yes I would think it would return 1.5 but I think that would be correct.  If the server supports 1.5 and the user asks for 1.5.20:39
NobodyCamrloo: if user requests a version and it fails it should try and negotiate a different version... at leat that is my understanding20:39
rloojlvillal: but the user originally asked for 1.5 and it failed. are we going to do another request for 1.5 again?20:39
NobodyCamit should *NOT* try ...20:39
jlvillalrloo: I would assume it will try again and should fail again.20:39
rloojlvillal: when will it stop?20:40
rloojlvillal: like, why try again? nothing will have changed.20:40
jlvillalrloo: Wouldn't the raised exception stop it?20:40
rloojlvillal: that's my question. i don't see that an exception will be raised.20:40
NobodyCamrloo: lines 10 and 11 of the commit message20:41
rloojlvillal: I don't think that if at line 80 will be triggered20:41
jlvillalrloo: But wouldn't that be a bug in the server?20:41
rlooNobodyCam: 'if the user did not request a specific version'...20:42
jlvillalrloo: The server is saying it supports 1.5 but then when the client requests 1.5 it returns 406.  Or am I missing something?20:42
rlooNobodyCam: but in the http.py file https://review.openstack.org/#/c/171334/10/ironicclient/common/http.py20:42
rlooNobodyCam: line 81 -- what is that testing for?20:42
jlvillalrloo: I think it is testing for user requests 1.8 but server only supports 1.6.  So fail.20:43
rloojlvillal, NobodyCam: maybe I'm missing something. I'll have to test it out. Something doesn't make sense to me.20:44
jlvillalrloo: okay20:44
*** ijw has joined #openstack-ironic20:44
NobodyCamhumm20:45
NobodyCamoh looks like like 217 should also be checking self.os_ironic_api_version20:46
*** andreykurilin_ has joined #openstack-ironic20:46
NobodyCamif resp = 406 and self.os_ironic_api_version not none20:47
NobodyCamthen ... negotiate version20:47
NobodyCamif resp = 406 and self.os_ironic_api_version IS none20:48
NobodyCamthen ... negotiate version20:48
NobodyCam:-p20:48
rlooNobodyCam: I *think* os_ironic_api_version will actually be specified there.20:48
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient: WIP: Unit tests for micro-versions.  Feedback wanted!  https://review.openstack.org/17216820:49
*** pcrews has quit IRC20:49
jlvillalrloo: https://review.openstack.org/#/c/172168/2/ironicclient/tests/unit/test_http.py L123  I added a test case for how I think it should work20:49
rloojlvillal: it's just a ploy on your part to get me to look at your patch ;)20:50
jlvillalrloo: :D20:50
*** ijw has quit IRC20:51
rloojlvillal: do you  have a case where you test that the user-specified version is supported by the server, but that the actual request isn't?20:51
*** Marga_ has joined #openstack-ironic20:51
jlvillalrloo: I do not.  I'm just starting on these unit tests.20:51
rloojlvillal: I mean eg, using a node name if the version is < 1.5 or whatever, or doing an inspect if < 1.6. I think that's where I'm confused as to how this patch is handling or not handling.20:52
jlvillalrloo: Ah, that makes sense.20:52
jlvillalrloo: User requests a version that the server supports but then asks for a specific call which is not supported by that version.20:52
*** achanda has joined #openstack-ironic20:53
rloooh s*. i had to kill my client. i was right. the code isn't correct.20:53
*** pcrews has joined #openstack-ironic20:53
NobodyCam:(20:53
NobodyCamrloo: so for my understanding:you requested a supported version but asked for something that was not supported in that version20:54
rlooNobodyCam: yup.20:59
rlooNobodyCam: I added a comment or several comments.20:59
rloojlvillal: maybe we should add your tests to that patch too.20:59
jlvillalrloo: Works for me.  I was trying not to delay the patch.21:00
rloojlvillal: I know, and I normally would agree but there seem to be subtleties/cases here that I'm not sure I can remember to manually think of/test for.21:01
rloowe aren't cutting rc1 until Monday, right?21:02
*** thrash is now known as thrash|g0ne21:03
BadCubrloo: correct21:05
NobodyCamjlvillal: would you be able to address these comments?21:05
NobodyCamand maybe merge your tests patch in21:06
rlooNobodyCam, jlvillal: It works if we remove the check of negotiated != os...version21:08
NobodyCamrloo:  :)21:09
jlvillalrloo: Do you want to propose that change?21:10
jlvillalrloo: Does it impact the case of I request version 1.99?21:11
*** jcoufal has joined #openstack-ironic21:12
rloojlvillal: I don't know if it impacts that case or not, it shouldn't. ie, if the user specified a version and they get 406, we should just raise an exception. not make another request.21:12
rloojlvillal: i can propose the change if you want. but i'd like to keep my +2 powers for this in case it is needed on Monday.21:13
jlvillalrloo: Okay :)21:13
rloojlvillal: esp if you're going to add your tests :-)21:13
jlvillalMaybe I just do the small change you suggest.21:13
NobodyCamrloo: ++ that is why I asked too21:13
jlvillalOkay I will add the tests without the refactoring I think21:14
rloojlvillal, NobodyCam: I'm off in a few minutes. might be back later tonight, or not. but then not back til Monday.21:14
jlvillalrloo: Okay21:15
rloojlvillal, NobodyCam: hopefully it'll be merged before then ;)21:15
jlvillalrloo: Do you think L384 should be changed?21:15
BadCubhave a good weekend rloo !! :-)21:15
jlvillalrloo: Around there?21:15
rloojlvillal: what do you mean? what change are you thinking of?21:16
jlvillalFor my case of version 1.99?21:16
jlvillalrloo: I need to read the code more...21:16
NobodyCamjlvillal: are you going to remove the check rloo pointed out21:16
NobodyCamrloo: havea great weekend21:16
rloojlvillal: so user asks for 1.99, server doesn't support it, user should get an exception. right?21:16
jlvillalrloo: If we get 406 and the user specified the version should we just fail then.21:16
rloojlvillal: yes, we should just fail. cuz the user explicitly specified the version.21:17
jlvillalNobodyCam: I will do that.21:17
jlvillalrloo: That is what I was thinking in the L384 region.21:17
rloojlvillal: the 'failing' is being done in that negotiate method though21:17
jlvillalrloo: Okay, let me look more closely.  And work on an update21:18
NobodyCamawesome thank you jlvillal :)21:18
rloojlvillal: if your tests are complete, we should see where the failings are21:18
jlvillalrloo: Big if ;)21:19
rloojlvillal: oh, hmm. if there are tests that test the scenarios we are interested in, we will see where/if there are failings :-)21:20
jlvillalrloo: Yes21:20
jlvillalNobodyCam: Hopefully I can have a patch uploaded before the end of the work day.21:20
NobodyCam:) that would be supper awesome :)21:22
jlvillalNobodyCam: and dinner great ;)21:22
NobodyCambut there is always tomorrow21:22
jlvillalNobodyCam: Thanks21:23
NobodyCam:)21:23
*** meghal has quit IRC21:23
*** meghal has joined #openstack-ironic21:24
*** meghal has quit IRC21:24
*** meghal has joined #openstack-ironic21:25
openstackgerritClif Houck proposed openstack/ironic: Add support for image caching for the agent driver  https://review.openstack.org/16183221:25
*** korekhov has joined #openstack-ironic21:26
*** r-daneel has joined #openstack-ironic21:31
*** rloo is now known as rloo_afk21:37
*** Sukhdev has joined #openstack-ironic21:45
mrdaMorning Ironic21:45
TheJuliaGood evening :)21:46
*** kkoski has quit IRC21:46
mrdaTheJulia :)21:47
*** ijw has joined #openstack-ironic21:47
*** trown is now known as trown|outttypeww21:50
*** andreykurilin_ has quit IRC21:51
*** ijw has quit IRC21:52
NobodyCammornign mrda21:54
mrdahi NobodyCam21:54
BadCubheya mrda21:54
mrda...and BadCub21:54
NobodyCam:)21:54
openstackgerritMichael Davies proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary  https://review.openstack.org/17133421:55
openstackgerritMichael Davies proposed openstack/python-ironicclient: Cache negotiated api microversion for this server  https://review.openstack.org/17194621:55
mrdaahh, bother.  Stupid rebase21:56
NobodyCamdid you see rloo_afk  comments on that one21:56
NobodyCam:-p21:56
mrdaSorry, I need to put that back how it was - that rebase somehow screwed up :(21:57
* NobodyCam offers mrda coffee :)21:58
mrdaI should have done that first before starting work :-S21:58
NobodyCam:p21:58
openstackgerritClif Houck proposed openstack/ironic: Add support for image caching for the agent driver  https://review.openstack.org/16183222:03
* NobodyCam steps afk for few 22:05
openstackgerritMichael Davies proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary  https://review.openstack.org/17133422:10
* mrda steps away to make coffee22:11
*** jcoufal has quit IRC22:14
*** kkoski has joined #openstack-ironic22:23
*** kkoski has quit IRC22:26
jlvillalmrda: ping22:27
mrdahey jlvillal22:27
jlvillalmrda: Hey I am working on a patch for 17133422:28
jlvillalI was about to push it22:28
mrdagreat!22:28
jlvillalmrda: So I won't trample on you?22:28
mrdaSorry, I was rebasing a depends on change, and accidentilly changed 17133422:28
mrdaSo I just reverted22:28
jlvillalmrda: Okay :)  Thanks!22:28
mrdaSorry for the noise22:28
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary  https://review.openstack.org/17133422:29
jlvillalmrda: Feel free to review ^^^  :)22:29
jlvillalNobodyCam: ^^^^^22:29
NobodyCamoh... TY jlvillal22:29
NobodyCamI'm reading over the rescue mode spec22:30
NobodyCamhehehehe22:30
NobodyCamwhich if run on a not borked node could break it..22:30
mrdajlvillal: shall do22:30
jlvillalmrda: Thanks22:30
NobodyCamwould be nice to have soft power off support22:31
NobodyCamJoshNang: around?22:35
JoshNangNobodyCam: o/22:36
NobodyCamhowdy22:36
NobodyCam:-p22:36
JoshNanghow's it going?22:36
NobodyCamgoing good :)22:36
NobodyCamjust a question22:36
JoshNangok, shoot22:37
NobodyCamto much of a miss use of driver_internal_info to store the salted hashed password there vs instance_info22:37
JoshNangwe went with instance info because it was related to an instance on the machine, and not the node itself22:40
NobodyCam:) maakes me want a instance_intenal_info field22:40
NobodyCamlol22:40
JoshNangalso, can you update driver_internal_info via the api?22:40
NobodyCambut I understand22:40
JoshNangi'd definitely want guards on that so it doesn't show up in api requests, like we do with ipmi passwords22:41
NobodyCam:)22:42
*** Marga_ has quit IRC22:43
*** ijw has joined #openstack-ironic22:48
*** ijw has quit IRC22:52
*** r-daneel has quit IRC23:13
*** Marga_ has joined #openstack-ironic23:14
*** yuanying has joined #openstack-ironic23:23
*** davideagnello has quit IRC23:29
*** jcoufal has joined #openstack-ironic23:34
*** Marga_ has quit IRC23:35
*** Marga_ has joined #openstack-ironic23:36
*** davideagnello has joined #openstack-ironic23:37
*** Marga_ has quit IRC23:38
*** Sukhdev has quit IRC23:45
*** Marga_ has joined #openstack-ironic23:47
*** Marga_ has quit IRC23:48
*** Marga_ has joined #openstack-ironic23:48
*** ijw has joined #openstack-ironic23:49
*** ijw has quit IRC23:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!