Tuesday, 2015-02-24

*** ijw has joined #openstack-ironic00:02
devanandaNobodyCam: ah, jogo's pinning on stable/juno00:03
devanandanope. /me lands it00:03
devanandaNobodyCam: actually it was failing previous revisions00:04
openstackgerritJohn L. Villalovos proposed openstack/ironic: iLO implementation for hardware inspection  https://review.openstack.org/15159600:04
*** hj-hp has quit IRC00:06
*** penick has joined #openstack-ironic00:06
NobodyCamdevananda: I was just rebuilding to test it00:07
NobodyCamofc had to also update all my caches too00:08
NobodyCam:-p00:08
*** wanyen has joined #openstack-ironic00:11
openstackgerritJoshua Harlow proposed openstack/ironic: Update the states generator and regenerate the image  https://review.openstack.org/15810200:11
wanyenHi BadCub,00:11
BadCubheya wanyen00:12
wanyenBadCub, there are a few iLO driver specs that have been approved but not yet on ironic kilo3 LP.  Can you add them?  I will give you the links.00:12
BadCubabsolutely!00:13
wanyenImplement Cleaning Operations for iLO drivers https://blueprints.launchpad.net/ironic/+spec/ilo-cleaning-support00:13
openstackgerritMerged openstack/ironic: Remove unused modules from ironic/openstack/common  https://review.openstack.org/15826400:13
jogodevananda: ? did it break something00:13
wanyenBadCub, another one - In-band RAID configuration using IP https://blueprints.launchpad.net/ironic/+spec/inband-raid-configuration00:14
wanyenBadCub,, one more: New driver interface for RAID configuration https://blueprints.launchpad.net/ironic/+spec/ironic-generic-raid-interface00:15
wanyenDevananda and BadCub, also, can you raise priority  of https://blueprints.launchpad.net/ironic/+spec/uefi-secure-boot from low to medium?  It’s iLO driver’s top priority item.  Thanks!00:17
BadCubations for iLO drivers https://blueprints.launchpad.net/ironic/+spec/ilo-cleaning-support appears to already be approved for K300:17
BadCuback, my copy functionality has gone insane00:17
wanyenBadCub, all the blueprints and specs that I justed mentioned have been approved but not yet on Kilo3 launchpad.00:18
BadCubDOH. My bad. My mouse is gone insane, gimmie a sec and I will nail them down00:19
wanyenBadCub, ty00:19
BadCubwanyen UEFI and Cleaning were already tagged for K3. I just updated RAID for K300:23
BadCubwanyen:  devananda still sets priority on things :-)00:24
wanyenBadCub, ty00:28
wanyenDevananda,  can you consider raising priority for secure boot  https://blueprints.launchpad.net/ironic/+spec/uefi-secure-boot from low to medium?  It’s iLO driver’s top priority item.  Thanks!00:29
BadCubwanyen, yw :-)00:29
*** Marga_ has quit IRC00:40
*** Marga_ has joined #openstack-ironic00:41
*** Marga_ has quit IRC00:41
devanandajroll: you started on the pluggable network provider work -- how's that going? chance of being done for kilo?00:45
devanandawanyen: done00:45
jrolldevananda: distractions00:45
devanandawanyen: I updated several proirities just now00:45
jrollidk, I could probably get it close this week00:45
jrollhaven't gotten any feedback on current patches00:45
jroll(yes I know tests are failing, that isn't the point)00:46
devanandajroll: it's at least a High priority for me00:46
devanandaonce I have some time to start reviewing deeper things00:46
jrollok, cool00:46
jrolldevananda: can you take a rough look tonight and I'll hack on it a bit tomorrow?00:46
devanandaafter spending most of today going over the BPs and specs with BadCub I think I have a better picture of htings00:46
devanandastill feels like there are several items we're not tracking well00:46
devanandabut that's probably entirely my fault. like the microver stuff00:47
jrollheh00:47
*** ChuckC has quit IRC00:56
openstackgerritDevananda van der Veen proposed openstack/python-ironicclient: Add support for logical names  https://review.openstack.org/15852000:56
devanandaand like that one00:57
devanandaoh, which needs to be based on the microver support in the client, otherwise the server will rejecet it00:57
NobodyCamlol which you have a -1 on atm lol :-p00:59
devanandaright01:00
devanandabecause it does it wrong01:00
devanandai may just fix that up too01:00
NobodyCamoh sure devananda wakes up at 5 pm :-p01:00
NobodyCamhehehe01:01
* BadCub rubs eyes01:01
mrdadevananda: oh, thanks for that.  I was waiting for 155624 first.01:01
NobodyCammorning mrda :)01:02
mrda:)01:02
mrdahey NobodyCam01:02
devanandamrda: ohhai! welcome01:03
devanandamrda: if you feel like doing some related stuff - I think we should have a "latest" version in the server, and the client should default to it01:03
jrollo.o01:04
devanandaeg, instead of only accepting numbers, the server should appect X-OpenStack-ironic-API-Version="latest"01:04
devanandaand then just do that01:04
mrdaSince the microversion support one was still very much a work in progress, I was delaying :)01:04
mrdaoh, ok.  Sure.01:04
devanandabecause otherwise the client has to magicallyknow what the latest version is01:04
mrdaI'll put something up01:04
devanandawhich, well, means a bunch of other magic01:04
devanandanova does ^ and I like it01:04
devanandathanks!01:04
openstackgerritMerged openstack/ironic: Return required properties for agent deploy driver  https://review.openstack.org/15831301:04
* devananda runs off to a 5pm meeting01:04
mrdaso, just on 155624, it should *always* send the microversion header now, right?01:05
*** penick has quit IRC01:07
*** adam_g is now known as adam_g_out01:09
*** devlaps has quit IRC01:11
openstackgerritJosh Gachnang proposed openstack/ironic: Implement Cleaning States  https://review.openstack.org/15344401:15
*** david-lyle is now known as david-lyle_afk01:19
*** achanda has quit IRC01:21
devanandamrda: yes01:27
* BadCub thinks it is time to fix dinner and hide for the evening01:27
*** ParsectiX has quit IRC01:35
*** ParsectiX has joined #openstack-ironic01:36
NobodyCammmmmmm dinner01:37
openstackgerritJosh Gachnang proposed openstack/ironic: Implement Cleaning in DriverInterfaces  https://review.openstack.org/15720801:42
*** krtaylor has quit IRC01:43
*** BadCub has quit IRC01:45
*** ijw has quit IRC01:48
*** krtaylor has joined #openstack-ironic01:55
openstackgerritJosh Gachnang proposed openstack/ironic: Implement execute clean steps  https://review.openstack.org/15556101:59
openstackgerritJosh Gachnang proposed openstack/ironic: Implement execute clean steps  https://review.openstack.org/15556102:01
*** yog_ has quit IRC02:32
*** rloo_afk has quit IRC02:45
*** spandhe has quit IRC02:48
*** ramineni has joined #openstack-ironic02:49
*** yuanying has quit IRC02:54
*** wanyen has quit IRC03:14
*** yog_ has joined #openstack-ironic03:24
*** dmellado has quit IRC03:27
*** dmellado has joined #openstack-ironic03:29
*** Marga_ has joined #openstack-ironic03:30
*** yuanying has joined #openstack-ironic03:36
*** jlvillal_remote has joined #openstack-ironic03:38
*** killer_prince has quit IRC03:40
*** oomichi has quit IRC03:41
*** Marga_ has quit IRC03:43
*** spandhe has joined #openstack-ironic03:44
*** Marga_ has joined #openstack-ironic03:44
*** spandhe_ has joined #openstack-ironic03:47
*** spandhe has quit IRC03:48
*** spandhe_ is now known as spandhe03:48
*** harlowja is now known as harlowja_away04:14
*** harlowja_away is now known as harlowja04:15
*** devlaps has joined #openstack-ironic04:17
*** pensu has joined #openstack-ironic04:51
*** ParsectiX has quit IRC04:55
*** ParsectiX has joined #openstack-ironic04:55
*** krtaylor has quit IRC04:55
*** ParsectiX has quit IRC04:57
*** ParsectiX has joined #openstack-ironic04:58
*** spandhe has quit IRC04:59
*** killer_prince has joined #openstack-ironic05:05
*** killer_prince is now known as lazy_prince05:06
*** krtaylor has joined #openstack-ironic05:07
*** krtaylor has quit IRC05:14
*** devlaps has quit IRC05:17
*** krtaylor has joined #openstack-ironic05:26
*** eghobo has joined #openstack-ironic05:29
*** lazy_prince has quit IRC05:29
*** killer_prince has joined #openstack-ironic05:31
*** killer_prince is now known as lazy_prince05:31
*** achanda has joined #openstack-ironic05:34
*** jrist is now known as jrist-afk05:35
*** takadayuiko has joined #openstack-ironic05:38
*** killer_prince has joined #openstack-ironic05:40
*** lazy_prince has quit IRC05:40
*** killer_prince is now known as lazy_prince05:40
*** ParsectiX has quit IRC05:47
*** ParsectiX has joined #openstack-ironic05:47
*** coolsvap_ is now known as coolsvap05:57
openstackgerritMerged stackforge/proliantutils: HPSSA: Fix the disk sorting issue on create  https://review.openstack.org/15783205:58
openstackgerritAnusha Ramineni proposed openstack/ironic: Add Cleaning Operations for iLO drivers  https://review.openstack.org/15771506:00
openstackgerritMerged stackforge/proliantutils: HPSSA: Move test outputs to a single file  https://review.openstack.org/15786206:03
*** harlowja is now known as harlowja_away06:11
*** ParsectiX has quit IRC06:13
*** andreykurilin_ has joined #openstack-ironic06:14
*** eghobo has quit IRC06:19
openstackgerritsandhya proposed openstack/ironic:  Implement Chassis Level Discovery Tool  https://review.openstack.org/15857706:32
*** eghobo has joined #openstack-ironic06:38
*** eghobo has quit IRC06:38
*** pcrews has quit IRC06:39
*** eghobo has joined #openstack-ironic06:41
*** pradipta has joined #openstack-ironic06:42
*** andreykurilin_ has quit IRC06:44
*** viktors1 has joined #openstack-ironic06:45
*** eghobo has quit IRC06:46
*** pcrews has joined #openstack-ironic06:46
*** eghobo has joined #openstack-ironic06:48
*** lazy_prince has quit IRC06:54
*** Nisha has joined #openstack-ironic06:55
*** killer_prince has joined #openstack-ironic06:58
*** killer_prince is now known as lazy_prince06:58
*** jcoufal has joined #openstack-ironic07:03
*** dlpartain has joined #openstack-ironic07:06
*** dlpartain has left #openstack-ironic07:06
openstackgerritAnusha Ramineni proposed openstack/ironic: Add tests for ilo_deploy driver  https://review.openstack.org/14298507:16
*** eghobo has quit IRC07:23
*** viktors1 has quit IRC07:28
*** jcoufal_ has joined #openstack-ironic07:32
*** chlong has quit IRC07:34
openstackgerritRamakrishnan G proposed openstack/ironic: Root partition should be marked as bootable  https://review.openstack.org/15658707:35
*** jcoufal has quit IRC07:35
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: Add disk allocator  https://review.openstack.org/15805207:35
*** coolsvap is now known as coolsvap_07:36
*** viktors1 has joined #openstack-ironic07:36
*** Nisha has quit IRC07:37
*** coolsvap_ is now known as coolsvap07:39
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: RAID creation should return current config  https://review.openstack.org/15803307:42
openstackgerritShivanand Tendulker proposed openstack/ironic: Common changes for secure boot support  https://review.openstack.org/15397407:43
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: RAID creation should return current config  https://review.openstack.org/15803307:44
openstackgerritShivanand Tendulker proposed openstack/ironic: Common changes for secure boot support  https://review.openstack.org/15397407:45
openstackgerritShivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver  https://review.openstack.org/15480807:45
*** Marga_ has quit IRC07:45
*** Marga_ has joined #openstack-ironic07:46
openstackgerritShivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver  https://review.openstack.org/15481407:46
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: Add disk allocator  https://review.openstack.org/15805207:46
openstackgerritShivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver  https://review.openstack.org/15481607:47
openstackgerritShivanand Tendulker proposed openstack/ironic: Common changes for secure boot support  https://review.openstack.org/15397407:48
openstackgerritShivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver  https://review.openstack.org/15480807:48
openstackgerritShivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver  https://review.openstack.org/15481407:49
openstackgerritShivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver  https://review.openstack.org/15481607:49
*** viktors1 has quit IRC07:53
*** viktors1 has joined #openstack-ironic07:53
openstackgerritShivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node  https://review.openstack.org/15573107:56
*** Marga_ has quit IRC07:59
*** jcoufal has joined #openstack-ironic08:01
*** jcoufal_ has quit IRC08:05
*** ndipanov has joined #openstack-ironic08:08
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: Add disk allocator  https://review.openstack.org/15805208:08
openstackgerritMichael Davies proposed openstack/ironic: Add support for 'latest' in microversion header  https://review.openstack.org/15860108:10
mrdadevananda: ^^^ Still need to test, but here's the 1st revision (just rebuilding a devstack)08:11
openstackgerritMerged stackforge/proliantutils: ILO: Update get_persistent_boot for UEFI  https://review.openstack.org/15820508:14
*** athomas has joined #openstack-ironic08:26
*** priteau has joined #openstack-ironic08:27
*** ifarkas has joined #openstack-ironic08:27
*** takadayuiko has quit IRC08:34
*** teju has joined #openstack-ironic08:37
*** dtantsur|afk is now known as dtantsur08:37
dtantsurMorning Ironic08:37
*** Nisha has joined #openstack-ironic08:38
*** saripurigopi has joined #openstack-ironic08:39
*** oomichi_ has joined #openstack-ironic08:40
*** achanda has quit IRC08:42
*** rameshg87 has joined #openstack-ironic08:46
*** achanda has joined #openstack-ironic08:49
*** bauzas has joined #openstack-ironic08:50
openstackgerritDmitry Tantsur proposed stackforge/ironic-discoverd: setup.py to work without requirements.txt  https://review.openstack.org/15860908:54
*** jistr has joined #openstack-ironic08:54
*** erwan_taf has joined #openstack-ironic08:55
openstackgerritDmitry Tantsur proposed stackforge/ironic-discoverd: setup.py to work without requirements.txt  https://review.openstack.org/15860908:55
*** pradipta has quit IRC08:59
*** yarker has quit IRC09:04
*** teju has quit IRC09:05
*** rfchapman has quit IRC09:05
*** achanda has quit IRC09:06
*** lucasagomes has joined #openstack-ironic09:11
openstackgerritMerged stackforge/ironic-discoverd: setup.py to work without requirements.txt  https://review.openstack.org/15860909:13
*** vdrok_afk is now known as vdrok09:16
vdrokmorning ironic09:16
*** viktors|afk is now known as viktors09:20
*** derekh has joined #openstack-ironic09:20
*** romcheg has joined #openstack-ironic09:21
rameshg87lucasagomes, hi09:22
gilliardGood morning Ironic ;)09:22
openstackgerritVladyslav Drok proposed openstack/ironic: Support for non-Glance image references  https://review.openstack.org/13674109:22
rameshg87morning vdrok, gilliard, dtantsur, lucasagomes :)09:22
dtantsuro/09:22
vdrokmorning rameshg87, gilliard, dtantsur, lucasagomes09:23
lucasagomesmorning all :)09:24
*** ndipanov has quit IRC09:30
*** ndipanov has joined #openstack-ironic09:30
*** MattMan has quit IRC09:32
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Add the image extension (for local boot)  https://review.openstack.org/15746909:36
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Add iscsi extension  https://review.openstack.org/15572709:36
*** openstackgerrit has quit IRC09:36
*** MattMan has joined #openstack-ironic09:36
saripurigopiare there any guide lines for writing the mock tests for new driver?09:36
*** openstackgerrit has joined #openstack-ironic09:36
lucasagomessaripurigopi, not really :( I would use other drivers tests as an example tho09:43
saripurigopilucasagomes, :-)  I'm doing the same, just wanted to know.09:44
lucasagomesack :)09:44
rameshg87lucasagomes, hey09:53
lucasagomesrameshg87, hi there09:55
rameshg87lucasagomes, i wanted to check regarding root device hints09:56
rameshg87lucasagomes, i see you are planning to do this in dib - https://review.openstack.org/#/c/142178/2/elements/deploy-ironic/init.d/70-ironic-root-device09:56
openstackgerritNaohiro Tamura proposed openstack/ironic: Fix reboot logic of iRMC Power Driver  https://review.openstack.org/15861409:56
rameshg87lucasagomes, just a min, i think i jumped in too soon09:58
*** jcoufal has quit IRC09:59
*** jcoufal has joined #openstack-ironic09:59
lucasagomesrameshg87, right, I gotta a patch on DIB09:59
lucasagomesI need to polish it up but it works09:59
lucasagomesrameshg87, I want to do it in IPA too10:00
rameshg87lucasagomes, i had a question on how you get wwn.10:00
lucasagomesrameshg87, lsblk?10:00
rameshg87lucasagomes, yeah10:00
rameshg87lucasagomes, but i think i figured out. i am writing some functional tests in proliantutils module10:01
rameshg87lucasagomes, so i will assert that what wwn i get from hp utility is same as what is reported by lsblk10:01
lucasagomesrameshg87, http://paste.openstack.org/show/181114/ the options from lsblk10:01
lucasagomesah nice, ok :)10:01
lucasagomesyeah that should work10:02
rameshg87lucasagomes, https://review.openstack.org/#/c/158122/1/proliantutils/functests/test_hpssa.py L9810:02
*** athomas has quit IRC10:02
rameshg87lucasagomes, i will assert size and wwn reported by our tool and lsblk are same.10:03
*** pelix1 has joined #openstack-ironic10:03
rameshg87lucasagomes, so it matches when ironic tries to use them later on10:03
lucasagomes+1!10:04
openstackgerritImre Farkas proposed stackforge/ironic-discoverd: eDeploy plugin to expose cmdb data  https://review.openstack.org/15861810:04
lucasagomesrameshg87, I will polish that DIB patch as soon as I get some time10:04
lucasagomesthe comments are most about bash style etc10:04
*** harlowja_away has quit IRC10:04
*** pelix1 is now known as pelix10:04
rameshg87lucasagomes, great .. thanks :)10:13
rameshg87lucasagomes, wwn is always an 16-byte number ? any idea ?10:14
rameshg87lucasagomes, our tool returned unique identifier as "600508B1001C456EF1BDF9C0605EF7DD"10:14
rameshg87lucasagomes, where as lsblk returned WWN="0x600508b1001c456e"10:14
lucasagomesrameshg87, hmm gotta check it out10:14
rameshg87lucasagomes, first 16-bytes seem to be same :) o10:15
rameshg87okay:)10:15
lucasagomesmaybe we should normalize it too, like before passing to the ramdisk?10:15
lucasagomeslike first 16 hex10:15
rameshg87lucasagomes, what does normalize mean here ?10:15
lucasagomeslower case10:15
rameshg87lucasagomes, okay10:15
lucasagomesand I we do the same on the ramdisk side10:16
rameshg87lucasagomes, so ramdisk would expect 0x prefix as well, right ?10:16
lucasagomesrameshg87, right now yes, but we can sync it10:16
rameshg87lucasagomes, okay10:16
lucasagomescause right now I just test against the lsblk output10:16
rameshg87lucasagomes, yeah, okay10:16
rameshg87lucasagomes, please have a look at when you get some time: https://review.openstack.org/#/c/156587/10:21
rameshg87lucasagomes, the root partition should be made bootable fix :)10:21
rameshg87lucasagomes, i changed it to do only for localboot10:21
lucasagomesoh sure will do10:22
openstackgerritShivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node  https://review.openstack.org/15573110:25
*** erwan_taf has quit IRC10:26
*** erwan_taf has joined #openstack-ironic10:27
*** yog_ has quit IRC10:28
openstackgerritMerged stackforge/proliantutils: HPSSA: RAID creation should return current config  https://review.openstack.org/15803310:30
*** ndipanov has quit IRC10:32
openstackgerritMerged openstack/ironic: Update the states generator and regenerate the image  https://review.openstack.org/15810210:44
*** ndipanov has joined #openstack-ironic10:46
*** takadayuiko has joined #openstack-ironic10:51
*** yuanying has quit IRC10:56
*** ramineni has quit IRC11:04
*** subscope has quit IRC11:05
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: Add disk allocator  https://review.openstack.org/15805211:06
openstackgerritMerged openstack/ironic: Minor changes to InspectInterface  https://review.openstack.org/15843611:16
*** subscope has joined #openstack-ironic11:17
openstackgerritLucas Alvares Gomes proposed openstack/ironic: PXE drivers support for IPA  https://review.openstack.org/15572811:22
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Local boot support for IPA  https://review.openstack.org/15772311:22
openstackgerritLucas Alvares Gomes proposed openstack/ironic: PXE driver: Deprecate pxe_deploy_{ramdisk, kernel}  https://review.openstack.org/15864411:22
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: Fixes for issue found during functional testing  https://review.openstack.org/15864511:23
*** pensu has quit IRC11:23
mrda.11:29
openstackgerritMichael Davies proposed openstack/ironic: Add support for 'latest' in microversion header  https://review.openstack.org/15860111:29
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: Fixes for issue found during functional testing  https://review.openstack.org/15864511:34
*** Nisha has quit IRC11:34
*** naohirot has joined #openstack-ironic11:38
openstackgerritVladyslav Drok proposed openstack/ironic: Support for non-Glance image references  https://review.openstack.org/13674111:40
*** GheRivero has quit IRC11:41
*** GheRivero has joined #openstack-ironic11:41
openstackgerritMichael Davies proposed openstack/ironic: Add support for 'latest' in microversion header  https://review.openstack.org/15860111:45
openstackgerritRamakrishnan G proposed stackforge/proliantutils: HPSSA: Add functional tests for create  https://review.openstack.org/15812211:46
*** rameshg87 has quit IRC11:47
*** Nisha has joined #openstack-ironic11:49
*** saripurigopi has quit IRC11:49
openstackgerritMichael Davies proposed openstack/ironic: Add support for 'latest' in microversion header  https://review.openstack.org/15860111:54
openstackgerritLucas Alvares Gomes proposed openstack/ironic: PXE drivers support for IPA  https://review.openstack.org/15572811:54
openstackgerritLucas Alvares Gomes proposed openstack/ironic: PXE driver: Deprecate pxe_deploy_{ramdisk, kernel}  https://review.openstack.org/15864411:54
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Local boot support for IPA  https://review.openstack.org/15772311:54
*** chlong has joined #openstack-ironic11:56
*** kbs has joined #openstack-ironic12:02
*** oomichi_ has quit IRC12:21
*** takadayuiko has quit IRC12:29
lucasagomesjroll, JayF bug on devstack + agent https://bugs.launchpad.net/devstack/+bug/142505912:32
openstackLaunchpad bug 1425059 in devstack "Ironic: IPA fails to build the ramdisk" [Undecided,New]12:32
lucasagomesright now our guidelines inlcude "IRONIC_BUILD_DEPLOY_RAMDISK=False" so we download the ramdisk, but building it with devstack is not working :( I will take a look when I get some time too12:33
lucasagomesjust pinging you to see if u have any idea, the log is in the bug ticket12:34
*** lucasagomes is now known as lucas-hungry12:36
*** chlong has quit IRC12:44
*** dlpartain has joined #openstack-ironic12:46
*** dlpartain has quit IRC12:55
*** athomas has joined #openstack-ironic12:56
*** Nisha has quit IRC12:57
*** jjohnson2 has joined #openstack-ironic12:58
*** lazy_prince is now known as killer_prince12:59
openstackgerritMerged openstack/ironic: Ensure state values are 15 characters or less  https://review.openstack.org/15839313:02
*** yog_ has joined #openstack-ironic13:04
jrollmorning all :)13:06
TheJuliagood morning13:06
jrolllucas-hungry: looks like your dns is bad or archive.ubuntu.com is down... dunno what you want me to do :P13:07
openstackgerritDmitry Tantsur proposed openstack/ironic: WIP: add module for in-band inspection using ironic-discoverd  https://review.openstack.org/15656213:12
dtantsurjroll, TheJulia, morning13:16
jrollmorning dtantsur13:16
*** dprince has joined #openstack-ironic13:18
lucas-hungryjroll, heh nothing, just pointing you to the bug13:27
lucas-hungryjroll, it's odd because I can build the ramdisk when not running with devstack13:28
lucas-hungryon the same machine13:28
*** lucas-hungry is now known as lucasagomes13:28
lucasagomesso that's why I think it's a devstack misconfiguration or something13:28
jrolllucasagomes: hrm, I did a recheck on an ipa patch to see if this is working in the gate13:28
jrolllucasagomes: I just assume fedora null-routes archive.ubuntu.com :P13:29
lucasagomeslol13:29
lucasagomesmaybe :P13:29
jrolllucasagomes: this is the patch I rechecked https://review.openstack.org/#/c/157768/13:30
lucasagomesjroll, but you build the ramdisk in gate? or it downloads it?13:31
jrolllucasagomes: in ipa, we build it13:31
jrollor for ipa patches13:31
jrollwe build from source13:31
jrollthen after merge we build and upload a new ramdisk13:32
jrolland ironic patches download that13:32
lucasagomesI see, but it doesn't run with devstack does it?13:33
jrollmmm.13:33
jrollwell, yes it does13:33
jrollthe agent_ssh-src job runs devstack13:33
lucasagomesI see, it may be on fedora only then :(13:34
lucasagomesI will take a look later see if I can find something13:34
*** ChuckC has joined #openstack-ironic13:45
*** kbs has quit IRC13:49
*** rloo has joined #openstack-ironic13:54
*** kbs has joined #openstack-ironic13:54
*** dlpartain has joined #openstack-ironic14:02
*** dlpartain has left #openstack-ironic14:02
*** rameshg87 has joined #openstack-ironic14:20
*** rameshg87_ has joined #openstack-ironic14:28
lucasagomescheck-tempest-dsvm-ironic-pxe_ssh: SUCCESS, gate fixed for the IPA patches :D14:29
*** rameshg87 has quit IRC14:31
trowndtantsur: is the func test on ironic-discoverd failing for you on master?14:34
* dtantsur is checking14:35
dtantsurtrown, no. are you sure you got the latest master?14:35
trownI just did a `git remote update; git pull` might be something odd here14:36
dtantsurtrown, what's your current commit and what's an error?14:37
trowndtantsur, the problem was between the keyboard and chair14:38
*** BadCub has joined #openstack-ironic14:38
trownI must have missed git pull14:38
BadCubMorning Ironic14:38
dtantsurheh these Tuesday qualifies as Monday :D14:38
dtantsurBadCub, morning14:39
dtantsur* these = this14:39
trownhehe14:39
victor_lowtherMorning Ironic14:39
dtantsurvictor_lowther, morning14:39
openstackgerritVictor Lowther proposed openstack/ironic: Add DRAC BIOS config vendor passthru API  https://review.openstack.org/15048814:40
*** jlvillal_sfo_air has joined #openstack-ironic14:40
rloomorning trown, BadCub, victor_lowther, lucasagomes, dtantsur14:41
*** jlvillal_sfo_air is now known as jlvllal_rem14:41
lucasagomesrloo, morning14:41
rloodtantsur: if this is monday, you going to work on friday too? :-)14:41
jlvllal_remIs the tip broken?  Or is it just my tests which are failing?14:41
victor_lowtherif I could get some reviews on https://review.openstack.org/150488, that would be awesome.14:41
rloojlvllal_rem: i noticed one of your patches failing. are there others?14:41
trownrloo, good morning14:42
jlvllal_remrloo: I think that might be on the python-ironicclient.  The py34 test seems to die.14:42
jlvllal_remBut I am more concerned with 'ironic'.14:42
jlvllal_remI will try a fresh clone and see what happens.  I am getting an error at the moment14:43
rloojlvllal_rem: so your unit tests are failing?14:43
jlvllal_remrloo: Yes.  And I did a 'git reset --hard' to get to the tip and still failing.14:44
jlvllal_remSo I am doing a fresh 'git clone' and new tox run.14:44
rloojlvllal_rem: maybe rebuild your tox environment?14:44
jlvllal_remI will see what happens14:44
rloojlvllal_rem: ok. I just tried it on my dev, and it works. I think I rebuilt tox yesterday.14:45
jlvllal_remrloo: Okay great :)14:45
rloojlvllal_rem: things could break if an updated 3rd party package was released14:45
jlvllal_remThanks.  And you did a 'git pull'14:45
rloojlvllal_rem: yup.14:45
jlvllal_remGreat.  Thanks!14:45
jlvllal_remAnd it worked for me to.  I guess my environment got funky14:46
rloogood, that was an easy one to fix ;)14:46
vdrokmorning everyone14:46
jlvllal_remrloo: But the python-ironicclient gate seems broken.  On the py34 test.14:46
jlvllal_remMaybe that has been fixed in the last 10 hours.14:47
rloojlvllal_rem: yeah. I -1'd that patch so why don't you fix it and try again. i don't have a py34 environment to try. it seems odd that it is consistently failing there. makes me think it has something to do with the change although i don't see how.14:47
vdrokThere is a question - it seems that at the moment we cannot download images without using cache for pxe driver14:47
vdrokhttps://bugs.launchpad.net/ironic/+bug/142510514:48
openstackLaunchpad bug 1425105 in Ironic "Node can not be deployed if image cache is not used" [Undecided,New] - Assigned to Vladyslav Drok (vdrok)14:48
rloovdrok: thx for fixing it ;)14:48
vdrokShould we restore this possibility?14:48
vdrokrloo, I have not fixed it yet :)14:48
vdrokrloo, I don't know should it be fixed or maybe that part of code can be removed14:49
jlvllal_remrloo: Thanks for the catch on E711.  The perils of cut-n-paste14:49
rloovdrok: oh, you just reported that bug. I thought it had already been triaged etc.14:49
openstackgerritJohn Trowbridge proposed stackforge/ironic-discoverd: Change utils.get_ipmi_address(node) to always return IPv4 address  https://review.openstack.org/15701214:49
rloovdrok: why does it matter. why would you NOT want to use the cache?14:50
jrollyeah, I'd like to hear a use case on that14:50
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient: For flake8 check, make the 'E12' ignore be more granular  https://review.openstack.org/15792914:50
jrollmorning jlvllal_rem vdrok rloo :)14:50
rloomorning jroll14:51
vdrokI don't know, maybe if I do deployment only once?14:51
vdrokmorning jroll14:51
vdrokthis code for some reason allows it https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/image_cache.py#L89-L9714:51
jlvllal_remjroll: morning14:52
vdrokoh, and morning rloo :)14:52
rlooafternoon vdrok!14:52
vdrokmorning jlvillal_rem14:52
mdboothjroll devananda: Do you have a moment to review https://review.openstack.org/#/c/158269/1, at least to express an opinion on whether it would interfere with Ironic?14:53
dtantsurrloo, o/14:53
rloovdrok: the code does change over time. I don't know the history/reason for that, so I can't answer. I suppose one could just delete that 'if' part if it never gets there14:55
rloovdrok: on the other hand, if in the future, someone has a usecase for not using the cache, that code might be useful. dunno.14:55
rloovdrok: so I don't see that the bug you opened is a bug. It just describes a behaviour of what the code is doing. It doesn't say why it shouldn't do that.14:56
NobodyCamgood morning Ironicers, says the man make'n coffee14:57
*** jjohnson2 has quit IRC14:57
jrollmdbooth: I haven't had enough coffee yet. ComputeNode.host == CONF.host, yes?14:57
*** kbs has quit IRC14:57
mdboothjroll: ack14:57
jrollcool14:57
vdrokrloo, yeah, right, at first I though it's broken because we don't check that we can write to dest if it exists, but then I tried to deploy without cache and got this problem instead14:57
*** killer_prince is now known as lazy_prince14:58
rloovdrok: so the code isn't easily understandable :-(14:58
jrollmdbooth: +1'd, it won't break *my* deployment, I'm not sure about others but I think it's fine14:58
mdboothjroll: Cool, honesty in review :)15:00
jrollyep :)15:01
*** jrist-afk is now known as jrist15:03
naohirotgood morning all15:03
NobodyCammorning naohirot :)15:03
naohirotNobodyCam: Hi15:03
NobodyCam:)15:03
naohirotNobodyCam: I'd like to consult with you about iRMC priority15:04
openstackgerritJohn L. Villalovos proposed openstack/ironic: iLO implementation for hardware inspection  https://review.openstack.org/15159615:05
naohirotNobodyCam: I noticed that it seems iRMC has the lowest priority15:05
jrollnaohirot: devananda sets priorities15:05
naohirotjroll: Okay, maybe I need to talk to devananda, but15:06
naohirotjroll: NobodyCam: You know, my mission is to put fujitsu driver into the ironic15:06
*** alexpilotti has quit IRC15:07
naohirotjogo: NobodyCam: I need to hear from core team how this priority set.15:07
naohirotnaohirot: sorry s/jogo/jroll/15:08
NobodyCamnaohirot: Jroll is core :)15:08
naohirotNobodyCam: Yes, I know15:08
NobodyCamand he is correct devananda set the priority15:08
jrollI don't understand the question15:08
NobodyCam:)15:08
naohirotjroll: I need to explain why and how iRMC got the current priority.15:09
naohirotjroll: to my company.15:09
*** kbs has joined #openstack-ironic15:09
naohirotjroll: I don't have any information.15:09
NobodyCamnaohirot: are you getting this from the Ironic Priorities & Planning spreed sheet?15:10
naohirotjroll: From my point of view, everything has been decided in the place I cannot take part in.15:10
jrollnaohirot: then ask devananda, he sets the priorities. to the best of my knowledge, we don't have secret meetings or anything to decide them.15:11
jrollif we do have them, then 1) I wasn't invited; and 2) that's bad and we should feel bad15:11
naohirotNobodyCam: the priority sheet is also the source , but main source is https://launchpad.net/ironic/+milestone/kilo-315:11
jrollholy cow, we have so much work to do15:12
rloojroll, naohirot: I think that is a fair question. How are the priorities set?15:12
* jroll is scared15:12
jrollrloo: devananda clicks things.15:12
dtantsurI don't really disagree with drivers having lower priorities15:13
jrollI assume they are based on things like, how many deployers will use this feature, etc15:13
dtantsurwe have too many principal things to work on/introduce etc15:13
rloojroll: I understand. but clearly people want to know.15:13
jrollright. should ask deva.15:13
naohirotdtantsur: my manager ask that why irmc has lower priority than iLO, AMT, or Drac.15:14
rlooif left to me, the high priority things are infrastructure things. then the drivers. and I'd like to put some sort of tariff on the drivers; they need to participate in X reviews, for one review from me.15:14
rloobut that's what I think internally, that isn't what I do ;)15:14
NobodyCamnaohirot: I believe the priorities are set on several factors, Importance to project, closeness to completition, amount of time needed to review, amount others (i'm sure)15:14
BadCubI think NobodyCam's assumption to be pretty much on target15:15
NobodyCamnaohirot: just because I item does not have a high priority does not mean it won't land15:15
naohirotNobodyCam: If so, I need those information to convince myself and my company.15:15
NobodyCamthat information is for the reviewers to plan there reviews15:15
rlooNobodyCam: it doesn't mean it won't land, but the chances are lower because eg I don't have time to review all this stuff, so I'll review the higher priority things.15:15
dtantsurnaohirot, to be honest I never care about priorities in Launchpad when reviewing, so please don't overestimate them15:16
rloonaohirot: you and everyone else can help by reviewing too. I'd like to see more reviewers that are non-core-reviewers.15:16
naohirotNobodyCam: You know I submitted spec and code pretty much earlier, and revised as quickly as possible if I got comments.15:16
NobodyCamrloo: yes, higher protity items are most likly "more difficult" to review15:16
jrollyeah, I try to ignore priority as well15:17
NobodyCamnaohirot: yes I do know.15:17
naohirotdtantsur: But my company is really cares about :)15:17
devanandanaohirot: because irmc has already landed a driver this cycle, so I feel the remaining work (vmedia support), while good, is lower priority than getting some attention for the ilo and drac drivers15:18
jrollnaohirot: as I understand it, priorities are just like... how critical to the project, etc. iRMC is not as critical to making ironic useful as say, cleaning or RAID15:18
dtantsurnaohirot, every company wants its stuff to land asap :) and I don't know why ilo is higher than irmc, but I do understand why generic changes and generic drivers are higher15:18
NobodyCamgood morning devananda :)15:18
devanandanaohirot: for comparison, in k1 and k2 cycles, we completed 5 and 4 blueprints, respectively15:18
jrollmorning deva :)15:18
NobodyCammorning dtantsur :)15:18
dtantsurmorning, NobodyCam, devananda15:18
devanandanaohirot: we have 23 targeted to k3 ....15:18
BadCubmorning devananda15:18
naohirotdevananda: good morning :)15:18
devanandaI am still revising priorities as well15:19
naohirotdevananda: My company planned everything based on Kilo has iRMC 3 drivers.15:20
devanandanaohirot: as others have said, the priority is an indication from me to reviewers that "hey, this is more important to making Ironic as a whole project better, please spend more time over here"15:21
devanandathere are certain features which I personally really want, because my team needs them, which I've set as LOW proirity. for example, non-glance image refs15:21
devanandanaohirot: your company should not plan based on expectations about a community project15:22
naohirotdevananda: Okay, I understand your intention about the priority15:22
devanandanaohirot: you, like every other company, are participating in a community project. the best way to get your work landed is to help others land their work by reviewing it15:23
naohirotdevananda: As you know that company needs some reason when company change their plan.15:23
*** devlaps has joined #openstack-ironic15:24
devanandanaohirot: sure. there's nothing preventing it from landing in kilo15:24
*** devlaps has quit IRC15:24
naohirotdevananda: are you saying that nothing prevent from landing iRMC in kilo?15:25
devanandanaohirot: that is what I said15:25
naohirotdevananda: for instance, when iRMC management driver bumped from kilo-2 to kilo-3, I could not answer to my manager why it happened.15:26
naohirotdevananda: I'm realy worry about happing same thing from kilo-3 to L series.15:27
dtantsurnaohirot, because we have too many things to review and land... to top it all some people have their own priorities, which is unavoidable, as we all work for some company :)15:27
rloohonestly. let's be realistic here. I will be. I only have so much time, and I can only review so much. So I tend to review based on priority. which to me means that I most likely will NOT get to naohirot's changes.15:28
devanandanaohirot: it bumped from k2 to k3 for a very simple reason -- it was not landed when the k2 deadline arrived15:28
naohirotdevananda: I know that core team is busy, therefore we need to discuss the priority and need consensus about the priority15:29
devanandanaohirot: code reviews take a lot of time. the core team is small and has a HUGE amount of reviews to do. if you want your code to land faster, you should review other developers' code too15:29
naohirotdevananda: Yes, I'll do that, no problem :)15:30
naohirotdevananda: I submitted my code as earlier as possible, so that core team can review enough before the dead line.15:31
naohirotdevananda: I think iRMC management code reached to certain level of quality, I tested it with Power driver using several fujitsu servers.15:33
*** anderbubble has joined #openstack-ironic15:36
*** dprince has quit IRC15:36
*** jcoufal has quit IRC15:37
naohirotdevananda: I'd like you to review the management code before really you become busy for kilo-3 deadline15:37
*** jcoufal has joined #openstack-ironic15:37
*** absubram has joined #openstack-ironic15:37
*** jlvllal_rem has quit IRC15:40
*** mgoddard1 has joined #openstack-ironic15:41
* naohirot good night all15:42
*** naohirot has quit IRC15:42
*** mgoddard has quit IRC15:43
*** david-lyle_afk is now known as david-lyle15:47
openstackgerritJohn Trowbridge proposed stackforge/ironic-discoverd: Change utils.get_ipmi_address(node) to always return IPv4 address  https://review.openstack.org/15701215:48
rloovdrok: are you OK if I change your bug to invalid? https://bugs.launchpad.net/ironic/+bug/142510515:54
openstackLaunchpad bug 1425105 in Ironic "Node can not be deployed if image cache is not used" [Undecided,New] - Assigned to Vladyslav Drok (vdrok)15:54
*** hj-hp has joined #openstack-ironic15:55
vdrokrloo, idk, if you think that this functional is not needed then yes, i'll just put up a patch removing the code15:56
rloovdrok: i don't even know that we should delete the code.15:56
vdrokrloo, i'll do it tomorrow, so we can wait to see what others think15:57
vdrokrloo, but if you want, go ahead :)15:58
rloovdrok: for the reason that if you write a method 'foo' that does x or y, and method 'bar' calls 'foo' but only ever causes x, does that mean y should be deleted?15:58
vdrokrloo, also because it seems that that piece does not work even if gets called15:59
vdrokrloo, on rebuild15:59
rloovdrok: ok, if that piece doesn't work, then yes, it should be deleted ;)16:00
vdrokrloo, I'll update the decription to be a bit clearer16:00
rloovdrok: in that case, you could reword the bug to say that it doesn't work even if it was possible to invoke it, so it should be deleted ;)16:01
rloovdrok: thx16:01
vdrokrloo, np16:01
rameshg87_devananda, dtantsur, shouldn't we just lay down some better rules for vendor drivers16:02
rameshg87_devananda, dtantsur, just a suggestion16:02
rameshg87_devananda, dtantsur, for example: https://review.openstack.org/#/c/152857/5/ironic/drivers/modules/amt/management.py16:02
*** coolsvap is now known as coolsvap_16:02
rameshg87_nobody much gets what's _set_boot_device_order _enable_boot_config16:02
rameshg87_unless they know about amt hardware16:03
rameshg87_shouldn't the stuffs like set_boot_device, get_boot_device() be just a call to some library of the vendor module16:03
rameshg87_all these stuffs can stay there making the ironic driver module much simpler and easy to review16:04
rameshg87_wdyt ?16:04
NobodyCamlucasagomes: is the Expose configdrive stuff all wrapped up? all reviews taged to the BP are merged!16:10
jlvillalrloo: Any chance that the python34 test is broken on the python-ironicclient project?16:10
rloojlvillal: no idea. did it fail again?16:10
jlvillalrloo: I'm just not sure how the config change to flake8 would break python34.16:10
jlvillalYes :(16:10
lucasagomesNobodyCam, hey yes16:10
lucasagomesNobodyCam, well need docs16:10
rloojlvillal: take a look at some other patches to the client to see if they failed too.16:10
lucasagomesI will put some docs up, but code-wise it's good :)16:10
jlvillalrloo: And if so, who can fix it?16:10
NobodyCamahh okay I'll update the spreed sheet16:10
NobodyCam:)16:11
rloojlvillal: infra folks16:11
jlvillalrloo: Thanks16:11
devanandalucasagomes: and testing?16:11
lucasagomesdevananda, tempest tests? yeah hmm I could add that too16:11
devanandalucasagomes: ta :)16:11
lucasagomesdevananda, lemme right down16:11
lucasagomesdevananda, btw, re IPA, gate patch is now merged and patches are passing16:12
rloojlvillal: looks like there is something wrong there. I see another patch failed there too.16:12
rloohttps://review.openstack.org/#/c/158520/16:12
lucasagomesyou prefer to create a new job to test the IPA ramdisk, or switch from the existing one?16:12
jlvillalrloo: Agreed16:12
* lucasagomes is working on the devstack integration16:12
lucasagomesNobodyCam, also, local boot need docs too :)16:13
lucasagomesand root device hints16:13
*** dprince has joined #openstack-ironic16:13
*** MattMan has left #openstack-ironic16:13
lucasagomesit's on my todo list, but I've been busy with some other bits and didn't put a patch up for that yet16:13
jlvillalrloo: I'm asking over on #openstack-infra to see if anyone can help.  Not sure if there is a particular person I should ping.16:13
*** MattMan has joined #openstack-ironic16:13
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/15875016:14
openstackgerritShivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node  https://review.openstack.org/15573116:16
jrolljlvillal: 2015-02-24 15:37:27.114 | Build timed out (after 40 minutes). Marking the build as failed.16:17
NobodyCamdevananda: I'm going to add "Doc's" t the priorities and planning spread sheet?16:17
jrollmakes me hrm16:17
jlvillaljroll: I'm over in #openstack-infra asking guy16:17
jrollyeah, I see now16:18
jrollI don't think it's an infra problem16:18
jlvillalHe is suggesting that something is wrong with the package.  I'm thinking huh?16:18
openstackgerritShivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node  https://review.openstack.org/15573116:18
jrollclarkb is pretty good at this stuff fwiw :P16:18
jrollit's likely a dependency that was updated16:18
jrolldid you run tox -r -epy34 locally?16:18
jlvillaljroll: Not yet.  My system didn't have python 3416:19
openstackgerritLucas Alvares Gomes proposed stackforge/ironic-discoverd: eDeploy plugin to not overwrite node's capabilities  https://review.openstack.org/15875716:19
jlvillalI will try on my Trusty system16:19
jrollyeah, I'd do that first16:19
*** rameshg87_ has quit IRC16:19
jrollI actually kind of wonder if testr is broken on 3.4, but kind of doubt it16:19
* lucasagomes thinks he have seen a problem with mock and 3.416:22
lucasagomesseems fixed now: https://bugs.launchpad.net/ubuntu/+source/python-mock/+bug/128374216:23
openstackLaunchpad bug 1283742 in python-mock (Ubuntu Trusty) "python-mock tests fail with python3.4" [High,Fix released] - Assigned to Barry Warsaw (barry)16:23
NobodyCamdtantsur: just checking on 156562... woundering when it will be ready to un-WIP?16:23
dtantsurNobodyCam, today-tomorrow when I write some tests and also test it in real world. Actually it should be rebased on top of Nisha's last patch, so that we can test it...16:24
dtantsurNobodyCam, but you review would help ;)16:24
NobodyCam:) ack will do :)16:25
NobodyCamand awesome thank you :)16:25
*** vdrok is now known as vdrok_afk16:25
openstackgerritMerged stackforge/ironic-discoverd: Change utils.get_ipmi_address(node) to always return IPv4 address  https://review.openstack.org/15701216:29
*** jcoufal has quit IRC16:30
jlvillaljroll: Am I doing something wrong?  http://paste.openstack.org/show/181310/   My command: tox -v -v -epy3416:31
jlvillaljroll: I snipped out the stuff before the error.16:32
jrolljlvillal: interesting, not sure16:32
jrollI wonder if it's using 2.7 pbr or pip or something16:32
jlvillaljroll: This is Ubuntu 14.04.  Has been updated16:32
jrolldunno, I don't tend to run 3.4 locally :/16:33
jrollor httpretty is broken or something16:33
jlvillaljroll: Me either :)  It is Python 3.4.016:33
* jroll distracted atm16:33
jlvillaljroll: Okay.  Thanks16:33
NobodyCamdtantsur: quick question: on line 132 of https://review.openstack.org/#/c/156562/3/ironic/drivers/modules/discoverd.py16:33
NobodyCamwhy id and uuid?16:34
*** lazy_prince is now known as killer_prince16:35
*** jcoufal has joined #openstack-ironic16:37
dtantsurNobodyCam, copy-paste to the win! :)16:44
NobodyCam:)16:45
NobodyCamheheh I commented on it16:45
NobodyCamoverall LGTM... couple of nits :-p16:45
dtantsuryeah thanks!16:45
*** jcoufal has quit IRC16:47
*** jcoufal has joined #openstack-ironic16:57
*** mgoddard1 has quit IRC16:58
*** mgoddard has joined #openstack-ironic16:59
openstackgerritDmitry Tantsur proposed openstack/ironic: WIP: add module for in-band inspection using ironic-discoverd  https://review.openstack.org/15656217:06
dtantsurwill be finishing ^^^ tomorrow17:06
NobodyCam:)17:07
NobodyCamyou out for the rest of the day dtantsur ?17:07
dtantsurNobodyCam, yeah, it's 6pm and it's that kind of Tuesday that feels like Monday17:07
dtantsurso I'm finishing here17:07
NobodyCamhave a great night dtantsur :)17:07
dtantsurg'night17:08
*** dtantsur is now known as dtantsur|afk17:08
*** romcheg has quit IRC17:15
openstackgerritLucas Alvares Gomes proposed stackforge/ironic-discoverd: eDeploy plugin to not overwrite node's capabilities  https://review.openstack.org/15875717:17
*** jistr has quit IRC17:18
*** rwsu-afk is now known as rwsu17:18
*** erwan_taf has quit IRC17:19
*** coolsvap_ is now known as coolsvap17:20
lucasagomeswhen people get some time and wants to review something in IPA please take a look at https://review.openstack.org/#/c/155727/17:22
lucasagomesthanks :)17:22
NobodyCamlucasagomes: I'll take a look in a couple of minutes17:22
lucasagomesNobodyCam, cheers, no rush17:22
lucasagomesI'm working on the devstack now to enabled IPA + pxe_ssh to run17:23
openstackgerritMerged openstack/ironic: Add tests for ilo_deploy driver  https://review.openstack.org/14298517:23
lucasagomesso you guys can test it as well17:23
devanandalucasagomes: what's the status of the switch to IPA in our gate?17:23
devanandalucasagomes: is there a patch up for devstack or ...?17:23
lucasagomesdevananda, should be all good17:23
lucasagomesdevananda, working on that now17:23
lucasagomesso gate is unblocked now, we get our 1G17:24
lucasagomesdevananda, question is, are we creating a new job? or replacing the existing one with IPA?17:24
devanandacool. ya, saw that land17:24
devanandalucasagomes: oh. so dib should still run the old job in their gate17:24
lucasagomesI will create a switch on devstack IRONIC_USE_IPA_RAMDISK=True/False17:24
lucasagomesdevananda, yeah, let's create another job for the IPA ramdisk, so we keep both running17:25
lucasagomesrunning = being tested17:25
lucasagomesdevananda, btw if u wanna try locally, should be fairly easy17:25
devanandajroll: planning to attend the cross project meeting today?17:26
devanandajroll: there's going to be a discussion about release cycle management / cadence. based on your comments yesterday, you might be interested17:26
*** penick has joined #openstack-ironic17:26
jrolldevananda: I have a conflict :/17:26
jrollbut I'll be lurking17:26
devanandajroll: see https://wiki.openstack.org/wiki/Release_Cycle_Management/Liberty_Tracking17:26
lucasagomesapply this to ironic https://review.openstack.org/#/c/155728/17:27
lucasagomesbuild the IPA image with https://review.openstack.org/#/c/155727/17:27
lucasagomesand that's it, you will be able to use pxe_* with either ramdisk17:27
lucasagomesno extra config17:27
lucasagomesfor those who wants to test ^17:27
devanandaawesome17:27
*** viktors is now known as viktors|afk17:27
JoshNangsweet!17:27
jlvillaljroll: Argh, that took awhile.  So my issue was that I have LANG=C in my environment.  Once I let it default to: LANG=en_US.UTF-8  then httpretty installed.17:27
devanandaTheJulia: ^17:27
*** penick has quit IRC17:27
jrolljlvillal: fun17:28
jlvillaljroll: Now to go to the next step... :)17:28
devanandajroll: IIRC, ipa can pull an image from any source, not just glance/swift, right?17:32
*** athomas has quit IRC17:33
openstackgerritJosh Gachnang proposed openstack/ironic: Implement Cleaning in DriverInterfaces  https://review.openstack.org/15720817:35
openstackgerritJosh Gachnang proposed openstack/ironic: Implement Cleaning States  https://review.openstack.org/15344417:35
jrolldevananda: any http url17:35
devanandajroll: thought so. ty17:36
jrollnp17:36
openstackgerritMerged openstack/ironic: Fix reboot logic of iRMC Power Driver  https://review.openstack.org/15861417:38
JoshNangjroll: it does require a checksum of the image to be included though. https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/standby.py#L16517:40
jrollJoshNang: good point17:40
jrolldevananda: ^^17:40
JoshNangwe could make it only check the checksum if the key is there17:41
devanandaahh ty17:41
*** derekh has quit IRC17:44
lucasagomes[off-topic] awesome talk: http://www.ted.com/talks/miguel_nicolelis_brain_to_brain_communication_has_arrived_how_we_did_it17:45
NobodyCamJoshNang: hahah I added a comment to ps 5 of 157208 just as you pushed up ps 617:45
NobodyCam:0p17:45
JoshNangNobodyCam: ha, no worries, that's an easy fix17:46
JoshNangthanks :)17:46
NobodyCam:-p17:46
*** Marga_ has joined #openstack-ironic17:48
*** hj-hp has quit IRC17:48
*** hj-hp has joined #openstack-ironic17:49
jrollstates.VERBS are for API verbs yes?17:54
*** ParsectiX has joined #openstack-ironic17:54
lucasagomesjroll, confirmed, yeah the building IPA with devstack only affects fedora... I will investigate when I get some time17:54
jrolllucasagomes: that's really strange17:54
lucasagomesjroll, should be some fw rule, not sure17:54
lucasagomesjroll, I can build IPA on fedora, if not running with devstack :)17:55
jrolllucasagomes: you'd think if building docker ubuntu images was broken on fedora, someone would have said something17:55
jrolloh17:55
jrollgotcha17:55
jrollmaybe devstack configures docker weird17:55
lucasagomesno, it's just some odd misconfiguration that devstack might be doing on fedora17:55
lucasagomesjroll, yeah maybe that17:55
lucasagomesgotta look, but I will leave it at side for now17:56
lucasagomesthe bug is open there too if someone wants to take a look17:56
jrollI can't imagine they're firewalling archive.ubuntu.com or port 44317:57
lucasagomesjroll, yeah no idea, I worked around it by building the ramdisk myself and adding to files/*17:58
lucasagomes:)17:58
lucasagomestested on ubuntu now just to see if happens there too, but apparently not17:58
jrollyep :)17:58
lucasagomesand with that said, I will call it a day17:59
lucasagomesneed a break :)17:59
lucasagomeshave a good night everyone!17:59
lucasagomesNobodyCam, btw, lemme know if my reply satisfy ur comment in https://review.openstack.org/#/c/157723/18:00
lucasagomescheers!18:00
*** lucasagomes is now known as lucas-dinner18:00
jrollnight lucas-dinner :)18:00
*** coolsvap is now known as coolsvap_18:00
* victor_lowther ifarkas: Some replies to your comments.18:01
*** spandhe has joined #openstack-ironic18:01
NobodyCamhave a good night lucas-dinner18:03
openstackgerritJosh Gachnang proposed openstack/ironic: Missing mock causing long tests  https://review.openstack.org/15879918:03
*** Nisha has joined #openstack-ironic18:03
JoshNangeasy review ^18:03
*** jcoufal has quit IRC18:04
*** jcoufal has joined #openstack-ironic18:04
jrollJoshNang: how was that passing before :x18:04
JoshNangno idea18:04
JayFshouldn't we find out? lol18:04
JoshNangbut when i rebased one of my patches, all the sudden they were taking...quite awhile18:05
JoshNangohh, set_failed_state catching the exception if it can't power off the node18:05
jrollright, and this test expects a deploy fail18:06
jrollya18:06
JayFcool18:06
* jroll +218:06
*** ndipanov has quit IRC18:07
*** jcoufal has quit IRC18:09
jlvillaljroll: I'm going to leave it to a better developer than me to figure it out.  I have almost zero knowledge of testr, so unsure how to proceed :(  Since it is tip of tree, I would assume something in the testing environment has changed???18:09
jrolljlvillal: yeah, probably a bumped dependency tbh18:10
*** devlaps has joined #openstack-ironic18:11
*** mgoddard1 has joined #openstack-ironic18:13
*** mgoddard has quit IRC18:15
*** mgoddard1 has quit IRC18:19
*** hj-hp has quit IRC18:19
*** hj-hp has joined #openstack-ironic18:19
*** harlowja has joined #openstack-ironic18:20
*** ChuckC has quit IRC18:20
*** ChuckC has joined #openstack-ironic18:21
*** MattMan has left #openstack-ironic18:22
*** harlowja has quit IRC18:24
*** harlowja has joined #openstack-ironic18:24
NobodyCamgah: +1219 lines18:29
*** Marga_ has quit IRC18:32
rloodevananda: I'm a procrastinator. I had offered to look at resource-locking in kilo. Should I bother, or is it better for me to spend time on the existing priorities?18:32
*** Marga_ has joined #openstack-ironic18:32
*** mgoddard has joined #openstack-ironic18:32
*** Nisha_away has joined #openstack-ironic18:34
*** Nisha has quit IRC18:34
jlvillalNisha: I added some extra testing to your patch series.  Hopefully you like it :)18:35
*** penick has joined #openstack-ironic18:35
*** yginger5 is now known as yjiang518:35
*** priteau has quit IRC18:36
*** ParsectiX has quit IRC18:37
*** ParsectiX has joined #openstack-ironic18:38
*** ParsectiX has quit IRC18:41
devanandarloo: by resource locking, you mean the distributed locking with non-mysql backend?18:41
*** ParsectiX has joined #openstack-ironic18:41
rloodevananda: I mean actually looking at what was discussed at the kilo summit and seeing what might be doable18:42
devanandajroll: since you have strong feelings on it, could you go comment on 157757 in the next hour?18:42
devanandajroll: iow, before the TC meeting where we discuss it18:42
rloodevananda: https://etherpad.openstack.org/p/kilo-ironic-resource-locking18:43
devanandajroll: because folks are going to ask, very directly, why we're not proposing it to oslo18:43
devanandajroll: and I don't have strong feelings on it, so I won't defend it18:43
devanandarloo: oh, right18:43
devanandarloo: yea, punt on it. too late in the cycle now. no one felt strongly enough to write a spec or really work on it18:44
rloodevananda: yeah, I had forgotten most of that. (Good thing we took notes.)18:44
devanandarloo: except for the rackspace folks who wrote the zookeeper backend18:44
rloodevananda: ok. i'll focus on the existing priorities then.18:44
rloodevananda: thx18:44
jrolldevananda: great...18:45
* rloo thinks it sometimes helps to procrastinate18:45
devanandabbiab18:45
*** krtaylor has quit IRC18:48
*** achanda has joined #openstack-ironic18:52
*** penick has quit IRC18:53
*** penick_ has joined #openstack-ironic18:53
Nisha_awayjlvillal, there18:56
openstackgerritNisha Agarwal proposed openstack/ironic: Generic changes for Node Inspection  https://review.openstack.org/14982318:58
*** krtaylor has joined #openstack-ironic19:00
jrolldevananda: commented on 15775719:01
*** jlvillal_remote has quit IRC19:04
openstackgerritVictor Lowther proposed openstack/ironic: Add DRAC BIOS config vendor passthru API  https://review.openstack.org/15048819:14
*** Nisha_away has quit IRC19:18
*** Nisha_away has joined #openstack-ironic19:19
*** hj-hp has quit IRC19:19
*** ChuckC_ has joined #openstack-ironic19:23
*** hj-hp has joined #openstack-ironic19:24
*** penick_ has quit IRC19:24
*** ChuckC has quit IRC19:25
*** ChuckC has joined #openstack-ironic19:26
openstackgerritMerged openstack/ironic-python-agent: Add additional logging and return results for IPA extensions  https://review.openstack.org/15275519:27
openstackgerritJosh Gachnang proposed openstack/ironic: Implement Cleaning States  https://review.openstack.org/15344419:27
*** ChuckC_ has quit IRC19:28
*** hj-hp has quit IRC19:30
*** hj-hp has joined #openstack-ironic19:31
*** achanda has quit IRC19:33
*** devlaps has quit IRC19:33
*** dprince has quit IRC19:35
*** achanda has joined #openstack-ironic19:41
*** hj-hp has quit IRC19:44
*** trown is now known as trown|brb19:50
NobodyCambrb19:51
ifarkasvictor_lowther, ok, thanks! I will check it tomorrow morning20:04
*** hj-hp has joined #openstack-ironic20:13
*** hj-hp has quit IRC20:14
*** trown|brb is now known as trown20:16
*** Marga_ has quit IRC20:18
*** hj-hp has joined #openstack-ironic20:19
*** Marga_ has joined #openstack-ironic20:19
*** datajerk1 has joined #openstack-ironic20:21
*** ifarkas has quit IRC20:23
openstackgerritChris Krelle proposed openstack/ironic: Add documentation for VirtualBox drivers  https://review.openstack.org/14630720:24
*** datajerk has quit IRC20:25
*** rfchapman has joined #openstack-ironic20:26
rfchapmanHello all20:26
NobodyCamhey hey rfchapman :)20:27
openstackgerritJosh Gachnang proposed openstack/ironic: Implement Cleaning in DriverInterfaces  https://review.openstack.org/15720820:28
rfchapmanNobodyCam: is it possible for an image to become corrupted in some way?  I created a fedora 20 image several days ago and it seemed to be working with the hardware i'm using (hp dl365g1).  It was failing late into the image install but was getting futher along than it is now. Now it doesn't even complete the first stage of baremetal install.  It hangs at "uhci_hcd 0000:00:04.4: HCRESET not completed yet!"  System Halted20:28
NobodyCamrfchapman: I suppose it could :/20:30
*** hj-hp has quit IRC20:30
*** Marga_ has quit IRC20:30
openstackgerritJosh Gachnang proposed openstack/ironic: Implement Cleaning in DriverInterfaces  https://review.openstack.org/15720820:31
NobodyCamrfchapman: your not even booting into the deploy image? if I understand correct?20:31
rfchapmanNobodyCam: Yesterday it was failing at the partitioning,  I found that the disks were 73Gig drives and not 80Gig.  I created another flavor with 50gig drive and then it started haning at he forementioned spot.20:32
rfchapmanNobodyCam: correct.  I'ts the initrd that fails.20:33
NobodyCamhummm... How did you create the deployment image (kernel and ramdisk)20:33
rfchapmannothing else has changed.20:34
NobodyCammay be worth recrating20:34
NobodyCamrecreating even20:34
rfchapmanI created it with the diskimage-builder as outlined in the ironic baremetal installation page.20:36
*** faizan has joined #openstack-ironic20:39
*** Nisha_away is now known as Nisha20:40
rfchapmanNobodyCam: So you think I should re-create the image and try again?20:41
jlvillaljroll: Made a little progress.  Appears to be: ironicclient.tests.test_shell.ShellTestNoMox.test_node_list which is hanging20:42
jlvillalWhy I don't know...20:42
NobodyCamrfchapman: couldn't hurt20:42
jrolljlvillal: perhaps the client isn't mocked properly or something?20:42
jrolljlvillal: e.g. hanging trying to reach the server20:42
jlvillaljroll: I will look.  Thanks.20:42
NobodyCamrfchapman: may just reload the images in glance?20:42
jrolljlvillal: unclear why that would have ever passed but yeah20:42
rfchapmanNobodyCam: OK, I'll try that just after grab a bite to eat.  brb20:43
NobodyCam:)20:43
jlvillaljroll: The two NoMox tests seem to hang.20:44
jlvillalinvestigating...20:44
jrollmaybe mox is ded on 3.420:44
jrollor wait, that's NoMox20:44
faizandevananda: jroll: NobodyCam: hello all, Please take look at https://review.openstack.org/#/c/157636/ for adding "ironic-lib" to openstack20:45
faizanjroll: Thanks for your comments on https://review.openstack.org/#/c/157757/20:46
*** Nisha has quit IRC20:46
NobodyCamfaizan: :) will do20:47
devanandafaizan: that is going to be discussed by the TC soon, if we have time today20:47
devanandafaizan: jroll: please join #openstack-meeting -- though I'm not sure we will get to it today, so it may have to wait for next week20:48
*** marzif_ has joined #openstack-ironic20:49
jrolldevananda: I have another meeting, but I'll be lurking and may speak up20:50
jrollsometimes I wish I didn't have opinions20:50
devanandaheh20:52
mrdaMorning Ironic20:56
NobodyCammorning mrda :)20:56
devanandalooks like no time20:57
*** hj-hp has joined #openstack-ironic20:58
jrollI really don't understand the point of oslo21:01
jrollis it so that common code can have a PTL?21:02
devanandajroll: so that we don't all create different db abstraction layers21:02
devanandajroll: and different messaging layers. and different service libraries. and different config parsing code.21:02
devananda.... and ...21:02
jrollwell sure, but why does a common library need to be called oslo21:02
devanandait doesn't. unless all of openstack is going to use it21:02
mrdajroll: someone has to be responsible for, and nuture the common code21:03
devanandaif it really is just part of ironic, great - it should be in our domain21:03
devanandaif it's code that other projects will want/need, it should be in the designated place to share that sort of thing21:03
mrda...it's better than copying and pasting the same code all around the place21:03
devanandaI think that's al lthe TC folks are asking - a little diligence in answering that21:03
jrollwhy can we not have an oslo program that houses a bunch of libraries21:03
jrolland if a library starts being used by multiple projects, move it to the right umbrella21:04
devanandahuh?21:04
jrolllike21:04
jrollin this particular case:21:04
jrollput ironic-lib or whatever in ironic21:04
jrollif another project starts using it, then move it to the oslo program21:05
jrollthe name doesn't need to change21:05
*** mgoddard has quit IRC21:11
*** andreykurilin_ has joined #openstack-ironic21:12
*** faizan has quit IRC21:12
devanandaBadCub: you're missing the project meeting21:13
devanandaBadCub: and I just mentioned you21:13
jrollBadCub: he said you're bad21:13
mrdalol21:13
*** andreykurilin_ has quit IRC21:17
*** andreykurilin__ has joined #openstack-ironic21:17
BadCubdevananda I know man... I should really get up there21:17
BadCublike immediately!21:17
NobodyCamhehehe21:17
devanandaBadCub: it is in #openstack-meeting ...21:18
BadCubon my way21:18
*** ParsectiX has quit IRC21:19
openstackgerritChris Krelle proposed openstack/ironic: Root partition should be marked as bootable  https://review.openstack.org/15658721:19
*** ParsectiX has joined #openstack-ironic21:19
*** andreykurilin_ has joined #openstack-ironic21:22
*** andreykurilin__ has quit IRC21:22
*** jcoufal has joined #openstack-ironic21:25
jlvillalGheRivero: ping21:28
NobodyCamjlvillal: I hope he's sleeping now..21:29
NobodyCamI believe he's back home21:29
jlvillalNobodyCam: Okay.  I was trying to ask him or David Hu a question on a unit test in python-ironicclient.  As I think they are the authors.21:29
jlvillalAnd it is the test which seems to be hanging the Python 3.4 test.  I don't know why it is hanging.21:30
*** Marga_ has joined #openstack-ironic21:32
*** marzif_ has quit IRC21:32
*** ijw has joined #openstack-ironic21:36
*** sdake has quit IRC21:37
*** Marga_ has quit IRC21:40
*** Marga_ has joined #openstack-ironic21:41
*** ParsectiX has quit IRC21:41
*** Marga_ has quit IRC21:42
*** ParsectiX has joined #openstack-ironic21:42
*** Marga_ has joined #openstack-ironic21:42
*** Marga_ has quit IRC21:42
*** Marga_ has joined #openstack-ironic21:43
*** Marga_ has quit IRC21:44
*** Marga_ has joined #openstack-ironic21:44
*** Marga_ has quit IRC21:45
*** Marga_ has joined #openstack-ironic21:46
*** Marga_ has quit IRC21:47
*** Marga_ has joined #openstack-ironic21:47
*** sdake has joined #openstack-ironic21:47
*** sdake has quit IRC21:48
*** Marga_ has quit IRC21:51
*** Marga_ has joined #openstack-ironic21:52
*** Marga_ has quit IRC21:53
*** sdake has joined #openstack-ironic21:53
*** Marga_ has joined #openstack-ironic21:53
*** Marga_ has quit IRC21:54
*** Marga_ has joined #openstack-ironic21:54
mordredjroll: there are libs in oslo that are not called oslo22:08
mordredjroll: pbr springs to mind22:08
openstackgerritMichael Davies proposed openstack/ironic: Add support for 'latest' in microversion header  https://review.openstack.org/15860122:08
*** Hefeweizen has quit IRC22:10
*** pelix has quit IRC22:10
NobodyCammrda: oh cool ^^^^22:10
NobodyCamand hey hey mordred :)22:12
jrollmordred: that's what I'm sayin22:12
*** ijw has quit IRC22:13
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient: Do not use httpretty 0.8.7 as it breaks testing  https://review.openstack.org/15889322:19
jlvillaljroll: I think I fixed it :)  ^^^^22:20
jrollwoot22:20
jlvillalOkay, "fixed" may be too strong a word ;)22:20
* jlvillal has no idea what the the root cause of httpretty breaking is.22:21
NobodyCamdevananda: BadCub: I think the blueprint : https://blueprints.launchpad.net/ironic/+spec/irmc-virtualmedia-deploy-driver is mismarked as approved.22:21
jrollhttpretty>=0.8.0,!=0.8.1,!=0.8.2,!=0.8.3,!=0.8.722:21
jrollmust be great software22:21
NobodyCamlol22:22
NobodyCamya22:22
BadCub.me goes to look now22:22
jrollNobodyCam: agree, https://review.openstack.org/#/c/134865/ is the spec22:22
mrdajroll: Just means they made a few oopses on release22:22
mrdanot an excuse though22:23
jrollmrda: that's a lot of oppses22:23
jrollidk22:23
BadCubNobodyCam that one is not on my spreadsheet yet. hmmmm22:23
BadCubhttps://blueprints.launchpad.net/ironic/+spec/inband-raid-configuration i supdated to pending approval22:25
jlvillaljroll: :)  Probably could clean that up to say >=0.8.4,!=0.8.722:26
jrolljlvillal: meh22:26
jrolljlvillal: you may need to patch global-requirements, btw22:26
* BadCub hatesw IceChat copy/past features.22:27
jlvillaljroll: Where is that?  What is that?22:27
jrolljlvillal: uh oh22:27
jrollyou're gonna hate this22:27
* jlvillal prepares himself...22:27
jrolljlvillal: https://github.com/openstack/requirements#global-requirements-for-openstack-projects22:27
jrollso you'd have to patch https://github.com/openstack/requirements/blob/master/global-requirements.txt#L20622:28
jlvillalThere be a lot of words in that there document ;)22:28
jlvillaljroll: Okay.  I will work on a patch for that.  Thanks!22:29
BadCubNobodyCam take care of.22:30
NobodyCam:) Thank you BadCub :)22:30
jrolljlvillal: awesome, thanks :)22:30
BadCubNP. devananda and I talked about this one this morning, hence it not being on my "approved" spreadsheet. :-p22:31
openstackgerritChris Krelle proposed openstack/ironic: Root partition should be marked as bootable  https://review.openstack.org/15658722:33
jlvillaljroll: https://review.openstack.org/#/c/158897/22:34
*** jcoufal has quit IRC22:35
*** Marga_ has quit IRC22:35
*** Marga_ has joined #openstack-ironic22:36
*** openstackgerrit has quit IRC22:37
*** openstackgerrit has joined #openstack-ironic22:37
openstackgerritNisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection  https://review.openstack.org/15159622:40
jrolljlvillal: awesome. fwiw the infra team mostly reviews that, you might poke clarkb again with that patch since he'll be interested what broke22:41
jlvillaljroll: I subtly (I hope) just did :)22:41
jlvillaljroll: Amazing how long it took me to come up with one line code change :(22:42
*** kbs has quit IRC22:42
jlvillalThe joy of software :D22:43
jrolljlvillal: such is software22:43
jrollheh22:43
jroll:D22:43
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient: Do not use httpretty 0.8.7 as it breaks testing  https://review.openstack.org/15889322:45
*** Marga_ has quit IRC22:49
*** Marga_ has joined #openstack-ironic22:49
*** achanda has quit IRC22:54
*** hj-hp has quit IRC22:55
*** hj-hp has joined #openstack-ironic22:57
*** lucas-dinner has quit IRC22:59
*** harlowja is now known as harlowja_away23:02
NobodyCamdoc patch: https://review.openstack.org/#/c/146307 has one +223:04
*** harlowja_away is now known as harlowja23:05
*** achanda has joined #openstack-ironic23:13
jlvillalIf anyone wants a review, just let me know.  Otherwise I will see what is on my watched list.23:18
*** purp has joined #openstack-ironic23:19
*** hj-hp has quit IRC23:19
*** chlong has joined #openstack-ironic23:19
jrolljlvillal: I got an easy one coming :D23:22
jlvillaljroll: Okay!  I can handle an easy one, I hope ;)23:23
*** spandhe has quit IRC23:23
jrollthere you are sir23:23
openstackgerritJim Rollenhagen proposed openstack/ironic: Remove unused code from agent vendor lookup()  https://review.openstack.org/15891223:23
jrollenjoy23:23
jrollit should pass tests, I didn't run locally23:24
* NobodyCam -1's just for fun23:24
* NobodyCam also ducks23:24
NobodyCamlol23:24
jrollx.x23:24
NobodyCamhehehe23:24
*** andreykurilin_ has quit IRC23:28
NobodyCamhumm jroll my only comment is I would ask lucas what he inteneded. as he just added that 12 days ago.23:29
jrollNobodyCam: he refactored that code to another file23:30
jrollthat was from us and probably remnants of crappy downstream code23:30
*** anderbubble has quit IRC23:31
NobodyCamya looking at the commit now23:32
NobodyCamlol great way to folks to read your email. add "Free beer and pizza!" to the title23:35
*** absubram has quit IRC23:36
jrollheh23:37
*** ijw has joined #openstack-ironic23:38
NobodyCamjroll: is it okay that i'm sad you didn't have to modify any tests to remove that :(23:41
*** ijw has quit IRC23:44
jlvillalIs there a way to have your patch depend on another patch that is in a different project?  Maybe a line added to the commit message?23:46
NobodyCamjlvillal: I hear tell there is23:46
jlvillalWe had a "Depends-Change-Id: XXXXXXXXXXXX" thing in my last build system23:47
jrollNobodyCam: it's bad, but now there's less code not tested :)23:47
jrolljlvillal: Depends-On: $CHANGE_ID23:47
jlvillaljroll: Thanks23:47
NobodyCam:)23:47
NobodyCamjroll: :)23:47
jlvillaljroll: I will try that with my python-ironicclient patch :)23:47
jrolljlvillal: awesome23:48
jroll(it works, I've used it, it's fantastic)23:48
*** achanda has quit IRC23:48
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient: Do not use httpretty 0.8.7 as it breaks testing  https://review.openstack.org/15889323:49
*** chlong_ has joined #openstack-ironic23:50
jlvillaljroll: Cool.  I see it in the Zuul page with the two patches :)23:50
*** achanda has joined #openstack-ironic23:53
NobodyCam:) kewl23:54
NobodyCamj* just fyi here a link to the free beer and pizza: http://lists.openstack.org/pipermail/openstack/2015-February/011660.html23:58
NobodyCamit's up by you23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!