| *** naohirot has joined #openstack-ironic | 00:02 | |
| *** Marga_ has quit IRC | 00:05 | |
| *** Marga_ has joined #openstack-ironic | 00:05 | |
| NobodyCam | Nisha: I'm sorry I should have looked sooner | 00:07 |
|---|---|---|
| NobodyCam | want to toss up a new commit message on 147857 | 00:07 |
| NobodyCam | only because it calls out that the patch is adding "INSPECTED" state and its not now :-p | 00:09 |
| Nisha | :) | 00:09 |
| Nisha | i will just post it again | 00:09 |
| NobodyCam | THank you :) | 00:10 |
| openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Support i18n part2 https://review.openstack.org/156115 | 00:11 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 00:12 |
| jlvillal | jroll: Speaking of https://review.openstack.org/#/c/155727/2 . I figured it out. Since the 'time' mock specifies the 'new=' argument it doesn't create an argument to the function. | 00:12 |
| jlvillal | jroll: https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch Read the 'new' section | 00:13 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Add states required for node-inspection https://review.openstack.org/147857 | 00:16 |
| Nisha | NobodyCam, ^^^ | 00:16 |
| NobodyCam | Nisha: Thank you I will have a look | 00:17 |
| *** eghobo has joined #openstack-ironic | 00:17 | |
| Nisha | thanks NobodyCam | 00:17 |
| NobodyCam | :) | 00:17 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement Cleaning States https://review.openstack.org/153444 | 00:20 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Add InspectInterface for node-introspection https://review.openstack.org/149817 | 00:20 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement Cleaning in DriverInterfaces https://review.openstack.org/157208 | 00:20 |
| JoshNang | Nisha: NobodyCam just noticed my commit message on https://review.openstack.org/#/c/153444/ didn't have "Implements blueprint", blah sorry | 00:21 |
| NobodyCam | oh -2 for that | 00:22 |
| NobodyCam | lol | 00:22 |
| NobodyCam | j/k | 00:22 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Generic changes for Node Inspection https://review.openstack.org/149823 | 00:23 |
| JoshNang | :) | 00:24 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 00:26 |
| naohirot | good morning to all | 00:27 |
| *** penick has quit IRC | 00:29 | |
| NobodyCam | morning naohirot :) | 00:31 |
| jlvillal | morning naohirot | 00:32 |
| naohirot | Hi good evening NobodyCam, thanks for the approval :) | 00:32 |
| *** Nisha has quit IRC | 00:32 | |
| NobodyCam | huh | 00:32 |
| NobodyCam | oh it was catch up day | 00:32 |
| naohirot | jlvillal: hi good evening :) | 00:33 |
| naohirot | NobodyCam: Yeah, I saw several merges :) | 00:33 |
| jlvillal | JoshNang: Question on https://review.openstack.org/#/c/153444/15/ironic/common/states.py Line 254 | 00:37 |
| jlvillal | Does the comment match what is being done? | 00:37 |
| naohirot | jlvillal: thanks for reviewing my code and docs, those helped me a lot :) | 00:37 |
| jlvillal | naohirot: Glad to help! :) | 00:37 |
| JoshNang | jlvillal: good catch, should be manageable | 00:38 |
| *** dprince has quit IRC | 00:38 | |
| jlvillal | JoshNang: Okay, let me make a few other comments :) | 00:38 |
| jlvillal | In a review | 00:38 |
| JoshNang | jlvillal: alright, i'll hold off on pushing another patchset | 00:39 |
| jlvillal | JoshNang: Should be just a couple minutes | 00:39 |
| naohirot | jlvillal: Year, especially usage of articles, it is very difficult for non English natives | 00:39 |
| JoshNang | jlvillal: no worries | 00:40 |
| jlvillal | naohirot: Well my brother is in Japan and he says Japanese is most difficult language he has learned :) he speaks English, French, and Spanish | 00:40 |
| jlvillal | He is trying to learn Japanese | 00:40 |
| *** david-lyle is now known as david-lyle_afk | 00:41 | |
| naohirot | jlvillal: that's great to hear that :) | 00:42 |
| jlvillal | JoshNang: Done. Not sure if those are valid comments or not. | 00:42 |
| *** eghobo has quit IRC | 00:42 | |
| naohirot | jlvillal: have you visited to your brother? | 00:42 |
| jlvillal | naohirot: I have! Just not in Japan ;) | 00:43 |
| jlvillal | It sounds very nice though. He really likes it. | 00:43 |
| naohirot | jlvillal: I see, so travel around Asia? | 00:44 |
| jlvillal | I think he has only gone to Japan. Myself I have never been to Asia | 00:44 |
| *** Marga_ has quit IRC | 00:46 | |
| *** Marga_ has joined #openstack-ironic | 00:46 | |
| naohirot | jlvillal: I thought you said you visited just not in Japan but also other countries, maybe I misunderstood. | 00:46 |
| *** Marga_ has quit IRC | 00:47 | |
| *** Marga_ has joined #openstack-ironic | 00:47 | |
| *** pegmatite has quit IRC | 00:48 | |
| jlvillal | naohirot: Sorry, I was trying to make a joke. I said I had visited my brother. Just not in Japan. Because you had asked me if I had visited my brother. | 00:48 |
| jlvillal | naohirot: So I have visited my brother when he lived here in the US. | 00:48 |
| jlvillal | it is probably hard to explain joke and trust me the native English speakers will tell you it was not a very good joke :) | 00:49 |
| NobodyCam | we'll all be in Japan in about a year or so ish | 00:49 |
| NobodyCam | :-p | 00:49 |
| naohirot | jlvillal: Yeah, I got it, you visited your brother in U.S. (^_^) | 00:50 |
| jlvillal | :) | 00:50 |
| *** pcrews has quit IRC | 00:55 | |
| *** spandhe has quit IRC | 00:59 | |
| *** Marga_ has quit IRC | 01:06 | |
| *** Marga_ has joined #openstack-ironic | 01:07 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement Cleaning States https://review.openstack.org/153444 | 01:10 |
| *** Marga_ has quit IRC | 01:12 | |
| * jlvillal thinks it is time to go to Costco and get some groceries | 01:12 | |
| jlvillal | Good night all! :) | 01:12 |
| NobodyCam | night :) | 01:12 |
| *** BadCub_ has quit IRC | 01:33 | |
| *** EmilienM is now known as EmilienM|afk | 01:36 | |
| *** absubram has quit IRC | 01:54 | |
| *** devlaps has quit IRC | 01:55 | |
| *** krtaylor has joined #openstack-ironic | 02:09 | |
| *** pcrews has joined #openstack-ironic | 02:13 | |
| *** killer_prince is now known as lazy_prince | 02:21 | |
| *** yuanying has joined #openstack-ironic | 02:29 | |
| *** achanda has quit IRC | 02:33 | |
| *** spandhe has joined #openstack-ironic | 02:41 | |
| *** achanda has joined #openstack-ironic | 02:42 | |
| *** spandhe_ has joined #openstack-ironic | 02:43 | |
| *** achanda has quit IRC | 02:46 | |
| *** spandhe has quit IRC | 02:46 | |
| *** spandhe_ is now known as spandhe | 02:46 | |
| *** ramineni has joined #openstack-ironic | 02:50 | |
| *** anderbubble has joined #openstack-ironic | 02:53 | |
| ramineni | NobodyCam: hi ..there? | 03:00 |
| *** achanda has joined #openstack-ironic | 03:02 | |
| adam_g | NobodyCam, woo https://launchpad.net/bugs/1423427 | 03:04 |
| openstack | Launchpad bug 1423427 in OpenStack Compute (nova) "os-baremetal-node ext relies on presence of specific ironic node properties " [Undecided,New] | 03:04 |
| *** harlowja_ is now known as harlowja_away | 03:15 | |
| *** saripurigopi has joined #openstack-ironic | 03:21 | |
| *** anderbubble has quit IRC | 03:25 | |
| *** Nisha has joined #openstack-ironic | 03:42 | |
| NobodyCam | ramineni: maybe :-p | 03:42 |
| NobodyCam | adam_g: oh wow | 03:42 |
| ramineni | NobodyCam: :) , just wanted to check if we have consent on https://review.openstack.org/#/c/129529/ | 03:43 |
| *** achanda has quit IRC | 03:45 | |
| NobodyCam | I think we were waiting to see ... I did not have a chance today to follow up on it. | 03:46 |
| NobodyCam | I see we got a reply on 135845 too | 03:47 |
| NobodyCam | ramineni: I will see if I can get eyes on both tomorrow | 03:47 |
| ramineni | NobodyCam: sure .. thanks | 03:49 |
| NobodyCam | :) | 03:50 |
| ramineni | NobodyCam: ya , have seen the comment now .. then still no consensus yet :P | 03:50 |
| *** korekhov_ has joined #openstack-ironic | 03:51 | |
| NobodyCam | I'll do my best to see if we can tomorrow | 03:51 |
| Nisha | NobodyCam, there? | 03:52 |
| *** achanda has joined #openstack-ironic | 03:52 | |
| *** korekhov has quit IRC | 03:54 | |
| ramineni | NobodyCam: thanks ..that would be great :) | 03:54 |
| *** korekhov_ has quit IRC | 03:55 | |
| *** saripurigopi has quit IRC | 03:59 | |
| *** lazy_prince is now known as killer_prince | 04:05 | |
| NobodyCam | Hi Nisha only kinda | 04:06 |
| NobodyCam | :) | 04:06 |
| Nisha | Reviews :( | 04:07 |
| Nisha | NobodyCam, reviews ? | 04:10 |
| JoshNang | ramineni: this should be what you're looking for: https://review.openstack.org/#/c/157208/ | 04:11 |
| ramineni | JoshNang : thanks ..will have a look :) | 04:12 |
| NobodyCam | Nisha: I reviewed several reviews today. I plan on doing more tomorrow, but I need to be in a good mind state to be a good reviewer | 04:13 |
| Nisha | NobodyCam, hmmm | 04:14 |
| NobodyCam | we will get to it | 04:14 |
| *** BadCub_ has joined #openstack-ironic | 04:14 | |
| *** achanda has quit IRC | 04:16 | |
| Nisha | NobodyCam, actually not getting reviews on inspection changes so.... | 04:16 |
| jroll | Nisha: the last patch was posted after work hours for the entire US... | 04:17 |
| jroll | we can't work 24 hours a day | 04:18 |
| Nisha | jroll, yeah i understand | 04:18 |
| Nisha | jroll, i myself was working in midnight... as US day is night in India | 04:19 |
| jroll | Nisha: I understand, it's difficult | 04:20 |
| Nisha | jroll, yes. Its fine. | 04:20 |
| Nisha | i hope it gets reviews tomorrow | 04:20 |
| *** korekhov has joined #openstack-ironic | 04:21 | |
| openstackgerrit | Merged openstack/ironic: fixed typos from eligable to eligible and delition to deletion https://review.openstack.org/155044 | 04:25 |
| *** korekhov has quit IRC | 04:26 | |
| *** pensu has joined #openstack-ironic | 04:27 | |
| *** coolsvap_ is now known as coolsvap | 04:28 | |
| *** rbrooker has quit IRC | 04:39 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 04:47 |
| *** rameshg87 has joined #openstack-ironic | 04:53 | |
| rameshg87 | good morning ironic | 04:54 |
| BadCub_ | heya rameshg87 | 04:55 |
| rameshg87 | hello BadCub_ | 04:55 |
| rameshg87 | hey BadCub_ i still don't know your real name, what's your real name ? :) | 04:57 |
| BadCub_ | John :-) | 04:57 |
| rameshg87 | John L. Villalovos ? | 04:57 |
| *** yog_ has joined #openstack-ironic | 04:58 | |
| BadCub_ | John Stafford. Sorry, multi-layer conversations going | 04:58 |
| rameshg87 | okay .. | 04:58 |
| BadCub_ | I am with HP, work with Devandanda and NobodyCam | 05:00 |
| rameshg87 | BadCub_, okay. I am also working at HP :) | 05:00 |
| rameshg87 | BadCub_, my real name is "Ramakrishnan G" | 05:00 |
| *** pensu has quit IRC | 05:00 | |
| BadCub_ | Oh hey! I know that name!!! | 05:00 |
| BadCub_ | sometimes it is hard putting IRC handles to real names | 05:01 |
| *** coolsvap is now known as coolsvap_ | 05:05 | |
| *** saripurigopi has joined #openstack-ironic | 05:06 | |
| *** yuanying has quit IRC | 05:09 | |
| *** yuanying has joined #openstack-ironic | 05:11 | |
| *** spandhe has quit IRC | 05:13 | |
| *** coolsvap_ is now known as coolsvap | 05:15 | |
| *** achanda has joined #openstack-ironic | 05:16 | |
| *** achanda has quit IRC | 05:18 | |
| *** achanda has joined #openstack-ironic | 05:18 | |
| rameshg87 | yeah .. it is..:) | 05:22 |
| rameshg87 | hey BadCub_, devananda told during the meeting that you can help setting the status of blueprint | 05:23 |
| rameshg87 | BadCub_, if so, can you please set the status of 2 of my blueprints whose specs are merged for kilo | 05:23 |
| rameshg87 | BadCub_, https://blueprints.launchpad.net/ironic/+spec/ironic-generic-raid-interface | 05:23 |
| rameshg87 | BadCub_, https://blueprints.launchpad.net/ironic/+spec/inband-raid-configuration | 05:23 |
| rameshg87 | BadCub_, both the specs are merged | 05:23 |
| *** ParsectiX has quit IRC | 05:30 | |
| *** ParsectiX has joined #openstack-ironic | 05:31 | |
| *** killer_prince is now known as lazy_prince | 05:38 | |
| *** Marga_ has joined #openstack-ironic | 05:40 | |
| *** Marga_ has quit IRC | 05:41 | |
| *** Marga_ has joined #openstack-ironic | 05:42 | |
| openstackgerrit | Merged openstack/python-ironicclient: Capture stdout or stderr in tests https://review.openstack.org/155406 | 05:44 |
| BadCub_ | rameshg87 both are tagged for k-3 | 05:44 |
| *** achanda has quit IRC | 05:45 | |
| rameshg87 | BadCub_, thanks :) | 05:45 |
| BadCub_ | YW :-) | 05:48 |
| *** zigo has quit IRC | 05:54 | |
| *** zigo has joined #openstack-ironic | 05:55 | |
| *** achanda has joined #openstack-ironic | 05:56 | |
| *** pradipta has joined #openstack-ironic | 05:57 | |
| *** ParsectiX has quit IRC | 05:58 | |
| *** ParsectiX has joined #openstack-ironic | 05:58 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 05:58 |
| *** absubram has joined #openstack-ironic | 06:01 | |
| *** absubram has quit IRC | 06:02 | |
| *** absubram has joined #openstack-ironic | 06:03 | |
| *** korekhov has joined #openstack-ironic | 06:03 | |
| *** korekhov has quit IRC | 06:07 | |
| *** spandhe has joined #openstack-ironic | 06:27 | |
| *** absubram has quit IRC | 06:31 | |
| *** Nisha has quit IRC | 06:34 | |
| saripurigopi | I've a question reg management interface part of a driver. | 06:40 |
| saripurigopi | When we set boot device, the driver has to update the baremetal boot-order, does it have to include only the specified option in the boot order, or its the first option in boot-order. | 06:41 |
| *** BadCub_ has quit IRC | 06:44 | |
| *** spandhe has quit IRC | 06:54 | |
| *** Nisha has joined #openstack-ironic | 06:55 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 07:02 |
| rameshg87 | saripurigopi, Ironic cares only about the device that the bare metal will boot from | 07:05 |
| rameshg87 | saripurigopi, it doesn't care about the devices in 2nd, 3rd, 4th of the boot order | 07:05 |
| saripurigopi | rameshg87, so just setting same option would be fine right. | 07:07 |
| rameshg87 | saripurigopi, yes, whatever device is passed has to be the 1st boot device on your bare metal's boot order | 07:07 |
| saripurigopi | rameshg87, okay. That clarifies my doubt. | 07:08 |
| *** gridinv has joined #openstack-ironic | 07:09 | |
| saripurigopi | rameshg87, now that vendor_passthru apis supports async calls at node level. How can user know the status of that operation? | 07:10 |
| rameshg87 | saripurigopi, vendor_passthru's were async before | 07:15 |
| rameshg87 | saripurigopi, oh may be wasn't | 07:15 |
| rameshg87 | saripurigopi, async vendor_passthrus we can't get the status back | 07:15 |
| rameshg87 | saripurigopi, have to check the logs | 07:15 |
| rameshg87 | afaik | 07:16 |
| saripurigopi | rameshg87, Okay, so If I need to get some info of the server, like faults/ stats/ get_sensor_data is the only option to periodically poll ? | 07:16 |
| rameshg87 | saripurigopi, yeah | 07:17 |
| rameshg87 | saripurigopi, but what/where will you poll ? | 07:18 |
| *** chlong has quit IRC | 07:19 | |
| saripurigopi | rameshg87, okay. I'm not sure, my understanding is celio meter agent would call get_sensor_data and send it to celiometer, isnt' that the case? | 07:19 |
| rameshg87 | saripurigopi, don't have much idea | 07:20 |
| saripurigopi | rameshg87, okay. | 07:21 |
| *** spandhe has joined #openstack-ironic | 07:21 | |
| rameshg87 | Haoment (not online right now) might be a good person to ask | 07:21 |
| rameshg87 | Haomeng iirc | 07:21 |
| rameshg87 | sirushti, hey | 07:22 |
| Nisha | saripurigopi, aynsc call at node level means? | 07:22 |
| sirushti | rameshg87: Hi | 07:22 |
| rameshg87 | sirushti, in patch https://review.openstack.org/#/c/150142/19/ironic/conductor/manager.py | 07:22 |
| rameshg87 | sirushti, i still see the _infer_image_type has been moved above before conductor calls task.driver.deploy.validate() | 07:23 |
| rameshg87 | sirushti, but nova makes a separate validate call before triggering the deploy | 07:23 |
| rameshg87 | sirushti, https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L655 | 07:23 |
| rameshg87 | sirushti, does it work from nova now ? | 07:23 |
| sirushti | rameshg87: it calls rpc.validate_driver_interfaces first and then rpc.do_node_deploy | 07:24 |
| saripurigopi | Nisha, can invoke vendor-passthru api to perform operation on a specific ironic-node | 07:24 |
| sirushti | rameshg87: which both respectively call _infer_image_type | 07:25 |
| rameshg87 | sirushti, oh i missed that part | 07:25 |
| rameshg87 | sirushti, thanks :) | 07:25 |
| sirushti | rameshg87: Sure, no problem :) | 07:26 |
| Nisha | saripurigopi, asaik, async vendor pass thru will be called from conductor | 07:27 |
| Nisha | then the async call can wait for driver code to finish, while the sync part of it can just return to the api | 07:28 |
| Nisha | saripurigopi, i am not sure if you are asking same.. | 07:28 |
| *** Marga_ has quit IRC | 07:29 | |
| saripurigopi | Nisha, is there a way user notified about the status of this api invocation, success/failure? As of now it support only POST operations right? | 07:30 |
| *** pensu has joined #openstack-ironic | 07:36 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 07:42 |
| *** cinerama has quit IRC | 07:49 | |
| *** korekhov has joined #openstack-ironic | 07:51 | |
| *** korekhov has quit IRC | 07:55 | |
| *** spandhe has quit IRC | 08:00 | |
| *** harlowja_away has quit IRC | 08:03 | |
| *** Nisha_away has joined #openstack-ironic | 08:06 | |
| *** Nisha has quit IRC | 08:06 | |
| *** korekhov has joined #openstack-ironic | 08:11 | |
| *** jcoufal has joined #openstack-ironic | 08:25 | |
| *** achanda has quit IRC | 08:29 | |
| *** andreykurilin_ has joined #openstack-ironic | 08:29 | |
| *** achanda has joined #openstack-ironic | 08:29 | |
| *** achanda has quit IRC | 08:30 | |
| *** pensu has quit IRC | 08:33 | |
| *** ifarkas has joined #openstack-ironic | 08:35 | |
| *** pradipta has quit IRC | 08:37 | |
| *** yog_ has quit IRC | 08:38 | |
| *** dtantsur|afk is now known as dtantsur | 08:41 | |
| dtantsur | Morning Ironic | 08:41 |
| *** jistr has joined #openstack-ironic | 08:42 | |
| openstackgerrit | Anusha Ramineni proposed stackforge/proliantutils: Add Proliant Hardware Manager https://review.openstack.org/157291 | 08:46 |
| *** cinerama has joined #openstack-ironic | 08:48 | |
| *** korekhov has quit IRC | 08:53 | |
| *** korekhov has joined #openstack-ironic | 08:53 | |
| *** yog_ has joined #openstack-ironic | 08:54 | |
| *** erwan_taf has joined #openstack-ironic | 08:55 | |
| *** korekhov has quit IRC | 08:58 | |
| *** andreykurilin_ has quit IRC | 08:58 | |
| *** Nisha_away has quit IRC | 09:01 | |
| *** erwan_taf has quit IRC | 09:04 | |
| *** jcoufal_ has joined #openstack-ironic | 09:05 | |
| *** korekhov has joined #openstack-ironic | 09:05 | |
| *** jcoufal has quit IRC | 09:08 | |
| *** korekhov has quit IRC | 09:09 | |
| *** mgoddard has joined #openstack-ironic | 09:12 | |
| *** pas-ha has joined #openstack-ironic | 09:13 | |
| *** lucasagomes has joined #openstack-ironic | 09:15 | |
| *** erwan_taf has joined #openstack-ironic | 09:16 | |
| ramineni | dtantsur:hi | 09:19 |
| *** derekh has joined #openstack-ironic | 09:19 | |
| *** ndipanov has quit IRC | 09:21 | |
| *** korekhov has joined #openstack-ironic | 09:24 | |
| dtantsur | ramineni, o/ | 09:27 |
| *** kylestev has quit IRC | 09:27 | |
| ramineni | dtantsur: could you please increase severity of bug https://bugs.launchpad.net/ironic/+bug/1420210 | 09:27 |
| openstack | Launchpad bug 1420210 in Ironic "Ilo drivers doesn't support to communicate to iLO via REST API" [Low,In progress] - Assigned to Anusha (anusha-iiitm) | 09:27 |
| *** korekhov has quit IRC | 09:28 | |
| ramineni | otherwise IloDrivers break after latest release of proliantutils if the bug doesnt go in | 09:28 |
| dtantsur | ramineni, severity makes sense when nobody is working on the bug, now it does not change anything | 09:29 |
| dtantsur | ramineni, I don't mind doing it though, but breaking backward compatibility bothers me | 09:29 |
| dtantsur | ramineni, does that mean that people using Juno will break on updating proliantutils? | 09:29 |
| *** ndipanov has joined #openstack-ironic | 09:29 | |
| ramineni | dtantsur: no ..actually it doesn't , https://github.com/stackforge/proliantutils/blob/master/proliantutils/ilo/ribcl.py#L496 , its handled for backward compatibility | 09:31 |
| dtantsur | then what's the problem with bug severity? :) | 09:31 |
| ramineni | dtantsur , for latest features we want it in | 09:31 |
| ramineni | :) | 09:31 |
| dtantsur | bug severity literally means how deeply broken things are. In your case things are not broken, thus I put 'low' there. Anyway, it only makes sense when people pick bugs to work on, this one is already worked on :) | 09:32 |
| ramineni | dtantsur : ok , thanks for clarifying :) | 09:33 |
| ramineni | dtantsur , in that case , it should be fine | 09:33 |
| *** pensu has joined #openstack-ironic | 09:33 | |
| *** Nisha has joined #openstack-ironic | 09:34 | |
| openstackgerrit | Mark Goddard proposed openstack/ironic: Avoid deregistering conductor following SIGUSR1 https://review.openstack.org/155785 | 09:34 |
| openstackgerrit | Victor Sergeyev proposed openstack/ironic: Use oslo_utils replace oslo.utils https://review.openstack.org/149450 | 09:40 |
| openstackgerrit | Victor Sergeyev proposed openstack/ironic: Use mock from standard library in py3x env https://review.openstack.org/156600 | 09:45 |
| openstackgerrit | Victor Sergeyev proposed openstack/ironic: Run tests in py34 environment https://review.openstack.org/156192 | 09:45 |
| *** viktors|afk is now known as viktors | 09:47 | |
| *** Nisha has quit IRC | 09:47 | |
| viktors | ^^ a simple rebase | 09:47 |
| dtantsur | ramineni, still around? I have a question on iLO cleaning | 09:48 |
| ramineni | dtantsur: yes | 09:48 |
| dtantsur | ramineni, it's about the in-band part. will you be using something standard for Linux on the ramdisk or some proprietary tools? | 09:49 |
| dtantsur | rameshg87, hi, the same question for you about in-band RAID ^^^ | 09:49 |
| rameshg87 | dtantsur, for raid, it's a proprietary tool | 09:50 |
| rameshg87 | dtantsur, it's called hpssa. free for download but not opensource | 09:50 |
| dtantsur | aha... that's pity. will you have something out-of-band for RAID? or only this thingy? | 09:50 |
| ramineni | dtantsur: except for raid , not using any other proprietary tools for k release | 09:51 |
| rameshg87 | dtantsur, hp hardware cannot do RAID out-of-band | 09:51 |
| rameshg87 | dtantsur, i use this for raid: http://h20564.www2.hp.com/hpsc/swd/public/detail?swItemId=MTX_b6a6acb9762443b182280db805 | 09:51 |
| dtantsur | I see. Thanks, folks! | 09:51 |
| *** romcheg has joined #openstack-ironic | 09:54 | |
| rameshg87 | lucasagomes, hi | 09:56 |
| lucasagomes | rameshg87, hi there | 09:56 |
| rameshg87 | lucasagomes, when you get some time, let me know what you thing about Chris's comment: https://review.openstack.org/156587 | 09:56 |
| rameshg87 | lucasagomes, oh you already commented :) | 09:57 |
| rameshg87 | thanks | 09:57 |
| lucasagomes | rameshg87, yeah commented 2 min ago heh | 09:57 |
| lucasagomes | I'm good with that | 09:57 |
| openstackgerrit | Alexis Lee proposed openstack/ironic: Correctly rebuild the PXE file during takeover of ACTIVE nodes https://review.openstack.org/155460 | 10:03 |
| openstackgerrit | Alexis Lee proposed openstack/ironic: Don't write PXE config during ACTIVE takeover https://review.openstack.org/156250 | 10:03 |
| openstackgerrit | Merged stackforge/ironic-discoverd: Support i18n part2 https://review.openstack.org/156115 | 10:05 |
| openstackgerrit | Alexis Lee proposed openstack/ironic: Don't write PXE config during ACTIVE takeover https://review.openstack.org/156250 | 10:06 |
| *** dtantsur is now known as dtantsur|bbl | 10:21 | |
| openstackgerrit | Anusha Ramineni proposed openstack/ironic-python-agent: Add raid configuration in IPA https://review.openstack.org/157316 | 10:25 |
| *** jcoufal_ has quit IRC | 10:45 | |
| *** jcoufal has joined #openstack-ironic | 10:46 | |
| *** pelix has joined #openstack-ironic | 10:46 | |
| *** erwan_taf has quit IRC | 10:48 | |
| *** erwan_taf has joined #openstack-ironic | 10:49 | |
| *** ndipanov has quit IRC | 11:04 | |
| *** ramineni has quit IRC | 11:04 | |
| *** yog_ has quit IRC | 11:11 | |
| *** erwan_taf has quit IRC | 11:17 | |
| *** ndipanov has joined #openstack-ironic | 11:18 | |
| *** korekhov has joined #openstack-ironic | 11:25 | |
| *** korekhov has quit IRC | 11:29 | |
| *** erwan_taf has joined #openstack-ironic | 11:29 | |
| *** rameshg87 has quit IRC | 11:37 | |
| *** chlong has joined #openstack-ironic | 11:41 | |
| *** richard_1aw is now known as richard_maw | 11:46 | |
| *** alexpilotti has joined #openstack-ironic | 11:51 | |
| *** dtantsur|bbl is now known as dtantsur | 11:56 | |
| *** saripurigopi has quit IRC | 12:06 | |
| *** agentle_ has quit IRC | 12:06 | |
| *** ndipanov has quit IRC | 12:13 | |
| *** saripurigopi has joined #openstack-ironic | 12:13 | |
| *** ndipanov has joined #openstack-ironic | 12:14 | |
| *** ndipanov has quit IRC | 12:20 | |
| *** foexle has joined #openstack-ironic | 12:20 | |
| *** yuanying has quit IRC | 12:25 | |
| *** saripurigopi has quit IRC | 12:29 | |
| *** erwan_taf has quit IRC | 12:30 | |
| *** erwan_taf has joined #openstack-ironic | 12:30 | |
| *** rameshg87 has joined #openstack-ironic | 12:30 | |
| rameshg87 | lucasagomes, regarding some comments on https://review.openstack.org/#/c/155230/8/ironic/api/controllers/v1/node.py | 12:32 |
| rameshg87 | lucasagomes, the 202 error code | 12:32 |
| *** ndipanov has joined #openstack-ironic | 12:32 | |
| lucasagomes | rameshg87, right | 12:32 |
| rameshg87 | lucasagomes, it's true the intention of the PUT call was just to store to the database and no action has been triggered in background | 12:33 |
| rameshg87 | lucasagomes, the reason behind 202 was PUTting /raid/configuration on the node is not complete yet | 12:33 |
| lucasagomes | rameshg87, yeah, that's my understanding too | 12:33 |
| lucasagomes | right but that's the return code for that request right | 12:33 |
| lucasagomes | it's like when config is done in 2 steps | 12:33 |
| lucasagomes | you first configure it and then you commit the changes | 12:34 |
| lucasagomes | the configuration part is done (200) | 12:34 |
| lucasagomes | when you commit yeah that takes while so (202) | 12:34 |
| lucasagomes | rameshg87, idk, maybe it's only me, but when I see a 202 in my head it basically means that my request wasn't fullfilled yet | 12:34 |
| lucasagomes | and it's doing something in the background | 12:34 |
| rameshg87 | request wasn't fullfilled yet is correct :) | 12:35 |
| rameshg87 | but doing something in background is wrong | 12:35 |
| lucasagomes | well it was, the configuration was applied correctly and it's done for that request right? | 12:35 |
| rameshg87 | lucasagomes, i just checked w3.org description of it: http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html | 12:35 |
| rameshg87 | lucasagomes, 202 Accepted | 12:35 |
| rameshg87 | lucasagomes, says "The 202 response is intentionally non-committal. Its purpose is to allow a server to accept a request for some other process (perhaps a batch-oriented process that is only run once per day) without requiring that the user agent's connection to the server persist until the process is completed." | 12:36 |
| rameshg87 | lucasagomes, "that is only run once per day" example | 12:36 |
| lucasagomes | right yeah | 12:36 |
| rameshg87 | lucasagomes, says it needn't trigger something in the background | 12:36 |
| lucasagomes | rameshg87, ack, yeah I commented more to document that (nor -1'ed too) | 12:36 |
| lucasagomes | cause I think that the rest of our API 202 basically means task running on the background | 12:37 |
| lucasagomes | I could argue both ways really | 12:37 |
| rameshg87 | lucasagomes, :) | 12:37 |
| rameshg87 | lucasagomes, so do you feel 202 is okay as well ? | 12:38 |
| lucasagomes | rameshg87, yup, it's valid | 12:38 |
| rameshg87 | lucasagomes, okay | 12:38 |
| lucasagomes | but maybe a bit less consistent with the rest of our calls | 12:38 |
| *** jjohnson2 has joined #openstack-ironic | 12:38 | |
| rameshg87 | wanna take a vote or get more opinions ? | 12:39 |
| lucasagomes | rameshg87, I wouldn't -1 for that. The +1 is for the other bits too | 12:39 |
| lucasagomes | if that was my only comment I would +2 it | 12:39 |
| rameshg87 | okay | 12:40 |
| rameshg87 | let me fix other things for now then | 12:40 |
| lucasagomes | the thing about overwriting the 'raid' module should be fixed really | 12:40 |
| rameshg87 | lucasagomes, yeah doing it rightaway | 12:40 |
| rameshg87 | lucasagomes, and regarding jsontype | 12:40 |
| rameshg87 | on the same file | 12:40 |
| lucasagomes | rameshg87, yeah the json type I'm good too, it's just an remind that a list is also a json valid type | 12:40 |
| lucasagomes | or a string | 12:40 |
| lucasagomes | the return docstring says dictionary | 12:41 |
| rameshg87 | lucasagomes, okay | 12:41 |
| lucasagomes | perhaps saying a json on the docstring? it's just a nit really | 12:41 |
| rameshg87 | lucasagomes, dtantsur and i discussed on previous patchset. | 12:41 |
| lucasagomes | oh, ok, I will take a look | 12:41 |
| lucasagomes | but it's good | 12:42 |
| *** Nisha has joined #openstack-ironic | 12:42 | |
| rameshg87 | even put accepts jsontype for now where raid configuration is supposed to be '{"logical_disks": []}' | 12:42 |
| lucasagomes | I said in the comment it's fine as-is too. So no changes needed on my side | 12:42 |
| lucasagomes | rameshg87, +1 | 12:42 |
| rameshg87 | okay | 12:42 |
| lucasagomes | I just feel like commenting that stuff to document, maybe someone has another opnion on that which might be important | 12:43 |
| Nisha | lucasagomes, hi | 12:43 |
| lucasagomes | Nisha, hi | 12:43 |
| *** pensu has quit IRC | 12:43 | |
| Nisha | lucasagomes, could i request your time for inspection patches review | 12:43 |
| Nisha | ? | 12:43 |
| lucasagomes | Nisha, sure, what patches? btw the Nova one got approved :) | 12:44 |
| lucasagomes | oh inspection patches | 12:44 |
| Nisha | lucasagomes, yes | 12:44 |
| lucasagomes | gotcha, yeah I will take a look | 12:44 |
| Nisha | dtantsur, there | 12:48 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add driver interface for RAID configuration https://review.openstack.org/155230 | 12:58 |
| *** Nisha has quit IRC | 12:58 | |
| *** EmilienM|afk is now known as EmilienM | 12:58 | |
| *** alexpilotti has quit IRC | 13:05 | |
| *** korekhov has joined #openstack-ironic | 13:05 | |
| *** korekhov has quit IRC | 13:09 | |
| *** jjohnson2 has quit IRC | 13:10 | |
| *** pensu has joined #openstack-ironic | 13:18 | |
| NobodyCam | morning Ironicers | 13:23 |
| dtantsur | NobodyCam, morning | 13:25 |
| *** pensu has quit IRC | 13:26 | |
| lucasagomes | NobodyCam, morning | 13:27 |
| *** pensu has joined #openstack-ironic | 13:29 | |
| NobodyCam | morning dtantsur and lucasagomes :) | 13:30 |
| openstackgerrit | John Trowbridge proposed openstack/ironic: Add documentation for the IPMI retry timeout option https://review.openstack.org/131296 | 13:33 |
| trown | NobodyCam: lucasagomes, thanks for teaching me how to properly update the sample config | 13:33 |
| NobodyCam | :) | 13:34 |
| lucasagomes | trown, cool yw | 13:34 |
| trown | learned something new just working on docs | 13:34 |
| *** jistr_ has joined #openstack-ironic | 13:37 | |
| *** jistr has quit IRC | 13:39 | |
| NobodyCam | :) | 13:47 |
| rameshg87 | morning NobodyCam | 13:47 |
| naohirot | good morning NobodyCam :) | 13:47 |
| naohirot | lucasagomes: rameshg87: can I ask a question regarding this code https://github.com/openstack/diskimage-builder/blob/master/elements/deploy-ironic/init.d/80-deploy-ironic#L19 | 13:48 |
| rameshg87 | NobodyCam, have added my reasoning of why root partition can be made bootable in all cases ps://review.openstack.org/#/c/156587/1/ironic/drivers/modules/deploy_utils.py | 13:48 |
| lucasagomes | trown, :) yeah there's the -egendocs command as well so you can generate the docs from API and other bits locally too | 13:48 |
| rameshg87 | NobodyCam, please have a look at them and see if it seems reasonable | 13:48 |
| lucasagomes | naohirot, sure, it's all stuff let's see if I remember :) | 13:48 |
| lucasagomes | it's old stuff* | 13:48 |
| *** jistr_ is now known as jistr | 13:48 | |
| naohirot | lucasagomes: my test env started to return ERROR ironic.drivers.modules.iscsi_deploy [-] Error retu | 13:49 |
| naohirot | rned from deploy ramdisk: Could+not+find+disk+to+use. | 13:49 |
| NobodyCam | rameshg87: the concern I have (with out looking atm) was some bios may see that bit and do some kind of fall back and attempt to boot from the disk ... Ie stop trying to pxe boot | 13:49 |
| NobodyCam | but I will take a look in a bit | 13:50 |
| rameshg87 | NobodyCam, okay | 13:50 |
| naohirot | lucasagomes: I checked disk partition of my bare metal, | 13:50 |
| lucasagomes | naohirot, right... so that's the func that look for the devices | 13:51 |
| lucasagomes | https://github.com/openstack/diskimage-builder/blob/master/elements/ramdisk-base/extra-data.d/scripts/d/init-func#L193 | 13:51 |
| naohirot | lucasagomes: basically should I remove all partition? It have been working before. | 13:51 |
| lucasagomes | naohirot, no, having partitions or not shouldn't make a difference | 13:51 |
| rameshg87 | naohirot, is /dev/sda there on your system ? | 13:52 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add RAID configuration methods in decom extension https://review.openstack.org/157316 | 13:52 |
| lucasagomes | naohirot, also, take a look at the parameter that is passed via Ironic to the ramdisk | 13:52 |
| * lucasagomes hate that bit part of the code | 13:52 | |
| lucasagomes | naohirot, 1 sec will point it out to u | 13:52 |
| rameshg87 | lucasagomes, naohirot, this one ? https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L69 | 13:53 |
| naohirot | rameshg87: I removed all partitions. | 13:53 |
| rameshg87 | naohirot, what do you mean by partitions ? is it /dev/sda1, /dev/sda2, etc ? | 13:54 |
| *** mkerrin has quit IRC | 13:55 | |
| naohirot | rameshg87: Yes, I removed /dev/sdc1 and /dev/sdc2 by fdisk | 13:55 |
| lucasagomes | naohirot, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L69 | 13:56 |
| lucasagomes | yeah | 13:56 |
| rameshg87 | naohirot, don't you have /dev/sda on your system ? | 13:56 |
| rameshg87 | naohirot, by default ironic looks *only* for /dev/sda | 13:56 |
| lucasagomes | yeah it looks sda,vda,hda by default | 13:56 |
| naohirot | rameshg87: I need to check exact device name, but this system worked before, so the disk device name should be okay. | 13:57 |
| rameshg87 | naohirot, not sure, but disk names can change | 13:57 |
| * rameshg87 wonders why would linux kernel skip sda | 13:57 | |
| lucasagomes | yeah disk names are abritary, but yeah skipping sda is def odd | 13:57 |
| lucasagomes | anyway... I think we should make the ramdisk smarter, make it use lsblk for example and get a valid disk from that | 13:58 |
| lucasagomes | like IPA does | 13:58 |
| lucasagomes | (or use root device hints, but it's not merged in DIB yet :/) | 13:58 |
| naohirot | rameshg87: lucasagomes: let me check the disk device name by booting rescue cdrom again | 13:58 |
| rameshg87 | lucasagomes, +1 | 13:58 |
| lucasagomes | naohirot, cool, yeah the thing is... even booting on cdrom may not be enough because it's arbritary | 13:58 |
| lucasagomes | naohirot, to be very honest. I think it's a real problem/bug | 13:59 |
| naohirot | rameshg87: lucasagomes: so the device name has to be one of default='cciss/c0d0,sda,hda,vda', right? | 13:59 |
| lucasagomes | I would fix that method on DIB to do a better job finding the device | 13:59 |
| lucasagomes | naohirot, yeah, that really sucks | 13:59 |
| lucasagomes | lsblk -oKNAME,TYPE | 14:00 |
| lucasagomes | test if TYPE=="disk" | 14:00 |
| naohirot | lucasagomes: rameshg87: I'll report the device name in 10 min. | 14:00 |
| lucasagomes | naohirot, ack | 14:00 |
| lucasagomes | naohirot, but again, it's arbitrary. It can change from one boot to another | 14:00 |
| lucasagomes | unless you got perment rules for naming ur devices (udev rules) | 14:00 |
| *** Nisha has joined #openstack-ironic | 14:04 | |
| naohirot | lucasagomes: rameshg87: booting ubuntu rescue disk, fdisk -l said /dev/sda | 14:08 |
| rameshg87 | naohirot, if it was /dev/sda in the deploy ramdisk, i would expect find_disk to find it | 14:09 |
| naohirot | lucasagomes: rameshg87: it seems it should be okay | 14:09 |
| rameshg87 | naohirot, may be we should check what disk files does deploy ramdisk see ? | 14:09 |
| GheRivero | lucasagomes: Are you planning to work on https://review.openstack.org/#/c/128005/ (oslo config generator) or can I 'hijack' it? | 14:10 |
| lucasagomes | yeah, it's hard to tell... since it can switch names from boots | 14:10 |
| lucasagomes | GheRivero, go ahead! | 14:10 |
| GheRivero | lucasagomes: will do. Thx | 14:10 |
| lucasagomes | GheRivero, thank you for taking over :) | 14:10 |
| GheRivero | lucasagomes: sure. no problem | 14:10 |
| naohirot | rameshg87: passing some parameter by configdrive makes deploy ramdisk display debug message on console? | 14:11 |
| lucasagomes | naohirot, when it fails do you get a shell ? | 14:11 |
| rameshg87 | yeah we get troubleshoot shell, right ? | 14:11 |
| rameshg87 | press t to drop to shell or something | 14:11 |
| naohirot | lucasagomes: no, it failed after first boot, when my bare metal powered off, before second boot. | 14:12 |
| lucasagomes | :( | 14:12 |
| lucasagomes | naohirot, I feel like ur going to have to tweak the ramdisk and rebuild it | 14:13 |
| naohirot | lucasagomes: my disk is ssd, is it related to this problem? | 14:14 |
| *** jjohnson2 has joined #openstack-ironic | 14:14 | |
| lucasagomes | naohirot, normally ssd are named sd* so should be fine :/ | 14:15 |
| naohirot | lucasagomes: okay | 14:15 |
| lucasagomes | naohirot, the thing is, that method to find the disk is not appropriated | 14:15 |
| lucasagomes | I would rather improve it if possible | 14:16 |
| rameshg87 | naohirot, yeah i guess you can uncompress the ramdisk, add a troubleshoot above this line https://github.com/openstack/diskimage-builder/blob/master/elements/deploy-ironic/init.d/80-deploy-ironic#L9 | 14:16 |
| naohirot | rameshg87: I'll try to press 't' on console. | 14:16 |
| rameshg87 | naohirot, above this line in /init within the ramdisk | 14:16 |
| rameshg87 | naohirot, and then archive it back | 14:16 |
| rameshg87 | naohirot, this will uncompress the ramdisk: mkdir init; cd init; gunzip < ../initramfs | cpio -i --make-directories | 14:17 |
| rameshg87 | naohirot, this will package it back: find . | cpio -H newc -o | gzip > ../initramfs.new | 14:17 |
| rameshg87 | naohirot, from my cheatsheat, i use it often :) | 14:18 |
| * dtantsur needs a cheatsheet too | 14:18 | |
| naohirot | rameshg87: Okay, in order to print some variable, can just echo be okay? | 14:19 |
| lucasagomes | naohirot, yup, echo and call "bash" | 14:20 |
| lucasagomes | so you get a shell you can play with | 14:20 |
| naohirot | rameshg87: Okay I added those to my cheetsheat too :) | 14:20 |
| lucasagomes | naohirot, and run those gunzip/find... as root | 14:20 |
| lucasagomes | or u can get it not booting due permission problems | 14:20 |
| naohirot | lucasagomes: I'd like to make sure that if the disk has no partition is okay. | 14:21 |
| lucasagomes | naohirot, fair enuff :) | 14:21 |
| naohirot | lucasagomes: ramdisk creates partition, right? | 14:22 |
| victor_lowther | ifarkas: https://review.openstack.org/#/c/150488/ has been updated for your reviewing pleasure. | 14:22 |
| ifarkas | victor_lowther, great, I will check it ;-) | 14:23 |
| Shrews | lucasagomes: Hey. I ended up changing my vote on this review (https://review.openstack.org/145690). I've rebuilt my devstack env a couple of times and have run into this issue where --nic needs to be specified during boot. I'm not sure why, which makes me sad. | 14:30 |
| *** rloo has joined #openstack-ironic | 14:31 | |
| lucasagomes | Shrews, lemme see | 14:31 |
| lucasagomes | Shrews, oh randomly ? :( :( :( :( | 14:32 |
| *** EmilienM is now known as EmilienM|afk | 14:32 | |
| *** Nisha has quit IRC | 14:32 | |
| lucasagomes | Shrews, did you source only openrc for credentials? | 14:32 |
| *** Nisha has joined #openstack-ironic | 14:33 | |
| Shrews | lucasagomes: maybe random was the wrong word. it didn't happen before, but now seems to occur constantly | 14:33 |
| Shrews | lucasagomes: yeah, only openrc | 14:33 |
| lucasagomes | Shrews, ack, alright I will approve it then | 14:33 |
| lucasagomes | :( | 14:33 |
| Shrews | but your question makes me wonder... could it be a difference between the admin and non-admin accounts? | 14:34 |
| lucasagomes | Shrews, I think so | 14:34 |
| lucasagomes | that's the thing, I haven't tried, sometimes I source admin because I want to do a ironic node-list etc | 14:35 |
| lucasagomes | and forget it before doing nova boot | 14:35 |
| lucasagomes | that yes, can cause problems | 14:35 |
| *** BadCub_ has joined #openstack-ironic | 14:36 | |
| lucasagomes | Shrews, I changed my vote there, didn't approve jsut in case u want to test the credentials thing | 14:37 |
| Shrews | lucasagomes: i do want to test. thx | 14:37 |
| lucasagomes | Shrews, cool, thank you for looking deeper into it | 14:38 |
| jroll | rameshg87: dtantsur: we're using a proprietary tool for in-band raid? :x the call to that is shipping in an external hardware manager yes? | 14:49 |
| jroll | morning lucasagomes Shrews and everyone else :) | 14:50 |
| dtantsur | jroll, morning | 14:50 |
| Shrews | jroll: morning | 14:50 |
| rameshg87 | jroll, morning | 14:50 |
| lucasagomes | jroll, yo morning | 14:50 |
| jroll | morning :) | 14:50 |
| lucasagomes | jroll, yeah, probably we can't ship it | 14:50 |
| lucasagomes | we cna give instructions on how to build that | 14:50 |
| jroll | right | 14:51 |
| rameshg87 | jroll, for hp inband raid, it's free but not opensource | 14:51 |
| rloo | morning ironickers. Looks like you were all busy yesterday ;) | 14:51 |
| rameshg87 | jroll, so anyone can build it using dib or dockerfile | 14:51 |
| jroll | we use proprietary firmware tools, but the call to that is either closed source or in our hardware manager | 14:51 |
| jroll | rameshg87: yes, but I don't think IPA should depend on a closed-source tool | 14:51 |
| dtantsur | that leaves us with only DELL for RAID upstream... | 14:51 |
| rameshg87 | jroll, yeah that's why a new hardware manager .. | 14:51 |
| dtantsur | rloo, morning! | 14:51 |
| jroll | dtantsur: and mdadm :) | 14:52 |
| jroll | rameshg87: ok, cool | 14:52 |
| Shrews | hi rloo, dtantsur | 14:52 |
| jroll | morning rloo :) | 14:52 |
| dtantsur | jroll, definitely :) | 14:52 |
| dtantsur | Shrews, morning to you too :) | 14:52 |
| rloo | morning Shrews, jroll. Hi dtantsur, lucasagomes, rameshg87 :) | 14:52 |
| lucasagomes | rloo, hi good morning | 14:52 |
| rameshg87 | morning rloo :) | 14:52 |
| *** foexle has quit IRC | 14:53 | |
| *** Nisha has quit IRC | 14:55 | |
| Shrews | lucasagomes: interesting. --nic is required with admin, but NOT with demo user | 14:56 |
| lucasagomes | Shrews, yeah, def running things as admin can cause some troubles | 14:57 |
| lucasagomes | I haven't looked much into it | 14:57 |
| lucasagomes | Shrews, you think that was the problem there? | 14:57 |
| lucasagomes | if so, I don't think we should ever run with admin | 14:57 |
| lucasagomes | nor the guidelines should do that | 14:57 |
| Shrews | lucasagomes: yeah, me neither. our devstack doc does not use the admin account in the example, so i think the patch is invalid | 14:58 |
| jroll | demo user probably has a default nic | 14:58 |
| lucasagomes | Shrews, right | 14:58 |
| Shrews | jroll: is that specified in lib/ironic somewhere? (if you know offhand) | 14:58 |
| jroll | Shrews: the default nic/network? | 14:59 |
| jroll | probably defined in nova or neutron stuff | 14:59 |
| jroll | that isn't specific to us, I'm sure | 14:59 |
| Shrews | eh. may look into it sometime when things get slow | 14:59 |
| *** saripurigopi has joined #openstack-ironic | 15:00 | |
| *** mgoddard1 has joined #openstack-ironic | 15:00 | |
| *** mgoddard has quit IRC | 15:01 | |
| rloo | sigh. everyone, wrt https://review.openstack.org/147857, we aren't deleting the *ED states. | 15:02 |
| dtantsur | looks like we don't have agreement on this one :) I thought we decided to keep them, but then people started commenting on the inspection patch... | 15:04 |
| jroll | *everyone* has gone back and forth on it | 15:05 |
| rloo | dtantsur: in one of our meetings, I thought it was discussed. the *ED should stay. The question is what happens in *ED state and how to transition from that to the passive/stable state. | 15:05 |
| *** lazy_prince is now known as killer_prince | 15:05 | |
| jroll | deva included | 15:05 |
| rloo | jroll: we don't seem to be very effective communicators :-( | 15:05 |
| jroll | rloo: nope | 15:05 |
| jroll | email is good, we should use that more | 15:05 |
| jroll | now | 15:05 |
| jroll | the latest patch removes the INSPECTED state | 15:06 |
| rloo | jroll: yes, I just noticed that. | 15:06 |
| jroll | are we ok with that? | 15:06 |
| *** absubram has joined #openstack-ironic | 15:06 | |
| jroll | also, should one be able to retry a failed inspection? | 15:06 |
| dtantsur | definitely | 15:06 |
| rloo | jroll: I would like the *ED back since it is in the spec, but poor Nisha... | 15:06 |
| naohirot | good night all :) | 15:06 |
| *** naohirot has quit IRC | 15:07 | |
| jroll | dtantsur: right, ok, I missed it | 15:07 |
| rloo | jroll: the retry of a failed inspection has to be done by an API call so yes, I think we should allow it. | 15:07 |
| dtantsur | rloo, what if we ask her to create one more patch adding *ED states, and start discussing there? | 15:07 |
| rloo | jroll: but yeah, good question. cuz we're going to have to think about it for every *FAIL. | 15:07 |
| dtantsur | provided we can agree on everything BUT *ED state | 15:07 |
| jroll | rloo: right, I thought it wasn't allowing it and thought it should, it's fine | 15:07 |
| jroll | dtantsur: +1 | 15:08 |
| jroll | I personally think it's not necessary | 15:08 |
| jroll | spec be damned :) | 15:08 |
| rloo | dtantsur: I thought Nisha mentioned that she was doing something in the ED state, but yeah, fine for now. | 15:08 |
| rloo | jroll: we spent a lot of time on that beautiful spec :-) | 15:08 |
| jroll | rloo: :P | 15:09 |
| dtantsur | rloo, it will use return value of inspect_hardware to figure out whether inspection is finished (return INSPECTED) or not finished aka async aka in-band (return INSPECTING) | 15:09 |
| dtantsur | that's the only use cases I'm aware of _right now_ | 15:09 |
| jroll | are we ever going to do it synchronously? | 15:09 |
| dtantsur | jroll, it's not sync in terms of API | 15:10 |
| jroll | also, I know devananda got rid of that model with the other stuff via callbacks or something | 15:10 |
| jroll | ah, right | 15:10 |
| rloo | my question is: is it easier to add *ED later if needed, or add *ED now and if not needed, delete later? | 15:10 |
| dtantsur | I just mean whether inspect_hardware returns after doing all the stuff (OOB) or after just initiating stuff (IB) | 15:10 |
| dtantsur | rloo, from compatibility POV it's easier to add | 15:10 |
| jroll | rloo: once we have a state, people may depend on it :) | 15:11 |
| jroll | out of tree drivers and such | 15:11 |
| rloo | dtantsur, jroll: OK, then better not to put it in until we're sure. | 15:11 |
| jroll | I agree | 15:12 |
| jroll | I +2'd the patch, but going to let others weigh in | 15:12 |
| dtantsur | please no, let's finally approve it :D | 15:12 |
| jroll | unless you want me to just go ahead and approve so we don't fight any longer :) | 15:12 |
| jroll | boom | 15:12 |
| jroll | done | 15:12 |
| dtantsur | woohoo! finally some progress with inspection | 15:12 |
| rloo | dtantsur: you only wanted it approved for selfish reasons ;) | 15:13 |
| jroll | \o/ | 15:13 |
| jroll | heh | 15:13 |
| rloo | thx jroll. if you hadn't done it, I would have. | 15:13 |
| dtantsur | rloo, as everything I do 8-) | 15:13 |
| * dtantsur is evil | 15:13 | |
| rloo | if dtantsur is evil, I have to wonder about the rest of us ;) | 15:13 |
| dtantsur | :) | 15:14 |
| rloo | ok, who wants to start the email discussion about *ED states? | 15:14 |
| * jroll hides | 15:14 | |
| dtantsur | lemme find the first message here.... | 15:14 |
| dtantsur | <rloo> sigh. everyone, wrt https://review.openstack.org/147857, we aren't deleting the *ED states. | 15:14 |
| dtantsur | here I found ^^^ | 15:14 |
| jroll | lol | 15:14 |
| *** saripurigopi has quit IRC | 15:14 | |
| rloo | dtantsur: huh? | 15:15 |
| *** saripurigopi has joined #openstack-ironic | 15:15 | |
| dtantsur | rloo, I found one to blame by finding one who posted the first message on the topic | 15:15 |
| dtantsur | rloo, looks like it's you | 15:15 |
| * dtantsur is REALLY evil | 15:16 | |
| rloo | dtantsur: I said to delete it? | 15:16 |
| dtantsur | heh, to be serious, I can start the discussion | 15:16 |
| lucasagomes | jroll, JoshNang for the cleaning/zapping tasks... the methods it's going to run is hardcoded in the driver is that right? | 15:17 |
| rloo | thx dtantsur. I think we should keep it but I haven't thought much about it. Although I could see myself suggesting to delete it just cuz that is always an option. | 15:17 |
| jroll | lucasagomes: I believe it collects them from all drivers based on a decorator, kind of like the driver tasks thing | 15:18 |
| lucasagomes | jroll, JoshNang have you thought in the future to make it like, extendable somehow? where people could delete/add new tasks without having to change the code? | 15:18 |
| lucasagomes | jroll, right | 15:18 |
| jroll | lucasagomes: idk, I haven't been paying much attention to that stuff | 15:18 |
| lucasagomes | jroll, right, I was thinking about it. Because not all the zapping tasks will go upstream | 15:19 |
| lucasagomes | say firmware updates etc | 15:19 |
| lucasagomes | so it would be good to have a way to drop a file somewhere in the filesystem and have the Ironic conductor to look at it | 15:19 |
| lucasagomes | and include that extra task as part of zapping/cleaning | 15:19 |
| jroll | lucasagomes: right, I know hardware managers can deploy a thing, idk what we're doing for oob stuff | 15:20 |
| jroll | s/deploy/declare | 15:20 |
| lucasagomes | without making people to patch downstream their code to add some vendor stuff | 15:20 |
| jroll | right, agree, we should figure that out | 15:20 |
| lucasagomes | jroll, I see... cool | 15:20 |
| lucasagomes | food for thought :) | 15:20 |
| jroll | indeed :) | 15:20 |
| jroll | lucasagomes: I assume drac and ilo would do firmware update oob? | 15:21 |
| lucasagomes | jroll, right, yeah that's an example of something that can be done both ways | 15:21 |
| lucasagomes | but it may have some tasks which needs to be done only in-band | 15:21 |
| lucasagomes | like the HP raid stuff | 15:21 |
| jroll | right | 15:21 |
| * dtantsur wrote to the ML | 15:26 | |
| jroll | oh goody | 15:26 |
| openstackgerrit | Merged openstack/ironic: For flake8 check, make the 'E12' ignore be more granular https://review.openstack.org/157171 | 15:28 |
| * lucasagomes refresh his email | 15:28 | |
| *** achanda has joined #openstack-ironic | 15:33 | |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: Add Proliant Hardware Manager for IPA https://review.openstack.org/157291 | 15:37 |
| rameshg87 | jroll, JoshNang, JayF, please have a look at this when you get some time: https://review.openstack.org/#/c/157316/ | 15:39 |
| rameshg87 | jroll, JoshNang, JayF, add decom extensions for RAID | 15:39 |
| jroll | rameshg87: yeah, looking | 15:39 |
| rameshg87 | jroll, JoshNang, JayF, and the hardware manager that we are building will be in proliantutils: https://review.openstack.org/#/c/157291/2 | 15:40 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Use less verbose imports for i18n https://review.openstack.org/157419 | 15:41 |
| *** achanda has quit IRC | 15:41 | |
| *** EmilienM|afk is now known as EmilienM | 15:41 | |
| rameshg87 | would love if you guys have comment on the hardware manager in proliantutils (eventhough it is not in your usual radar) | 15:41 |
| * rameshg87 leaves for the day | 15:42 | |
| rameshg87 | having a good day everyone :) | 15:42 |
| jroll | rameshg87: you'll probably want to talk to JoshNang about the decom extension | 15:42 |
| jroll | as that will probably change to clean or something | 15:42 |
| jroll | but we could land this and move it later :) | 15:42 |
| jroll | have a good night :) | 15:42 |
| rameshg87 | jroll, sure .. :) | 15:42 |
| rameshg87 | jroll, please post comment if you have some .. | 15:43 |
| rameshg87 | good day jroll | 15:43 |
| *** rameshg87 has quit IRC | 15:43 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Always use non-localized strings in unit tests https://review.openstack.org/157422 | 15:50 |
| *** mgoddard1 has quit IRC | 15:51 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Fix PEP8 E121 & E122 errors https://review.openstack.org/157424 | 15:51 |
| lucasagomes | jroll, JoshNang anoher q... right now for zapping/cleaning tasks inband we are using the same deploy ramdisk right? | 15:52 |
| lucasagomes | are we thinking about having a different ramdisk that could be used for those tasks (!= deploy ramdisk) | 15:53 |
| jroll | lucasagomes: yes, and no we haven't thought about that | 15:54 |
| *** romcheg has quit IRC | 15:54 | |
| lucasagomes | jroll, right, food for thought | 15:54 |
| * lucasagomes needs to start a FFT list | 15:55 | |
| jroll | heh | 15:55 |
| *** killer_prince is now known as lazy_prince | 15:55 | |
| NobodyCam | morning jroll rloo and Shrews | 15:55 |
| rloo | morning NobodyCam | 15:55 |
| jroll | morning NobodyCam :) | 15:56 |
| NobodyCam | :) | 15:56 |
| *** korekhov has joined #openstack-ironic | 15:57 | |
| *** kozhukalov has joined #openstack-ironic | 15:57 | |
| *** pas-ha has quit IRC | 15:58 | |
| *** mgoddard has joined #openstack-ironic | 15:59 | |
| *** spandhe has joined #openstack-ironic | 15:59 | |
| *** ParsectiX has quit IRC | 16:00 | |
| *** ParsectiX has joined #openstack-ironic | 16:01 | |
| *** anderbubble has joined #openstack-ironic | 16:01 | |
| *** david-lyle_afk is now known as david-lyle | 16:04 | |
| *** korekhov_ has joined #openstack-ironic | 16:05 | |
| jlvillal | Good morning all | 16:07 |
| dtantsur | jlvillal, morning | 16:07 |
| *** saripurigopi has quit IRC | 16:07 | |
| lucasagomes | jlvillal, morning | 16:07 |
| jlvillal | dtantsur: Thanks :) | 16:07 |
| jlvillal | lucasagomes: And thanks to you all who follow :D | 16:07 |
| NobodyCam | morning jlvillal | 16:08 |
| jlvillal | s/you all/you and all/ | 16:08 |
| lucasagomes | :) | 16:08 |
| *** korekhov has quit IRC | 16:08 | |
| BadCub_ | Morning all | 16:08 |
| *** dlpartain has joined #openstack-ironic | 16:08 | |
| jlvillal | NobodyCam: BadCub_: Morning | 16:08 |
| openstackgerrit | Merged openstack/ironic: Add states required for node-inspection https://review.openstack.org/147857 | 16:24 |
| jlvillal | dtantsur: Can *ED states be optional? I'm not sure what a 'no-op' state means or how it has value. I'm reading your email now | 16:24 |
| *** krtaylor has quit IRC | 16:25 | |
| dtantsur | jlvillal, what do you mean by optional state? no-op means that transition from it is done right after transition into it without any actions in between | 16:25 |
| jlvillal | dtantsur: To me they are optional. If they aren't used then don't put them into the code. If there is a value for an *ED state then put it into the code. | 16:26 |
| dtantsur | well, maybe :) let's see what people say, IIRC devananda had some idea.. | 16:26 |
| jlvillal | I'm not sure how a 'no-op' is handled. I don't think the state machine has a concept of a 'no-op'. So it sounds to me like the code will need to do two transitions in a row. | 16:27 |
| *** pcrews has quit IRC | 16:27 | |
| jlvillal | The code outside of fsm.py, that is | 16:27 |
| dtantsur | I think it will be implemented like that | 16:27 |
| jlvillal | dtantsur: That seems ugly to me :) | 16:27 |
| dtantsur | I don't really insist (though it would be convenient for inspection) | 16:27 |
| jlvillal | dtantsur: I'm curious how it is valuable for transition? If a 'no-op' then it would only be in that state for a very brief moment. Unless I'm missing something. | 16:28 |
| dtantsur | jlvillal, IIRC the idea was that we can change it later to be meaningful without changing users | 16:29 |
| jlvillal | dtantsur: Is that easier than adding the *ED state later? I guess a little bit, but to me with a cost of some cruft in the code. | 16:30 |
| jroll | imo we should conversate about this on the mailing list >.> | 16:31 |
| jlvillal | jroll: I'm trying to formulate my reply ;) | 16:31 |
| jroll | :P | 16:31 |
| jroll | morning jlvillal :) | 16:32 |
| jlvillal | jroll: Good morning! | 16:32 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Remove unused OS_TEST_TIMEOUT variable https://review.openstack.org/155408 | 16:33 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Fix PEP8 E121 & E122 errors https://review.openstack.org/157424 | 16:33 |
| *** openstackgerrit has quit IRC | 16:36 | |
| *** saripurigopi has joined #openstack-ironic | 16:36 | |
| *** openstackgerrit has joined #openstack-ironic | 16:36 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Consistent names of args and metavars, and help strings https://review.openstack.org/155031 | 16:41 |
| GheRivero | morning Ironic | 16:43 |
| openstackgerrit | Merged openstack/ironic: Avoid deregistering conductor following SIGUSR1 https://review.openstack.org/155785 | 16:44 |
| jlvillal | GheRivero: Good morning | 16:44 |
| NobodyCam | morning GheRivero :) | 16:45 |
| *** spandhe has quit IRC | 16:46 | |
| *** krtaylor has joined #openstack-ironic | 16:47 | |
| *** lazy_prince is now known as killer_prince | 16:49 | |
| *** gridinv has quit IRC | 16:52 | |
| *** dlpartain has quit IRC | 16:54 | |
| *** killer_prince is now known as lazy_prince | 16:55 | |
| *** coolsvap is now known as coolsvap_ | 16:57 | |
| *** dprince has joined #openstack-ironic | 16:58 | |
| *** anderbubble has quit IRC | 17:00 | |
| jlvillal | Not sure if anyone can give some love to: https://review.openstack.org/156655 and https://review.openstack.org/155529 Or let me know what the proper way to ask for additional reviews is. Thanks. | 17:02 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: [WIP] Proper client for ironic-discoverd https://review.openstack.org/157448 | 17:04 |
| *** ParsectiX has quit IRC | 17:05 | |
| *** ParsectiX has joined #openstack-ironic | 17:06 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Change i18n domain to match what is generated in oslo-incubator sync https://review.openstack.org/157451 | 17:08 |
| *** Marga_ has joined #openstack-ironic | 17:08 | |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| *** Marga_ has quit IRC | 17:09 | |
| *** Marga_ has joined #openstack-ironic | 17:10 | |
| *** anderbubble has joined #openstack-ironic | 17:10 | |
| *** pcrews has joined #openstack-ironic | 17:21 | |
| *** erwan_taf has quit IRC | 17:23 | |
| *** jcoufal has quit IRC | 17:25 | |
| *** jistr has quit IRC | 17:28 | |
| *** derekh has quit IRC | 17:34 | |
| *** Shrews has quit IRC | 17:34 | |
| *** Shrews has joined #openstack-ironic | 17:41 | |
| *** spandhe has joined #openstack-ironic | 17:42 | |
| *** ParsectiX has quit IRC | 17:44 | |
| *** ParsectiX has joined #openstack-ironic | 17:44 | |
| *** rloo has quit IRC | 17:50 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Add the image extension (for local boot) https://review.openstack.org/157469 | 18:05 |
| lucasagomes | https://review.openstack.org/#/c/155727/ <- IPA guys, when you have a chance please take a look (that's the iscsi bit) | 18:06 |
| *** harlowja has joined #openstack-ironic | 18:10 | |
| Shrews | InstanceDeployFailure: Failed to provision instance 6fe8e741-b1a6-40d1-a240-6bde29e8e094: Failed to deploy. Error: Could not authorize in Keystone: A username and password or token is required. | 18:14 |
| Shrews | yay broken devstack | 18:14 |
| Shrews | why is it so hard to get a working devstack deploy??? | 18:15 |
| * Shrews is doing it wrong, obviously | 18:15 | |
| *** ParsectiX has quit IRC | 18:16 | |
| *** ParsectiX has joined #openstack-ironic | 18:16 | |
| adam_g | Shrews, i think that is https://bugs.launchpad.net/ironic/+bug/1418341 | 18:19 |
| openstack | Launchpad bug 1418341 in Ironic "keystone_authtoken configuration error in ironic.conf from devstack" [Undecided,In progress] | 18:19 |
| lucasagomes | folks I will call it aday | 18:19 |
| lucasagomes | gotta get the train home still | 18:19 |
| *** absubram has quit IRC | 18:19 | |
| lucasagomes | have a good night everyone | 18:19 |
| adam_g | cya | 18:20 |
| *** lucasagomes has quit IRC | 18:20 | |
| NobodyCam | night lucas | 18:20 |
| Shrews | adam_g: are we hitting this in the gate, too? | 18:21 |
| Shrews | doesn't seem so | 18:21 |
| adam_g | Shrews, i dont think so. the only time its hit is if you end up with an expired token somewhere in the flow of things, and ironic needs to re-auth with keystone using configured credentials | 18:22 |
| adam_g | Shrews, a quick workaround is to add these to your ironic.conf (or pull this devstack patch) https://review.openstack.org/#/c/155360/5/lib/ironic | 18:23 |
| Shrews | adam_g: So maybe I'm hitting this on my HP cloud instance b/c it's so darned slow? | 18:23 |
| Shrews | seems to error quickly :( | 18:24 |
| Shrews | ugh | 18:24 |
| adam_g | Shrews, heh maybe? tho token expiry by default is like.. an hour | 18:24 |
| Shrews | that's not it then | 18:24 |
| * Shrews tries the patch | 18:25 | |
| adam_g | Shrews, so, not sure what would cause the re-auth to happen, but the issue is *probably* those config values | 18:25 |
| *** achanda has joined #openstack-ironic | 18:31 | |
| *** saripurigopi has quit IRC | 18:31 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_config generator https://review.openstack.org/128005 | 18:39 |
| *** penick has joined #openstack-ironic | 18:39 | |
| *** EmilienM is now known as EmilienM|afk | 18:40 | |
| Shrews | adam_g: temp fix seems to work. thx | 18:41 |
| adam_g | Shrews, hoping to fix that in ironic itself. we shouldn't be dependent on those config values.. tho i still have NFI what devstack is doing with them | 18:42 |
| *** faizan has joined #openstack-ironic | 18:42 | |
| Shrews | ack | 18:42 |
| *** datajerk has joined #openstack-ironic | 18:49 | |
| *** jjohnson2 has quit IRC | 18:56 | |
| *** jjohnson2 has joined #openstack-ironic | 18:57 | |
| *** kozhukalov has quit IRC | 19:00 | |
| *** rloo has joined #openstack-ironic | 19:02 | |
| *** jjohnson2_ has joined #openstack-ironic | 19:04 | |
| *** jjohnson2 has quit IRC | 19:08 | |
| *** jjohnson2_ has quit IRC | 19:09 | |
| *** r-daneel has joined #openstack-ironic | 19:10 | |
| *** achanda has quit IRC | 19:11 | |
| *** jjohnson2 has joined #openstack-ironic | 19:13 | |
| JoshNang | AFAICT, if a node fails driver.power.validate(), it looks like it returns an API error but doesn't put the node in any sort of error state. am i missing something? e.g. https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L666 | 19:14 |
| devananda | morning, all | 19:16 |
| NobodyCam | morning devananda :) | 19:17 |
| JayF | JoshNang: I guess I'd worry a little bit about transient IPMI errors / networking problems taking a node out of rotation | 19:17 |
| JayF | ahead of when it's configured to in that case by power status loop retry settings | 19:17 |
| JayF | if that makes sense? | 19:17 |
| rloo | morning devananda | 19:18 |
| JoshNang | JayF: hrm true | 19:18 |
| JoshNang | and if it really is a continuing ipmi error, it'll get caught by the power state loop | 19:18 |
| *** r-daneel has quit IRC | 19:19 | |
| JayF | Yeah. | 19:19 |
| JoshNang | alright! works for me. | 19:19 |
| JayF | Generally speaking we could unify that; IPMI_FAILURE_COUNT or something, and have all various ipmi things feed into it | 19:19 |
| JayF | power status loop, validate, actual ipmi calls | 19:20 |
| JayF | but ... meh | 19:20 |
| JoshNang | hrm, not sure how to handle a power validation failure in cleaning though. i don't really want to throw an error, because once you're in cleaning, you shouldn't prevent the tenant from finishing the delete.. | 19:21 |
| JoshNang | i guess cleanfail makes sense at that point | 19:22 |
| *** achanda has joined #openstack-ironic | 19:34 | |
| *** faizan has quit IRC | 19:36 | |
| *** krtaylor has quit IRC | 19:38 | |
| openstackgerrit | Merged openstack/ironic: Use oslo_utils replace oslo.utils https://review.openstack.org/149450 | 19:43 |
| *** pelix has quit IRC | 19:44 | |
| openstackgerrit | Victor Sergeyev proposed openstack/ironic: Run tests in py34 environment https://review.openstack.org/156192 | 19:46 |
| *** penick has quit IRC | 19:54 | |
| *** Marga_ has quit IRC | 19:54 | |
| *** penick has joined #openstack-ironic | 20:04 | |
| *** dprince has quit IRC | 20:08 | |
| *** dprince has joined #openstack-ironic | 20:16 | |
| *** krtaylor has joined #openstack-ironic | 20:16 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_config generator https://review.openstack.org/128005 | 20:20 |
| *** jjohnson2 has quit IRC | 20:20 | |
| *** jjohnson2 has joined #openstack-ironic | 20:23 | |
| *** Marga_ has joined #openstack-ironic | 20:25 | |
| *** achanda has quit IRC | 20:28 | |
| *** Marga_ has quit IRC | 20:30 | |
| *** penick has quit IRC | 20:31 | |
| jlvillal | GheRivero: question for you | 20:31 |
| GheRivero | jlvillal: shoot | 20:32 |
| jlvillal | GheRivero: https://review.openstack.org/#/c/128005/6/ironic/opts.py Line 66. I'm confused on value of _build_list there. | 20:32 |
| *** achanda has joined #openstack-ironic | 20:32 | |
| GheRivero | you are creating a lists of opts by iterating into each block of opts that are in each module | 20:35 |
| jlvillal | GheRivero: But it seems like it already is a list. Or am I missing something | 20:37 |
| GheRivero | the list that we need is not the modules, but the options inside the modules | 20:38 |
| *** pensu has quit IRC | 20:40 | |
| jlvillal | GheRivero: Thanks. Looking again... | 20:40 |
| jlvillal | GheRivero: Okay, makes sense now :) Thanks for the explanation! | 20:41 |
| NobodyCam | jroll: want to comment on: https://review.openstack.org/#/c/156587 ? | 20:45 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement Cleaning States https://review.openstack.org/153444 | 20:46 |
| jlvillal | JoshNang: Am I only the only person who thinks VERBS should be a namedtuple? | 20:47 |
| jlvillal | And not a dict | 20:47 |
| * jlvillal thinks about submitting a patch... | 20:48 | |
| GheRivero | jlvillal: you are welcome | 20:49 |
| jroll | NobodyCam: done | 20:50 |
| NobodyCam | :) | 20:51 |
| NobodyCam | tk jroll | 20:51 |
| NobodyCam | ty even | 20:51 |
| jroll | np | 20:52 |
| *** ifarkas has quit IRC | 20:55 | |
| *** jlvillal has quit IRC | 20:56 | |
| rloo | jroll: do you know why this wasn't approved yet? https://review.openstack.org/#/c/156655/ (maybe you can?) | 21:00 |
| *** jlvillal has joined #openstack-ironic | 21:03 | |
| *** achanda has quit IRC | 21:06 | |
| *** spandhe has quit IRC | 21:10 | |
| *** penick has joined #openstack-ironic | 21:16 | |
| jroll | rloo: no idea, but I just did it | 21:17 |
| NobodyCam | cores review with +2's and a +1 anyone have a free minute for a review https://review.openstack.org/#/c/155460 | 21:17 |
| rloo | thx jroll ;) | 21:17 |
| rloo | NobodyCam: am just looking at that now. I'm going to -1 it. | 21:17 |
| mrda | Morning | 21:17 |
| *** spandhe has joined #openstack-ironic | 21:17 | |
| *** Marga_ has joined #openstack-ironic | 21:19 | |
| rloo | NobodyCam: let me know if you disagree | 21:19 |
| NobodyCam | morning mrda :) | 21:19 |
| mrda | \o NobodyCam | 21:20 |
| rloo | NobodyCam: or if it can be done in a followup patch | 21:20 |
| *** Marga_ has quit IRC | 21:20 | |
| *** Marga_ has joined #openstack-ironic | 21:20 | |
| openstackgerrit | Merged openstack/ironic-specs: Use the term 'stable state' instead of 'passive state' https://review.openstack.org/156655 | 21:21 |
| NobodyCam | I can fix that | 21:21 |
| rloo | NobodyCam: wrt 155460, this may be a dumb question. but do we need to regenerate the pxe config files if booting from local disk? | 21:21 |
| NobodyCam | to deploy the deploy ramdisk | 21:22 |
| JoshNang | jlvillal: i don't know that namedtuple buys us anything more than a dict | 21:22 |
| NobodyCam | this is on takeover | 21:22 |
| * devananda closes down, heads into the tripleo meetup | 21:23 | |
| jlvillal | JoshNang: I like the idea of VERBS.manage. Seems cleaner. | 21:23 |
| NobodyCam | have fun devananda | 21:23 |
| NobodyCam | :) | 21:23 |
| rloo | NobodyCam: yes, right, thx. | 21:23 |
| jlvillal | devananda: I guess you get to meet the new PTL :) | 21:23 |
| devananda | jlvillal: is the difference in style really that important? | 21:24 |
| *** achanda has joined #openstack-ironic | 21:24 | |
| mrda | rloo: FWIW, I agree with your assessment on 155460. It's probably better to return for invalid root_uuid and not save to driver_internal_info | 21:24 |
| rloo | thx mrda. | 21:24 |
| NobodyCam | yep fixing now | 21:24 |
| jlvillal | devananda: That important? No. But maybe cleaner. Let me look more closely and see how it is being used. | 21:25 |
| rloo | thx NobodyCam. You'll get my +2 after that! | 21:25 |
| *** meghal has joined #openstack-ironic | 21:29 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Correctly rebuild the PXE file during takeover of ACTIVE nodes https://review.openstack.org/155460 | 21:30 |
| *** Marga_ has quit IRC | 21:30 | |
| *** Marga_ has joined #openstack-ironic | 21:31 | |
| *** lazy_prince is now known as killer_prince | 21:39 | |
| *** achanda has quit IRC | 21:40 | |
| *** meghal has quit IRC | 21:41 | |
| *** andreykurilin_ has joined #openstack-ironic | 21:45 | |
| *** achanda has joined #openstack-ironic | 21:46 | |
| jlvillal | rloo: The blocking patch for https://review.openstack.org/155529 has been merged. Wondering if you have any other concerns. | 21:48 |
| rloo | jlvillal: oh. can't remember. let me look. (in the middle of another review.) | 21:49 |
| jlvillal | rloo: Thanks | 21:49 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Correctly rebuild the PXE file during takeover of ACTIVE nodes https://review.openstack.org/155460 | 21:53 |
| *** pensu has joined #openstack-ironic | 21:57 | |
| *** Marga_ has quit IRC | 22:01 | |
| *** jjohnson2 has quit IRC | 22:02 | |
| *** viktors has quit IRC | 22:08 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Mock sleep function for OtherFunctionTestCase https://review.openstack.org/157551 | 22:08 |
| *** meghal has joined #openstack-ironic | 22:10 | |
| *** viktors has joined #openstack-ironic | 22:12 | |
| *** meghal has quit IRC | 22:12 | |
| *** meghal1 has joined #openstack-ironic | 22:12 | |
| *** zer0c00l has quit IRC | 22:14 | |
| *** zer0c00l has joined #openstack-ironic | 22:14 | |
| *** openstackstatus has joined #openstack-ironic | 22:15 | |
| *** ChanServ sets mode: +v openstackstatus | 22:15 | |
| *** meghal1 has quit IRC | 22:16 | |
| *** kbs has quit IRC | 22:17 | |
| *** kbs has joined #openstack-ironic | 22:17 | |
| jlvillal | NobodyCam: You might be interested in my patch: https://review.openstack.org/157551 | 22:17 |
| jlvillal | Looks like I am touching code from you from two days ago??? | 22:18 |
| NobodyCam | jroll: as you've commented on it resently you may want to look at my latest comment on https://review.openstack.org/#/c/135845 | 22:18 |
| NobodyCam | jlvillal: looking | 22:18 |
| jroll | NobodyCam: thanks for the heads up | 22:19 |
| NobodyCam | jlvillal: I don't think I fiddled with time. in my tests so should be ok :) | 22:19 |
| NobodyCam | jroll: :) | 22:20 |
| jlvillal | NobodyCam: Thanks for looking. I just happened to notice the test time when I was working. | 22:20 |
| * jlvillal tries to figure out best NUC to order for use with Ironic. Thinking something that supports AMT would be good. | 22:21 | |
| * NobodyCam has a d54250WYHK | 22:22 | |
| jlvillal | NobodyCam: Is that a recommendation? Does it work well for testing? | 22:23 |
| NobodyCam | lol not a recommendation. I have not used it for testing :-p | 22:23 |
| jlvillal | Argh! ;) | 22:23 |
| NobodyCam | but is it a nice i5 | 22:24 |
| NobodyCam | :-p | 22:24 |
| *** penick has quit IRC | 22:26 | |
| *** meghal has joined #openstack-ironic | 22:27 | |
| *** penick has joined #openstack-ironic | 22:34 | |
| *** penick has quit IRC | 22:34 | |
| NobodyCam | jlvillal: would you kill me if I asked of a doc string on 157551 that just states its nooping time to speedup the test. I can read the code to see whats its doing but would really like to see why. ??? | 22:37 |
| jlvillal | NobodyCam: I could do that. I copied the code from up above ;) | 22:37 |
| jlvillal | let me add a docstring | 22:37 |
| NobodyCam | :) that would be awesome TY | 22:37 |
| jlvillal | NobodyCam: By docstring, can that be a comment? Or a real docstring? | 22:38 |
| NobodyCam | oh ya... | 22:38 |
| NobodyCam | thats perfect | 22:39 |
| jlvillal | Okay, doing a comment... | 22:39 |
| NobodyCam | :) | 22:39 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Mock sleep function for OtherFunctionTestCase https://review.openstack.org/157551 | 22:42 |
| *** meghal has quit IRC | 22:43 | |
| jlvillal | NobodyCam: Done ^^^ | 22:44 |
| NobodyCam | jlvillal: ++ TY | 22:45 |
| *** jgrimm is now known as zz_jgrimm | 22:55 | |
| NobodyCam | JoshNang: I think line 272 of https://review.openstack.org/#/c/153444/17/ironic/common/states.py is not correct | 23:04 |
| NobodyCam | machine.add_transition(MANAGEABLE, CLEANING, 'provide') <-- s/provide/clean/ | 23:04 |
| *** penick has joined #openstack-ironic | 23:06 | |
| JoshNang | NobodyCam: heh i agree, i'm not a fan. the api verb to go manageable->cleaning is provide, so i used that for consistency | 23:06 |
| NobodyCam | or am I missing the intent of causing provide to go thru cleaning | 23:06 |
| NobodyCam | ack | 23:07 |
| *** meghal has joined #openstack-ironic | 23:08 | |
| *** Guest936 has joined #openstack-ironic | 23:13 | |
| *** Guest936 is now known as annegentle | 23:13 | |
| openstackgerrit | Merged openstack/ironic: Add documentation for the IPMI retry timeout option https://review.openstack.org/131296 | 23:15 |
| meghal | hello…I had a quick question about how nova-compute selects ironic target nodes for deployment in juno? | 23:15 |
| meghal | I had used icehouse previously and had seen that it selected available nodes based on power state (which was being updated periodically) | 23:16 |
| meghal | so is there some provision to control selection of available ironic nodes ? | 23:16 |
| *** anderbubble has quit IRC | 23:18 | |
| *** mjturek1 has quit IRC | 23:19 | |
| *** yuanying has joined #openstack-ironic | 23:20 | |
| NobodyCam | meghal: Hi, I am not understanding the question. is your questoin to exclude nodes from nova scheduler? | 23:25 |
| *** Marga_ has joined #openstack-ironic | 23:30 | |
| *** meghal1 has joined #openstack-ironic | 23:39 | |
| *** meghal1 has quit IRC | 23:39 | |
| *** meghal has quit IRC | 23:39 | |
| *** meghal has joined #openstack-ironic | 23:39 | |
| *** andreykurilin_ has quit IRC | 23:40 | |
| *** meghal has quit IRC | 23:49 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_config generator https://review.openstack.org/128005 | 23:54 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic: Use oslo_log lib https://review.openstack.org/157602 | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!