| *** romcheg1 has joined #openstack-ironic | 00:00 | |
| *** anderbubble has joined #openstack-ironic | 00:02 | |
| *** romcheg1 has quit IRC | 00:27 | |
| NobodyCam | Anyone have anything for the Agenda? | 00:28 |
|---|---|---|
| *** Masahiro has joined #openstack-ironic | 00:37 | |
| *** naohirot has joined #openstack-ironic | 00:38 | |
| *** Masahiro has quit IRC | 00:42 | |
| naohirot | good morning ironic | 00:42 |
| *** ryanpetrello has joined #openstack-ironic | 00:43 | |
| *** tylerdurden has quit IRC | 00:54 | |
| *** shakamunyi has joined #openstack-ironic | 00:55 | |
| *** Masahiro has joined #openstack-ironic | 00:55 | |
| *** ryanpetrello has quit IRC | 00:59 | |
| *** ryanpetrello has joined #openstack-ironic | 01:01 | |
| *** ryanpetrello has quit IRC | 01:12 | |
| *** chenglch has joined #openstack-ironic | 01:23 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: iRMC Virtual Media Deploy Driver for Ironic https://review.openstack.org/134865 | 01:33 |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: iRMC Management Driver for Ironic https://review.openstack.org/136020 | 01:42 |
| *** Haomeng|2 has quit IRC | 01:48 | |
| *** anderbubble has quit IRC | 01:55 | |
| *** Haomeng has joined #openstack-ironic | 02:08 | |
| *** Marga_ has quit IRC | 02:11 | |
| *** pcrews has joined #openstack-ironic | 02:18 | |
| *** pcrews has quit IRC | 02:27 | |
| *** ramineni has joined #openstack-ironic | 02:43 | |
| *** anderbubble has joined #openstack-ironic | 02:48 | |
| *** anderbubble has quit IRC | 02:49 | |
| *** anderbubble has joined #openstack-ironic | 02:50 | |
| *** jerryz has joined #openstack-ironic | 02:54 | |
| *** jiangfei has joined #openstack-ironic | 02:56 | |
| *** spandhe has joined #openstack-ironic | 02:57 | |
| *** anderbubble has quit IRC | 03:21 | |
| *** naohirot has quit IRC | 03:26 | |
| *** Masahiro has quit IRC | 03:27 | |
| *** spandhe has quit IRC | 03:37 | |
| *** Nisha has joined #openstack-ironic | 03:37 | |
| *** spandhe has joined #openstack-ironic | 03:43 | |
| *** spandhe has quit IRC | 03:47 | |
| *** naohirot has joined #openstack-ironic | 03:59 | |
| *** anderbubble has joined #openstack-ironic | 04:04 | |
| *** Masahiro has joined #openstack-ironic | 04:04 | |
| ramineni | jroll: hi | 04:15 |
| openstackgerrit | jiangfei proposed openstack/ironic: ironic-api vaild the input driver https://review.openstack.org/141703 | 04:18 |
| ramineni | yuriyz: hi , there? | 04:18 |
| *** Marga_ has joined #openstack-ironic | 04:42 | |
| *** achanda has joined #openstack-ironic | 04:47 | |
| *** masco has joined #openstack-ironic | 04:48 | |
| *** chenglch|2 has joined #openstack-ironic | 05:02 | |
| *** chenglch has quit IRC | 05:04 | |
| *** achanda has quit IRC | 05:08 | |
| *** achanda has joined #openstack-ironic | 05:09 | |
| *** achanda has quit IRC | 05:11 | |
| *** achanda has joined #openstack-ironic | 05:12 | |
| *** pensu has joined #openstack-ironic | 05:15 | |
| *** achanda has quit IRC | 05:16 | |
| *** Nisha has quit IRC | 05:16 | |
| *** achanda has joined #openstack-ironic | 05:16 | |
| *** Nisha has joined #openstack-ironic | 05:17 | |
| *** achanda has quit IRC | 05:18 | |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic-specs: Update after initial review chagnes https://review.openstack.org/139517 | 05:31 |
| *** anderbubble has quit IRC | 05:32 | |
| *** anderbubble has joined #openstack-ironic | 05:39 | |
| *** anderbubble has quit IRC | 05:40 | |
| *** anderbubble has joined #openstack-ironic | 05:47 | |
| *** Nisha_away has joined #openstack-ironic | 06:26 | |
| *** Masahiro_ has joined #openstack-ironic | 06:26 | |
| *** cppforlife has quit IRC | 06:26 | |
| *** Nisha has quit IRC | 06:28 | |
| *** Masahiro has quit IRC | 06:28 | |
| *** cppforlife has joined #openstack-ironic | 06:28 | |
| *** anderbubble has quit IRC | 06:29 | |
| *** lazy_prince has quit IRC | 06:29 | |
| *** lazy_prince has joined #openstack-ironic | 06:30 | |
| *** anderbubble has joined #openstack-ironic | 06:32 | |
| openstackgerrit | jiangfei proposed openstack/ironic: ironic-api vaild the input driver https://review.openstack.org/141703 | 06:33 |
| *** anderbubble has quit IRC | 06:49 | |
| *** Nisha_away has quit IRC | 06:49 | |
| *** Haomeng|2 has joined #openstack-ironic | 06:51 | |
| *** Haomeng has quit IRC | 06:52 | |
| *** Marga_ has quit IRC | 07:06 | |
| cuihaozhi | finally deploy bm with pxe_ipmi driver successed :DD, but i think some step missed on install-guide, may i report a BUG? | 07:08 |
| Haomeng|2 | cuihaozhi: sure, welcome | 07:09 |
| Haomeng|2 | cuihaozhi: congts:) | 07:09 |
| Haomeng|2 | cuihaozhi: the install-guide can not cover more details such as networking configurations I think | 07:10 |
| cuihaozhi | Haomeng|2: thanks for help :) | 07:10 |
| Haomeng|2 | cuihaozhi: yw, anytime:) | 07:10 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic-specs: Update after initial review chagnes https://review.openstack.org/139517 | 07:11 |
| jiangfei | Haomeng: hi | 07:18 |
| jiangfei | Haomeng: please taka a look at review : https://review.openstack.org/#/c/141703/ | 07:22 |
| Haomeng|2 | jiangfei: y | 07:23 |
| Haomeng|2 | jiangfei: yes, I am review, great work | 07:24 |
| Haomeng|2 | jiangfei: thank you | 07:24 |
| jiangfei | Haomeng: thks | 07:24 |
| Haomeng|2 | jiangfei: but not sure if conductor database table change can be accepted by other reviewers:) | 07:25 |
| Haomeng|2 | jiangfei: can we get idea that does not change existing data model? | 07:25 |
| openstackgerrit | Michael Davies proposed openstack/ironic: Add logical name support to Ironic https://review.openstack.org/141737 | 07:26 |
| mrda | devananda: ^^^ First version of the logical names implementation (thought I'd let you know as I won't be in the team meeting this week because 3:30am :) | 07:27 |
| jiangfei | Haomeng: hmmm, i can't find the reserved field to use . so i changed | 07:27 |
| mrda | Also note: much more system testing needed before it can be considered mergeable. | 07:28 |
| Haomeng|2 | jiangfei: ok, np, looking for more review comments, and we can discuss the better way | 07:28 |
| jiangfei | Haomeng: ok. i have one question about CI | 07:29 |
| jiangfei | Haomeng: check-tripleo-ironic-undercloud-precise-nonha is failed, and i found ERROR: The template version is invalid: Template version was not provided when heat stack-create -e /opt/stack/new//undercloud-env.json -t 360 -f /opt/stack/new//tripleo-heat-templates/undercloud-vm-ironic.yaml undercloud. What is the relationship between heat and ironic is that? | 07:31 |
| Haomeng|2 | jiangfei: heat will call nova, and nova call ironic | 07:33 |
| Haomeng|2 | jiangfei: so what is your concern here? | 07:33 |
| *** Nisha has joined #openstack-ironic | 07:33 | |
| jiangfei | Haomeng: no , i just have no idea about CI failed | 07:34 |
| *** mrda is now known as mrda-away | 07:34 | |
| Haomeng|2 | jiangfei: yes, some ci failed case depends on other components patch | 07:43 |
| jiangfei | Haomeng: ok, I'm looking at heat of the error log. thks | 07:45 |
| Haomeng|2 | jiangfei: left some comments with your new patch - https://review.openstack.org/#/c/141703/2 , but dont worry, and you can wait more comments and commit new patch to cover more guys comments together. | 07:47 |
| jiangfei | Haomeng: OK, thank you very much. :) | 07:48 |
| Haomeng|2 | jiangfei: yw, thanks for the patch:) | 07:48 |
| *** yuriyz has quit IRC | 07:50 | |
| *** yuriyz has joined #openstack-ironic | 07:55 | |
| *** Nisha has quit IRC | 08:18 | |
| *** Nisha has joined #openstack-ironic | 08:22 | |
| *** k4n0 has joined #openstack-ironic | 08:25 | |
| *** dlpartain has joined #openstack-ironic | 08:29 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Discover node properties using new CLI node-inspect https://review.openstack.org/100951 | 08:29 |
| *** dlpartain has quit IRC | 08:30 | |
| *** jcoufal has joined #openstack-ironic | 08:31 | |
| GheRivero | morning all | 08:36 |
| openstackgerrit | sandhya proposed openstack/ironic-specs: Chassis Level Node Discovery https://review.openstack.org/134866 | 08:38 |
| Nisha | morning GheRivero | 08:39 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic-specs: Update after review chagnes https://review.openstack.org/139517 | 08:40 |
| openstackgerrit | sandhya proposed openstack/ironic-specs: Chassis Level Node Discovery https://review.openstack.org/134866 | 08:42 |
| openstackgerrit | sandhya proposed openstack/ironic-specs: Chassis Level Node Discovery https://review.openstack.org/134866 | 08:43 |
| *** bauzer is now known as bauzas | 08:45 | |
| *** romcheg has joined #openstack-ironic | 08:49 | |
| *** romcheg has left #openstack-ironic | 08:52 | |
| *** ndipanov has joined #openstack-ironic | 08:54 | |
| *** romcheg has joined #openstack-ironic | 08:55 | |
| *** zyluo has quit IRC | 08:57 | |
| *** subscope has joined #openstack-ironic | 09:00 | |
| *** athomas has joined #openstack-ironic | 09:05 | |
| *** andreykurilin has joined #openstack-ironic | 09:13 | |
| *** derekh has joined #openstack-ironic | 09:17 | |
| dtantsur | Morning! | 09:35 |
| Nisha | dtantsur, Morning | 09:36 |
| dtantsur | Nisha, o/ | 09:37 |
| Nisha | dtantsur, could you review the discovery spec | 09:37 |
| dtantsur | doing right now | 09:38 |
| Nisha | ok thanks | 09:38 |
| Nisha | dtantsur, let me know if any comments...will address right away | 09:39 |
| *** MattMan has joined #openstack-ironic | 09:41 | |
| dtantsur | Nisha, left come comments, nothing critical | 09:44 |
| Nisha | dtantsur, MANAGED shouldnt be in the scope of introspection, correct? i am just clarifying | 09:47 |
| dtantsur | Nisha, probably. So IIRC the target state for inspection should be INSPECTED and then _something_ moves node to MANAGED... | 09:48 |
| Nisha | yes | 09:48 |
| dtantsur | but I'm not pretty sure I understand the latest state machine well | 09:48 |
| dtantsur | :) | 09:48 |
| Nisha | dtantsur, i also understand it that way only | 09:48 |
| Nisha | :) | 09:48 |
| *** pelix has joined #openstack-ironic | 09:50 | |
| Nisha | dtantsur, does this look to you fine " The default value for same shall be 1800 secs as | 09:54 |
| Nisha | required by in-band implementations." | 09:54 |
| dtantsur | Nisha, yeah, good | 09:54 |
| *** andreykurilin has quit IRC | 09:55 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Discover node properties using new CLI node-inspect https://review.openstack.org/100951 | 09:55 |
| Nisha | dtantsur, ^^^^^ | 09:55 |
| dtantsur | good, will look in a couple of minutes | 09:55 |
| Nisha | should i remove the other properties from the spec? | 09:56 |
| Nisha | dtantsur, it is just the refernece driver implementation | 09:56 |
| dtantsur | Nisha, I didn't notice you have them, but IMO this spec should touch only the basic properties | 09:57 |
| dtantsur | otherwise we'll keep arguing forever :) | 09:57 |
| Nisha | I dont have them explicitly | 09:57 |
| *** athomas has quit IRC | 09:57 | |
| Nisha | dtantsur, i added this in patchset 58 : "* The reference implementation will be done for iLO drivers. The | 09:58 |
| Nisha | driver can introspect the hardware and get more properties | 09:58 |
| Nisha | apart from above discussed properties. These properties will be just | 09:58 |
| Nisha | updated in the node.properties as capabilities. | 09:58 |
| Nisha | " | 09:58 |
| Nisha | the first line was there | 09:58 |
| Nisha | i added rest three lines in patchset 58 | 09:58 |
| dtantsur | Nisha, I would move it to ILO spec or to a separate generic spec. | 09:58 |
| Nisha | ok so u say it shud be a seperate ilo spec | 09:59 |
| Nisha | ? | 09:59 |
| Nisha | then the dependent ilo spec can do this? | 09:59 |
| Nisha | dtantsur, the only point why i added in this is hardware capabilities are bunped to L...and introspecting hardware to get the properties requires no other action apart from what we do here for basic properties | 10:01 |
| dtantsur | Nisha, it should be either something generic (which honestly has little chances to fit into K) or just an addition for your existing ILO spec | 10:01 |
| Nisha | if the dependent spec can go in K, i already have it in that...i am fine with that | 10:01 |
| Nisha | ok i will remove this line | 10:02 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Discover node properties using new CLI node-inspect https://review.openstack.org/100951 | 10:03 |
| Nisha | dtantsur, ^^^^ removed the above line | 10:03 |
| dtantsur | ack | 10:03 |
| *** athomas has joined #openstack-ironic | 10:04 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Discover node properties for iLO drivers https://review.openstack.org/103007 | 10:10 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Discover node properties for iLO drivers https://review.openstack.org/103007 | 10:13 |
| Nisha | dtantsur, ^^^^ | 10:13 |
| Nisha | dtantsur, updated the ilo spec also | 10:14 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Automate UEFI-BIOS Iso Creation https://review.openstack.org/134022 | 10:28 |
| *** Nisha has quit IRC | 10:34 | |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Improve Agent deploy driver validation https://review.openstack.org/141766 | 10:42 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Improve Agent deploy driver validation https://review.openstack.org/141766 | 10:49 |
| ramineni | Yuriyz: hi | 10:51 |
| yuriyz | hi ramineni | 10:51 |
| ramineni | yuriyz, i have seen you have added agent element in DIB only supported on fedora right? | 10:52 |
| ramineni | yuriyz , i want to understand , what is the dependency on fedora , or is it only testing effort to test on other platforms like ubuntu | 10:53 |
| *** lucasagomes has joined #openstack-ironic | 10:54 | |
| lucasagomes | :) morning ironic | 10:54 |
| ramineni | yuriyz, basically want to use IPA on other ramdisks as well, so want to understand the denpedency | 10:55 |
| ramineni | lucasagomes, morning :) | 10:56 |
| yuriyz | ramineni it uses systemd. But it works on Fedora good if systemd does not start agent (run via rc.local), there is a problem with this, more need more work | 10:56 |
| sambetts | morning lucasagomes | 10:56 |
| lucasagomes | sambetts, ramineni yo :) | 10:56 |
| * lucasagomes is back from holidays, catching up with everything | 10:57 | |
| yuriyz | I plan to fix DIB patch on this week | 10:57 |
| yuriyz | morning Ironic lucasagomes | 10:57 |
| lucasagomes | yuriyz, hi there | 10:58 |
| ramineni | yuriyz, ok thanks .. will look into it | 10:58 |
| *** ramineni has quit IRC | 11:02 | |
| *** Masahiro_ has quit IRC | 11:17 | |
| *** pensu has quit IRC | 11:23 | |
| sambetts | lucasagomes, every one of my functions in a class extending base.PowerInterface creates a new client object for talking to my bmc, would it make sense to create that in an __init__ or would that potentially affect functionality of the interface? | 11:28 |
| lucasagomes | sambetts, I would just create it in the __init__ | 11:30 |
| lucasagomes | sambetts, I don't see how it would impact the functionality | 11:31 |
| lucasagomes | sambetts, tho if username/password changes you may need to get a new instance (idk how the code looks like) | 11:31 |
| lucasagomes | if so I would create a _get_client() helper function to deal with those random changes | 11:32 |
| dtantsur | lucasagomes, o/ how was your holiday? | 11:37 |
| lucasagomes | dtantsur, yo! pretty good man. I was needing a break from everything | 11:38 |
| dtantsur | heh sure | 11:38 |
| lucasagomes | dtantsur, trying to catch up with emails/code reviews now | 11:38 |
| lucasagomes | dtantsur, and it's pretty hot over here, I wasn't used to it anymore | 11:38 |
| lucasagomes | 29C+ | 11:38 |
| dtantsur | 29 sounds sweet to me :) | 11:38 |
| lucasagomes | dtantsur, yeah it's not bad | 11:49 |
| lucasagomes | but it's still morning | 11:49 |
| lucasagomes | def going up in the afternoon | 11:50 |
| dtantsur | ouch | 11:50 |
| lucasagomes | dtantsur, it's all good :D I need some vitamin d | 11:54 |
| lucasagomes | and a tan as well :D | 11:54 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Simple functional testing for discoverd and the reference ramdisk https://review.openstack.org/141777 | 12:02 |
| dtantsur | lucasagomes, wanna review some crazyness ^^^ ? :) | 12:03 |
| lucasagomes | dtantsur, will do, just finishing up some stuff | 12:04 |
| * lucasagomes loads to catch up :( | 12:04 | |
| dtantsur | oh yeah, take your time | 12:04 |
| *** afaranha has quit IRC | 12:09 | |
| *** jiangfei has quit IRC | 12:09 | |
| *** jiangfei has joined #openstack-ironic | 12:10 | |
| *** Masahiro has joined #openstack-ironic | 12:18 | |
| *** Masahiro has quit IRC | 12:23 | |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/141507 | 12:27 |
| *** masco has quit IRC | 12:34 | |
| *** EmilienM is now known as EmilienM|afk | 12:37 | |
| openstackgerrit | Merged openstack/ironic: Remove Python 2.6 from setup.cfg https://review.openstack.org/141074 | 12:52 |
| *** afaranha_ has joined #openstack-ironic | 12:59 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: DO NOT MERGE https://review.openstack.org/141786 | 12:59 |
| *** afaranha has joined #openstack-ironic | 13:00 | |
| *** afaranha_ has quit IRC | 13:00 | |
| *** jcoufal_ has joined #openstack-ironic | 13:05 | |
| *** dprince has joined #openstack-ironic | 13:08 | |
| *** jcoufal has quit IRC | 13:08 | |
| openstackgerrit | Merged openstack/ironic: rename oslo.concurrency to oslo_concurrency https://review.openstack.org/139782 | 13:13 |
| *** EmilienM|afk is now known as EmilienM | 13:17 | |
| *** Masahiro has joined #openstack-ironic | 13:19 | |
| *** Masahiro has quit IRC | 13:24 | |
| *** jistr has joined #openstack-ironic | 13:28 | |
| *** jistr has quit IRC | 13:36 | |
| *** chenglch|2 has quit IRC | 13:56 | |
| *** masco has joined #openstack-ironic | 14:02 | |
| *** trown has joined #openstack-ironic | 14:10 | |
| *** mjturek has joined #openstack-ironic | 14:10 | |
| *** lazy_prince is now known as killer_prince | 14:11 | |
| *** killer_prince is now known as lazy_prince | 14:13 | |
| *** Nisha has joined #openstack-ironic | 14:16 | |
| *** Guest91362 is now known as annegentle | 14:33 | |
| *** achanda has joined #openstack-ironic | 14:42 | |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Improve Agent deploy driver validation https://review.openstack.org/141766 | 14:44 |
| NobodyCam | good morning Ironic | 14:45 |
| Shrews | NobodyCam: morning | 14:48 |
| GheRivero | morning all | 14:49 |
| lucasagomes | NobodyCam, Shrews GheRivero morning :) | 14:50 |
| Shrews | morning lucasagomes. welcome back | 14:52 |
| lucasagomes | Shrews, cheers :D | 14:52 |
| lucasagomes | it's good to be back | 14:52 |
| *** rloo has joined #openstack-ironic | 14:53 | |
| lucasagomes | it's good to be back | 14:54 |
| * lucasagomes feels his connection is a bit flaky | 14:54 | |
| NobodyCam | morning Shrews GheRivero lucasagomes :) | 14:55 |
| rloo | morning NobodyCam, Shrews, GheRivero, lucasagomes | 14:55 |
| NobodyCam | how was your time away lucasagomes ... did you habe a good time | 14:55 |
| NobodyCam | morning rloo :) | 14:55 |
| lucasagomes | NobodyCam, yeah very good man | 14:56 |
| lucasagomes | NobodyCam, I'm still in brazil I will go back to ireland on january | 14:56 |
| NobodyCam | :) | 14:56 |
| lucasagomes | working from here for a while :) | 14:56 |
| NobodyCam | very nice :) | 14:56 |
| lucasagomes | yeah, I def needed a break of everything | 14:57 |
| NobodyCam | lucasagomes: http://paste.openstack.org/show/SY03EvpQ5Jkdi8JZmcV5 | 14:57 |
| lucasagomes | NobodyCam, AWESOME! | 14:58 |
| lucasagomes | Oh that's brillant | 14:58 |
| lucasagomes | hah | 14:58 |
| lucasagomes | I still need to upload the images somewhere | 14:58 |
| NobodyCam | lol | 14:58 |
| NobodyCam | its running in #ironic-bot channel | 14:58 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Simple functional testing for discoverd and the reference ramdisk https://review.openstack.org/141777 | 14:59 |
| lucasagomes | NobodyCam, awesome stuff | 15:04 |
| NobodyCam | lol still needs some work | 15:05 |
| NobodyCam | that was just hacking over the weekend | 15:05 |
| lucasagomes | NobodyCam, that's awesome, like really awesome! | 15:05 |
| NobodyCam | lol | 15:05 |
| *** rlr0329 has joined #openstack-ironic | 15:05 | |
| lucasagomes | NobodyCam, we could even use it to parse the whiteboard etherpad later and give the updates for example | 15:06 |
| NobodyCam | push up what I did over the weekend... which is not a lot | 15:06 |
| lucasagomes | PixieBoots update me | 15:06 |
| NobodyCam | oh ya | 15:06 |
| lucasagomes | NobodyCam, or even check launchpad for number of openbugs | 15:07 |
| lucasagomes | etc... | 15:07 |
| lucasagomes | loads of things to do :D | 15:07 |
| NobodyCam | lucasagomes: https://github.com/NoBodyCam/PixieBootsIrcBot | 15:09 |
| NobodyCam | bot is all python | 15:10 |
| lucasagomes | NobodyCam, nice one! I will check that out later on | 15:10 |
| lucasagomes | NobodyCam, dtantsur btw, I replied to the reviews on the root device hint specs | 15:10 |
| lucasagomes | if you guys have a time please check that out | 15:10 |
| NobodyCam | ack | 15:10 |
| *** lucasagomes is now known as lucas-hungry | 15:13 | |
| rlr0329 | I think I am getting close but I am still missing something simple when trying to boot up a baremetal node using ipmi. The nova boot command launches an instance on a compute node instead of booting up a new baremetal node. Here is the command I am using: nova boot --flavor baremetal --image $SOURCE_IMAGE_UUID --key-name default newnode | 15:21 |
| NobodyCam | rlr0329: what is you computedriver in the nova conf file? | 15:22 |
| rlr0329 | compute_driver = libvirt.LibvirtDriver. So do I need to change it to compute_driver=nova.virt.ironic.IronicDriver? Can a nova api service only support 1 driver? | 15:25 |
| NobodyCam | rlr0329: yes | 15:26 |
| BadCub_ | Morning Ironic!!! | 15:26 |
| NobodyCam | morning BadCub_ | 15:26 |
| rlr0329 | NobodyCam: Will try that. Thanks! | 15:26 |
| *** dlpartain has joined #openstack-ironic | 15:28 | |
| NobodyCam | :) | 15:29 |
| jroll | morning everybody :) | 15:30 |
| jroll | welcome back lucas-hungry \o/ | 15:30 |
| NobodyCam | good morning jroll | 15:31 |
| NobodyCam | agenda looks a light today. | 15:32 |
| jroll | heya | 15:32 |
| NobodyCam | :) | 15:32 |
| jroll | I need some brainpower on https://review.openstack.org/#/c/139767/ | 15:32 |
| jroll | as it is now, it could cache a power off state very easily, and nova might end up powering off the box when the deploy ends :| | 15:33 |
| NobodyCam | jroll: in the power off ... the sate is still deploying isn't it? | 15:35 |
| jroll | mmm | 15:35 |
| *** lazy_prince is now known as killer_prince | 15:35 | |
| jroll | but that's not where it checks provision state, so provision state could be updated without updating power state | 15:36 |
| jroll | so it can go ACTIVE and still show "Shutdown" | 15:36 |
| jroll | in which case nova calls power_off() | 15:36 |
| NobodyCam | ahh | 15:36 |
| jroll | (more specifically the stop() compute api) | 15:36 |
| *** jerryz has quit IRC | 15:37 | |
| jroll | dunno, just looking for ideas | 15:37 |
| jroll | we really don't have a hook into this loop where we could refresh the cache | 15:37 |
| *** ndipanov has quit IRC | 15:47 | |
| *** mjturek has quit IRC | 15:48 | |
| *** rloo has quit IRC | 15:48 | |
| Nisha | hello, could i request review for introspection spec https://review.openstack.org/#/c/100951/ | 15:50 |
| *** rloo has joined #openstack-ironic | 15:50 | |
| *** ndipanov has joined #openstack-ironic | 15:54 | |
| NobodyCam | Nisha: will take a look in a few minutes | 15:57 |
| Nisha | Thanks NobodyCam | 15:58 |
| *** mjturek has joined #openstack-ironic | 15:59 | |
| *** mjturek has quit IRC | 16:00 | |
| *** mjturek has joined #openstack-ironic | 16:01 | |
| *** lucas-hungry is now known as lucasagomes | 16:01 | |
| lucasagomes | jroll, yo! thanks man! | 16:01 |
| jroll | :) | 16:02 |
| jroll | NobodyCam: thinking maybe just refresh that cache if it's older than 5 seconds or something silly | 16:02 |
| jroll | that way it should only happen for the first get_info() call | 16:02 |
| jroll | Nisha: "A node must be in MANAGED state before initiating inspection." | 16:07 |
| jroll | Nisha: so this code must wait for the new state machine code? | 16:08 |
| *** pcrews has joined #openstack-ironic | 16:10 | |
| NobodyCam | I just added a couple of items to the agenda | 16:15 |
| jroll | ++ | 16:16 |
| *** mjturek has quit IRC | 16:19 | |
| *** mjturek has joined #openstack-ironic | 16:20 | |
| *** pensu has joined #openstack-ironic | 16:22 | |
| devananda | morning, all | 16:22 |
| NobodyCam | good morning devananda :) | 16:23 |
| devananda | lucasagomes: hey there! welcome back :) | 16:23 |
| *** erwan_taf has quit IRC | 16:23 | |
| lucasagomes | devananda, good morning! | 16:23 |
| lucasagomes | thank you :) | 16:23 |
| BadCub_ | Morning Devananda | 16:23 |
| lucasagomes | it's good to be back | 16:23 |
| jroll | morning devananda | 16:24 |
| Shrews | morning devananda | 16:24 |
| *** athomas has quit IRC | 16:33 | |
| *** david-lyle_afk is now known as david-lyle | 16:34 | |
| *** achanda has quit IRC | 16:37 | |
| *** achanda has joined #openstack-ironic | 16:38 | |
| *** athomas has joined #openstack-ironic | 16:41 | |
| *** achanda has quit IRC | 16:42 | |
| *** achanda has joined #openstack-ironic | 16:42 | |
| lucasagomes | the meeting is in 15 minutes? | 16:46 |
| lucasagomes | or it's the alternate time today? | 16:46 |
| devananda | yes | 16:46 |
| *** masco has quit IRC | 16:46 | |
| devananda | 15 minutes | 16:46 |
| lucasagomes | right | 16:46 |
| lucasagomes | thanks | 16:47 |
| devananda | the openstack meeting calendar now includes all the new times | 16:47 |
| NobodyCam | :) | 16:47 |
| lucasagomes | oh nice one | 16:47 |
| sambetts | whats the situation in Ironic about vendor drivers and 3rd party CIs to test them? I notice there are any Ilo or Drac specfic CIs | 16:50 |
| *** dtantsur is now known as dtantsur|afk | 16:53 | |
| devananda | sambetts: https://wiki.openstack.org/wiki/Ironic/Drivers | 16:53 |
| devananda | sambetts: also http://stackalytics.com/report/driverlog?project_id=openstack%2Fironic&release=juno | 16:54 |
| jroll | devananda: how is that updated? I don't want to be the only maintainer :/ | 16:55 |
| devananda | jroll: a patch to the stackalytics repo | 16:56 |
| jroll | k | 16:56 |
| jroll | thanks | 16:56 |
| Nisha | jroll, Yes it need to wait for state spec code to get merged or the alternative is that i add the introspection related states in my implementation. It will just add the state as MANAGED, INSPECTING, etc | 16:56 |
| sambetts | devananda: thanks, so IBM has one for impinative, but I guess there is no requirement for the 3rd parties to run their own CIs as the other don't have one? Just wondering if that need to be consideration for the Cisco driver or not | 16:56 |
| *** Masahiro has joined #openstack-ironic | 16:56 | |
| jroll | Nisha: ok, thanks | 16:57 |
| jroll | sambetts: it's the right thing to do, it's also a huge PITA to dedicate real hardware | 16:57 |
| devananda | sambetts: I would strongly encourage you to set up third-party CI | 16:57 |
| jroll | (is how I see it) | 16:57 |
| Nisha | what is the meeting room today | 16:57 |
| JayF | #openstack-meeting-3 | 16:58 |
| Nisha | ok | 16:58 |
| jroll | https://wiki.openstack.org/wiki/Meetings/Ironic | 16:58 |
| jroll | always has correct info | 16:58 |
| sambetts | devananda: ok, that gives me something to report back on, thank you :-) | 16:58 |
| devananda | sambetts: we aren't enforcing a strict rule around it right now. in part, we haven't had any major problems yet in the way that other projects have. and in part, we have community-contributed drivers that will never reasonably have automated CI (like the iboot driver) | 16:58 |
| Nisha | jroll, so which one do you prefer? | 16:58 |
| Nisha | introspection could add the related fields | 16:58 |
| jroll | Nisha: I'd prefer waiting for MANAGED, was just asking :) | 16:58 |
| devananda | sambetts: np | 16:58 |
| *** k4n0 has quit IRC | 16:59 | |
| Nisha | and do its implementation | 16:59 |
| Nisha | ? | 16:59 |
| Nisha | ok | 16:59 |
| jroll | devananda: speaking of community drivers, we still haven't seen the mindstorm driver >:( | 16:59 |
| * devananda shuffles papers and heads over to the meeting room | 16:59 | |
| devananda | jroll: i know :( | 16:59 |
| * NobodyCam heads over to the meeting room | 16:59 | |
| sambetts | jroll, devananda: wasn't it cloudbase that were working on that? | 17:00 |
| jroll | yep | 17:00 |
| *** Guest59984 has joined #openstack-ironic | 17:00 | |
| devananda | http://www.cloudbase.it/rebot/ | 17:00 |
| sambetts | so cool :-P those guys also had a bunch of 3D printed stuff at their booth in Paris | 17:01 |
| *** Masahiro has quit IRC | 17:01 | |
| *** shakamunyi has quit IRC | 17:03 | |
| *** MattMan1 has joined #openstack-ironic | 17:04 | |
| MattMan1 | Hi, just wondering is there a plan for a ironic 2014.2.1 release ? | 17:05 |
| NobodyCam | MattMan1: we're in meeting just now. | 17:05 |
| MattMan1 | Apologies | 17:06 |
| *** ndipanov has quit IRC | 17:07 | |
| NobodyCam | no no nothing to apologie for | 17:08 |
| devananda | dtantsur|afk: hi! if you're around -- weekly meeting in progress | 17:09 |
| NobodyCam | dtantsur|afk: are you able to join the meeting | 17:09 |
| devananda | MattMan1: none that I'm aware of off-hand, but I will follow up after this meeting. adam_g - any thoughts? | 17:09 |
| adam_g | there hasn't been any patches there | 17:10 |
| adam_g | the only thing merged to those branches is requirements updates | 17:10 |
| adam_g | so it hasn't warranted any release. if there are critical bugs that should be fixed in 2014.2, please escalate them and make us aware | 17:10 |
| MattMan1 | Nothing to escalate on my side, was just wondering that's all. Thanks | 17:11 |
| *** dlpartain has quit IRC | 17:11 | |
| *** pensu has quit IRC | 17:17 | |
| afaranha | devananda, Hey, I still trying to deploy Ironic, but I'm having some issues. Now I have 3 services that isn't running | 17:18 |
| afaranha | I sent an email to the list explaining the situation better | 17:18 |
| *** Guest59984 has quit IRC | 17:19 | |
| *** ndipanov has joined #openstack-ironic | 17:20 | |
| *** dlaube has joined #openstack-ironic | 17:31 | |
| *** pensu has joined #openstack-ironic | 17:32 | |
| *** jcoufal_ has quit IRC | 17:43 | |
| *** achanda has quit IRC | 17:45 | |
| *** achanda has joined #openstack-ironic | 17:45 | |
| *** achanda has quit IRC | 17:47 | |
| *** achanda has joined #openstack-ironic | 17:47 | |
| NobodyCam | dtantsur|afk: can you make a bug review day thursday? | 17:48 |
| *** rodrigods has joined #openstack-ironic | 18:00 | |
| jroll | so | 18:01 |
| jroll | other than ramdisk size | 18:01 |
| jroll | is there any benefit to using DIB for the agent driver? | 18:01 |
| lucasagomes | I believe people would like to use other image types rather than coreos images for the ramdisk | 18:01 |
| *** marcoemorais has joined #openstack-ironic | 18:02 | |
| JayF | lucasagomes: I think that's a bad reason to change it, TBH | 18:02 |
| NobodyCam | as of right now the dib element only supports fedora/RH | 18:02 |
| *** marcoemorais has quit IRC | 18:02 | |
| lucasagomes | JayF, right, but not my call | 18:02 |
| lucasagomes | like red hat would like to have a fedora/rhel image for it | 18:02 |
| *** marcoemorais has joined #openstack-ironic | 18:02 | |
| JayF | jroll: I'm wondering if image streaming + another round of shrinking could get the CoreOS iamge working in 512MB :) | 18:02 |
| adam_g | ive got multi-host ironic devstack working now, we may be able to use that to do non-parallel testing if we cant slim it down | 18:03 |
| jroll | JayF: it wouldn't even boot | 18:03 |
| NobodyCam | brb | 18:03 |
| jroll | lucasagomes: sigh, why, it literally makes no difference | 18:03 |
| JayF | jroll: I know :) That doesn't mean it couldn't be fixed though :) | 18:03 |
| * devananda jumps on a call, back in 90 min | 18:03 | |
| lucasagomes | jroll, I know... I can check it internally | 18:03 |
| jroll | JayF: right (glhf?) :P | 18:03 |
| lucasagomes | jroll, but we usually use our own stuff... productization and stuff | 18:03 |
| JayF | jroll: priorities, priorities :) | 18:03 |
| *** derekh has quit IRC | 18:04 | |
| sambetts | I'm heading off for the evening, night ironic | 18:04 |
| jroll | lucasagomes: right :/ | 18:04 |
| jroll | night sam | 18:04 |
| sambetts | night jroll | 18:04 |
| JayF | lucasagomes: didn't fedora announce a coreos-like new spin just like the new ubuntu light one? | 18:04 |
| devananda | g'night, sambetts | 18:04 |
| jroll | I mean, all you need is a system with systemd-nspawn | 18:05 |
| jroll | which fedora presumably has | 18:05 |
| lucasagomes | JayF, not sure, I will check. I was outside tech world for more than 1 week :D | 18:05 |
| lucasagomes | didn't follow any news whatsoever | 18:05 |
| jroll | you could easily tweak the builder to use fedora, I would think | 18:05 |
| JayF | jroll: remember cloud-config.yml is a coreos-specific thing | 18:05 |
| jroll | assuming there's a fedora pxe image you could crack open | 18:05 |
| JayF | jroll: so not quite so easy | 18:05 |
| jroll | mmm, true | 18:05 |
| lucasagomes | jroll, yeah and the fact that fedora/rhel now runs systemd | 18:05 |
| lucasagomes | I believe it may facilitate a bit | 18:05 |
| jroll | right | 18:05 |
| *** Nisha has quit IRC | 18:06 | |
| lucasagomes | but what I mean also is that, dib makes it easier to customize the image the way you want | 18:06 |
| jroll | lucasagomes: the DIB thing works, it just needs to be optimized, I'd suggest pursuing that | 18:06 |
| lucasagomes | like having ubuntu/fedora/suse elements etc | 18:06 |
| jroll | right | 18:06 |
| lucasagomes | and if we hard depend on a specific distro it may not be that dib-ish | 18:06 |
| JayF | lucasagomes: jroll: Check out the Dockerfile in IPA; you probably just need to purge a bunch of build-deps when it's done to make it smaller | 18:06 |
| lucasagomes | I understand the concerns, and I even agree | 18:06 |
| *** subscope has quit IRC | 18:07 | |
| jroll | JayF: right | 18:07 |
| lucasagomes | JayF, ah nice | 18:07 |
| JayF | when jroll said we spent weeks making that ramdisk smaller | 18:07 |
| lucasagomes | JayF, it does use the fedora cloud image as base? | 18:07 |
| JayF | most of those weeks were mine ;) | 18:07 |
| JayF | lol | 18:07 |
| lucasagomes | or normal fedora ? | 18:07 |
| JayF | lucasagomes: You mean DIB? Or the CoreOS builder thing? | 18:08 |
| lucasagomes | I mean desktop version* | 18:08 |
| jroll | JayF: I specifically said you :P | 18:08 |
| lucasagomes | JayF, the coreOs builder | 18:08 |
| JayF | lucasagomes: the CoreOS builder uses ubuntu trusty docker image (slimmed down ubuntu image) as a base | 18:08 |
| JayF | lucasagomes: for a container which is embedded inside the coreos | 18:08 |
| JayF | lucasagomes: trivially that could be changed to support Fedora instaed | 18:08 |
| lucasagomes | right | 18:08 |
| JayF | lucasagomes: https://github.com/openstack/ironic-python-agent/blob/master/Dockerfile | 18:08 |
| * lucasagomes clicks | 18:09 | |
| JayF | lucasagomes: I think #24-#30 are what need to be added to the DIB, or something lik eit | 18:09 |
| *** rustlebee is now known as russellb | 18:09 | |
| naohirot | I'm going to sleep until the noon. :-) see you all | 18:12 |
| *** naohirot has quit IRC | 18:12 | |
| NobodyCam | have good night naohirot | 18:13 |
| NobodyCam | have a * | 18:13 |
| dlaube | g'morning ironic | 18:13 |
| lucasagomes | JayF, right yeah... I hope I will find some time to play with it | 18:14 |
| lucasagomes | I know they do some stuff to slim down the cloud image for example using iptables instead of firewalld | 18:14 |
| NobodyCam | morning dlaube | 18:14 |
| lucasagomes | removing all docs | 18:14 |
| lucasagomes | etc etc | 18:15 |
| lucasagomes | dlaube, morning | 18:15 |
| *** MattMan1 has quit IRC | 18:15 | |
| *** Marga_ has joined #openstack-ironic | 18:21 | |
| *** harlowja has joined #openstack-ironic | 18:33 | |
| anteaya | adam_g: so in terms of what you just signed up for | 18:33 |
| anteaya | adam_g: it is helpful for starters to at least be able to find and share urls for third party information | 18:33 |
| anteaya | adam_g: first stop: http://ci.openstack.org/third_party.html | 18:34 |
| anteaya | linked from above: https://wiki.openstack.org/wiki/ThirdPartySystems | 18:34 |
| anteaya | reading the above information would be wonderful too | 18:35 |
| adam_g | anteaya, thanks. i'll take a look. im not involved in any third party testing myself but happy to lend a hand to any third parties trying to tie into ironic's CI | 18:35 |
| anteaya | thank you | 18:35 |
| anteaya | that is the role | 18:36 |
| anteaya | guiding hand that sort of thing | 18:36 |
| anteaya | also person able to share ironic perspective on things like the dashboard spec | 18:36 |
| anteaya | since it is hoping for cross-project buy in | 18:36 |
| NobodyCam | brb | 18:41 |
| *** andreykurilin_ has joined #openstack-ironic | 18:43 | |
| *** Masahiro has joined #openstack-ironic | 18:45 | |
| rlr0329 | Sorry to keep asking basic questions here but don't know where else to go as I can seem to find the answers in the docs. The nova boot command is now selecting the correct baremetal node but it is failing because the node isn't show as having enough available resources. | 18:50 |
| rlr0329 | nova.compute.resource_tracker reports the following: Total physical ram (MB): 0, total allocated virtual ram (MB): 0, Total physical disk (GB): 0, total allocated virtual disk (GB): 0, Free VCPU information unavailable. Question is, how does the available resources get updated if the node hasn't booted yet? | 18:50 |
| *** Masahiro has quit IRC | 18:50 | |
| NobodyCam | rlr0329: please keep asking :) | 18:53 |
| NobodyCam | rlr0329: take a look at step #3 of http://docs.openstack.org/developer/ironic/deploy/install-guide.html#flavor-creation | 18:53 |
| *** dprince has quit IRC | 18:57 | |
| rlr0329 | NobodyCam: I can do that. :) I've done that, i.e. created the flavor,etc. How does the basemetal node available resources get updated? For example, the available resources for physical ram 0 and I can't set the flavor to 0 | 18:58 |
| *** andreykurilin_ has quit IRC | 19:02 | |
| *** andreykurilin_ has joined #openstack-ironic | 19:03 | |
| *** marcoemorais has quit IRC | 19:04 | |
| *** marcoemorais has joined #openstack-ironic | 19:05 | |
| NobodyCam | gah I swear we had an example of creating a node | 19:07 |
| NobodyCam | rlr0329: one sec... searching | 19:07 |
| adam_g | rlr0329, the nova driver polls ironic for available node resources, based on the properties associated with that node in ironic (ram, memory, cpu) | 19:07 |
| adam_g | rlr0329, ironic wont expose the new node's resources to nova until it's synced its power state. if resources aren't showing up in nova, make sure ironic has at least set each node's power_state | 19:09 |
| rlr0329 | adam_g: so do I manually set whatever properties specified by the flavor in the ironic node properties? The power state is sync'd and I can control the power state using ironic | 19:11 |
| adam_g | rlr0329, you set the properties on the ironic side to reflect what the node provides, nova's scheduler will filter out nodes that can satisfy requirements described by the flavor | 19:12 |
| NobodyCam | rlr0329: have you added the properites to the node? ie (ironic node-create -d pxe_ipmitool -i pxe_deploy_kernel=<glance_uuid_of_pxe_deploy_kernel> -i pxe_deploy_ramdisk=<glance_uuid_of_deploy_ramdisk> -p cpus=<number_of_cpus> -p memory_mb=<memory_size_in_MB> -p local_gb=<local_disk_size_in_GB> -p cpu_arch=<cpu_arch>) | 19:12 |
| rlr0329 | Ahh. That makes more sense now. I did not set the cpus, memory, or local_gb in the ironic node properties. I didn't see that in the doc | 19:15 |
| NobodyCam | devananda: didn't you have a patch that added a good create node example to our docs? I swaer I remember reviewing it | 19:15 |
| rlr0329 | adam_g/NobodyCam: Will give that a go. Thanks! | 19:15 |
| NobodyCam | :) | 19:15 |
| devananda | NobodyCam: I did .. what happened to that? | 19:15 |
| NobodyCam | rlr0329: just note that it can take a full minute for nova to see the ironic resources | 19:16 |
| devananda | NobodyCam: oh. you reviewed it and I didn't update .. https://review.openstack.org/#/c/136202/ | 19:16 |
| NobodyCam | lol ahh ha | 19:17 |
| *** Marga_ has quit IRC | 19:17 | |
| NobodyCam | there it is | 19:17 |
| devananda | sometimes I wish we'd just land a big patch like this even with one or two typos | 19:17 |
| devananda | then file a smaller patch to fix the typo | 19:17 |
| NobodyCam | I'm not nuts | 19:17 |
| NobodyCam | lol my comment says I'm good with a follow up patch fix | 19:17 |
| rlr0329 | NobodyCam: duly noted :-) | 19:18 |
| adam_g | rlr0329, you should be able to update them in place, ie ironic node-update a8c61627-8c32-4ead-b4c2-07ad79dc89a9 add properties/memory_mb=512 (for memory_mb, cpu_arch, local_gb, cpus) | 19:19 |
| NobodyCam | rlr0329: also take a look at the patch devananda pointed out above for better examples | 19:20 |
| rlr0329 | got it. Thanks!! | 19:21 |
| adam_g | has anyone else been getting spammed /w 'oslo.messaging._drivers.impl_rabbit [-] Timed out waiting for RPC response: timed out from (pid=16191)' in the conductor log? | 19:25 |
| jroll | o.o | 19:27 |
| jroll | yes | 19:27 |
| rlr0329 | adam_g: Yes, I am in my setup | 19:27 |
| adam_g | hmm | 19:27 |
| jroll | I thought that was our environment | 19:27 |
| devananda | adam_g: yes. can't stand it .. | 19:27 |
| jroll | interesting | 19:27 |
| devananda | I think that coincided with the new release of oslo.messaging, but i haven't dug into it yet | 19:28 |
| adam_g | is there a bug? ill file one | 19:28 |
| devananda | adam_g: not afaik. thx | 19:28 |
| * devananda finishes with meetings, gets back to code and stuff | 19:28 | |
| *** pensu has quit IRC | 19:28 | |
| *** marcoemorais has quit IRC | 19:29 | |
| rlr0329 | adam_g: remember seeing a bug for that | 19:29 |
| *** marcoemorais has joined #openstack-ironic | 19:29 | |
| NobodyCam | devananda: if you don't mind I patch up 136202 for you? | 19:31 |
| devananda | NobodyCam: ty | 19:32 |
| rlr0329 | adam_g: here is the bug #: https://bugs.launchpad.net/designate/+bug/1399257 | 19:32 |
| adam_g | rlr0329, oh nice, thanks! | 19:33 |
| *** rloo has quit IRC | 19:33 | |
| *** rloo has joined #openstack-ironic | 19:34 | |
| * devananda hits also-affects | 19:34 | |
| devananda | marking low since there's neglible impact, aside from annoyance | 19:35 |
| devananda | GheRivero: looks like ^ will need another release of oslo.messaging | 19:36 |
| devananda | *means we will need | 19:36 |
| *** david-lyle is now known as david-lyle_lunch | 19:39 | |
| GheRivero | devananda: yeah. That's the second time we broke because of oslo.messaging. | 19:40 |
| devananda | GheRivero: this isn't much of a "break" at least :) | 19:41 |
| devananda | just annoying log messages | 19:41 |
| GheRivero | also, I have to review oslo.config and oslo.policy patches and land them to and sync every oslo library | 19:42 |
| GheRivero | lucasagomes: romcheg: ^^ | 19:42 |
| devananda | GheRivero: trying to do that before kilo-1? | 19:42 |
| GheRivero | I want to | 19:43 |
| lucasagomes | GheRivero, yeah, I gotta take a look at the oslo.config I saw that you put another patch up | 19:43 |
| JayF | GheRivero: this is something relevant generally to your interests if you'd like to review it --> https://review.openstack.org/#/c/138116/ | 19:43 |
| devananda | GheRivero: ok - could you open a tracking bug for that and target to kilo-1, so that it is reflected on the milestone page? | 19:43 |
| devananda | GheRivero: then close the bug when that work is done | 19:43 |
| GheRivero | devananda: sure | 19:44 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Add new enrollment and troubleshooting doc sections https://review.openstack.org/136202 | 19:44 |
| GheRivero | JayF: thanks. It's already on my radar, but was giving priority to the config and policy patches. They are more disruptive | 19:44 |
| NobodyCam | all needed doc patch ^^^^^ | 19:45 |
| *** eghobo has joined #openstack-ironic | 19:45 | |
| *** rwsu has joined #openstack-ironic | 19:45 | |
| JayF | GheRivero: I was just hoping to get that out b/c I put some patches in to fix the rebase. Would rather it not get outta date again :) | 19:45 |
| devananda | adam_g: there was a question earlier (not sure if you saw / replied) asking whether we're going to release a 2014.2.1 | 19:46 |
| devananda | adam_g: I haven't been tracking or targeting backports specifically -- but I think you have? | 19:46 |
| adam_g | devananda, yeah--i pointed out that we had no bugs or patches targeted for backporting, so there was no need to do a point release | 19:46 |
| adam_g | only things merged were auto global requirements patches | 19:47 |
| devananda | k k | 19:47 |
| *** Marga_ has joined #openstack-ironic | 19:48 | |
| rloo | NobodyCam: misspelled 'trimed' in https://review.openstack.org/#/c/136202/4/doc/source/deploy/install-guide.rst | 19:50 |
| rloo | NobodyCam: what about putting a line with something like '| ... | ...|' where the <snip> was | 19:50 |
| NobodyCam | d'oh | 19:50 |
| NobodyCam | rloo: ahh that would look better will add now | 19:50 |
| devananda | adam_g: skimming fix-committed bugs, this one looks like it probably affects juno. not sure it warrants a backport so I'm posing that as a question -- https://review.openstack.org/#/c/125972/ | 19:51 |
| rloo | NobodyCam: thx. Cuz I was also going to mention that '... for space requirements' is a bit odd. There are no space REQuirements? | 19:52 |
| devananda | ditto for https://bugs.launchpad.net/ironic/+bug/1355375 <-- jroll | 19:52 |
| *** Marga_ has quit IRC | 19:53 | |
| *** david-lyle_lunch is now known as david-lyle | 19:53 | |
| NobodyCam | rloo: how about trimmed for space? | 19:53 |
| *** david-lyle is now known as david-lyle_t | 19:53 | |
| *** david-lyle_t is now known as david-lyle | 19:53 | |
| adam_g | devananda, those both look like they fit within the stable branch policies | 19:53 |
| rloo | NobodyCam: if you put the |...|.. instead of the snip, I don't think it needs the trimmed... text | 19:54 |
| devananda | adam_g: ack. so no one has, afaik, asked for either to be backported, but it might be nice of us to do that | 19:54 |
| NobodyCam | ok.. let me push that up | 19:54 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Add new enrollment and troubleshooting doc sections https://review.openstack.org/136202 | 19:55 |
| adam_g | devananda, sure. if you want to propose them i can take a look when i get back. | 19:55 |
| adam_g | im being kicked out of jury duty for a 1hr45min lunch break | 19:56 |
| rloo | NobodyCam: all that to say that I can't think of good wording right now, for that ;) | 19:56 |
| devananda | adam_g: mmm, lunch | 19:56 |
| devananda | adam_g: also, how is it you're here if you're on jury duty? | 19:56 |
| adam_g | im in the waiting area where they pick jurors from. they have wireless, laptops are allowed | 19:57 |
| devananda | ah | 19:57 |
| adam_g | they even have work desks and board games | 19:57 |
| NobodyCam | rloo: output redacted for easier reading | 19:57 |
| NobodyCam | :-p | 19:57 |
| rloo | NobodyCam: that's better! | 19:57 |
| NobodyCam | rloo: take a look at that last version and I can add the redacted line if you think its still needed | 19:58 |
| rloo | NobodyCam: no, the redacted line isn't needed. Did you check the rendered page? You might be missing a '|' | 19:59 |
| NobodyCam | thou redacted makes me think of some CIA guy with a black marker | 20:00 |
| NobodyCam | lol no I didn't ... checks now | 20:00 |
| rloo | NobodyCam: i think I was wrong wrt the |. | 20:00 |
| rloo | NobodyCam: I +2'd. My excuse was the rendered page hadn't rendered yet. But I think it'll be right ;) | 20:01 |
| NobodyCam | I do get a couple of warrning localy let me fix them real quick | 20:01 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Add new enrollment and troubleshooting doc sections https://review.openstack.org/136202 | 20:03 |
| NobodyCam | rloo: warrnings fixed | 20:04 |
| *** subscope has joined #openstack-ironic | 20:05 | |
| rloo | thx NobodyCam | 20:05 |
| *** kevinbenton has joined #openstack-ironic | 20:07 | |
| *** subscope has quit IRC | 20:09 | |
| *** dprince has joined #openstack-ironic | 20:13 | |
| lucasagomes | I will call it a day folks | 20:19 |
| lucasagomes | have a great night | 20:19 |
| *** lucasagomes is now known as lucas-dinner | 20:19 | |
| NobodyCam | have a good night lucas-dinner | 20:20 |
| rloo | night lucas-dinner | 20:20 |
| *** penick has joined #openstack-ironic | 20:24 | |
| Shrews | devananda: Hi! Had a chance to see my comment re: NOSTATE on this yet? https://review.openstack.org/#/c/139216/8/ironic/conductor/manager.py | 20:28 |
| Shrews | hoping you can unconfuse me (which is a large task, i know) | 20:28 |
| *** erwan_taf has joined #openstack-ironic | 20:28 | |
| NobodyCam | devananda: a assume your about to push up a new 139215 as the comments are morked done :) | 20:29 |
| *** marios has quit IRC | 20:30 | |
| *** kylestev has quit IRC | 20:30 | |
| *** cinerama has quit IRC | 20:30 | |
| devananda | yup | 20:30 |
| devananda | just posted | 20:30 |
| devananda | about to push a new patch series | 20:30 |
| *** marios has joined #openstack-ironic | 20:31 | |
| *** kylestev has joined #openstack-ironic | 20:31 | |
| *** cinerama has joined #openstack-ironic | 20:31 | |
| NobodyCam | :) | 20:31 |
| *** Masahiro has joined #openstack-ironic | 20:34 | |
| *** erwan_taf has quit IRC | 20:34 | |
| *** romcheg has quit IRC | 20:35 | |
| Shrews | devananda: thx | 20:36 |
| *** mrda-away is now known as mrda | 20:37 | |
| mrda | Morning Ironic | 20:37 |
| devananda | mmm, rebase conflict | 20:37 |
| NobodyCam | morning mrda | 20:37 |
| mrda | \o | 20:38 |
| devananda | jroll: where'd agent _set_failed_state go? | 20:38 |
| *** Masahiro has quit IRC | 20:39 | |
| devananda | ooh. vdrok removed it. k k | 20:39 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Refactor async helper methods in conductor/manager.py https://review.openstack.org/139217 | 20:45 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Begin using the state machine for node deploy/teardown https://review.openstack.org/139216 | 20:45 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Convert drivers to use process_event() https://review.openstack.org/140883 | 20:45 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Enable async callbacks from task.process_event() https://review.openstack.org/140868 | 20:45 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Convert check_deploy_timeout to use process_event https://review.openstack.org/140869 | 20:45 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add base state machine https://review.openstack.org/139215 | 20:45 |
| NobodyCam | woo | 20:45 |
| *** marcoemorais has quit IRC | 20:45 | |
| NobodyCam | no 139215? | 20:46 |
| devananda | hm. didn't mean to change the branch name | 20:46 |
| *** marcoemorais has joined #openstack-ironic | 20:46 | |
| NobodyCam | oh there it is | 20:46 |
| devananda | NobodyCam: no, it's there. just didn't post to IRC for some reason | 20:46 |
| NobodyCam | :-p | 20:46 |
| Shrews | it did. it's just last | 20:47 |
| NobodyCam | ya just saw that | 20:47 |
| NobodyCam | :-p | 20:47 |
| devananda | ah | 20:47 |
| * devananda is also blind | 20:47 | |
| * NobodyCam jumps in the boat with devananda :) | 20:47 | |
| * rloo hopes NobodyCam didn't land in the water | 20:48 | |
| NobodyCam | lol | 20:48 |
| NobodyCam | :) | 20:48 |
| *** Marga_ has joined #openstack-ironic | 20:48 | |
| clif_h | I'm seeing something with ironicclient that seems odd to me. I'm getting a 401 unauthorized response from keystone, which is fine by itself, but instead of throwing an 'Unauthorized' exception, ironicclient throws a very low-level 'AttributeError' exception instead | 20:48 |
| clif_h | in particular it throws the AttributeError from this line: https://github.com/openstack/python-ironicclient/blob/master/ironicclient/openstack/common/apiclient/exceptions.py#L447 | 20:50 |
| clif_h | so response.text is absent, but should be there since the content_type starts with "text/" | 20:51 |
| JoshNang | clif_h: got a traceback? | 20:52 |
| NobodyCam | clif_h: that may be a bug | 20:52 |
| clif_h | https://gist.github.com/ClifHouck/dd7ea92bff4862d6567e | 20:52 |
| clif_h | I'm testing a change I'm making to the nova ironic driver to try to cache the ironicclient instead of creating a new one for every call | 20:53 |
| clif_h | I haven't mucked with the actual client in any way | 20:53 |
| *** Marga_ has quit IRC | 20:53 | |
| devananda | clif_h: I believe mrda did some work on that. you may want to share ideas | 20:53 |
| devananda | clif_h: also, that is definitely a bug. what version of the client are you using? | 20:54 |
| clif_h | from pip list: python-ironicclient (0.3.2) | 20:54 |
| clif_h | I'm testing on devstack | 20:55 |
| *** dprince has quit IRC | 20:55 | |
| devananda | clif_h: can you install 0.3.1 and test that? | 20:55 |
| mrda | devananda: thanks, I have already promised clif_h I'd take a look. | 20:55 |
| devananda | clif_h: asking because I haven't seen this before and knowing if the release we did last week is related will help narrow down a cause | 20:55 |
| mrda | clif_h: I will today, sorry for the delay | 20:56 |
| devananda | mrda: :) | 20:56 |
| clif_h | mrda: it's ok, the current review doesn't reflect all the changes I've made | 20:56 |
| clif_h | I can install 0.3.1 if you think that will make a difference | 20:56 |
| *** Ng has quit IRC | 21:00 | |
| *** david-ly_ has joined #openstack-ironic | 21:00 | |
| *** lifeless has quit IRC | 21:02 | |
| *** gingerjiang has quit IRC | 21:02 | |
| *** vipul has quit IRC | 21:02 | |
| *** ekarlso- has quit IRC | 21:02 | |
| *** david-lyle has quit IRC | 21:02 | |
| *** yjiang5 has joined #openstack-ironic | 21:02 | |
| *** lifeless has joined #openstack-ironic | 21:04 | |
| devananda | Haomeng|2: ping | 21:08 |
| jroll | clif_h: "ironicclient throws a very low-level 'AttributeError' exception instead" that's because the response body is empty | 21:08 |
| jroll | devananda: on https://bugs.launchpad.net/ironic/+bug/1355375 | 21:09 |
| jroll | devananda: I don't really expect that to *need* to be backported, but I guess it can't hurt | 21:09 |
| clif_h | jroll: right, I get that, but it doesn't seem like its actually empty | 21:09 |
| clif_h | at least not in the logs | 21:09 |
| JayF | there's no concept of backporting an IPA patch | 21:09 |
| JayF | because we have no concept of an IPA release | 21:09 |
| jroll | oh | 21:09 |
| jroll | right | 21:09 |
| jroll | devananda: IPA doesn't have a juno release, no backport necessary :) | 21:09 |
| JayF | (which we may desire to change in Kilo, but idk) | 21:09 |
| *** vipul has joined #openstack-ironic | 21:10 | |
| clif_h | if you look at the HTTP response listed in https://gist.github.com/ClifHouck/dd7ea92bff4862d6567e | 21:10 |
| clif_h | It seems that the body of the response is 'Authentication required' | 21:10 |
| jroll | oh, huh | 21:10 |
| jroll | interesting | 21:11 |
| devananda | jroll: oh right | 21:11 |
| devananda | jroll: though I mean in the driver, not in IPA | 21:11 |
| clif_h | I'm not sure what's going on with the response object | 21:12 |
| clif_h | why isn't that getting set in response.text | 21:12 |
| devananda | jroll: but yea, no one's asked for that backport yet, so ... | 21:12 |
| clif_h | jroll: I could be misinterpreting the log | 21:13 |
| jroll | devananda: that fix doesn't touch the driver | 21:13 |
| clif_h | but it seems like the log does print the response body of an http response | 21:13 |
| devananda | jroll: ah! never mind then | 21:13 |
| jroll | clif_h: right :/ | 21:13 |
| devananda | jroll: ya'll need a different bug tracker? | 21:14 |
| jroll | devananda: dunno, been fine so far, you were the one that suggested sharing :) | 21:14 |
| devananda | cool. i'm just being obtuse then :) | 21:14 |
| devananda | oh hey, random question | 21:14 |
| jroll | random.answer() | 21:15 |
| NobodyCam | 42 | 21:15 |
| *** ekarlso- has joined #openstack-ironic | 21:15 | |
| * JayF suspects our random module has been hax'd by rats | 21:15 | |
| devananda | what if setting a node to 'maintenance mode' removed any network info from Neutron | 21:15 |
| jroll | nooooooooooooo | 21:15 |
| jroll | clif_h: anyway, I'd say that exception is a client bug | 21:15 |
| devananda | that'd probably break you guys | 21:15 |
| JayF | ==jroll | 21:15 |
| devananda | yea ... | 21:15 |
| jroll | that would break the world tbh | 21:16 |
| jroll | for example, we have ports in neutron for the decom vlan | 21:16 |
| *** romcheg has joined #openstack-ironic | 21:16 | |
| devananda | you decom a node that's in maintenance mode? | 21:16 |
| jroll | why would you want to clear network info? | 21:16 |
| jroll | decom vlan == everything not tenant | 21:16 |
| jroll | sorry, I should say provisioning vlan | 21:17 |
| JayF | devananda: downstream we do; yes; but that's not relevant to jroll's conversation :) | 21:17 |
| jroll | internal words | 21:17 |
| devananda | JayF: actually it might be. if booting into IPA is explicitly something you need to do on a node that's in 'maintenance' -- yep, relevant | 21:17 |
| clif_h | jroll: should I file a bug? | 21:17 |
| jroll | clif_h: sure! | 21:17 |
| JayF | devananda: also this is a workflow: maintenance a server; ssh to running agent to see how the hardware is broken; fix hardware; use agent running while still in maint to verify fix; unmaint | 21:17 |
| devananda | JayF: do you need to reboot back into the agent while still in maintenance? | 21:18 |
| JayF | devananda: yes | 21:18 |
| devananda | I would imagine "yes" | 21:18 |
| JayF | devananda: many time | 21:18 |
| devananda | k | 21:18 |
| JayF | *many times | 21:18 |
| devananda | so, if i remember the context of my own note (hah!) it is for an external mgmt system | 21:18 |
| devananda | that uses its own PXE env | 21:18 |
| devananda | rather than the one ironic uses | 21:18 |
| jroll | ah | 21:19 |
| *** Ng has joined #openstack-ironic | 21:19 | |
| devananda | and wants a way to temporarily disable all the pxeboot stuff that ironic/neutron manage | 21:19 |
| jroll | to do inventory or something? | 21:19 |
| devananda | or something | 21:19 |
| jroll | right | 21:19 |
| JayF | devananda: I'd think you maint in ironic then do a thing in neutron if you had that use case | 21:19 |
| devananda | JayF: right. where "a thing" is "stop answering dhcp requests" | 21:19 |
| jroll | that's what we would do, anyway | 21:19 |
| jroll | "remove these ports" | 21:20 |
| NobodyCam | would it be worth having a understanding of a maintance mode network | 21:20 |
| JayF | until/unless we offer a better way to say "tenants don't belong on this node" maintenance can't do much more than it already does | 21:20 |
| jroll | or whatever | 21:20 |
| jroll | yeah | 21:20 |
| devananda | jroll: exactly. hence my opening question :) | 21:20 |
| JayF | bceause it's the big hammer for "don't provision on this machine" | 21:20 |
| jroll | we don't do the neutron dhcp thing so it's harder to reason about | 21:20 |
| devananda | jroll: yup. and I want to not break folks who dont use neutron | 21:20 |
| devananda | but for folks who do, this seems quite reasonable to me | 21:20 |
| devananda | "make neutron stop answering requests for MAC xxxx" | 21:21 |
| JayF | devananda: I disagree, actually | 21:21 |
| devananda | i'm just not sure how that relates to maintenance mode | 21:21 |
| JayF | devananda: even for people using neutron, I think we should enable people to boot agents on maintenanced boxes | 21:21 |
| jroll | JayF: that's different | 21:21 |
| devananda | JayF: well, right. see my last comment :) | 21:21 |
| JayF | devananda: mainly to permit folks (like us) who use the agent to help with fleet management out of band of ironic | 21:21 |
| jroll | this is booting something outside of ironic | 21:21 |
| devananda | I think these are orthogonl | 21:21 |
| jroll | not an agent | 21:21 |
| *** Marga_ has joined #openstack-ironic | 21:21 | |
| JayF | Would jroll's pxe-pxe driver fix this use case? | 21:22 |
| jroll | "make ironic stop managing dhcp" is the actual behavior we're looking at | 21:22 |
| devananda | "hey ironic, boot this node into a rescue env" | 21:22 |
| jroll | :o | 21:22 |
| jroll | yes | 21:22 |
| jroll | maybe | 21:22 |
| JayF | i.e. if Ironic would just pxe boot an instance into a random thing on request? | 21:22 |
| devananda | "hey openstack, stop managing this node for a while, while $otherthing manages it" | 21:22 |
| jroll | devananda: wait, does "nova rescue" solve that? | 21:22 |
| jroll | oh, no | 21:22 |
| JayF | devananda: that second line sounds like "ironic node-delete" | 21:22 |
| jroll | JayF: I like where you're going | 21:22 |
| devananda | yea. different | 21:22 |
| JayF | devananda: followed by a recreate when they're done | 21:22 |
| devananda | JayF: it sort of does, yup | 21:22 |
| JayF | we've used that pattern here | 21:22 |
| jroll | pxepxe++ | 21:23 |
| JayF | delete a node then readd it later when it's ready to be readded | 21:23 |
| * JayF won't comment on whether or not ironic node-delete got confused with ironic node-set-provision-state deleted to cause that node to get deleted | 21:23 | |
| JayF | but it's a pattern that is OK | 21:23 |
| jroll | lol | 21:23 |
| devananda | heh | 21:23 |
| devananda | JayF: at least, node-delete should error if there's an instance on it | 21:23 |
| devananda | JayF: so you won't accidentally do /that/ | 21:24 |
| JayF | if someone was trying to set provision-state deleted on a node with an instance_uuid | 21:24 |
| JayF | they screwed up already ;) | 21:24 |
| *** Marga_ has quit IRC | 21:26 | |
| Shrews | So, I know it's bad form to vote on a review you are listed as co-author on, but I want to see 139215 merged this week, so I only put a +1 on it. | 21:27 |
| Shrews | plus my contribution was very minor :-P | 21:27 |
| NobodyCam | Shrews: I always agree to a +1 to show that you agree with the current set of changes | 21:28 |
| * NobodyCam does the same | 21:28 | |
| devananda | Nobodycam, Shrews: not +2'ing that means we essentially need 5 cores to vote on it | 21:30 |
| NobodyCam | devananda: we can get the J*'s to review it | 21:31 |
| jroll | oh lawd | 21:31 |
| devananda | when just doing a fix-up patch for someone, and not a significant amount of the work, I think co-authors should +2 | 21:31 |
| jroll | I need to do some things | 21:32 |
| Shrews | devananda: I'm willing to +2 if you're ok with that. | 21:32 |
| jroll | but can review later today | 21:32 |
| devananda | Shrews: yup | 21:32 |
| Shrews | devananda: done | 21:33 |
| NobodyCam | oh devananda I just found: http://robhirschfeld.com/2014/12/09/openstack-ironic-crowbar ... interesting read | 21:36 |
| devananda | NobodyCam: yup. | 21:39 |
| devananda | I like the pictures :) | 21:39 |
| *** eghobo has quit IRC | 21:39 | |
| Shrews | Oh, if anyone wants to play around with a docker-based ironic test environment, feel free to give dockstack a try over the holidays: https://github.com/Shrews/dockstack | 21:40 |
| Shrews | It doesn't yet integrate nova/neutron/glance. I need to build the configs for that, but ironic does run with the fake driver. | 21:40 |
| devananda | Shrews: you see http://lists.openstack.org/pipermail/openstack-dev/2014-December/052708.html ? | 21:40 |
| jroll | ^ is p cool | 21:41 |
| Shrews | devananda: i did. iirc, it was solving a larger problem for *production* scale stuff | 21:41 |
| dlaube | hey guys, so after I deploy a node and it gets installed I see some failed attempts being made to the metadata service. more specifically, I'm getting "x-instance-id header is missing from request" even while running the ec2metadata util from the command line | 21:41 |
| * jroll wishes our public cloud infra ran on that | 21:41 | |
| devananda | Shrews: ah | 21:41 |
| dlaube | any idea how x-instance-id is injected into baremetal servers? or is there something else I can look at to see whats going on under the hood | 21:41 |
| devananda | Shrews, NobodyCam: how do ya'll want to land these patches? | 21:45 |
| Shrews | quickly and without abandon! | 21:45 |
| devananda | I know you've only reviewed the first two or three, but there is a bunch of important changes later on in the series as well | 21:45 |
| devananda | Shrews: with*out* abandon? :p | 21:45 |
| devananda | or with? | 21:46 |
| Shrews | whichever one means wrecklessly :) | 21:46 |
| NobodyCam | zull is way slow today | 21:46 |
| devananda | with | 21:46 |
| *** marcoemorais has quit IRC | 21:46 | |
| Shrews | devananda: i'm re-reviewing the 2nd in the chain now and have barely touched the 3rd. do you think we need to land them all in one go? | 21:47 |
| *** marcoemorais has joined #openstack-ironic | 21:47 | |
| devananda | no - these are set up in stages. however, if we *dont* land them as a group, the code will look odd | 21:47 |
| devananda | second patch starts using the new fsm, in just a few places | 21:48 |
| devananda | third patch is a big refactor of conductor/manager | 21:48 |
| devananda | but no functional changes | 21:48 |
| *** ryanpetrello has joined #openstack-ironic | 21:48 | |
| devananda | fourth patch uses the refactoring in the previous patch, and adds callbacks to task_manager, again just for the few places using it at this point | 21:49 |
| devananda | fifth and sixth patches start using this in more places | 21:49 |
| Shrews | devananda: does it make sense sub-group them? like, should we work on trying to land the first 3 (or whatever) back-to-back? then focus on the ones after? | 21:49 |
| devananda | basically ... review up to at least the 4th patch | 21:49 |
| devananda | otherwise you won't see what i'm really doing | 21:50 |
| devananda | 1-4, 5-6 | 21:50 |
| devananda | 4-6 is where you can see the effect this has on drivers | 21:50 |
| *** openstackgerrit has quit IRC | 21:50 | |
| *** penick has quit IRC | 21:50 | |
| devananda | 1-3 is really just prep work | 21:50 |
| *** openstackgerrit has joined #openstack-ironic | 21:51 | |
| devananda | meanwhile I need to get lunch | 21:52 |
| devananda | bbiaf | 21:52 |
| Shrews | ok. let me focus on getting 1-4 reviewed by tomorrow then | 21:52 |
| NobodyCam | :) | 21:52 |
| NobodyCam | Shrews: ++ | 21:52 |
| Shrews | then maybe i'll have a better sense for how to land this | 21:52 |
| NobodyCam | enjoy lunch devananda | 21:52 |
| devananda | Shrews: it may seem backwards, but actually, you might try starting from 6 | 21:52 |
| devananda | they are much smaller at the end :) | 21:52 |
| devananda | and if the usage looks terrible in 6 or 5, then it means 1-3 need to be changed | 21:53 |
| Shrews | i think my OCD would prevent me from doing that :) | 21:53 |
| Shrews | but i'll give that a try | 21:53 |
| *** penick has joined #openstack-ironic | 21:54 | |
| *** Marga_ has joined #openstack-ironic | 21:57 | |
| * Shrews has a crockpot full of chili going in the kitchen and the smell is driving him insane... so hard to concentrate | 21:57 | |
| *** pelix has quit IRC | 22:08 | |
| *** david-ly_ is now known as david-lyle | 22:11 | |
| devananda | NobodyCam: you fixing the doc patch? if not, I will | 22:12 |
| NobodyCam | devananda: I did | 22:13 |
| NobodyCam | rloo: +2'd | 22:13 |
| devananda | NobodyCam: Shrews has some new comments | 22:13 |
| NobodyCam | oh :-p | 22:13 |
| * NobodyCam looks | 22:13 | |
| *** marcoemorais has quit IRC | 22:14 | |
| *** marcoemorais has joined #openstack-ironic | 22:15 | |
| NobodyCam | devananda: I can fix... Just finishing up some food atm... | 22:15 |
| *** ryanpetrello has quit IRC | 22:15 | |
| devananda | ack | 22:15 |
| *** ryanpetrello_ has joined #openstack-ironic | 22:16 | |
| *** ryanpetrello_ is now known as ryanpetrello | 22:16 | |
| Shrews | devananda: for 139217, looks like you did more than just move _do_node_deploy(). I see there is a change to where you set conductor affinity | 22:19 |
| Shrews | intentional? | 22:19 |
| devananda | Shrews: just moved the function | 22:20 |
| Shrews | moved from the try to the else | 22:20 |
| devananda | line # ? | 22:20 |
| Shrews | 1369 | 22:20 |
| Shrews | vs. 705 in the old file | 22:20 |
| devananda | ah | 22:21 |
| devananda | yes | 22:21 |
| devananda | that *shouldn't* have any functional effect, but it is cleaner to be explicit | 22:21 |
| devananda | actually | 22:21 |
| devananda | task.process_event() could raise an exception -- though it shouldn't here | 22:22 |
| devananda | so updating the node.conductor_affinity in a code block separated from where that would be .save()'d | 22:22 |
| devananda | is not as easy to reason about as doing it in the same code block | 22:22 |
| *** Masahiro has joined #openstack-ironic | 22:23 | |
| * devananda hopes his rambling helped | 22:23 | |
| Shrews | just trying to think of the implications... you're right. should be functionally the same. i think we should point out this change in the commit message, though. | 22:24 |
| Shrews | but that's sort of a pain due | 22:25 |
| Shrews | to the other reviews | 22:25 |
| * Shrews makes a nit | 22:25 | |
| devananda | I can update that easily enough | 22:25 |
| Shrews | eh, wait until others review. i'll leave a comment | 22:26 |
| devananda | k | 22:26 |
| *** ChuckC has quit IRC | 22:26 | |
| *** Masahiro has quit IRC | 22:28 | |
| Shrews | hrm, a change in _do_node_tear_down() too | 22:29 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Add new enrollment and troubleshooting doc sections https://review.openstack.org/136202 | 22:33 |
| NobodyCam | Shrews: devananda: ^^^ | 22:35 |
| rloo | devananda, NobodyCam, Shrews: I +2'd 139215. but I don't see Jenkins. Should I approve it and see what happens? | 22:40 |
| Shrews | NobodyCam: lol. a mix of hardcoded list numbers and use of # in 136202? that seems... hackish :-P | 22:43 |
| NobodyCam | rloo: just finished up zull | 22:43 |
| NobodyCam | the .. ref is reseting the counter | 22:43 |
| Shrews | NobodyCam: hrm. do we need that ref? where is it used? | 22:44 |
| Shrews | oh, above it | 22:44 |
| rloo | NobodyCam: wrt 136202, can't you just move the .. _ComputeCapabilitiesFilter to the end of the section? | 22:44 |
| NobodyCam | let me try | 22:44 |
| Shrews | why aren't we just using href links? | 22:45 |
| *** eghobo has joined #openstack-ironic | 22:46 | |
| NobodyCam | that worked | 22:46 |
| * Shrews brb | 22:46 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Add new enrollment and troubleshooting doc sections https://review.openstack.org/136202 | 22:47 |
| NobodyCam | Shrews: rloo: ^^^ | 22:47 |
| NobodyCam | removed my hack | 22:47 |
| rloo | NobodyCam: thx! | 22:48 |
| *** Marga_ has quit IRC | 22:49 | |
| *** Marga_ has joined #openstack-ironic | 22:49 | |
| *** eghobo has quit IRC | 22:50 | |
| *** Marga_ has quit IRC | 22:50 | |
| *** Marga_ has joined #openstack-ironic | 22:50 | |
| Shrews | NobodyCam: +A'd | 22:52 |
| Shrews | Going to call it a night now. Will review states reviews 4-6 tomorrow. | 22:53 |
| NobodyCam | w00t :) thank you devananda :) | 22:53 |
| NobodyCam | Shrews: ack have a good night | 22:53 |
| NobodyCam | oh wow IRC cloud is working on "Pay with bitcoin" | 22:58 |
| *** ChuckC has joined #openstack-ironic | 22:59 | |
| *** achanda has quit IRC | 23:04 | |
| *** achanda has joined #openstack-ironic | 23:04 | |
| NobodyCam | rloo: are you loking over 139216 Shrews +2'd and I'm about to. should I hold off on the +a? | 23:08 |
| *** achanda has quit IRC | 23:09 | |
| rloo | NobodyCam: I wanted to, but I won't be able to get to it today. Go ahead and +a it; I'll still take a look tomorrow. | 23:09 |
| NobodyCam | rloo: Ack :) | 23:09 |
| rloo | we're doing our self-assessment stuff for the year. I have to copy/paste all the comments/reviews I did in ironic. | 23:09 |
| rloo | Just Joking! | 23:09 |
| jroll | hahahaha | 23:09 |
| NobodyCam | omg | 23:09 |
| NobodyCam | lol | 23:09 |
| jroll | you should have seen my jaw drop | 23:09 |
| * NobodyCam has that tomorrow | 23:09 | |
| rloo | ha ha ha | 23:10 |
| NobodyCam | devananda: are you adressing Shrews comments on 139217? | 23:13 |
| *** penick has quit IRC | 23:17 | |
| devananda | NobodyCam: addressing them, but not uploading a new patch | 23:17 |
| NobodyCam | ack.. the return think makes some sense | 23:18 |
| devananda | nope | 23:18 |
| NobodyCam | s/think/thing/ | 23:18 |
| NobodyCam | no ? | 23:18 |
| NobodyCam | oh | 23:18 |
| devananda | commented | 23:19 |
| * NobodyCam looks | 23:19 | |
| *** eghobo has joined #openstack-ironic | 23:23 | |
| *** andreykurilin_ has quit IRC | 23:27 | |
| *** penick has joined #openstack-ironic | 23:30 | |
| NobodyCam | devananda: line2 1511-1514 https://review.openstack.org/#/c/139217/8/ironic/conductor/manager.py kinda seem like log chatter to /me.. is there a reason its not at debug? | 23:34 |
| NobodyCam | s/line2/lines/ | 23:35 |
| devananda | NobodyCam: copied from old code | 23:36 |
| devananda | NobodyCam: that said, I agree. | 23:36 |
| NobodyCam | :) wants a comment on the review? | 23:36 |
| devananda | I mean, on the one hand, failing to manipulate the power state is an error that someone should care about | 23:37 |
| NobodyCam | that is logged at error right above | 23:37 |
| devananda | on the other hand, we expect a few failures now and then, and already retry for them, so we don't need to log *each* one | 23:37 |
| devananda | oh. yea. that's silly | 23:37 |
| NobodyCam | error is at 1507 | 23:37 |
| devananda | why LE and the LW a line below | 23:37 |
| devananda | NobodyCam: I don't think that's related to this patch at all -- but it's great if you want to clean that up in another patch | 23:38 |
| NobodyCam | ok :) | 23:38 |
| *** BadCub02 has joined #openstack-ironic | 23:43 | |
| *** marcoemorais1 has joined #openstack-ironic | 23:53 | |
| *** marcoemorais has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!