| NobodyCam | :( sorry | 00:00 |
|---|---|---|
| NobodyCam | utc time is now a new day | 00:00 |
| jroll | tis | 00:00 |
| jroll | FEATURE FREEZE EVERYBODY GO HOME | 00:00 |
| * Shrews IS home | 00:00 | |
| jroll | Shrews: 116772 is already in nova | 00:00 |
| * NobodyCam is home | 00:00 | |
| rloo | and mrda: I'll leave it to you to respond to Joe's suggestions in test_driver.py (see the end). we didn't do it cuz make-something-up | 00:00 |
| rloo | mrda: https://review.openstack.org/#/c/111425/19/nova/tests/virt/ironic/test_driver.py | 00:00 |
| jroll | s/HOME/THE LIQUOR CABINET/ | 00:01 |
| *** yuanying has quit IRC | 00:01 | |
| mrda | rloo: thanks | 00:01 |
| rloo | are you guys sure that this is feature freeze? | 00:01 |
| mrda | rloo: I've pinged him OOB, I'll see what he says | 00:01 |
| * Shrews IS in the liquor cabinet. wifi is much better here | 00:01 | |
| mrda | Just want to say, the Ironic team have been awesome this morning! | 00:01 |
| rloo | for J2, deva was the one that decided when to pull the switch. or cut the ribbon. | 00:02 |
| rloo | if 'awesome' == 'giddy' | 00:02 |
| NobodyCam | lol 118693 failed py26 | 00:02 |
| rloo | although for nova, the feature freeze date/time may apply. | 00:03 |
| NobodyCam | make a change to restart it | 00:03 |
| NobodyCam | :( oh wait the many hours | 00:03 |
| *** r-daneel has quit IRC | 00:03 | |
| NobodyCam | s/oh/or/ | 00:03 |
| jroll | rloo: I'm not sure | 00:03 |
| jroll | Shrews: I'm coming over to join you | 00:03 |
| *** r-daneel has joined #openstack-ironic | 00:04 | |
| jroll | mrda: I can't tell you how many thousand lines of code I've reviewed today | 00:04 |
| jroll | so tired | 00:04 |
| NobodyCam | oh wait: that may be a real error: FAIL: ironic.tests.test_pxe_utils.TestPXEUtils.test_clean_up_pxe_config_uefi | 00:04 |
| mrda | jroll: good job. For that you can have an early mark. | 00:04 |
| jroll | I can't | 00:04 |
| jroll | more to do | 00:04 |
| mrda | Oh | 00:04 |
| jroll | NobodyCam: lovely | 00:05 |
| jroll | why the f | 00:05 |
| jroll | oh, never mind | 00:05 |
| jroll | but like, how did that fail | 00:05 |
| jroll | uefi test | 00:06 |
| Shrews | unlink_mock.assert_called_once_with('/tftpboot/0A0A0001.conf') | 00:06 |
| *** yuanying_ has joined #openstack-ironic | 00:06 | |
| Shrews | failed | 00:06 |
| Shrews | *sob* | 00:06 |
| jroll | well, I see *that* | 00:06 |
| jroll | but... | 00:07 |
| jroll | that patch passed tests a few hours ago | 00:07 |
| jroll | ogod | 00:07 |
| jroll | please tell me they aren't actually touching disk | 00:07 |
| *** datajerk has joined #openstack-ironic | 00:07 | |
| Shrews | AND a docs failure | 00:10 |
| Shrews | yay | 00:10 |
| Shrews | wth? | 00:10 |
| jroll | how what | 00:11 |
| *** scubacuda has quit IRC | 00:11 | |
| mrda | BTW, Joe is happy with the log levels remaining as is, with a bug raised. So I'll do that today. | 00:11 |
| mrda | rloo: ^^^ | 00:11 |
| *** slagle_ has joined #openstack-ironic | 00:11 | |
| *** ekarlso- has joined #openstack-ironic | 00:11 | |
| *** devananda has joined #openstack-ironic | 00:11 | |
| rloo | mrda: yay! | 00:12 |
| *** ifarkas_ has joined #openstack-ironic | 00:12 | |
| *** ekarlso has quit IRC | 00:12 | |
| *** dhellmann_ has quit IRC | 00:12 | |
| *** datajerk1 has quit IRC | 00:12 | |
| *** devanand1 has quit IRC | 00:12 | |
| *** ifarkas has quit IRC | 00:12 | |
| *** slagle has quit IRC | 00:12 | |
| *** eguz has joined #openstack-ironic | 00:12 | |
| kylestev | welcome back devananda | 00:12 |
| *** eguz has quit IRC | 00:12 | |
| jroll | ... maybe | 00:12 |
| *** dhellmann has joined #openstack-ironic | 00:12 | |
| NobodyCam | mrda: cool! | 00:13 |
| NobodyCam | looks like modem is working again ... brb | 00:13 |
| jroll | mrda: nice | 00:13 |
| NobodyCam | w00t real bandwidth | 00:14 |
| jroll | huh, I don't understand why py26 would have failed there | 00:15 |
| kylestev | NobodyCam: yay! | 00:15 |
| *** eghobo has quit IRC | 00:16 | |
| Shrews | jroll: py27 succeeded. transient? | 00:16 |
| Shrews | won't know until we can see the full logs | 00:16 |
| jroll | ... maybe | 00:16 |
| jroll | must be | 00:16 |
| jroll | I mean | 00:17 |
| jroll | it passed tests hours ago | 00:17 |
| lifeless | Shrews: full log is available now | 00:17 |
| Shrews | lifeless: where? | 00:17 |
| lifeless | jenkins | 00:18 |
| Shrews | i can see console, yes. | 00:18 |
| lifeless | and/or logs. | 00:18 |
| lifeless | they get copied up immediately | 00:18 |
| jroll | ok, does anyone need me to do anything? | 00:18 |
| jroll | (for the next hour) | 00:18 |
| jroll | or can I head home and resume | 00:19 |
| jroll | NobodyCam: ^^ | 00:19 |
| jroll | mrda ^ | 00:19 |
| lifeless | give me some nice things | 00:19 |
| * jroll gives lifeless a shiny thing | 00:19 | |
| lifeless | oh siny | 00:19 |
| jroll | I'm trying to give you an ilo driver | 00:19 |
| jroll | that's nice, right? | 00:19 |
| * NobodyCam now runs to get dinner | 00:19 | |
| Shrews | lifeless: well, that's awesome. unfortunately, i don't know how to access those until after the run :( | 00:19 |
| jroll | just need jenkins to let it through to you | 00:19 |
| lifeless | jroll: iloone :) | 00:19 |
| mrda | jroll: go home :) | 00:19 |
| jroll | lifeless: whassat | 00:19 |
| lifeless | Shrews: ah, so whats the review # | 00:19 |
| mrda | you've earned it! | 00:19 |
| NobodyCam | bbiah | 00:19 |
| Shrews | lifeless: 118693 | 00:20 |
| lifeless | Shrews: so you start here http://logs.openstack.org/93/118693/ | 00:20 |
| lifeless | Shrews: the last two digits are a load shedder | 00:20 |
| lifeless | Shrews: following my nose I get http://logs.openstack.org/93/118693/3/check/gate-ironic-python26/d4f0d85/ | 00:21 |
| lifeless | Shrews: does that look like what you want ? | 00:21 |
| Shrews | load shedder? | 00:21 |
| Shrews | lifeless: but yes | 00:21 |
| lifeless | spreads the load across directories | 00:21 |
| lifeless | bit bogus on ext4 | 00:22 |
| lifeless | but hey folk still do it :) | 00:22 |
| Shrews | oh, 93 from the review # | 00:22 |
| Shrews | i get it now | 00:22 |
| Shrews | neat-o | 00:22 |
| Shrews | magic | 00:22 |
| Shrews | nothing useful uploaded yet, though | 00:23 |
| kylestev | Shrews: http://logs.openstack.org/93/118693/3/check/gate-ironic-python26/d4f0d85/console.html#_2014-09-03_23_09_29_296 | 00:24 |
| lifeless | Shrews: well this is a python 26 unittest | 00:24 |
| Shrews | kylestev: well, yeah. we can see that easily in the jenkins job. was hoping to see conductor logs, or something | 00:24 |
| lifeless | Shrews: you won't be getting other logs | 00:24 |
| kylestev | Shrews: ahhh | 00:24 |
| jroll | I mean | 00:25 |
| lifeless | Shrews: see the last 10 lines of http://logs.openstack.org/93/118693/3/check/gate-ironic-python26/d4f0d85/console.html | 00:25 |
| jroll | it's just unit tests | 00:25 |
| Shrews | or testr log, rather | 00:25 |
| jroll | there shouldn't be others | 00:25 |
| lifeless | jroll: as more jobs finish they will upload to sibling directories yes | 00:25 |
| jroll | right, but those won't explain py26 failures :P | 00:26 |
| Shrews | anyone have py26 so they can run the test locally? | 00:26 |
| lifeless | jroll: indeed | 00:26 |
| Shrews | jroll: GO HOME | 00:26 |
| mrda | jroll: GO HOME | 00:26 |
| jroll | SHHHHH | 00:26 |
| jroll | dude. | 00:26 |
| jroll | my sandal just broke | 00:26 |
| jroll | should have left 10 minutes ago | 00:26 |
| jroll | :((((((((( | 00:26 |
| jroll | someone send emergency duct tape | 00:27 |
| kylestev | jroll: if only aweeks was here | 00:27 |
| kylestev | you could use his superglue | 00:27 |
| jroll | ? | 00:27 |
| jroll | orly | 00:28 |
| * jroll wonders if it's in his desk | 00:28 | |
| mrda | duct tape | 00:28 |
| lifeless | hmm, new hash ring slow. sadness. | 00:28 |
| Shrews | jroll: you just rebased 118693 w/ master? | 00:29 |
| jroll | Shrews: I didn't rebase that at all | 00:30 |
| Shrews | oh, no. different review | 00:30 |
| Shrews | sorry | 00:30 |
| jroll | heh | 00:30 |
| mrda | I was going to say, "Go home jroll, you're drunk" | 00:30 |
| mrda | But I don't need to now | 00:30 |
| mrda | :-) | 00:30 |
| jroll | lolol | 00:31 |
| *** yuanying_ has quit IRC | 00:31 | |
| aweeks | kylestev: wait, what's this about superglue? | 00:36 |
| kylestev | aweeks: i have. ECHAN? | 00:37 |
| jroll | ok | 00:37 |
| jroll | see y'all in an hour ish :) | 00:37 |
| rloo | Shrews: fwiw, I have py26 and 118693 passes. but yeah, I modified 118693 from lucas, but didn't rebase. Maybe we should. I have to go. Might be back later. | 00:38 |
| Shrews | rloo: thx. likely something transient then. i suggest a recheck | 00:40 |
| Shrews | i don't see anything relevant in the e-r list | 00:41 |
| Shrews | LOG.warn("Shrews experiencing late night thunder storm") | 00:41 |
| mrda | Shrews: umm, -1 | 00:42 |
| mrda | Shrews: LOG.warn(_LW("Shrews experiencing late night thunder storm")) | 00:42 |
| Shrews | lol | 00:42 |
| *** r-daneel has quit IRC | 00:43 | |
| *** yuanying has joined #openstack-ironic | 00:44 | |
| *** yuanying_ has joined #openstack-ironic | 00:49 | |
| *** yuanying has quit IRC | 00:51 | |
| lifeless | adam_g: fixed | 00:52 |
| openstackgerrit | lifeless proposed a change to openstack/ironic: Run the whole test suite as one run https://review.openstack.org/118920 | 00:52 |
| openstackgerrit | lifeless proposed a change to openstack/ironic: Ignore backup files https://review.openstack.org/118922 | 00:52 |
| openstackgerrit | lifeless proposed a change to openstack/ironic: Fix hash ring stability https://review.openstack.org/118932 | 00:52 |
| lifeless | greghaynes: fix for the hash ring ^ | 00:52 |
| greghaynes | ooo | 00:53 |
| lifeless | greghaynes: I rather suspect your work is needed to land before it | 00:53 |
| lifeless | greghaynes: you may want to rebase it ontop of your stuff | 00:53 |
| lifeless | greghaynes: see the commit message for why | 00:53 |
| greghaynes | ok | 00:53 |
| greghaynes | yea | 00:53 |
| *** eghobo has joined #openstack-ironic | 00:54 | |
| *** eghobo has quit IRC | 00:55 | |
| lifeless | ok C gymnastics | 00:55 |
| *** eghobo has joined #openstack-ironic | 00:55 | |
| *** eghobo has quit IRC | 00:56 | |
| *** penick has quit IRC | 01:27 | |
| *** Hefeweizen has joined #openstack-ironic | 01:34 | |
| rloo | mrda: I'm a bit puzzled. https://review.openstack.org/#/c/111428/13..14/nova/virt/ironic/driver.py | 01:46 |
| rloo | mrda: the changes in version 14 are still there in the latest version (17). BUT I don't see those changes in the ironic tree, and I don't think they are right. | 01:47 |
| *** HenryG has quit IRC | 01:51 | |
| *** zer0c00l has quit IRC | 01:52 | |
| rloo | mrda: going to take off. will check later or touch base with you tomorrow about that driver file. Have a good day w/o us :-) | 01:54 |
| *** nosnos has joined #openstack-ironic | 01:54 | |
| *** rloo has quit IRC | 01:54 | |
| *** zer0c00l has joined #openstack-ironic | 01:55 | |
| mrda | thanks rloo | 01:58 |
| jroll | heyyyy | 02:26 |
| jroll | Shrews: the wifi is much better from the liquor cabinet, you're right :) | 02:26 |
| jroll | lifeless: nice work :) | 02:27 |
| jroll | mrda: anything I can help with? | 02:27 |
| *** yuanying_ has quit IRC | 02:28 | |
| *** yuanying has joined #openstack-ironic | 02:31 | |
| *** penick has joined #openstack-ironic | 02:32 | |
| mrda | jroll: I hope you went home | 02:35 |
| mrda | all is well | 02:35 |
| jroll | yes, I'm home :P | 02:36 |
| *** HenryG has joined #openstack-ironic | 02:40 | |
| lifeless | jroll: thanks; everynow and then I get to write codes | 02:48 |
| jroll | lifeless: I know that feeling, probably not as well as you do :P | 02:49 |
| jroll | (that said, I haven't really reviewed the change, just saw it exists) | 02:49 |
| *** penick has quit IRC | 02:49 | |
| openstackgerrit | lifeless proposed a change to openstack/ironic: Run the whole test suite as one run https://review.openstack.org/118920 | 02:58 |
| openstackgerrit | lifeless proposed a change to openstack/ironic: Fix hash ring stability https://review.openstack.org/118932 | 02:59 |
| openstackgerrit | lifeless proposed a change to openstack/ironic: Ignore backup files https://review.openstack.org/118922 | 02:59 |
| *** yuanying has quit IRC | 03:00 | |
| *** yuanying has joined #openstack-ironic | 03:00 | |
| *** pcrews has quit IRC | 03:02 | |
| *** yuanying has quit IRC | 03:04 | |
| *** zz_naotok is now known as naotok | 03:04 | |
| *** dlaube has quit IRC | 03:16 | |
| *** penick has joined #openstack-ironic | 03:19 | |
| *** Poornima has joined #openstack-ironic | 03:26 | |
| *** penick has quit IRC | 03:27 | |
| *** yuanying has joined #openstack-ironic | 03:40 | |
| *** rushiagr_away is now known as rushiagr | 03:42 | |
| *** eghobo has joined #openstack-ironic | 04:02 | |
| *** rushiagr is now known as rushiagr_away | 04:07 | |
| *** vinbs has joined #openstack-ironic | 04:19 | |
| *** rushiagr_away is now known as rushiagr | 04:51 | |
| openstackgerrit | Motohiro Otsuka proposed a change to openstack/ironic: Search line with awk itself and avoid grep https://review.openstack.org/118966 | 04:53 |
| *** faizan has joined #openstack-ironic | 04:57 | |
| *** rakesh_hs has joined #openstack-ironic | 05:14 | |
| *** yuanying has quit IRC | 05:19 | |
| *** yuanying has joined #openstack-ironic | 05:19 | |
| *** yuanying has quit IRC | 05:24 | |
| *** yuanying has joined #openstack-ironic | 05:24 | |
| *** killer_prince is now known as lazy_prince | 05:34 | |
| *** vinbs has quit IRC | 05:37 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add uefi boot mode support in IloVirtualMediaIscsiDeploy https://review.openstack.org/116561 | 05:49 |
| *** harlowja is now known as harlowja_away | 05:50 | |
| *** vinbs has joined #openstack-ironic | 05:51 | |
| *** Nisha has joined #openstack-ironic | 05:54 | |
| faizan | Hi JoshNang, | 05:59 |
| faizan | JoshNang, Posted a new patch addressing your review comments for https://review.openstack.org/116561 | 06:00 |
| *** bmahalakshmi has joined #openstack-ironic | 06:01 | |
| *** psp08 has joined #openstack-ironic | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/118548 | 06:13 |
| *** lazy_prince is now known as killer_prince | 06:14 | |
| *** pradhan has joined #openstack-ironic | 06:17 | |
| *** killer_prince is now known as lazy_prince | 06:17 | |
| *** pradhan has quit IRC | 06:18 | |
| wanyen | Hi Lucas, are you there? | 06:18 |
| wanyen | Lucas, can you review Add uefi boot mode support in IloVirtualMediaIscsiDeploy https://review.openstack.org/116561 . We very much like to include this code in Juno. Can you and other reviewers review this patch? Thanks! | 06:20 |
| *** saripurigopi has joined #openstack-ironic | 06:47 | |
| *** romcheg1 has joined #openstack-ironic | 06:52 | |
| *** aweeks has quit IRC | 07:03 | |
| *** stevebaker has quit IRC | 07:04 | |
| *** adam_g has quit IRC | 07:04 | |
| saripurigopi | are there any guide lines documented for writing unit-tests for new driver ? | 07:04 |
| *** wendar has quit IRC | 07:04 | |
| *** wendar_ has joined #openstack-ironic | 07:04 | |
| *** bluex-pl has joined #openstack-ironic | 07:04 | |
| *** aweeks has joined #openstack-ironic | 07:05 | |
| *** stevebaker has joined #openstack-ironic | 07:06 | |
| *** adam_g has joined #openstack-ironic | 07:06 | |
| *** adam_g has quit IRC | 07:06 | |
| *** adam_g has joined #openstack-ironic | 07:06 | |
| *** eghobo has quit IRC | 07:06 | |
| mrda | saripurigopi: I think your best bet is to see how existing drivers are done, and use the same approach | 07:09 |
| *** jistr has joined #openstack-ironic | 07:09 | |
| saripurigopi | @mrda, these tests can only be run on real hardware. but most of the testcases run on Fake data. | 07:11 |
| *** jcoufal has joined #openstack-ironic | 07:21 | |
| *** rakesh_hs2 has joined #openstack-ironic | 07:24 | |
| *** rakesh_hs has quit IRC | 07:24 | |
| *** rakesh_hs2 has quit IRC | 07:25 | |
| *** rakesh_hs has joined #openstack-ironic | 07:27 | |
| *** rakesh_hs has quit IRC | 07:28 | |
| *** rakesh_hs has joined #openstack-ironic | 07:29 | |
| *** romcheg2 has joined #openstack-ironic | 07:29 | |
| *** romcheg1 has quit IRC | 07:30 | |
| *** bluex-pl has quit IRC | 07:32 | |
| *** romcheg1 has joined #openstack-ironic | 07:33 | |
| *** romcheg2 has quit IRC | 07:35 | |
| *** bluex-pl has joined #openstack-ironic | 07:46 | |
| *** romcheg1 has quit IRC | 07:46 | |
| *** bluex-pl has quit IRC | 07:51 | |
| *** romcheg1 has joined #openstack-ironic | 07:51 | |
| *** bluex-pl has joined #openstack-ironic | 08:02 | |
| mrda | rloo: So I'm not sure which part you were referring to, but the bit that's different that I can see | 08:09 |
| mrda | rloo: is in spawn(). I've looked at 111428 (what's proposed in Nova), along with Ironic HEAD, | 08:09 |
| mrda | rloo: and looked at the proposed split of the code base that I put together at midcycle | 08:09 |
| mrda | rloo: (ref https://raw.githubusercontent.com/mrda/nova-ironic-driver-split/master/patch-4/nova/virt/ironic/driver.py) | 08:09 |
| mrda | rloo: so the proposed Nova patch is consistent with the snapshot of the driver I took at midcycle in PDX. | 08:09 |
| mrda | oo: but it appears that Ironic trunk moved on post-snapshot, and I didn't know about it :( | 08:09 |
| mrda | oo: So what I've done is to upload a new 111428 with spawn() reflecting what it is in HEAD (with the changes | 08:10 |
| mrda | rloo: that Nova have required of the driver). | 08:10 |
| mrda | rloo: There's two things remaining. 1) double check that no more changes have snuck into the Ironic tree | 08:10 |
| mrda | rloo: that haven't been proposed to Nova, and 2) Ensure that all the Nova fixes, even the trivials, have made | 08:10 |
| mrda | rloo: their way back into Ironic. | 08:10 |
| mrda | rloo: That's what I'm doing (when I'm not servicing Nova review comments) | 08:10 |
| mrda | rloo: Please let me know if there's anything you can think of that I've missed. | 08:10 |
| mrda | And on that note, it's time to call it a day :) | 08:11 |
| *** lucasagomes has joined #openstack-ironic | 08:13 | |
| lucasagomes | some core https://review.openstack.org/#/c/118693/ | 08:14 |
| lucasagomes | that's nova driver changes, there's 3 +2 and mrda already +1'd so he's aware of the changes | 08:14 |
| *** derekh has joined #openstack-ironic | 08:15 | |
| *** dtantsur|afk is now known as dtantsur | 08:19 | |
| dtantsur | Morning Ironic | 08:19 |
| mrda | hi lucasagomes and dtantsur | 08:19 |
| lucasagomes | morning mrda dtantsur | 08:19 |
| mrda | Ok, I'm really going now. Have a great day Ironic and see you tomorrow. | 08:23 |
| * mrda hopes the check gate holds up while I'm away | 08:23 | |
| lucasagomes | mrda, g'night! | 08:26 |
| vinbs | Morning dtantsur, lucasagomes | 08:27 |
| lucasagomes | vinbs, morning | 08:27 |
| *** stendulker has joined #openstack-ironic | 08:30 | |
| dtantsur | mrda, lucasagomes, vinbs, hi! Are we in FF already? Are we trying to merge what was approved yesterday? | 08:32 |
| lucasagomes | dtantsur, I thin we have today as well to merge stuff | 08:37 |
| lucasagomes | think* | 08:37 |
| dtantsur | I see. So we keep rechecking/reapproving this Ilo* things, right? | 08:37 |
| lucasagomes | yup | 08:38 |
| vinbs | dtantsur, is there a way I can have a preview of how the documentation looks before committing the changes for review? | 08:46 |
| vinbs | dtantsur, I'm referring to these changes I committed https://review.openstack.org/#/c/118614/2/doc/source/deploy/install-guide.rst | 08:47 |
| dtantsur | lemme try to remember | 08:47 |
| dtantsur | vinbs, $ sphinx-build doc/source/ /destination | 08:49 |
| vinbs | dtantsur, thanks | 08:51 |
| vinbs | dtantsur, also is there a recommended editor for editing the RST files in doc/source? | 08:51 |
| vinbs | dtantsur, I'm finding it tough to get the indentation and formatting right | 08:52 |
| dtantsur | vinbs, don't know anything about the recommend editor, vim usually works for me | 08:53 |
| *** athomas has quit IRC | 08:58 | |
| *** athomas has joined #openstack-ironic | 08:58 | |
| *** foexle has joined #openstack-ironic | 08:58 | |
| *** Ng has quit IRC | 09:04 | |
| *** Ng_ has joined #openstack-ironic | 09:05 | |
| mrda | . | 09:10 |
| mrda | dtantsur: I will be pushing the case for a FFE tomorrow at the Nova team meeting (in about 12 hours time) | 09:10 |
| mrda | but I need another core to sign up | 09:11 |
| lucasagomes | mrda, how many cores we have/need? | 09:14 |
| *** ifarkas_ has quit IRC | 09:15 | |
| mrda | we have 2, need one more | 09:15 |
| lucasagomes | mrda, right, I will try to find soneone | 09:16 |
| lucasagomes | someone | 09:16 |
| lucasagomes | mrda, there's a list somewhere? | 09:16 |
| lucasagomes | etherpad? | 09:16 |
| mrda | well, right now: https://wiki.openstack.org/wiki/Meetings/Nova | 09:16 |
| mrda | where it's an agenda item | 09:17 |
| *** ifarkas has joined #openstack-ironic | 09:17 | |
| mrda | After the meeting I'll update our whiteboard | 09:17 |
| mrda | (once we have some certainty) | 09:17 |
| lucasagomes | mrda, right, who are the cores we have now? | 09:17 |
| lucasagomes | mrda, dan smith? daniel berrage? | 09:17 |
| mrda | Joe Gordon and Dan Smith | 09:17 |
| lucasagomes | alright | 09:18 |
| lucasagomes | mrda, I will see if I can find someone else | 09:18 |
| mrda | that'd be great - even better if it someone who wants to see it merge too :) | 09:19 |
| lucasagomes | mrda, overall the driver is doing well right? based on the reviews I think we are not getting any bigger blocker for the driver | 09:19 |
| lucasagomes | mrda, yup | 09:19 |
| mrda | lucasagomes: do you know Daniel Berrange's IRC nick? | 09:19 |
| mrda | the driver is making progress | 09:19 |
| mrda | but each time a reviewer joins in, a new set of explanations/fixes required | 09:20 |
| lucasagomes | mrda, not sure his IRC name :/ | 09:20 |
| mrda | yeah, I can't see it | 09:20 |
| lucasagomes | mrda, yeah, mostly nits | 09:20 |
| *** rakesh_hs has quit IRC | 09:30 | |
| *** rakesh_hs has joined #openstack-ironic | 09:31 | |
| *** rakesh_hs has quit IRC | 09:31 | |
| *** danpb has joined #openstack-ironic | 09:31 | |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Nova review updates for _node_resource https://review.openstack.org/116772 | 09:32 |
| danpb | i hear that ironic is looking for a 3rd nova core sponsor for FFE. if so, I'm fine with being your final sucker^H^H^H volunteer :-) | 09:33 |
| *** rakesh_hs has joined #openstack-ironic | 09:34 | |
| mrda | Thanks danpb - much appreciated | 09:34 |
| lucasagomes | danpb, yay! man thanks very much | 09:37 |
| lucasagomes | danpb, I pay you 2 pints in paris :) | 09:37 |
| *** bluex-pl has quit IRC | 09:37 | |
| *** bluex-pl has joined #openstack-ironic | 09:38 | |
| mrda | :) | 09:38 |
| Nisha | hi lucasagomes | 09:42 |
| *** bluex-pl has quit IRC | 09:43 | |
| Nisha | lucasagomes: does https://review.openstack.org/#/c/115885/ needs more +1/+2 | 09:43 |
| *** bluex-pl has joined #openstack-ironic | 09:43 | |
| dtantsur | Nisha, hi, it anyway needs previous patch to land | 09:47 |
| Nisha | ohk | 09:47 |
| Nisha | thanks, i didnt see that it is dependent on the other one | 09:48 |
| dtantsur | I hope to land both actually | 09:48 |
| dtantsur | brb | 09:48 |
| *** dtantsur is now known as dtantsur|brb | 09:48 | |
| Nisha | dtantsur: i was looking at its parent patch, it fails in tempest while for requirements.txt | 09:48 |
| openstackgerrit | lifeless proposed a change to openstack/ironic: Fix hash ring stability https://review.openstack.org/118932 | 09:52 |
| *** romcheg2 has joined #openstack-ironic | 09:57 | |
| *** romcheg1 has quit IRC | 09:59 | |
| * mrda didn't realise romcheg was a twin | 09:59 | |
| *** danpb has left #openstack-ironic | 10:00 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Driver merge review comments from 111425 https://review.openstack.org/118693 | 10:05 |
| *** mmitchell has quit IRC | 10:06 | |
| *** mmitchell has joined #openstack-ironic | 10:06 | |
| romcheg2 | mrda: I left one instance of the IM on the computer I cannot access in any way :) | 10:06 |
| mrda | I'm just over tired, feel free to ignore me :) | 10:08 |
| *** romcheg1 has joined #openstack-ironic | 10:08 | |
| *** romcheg2 has quit IRC | 10:10 | |
| *** nosnos has quit IRC | 10:14 | |
| *** Nisha has quit IRC | 10:14 | |
| *** nosnos has joined #openstack-ironic | 10:15 | |
| *** rameshg87 has joined #openstack-ironic | 10:15 | |
| *** bluex-pl has quit IRC | 10:17 | |
| *** rameshg87 has quit IRC | 10:18 | |
| *** nosnos_ has joined #openstack-ironic | 10:18 | |
| *** Ugallu has joined #openstack-ironic | 10:18 | |
| *** nosnos has quit IRC | 10:19 | |
| *** rameshg87 has joined #openstack-ironic | 10:19 | |
| *** rameshg87 has quit IRC | 10:20 | |
| *** Ugallu has quit IRC | 10:22 | |
| *** psp08 has quit IRC | 10:23 | |
| *** rushiagr is now known as rushiagr_away | 10:28 | |
| *** k4n0_ has quit IRC | 10:33 | |
| *** k4n0 has joined #openstack-ironic | 10:35 | |
| *** Ugallu has joined #openstack-ironic | 10:38 | |
| *** naotok is now known as zz_naotok | 10:45 | |
| mrda | Good news Ironic! | 10:50 |
| mrda | We now have 2x+2's on patches 1 and 2 | 10:50 |
| mrda | and 1x+2 on patches 3, 4, 5, 6 and 7 | 10:50 |
| mrda | so we're only a single Nova core away from merging the ironic driver into Nova! | 10:51 |
| mrda | and on that nice thought, I am leaving for the evening, for the third time :) | 10:53 |
| lucasagomes | w00000000000000000000000000000000000000000000000000000000000000000000000000000000000000ts | 10:53 |
| lucasagomes | mrda, have a great night! | 10:54 |
| mrda | \o/ | 10:54 |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add uefi boot mode support in IloVirtualMediaIscsiDeploy https://review.openstack.org/116561 | 10:55 |
| *** Ng_ is now known as Ng | 11:01 | |
| *** romcheg1 has quit IRC | 11:03 | |
| *** stendulker has quit IRC | 11:03 | |
| *** bmahalakshmi has quit IRC | 11:05 | |
| *** bmahalakshmi has joined #openstack-ironic | 11:08 | |
| *** romcheg1 has joined #openstack-ironic | 11:11 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Support for setting boot mode in pxe_ilo driver https://review.openstack.org/118578 | 11:14 |
| *** dtantsur|brb is now known as dtantsur | 11:14 | |
| *** rushiagr_away is now known as rushiagr | 11:18 | |
| *** saripurigopi has quit IRC | 11:21 | |
| *** Poornima has quit IRC | 11:25 | |
| *** bmahalakshmi has quit IRC | 11:29 | |
| *** ndipanov has joined #openstack-ironic | 11:34 | |
| *** mrda1 has joined #openstack-ironic | 11:49 | |
| *** jroll|dupe has joined #openstack-ironic | 11:50 | |
| *** greghaynes has quit IRC | 11:50 | |
| *** jroll has quit IRC | 11:50 | |
| *** mrda has quit IRC | 11:51 | |
| *** dtantsur has quit IRC | 11:51 | |
| *** dtantsur has joined #openstack-ironic | 11:51 | |
| *** dtantsur has quit IRC | 11:51 | |
| *** dtantsur has joined #openstack-ironic | 11:51 | |
| *** jroll|dupe is now known as jroll | 11:51 | |
| *** greghayn1 has joined #openstack-ironic | 11:51 | |
| *** romcheg has quit IRC | 11:53 | |
| *** vdrok_afk has quit IRC | 11:56 | |
| *** romcheg has joined #openstack-ironic | 11:59 | |
| *** faizan has quit IRC | 12:05 | |
| *** vinbs has quit IRC | 12:06 | |
| openstackgerrit | A change was merged to openstack/ironic: Ignore backup files https://review.openstack.org/118922 | 12:24 |
| *** igordcard has joined #openstack-ironic | 12:37 | |
| *** rameshg87 has joined #openstack-ironic | 12:45 | |
| rameshg87 | lucasagomes, hi | 12:45 |
| lucasagomes | rameshg87, hi there | 12:45 |
| rameshg87 | lucasagomes, regarding review 113865, the gate jobs are very slow, any idea why? :( | 12:46 |
| lucasagomes | rameshg87, I think it's due the FF, people are now merging many things | 12:47 |
| lucasagomes | http://status.openstack.org/zuul/ | 12:47 |
| lucasagomes | the list is gigantic | 12:47 |
| rameshg87 | lucasagomes, okay. So it's crunch time out there :( | 12:48 |
| lucasagomes | rameshg87, yeah :( | 12:49 |
| rameshg87 | lucasagomes, hope we will wait for the two approved patches to land :) | 12:50 |
| lucasagomes | rameshg87, yup yeah I think it makes sense, but also it's just a milestone... if they are approved they will get to the final release which is the most important thing (as far as I see it) | 12:51 |
| *** rameshg87 has quit IRC | 12:57 | |
| *** foexle_ has joined #openstack-ironic | 13:00 | |
| *** foexle has quit IRC | 13:04 | |
| *** bluex-pl has joined #openstack-ironic | 13:08 | |
| *** jcoufal has quit IRC | 13:08 | |
| *** Nisha has joined #openstack-ironic | 13:09 | |
| Shrews | morning ironic | 13:09 |
| *** jcoufal has joined #openstack-ironic | 13:11 | |
| *** k4n0 has quit IRC | 13:12 | |
| *** bluex-pl has quit IRC | 13:13 | |
| lucasagomes | Shrews, morning | 13:13 |
| *** bluex-pl has joined #openstack-ironic | 13:13 | |
| *** ndipanov_ has joined #openstack-ironic | 13:15 | |
| Nisha | lucasagomes: Hi | 13:16 |
| lucasagomes | Nisha, hi there | 13:16 |
| *** ndipanov has quit IRC | 13:16 | |
| Nisha | lucasagomes: there is jenkins failure for https://review.openstack.org/#/c/113865/ | 13:17 |
| lucasagomes | Nisha, :( will take a look | 13:18 |
| Nisha | But are not related to the patch | 13:18 |
| lucasagomes | Nisha, ah it seems to be devstack related | 13:18 |
| lucasagomes | yup there's a bug open for that | 13:18 |
| lucasagomes | sec will find the link | 13:19 |
| Nisha | Yes | 13:19 |
| lucasagomes | https://bugs.launchpad.net/devstack/+bug/1363828 | 13:19 |
| lucasagomes | the fix seems to have been approved upstream too | 13:19 |
| lucasagomes | but didn't merge in devstack yet | 13:19 |
| lucasagomes | https://review.openstack.org/#/c/118090/ | 13:19 |
| lucasagomes | Nisha, we can recheck it | 13:19 |
| lucasagomes | recheck bug 1363828 | 13:19 |
| Nisha | lucasagomes: but it shows the status for it as New | 13:20 |
| lucasagomes | Nisha, In Progress | 13:20 |
| Nisha | lucasagomes: :) yes | 13:20 |
| lucasagomes | and the patch is alreayd approved, so have to wait to gate to merge it in the code base | 13:21 |
| Nisha | lucasagomes: https://review.openstack.org/#/c/113865/ already has two +2's | 13:21 |
| *** vdrok_afk has joined #openstack-ironic | 13:21 | |
| *** vdrok_afk is now known as vdrok | 13:21 | |
| Nisha | and one +1 | 13:21 |
| lucasagomes | Nisha, yup, sec I will review it in a moment | 13:21 |
| Nisha | Thanks | 13:21 |
| lucasagomes | just finishing something here first | 13:21 |
| lucasagomes | Nisha, np | 13:21 |
| Nisha | lucasagomes: thanks | 13:21 |
| Nisha | lucasagomes: so jenkins failure can be ignored or we have to post the patch again after the gate merges the fix for the bug | 13:24 |
| lucasagomes | Nisha, yeah you can ignore it for now | 13:24 |
| Nisha | lucasagomes: thanks | 13:24 |
| lucasagomes | Nisha, in any case, say the patch is approved and failed like that to merge | 13:24 |
| lucasagomes | you can issue a recheck command | 13:24 |
| Nisha | how do we issue recheck? | 13:24 |
| lucasagomes | so jenkins will pick the patch again to erge it | 13:24 |
| lucasagomes | you just post a comment on the last patch set | 13:25 |
| Nisha | lucasagomes: sorry never done before | 13:25 |
| lucasagomes | "recheck bug <bug number>" | 13:25 |
| lucasagomes | if there's a bug | 13:25 |
| lucasagomes | if not you can do "recheck no bug" | 13:25 |
| lucasagomes | but please when rechecking first look if there's a bug open already for that error | 13:25 |
| lucasagomes | and if possible open one as well | 13:25 |
| lucasagomes | if there's none | 13:25 |
| Nisha | Ok :) thanks | 13:26 |
| lucasagomes | Nisha, nothing to be sorry about :) that's totally cool! | 13:26 |
| lucasagomes | yvw | 13:26 |
| *** pcrews has joined #openstack-ironic | 13:27 | |
| lucasagomes | Nisha, btw, https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures | 13:28 |
| lucasagomes | describes it better | 13:28 |
| *** lazy_prince is now known as killer_prince | 13:28 | |
| Nisha | lucasagomes: request review for https://review.openstack.org/#/c/116561/ also | 13:29 |
| Nisha | we reposted the patch in the afternoon | 13:29 |
| Nisha | we would like to land it also in Juno3 | 13:31 |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Translator functions cleanup part 1 https://review.openstack.org/116303 | 13:32 |
| lucasagomes | ack | 13:32 |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Translator functions cleanup part 2 https://review.openstack.org/118587 | 13:32 |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Translator functions cleanup part 3 https://review.openstack.org/118588 | 13:33 |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Translator functions cleanup part 4 https://review.openstack.org/118591 | 13:33 |
| *** datajerk has quit IRC | 13:36 | |
| *** rloo has joined #openstack-ironic | 13:37 | |
| *** rloo has quit IRC | 13:38 | |
| NobodyCam | good mornng Ironic | 13:38 |
| NobodyCam | did we land everthing | 13:38 |
| NobodyCam | I fell asleep around 11:30 pm and the patches where still in hte gate | 13:39 |
| NobodyCam | nope :( | 13:40 |
| *** rameshg87 has joined #openstack-ironic | 13:41 | |
| NobodyCam | going to approve 115885 even thou the dep is still in the gate, just so it shows as approved | 13:42 |
| NobodyCam | actually I'll wait | 13:42 |
| dtantsur | NobodyCam, Shrews, morning | 13:45 |
| NobodyCam | morning dtantsur | 13:50 |
| *** nosnos_ has quit IRC | 13:50 | |
| *** nosnos has joined #openstack-ironic | 13:51 | |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/python-ironicclient: Add sort_key and sort_dir parameters to *-list https://review.openstack.org/114555 | 13:52 |
| NobodyCam | anyone going to join me in tne nova meeting? | 13:52 |
| NobodyCam | :-p | 13:52 |
| *** r-daneel has joined #openstack-ironic | 13:53 | |
| lucasagomes | NobodyCam, it's now? | 13:53 |
| NobodyCam | morning lucasagomes | 13:53 |
| lucasagomes | morning | 13:53 |
| NobodyCam | its at 7 | 13:53 |
| *** rloo has joined #openstack-ironic | 13:53 | |
| NobodyCam | (6 minutes) | 13:53 |
| rloo | NobodyCam, mrda will be there I think | 13:54 |
| NobodyCam | good morning rloo | 13:54 |
| NobodyCam | :) | 13:54 |
| rloo | morning NobodyCam and all Iroknickers out there! | 13:55 |
| lucasagomes | rloo, morning | 13:55 |
| *** romcheg2 has joined #openstack-ironic | 13:55 | |
| *** nosnos has quit IRC | 13:55 | |
| rloo | hi lucasagomes | 13:55 |
| NobodyCam | :) | 13:56 |
| *** romcheg1 has quit IRC | 13:56 | |
| dtantsur | rloo, morning | 13:59 |
| *** dtantsur is now known as dtantsur|brb | 14:00 | |
| *** killer_prince is now known as lazy_prince | 14:00 | |
| rloo | afternoon dtantsur|brb | 14:00 |
| *** Nisha has quit IRC | 14:00 | |
| jroll | morning ironic :) | 14:03 |
| NobodyCam | hummw | 14:03 |
| jroll | NobodyCam: meeting-alt :P | 14:03 |
| NobodyCam | morning jroll | 14:03 |
| NobodyCam | doh | 14:03 |
| jroll | whoaaaaaaaaaaaaaaaa | 14:04 |
| jroll | we have daniel berrange +2 on all patches | 14:04 |
| NobodyCam | nice | 14:04 |
| *** yuanying_ has joined #openstack-ironic | 14:06 | |
| rloo | hmm we might have a problem. lucasagomes , https://review.openstack.org/#/c/118693/4/ironic/nova/virt/ironic/driver.py | 14:07 |
| rloo | line 181 | 14:07 |
| lucasagomes | rloo, nodes_extra_specs = {} ? | 14:08 |
| rloo | forget it. more caffeine needed. | 14:08 |
| lucasagomes | why? | 14:08 |
| lucasagomes | ah | 14:08 |
| jroll | hehe | 14:08 |
| lucasagomes | heh | 14:08 |
| * jroll makes rloo some coffee | 14:08 | |
| rloo | it was capabilities that i got confused with. | 14:08 |
| rloo | phew | 14:08 |
| lucasagomes | rloo, :) no worries | 14:08 |
| lucasagomes | we got +2sssss | 14:08 |
| lucasagomes | on the patches, that's awesome | 14:08 |
| lucasagomes | oh, I mean in the nova driver patches | 14:09 |
| rloo | yeah, i'll refrain from -1'ing them this time. | 14:09 |
| jroll | fyi, looks like we got bumped to rc1 | 14:09 |
| jroll | so I think that means we already got the ffe? | 14:09 |
| rloo | yay | 14:09 |
| lucasagomes | jroll, we have the sponsors | 14:09 |
| lucasagomes | https://wiki.openstack.org/wiki/Meetings/Nova | 14:09 |
| jroll | ah, right | 14:10 |
| rloo | i thought i saw something in the mailing list that even with a ffe, it has to be merged by next Friday | 14:10 |
| jroll | lucasagomes: I'm looking at https://etherpad.openstack.org/p/SC1ILk7zMT | 14:10 |
| jroll | rloo: yep | 14:10 |
| jroll | rloo: I don't think that will be a problem | 14:10 |
| jroll | I think the intent of our sponsors is to keep things going through | 14:10 |
| lucasagomes | ah nice! | 14:11 |
| lucasagomes | rc1 works for me :) | 14:11 |
| jroll | I think its the same thing. idk | 14:13 |
| *** romcheg2 has quit IRC | 14:14 | |
| *** romcheg1 has joined #openstack-ironic | 14:15 | |
| NobodyCam | w00t | 14:16 |
| *** vdrok has quit IRC | 14:17 | |
| *** Ugallu has quit IRC | 14:17 | |
| *** yuanying has quit IRC | 14:17 | |
| *** zer0c00l has quit IRC | 14:17 | |
| *** ekarlso- has quit IRC | 14:17 | |
| *** lsmola has quit IRC | 14:17 | |
| *** harlowja_away has quit IRC | 14:17 | |
| *** annegentle has quit IRC | 14:17 | |
| *** notq has quit IRC | 14:17 | |
| *** antonym has quit IRC | 14:17 | |
| NobodyCam | 14:16 | johnthetubaguy > #info ironic gets FFE dansmith jogo danpb | 14:17 |
| jroll | \o/ | 14:17 |
| * jroll makes coffee | 14:17 | |
| * NobodyCam approves 113865!!!!!! | 14:20 | |
| NobodyCam | and 115885!!!! | 14:20 |
| jroll | oh nice | 14:20 |
| jroll | cool | 14:22 |
| *** antonym has joined #openstack-ironic | 14:22 | |
| *** vdrok has joined #openstack-ironic | 14:22 | |
| *** zer0c00l has joined #openstack-ironic | 14:22 | |
| *** ekarlso- has joined #openstack-ironic | 14:23 | |
| jroll | so we just have the uefi spec left | 14:23 |
| *** rameshg87 has joined #openstack-ironic | 14:23 | |
| jroll | the main patch landed | 14:23 |
| jroll | two left: https://review.openstack.org/#/c/116561/ | 14:23 |
| jroll | https://review.openstack.org/#/c/118578/ | 14:23 |
| NobodyCam | jroll: I will start looking after nova meeting | 14:24 |
| jroll | yeah, no rush | 14:24 |
| *** lsmola has joined #openstack-ironic | 14:25 | |
| *** jistr has quit IRC | 14:27 | |
| *** jistr has joined #openstack-ironic | 14:29 | |
| *** lsmola is now known as 18VAAT2X4 | 14:33 | |
| bluex-pl | jroll: hi, created a little less dirty way to create command_map in ironic_python_agent - http://paste.openstack.org/show/105820/ :) | 14:33 |
| *** Ugallu has joined #openstack-ironic | 14:33 | |
| *** yuanying has joined #openstack-ironic | 14:33 | |
| *** 17SAA4BEV has joined #openstack-ironic | 14:33 | |
| *** lsmola has joined #openstack-ironic | 14:33 | |
| *** annegentle has joined #openstack-ironic | 14:33 | |
| *** notq has joined #openstack-ironic | 14:33 | |
| *** 17SAA4BEV has quit IRC | 14:33 | |
| *** annegentle_ has joined #openstack-ironic | 14:33 | |
| *** yuanying has quit IRC | 14:33 | |
| *** lsmola has quit IRC | 14:34 | |
| *** annegentle has quit IRC | 14:34 | |
| *** annegentle_ is now known as Guest18621 | 14:34 | |
| jroll | bluex-pl: neat, I like it :) | 14:37 |
| *** victor_lowther has quit IRC | 14:38 | |
| *** ndipanov_ is now known as nidpanov | 14:38 | |
| *** jistr has quit IRC | 14:39 | |
| *** jistr has joined #openstack-ironic | 14:39 | |
| *** jistr has quit IRC | 14:39 | |
| *** victor_lowther_ has joined #openstack-ironic | 14:39 | |
| bluex-pl | can I push it to the same changeset or should I create a new one? | 14:39 |
| *** jistr has joined #openstack-ironic | 14:40 | |
| jroll | bluex-pl: same review is fin | 14:40 |
| jroll | e | 14:40 |
| *** ifarkas has quit IRC | 14:42 | |
| *** Nisha has joined #openstack-ironic | 14:43 | |
| *** datajerk has joined #openstack-ironic | 14:43 | |
| NobodyCam | nice ok we gots a plan | 14:44 |
| jroll | whee. | 14:44 |
| NobodyCam | 14:44 | johnthetubaguy > #info baremetal proxy api could use the virt driver setting to decide what mode its in, until we rip out baremetal | 14:44 |
| Nisha | lucasagomes: dtantsur|brb https://review.openstack.org/#/c/113865/ needs one more reviewer to look at.... | 14:45 |
| lucasagomes | Nisha, NobodyCam approved that | 14:46 |
| NobodyCam | Nisha: 113865 was approved this morning | 14:46 |
| Nisha | lucasagomes: but its not merged | 14:46 |
| lucasagomes | Nisha, it will after jenkins | 14:46 |
| NobodyCam | its in the gate now | 14:46 |
| Nisha | Ok :) Thanks | 14:46 |
| jroll | if only we could merge code :P | 14:47 |
| lucasagomes | heh | 14:47 |
| NobodyCam | brb | 14:47 |
| Nisha | lucasagomes: NobodyCam core reviewers : need review for https://review.openstack.org/#/c/116561 | 14:48 |
| openstackgerrit | Szymon Wróblewski proposed a change to openstack/ironic-python-agent: Enhance decorators in agent and automate creation of command_map. https://review.openstack.org/117529 | 14:48 |
| NobodyCam | have to run the car into the shop... bbiafm | 14:48 |
| *** rakesh_hs has quit IRC | 14:49 | |
| *** igordcard has quit IRC | 14:50 | |
| bluex-pl | jroll: done | 14:52 |
| jroll | thanks :) | 14:52 |
| *** rameshg87 has joined #openstack-ironic | 14:53 | |
| *** rameshg87 has quit IRC | 14:53 | |
| *** datajerk has quit IRC | 14:58 | |
| *** jcoufal has quit IRC | 15:01 | |
| openstackgerrit | A change was merged to openstack/ironic: IloVirtualMediaIscsi deploy driver https://review.openstack.org/113865 | 15:15 |
| openstackgerrit | A change was merged to openstack/ironic: IloVirtualMediaAgent deploy driver https://review.openstack.org/115885 | 15:15 |
| *** rameshg87 has joined #openstack-ironic | 15:18 | |
| jroll | ^^ yesssssssssssss | 15:18 |
| * NobodyCam is back | 15:19 | |
| NobodyCam | 116561 and 118693 are both failing check jobs | 15:24 |
| NobodyCam | :( | 15:24 |
| jroll | are you watching zuul again? | 15:26 |
| Shrews | thin line between "watching" and "stalking" :) | 15:27 |
| * NobodyCam is way past the line... | 15:27 | |
| * NobodyCam expects a restraning order soon | 15:27 | |
| jroll | I have a feeling NobodyCam is on a console in the hp cloud | 15:28 |
| jroll | *in* zuul | 15:28 |
| NobodyCam | lol I wish | 15:28 |
| NobodyCam | heheheh | 15:28 |
| NobodyCam | 118578 looks like there may be real issues with that one | 15:30 |
| Shrews | NobodyCam: i just left some comments there | 15:30 |
| NobodyCam | ya I saw them | 15:30 |
| Shrews | ah | 15:31 |
| *** dlaube has joined #openstack-ironic | 15:31 | |
| Shrews | that was just a quick once over. there may be more | 15:31 |
| NobodyCam | and 116561 also looks like real errors https://jenkins05.openstack.org/job/gate-ironic-pep8/833/console | 15:32 |
| *** rameshg87 has joined #openstack-ironic | 15:36 | |
| JayF | There's an email on the mailing list | 15:38 |
| JayF | about splitting out all nova drivers into their own repos | 15:38 |
| JayF | and one of the cited reasons why is that "In Juno it is likely that the Ironic driver will be merged into Nova." | 15:38 |
| JayF | from one of the people who've been reviewing our patches, at that | 15:38 |
| jroll | it is likely, we have a +2 on every patch, and three sponsoring cores | 15:39 |
| JayF | I'm just saying that there's ... misinformation being put on the list | 15:39 |
| jroll | what misinformation? | 15:39 |
| JayF | and someone who has more nova/ironic crossover than I do might want to read the thread and reply | 15:39 |
| JayF | that Ironic driver is unlikely to land in Juno | 15:40 |
| jroll | oh, you said it is likely | 15:40 |
| Shrews | isn't devananda back soon? he should probably jump on that | 15:40 |
| jroll | right | 15:41 |
| * jroll is trying to find the exact email | 15:41 | |
| *** jistr has quit IRC | 15:41 | |
| JayF | jroll: hahaha | 15:41 |
| JayF | jroll: that's a direct copy pasty | 15:41 |
| JayF | *paste | 15:41 |
| JayF | jroll: which means I added the "not" in my brain alone | 15:41 |
| Shrews | http://lists.openstack.org/pipermail/openstack-dev/2014-September/044872.html | 15:42 |
| JayF | Add that to the list of reasons I should be in bed this morning, haha | 15:42 |
| jroll | JayF: lol | 15:42 |
| jroll | so everything is fine :P | 15:42 |
| jroll | Shrews: right, that's on my 'to read' list | 15:42 |
| NobodyCam | ogm its long | 15:42 |
| NobodyCam | omg | 15:43 |
| Shrews | ikr? | 15:43 |
| jroll | I can appreciate a good novel | 15:43 |
| *** eghobo has joined #openstack-ironic | 15:44 | |
| lucasagomes | Nisha, done reviewed | 15:50 |
| NobodyCam | humm great food for thought | 15:50 |
| Nisha | lucasagomes: Thanks. Will just have look | 15:51 |
| lucasagomes | ack | 15:51 |
| NobodyCam | Not sure I agree is the split out idea | 15:51 |
| lucasagomes | Nisha, I think that patch is broken btw | 15:51 |
| lucasagomes | well you'll see the comments | 15:51 |
| Nisha | why | 15:51 |
| lucasagomes | Nisha, there's a getsize() in a string | 15:51 |
| Nisha | lucasagomes: yes let me see the comments first | 15:51 |
| *** dtantsur|brb is now known as dtantsur | 15:51 | |
| lucasagomes | yup | 15:51 |
| NobodyCam | there is already so much invoulved in cross project coradation that I think it would only server to make things worse | 15:52 |
| NobodyCam | coordination even | 15:52 |
| lucasagomes | NobodyCam, when you get some time https://review.openstack.org/#/c/118693/ | 15:53 |
| lucasagomes | mrda is aweare of that changes ^ | 15:53 |
| lucasagomes | the py26 failure seems to be pip related | 15:53 |
| lucasagomes | ConnectionError: HTTPConnectionPool(host='pypi.openstack.org', port=80): Max retries exceeded with url: /packages/source/f/fixtures/fixtures-0.3.16.tar.gz (Caused by <class 'httplib.BadStatusLine'>: ) | 15:54 |
| NobodyCam | lucasagomes: are you rechecking | 15:55 |
| lucasagomes | NobodyCam, didn't issued the command | 15:55 |
| lucasagomes | idk if you +a gate will take it and run tests anyway | 15:55 |
| *** rameshg87 has joined #openstack-ironic | 15:56 | |
| *** rameshg87 has quit IRC | 15:57 | |
| rloo | lucasagomes, wrt that connection error, try recheck bug 1268725 | 15:58 |
| lucasagomes | rloo, cheers | 15:58 |
| lucasagomes | will do | 15:58 |
| lucasagomes | btw all the iLO stuff is now merged right? | 15:58 |
| lucasagomes | there's docs or something to come or we can mark the bps as Implemented? | 15:59 |
| rloo | i encountered that before and someone in infra said to do that. (I put a note about it in our etherpad) | 15:59 |
| lucasagomes | rloo, done, thanks! sorry I didn't see it there :( | 15:59 |
| *** agordeev has joined #openstack-ironic | 16:00 | |
| jroll | lucasagomes: I think they're done? | 16:01 |
| lucasagomes | jroll, the patches seems to be merged already | 16:01 |
| jroll | right | 16:02 |
| jroll | I think we can mark implemented | 16:02 |
| lucasagomes | unless there's more, lemme look at the queue | 16:02 |
| devananda | I'm not really here | 16:02 |
| devananda | https://review.openstack.org/#/q/status:open+project:openstack/ironic+branch:master+topic:bp/uefi-boot-for-ironic,n,z is not done yet | 16:02 |
| lucasagomes | I see a bunch of uefi other patches | 16:02 |
| devananda | I've marked the other two BP completed | 16:02 |
| jroll | devananda: welcome back :) | 16:02 |
| lucasagomes | devananda, ah, awesome | 16:02 |
| lucasagomes | thanks | 16:02 |
| jroll | right, uefi is not done yet | 16:02 |
| devananda | any reason not to tak the milestone now() ? | 16:02 |
| jroll | but ilo bps are done | 16:02 |
| lucasagomes | yeah the uefi one is not quite there yet | 16:02 |
| devananda | *tag | 16:02 |
| NobodyCam | Good Morning devananda | 16:02 |
| lucasagomes | devananda, I don't see any... if everybody agrees to have uefi as FFE | 16:03 |
| NobodyCam | lucasagomes: +1 here | 16:03 |
| jroll | devananda: I don't see a reason, unless you really want uefi with ilo to be in J3 | 16:03 |
| jroll | I'm fine with ffe | 16:03 |
| rloo | hey, we need 3 cores for ffe :-) | 16:03 |
| jroll | though one of the uefi patches was posted yesterday | 16:03 |
| jroll | which is... not lovely | 16:03 |
| devananda | oh :( | 16:04 |
| jroll | it's uefi for the pxe_ilo driver | 16:04 |
| lucasagomes | yeah the uefi's patches doesn't seem to be super ready | 16:06 |
| lucasagomes | I -1'ed two of them | 16:06 |
| lucasagomes | and they duplicate code as well... | 16:06 |
| jroll | right | 16:06 |
| lucasagomes | so I'm happy with ffe for that | 16:06 |
| devananda | ffe it is, assuming they apply, which I think they will | 16:06 |
| jroll | I would assume so, wanyen was poking us about them all day yesterday | 16:07 |
| *** bluex-pl has quit IRC | 16:08 | |
| Nisha | lucasagomes: FFE? | 16:09 |
| lucasagomes | Nisha, feature freeze exception | 16:09 |
| NobodyCam | should we add a section to our agenda for that like nova did? | 16:09 |
| lucasagomes | means we land it in J4 | 16:09 |
| Nisha | Ok | 16:09 |
| *** rushiagr is now known as rushiagr_away | 16:09 | |
| devananda | lucasagomes: there is no "J4" milestone | 16:09 |
| lucasagomes | NobodyCam, we have only uefi incomplete | 16:09 |
| jroll | NobodyCam: probably, but I would hope people can move quickly enough to land it by the meeting | 16:09 |
| devananda | lucasagomes: after J3 we enter the RC period | 16:09 |
| devananda | which is probably what you mean :) | 16:10 |
| lucasagomes | oh, right... yeah i didn't see "J4" at https://wiki.openstack.org/wiki/Juno_Release_Schedule | 16:10 |
| lucasagomes | but yeah that's how I got used to call it | 16:10 |
| lucasagomes | but it's wrong, so RC | 16:10 |
| devananda | ok folks - J3 is tagged | 16:10 |
| lucasagomes | :) | 16:10 |
| NobodyCam | wooo hoo | 16:10 |
| NobodyCam | \o/ | 16:11 |
| devananda | anything not a bug fix should not be approved at this point forward | 16:11 |
| NobodyCam | execpt for uefi | 16:11 |
| NobodyCam | ? | 16:11 |
| devananda | until we grant FFE, which will be done on the mailing list | 16:11 |
| lucasagomes | devananda, nova driver? | 16:11 |
| NobodyCam | :-p | 16:11 |
| lucasagomes | we still have some patches up for the nova driver | 16:11 |
| devananda | NobodyCam: for now, even uefi -- there is a process they need to go through to document it | 16:11 |
| devananda | lucasagomes: ah. and that. anything syncing changes from the nova driver reviews is good, too. | 16:12 |
| lucasagomes | ack | 16:12 |
| devananda | NobodyCam: how was the nova meeting this morning? | 16:12 |
| NobodyCam | ack | 16:12 |
| rloo | what does bug fix mean? that there is a bug opened for it? | 16:12 |
| NobodyCam | we have ffe and a plan for the proxy stuff | 16:12 |
| devananda | rloo: there is a bug open, and that bug has been targeted to the RC milestone | 16:13 |
| NobodyCam | 14:16 | johnthetubaguy > #info ironic gets FFE dansmith jogo danpb | 16:13 |
| NobodyCam | 14:44 | johnthetubaguy > #info baremetal proxy api could use the virt driver setting to decide what mode its in, until we rip out baremetal | 16:13 |
| lucasagomes | o/ | 16:13 |
| jroll | devananda: we have until next friday to land things in nova :) | 16:13 |
| jroll | devananda: also, we have +2 on everything from daniel b, and 2x +2 on the first 3 or 4 patchs | 16:14 |
| jroll | paches* | 16:14 |
| jroll | I think we'll have no issues landing things | 16:14 |
| rloo | devananda, thx for clarifying. so no patches w/o a bug associated with it, and the bug must be targeted to rc. (and who can do the targetting?) | 16:14 |
| dtantsur | devananda, hi, welcome back | 16:14 |
| lucasagomes | btw about landing things in nova, there're two patches doing changes in the driver that mrda is aware of https://review.openstack.org/#/c/116772/ and https://review.openstack.org/#/c/118693/ | 16:14 |
| lucasagomes | I think we should land those | 16:14 |
| devananda | rloo: i believe anyone on ironic-bugs team (which is currently open, so anyone-anyone) | 16:14 |
| devananda | rloo: but if that is abused, we can close the team | 16:14 |
| dtantsur | rloo, I thought we can land fixes for any bugs, if they're really bugs | 16:15 |
| devananda | jroll: awesome | 16:15 |
| devananda | https://launchpad.net/ironic/+milestone/juno-rc1 | 16:15 |
| rloo | I don't mean to be picky, but people may/will ask to get their patch merged. | 16:15 |
| devananda | any bug we think should be fixed in juno should be targeted // added to that page | 16:15 |
| jroll | there's 3(?) bugs targeted for j3 that we likely need to move to rc1 | 16:16 |
| devananda | rloo: absolutely | 16:16 |
| devananda | jroll: already moved | 16:16 |
| jroll | devananda: awesome, ty | 16:16 |
| lucasagomes | this one will annoy us I think https://bugs.launchpad.net/ironic/+bug/1365370 | 16:17 |
| lucasagomes | I'm taking a look at it | 16:17 |
| lucasagomes | maybe worth adding to rc | 16:17 |
| devananda | lucasagomes: you have the power :) | 16:17 |
| devananda | (as does everyone else, heh) | 16:18 |
| lucasagomes | done | 16:18 |
| lucasagomes | :) | 16:18 |
| jroll | lucasagomes: hmm, is that an ironic or a neutron issue? | 16:18 |
| NobodyCam | lucasagomes: is that what lifeless' patches address.. I have not looked | 16:18 |
| dtantsur | oh I remember having an etherpad with candidates, need to recover | 16:18 |
| lucasagomes | jroll, ironic | 16:18 |
| devananda | fwiw, i'm going to be afk for a lot of today and probably tomorrow as well | 16:18 |
| lucasagomes | someone we landed with the previous uefi patch | 16:18 |
| lucasagomes | that is causing some races in the tests | 16:18 |
| devananda | lots of things to catch up on -- apparently i got two offers on my house while I was away | 16:19 |
| NobodyCam | devananda: ack | 16:19 |
| jroll | dtantsur: https://etherpad.openstack.org/p/IIe0cnnJ5L | 16:19 |
| NobodyCam | oh wow | 16:19 |
| jroll | lucasagomes: huh, that's odd | 16:19 |
| jroll | lucasagomes: afaik that just hits neutron for an IP | 16:19 |
| lucasagomes | NobodyCam, I don't think so... lifeless has some patches for tox to redirect the output and one for the hash ring right? | 16:20 |
| jroll | lucasagomes: unless there's a race in get_dchp_provider() | 16:20 |
| lucasagomes | NobodyCam, will take a look | 16:20 |
| jroll | lucasagomes: lifeless' stuff is unrelated I think | 16:20 |
| lucasagomes | jroll, yeah... that happens on master | 16:20 |
| NobodyCam | lucasagomes: I may be wrong ... I was not following lifeless convo last night | 16:20 |
| lucasagomes | jroll, do for i in {1..20}; do testr run --parallel; done > /tmp/output.txt | 16:20 |
| lucasagomes | see if it happens there too | 16:21 |
| jroll | lucasagomes: right... I don't think lifeless' patches are related to this at all | 16:21 |
| lucasagomes | jroll, ack yeah I will double check just in case | 16:21 |
| lucasagomes | but i don't think so too | 16:22 |
| jroll | heh, ok | 16:22 |
| *** bandicot has joined #openstack-ironic | 16:26 | |
| jroll | can I please have CI on the agent driver? :( | 16:26 |
| jroll | so much pushback / lack of care going on | 16:27 |
| NobodyCam | jroll: sure just set it up | 16:27 |
| NobodyCam | lol | 16:27 |
| NobodyCam | :( | 16:27 |
| jroll | -.- | 16:27 |
| jroll | we've been working on it for 6 weeks | 16:27 |
| * NobodyCam makes mo coffee | 16:27 | |
| devananda | jroll: what's the blocker on agent CI ? | 16:27 |
| jroll | people don't read emails, and then wait a month to review things | 16:28 |
| jroll | devananda: getting things merged | 16:28 |
| devananda | jroll: merged in tempest? devstack? ironic? | 16:28 |
| jroll | devananda: we were close... and then someone didn't like a thing | 16:28 |
| *** bandicot is now known as bensonmiller | 16:28 | |
| jroll | so we fixed a thing, and been pinging, and still nothing | 16:28 |
| jroll | infra/config and devstack | 16:28 |
| devananda | jroll: there is increasing support (and need) for in-project functional testing (as opposed to in-tempest) | 16:28 |
| jroll | devananda: great, how do you propose ironic handle that? | 16:29 |
| devananda | jroll: ok. perhaps we need to do that ourselves | 16:29 |
| jroll | devananda: and in the meantime, how do I make sure we don't break the agent driver | 16:29 |
| devananda | i'm not sure :) | 16:29 |
| jroll | right | 16:29 |
| devananda | isn't there a way for tempest to support out-of-tree things? | 16:29 |
| jroll | I have no idea | 16:30 |
| devananda | if so - can we add those things either to ironic, or to ipa? we'd stil bottleneck on infra/config though | 16:30 |
| jroll | but this all relies on a devstack environment, no? | 16:30 |
| jroll | like... today you can't even build IPA in devstack | 16:30 |
| jroll | *still* | 16:30 |
| devananda | i see | 16:30 |
| devananda | jroll: you had patches up for that before i left, iirc | 16:31 |
| devananda | not really surprising they haven't landed | 16:31 |
| jroll | devananda: here's where we're at; some things landed | 16:31 |
| jroll | we changed IPA build scripts a bit to support building ramdisks in devstack better | 16:31 |
| jroll | which resulted in this change: https://review.openstack.org/#/c/117384/ | 16:31 |
| jroll | sdague didn't like it, so as suggested we made this change: https://review.openstack.org/#/c/118507/ | 16:32 |
| jroll | can't get him to look at that | 16:32 |
| JayF | that wasn't EXACTLY his suggestion | 16:32 |
| jroll | then we have this, but should change it slightly after 118507 lands: https://review.openstack.org/#/c/114408/ | 16:32 |
| JayF | he wanted us to put a Makefile with an install target inside the tarball with the two files | 16:32 |
| JayF | which I nack'd | 16:32 |
| jroll | JayF: beside the point | 16:32 |
| jroll | devananda: once all that lands, we can land this: https://review.openstack.org/#/c/112693/ | 16:33 |
| jroll | which is dependent on adam_g's changes, which aren't getting love afaik | 16:33 |
| *** greghayn1 is now known as greghaynes | 16:33 | |
| *** scubacuda has joined #openstack-ironic | 16:33 | |
| devananda | sure | 16:33 |
| devananda | things are slow | 16:33 |
| devananda | everyone is bottlenecked of infra & qa | 16:33 |
| jroll | right | 16:33 |
| jroll | the hard part is, we laid out a plan on the mailing list 6 weeks ago | 16:34 |
| devananda | it's terribly frustrating and there have been a ton of discussions in the past few months on solving it | 16:34 |
| jroll | and *now* we're being told our plan sucks | 16:34 |
| devananda | yep | 16:34 |
| devananda | hey, 6 weeks for negative feedback is actually kinda fast around here | 16:34 |
| JayF | By admission a large # of infra folks said they didn't read the email until I pasted a link to it a month later | 16:34 |
| jroll | and we're goign to release juno 3 (and maybe juno final) with a driver that should have CI but doesn't | 16:34 |
| devananda | and i'm only being slightly sarcastic | 16:34 |
| JayF | then things are too damn slow around here | 16:34 |
| JayF | and I'm being 100% serious | 16:34 |
| jroll | (as opposed to the drivers that CI is much harder on) | 16:34 |
| jroll | devananda: yeah, sadface | 16:34 |
| devananda | i know | 16:35 |
| devananda | everyone's frustrated by this and we all disagree on the solution | 16:35 |
| devananda | we == TC | 16:35 |
| jroll | yeah | 16:35 |
| jroll | it would literally be easier for me to set up an entire ironic environment at this point and do third-party CI | 16:36 |
| jroll | s/easier/less frustrating/ | 16:36 |
| jroll | (assuming I could convince someone to give me a rack) | 16:36 |
| JayF | jroll: here, have a rack | 16:37 |
| * jroll ironic delete $(nodes_in_rack_x) | 16:38 | |
| lucasagomes | :P | 16:38 |
| devananda | :) | 16:38 |
| devananda | jroll: i assume you've chatted at some point with sdague and/or mtreinish about ^ ? | 16:39 |
| jroll | chatted with sdague about his -1 | 16:40 |
| jroll | he wants us to have a 'make install' target in the ipa tarball | 16:40 |
| *** vdrok is now known as vdrok_afk | 16:40 | |
| jroll | others helped us come to a slightly better solution | 16:41 |
| jroll | and we haven't been able to get a hold of him since | 16:41 |
| devananda | jroll: when next you get his attention, esp. if it's before I am able to, you may want to chat about in-project testing | 16:43 |
| jroll | I would love to do in project testing | 16:44 |
| jroll | but I think that will be a bigger effort | 16:44 |
| devananda | like, how we can get IPA testing done w/o blocking on landing changes in devstack & tempest | 16:44 |
| devananda | maybe. but maybe getting us to approve the patches is easier :) | 16:44 |
| jroll | right | 16:44 |
| jroll | although | 16:44 |
| jroll | right now I can't verify that it works at all | 16:45 |
| jroll | so how do I verify our in-project tests are correct? :) | 16:45 |
| devananda | heh | 16:45 |
| devananda | off topic, take a look at daniel berrange's latest email (6hr ago) | 16:46 |
| devananda | "averting the nova crisis" | 16:46 |
| jroll | yeah, I read most... got distracted | 16:47 |
| devananda | given all the work we've collectively put in to getting the ironic driver in nova.... | 16:48 |
| jroll | lol | 16:49 |
| *** viktors is now known as viktors|afk | 16:50 | |
| jroll | devananda: I think it would actually help - we'd have core power on our driver, a stable driver api, and voting(?) CI on nova changes | 16:50 |
| *** derekh has quit IRC | 16:51 | |
| devananda | yep | 16:52 |
| Nisha | lucasagomes: Thanks for the review for https://review.openstack.org/#/c/118578 | 16:53 |
| devananda | Nisha: wanyen: hi! Juno-3 milestone has been tagged and we are enterring feature freeze. Your UEFI blueprint - https://blueprints.launchpad.net/ironic/+spec/uefi-boot-for-ironic - is the only one that was approved but has not yet landed | 16:54 |
| Nisha | devananda: hi, Yes i was reading the chat when it was going on. We are trying to get that in asap | 16:55 |
| devananda | I think it's actually really amazing how well ya'll worked with the core team and were able to land all but one already | 16:55 |
| devananda | and now that I'm a little mroe awake, I actually don't feel there's any benefit to jumping through the mailing list hoops | 16:55 |
| devananda | (if we had several FFE's, I would want to) | 16:55 |
| NobodyCam | :) | 16:56 |
| devananda | please continue to focus on this and work with the core review team to land it ASAP | 16:56 |
| devananda | if it's not landed by next friday (12 September) we'll have to bump it until Kilo | 16:57 |
| Nisha | lucasagomes: for your comments on https://review.openstack.org/#/c/118578 , there is one method set_persistent_boot_device() which is not there in https://review.openstack.org/#/c/116561. Do we want to move that too to the common place? | 16:57 |
| Nisha | devananda: We will make sure to land it before next Friday | 16:58 |
| lucasagomes | nidpanov, set_peristent_boot_device should be part of the management interface | 16:59 |
| *** sirushti has left #openstack-ironic | 16:59 | |
| lucasagomes | ops | 16:59 |
| lucasagomes | Nisha, ^ | 16:59 |
| lucasagomes | there's a TODO there to put it in the ManagementInterface later | 16:59 |
| lucasagomes | so I would just leave in ilo_common | 16:59 |
| nidpanov | lucasagomes, I strongly disagree with everything you said :P | 16:59 |
| lucasagomes | and also it's common to other drivers, it's ilo specific | 16:59 |
| NobodyCam | :O | 16:59 |
| lucasagomes | nidpanov, hah | 16:59 |
| Nisha | lucasagomes: :) | 17:01 |
| lucasagomes | Nisha, I'll have to go now :( still gotta catch the train back home | 17:01 |
| lucasagomes | but leave the comments on the patch and I will look it later at home | 17:01 |
| NobodyCam | have a good night lucasagomes | 17:01 |
| Nisha | lucasagomes: Yes sure | 17:01 |
| lucasagomes | have a good night everybody | 17:01 |
| Nisha | Good Night lucasagomes | 17:01 |
| lucasagomes | Nisha, ta much! | 17:01 |
| lucasagomes | good night | 17:01 |
| *** lucasagomes has quit IRC | 17:03 | |
| jroll | any reason we can't approve https://review.openstack.org/#/c/116772/ ? | 17:05 |
| jroll | mrda is aware of it | 17:05 |
| jroll | and that's actually backporting nova changes to ironic | 17:05 |
| *** Nisha has quit IRC | 17:05 | |
| * NobodyCam looking now | 17:06 | |
| *** lazy_prince is now known as killer_prince | 17:06 | |
| NobodyCam | did lifeless say somehting that the canonicalize will break tripleo? | 17:08 |
| jroll | well | 17:09 |
| jroll | it will until scheduler canonicalizes things | 17:10 |
| jroll | which is in review | 17:10 |
| boris-42 | NobodyCam jroll hi there | 17:10 |
| NobodyCam | morning (or correct time of day) boris-42 | 17:10 |
| jroll | NobodyCam: and when that change lands, it will break tripleo the other way | 17:10 |
| jroll | hi boris-42 | 17:11 |
| jroll | NobodyCam: so realistically they need to land at the same time | 17:11 |
| boris-42 | NobodyCam jroll morning =) | 17:11 |
| boris-42 | NobodyCam jroll so there is short blogpost | 17:11 |
| boris-42 | NobodyCam jroll about osprofiler http://ahsalkeld.wordpress.com/2014/09/04/how-to-profile-heat-using-osprofile/ | 17:11 |
| NobodyCam | jroll: you have sched patch ur handy | 17:11 |
| jroll | NobodyCam: https://review.openstack.org/#/c/109590/11/nova/scheduler/filters/image_props_filter.py | 17:11 |
| *** pelix has quit IRC | 17:12 | |
| jroll | NobodyCam: and that is approved :O | 17:12 |
| boris-42 | NobodyCam jroll you can take a look to better understand how to use it and what you'll get | 17:12 |
| jroll | boris-42: 2 hours after feature freeze is a great time to discuss new features :| | 17:12 |
| NobodyCam | oh that is approved | 17:12 |
| boris-42 | jroll NobodyCam crap =( | 17:12 |
| boris-42 | jroll NobodyCam in any moment during cycle it was not a good time.. | 17:12 |
| NobodyCam | with no dependencies | 17:13 |
| jroll | boris-42: right, without a spec, it's never a good time for a feature | 17:13 |
| jroll | boris-42: which projects did this land in? | 17:14 |
| boris-42 | jroll I won't make bureacraccy | 17:14 |
| boris-42 | jroll glance/cinder | 17:14 |
| jroll | boris-42: did they ask you to write a spec? | 17:14 |
| boris-42 | jroll heat is going soon (just after ff stuff) | 17:14 |
| boris-42 | jroll nope they are normal people | 17:14 |
| boris-42 | sry=) | 17:14 |
| boris-42 | jroll even no BP | 17:14 |
| boris-42 | jroll but I have spec | 17:15 |
| boris-42 | jroll https://review.openstack.org/#/c/103825/ | 17:15 |
| boris-42 | jroll in oslo-specs | 17:15 |
| boris-42 | jroll but I won't make it in every project | 17:15 |
| jroll | boris-42: insults aren't a good way to make friends :| | 17:16 |
| jroll | I understand the pain | 17:16 |
| jroll | ironic's ptl asked you to write a spec, you might want to speak with him | 17:16 |
| jroll | thanks for the blog post link, this looks neat | 17:16 |
| boris-42 | jroll I need to drink what with him | 17:16 |
| boris-42 | jroll vodka** | 17:16 |
| boris-42 | =) | 17:16 |
| boris-42 | jroll but really I don't have enough time to write in every project spec and more then I think that it's a bit useless?) | 17:17 |
| boris-42 | jroll btw devananda +1 that spec | 17:17 |
| boris-42 | jroll https://review.openstack.org/#/c/103825/ | 17:17 |
| jroll | ok, good | 17:17 |
| jroll | now it needs code in oslo | 17:17 |
| NobodyCam | oh late bbt brb... | 17:17 |
| boris-42 | jroll there is no code in oslo.. | 17:17 |
| jroll | and then we may be able to pull it in ironic | 17:17 |
| jroll | oh | 17:18 |
| jroll | ok, so | 17:18 |
| boris-42 | jroll in oslo only spec | 17:18 |
| jroll | do you have a change to propose to ironic? | 17:18 |
| boris-42 | jroll nope I'll make after FF (cause now it's not proper time) | 17:18 |
| jroll | ok | 17:18 |
| jroll | so thanks for the blog post | 17:18 |
| boris-42 | jroll np | 17:18 |
| jroll | and I look forward to a patch | 17:19 |
| boris-42 | jroll okay I'll ping you after FF | 17:19 |
| *** harlowja has joined #openstack-ironic | 17:20 | |
| jroll | thanks :) | 17:21 |
| jroll | boris-42: you're always welcome to propose code now, it just won't land | 17:21 |
| * jroll is curious to see it | 17:21 | |
| boris-42 | jroll yep I will just some busy days in Rally =( | 17:21 |
| boris-42 | jroll so not able to do today=) | 17:21 |
| jroll | sure, no worries | 17:22 |
| *** linggao has joined #openstack-ironic | 17:24 | |
| *** athomas has quit IRC | 17:25 | |
| devananda | before i left, rally was caught in a heated discussion with the TC | 17:30 |
| devananda | osprofiler in and of itself is less contentious, but how it is consumed, and what the intent is (eg, rally) is where things were stuck | 17:30 |
| NobodyCam | jroll: commented on and +2'd https://review.openstack.org/#/c/116772 | 17:31 |
| devananda | i haven't caugh tup on that yet since being back for <24 hours | 17:31 |
| jroll | devananda: yeah, I haven't been tracking that | 17:31 |
| devananda | boris-42: and honestly, it doesn't seem important right now.. AFAIK, no one besides you has come to the team asking for osprofiler support | 17:31 |
| devananda | someone please correct me if there have been requests for it while I was away | 17:32 |
| jroll | well | 17:32 |
| jroll | there's currently a single production deployment of ironic, afaik | 17:32 |
| jroll | and that team has not asked for profiling :) | 17:32 |
| jroll | s/profiling/osprofiler/ | 17:32 |
| * jroll points at the statsd patches | 17:32 | |
| devananda | jroll: right - ya'll awnt profiling, but through statsd :) | 17:33 |
| jroll | right | 17:33 |
| jroll | stacktach may also be relevant, not sure | 17:33 |
| boris-42 | jroll stacktach won't give you such nested cross service/project stuff | 17:34 |
| boris-42 | devananda hm honestly I don't know how to develop such distributed systems like openstack without osprofiler | 17:34 |
| boris-42 | devananda and nobody didn't asked it, cause nobody (in ironic world) knows about how it works and what they can get | 17:35 |
| * devananda goes afk for a while | 17:35 | |
| jroll | I don't know much about stacktach, but it's already deployed widely within my environment, and I don't see that switching to osprofiler soon | 17:36 |
| boris-42 | jroll there is no switching to osprofiler.. | 17:36 |
| boris-42 | jroll if you have it and have ceilometer it works | 17:36 |
| jroll | we don't have ceilometer | 17:36 |
| jroll | and don't want ceilometer | 17:37 |
| boris-42 | jroll so maybe I should talk with sandywalsh | 17:37 |
| boris-42 | jroll next summit about integrating osprofiler with stacktach | 17:38 |
| jroll | sure | 17:38 |
| boris-42 | jroll in any case in local development by devstack | 17:38 |
| jroll | that's a great idea | 17:38 |
| jroll | devstack is nothing like the real world | 17:38 |
| boris-42 | jroll you know | 17:39 |
| boris-42 | jroll it already shows on single node installation | 17:39 |
| boris-42 | jroll that openstack won't scale | 17:39 |
| *** dtantsur is now known as dtantsur|afk | 17:39 | |
| boris-42 | jroll just taking look on amount of rpc/db stuff and other stuff | 17:39 |
| jroll | we've certainly been able to scale openstack | 17:39 |
| NobodyCam | jroll: are you going to +a 116772? | 17:39 |
| boris-42 | jroll like every GET /v2.0/tokens run 25 DB requests | 17:40 |
| *** rushiagr_away is now known as rushiagr | 17:40 | |
| jroll | boris-42: I didn't say it was fast :) | 17:40 |
| boris-42 | jroll =) | 17:40 |
| jroll | NobodyCam: yeah, I think so, one sec | 17:40 |
| boris-42 | jroll but I mean on single node with devstack installation you can understand | 17:40 |
| jroll | NobodyCam: although the point Jay raised the other day still stands, I think | 17:40 |
| boris-42 | jroll how heavy requests are | 17:40 |
| boris-42 | jroll and refactor them | 17:40 |
| boris-42 | jroll if it's required | 17:41 |
| jroll | boris-42: sure, I'm not fighting against osprofiler here anyway | 17:41 |
| boris-42 | jroll ok great=) I am just making sure that we are on the same page=) | 17:41 |
| NobodyCam | jroll: but like he pointed out "I don't see any other alternatives" | 17:47 |
| jroll | right... | 17:48 |
| rloo | hmm, dan smith +2 and +A'd two of the patches. I guess they won't actually get merged cuz 1&2 haven't been +A'd | 17:48 |
| NobodyCam | maybe add to docs with that patch and add #doc impact tag | 17:48 |
| jroll | NobodyCam: I'm fine with that because this was my original solution :P | 17:48 |
| jroll | not too worried about docs | 17:49 |
| jroll | could file a docs bug | 17:49 |
| jroll | or something | 17:49 |
| jroll | I think the docimpact tag would need to be on the nova review anyway | 17:49 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/119141 | 17:49 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/114058 | 17:49 |
| NobodyCam | oh will this break our migration scripts? | 17:50 |
| jroll | NobodyCam: +A | 17:50 |
| jroll | gah | 17:50 |
| jroll | I doubt it? | 17:50 |
| * jroll looks at scripts | 17:50 | |
| jroll | I kind of doubt it | 17:50 |
| jroll | NobodyCam: cpu_arch is an argument to migration scripts, so people just need to make sure that's a valid arch when they run it | 17:51 |
| NobodyCam | nice :) most featureful | 17:53 |
| NobodyCam | milestone in Ironic's history | 17:53 |
| jroll | \o/ | 17:53 |
| NobodyCam | jroll: sweet | 17:53 |
| NobodyCam | :) | 17:53 |
| NobodyCam | x86_32 is now vaild arch | 17:53 |
| NobodyCam | lol | 17:53 |
| jroll | rloo: about the patches, plan is to land all of them at once | 17:54 |
| jroll | lol x86_32 | 17:55 |
| rloo | jroll, that's what I thought. Maybe Dan knows, maybe not, or knows that his +A is ok cuz the patch won't land w/o the ones before it | 17:55 |
| jroll | we discussed the process in the nova meeting this morning, everyone is aware :) | 17:56 |
| jroll | any opposition to me proposing an ironic fix for this? https://review.openstack.org/#/c/111429/22/nova/virt/ironic/driver.py | 17:59 |
| rloo | so there's a -1 on https://review.openstack.org/#/c/111429/. Should we propose a patch in ironic tree for mrda, or leave it for mrda? | 17:59 |
| jroll | that's what I just asked, I think I might just do it | 18:00 |
| rloo | jroll, just what I was asking. | 18:00 |
| rloo | jroll, yeah, please go for it | 18:00 |
| jroll | k | 18:00 |
| rloo | mrda thanks you jroll :) | 18:00 |
| jroll | :P | 18:01 |
| rloo | although the other 2 patches haven't been merged into our tree yet. not sure how he can keep track of it all. | 18:01 |
| jroll | they've been merged into nova patches | 18:02 |
| rloo | right. just not into our ironic tree. | 18:02 |
| jroll | right | 18:02 |
| jroll | which is fine, as long as they go eventually | 18:02 |
| rloo | yeah, w/o merge/rebase conflicts | 18:03 |
| jroll | yeah, it'll be fine | 18:03 |
| NobodyCam | wont the whole nova tree be removed from our repo as soon as it lands? | 18:05 |
| jroll | yes | 18:05 |
| NobodyCam | so backporting into our tree is for testing? | 18:05 |
| NobodyCam | never mind | 18:06 |
| NobodyCam | i'm in left field | 18:06 |
| * NobodyCam makes some comment about danddy lions and muttles off | 18:07 | |
| jroll | heh | 18:07 |
| NobodyCam | haha had to refresh me screen now I see dan comment | 18:18 |
| NobodyCam | :-p | 18:18 |
| NobodyCam | jroll: are you working the patch for it? | 18:18 |
| jroll | NobodyCam: I am, I thought it was just that one instance, but there are many | 18:19 |
| jroll | should have something in 10 | 18:19 |
| NobodyCam | you roc :) | 18:19 |
| *** eghobo has quit IRC | 18:23 | |
| *** eghobo has joined #openstack-ironic | 18:23 | |
| NobodyCam | nova patch #7 has a bunch of ./nova/virt/ironic/driver.py:285:20: F821 undefined name '_' pep8 errorrs | 18:26 |
| jroll | huh, weird | 18:30 |
| jroll | did they stop patching builtins too? | 18:30 |
| jroll | and why don't those show up in other sets | 18:30 |
| NobodyCam | could be a recent change and other patches just havn't been rechecked? | 18:31 |
| *** rloo has left #openstack-ironic | 18:31 | |
| jroll | maybe | 18:31 |
| *** rloo has joined #openstack-ironic | 18:31 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Fix comments from 111429 https://review.openstack.org/119165 | 18:36 |
| jroll | NobodyCam: ^^ | 18:37 |
| NobodyCam | lgtm should we put the link to the patch rev with the comment like the other patchs | 18:39 |
| jroll | yeah, will do | 18:40 |
| jroll | I already poked dan | 18:40 |
| NobodyCam | ie:) | 18:40 |
| NobodyCam | s/ie// | 18:40 |
| wanyen | Deva, I received UEFI blueprint update about granting FFE till 09/12. Is this offical or do I need to go through FFE application process? | 18:43 |
| jroll | wanyen: he approved it in irc | 18:44 |
| jroll | 16:56:46 devananda | please continue to focus on this and work with the core review team to land it ASAP | 18:44 |
| jroll | 16:57:07 devananda | if it's not landed by next friday (12 September) we'll have to bump it until Kilo | 18:44 |
| jroll | (with nisha) | 18:44 |
| wanyen | jroll, great! Thanks for the approval. | 18:45 |
| jroll | :) | 18:45 |
| jroll | NobodyCam: dan smith also wants a follow-up patch to change object attr access from dict['style'] to object.style | 18:46 |
| jroll | going to do that real quick | 18:46 |
| NobodyCam | jroll: ack :) | 18:47 |
| jroll | although... should do that in ironic first? or no? | 18:47 |
| jroll | I'm thinking no... | 18:47 |
| jroll | but that might give mrda ulcers | 18:47 |
| NobodyCam | yea I say put up for Ironic and we can point mrda to it | 18:48 |
| jroll | ok | 18:48 |
| jroll | we have three nova driver patches in ironic right now | 18:48 |
| jroll | so I can't depend on them :| | 18:48 |
| NobodyCam | welll lets land um | 18:48 |
| NobodyCam | :) | 18:48 |
| jroll | heh | 18:49 |
| jroll | maybe I should step away for a bit while that happens :) | 18:49 |
| NobodyCam | jroll: it is near lunch time | 18:49 |
| NobodyCam | :-p | 18:49 |
| jroll | yep | 18:49 |
| jroll | and I have a meeting at 1, so | 18:49 |
| openstackgerrit | A change was merged to openstack/ironic: Nova review updates for _node_resource https://review.openstack.org/116772 | 18:50 |
| *** pcrews has quit IRC | 18:51 | |
| NobodyCam | jroll: down to two ^^^^ | 18:53 |
| jroll | whee | 18:54 |
| greghaynes | lifeless: left you a comment on https://review.openstack.org/#/c/118932/ | 18:58 |
| greghaynes | I think its not actually a new issue if im correct, so feel free to say you want to charge ahead anyways | 18:58 |
| NobodyCam | brb | 19:02 |
| *** eghobo has quit IRC | 19:03 | |
| lifeless | greghaynes: replied | 19:06 |
| greghaynes | ah! | 19:06 |
| openstackgerrit | lifeless proposed a change to openstack/ironic: Fix hash ring stability https://review.openstack.org/118932 | 19:06 |
| greghaynes | ok, so another thing that made me think - does this mean my patch to add an index for conductor for each node in the db actually needs to be a store multiple conductors due to replication? | 19:07 |
| *** eghobo has joined #openstack-ironic | 19:08 | |
| lifeless | no | 19:08 |
| lifeless | at the moment the fallback replicas are entirely passive | 19:08 |
| lifeless | we just need to detect which nodes have had their primary replica go away/offline/fail | 19:09 |
| *** eghobo has quit IRC | 19:09 | |
| greghaynes | ok *relief* | 19:09 |
| *** eghobo has joined #openstack-ironic | 19:10 | |
| Shrews | adam_g: omg, 112660 finally in the gate | 19:11 |
| adam_g | Shrews, *fingers crossed* | 19:13 |
| *** adam_g has left #openstack-ironic | 19:13 | |
| *** adam_g has joined #openstack-ironic | 19:13 | |
| *** penick has joined #openstack-ironic | 19:30 | |
| *** bigjools has quit IRC | 19:34 | |
| *** bigjools has joined #openstack-ironic | 19:34 | |
| *** bigjools has quit IRC | 19:35 | |
| *** bigjools has joined #openstack-ironic | 19:35 | |
| jroll | adam_g: anything I can help with on https://review.openstack.org/#/c/112134/ | 19:35 |
| adam_g | jroll, lemme dust it off and see if i can get some infra eyes on it | 19:38 |
| *** datajerk has joined #openstack-ironic | 19:38 | |
| jroll | adam_g: ok, I don't expect to need it super soon, but I have a patch depending on it | 19:38 |
| jroll | adam_g: I mean, I want my patch in asap, I just expect slowness at this point | 19:38 |
| *** rushiagr is now known as rushiagr_away | 19:39 | |
| adam_g | jroll, yea.. :| | 19:39 |
| *** datajerk has quit IRC | 19:42 | |
| *** pcrews has joined #openstack-ironic | 19:46 | |
| *** penick has quit IRC | 19:46 | |
| jroll | JayF: we have sdague happy \o/ | 19:48 |
| Shrews | SpamapS: ping | 19:49 |
| SpamapS | Shrews: pong, wassup? | 19:53 |
| Shrews | SpamapS: for https://bugs.launchpad.net/ironic/+bug/1362733, was it the ironic node state that was stuck in ERROR, or the nova instance? | 19:54 |
| *** penick has joined #openstack-ironic | 19:54 | |
| SpamapS | Shrews: the nova instance | 19:55 |
| Shrews | hrm | 19:55 |
| SpamapS | Shrews: ironic was accurate IIRC | 19:55 |
| Shrews | SpamapS: thx for the clarification | 19:55 |
| SpamapS | could be wrong tho. ;) | 19:55 |
| SpamapS | does Ironic have a fake driver where you could write a test that doesn't need metal or vms? | 19:55 |
| Shrews | depends on what you want to test | 19:57 |
| Shrews | some of our fake drivers use real power drivers and such, which boggles my mind | 19:58 |
| rloo | linggao: you around? | 20:03 |
| linggao | Hi rloo, yes | 20:03 |
| rloo | linggao: hi. i just reviewed 97331. | 20:04 |
| rloo | linggao: I can't decide if I should +2/approve, and ask you to fix in a subsequent patch, or -1. | 20:04 |
| linggao | let me check... | 20:05 |
| rloo | linggao: I want to try to be consistent with how we've handled other patches, but I'm not sure I know what that might be. | 20:05 |
| linggao | are you talking about ConsoleSubprocessFailed? | 20:06 |
| *** andreykurilin_ has joined #openstack-ironic | 20:06 | |
| rloo | linggao: yes | 20:06 |
| linggao | rloo, it is a subclass of ConsoleError, so I just put ConsoleError there. | 20:07 |
| rloo | linggao: ahh. ok, then it isn't a blocker. | 20:08 |
| linggao | rloo, thanks for reviewing it. | 20:08 |
| rloo | linggao: ok, approved. | 20:11 |
| linggao | thank you rloo :-) | 20:11 |
| *** nidpanov has quit IRC | 20:15 | |
| *** eghobo has quit IRC | 20:17 | |
| openstackgerrit | Andrey Kurilin proposed a change to openstack/ironic: Use models.TimestampMixin from oslo.db https://review.openstack.org/119195 | 20:23 |
| *** penick has quit IRC | 20:23 | |
| Shrews | ugh. that feeling when you been tracking a non-existent failure and realized you mistyped a command | 20:26 |
| Shrews | s/command/command option/ | 20:26 |
| *** bensonmiller has quit IRC | 20:35 | |
| *** igordcard has joined #openstack-ironic | 20:35 | |
| *** pcrews has quit IRC | 20:36 | |
| *** eghobo has joined #openstack-ironic | 20:39 | |
| *** linggao has quit IRC | 20:45 | |
| mrda1 | Morning Ironic | 20:52 |
| *** mrda1 is now known as mrda | 20:53 | |
| rloo | morning mrda | 20:53 |
| rloo | mrda: we left some things for you to figure out ;) | 20:54 |
| mrda | oh? | 20:54 |
| mrda | rloo: I take it you saw the message I left in channel | 20:54 |
| rloo | mrda: yup. i sent you email about it. | 20:54 |
| * mrda hasn't got to email yet | 20:55 | |
| mrda | ok, the use of six | 20:55 |
| mrda | str(exception) gives a pep8 failure in Nova | 20:55 |
| mrda | and moving away from NovaException for a hard fail | 20:56 |
| rloo | mrda: oh, interesting. will it get backported to our tree then? I guess it doesn't have to, but it was confusing to me. | 20:56 |
| rloo | mrda: but not confusing any more cuz I know now ;) | 20:56 |
| jroll | mrda: heya :) | 20:56 |
| mrda | NoveException will cause a reschedule, which isn't appropriate for an unrecoverable fail | 20:57 |
| rloo | mrda: yeah, I figured that out about NovaException. I was thinking a comment would be nice, but I only *thought* it. | 20:57 |
| rloo | mrda. jroll has a present for you. | 20:57 |
| jroll | I do I do | 20:57 |
| mrda | So I did discuss both in channel at the time with Ironic cores, but because they were trivial, I just did them in the Nova tree. They should be back ported into Ironic. They were just just lower down on the priuority list :) | 20:57 |
| jroll | mrda: https://review.openstack.org/#/c/119165 | 20:58 |
| mrda | hey jroll | 20:58 |
| jroll | mrda: I guess I have some rloo nits to fix :) | 20:58 |
| rloo | btw jroll, sorry about the nits. There's really just one that might be more than a nit. | 20:58 |
| jroll | yeah | 20:58 |
| jroll | agree :) | 20:58 |
| mrda | jroll: cool, even though this will kick some +2's in the head | 20:59 |
| mrda | I'll port this back into Nova after breakfast | 21:00 |
| jroll | no worries | 21:00 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Fix comments from 111429, rev 22 https://review.openstack.org/119165 | 21:00 |
| jroll | mrda: dansmith -1'd it | 21:00 |
| jroll | mrda: this is the first patch that didn't have 2x +2 | 21:00 |
| jroll | rloo: ^^ fixed | 21:00 |
| openstackgerrit | A change was merged to openstack/ironic: Interactive console support for ipminative driver https://review.openstack.org/97331 | 21:01 |
| mrda | So it appears I missed the nova meeting 6 hourts ago. Did anyone go? | 21:01 |
| mrda | (only because the Nova Meeting wiki was out of date) | 21:01 |
| mrda | rloo: Again I'm sorry about not back-porting those two changes earlier, it's always been my intention of keeping the trees in sync as much as possible | 21:03 |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Draft a 'pxe_logpower' driver https://review.openstack.org/98950 | 21:04 |
| rloo | mrda: NobodyCam was there, and jroll maybe (not sure if he was just lurking or what) | 21:04 |
| NobodyCam | sorry was off doing something else | 21:04 |
| NobodyCam | I am here | 21:04 |
| rloo | mrda: it is in irc if you scroll back. but we have a FFE | 21:04 |
| jroll | mrda: we got an ffe | 21:04 |
| mrda | cool, I should have just stayed up another 2 hours :) | 21:04 |
| mrda | \o/ | 21:04 |
| jroll | dansmith, jogo, and danpb sponsoring | 21:04 |
| NobodyCam | mrda: 14:16 | johnthetubaguy > #info ironic gets FFE dansmith jogo danpb | 21:05 |
| mrda | So all my IRC canvassing worked yesterday! | 21:05 |
| NobodyCam | :) | 21:05 |
| mrda | So we're only 3 x +2's away from landing | 21:06 |
| mrda | That's not bad out of a required 14 | 21:06 |
| jroll | woot | 21:06 |
| *** pcrews has joined #openstack-ironic | 21:09 | |
| rloo | ok, I'll happy with https://review.openstack.org/#/c/119165/ now ;) | 21:09 |
| rloo | Shrews: do you want to bless 119165 again? (my fault of course) | 21:10 |
| Shrews | rloo: if that would please you :) | 21:11 |
| rloo | Shrews: yes, so I won't feel so guilty ;) | 21:11 |
| NobodyCam | jroll: line 646 of https://review.openstack.org/#/c/119165/2/ironic/nova/tests/virt/ironic/test_driver.py | 21:12 |
| NobodyCam | mock_flavor.assert_called_once() | 21:12 |
| mrda | yeah that's a big uggh | 21:12 |
| mrda | self.assertEqual(1, mock_flavor.call_count) is better I think | 21:13 |
| jroll | NobodyCam: yesh? | 21:13 |
| jroll | that asserts called exactly once | 21:13 |
| Shrews | NobodyCam: ah, good catch | 21:13 |
| jroll | like | 21:13 |
| rloo | what's wrong with that? | 21:13 |
| jroll | wait, you want me to remove the `_with` part? | 21:13 |
| NobodyCam | no need for _with() | 21:13 |
| Shrews | assert_called_once() does not exist, no? | 21:14 |
| * mrda didn't realise there was a version without the _with | 21:14 | |
| jroll | I mean, it does the same thing | 21:14 |
| jroll | they both exist | 21:14 |
| jroll | this one asserts it was called with no args, though :) | 21:14 |
| Shrews | jroll: are you sure? you can call anything you want on a mock object... i'm pretty sure i've made that exact error before | 21:14 |
| jroll | Shrews: I'm sure | 21:14 |
| * jroll looks for docs | 21:14 | |
| NobodyCam | jroll: line 55 of https://review.openstack.org/#/c/98950/5/ironic/tests/drivers/test_logpower.py | 21:14 |
| jroll | oh, maybe it doesn't, idk | 21:15 |
| Shrews | http://mock.readthedocs.org/en/latest/mock.html#mock.Mock.assert_called_once_with | 21:15 |
| jroll | NobodyCam: eh? | 21:15 |
| jroll | btw | 21:15 |
| jroll | I'm in a meeting | 21:15 |
| NobodyCam | oh | 21:15 |
| NobodyCam | sorrry | 21:15 |
| NobodyCam | :-p | 21:15 |
| jroll | NobodyCam: but, what's your question | 21:15 |
| jroll | I don't like this logpower driver anyhow | 21:16 |
| NobodyCam | I pointed out the _with() not needed thats all | 21:16 |
| NobodyCam | lol (nor I) | 21:16 |
| Shrews | NobodyCam: it *is* needed | 21:16 |
| mrda | Shrews: why? | 21:16 |
| Shrews | you can call mock.some_funky_nonexisting_method() and it will work | 21:17 |
| mrda | does it test no params? | 21:17 |
| Shrews | mrda: it's not valid | 21:17 |
| Shrews | see link above | 21:17 |
| * mrda needs coffee | 21:17 | |
| NobodyCam | oh | 21:17 |
| NobodyCam | (in best gilda ratener voice) Never Mind | 21:18 |
| rloo | so who wrote that test_logpower.py code? | 21:18 |
| NobodyCam | lol | 21:18 |
| rloo | NobodyCam just wanted us to review his stuff ;) | 21:19 |
| NobodyCam | no no | 21:19 |
| NobodyCam | I hacked that up | 21:19 |
| Shrews | ugh, that's used in lots of places | 21:19 |
| NobodyCam | I use it as example that htere is a called_once() method | 21:19 |
| jroll | Shrews: autospec=True will change that, but I see your point | 21:20 |
| * Shrews removes +2 | 21:20 | |
| NobodyCam | so we should file a bug about that | 21:20 |
| *** penick has joined #openstack-ironic | 21:20 | |
| Shrews | oh wait, the new code doesn't add that, does it | 21:22 |
| Shrews | ? | 21:22 |
| Shrews | ok, yeah. so, leaving the +2, but someone should file that bug | 21:22 |
| rloo | Shrews: the code is correct. BUT... | 21:22 |
| Shrews | rloo: the mock call is correct??? | 21:23 |
| rloo | Shrews: I see in ironic tree anyway, that test_driver.py has 2 calls fake_looping_call.wait.assert_called_once() | 21:23 |
| Shrews | yeah | 21:23 |
| Shrews | should we fix them in this review? | 21:24 |
| * Shrews leaves it up to mrda | 21:24 | |
| rloo | to recap, so I get it right. mock.assert_called_once_with() is correct. mock.assert_called_once() is incorrect. | 21:24 |
| mrda | Oh no you don't! | 21:24 |
| NobodyCam | well | 21:24 |
| Shrews | rloo: that is correct | 21:25 |
| NobodyCam | I use called_once() when I don't care about args, | 21:25 |
| Shrews | NobodyCam: but that doesn't actually TEST anything | 21:25 |
| Shrews | it's a noop | 21:25 |
| NobodyCam | so I should start using mock.ANY when I don't care | 21:25 |
| *** eghobo has quit IRC | 21:27 | |
| rloo | mrda: line 512 is somewhat incorrect: https://review.openstack.org/#/c/119165/2/ironic/nova/tests/virt/ironic/test_driver.py | 21:27 |
| *** eghobo has joined #openstack-ironic | 21:27 | |
| rloo | mrda: as is line 1092 | 21:28 |
| mrda | rloo: cool, thanks. I'll fix it on the way into Nova | 21:28 |
| Shrews | NobodyCam: that, or use mrda's suggestion using call_count | 21:28 |
| rloo | mrda: but I think that nova driver patch was approved. | 21:28 |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Draft a 'pxe_logpower' driver https://review.openstack.org/98950 | 21:28 |
| mrda | if it's in code I can touch without removing a +2 I'll do it | 21:28 |
| rloo | mrda: yeah, otherwise, it can be fixed later. I hope you're keeping track of them. | 21:29 |
| mrda | Anything I've said we'll fix later I'm raising as a bug | 21:29 |
| rloo | fwiw, I see two instances in nova tests that are wrong. | 21:29 |
| rloo | so it isn't only us ;) | 21:30 |
| NobodyCam | mrda: awesome :) thank you for the tracking bugs | 21:30 |
| mrda | well, raising them :) | 21:30 |
| rloo | mrda: ah, so you can just open a bug that there are tests in nova that use assert_called_once(). don't need to call out only ironic code. | 21:30 |
| mrda | right, that's better | 21:31 |
| mrda | and more complete :) | 21:31 |
| NobodyCam | i supect many project have it | 21:31 |
| * mrda starts porting in 119165 | 21:31 | |
| rloo | but we still need to fix the other (non driver) cases in our code. I'll open a bug about that on the ironic side. | 21:31 |
| mrda | rloo: thank you | 21:32 |
| rloo | NobodyCam: wrt 119165, is it still a draft? | 21:32 |
| rloo | mrda: yw. thank YOU ;) | 21:32 |
| mrda | rloo: It has 2x+2's | 21:33 |
| mrda | :) | 21:33 |
| mrda | once from you | 21:33 |
| Shrews | i think rloo meant 98950 | 21:33 |
| rloo | mrda: let's make sure we are talking about the same thing. | 21:33 |
| NobodyCam | 119165 is good to go | 21:33 |
| rloo | mrda: yup, Shrews is right. I copy/pasted the wrong thing. | 21:34 |
| NobodyCam | 98950 yea! i'll mark wip | 21:34 |
| mrda | lol | 21:34 |
| mrda | phew! | 21:34 |
| rloo | mrda: sorry about that. | 21:34 |
| NobodyCam | lol | 21:34 |
| NobodyCam | sorry mrda | 21:34 |
| mrda | I'm not porting that into Nova | 21:34 |
| Shrews | mrda: you'll do it and you'll like it!!!! | 21:34 |
| mrda | lol | 21:34 |
| Shrews | hehe | 21:34 |
| *** andreykurilin_ has quit IRC | 21:42 | |
| *** andreykurilin_ has joined #openstack-ironic | 21:43 | |
| openstackgerrit | Andrey Kurilin proposed a change to openstack/ironic: Use models.TimestampMixin from oslo.db https://review.openstack.org/119195 | 21:51 |
| NobodyCam | oh gawd I read 119195 as 119165 and almost cried :-p | 21:52 |
| *** andreykurilin_ has quit IRC | 21:56 | |
| mrda | jroll: https://review.openstack.org/#/c/119165/2/ironic/nova/virt/ironic/driver.py | 21:58 |
| rloo | NobodyCam: I think we all need a break. Although feel free to review 119195. I'm not sure why my name is there as a reviewer. | 21:59 |
| rloo | mrda: good catch. why didn't I see that, sigh. | 22:00 |
| NobodyCam | rloo: reviewed ... well kinda | 22:07 |
| NobodyCam | lol | 22:07 |
| rloo | NobodyCam: thx, better you than me ;) | 22:08 |
| mrda | ok, new driver.py pushed | 22:08 |
| *** chuckC has quit IRC | 22:18 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: mock.assert_called_once() is not valid method https://review.openstack.org/119234 | 22:19 |
| *** foexle_ has quit IRC | 22:26 | |
| lifeless | oh hai | 22:27 |
| lifeless | 10:25 < greghaynes> ObjectActionError: Object action obj_load_attr failed because: unable to load extra_specs | 22:27 |
| lifeless | we're seeing this in our ironic CI jobs | 22:27 |
| greghaynes | https://review.openstack.org/#/c/116772/ look suspicious | 22:28 |
| jroll | mrda: need me to fix that still or did you get it? | 22:28 |
| mrda | I haven't fixed it, but I can | 22:28 |
| jroll | I can | 22:28 |
| jroll | lifeless: got any context? | 22:28 |
| mrda | sure, it's your fix :) | 22:28 |
| greghaynes | https://bugs.launchpad.net/ironic/+bug/1365750 | 22:29 |
| jroll | there you are sir | 22:29 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Fix comments from 111429, rev 22 https://review.openstack.org/119165 | 22:29 |
| jroll | rloo Shrews ^^ | 22:30 |
| jroll | lifeless, greghaynes, I would be looking at this, but it hasn't landed yet: https://review.openstack.org/#/c/118693/4/ironic/nova/virt/ironic/driver.py | 22:32 |
| jroll | oh, wait, I see it | 22:32 |
| jroll | maybe | 22:32 |
| *** penick has quit IRC | 22:33 | |
| jroll | greghaynes, lifeless, that looks more like a broken flavor to me | 22:34 |
| jroll | this is failing: https://github.com/openstack/ironic/blob/master/ironic/nova/virt/ironic/patcher.py#L109 | 22:34 |
| jroll | I don't see why messing with arch would do that | 22:34 |
| *** penick has joined #openstack-ironic | 22:34 | |
| lifeless | jroll: I don't think we've changed our flavor API calls recently. greghaynes ? | 22:35 |
| jroll | greghaynes, lifeless, that said, what is the arch for the failing node, and the failing flavor? | 22:35 |
| jroll | actually, you know what... | 22:35 |
| * jroll looks | 22:35 | |
| lifeless | i386 | 22:35 |
| lifeless | or amd64 | 22:35 |
| greghaynes | not that I know of | 22:35 |
| greghaynes | https://review.openstack.org/#/c/119243/ | 22:35 |
| greghaynes | is a temprevert run | 22:35 |
| jroll | hmm, that might break amd64 | 22:36 |
| jroll | well, both | 22:36 |
| jroll | ok I suspect this patch as well | 22:36 |
| jroll | that said | 22:36 |
| jroll | this patch has been approved and should fix it https://review.openstack.org/#/c/109591/ | 22:36 |
| jroll | for i386 at least | 22:37 |
| jroll | amd64, this one needs to get through: https://review.openstack.org/117555 | 22:37 |
| greghaynes | :/ | 22:37 |
| jroll | it's a patch race that is an unfortunate side effect of being out of tree :( | 22:38 |
| mrda | jroll: you should be pimping that one in Nova | 22:38 |
| jroll | yeah | 22:38 |
| jroll | well, I'd rather someone pimp it for me :P | 22:39 |
| mrda | hmmm, perhaps I should add that as a dependency for 111223 :) | 22:39 |
| jroll | O.O | 22:39 |
| *** cloutedcanine has joined #openstack-ironic | 22:40 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Draft a 'pxe_logpower' driver https://review.openstack.org/98950 | 22:48 |
| jroll | greghaynes: y'all define flavor/node arch in each test run? | 22:49 |
| jroll | or like.. can they be changed? | 22:49 |
| greghaynes | well, anything can be changed ;) | 22:51 |
| greghaynes | whether its a good idea... | 22:52 |
| NobodyCam | 116165 still failing test_clean_up_pxe_config_uefi | 22:52 |
| jroll | I mean, what could it hurt? | 22:52 |
| jroll | NobodyCam: wrong review number :P | 22:52 |
| NobodyCam | jroll: ??? rev 3 | 22:53 |
| jroll | NobodyCam: https://review.openstack.org/#/c/116165 | 22:54 |
| jroll | is what you said | 22:54 |
| jroll | which is a keystonemiddleware change | 22:54 |
| jroll | that has landed | 22:54 |
| jroll | so I don't think it's failing an ironic unit test :) | 22:54 |
| *** cloutedcanine has quit IRC | 22:54 | |
| lifeless | jroll: well, we have deployed users with db's with flavors in them | 22:54 |
| lifeless | jroll: be nice to know that they still work | 22:55 |
| NobodyCam | oh doh | 22:55 |
| NobodyCam | 119165 | 22:55 |
| NobodyCam | its late | 22:55 |
| jroll | lifeless: right, sounds like right now they don't, and with those patches I linked, they will :| | 22:55 |
| jroll | NobodyCam: thanks :P | 22:55 |
| jroll | NobodyCam: I don't see any test failures :/ | 22:56 |
| jroll | NobodyCam: I wonder if we have a transient failure on that test, though, somehow | 22:56 |
| NobodyCam | https://jenkins01.openstack.org/job/gate-ironic-python26/2056/ | 22:56 |
| jroll | gah | 22:57 |
| jroll | I bet there's something not 2.6 compatible in there | 22:57 |
| jroll | but like | 22:57 |
| jroll | how did the change that broke it get through the gate | 22:57 |
| lifeless | is this the one from yesterday? | 22:58 |
| jroll | "the one"? | 22:58 |
| lifeless | pyton26 failure | 22:58 |
| jroll | we landed thousands of LOC yesterday :| | 22:58 |
| jroll | idk what the one from yesterday is | 22:58 |
| NobodyCam | AssertionError: Expected to be called once. Called 0 times. is the error | 22:58 |
| lifeless | yeah | 22:58 |
| lifeless | thats what Shrews was looking at | 22:58 |
| jroll | ah | 22:59 |
| mrda | lol, py26 fails | 22:59 |
| NobodyCam | ahh ok | 22:59 |
| jroll | I'm checking it out locally | 23:01 |
| * NobodyCam would wishes there were more hours in a day. he would love to attend all the hp workshops (as example the latest one: Storage Array Write Optimization Without Initiator Involvement) | 23:07 | |
| NobodyCam | s/would// | 23:07 |
| *** chuckC has joined #openstack-ironic | 23:07 | |
| *** r-daneel has quit IRC | 23:07 | |
| jroll | NobodyCam: btw, py26 passes on master here | 23:21 |
| * jroll tries with that change | 23:21 | |
| jroll | NobodyCam: passed with that change as well | 23:24 |
| jroll | odd | 23:24 |
| NobodyCam | random gate issue? | 23:25 |
| NobodyCam | :( | 23:25 |
| jroll | I guess? | 23:26 |
| jroll | so weird | 23:26 |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Draft a 'pxe_logpower' driver https://review.openstack.org/98950 | 23:26 |
| *** bandicot has joined #openstack-ironic | 23:30 | |
| *** penick has quit IRC | 23:40 | |
| jroll | adam_g: got a minute? | 23:40 |
| adam_g | jrist, hey | 23:40 |
| adam_g | er | 23:40 |
| adam_g | jroll, ya :) | 23:40 |
| jroll | hey, so | 23:41 |
| jroll | I was going to use IMAGE_URLS in stackrc to download the agent ramdisk/kernel and add to glance | 23:41 |
| jroll | right here: https://github.com/openstack-dev/devstack/blob/master/stackrc#L411 | 23:41 |
| jroll | I was going to just set IRONIC_KERNEL_PATH etc there | 23:42 |
| jroll | but what if someone has overridden it? | 23:42 |
| jroll | should I do if [ -z $IRONIC_KERNEL_PATH ] IRONIC_KERNEL_PATH=.. ? | 23:42 |
| adam_g | IRONIC_KERNEL_PATH=${IRONIC_KERNEL_PATH:-"default_path"} ? | 23:43 |
| jroll | well, we do that in lib/ironic already | 23:44 |
| jroll | should I just change that default path? | 23:44 |
| jroll | that might work out | 23:44 |
| jroll | here, specifically: https://github.com/openstack-dev/devstack/blob/master/lib/ironic#L572-578 | 23:45 |
| jroll | it will already be loaded into glance with a different name | 23:45 |
| jroll | so I'll have to special case the glance create thing | 23:45 |
| jroll | this might work... let me post the review and see what you think | 23:45 |
| adam_g | jroll, okay cool. sorry, im not sure i fully understand the issue. my brain is having trouble /w context switches today | 23:46 |
| jroll | heh, no worries | 23:47 |
| NobodyCam | adam_g: disable hyper threading I found it helps | 23:48 |
| adam_g | maybe if i toggle the turbo button | 23:48 |
| NobodyCam | lol | 23:49 |
| *** Haomeng has joined #openstack-ironic | 23:57 | |
| jroll | adam_g: I made it a lot simpler, since the IMAGE_URLS code doesn't understand vmlinuz or cpio.gz: https://review.openstack.org/#/c/117384/ | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!