Tuesday, 2014-09-02

« Monday, 2014-09-01 Index Wednesday, 2014-09-03 »
*** lsmola has quit IRC00:00
*** yuanying has joined #openstack-ironic00:07
*** lsmola has joined #openstack-ironic00:13
*** r-mibu has joined #openstack-ironic00:38
*** nosnos has joined #openstack-ironic01:48
*** Poornima_ has joined #openstack-ironic02:17
*** eghobo has joined #openstack-ironic02:28
*** yuanying has quit IRC03:00
*** zz_naotokl is now known as naotok03:00
*** yuanying has joined #openstack-ironic03:16
*** eghobo has quit IRC03:17
*** nosnos has quit IRC03:44
*** nosnos has joined #openstack-ironic03:45
*** nosnos has quit IRC03:49
*** eghobo has joined #openstack-ironic04:14
*** nosnos has joined #openstack-ironic04:17
*** yuanying has quit IRC04:21
*** yuanying has joined #openstack-ironic04:28
*** nikunj2512 has joined #openstack-ironic04:33
*** teju has joined #openstack-ironic04:36
tejuhi all...i would like to test pxe boot using ironic. can I do this only with nova? , i mean without neutron?04:38
*** teju has quit IRC04:46
*** eghobo has quit IRC04:50
*** eghobo has joined #openstack-ironic04:50
*** killer_prince is now known as lazy_prince04:53
*** rushiagr_away is now known as rushiagr05:05
*** melgus has quit IRC05:06
*** penick has joined #openstack-ironic05:14
*** bmahalakshmi has joined #openstack-ironic05:20
*** rakesh_hs has joined #openstack-ironic05:24
*** eghobo has quit IRC05:30
*** eghobo has joined #openstack-ironic05:30
*** bmahalakshmi has quit IRC05:33
*** nikunj2512 has quit IRC05:34
*** nikunj2513 has joined #openstack-ironic05:34
*** bmahalakshmi has joined #openstack-ironic05:35
*** nikunj2513 has quit IRC05:44
*** nikunj2513 has joined #openstack-ironic05:45
*** bmahalakshmi2 has joined #openstack-ironic05:46
*** bmahalakshmi has quit IRC05:46
*** penick has quit IRC05:52
openstackgerritSyed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic  https://review.openstack.org/11435705:54
*** bmahalakshmi2 has quit IRC06:00
*** k4n0 has joined #openstack-ironic06:06
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/11769806:14
*** rameshg87 has joined #openstack-ironic06:15
*** chenglch has joined #openstack-ironic06:28
*** ndipanov has joined #openstack-ironic06:40
*** Haomeng has quit IRC06:44
*** Haomeng has joined #openstack-ironic06:46
*** Haomeng has quit IRC06:56
*** Haomeng has joined #openstack-ironic06:58
*** bmahalakshmi has joined #openstack-ironic07:00
*** openstackgerrit has quit IRC07:02
*** Haomeng has quit IRC07:04
*** bmahalakshmi has quit IRC07:06
*** nikunj2513 has quit IRC07:07
*** nikunj2513 has joined #openstack-ironic07:07
*** bmahalakshmi has joined #openstack-ironic07:08
*** jcoufal has joined #openstack-ironic07:13
*** rameshg87 has left #openstack-ironic07:25
*** Haomeng has joined #openstack-ironic07:26
*** naotok is now known as zz_naotok07:33
*** romcheg1 has joined #openstack-ironic07:38
*** Haomeng has quit IRC07:41
*** jistr has joined #openstack-ironic07:45
*** Haomeng has joined #openstack-ironic07:47
*** rameshg87 has joined #openstack-ironic07:49
*** eghobo has quit IRC07:50
*** derekh has joined #openstack-ironic07:58
*** Haomeng has quit IRC08:01
*** MattMan has quit IRC08:08
*** MattMan has joined #openstack-ironic08:09
*** nikunj2513 has quit IRC08:17
*** foexle has joined #openstack-ironic08:20
*** lucasagomes has joined #openstack-ironic08:23
*** bluex-pl has joined #openstack-ironic08:24
*** pelix has joined #openstack-ironic08:29
mrdaNight ironic08:36
*** athomas has joined #openstack-ironic08:39
romcheg1Good night mrda!08:39
romcheg1And good morning everyone else!08:40
lucasagomesmrda, night08:48
lucasagomesromcheg1, morning :)08:48
romcheg1Morning lucasagomes08:49
rameshg87good morning lucasagomes, romcheg108:50
lucasagomesmorning rameshg8708:50
romcheg1Morning rameshg87!08:50
rameshg87lucasagomes: request you to have a look at ironic-ilo-virtualmedia-driver : https://review.openstack.org/#/c/113865/ .  not much progress after the last review jam :(08:51
lucasagomesrameshg87, yeah will do08:52
rameshg87lucasagomes: thanks08:52
*** dtantsur|afk is now known as dtantsur08:57
dtantsurMorning Ironic08:57
vdrokmorning Ironic09:00
vdrokmorning dtantsur romcheg1 lucasagomes rameshg8709:01
lucasagomesmorning vdrok09:01
lucasagomesand dtantsur09:01
dtantsurlucasagomes, vdrok and others, morning :)09:02
*** pelix has quit IRC09:03
*** pelix has joined #openstack-ironic09:03
*** rameshg87 has quit IRC09:06
*** rameshg87 has joined #openstack-ironic09:07
*** Haomeng has joined #openstack-ironic09:15
romcheg1lucasagomes: Could you please take a look at this one https://review.openstack.org/#/c/107629/ ?09:21
romcheg1Both I and dtantsur have some concerns we left in the comments09:21
lucasagomesromcheg1, yup, will do09:30
*** bluex-pl has quit IRC09:32
*** bluex-pl has joined #openstack-ironic09:33
romcheg1lucasagomes: in general I don't think the patch is bad. My -1 is just to block it until we discuss the things09:33
lucasagomesromcheg1, yeah trying o get my head around it, not very familiar with that script/db parts of the code09:33
lucasagomesI will add a comment there09:34
*** Haomeng has quit IRC09:38
*** bluex-pl has left #openstack-ironic09:39
*** yuanying has quit IRC09:39
lucasagomesromcheg1, commented... but I haven't looked very deep into it09:44
*** romcheg1 has left #openstack-ironic09:45
*** romcheg1 has joined #openstack-ironic09:51
*** rameshg87 has quit IRC09:54
*** chenglch has quit IRC10:07
*** rameshg87 has joined #openstack-ironic10:11
*** yuanying has joined #openstack-ironic10:11
*** Poornima_ has quit IRC10:16
*** rameshg87 has quit IRC10:18
*** rameshg87 has joined #openstack-ironic10:18
*** rameshg871 has joined #openstack-ironic10:55
*** rameshg87 has quit IRC10:57
*** romcheg1 has left #openstack-ironic11:17
*** yuanying has quit IRC11:17
*** Haomeng has joined #openstack-ironic11:22
*** Haomeng has quit IRC11:27
*** lucasagomes is now known as lucas-hungry11:30
vdroklucasagomes, dtantsur, could you please take a look at this one also - https://review.openstack.org/#/c/116303/11:35
rameshg871dtantsur: hi11:35
rameshg871dtantsur: regarding https://review.openstack.org/#/c/114555/2/ironicclient/common/utils.py :)11:35
dtantsurvdrok, ack11:36
rameshg871dtantsur: it saves creating a couple of new data structures no ? - first zip() creates a tuple, then dict() creates a dict out of the generated tuples, etc11:36
dtantsurrameshg871, right. I'm just against using algorythmic anti-patterns like calling index() on a list11:37
dtantsurI can change if you really feel like11:37
rameshg871dtantsur: okay. i am not insisting, whatever is best i agree to it ..11:38
rameshg871dtantsur: but why are you against index() method ?11:38
rameshg871dtantsur: it should be same a the membership test 'in' except that it returns the index of the item in the list.11:38
dtantsurrameshg871, just my math background - finding element is not natural operation for lists :) nevermind, I can change11:39
rameshg871dtantsur: yeah i agree. it requires iterating over the list, but zip() and dict() should anyway iterate over the same list completely :)11:40
dtantsurright, that's why I hate both :)11:41
dtantsurbrb11:41
rameshg871dtantsur: :)11:41
*** bmahalakshmi has quit IRC11:43
*** k4n0 has quit IRC11:46
*** yuanying has joined #openstack-ironic11:48
*** bluex-pl has joined #openstack-ironic11:51
*** todd_dsm has joined #openstack-ironic11:54
*** yuanying has quit IRC11:56
*** vdrok is now known as vdrok_afk12:00
*** bluex-pl has quit IRC12:04
*** bluex-pl has joined #openstack-ironic12:11
*** todd_dsm has quit IRC12:14
*** bluex-pl has quit IRC12:22
*** todd_dsm has joined #openstack-ironic12:22
*** bluex-pl has joined #openstack-ironic12:22
*** rushiagr is now known as rushiagr_away12:22
*** lucas-hungry is now known as lucasagomes12:32
*** Haomeng has joined #openstack-ironic12:37
*** Haomeng has quit IRC12:41
*** bluex-pl has quit IRC12:48
*** bluex-pl has joined #openstack-ironic12:49
lucasagomesjroll, ^ mostly curiosity, please take a look when you get some time https://review.openstack.org/11832612:50
*** yuanying has joined #openstack-ironic12:53
*** yuanying has quit IRC13:02
*** pcrews has joined #openstack-ironic13:04
Shrewsmorning all13:05
dtantsurShrews, morning13:08
*** rloo has joined #openstack-ironic13:14
*** dkehn_ has joined #openstack-ironic13:27
*** rushiagr_away is now known as rushiagr13:27
*** bluex-pl has quit IRC13:33
*** lazy_prince is now known as killer_prince13:36
*** dkehn_ is now known as dkehnx13:39
*** jasondotstar has joined #openstack-ironic13:41
jrollmorning everybody :)13:41
jrolllucasagomes: I don't think that will work, because it's a driver_passthru?13:41
jrollunless you investigated and verified13:41
rloomorning jroll13:41
jrollhiya rloo :)13:42
lucasagomesjroll, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L301-L306 (1 sec I'm in a call)13:43
lucasagomesmorning jroll rloo13:43
rloohi lucasagomes13:44
jrolllucasagomes: will poke at it later in devstack but I think you're right, thanks :)13:47
lucasagomesjroll, tx much :)13:50
lucasagomesrloo, hi there, long time :) how was the holiday?13:50
rloolucasagomes: too short :-(  School started today for my daughter, so I'm back at work now ;)13:50
*** lnxnut has joined #openstack-ironic13:51
rloolucasagomes: catching up on emails etc. let me know if there are any 'urgent' patches to be reviewed.13:51
*** r-daneel has joined #openstack-ironic13:54
*** bluex-pl has joined #openstack-ironic13:57
*** faizan has joined #openstack-ironic13:57
*** yuanying has joined #openstack-ironic13:58
dtantsurjroll, rloo morning13:59
rloohi dtantsur. Hope you're feeling better.13:59
jrollmorning dtantsur :)13:59
dtantsurrloo, not actually :( hope to feel better by tomorrow13:59
*** dlaube has joined #openstack-ironic14:00
rloodtantsur: sorry to hear that. What are you doing working? Go to bed!14:00
dtantsurhave some important things to finish..14:00
dtantsurat least I'm not in the office :)14:01
NobodyCamGood mroning Ironic14:04
NobodyCammorning even14:05
NobodyCam:-p14:05
jrollmorning NobodyCam :)14:05
NobodyCammorning jroll :) how was your weelend?14:05
* NobodyCam needs coffee14:05
NobodyCam*weekend14:05
dtantsurNobodyCam, morning14:06
jrolltwas good, went to bodega bay :) how was yours?14:06
NobodyCammorning dtantsur :)14:06
*** chuckC has quit IRC14:06
*** openstackgerrit has joined #openstack-ironic14:07
NobodyCamwas, good went camping, with no phone or internet access at all for three days14:07
rloomorning NobodyCam14:07
NobodyCamI want more of that... lol14:07
*** yuanying has quit IRC14:07
*** todd_dsm has quit IRC14:07
NobodyCammorning rloo :)14:07
ShrewsNobodyCam: sounds wonderful14:08
NobodyCammorning Shrews :) actually it was!!! I loved it.14:09
jrollcamping ftw14:09
jrollmorning Shrews :)14:10
ShrewsNobodyCam: i went hiking last week during my PTO. was awesome to get away from computer thingies14:10
*** jcoufal has quit IRC14:11
Shrewsjroll: morning14:11
*** jcoufal has joined #openstack-ironic14:13
NobodyCamShrews: YA :)14:13
* NobodyCam takes a few minutes to drink the now ready coffee :) brb14:14
Shrewslucasagomes: except for the nits, 116913 looks ready for +A, yes?14:17
lucasagomesShrews, yup, you want to me to fix that nits? or can be a following patch?14:18
lucasagomesI didn't because it had a +2 already :(14:18
Shrewslucasagomes: can be fixed later. was just wondering if you were planning another patch already14:18
*** killer_prince is now known as lazy_prince14:18
lucasagomesShrews, nop, I'm happy with that as-is14:18
lucasagomesShrews, o/ tx much14:19
NobodyCammorning lucasagomes14:22
lucasagomesmorning NobodyCam14:22
NobodyCamDid we land everything14:22
rloolucasagomes: I had a nit in 116913, not worth preventing it from landing though.14:22
lucasagomesrloo, thanks! I will put a patch up fixing that and the other nits soon14:25
lucasagomesNobodyCam, nop, not yet14:25
rloolucasagomes: no worries ;)14:25
lucasagomesNobodyCam, drac just got approved, we have UEFI and iLO Media14:25
lucasagomesthere's also the PDU power driver which has no patch to review yet :(14:25
lucasagomesso...14:25
*** jistr has quit IRC14:26
*** jistr has joined #openstack-ironic14:28
*** todd_dsm has joined #openstack-ironic14:28
*** todd_dsm has quit IRC14:29
NobodyCamtoday is our last day to land them? if I recall correctly14:30
dtantsurNobodyCam, I guess we may make last approvals tomorrow14:32
jrollisn't j3 release thursday? why would today be the cutoff14:32
*** linggao has joined #openstack-ironic14:32
rlooNobodyCam: I thought cuz Ironic hasn't graduated, that it could be Thurs. When devanand1 says it is ready.14:33
rlooNobodyCam: I believe that's what happened with J2; it wasn't done the Tues before the deadline.14:33
NobodyCamI though I remember some deva saying some thing about the 3rd but I could be wrong thats why I'm asking14:34
NobodyCam:-p14:34
*** bluex-pl has quit IRC14:34
Shrewsttx's email to the list seems to indicate today is the day, but not sure if that applies to us14:34
NobodyCamI'm Not 100% sure,but I do recall something about the 3rd (the day deva gets back)14:35
viktorslucasagomes: hi!14:36
lucasagomesviktors, hi there14:37
viktorslucasagomes: I want to ask you about a patch https://review.openstack.org/#/c/107629 (Use metadata.create_all() to get database schema)14:37
NobodyCamare the tremptest tests stable and working: RE: https://review.openstack.org/#/c/11818914:39
viktorslucasagomes:  do we really need to keep the old behavior? I have a big doubt, that this class works for for non-sqlite backends14:39
*** Haomeng has joined #openstack-ironic14:39
lucasagomesviktors, oh, so I'm not super familiar on that db area. I rely more in guys like you14:39
lucasagomesif it's possible and we are confident, I think that maintaining the old behavior is a good thing14:40
lucasagomesbut as you say that may not even work, I don't have a strong objection in not doing that14:40
lucasagomeseven because, as in the comment, I think that the error raised to the user14:40
lucasagomesis self explanatory14:40
lucasagomesand he can just call upgrade() to sync the db to the last version, correct14:41
lucasagomes?14:41
viktorslucasagomes: not really, there is a check on lines 89-90, so user will not get this error - tests will silently use old DB schema14:42
*** jistr has quit IRC14:42
*** jistr has joined #openstack-ironic14:43
viktorslucasagomes: ok, I'll return the old behavior - I hope, that it will make someone happy :)14:43
lucasagomesviktors, right14:44
*** NIsha has joined #openstack-ironic14:48
*** shakamunyi has joined #openstack-ironic14:48
*** NIsha has quit IRC14:49
*** Haomeng has quit IRC14:49
*** Nisha has joined #openstack-ironic14:49
*** chuckC has joined #openstack-ironic14:56
openstackgerritVictor Sergeyev proposed a change to openstack/ironic: Use metadata.create_all() to initialise DB schema  https://review.openstack.org/10762914:58
viktorslucasagomes: done. You can look at ^^, if you have a time.14:59
lucasagomesviktors, thanks, I will take a look soonish14:59
openstackgerritA change was merged to openstack/ironic: Implements the DRAC ManagementInterface for get/set boot device  https://review.openstack.org/11691315:02
*** yuanying has joined #openstack-ironic15:03
*** nosnos has quit IRC15:06
*** nosnos has joined #openstack-ironic15:07
*** shakamunyi has quit IRC15:07
NobodyCamlucasagomes: Ty for https://review.openstack.org/#/c/118194 :) LGTM, but I think dtantsur comment about adding sudo is valid, want to toss a new rev and we can land it? or just add the sudo in anouther patch?15:08
*** rakesh_hs has quit IRC15:10
*** foexle has quit IRC15:10
lucasagomesNobodyCam, oh, I can put a patch up very quick adding sudo15:11
lucasagomes1 sec will do15:11
NobodyCam:)15:11
NobodyCamTy lucasagomes :)15:11
*** shakamunyi has joined #openstack-ironic15:11
*** nosnos has quit IRC15:11
*** yuanying has quit IRC15:12
openstackgerritSyed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic  https://review.openstack.org/11435715:14
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Update installation guide for syslinux 6  https://review.openstack.org/11819415:14
lucasagomesNobodyCam, here we go ^15:14
NobodyCamw00t .. TY lucasagomes :)15:14
lucasagomesty for reviwing :)15:14
NobodyCamhehehe :)15:15
NobodyCamdtantsur: I just +2'd https://review.openstack.org/118194 want to re-add yours and we'll land as soon as mr J is done15:16
JayFeverytime you say Mr. J15:17
JayFI'm thinking I'm Mister J15:17
jrollmister JayF15:18
*** faizan has quit IRC15:19
NobodyCamlol15:21
NobodyCammorning JayF and jroll15:21
NobodyCam:)15:21
*** viktors is now known as viktors|afk15:21
jrollmorning NobodyCam :)15:22
jrollJayF: thoughts on sdague's comment? https://review.openstack.org/#/c/117384/15:22
jrollhe makes a good point... but not sure how to reply to that15:22
JayFwhy are you rm -rf imagebuild/15:23
JayFand I'm not sure I understand his comment15:23
jrollbecause it's cruft-ohhhhhhhh15:24
*** jcoufal has quit IRC15:24
jrollyeah, that's bad15:24
jrollhe's asking15:24
jrollwhat if build scripts change again15:24
jrollwe'll have to change devstack15:24
jrollalthough, once this stuff lands, we have gate jobs15:24
jrollok, thanks for rubber ducking me15:24
jrollcan you -1 for imagebuild/ ?15:24
JayFjroll: make clean && rm imagebuild/coreos/UPLOAD/*15:26
jrollyep, +115:26
JayFjroll: s/UPLOAD/OUTPUT/ might quash his concern15:26
JayFit's just a matter of what we name things15:26
jrollwell15:26
jrollit's more that now our build scripts run from root of ipa repo15:26
jrollhe's asking what if build scripts break devstack again15:27
jrollwhich is fair15:27
jrollbut, gate jobs15:27
rameshg871lucasagomes: dtantsur, need your votes on https://review.openstack.org/#/c/113865/ again . there was a manual rebase i needed to do after a submission15:32
*** annegentle has quit IRC15:32
JayFjroll: comment posted15:33
NobodyCamrameshg871: PEP8 FAIL?15:33
NobodyCamsorry for caps15:33
jrollJayF: already fixed :P15:33
rameshg871NobodyCam: i did recheck no bug and pep8 failure went away15:33
dtantsurrameshg871, could you make mr. J happy first?15:33
NobodyCamahh15:33
rameshg871NobodyCam: jenkins will post the results soon .. :)15:33
jrollJayF: but, thanks15:33
NobodyCam:)15:34
rameshg871dtantsur: okay, the results will come in few mins. i think i pinged too quickly :)15:34
NobodyCamlol hehehehe15:34
dtantsurrameshg871, it won't be fixed by recheck15:34
dtantsurrameshg871, error is real15:34
dtantsurwe no longer treat _ as a built-in15:35
NobodyCamya looks real ./ironic/drivers/modules/ilo/deploy.py:43:1: F821 undefined name '_'15:35
jrolloh, did that land? \o/15:35
dtantsuryep15:36
jrollyesssssss15:36
NobodyCamahhh freesh coffee is ready...brb15:36
jrollI think I can fix this in a sane manner, then: https://bugs.launchpad.net/bugs/130093915:36
jrollwas waiting to use oslo.i18n15:36
rameshg871dtantsur: i don't know. it is not caught on my local machine.15:36
rameshg871dtantsur: NobodyCam: pep8 already SUCCESS on http://status.openstack.org/zuul/ 11386515:37
rameshg871dtantsur: NobodyCam: even i was surprised :)15:37
jrolluhh.15:38
jrollthat seems wrong15:38
dtantsurrameshg871, try rebasing locally again - it does fail15:39
dtantsurrameshg871, maybe it's still old version in the check15:39
* dtantsur just checked locally15:39
JayFEven if it passes check jobs, unless it gets the i18n fixes, it'll die in the gate, right?15:40
rameshg871dtantsur: does it fail ?15:40
JayFassumign that's the patch jroll was celebrating land15:40
rameshg871dtantsur: the dependant patch went through in first attempt https://review.openstack.org/#/c/115885/15:40
jrollindeed15:40
dtantsurrameshg871, could you just check please?15:41
rameshg871dtantsur: Mr J is happy :-)  https://review.openstack.org/#/c/113865/15:41
rameshg871dtantsur: let me check locally ..15:41
JayF113865 lgtm15:42
jrollit's gonig to fail in the gate15:42
jrollnot sure why it didn't fail here15:42
dtantsur> HEAD is now at e20b061 Merge "Rewrite images tests with mock"15:42
jrollthat's really odd15:42
rameshg871dtantsur: still doesn't fail locally :-)15:42
dtantsurit does, it's not possible for it not to fail15:43
dtantsuryou're using undeclared variable _15:43
lucasagomesrameshg871, ack15:44
dtantsur$ git checkout a6caeef289d92edc941720bc7442e58ae9036cc1 && git fetch https://review.openstack.org/openstack/ironic refs/changes/65/113865/18 && git cherry-pick FETCH_HEAD && tox -epep815:44
dtantsurrameshg871, does not it output error?15:44
rameshg871dtantsur: just checking ....15:45
*** shakamunyi has quit IRC15:46
rameshg871dtantsur: i did this ... git fetch origin && git rebase origin/master15:46
rameshg871dtantsur: even the effect is same, right ?15:46
dtantsurshould be. check that origin/master is a6caeef289d92edc941720bc7442e58ae9036cc115:46
jrollyeah, failing for me locally15:47
rameshg871dtantsur: yup it is :-)15:47
dtantsurthen it should fail15:47
jrollrameshg871: you should just need to add 'from ironic.common.i18n import _' to ironic/drivers/ilo.py and ironic/drivers/modules/ilo/deploy.py15:48
dtantsurright15:48
jrollnow, why jenkins is fine with it...15:48
dtantsurjroll, <dtantsur> > HEAD is now at e20b061 Merge "Rewrite images tests with mock"15:49
dtantsurit was testing on an old master15:49
dtantsurno idea why15:49
jrollI don't see that :|15:49
jrollhttp://logs.openstack.org/65/113865/18/check/gate-ironic-pep8/963e8aa/console.html15:49
jrolloh, I do15:50
jrollok15:50
rameshg871dtantsur: still i am not getting error :(15:51
rameshg871dtantsur: let me check15:51
jrolleven just "git review -d 113865 && tox -epep8" fails15:54
jrolleasier case to deal with15:54
* jroll bbiab15:54
lucasagomesjroll, if mrda agrees to include https://review.openstack.org/118189 , please approve it15:55
NobodyCam:)15:56
lucasagomesor rloo or NobodyCam (anybody that will see mrda online at some point and can ask him :))15:56
NobodyCamlucasagomes: on my list to pounce15:56
lucasagomestx15:57
NobodyCamlucasagomes: what do you think about the name here: https://review.openstack.org/#/c/113865/18/setup.cfg15:57
lucasagomesNobodyCam, hmm, I haven't thought much about it but I don't have a better name as well :/15:58
NobodyCam:-p15:58
openstackgerritA change was merged to openstack/ironic: Add boot_device support for vbox  https://review.openstack.org/11615215:58
lucasagomesthey are using iscsi to boot the deploy ramdisk :/ maybe vmedia_ilo15:58
NobodyCamthat's what I was leaning to but I too am unsure15:59
NobodyCamif ots better15:59
NobodyCams/ots/its/15:59
lucasagomesyeah I'm in the same15:59
lucasagomesvmedia is def more generic15:59
NobodyCam:)16:02
NobodyCamyea16:02
NobodyCamrameshg871: anythoughs on the name?16:04
*** shakamunyi has joined #openstack-ironic16:04
rlooso we merged 110634. hmm. Anyone know if there is going to be further 'enhancements'? Cuz eg _ and _LE are handled differently: https://review.openstack.org/#/c/110634/14/ironic/common/images.py16:04
*** eghobo has joined #openstack-ironic16:04
*** jistr has quit IRC16:05
rloovdrok_afk: ^^16:05
rloojroll: should this be assigned to you or vdrok_afk? https://bugs.launchpad.net/ironic/+bug/134640616:06
*** eghobo has quit IRC16:06
*** rameshg871 has quit IRC16:08
*** davidlenwell_ is now known as davidlenwell16:08
*** eglynn_ has joined #openstack-ironic16:09
*** yuanying has joined #openstack-ironic16:09
*** rameshg87 has joined #openstack-ironic16:10
dtantsurrloo, you mean this: https://review.openstack.org/116303 ?16:11
*** rameshg871 has joined #openstack-ironic16:12
rloodtantsur: maybe. that isn't associated with a bug? let me see...16:12
openstackgerritA change was merged to openstack/ironic: Check ERROR state from driver in _do_sync_power_state  https://review.openstack.org/11687616:13
rameshg871NobodyCam: happy to put vmedia in. but would like to have iscsi in there ..16:13
rameshg871NobodyCam: iscsi is the actual deploy mechanism there still16:13
*** rameshg87 has quit IRC16:14
NobodyCamrameshg871: ya polease do not make a change. just looking for thoughts / ideas ...16:15
*** davidlenwell is now known as meatpopcicle16:15
*** meatpopcicle is now known as davidlenwell16:15
NobodyCamplease even16:15
NobodyCamhehehe16:15
Shrewsadam_g`: 112660 +A'd. woohoo!  2 to go16:16
JayFrussell_h: jroll: relevant to your interests: http://lists.openstack.org/pipermail/openstack-dev/2014-September/044566.html16:16
JayFI forget who exactly was working on our hash ring stuff16:16
Shrewsgreghaynes, iirc16:17
JayFgreghaynes: ^^ also relevant to your interests16:17
*** yuanying has quit IRC16:18
greghaynesyea, I was just reading that16:18
rloodtantsur: yes, that's what I mean. thx. Although I'm not happy that it is all in one patch cuz that makes it harder to review etc.16:18
greghaynesIm not sure that is correct16:18
greghaynesbut I need to read some code first16:19
*** shakamunyi has quit IRC16:20
russell_hJayF: heh yeah I saw that16:21
lucasagomesdtantsur, https://review.openstack.org/#/c/116913/10/ironic/tests/drivers/drac/test_common.py why set() and not sort()16:21
dtantsurlucasagomes, just looks clearer to me, you may ignore16:22
lucasagomesdtantsur, I think sorted is better there, I mean... set() will not avoid duplication but if 2 elements has the same value16:22
lucasagomesit will be wrong to test with set16:22
lucasagomescause it will have len 1 while the real case will have len 216:22
lucasagomesdtantsur, ack16:22
lucasagomesthanks16:22
rameshg871NobodyCam: okay :-)16:23
rameshg871jroll: dtantsur: i have one question.  does tox -epep8 create the venv everytime ?16:27
dtantsurrameshg871, should only the 1s time16:27
*** linggao has quit IRC16:28
rameshg871dtantsur: is it same as tox -evenv ?16:28
dtantsurrameshg871, venv is required for all these commands16:29
dtantsur(I know it sucks)16:29
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Fix minor issues in the DRAC driver  https://review.openstack.org/11839716:29
rameshg871dtantsur: okay :-)16:29
*** Haomeng has joined #openstack-ironic16:31
*** rushiagr is now known as rushiagr_away16:32
* Shrews goes afk for a bit. bbs16:32
NobodyCamenjoy Shrews16:32
NobodyCamlucasagomes: looking at 118397... just asking why the filter dialect constant is a constant and not a conf value that can be set by folks that may mirror that pdf?16:34
lucasagomesNobodyCam, that's a good question, I wonder if the same would be true for the other URLs (check resource_uris)16:36
lucasagomesI've no immediately answer for that16:36
lucasagomesI don't know WSMAN very well, I based a lot on the power interface of drac to make the managment16:36
lucasagomesand the file dialect was a constant there16:36
lucasagomesmaybe ifarkas can give you a better answer for that ^16:36
rameshg871dtantsur: i understand i need to change as done in https://review.openstack.org/#/c/110634/16:37
rameshg871dtantsur: but still flake8 doesn't fail :(16:37
rameshg871dtantsur: any other things on top of your mind to try ?16:37
dtantsurit's very strange...16:37
rameshg871dtantsur: i mean tox -epep8 doesn't fail :(16:37
lucasagomesNobodyCam, also if you try to access those URLs they basically don't exist... I mean it may be some special value16:38
NobodyCamoh16:39
NobodyCamhttp://schemas.dmtf.org/wbem/ exists16:39
lucasagomessomething that the creator os SOAP and related technologies got when they tried to telepathically communicate with outer-space creatures that were telling them how to develop a new shiny protocol16:40
NobodyCamlol16:40
dtantsurLOL16:40
lucasagomesyeah I that exist, but I get a 404 on that pdf16:41
lucasagomesand that works16:41
lucasagomesso, I've I don't think we humans are able to understand such technology16:41
lucasagomess/I've//16:41
lucasagomesfirst of, why a pdf? yeah I asked myself that as well16:42
lucasagomesstill don't know16:42
*** Haomeng has quit IRC16:43
NobodyCam:)16:44
* NobodyCam adds ifarkas to punce list16:44
NobodyCampounce even16:44
openstackgerritRamakrishnan G proposed a change to openstack/ironic: IloVirtualMediaIscsi deploy driver  https://review.openstack.org/11386516:45
lucasagomesNobodyCam, yeah, worth asking, but that patch doesn't change any of the current behavior, just put the constants in a common place instead of leaving them scattered around the code16:45
NobodyCamya I just want ot undertand that url16:46
openstackgerritStig Telfer proposed a change to openstack/ironic: Adds SNMP power driver  https://review.openstack.org/11840416:47
lucasagomes^ that's our missing code!16:47
*** Nisha_ has joined #openstack-ironic16:48
*** zer0c00l has quit IRC16:49
*** Nisha has quit IRC16:50
dtantsurhmmm, so we'll try to land it?16:50
NobodyCamlucasagomes: +1'd with a comment16:50
lucasagomesNobodyCam, awesome!16:51
lucasagomesdtantsur, yup16:51
NobodyCamI under stand that you are not the one to answer, Left there mainly so I don't forget16:51
*** zer0c00l has joined #openstack-ironic16:52
NobodyCambrb16:52
*** derekh has quit IRC16:55
jrollrloo: that should be assigned to vdrok_afk16:56
jrollrloo: also, we added flake8 exceptions for importing _, should probably move the imports for _Lx16:57
rloojroll: thx, I reassigned to vdrok_afk16:58
*** Haomeng has joined #openstack-ironic16:58
jrollrloo: thank you :)17:00
jrollI just pushed the last rebase, so17:00
*** lazy_prince is now known as killer_prince17:01
rloojroll: dtantsur pointed out https://review.openstack.org/116303. too many files changed there so I didn't look ;)17:01
dtantsurleft some comments on SNMP patch and switching to health recovery mode now :)17:01
*** dtantsur is now known as dtantsur|afk17:01
jrollrloo: ok, cool, that patch is for the same bug, it was split from the patch that already landed17:02
openstackgerritRamakrishnan G proposed a change to openstack/ironic: IloVirtualMediaAgent deploy driver  https://review.openstack.org/11588517:02
*** harlowja has joined #openstack-ironic17:04
rloojroll: I asked for a bug # for that patch. it makes sense that it is part of the same bug. thx.17:04
jrollah, right, just glanced at your comment quick17:05
*** Haomeng has quit IRC17:05
lucasagomesalright folks, I'll have to go now17:06
lucasagomeshave a good night117:06
rloociao lucasagomes17:06
jrollnight lucasagomes :)17:06
NobodyCamhave a good night lucasagomes17:06
lucasagomessee ye tomorrow17:06
*** lucasagomes is now known as lucas-dinner17:06
NobodyCam:)17:06
*** rushiagr_away is now known as rushiagr17:07
*** yuanying has joined #openstack-ironic17:14
*** yuanying has quit IRC17:22
*** Nisha_ has quit IRC17:23
*** slagle_ is now known as slagle17:28
*** eglynn_ has quit IRC17:29
NobodyCamyuriyz: you still here?17:37
rloojroll: are you helping out on https://review.openstack.org/#/c/114357/? pep8 failure. is Syed around? (don't know their nickname)17:37
greghayneslucas-dinner: Just missed you :(. Im working on https://review.openstack.org/#/c/109688/8/ironic/api/controllers/v1/node.py and Shrews' comment there seems valid, but im curious about the lines above it which do the same for chassis_uuid17:38
greghaynesseems like that might be a bug?17:38
*** bandicot has joined #openstack-ironic17:39
openstackgerritA change was merged to openstack/ironic: Update installation guide for syslinux 6  https://review.openstack.org/11819417:41
*** penick has joined #openstack-ironic17:48
*** mikal_ is now known as mikal17:50
greghaynesaye, this is dirty :/17:57
greghayneswe have that nasty overloaded type for objects.Chassis.get() which is why yours works17:59
*** coolsvap has quit IRC18:00
*** coolsvap has joined #openstack-ironic18:03
*** rameshg871 has quit IRC18:06
*** linggao has joined #openstack-ironic18:08
openstackgerritGregory Haynes proposed a change to openstack/ironic: Add conductor_hostname property to nodes  https://review.openstack.org/10968818:10
*** pelix has quit IRC18:11
*** harlowja has quit IRC18:12
*** harlowja has joined #openstack-ironic18:13
*** rameshg87 has joined #openstack-ironic18:16
*** yuanying has joined #openstack-ironic18:19
*** yuanying has quit IRC18:27
*** rushiagr is now known as rushiagr_away18:33
*** davidlenwell has quit IRC18:36
*** davidlenwell has joined #openstack-ironic18:36
*** wanyen has joined #openstack-ironic18:39
*** rameshg87 has joined #openstack-ironic18:44
*** adam_g` is now known as adaM_g18:44
*** adaM_g is now known as adam_g18:44
NobodyCamhummm..... open question. Just woundering what thoughts folks have. Does each driver need its own time-out value18:45
JayFWhich of many timeout values do you speak of18:45
NobodyCamthat came ti mind while looking atL https://review.openstack.org/#/c/118404/1/etc/ironic/ironic.conf.sample18:45
JayFin cases like that; very much so yes18:46
NobodyCamseamicohas action_timeout, snmp is looking to add power_timeout18:46
rameshg87NobodyCam: i think i finally got Mr.Jenikins happy: https://review.openstack.org/#/c/113865/18:46
JayFThey should probably be named similarly18:46
JayFbut otherwise I very much agree the timeouts should be configured separately18:47
NobodyCamrameshg87: woo hoo18:47
NobodyCamI'll have a look see in a few18:47
rameshg87NobodyCam: JayF: please take a look at it :)18:47
NobodyCamok we can have a clean up timeout names patch later18:48
rlooNobodyCam: what do you mean by 'later'? A different patch, or a different version of the same patch?18:50
NobodyCamdifferent patch that cleans up all the timeout names.. I think we have quite a few now18:50
rlooNobodyCam: sigh. we should clean up asap then cuz we have to be backwards compatible :-(18:51
JayFor don't worry about it :)18:51
JayFnot many people will be using multiple drivers on the same conductor18:52
JayFso risk of confusion is minimal18:52
NobodyCamrloo: if it is something we want we could do it in k too18:52
JayFimo we have more important things to fix than what options are named, even though I *wish* they were consistent18:52
rloono, we should worry/fix now so it doesn't get more confusing later with more drivers.18:52
jrollrloo: idk what I need to "help" with, people should debug their own test failures or ask for help; but happy to push a new patchset so we can push it through18:54
* jroll just does it18:55
rloojroll: I was wondering if people were rebasing/fixing things to get them moving along, and I saw your name as a co-author or whatever ;)18:55
jrollrloo: more than happy to, we should be at this point18:55
rloojroll: so since you had a special relationship, I wanted to check with you first before I fixed it ;)18:56
jrollI forgot I was co-author on that :P18:56
*** rameshg87 has left #openstack-ironic18:57
* jroll waits for tests18:57
*** ndipanov is now known as ndipanov_gone19:00
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic  https://review.openstack.org/11435719:00
NobodyCamhumm19:01
jrollrloo: ^19:01
jrolland whoever else wants to push the +2+A button19:01
rloothx jroll. Will review soon.19:01
NobodyCamjroll: will look in a few19:01
jrollthanks!19:02
JayFlookig19:02
jrollI just added an import19:02
JayFhttps://review.openstack.org/#/c/113865/19 has passed jenkins now, was pretty close to landing but had to get rebased (ilo-iscsi driver)19:09
NobodyCambrb19:10
*** yuanying has joined #openstack-ironic19:24
NobodyCamahh we lost rameshg8719:28
NobodyCamwas going to let him know I +2'd the IloVirtualMediaIscsi patch :-p19:29
NobodyCamjroll: that was just a rebase on 114357?19:32
*** yuanying has quit IRC19:32
jrollNobodyCam: it was pep8 fixes19:35
jrollNobodyCam: I only made this change https://review.openstack.org/#/c/114357/17..18/ironic/common/pxe_utils.py19:36
NobodyCam:) ahh19:38
*** rushiagr_away is now known as rushiagr19:43
*** jasondotstar has quit IRC19:54
*** jasondotstar has joined #openstack-ironic19:59
*** penick has quit IRC20:01
*** penick has joined #openstack-ironic20:02
NobodyCambrb20:08
*** rushiagr is now known as rushiagr_away20:12
*** rloo has quit IRC20:18
*** GheRivero_afk is now known as GheRivero20:27
*** yuanying has joined #openstack-ironic20:29
*** rloo has joined #openstack-ironic20:33
*** rloo_ has joined #openstack-ironic20:36
*** rloo has quit IRC20:36
*** rloo_ has quit IRC20:36
*** rloo has joined #openstack-ironic20:37
*** yuanying has quit IRC20:37
*** eghobo has joined #openstack-ironic20:38
*** rloo has quit IRC20:40
*** rloo has joined #openstack-ironic20:40
*** eguz has joined #openstack-ironic20:52
*** eguz has quit IRC20:52
*** rloo has quit IRC20:53
*** linggao has quit IRC20:54
*** rloo has joined #openstack-ironic20:54
*** eghobo has quit IRC20:56
*** rushiagr_away is now known as rushiagr20:56
*** eghobo has joined #openstack-ironic20:58
NobodyCamassertEqual(expected, actual) is the correct order yes?21:00
*** rloo has quit IRC21:00
*** rloo has joined #openstack-ironic21:01
rlooNobodyCam: yes, expected first.21:03
*** eghobo has quit IRC21:05
*** eghobo has joined #openstack-ironic21:05
NobodyCamty rloo :)21:06
*** rloo has quit IRC21:07
NobodyCammrda: around yet?21:07
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Update ironic states and documentation.  https://review.openstack.org/11846721:08
*** rloo has joined #openstack-ironic21:09
openstackgerritGregory Haynes proposed a change to openstack/ironic: Add conductor_hostname property to nodes  https://review.openstack.org/10968821:09
JayFShrews: ^^ put a -1 and some comments on 11846721:12
ShrewsJayF: wow, fast21:13
ShrewsJayF pounces like a jungle cat21:13
JayFif I'm going to review something, might as well do it when it's fresh21:14
ShrewsJayF: it's still a WIP. just throwing it out there so i don't lose it21:14
*** rushiagr is now known as rushiagr_away21:14
JayFShrews: I get that, I do that all the time :) was just excited to see it updated and looked21:15
Shrewshrm, there's a new 3rd party testing system specifically for LBaaS now? interesting21:19
ShrewsPatch Set 14: "Brocade LBaaS API testing PASSED with Brocade LBaaS CI "21:19
*** jasondotstar has quit IRC21:20
jrollrloo: I'm going to push fixes for your review on the uefi stuff so we can land that today21:24
rloojroll: fine with me.21:25
rloojroll: I'm around for another 30 min or so, and will try to be back later tonight.21:25
jrollok, cool21:26
mrdaMorning Ironic (incl NobodyCam )21:26
jrollmorning mrda :)21:26
NobodyCammorning mrda21:26
NobodyCamlol21:27
Shrewsmrda: hi and morning21:27
NobodyCammrda: https://review.openstack.org/#/c/11818921:27
* mrda looks21:27
rloomorning mrda21:27
mrdaAs Jimmy Fallon would say, "Eww"21:28
NobodyCamsorry :-p21:28
mrdare: that review21:28
*** rloo has quit IRC21:29
*** rloo has joined #openstack-ironic21:29
mrdaso just to be clear, this needs to be added to the ironic driver under nova review, asap21:29
mrdaright NobodyCam ?21:29
NobodyCamasap == before landing ya :(21:30
mrdasure21:30
NobodyCami'm sorry21:30
NobodyCam:-p21:30
mrdaGo ahead and land it in irnic21:31
mrdaironic21:31
NobodyCam+a'ing now21:31
NobodyCamdone21:32
mrdaSo Phil Day has already -1'd 111428 in prep for me adding this patch in :)21:32
mrdaSo it's all good.  It's not like anyone has done any reviewing since Wednesday last week anyways :-(21:32
NobodyCam:(21:33
jrolllazy americans21:33
* mrda doesn't like what public holidays does to reviews21:33
jroll(for those that don't realize I'm also american, that's a joke)21:33
mrda:)21:33
NobodyCamha ha21:33
*** yuanying has joined #openstack-ironic21:34
mrdaOk, time to follow rule number 1.  No code change before breakfast.  But after that, I'll add in that bugfix21:34
NobodyCamawesome Thank you mrda :)21:35
NobodyCamifarkas: happen to be around?21:35
*** penick has quit IRC21:37
mrdaActually NobodyCam, I think I'll have to change the impl of 118189 slightly.  i.e. s/str/six.text_type/  Nova has hacking checks that stop str() being used :)21:42
*** yuanying has quit IRC21:42
NobodyCammrda: do we need to push up a patch for ironic21:45
NobodyCamor is that how your doing it21:45
NobodyCam:-p21:45
mrdaprobably not, I mean it will be a slight difference21:45
NobodyCamack21:46
NobodyCam:)21:46
*** lnxnut has quit IRC21:46
mrdaI might have to publish a small nit patch at some point, there's a few very minor changes where the code has diverged21:46
mrdabut non functional21:46
mrdait all depends upon whether the code merges in Nova RSN.  If it does, we just delete the ironic driver21:46
mrdain our tree21:47
NobodyCam:) i'm ready +a that patch21:48
NobodyCamlol21:48
mrda:)21:48
mrda(for example, the note in 118189 has english grammar nits in it.  I'll fix as it ports over)21:51
NobodyCamjroll: JayF: should the agent_config.template and the test/agent_config.template?21:55
JayFNobodyCam: what?21:56
JayFNobodyCam: E_NO_CONTEXT ?21:56
NobodyCamhttps://review.openstack.org/#/c/115885/8/ironic/drivers/modules/agent_config.template vs https://review.openstack.org/#/c/115885/8/ironic/tests/drivers/agent_pxe_config.template21:56
NobodyCamlol21:56
jrollone is for tests, one is not?21:56
NobodyCamcontest21:56
jrollwhat the heck is this21:57
jrollthat decidedly won't work21:57
NobodyCamyea, the test template does not have text optionm is that a issue at all?21:57
jrolloh, it will21:57
jrollhuh.21:57
jrollNobodyCam: it's apparently not used, so21:57
JayFour default template should work for tests, right? or else we need a better default template?21:58
jrollJayF: the test template is what pxe driver does, I remember there was a good reason for it but not sure what21:59
NobodyCam-1 that patch22:06
jrollNobodyCam: apparently we don't test that22:07
jrollI don't think that's worth -1 for22:07
jrollon that patch22:07
jrollthat said22:07
jrollworth a bug22:07
jrolland the unnecessary changes to the template are worth a -122:07
NobodyCamjroll: dont the other drivers use the test template to check what is returned from the live template? should not a option difference be cought? I know with other drivers I have worked on it was22:09
jrollNobodyCam: right, we messed up and that test didn't get in somehow22:09
jrollnot sure what happened22:09
jrollidk, maybe that variable name change is fine22:10
NobodyCammaybe at min add something to the commit message as to why that changes is needed22:11
JayFthat actually seems reasonable22:11
JayFyeah I'd be OK with a commit fix22:11
JayFor none at all now that I get what's going on :P22:11
jrollmeh, I don't think it needs it22:12
* JayF wants to just land all the things22:12
jrollI just needed to read more22:12
NobodyCamlol ask first read later22:12
jroll:D22:12
*** athomas has quit IRC22:14
JayFIt's more like "Code review: try to fit something in your head in 10 minutes that it took another person days of work to come up with"22:14
jrollyeah22:14
jrolland then tear that tower down and make them start over on the "come up with" part22:14
jrollrloo left me a comment that I have no idea what to do with22:15
*** annegentle has joined #openstack-ironic22:15
jrollon what we were talking about earlier22:15
NobodyCamjroll: on 114357?22:16
jrollNobodyCam: line 134 https://review.openstack.org/#/c/114357/18/ironic/common/pxe_utils.py22:17
jrollehate elilo22:19
NobodyCamjroll: I get this from that comment : http://paste.openstack.org/show/6Vczk2BSmP2nNBxT5FlB/22:20
NobodyCammaybe a log.debug("couldn't get valid ip for port <blah>")22:21
jrollNobodyCam: maybe22:21
jrollnow I'm thinking harder though22:21
jrollshe's asking f we should continue, or clean up all the links22:22
jrollprobably continue22:22
NobodyCamJayF: better be ready with the fire extinguisher22:22
jroll^^22:22
JayFNobodyCam: me and jroll are talking about it together22:22
JayFNobodyCam: which means there's nobody here to put out the fire22:23
JayFwhich, btw, we didn't start22:23
NobodyCamoh no22:23
NobodyCamlol22:23
JayFit was always burning since the world was tu....22:23
jrollwe found a good resolution, I think, will upload patch soon22:28
jrollwould be great if syed was on irc, I forget his name22:28
NobodyCamfix for snmp review?22:31
openstackgerritA change was merged to openstack/ironic: Avoid deadlock when logging network_info  https://review.openstack.org/11818922:31
NobodyCammrda: ^^^^^^22:31
NobodyCamjust fyi22:32
mrda\o/22:32
openstackgerritA change was merged to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/11769822:33
*** yuanying has joined #openstack-ironic22:39
jrollNobodyCam: no, for uefi22:40
NobodyCamahh ok, i was pointing the template issues out on the IloAgent patch22:42
NobodyCam:-p22:42
jrollright, I was still stuck on ruby's comments22:42
jrollNobodyCam: going to be a largish change though :|22:43
NobodyCamjroll: is your fix minor22:43
NobodyCamoh22:43
NobodyCamlol22:43
*** yuanying has quit IRC22:47
jrollNobodyCam: other than code moving, yes22:48
rloojroll: does the uefi change need to go in today. we can wait for syed to answer my questions.22:52
jrollI've got it22:52
jrollwould love for it to land today22:52
rloojroll: but then I'll have nothing to do tomorrow :D22:55
jrollrloo: I'll find something :D22:57
*** yuanying has joined #openstack-ironic23:05
*** dlaube has quit IRC23:08
*** penick has joined #openstack-ironic23:08
greghayneswoo passed CI again https://review.openstack.org/#/c/109688/23:10
greghaynes(shameless plug for getting reviews23:10
NobodyCamshame shame greghaynes...lol...will look in a few23:11
greghayneswooo, ty23:11
jrolllol23:12
jrollok, now I have a serious question...23:12
jrollhttps://review.openstack.org/#/c/114357/18/ironic/drivers/modules/pxe.py23:12
jrollthe "do not set boot device here" on line 33223:12
jrolldid we agree that's ok at some point?23:12
jrollNobodyCam JayF ^^23:12
jroll(I'm assuming this means operators manually set bootdev)23:13
JayFwhat that's doing is that if a node isn't advertised from the deployer as supporting UEFI natively23:13
* NobodyCam look23:13
JayFit tries to support UEFI via elilo?23:13
jrollwait...23:14
jrollso if the node does not support uefi23:14
jrollwe don't set boot device?23:14
JayFbecause I *think* all pxe boots are 'legacy' boots23:14
jrollstill don't get it23:14
JayFyes, so the node continues to pxe boot23:14
JayFinstead of disk boot23:14
JayFwait, what?23:14
jrollum23:14
JayFokay I don't understand23:14
jrollthis is booting the ramdisk23:14
jrolland now pxe driver won't set bootdev to pxe23:14
jrollholy shit how did we miss this23:15
* JayF pulls the ripcord and jumps out of the plane23:15
jrollNobodyCam: this looks real bad, do you agree?23:17
jrolloh wait23:17
jrollWOW23:17
jrollok I need to go home23:17
jrollcan't read, at all23:17
jrollif a machine DOES support uefi23:17
jrollskip setting bootdev23:17
jrolland I think make the deployer set it, idk23:17
JayFwhy?23:17
jrolldid you read the comment?23:18
jrollI still don't like it23:18
jrollbut I hate it less23:18
NobodyCamIPMITool does not work for setting boot devices in UEFI mode for certain machines.23:18
NobodyCamwhould love to know which machines and why23:19
JayFshouldn't the management interface just handle that?23:19
JayFif we set_boot_device() on something that doesn't support it23:19
jrollright...23:19
JayFshouldn't it just be OK that it tried?23:19
jrollwho knows23:19
jrollwant to see what ipmitooldoes23:19
jrollI think I'm going to push the rest of the changes up23:20
jrolland re-ask the question23:20
JayFI just see a lot of situations where23:20
jrolland let syed speak for himself23:20
JayFyou could get nodes in a weird state23:20
jrollor herself23:20
JayFi.e. I think you could have a node that you think is deploying (DEPLOYWAIT)23:20
JayFthat's just never going to boot shit23:20
JayFbecause it booted the last thing that was written to it's disk23:20
NobodyCamJayF: oh that would be very bad23:20
jrollehhhhhhh23:21
jrollno23:21
jrollbecause we never boot from disk today23:21
jroll(in the pxe driver)23:21
JayFthat makes huge assumptions about what force_pxe means23:21
JayFif you set boot device to pxe in our environment today23:21
JayFand it fails to pxe for any reason, it will happily boot from disk23:21
jrollJayF: if you're using this node with the pxe driver, it will never boot from disk23:21
JayFthat's just what the hardware does23:21
jrollbecause there's no kernel on disk23:22
JayF/when ironic provisions it/23:22
jrollit might try, sure23:22
jrollright23:22
jrollugh23:22
* JayF assumes hostile tenants at all times23:22
jrollright23:22
NobodyCamJayF: you have too23:22
JayFNobodyCam: yes, exactly23:22
jrolllet me push a new patch and then pose these questions to syed23:22
jrollbecause I fixed the other things23:22
JayFtl;dr rloo has a thing todo tomorrow23:23
NobodyCamjroll: awesome TY23:23
JayFhaha23:23
jrollha23:23
rlooyou guys are mean. Can't you just answer it all tonight? :D23:24
NobodyCamspeaking of reviews j* have a quick minute to look at https://review.openstack.org/#/c/11588523:24
NobodyCamrloo: lol23:24
NobodyCamwe did try23:24
kylestev-j* lol23:24
JayFI do /not/ highlight on j*23:24
rlooNobodyCam: +2 for trying!23:24
JayFlol23:24
NobodyCam:-p23:25
NobodyCam/{j|J}.*/ to be more correct23:25
kylestev-why not /j.*/i?23:26
JayFheh, I have this problem, where I review half of a patch, get distracted, then someone links it here (like that one) and I end up rereading the whole thing23:26
NobodyCamlol23:26
NobodyCamsorry JayF23:26
* JayF sees something shiny and chases it23:26
NobodyCam:-p23:27
*** kylestev- is now known as kylestev23:27
* kylestev is confused as to why freenode keeps making his nick kylestev-23:27
* NobodyCam notes not to be a passanger in JayF's car23:27
kylestevlol23:27
JayFhttps://review.openstack.org/#/c/115885/8/ironic/drivers/modules/ilo/deploy.py,cm line 30523:27
jrollhahaha23:27
JayFwhy is it calling REBOOT23:28
JayFShouldn't it be power on?23:28
jrollkylestev: you should read the irc rfc23:28
jrollJayF: it's reboot in pxe driver fwiw23:28
JayFNobodyCam: I'm much better at driving than computing. I don't have these numbers in front of me telling me to read more stuff :)23:28
jrollJayF: e.g. with our servers, power on wouldn't work :P23:28
JayFjroll: okay then, should be fine23:28
JayFthat's why I asked here :)(23:29
kylestevjroll: i mean, i should but... that's gotta be lengthy.23:29
JayFwell our servers aren't running ironic23:29
JayFit's running our fork of IPA driver in ironic23:29
JayFwhich has long running ramdisks23:29
jrollkylestev: something something ping timeout something one connection per nick something23:29
JayFso I thought that might be why it's different for our stuff :)23:29
jrollJayF: that wasn't the point23:29
jroll:)23:29
JayFkylestev: look at your IRC clients backup nickname setting23:29
JayFkylestev: I bet it defaults to ${nick}-23:29
jrollit's more like... if your dcops person didn't shut off your servers when they were racked23:29
kylestevJayF: oddly, in ZNC it is kylestev_23:29
jrollyeah, but znc and your client both send NICK message23:30
jrolls23:30
kylestevhmmm23:30
kylestevodd. ok23:30
JayFonly odd because you don't understand...yet :)23:30
jrollright23:31
jrollread the protocol23:31
*** penick has quit IRC23:31
kylestevk23:32
*** penick has joined #openstack-ironic23:33
* JayF about to -1 11386523:38
jrollrloo: idk what this comment means: https://review.openstack.org/#/c/114357/18/ironic/tests/drivers/test_deploy_utils.py23:39
rloojroll: oh. utils.switch_pxe_config() had a new arg added, the boot_mode. I only see 'bios' here, but boot_mode could be uefi, None, or I guess garbage (not sure about the latter)23:40
jrolloh, I see23:40
rloojroll: I'm not saying there should be tests for that, but I'd like to know that someone considered it and decided to do it or not do it.23:41
jrollyeah... I'm not sure what that function does23:41
jrollI could add one23:41
rlooit's never clear to me how much detail and how many unit tests there ought to be23:41
jrollsuch is softwre dev23:42
rloojroll: you should just let syed deal with it ;) I'm not going to review it until everything is answered anyway.23:42
jrollright23:42
jrollbut, I did a big refactor23:42
jrollI'll ask the question again after I put up a review23:43
rloootherwise, there's an overhead for me reviewing again and again and i have to keep from going coo-coo (sp).23:43
jrollright23:43
openstackgerritKyle Stevenson proposed a change to openstack/ironic: Fix typo in PXE driver docstrings  https://review.openstack.org/11849523:44
JayFrloo: if you read a method and can't understand it, and it doesn't have a unit test, it should probably have one23:44
jrollkylestev: nice one23:44
JayFrloo: that's usually the rule I've applied as someone who reads tests to determine what code does often :)23:44
jrollkylestev: I need a bug # please23:45
* jroll ducks :P23:45
kylestevjroll: it was bothering me23:45
JayFhe's already got on23:45
JayF*one23:45
JayFin the commit message23:45
kylestevyep23:45
JayFkylestev knows how to topenstack23:45
jrolloh wow23:45
jrollunexpected23:45
rlooJayF: if I read a method and can't understand it, I ask what the method is doing ;)23:45
jroll+2'd23:45
kylestevjroll: thanks ;)23:45
jrollsomeone should approve that :D23:45
JayFrloo: a test or comment answers it for future yous23:45
JayFnot before I get my cheap review!23:45
jroll>.>23:45
rlooJayF: ah, yes, that makes sense too.23:46
* rloo wonders if it might be better to not comment on typos so there are lots of low-hanging-fruit for others to find/fix.23:48
jrollno, hate typos :(23:48
kylestevi have a list of typos on my harddrive that i found in my first 1-2 weeks at rackspace23:48
kylestevi might go through and fix them on slow days23:48
jrollrloo: do we translate exception messages?23:49
JayFrloo: no absolutely point them out23:49
kylestevi think there were only like 3-4. what a huge list.23:49
JayFrloo: if you ever see so much as a misplaced period in my patches and don't bring it up, I'll be sad :(23:49
rlooJayF: be careful what you ask for.23:50
JayFrloo: how am I supposed to get better if not by peer review?23:50
jrollpeer beatings23:50
JayFrloo: too many people let folks get away with stuff, I want to be called out, nitpicked, etc23:50
NobodyCamlol23:50
JayFrloo: that's why I try to be low-latency on giving and responding to reviews. Doesn't take long to make things right unless you're waiting 2 days between reviews23:50
JayFmy only issue is if you put a comment and a -* on my review, you gotta check back quicklyish when I fix it :)23:51
NobodyCamlol https://answers.yahoo.com/question/index?qid=20070710110900AAV1zMj23:51
jrollhehehe23:51
JayFwhen I saw the answer started with "Chris " I was waiting for the "Krelle"23:51
kylestevlol23:51
NobodyCamlol23:51
JayF"I contribute to several open source projects, including Openstack, cloud-init, and Yahoo! Answers"23:52
NobodyCamhehehe23:52
rlooJayF: yeah, I try to be quick but I only have so much time and I only work so many days. So I don't always go back and re-review something. It would be interesting to know what/how people feel about comments etc. JayF, I know now!23:52
JayFthis is how *I* feel about it :)23:52
jrollwe have code review for a reason :)23:52
JayFnote that I also would never have my feelings hurt for a code review either23:52
JayFand apparently some people do :)23:52
JayFit's just code! If it's better that's a call I might not get at midnight-thirty when shit breaks :D23:53
mrdaand since greghaynes is pimping reviews, any reviews on the nova ironic driver series starting at review 111223 welcomed :)  (Anything to get it at the top of the list of reviews :)23:53
NobodyCamoh ... Ty23:53
* jroll blind +123:54
rloomrda. sorry, there ought to be a better way to call out those patches cuz they are really important.23:54
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic  https://review.openstack.org/11435723:54
*** lucas-dinner has quit IRC23:54
kylestevwhat are y23:55
jrollwait23:55
jrollthat has 3 +2s23:55
jrollwth23:55
JayFNobodyCam: I just -1'd on your https://review.openstack.org/#/c/113865/1923:55
JayFNobodyCam: you have that +2'd so thought you might want a look23:55
kylestevwhat do you all think of typos in comments that are not doc strings? **23:55
JoshNangrloo: i think Syed's nick is faizan23:55
jrollmrda: why isn't 111223 +A'd23:55
JoshNangwhoops, up on the wrong window23:55
mrdaJoshNang: it has been23:55
mrdabut the rebasing takes it away23:56
jrollwhy rebase ?23:56
JayFkylestev: I typically mark it explictly as a nit "nit: s/typa/typo/" and only make them fix if they push another patchset23:56
jrollmrda: git review -R yo23:56
mrdawell, just to keep the whole chain up to date23:56
JayFkylestev: that being said; if you put that nit on my patch I'd push a new patchset to fix it :)23:56
jrollok23:56
kylestevJayF: what if it's been merged for a while?23:56
rlookylestev: typos are typos, but to be honest, if it isn't a doc string or a user-facing thing, I sometimes don't bother. (except for JayF, for him, I'll call them out.)23:56
JayFkylestev: then file a bug, and fix it?23:57
jrollkylestev: feel free to fix things if you're that bored :P23:57
jrollI wouldn't even file a bug for typos, but that might just be me23:57
jrolllike... that's just dumb23:57
rlooJoshNang: thx23:57
JayFI'm OK with that too :)23:57
JayFalthough if we keep a tight bug:typo coupling23:57
NobodyCamJayF: updated Ty23:57
JayFwe can break recorsd for openstack bugfixes!23:57
JayF:P23:57
jroll/kick JayF stahp23:57
kylestevlol23:58
kylestevJayF: don't encourage the intern23:58
« Monday, 2014-09-01 Index Wednesday, 2014-09-03 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!