| jroll | or that's him beating the person that broke it | 00:00 |
|---|---|---|
| jroll | hard to tell | 00:00 |
| *** achanda has quit IRC | 00:01 | |
| mrda | NobodyCam: earlier today you were pinging me in channel. Did you need something from me? | 00:01 |
| openstackgerrit | A change was merged to openstack/ironic: Set ssh_virt_type to vmware https://review.openstack.org/116151 | 00:07 |
| NobodyCam | mrda: we covered it the meeting :) | 00:15 |
| mrda | kk | 00:16 |
| *** HenryG_ is now known as HenryG | 00:16 | |
| jroll | why oh why did I let myself take this on https://bugs.launchpad.net/ironic/+bug/1300939 | 00:19 |
| * jroll wonders when translation actually happens | 00:21 | |
| jroll | wonder if we should be doing this https://github.com/openstack/oslo.i18n/blob/master/oslo/i18n/_lazy.py#L24 | 00:24 |
| jroll | after that one patch lands to import _ from oslo.i18n | 00:24 |
| * jroll tries some stuff | 00:25 | |
| kylestev | i find it odd that this is valid python https://gist.github.com/kylestev/5ad035c54ffcd317eb7d | 00:31 |
| jroll | why | 00:33 |
| kylestev | having logic inside a class to define methods | 00:34 |
| jroll | well | 00:34 |
| jroll | that method won't be accessible with an instance of that class, I think | 00:34 |
| kylestev | right | 00:34 |
| openstackgerrit | A change was merged to openstack/ironic: Set PYTHONHASHSEED for venv tox environment https://review.openstack.org/116713 | 00:38 |
| jroll | whee. | 00:38 |
| jroll | NobodyCam: ^^ | 00:38 |
| *** mitz has joined #openstack-ironic | 00:53 | |
| openstackgerrit | A change was merged to openstack/ironic: Add driver name on driver load exception https://review.openstack.org/112049 | 01:05 |
| mrda | w00t! | 01:07 |
| * mrda doesn't understand why PYTHONHASHSEED affects sphinx, but glad this is over with | 01:08 | |
| *** chenglch has joined #openstack-ironic | 01:27 | |
| *** eghobo has quit IRC | 01:31 | |
| *** dlaube has quit IRC | 01:34 | |
| *** nosnos has joined #openstack-ironic | 01:44 | |
| *** Poornima_ has joined #openstack-ironic | 01:46 | |
| *** shakamunyi has quit IRC | 02:05 | |
| *** ryanpetrello has quit IRC | 02:21 | |
| *** shakamunyi has joined #openstack-ironic | 02:23 | |
| *** rushiagr_away is now known as rushiagr | 02:24 | |
| *** rushiagr is now known as rushiagr_away | 02:25 | |
| *** ryanpetrello has joined #openstack-ironic | 02:28 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Clean up image build script https://review.openstack.org/116742 | 02:44 |
| *** pcrews has quit IRC | 02:47 | |
| *** dlaube has joined #openstack-ironic | 02:48 | |
| *** nosnos has quit IRC | 02:54 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/115600 | 02:54 |
| *** radsy has quit IRC | 02:55 | |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Nova review updates for _node_resource https://review.openstack.org/116772 | 03:16 |
| mrda | Hey Ironic cores - I have a quick review that I wouldn't mind your eyeballs on - https://review.openstack.org/116772. This is a Ironic driver change that needs to go into Nova. | 03:20 |
| *** pcrews has joined #openstack-ironic | 03:20 | |
| *** pcrews has quit IRC | 03:25 | |
| *** rloo has quit IRC | 03:28 | |
| *** Poornima_ has quit IRC | 03:31 | |
| *** bmahalakshmi has joined #openstack-ironic | 03:38 | |
| NobodyCam | mrda: have you tested that patch? | 03:43 |
| openstackgerrit | A change was merged to openstack/ironic: Take iSCSI deploy out of pxe driver https://review.openstack.org/111232 | 03:45 |
| openstackgerrit | A change was merged to openstack/ironic: handle invalid seamicro_api_version https://review.openstack.org/115692 | 03:45 |
| mrda | NobodyCam: playing with it in parallel. It's a pretty simple fix. | 03:45 |
| mrda | NobodyCam: do you have concerns? | 03:45 |
| *** harlowja is now known as harlowja_away | 03:47 | |
| *** harlowja_away is now known as harlowja | 03:48 | |
| *** dlaube has quit IRC | 03:48 | |
| NobodyCam | just looking at https://github.com/openstack/nova/blob/master/nova/compute/arch.py | 03:52 |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Nova review updates for _node_resource https://review.openstack.org/116772 | 03:52 |
| NobodyCam | and didn't see i386 | 03:52 |
| NobodyCam | so wanted to test it with DIB | 03:52 |
| NobodyCam | from DIB seed "cpu_arch": "i386" | 03:53 |
| NobodyCam | thats all | 03:55 |
| NobodyCam | :-p | 03:55 |
| mrda | so canonicalize translates stuff :) | 03:55 |
| mrda | if newname in ("i386", "i486", "i586"): | 03:55 |
| mrda | newname = I686 | 03:55 |
| *** eghobo has joined #openstack-ironic | 03:56 | |
| NobodyCam | :) | 03:56 |
| mrda | so I think NobodyCam that's ok, unless there's some black magic I don't know about :) | 03:56 |
| NobodyCam | check-tripleo-ironic-undercloud-precise-nonha failed | 03:56 |
| NobodyCam | lol | 03:56 |
| NobodyCam | I have not looked in to as why | 03:56 |
| NobodyCam | prob nothing to do with the patch | 03:56 |
| mrda | probably | 03:57 |
| NobodyCam | but would want to check | 03:57 |
| NobodyCam | lol | 03:57 |
| NobodyCam | :-p | 03:57 |
| mrda | but once I get the new patch series up for nova review I can take a look | 03:57 |
| mrda | but patch-monkeying is the priority right now | 03:57 |
| mrda | :) | 03:57 |
| NobodyCam | and I will test it tomorrow :) | 03:57 |
| mrda | This fix is noted as something I'll have to add back in as a future patch | 03:57 |
| mrda | NobodyCam: Isn't it way past beer o'clock by now? | 03:58 |
| NobodyCam | ack :) | 03:58 |
| NobodyCam | oh yes it is | 03:58 |
| mrda | you should do something about that ;) | 03:58 |
| NobodyCam | lol thats why I am not attempting to test it now | 03:58 |
| mrda | :) | 03:58 |
| *** Poornima_ has joined #openstack-ironic | 04:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/115600 | 04:06 |
| *** nosnos has joined #openstack-ironic | 04:12 | |
| *** ramineni has joined #openstack-ironic | 04:39 | |
| *** rakesh_hs has joined #openstack-ironic | 04:41 | |
| *** bmahalakshmi has quit IRC | 05:03 | |
| *** nikunj2512 has joined #openstack-ironic | 05:09 | |
| *** shakamunyi has quit IRC | 05:16 | |
| GheRivero | morning all | 05:22 |
| *** eghobo has quit IRC | 05:42 | |
| *** eghobo has joined #openstack-ironic | 05:50 | |
| *** k4n0 has joined #openstack-ironic | 05:57 | |
| mrda | Morning GheRivero | 06:00 |
| mrda | NobodyCam: Just FYI, on a subsequent run the tripleo job passed for 116772, so feel free to approve :) | 06:01 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/115878 | 06:10 |
| *** lazy_prince has quit IRC | 06:17 | |
| *** eghobo has quit IRC | 06:18 | |
| *** rameshg87 has joined #openstack-ironic | 06:25 | |
| *** dvorak has quit IRC | 06:29 | |
| *** killer_prince has joined #openstack-ironic | 06:30 | |
| *** killer_prince is now known as lazy_prince | 06:30 | |
| *** harlowja is now known as harlowja_away | 06:31 | |
| *** ndipanov has joined #openstack-ironic | 06:34 | |
| *** rushiagr_away is now known as rushiagr | 07:02 | |
| *** jcoufal has joined #openstack-ironic | 07:17 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic https://review.openstack.org/114357 | 07:25 |
| *** viktors|afk has quit IRC | 07:37 | |
| *** jistr has joined #openstack-ironic | 07:55 | |
| *** lucasagomes has joined #openstack-ironic | 08:13 | |
| *** Alexei_987 has joined #openstack-ironic | 08:14 | |
| *** Shrews has quit IRC | 08:18 | |
| *** derekh has joined #openstack-ironic | 08:23 | |
| *** dtantsur|afk is now known as dtantsur | 08:29 | |
| dtantsur | Late morning, Ironic! | 08:30 |
| *** Shrews has joined #openstack-ironic | 08:35 | |
| rameshg87 | dtantsur, good morning :) | 08:39 |
| dtantsur | o/ | 08:39 |
| rameshg87 | dtantsur, i have a question for you straight away | 08:39 |
| dtantsur | sure | 08:39 |
| rameshg87 | dtantsur, since rloo is not there i just wanted to check with you (because i thought you might be against it) | 08:40 |
| rameshg87 | dtantsur, https://review.openstack.org/#/c/105413/13/ironic/common/images.py | 08:40 |
| rameshg87 | dtantsur, L78-L113, i have the fat create image method. this can throw a variety of excepetions like OSError, IOError, ProcessExecutionError, etc | 08:41 |
| dtantsur | hmmm lemme think | 08:41 |
| rameshg87 | dtantsur, would it be okay if i just catch it in a *big* try block ? | 08:42 |
| rameshg87 | dtantsur, just thinking for this because the code will become messy otherwise | 08:42 |
| dtantsur | well... | 08:43 |
| dtantsur | it makes sense for create_vfat_image and create_isolinux_image to reraise _expected_ exceptions as smth like ImageCreationFailed | 08:44 |
| dtantsur | I highlight word expected, because I'm still opposed to cover everything in a big try.. except Exception.. block | 08:45 |
| dtantsur | that means, if we absolutely _have_ to do it - let it be | 08:45 |
| rameshg87 | dtantsur, yeah ImageCreationFailed is what i am thinking too..but do you just to catch the name the *expected* ones only | 08:45 |
| dtantsur | but likely we can try to either predict exception types or do it on smaller peaces | 08:45 |
| dtantsur | rameshg87, look: utils.{dd,mount,umount,mkfs} are expected to raise some set of exception | 08:46 |
| rameshg87 | dtantsur, yes ProcessExecutionError | 08:47 |
| dtantsur | rameshg87, on the contrary, I doubt we expect something from _generate_isolinux_cfg | 08:47 |
| rameshg87 | dtantsur, no, we don't | 08:47 |
| rameshg87 | dtantsur, and may be an IOError from writing the file | 08:47 |
| dtantsur | we have to convert exception from utils.{...}, but I don't particularly like cover everything in one big block | 08:47 |
| rameshg87 | dtantsur, so small pieces more favourable ? | 08:48 |
| rameshg87 | dtantsur, and let it go a *little* messy :) | 08:48 |
| dtantsur | to me - yes. I know that's annoying, but debugability is an important concern :) | 08:48 |
| dtantsur | of course you may want to sync with rloo on this in the evening | 08:49 |
| rameshg87 | dtantsur, okay will do..rloo s main concern was to convert the exceptions. so let me make the changes anyway and let you and rloo have a look at my code :) | 08:50 |
| dtantsur | rameshg87, ack. left a comment | 08:51 |
| rameshg87 | dtantsur, thanks :) | 08:52 |
| *** fishcried has joined #openstack-ironic | 08:54 | |
| *** MattMan has quit IRC | 08:54 | |
| *** MattMan has joined #openstack-ironic | 08:55 | |
| *** MattMan has left #openstack-ironic | 08:55 | |
| *** MattMan has joined #openstack-ironic | 08:56 | |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Implement hardware discovery setup in PXE driver https://review.openstack.org/110031 | 09:11 |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Endpoint for accepting discovered data https://review.openstack.org/116003 | 09:11 |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Add newly_discovered column to Node object https://review.openstack.org/107389 | 09:11 |
| *** pelix1 has joined #openstack-ironic | 09:16 | |
| *** viktors has joined #openstack-ironic | 09:22 | |
| *** dtantsur is now known as dtantsur|brb | 09:41 | |
| *** fishcried has quit IRC | 10:04 | |
| *** vdrok_away is now known as vdrok | 10:17 | |
| openstackgerrit | A change was merged to openstack/ironic: Add management interface for agent drivers https://review.openstack.org/116241 | 10:20 |
| *** tatyana has joined #openstack-ironic | 10:23 | |
| *** dtantsur|brb is now known as dtantsur | 10:47 | |
| *** athomas has joined #openstack-ironic | 11:06 | |
| *** nikunj2512 has quit IRC | 11:06 | |
| *** chenglch has quit IRC | 11:14 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for creating vfat and iso images https://review.openstack.org/105413 | 11:18 |
| GheRivero | lucasagomes: ping | 11:19 |
| lucasagomes | GheRivero, hey poing | 11:21 |
| lucasagomes | pong* | 11:22 |
| mrda | hey lucasagomes ;) | 11:23 |
| lucasagomes | morning mrda | 11:23 |
| GheRivero | lucasagomes: did you take a look to the db migraton tests bug? I know you were talking about that some days ago in the channel | 11:24 |
| lucasagomes | GheRivero, I saw ur comments and the link you posted showing it's running on gate | 11:24 |
| lucasagomes | but I didn't look at it closer than that | 11:25 |
| GheRivero | ah ok. Whenever you want, ping me back about that. | 11:25 |
| lucasagomes | GheRivero, ack, thanks for that! | 11:27 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for interacting with swift https://review.openstack.org/105795 | 11:35 |
| *** rameshg87 has quit IRC | 11:35 | |
| *** foexle has joined #openstack-ironic | 11:36 | |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Translator functions cleanup https://review.openstack.org/116303 | 11:42 |
| *** rushiagr is now known as rushiagr_away | 11:58 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: DRAC wsman_{enumerate, invoke}() to return an ElementTree object https://review.openstack.org/116871 | 12:02 |
| lucasagomes | ifarkas, ^ | 12:02 |
| ifarkas | lucasagomes, great job! | 12:03 |
| *** lucasagomes is now known as lucas-hungry | 12:03 | |
| lucas-hungry | ifarkas, I tested locally it works, I think that facilitate a lot to have the whole XML at once | 12:03 |
| lucas-hungry | be back, lunch time | 12:03 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Chech ERROR state from driver in _do_sync_power_state https://review.openstack.org/116876 | 12:19 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Check ERROR state from driver in _do_sync_power_state https://review.openstack.org/116876 | 12:21 |
| *** Poornima_ has quit IRC | 12:24 | |
| *** ndipanov has quit IRC | 12:38 | |
| *** lucas-hungry is now known as lucasagomes | 12:44 | |
| *** dvorak has joined #openstack-ironic | 12:46 | |
| *** nosnos has quit IRC | 12:46 | |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Remove gettextutils _ injection https://review.openstack.org/110634 | 12:47 |
| *** dlaube has joined #openstack-ironic | 12:49 | |
| *** k4n0 has quit IRC | 12:49 | |
| *** tzumainn has quit IRC | 12:58 | |
| *** tzumainn has joined #openstack-ironic | 12:58 | |
| *** stelfer has joined #openstack-ironic | 13:10 | |
| *** ifarkas has quit IRC | 13:11 | |
| dtantsur | lucasagomes and others, when are we having hangout, 3pm UTC? | 13:15 |
| romcheg | Hi all! | 13:16 |
| romcheg | It's been a while | 13:16 |
| lucasagomes | dtantsur, yeah I think that's a good time, let's see when other join | 13:16 |
| dtantsur | romcheg, welcome back! | 13:16 |
| * lucasagomes would like to do it tomorrow if possible, trying to finish the DRAC stuff | 13:16 | |
| *** linggao has joined #openstack-ironic | 13:16 | |
| *** ifarkas has joined #openstack-ironic | 13:17 | |
| mrda | night ironic, time for zZz | 13:19 |
| dtantsur | mrda, g'night | 13:20 |
| *** rameshg87 has joined #openstack-ironic | 13:24 | |
| lucasagomes | mrda, g'night | 13:28 |
| *** tatyana has quit IRC | 13:28 | |
| *** tatyana has joined #openstack-ironic | 13:28 | |
| *** rakesh_hs2 has joined #openstack-ironic | 13:32 | |
| *** rakesh_hs has quit IRC | 13:33 | |
| *** pcrews has joined #openstack-ironic | 13:35 | |
| Shrews | oh, the review jam is done via hangout? | 13:39 |
| *** tatyana has quit IRC | 13:42 | |
| *** rakesh_hs has joined #openstack-ironic | 13:43 | |
| *** rakesh_hs2 has quit IRC | 13:44 | |
| lucasagomes | romcheg, hey there, yup long time! how was the holidays? | 13:51 |
| romcheg | lucasagomes: it was a very nice trip. And you were right, Spanish really helps in Portugal :) | 13:52 |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Translator functions cleanup https://review.openstack.org/116303 | 13:52 |
| lucasagomes | romcheg, hah indeed it does | 13:52 |
| *** pelix1 is now known as help | 13:58 | |
| *** help is now known as pelix1 | 13:59 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Clean up image build script https://review.openstack.org/116742 | 14:10 |
| jroll | good morning ironic :) | 14:10 |
| Shrews | morning jroll | 14:11 |
| *** jasondotstar has joined #openstack-ironic | 14:12 | |
| jroll | heya Shrews :) | 14:12 |
| jroll | dtantsur, lucasagomes, we were planning on 1500, yeah, fine with tomorrow as well but would prefer to just get it over with :P | 14:12 |
| lucasagomes | jroll, ack, yeah I will speed up the most I can here, if not I submit the drac stuff tomorrow morning | 14:13 |
| jroll | sounds good, we can fast track it either way | 14:13 |
| lucasagomes | ack :) | 14:14 |
| *** rameshg87 has quit IRC | 14:14 | |
| NobodyCam | morning Ironic | 14:18 |
| jroll | https://review.openstack.org/#/c/116772/2/ironic/nova/virt/ironic/driver.py | 14:18 |
| jroll | morning NobodyCam | 14:19 |
| jroll | :) | 14:19 |
| * NobodyCam awoke to a mess so I'm running a tad late | 14:19 | |
| NobodyCam | morning jroll lucasagomes | 14:19 |
| lucasagomes | morning NobodyCam | 14:19 |
| jroll | NobodyCam: #dogloverproblems | 14:20 |
| NobodyCam | jroll: yep :( | 14:21 |
| dtantsur | jroll, morning. I'm ok with today (it's in 40 minutes, right?), though also prefer tomorrow | 14:22 |
| dtantsur | NobodyCam, morning as well :) | 14:22 |
| jroll | morning dtantsur :) | 14:23 |
| jroll | NobodyCam: https://i.imgur.com/lxXk46g.gif | 14:29 |
| jroll | you need one of those to keep the dogs out of things that don't belong to them :P | 14:30 |
| *** ekarlso has quit IRC | 14:31 | |
| NobodyCam | jroll: lol | 14:33 |
| *** rakesh_hs has quit IRC | 14:33 | |
| *** rameshg87 has joined #openstack-ironic | 14:37 | |
| *** vdrok is now known as vdrok_away | 14:38 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: IloVirtualMediaIscsi deploy driver https://review.openstack.org/113865 | 14:39 |
| *** rameshg87 has quit IRC | 14:45 | |
| lucasagomes | jroll, hah that's team work | 14:50 |
| jroll | :P | 14:50 |
| lucasagomes | I saw a gif this week I loled hard... it's a bit mean but super funny | 14:52 |
| lucasagomes | lemme find it | 14:52 |
| lucasagomes | http://goo.gl/21Ns7L | 14:52 |
| lucasagomes | hah | 14:52 |
| jroll | hahahaha | 14:53 |
| NobodyCam | oh thats bad :-p | 14:54 |
| NobodyCam | is our gate working? | 14:54 |
| lucasagomes | NobodyCam, yup | 14:55 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: DRAC wsman_{enumerate, invoke}() to return an ElementTree object https://review.openstack.org/116871 | 14:55 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Implements the DRAC ManagementInterface for get/set boot device https://review.openstack.org/116913 | 14:55 |
| lucasagomes | need tests still ^ (the last one) | 14:55 |
| NobodyCam | lucasagomes: monday is a US holiday, I may not have internets | 14:57 |
| lucasagomes | NobodyCam, right u want me to run the meeting? | 14:57 |
| NobodyCam | would you be able to host (chair) the meeting for all the non US folks | 14:57 |
| NobodyCam | :) | 14:57 |
| lucasagomes | if we have enough people | 14:57 |
| lucasagomes | NobodyCam, sure | 14:57 |
| NobodyCam | perfect :) | 14:57 |
| lucasagomes | np | 14:57 |
| NobodyCam | TY | 14:58 |
| jroll | ugh, hate comcast | 15:01 |
| jroll | wired network is fine, has internet | 15:02 |
| jroll | wireless works on lan but not wan | 15:02 |
| NobodyCam | :( | 15:02 |
| NobodyCam | jroll: was just looking over your comments on 116772 | 15:02 |
| *** stelfer has quit IRC | 15:02 | |
| lucasagomes | review jam time? | 15:02 |
| jroll | no webcam on desktop, no wire long enough for laptop | 15:02 |
| jroll | :| | 15:02 |
| JayF | So how do the jams usually happen? Over G+ or what? | 15:03 |
| NobodyCam | si | 15:03 |
| jroll | yeah | 15:03 |
| jroll | morning JayF | 15:03 |
| JayF | g'morning | 15:03 |
| NobodyCam | morning JayF | 15:03 |
| NobodyCam | lucasagomes: dtantsur up for a jam? | 15:03 |
| lucasagomes | JayF, yup usually a google hangout | 15:03 |
| NobodyCam | no rloo this morning | 15:04 |
| * jroll starts a hangout | 15:04 | |
| dtantsur | NobodyCam, yep | 15:04 |
| NobodyCam | :) awesome | 15:04 |
| dtantsur | oh one sec, moving to enclave | 15:04 |
| NobodyCam | moving to a cave? | 15:04 |
| NobodyCam | lol | 15:04 |
| jroll | ^^ | 15:05 |
| jroll | that's what I heard | 15:05 |
| * lucasagomes stops the music | 15:05 | |
| jroll | https://plus.google.com/hangouts/_/gzlzo4tkee7u7cmxcvzhkxouoya | 15:05 |
| JayF | just don't go to burning man | 15:05 |
| jroll | NobodyCam JayF lucasagomes dtantsur etc | 15:05 |
| JayF | you'll get washed away | 15:05 |
| jroll | no, do go to burning man | 15:05 |
| lucasagomes | lifeless, ping, when you get a time please take a look at https://review.openstack.org/#/c/116772 (will that affects OOO somehow?) | 15:08 |
| jroll | I'm going to reboot, guys, idk what's wrong :( | 15:12 |
| jroll | NobodyCam: ^^ | 15:13 |
| jroll | also, ellen said she might not be able to do much with that patch until early september... I might take it just to make sure it gets through j3 ok | 15:14 |
| *** viktors is now known as viktors|afk | 15:21 | |
| *** ekarlso has joined #openstack-ironic | 15:29 | |
| *** ekarlso has quit IRC | 15:40 | |
| *** lazy_prince is now known as killer_prince | 15:40 | |
| *** ekarlso has joined #openstack-ironic | 15:40 | |
| *** athomas has quit IRC | 15:50 | |
| *** athomas has joined #openstack-ironic | 15:51 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for creating vfat and iso images https://review.openstack.org/105413 | 15:51 |
| *** athomas has quit IRC | 15:52 | |
| *** pcrews has quit IRC | 15:54 | |
| NobodyCam | https://etherpad.openstack.org/p/IIe0cnnJ5L | 15:54 |
| *** romcheg1 has joined #openstack-ironic | 15:57 | |
| *** romcheg1 has left #openstack-ironic | 15:57 | |
| *** jcoufal has quit IRC | 16:09 | |
| *** foexle has quit IRC | 16:19 | |
| *** eghobo has joined #openstack-ironic | 16:21 | |
| *** eghobo has quit IRC | 16:22 | |
| *** eghobo has joined #openstack-ironic | 16:22 | |
| *** Alexei_987 has quit IRC | 16:29 | |
| *** pcrews has joined #openstack-ironic | 16:33 | |
| Shrews | ugh | 16:33 |
| * JayF hands Shrews google.com/chrome | 16:34 | |
| * Shrews installs | 16:34 | |
| *** derekh has quit IRC | 16:36 | |
| *** pcrews has quit IRC | 16:39 | |
| Shrews | oh great. browser freeze | 16:40 |
| * Shrews cries | 16:40 | |
| jroll | :( | 16:43 |
| * kylestev is starting to appreciate the value of specs | 16:45 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/115600 | 16:46 |
| jroll | kylestev: uh oh | 16:58 |
| kylestev | jroll: I didn't say I enjoy writing them | 16:58 |
| kylestev | just that I can see value :P | 16:59 |
| *** rushiagr_away is now known as rushiagr | 17:00 | |
| *** killer_prince has quit IRC | 17:01 | |
| *** killer_prince has joined #openstack-ironic | 17:04 | |
| *** killer_prince is now known as lazy_prince | 17:04 | |
| *** jistr has quit IRC | 17:07 | |
| *** harlowja_away is now known as harlowja | 17:15 | |
| jroll | NobodyCam: still on your call? | 17:19 |
| *** chuckC has quit IRC | 17:19 | |
| jroll | NobodyCam: line 141 :/ https://review.openstack.org/#/c/113865/10/ironic/drivers/modules/ilo/power.py | 17:20 |
| NobodyCam | I am back | 17:23 |
| * NobodyCam looks | 17:23 | |
| *** pcrews has joined #openstack-ironic | 17:23 | |
| NobodyCam | jroll: humm seems lucas commented on it too | 17:25 |
| jroll | yeah, we were just talking about no idea how to do that | 17:26 |
| jroll | in a good way | 17:26 |
| *** bmahalakshmi has joined #openstack-ironic | 17:26 | |
| NobodyCam | yea I think thats only needed for deploy | 17:28 |
| *** penick has joined #openstack-ironic | 17:34 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: DRAC wsman_{enumerate, invoke}() to return an ElementTree object https://review.openstack.org/116871 | 17:35 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Implements the DRAC ManagementInterface for get/set boot device https://review.openstack.org/116913 | 17:35 |
| *** penick has quit IRC | 17:36 | |
| lucasagomes | alright I'm going now, have a good night everybody | 17:37 |
| *** lucasagomes is now known as lucas-dinner | 17:37 | |
| NobodyCam | have a good night lucas-dinner :) | 17:37 |
| JayF | goodnight | 17:37 |
| jroll | night lucas-dinner :) | 17:39 |
| *** rameshg87 has joined #openstack-ironic | 17:42 | |
| *** bmahalakshmi has quit IRC | 17:44 | |
| rameshg87 | jroll, hi | 17:48 |
| jroll | hiya rameshg87 | 17:48 |
| rameshg87 | jroll, have one question about a comment on https://review.openstack.org/#/c/105795/13/ironic/common/swift.py - L68 | 17:49 |
| jroll | rameshg87: what's the question | 17:50 |
| *** penick has joined #openstack-ironic | 17:50 | |
| *** lynxman has quit IRC | 17:50 | |
| *** lynxman has joined #openstack-ironic | 17:50 | |
| rameshg87 | jroll, i agree we shouldn't hardcode it. | 17:52 |
| rameshg87 | jroll, but seems like ironic is already doing it here: https://github.com/openstack/ironic/blob/master/ironic/common/keystone.py#L40-L43 | 17:52 |
| jroll | ughhhhhhhhhhhhhh | 17:52 |
| rameshg87 | jroll, i am thinking we can just have it only at this place at keystone.py | 17:53 |
| rameshg87 | jroll, i can just call keystone.get_service_url(service_type='identity') to get this | 17:54 |
| jroll | we should at least do it the same way | 17:54 |
| jroll | maybe | 17:54 |
| jroll | eh, not everyone has a working service catalog | 17:54 |
| jroll | maybe | 17:54 |
| jroll | idk | 17:54 |
| JayF | why not just factor out that part in get_service_url? | 17:54 |
| JayF | get_keystone_url() returns the assembled url | 17:54 |
| jroll | yeah | 17:54 |
| JayF | get_service_url and the swift stuff both use that | 17:54 |
| jroll | JayF++ | 17:55 |
| JayF | we isolate the crappy code behind an abstraction so we can make it better later | 17:55 |
| rameshg87 | JayF, jroll, yeah that seems better :) | 17:55 |
| rameshg87 | JayF, jroll, but why are we not having it in auth_uri itself | 17:58 |
| rameshg87 | JayF, jroll, any idea ? | 17:58 |
| jroll | no idea | 17:58 |
| JayF | There was some talk of why in the review jam | 17:58 |
| JayF | it sounded like something historical? IDK for sure, but isolating the behavior behind that function would be a good first step to fixing that | 17:58 |
| rameshg87 | JayF, okay | 17:59 |
| *** igordcard has joined #openstack-ironic | 18:00 | |
| *** romcheg1 has joined #openstack-ironic | 18:01 | |
| *** pelix1 has quit IRC | 18:01 | |
| *** chuckC has joined #openstack-ironic | 18:03 | |
| *** lynxman has quit IRC | 18:08 | |
| *** lynxman has joined #openstack-ironic | 18:09 | |
| *** dlaube has quit IRC | 18:14 | |
| *** dlaube has joined #openstack-ironic | 18:20 | |
| NobodyCam | ok /me is back and seated :-p | 18:20 |
| NobodyCam | how did the jam go? anything for /me to review? | 18:21 |
| *** penick has quit IRC | 18:23 | |
| JayF | It kinda tuckered out after the ilo-iscsi review | 18:23 |
| NobodyCam | :) I saw rameshg87 is already on those :) | 18:24 |
| rameshg87 | NobodyCam, JayF, :) | 18:25 |
| NobodyCam | rameshg87: your doing an awesome job!!! Thank you :) | 18:26 |
| rameshg87 | NobodyCam, thanks :) | 18:26 |
| rameshg87 | thanks a lot everyone for all the review comments. i am just trying to address them as soon as i can and give it for review again :) | 18:29 |
| NobodyCam | rameshg87: just fyi once zuul passes on 105413 I'll be landing it | 18:30 |
| *** tatyana has joined #openstack-ironic | 18:30 | |
| rameshg87 | NobodyCam, thanks | 18:30 |
| NobodyCam | :) the first in the chain :) | 18:31 |
| rameshg87 | NobodyCam, but the first in the chain landed yesterday.https://review.openstack.org/111232 | 18:32 |
| NobodyCam | doh | 18:32 |
| NobodyCam | okay the second :-p | 18:32 |
| rameshg87 | NobodyCam, :) | 18:32 |
| *** penick has joined #openstack-ironic | 18:34 | |
| adam_g | anyone have some cycles to spare on reviewing the nova-bm -> ironic migration script? the grenade work is about to be blocked in its landing: https://review.openstack.org/#/c/112402/ | 18:35 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for interacting with swift https://review.openstack.org/105795 | 18:40 |
| jroll | adam_g: I can take a look in a bit... I tend to not really care about code quality for that, and more just if it works or not | 18:41 |
| jroll | (which I'm in no position to actually test) | 18:41 |
| *** rushiagr is now known as rushiagr_away | 18:45 | |
| NobodyCam | adam_g: ??? H302 import only modules.'from ironic.migrate_nova import nova_bm_states as nova_states' | 18:47 |
| NobodyCam | pep8 error | 18:47 |
| adam_g | oh hmph | 18:47 |
| NobodyCam | lol that was a quick review | 18:47 |
| adam_g | renamed a file | 18:47 |
| NobodyCam | :-p | 18:47 |
| adam_g | didn't update the import :) | 18:47 |
| NobodyCam | hehehehe | 18:47 |
| NobodyCam | J/k | 18:47 |
| openstackgerrit | Adam Gandelman proposed a change to openstack/ironic: Script to migrate Nova BM data to Ironic https://review.openstack.org/112402 | 18:54 |
| *** jasondotstar has quit IRC | 18:56 | |
| *** penick has quit IRC | 18:59 | |
| lifeless | lucas-dinner: I suspect it will | 19:04 |
| jroll | your afternoon entertainment: http://www.google.com/teapot | 19:05 |
| jroll | tip your laptop/phone | 19:05 |
| *** penick has joined #openstack-ironic | 19:05 | |
| *** harlowja has quit IRC | 19:06 | |
| NobodyCam | lol works if I click on it | 19:08 |
| JayF | yeah same | 19:08 |
| *** harlowja has joined #openstack-ironic | 19:08 | |
| jroll | not as fun :( | 19:08 |
| *** jistr has joined #openstack-ironic | 19:14 | |
| NobodyCam | brb | 19:28 |
| *** tatyana has quit IRC | 19:29 | |
| JayF | russell_h JoshNang: or any ironic cores, IPA fixes for build that jroll needs to get in for testing ipa in infra --> https://review.openstack.org/#/c/116742/4 | 19:33 |
| JayF | it lgtm and the build successfully completed in the check job | 19:34 |
| JayF | needs +2a | 19:34 |
| NobodyCam | assuming dependencies are installed | 19:40 |
| NobodyCam | is that not what sudo pip install -r requirements.txt is for? | 19:41 |
| *** jrist_ is now known as jrist | 19:41 | |
| JayF | NobodyCam: right now our coreos-oem-inject.py script to build ipa image contains different requirements than IPA (not compatible with global-req either) | 19:42 |
| JayF | NobodyCam: it's something that's 'we need to eventually fix this' and I think I actually filed a bug about it | 19:42 |
| JayF | so we have to specifically do a install of requirements.txt during the build -- but it's the requirements.txt for the coreos builder | 19:42 |
| NobodyCam | oh then I'd have to ask that he bug # be included there | 19:42 |
| NobodyCam | jroll: would you kill me if I asked for a note about ^^^^^^^^ | 19:43 |
| NobodyCam | oh this is the IPA repo | 19:44 |
| NobodyCam | heck I'll land anything there (j/k) | 19:44 |
| NobodyCam | :> *smerk* | 19:44 |
| NobodyCam | JayF: I would ask for a comment be added for the Ironic repo | 19:45 |
| NobodyCam | but its really minnor to getting testing going | 19:45 |
| JayF | If you think it's important, put the comment on it | 19:46 |
| JayF | just be ready to add your +2 once I ninja-fix it because I think jroll isn't around right now :P | 19:46 |
| NobodyCam | ahh | 19:46 |
| JayF | I <3 good reviews and more iterations, as long as latency is low | 19:46 |
| JayF | I only mind comments on code reviews when the person who makes them doesn't look again when I fix | 19:46 |
| JoshNang | JayF: is the symlink "sudo ln -sf /usr/bin/docker.io /usr/local/bin/docker" to support ubuntu 12.04 and 14.04? | 19:47 |
| JayF | it's because the docker package packaged by ubuntu | 19:48 |
| JayF | the binary is called 'docker.io' because apparently some older app owned 'docker' on ubuntu from some older release | 19:48 |
| JayF | so we symlink it to docker | 19:48 |
| JayF | on fedora 20 the binary is already named docker so np | 19:48 |
| JayF | that's actually verbatim from the docker.io install guide :) | 19:48 |
| JayF | (the symlink) | 19:49 |
| JoshNang | gotcha! | 19:49 |
| NobodyCam | JayF: comment posted. ready with +2 | 19:49 |
| NobodyCam | brb | 19:54 |
| *** penick has quit IRC | 19:58 | |
| linggao | Hi Ironic. I reinstalled my dev machine and now cannot do the git review. | 19:58 |
| linggao | got the following error: | 19:58 |
| linggao | git review -s | 19:58 |
| linggao | Problems encountered installing commit-msg hook | 19:58 |
| linggao | Permission denied (publickey). | 19:58 |
| linggao | I put the new public key on https://review.openstack.org/#/settings/ssh-keys | 19:59 |
| linggao | still have the same problem. Does anyone know how to resolve it? | 20:00 |
| *** penick has joined #openstack-ironic | 20:01 | |
| NobodyCam | linggao: sounds like you didn't put your LP key on your dev system? | 20:02 |
| linggao | NobodyCam, where is the LP key? | 20:03 |
| NobodyCam | linggao: these https://launchpad.net/~linggao | 20:04 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Clean up image build script https://review.openstack.org/116742 | 20:04 |
| *** shakamunyi has joined #openstack-ironic | 20:04 | |
| JayF | NobodyCam: JoshNang ^^^ | 20:04 |
| *** jistr has quit IRC | 20:06 | |
| JoshNang | JayF: +2 | 20:07 |
| NobodyCam | JayF: -1'd :( | 20:07 |
| JayF | NobodyCam: khaaaannnnnn | 20:07 |
| NobodyCam | it shouldn't pass pep8 like that | 20:08 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Clean up image build script https://review.openstack.org/116742 | 20:08 |
| NobodyCam | lol | 20:08 |
| JayF | NobodyCam: I'd suggest you... not look at whether or not any of the pep8 jobs run inside imagebuild/ | 20:08 |
| JayF | JoshNang: ^ you can re-review | 20:09 |
| NobodyCam | lol | 20:10 |
| NobodyCam | JayF: +2'd left comment go to +a after mr J blesses :) | 20:10 |
| JoshNang | ahh i saw that and thought to myself "eh, the automated tools don't care, i guess it's not a big deal" | 20:10 |
| NobodyCam | lol | 20:10 |
| NobodyCam | brb again | 20:11 |
| NobodyCam | need to run to the store | 20:11 |
| *** shakamunyi has quit IRC | 20:11 | |
| Shrews | adam_g: finally got around to reviewing 112402 for you | 20:21 |
| *** tatyana has joined #openstack-ironic | 20:25 | |
| *** tatyana has quit IRC | 20:25 | |
| chuckC | Shrews: hi | 20:33 |
| Shrews | howdy | 20:33 |
| chuckC | Shrews: hey, I'm working on a neutron bug to allow a port's mac address to be updated | 20:34 |
| chuckC | Shrews: this is to help with situations where a NIC on an ironic server needs to be replaced | 20:34 |
| chuckC | Shrews: I'm trying to understand how neutron ports connected to ironic server nics work | 20:35 |
| chuckC | Shrews: In my tripleo undercloud, I have 3 ironic servers, and all ports on them show status DOWN | 20:36 |
| chuckC | Shrews: is that normal? | 20:37 |
| chuckC | Shrews: all the ports work fine, however | 20:37 |
| Shrews | hrm, i seem to recall someone else mentioning the ports showing as DOWN a while back | 20:39 |
| Shrews | NobodyCam: weren't you looking at that? | 20:39 |
| Shrews | i think it was "normal", but "incorrect" | 20:39 |
| Shrews | iirc | 20:40 |
| Shrews | i.e., we weren't updating neutron correctly or some such thing | 20:40 |
| chuckC | Shrews: if I can rely on that, then I can avoid unfortunate side-affects with normal VM nics | 20:40 |
| chuckC | Shrews: or if there's some other way to identify a port as attached to an ironic nic | 20:41 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: IloVirtualMediaIscsi deploy driver https://review.openstack.org/113865 | 20:41 |
| *** jistr has joined #openstack-ironic | 20:42 | |
| chuckC | Shrews: I also see device_owner as "compute:None" | 20:43 |
| *** rameshg87 has quit IRC | 20:43 | |
| Shrews | chuckC: i'm not real familiar with the neutron interaction part of the code yet. let's see what NobodyCam says first | 20:43 |
| chuckC | Shrews: sure | 20:44 |
| *** igordcard has quit IRC | 20:50 | |
| Shrews | chuckC: so, the only sure way i see to relate a neutron port to an ironic node is to compare values from the ironic.ports table ('extra' column will have a neutron port ID for the vif_port_id key) to the neutron.ports table | 20:57 |
| *** romcheg1 has quit IRC | 20:57 | |
| *** romcheg1 has joined #openstack-ironic | 20:57 | |
| Shrews | i wouldn't count on using the DOWN value. not sure what's up with the "compute:None" thing | 20:57 |
| chuckC | Shrews: yeah, all convenient ways to solve my issue seem hack-ish to me | 21:00 |
| Shrews | mysql> select extra from ironic.ports where extra != '{}'\G | 21:01 |
| Shrews | *************************** 1. row *************************** | 21:01 |
| Shrews | extra: {"vif_port_id": "b811c524-dc1b-423c-ae2e-c9b80cd1828f"} | 21:01 |
| Shrews | so, whatever that's worth :) | 21:01 |
| *** linggao has quit IRC | 21:02 | |
| chuckC | Shrews: thanks! not sure about querying ironic from neutron, though…. | 21:02 |
| *** igordcard has joined #openstack-ironic | 21:03 | |
| *** igordcard has quit IRC | 21:04 | |
| chuckC | It looks from the neutron data like the 'agent' plumbing the port failed | 21:06 |
| chuckC | but I suspect there actually is no agent | 21:07 |
| chuckC | adam_g: you've poked around in neutron a bit, do you have any thoughts on ^ | 21:08 |
| * NobodyCam is back | 21:14 | |
| *** foexle has joined #openstack-ironic | 21:14 | |
| NobodyCam | I did look at that and seem to recall it had something to do with the dhcp subnet for the deployed nodes was not a valid subnet in it self | 21:15 |
| NobodyCam | but am not 100% sure that is correct | 21:15 |
| NobodyCam | lol :( | 21:15 |
| *** todd_dsm has joined #openstack-ironic | 21:16 | |
| chuckC | NobodyCam: thanks. Do you know if this is an open bug? | 21:16 |
| NobodyCam | chuckC: not that I recall | 21:17 |
| chuckC | NobodyCam: if a nic on an ironic server fails, does anyone hear it? | 21:19 |
| *** shakamunyi has joined #openstack-ironic | 21:19 | |
| openstackgerrit | A change was merged to openstack/ironic: Add support for creating vfat and iso images https://review.openstack.org/105413 | 21:20 |
| *** jistr has quit IRC | 21:21 | |
| NobodyCam | oh who was testing that? | 21:26 |
| NobodyCam | oh so nice to see a working gate | 21:27 |
| NobodyCam | 116742 still waiting on mr J | 21:29 |
| jroll | JayF: thanks for getting that patch through :) | 21:30 |
| jroll | if a nic on an ironic server fails, throw away the whole server :) | 21:30 |
| NobodyCam | lol | 21:30 |
| NobodyCam | jroll: tossing out any of the 512 gig servers yet? | 21:31 |
| kylestev | i'd be more interested in getting my hands on some of those nitro cards... | 21:31 |
| jroll | NobodyCam: :P | 21:32 |
| jroll | by 'throw away', I mean RMA, but yeah | 21:32 |
| NobodyCam | lol | 21:34 |
| *** harlowja is now known as harlowja_away | 21:43 | |
| mrda | Morning Ironic | 21:45 |
| NobodyCam | morning mrda | 21:46 |
| jroll | goooood morning | 21:46 |
| kylestev | morning | 21:46 |
| mrda | \o | 21:50 |
| mrda | Two more +2's on the driver overnight \o/ | 21:56 |
| jroll | \o/ nice | 21:56 |
| mrda | Still going to be *very* tight | 21:56 |
| jroll | they've probably decided to merge it all and now just messing with you | 21:57 |
| NobodyCam | :) | 21:57 |
| jroll | look over at mikal, he's probably giggling like a little girl | 21:57 |
| mrda | unlikely :) | 21:57 |
| mrda | But it would be nice | 21:58 |
| mrda | I'll have to go rustling nova cores today for more eyeballs | 21:58 |
| *** harlowja_away is now known as harlowja | 22:00 | |
| *** cinerama` is now known as cinerama | 22:00 | |
| *** penick has quit IRC | 22:22 | |
| *** Madasi has quit IRC | 22:22 | |
| *** Hefeweizen has quit IRC | 22:23 | |
| jroll | NobodyCam: good news! | 22:23 |
| *** marios_ has quit IRC | 22:23 | |
| *** GheRivero has quit IRC | 22:23 | |
| jroll | our tests fail with master of python-keystoneclient | 22:23 |
| jroll | so, that's fun | 22:23 |
| *** marios has joined #openstack-ironic | 22:23 | |
| *** GheRivero has joined #openstack-ironic | 22:24 | |
| NobodyCam | good, uggh | 22:24 |
| jroll | I'll look/fix | 22:24 |
| *** Hefeweizen has joined #openstack-ironic | 22:24 | |
| NobodyCam | :) awesome ness Ty | 22:24 |
| *** chuck_ has joined #openstack-ironic | 22:25 | |
| *** slagle_ has joined #openstack-ironic | 22:25 | |
| *** Madasi has joined #openstack-ironic | 22:26 | |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic-specs: Add ZooKeeper SyncManager spec to Kilo specs https://review.openstack.org/117040 | 22:26 |
| *** scubacuda has quit IRC | 22:27 | |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic-specs: Add ZooKeeper SyncManager spec to Kilo specs https://review.openstack.org/117040 | 22:29 |
| *** penick has joined #openstack-ironic | 22:31 | |
| kylestev | NobodyCam: ^ ;) | 22:32 |
| *** dtantsur_ has joined #openstack-ironic | 22:34 | |
| *** dlaube1 has joined #openstack-ironic | 22:36 | |
| *** todd_dsm has quit IRC | 22:36 | |
| *** vdrok_ has joined #openstack-ironic | 22:36 | |
| *** NobodyCa1 has joined #openstack-ironic | 22:37 | |
| *** foexle_ has joined #openstack-ironic | 22:37 | |
| NobodyCa1 | humm | 22:37 |
| NobodyCa1 | that was odd | 22:37 |
| NobodyCa1 | anyone else just get kicked? | 22:37 |
| *** zul has quit IRC | 22:37 | |
| *** mrda has quit IRC | 22:37 | |
| *** slagle has quit IRC | 22:37 | |
| *** dtantsur has quit IRC | 22:37 | |
| *** rainya_ has quit IRC | 22:37 | |
| *** dtantsur_ is now known as dtantsur | 22:37 | |
| *** dlaube1 has quit IRC | 22:38 | |
| *** Shrews_ has joined #openstack-ironic | 22:38 | |
| jroll | NobodyCa1: netsplit? :P | 22:38 |
| NobodyCa1 | looks that way | 22:38 |
| NobodyCa1 | lol | 22:39 |
| NobodyCa1 | 22:37 |-INFO > Irssi: Your nick is owned by Chris Krelle [~NobodyCam@15.125.99.181] | 22:39 |
| NobodyCa1 | 22:38 |-INFO > Nick NobodyCam is already in use | 22:39 |
| NobodyCa1 | that me really | 22:39 |
| jroll | /msg nickserv ghost nobodycam $nickserv_pass | 22:40 |
| jroll | will kill it | 22:40 |
| *** slagle_ has quit IRC | 22:43 | |
| *** foexle has quit IRC | 22:43 | |
| *** dlaube has quit IRC | 22:43 | |
| *** tzumainn has quit IRC | 22:43 | |
| *** Shrews has quit IRC | 22:43 | |
| *** lucas-dinner has quit IRC | 22:43 | |
| *** krtaylor has quit IRC | 22:43 | |
| *** vdrok_away has quit IRC | 22:43 | |
| *** openstackgerrit has quit IRC | 22:43 | |
| *** NobodyCam has quit IRC | 22:43 | |
| *** lsmola has quit IRC | 22:43 | |
| *** greghaynes has quit IRC | 22:43 | |
| *** devananda has quit IRC | 22:43 | |
| *** devananda has joined #openstack-ironic | 22:43 | |
| *** greghaynes has joined #openstack-ironic | 22:44 | |
| *** dguerri has quit IRC | 22:44 | |
| *** krtaylor has joined #openstack-ironic | 22:44 | |
| *** dguerri has joined #openstack-ironic | 22:44 | |
| *** lsmola has joined #openstack-ironic | 22:45 | |
| *** HenryG has quit IRC | 22:46 | |
| *** tzumainn has joined #openstack-ironic | 22:47 | |
| *** NobodyCa1 is now known as NobodyCam | 22:48 | |
| NobodyCam | :) | 22:48 |
| *** lucas-dinner has joined #openstack-ironic | 22:49 | |
| kylestev | nice :P | 22:51 |
| kylestev | so NobodyCam want to take a look at my ZooKeeper and pluggable locking specs? :) | 22:52 |
| JayF | you're going to turn his IRC client into a cookoo clock | 22:52 |
| JayF | ding ding ding ding ding :P | 22:52 |
| JayF | kylestev: that spec needs to be rebased on top of the pluggable locking spec | 22:53 |
| JayF | kylestev: to indicate the dependency | 22:53 |
| kylestev | JayF: ah, I was wondering about that | 22:53 |
| *** dtantsur has quit IRC | 22:55 | |
| *** dtantsur has joined #openstack-ironic | 22:55 | |
| *** lsmola has quit IRC | 22:56 | |
| *** lsmola has joined #openstack-ironic | 22:56 | |
| NobodyCam | lol | 22:56 |
| kylestev | JayF: now git hates me: https://gist.github.com/kylestev/04e05b94e2d9630a96b8 | 22:57 |
| kylestev | maybe my bp/pluggable branch is somehow out of date? | 22:58 |
| * kylestev tries some things | 22:58 | |
| JayF | That's strange. | 22:59 |
| JayF | jroll: wdyt about his gist ^ I consider you our local gerrit/git/rebase all the things expert | 22:59 |
| jroll | wat | 23:00 |
| jroll | one sec | 23:00 |
| jroll | kylestev: so gerrit won't let you upload if nothing changed | 23:02 |
| jroll | so like, put an extra space in or something | 23:02 |
| jroll | JayF: local doesn't mean much when I'm at home :P | 23:03 |
| JayF | that's what I thought, but I hoped I was wrong :( | 23:03 |
| JayF | jroll: you're still pretty close, relative to others in the channel | 23:03 |
| jroll | heh | 23:03 |
| *** mrda has joined #openstack-ironic | 23:04 | |
| kylestev | jroll: I tried that as well | 23:13 |
| jroll | kylestev: on both patches? :) | 23:13 |
| kylestev | jroll: ... | 23:13 |
| jroll | is that a yes? | 23:13 |
| jroll | ... matches yes, so ok | 23:14 |
| jroll | .. for no | 23:14 |
| kylestev | change it the patch on the bp/pluggable and then rebase my ZK branch on top of it? | 23:14 |
| kylestev | ha | 23:14 |
| kylestev | jroll: ^^ | 23:15 |
| JayF | yeah I think so | 23:16 |
| JayF | because that's the patch it complained about when uploading | 23:16 |
| *** lucas-dinner has quit IRC | 23:17 | |
| jroll | kylestev: yeah | 23:17 |
| kylestev | i really messed up my branch... | 23:23 |
| jroll | lol | 23:24 |
| jroll | kylestev: do this, then | 23:24 |
| jroll | git checkout master; git review -X 123; git review -X 456 | 23:24 |
| kylestev | `rm -rf /` ? | 23:24 |
| jroll | where 123 and 456 are your patch numbers | 23:25 |
| jroll | I guess do the review -X stuff on a branch if you prefer | 23:25 |
| *** athomas has joined #openstack-ironic | 23:27 | |
| kylestev | still no dice | 23:27 |
| kylestev | ok... created a new branch | 23:30 |
| jroll | what now | 23:30 |
| kylestev | seems to have fixed it | 23:30 |
| kylestev | same change-id and all that | 23:30 |
| kylestev | but now it magically works? | 23:30 |
| *** fishcried has joined #openstack-ironic | 23:30 | |
| jroll | yay. | 23:30 |
| jroll | probably because rebase | 23:30 |
| kylestev | alright now it's all updated | 23:32 |
| jroll | cool | 23:33 |
| lifeless | mrda: ping | 23:33 |
| lifeless | mrda: lucas pointed me at your patch to use the local node characteristics for capabilities | 23:33 |
| kylestev | how does one with no life ping? | 23:33 |
| lifeless | mrda: that seems 100% wrong for Ironic | 23:33 |
| jroll | lifeless: curious which patch this is | 23:34 |
| lifeless | mrda: since there's absolutely no possibility of an advertised node being influenced by the architecture of the ironic conductor or the nova compute process | 23:34 |
| lifeless | https://review.openstack.org/#/c/116772/ | 23:34 |
| lifeless | jroll: ^ | 23:34 |
| JayF | lifeless: mrda: I agree | 23:34 |
| jroll | lifeless: yeah, agree | 23:34 |
| JayF | we talked about it some in the review jam and that seemed to be consensus | 23:34 |
| JayF | it'd be better to hardcode it than to pull in the one of the nova-compute | 23:34 |
| mrda | lifeless: hello | 23:36 |
| lifeless | mrda: hello - see ^^ | 23:37 |
| mrda | lifeless: you shouldn't be so coy, you should tell me what you really think :) | 23:37 |
| lifeless | mrda: does https://review.openstack.org/#/c/111428/11/nova/virt/ironic/driver.py include that change or its still under discussion ? | 23:37 |
| lifeless | mrda: you know I will :) | 23:37 |
| *** fishcried has quit IRC | 23:37 | |
| mrda | so it's not in the nova patch series | 23:37 |
| *** fishcried has joined #openstack-ironic | 23:38 | |
| mrda | I pushed it here for discussion first (which I do for all but the most trivial change) | 23:38 |
| lifeless | ok cool | 23:38 |
| mrda | so, it's good that we've decided it's not a good way forward | 23:38 |
| mrda | I will need to tell Dan Berrange that his suggestion isn't going to fly | 23:38 |
| mrda | and see what happens :) | 23:39 |
| JayF | Well I'm curious what a better alternative is | 23:39 |
| JayF | probably just having that set via a config option? | 23:39 |
| lifeless | JayF: huh | 23:39 |
| lifeless | why does this need to be set? | 23:39 |
| JayF | lifeless: if you huh I maybe misunderstood the change | 23:39 |
| JayF | looking again | 23:39 |
| mrda | JayF: random.random() work for me :) | 23:40 |
| jroll | lifeless: it's the node resource, it needs to have something, theoretically | 23:40 |
| JayF | aha it is what I think | 23:40 |
| JayF | yeah, the model of that being static doesn't fit well with ironic | 23:40 |
| JayF | but if it can't be none, and must be static, it has to be a config option, right? | 23:41 |
| jroll | well, you can set it in node.properties, it's not static | 23:41 |
| jroll | but the fallback must be static | 23:41 |
| lifeless | so NotFound is a good fallback | 23:41 |
| lifeless | its not a valid cpu arch | 23:41 |
| lifeless | which is the point | 23:41 |
| lifeless | we can't advertise nodes where this isn't set in Ironic to Nova at all | 23:42 |
| lifeless | so if we hit this fallback, we've had a user delete the cpu arch from ironic after it was fully setup and advertised - or something like that | 23:42 |
| mrda | lifeless: I agree | 23:42 |
| lifeless | (and perhaps we're advertising it when its not fully ready) | 23:42 |
| jroll | lifeless: or the person registering nodes didn't enter it | 23:42 |
| JayF | We require cpu_arch to be set when creating a node, correct? | 23:42 |
| lifeless | claiming any arch that *might* match the scheduler would be a bug | 23:43 |
| lifeless | JayF: I thought so , but haven't cross checked | 23:43 |
| jroll | lifeless: if you only have 64-bit images and 64-bit cpus it doesn't matter | 23:43 |
| jroll | match em all | 23:43 |
| jroll | (as you should in 2014) | 23:43 |
| lifeless | jroll: long as they are all x86_64 and not power8 or something | 23:43 |
| lifeless | :) | 23:43 |
| JayF | ^ that's exactly what my thought was when I said make the static fallback configurable | 23:43 |
| JayF | not many folks are going to be running mixed-arch ironic | 23:44 |
| JayF | and if they are I bet they pay a LOT of attention to cpu_arch being set properly :) | 23:44 |
| jroll | right | 23:44 |
| jroll | heh | 23:44 |
| JayF | and could set their static default to "NotFound" potentially? | 23:44 |
| lifeless | so I don't like that | 23:44 |
| lifeless | it makes it a nasty nasty surprise if something that a) the UI can just steer folk at sometimes works and sometimes doesn't | 23:44 |
| JayF | make it configurable, but default to NotFound? | 23:45 |
| lifeless | what benefit does making it configurable bring? | 23:45 |
| mrda | I think that we don't have a robust solution here, and so if it's not set, using 'NotFound' is fine for now | 23:45 |
| lifeless | btw we have that NotFound fallback in other places | 23:45 |
| lifeless | like | 23:45 |
| lifeless | cpu_arch = str(node.properties.get('cpu_arch', 'NotFound')) | 23:45 |
| mrda | that's what we have in this case, currently | 23:46 |
| JayF | lifeless: okay, I agree with you. I couldn't defend my position w/r/t configurablity. Only argument I'd have is backwards compat but I'd suspect ironic+nova users would know there are dragons i->j | 23:46 |
| lifeless | yup, we're exporting nodes with cpu_arch NotFound in get_host_stats | 23:46 |
| lifeless | JayF: well, right now its not a backwards compat issue is it? The nova->Ironic migration can use the Nova config setting to populate this; | 23:46 |
| lifeless | anyone else, its part of the standard thing to set it per node | 23:47 |
| *** chuckC has quit IRC | 23:47 | |
| mrda | So I would suggest leaving things as is for now, and if we think this is something we should change, raise a bug and fix it later | 23:47 |
| lifeless | mrda: +1 | 23:47 |
| jroll | mrda: welllllllll | 23:47 |
| JayF | okay | 23:47 |
| jroll | I agree with the canonicalize bit | 23:47 |
| jroll | just leave the default to NotFound | 23:47 |
| lifeless | so the canonicalise bit will be a backwards compat break for tripleo | 23:47 |
| mrda | jroll: I have a current +2 on that patch right now :) | 23:48 |
| jroll | lifeless: why | 23:48 |
| jroll | mrda: well then :) | 23:48 |
| lifeless | jroll: the cpu_arch is compared to the flavor right? | 23:48 |
| mrda | how about, if I have to change it for reasons, I fix that? | 23:48 |
| lifeless | jroll: are both sides canonicalised by the scheduler ? | 23:48 |
| mrda | jroll: ^^ | 23:48 |
| jroll | lifeless: I assume so? idk | 23:48 |
| jroll | lifeless: what arch are y'all using? i386? | 23:48 |
| lifeless | jroll: so we have scripts that setup the flavor and the node | 23:48 |
| lifeless | jroll: arch is user supplied; but the only thing we do is poke the same value into both places | 23:49 |
| jroll | ok | 23:49 |
| lifeless | if one side gets munged by the system and the other side doesn't | 23:49 |
| lifeless | it will break | 23:49 |
| lifeless | so if we're going to add such a thing, I think the bare minimum test is one that checks we can schedule when the flavor and node are both given the same non-canonical form | 23:50 |
| jroll | lifeless: oops, you're right, canonicalize is only used with arch.from_host | 23:50 |
| lifeless | So yeah | 23:50 |
| jroll | lifeless: though it's trivial for tripleo to also do something similar to canonicalize(), tripleo lands it first, boom backwards compat | 23:50 |
| lifeless | jroll: API break is still a break :) | 23:51 |
| lifeless | jroll: it just means we'd have a version that works, but anyone upgrading nova and ironic without changing their tripleo versions would be stuffed | 23:51 |
| jroll | hmm | 23:52 |
| jroll | I guess I don't know the details | 23:52 |
| jroll | but i386 is one of the few that gets munged | 23:52 |
| jroll | hrm | 23:52 |
| jroll | yeah, you might be right | 23:53 |
| lifeless | more broadly, if we're going to canonicalize an item of data that is compared to another one, we need to canonicalize both, or neither. | 23:53 |
| mrda | lifeless: agreed | 23:53 |
| mrda | pref both | 23:53 |
| lifeless | I have no particular care about whether we should or shouldn't do it, but if we're going to do it, thats whats needed to do it safely. | 23:53 |
| jroll | indeed | 23:53 |
| jroll | lifeless: are flavor/node setup scripts separate scripts or all in one? | 23:54 |
| lifeless | jroll: setup-baremetal does both, it calls register-nodes internally, both are driven by the nodes.json data | 23:54 |
| jroll | lifeless: right, so if flavors are created at the same time, then they'll both be munged properly | 23:54 |
| jroll | old nodes/flavors will still show i386, but will still be deployable | 23:55 |
| jroll | so should be fine, no | 23:55 |
| jroll | ? | 23:55 |
| lifeless | jroll: no, because the proposed change in ironic is late-bound munging. | 23:55 |
| jroll | OH | 23:55 |
| jroll | ok | 23:55 |
| jroll | thanks for that :) | 23:55 |
| lifeless | jroll: if we add late-bound munging into the use of flavours as well, then both sides will line up and its fine. | 23:55 |
| jroll | right | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
