| *** eguz has joined #openstack-ironic | 00:04 | |
| *** eghobo has quit IRC | 00:08 | |
| *** eghobo has joined #openstack-ironic | 00:12 | |
| *** eguz has quit IRC | 00:16 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Use LLDP to get switch port mapping https://review.openstack.org/92627 | 00:17 |
|---|---|---|
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Use LLDP to get switch port mapping https://review.openstack.org/92627 | 00:18 |
| *** eghobo has quit IRC | 00:19 | |
| *** eghobo has joined #openstack-ironic | 00:19 | |
| *** harlowja is now known as harlowja_away | 00:29 | |
| *** rwsu has quit IRC | 00:37 | |
| *** rwsu has joined #openstack-ironic | 00:50 | |
| *** harlowja_away is now known as harlowja | 00:56 | |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Add implementation of pluggable distributed sync https://review.openstack.org/115148 | 00:59 |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Add implementation of pluggable distributed sync https://review.openstack.org/115148 | 01:02 |
| *** eghobo has quit IRC | 01:14 | |
| *** eguz has joined #openstack-ironic | 01:14 | |
| *** eguz has quit IRC | 01:27 | |
| *** scubacuda has quit IRC | 01:27 | |
| *** eghobo has joined #openstack-ironic | 01:27 | |
| *** eguz has joined #openstack-ironic | 01:28 | |
| *** eghobo has quit IRC | 01:28 | |
| *** eguz has quit IRC | 01:31 | |
| *** eghobo has joined #openstack-ironic | 01:31 | |
| *** shakamunyi has joined #openstack-ironic | 01:34 | |
| *** vinbs has joined #openstack-ironic | 01:42 | |
| *** vinbs_ has joined #openstack-ironic | 01:43 | |
| *** vinbs has quit IRC | 01:46 | |
| *** vinbs_ is now known as vinbs | 01:46 | |
| *** nosnos has joined #openstack-ironic | 01:47 | |
| *** mitz has quit IRC | 01:48 | |
| *** tatyana has joined #openstack-ironic | 01:50 | |
| *** ChuckC has joined #openstack-ironic | 01:58 | |
| openstackgerrit | Dan Prince proposed a change to openstack/ironic: Update compute driver macs_for_instance per docs. https://review.openstack.org/115158 | 02:03 |
| *** eguz has joined #openstack-ironic | 02:05 | |
| *** eguz has quit IRC | 02:05 | |
| *** eghobo has quit IRC | 02:08 | |
| *** vinbs has quit IRC | 02:12 | |
| *** Poornima_ has joined #openstack-ironic | 02:26 | |
| *** Krast_ has quit IRC | 02:26 | |
| *** Krast has joined #openstack-ironic | 02:26 | |
| *** rloo_afk has quit IRC | 02:51 | |
| *** dlaube has quit IRC | 03:03 | |
| *** vinbs has joined #openstack-ironic | 03:07 | |
| *** shakamunyi has quit IRC | 03:09 | |
| *** tatyana has quit IRC | 03:27 | |
| *** Poornima_ has quit IRC | 03:43 | |
| *** ramineni has joined #openstack-ironic | 03:50 | |
| *** shakamunyi has joined #openstack-ironic | 04:07 | |
| *** harlowja is now known as harlowja_away | 04:08 | |
| *** bvivek has joined #openstack-ironic | 04:12 | |
| *** Poornima_ has joined #openstack-ironic | 04:18 | |
| *** chenglch has joined #openstack-ironic | 04:32 | |
| *** rakesh_hs has joined #openstack-ironic | 04:35 | |
| *** eghobo has joined #openstack-ironic | 04:40 | |
| *** achanda has joined #openstack-ironic | 04:51 | |
| *** nikunj2512 has joined #openstack-ironic | 04:53 | |
| *** Krast has quit IRC | 05:08 | |
| *** pcrews has quit IRC | 05:08 | |
| *** shakamunyi has quit IRC | 05:13 | |
| *** eghobo has quit IRC | 05:13 | |
| *** eghobo has joined #openstack-ironic | 05:14 | |
| *** pradipta_away is now known as pradipta | 05:16 | |
| *** chuckC_ has joined #openstack-ironic | 05:16 | |
| *** killer_prince is now known as lazy_prince | 05:22 | |
| *** chuckC_ has quit IRC | 05:32 | |
| *** bmahalakshmi has joined #openstack-ironic | 05:34 | |
| *** sirushti has joined #openstack-ironic | 05:35 | |
| *** k4n0 has joined #openstack-ironic | 05:36 | |
| *** bmahalakshmi has quit IRC | 05:39 | |
| *** bmahalakshmi has joined #openstack-ironic | 05:40 | |
| *** sirushti has left #openstack-ironic | 05:41 | |
| *** rwsu has quit IRC | 05:51 | |
| *** tatyana has joined #openstack-ironic | 05:56 | |
| *** rwsu has joined #openstack-ironic | 06:07 | |
| *** achanda has quit IRC | 06:08 | |
| *** Krast has joined #openstack-ironic | 06:14 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/114135 | 06:25 |
| *** Krast has quit IRC | 06:28 | |
| *** mrda has quit IRC | 06:30 | |
| *** mrda has joined #openstack-ironic | 06:32 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Take iSCSI deploy out of pxe driver https://review.openstack.org/111232 | 06:46 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for creating vfat disk images https://review.openstack.org/105413 | 06:49 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add support for interacting with swift https://review.openstack.org/105795 | 06:53 |
| viktors | dtantsur|afk: hi! Please ping me, whey you'll be available. | 07:03 |
| *** dtantsur|afk is now known as dtantsur | 07:06 | |
| dtantsur | Morning, Ironic! | 07:06 |
| dtantsur | viktors, here | 07:06 |
| viktors | dtantsur: I have a question as for your notes to patch https://review.openstack.org/#/c/107629/ (Use metadata.create_all() to get database schema) | 07:08 |
| * dtantsur is looking in attempt to remember | 07:08 | |
| dtantsur | ah, I see | 07:09 |
| viktors | yes, it was a long time ago :) | 07:09 |
| dtantsur | viktors, my worry was about people using MySQL for tests and having incomplete (i.e. at some earlier stage) schema | 07:09 |
| dtantsur | I'm not 100% sure it's a real problem, but I remember having something similar myself | 07:10 |
| viktors | dtantsur: can you please give me an example of a such situation? | 07:10 |
| viktors | do we suppose to run tests on non actual DB schema? | 07:10 |
| dtantsur | viktors, IIRC you can setup your tests to use MySQL (at least I guess I succeeded once). Then you use dbsync to create some schema. After some time schema change more and you decide to run tests | 07:11 |
| dtantsur | viktors, before patch: schema is upgraded, after patch: errors | 07:11 |
| dtantsur | that's what I call behaviour change | 07:11 |
| dtantsur | viktors, well, I'm not sure we can't live with it :) just wanted to draw your attention to it | 07:12 |
| * viktors trying to run tests in mind =) | 07:13 | |
| viktors | dtantsur: ok, give me a few minutes | 07:14 |
| mrda | hey dtantsur! | 07:20 |
| dtantsur | mrda, g'evening :) | 07:21 |
| mrda | and good morning to you, dtantsur :) | 07:21 |
| *** rushiagr_away is now known as rushiagr | 07:22 | |
| dtantsur | I wonder, if we need specs for changes like this: https://review.openstack.org/#/c/114719/ | 07:23 |
| viktors | dtantsur: ok, let's clarify. AFAIK, in your case function setup_database() from ironic/tests/base.py will check, is database under alembic version control, or not. And if "yes", tests will use old db schema. Current code (master) in this case will upgrade mysql database to the last version. Is it the reason of your worries? | 07:23 |
| dtantsur | viktors, yes! | 07:23 |
| viktors | oh, I got it. :) | 07:24 |
| dtantsur | sorry, will disappear for ~ an hour, brb | 07:24 |
| viktors | dtantsur: so another question - do we really want to do this for all databases, but sqlite? | 07:24 |
| viktors | dtantsur: ok | 07:25 |
| dtantsur | viktors, I don't know :) it's nice to have as to me, but I'd like the others to tell their opinions | 07:25 |
| viktors | dtantsur: IMO, there is a sense to update sqlite also | 07:25 |
| dtantsur | viktors, we can't, sqlte does not support all our migrations | 07:26 |
| *** teju has joined #openstack-ironic | 07:26 | |
| dtantsur | ok, now running for real, sorry | 07:26 |
| viktors | dtantsur: ok, discuss it later | 07:26 |
| *** jcoufal has joined #openstack-ironic | 07:26 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: IloVirtualMediaIscsi deploy driver https://review.openstack.org/113865 | 07:34 |
| *** ifarkas has joined #openstack-ironic | 07:46 | |
| *** mitz has joined #openstack-ironic | 07:49 | |
| *** eghobo has quit IRC | 07:50 | |
| *** jcoufal has quit IRC | 07:51 | |
| *** ndipanov_gone is now known as ndipanov | 07:56 | |
| *** jcoufal has joined #openstack-ironic | 08:03 | |
| *** Halacs has joined #openstack-ironic | 08:04 | |
| *** Krast has joined #openstack-ironic | 08:22 | |
| teju | will ironic work fine just with nova? | 08:22 |
| *** rushiagr is now known as rushiagr_away | 08:22 | |
| *** derekh has joined #openstack-ironic | 08:23 | |
| *** lucasagomes has joined #openstack-ironic | 08:28 | |
| *** igordcard has joined #openstack-ironic | 08:33 | |
| *** athomas has joined #openstack-ironic | 08:39 | |
| *** bvivek has quit IRC | 08:39 | |
| *** overlayer has joined #openstack-ironic | 08:47 | |
| *** igordcard has quit IRC | 08:47 | |
| *** rushiagr_away is now known as rushiagr | 08:48 | |
| mrda | hey jroll, quoting the Nova PTL today "Feature proposal freeze is midnight Thursday this week, UTC. If your code isn't proposed by then, you will require a freeze exception..." | 08:51 |
| mrda | I'd like to have proposed 108545 and 113036 by Thursday midnight UTC, as a new review in Nova on the end of 111429. If it's not we will likely have to go theough a feature freeze exception. So you'd better get nagging :) | 08:53 |
| *** vinbs has quit IRC | 08:54 | |
| *** vinbs has joined #openstack-ironic | 08:55 | |
| *** proffalken has quit IRC | 09:04 | |
| *** pelix has joined #openstack-ironic | 09:10 | |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Remove gettextutils _ injection https://review.openstack.org/110634 | 09:31 |
| *** vinbs_ has joined #openstack-ironic | 09:37 | |
| *** vinbs has quit IRC | 09:37 | |
| *** vinbs_ is now known as vinbs | 09:37 | |
| *** rushiagr is now known as rushiagr_away | 09:47 | |
| *** rushiagr_away is now known as rushiagr | 09:50 | |
| *** vinbs has quit IRC | 10:04 | |
| *** lazy_prince is now known as killer_prince | 10:08 | |
| *** overlayer has quit IRC | 10:09 | |
| mrda | Night Ironic :) | 10:13 |
| Haomeng | mrda: night:) | 10:16 |
| *** vinbs has joined #openstack-ironic | 10:16 | |
| *** killer_prince is now known as lazy_prince | 10:19 | |
| *** rakesh_hs has quit IRC | 10:23 | |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Add driver name on driver load exception https://review.openstack.org/112049 | 10:23 |
| *** pradipta is now known as pradipta_away | 10:29 | |
| *** chenglch has quit IRC | 10:30 | |
| *** zul has quit IRC | 10:36 | |
| *** pradipta_away is now known as pradipta | 10:44 | |
| *** rakesh_hs has joined #openstack-ironic | 10:46 | |
| *** bvivek has joined #openstack-ironic | 10:49 | |
| *** mitz has quit IRC | 10:51 | |
| *** mitz has joined #openstack-ironic | 10:53 | |
| *** ifarkas has quit IRC | 10:55 | |
| *** ifarkas_ has joined #openstack-ironic | 10:57 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Update DevStack guide when listing images https://review.openstack.org/115243 | 10:59 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Update DevStack guide when querying the image UUID https://review.openstack.org/115243 | 11:00 |
| *** lucasagomes is now known as lucas-hungry | 11:09 | |
| *** overlayer has joined #openstack-ironic | 11:10 | |
| *** ifarkas_ has quit IRC | 11:18 | |
| *** ifarkas_ has joined #openstack-ironic | 11:29 | |
| *** ifarkas_ has quit IRC | 11:32 | |
| *** ifarkas has joined #openstack-ironic | 11:32 | |
| *** overlayer has quit IRC | 11:41 | |
| *** teju has left #openstack-ironic | 11:58 | |
| *** Krast has quit IRC | 12:02 | |
| *** bmahalakshmi has quit IRC | 12:04 | |
| openstackgerrit | Dan Prince proposed a change to openstack/ironic: Update compute driver macs_for_instance per docs https://review.openstack.org/115158 | 12:15 |
| *** lucas-hungry is now known as lucasagomes | 12:30 | |
| *** nikunj2512 has quit IRC | 12:38 | |
| dtantsur | Folks, any ideas whom to ping for reviewing quite an easy patch to oslo-incubator? https://review.openstack.org/#/c/113978 | 12:39 |
| dtantsur | it's blocking my 2 patches to the client :( | 12:39 |
| lucasagomes | dtantsur, :( #openstack-oslo? | 12:44 |
| *** dlaube has joined #openstack-ironic | 12:46 | |
| dtantsur | maybe | 12:48 |
| *** dlaube has quit IRC | 12:48 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic-python-agent: Add vmedia boot support in IPA https://review.openstack.org/115275 | 12:52 |
| *** nosnos has quit IRC | 12:56 | |
| *** dlaube has joined #openstack-ironic | 12:57 | |
| openstackgerrit | Davide Guerri proposed a change to openstack/ironic: Add Parallels virtualisation type https://review.openstack.org/114719 | 12:59 |
| *** jgrimm has joined #openstack-ironic | 13:00 | |
| viktors | dtantsur: around? | 13:01 |
| dtantsur | viktors, yes | 13:01 |
| *** Poornima_ has quit IRC | 13:02 | |
| *** jasondotstar has joined #openstack-ironic | 13:04 | |
| lazy_prince | Hi All, does anyone know of a writeup/pointer on configuring ironic for baremetal with neutron and tenant network isolation..? | 13:06 |
| viktors | dtantsur: I have a same question as a few hours ago =) | 13:08 |
| dtantsur | viktors, whether we should save the old behavior? I would still answer yes, because it's making life a bit easier for people using MySQL | 13:09 |
| viktors | dtantsur: my suggestion is - we should keep same logic for all DB backend, so we should either suppose, that DB in actual state (if there are any migrations) or update DB to the last version | 13:10 |
| viktors | dtantsur: by the way, is this test work with mysql at the moment? | 13:11 |
| dtantsur | viktors, it would be ok, if all databases would be the same | 13:12 |
| dtantsur | but they are not | 13:12 |
| dtantsur | sqlite supports very limited number of migrations, but we can use it in-memory and easily recreate schema | 13:12 |
| dtantsur | mysql is the opposite, as to me | 13:12 |
| dtantsur | lucasagomes and others, your opinion? ^^^ | 13:12 |
| viktors | dtantsur: we can easily update mysql and postgres | 13:14 |
| jroll | morning ironic :) | 13:16 |
| viktors | but there are a lot of issues with sqlite in file | 13:16 |
| dtantsur | jroll, morning | 13:16 |
| jroll | lazy_prince: I'm not sure that we support that yet :( | 13:16 |
| jroll | lazy_prince: we'd have to add code to flip networks and whatnot, I think, you would need a provisioning network and then the tenant networks | 13:16 |
| viktors | dtantsur: one more time - is this test work with mysql at the moment? | 13:17 |
| jroll | lazy_prince: you want to do this with some sort of SDN or real switches? | 13:17 |
| dtantsur | viktors, yeah... that's why I don't really know. I can revoke my -1 so that I'm not blocking it | 13:17 |
| jroll | 05:39:49 dtantsur | Folks, any ideas whom to ping for reviewing quite an easy patch to oslo-incubator? https://review.openstack.org/#/c/113978 <- ping dhellmann | 13:17 |
| dtantsur | viktors, which "this" test? I remember running some random tests with mysql | 13:17 |
| jroll | (I think) | 13:17 |
| dtantsur | jroll, thanks, will try once he's available | 13:18 |
| jroll | mrda: sadface, I'll bug people for reviews... who's in charge of the +A on nova patches while deva is gone | 13:18 |
| viktors | dtantsur: I mean, can we set connection string for mysql to CONF.database.connection ? | 13:18 |
| viktors | dtantsur: I'm not sure, that tests will pass in this case :) | 13:19 |
| jroll | dtantsur, lucasagomes, NobodyCam, we need to push these patches through quickly, have nova feature freeze coming up thursday midnight utc: https://review.openstack.org/#/c/108545/ https://review.openstack.org/#/c/113036/ | 13:19 |
| dtantsur | viktors, I don't quite remember, it seems to me I did it once | 13:20 |
| dtantsur | ok, nevermind, let's research it later | 13:20 |
| dtantsur | jroll, ack | 13:20 |
| jroll | thanks :) | 13:20 |
| viktors | dtantsur: ok. Maybe someone else will suggest | 13:21 |
| dtantsur | viktors, revoked -1 | 13:21 |
| viktors | lucasagomes: can you tel something about discussion ^^ | 13:21 |
| viktors | dtantsur: thanks | 13:22 |
| *** pradipta is now known as pradipta_away | 13:24 | |
| lucasagomes | viktors, hi sorry, I'm a bit busy with some stuff here... hmmmmm as per last comment of GheRivero at https://bugs.launchpad.net/ironic/+bug/1327225 | 13:26 |
| lucasagomes | it seems to be possible to set the string connection and run tests locally | 13:26 |
| lucasagomes | also (I didn't check) migrations should run on gate now | 13:26 |
| lucasagomes | (with mysql) | 13:26 |
| lucasagomes | jroll, ack I will take a look at it after the internal stuff | 13:29 |
| jroll | thanks, no rush, just sometime today :) | 13:30 |
| jroll | we can even just wait til review jam and I can turn around patches quick :) | 13:30 |
| viktors | lucasagomes: sorry, I didn't got your question as for migrations, but GheRivero's suggestion sounds correct | 13:30 |
| * jroll bbl | 13:30 | |
| lucasagomes | viktors, I was just pointing to Ghe's comment there, no question really... I thought you have asked if we could set the connection string for mysql | 13:31 |
| lucasagomes | so I pointed to Ghe's comment there saying that it might be possible | 13:31 |
| *** pcrews has joined #openstack-ironic | 13:33 | |
| viktors | lucasagomes: oh, I told, that IMO test can fail if we set mysql connection string here - https://github.com/openstack/ironic/blob/master/ironic/tests/base.py#L167 | 13:33 |
| lucasagomes | oh I see | 13:34 |
| lucasagomes | I have to also check ur patch for oslo.db | 13:34 |
| lucasagomes | that's what you guys are talking about right? | 13:34 |
| *** pcrews_ has joined #openstack-ironic | 13:34 | |
| lucasagomes | I will re-review that later on today | 13:34 |
| viktors | lucasagomes: yes, that's we are talking about. Thanks! | 13:35 |
| *** pcrews__ has joined #openstack-ironic | 13:35 | |
| *** rloo has joined #openstack-ironic | 13:36 | |
| *** pcrews has quit IRC | 13:38 | |
| *** pcrews_ has quit IRC | 13:39 | |
| *** pcrews__ has quit IRC | 13:41 | |
| *** pcrews has joined #openstack-ironic | 13:43 | |
| *** jcoufal has quit IRC | 13:45 | |
| *** jcoufal has joined #openstack-ironic | 13:46 | |
| *** HenryG_ has joined #openstack-ironic | 13:46 | |
| openstackgerrit | Dan Prince proposed a change to openstack/ironic: Update compute driver macs_for_instance per docs https://review.openstack.org/115158 | 13:47 |
| *** HenryG has quit IRC | 13:47 | |
| *** bvivek has quit IRC | 13:48 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: use MissingParameterValue exception in iboot https://review.openstack.org/115294 | 14:00 |
| *** bmahalakshmi has joined #openstack-ironic | 14:02 | |
| *** HenryG_ is now known as HenryG | 14:07 | |
| *** agordeev has quit IRC | 14:12 | |
| *** lazy_prince is now known as killer_prince | 14:13 | |
| *** shakamunyi has joined #openstack-ironic | 14:16 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: return power state ERROR instead of raising exception https://review.openstack.org/115300 | 14:17 |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Implement hardware discovery in PXE driver https://review.openstack.org/110031 | 14:27 |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Add newly_discovered column to Node object https://review.openstack.org/107389 | 14:27 |
| openstackgerrit | Imre Farkas proposed a change to openstack/ironic: Add DracDriver and its DracPower module https://review.openstack.org/104850 | 14:29 |
| NobodyCam | good morning Ironic | 14:30 |
| rloo | morning NobodyCam! | 14:31 |
| NobodyCam | morning rloo :) | 14:32 |
| *** shakamunyi has quit IRC | 14:32 | |
| *** vinbs has quit IRC | 14:37 | |
| *** dlaube1 has joined #openstack-ironic | 14:38 | |
| *** dlaube has quit IRC | 14:39 | |
| *** vinbs_ has joined #openstack-ironic | 14:45 | |
| *** vinbs_ is now known as vinbs | 14:45 | |
| *** shakamunyi has joined #openstack-ironic | 14:48 | |
| openstackgerrit | Rakesh H S proposed a change to openstack/ironic: IPMI double bridging functionality https://review.openstack.org/95775 | 14:48 |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Add in text for text mode on trusty https://review.openstack.org/98050 | 14:53 |
| *** vinbs has quit IRC | 14:54 | |
| dtantsur | morning, NobodyCam, rloo | 14:55 |
| rloo | hi dtantsur! We missed you yesterday :-) | 14:56 |
| dtantsur | :) | 14:56 |
| openstackgerrit | Rakesh H S proposed a change to openstack/ironic: IPMI double bridging functionality https://review.openstack.org/95775 | 15:01 |
| NobodyCam | brb | 15:02 |
| *** rakesh_hs has quit IRC | 15:12 | |
| openstackgerrit | Davide Guerri proposed a change to openstack/ironic: Add Parallels virtualisation type https://review.openstack.org/114719 | 15:15 |
| jroll | morning NobodyCam rloo :) | 15:22 |
| rloo | morning jroll! | 15:23 |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Implement hardware discovery in PXE driver https://review.openstack.org/110031 | 15:24 |
| NobodyCam | good morning jroll | 15:27 |
| NobodyCam | good morning dtantsur | 15:28 |
| jroll | hey | 15:29 |
| * jroll looks around for coffee | 15:29 | |
| *** sirushti has joined #openstack-ironic | 15:29 | |
| *** agordeev has joined #openstack-ironic | 15:31 | |
| lucasagomes | morning NobodyCam jroll rloo | 15:41 |
| rloo | hi lucasagomes! | 15:41 |
| jroll | heya lucasagomes :) | 15:41 |
| lucasagomes | jroll, about that patch from dprince | 15:45 |
| lucasagomes | jroll, we have to tell mrda before approving it right? | 15:45 |
| lucasagomes | mrda, https://review.openstack.org/#/c/115158/ | 15:45 |
| jroll | lucasagomes: yeah, indeed | 15:45 |
| jroll | lucasagomes: actually, I would check which nova patch that gets added in, and the current state | 15:45 |
| *** dtantsur is now known as dtantsur|brb | 15:45 | |
| jroll | if no +2's just approve it but still tell mrda | 15:46 |
| NobodyCam | morning lucasagomes | 15:46 |
| *** zzzeek has joined #openstack-ironic | 15:46 | |
| NobodyCam | I ended up with a 9:30 conf call so I will only be able to make the first 1/2 an hour of the jam | 15:47 |
| jroll | boo | 15:47 |
| zzzeek | hello all, I’m looking at this IRC log http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2014-07-07.log which refers to “<lucasagomes> matty_dubs, yes, ifarkas patch to use fuser to verify if the disk is not been held by another process was merged last friday”, in an effort to get ironic tests to run without “InstanceDeployFailure: Disk partitioning failed…”, however I’m on the very latest | 15:47 |
| zzzeek | from git.openstack and still getting this error | 15:47 |
| zzzeek | I’m just trying to test some changes in oslo.db that will be hitting ironic and others … | 15:48 |
| lucasagomes | zzzeek, oh... >.< | 15:49 |
| zzzeek | lucasagomes: sorry, I’m clueless at the level of “devices”, im just the database guy :) | 15:49 |
| zzzeek | i can get everythign to run just a couple of test failures for that one | 15:49 |
| lucasagomes | zzzeek, afair, this was a problem that when trying to partition the disk it would fail with a "device is busy" error | 15:49 |
| lucasagomes | before the work around was to sleep for some seconds and then ifarkas worked in a better way to use fuser | 15:50 |
| lucasagomes | to actually check if the device was busy or not | 15:50 |
| lucasagomes | but if it's not working :/ hmmm | 15:50 |
| lucasagomes | gotta dig into it | 15:50 |
| zzzeek | lucasagomes: I get this: http://paste.openstack.org/show/97353/ | 15:50 |
| ifarkas | zzzeek, what's the error you are getting? | 15:50 |
| jroll | well | 15:50 |
| zzzeek | on a fedora 20 VM | 15:50 |
| jroll | if the device never gets not busy | 15:50 |
| jroll | it will still fail | 15:50 |
| jroll | it doesn't retry forever iirc | 15:50 |
| lucasagomes | oh this seems to be another problem | 15:51 |
| lucasagomes | jroll, yeah it has a timeout afair | 15:51 |
| jroll | seems like it's not running as root | 15:51 |
| jroll | which is... odd | 15:51 |
| zzzeek | oh. the tests ahve to be run as root ? :) | 15:51 |
| jroll | nooooooo | 15:51 |
| jroll | wait, that's tests? | 15:51 |
| zzzeek | i need ot have sudo ? | 15:51 |
| zzzeek | yes | 15:51 |
| lucasagomes | hah these are unittests | 15:51 |
| jroll | that shouldn't actually execute fuser | 15:51 |
| jroll | wtf | 15:51 |
| lucasagomes | yeah | 15:51 |
| zzzeek | yes. I just did a checkout + tox | 15:51 |
| lucasagomes | I thought it was mocked | 15:51 |
| jroll | File "/opt/stack/ironic/.tox/py27/lib/python2.7/site-packages/mock.py", line 1201, in patched | 15:52 |
| lucasagomes | zzzeek, mind opnening a bug about it? | 15:52 |
| jroll | return func(*args, **keywargs) | 15:52 |
| jroll | heh | 15:52 |
| zzzeek | lucasagomes: its a bug? OK. this doesnt happen for you folks ? | 15:52 |
| jroll | correct | 15:52 |
| * jroll brb | 15:52 | |
| *** derekh has quit IRC | 15:52 | |
| zzzeek | Ok well I’m also on fedora 20 and its a VMware vm on OSX, think that has anythign to do with it ? | 15:52 |
| zzzeek | or this is just, “the tests shouldnt be doing that at all" | 15:52 |
| lucasagomes | zzzeek, haven't hit that in my env | 15:53 |
| lucasagomes | I use fedora 20 too | 15:53 |
| zzzeek | lucasagomes: OK. I’m just wondering if im doing something stupid | 15:53 |
| lucasagomes | zzzeek, wondering that if it's not being mocked, maybe selinux is doing something weird that | 15:53 |
| lucasagomes | there* | 15:53 |
| zzzeek | lucasagomes: OK…so for the bug repoirt what info do you need | 15:53 |
| lucasagomes | zzzeek, well just say that ur running it on fedora, post that error message | 15:54 |
| lucasagomes | and the way to reproduce | 15:54 |
| zzzeek | OK | 15:54 |
| lucasagomes | which in ur way is just running the tests | 15:54 |
| lucasagomes | zzzeek, thanks for that | 15:54 |
| zzzeek | OK let me just do a 100% clean start again and see if it still happens | 15:54 |
| zzzeek | which is fun b.c. i love waiting for numpy to build! again | 15:55 |
| lucasagomes | lol | 15:55 |
| lucasagomes | yeah | 15:55 |
| jroll | whee. | 15:56 |
| jroll | zzzeek: btw, using a pip cache helps a ton when rebuilding | 15:56 |
| openstackgerrit | A change was merged to openstack/ironic: Fix py3k-unsafe code in test_get_properties() https://review.openstack.org/114988 | 15:56 |
| jroll | export PIP_DOWNLOAD_CACHE=$HOME/.pip_download_cache | 15:57 |
| zzzeek | jroll: hmm will look into that, thought i already had that going | 15:57 |
| jroll | or similar | 15:57 |
| openstackgerrit | A change was merged to openstack/ironic: Updated from global requirements https://review.openstack.org/114057 | 15:57 |
| zzzeek | jroll: does that cache the actual build of numpy ? b.c. thats the slow part | 15:57 |
| jroll | you might, I'm not in your computer :) | 15:57 |
| jroll | no | 15:57 |
| jroll | ha | 15:57 |
| zzzeek | jroll: yeah | 15:57 |
| zzzeek | jroll: build numpy on vmware vm == zzzzz | 15:57 |
| jroll | ohhhhhhhh | 15:57 |
| jroll | yeah. | 15:57 |
| jroll | I just dev on 8-core cloud servers these days :P | 15:58 |
| zzzeek | jroll: if i install it systemwide that would help if the tox.ini here is allowing system site packages | 15:58 |
| jroll | yeah, but that defeats the purpose of tox :P | 15:59 |
| zzzeek | for numpy who cares | 15:59 |
| jroll | I guess yeah | 15:59 |
| zzzeek | pip should have a binary build cache. someday. | 15:59 |
| zzzeek | probably never :) | 15:59 |
| jroll | wheels are a thing | 16:00 |
| zzzeek | ugh dont satrt me on those | 16:00 |
| jroll | not sure if they exist for numpy, though | 16:00 |
| jroll | LOL | 16:00 |
| zzzeek | from the mind of dstufft | 16:00 |
| jroll | lucasagomes: want me to start a hangout or does someone have one open? | 16:00 |
| jroll | NobodyCam: rloo ^^ | 16:01 |
| lucasagomes | jroll, hey yes | 16:01 |
| lucasagomes | jroll, zzzeek yeah I set that PIP_DOWNLOAD_CACHE var in my bashrc :) | 16:01 |
| lucasagomes | helps indeed | 16:01 |
| jroll | dafuq, can I not just start a hangout and give people a link | 16:02 |
| jroll | hate google plus | 16:02 |
| jroll | oh, got it | 16:02 |
| jroll | and chrome hung | 16:02 |
| * rloo has been avoiding using google stuff | 16:03 | |
| jroll | me too | 16:03 |
| jroll | ok | 16:04 |
| jroll | lucasagomes rloo NobodyCam dtantsur|brb whoever else https://plus.google.com/hangouts/_/g2leqyqiojz4cpfnxwd6l2hw6qa | 16:04 |
| lucasagomes | jroll, https://launchpad.net/ironic/+milestone/juno-3 | 16:07 |
| rloo | hey what do you guys do with hangout? talk and see each other? | 16:07 |
| rloo | oh, hangout is a video call ... | 16:08 |
| zzzeek | lucasagomes / jroll : alrighty https://bugs.launchpad.net/ironic/+bug/1358820 | 16:10 |
| lucasagomes | zzzeek, cheers | 16:10 |
| *** vinbs has joined #openstack-ironic | 16:14 | |
| *** viktors is now known as viktors|afk | 16:16 | |
| lucasagomes | mrda, NobodyCam jroll https://review.openstack.org/#/c/115158/ (mrda I just approved that needs to go into the driver) | 16:17 |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Add implementation of pluggable distributed sync https://review.openstack.org/115148 | 16:19 |
| *** penick has joined #openstack-ironic | 16:19 | |
| *** rushiagr is now known as rushiagr_away | 16:20 | |
| *** rushiagr_away is now known as rushiagr | 16:22 | |
| *** eghobo has joined #openstack-ironic | 16:26 | |
| dguerri | jroll, thanks for the review | 16:31 |
| jroll | dguerri: np :) | 16:37 |
| *** ifarkas has quit IRC | 16:40 | |
| lucasagomes | jroll, rloo https://review.openstack.org/#/c/113276/ | 16:40 |
| *** eghobo has quit IRC | 16:41 | |
| *** harlowja_away is now known as harlowja | 16:56 | |
| *** penick has quit IRC | 17:01 | |
| *** eghobo has joined #openstack-ironic | 17:03 | |
| rloo | lucasagomes, jroll: https://review.openstack.org/#/c/112402 | 17:03 |
| *** penick has joined #openstack-ironic | 17:04 | |
| openstackgerrit | A change was merged to openstack/ironic: Update compute driver macs_for_instance per docs https://review.openstack.org/115158 | 17:10 |
| *** igordcard has joined #openstack-ironic | 17:11 | |
| *** dtantsur|brb is now known as dtantsur | 17:14 | |
| dtantsur | jroll, oh, I was out. Is hangout still going? | 17:14 |
| rloo | dtantsur: yes, we're still there. | 17:15 |
| NobodyCam | hangout still going? | 17:17 |
| lucasagomes | NobodyCam, yup | 17:18 |
| *** bvivek has joined #openstack-ironic | 17:19 | |
| *** vinbs has quit IRC | 17:19 | |
| kylestev | Hey NobodyCam, after the call is done want to take a look at my spec and initial implementation? :) spec: https://review.openstack.org/#/c/114632/ implementation: https://review.openstack.org/#/c/115148/ | 17:25 |
| *** eghobo has quit IRC | 17:26 | |
| *** eghobo has joined #openstack-ironic | 17:27 | |
| *** killer_prince has quit IRC | 17:37 | |
| *** ChuckC has quit IRC | 17:37 | |
| *** shakamunyi has quit IRC | 17:39 | |
| *** pcrews has quit IRC | 17:41 | |
| *** eghobo has quit IRC | 17:41 | |
| *** pcrews has joined #openstack-ironic | 17:41 | |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Add implementation of pluggable distributed sync https://review.openstack.org/115148 | 17:53 |
| *** rakesh_hs has joined #openstack-ironic | 17:55 | |
| openstackgerrit | A change was merged to openstack/ironic: IPMI double bridging functionality https://review.openstack.org/95775 | 17:59 |
| *** ChuckC has joined #openstack-ironic | 18:00 | |
| lucasagomes | see you guys tomorrow | 18:02 |
| lucasagomes | have a great night | 18:02 |
| jroll | \o | 18:02 |
| *** chuckC_ has joined #openstack-ironic | 18:02 | |
| lucasagomes | Jenkins has submitted this change and it was merged. | 18:03 |
| lucasagomes | ipmi double bridge | 18:03 |
| lucasagomes | will mark the bp as implemented ;) | 18:03 |
| lucasagomes | well will check first if the specs says something about docs and all | 18:03 |
| lucasagomes | anyway... have a great night! | 18:03 |
| *** lucasagomes is now known as lucas-dinner | 18:03 | |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Add implementation of pluggable distributed sync https://review.openstack.org/115148 | 18:04 |
| jroll | \o/ | 18:04 |
| jroll | brb | 18:04 |
| *** penick has quit IRC | 18:08 | |
| *** sirushti has left #openstack-ironic | 18:08 | |
| *** rakesh_hs has quit IRC | 18:09 | |
| *** shakamunyi has joined #openstack-ironic | 18:11 | |
| jroll | NobodyCam: don't hurt me | 18:16 |
| jroll | NobodyCam: https://review.openstack.org/#/c/98050/ | 18:17 |
| * jroll grabs lunch | 18:17 | |
| NobodyCam | jroll: lol doh... I can add tht | 18:19 |
| NobodyCam | that even | 18:19 |
| dtantsur | g'night | 18:22 |
| *** dtantsur is now known as dtantsur|afk | 18:22 | |
| *** penick has joined #openstack-ironic | 18:24 | |
| *** bmahalakshmi has quit IRC | 18:26 | |
| NobodyCam | night dtantsur|afk | 18:26 |
| NobodyCam | brb quick walkies | 18:26 |
| *** pelix has quit IRC | 18:28 | |
| *** shakamunyi has quit IRC | 18:30 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Add in text for text mode on trusty https://review.openstack.org/98050 | 18:36 |
| *** shakamunyi has joined #openstack-ironic | 18:44 | |
| *** rushiagr is now known as rushiagr_away | 18:54 | |
| NobodyCam | rloo: looking at 115294, what would you think of adding test to ensure MissingParameterValue is correctly raised in get/set power state and reboot? | 18:55 |
| NobodyCam | or you think the test on parse info is good enough? | 18:55 |
| rloo | sec, let me look/think about it. | 18:55 |
| *** penick has quit IRC | 18:56 | |
| *** bvivek has quit IRC | 18:56 | |
| *** penick has joined #openstack-ironic | 18:59 | |
| rloo | NobodyCam: I think it is good enough so I don't have to add more tests. If we want more thorough tests, then yes, but the question becomes how many unit tests to add since _parse_drive_info is called in many places. | 19:00 |
| NobodyCam | :) | 19:02 |
| NobodyCam | my thought was we say (as example) get/set _power_state can raise MissingParameterValue but we don't actually test that it dose :-p | 19:03 |
| NobodyCam | we do test parse_info so I am good with it, just thought I'd ask | 19:03 |
| rloo | NobodyCam: get/set power state and reboot don't test the output from _parse_driver_info. validate test does test for Invalid. So if anything, maybe add a validate test with Missing. | 19:06 |
| rloo | NobodyCam: but since we test that _parse_driver_info raises Missing, and we test that validate can get an exception from _parse_driver_info, I'm not sure it needs one to test for Missing exception. | 19:07 |
| NobodyCam | will need to do that in another patch if we want to | 19:08 |
| NobodyCam | lol | 19:08 |
| rloo | NobodyCam: heh | 19:08 |
| *** harlowja has quit IRC | 19:13 | |
| *** harlowja has joined #openstack-ironic | 19:13 | |
| *** zzzeek has quit IRC | 19:15 | |
| jroll | NobodyCam: thanks for the patch, +2'd | 19:16 |
| jroll | NobodyCam: also made me realize we have a template in the tests/ tree but nothing uses it :P | 19:17 |
| *** zzzeek has joined #openstack-ironic | 19:17 | |
| jroll | is there a way to change the owner on a review? | 19:23 |
| jroll | 12:23:36 clarkb | jroll: I don't think so. initial uploader is the owner | 19:24 |
| jroll | whee. | 19:24 |
| NobodyCam | what review jroll | 19:30 |
| jroll | NobodyCam: the one I +2'd or the one I want to change? | 19:31 |
| jroll | +2'd https://review.openstack.org/98050 | 19:31 |
| jroll | want to change this to josh https://review.openstack.org/92627 | 19:32 |
| *** ndipanov is now known as ndipanov_gone | 19:36 | |
| openstackgerrit | A change was merged to openstack/ironic: use MissingParameterValue exception in iboot https://review.openstack.org/115294 | 19:42 |
| NobodyCam | why do you want to change the owner on your review? | 19:46 |
| jroll | because josh is taking it over :P | 19:46 |
| NobodyCam | he can just push up reviews and add a co-authored by line | 19:47 |
| jroll | yeah, I know, but I don't want it on my list in gerrit :P | 19:48 |
| jroll | I just checked to see why someone -1'd my patch | 19:48 |
| jroll | turns out it was me | 19:48 |
| jroll | doh | 19:48 |
| NobodyCam | oh lol, | 19:48 |
| rloo | jroll: I +2'd 108545, but added a comment. Not sure how expensive it is to get the cli wrapper. | 19:48 |
| NobodyCam | brb running to grab a pack og smokes | 19:48 |
| jroll | rloo: thanks... it's not great | 19:48 |
| NobodyCam | s/og/of/ | 19:48 |
| jroll | NobodyCam: bad, use your ecig | 19:48 |
| jroll | rloo: good call, will update that | 19:49 |
| rloo | jroll: thx for updating it. Guess I should have put a +1, not a +2 ;) | 19:49 |
| jroll | rloo: that call could get a keystone token, so | 19:49 |
| rloo | jroll: ah, yes, that's worse than your line with the time diff ;) | 19:50 |
| jroll | I -1'd it | 19:50 |
| jroll | rloo: will you be around in like a half hour if I push a new one up? | 19:50 |
| rloo | jroll: yup. I'm around for 2 hours or so, and then maybe later tonight. | 19:50 |
| jroll | great, thanks :) will ping | 19:50 |
| openstackgerrit | A change was merged to openstack/ironic: Update DevStack guide when querying the image UUID https://review.openstack.org/115243 | 19:55 |
| *** stevebaker has quit IRC | 20:00 | |
| *** stevebaker has joined #openstack-ironic | 20:00 | |
| NobodyCam | jroll: I use both :) | 20:18 |
| NobodyCam | and had to also swing by starBucks :-p | 20:18 |
| jroll | NobodyCam: I know, trying to get you healthy :P | 20:20 |
| NobodyCam | hehehehe | 20:23 |
| NobodyCam | rloo: great catch on jroll's review :) | 20:26 |
| rloo | NobodyCam: thx ;) | 20:26 |
| * jroll is updating that now | 20:29 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Query full node details and cache https://review.openstack.org/108545 | 20:31 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Use cache in node_is_available() https://review.openstack.org/113036 | 20:31 |
| jroll | rloo, NobodyCam pls to +2 ^ | 20:31 |
| jroll | re +2 even | 20:31 |
| rloo | jroll: in a meeting, will see if i can fit it in, else in 30 min from now. | 20:31 |
| NobodyCam | :) | 20:31 |
| jroll | rloo: no rush, just before you go for the day :) | 20:32 |
| NobodyCam | nope only one +2 per review per day lol... (j/k) | 20:32 |
| jroll | in case this helps; https://review.openstack.org/#/c/108545/10..11/ironic/nova/virt/ironic/driver.py | 20:32 |
| jroll | :P | 20:32 |
| jroll | easy easy diff | 20:32 |
| jroll | (ignore the bottom, that's from that other nova patch from earlier) | 20:32 |
| NobodyCam | hehehehe | 20:33 |
| *** eghobo has joined #openstack-ironic | 20:34 | |
| *** eghobo has quit IRC | 20:35 | |
| *** athomas has quit IRC | 20:36 | |
| *** stevebaker has quit IRC | 20:41 | |
| *** stevebaker has joined #openstack-ironic | 20:41 | |
| *** shakamunyi has quit IRC | 20:46 | |
| NobodyCam | oh cool! http://startrekaxanar.com | 20:46 |
| *** jgrimm has quit IRC | 20:53 | |
| NobodyCam | lol gave the kick starter 65 for the dvd lol | 21:05 |
| *** jasondotstar has quit IRC | 21:11 | |
| *** penick has quit IRC | 21:24 | |
| mrda | Morning Ironic | 21:28 |
| jroll | mrda! hey :) | 21:28 |
| NobodyCam | good morning mrda | 21:30 |
| jroll | NobodyCam: can you +2 https://review.openstack.org/#/c/108545/ | 21:30 |
| NobodyCam | *pounce* | 21:30 |
| *** penick has joined #openstack-ironic | 21:31 | |
| jroll | mrda, so, 3 patches for nova today :) | 21:31 |
| jroll | whenever you're ready for them let me know | 21:31 |
| mrda | jroll: I can see you've been busy on 108545 and 113036 :) | 21:31 |
| jroll | NobodyCam: still waiting on jenkins though | 21:31 |
| jroll | mrda: yep, they're good to go | 21:31 |
| NobodyCam | jroll: why the set() in test_driver? | 21:32 |
| mrda | oh, and Dan Prince's 115158 | 21:32 |
| jroll | NobodyCam: that's from rebasing on master | 21:32 |
| jroll | from 115158 | 21:32 |
| NobodyCam | humm... ok | 21:33 |
| jroll | NobodyCam: https://review.openstack.org/#/c/115158/3/ironic/nova/tests/virt/ironic/test_driver.py | 21:33 |
| mrda | jroll: just to be explicit, the patches we're talking about are 108545, 113036 and 115158 | 21:33 |
| mrda | correc? | 21:33 |
| jroll | mrda: yeah, noticed patch #4 had a -1 with a note on 115158 so we just landed it | 21:33 |
| jroll | mrda, yes :) | 21:33 |
| mrda | thanks for that. | 21:33 |
| jroll | we'll need to +A and wait on jenkins but they should be good | 21:33 |
| NobodyCam | mrda: shall I +a 108545? | 21:33 |
| jroll | doiiiiiit | 21:34 |
| mrda | I knew Dan had submitted it, I just had to work out which patch it refered t :) | 21:34 |
| mrda | NobodyCam: if you're happy with the technical solution, yep | 21:34 |
| NobodyCam | :) | 21:34 |
| jroll | (he +2'd it this morning so I sure hope so) | 21:34 |
| NobodyCam | jroll: another one off your plate | 21:35 |
| jroll | this is... interesting http://info.metacloud.com/people-of-openstack-playing-cards | 21:35 |
| jroll | NobodyCam: \o/ | 21:35 |
| jroll | NobodyCam: we can also +A https://review.openstack.org/#/c/113036/ | 21:35 |
| rloo | mrda: how do you know which patch in the train, to put these patches in? | 21:35 |
| rloo | morning mrda ;) | 21:35 |
| openstackgerrit | Sergey Lupersolsky proposed a change to openstack/python-ironicclient: Fixes misspelled class name https://review.openstack.org/114916 | 21:35 |
| mrda | rloo: it does my head in | 21:35 |
| *** penick has quit IRC | 21:35 | |
| jroll | mrda: hint, 115158 goes in #4, the others can be tacked on the end | 21:36 |
| mrda | Basically, if I raise an ironic review, I put a cross ref in the nova review pointing to the ironic review, and in the ironic review I put a xref back to the aplicable nova review | 21:36 |
| jroll | mrda: we also discussed this morning... since nova wants to land the whole series at once... don't let thos e performance fixes mess that up, we can move forward on juno without them | 21:37 |
| mrda | jroll: right, we're always going to tack them on the end | 21:37 |
| jroll | mrda: right, just... don't let them say "you guys are doing too much now" and block the whole chain | 21:38 |
| rloo | mrda: yeah, if you take stuff at the end, how/is it clear to everyone which patches need to be approved before the actual merge happens? | 21:38 |
| rloo | take -> tack | 21:38 |
| mrda | "everything in the chain from me" | 21:38 |
| rloo | mrda. that's what i was afraid of. | 21:38 |
| mrda | I'll work with the nova ptl to make sure the whole chain goes through | 21:38 |
| mrda | rloo: why? | 21:39 |
| rloo | mrda. I'd prefer then, NOT to tack on jroll's changes. | 21:39 |
| mrda | rloo: why? | 21:39 |
| rloo | mrda. cuz i want some code/driver to get approved. if we keep tacking stuff on, will that annoy/delay the actual merge? | 21:39 |
| *** tatyana has quit IRC | 21:39 | |
| mrda | these have been deemed as must have fixes | 21:39 |
| *** penick has joined #openstack-ironic | 21:39 | |
| mrda | by lucas-dinner and NobodyCam as devananda reps | 21:40 |
| jroll | mrda: if there's any risk of my changes making the chain not land, we shouldn't put them on :/ | 21:40 |
| kylestev | jroll: JoshNang: after that recheck on 115148, still fails because of pcre. should I keep rechecking with that bug#? | 21:40 |
| jroll | although we could propose them after feature freeze as a bug fix | 21:40 |
| jroll | kylestev: yes | 21:40 |
| mrda | jroll: that's whay I'm asking everyone: are they happy with the technical solution of 108545 + 113036 | 21:40 |
| jroll | mrda: it's ok, it's just that ironic doesn't scale in juno, what could go wronf | 21:40 |
| rloo | mrda: I didn't realize they were deemed as must-have fixes. As long as NobodyCam and lucas-dinner realize that. | 21:41 |
| jroll | mrda: so far, people happy with it: lucas-dinner rloo NobodyCam devananda comstud me | 21:41 |
| kylestev | jroll: fun | 21:41 |
| mrda | if we are happy, then I'll add them. But if we have concerns, I won't. | 21:41 |
| comstud | i'm never happy | 21:41 |
| jroll | mrda: and this is running in production today at rackspace | 21:41 |
| jroll | comstud: shh | 21:41 |
| rloo | jroll: no, i'm only happy with one of them. i don't think i looked at both. did I? | 21:41 |
| comstud | what am I happy about | 21:41 |
| NobodyCam | rloo: I really think we do need the cache stuff | 21:41 |
| jroll | rloo: oh, idk | 21:41 |
| mrda | you guys are the cores, you need to tell me if these are kosha | 21:41 |
| jroll | comstud: nova driver resource cache thing | 21:41 |
| * mrda is a mere patch monkey | 21:41 | |
| jroll | comstud: the stuff you wrote and deployed :P | 21:41 |
| comstud | whoever wrote that stuff is an idiot | 21:42 |
| jroll | ^^ | 21:42 |
| mrda | oh, it's comstud code? That's never gonna work ;) | 21:42 |
| jroll | and whoever committed it | 21:42 |
| rloo | don't worry comstud, we fixed your code ;) | 21:42 |
| comstud | :) | 21:42 |
| jroll | ok back to business | 21:42 |
| jroll | are nova cores going to complain because they have more patches to review | 21:42 |
| mrda | it will be fine | 21:42 |
| jroll | ok. | 21:43 |
| jroll | let's jfdi then | 21:43 |
| mrda | today | 21:43 |
| jroll | yes | 21:43 |
| jroll | I'm going to +A 113036 unless there are objections | 21:43 |
| jroll | going once | 21:43 |
| jroll | twice | 21:44 |
| jroll | done | 21:44 |
| mrda | but while I have the floor | 21:44 |
| rloo | jroll: sorry, just thinking. | 21:44 |
| jroll | done https://review.openstack.org/#/c/113036/ | 21:44 |
| rloo | jroll: sorry, need to look at the code again before asking. | 21:44 |
| jroll | rloo: uh oh | 21:44 |
| jroll | rloo: should I un +a | 21:44 |
| rloo | jroll: it's comstud's fault I think. So, looking at the two patches. Wherever you actually want to use the cache, you check if the cache exists, and if it doesn't, you call _refresh_cache(). | 21:45 |
| jroll | yeah. | 21:46 |
| rloo | jroll: seems like, especially if the cache will be used in eg a 3rd place, that a small method can be used to do that. | 21:46 |
| mrda | It appears a change has slipped through: specifically the dynamic loading of ironciclient in client_wrapper.py (aka https://github.com/openstack/ironic/blob/master/ironic/nova/virt/ironic/client_wrapper.py#L43) I'm going to diff that and create a new patch (and tack it on the end) | 21:46 |
| rloo | jroll: i guess it can be cleaned up later if anyone notices it. | 21:46 |
| jroll | rloo: yeah, I think it's fine right now | 21:46 |
| mrda | (because client_wrapper.py has already +A'd) | 21:47 |
| jroll | I mean, I think it's fine as is | 21:47 |
| jroll | but yeah | 21:47 |
| jroll | mrda: huh, ok | 21:47 |
| rloo | jroll: ok, lets see if the nova reviewers notice it. (eg, have a node_cache() that refreshes/returns the cache) | 21:47 |
| jroll | right | 21:47 |
| jroll | and that one is my fault, I broke that out differently than chris did :P | 21:48 |
| comstud | We are not going to nitpick on that and make one's life hell. | 21:48 |
| mrda | so jroll, rloo you're happy with what I'm proposing? | 21:48 |
| jroll | comstud: you mean you are not, I don't have faith in everyone like that | 21:48 |
| comstud | fair enough | 21:48 |
| rloo | comstud: that is fine then. I just want to make sure we don't give much/anything for the reviewers to pick on. | 21:48 |
| jroll | mrda: the ironicclient stuff or? | 21:48 |
| jroll | mrda: just to be clear, happy with which proposal? | 21:49 |
| comstud | but I would tell that person (apparently rloo in this case, also) that they are being too picky. | 21:49 |
| comstud | :) | 21:49 |
| jroll | rloo: we've given them plenty to pick on already :P | 21:49 |
| mrda | lol, adding back in the dynamic loading in client_wrapper.py that somehow slipped through the rebase | 21:49 |
| rloo | jroll: we want to avoid giving them things to pick on. We want them to look at the code and think wow, this is awesome code, I'm going to +2 it. | 21:50 |
| jroll | mrda: yeah, weird that it slipped through, do what you feel is right | 21:50 |
| mrda | It was deva proposed, and it's in ironic today | 21:50 |
| mrda | ok | 21:50 |
| jroll | rloo: I understand, they're going to nitpick already | 21:50 |
| jroll | we should give them as little as possible but I don't think those are going to fly through first try | 21:50 |
| rloo | jroll: no, they won't nitpick. comstud said so ;) | 21:50 |
| comstud | anyone that would nitpick on that should not be core. | 21:50 |
| jroll | rloo: because it's an artifact of how we're breaking the nova paradigm | 21:50 |
| comstud | :P | 21:51 |
| mrda | comstud: good call! | 21:51 |
| rloo | ha ha. I'm going to quote comstud on that! | 21:51 |
| comstud | i'm totally fine with that | 21:51 |
| mrda | whoa. Patch set 1 and 2 are now +A | 21:55 |
| jroll | mrda: saw that this morning :D | 21:55 |
| jroll | good job | 21:55 |
| mrda | Just got to get 3 to pass tests now :) | 21:56 |
| mrda | ok, coffee time | 21:56 |
| jroll | mrda: ping if you want help :) | 21:58 |
| mrda | ta | 21:58 |
| kylestev | jroll: I got an email saying the builded succeeded but it didn't include the test that has been failing | 22:08 |
| kylestev | build* | 22:08 |
| russell_h | kylestev: yeah, that test is reported separately for some reason | 22:08 |
| jroll | kylestev: the tripleo thing is a separate CI job | 22:08 |
| kylestev | ugh | 22:08 |
| jroll | "for some reason" being we care differently about tripleo | 22:08 |
| kylestev | that's annoying. good to know. thanks! | 22:08 |
| jroll | (also because it's third party CI) | 22:08 |
| *** dlaube1 has quit IRC | 22:11 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR and DEPLOYFAIL state https://review.openstack.org/114281 | 22:15 |
| NobodyCam | lol the nova merge check queue is >285 | 22:17 |
| *** HenryG_ has joined #openstack-ironic | 22:17 | |
| *** HenryG has quit IRC | 22:19 | |
| mrda | NobodyCam: welcome to my world | 22:20 |
| NobodyCam | :( | 22:21 |
| NobodyCam | rloo: up for another review? https://review.openstack.org/#/c/98050? | 22:21 |
| kylestev | jroll: happened again \o/ more rechecks | 22:29 |
| jroll | dafuq | 22:29 |
| jroll | at this point | 22:29 |
| mrda | kylestev: that's our CI system :) | 22:29 |
| jroll | I would tell tripleo ci folks their stuff is broken | 22:29 |
| jroll | mrda: no, that's tripleo ci | 22:29 |
| jroll | same failure 3 times in a row | 22:29 |
| jroll | indicates problems imo | 22:29 |
| mrda | well, our as in 'openstack' | 22:30 |
| kylestev | mrda: http://logs.openstack.org/48/115148/7/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/0f5fe5f/console.html#_2014-08-19_22_16_13_578 | 22:30 |
| jroll | kylestev: what's the review link? | 22:30 |
| kylestev | jroll: https://review.openstack.org/#/c/115148/ | 22:30 |
| jroll | mrda: tripleo is third party afaik | 22:30 |
| jroll | thanks | 22:30 |
| kylestev | np | 22:30 |
| jroll | oh wow | 22:30 |
| jroll | I reported that | 22:30 |
| jroll | neat | 22:30 |
| jroll | (the bug) | 22:30 |
| kylestev | yep | 22:31 |
| kylestev | like a month ago... | 22:31 |
| kylestev | still no fix :( | 22:31 |
| jroll | I mean... | 22:31 |
| jroll | that's not abnormal | 22:31 |
| kylestev | :| | 22:31 |
| NobodyCam | humm keystone?? | 22:32 |
| NobodyCam | http://logs.openstack.org/48/115148/7/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/0f5fe5f/logs/seed_logs/keystone.txt.gz | 22:32 |
| jroll | lol. | 22:33 |
| kylestev | NobodyCam: oh my... | 22:34 |
| mrda | just as an aside jroll, do you have any objections in rolling 108545 & 113036 into a single Nova patch? "Performance improvements" | 22:34 |
| NobodyCam | oh maybe not: http://logs.openstack.org/48/115148/7/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/0f5fe5f/logs/seed_logs/neutron-dhcp-agent.txt.gz | 22:34 |
| NobodyCam | mrda: +1 (thou I am not jroll ) | 22:35 |
| jroll | mrda: yeah, fine with me, you might ask comstud what he thinks is best for getting good reviews | 22:35 |
| mrda | NobodyCam: you're a close enough approximation :) | 22:35 |
| NobodyCam | lol | 22:35 |
| jroll | hmm, not sure if an insult or compliment | 22:35 |
| NobodyCam | jroll: is much taller than /me :-p | 22:35 |
| jroll | lol | 22:35 |
| NobodyCam | :) | 22:35 |
| mrda | and I haven't seen NobodyCam in a trucker hat yet | 22:36 |
| NobodyCam | lol I have to do the white and blue you know :p | 22:36 |
| jroll | ... have you seen me in a trucker hat? | 22:36 |
| jroll | I feel like you have me confused with what's his name | 22:37 |
| jroll | from trove | 22:37 |
| mrda | jroll: sure, you wore one in ATL at summit. The first time I met you aftre russell_h's talk in ipa :) | 22:37 |
| NobodyCam | oh jroll who printed up the "bear metal" shirt? are there more of them? | 22:37 |
| mrda | I thought to myself, here is one hipster dude :) | 22:38 |
| jroll | mrda: I don't own a trucker hat, so | 22:38 |
| mrda | lol | 22:38 |
| jroll | I think we're confused :P | 22:38 |
| jroll | but I think I know who you mean | 22:38 |
| mrda | I didn't mean any offence, so I apologise if I have... | 22:38 |
| jroll | ha no | 22:38 |
| *** harlowja has quit IRC | 22:39 | |
| *** harlowja has joined #openstack-ironic | 22:39 | |
| comstud | mrda: i'd roll those 2 together | 22:40 |
| mrda | well anyways, I've only met you guys in person twice now :) Have to find a legitimate reason to come visit SFO | 22:40 |
| comstud | the 2nd one was just a 'oh crap -- need to fix that too' | 22:40 |
| comstud | and it really should have been part of the first one | 22:40 |
| mrda | thanks comstud - I'll get them proposed to nova today | 22:40 |
| jroll | kylestev: | 22:40 |
| jroll | 15:39:16 bnemec | jroll: Your last failure was actually | 22:40 |
| jroll | http://logs.openstack.org/48/115148/7/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/0f5fe5f/console.html#_2014-08-19_22_19_35_898 | 22:40 |
| jroll | 15:39:34 bnemec | A broken patch made it in because our CI wasn't testing new changes properly for a while. | 22:40 |
| jroll | 15:39:47 bnemec | We're reverting the bad change in https://review.openstack.org/#/c/115395/ | 22:40 |
| jroll | so ignore tripleo CI for now :) | 22:40 |
| jroll | (and since this isn't landing any time soon, I'd just ignore it period) | 22:41 |
| mrda | s/for now//g | 22:41 |
| kylestev | jroll: \i/ | 22:41 |
| kylestev | mrda: ha | 22:41 |
| jroll | mrda++ | 22:41 |
| mrda | ;) | 22:41 |
| rloo | NobodyCam: wrt 98050. I have no idea how those templates work. as long as 'text' is in there, it is ok? | 22:41 |
| *** zzzeek has quit IRC | 22:42 | |
| NobodyCam | yea :) | 22:46 |
| *** zzzeek has joined #openstack-ironic | 22:47 | |
| rloo | NobodyCam: so I think I'll let someone else +2 98050. I'm not comfortable doing it since I know so little about how it works. | 22:48 |
| *** penick has quit IRC | 22:50 | |
| openstackgerrit | A change was merged to openstack/ironic: Query full node details and cache https://review.openstack.org/108545 | 22:53 |
| NobodyCam | :) rloo sounds good :) | 22:54 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Use LLDP to get switch port mapping https://review.openstack.org/92627 | 22:55 |
| rloo | NobodyCam: wrt 114281, I put a suggestion. | 22:57 |
| NobodyCam | would love more info then: http://logs.openstack.org/48/115148/7/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/0f5fe5f/logs/seed_logs/mountall.txt.gz | 22:57 |
| NobodyCam | rloo: but then getting the 'or' in the right place is a pain | 22:58 |
| rloo | NobodyCam: yeah, if you really want the 'or' I guess. hmm. | 23:00 |
| rloo | NobodyCam: what if you did 'State must be one of: '. | 23:00 |
| *** shakamunyi has joined #openstack-ironic | 23:02 | |
| rloo | NobodyCam: 'State must be one of: a, b, c' ? (there are instances of that join in other places) | 23:03 |
| NobodyCam | humm... | 23:03 |
| NobodyCam | ya | 23:03 |
| NobodyCam | one sec | 23:03 |
| *** zzzeek_ has joined #openstack-ironic | 23:08 | |
| *** zzzeek has quit IRC | 23:08 | |
| *** zzzeek_ is now known as zzzeek | 23:08 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR and DEPLOYFAIL state https://review.openstack.org/114281 | 23:09 |
| NobodyCam | rloo: more like ^^^^ | 23:09 |
| NobodyCam | ??? | 23:09 |
| NobodyCam | :) | 23:09 |
| *** zzzeek has quit IRC | 23:10 | |
| *** shakamunyi has quit IRC | 23:18 | |
| NobodyCam | kylestev: is the recheck you used on 115148 the real root cause? I would have said: https://bugs.launchpad.net/nova/+bug/921858 based on http://logs.openstack.org/48/115148/7/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/0f5fe5f/logs/seed_logs/nova-api.txt.gz | 23:19 |
| kylestev | NobodyCam: There were many errors messages -- talking to JoshNang and jroll it was decided to recheck based on 1344050 | 23:27 |
| NobodyCam | :) | 23:30 |
| NobodyCam | its all good :) | 23:30 |
| *** shakamunyi has joined #openstack-ironic | 23:33 | |
| openstackgerrit | A change was merged to openstack/ironic: Use cache in node_is_available() https://review.openstack.org/113036 | 23:35 |
| openstackgerrit | Sergey Lupersolsky proposed a change to openstack/python-ironicclient: Fix misspelled class name AmbigiousAuthSystem https://review.openstack.org/114916 | 23:35 |
| *** igordcard has quit IRC | 23:35 | |
| *** HenryG_ is now known as HenryG | 23:42 | |
| jroll | mrda: I'm about to take off, need anything from me? | 23:53 |
| jroll | ok :) night all! | 23:53 |
| mrda | jroll: you've been a big help, but I should be ok. It's difficult finding out why tests run in ironic and not nova, but it's just legwork, so I should be ok. Thanks for the offer of help! | 23:53 |
| NobodyCam | that was quick | 23:53 |
| mrda | NobodyCam: He gave me 42 seconds to respond :P | 23:54 |
| jroll | :P | 23:54 |
| NobodyCam | jroll: mind re adding your +2 to https://review.openstack.org/#/c/114281/14 | 23:54 |
| jroll | sure, sec | 23:54 |
| NobodyCam | lol | 23:54 |
| mrda | lol | 23:54 |
| jroll | NobodyCam: it failed tripleo, -2 | 23:54 |
| mrda | see above comment from me :) | 23:54 |
| NobodyCam | lol grr | 23:54 |
| jroll | NobodyCam: see greg's comments? | 23:55 |
| jroll | :| | 23:55 |
| jroll | NobodyCam: new patch gogogo | 23:55 |
| NobodyCam | lol | 23:56 |
| NobodyCam | one sec | 23:56 |
| * jroll waits one sec and then leaves | 23:58 | |
| openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Allow rebuild of node in ERROR and DEPLOYFAIL state https://review.openstack.org/114281 | 23:58 |
| NobodyCam | lol Have a good night jroll :) | 23:59 |
| jroll | thanks | 23:59 |
| NobodyCam | heheheh | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!