*** bigjools has quit IRC | 00:33 | |
*** bigjools has joined #openstack-ironic | 00:44 | |
*** bigjools has joined #openstack-ironic | 00:44 | |
*** bigjools has quit IRC | 00:53 | |
*** bigjools has joined #openstack-ironic | 00:55 | |
*** bigjools has joined #openstack-ironic | 00:55 | |
*** pcrews has joined #openstack-ironic | 01:35 | |
*** nosnos has joined #openstack-ironic | 01:40 | |
*** pcrews has quit IRC | 01:51 | |
*** lazy_prince has quit IRC | 02:28 | |
*** killer_prince has joined #openstack-ironic | 02:37 | |
*** killer_prince is now known as lazy_prince | 02:38 | |
*** ramineni has joined #openstack-ironic | 03:16 | |
*** nosnos has quit IRC | 03:22 | |
*** Poornima has joined #openstack-ironic | 03:35 | |
*** rameshg87 has joined #openstack-ironic | 03:38 | |
*** eghobo has joined #openstack-ironic | 03:56 | |
*** nosnos has joined #openstack-ironic | 04:10 | |
*** sabah has joined #openstack-ironic | 04:26 | |
*** mdorman has joined #openstack-ironic | 04:34 | |
*** vinbs has joined #openstack-ironic | 04:35 | |
*** mdorman has quit IRC | 04:41 | |
*** lazy_prince has quit IRC | 04:42 | |
*** eghobo has quit IRC | 04:44 | |
*** saripurigopi has joined #openstack-ironic | 04:49 | |
*** mdorman has joined #openstack-ironic | 04:49 | |
*** rameshg87 has quit IRC | 04:49 | |
*** mdorman has quit IRC | 04:49 | |
*** rameshg87 has joined #openstack-ironic | 04:50 | |
*** vinbs has quit IRC | 04:50 | |
saripurigopi | Is there any wiki page that describes how to run various test cases after code changes? | 04:50 |
---|---|---|
*** vinbs has joined #openstack-ironic | 04:50 | |
*** bmahalakshmi has joined #openstack-ironic | 04:54 | |
*** lazy_prince has joined #openstack-ironic | 05:03 | |
*** lazy_prince has quit IRC | 05:03 | |
*** lazy_prince has joined #openstack-ironic | 05:03 | |
*** mdorman_ has joined #openstack-ironic | 05:03 | |
*** mdorman_ is now known as mdorman | 05:03 | |
*** bmahalakshmi2 has joined #openstack-ironic | 05:04 | |
*** bmahalakshmi has quit IRC | 05:04 | |
*** radsy has quit IRC | 05:13 | |
*** bmahalakshmi2 has quit IRC | 05:20 | |
rameshg87 | saripurigopi, may be you are looking for this one ? - http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 05:21 |
*** rameshg87 has quit IRC | 05:21 | |
*** bmahalakshmi has joined #openstack-ironic | 05:27 | |
*** mdorman has quit IRC | 05:30 | |
*** mdorman_ has joined #openstack-ironic | 05:31 | |
*** mdorman_ has quit IRC | 05:33 | |
*** bvivek has joined #openstack-ironic | 05:35 | |
*** bmahalakshmi has quit IRC | 05:35 | |
*** bmahalakshmi has joined #openstack-ironic | 05:36 | |
*** bmahalakshmi has quit IRC | 05:37 | |
*** k4n0 has joined #openstack-ironic | 05:38 | |
*** bmahalakshmi has joined #openstack-ironic | 05:39 | |
saripurigopi | @rameshg87, yes, thanks | 05:45 |
openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: iLO Node discovery https://review.openstack.org/109088 | 05:55 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/113075 | 06:10 |
*** dtantsur|afk is now known as dtantsur | 06:12 | |
dtantsur | Morning, Ironic | 06:13 |
*** rakesh_hs has joined #openstack-ironic | 06:14 | |
mrda | hi dtantsur | 06:19 |
vinbs | Morning dtantsur | 06:19 |
dtantsur | mrda, vinbs, hi :) | 06:22 |
*** zigo has quit IRC | 06:31 | |
*** zigo has joined #openstack-ironic | 06:36 | |
*** saripurigopi has quit IRC | 06:38 | |
*** mkerrin has quit IRC | 07:39 | |
*** jistr has joined #openstack-ironic | 07:43 | |
*** jistr has quit IRC | 07:44 | |
*** jistr has joined #openstack-ironic | 07:44 | |
*** Mikhail_D_wk has left #openstack-ironic | 07:44 | |
*** pradipta_away is now known as pradipta | 07:44 | |
*** mkerrin has joined #openstack-ironic | 07:45 | |
*** mrda is now known as mrda-away | 08:02 | |
*** ndipanov has joined #openstack-ironic | 08:08 | |
*** lucasagomes has joined #openstack-ironic | 08:09 | |
dtantsur | errands, bbl | 08:15 |
*** dtantsur is now known as dtantsur|bbl | 08:15 | |
*** nosnos has quit IRC | 08:19 | |
*** nosnos has joined #openstack-ironic | 08:21 | |
*** derekh has joined #openstack-ironic | 08:28 | |
*** Poornima has quit IRC | 08:34 | |
*** athomas has joined #openstack-ironic | 08:35 | |
*** jistr has quit IRC | 08:35 | |
*** jistr has joined #openstack-ironic | 08:38 | |
*** k4n0 has quit IRC | 08:42 | |
*** bvivek has quit IRC | 08:57 | |
*** dguerri`afk is now known as dguerri | 08:58 | |
*** k4n0 has joined #openstack-ironic | 08:59 | |
*** jistr has quit IRC | 09:22 | |
*** jistr has joined #openstack-ironic | 09:41 | |
*** pradipta is now known as pradipta_away | 09:42 | |
*** pradipta_away is now known as pradipta | 09:44 | |
*** pradipta is now known as pradipta_away | 09:45 | |
*** pelix has joined #openstack-ironic | 09:46 | |
*** rameshg87 has joined #openstack-ironic | 09:53 | |
*** pradipta_away is now known as pradipta | 09:54 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add create() and destroy() to Port object https://review.openstack.org/112323 | 09:58 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove direct calls to dbapi's get_node_by_instance https://review.openstack.org/112595 | 09:58 |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Move code to cleanup ImageCache to a common place https://review.openstack.org/110560 | 10:01 |
*** rameshg87 has quit IRC | 10:24 | |
*** k4n0 has quit IRC | 10:27 | |
*** sabah has quit IRC | 10:41 | |
*** ramineni has quit IRC | 10:58 | |
*** k4n0 has joined #openstack-ironic | 10:59 | |
*** bvivek has joined #openstack-ironic | 11:13 | |
*** lucasagomes is now known as lucas-hungry | 11:19 | |
*** jroll has quit IRC | 11:34 | |
*** dtantsur|bbl is now known as dtantsur | 11:45 | |
*** pradipta is now known as pradipta_away | 11:59 | |
*** vinbs has quit IRC | 12:00 | |
*** zigo has quit IRC | 12:17 | |
*** zigo has joined #openstack-ironic | 12:18 | |
*** jroll has joined #openstack-ironic | 12:19 | |
*** lucas-hungry is now known as lucasagomes | 12:21 | |
*** jroll has quit IRC | 12:24 | |
Shrews | lucasagomes: for the sphinx change, see this review: https://review.openstack.org/108624 | 12:29 |
lucasagomes | Shrews, hey morning | 12:30 |
lucasagomes | will take a look | 12:30 |
Shrews | morning | 12:30 |
lucasagomes | Shrews, a-ha, and this landed only for icehouse? | 12:30 |
lucasagomes | that doesn't seem to be a back port, I looked in the git logs for the requirements project | 12:31 |
*** nosnos has quit IRC | 12:31 | |
Shrews | lucasagomes: and havana | 12:31 |
lucasagomes | and that odd version was never there afaict | 12:31 |
lucasagomes | Shrews, I see... alright thanks for pointing me to that | 12:31 |
lucasagomes | I will change my vote | 12:31 |
lucasagomes | I was a bit confused when I saw that | 12:31 |
*** jroll has joined #openstack-ironic | 12:32 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Reduce running time of test_different_sizes https://review.openstack.org/113244 | 12:34 |
Shrews | lucasagomes: any reason https://review.openstack.org/112595 isn't approved? | 12:42 |
lucasagomes | Shrews, it was, but there's a dependency | 12:43 |
Shrews | oh, yeah. just saw that | 12:43 |
lucasagomes | I fixed the dependency and uploaded a new patch set so it lost the approved status for that patch :( | 12:43 |
openstackgerrit | Dan Prince proposed a change to openstack/ironic: Add method for deallocating networks on reschedule https://review.openstack.org/113047 | 12:50 |
*** matty_dubs|gone is now known as matty_dubs | 13:02 | |
*** shardy has joined #openstack-ironic | 13:05 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Show port by MAC address https://review.openstack.org/113252 | 13:05 |
shardy | Hi all, can anyone point me to the sources for http://docs.openstack.org/developer/ironic/dev/api-spec-v1.html please? | 13:06 |
*** rloo has joined #openstack-ironic | 13:11 | |
dtantsur | shardy, hi! IIRC it's mostly autogenerated, main source is https://raw.githubusercontent.com/openstack/ironic/master/doc/source/webapi/v1.rst | 13:11 |
shardy | dtantsur: Hi! Thanks, but the error I'd like to fix is in the Image section, I don't see that referenced as a controller in the code anywhere? | 13:14 |
*** bmahalakshmi has quit IRC | 13:14 | |
shardy | It's only a minor nit, but figured it may be worth fixing while I'm figuring out where everything is :) | 13:15 |
dtantsur | shardy, wow, I didn't know we support storing images Oo lemme see... | 13:15 |
shardy | dtantsur: yeah it does seem a little odd :) | 13:16 |
shardy | Says it's just an alias for the glance API | 13:16 |
dtantsur | shardy, we don't have this endpoint | 13:18 |
*** Poornima has joined #openstack-ironic | 13:18 | |
dtantsur | it should be a bug | 13:18 |
dtantsur | rloo, lucasagomes, Shrews, hi, have any idea what http://docs.openstack.org/developer/ironic/dev/api-spec-v1.html#image is? | 13:18 |
lucasagomes | dtantsur, hey... lemme see | 13:18 |
rloo | hi dtantsur -- lucasagomes will check :-) | 13:19 |
lucasagomes | hah well we def have no /images URI seems like an old copy&paste thing from some other project (prolly nova) | 13:19 |
dtantsur | I suspect it's something seriously outdated, we already have similar problem with installation guide | 13:19 |
dtantsur | shardy, thanks for reporting | 13:19 |
shardy | dtantsur: np, I'm happy to post a patch fixing it if we can work out where the section comes from :) | 13:20 |
dtantsur | we even had a bug for it, but you know... we're using launchpad... I can't find it | 13:22 |
rloo | dtantsur, shardy, lucasagomes: I think that api-spec-v1.html page was replaced by http://docs.openstack.org/developer/ironic/webapi/v1.html | 13:23 |
*** pcrews has joined #openstack-ironic | 13:23 | |
Shrews | rloo: welcome back! | 13:23 |
dtantsur | rloo, right. we need to get rid of these ancient pages asap, I guess | 13:23 |
lucasagomes | weird I can't find that section as well | 13:23 |
rloo | hi Shrews, thx! (although hard to be back heh) | 13:23 |
Shrews | rloo: hehe, i'm sure. i'm gone next week. can't wait :) | 13:24 |
shardy | rloo: Oh, OK, thanks - that's *really* confusing to a new API user :) | 13:24 |
rloo | shardy: yeah, I can imagine that it would be very confusing. Just not sure how to 'remove' it. | 13:25 |
lucasagomes | yeah... maybe after it generates the doc it's not updating the page correctly? cause I built the docs locally and I can't find those sections | 13:25 |
dtantsur | here's related bug https://bugs.launchpad.net/ironic/+bug/1323712 | 13:25 |
rloo | dtantsur: is that an infra question? seems like there was another page you noticed awhile ago, that needed to be removed too. | 13:25 |
lucasagomes | rloo, yeah looks like | 13:26 |
rloo | thanks dtantsur. Maybe importance is medium since it affects new users? | 13:27 |
dtantsur | rloo, devananda set it to low | 13:27 |
rloo | dtantsur: ah. ok, we'll leave it low then. I guess we could change the page; add a link to the new page. although there should be a way to delete it. | 13:28 |
dtantsur | pinged infra | 13:29 |
lucasagomes | seems like our gate docs jobs is not cleaning up stuff correctly so old pages can still be accessed | 13:30 |
*** rakesh_hs has quit IRC | 13:30 | |
dtantsur | lucasagomes, see #infra, it must be a general problem | 13:30 |
lucasagomes | dtantsur, joining | 13:31 |
*** linggao has joined #openstack-ironic | 13:34 | |
dtantsur | I was asked, if we have a means of creating a redirect in our docs. Anyone knows? | 13:35 |
rloo | dtantsur: don't you just add a redirect link to the page? (Ie, I don't know.) | 13:37 |
dtantsur | rloo, I don't think we want to reintroduce these all pages in our sources | 13:38 |
rloo | dtantsur: agree. They can be deleted, right? | 13:39 |
dtantsur | rloo, yes, manually | 13:39 |
rloo | dtantsur: since ironic is so young, I don't know that we care to have redirects. Redirect would be the right thing to do if eg people bookmarked the page. | 13:39 |
*** jgrimm has quit IRC | 13:42 | |
*** lazy_prince is now known as killer_prince | 13:45 | |
*** krtaylor has quit IRC | 13:53 | |
openstackgerrit | A change was merged to openstack/ironic: Add create() and destroy() to Port object https://review.openstack.org/112323 | 13:56 |
openstackgerrit | A change was merged to openstack/ironic: Remove direct calls to dbapi's get_node_by_instance https://review.openstack.org/112595 | 13:56 |
*** krtaylor has joined #openstack-ironic | 13:58 | |
openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties at node-create/node-discover-properties https://review.openstack.org/100951 | 13:59 |
*** Nisha has joined #openstack-ironic | 14:00 | |
Nisha | lucasagomes: dtantsur posted the new patch for Discovery spec addressing your comments. | 14:01 |
openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties at node-create/node-discover-properties https://review.openstack.org/100951 | 14:06 |
*** killer_prince has quit IRC | 14:09 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/python-ironicclient: Add /nodes/detail support https://review.openstack.org/112610 | 14:09 |
jroll | morning ironic :) | 14:09 |
*** sabah has joined #openstack-ironic | 14:09 | |
jroll | lucasagomes: good catch on that ^ thank you! | 14:09 |
lucasagomes | jroll, morning! no problem, thanks for fixing it :) will re-review it soon | 14:10 |
jroll | cool, ty | 14:10 |
jroll | I want to land everything today :P | 14:10 |
lucasagomes | np for me :D | 14:13 |
dtantsur | jroll, morning! | 14:17 |
jroll | heya dtantsur :) | 14:17 |
NobodyCam | good morning Ironic | 14:25 |
dtantsur | NobodyCam, morning :) | 14:26 |
NobodyCam | morning dtantsur :) have a good weekend? | 14:26 |
dtantsur | yes, quite :) thanks | 14:27 |
jroll | morning NobodyCam :) | 14:29 |
NobodyCam | morning jroll :) | 14:30 |
NobodyCam | How was your weekend? how are you feeling today? | 14:31 |
*** Poornima has quit IRC | 14:32 | |
*** k4n0 has quit IRC | 14:33 | |
*** rwsu has joined #openstack-ironic | 14:34 | |
lucasagomes | jroll, there's small thing on #112610 that Shrews pointed out | 14:34 |
lucasagomes | other than that it LGTM | 14:34 |
jroll | NobodyCam: weekend was good, feeling fine :) how about yourself? | 14:36 |
jroll | lucasagomes: gah | 14:36 |
jroll | thanks for that one Shrews :) | 14:37 |
*** killer_prince has joined #openstack-ironic | 14:38 | |
*** killer_prince is now known as lazy_prince | 14:38 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/python-ironicclient: Add /nodes/detail support https://review.openstack.org/112610 | 14:38 |
jroll | lucasagomes, Shrews ^^ | 14:38 |
lucasagomes | jroll, awesome +2'd | 14:39 |
NobodyCam | morning lucasagomes :) | 14:41 |
lucasagomes | NobodyCam, yo morning buddy, how it's going? | 14:42 |
jroll | thanks lucas | 14:42 |
NobodyCam | much better then last week at the same time | 14:42 |
NobodyCam | :) | 14:42 |
lucasagomes | :) good | 14:42 |
*** ryanpetrello has quit IRC | 14:43 | |
*** jgrimm has joined #openstack-ironic | 14:45 | |
*** ryanpetrello has joined #openstack-ironic | 14:47 | |
*** lazy_prince has quit IRC | 14:47 | |
*** killer_prince has joined #openstack-ironic | 14:58 | |
*** zigo has quit IRC | 14:58 | |
*** killer_prince is now known as lazy_prince | 14:58 | |
*** zigo has joined #openstack-ironic | 14:59 | |
*** jasondotstar has joined #openstack-ironic | 15:14 | |
*** krtaylor has quit IRC | 15:37 | |
*** sabah has quit IRC | 15:56 | |
NobodyCam | brb | 15:57 |
devananda | morning, all | 15:59 |
openstackgerrit | A change was merged to openstack/ironic: Reduce running time of test_different_sizes https://review.openstack.org/113244 | 16:01 |
*** matty_dubs is now known as matty_dubs|lunch | 16:03 | |
NobodyCam | good morning devananda | 16:04 |
dtantsur | devananda, morning | 16:07 |
lucasagomes | morning devananda | 16:10 |
*** krtaylor has joined #openstack-ironic | 16:18 | |
*** bvivek has quit IRC | 16:20 | |
*** ellenh has joined #openstack-ironic | 16:23 | |
*** jistr has quit IRC | 16:29 | |
*** ellenh1 has joined #openstack-ironic | 16:30 | |
*** openstack has joined #openstack-ironic | 16:33 | |
NobodyCam | Are there any open Spec's that need looking at before the meeting? | 16:35 |
JayF | I think all specs we wanted to land for J are in | 16:36 |
NobodyCam | ya!!!! | 16:36 |
JayF | maybe saying that in the meeting and seeing if anyone frantically disagrees | 16:36 |
JayF | is the best way to be certain :P | 16:36 |
NobodyCam | lol | 16:37 |
dtantsur | are we trying to land this: https://review.openstack.org/100951 ? | 16:37 |
JayF | Very much not is my understanding | 16:38 |
JayF | all the node-update/discovery/hardware interrogation stuff is going to be significantly hashed out at the summit | 16:38 |
Shrews | Is it still a no-no to +A something before Jenkins gives it a +1? | 16:38 |
JayF | Shrews: I've heard it's OK | 16:39 |
Shrews | JayF: from? | 16:39 |
NobodyCam | I try and wait until mr J is done | 16:39 |
JayF | deva :) | 16:39 |
Shrews | 'cept Mr. J is slooooooow | 16:39 |
JayF | I've seen him do it (IPA driver at Mid-cycle) | 16:39 |
BadCub | Morning everyone | 16:39 |
NobodyCam | morning BadCub | 16:40 |
*** ellenh1 has quit IRC | 16:41 | |
dtantsur | Folks, is there interest in thing like Ansible playbook for Ironic quick start guide? I have some here in private and wondering if I should share (requires some clean up though) | 16:42 |
JayF | I think you should share all code you use --> provisioning, software, anything | 16:42 |
JayF | best case scenario you make your life easier (open repos are easier to use) and help others | 16:43 |
Shrews | dtantsur: i'm sure there would be interest in it from someone | 16:43 |
NobodyCam | dtantsur: YES!!!!!! | 16:43 |
JayF | worst case you still make it easier for yourself :)( | 16:43 |
dtantsur | it requires some effort to separate it from my private (really private) cookbooks, but I'll do it maybe tomorrow | 16:43 |
dtantsur | now food-buying-time, brb | 16:44 |
NobodyCam | dtantsur: that would awesome!!!!! | 16:44 |
NobodyCam | oh seems I need to do a quick walkies... brb | 16:44 |
JayF | The only closed source stuff (other than all our deploy automation, which is integrated with our cloud stuff) that we have is we use our own CoreOS image builder, that's basically a copy of imagebuild/coreos is IPA with our own hardware manager added and a lot of utilities (like for bios) | 16:45 |
*** romcheg1 has joined #openstack-ironic | 16:47 | |
dtantsur | JayF, well it started as: "let's create a cookbook for setting up the VM how I like it" :) and ended up with some good stuff inside | 16:48 |
dtantsur | the hardest thing would be to make it work under Ubuntu, though | 16:48 |
dtantsur | ok, really brb for now | 16:48 |
JayF | just open it up. if folks wanna make it work better they can :) | 16:48 |
*** vinbs has joined #openstack-ironic | 16:50 | |
devananda | dtantsur: yes! | 16:51 |
devananda | dtantsur: is this a playbook to use ansible to start and configure ironic? or to use ironic to provision? | 16:52 |
devananda | both are useful. just curious which one you've done | 16:52 |
dtantsur | devananda, to configure. I have 2 peaces: one for "Exercising the Services Locally" (up to actually starting conductor & API), another small one for "Deploying Ironic with DevStack" up to running ./stack.sh | 16:53 |
JayF | NobodyCam: I dropped a -2 and a comment on https://review.openstack.org/#/c/100951/33 | 16:54 |
dtantsur | I'm not sure it's super-useful, but I no longer can do it by hand on each VM :) | 16:54 |
NobodyCam | JayF: ack :) | 16:54 |
dtantsur | + in 1st part using mariadb instead of sqlite | 16:54 |
*** vinbs has quit IRC | 16:55 | |
*** ndipanov is now known as ndipanov_gone | 16:55 | |
* JayF really hopes his and JoshNang's decom talk get in for Paris, watching nodes decom is thrilling | 16:55 | |
dtantsur | ehh | 16:56 |
* dtantsur has very low chances of getting to Paris | 16:56 | |
JayF | We were told that if we got a talk in, we'd get sent. I'm going to try hard to go either way because I think there are some design sessions we need to have that I want to be in | 16:57 |
devananda | dtantsur: ok. neither of those are quite what I'm looking for, but they'd none the less be helpful :) | 16:57 |
devananda | JayF: a few of you definitely should go | 16:57 |
dtantsur | devananda, heh, one day I can actually end up with what you want. I'm an automation fan :) what were you looking for? | 16:58 |
JayF | devananda: we're trying :) pull strings to make sure me+joshnang's talk is approved and jroll's talk is approved and that'll be three os us ;) | 16:58 |
*** dtantsur is now known as dtantsur|brb | 16:59 | |
*** matty_dubs|lunch is now known as matty_dubs | 17:00 | |
*** derekh has quit IRC | 17:02 | |
*** lucasagomes is now known as lucas-dinner | 17:04 | |
*** romcheg1 has quit IRC | 17:04 | |
*** bearhands is now known as comstud | 17:07 | |
*** bmahalakshmi has joined #openstack-ironic | 17:13 | |
Nisha | Hi JayF | 17:29 |
Nisha | JayF: https://review.openstack.org/#/c/100951/ is not node-discovery, it is node-properties discovery | 17:32 |
JayF | Nisha: i.e., I add a node, then Ironic discovers details about the node properties? | 17:33 |
JayF | Nisha: If so, then yes, that's something we talked about at the mid-cycle and decided to table until Kilo because of some of the contenious nature of adding the scope to Ironic :( | 17:33 |
Nisha | JayF: Sorry i didnt get the above ^ | 17:33 |
JayF | Nisha: meaning, your spec is about discovering properties of an added node | 17:34 |
JayF | i.e. hardware inspection/validation | 17:34 |
JayF | right? | 17:34 |
Nisha | No, it is discovering properties at the time of registering node | 17:34 |
*** pelix has quit IRC | 17:34 | |
JayF | Nisha: yes, that's what I meant. That is something that I think we (Ironic) want to talk about at the design summit in paris and talk about what's in scope, how to implement, etc | 17:35 |
JayF | Nisha: we spent the better part of a day talking about it at mid-cycle -- both your specs and ones like them | 17:35 |
openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 17:36 |
Nisha | JayF: I posted the patch after i got comments from lucas-dinner last week ....for those comments i had discussion with lucas-dinner and dtantsur|brb on IRC too | 17:37 |
*** dtantsur|brb is now known as dtantsur | 17:37 | |
jroll | devananda: after https://review.openstack.org/112610 merges, can we tag a new client? :) | 17:37 |
jroll | devananda: the nova caching patches are waiting for a new client version to land | 17:38 |
devananda | jroll: sure | 17:38 |
jroll | cool, thanks - I'll ping you if I see it merge | 17:38 |
JayF | Nisha: I understand, and I'm sorry to bear the bad news in this case. You can feel free to bring it up in the meeting if you think I'm wrong, and I'll gladly remove my -2 if the consensus changes that we should try and implement this for Juno :) | 17:38 |
dtantsur | Nisha, your patch is not wrong or bad, we appreciate your work, but 1. core team is already quite busy and won't be able to land more; 2. discovery is a hot topic that is expected to be prototyped more thoroughly during K cycle | 17:38 |
Nisha | dtantsur: JayF Ok. | 17:39 |
dtantsur | but yeah, if folks decide to give it a go - I'm ok with it. Bare in mind, that it does not make sense to land only this spec, but also 2 consequent | 17:39 |
jroll | mrda-away: fyi, we want to get these landed and into the nova patches: https://review.openstack.org/#/c/108545/ https://review.openstack.org/#/c/113036/ | 17:39 |
jroll | mrda-away: waiting on a new client, then they'll be good to land | 17:40 |
devananda | jroll: mrda-away and I are tracking the nova work onthe whiteboard. I'll add those | 17:40 |
jroll | devananda: right on, ty | 17:40 |
devananda | also, I spent several hours on friday merging small things into the patch chain | 17:41 |
*** bmahalakshmi has quit IRC | 17:41 | |
devananda | I'm going to begin arming mrda with sharp pointy objects so he can poke all of you | 17:42 |
jroll | yay | 17:42 |
Shrews | jroll: the '70s called. they want their lingo back | 17:42 |
jroll | lol | 17:42 |
jroll | /nick stuckinthe70s | 17:42 |
Shrews | righteous | 17:43 |
jroll | :P | 17:45 |
*** rameshg87 has joined #openstack-ironic | 17:45 | |
*** romcheg1 has joined #openstack-ironic | 17:48 | |
NobodyCam | lol | 17:48 |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Move code to cleanup ImageCache to a common place https://review.openstack.org/110560 | 17:50 |
*** romcheg1 has quit IRC | 17:52 | |
*** dguerri is now known as dguerri`afk | 17:56 | |
rameshg87 | devananda, hi | 18:16 |
*** coolsvap has quit IRC | 18:17 | |
*** harshada_kakad_ has joined #openstack-ironic | 18:17 | |
jroll | has anyone proposed a spec for notification support, like nova does? | 18:20 |
*** coolsvap has joined #openstack-ironic | 18:20 | |
rameshg87 | jroll, something similar to this ? - https://review.openstack.org/#/c/99770/ | 18:22 |
NobodyCam | brb | 18:22 |
jroll | rameshg87: more like https://github.com/openstack/nova/blob/master/nova/notifications.py | 18:23 |
jroll | rameshg87: it puts notifications for events on the rabbit bus | 18:23 |
rameshg87 | jroll, okay. | 18:24 |
devananda | jroll: yes. lemme find the link | 18:29 |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Take iSCSI deploy out of pxe driver https://review.openstack.org/111232 | 18:31 |
devananda | jroll: no. but there's this, which is not what you asked for :) https://review.openstack.org/#/c/72538/44/ironic/conductor/manager.py | 18:32 |
jroll | devananda: heh, not at all :) | 18:33 |
jroll | ok | 18:33 |
jroll | I'm thinking build/destroy notifications etc | 18:34 |
devananda | jroll: right. afaik, no, because Nova does that alraedy, so it would kinda be redundant? | 18:35 |
dtantsur | " Fedora support (dtantsur) There hasn't been much to report in a while. Should we take this off the agenda?" <-- likely yes. I guess there is no much breaking changes now. | 18:35 |
dtantsur | devananda, ^^^ | 18:35 |
devananda | dtantsur: great, thanks for the updaet! | 18:35 |
jroll | devananda: for those, yes, but what about e.g. 'decom failed', nova won't know anything about that | 18:35 |
jroll | devananda: or 'power state set to off' | 18:36 |
jroll | idk if that's useful or not | 18:36 |
jroll | but likely is | 18:36 |
devananda | jroll: honestly idk what the notifications are actually used for -- i suspect feeding into billing systems and the like, and you're the only ones (so far) billing for Ironic usage | 18:37 |
devananda | jroll: I am much more interested in API callbacks between services | 18:37 |
russell_h | devananda: we just bill for nova usage | 18:37 |
jroll | ^^ | 18:38 |
russell_h | for what thats worth | 18:38 |
devananda | eg, so that nova doesn't need to poll as often, and Ironic can actively inform nova of resource changes | 18:38 |
devananda | russell_h: thanks. that's what I expected | 18:38 |
jroll | devananda: I want to follow a stream of events and do things when bad things happen | 18:38 |
jroll | :) | 18:38 |
jroll | s/bad/interesting/ | 18:38 |
devananda | jroll: as an operator, creating operational tooling to troubleshoot "interesting" things -- I get that. tail the log file :) | 18:39 |
devananda | (j/k) | 18:39 |
jroll | heh | 18:39 |
devananda | but really, what's the difference between that kind of notification vs. a DEBUG log? | 18:39 |
jroll | that was the other direction I thought about, just stream logs | 18:39 |
devananda | or an ERROR log? | 18:39 |
jroll | these would be ERROR/WARNING logs | 18:39 |
jroll | yeah | 18:39 |
jroll | because we already have infrastructure that consumes a rabbit queue of events | 18:40 |
devananda | right. so yea, I think that's mroe what you're looking for, whereas the notification bus is there for billing and auditing events | 18:40 |
jroll | I suspect others may have that | 18:40 |
jroll | right - auditing may be a good use case | 18:40 |
devananda | I dunno - perhaps there's a queue for each | 18:40 |
jroll | audit ironic API use | 18:40 |
devananda | sure | 18:40 |
devananda | I can definitely see that | 18:40 |
devananda | "user 123 created node XYZ" | 18:40 |
jroll | but also thinking of seeing issues that nova wouldn't see - e.g. bmc goewdies | 18:41 |
jroll | dies* | 18:41 |
*** harshada_kakad_ has quit IRC | 18:44 | |
NobodyCam | last chance to get your item on the agenda | 18:44 |
*** harshada_kakad_ has joined #openstack-ironic | 18:45 | |
devananda | hmm | 18:45 |
devananda | we have an iLO driver in tree right now -- but as it landed, it's non-functional | 18:46 |
matty_dubs | Not an agenda item for the meeting, but I should mention to you guys... I've accepted a new position, so this will be my last week at Red Hat, and my last week working on OpenStack. :'( It's been terrific working with you all, though! | 18:46 |
dtantsur | matty_dubs ;( | 18:47 |
devananda | it includes a new "ilo" top level driver, which does not implement the required DeployInterface :( | 18:47 |
matty_dubs | dtantsur: Yeah :( | 18:47 |
NobodyCam | omg matty_dubs .... best of luck in your new directrion :) | 18:47 |
devananda | matty_dubs: congradulations. Good luck on your new adventure, though you'll be missed here | 18:47 |
NobodyCam | direction even | 18:47 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Use relative time sleeping in heartbeat thread https://review.openstack.org/113343 | 18:47 |
dtantsur | devananda, oh, and I've seen the same with recent (not yet merged) drac driver - no deploy interface | 18:47 |
NobodyCam | +1 to matty_dubs will be missed | 18:48 |
matty_dubs | Thanks guys :) | 18:48 |
jroll | matty_dubs: :( but grats on the new gig :) | 18:48 |
devananda | dtantsur: https://review.openstack.org/#/c/89500/26 | 18:48 |
devananda | dtantsur: not implementing required interfaces means it's not really a driver and should not be added to setup.cfg | 18:49 |
devananda | we should not have approved that patch :( | 18:49 |
dtantsur | yeah, shame on me for approving :( | 18:49 |
*** dlaube has joined #openstack-ironic | 18:50 | |
dtantsur | rameshg87, ^^^ | 18:50 |
rameshg87 | dtantsur, oh ! | 18:52 |
rameshg87 | dtantsur, so should we remove it from setup.cfg until deploy driver is merged ? | 18:52 |
rameshg87 | dtantsur, does that make sense ? | 18:52 |
devananda | I'm fixing it now | 18:53 |
devananda | one sec | 18:53 |
dtantsur | rameshg87, what's the state of the deploy driver btw? | 18:54 |
lucas-dinner | devananda, oh thanks for the review on the ports client patch, the /detail makes total sense! | 18:54 |
*** lucas-dinner is now known as lucasagomes | 18:54 | |
devananda | lucasagomes: yvw | 18:54 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Replace incomplete "ilo" driver with pxe_ilo https://review.openstack.org/113346 | 18:54 |
devananda | rameshg87: ^ paves teh way for using PXE for deploy but iLO for power and management interfaces | 18:55 |
devananda | rameshg87: when you have the minimum "core" interfaces landed, then please re-add the "ilo" driver to setup.cfg | 18:55 |
rameshg87 | dtantsur, WIP - should post the complete set of patches for deploy driver in a couple of days | 18:55 |
rameshg87 | devananda, okay, will add it when the deploy has landed too. thanks for taking care of it. | 18:56 |
devananda | almost meeting time :) | 18:57 |
*** mrda-away is now known as mrda | 18:57 | |
mrda | Morning Ironic | 18:57 |
dtantsur | mrda, morning :) | 18:58 |
devananda | mrda: good morning! | 18:58 |
mrda | devananda: dtantsur \o | 18:59 |
*** iron1 has quit IRC | 18:59 | |
NobodyCam | morning mrda | 18:59 |
mrda | jroll: ack | 18:59 |
jroll | :) | 18:59 |
mrda | NobodyCam: \o | 19:00 |
NobodyCam | o/ | 19:00 |
*** romcheg1 has joined #openstack-ironic | 19:19 | |
openstackgerrit | A change was merged to openstack/python-ironicclient: Add /nodes/detail support https://review.openstack.org/112610 | 19:23 |
jroll | devananda: friendly reminder to tag a new client after the meeting :) ^ | 19:23 |
devananda | jroll: snooze 40 minutes | 19:24 |
devananda | :) | 19:24 |
NobodyCam | :-p | 19:24 |
jroll | you weren't supposed to look yet :P | 19:24 |
devananda | it pinged me | 19:24 |
*** romcheg1 has quit IRC | 19:26 | |
*** bvivek has joined #openstack-ironic | 19:31 | |
JayF | https://review.openstack.org/#/c/112351/ link to the external dhcp provider review I'm shilling in the meeting | 19:32 |
dtantsur | it's on my list for tomorrow | 19:33 |
JayF | ellenh: ^ lucasagomes and dtantsur both agreed to look at that tomorrow | 19:34 |
* JayF wants to get it landed before you turn into a pumpkin | 19:34 | |
jroll | yeah, I need to re-review that today | 19:34 |
lucasagomes | :) | 19:34 |
*** rameshg87_ has joined #openstack-ironic | 19:43 | |
lucasagomes | jroll, will talk here because we are out of topic there | 19:43 |
lucasagomes | I think | 19:43 |
lucasagomes | jroll, so I just worked around on that patch, I still have to find out why it was calling cleaning up before configure | 19:43 |
jroll | ah, I see | 19:44 |
jroll | that works for me, I wouldn't want to dig into devstack | 19:44 |
dtantsur | Bugs I struggle to triage are most of 'New' bugs here: http://ironic-bugs.divius.net/ | 19:45 |
lucasagomes | jroll, yeah... it worked before and out of the blue it stopped, but not many changes in the lib/ironic itself that would cause it afaict | 19:45 |
lucasagomes | so it should be something deeper | 19:45 |
NobodyCam | dtantsur: will take a look a few minutes afterthe meeting | 19:45 |
*** ellenh has quit IRC | 19:46 | |
*** rameshg87 has quit IRC | 19:46 | |
*** bvivek has quit IRC | 19:50 | |
*** tatyana has joined #openstack-ironic | 19:58 | |
NobodyCam | brb | 20:01 |
NobodyCam | great meeting everyone | 20:01 |
dtantsur | yeah | 20:02 |
devananda | rameshg87_: is https://review.openstack.org/#/c/111232/ necessary for the iLO work? or just "nice to have" ? | 20:02 |
rameshg87_ | devananda, it is *required* for ilo work | 20:02 |
jroll | devananda: I had the same question about how useful that patch was, as well | 20:02 |
devananda | rameshg87_: oh, I see. | 20:02 |
rameshg87_ | devananda, unless we separate out iscsi portions, we cannot use it in the ilo driver | 20:02 |
rameshg87_ | jroll, i thought i had succeeded in convincing you :-) | 20:03 |
* mrda goes back to bed for a couple of hours | 20:03 | |
devananda | rameshg87_: ahh, and you are going to use the iSCSI functions with iLO boot (not PXE boot) | 20:03 |
devananda | mrda: g'night :) | 20:03 |
* devananda steps afk for 5 | 20:03 | |
dtantsur | well, it's already EOD here, g'night everyone :) | 20:03 |
rameshg87_ | devananda, yes, just replace the pxe portions with "ilo virtual media boot" | 20:03 |
*** wanyen has joined #openstack-ironic | 20:03 | |
lucasagomes | I'm also going, have a great night everyone | 20:03 |
lucasagomes | dtantsur, night night | 20:04 |
*** dtantsur is now known as dtantsur|afk | 20:04 | |
*** lucasagomes is now known as lucas-dinner | 20:04 | |
*** Nisha has quit IRC | 20:04 | |
*** harshada_kakad_ has quit IRC | 20:04 | |
rameshg87_ | devananda, i am just moving around the code in that review. i didn't have trouble rebasing it after the ipa and ipxe work. | 20:04 |
jroll | rameshg87_: I wasn't done :) | 20:05 |
jroll | devananda: I think it is useful | 20:05 |
rameshg87_ | jroll, :-) | 20:05 |
NobodyCam | night mrda lucas-dinner | 20:09 |
devananda | rameshg87_: http://docs.openstack.org/developer/oslo.config/opts.html#oslo.config.cfg.DeprecatedOpt | 20:10 |
rameshg87_ | devananda, thanks. let me take a look at this. | 20:11 |
devananda | rameshg87_: think of the impact this has on an existing deployment which upgrades | 20:13 |
*** penick has joined #openstack-ironic | 20:13 | |
devananda | rameshg87_: if by mistake they don't update their config file, it will cause significant problems. a "simple refactoring" shouldn't do that. | 20:13 |
rameshg87_ | devananda, yeah, i agree. moving around config option is a messy business. :-( | 20:14 |
devananda | rameshg87_: when defining a config option, there are some optional params | 20:14 |
devananda | deprecated_name and deprecated_group | 20:14 |
devananda | I would prefer they not change at all right now | 20:15 |
devananda | given that we want to refactor this in Kilo anyway, we really should only change these config options once | 20:16 |
rameshg87_ | devananda, it's not a must for the options to change, but wouldn't make logical sense with the code | 20:16 |
rameshg87_ | devananda, for example: https://review.openstack.org/#/c/111232/5/ironic/drivers/modules/iscsi_deploy.py | 20:16 |
devananda | rameshg87_: what about that? you can import options from anotehr file | 20:17 |
rameshg87_ | devananda, it would make sense for images_path to be moved here because it is iscsi_deploy that handles it | 20:17 |
rameshg87_ | devananda, yeah we can still refer the options in other file for now, and later do it once-and-all for K | 20:18 |
rameshg87_ | devananda, is that acceptable ? | 20:18 |
*** penick has quit IRC | 20:18 | |
devananda | yes. that would be a much cleaner refactoring now. | 20:18 |
rameshg87_ | devananda, okay. i can do that. i can add a small note in the code for that. | 20:19 |
devananda | great, thanks! | 20:19 |
rameshg87_ | devananda, i will do it this way then, i won't move the config options. | 20:19 |
rameshg87_ | devananda, thanks. | 20:19 |
devananda | don't hesitate to add #NOTE inline explaining the intent | 20:20 |
wanyen | deva, I am thinking to use ipmitool move sensro data to ceilometer and remote console in ilo driver. Can we file a bug to do this kindof mix and match fnctions? | 20:21 |
devananda | wanyen: you want to use iLO for deploy and management, but ipmitool for sensor data? | 20:22 |
wanyen | deva, ilo driver does not implement sensor data and remote console so I am thinkg to leverage those two fuctions in ilo driver. | 20:23 |
devananda | wanyen: yep, seems reasonable | 20:23 |
devananda | wanyen: that should just be a 2 line patch, right? | 20:23 |
wanyen | deva, so do we need to file a bug to do that or can we just do it in the ilo deploy driver as part of of the ilo deploy drive? | 20:24 |
devananda | wanyen: just do it as part of the ilo driver | 20:24 |
wanyen | deva, great! thanks! | 20:25 |
devananda | wanyen: IIUC it's just a change to this file: https://github.com/openstack/ironic/blob/master/ironic/drivers/ilo.py | 20:25 |
devananda | wanyen: which you'll need to make anyway when you land the vmedia deploy driver, so ... just do it then. | 20:25 |
wanyen | deva, okay. | 20:26 |
*** rameshg87__ has joined #openstack-ironic | 20:29 | |
*** rameshg87_ has quit IRC | 20:31 | |
*** tatyana has quit IRC | 20:36 | |
*** notq has joined #openstack-ironic | 20:42 | |
NobodyCam | are folks using the Ironic Priorties & planning Gdaic? | 20:50 |
NobodyCam | s/Gdaic/Gdoc/ | 20:50 |
jroll | yes | 20:52 |
JayF | devananda: question then; along the same lines would that seamicro console feature be a bug and not a spec? | 20:53 |
rloo | NobodyCam: I have in the past, and I may look at it in the future, but I don't look at it frequently. | 20:53 |
NobodyCam | ack TY | 20:55 |
*** tatyana has joined #openstack-ironic | 20:55 | |
jroll | devananda: reminder to tag a new client :) | 20:56 |
jroll | devananda: related: do I need to bump requirements.txt to the new version along with my bugfixes? | 20:56 |
*** rameshg87__ has quit IRC | 20:57 | |
*** rameshg87__ has joined #openstack-ironic | 20:57 | |
jroll | what's syntax for updating a thing in e.g. driver_info? how does this look? | 20:59 |
jroll | ironic node-update <uuid> replace /driver_info/ipmi_address=10.2.3.4 | 20:59 |
JayF | ^ that works | 21:01 |
*** matty_dubs is now known as matty_dubs|gone | 21:01 | |
JayF | thanks jroll | 21:01 |
*** linggao has left #openstack-ironic | 21:05 | |
devananda | JayF: not sure I grok your question | 21:05 |
JayF | devananda: if adding the ipmi stuff to the ilo driver is a 'bug', would adding a serial console support to seamicro driver also be a bug? | 21:06 |
JayF | i.e. instead of a spec, and that guy could get his stuff into J | 21:06 |
devananda | JayF: the ipmi-in-ilo thing isnt' even a bug -- it's two lines of "glue" connecting existing interfaces together when they add the IloDeploy interface class (which is part of an already approved spec) | 21:07 |
devananda | JayF: if the seamicro thing was the same -- just glue the existing serial colsole support into seamicro's driver, sure, taht's fine | 21:08 |
devananda | but AIUI, https://blueprints.launchpad.net/ironic/+spec/seamicro-serial-console is proposing a new class | 21:08 |
JayF | I am just trying to learn where the line is. Does it lie in how complex the implementation is then? | 21:08 |
devananda | yep | 21:08 |
devananda | the line between bug and feature is stupidly fuzzy | 21:09 |
devananda | and there's a fairly broad concensus we should abandon launchpad to get away from that | 21:09 |
devananda | (i'm oversimplifying -- don't quote me on that) | 21:09 |
devananda | JayF: but for example, IIUC, the seamicro console would add a requirement / dependency on telnet | 21:10 |
NobodyCam | brb | 21:10 |
JayF | gotcha. If it pivots on complexity that makes a lot of sense, I just didn't know if there was a general idea of 'implementing an existing ironic feature in a driver that doesn't have it is not spec-worthy' type of feel | 21:11 |
devananda | with only ~3 weeks to go to FF, core reviewers should be able to focus on landing code, not discussing design of new drivers or features | 21:11 |
JayF | seems like it mostly hinges on complexity, which practically makes a lot of sense | 21:11 |
devananda | it really pivots on that ^ | 21:11 |
JayF | heh | 21:11 |
JayF | ETOOMUCHWORK | 21:12 |
devananda | right :) | 21:12 |
devananda | also, fwiw, "implement feature in driver X that already exists in driver Y" totally needs a spec | 21:12 |
devananda | what if driver X does it differently? in a way that totally doesn't scale the same way as driver Y? | 21:12 |
jroll | is that the same as "implement this already defined api method in driver X"? | 21:13 |
JayF | the ilo/ipmi stuff muddied my opinion, but I get how that's not even ^ that :) | 21:13 |
jroll | I suspect yes | 21:13 |
devananda | the reason the iLO console question was such an easy answer -- they're NOT implementing anything new | 21:13 |
devananda | jroll: yes. same thing. driver wants to implement an optional interface which they didn't previously implement -> spec please. | 21:13 |
jroll | right, ok | 21:13 |
devananda | the iLO console is taking the existing ipmitoolconsole class and just glueing it into their driver | 21:14 |
devananda | which is the whole point of the modular interfaces :) | 21:14 |
*** rameshg87_ has joined #openstack-ironic | 21:14 | |
*** rameshg87__ has quit IRC | 21:16 | |
*** ellenh has joined #openstack-ironic | 21:18 | |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Take iSCSI deploy out of pxe driver https://review.openstack.org/111232 | 21:39 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Use auth_token from keystonemiddleware https://review.openstack.org/107197 | 21:56 |
*** rameshg87_ has quit IRC | 21:57 | |
*** eghobo has joined #openstack-ironic | 21:57 | |
*** rameshg87_ has joined #openstack-ironic | 21:57 | |
devananda | rameshg87_: I believe you need to use CONF.import_opt() to access conf options defined in other files | 21:59 |
jroll | not necessarily | 21:59 |
jroll | if the other files get imported before your file it should just work | 22:00 |
jroll | or something | 22:00 |
rameshg87_ | devananda, ah, i didn't. i referenced them directly | 22:00 |
jroll | (I didn't import the pxe config options in the agent driver) | 22:00 |
devananda | jroll: oh, i see | 22:00 |
devananda | jroll: so that "if" isn't really great | 22:00 |
rameshg87_ | devananda, even it worked for me now referencing them directly :-) | 22:00 |
jroll | devananda: right :) | 22:00 |
jroll | I'm not entirely sure if my "if" is true | 22:01 |
mrda | . | 22:01 |
rameshg87_ | jroll, what if somebody disabled pxe driver and enabled "only" agent driver ? | 22:02 |
rameshg87_ | jroll, in such a case the the module itself won't be loaded, right ? | 22:02 |
jroll | rameshg87_: it still works, we import all drivers at conductor startup or something silly | 22:02 |
jroll | idk how any of this works | 22:02 |
jroll | but it does | 22:02 |
jroll | :| | 22:02 |
rameshg87_ | jroll, i thought driver_factory loaded only drivers that were enabled | 22:03 |
devananda | jroll: ooh, i just leard you can declare an option as "secret" | 22:03 |
devananda | http://docs.openstack.org/developer/oslo.config/cfg.html near the bottom | 22:03 |
jroll | wat | 22:03 |
devananda | seems like someting to do for the swift token maybe? | 22:03 |
jroll | rameshg87_: it seems to load them all in my experience. but I might be wrong | 22:03 |
JayF | that's pretty sweet | 22:03 |
jroll | devananda: true that, let's try it :P | 22:04 |
rameshg87_ | jroll, okay | 22:04 |
jroll | devananda: also mysql connection strings etc | 22:04 |
rameshg87_ | jroll, yeah perhaps the tmpurl key is a secret :-) | 22:04 |
jroll | devananda: maybe I'll fix them all and put up one review | 22:04 |
* jroll just does it | 22:04 | |
rameshg87_ | devananda, so do we really need to use import_opt ? | 22:05 |
devananda | rameshg87_: I believe you should -- http://docs.openstack.org/developer/oslo.config/configopts.html?highlight=import_opt#oslo.config.cfg.ConfigOpts.import_opt | 22:06 |
devananda | fwiw, there are 312 occurrences of CONF.import_opt in Nova | 22:07 |
rameshg87_ | devananda, okay. will use it then .. thanks | 22:07 |
devananda | jroll: ^ | 22:07 |
devananda | jroll: oslo.config is a strage sort of global thing | 22:08 |
devananda | jroll: the biggest gotcha with it that i keep seeing is, you can't trust anything in CONF at parse time | 22:08 |
devananda | because it hasn't loaded the config file yet | 22:08 |
*** rameshg87_ has quit IRC | 22:09 | |
jroll | devananda: right | 22:09 |
jroll | so like, you can't use a CONF thing at module load time | 22:10 |
jroll | but like, at runtime (inside a method or whatever), you can | 22:10 |
jroll | hmm | 22:10 |
mrda | jroll: well, at least not in a way that works consistently. I've heard stories from Nova of intermittent bugs when this was done... | 22:11 |
jroll | yeah :\ | 22:12 |
jroll | huh, our conductor in devstack doesn't do a config dump at startup :/ | 22:14 |
openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 22:15 |
* NobodyCam is back | 22:22 | |
devananda | jroll: dont define a function default =CONF.something, for example | 22:22 |
devananda | becausethat's eval'd at parse time | 22:22 |
rloo | devananda: I replied to your comments to my comments, in https://review.openstack.org/#/c/107197/. If it doesn't make sense it is cuz I'm still trying to catch up and remember how to code ;) | 22:24 |
jroll | devananda: yeo | 22:24 |
jroll | yep | 22:24 |
*** rloo is now known as rloo_afk | 22:24 | |
devananda | rloo_afk: sure. fwiw, this change is trying to update ironic to use the newly requried keystonemiddleware package | 22:25 |
devananda | rloo_afk: some things changed upstream from us. keystone went and fixed it in all the integrated projects | 22:26 |
devananda | you can see the changes they made here https://launchpad.net/bugs/1342274 | 22:26 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Make swift tempurl key secret https://review.openstack.org/113390 | 22:29 |
jroll | devananda: ^^ | 22:29 |
jroll | tested in devstack too | 22:29 |
devananda | and? | 22:29 |
jroll | although it's not printed as-is today due to imports ordering | 22:29 |
jroll | or whatever | 22:30 |
jroll | but when I imported that module, to force parsing those configs | 22:30 |
jroll | it worked fine | 22:30 |
jroll | 2014-08-11 22:26:37.066 DEBUG ironic.cmd.conductor [-] glance.swift_temp_url_key = **** from (pid=23769) log_opt_values /usr/local/lib/python2.7/dist-packages/oslo/config/cfg.py:1988 | 22:30 |
devananda | nice | 22:30 |
*** eguz has joined #openstack-ironic | 22:30 | |
*** radsy has joined #openstack-ironic | 22:33 | |
*** eghobo has quit IRC | 22:33 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Use auth_token from keystonemiddleware https://review.openstack.org/107197 | 22:34 |
devananda | jroll: new tag pushed | 22:43 |
*** jgrimm has quit IRC | 22:44 | |
*** eguz has quit IRC | 22:51 | |
*** eghobo has joined #openstack-ironic | 22:54 | |
jroll | devananda: thanks! | 22:59 |
jroll | devananda: do I need to bump requirements.txt to require the latest, if we have code depending on the latest? | 23:00 |
openstackgerrit | Ghe Rivero proposed a change to openstack/ironic-python-agent: Sync oslo.incubator modules https://review.openstack.org/113397 | 23:00 |
*** eghobo has quit IRC | 23:00 | |
*** eghobo has joined #openstack-ironic | 23:00 | |
*** lucas-dinner has quit IRC | 23:01 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!