Tuesday, 2014-07-22

jrolllifeless: in your experience, how many nodes can nova-compute handle?00:05
*** killer_prince has joined #openstack-ironic00:16
*** killer_prince is now known as lazy_prince00:17
*** Haomeng|2 has joined #openstack-ironic00:17
*** Haomeng has quit IRC00:19
*** jcoufal has joined #openstack-ironic00:21
lifelessjroll: I have not tested beyond 50 yet00:41
jrolloh.00:41
*** malini1 has quit IRC00:41
jrollwe're seeing the resource tracker task do about 22 nodes/second00:42
jrollor about 15 seconds for ~330 nodes00:42
lifelesslet mee00:42
lifelesslet me see00:42
lifeless2014-07-21 06:31:18.190 24497 AUDIT nova.compute.resource_tracker [-] Auditing locally available compute resources00:42
lifeless2014-07-21 06:31:18.470 24497 AUDIT nova.compute.resource_tracker [-] Auditing locally available compute resources00:43
lifelessso about 300ms to do one00:43
lifeless2014-07-21 06:31:18.900 24497 AUDIT nova.compute.resource_tracker [-] Auditing locally available compute resources00:43
lifeless400ms there00:43
jrollyeah00:44
lifelessmuch less than 22/second00:45
lifelessthis is an idle node00:45
lifelessone-node cloud00:45
lifeless24 cores, 64GB of ram00:45
lifelesstop - 00:45:45 up 13 days,  1:46,  4 users,  load average: 0.99, 1.11, 0.9300:45
lifelesssorry, 96GB00:45
jrollok so00:46
jrollstandalone n-cpu, 4GB cloud server00:46
jrollslash vm, whatever you want to call it00:46
* jroll greps00:47
jrollI don't think that's the right loop, sec00:47
JayFjroll: note: we have the hack to use node/details00:47
JayFjroll: so ours might be faster already00:47
JayFjroll: and we should upstream that :)00:47
jrollgetting to that...00:48
lifelessyeah :)00:48
jroll2014-07-22 00:47:54.476 27177 DEBUG ironic.nova.virt.ironic.driver [-] Returning 332 available node(s):00:49
JayFoh!00:49
jroll2014-07-22 00:48:42.409 27177 DEBUG ironic.nova.virt.ironic.driver [-] Returning 332 available node(s):00:49
JayFI thought he was saying 300ms/node, not 300ms/whole run00:50
jrollgah00:50
JayFthat's impressive00:50
jrollwrong lines, again00:50
jroll2014-07-22 00:48:09.336 27177 INFO nova.compute.resource_tracker [-] Compute_service record updated for ironic-compute00:50
jrollthat's the last one...00:50
* jroll puts things in order00:50
jroll2014-07-22 00:47:54.476 27177 DEBUG ironic.nova.virt.ironic.driver [-] Returning 332 available node(s):00:50
jroll2014-07-22 00:47:54.476 27177 DEBUG ironic.nova.virt.ironic.driver [-] Returning 332 available node(s):00:50
jroll^ that's the entire update loop00:51
jrollfuck00:51
* JayF hands jroll a clipboard00:51
jroll2014-07-22 00:47:54.476 27177 DEBUG ironic.nova.virt.ironic.driver [-] Returning 332 available node(s):00:51
jroll2014-07-22 00:48:09.336 27177 INFO nova.compute.resource_tracker [-] Compute_service record updated for ironic-compute00:51
jrollis the entire loop00:51
jrollso 15s there00:51
jrolllifeless: this is including a hack to only hit ironic-api once, at /nodes/details: https://gist.github.com/jimrollenhagen/8a8783ae107a79db090a00:53
lifelessjroll: can you git review that ;)00:55
jrolllifeless: definitely00:55
jrollneeds to be cleaned up and tests, but that's planned00:55
jrollwe don't believe in proprietary :)00:56
mrdajroll: +100:56
jroll(agent driver is my top priority right now, though)00:56
lifelessyeah - I meant, just get it up, folk might do that for you00:56
JayF^ the only place we differ in philosphy is that we write code at about 2x the pace it merges :P00:56
jrolltrue00:56
jrolllol00:56
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Query full node details and cache  https://review.openstack.org/10854501:03
jrolllifeless: ^ had some conflicts so no idea if that works :)01:03
JayFcomstud: ^ probably wants to know you put that up too01:04
JayFin case he wants to clean it up01:04
jrollI told him :P01:05
jrollok, I need to go, night y'all01:05
lifelessnight01:05
mrdarloo: \o01:05
mrdajroll: \o01:06
rloohi Mr mrda01:06
mrdahi rloo - sorry typing fail.01:06
mrdaThanks for the review comments btw01:06
rlooyw mrda. hope it helps. although i need to look at the baremetal refactoring now that I think I understand what's going on ;)01:06
mrdait's not trivial, but I hope it's clear now01:07
*** eghobo has joined #openstack-ironic01:07
rloomrda: I was thinking that it was hard to know what the 'original' baremetal_host_manager was, but I guess it doesn't make sense to checkin the original file first, before refactoring.01:08
rlooanyway mrda, I'll look at that tomorrow. that's the plan anyway ;)01:09
mrdayeah, mikal provided a unified diff of the ironic_host_manager.py against the original01:09
mrdathanks rloo01:09
mrdamuch appreciated!01:09
*** eghobo has quit IRC01:12
*** eghobo has joined #openstack-ironic01:12
*** jcoufal has quit IRC01:13
*** nosnos has joined #openstack-ironic01:40
*** Haomeng has joined #openstack-ironic01:45
*** Haomeng has quit IRC01:46
*** Haomeng|2 has quit IRC01:47
*** eguz has joined #openstack-ironic02:03
*** eguz has quit IRC02:04
*** eguz has joined #openstack-ironic02:04
*** rainya has joined #openstack-ironic02:06
*** eghobo has quit IRC02:07
*** rainya has quit IRC02:09
*** rainya has joined #openstack-ironic02:10
*** rloo has quit IRC02:12
*** eguz has quit IRC02:36
*** vinbs has joined #openstack-ironic02:59
mrdadtantsur|afk: as per our conversation yesterday, here's a Nova patch you will be pleased with: https://review.openstack.org/#/c/108564/03:00
*** eghobo has joined #openstack-ironic03:18
*** rainya has quit IRC03:34
*** Poornima|mtg has joined #openstack-ironic03:34
*** Poornima|mtg is now known as Poornima_03:34
*** nosnos has quit IRC03:40
*** eghobo has quit IRC03:55
*** eghobo has joined #openstack-ironic03:55
*** nosnos has joined #openstack-ironic04:06
*** shakamunyi has joined #openstack-ironic04:06
*** shakamunyi has quit IRC04:08
*** pcrews has quit IRC04:10
*** rameshg87 has joined #openstack-ironic04:11
*** lazy_prince is now known as killer_prince04:14
*** Nisha has joined #openstack-ironic04:14
*** krtaylor has quit IRC04:18
*** Poornima_ has quit IRC04:19
*** Poornima_ has joined #openstack-ironic04:30
*** Poornima_ has quit IRC04:39
*** krtaylor has joined #openstack-ironic05:03
*** Poornima|mtg has joined #openstack-ironic05:07
*** Poornima|mtg is now known as Poornima_05:07
*** ramineni has joined #openstack-ironic05:17
*** romcheg1 has joined #openstack-ironic05:30
*** romcheg1 has left #openstack-ironic05:30
*** shausy has joined #openstack-ironic05:33
*** rameshg87 has left #openstack-ironic05:37
*** bvivek has joined #openstack-ironic05:37
*** killer_prince is now known as lazy_prince05:57
*** rakesh_hs has joined #openstack-ironic05:58
*** k4n0 has joined #openstack-ironic05:59
*** pradipta_away is now known as pradipta05:59
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/10694806:12
openstackgerritA change was merged to openstack/ironic: Use opportunistic approach for migration testing  https://review.openstack.org/10705306:24
*** kpavel has joined #openstack-ironic06:31
*** eghobo has quit IRC06:36
*** Halacs has joined #openstack-ironic06:37
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer  https://review.openstack.org/7253806:39
*** vkdrao has joined #openstack-ironic06:42
*** vkdrao has quit IRC06:46
*** Mikhail_D_ltp has joined #openstack-ironic06:49
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer  https://review.openstack.org/7253806:50
*** Haomeng has joined #openstack-ironic06:51
*** bmahalakshmi has joined #openstack-ironic07:01
dtantsur|afkmrda, cool, thank you, will have a look07:03
*** dtantsur|afk is now known as dtantsur07:04
dtantsurand good morning Ironic (said man trying to open his eyes)07:04
*** harlowja is now known as harlowja_away07:04
mrdadtantsur: that was me at the meeting 12 hours ago :)07:11
dtantsurheh, I can understand it07:11
dtantsurand I'm always feeling bad the morning after the meeting :(07:11
*** rameshg87 has joined #openstack-ironic07:22
rameshg87dtantsur: hi07:27
dtantsurrameshg87, hi07:27
rameshg87dtantsur: just one more question on https://review.openstack.org/#/c/10734407:27
dtantsursure07:27
rameshg87dtantsur: in the spec we say "On next start-up the driver's __init__ code  will set up the environment"07:28
*** kpavel has quit IRC07:28
rameshg87dtantsur: but where does the driver tear down the environment so that nodes don't boot again ??07:28
rameshg87dtantsur: so that the pxe/tftp configuration to bootup the node to discovery ramdisk is removed off ..07:28
rameshg87dtantsur: i think we might want this for an admin who might set discovery.enabled=false later on07:29
dtantsurrameshg87, good catch! I guess we need to introduce something like set_up_discovery and tear_down_discovery to DriverInterface...07:29
dtantsurwhat do you think?07:29
rameshg87dtantsur: yes, we might need07:29
*** bvivek has quit IRC07:30
rameshg87dtantsur: and regarding the nics i think your point is valid07:30
rameshg87dtantsur: better to leave it to ramdisk which does discovery :-)07:31
dtantsurrameshg87, ack, thank you07:31
rameshg87dtantsur: thanks07:31
*** bvivek has joined #openstack-ironic07:32
rameshg87dtantsur: but when can tear_down_discovery happen ? on stopping the conductor ?07:34
dtantsurrameshg87, currently yes. Later - when it's disabled by any means.07:35
rameshg87dtantsur: okay ..07:35
rameshg87dtantsur: a problem when process dies off suddenly due to any issue :-(07:36
*** malini has joined #openstack-ironic07:36
dtantsurrameshg87, here is HA-related part of discovery: if it's still enabled, we need another conductor to carry on07:36
dtantsurso set_up_discovery must somehow clean up environment before it proceedes07:37
rameshg87dtantsur: yes ..07:37
rameshg87dtantsur: probably __init__() can try to clean up environment if discovery.enabled=false ??07:37
rameshg87dtantsur: there is no harm in trying once ..07:37
dtantsurrameshg87, if the only conductor dies and then the admin disabled discovery...07:38
dtantsurrameshg87, but what driver to call? we do not know, which driver used to do the discovery07:38
rameshg87dtantsur: hmm.. yes07:38
rameshg87dtantsur: it could have changed07:38
dtantsurrameshg87, the more I think about it, the more I suspect we need to persist some information about discovery in DB07:40
rameshg87dtantsur: do you mean persist discovery.driver in db ?07:40
dtantsurrameshg87, yes, store the last driver and status of discovery07:41
dtantsurrameshg87, so that on restart/failure this information can be recovered07:41
*** jistr has joined #openstack-ironic07:42
dtantsurrameshg87, we can cheat a bit and store it in the Conductor model, so that we do not create a new table07:42
rameshg87dtantsur: yeah, i was just checking the same07:43
rameshg87dtantsur: i don't think it's cheating because it truly belongs to conductor07:43
rameshg87:-)07:43
dtantsurmakes sense, yeah07:43
*** foexle has joined #openstack-ironic07:43
rameshg87dtantsur: yeah, may be on startup of conductor, it can retrieve value from db, and call cleanup of discovery.driver in db07:44
dtantsurrameshg87, yeah. There is a corner case, when this driver is no longer enabled, but it's solvable07:44
rameshg87dtantsur: and then call setup() for the new(or the same) discovery.driver if its enabled07:45
rameshg87dtantsur: oh :-)07:45
dtantsurwe can error-out, if we need to clean up, but the driver is disabled07:45
rameshg87dtantsur: yeah, makes sense so that admin is informed07:45
rameshg87dtantsur: then we might have covered every scenario :-)07:46
rameshg87dtantsur: then for now it might not be required to do cleanup on stopping the conductor right ?07:46
rameshg87dtantsur: or may be still worth attempting to prevent unexpected pxe bootings from the conductor node07:47
dtantsurrameshg87, I think it is07:47
rameshg87dtantsur: okay07:47
dtantsurrameshg87, thanks for this discussion, helps a lot :)07:49
rameshg87dtantsur: :-)07:49
dtantsurquick walk, be back in ~ 1 hour07:50
*** k4n0 has quit IRC07:51
*** foexle has quit IRC07:54
openstackgerritA change was merged to openstack/ironic: IPMITool to use the new ManagementInterface  https://review.openstack.org/8609207:55
openstackgerritMichael Davies proposed a change to openstack/ironic: Review fixes from Nova scheduler reviews  https://review.openstack.org/10731607:55
*** foexle has joined #openstack-ironic07:56
*** k4n0 has joined #openstack-ironic08:04
viktorsGheRivero: hi!08:07
*** kpavel has joined #openstack-ironic08:10
*** bvivek has quit IRC08:13
*** lucasagomes has joined #openstack-ironic08:17
yuriyzmorning Ironic08:19
*** bvivek has joined #openstack-ironic08:21
*** k4n0 has quit IRC08:32
*** saripurigopi has joined #openstack-ironic08:41
saripurigopiI'm trying to add blueprint, when I try to push the changes, it is failing with permission denied.08:42
saripurigopido I need additional privileges to upload blueprint ?08:42
*** malini has quit IRC08:42
saripurigopiremote: Permission to openstack/ironic-specs.git denied to saripurigopi@gmail.com. fatal: unable to access 'https://github.com/openstack/ironic-specs/': The requested URL returned error: 40308:42
lazy_princesaripurigopi08:43
lazy_princeare you using gerrit or git push..?08:43
saripurigopigit push for committing the spec.08:44
lazy_princesaripurigopi: you need to use git-review.08:44
dtantsuryuriyz, morning :)08:48
*** k4n0 has joined #openstack-ironic08:49
dtantsurlucasagomes, morning :) "IPMITool to use the new ManagementInterface" merged08:49
lucasagomeso/////08:49
lucasagomesthanks!08:49
mrdahi dtantsur and lucasagomes08:49
lucasagomesmrda, morning!08:49
dtantsurmrda, good evening :)08:50
mrdawhat time is it?08:50
mrda:)08:50
lucasagomes9:50am08:50
dtantsurmrda, 10:50 (morning) here08:50
lucasagomesmrda, good evening there?08:50
mrda6:20pm here, still going from the 4:30am meeting this morning :)08:50
lucasagomeswoah!08:51
dtantsurlucasagomes, also we had a discussion with rameshg87 before you arrived. It resulted in following: 1. we need a set_up_discovery and tear_down_discovery on DriverInterface; 2. we do need to persist information about discovery (I'm finally convinced!), we can use Conductor model for it08:51
lucasagomesyup08:52
lucasagomesset_up...tear_down is the active/deactive functions08:52
lucasagomesdtantsur, so, it will be exposed on the API or config options?08:53
lucasagomesI was thinking about the config options, the problem with them is how to pass parameters08:53
lucasagomeshw to tell ironic what is the discovery ramdisk and kernel08:53
lucasagomeswhen it was on the api I was thinking about something like08:53
lucasagomesPUT -d {'discovery_ramdisk' ..., 'discovery_kernel':...} /drivers/pxe_*/discovery08:54
lucasagomessomehting like that08:54
dtantsurlucasagomes, too many problems with new API, as was discussed yesterday08:54
dtantsurlucasagomes, currently it will happen on start/stop the conductor08:55
dtantsurlucasagomes, we can store everything driver-specific in static configuration08:55
lucasagomesdtantsur, right08:55
lucasagomesthat means that, this parameters should be at the driver_info before the conductor starts?08:56
dtantsurlucasagomes, in configuration. driver_info is for a node08:56
lucasagomesah08:56
lucasagomestrue08:56
lucasagomeshmm08:56
dtantsurlucasagomes, I am updating the spec right now, so we can discuss later, how it is shaping08:58
*** igordcard has joined #openstack-ironic08:59
lucasagomesack09:01
*** bvivek has quit IRC09:04
*** pradipta is now known as pradipta_away09:07
*** bvivek has joined #openstack-ironic09:13
*** athomas has joined #openstack-ironic09:18
*** k4n0 has quit IRC09:19
dtantsurlucasagomes, putting any HA considerations there is a can of worms >_<09:19
dtantsuronce you start, you can't finish...09:19
lucasagomeshah I can imagine09:20
dtantsurlucasagomes, I'm seriously thinking of 2 specs: first stating "only one conductor can do discovery at the same time", second about HA and friends (on which we can argue infinitely)09:21
mrdadtantsur: if that will help us make progress, I see no harm09:22
lucasagomesdtantsur, :/09:22
lucasagomeswell openstack wise that's not very well acceptable really09:22
lucasagomespeople want it to scale09:22
lucasagomes1 conductor hardly would be able to handle more than 5~10 machines booting at the same time with the normal PXE (tftp)09:23
saripurigopiI'm trying to submit spec review with git-review, now it is falling with "fatal: ICLA contributor agreement requires current contact information."09:23
lucasagomesif you look at the video I have for the discovery it's 3 machines, the network is just a bridge, and the TFTP speed is very slow09:24
saripurigopiI've the contact info updated in my profile.09:24
dtantsurlucasagomes, conductor without discovery support will boot 0 new machines :/ and that's where we are going09:24
lazy_princesaripurigopi: did you sign ICLA..?09:24
rameshg87saripurigopi: you neeed to goto review.openstack.org -> top right bar Settings -> Agreements09:24
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Rename/update common/tftp.py to common/pxe_utils.py  https://review.openstack.org/10359509:24
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add iPXE Installation Guide documentation  https://review.openstack.org/10680909:24
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add iPXE support for Ironic  https://review.openstack.org/9931809:24
saripurigopiYes, I've signed ICLA.09:25
saripurigopiVerifiedICLAOpenStack Individual Contributor License Agreement09:25
rameshg87lucasagomes: just a question on ipxe cache in https://review.openstack.org/#/c/99318/11/ironic/drivers/modules/pxe.py09:25
lucasagomesrameshg87, yup I answered that09:25
lucasagomesrameshg87, and fixed the tests you pointed out09:25
rameshg87lucasagomes: yeah the question is on the comment09:26
lucasagomesrameshg87, oh... lemme take a look I'm sorry09:26
rameshg87lucasagomes: i am just about to ask :-)09:26
lucasagomesrameshg87, (2 comments)09:26
lucasagomesJust a couple of small issues.09:26
rameshg87lucasagomes: when we have a conductor running ipxe only09:26
rameshg87lucasagomes: wouldn't the admin need to make sure space is available for two mounts /tftproot and /http_root ?09:27
rameshg87lucasagomes: if we continue to make use of TFTPImageCache09:27
lucasagomesrameshg87, yeah, as you said I still using TFTP for the master images09:27
lucasagomesI didn't want to touch that part of the code for now09:27
lucasagomesrameshg87, do you think I need to refactor that before?09:28
dtantsurlucasagomes, btw, if Neutron can't route new nodes to different conductors, it won't work anyway09:28
lucasagomesI don't really mind doing that, the TFTP on the names really annoys me09:28
rameshg87lucasagomes: can't we just change the master dir to /http_root/master_images if ipxe is enabled ?09:28
lucasagomesrameshg87, yup we can09:29
rameshg87lucasagomes: so that all the deploy_kr_images go inside /http_root09:29
rameshg87lucasagomes: and we the admin doesn't need to bother about space in /tftp_root09:29
lucasagomesI will take a look at it09:29
lucasagomesrameshg87, +109:29
rameshg87lucasagomes: okay :-)09:29
rameshg87lucasagomes: thanks09:30
lucasagomesI will do in a separated patch that refacotr, cause it involves config options09:30
saripurigopido I need additional permissions to access github.com/openstack/ironic-specs to submit review?09:30
lucasagomestftp_master_dir09:30
lucasagomesetc...09:30
dtantsurlucasagomes, and if TFTP is slow for 3 machines, we just have to use iPXE. I don't believe a single node can't serve hundreds of files simultaneously09:30
lucasagomesdtantsur, yeah with iPXE it will work better09:30
lucasagomesI mean, way better09:30
lucasagomesrameshg87, btw... so what about making the master_dir generic?09:31
lucasagomesrameshg87, I mean... the op can choose the dir he wants to cache the master images09:31
lucasagomesdoesn't matter if it's tftp or http09:31
*** openstackgerrit has quit IRC09:31
lucasagomesI prefer to avoid to tie the dir to cache image with the transport protocol, it makes little sense IMO09:32
rameshg87lucasagomes: oh yeah09:32
rameshg87lucasagomes: i guess it is already a config option09:32
lucasagomesrameshg87, yeah, with the "tftp_" on the name09:32
rameshg87lucasagomes: then you were just referring to change the name ?09:32
lucasagomesI will try to work that out09:32
lucasagomesyeah, small refactor09:33
lucasagomesto make it less misleading09:33
*** openstackgerrit has joined #openstack-ironic09:33
openstackgerritMichael Davies proposed a change to openstack/ironic: Review fixes from the Nova driver reviews  https://review.openstack.org/10788209:33
rameshg87lucasagomes: oh okay..that makes sense .. i just wanted to see if we can easily make both the cache and the actual files in the same directory - whether it will be pxe or ipxe09:33
rameshg87lucasagomes: so we don't have to go and change anything :-)09:33
lucasagomesrameshg87, sure... I will take a look at it09:34
lucasagomesrameshg87, thanks for pointing that out09:34
rameshg87lucasagomes: :-)09:34
*** athomas has quit IRC09:36
saripurigopiI'm trying to submit the review for first time.09:36
*** k4n0 has joined #openstack-ironic09:38
rameshg87saripurigopi: no you don't need09:38
lucasagomessaripurigopi, https://wiki.openstack.org/wiki/Documentation/HowTo/FirstTimers#Step-by-step_tutorial09:38
openstackgerritVictor Sergeyev proposed a change to openstack/ironic: Use metadata.create_all() to get database schema  https://review.openstack.org/10762909:44
openstackgerritVictor Sergeyev proposed a change to openstack/ironic: Add a test case for DB schema comparison  https://review.openstack.org/10762809:44
*** athomas has joined #openstack-ironic09:49
saripurigopiI've the SSH keys in place and still it fails with "Please make sure you have the correct access rights and the repository exists."09:51
mrdaGood night ironic, see you tomorrow!09:53
*** mrda is now known as mrda-away09:53
*** NobodyCam has quit IRC09:54
*** Shrews has quit IRC09:54
*** jogo has quit IRC09:54
*** anteaya has quit IRC09:54
*** jogo has joined #openstack-ironic09:54
openstackgerritDmitry Tantsur proposed a change to openstack/ironic-specs: Generic Hardware Discovery Bits  https://review.openstack.org/10734409:55
*** NobodyCam has joined #openstack-ironic09:55
dtantsurlucasagomes, rameshg87, ok, I got something new ^^^ can we discuss it?09:55
*** anteaya has joined #openstack-ironic09:55
*** Shrews has joined #openstack-ironic09:56
*** nosnos has quit IRC09:58
*** nosnos has joined #openstack-ironic09:58
rameshg87dtantsur: i am in ...10:01
lifelessdtantsur: hi, you pinged the other day?10:02
*** nosnos has quit IRC10:03
dtantsurlifeless, hi, I don't quite remember :) maybe it was about whether lucas needs a spec for his ramdisk or not...10:03
lucasagomesdtantsur, what is DriverInterface?10:03
*** martyntaylor has joined #openstack-ironic10:04
dtantsurlucasagomes, hmm.. I meant BaseDriver, no idea why I called it that way10:04
lucasagomesso the setup and tear down won't be linked with any interface?10:05
dtantsurlucasagomes, I guess no. As Deva stated yesterday, interfaces are related to nodes10:06
lifelessoh yeah, it was, nvm :)10:07
rameshg87dtantsur: i have a question10:08
rameshg87dtantsur: "For existing row, check if conductor is alive, using the hash ring.86    If it is not and the same driver is enabled on the current node,87    ask this driver to do tear down, than proceed with enabling the discovery."10:08
rameshg87dtantsur: will tear down work if it is performed by someother conductor node ?10:08
rameshg87dtantsur: for pxe, conductor A would have setup a tftp configuration in its own machine10:09
dtantsurrameshg87, it should at least to some extend. Imagine PXE or IPA driver will have to clean Neutron config10:09
rameshg87dtantsur: conductor B can't tear this down10:09
dtantsurrameshg87, of course it won't clean local caches, but local caches are not going to break things :)10:09
dtantsurNeutron configuration will, on the contrary10:09
rameshg87dtantsur: oh okay..it can do it with neutron..:-)10:09
rameshg87dtantsur: caches won't affect it ..10:10
rameshg87dtantsur: looks okay to me.  i will have a detailed look to see if my eye can find something :-)10:11
dtantsurthanks!10:11
*** romcheg1 has joined #openstack-ironic10:15
lucasagomesso on the conductor that is serving the dhcp for the discovery, neutron will be configured to answer the dhcp request for all unkown NICs10:16
lucasagomesconductor where the discovery is enabled10:16
lucasagomesI can't see how this take over happens10:16
* lucasagomes thinking....10:17
lucasagomescause, let's say the conductor doing the previously discovery haven't died10:18
lucasagomesit was a network problem10:18
lucasagomesso hashring thought it was died10:18
lucasagomesnow it's back10:18
lucasagomesand the dhcp server still running on it...10:19
lucasagomesmaybe I'm not understand the detection model... how it will detect that the previous conductor died? will have a periodic task looking at the hash ring to see that?10:20
lucasagomeshow we are going to elect a new conductor to be the one serving the discovery?10:20
*** viktors is now known as viktors|afk10:22
lifelesslucasagomes: I'm confused10:24
lucasagomeslifeless, me too10:24
lucasagomestotally10:24
lifelesslucasagomes: thats a neutron dhcp agent HA problem, not an ironic conductor problem10:24
lifelesslucasagomes: isn't it?10:24
lucasagomeslifeless, so this is the new spec https://review.openstack.org/10734410:25
lucasagomesit has the discovery enabled in one conductor in the cluster (instead of all conductors that support that driver)10:26
lucasagomesso only one can receive the dhcp request for unkown NICs10:26
lucasagomesthat's what I'm missing, how to tie conductor with the neutron dhcp server10:26
dtantsurlucasagomes, ehhhrr.. we'll never receive DHCP requests10:29
dtantsurplease don't confuse10:29
lucasagomesdtantsur, right... so how we are going to PXE boot the image?10:29
dtantsurlucasagomes, neutron will point to the conductor, on which it's enabled10:29
dtantsurI mean, discovery is enabled10:30
dtantsurlucasagomes, so as the first step, it's matter of static configuration10:31
lucasagomesdtantsur, right, so neutron dhcp server will be running and configured to answer DHCP requests on the conductor where discovery is enabled10:31
lucasagomesright?10:31
dtantsur(which obviously sucks, but still)10:31
lucasagomesDHCP requests for unknown NICs*10:31
dtantsurlucasagomes, yes10:31
lucasagomesdtantsur, ok...10:31
lifelesslucasagomes: why are you saying 'on the conductor'10:31
lucasagomeslifeless, cause the PXE enviroment will be set up on that conductor10:31
lifelesslucasagomes: theres absolutely no reason that the neutron dhcp server would be on the conductor machine10:31
lucasagomeslifeless, the default PXE configuration file where the unregistered machines will boot from will be locally on that conductor10:32
lifelesslucasagomes: yes, the PXE file will be10:32
lifelessbut neutron' DHCP server(s) may be elsewhere10:32
*** Amar has joined #openstack-ironic10:32
*** Amar is now known as Guest670310:32
lifelesslucasagomes: (not to mention that Neutron doesn't have wildcard DHCP support today (at least, AFAIK), so I'm not sure how the spec can be implemented without some discussion with Neutron about that.10:33
dtantsurlifeless, re authentication: it's a long-lasting topic, IPA is also discussing it and the only answer for J currently is: secure your network10:33
dtantsurand yes, it sucks10:33
*** ndipanov has joined #openstack-ironic10:33
lucasagomeslifeless, right.. ok so we just update_port and give the address of the node which contains the PXE config file... yeah makes sense10:33
lifelessdtantsur: If there is consensus on that, thats fine - but I think it needs to be explictly spelt out in this spec, not just 'oh its a problem alright' :)10:34
lifelesslucasagomes: not update_port - there is no port oject10:34
lifelesslucasagomes: its going to be a subnet change10:34
dtantsurlifeless, ok, I'll try to make it clearer and mention discussion with IPA folks also...10:34
lucasagomeslifeless, right, ok I think I'm understanding it better10:35
dtantsurlucasagomes, if neutron does not support it, we're in trouble10:35
lucasagomesdtantsur, yeah, let's check with marios10:36
*** ndipanov has quit IRC10:38
*** marios has joined #openstack-ironic10:39
mariosdtantsur: hey10:39
dtantsurmarios, hi! We're discussing hardware auto-discovery here and we need to know, if we can tell neutron: "for all unknown MAC addresses, point them to this IP for PXE boot"10:39
mariosdtantsur: hmm, i don't know off hand, but i can try and find out. the l2 subnets will hand out dhcp info to vms coming up (so for 'unkown mac addressses') but don't know if there is something for pxe in neutron (well, for this arbitrary metadata)10:41
mariosdtantsur: but, you may get better mileage asking this directly in #openstack-neutron10:42
mariosdtantsur: is there any more context here? the machines aren't booted yet, so are they even managed by neutron at this point?10:44
dtantsurmarios, no, they are not. It is for new machines enrolling.10:44
mariosright. so then this is more of a tripleo metadata question no?10:44
marios(heat metadata)10:44
mariosbut i guess i am missing lots still here10:44
openstackgerritDmitry Tantsur proposed a change to openstack/ironic-specs: Generic Hardware Discovery Bits  https://review.openstack.org/10734410:44
dtantsurlucasagomes, lifeless ^^^ updated10:45
dtantsurmarios, the task is: the admin brought 10 new servers, plugged them in network and power10:45
dtantsurmarios, now we need to boot a specific ramdisk on them, collect hardware inventory and report back to Ironic10:45
mariosdtantsur: is the description in that spec ^^10:45
dtantsurmarios, more-or-less should be10:46
mariosdtantsur: ok10:51
mariosso if you have a subnet, where the default gateway is the pxe server, that could work10:53
mariosdtantsur: still there?10:54
dtantsuryep10:54
dtantsurmarios, can we do it with Neutron?10:55
mariosdtantsur: as i said, i don't know :) i am trying to understand more of the problem10:55
mariosdtantsur: so once ironic has this info, it gives it to ? tuskar-ui?10:55
dtantsurmarios, it stores it and tuskar UI uses it later, yes10:56
mariosdtantsur: ok... so tuskar defines the heat env for tripleo (e.g. will include those discovered mac addresses per host)10:58
mariosdtantsur: so first thing, i don't know enough about pxe, but the hosts need to have already received an IP address first before they can boot right10:59
dtantsurmarios, I am not sure10:59
dtantsurok, lucasagomes, should we bring this to #openstack-neutron ?11:03
mariosdtantsur: so, your PXE server needs to be on the same subnet as your hosts11:03
mariosdtantsur: i think that's a very good idea11:03
marioslet's go there now11:03
lucasagomesdtantsur, yes sounds like we do11:03
*** Halacs has quit IRC11:04
*** athomas_ has joined #openstack-ironic11:04
*** athomas has quit IRC11:06
*** ramineni has quit IRC11:06
lifelessNobodyCam: comstud: https://review.openstack.org/10864011:10
lifelessmarios: VMs coming up are known MACs11:10
lifelessmarios: PXE server doesn't need to be on the same subnet :)11:10
marioslifeless: oh really? but it's basically using dhcp (are you talking about relay?)11:12
lifelessPXE is unicast11:12
lifelessor rather11:12
lifelessPXE is a combination of DHCP metadata and a TFTP server11:12
lifelessthe TFTP is unicast11:13
mariosright11:13
lifelessthe DHCP is relayable yes11:13
marios(so much wikipedia told me, as i said i really don't know a lot about pxe)11:13
openstackgerritGopi Krishna S proposed a change to openstack/ironic-specs: Add HTTP GET support for vendor_passthru API  https://review.openstack.org/10864611:13
mariosi see. but do we have dhcp-relay in neutron, i'm not sure we do today11:13
marioslifeless: ^^^11:13
*** nosnos has joined #openstack-ironic11:13
marioslifeless: but in anycase, aren't we considering the simple case first, where they are on the same subnet?11:13
marioslifeless: isn't out baremetal network single flat, right now. or are we already talking about subnetting the undercloud network?11:14
lifelesspossibly, I don't think it affects our code11:14
lifelessmarios: those are separate concerns11:14
lifelessmarios: point is the DHCP server doesn't need to be in the same subnet11:15
lifelessit could be on a different subnet, our flat network code still works11:15
marioslifeless: which dhcp server though, the neutron one, or the server running on your real world router11:15
marioslifeless: since in neutron dhcp is enabled by subnet (is what i mean)11:16
dtantsurmarios, what do you mean by "dhcp enabled by subnet"11:17
dtantsuraren't subnets property of IP?11:17
mariosdtantsur: yes they are, that's why i was asking about neutron vs real11:17
lifelessmarios: a neutron managed one, which doesn't preclude it being on the router:)11:17
marioslifeless: i see :)11:17
lifelesspoint is we don't need to think about that11:18
lifelessits a separate concern11:18
marioslifeless: ok, so i only just got pulled into this so am trying to understand the problem still11:18
lifelesswe tell neutron what we want, and if the network admins have set it up with relay vs same-l2-domain, its not our concern11:19
*** bmahalakshmi has quit IRC11:19
marioslifeless: so, i think lucasagomes is right that we may be able to use extra-dhcp-options (since it has an example for pxe specifically)11:20
lifelessits per port11:20
lifelessyou would need to create a port for every possible MAC :)11:20
mariosAHH... this conversation is split between two channels, i have a headache11:20
marioslifeless: right, why is that a problem11:20
lucasagomeshah yeah let's stick to this channel?11:20
marioslifeless: you then use those ports to boot11:20
marioslifeless: one port for each host11:21
lifelessso as I said, AFAIK neutron has no support for wildcard DHCP today11:21
mariosnova boot <server_name> --image <image> --flavor <flavor> --nic port-id=<port1_id>11:21
*** lazy_prince has quit IRC11:21
mariosi am still missing something then11:21
*** romcheg1 has quit IRC11:22
lifelessyes11:22
marioshaha, thanks11:22
lifelessthe problem lucasagomes is trying to solve is booting unknown machiens11:22
lifelessnova boot boots known machines11:22
lucasagomesyes, so those dhcp extra options needs to be set in a more "global way" not for a specific port11:23
lifelessextra-dhcp-options on ports was added by dkehn to support nova-bm and Ironic, so we didn't have a separate DHCP server (which caused all sorts of issues)11:23
lifelessthey have to be set per-port for booting known machines11:23
mariosok11:23
lifelessbecause they are unique per machine11:23
lifelesschanging that stuff would be bad11:23
lifelesswe're talking an entirely different thing here11:23
lifelesswildcard DHCP11:23
lifelesswhich is where the DHCP server answers a request with a just-in-time lease allocation11:24
lifelessall Neutron DHCP servers today are static allocation11:24
lifeless(done by API calls)11:24
lifelessso to PXE boot unknown macs we need 'wildcard DHCP' *and* we need the ability to set extra DHCP options just for the wildcard responses11:25
*** athomas_ has quit IRC11:25
lifelesswe can't sanely do it by running a parallel server, because wildcard and Neutron would race, so it has to be a Neutron feature11:25
mariosOK. thanks for taking the time to give all this context, i am reading and thinking11:26
marioslifeless: so the 'set extra dhcp options' is tripleo-code. the initial bit is in fact completely missing in neutron today11:26
lifelessAIUI yes11:27
marioslifeless: i.e. some kind of extension for neutron-dhcp-agent11:27
*** ryanpetrello has quit IRC11:27
*** athomas has joined #openstack-ironic11:27
lifelessyes11:27
*** k4n0 has quit IRC11:28
dtantsurso it's still unlikely that neutron supports it?11:28
dtantsur(my research also didn't show anything similar)11:29
*** Guest6703 has quit IRC11:29
dtantsurlifeless ^^^11:29
lucasagomeslifeless, thanks for the detailed explanantion of what's needed11:30
dtantsurok, how can we work around it?11:30
mariosdtantsur: yes i think that's true. BUT I still think it would be worth sending a mail out with this context to [#neutron]. we will need to write up a spec for 'wildcard dhcp' if this is something we need to pursue in neutron11:30
marioserr openstack-dev [neutron]11:31
dtantsurmarios, that will be definitely for Kilo, right?11:31
mariosdtantsur: 100000%11:31
mariosdtantsur: so if that is a factor, we need another way11:31
dtantsurso if we want something in J, we only can try to work around?11:31
mariosright11:31
marioslifeless: what about os-net-config11:31
mariosoh i am still confuging thigs, this is before they boot right?11:32
dtantsuryes, before11:32
*** ryanpetrello has joined #openstack-ironic11:32
lifelessmarios: as dtantsur says11:32
lucasagomesthe only workaround I can think of is having a external DHCP server... but idk what that may cause, it may overlap with neutron11:33
marioslucasagomes: and we'd need dhcp relay for that, which we also don't have (in neutron, afaik)11:34
dtantsurlucasagomes, it probably will overlap...11:34
lucasagomes:/11:34
lucasagomesaight11:34
dtantsurlucasagomes, I'm out of ideas, honestly. This discovery is adding me too much gray hair :/11:35
lucasagomesdtantsur, heh many missing bits and pieces on both ironic and now neutron11:36
lucasagomesdtantsur, but it's good if we can at least have a plan out of it11:36
lucasagomesfind out the missing parts etc11:36
lucasagomesthat's all good11:36
dtantsurlucasagomes, I agree, I just can't accept, that it's barely possible for J11:37
lucasagomesmarios, hey, thank you very much for the conversation!11:37
*** shausy has quit IRC11:37
*** shausy2 has joined #openstack-ironic11:37
dtantsuryeah, marios, lifeless, thanks a lot!11:37
lucasagomesdtantsur, yeah11:37
lucasagomesyeah, thanks guys11:38
lifelesslucasagomes: that workaround won't work11:39
lifelesslucasagomes: see my comment about races11:39
Nishadtantsur: lifeless lucasagomes  :) could you consider https://review.openstack.org/#/c/100951/ for review for J11:39
lifeless23:25 < lifeless> we can't sanely do it by running a parallel server, because wildcard and Neutron would race,11:39
lifeless                  so it has to be a Neutron feature11:39
*** nosnos has quit IRC11:40
dtantsurNisha, left my comments already11:40
Nishadtantsur: thanks11:40
mariosdtantsur: np, wasn't really very useful ;)11:40
marioslucasagomes: same matey, ^^^11:41
lucasagomeslifeless, :( yeah11:41
lucasagomesmarios, it was useful yes11:41
lucasagomesidentified what's missing is always useful :)11:42
lucasagomesidentifying*11:42
* marios still trying to get his head around the sequence of ops11:42
Nishadtantsur: Thanks. Minor comments will address them and post patch11:43
marioslucasagomes: do you have any more specs that have any of this written down (i.e. 'once the h/w info is retrieved by Ironic, we need to boot the host and it should contact our pxedchp' ...)11:43
lucasagomesmarios, I'm afraid not11:43
Nishalifeless: lucasagomes please could you guys also review the spec as it is also on dicovery11:43
Nishadiscovery*11:43
dtantsurmarios, after retrieving the information, we work as usual: create Ironic node, give it to Nova etc11:44
marioslifeless: if we could define the mac address for a port, that could also help right (but still, ponies and rainbows if we could get it into neutron asap)11:45
lifelessmarios: *blink* - how?11:46
marioslifeless: define the neutron port with mac and then dhcp works as usual. oh but its the pxe that is missing.11:46
mariosk11:46
marios(pxe dhcp)11:46
marioslifeless: (i.e. port with mac and use that to boot the server)11:47
mariosnm11:47
lucasagomesmarios, well if you define the neutron port with the mac you can set the extra_dhcp_opts for pxe11:48
lucasagomesbut the idea of the discovery is to find that information (like mac address)11:48
lucasagomesthat's why we need the wild cards11:48
lucasagomeslike tell neutron to boot everything that is "00-FF-*"11:48
marioslucasagomes: but the mac we get from the ramdisk right11:49
lucasagomesand set extra dhcp options for that wildcard configuration ^11:49
lucasagomesmarios, yes, but we need to boot it first11:49
lucasagomesand for that we need a dhcp server11:49
lucasagomesfor unknown nics11:50
marioslol. i'll get there eventually lucasagomes :)11:50
lucasagomes:D11:50
lucasagomesmarios, https://www.youtube.com/watch?v=gZGYeo7sJhQ << with an external dhcp server11:51
*** jcoufal has joined #openstack-ironic11:51
lucasagomesjust to give an idea of how it would looks like11:51
lucasagomesmarios, on that example, I'm not using neutron and I've a dnsmasq started with: sudo  dnsmasq --conf-file= --port=69 --enable-tftp --tftp-root=/tftpboot  --dhcp-boot=pxelinux.0 --bind-interfaces --pid-file=/var/run/dnsmasq.pid  --interface=ens9 --dhcp-range=192.0.2.32,192.0.2.4811:52
lifelessmarios: its the mac that is missing11:54
lifelessmarios: if you have the mac, you've already discovered the machine11:54
lifelesslucasagomes: that will race with neutron and cause Ironic boots to fail11:54
lucasagomeslifeless, yeah yeah I know, it was just the first stab11:54
openstackgerritGopi Krishna S proposed a change to openstack/ironic-specs: Updated the spec file format.  https://review.openstack.org/10865711:54
lucasagomeslifeless, I had an external dhcp server to test the DIB element for the discovery ramdisk11:55
lifelesssure11:55
*** vinbs_ has joined #openstack-ironic11:58
*** vinbs has quit IRC12:01
*** vinbs_ is now known as vinbs12:01
saripurigopiIf I submit modified spec for review, does it create new review request ?12:03
*** kpavel has quit IRC12:04
*** kpavel has joined #openstack-ironic12:05
lucasagomessaripurigopi, if ur using the same Change-Id in the commit message, no12:05
lucasagomesit will just create a new patch-set on that review12:05
*** chuckC has quit IRC12:06
lucasagomes(well assuming "new review request" == a new patch)12:06
lucasagomessaripurigopi, I think the best is to take a look here https://wiki.openstack.org/wiki/Gerrit_Workflow12:07
saripurigopilucasagomes, ok, I'll correct it.12:07
*** Poornima_ has quit IRC12:07
*** dtantsur is now known as dtantsur|lunch12:07
*** krtaylor has quit IRC12:08
*** vinbs_ has joined #openstack-ironic12:09
*** vinbs has quit IRC12:11
*** vinbs_ has quit IRC12:14
openstackgerritGopi Krishna S proposed a change to openstack/ironic-specs: Add HTTP GET support for vendor_passthru API  https://review.openstack.org/10864612:18
*** lucasagomes is now known as lucas-hungry12:19
*** jdob has joined #openstack-ironic12:27
*** i159 has joined #openstack-ironic12:27
*** romcheg1 has joined #openstack-ironic12:27
i159Hi! I have a problem with requirements installation of Ironic: IOError: [Errno 2] No such file or directory: '.tox/py26/build/nova/setup.py'. Branch master. Is it OK? How to solve it?12:29
*** killer_prince has joined #openstack-ironic12:31
*** killer_prince is now known as lazy_prince12:32
*** saripurigopi has quit IRC12:34
*** derekh_ has joined #openstack-ironic12:49
devanandamorning, all12:55
*** rameshg87 has left #openstack-ironic12:56
*** matty_dubs|gone is now known as matty_dubs12:59
*** pcrews has joined #openstack-ironic13:01
*** jcoufal has quit IRC13:03
*** athomas has quit IRC13:03
*** greghaynes has joined #openstack-ironic13:05
*** dtantsur|lunch is now known as dtantsur13:05
dtantsurdevananda, morning13:06
*** rloo has joined #openstack-ironic13:07
*** athomas has joined #openstack-ironic13:07
*** rwsu has joined #openstack-ironic13:08
*** lucas-hungry is now known as lucasagomes13:11
lucasagomesdevananda, morning13:11
lucasagomesi159, requirements installation? are you following http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html?13:11
lucasagomesi159, tox -evenv -- echo 'done' ; to create a new env13:12
i159lucasagomes: I use tox -re py2613:14
*** krtaylor has joined #openstack-ironic13:15
i159lucasagomes: It worked well a few days ago.13:15
lucasagomesi159, right I'm not tox expert... so I mostly follow the guidelines at dev-quickstart and it works for me13:15
NobodyCamgood morning Ironic13:16
lucasagomesNobodyCam, morning13:16
NobodyCammoring lucasagomes :)13:16
i159lucasagomes: me too, have you tried to run tox -re with Ironic lately (today)?13:17
lucasagomesi159, nop, lemme give it a go13:17
*** jgrimm has joined #openstack-ironic13:17
dtantsurNobodyCam, morning :)13:17
rlooi159: I haven't scrolled back, but yesterday I had to redo my tox environment because I think the requirements or something changed.13:18
lucasagomesrloo, I think it was the oslo.db13:18
rlooi159: ie, I deleted .tox and reran tox -evenv -- echo 'done'.13:18
lucasagomesyou would have to delete the pyc13:18
lucasagomesleft by the openstack/common/db/*13:18
NobodyCammorning dtantsur and rloo too:)13:19
rloomorning NobodyCam and all ironickers.13:19
i159lucasagomes: we have tried on two Ubuntu machines, and it falls down on both.13:19
rloolucasagomes: yeah, might have been that.13:19
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: Add newly_discovered column to Node object  https://review.openstack.org/10738913:19
lucasagomesi159, right I will take a look13:19
i159lucasagomes: thanks!13:20
lucasagomesi159, oh yeah I see it13:22
lucasagomesi159, it seems to be something with the nova tarball tho13:22
lucasagomeshttp://paste.openstack.org/show/87606/ < on my machine13:22
*** jcoufal has joined #openstack-ironic13:23
jrollmornin13:23
lucasagomesi159, yeah the nova tarball seems to be corrupted13:24
dtantsurjroll, morning13:24
lucasagomestar: Skipping to next header13:24
lucasagomesgzip: stdin: invalid compressed data--crc error13:24
lucasagomesgzip: stdin: invalid compressed data--length erro13:24
i159lucasagomes: yep this is it, I saw that the problem with some nova stuff, but I don't know nothing about Ironic, and it was happened on master branch13:24
rloolucasagomes, i159: I see it too now :-(13:24
* jroll scrolls up13:24
lucasagomesi159, we download nova because we right now have the nova driver in our tree13:24
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: Fix leaking DB details to API on error  https://review.openstack.org/7312113:24
lucasagomesi159, so nova is a requirement for us to be able to run the tests on the driver13:24
i159rloo lucasagomes: good, I mean good, that you see it too =) Can you fix it, or I should ping Nova guys?13:26
devanandawhat's wrong with the nova tests?13:26
lucasagomesi159, yeah I just brought it to the nova channel to let them know13:26
lucasagomesdevananda, nothing... the tarball at http://tarballs.openstack.org/nova/nova-master.tar.gz is corrupted13:26
i159lucasagomes: yep, good...13:27
*** bvivek has quit IRC13:27
devanandalucasagomes: corrupted? it opens fine for me13:27
lucasagomesdevananda, if u try to extarct with "tar xvf"13:27
lucasagomesit fails in the middle13:27
lucasagomesand the setup.py is not there13:27
lucasagomesdevananda, probably it failed when it was creating the tar ball, that's why there's some missing files13:28
devanandaahh13:28
devanandayou're right13:28
rloodoes jenkins use the same nova tarball?13:29
lucasagomesdevananda, just brought it to the #openstack-infra should be fixed soon13:29
devanandalucasagomes: great, thanks13:29
rloothx lucasagomes. Guess I'll do some reviews in the meantime ;)13:30
lucasagomesrloo, :)13:30
devanandarloo: i believe so. which means our tests will be broken atm13:30
NobodyCamgood morning devananda13:30
NobodyCammornign jroll13:30
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Import fixes from Nova scheduler reviews  https://review.openstack.org/10731613:31
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Import fixes from Nova scheduler reviews  https://review.openstack.org/10731613:33
*** rakesh_hs has quit IRC13:33
devanandalucasagomes: fixed a typo in the base host class just now too13:34
lucasagomesdevananda, yeah just revoted after saw ur comment13:34
lucasagomesI mean removed my vote13:34
jrollholy scrollback13:34
lucasagomesdevananda, the hard thing with that typo is that it's not exercises in our tree (and shouldn't)13:34
* jroll stabs neutron13:34
devanandaactually it's not going to be exercised anywhere13:35
lucasagomesx.x13:35
devanandasince nothing will instantiate the base class13:35
lucasagomesyeah baremetal classes13:35
devanandaand there are no unit tests being proposed for this13:35
devanandai hate everything about that patch, fwiw, but am tired of arguing with Nova about hwo to land our code13:35
devanandaso it gets my +213:35
lucasagomesyeah, I figured that... sharing code with nova bm13:35
lucasagomesnot good13:35
lucasagomesI mean... I wanted nova bm gone really13:36
lucasagomesand not have to refactor ironic code when nova bm time arrives13:36
devanandalucasagomes: gonna be a year before nova deletes taht code, apparently13:37
lucasagomesdevananda, 2 releases?!13:37
* lucasagomes thought it was 1 13:38
devanandai thought so too13:38
devanandajust quoting ...13:38
lucasagomesoh well...13:38
NobodyCam:(13:39
lucasagomesdevananda, patch lgtm, I will go ahead and approve it, objections?13:39
devananda++13:39
devanandagoing to fix up 107882 too now13:45
openstackgerritChris Krelle proposed a change to openstack/ironic: Add option to allow soft power off  https://review.openstack.org/10777813:48
jrolldtantsur: that devstack patch is just a WIP... it's going to be fully configurable etc, don't worry :)13:50
jrollI didn't put it up for reviews, I put it up so that others can 'git review -d'13:51
dtantsurjroll, I could not resist, sorry ;)13:51
jrolllol13:51
jrollget those review points ;)13:51
NobodyCam:-p13:51
*** rainya has joined #openstack-ironic13:52
*** bvivek has joined #openstack-ironic13:52
*** igordcard has quit IRC13:53
*** Nisha has quit IRC13:54
NobodyCamlucasagomes: got a second13:54
lucasagomesNobodyCam, yo sure13:55
NobodyCam:)13:55
NobodyCamwanted to quickly chatt about 10777813:56
NobodyCamthats my soft power off patch13:56
NobodyCamstill very much a wip13:56
NobodyCambut13:56
NobodyCamI think my patch is the incorrect way to do this13:57
NobodyCamI like Ng's way (107864) much better, thou it too may need some clean up13:57
lucasagomesNobodyCam, will take a look at Ng's14:01
*** romcheg1 has quit IRC14:01
NobodyCam:)14:01
lucasagomesNobodyCam, yeah well it was just confusing, the loop logics there14:01
lucasagomescould be simplyfied, that was my point14:01
NobodyCamand only send soft / off one time each?14:02
jrolllucasagomes: you think it's ok for the agent to use a bunch of pxe options? (tftproot etc) or should we re-define those?14:03
lucasagomesjroll, I was talking to lifeless while ago... we want to introduce a new interface for drivers, like boot manager interface14:05
lucasagomeswhich will be separate of the deploy interface14:05
lucasagomesthey are 2 diff things14:05
jrollwell14:05
jrollyes14:05
lucasagomesjroll, but I'm afraid that for J14:05
lucasagomesidk if we should go for that much refactor14:05
jrollbut we want to land ipa driver in the meantime :)14:05
lucasagomesjroll, sure, ofc14:06
jrollyeah, there's no way we can land that split in juno14:06
lucasagomesjroll, that's why I think that yeah using that options is not ideal, but... I would do it for the first version if u guys don't mind14:06
lucasagomesexactly14:06
jrollright, so14:06
jrollI don't mind because I won't be using pxe14:06
jrollbut the drivers should be able to coexist14:06
jrolland was trying to think if that's a problem, if people are using both14:06
lucasagomesjroll, oh that's a very good point14:07
jrollI'm inclined to say its ok... can't think of a huge problem14:08
lucasagomesjroll, right, 1 min... I'm in a hangout14:08
jrollthere is tftp_root, tftp_master_path, and tftp_server14:08
jrollyeah no worries14:08
*** kpavel has quit IRC14:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Import fixes from the Nova driver reviews  https://review.openstack.org/10788214:11
openstackgerritChris Krelle proposed a change to openstack/ironic: Add option to allow soft power off  https://review.openstack.org/10777814:13
devanandadtantsur, rloo: on when to use _L* -- http://docs.openstack.org/developer/oslo.i18n/guidelines.html#examples14:19
devanandatldr; still use _() for any user (API) facing messages14:19
devanandalike exceptions14:19
rloothx devananda.14:19
dtantsurdevananda, oh crazy :(14:19
dtantsurthanks14:19
NobodyCam:-p14:19
*** russellb has joined #openstack-ironic14:20
rloodtantsur: ha ha. I was refraining from commenting...14:20
russellbdevananda: o/  just checking in on juno-2 status whenever you have a few minutes14:20
*** romcheg1 has joined #openstack-ironic14:20
devanandarussellb: hi! i was just updating it :)14:20
devanandarussellb: should be done in a few minutes14:21
russellbsounds good, ping when you're done then14:21
devanandarloo: what's the status of your get-required-info patches? looks like they got rebased and should just be re approved?14:22
rloodevananda: yeah. rebased. although i was wondering if it needed to be rebased again today, but since tox isn't working, i can't really check/test.14:23
*** rainya has quit IRC14:24
devanandadtantsur, lucasagomes: either of you have a few to review https://review.openstack.org/#/c/107096/ ?14:26
dtantsurdevananda, we're on the call, I'll review afterwards14:26
jrollI can grab it14:27
devanandacheers, thanks14:27
rloodtantsur, devananda: i've been staring at the 2nd example and I don't get it: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#examples14:27
rloodtantsur, devananda: it seems to contradict the first example14:28
devanandarloo: which one?14:28
rloo# RIGHT14:29
rlooLOG.exception(_LE('There was an error.'))14:29
rlooraise LocalExceptionClass(_('An error occured.'))14:29
rloodevananda: the first example was msg = _(), LOG.exception(msg), raise Exception(msg)14:29
jrollrloo: so... if I update a driver and restart my conductor, then I need to restart api servers to get the updated properties?14:29
devanandarloo: difference between that and the first example -- the i18n'd string is different for the LOG vs the raise14:29
rloojroll: yup.14:29
devanandajroll: yep14:30
jrollrloo: and we're ok with that? :)14:30
rloojroll: yup the spec was approved.14:30
jrollI'm ok with that... just making sure14:30
jrollright14:30
* jroll keep sreading14:30
devanandajroll: spec outlined several alternatives. this was achievable :)14:30
rloodevananda: right, there's a diff. but for both, the exception msg is seen by the user. so why the diff with the LOG in the 2nd example?14:30
jrolldevananda: yep, no worries14:31
devanandarloo: the string seen by the user is not _LE in either case14:31
devanandarloo: in the second example, the LOG is _LE but the exception is not14:31
rloodevananda. so why in the first case, the LOG is not _LE, but in the 2nd case, it is _LE?14:32
devanandarloo: because in the first case, the string is the same. in the second case, the string is different14:32
rloodevananda: ie, when do you use _LE for the log.exception and when don't you use it?14:32
devananda"A common pattern is to define a single message object and use it more than once, for the log call and the exception. In that case, use _() because the message is going to appear in an exception that may be presented to the user."14:32
rloodevananda: $@% got it. I didn't realize that in the 2nd case, the strings were diff. need more caffeine... thx.14:33
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Implement retry on NodeLocked exceptions  https://review.openstack.org/10771014:33
devananda:)14:33
rloodevananda: so for logging exceptions and logging errors, we use _LE().14:34
rloodevananda: or maybe for LOG.exception we use whatever _L*() that seems right for that situation. Sigh.14:35
devanandaLOG.warning(_LW('words'))14:35
dtantsurIOError: [Errno 2] No such file or directory: '/home/jenkins/workspace/gate-ironic-pep8/.tox/pep8/build/nova/setup.py'14:35
dtantsurnow in the gate (just FYI)14:35
rloodtantsur: yeah. we're waiting for a fix... (I updated the whiteboard status)14:36
lucasagomesdevananda, will take a look, was in a call14:36
devanandaAIUI, LOG.error and LOG.exception should be _LE'd *unless* the same message is raised in such a way that it may be emitted by the API14:36
lucasagomesdtantsur, the nova tarball is corrupted, infra will fix it14:36
rloodevananda: ok, so _LE for both error & exception. thx.14:36
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements  https://review.openstack.org/10656914:38
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/8872214:38
jrollrloo: just one question... https://review.openstack.org/#/c/107096/4/ironic/common/hash_ring.py14:39
rloojroll: the answer is yes :-)14:40
jrollactually, that just clicked14:40
jrollyy14:40
jrollyay*14:40
rloojroll: ha ha.14:40
jrollapproved14:40
jrolldevananda: ^14:40
dtantsurbtw, http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables  <-- this is often encountered in our code14:40
rloodtantsur: yeah, I saw that too. I'm sure someone will have a patch to fix all that...14:41
*** MattMan has quit IRC14:44
*** MattMan has joined #openstack-ironic14:55
*** jgrimm has quit IRC14:56
*** shausy2 has quit IRC14:57
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Expose {set,get}_boot_device in the API  https://review.openstack.org/9015114:57
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: SSH virsh to use the new ManagementInterface  https://review.openstack.org/8988414:57
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: SeaMicro to use the new ManagementInterface  https://review.openstack.org/8632814:57
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface  https://review.openstack.org/8658814:57
*** ramineni has joined #openstack-ironic15:02
devanandajroll: have you applied for a nova spec freeze exception for the configdrive changes?15:02
devanandajroll: fwiw, I'd prefer we punt on that work until after hte ironic driver lands, as that is going to be hard enough as it is15:03
jrolldevananda: no... should I?15:03
jrollyeah15:03
devanandajroll: nova spec freeze deadline has passed15:03
jrollI'm still going to write and deploy the code, I don't mind so much when it lands :)15:03
jrollright, I know15:03
devanandajroll: right, k15:03
jrollI'm not rushed15:03
*** rainya has joined #openstack-ironic15:04
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Import fixes from the Nova driver reviews  https://review.openstack.org/10788215:06
jroll07:36:40     lucasagomes | dtantsur, the nova tarball is corrupted, infra will fix it <- how aware are they?15:06
lucasagomesjroll, I pinged the channel15:06
lucasagomeslemme ping again15:06
jrollheh ok15:07
*** mdorman has joined #openstack-ironic15:08
devanandalucasagomes: management interface patches on track to be landable (jenkins issues notwithstanding) today or tomorrow?15:08
lucasagomesdevananda, yup, I've been addressing the comments and rebasing it as quickly as I can15:08
rloodevananda: qq line 125: https://review.openstack.org/#/c/107882/5/ironic/nova/virt/ironic/driver.py15:09
devanandayea, i've seen. good stuff15:09
devanandarloo: ack15:09
lucasagomesdevananda, btw, now we have pagination and the cache thing on the client15:10
*** mdorman has quit IRC15:10
lucasagomesdevananda, we might want to make a new release of it15:10
devanandalucasagomes: yep! thanks for the ping15:11
devanandarloo: replied15:11
devanandagetting food -- bbiab15:11
lucasagomesdevananda, there's one patch in the queue adding a vendor passthru to the client, will review it15:11
lucasagomeswe may want to included that also15:11
*** mdorman has joined #openstack-ironic15:11
rloolucasagomes, devananda: are we in a hurry to do a new client pkg? I just remembered, the API to get driver properties has a change there too, but it is WIP until the code in ironic is merged.15:12
devanandaclient releases can be done as often as we like15:13
devanandait's not like doing one today prevents doing one next week (or tomorrow) -- i've just been waiting until we had actually landed those fixes15:14
*** ChuckC has joined #openstack-ironic15:14
*** lazy_prince is now known as killer_prince15:15
devanandarussellb: j2 milestone status page is accurate. we have patches up for all the specs targeted there, should be landable in the next ~48 hrs15:17
* devananda really gets food now... bbs15:17
russellbdevananda: thanks for the update!  if you could aim for tagging by EOD Wednesday, that'd be best.  Thursday should really be reserved for emergencies.15:17
russellbgood news is it's just an intermediate milestone, so just a checkpoint, not a huge deal to defer things15:18
russellbjust needs to be a in a good workable state, at least15:18
dtantsurlucasagomes, As I understand the last discussion, if you reuse log message as exception message, you should not use _LE, right?15:21
lucasagomesdtantsur, yes, that's how I understand it as well15:21
lucasagomesdtantsur, the _L* are for logs15:21
lucasagomesonly15:21
dtantsurlucasagomes, ok, you have one place in seamicro patch15:21
dtantsurlucasagomes, ah no, seems like I'm wrong15:22
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Implement retry on NodeLocked exceptions  https://review.openstack.org/10771015:22
dtantsurnevermind15:22
lucasagomesdtantsur, ack15:22
openstackgerritGhe Rivero proposed a change to openstack/ironic: Raise MissingParameterValue instead of invalid  https://review.openstack.org/10845515:25
dtantsurdevananda, https://review.openstack.org/#/c/107882/7/ironic/nova/virt/ironic/client_wrapper.py _LE is imported, but does not seem to be used. Why is that?15:26
rloodtantsur: ugh, that should be removed. It was there cuz _LE had been used but was removed.15:30
dtantsurenough for now, maybe will be back in the evening15:38
*** dtantsur is now known as dtantsur|afk15:39
lucasagomesurgh now the nova tarball is affecting our gate15:40
rloolucasagomes: yup. A long list of FAILUREs :-(15:40
lucasagomesyeah I just pinged sean directly15:41
lucasagomestelling on the channel wasn't giving me any feedbacks15:41
rloothx lucasagomes15:42
*** ramineni has quit IRC15:42
*** foexle has quit IRC15:53
*** Nisha has joined #openstack-ironic15:53
*** i159 has quit IRC15:54
openstackgerritRamakrishnan G proposed a change to openstack/ironic-specs: Move code to cleanup ImageCache to a common place  https://review.openstack.org/10799615:55
*** eghobo has joined #openstack-ironic15:56
*** eghobo has quit IRC16:00
*** eghobo has joined #openstack-ironic16:01
*** jgrimm has joined #openstack-ironic16:06
*** hemna has joined #openstack-ironic16:13
openstackgerritGhe Rivero proposed a change to openstack/ironic: Raise MissingParamenterValue when validating glance info  https://review.openstack.org/10845616:17
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Implement retry on NodeLocked exceptions  https://review.openstack.org/10771016:24
* devananda is back16:24
devanandalucasagomes: did you get any traction with infra?16:25
lucasagomesdevananda, clarkb seems to be looking at it16:25
lucasagomes<mordred> clarkb: the second thing16:26
lucasagomes<mordred> clarkb: what is the problem?16:26
lucasagomes<clarkb> nova tarball corrupted16:26
lucasagomes<mordred> awesome16:26
lucasagomes* annegent_ (~annegentl@50.57.17.244) has joined #openstack-infra16:26
lucasagomes<clarkb> two tarball jobs raced each other16:26
lucasagomes<clarkb> logs are linked about 12 minutes ago16:26
devanandacool16:26
*** bvivek has quit IRC16:30
*** romcheg1 has quit IRC16:39
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements  https://review.openstack.org/10656916:40
*** jistr has quit IRC16:41
openstackgerritGhe Rivero proposed a change to openstack/ironic: Avoid calling _parse_deploy_info twice  https://review.openstack.org/10844216:42
*** killer_prince has quit IRC16:43
*** jgrimm has quit IRC16:44
*** Mikhail_D_ltp has quit IRC16:47
*** jcoufal has quit IRC16:49
*** jcoufal has joined #openstack-ironic16:49
*** jcoufal has quit IRC16:50
*** jcoufal has joined #openstack-ironic16:50
*** pelix has quit IRC16:51
*** killer_prince has joined #openstack-ironic16:52
*** killer_prince is now known as lazy_prince16:52
*** martyntaylor has quit IRC16:56
*** jgrimm has joined #openstack-ironic16:57
*** jogo has left #openstack-ironic17:01
*** harlowja_away is now known as harlowja17:19
*** tatyana has joined #openstack-ironic17:28
openstackgerritNisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties at node-create/node-update  https://review.openstack.org/10095117:32
mordreddevananda: sorry I've been mostly flaky recently - are your 2.6 tests passing again?17:32
mordredor whatever the massive fail you had yesterday17:33
rloomordred: it was failing today too. do you know if a new nova tarball was generated recently?17:34
devanandamordred: i dont know if the 2.6 jobs were fixed, because ALL our jobs broke today. ^17:35
rloo(oops, forgot about the 2.6 failures.)17:36
lucasagomesaight ppl I will call it a day17:36
lucasagomeshave a good night everyone!17:36
rloonight lucasagomes!17:36
*** lucasagomes is now known as lucas-dinner17:37
NobodyCamnigt lucas-dinner17:37
jrollnight lucas17:38
*** tatyana has quit IRC17:39
openstackgerritNisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties for iLO driver  https://review.openstack.org/10300717:47
*** Mikhail_D_ltp has joined #openstack-ironic17:52
*** jcoufal has quit IRC17:59
ryanpetrellohey ironic folks17:59
ryanpetrellohttps://review.openstack.org/#/c/105583/1 this backport passed17:59
ryanpetrellomerging it should fix ironic stable/icehouse tests :)17:59
devanandaryanpetrello: cheers! adam_g ^18:01
* jroll tried to +2 that18:05
*** chuckC_ has joined #openstack-ironic18:05
devanandai can't +2 it either, fwiw18:05
devanandaonly members of stable-maint team can approve it18:05
*** chuckC_ has quit IRC18:06
*** romcheg1 has joined #openstack-ironic18:11
*** jcoufal has joined #openstack-ironic18:15
*** rainya_ has joined #openstack-ironic18:27
devanandamessing with graphite .... gate status graph short link: bit.ly/1qyzwG218:28
devanandastill messing around -- bit.ly/1o6uKwn  and bit.ly/1nj3lqc18:35
*** tatyana has joined #openstack-ironic18:45
ShrewsRun: 509 in 1475.027208 sec.18:48
Shrews - Passed: 38118:48
Shrews - Skipped: 6618:48
Shrews - Failed: 6418:48
Shrewsdevananda: adam_g: ^^^ smoke test results18:48
*** rainya has quit IRC18:49
*** rainya has joined #openstack-ironic18:50
rloofwiw, the nova tarball seems to be fixed. I can run tox in my dev environment. Not sure about jenkins though -- has anyone seen anything pass recently?18:50
devanandarloo: i just rechecked something to see18:51
*** shakamunyi has joined #openstack-ironic18:56
*** tatyana has quit IRC18:57
*** chuckC_ has joined #openstack-ironic18:59
Shrewsdevananda: adam_g: ignore those numbers... for some reason, i was on the wrong tempest branch and didn't have all of our recent changes included19:00
rlooI have a patch that passed 2 gates so Jenkins is working fine now. (I need to rebase, the story of our lives...)19:02
*** jcoufal has quit IRC19:04
*** jcoufal has joined #openstack-ironic19:05
*** chuckC_ has quit IRC19:06
openstackgerritRuby Loo proposed a change to openstack/ironic: Add drivers.base.BaseDriver.get_properties()  https://review.openstack.org/10709219:17
*** shakamunyi has quit IRC19:42
*** jbjohnso has joined #openstack-ironic19:44
openstackgerritGhe Rivero proposed a change to openstack/ironic: Fix tear_down a node with missing info  https://review.openstack.org/10368519:47
*** tatyana has joined #openstack-ironic19:49
openstackgerritRuby Loo proposed a change to openstack/ironic: Implement API to get driver properties  https://review.openstack.org/10709619:57
*** Nisha has quit IRC20:06
*** rloo has quit IRC20:10
*** fausto has joined #openstack-ironic20:13
*** rloo has joined #openstack-ironic20:15
openstackgerritA change was merged to openstack/ironic: Import fixes from Nova scheduler reviews  https://review.openstack.org/10731620:28
jrollNobodyCam: I hear there's an openstack NW meetup in portland tonight... has voodoo donuts.20:32
jrolldevananda: ^20:33
devanandajroll: openstack birthday party @ OSCON, yah?20:33
devanandajroll: except we're in Raleigh20:33
jrollI think so20:33
jrolloh shit20:33
jrollright20:33
jrollso confused20:34
jrollso many people in portland lately :P20:34
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Use auth_token from keystonemiddleware  https://review.openstack.org/10719720:34
* devananda wishes he was in portland right now20:34
jroll:)20:35
Shrewsdevananda: there is an OS b-day party at the local meetup this thursday. Would require a vehicle to get there, though20:35
jrollthere's one in sf this week, too :P20:35
devanandaShrews: and I'll be on a plane at that time20:37
*** tatyana has quit IRC20:43
devanandawhat do ya'll think of the client printing a big warning message any time someone calls a vendor_passthru method?20:47
devanandaI'm reviewing https://review.openstack.org/#/c/101297/ and realized why I'm hesitating to approve it, even thoug the code is fine20:47
devananda-- it validates *using* the vendor_passthru API in client code and bash scripts20:48
jrollwat20:48
devanandawhen I intend to change that API and expressly don't want to support any guarantee of compatibility (what a vendor does is up to them)20:48
devananda*intend to move things in that API into the common/standard/core API in the future20:49
jrollI don't see this validation you speak of20:49
devanandanot a programatic validation, a perceptual one20:49
devanandahaving it easily scriptable in the client enables folks to use it without realizign why they should NOT use it20:50
jrollohhhh, I see20:50
jrollright, I still don't know how I feel about it being in the client :/20:50
devanandait makes it possible for me to write a bash script that relies on some particular feature in the $foo driver's API20:50
devanandasomeone's going to put it in some client somewhere20:51
jrollyep, I don't know if I like that :)20:51
jrollI'm going to write *a* client for *my* driver...20:51
jrollidk what vendor passthru methods people would want to use from a bash script, though :/20:51
devanandajroll: discovery20:52
devanandajroll: downstream (proprietary) drivers20:52
jroll:|20:52
devanandajroll: it's the only case I can think of20:52
devanandaand they want support in the common client to use that functionailty20:52
jrollI'm starting to hate the idea of discovery, fwiw20:52
devanandaheh20:52
jrollit's like, really really cool20:52
jrollbut really complicated and totally unneccessary if you can convince your vendor to give you a spreadsheet full of mac addresses :P20:53
jrolland hardware specs etc20:53
devanandajroll: except for when that spreadsheet is almost always wrong20:53
jrollhmmm this would be a good blog post20:53
jrollvalidation20:53
jrollor something20:53
jrollhomogeneous hardware20:53
devanandausing discovery as a way to validate that spreadsheet?20:53
devanandayah20:54
jroll(yes, I know that's not an option)20:54
jrollehhhhhhh20:54
jrollI'm not questioning that it's useful, I'm questioning how much deployer work it saves :)20:55
jroll(compared to how much dev work it creates)20:55
*** jdob has quit IRC20:57
Shrewsdevananda: at least a warning seems like a good idea20:58
*** mrda-away is now known as mrda21:00
mrdaMorning Ironic!21:00
rlooso if anyone has some time, these need to be re-reviewed and approved: 107092 & 10709621:02
Shrewsmorning mrda21:02
rloothey also happen to conflict with lucas-dinner's new ManagementInterface changes. So every time one of his patches makes it in, the above need to be rebased/fixed.21:03
mrdarloo: I'll take a look21:03
mrdaShrews: \o21:03
*** eghobo has quit IRC21:03
rloothx mrda. They've already been approved once, so I really need +2 powers ;)21:03
Shrewsrloo: looking21:04
mrdarloo: I understand, but at least I can do the sanity check21:04
devanandaShrews: lifeless had an interesting point. Simply that the word "vendor" is in the CLI command is probably sufficient to scare people a bit :)21:05
* devananda approves it21:05
rlooyes, I trust that you're sane mrda :-) (Didn't meeeerda anyone recently have you?)21:05
devanandamrda: hi! I fixed up several things in your patches to Ironic21:06
mrdarloo: *groan*21:06
mrdadevananda: thanks I'll take a look21:06
rlooMr. mrda, you're the one that mentioned it to me :-)21:06
*** athomas has quit IRC21:07
mrdadevananda: if you have a few cycles, Dan Prince's config options questions might be worth your opinion (that's the outstanding thing from the nova-side of these reviews)21:07
devanandamrda: alraedy done :)21:07
mrdarloo: I need to make you forget21:07
mrdadevananda: ta21:07
devanandamrda: see latest version of https://review.openstack.org/#/c/107882/21:07
devanandai'm looking into the jenkins failure21:08
devanandaalso i dont know that I agree with dtantsur|afk's objections21:08
devanandaoh. error is trivial, duh. http://logs.openstack.org/82/107882/7/check/check-tempest-dsvm-virtual-ironic/5edd30f/logs/screen-n-cpu.txt.gz?level=INFO21:08
devanandaerr21:09
devanandahah21:09
zer0c00lHi rloo21:09
rloohi zer0c00l21:10
mrdadevananda: oh21:10
zer0c00lI am Arun from Yahoo's Linux team.21:11
devanandamrda: your import wrapper is failing, fwiw21:11
mrdayup, looking now21:11
rloozer0c00l: are you going to help out on ironic?21:11
devanandamrda: it's assuming that the 'ironicclient' module has an 'client' and 'exception' member objects,w hih it does not21:11
zer0c00lWhy not?21:12
zer0c00lI know little bit of python21:12
zer0c00l:)21:12
rloozer0c00l: that would be GREAT21:12
zer0c00lI had questions about ironic-python-agent before21:12
zer0c00lIt has lot of features that overlap with an OS installer21:13
rloozer0c00l: I'm not the person to ask about IPA. jroll et al are. What kind of questions.21:13
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Import fixes from the Nova driver reviews  https://review.openstack.org/10788221:13
devanandamrda: lets see if that passes21:13
zer0c00lAnaconda has code for partitioning the disk and stuff , it would be nice to look at that code. May be reuse some of it21:14
zer0c00lAnaconda is from RedHat21:14
harlowjawhats redhat, haha21:14
harlowja:-P21:14
zer0c00land it is mostly python21:14
devanandazer0c00l: you should talk with jroll21:14
zer0c00lyeah21:14
mrdadevananda: thanks for pushing a new version!21:14
*** foexle has joined #openstack-ironic21:14
zer0c00lsure!21:15
zer0c00ljroll: hi21:15
devanandaJoshNang: status of the swiftclient changes? any news?21:17
zer0c00lI think lucas-dinner may know little bit more about anaconda.21:17
zer0c00lhttps://git.fedorahosted.org/cgit/anaconda.git/21:17
JoshNangdevananda: merged and packaged!21:17
devanandaJoshNang: woot! thought I heard that. So. we should proceed with the changes here, ya?21:17
JoshNangpython-swiftclient 2.2.0 has it. i have a patch to global reqs to bump it up and i'm working on the ironic patch right now21:18
devanandaJoshNang: awesome. so not this week. possibly next. definitely before J321:18
rloozer0c00l: might try dtantsur|afk wrt anaconda, he's a RH person too.21:19
Shrewsrloo: reviewed 107092. not sure i'll get to the other one today21:19
rloothx Shrews. The first is the important one - that's the one that clashes with lucas' new ManagementInterface stuff.21:19
JoshNangdefinitely before J3. I mean tests will pass before the global reqs get bumped, and -infra seemed to imply we could go ahead and merge before the bump, but that doesn't seem right to me.21:20
Shrewsrloo: i'll +2 it if you agree to the recommended fix and push a new one soon21:20
Shrewsbrb21:20
rloothx Shrews. good catch!21:21
openstackgerritRuby Loo proposed a change to openstack/ironic: Add drivers.base.BaseDriver.get_properties()  https://review.openstack.org/10709221:23
faustoHi all @here : )21:24
jrollzer0c00l: hello!21:26
* jroll reads up a little21:26
faustoI'd like to give some help with Ironic, if possible21:26
devanandafausto: hi and welcome :)21:27
faustodevananda, thanks, I think we are collegues21:28
fausto:)21:28
*** matty_dubs is now known as matty_dubs|gone21:29
faustoopsauto21:29
jrollzer0c00l: does anaconda have a python API? it's unclear to me if we do anything advanced enough to want to depend on anaconda21:30
jrolldevananda, JoshNang, josh's patch is a blocker for landing the ipa driver. so... I'd really like to land it this week :|21:30
mrdadevananda: you meantioned that you didn't agree with dtantsur's comments on patch 7 of 107882.  i.e interpolation and exceptions?21:30
devanandajroll: ack. I fully support that if it can be done21:31
jrolldevananda: I think it can be done :)21:31
devanandajroll: ie, it depends on landing a change in global-requirements, which we don't control21:31
* jroll +A's :P21:31
jrolldid that not land?21:31
jrollboo21:32
devananda21:18:06 < JoshNang> python-swiftclient 2.2.0 has it. i have a patch to global reqs to bump it up and i'm working on the ironic patch right now21:32
jrollwe just need to bug infra...21:32
jrollbut I think we should review josh's patch on the next rev21:32
jroll+2 it all over the place21:32
jrolland land immediately after global req21:32
*** shakamunyi has joined #openstack-ironic21:33
devanandajroll: ++21:33
openstackgerritRuby Loo proposed a change to openstack/ironic: Implement API to get driver properties  https://review.openstack.org/10709621:34
zer0c00ljroll: It does not exactly have an API21:36
jrollzer0c00l: hmmmm, I don't love shelling out :|21:37
zer0c00lDracut parses kickstart -> Starts anaconda -> Partitions -> installation -> Bootloader reboot21:37
jrollwe do this already... but to single-purpose programs21:37
jrollhmmm21:37
*** foexle has quit IRC21:39
zer0c00lI think ironic-python-agent will be an installer with an API :)21:40
zer0c00lBut the code/ideas can be copied easily from the existing installer (guessing)21:40
zer0c00lLike figuring out whether it is a bios boot/ uefi boot21:41
zer0c00lhandling grub2 vs grub121:41
devanandazer0c00l: ironic should not (and does not) run installers21:41
devanandazer0c00l: it writes a machine image to a disk21:41
JayFdevananda: jroll: I tried to get some urgency behind that global-reqs merge req, but ClarkB kept saying we should just merge the ironic patch before the global req patch hits because pip will install the newest version by default21:41
zer0c00li understand, but as per correct spec there is a plan to support partitions ?21:42
JayFdevananda: jroll: I do not /agree/ with this assessment however, but wanted to be sure it was stated :)21:42
devanandazer0c00l: no. Ive blocked and pushed back on that discussion. arbitrary partitioning, support for LVM, etc, should not, IMNSHO, be in Ironic21:42
devanandazer0c00l: what spec are you referring to?21:42
zer0c00li see21:42
devanandazer0c00l: and has it been approved?21:43
zer0c00llet me check21:43
devanandaJayF: gotcha. clarkb seldom gives bad advice when it comes to test infra ...21:43
devanandaJayF: so perhaps we should proceed21:43
jrolldevananda, zer0c00l: we'll need to support partitions to some extent, but not arbitrary partitions21:43
zer0c00li think that is a slippery slope :)21:44
devanandazer0c00l: also, what does partitioning have to do with the "be an installer with an API"?21:44
JayFdevananda: I would, and if it breaks, we'll tell him so he won't issue that advice in the future :)21:45
zer0c00lhow do you define parition type/lvm21:45
jrollright... I don't think anaconda is very relevant here, unfortunately21:45
devanandathere's a functional difference between traditional installers and taking a pre-built cloud image and booting it21:45
devanandathat difference is tremendous21:45
zer0c00lyes21:45
jrollzer0c00l: nova/ironic should define the partition scheme, based on the user/flavor options21:45
devanandaironic is not an installer with an API21:45
*** romcheg1 has quit IRC21:45
devanandathough I would like to know what gave you taht impression. Possibly our messaging about what ironic *is* could use some clarification :)21:46
openstackgerritA change was merged to openstack/python-ironicclient: Add ironic cli support for vendor-passthru  https://review.openstack.org/10129721:47
*** ChuckC has quit IRC21:48
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Push the image cache ttl way up  https://review.openstack.org/10690621:48
jrolldevananda: IPA still has some cruft left over in launchpad from agordeev and friends :|21:48
zer0c00ldevananda: https://wiki.openstack.org/wiki/Ironic-python-agent21:49
* jroll is curious what happened to those folks21:49
*** Badcub01 has joined #openstack-ironic21:49
zer0c00lThe motivation, seems like a installer project to me.21:49
zer0c00lSorry i might have misunderstood21:49
zer0c00lthis whole thing21:49
*** john___ has joined #openstack-ironic21:49
jrollwell... IPA does a lot of "write an image to disk", yes21:50
devanandazer0c00l: one motivation: treat hardware like cattle. use a cloud API to provision physical machines, just like any other instance in a cloud.21:50
devanandajroll: feel free to clean up cruft where you find it. should go without saying :)21:51
zer0c00lok21:51
jrolldevananda: ofc, I just haven't gone looking for it21:51
*** chuckC has joined #openstack-ironic21:55
*** rainya has quit IRC21:55
*** john___ has quit IRC21:55
*** Badcub01 has quit IRC21:55
*** shakamunyi has quit IRC21:56
Shrewsrloo: i lied. i did get to the other review  :)21:59
*** chuckC has quit IRC21:59
*** jcoufal has quit IRC21:59
rloothx Shrews. I'll take a look. I suspect that they will both have to be rebased anyway.22:00
*** derekh_ has quit IRC22:00
*** rwsu has quit IRC22:02
openstackgerritRuby Loo proposed a change to openstack/ironic: Implement API to get driver properties  https://review.openstack.org/10709622:04
*** BadCub02 has joined #openstack-ironic22:06
devanandagetting food, bbl22:09
*** eghobo has joined #openstack-ironic22:11
openstackgerritGhe Rivero proposed a change to openstack/ironic: Raise MissingParameterValue instead of invalid  https://review.openstack.org/10845522:12
*** jgrimm has quit IRC22:17
*** Mikhail_D_ltp has quit IRC22:23
openstackgerritA change was merged to openstack/ironic: Rename/update common/tftp.py to common/pxe_utils.py  https://review.openstack.org/10359522:23
openstackgerritA change was merged to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/10694822:23
*** mdorman has quit IRC22:24
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Adding swift temp url support  https://review.openstack.org/8139122:31
*** eghobo has quit IRC22:38
openstackgerritMichael Davies proposed a change to openstack/ironic: Import fixes from the Nova driver reviews  https://review.openstack.org/10788222:38
*** eghobo has joined #openstack-ironic22:50
openstackgerritGhe Rivero proposed a change to openstack/ironic: Raise MissingParamenterValue when validating glance info  https://review.openstack.org/10845622:55
openstackgerritGhe Rivero proposed a change to openstack/ironic: Avoid calling _parse_deploy_info twice  https://review.openstack.org/10844222:56
*** lucas-dinner has quit IRC22:56
*** fausto has quit IRC22:57
*** eghobo has quit IRC23:02
*** eghobo has joined #openstack-ironic23:02
openstackgerritA change was merged to openstack/ironic: SeaMicro to use the new ManagementInterface  https://review.openstack.org/8632823:03
*** dkehnx has joined #openstack-ironic23:06
*** jcoufal has joined #openstack-ironic23:15
*** rainya has joined #openstack-ironic23:18
mrdaThanks to all who reviewed 107316 - I've just proposed that code back into Nova now as an update to 103165 \o/23:46
* mrda goes back to the driver now that the scheduler changes are in Nova's court23:47
*** radsy has joined #openstack-ironic23:54
*** radsy has joined #openstack-ironic23:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!