| openstackgerrit | Chris Jones proposed a change to openstack/ironic: Do terrible things to support graceful shutdowns on rebuild(). https://review.openstack.org/107864 | 00:14 |
|---|---|---|
| NobodyCam | lol love th title | 00:14 |
| mrda | lol | 00:15 |
| mrda | *that* will get lots of review out of curiosity sake | 00:15 |
| Ng | damn | 00:16 |
| Ng | I should re-push with some kind of enterprise buzzword nightmare that puts everyone to sleep | 00:17 |
| Ng | commit messages could do with a "Gerrit: pleae don't shame me on IRC for this" flag | 00:17 |
| NobodyCam | lol | 00:18 |
| NobodyCam | and it really not so terrible | 00:18 |
| NobodyCam | we never had anything in the design to support multiable modes for off | 00:19 |
| NobodyCam | Ng: if your are pushing a better commit message. may be add some about why its needed... | 00:20 |
| openstackgerrit | Chris Jones proposed a change to openstack/ironic: Hack to support graceful shutdowns on rebuild(). https://review.openstack.org/107864 | 00:23 |
| Ng | NobodyCam: expanded the full commit to be clear about what's going on | 00:23 |
| NobodyCam | :) do you have a ironic power off corupts mysql datebases bug filed? | 00:24 |
| * NobodyCam makes air quotes | 00:24 | |
| NobodyCam | * ironic rebuild with --perserve-ephemeral power off corupts mysql datebases bug filed? | 00:26 |
| Ng | NobodyCam: we have https://bugs.launchpad.net/tripleo/+bug/1317056 | 00:28 |
| Ng | which is fs corruption | 00:28 |
| devananda | arriving in portland. see ya'll later | 00:29 |
| mrda | \o | 00:32 |
| lifeless | NobodyCam: around ? | 00:33 |
| lifeless | NobodyCam: so thi soft power thing | 00:35 |
| lifeless | NobodyCam: I think it would be a lot simpler to just change all the power off code paths | 00:35 |
| lifeless | NobodyCam: to try soft first for several retries and then do a hard | 00:36 |
| NobodyCam | lifeless: that would slow down power offs quite a bit | 00:40 |
| lifeless | NobodyCam: in the short term - can always add a soft-only thing in future | 00:40 |
| lifeless | NobodyCam: only if the OS is ignoring ACPI messages | 00:40 |
| lifeless | NobodyCam: there's no reason we can't make the ramdisk respond instantly | 00:40 |
| *** rloo has quit IRC | 00:41 | |
| NobodyCam | i can see a case where it could make things worse.. ie.. sends soft, node starts to shut down(writting to disk), soft off times out and then hard offs in the middle of the disk io | 00:41 |
| lifeless | NobodyCam: node might be writing anyway | 00:43 |
| NobodyCam | if the soft was in its own code path like in ng patch it could wait longer only for soft offs | 00:44 |
| *** Haomeng|2 has joined #openstack-ironic | 00:48 | |
| * jroll votes for soft power off only if instance_uuid is not None | 00:48 | |
| *** Haomeng has quit IRC | 00:49 | |
| jroll | question | 00:49 |
| jroll | do we expect that the user will never issue a hard shutdown from the OS? | 00:50 |
| jroll | seems like a really bad assumption | 00:50 |
| mrda | jroll: agreed | 00:53 |
| *** nosnos has joined #openstack-ironic | 00:53 | |
| jroll | I have a provisioned node with "last_error": "During sync_power_state, max retries exceeded for node 7856316a-45ab-46da-8d8c-0df3ca040d40, node state None does not match expected state 'power on'. Updating DB state to 'None' Switching node to maintenance mode.", | 00:55 |
| jroll | guessing that's what happened | 00:56 |
| jroll | but have not investigated | 00:56 |
| jroll | oh, maintenance=True, so that's not the issue here... but made me think about it | 00:56 |
| jroll | :) | 00:56 |
| lifeless | jroll: nice tweak | 00:58 |
| lifeless | jroll: if the user shuts down the OS themselves, their business | 00:58 |
| jroll | lifeless: I mean, maintenance is set to True, which means we were likely poking at it manually :) | 00:59 |
| jroll | lifeless: my problem is that ironic will power it back on if they shut it down | 00:59 |
| jroll | which is clearly not desirable | 00:59 |
| lifeless | jroll: sure, but they can call halt() | 01:01 |
| lifeless | jroll: rather than poweroff | 01:01 |
| jroll | as in, 'nova stop' or whatever? | 01:02 |
| lifeless | man halt | 01:02 |
| lifeless | halt stops everything but doesn't power off | 01:02 |
| lifeless | then nova stop | 01:02 |
| lifeless | to turn it off | 01:02 |
| lifeless | but you said this is the non-nova case (in maintenance) | 01:03 |
| lifeless | so we should expect ironic node-set-power-state | 01:03 |
| jroll | oh, right | 01:03 |
| jroll | I'm talking about the non-maintenance case | 01:03 |
| jroll | where a user | 01:03 |
| jroll | calls nova boot | 01:04 |
| jroll | and then wants to shut the server down | 01:04 |
| jroll | but doesn't know intimately (or at all) how our control plane works | 01:04 |
| jroll | and they do what they know | 01:04 |
| jroll | which is run 'sudo shutdown' | 01:04 |
| *** geekyogi has quit IRC | 01:08 | |
| *** rainya has joined #openstack-ironic | 01:17 | |
| lifeless | jroll: so, same thing as with nova and kvm or xen, right ? | 01:27 |
| lifeless | jroll: or does nova/kvm know that the user requested poweroff via ACPI ? | 01:28 |
| jroll | I would assume the hypervisor knows | 01:28 |
| jroll | maybe | 01:28 |
| jroll | idk | 01:28 |
| jroll | I need to look into this more... mostly thinking out loud | 01:28 |
| mrda | it's interesting f'sure | 01:29 |
| jroll | I gotta run, night y'all | 01:29 |
| mrda | jroll: \o | 01:30 |
| *** rainya has quit IRC | 02:15 | |
| *** killer_prince has quit IRC | 02:17 | |
| *** radsy has quit IRC | 02:33 | |
| *** pcrews has quit IRC | 02:53 | |
| *** Poornima has joined #openstack-ironic | 03:03 | |
| *** nosnos has quit IRC | 03:21 | |
| *** jcoufal has quit IRC | 03:21 | |
| *** killer_prince has joined #openstack-ironic | 03:23 | |
| *** killer_prince is now known as lazy_prince | 03:23 | |
| *** harlowja is now known as harlowja_away | 03:28 | |
| lifeless | NobodyCam: so that deallocate bug fix is buggy | 03:31 |
| lifeless | instance['node'] is raising, I think. digging atm | 03:31 |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Review fixes from the Nova driver reviews https://review.openstack.org/107882 | 03:45 |
| *** nosnos has joined #openstack-ironic | 03:50 | |
| *** Haomeng has joined #openstack-ironic | 03:51 | |
| *** Haomeng|2 has quit IRC | 03:52 | |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Review fixes from the Nova driver reviews https://review.openstack.org/107882 | 03:54 |
| *** krtaylor has joined #openstack-ironic | 03:55 | |
| *** hemna has quit IRC | 03:55 | |
| *** vinbs has joined #openstack-ironic | 04:14 | |
| *** ramineni has joined #openstack-ironic | 04:27 | |
| *** Haomeng|2 has joined #openstack-ironic | 04:33 | |
| *** Haomeng has quit IRC | 04:34 | |
| *** bvivek has joined #openstack-ironic | 04:49 | |
| *** geekyogi has joined #openstack-ironic | 05:00 | |
| *** geekyogi has quit IRC | 05:13 | |
| *** rakesh_hs has joined #openstack-ironic | 05:16 | |
| *** k4n0 has joined #openstack-ironic | 05:30 | |
| *** shausy has joined #openstack-ironic | 05:36 | |
| *** pcrews has joined #openstack-ironic | 05:38 | |
| *** pcrews has quit IRC | 05:50 | |
| *** bmahalakshmi has joined #openstack-ironic | 06:08 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/106948 | 06:11 |
| *** Mikhail_D_ltp has joined #openstack-ironic | 06:13 | |
| *** rameshg87 has joined #openstack-ironic | 06:47 | |
| rameshg87 | dtantsur|afk: i have some questions regarding image cache in here | 06:48 |
| rameshg87 | dtantsur|afk: i can't make out this method completely here. https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L266-L295 . i feel there is a bug here :-) | 06:48 |
| rameshg87 | dtantsur|afk: please ping when you are available | 06:48 |
| lifeless | rameshg87: what do you think is wrong? | 06:50 |
| rameshg87 | lifeless: hai | 06:52 |
| rameshg87 | lifeless: i was just trying to make sense from the code, i am just missing something here | 06:52 |
| rameshg87 | lifeless: i think we are trying to cleanup as much space as required for the images in this method. in here, we try to cleanup the mentioned cache first, and then try to cleanup all other caches until we have enough spec | 06:53 |
| rameshg87 | lifeless: s/spec/space | 06:53 |
| rameshg87 | lifeless: am i correct ? | 06:53 |
| rameshg87 | lifeless: have a look at this line first: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L284 | 06:53 |
| rameshg87 | lifeless: shouldn't this have been free += _free_disk_space_for(cache_to_clean.master_dir) | 06:54 |
| rameshg87 | lifeless: because we should keep on adding to free until we cross over total_size | 06:54 |
| lifeless | I believe you are right | 06:55 |
| lifeless | mmm possibly | 06:55 |
| lifeless | actually no | 06:55 |
| lifeless | cache is the cache we're going to be writing to | 06:55 |
| *** Haomeng has joined #openstack-ironic | 06:55 | |
| lifeless | we don't know if all caches are on the same fs | 06:55 |
| lifeless | so we can't assume that free space is additive | 06:55 |
| rameshg87 | lifeless: oh, so we read the free space again and again. | 06:56 |
| *** Haomeng|2 has quit IRC | 06:56 | |
| lifeless | however | 06:56 |
| lifeless | the caches = line | 06:56 |
| lifeless | does check st_dev | 06:56 |
| lifeless | so we could in principle be smarter | 06:56 |
| lifeless | but | 06:56 |
| lifeless | it still wouldn't be additive | 06:56 |
| lifeless | with the current code, direct reading of free space is correct | 06:57 |
| rameshg87 | lifeless: ah okay, i get it. | 06:57 |
| rameshg87 | lifeless: but why would we want to free up TFTPImageCache() when we want more space on InstanceImageCache() | 06:58 |
| rameshg87 | lifeless: assuming they are on the same fs ? | 06:58 |
| lifeless | so I'm not sure cleaning up files from the TFTP root is ever right | 06:59 |
| lifeless | its not a cache after all | 06:59 |
| lifeless | its working state | 06:59 |
| lifeless | dtantsur|afk: ^ | 06:59 |
| lifeless | rameshg87: the guard on line 275 means that we only try to cleanup (here) if there is not enough space to download the files for the image. | 07:00 |
| *** foexle has joined #openstack-ironic | 07:00 | |
| lifeless | rameshg87: I think the theory when this was written was that we should try hard to make space | 07:00 |
| rameshg87 | lifeless: i think because it compares st_dev of both the caches, it hopes we can cleanup some space from the other cache if they are onthe same mount | 07:00 |
| rameshg87 | lifeless: okay | 07:00 |
| lifeless | rameshg87: which I agree with except for the tftp root being files that belong to instances - deleting them breaks instance ability to boot | 07:00 |
| rameshg87 | but lifeless we delete only the files with link count == 1 | 07:01 |
| rameshg87 | https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/image_cache.py#L256 | 07:02 |
| rameshg87 | lifeless: so in effect we delete only the files which are not being used. | 07:02 |
| lifeless | oh, you have better eyes than me:) | 07:07 |
| lifeless | thanks for unconfusing me | 07:07 |
| lifeless | it is a cache | 07:07 |
| rameshg87 | lifeless: :-) | 07:08 |
| rameshg87 | dtantsur|afk: code looks alright and everything makes sense. no need to ping back :-) | 07:08 |
| rameshg87 | thanks lifeless for helping to understand :-) | 07:09 |
| *** ndipanov has joined #openstack-ironic | 07:13 | |
| *** Haomeng|2 has joined #openstack-ironic | 07:13 | |
| rameshg87 | dtantsur|afk: i just have an idea how we can move _cleanup_caches_if_required to image_cache | 07:14 |
| rameshg87 | dtantsur|afk: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L267-L270 | 07:14 |
| *** Haomeng has quit IRC | 07:15 | |
| rameshg87 | dtantsur|afk: will ping you when you are back | 07:15 |
| *** lazy_prince is now known as killer_prince | 07:15 | |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Review fixes from the Nova driver reviews https://review.openstack.org/107882 | 07:24 |
| *** geekyogi has joined #openstack-ironic | 07:25 | |
| *** romcheg has joined #openstack-ironic | 07:32 | |
| *** romcheg has quit IRC | 07:44 | |
| *** killer_prince has quit IRC | 07:48 | |
| *** bvivek has quit IRC | 07:48 | |
| *** jistr has joined #openstack-ironic | 07:56 | |
| *** ifarkas has joined #openstack-ironic | 07:59 | |
| *** killer_prince has joined #openstack-ironic | 08:01 | |
| *** killer_prince is now known as lazy_prince | 08:01 | |
| *** Dafna has joined #openstack-ironic | 08:05 | |
| *** jcoufal has joined #openstack-ironic | 08:12 | |
| *** Dafna is now known as Dafna_away | 08:15 | |
| *** bvivek has joined #openstack-ironic | 08:15 | |
| *** dtantsur|afk is now known as dtantsur | 08:16 | |
| dtantsur | Morning Ironic! I will be started somewhat later today - Czech lessons | 08:16 |
| dtantsur | rameshg87, will definitely answer your questions, when I'm back :) | 08:17 |
| *** athomas has quit IRC | 08:17 | |
| dtantsur | lifeless, right, only files that are not in use are considered for cleaning up | 08:18 |
| *** derekh_ has joined #openstack-ironic | 08:19 | |
| *** geekyogi has quit IRC | 08:20 | |
| *** geekyogi has joined #openstack-ironic | 08:20 | |
| *** geekyogi has quit IRC | 08:22 | |
| *** geekyogi has joined #openstack-ironic | 08:23 | |
| *** geekyogi is now known as yogib88 | 08:24 | |
| *** yogib88 has quit IRC | 08:26 | |
| *** lucasagomes has joined #openstack-ironic | 08:28 | |
| *** athomas has joined #openstack-ironic | 08:30 | |
| mrda | Have a good weekend Ironic - see you Monday! | 08:34 |
| *** mrda is now known as mrda-weekend | 08:34 | |
| *** bowdeng_hp has joined #openstack-ironic | 08:48 | |
| rameshg87 | thanks dtantsur | 08:48 |
| *** mordred has quit IRC | 08:54 | |
| *** datajerk has quit IRC | 08:59 | |
| rameshg87 | lucasagomes: request you to take a look at https://review.openstack.org/#/c/89500/ , we just did some minor changes from dtantsur comments from where you had approved :-) | 09:02 |
| *** mordred has joined #openstack-ironic | 09:14 | |
| *** mordred has quit IRC | 09:14 | |
| *** mordred has joined #openstack-ironic | 09:14 | |
| lucasagomes | rameshg87, will do | 09:18 |
| rameshg87 | thanks lucasagomes :-) | 09:19 |
| *** Haomeng has joined #openstack-ironic | 09:21 | |
| *** pelix has joined #openstack-ironic | 09:22 | |
| rameshg87 | yuriyz: hello | 09:22 |
| *** Haomeng|2 has quit IRC | 09:22 | |
| yuriyz | rameshg87 hello | 09:23 |
| rameshg87 | yuriyz: thanks for the review for IloPower | 09:23 |
| rameshg87 | yuriyz: just saw your comment "I plan also test with hardware." | 09:23 |
| rameshg87 | yuriyz: wondering if you already have hp proliant machines :-) | 09:23 |
| yuriyz | I will get access to ILO server on next week | 09:24 |
| rameshg87 | yuriyz: ah okay. | 09:24 |
| rameshg87 | yuriyz: which model is it ? we test on proliant gen 8 server which has ilo 4 | 09:24 |
| yuriyz | I dont know now | 09:25 |
| rameshg87 | yuriyz: okay. :-) | 09:25 |
| *** martyntaylor has joined #openstack-ironic | 09:28 | |
| *** datajerk has joined #openstack-ironic | 09:43 | |
| *** Dafna_away is now known as Dafna | 09:50 | |
| *** Haomeng|2 has joined #openstack-ironic | 09:59 | |
| *** Haomeng has quit IRC | 10:00 | |
| *** Alexei_9871 has joined #openstack-ironic | 10:07 | |
| openstackgerrit | A change was merged to openstack/ironic: Add methods to ipmitool driver https://review.openstack.org/100364 | 10:08 |
| *** jcoufal has quit IRC | 10:10 | |
| *** jcoufal has joined #openstack-ironic | 10:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/106569 | 10:37 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/88722 | 10:37 |
| derekh_ | I'm seeing a few tripleo/ironic CI failures with : 2014-07-18 09:00:46.577 | OUTPUT=SSH connection cannot be established: Failed to establish SSH connection to host 192.168.1.154. (HTTP 400) | 10:41 |
| derekh_ | http://logs.openstack.org/42/99242/11/check-tripleo/check-tripleo-ironic-undercloud-precise/796b48b/console.html | 10:42 |
| derekh_ | Are these because of bug 1321787 | 10:42 |
| derekh_ | and if so any idea when the newer version of eventlet will be out | 10:42 |
| lucasagomes | derekh_, anyway we can see the logs of the ir-cond? I think there u can figure out if u hit that paramiko problem | 10:48 |
| lucasagomes | the error is vague it could also be some problem with the ssh key (tho very unlike) | 10:49 |
| derekh_ | lucasagomes: yup, here http://logs.openstack.org/42/99242/11/check-tripleo/check-tripleo-ironic-undercloud-precise/796b48b/logs/seed_logs/ | 10:50 |
| *** martyntaylor has quit IRC | 10:50 | |
| derekh_ | lucasagomes: it doesn't contain the traceback in the bug but I thought this may be a different manifestation of the same bug | 10:50 |
| lucasagomes | yeah :( | 10:50 |
| lucasagomes | it doesn't seem to be in debug mode as well | 10:51 |
| lucasagomes | this eventlet problem is a bit broad, I know there was one guy looking at it | 10:51 |
| lucasagomes | but if there's no new release fixing it soon we may want to work that around in the ironic code | 10:52 |
| lucasagomes | by adding some locks between the ssh calls | 10:52 |
| derekh_ | lucasagomes: ok, thanks | 10:58 |
| *** martyntaylor has joined #openstack-ironic | 11:03 | |
| *** nosnos has quit IRC | 11:03 | |
| *** ramineni has quit IRC | 11:04 | |
| *** Haomeng has joined #openstack-ironic | 11:10 | |
| *** Haomeng|2 has quit IRC | 11:11 | |
| *** Haomeng|2 has joined #openstack-ironic | 11:15 | |
| yuriyz | rameshg87: I got the server today, ilo power driver tested | 11:16 |
| rameshg87 | yuriyz: great :-) | 11:16 |
| rameshg87 | yuriyz: which model is it ? | 11:16 |
| *** Haomeng has quit IRC | 11:16 | |
| yuriyz | ProLiant ML110 G7 iLO 3 Advanced | 11:17 |
| *** Poornima has quit IRC | 11:17 | |
| * dtantsur is back | 11:17 | |
| rameshg87 | yuriyz: okay | 11:18 |
| *** martyntaylor has left #openstack-ironic | 11:31 | |
| *** romcheg has joined #openstack-ironic | 11:40 | |
| rameshg87 | dtantsur: are you back, have some time for a query | 11:40 |
| dtantsur | rameshg87, sure | 11:41 |
| rameshg87 | dtantsur: okay | 11:41 |
| rameshg87 | dtantsur: regarding this comment, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L267-L270 | 11:41 |
| rameshg87 | dtantsur: i hope it was put by you :-) | 11:41 |
| rameshg87 | dtantsur: even i would like to move this method to image_cache which seems its appropriate place | 11:42 |
| dtantsur | rameshg87, yes, the comment does not lie :) | 11:42 |
| rameshg87 | dtantsur: okay, can't we do it this way: | 11:42 |
| dtantsur | rameshg87, my problem is: how are you going to assure, that Instance cache is cleared before TFTP cache? | 11:42 |
| rameshg87 | dtantsur: python provides __sub_classes__() for a class to find out what are its subclasses | 11:42 |
| rameshg87 | dtantsur: oh that is a problem .. | 11:43 |
| rameshg87 | dtantsur: so had you previously considered getting all the subclasses and then examining them | 11:43 |
| dtantsur | rameshg87, my main point is that it makes much more sense to clear instance cache, as it's large and instances are free to cleaning after deploy, not after tear_down | 11:43 |
| rameshg87 | dtantsur: we can find out all the subclasses of ImageCache using ImageCache.__sub_classes() | 11:44 |
| rameshg87 | dtantsur: why don't have a property in InstanceImageCache and TFTPImageCache | 11:44 |
| rameshg87 | dtantsur: say for InstanceImageCache, we have use_for_global_cleanup = 1 | 11:45 |
| rameshg87 | dtantsur: say for TFTPImageCache, we have use_for_global_cleanup = 2 | 11:45 |
| rameshg87 | dtantsur: and we figure out all subclasses and sort them | 11:45 |
| dtantsur | rameshg87, that may work... a bit too implicit for me though... Anyway, that will require a spec. Wanting to come up with one? | 11:45 |
| dtantsur | I will be glad to discuss it | 11:46 |
| rameshg87 | dtantsur: so that without hardcoding the inherited classes in the method, we can have an ordered list of classes .. | 11:46 |
| rameshg87 | dtantsur: okay .. | 11:46 |
| rameshg87 | dtantsur: i can come up with one .. | 11:46 |
| rameshg87 | dtantsur: i hope new specs won't be freezed :-) | 11:46 |
| dtantsur | rameshg87, freeze is on 24th, IIRC | 11:46 |
| dtantsur | or 25th | 11:47 |
| *** lucasagomes is now known as lucas-hungry | 11:47 | |
| dtantsur | in ~ a week | 11:47 |
| rameshg87 | dtantsur: okay .. | 11:47 |
| rameshg87 | dtantsur: i can do it today itself ... | 11:47 |
| rameshg87 | dtantsur: thanks .. | 11:47 |
| *** bmahalakshmi has quit IRC | 11:48 | |
| openstackgerrit | Imre Farkas proposed a change to openstack/ironic-specs: DRAC vendor passthru for RAID management https://review.openstack.org/107981 | 11:54 |
| openstackgerrit | Imre Farkas proposed a change to openstack/ironic-specs: DRAC vendor passthru for RAID management https://review.openstack.org/107981 | 11:55 |
| *** ramineni has joined #openstack-ironic | 11:58 | |
| *** jdob has joined #openstack-ironic | 12:04 | |
| *** vinbs has quit IRC | 12:12 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic-specs: Refactor cleanup image cache in pxe driver https://review.openstack.org/107996 | 12:41 |
| rameshg87 | dtantsur: i have raised a review to do the refactor that we discussed a while back | 12:42 |
| rameshg87 | dtantsur: https://review.openstack.org/#/c/107996/1/specs/juno/refactor_cleanup_image_cache.rst | 12:42 |
| rameshg87 | dtantsur: please have a look at it when you have some time | 12:42 |
| openstackgerrit | A change was merged to openstack/ironic: Add IloDriver and its IloPower module https://review.openstack.org/89500 | 12:42 |
| dtantsur | rameshg87, btw ^^^ | 12:42 |
| dtantsur | :) | 12:42 |
| rameshg87 | dtantsur: :-) | 12:43 |
| dtantsur | rameshg87, re new spec, please make commit message a bit more specific, just "refactor" is too vague. Will give it more attention a bit later... | 12:43 |
| dtantsur | Folks, anyone to approve https://review.openstack.org/#/c/102506/ ? Already has 2x +2! | 12:44 |
| rameshg87 | dtantsur: okay, will do that .. | 12:50 |
| NobodyCam | lifeless: Re: buggy deallocate what did you find | 12:53 |
| *** d0ugal has quit IRC | 12:53 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic-specs: Move code to cleanup ImageCache to a common place https://review.openstack.org/107996 | 12:54 |
| NobodyCam | good morning Ironic | 12:54 |
| *** d0ugal has joined #openstack-ironic | 12:56 | |
| *** lucas-hungry is now known as lucasagomes | 12:58 | |
| *** dguerri has quit IRC | 13:01 | |
| *** jbjohnso_ has joined #openstack-ironic | 13:02 | |
| *** dguerri has joined #openstack-ironic | 13:02 | |
| *** datajerk has quit IRC | 13:06 | |
| *** matty_dubs|gone is now known as matty_dubs | 13:09 | |
| *** jbjohnso_ has quit IRC | 13:11 | |
| dtantsur | btw, started working on some bug dashboard, as discussed on recent meetings. early WIP: https://github.com/Divius/ironic-bug-dashboard | 13:14 |
| *** pcrews has joined #openstack-ironic | 13:14 | |
| dtantsur | oh, and good morning, NobodyCam! | 13:14 |
| dtantsur | I would say that Launchpad API is much better than their UI :D | 13:15 |
| *** datajerk has joined #openstack-ironic | 13:16 | |
| NobodyCam | good mornign dtantsur & lucasagomes ...TGIF | 13:16 |
| dtantsur | oh, yes, TGIF! | 13:16 |
| Shrews | Hello, Friday. So happy to see you again. | 13:22 |
| NobodyCam | morning Shrews | 13:23 |
| Shrews | NobodyCam: hi-dee ho! | 13:24 |
| NobodyCam | :) | 13:30 |
| *** igordcard has joined #openstack-ironic | 13:31 | |
| NobodyCam | jroll: you get teh best gerit errors: http://logs.openstack.org/15/107715/1/check-tripleo/check-tripleo-ironic-undercloud-precise/e772513/console.html#_2014-07-17_14_47_32_735 | 13:46 |
| *** k4n0 has quit IRC | 13:47 | |
| jroll | NobodyCam: lolwtf | 13:47 |
| jroll | mornin everybody, tgif indeed | 13:47 |
| Shrews | jroll: morning | 13:52 |
| *** shausy has quit IRC | 13:53 | |
| *** comstud is now known as bearhands | 13:54 | |
| NobodyCam | good morning jroll | 13:54 |
| dtantsur | Shrews, jroll, morning :) | 14:00 |
| jroll | goood morning | 14:00 |
| Shrews | morning dtantsur | 14:00 |
| *** bowdeng_hp has quit IRC | 14:02 | |
| Shrews | so, this little guy is working next to me this morning: http://imgur.com/XG8yVSD | 14:10 |
| lucasagomes | NobodyCam, morning!!! TGIF! sorry for the late reply | 14:13 |
| NobodyCam | ahhh... oh Shrews still have that ping pong table? | 14:13 |
| NobodyCam | lucasagomes: NP :) goood afternoon to you:) | 14:13 |
| Shrews | NobodyCam: lol | 14:13 |
| NobodyCam | :) | 14:14 |
| *** bvivek has quit IRC | 14:16 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add missing docstrings https://review.openstack.org/106202 | 14:20 |
| *** Mikhail_D_ltp has quit IRC | 14:21 | |
| *** jgrimm has joined #openstack-ironic | 14:22 | |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/python-ironicclient: Add ironic cli support for vendor-passthru https://review.openstack.org/101297 | 14:23 |
| rameshg87 | folks request you to have a look at ilo virtual media deploy driver spec which has been refactored as per discussion yesterday: https://review.openstack.org/97744 | 14:24 |
| rameshg87 | devananda: this code for this blueprint has been submitted, this may be marked as complete now https://blueprints.launchpad.net/ironic/+spec/ironic-ilo-power-driver | 14:25 |
| *** annegentle is now known as notsogentle | 14:27 | |
| dtantsur | https://review.openstack.org/#/c/102506/ 3x +2 :) anyone mind just approving? | 14:28 |
| *** hemna has joined #openstack-ironic | 14:28 | |
| * jroll looks | 14:28 | |
| jroll | dtantsur: the InstanceAssociated error here: https://review.openstack.org/#/c/102506/8/ironic/db/sqlalchemy/api.py | 14:30 |
| jroll | (the first exception) | 14:30 |
| jroll | can you create a node with an instance_uuid? | 14:30 |
| jroll | seems like that would never hit | 14:30 |
| *** hemna has quit IRC | 14:30 | |
| dtantsur | jroll, from the code perspective - you can, though I can't imagine it :) I guess it was requested by some of reviewers for the sake of correctness | 14:31 |
| NobodyCam | lgtm | 14:31 |
| jroll | huh. | 14:31 |
| dtantsur | (raising NodeAlreadyExists would be clearly wrong here) | 14:31 |
| dtantsur | NobodyCam, thanks | 14:32 |
| jroll | and I thought we didn't allow setting the uuid | 14:32 |
| jroll | IMBW | 14:32 |
| jroll | anyway, too late now | 14:33 |
| NobodyCam | hehehe | 14:33 |
| dtantsur | jroll, via API - does not. It's again for the sake of internal correctness of DB API (read: good encapsulation :) | 14:34 |
| jroll | dtantsur: sure. but then how does any of this help with the linked bug? :) | 14:35 |
| dtantsur | jroll, some of it helps and then I was asked to make it consistent :) | 14:35 |
| dtantsur | (actual fix is 1 or 2 places, IIRC) | 14:36 |
| *** bmahalakshmi has joined #openstack-ironic | 14:36 | |
| jroll | ok | 14:36 |
| *** bmahalakshmi has quit IRC | 14:37 | |
| *** bmahalakshmi has joined #openstack-ironic | 14:37 | |
| *** jistr has quit IRC | 14:38 | |
| NobodyCam | lol jroll I think I found another bug to recehck that client patch on | 14:48 |
| NobodyCam | s/on/with/ | 14:48 |
| jroll | oh? | 14:48 |
| jroll | I filed one | 14:48 |
| NobodyCam | yea | 14:48 |
| NobodyCam | going thru the logs | 14:48 |
| NobodyCam | http://logs.openstack.org/15/107715/1/check-tripleo/check-tripleo-ironic-undercloud-precise/e772513/logs/seed_logs/neutron-dhcp-agent.txt.gz | 14:49 |
| NobodyCam | but goot to have the bug you files too.. | 14:50 |
| NobodyCam | I think it is real | 14:50 |
| jroll | oh good, neutron failed | 14:50 |
| jroll | I'm shocked | 14:50 |
| NobodyCam | lol | 14:50 |
| * jroll brb | 14:50 | |
| *** athomas has quit IRC | 14:52 | |
| *** mdorman has joined #openstack-ironic | 14:54 | |
| *** athomas has joined #openstack-ironic | 14:57 | |
| *** jcoufal has quit IRC | 14:58 | |
| NobodyCam | brb | 15:01 |
| *** foexle has quit IRC | 15:04 | |
| *** igordcard has quit IRC | 15:16 | |
| *** ifarkas has quit IRC | 15:17 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Ignore RAID devices for erase_devices https://review.openstack.org/108040 | 15:18 |
| *** igordcard has joined #openstack-ironic | 15:28 | |
| NobodyCam | and brb again | 15:31 |
| devananda | viktors|afk: ping | 15:35 |
| devananda | morning, all | 15:35 |
| viktors|afk | devananda: hi | 15:35 |
| dtantsur | devananda, morning | 15:35 |
| *** viktors|afk is now known as viktors | 15:35 | |
| jroll | morning devananda | 15:35 |
| devananda | viktors: hi! when testing 107053 locally, i keep hitting | 15:35 |
| devananda | AttributeError: 'MySQLOpportunisticFixture' object has no attribute '_details' | 15:35 |
| devananda | viktors: even after rebuilding venv | 15:36 |
| Shrews | morning devananda | 15:36 |
| devananda | i'm at CLS today and tomorrow, so will be only semi around | 15:36 |
| viktors | devananda: one min please | 15:36 |
| devananda | Shrews, romcheg, adam_g: ya'll should read the email I sent to ML last night about upgrade path and testing | 15:36 |
| devananda | QA team is still in germany afaik, so they may not respond for a few more days | 15:37 |
| Shrews | devananda: i read that. great observation about how we don't fit the suggested test path | 15:37 |
| viktors | devananda: does user `openstack_citest` can create new databases on mysql? | 15:38 |
| devananda | viktors: probably not :) | 15:38 |
| NobodyCam | morning devananda | 15:38 |
| devananda | viktors: if that's the problem, the failure is not helpful | 15:38 |
| devananda | *failure message | 15:38 |
| viktors | devananda: agree, I'll ask someone fron uor team to fix it | 15:39 |
| viktors | *from our | 15:39 |
| openstackgerrit | A change was merged to openstack/ironic: Raise appropriate errors on duplicate Node, Port and Chassis creation https://review.openstack.org/102506 | 15:40 |
| devananda | viktors: yea, that fixes it | 15:40 |
| devananda | viktors: so why did this not test with sqlite? | 15:40 |
| viktors | devananda: cool :) | 15:40 |
| viktors | devananda: we can try to do it, but Alembic have very limited support of SQLite, unfortunately, so I have a doubt, that migration tests will pass | 15:42 |
| devananda | viktors: is that limitation documented within oslo.db? I think it may come as a surprise to many projects | 15:43 |
| devananda | viktors: which are accustomed to using sqlite | 15:43 |
| devananda | viktors: also, this does not appear to have actualy tested migrations! :( | 15:44 |
| devananda | viktors: it jsut created and dropped tables, did a few inserts | 15:44 |
| devananda | viktors: it didn't run any of the ALTERs | 15:44 |
| viktors | devananda: let me look | 15:44 |
| devananda | viktors: http://paste.openstack.org/show/0JifhqoQSdEAuOVc5Ujp/ | 15:45 |
| devananda | that is full log from a run of "tox -epy27 test_migrations" | 15:45 |
| devananda | of all SQL queries received by local mysql server | 15:46 |
| devananda | I need to check in to conference now, bbl | 15:46 |
| devananda | viktors: please tell me i'm donig something wrong, cause I'd really like to move to oslo.db and get these fixes in | 15:46 |
| viktors | devananda: do you tested it with the oslo code? I supposed to see "ALTER TABLE " at migration 3cb628139ea4 for example | 15:47 |
| devananda | I am testing with commit ffd83dc3af170608a867ed1721a90747e67d2934 | 15:48 |
| devananda | that's your opportunistic fixes on top of the oslo.db patch | 15:48 |
| devananda | ok, really afk now | 15:49 |
| viktors | devananda: ok, I'll check it | 15:49 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic-specs: Move code to cleanup ImageCache to a common place https://review.openstack.org/107996 | 15:51 |
| *** rameshg87 has quit IRC | 15:53 | |
| *** wanyen has quit IRC | 15:55 | |
| dtantsur | going now, have a nice weekend :) | 15:58 |
| *** dtantsur is now known as dtantsur|afk | 15:59 | |
| NobodyCam | have a good weekend dtantsur|afk | 15:59 |
| *** matty_dubs is now known as matty_dubs|lunch | 16:01 | |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Fix leaking DB details to API on error https://review.openstack.org/73121 | 16:01 |
| NobodyCam | brb | 16:03 |
| lucasagomes | morning devananda | 16:04 |
| viktors | devananda: please look, hen you'll be around - http://paste.openstack.org/show/87149/ | 16:04 |
| *** rakesh_hs has quit IRC | 16:05 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Expose {set,get}_boot_device in the API https://review.openstack.org/90151 | 16:06 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SSH virsh to use the new ManagementInterface https://review.openstack.org/89884 | 16:06 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMITool to use the new ManagementInterface https://review.openstack.org/86092 | 16:06 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SeaMicro to use the new ManagementInterface https://review.openstack.org/86328 | 16:06 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface https://review.openstack.org/86588 | 16:06 |
| *** chuckC has quit IRC | 16:06 | |
| *** ramineni has quit IRC | 16:10 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Expose {set,get}_boot_device in the API https://review.openstack.org/90151 | 16:16 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SSH virsh to use the new ManagementInterface https://review.openstack.org/89884 | 16:16 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMITool to use the new ManagementInterface https://review.openstack.org/86092 | 16:16 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SeaMicro to use the new ManagementInterface https://review.openstack.org/86328 | 16:16 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface https://review.openstack.org/86588 | 16:16 |
| *** Poornima has joined #openstack-ironic | 16:16 | |
| viktors | devananda: see also http://www.sqlite.org/omitted.html and http://paste.openstack.org/show/87150/ | 16:20 |
| *** rainya has joined #openstack-ironic | 16:25 | |
| *** ramineni has joined #openstack-ironic | 16:32 | |
| *** romcheg1 has joined #openstack-ironic | 16:44 | |
| *** romcheg1 has left #openstack-ironic | 16:44 | |
| *** lazy_prince is now known as killer_prince | 16:44 | |
| *** max_lobur has joined #openstack-ironic | 16:46 | |
| *** matty_dubs|lunch is now known as matty_dubs | 16:53 | |
| *** ramineni has quit IRC | 16:55 | |
| *** viktors is now known as viktors|afk | 17:03 | |
| *** chuckC has joined #openstack-ironic | 17:06 | |
| *** Alexei_9871 has quit IRC | 17:07 | |
| *** malini1 has joined #openstack-ironic | 17:09 | |
| *** derekh_ is now known as derekh_afk | 17:10 | |
| lucasagomes | aight folks I will call it a day | 17:10 |
| lucasagomes | have a great weekend everybody! | 17:10 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Drivers determine acceptable power states https://review.openstack.org/86744 | 17:11 |
| *** lucasagomes is now known as lucas-beer | 17:11 | |
| Shrews | have a good weekend lucas-beer | 17:12 |
| jroll | later lucas-beer (lol) | 17:13 |
| devananda | viktors|afk: I can reproduce your result and see the ALTERs in the testrepository log | 17:14 |
| devananda | viktors|afk: howver I still don't see it in MySQL's log | 17:14 |
| *** ndipanov has quit IRC | 17:20 | |
| devananda | viktors|afk: whereas if I run an ALTER myself, I see it in the log. So I don't understand why the migration ALTERs aren't showing up | 17:21 |
| openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties at node-create/node-update https://review.openstack.org/100951 | 17:23 |
| *** Nisha has joined #openstack-ironic | 17:24 | |
| *** harlowja_away is now known as harlowja | 17:25 | |
| *** jdob_ has joined #openstack-ironic | 17:31 | |
| *** jdob has quit IRC | 17:31 | |
| *** bmahalakshmi has quit IRC | 17:41 | |
| *** viktors has joined #openstack-ironic | 17:43 | |
| *** Mikhail_D_ltp has joined #openstack-ironic | 17:43 | |
| viktors | devananda: how did you set logging for mysql? | 17:44 |
| viktors | devananda: anyway, I believe, that migration https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/alembic/versions/3bea56f25597_add_unique_constraint_to_instance_uuid.py will generate ALTER | 17:46 |
| openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties at node-create/node-update https://review.openstack.org/100951 | 17:54 |
| devananda | viktors: set global slow_query_log=ON; set global long_query_time=0; | 17:56 |
| devananda | viktors: i can clearly see the selects, creates, inserts, and drop | 17:56 |
| *** rameshg87 has joined #openstack-ironic | 18:02 | |
| * viktors checking | 18:03 | |
| viktors | devananda: I got no success in your case also - no logs at all | 18:07 |
| viktors | devananda: but I see ALTERS in log after I modified my.conf file | 18:07 |
| rameshg87 | devananda: request your review on the revised ilo deploy driver spec https://review.openstack.org/97744 | 18:10 |
| *** athomas has quit IRC | 18:10 | |
| *** jdob_ is now known as jdob | 18:11 | |
| NobodyCam | br | 18:13 |
| NobodyCam | brb | 18:13 |
| *** viktors has quit IRC | 18:23 | |
| NobodyCam | I need to step afk for a bit.. prob two hours... I will be and ofc I have google with me if I am needed | 18:23 |
| *** jgrimm has quit IRC | 18:23 | |
| *** NobodyCam is now known as Nobodycam_afk | 18:23 | |
| *** mikal has quit IRC | 18:35 | |
| *** mikal has joined #openstack-ironic | 18:36 | |
| *** igordcard has quit IRC | 18:45 | |
| *** romcheg1 has joined #openstack-ironic | 18:47 | |
| *** rameshg87 has left #openstack-ironic | 18:55 | |
| *** Poornima has quit IRC | 18:59 | |
| *** jdob has quit IRC | 19:05 | |
| lifeless | Nobodycam_afk: the very next run I did didn't trigger it | 19:07 |
| lifeless | Nobodycam_afk: but | 19:07 |
| lifeless | Nobodycam_afk: instance['node'] is raising sometimes AFAICT | 19:07 |
| lifeless | Nobodycam_afk: the new code path throws an error and then the instance stalls | 19:07 |
| *** romcheg1 has quit IRC | 19:10 | |
| *** killer_prince has quit IRC | 19:11 | |
| *** faizan has joined #openstack-ironic | 19:18 | |
| *** killer_prince has joined #openstack-ironic | 19:25 | |
| *** killer_prince is now known as lazy_prince | 19:25 | |
| *** Nisha has quit IRC | 19:32 | |
| *** malini1 has quit IRC | 19:36 | |
| *** martyntaylor has joined #openstack-ironic | 19:43 | |
| *** datajerk has quit IRC | 19:55 | |
| *** rwsu has quit IRC | 19:55 | |
| *** zul has quit IRC | 19:55 | |
| *** datajerk has joined #openstack-ironic | 19:55 | |
| *** rwsu has joined #openstack-ironic | 19:55 | |
| *** zul has joined #openstack-ironic | 19:56 | |
| *** eghobo has joined #openstack-ironic | 19:58 | |
| *** romcheg1 has joined #openstack-ironic | 20:04 | |
| *** rwsu has quit IRC | 20:09 | |
| *** faizan has quit IRC | 20:16 | |
| *** rwsu has joined #openstack-ironic | 20:21 | |
| *** malini1 has joined #openstack-ironic | 20:35 | |
| *** pelix has quit IRC | 20:53 | |
| *** romcheg1 has quit IRC | 21:00 | |
| *** martyntaylor has quit IRC | 21:14 | |
| *** chuckC has quit IRC | 21:30 | |
| *** matty_dubs is now known as matty_dubs|gone | 21:40 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Ignore RAID devices for erase_devices https://review.openstack.org/108040 | 21:52 |
| *** chuckC has joined #openstack-ironic | 21:54 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Ignore RAID devices for erase_devices https://review.openstack.org/108040 | 21:56 |
| *** Mikhail_D_ltp has quit IRC | 22:08 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Ignore RAID devices for erase_devices https://review.openstack.org/108040 | 22:15 |
| *** wanyen has joined #openstack-ironic | 22:18 | |
| wanyen | Hi, iLO virtual media + iscsi driver spec https://review.openstack.org/#/c/107344/ has been uploaded. This spec reflected the irc discussion yesterday regarding using iLO virtual media driver to replace tftp for PXE driver and uses iscsci to disploy boot image. Please review the spec. Thanks! | 22:23 |
| *** malini1 has quit IRC | 22:29 | |
| *** lucas-beer has quit IRC | 22:40 | |
| *** derekh_afk has quit IRC | 22:41 | |
| *** romcheg1 has joined #openstack-ironic | 22:45 | |
| *** mdorman has quit IRC | 22:45 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Improve Disk Detection https://review.openstack.org/108040 | 22:50 |
| openstackgerrit | A change was merged to openstack/ironic: Add missing docstrings https://review.openstack.org/106202 | 22:53 |
| wanyen | s/disploy/deploy | 23:02 |
| *** malini1 has joined #openstack-ironic | 23:05 | |
| *** faizan has joined #openstack-ironic | 23:18 | |
| *** stevebaker has quit IRC | 23:21 | |
| *** stevebaker has joined #openstack-ironic | 23:21 | |
| *** max_lobur has quit IRC | 23:21 | |
| *** stevebaker has quit IRC | 23:26 | |
| *** stevebaker has joined #openstack-ironic | 23:26 | |
| *** Haomeng has joined #openstack-ironic | 23:34 | |
| *** Haomeng|2 has quit IRC | 23:35 | |
| *** faizan has quit IRC | 23:50 | |
| *** stevebaker has quit IRC | 23:51 | |
| *** stevebaker has joined #openstack-ironic | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!