adam_g | jroll, https://review.openstack.org/#/c/99770/ | 00:00 |
---|---|---|
jroll | yeah, I'm looking :) | 00:00 |
jroll | adam_g: quick thing, s/217/207/ on line 177 | 00:00 |
devananda | lifeless, adam_g : this seems like soemthing you guys would have hit by now if it was a thing: https://bugs.launchpad.net/ironic/+bug/1321787 | 00:00 |
adam_g | jrist, derr :) | 00:00 |
*** hemna has quit IRC | 00:01 | |
jroll | I'm just skimming it atm, so I don't want to post a review just for that | 00:01 |
jroll | heh | 00:01 |
adam_g | i need to fix up the formatting anyway in a new patch, so any comments welcome before i get a chacne | 00:01 |
jroll | I have to run but I'll dive deep in the morning :) | 00:02 |
adam_g | devananda, hmm. thats an old issue thats turned up all over. | 00:02 |
NobodyCam | lifeless: fyi, just got a unique error on my last run of check-tripleo-ironic-undercloud-precise for which the patch for landed after the test started ... running another test now. | 00:03 |
devananda | adam_g: we just got this hackish fix posted from some HP folks - https://review.openstack.org/#/c/99626/1 | 00:03 |
adam_g | devananda, i feel like i spent a while last year working thru this, it should be fixed at this point in ubuntu/debian unless im thinking of another bug | 00:03 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: WIP: Serialise paramiko requests https://review.openstack.org/99626 | 00:04 |
* devananda fixed commit message | 00:04 | |
adam_g | https://bugs.launchpad.net/cinder/+bug/1150720 | 00:05 |
adam_g | maybe something different | 00:05 |
devananda | lucas posted a comment on LP saying he hit it yesterday | 00:05 |
russell_h | devananda: FWIW I hit that same bug in paramiko in a neutron plugin | 00:06 |
lifeless | russell_h: paramikobug ? | 00:06 |
*** radsy has quit IRC | 00:07 | |
lifeless | oh the eventlet thing | 00:07 |
* adam_g wonders if its a fedora-specific thing | 00:07 | |
openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Save failed spawn exception in nova driver https://review.openstack.org/99808 | 00:10 |
*** matsuhashi has joined #openstack-ironic | 00:19 | |
NobodyCam | humm should we have landed this: https://review.openstack.org/#/c/88336 | 00:24 |
devananda | NobodyCam: it continues to fail the dependent patch https://review.openstack.org/#/c/89554/1 | 00:26 |
devananda | and I haven't put time into fixing it | 00:26 |
NobodyCam | lol :) | 00:27 |
NobodyCam | was just look at that | 00:27 |
devananda | adam_g: you've been doing stable branch maintenance? | 00:27 |
adam_g | devananda, only a little bit since icehouse | 00:27 |
NobodyCam | how can a conf file fail pep8 | 00:27 |
NobodyCam | ahh check_uptodate.sh: ironic.conf.sample is not up to date. | 00:28 |
devananda | it's just been pointed out to me that I failed to open stable/icehouse :( | 00:28 |
adam_g | devananda, is it too late? since ironic's not part of the integrated icehouse release, we're probably able to maintain our stable branch outside of the regular release schedule | 00:30 |
NobodyCam | i'm looking at 89554 should we be adding Deprecated warnings for keystone to our log? | 00:31 |
NobodyCam | seems wrong | 00:31 |
devananda | adam_g: i don't follow. there's also a jackhammer outside my window. | 00:31 |
NobodyCam | taco's here ...bbl | 00:32 |
devananda | NobodyCam: those conf strings are coming directly from keystoneclient | 00:32 |
adam_g | devananda, theres a defined release schedule for stable releases to the main integrated projects, and the stable-maint team looks after those branches and cuts releases accordingly. ironic wasn't part of the icehouse release and stable-maint is not responsible for pushing tags/tarballs. ironic may be able to still open our branch late and release point releases according as seen fit, albeit without much help from core -infra | 00:33 |
devananda | adam_g: yes | 00:34 |
adam_g | devananda, tho i imagine it might be much more challenging in practice, in terms of keeping CI passing | 00:37 |
*** eguz has joined #openstack-ironic | 00:40 | |
*** eguz has quit IRC | 00:40 | |
*** eghobo has quit IRC | 00:44 | |
NobodyCam | ahh | 00:51 |
NobodyCam | doh | 00:51 |
*** ellenh has quit IRC | 01:01 | |
* devananda packs up and heads out for dinner | 01:07 | |
*** max_lobur1 has quit IRC | 01:16 | |
*** nosnos has joined #openstack-ironic | 01:21 | |
openstackgerrit | lifeless proposed a change to openstack/ironic: Draft a 'pxe_logpower' driver https://review.openstack.org/98950 | 01:22 |
*** lazy_prince has joined #openstack-ironic | 01:28 | |
*** eghobo has joined #openstack-ironic | 01:33 | |
*** rwsu has quit IRC | 01:38 | |
*** rloo has quit IRC | 01:45 | |
*** rloo has joined #openstack-ironic | 01:46 | |
*** eghobo has quit IRC | 01:48 | |
*** eghobo has joined #openstack-ironic | 01:48 | |
*** meylor has joined #openstack-ironic | 01:53 | |
*** meylor has quit IRC | 02:08 | |
*** rloo has quit IRC | 02:17 | |
*** rloo has joined #openstack-ironic | 02:18 | |
*** rloo has quit IRC | 02:19 | |
*** eguz has joined #openstack-ironic | 02:37 | |
*** lazy_prince has quit IRC | 02:40 | |
*** lazy_prince has joined #openstack-ironic | 02:40 | |
*** eghobo has quit IRC | 02:42 | |
*** harlowja is now known as harlowja_away | 02:53 | |
*** meylor has joined #openstack-ironic | 03:01 | |
*** vinbs has joined #openstack-ironic | 03:13 | |
*** vinbs_ has joined #openstack-ironic | 03:14 | |
*** coolsvap is now known as coolsvap|afk | 03:15 | |
*** nosnos has quit IRC | 03:16 | |
*** vinbs has quit IRC | 03:17 | |
*** vinbs_ is now known as vinbs | 03:17 | |
*** Haomeng has joined #openstack-ironic | 03:33 | |
*** lazy_prince has quit IRC | 03:40 | |
*** nosnos has joined #openstack-ironic | 03:52 | |
*** meylor1 has joined #openstack-ironic | 04:00 | |
*** eghobo has joined #openstack-ironic | 04:01 | |
*** meylor has quit IRC | 04:01 | |
*** matsuhas_ has joined #openstack-ironic | 04:03 | |
*** matsuhas_ has quit IRC | 04:04 | |
*** matsuhas_ has joined #openstack-ironic | 04:05 | |
*** matsuhashi has quit IRC | 04:05 | |
*** eghobo has quit IRC | 04:10 | |
*** Poornima has joined #openstack-ironic | 04:10 | |
*** matsuhas_ has quit IRC | 04:12 | |
*** matsuhashi has joined #openstack-ironic | 04:13 | |
*** eghobo has joined #openstack-ironic | 04:31 | |
*** rameshg87 has joined #openstack-ironic | 04:36 | |
*** jcoufal has joined #openstack-ironic | 04:57 | |
*** rakesh_hs has joined #openstack-ironic | 05:03 | |
*** Poornima has quit IRC | 05:03 | |
*** coolsvap|afk is now known as coolsvap | 05:11 | |
*** k4n0 has joined #openstack-ironic | 05:17 | |
*** lazy_prince has joined #openstack-ironic | 05:18 | |
*** krtaylor has joined #openstack-ironic | 05:24 | |
*** coolsvap is now known as coolsvap|afk | 05:25 | |
*** sysexit has joined #openstack-ironic | 05:30 | |
*** coolsvap|afk is now known as coolsvap | 05:33 | |
*** sseago has quit IRC | 05:43 | |
*** loki184 has joined #openstack-ironic | 05:45 | |
*** matsuhashi has quit IRC | 05:52 | |
*** coolsvap is now known as coolsvap|afk | 05:55 | |
openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic-specs: UEFI support for Ironic deploy drivers https://review.openstack.org/99850 | 05:57 |
*** matsuhashi has joined #openstack-ironic | 05:57 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/96063 | 06:01 |
*** coolsvap|afk is now known as coolsvap | 06:03 | |
*** shausy has joined #openstack-ironic | 06:13 | |
*** k4n0 has quit IRC | 06:20 | |
*** k4n0 has joined #openstack-ironic | 06:26 | |
*** Kai14 has joined #openstack-ironic | 06:31 | |
*** k4n0 has quit IRC | 06:33 | |
*** eghobo has quit IRC | 06:38 | |
*** k4n0 has joined #openstack-ironic | 06:42 | |
*** rameshg87 has quit IRC | 06:43 | |
*** k4n0 has quit IRC | 06:50 | |
*** rameshg87 has joined #openstack-ironic | 07:01 | |
*** rameshg87 has left #openstack-ironic | 07:01 | |
*** rameshg87 has joined #openstack-ironic | 07:01 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 07:12 | |
*** ndipanov has joined #openstack-ironic | 07:23 | |
mrda | Have a good weekend Ironic! See you Monday. | 07:25 |
*** mrda is now known as mrda-weekend | 07:25 | |
Haomeng | mrda: nice weekend:) | 07:30 |
*** sysexit has quit IRC | 07:35 | |
*** matsuhas_ has joined #openstack-ironic | 07:36 | |
*** matsuhashi has quit IRC | 07:36 | |
*** Mikhail_D_ltp has left #openstack-ironic | 07:40 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 07:42 | |
*** sysexit has joined #openstack-ironic | 07:46 | |
*** max_lobur has joined #openstack-ironic | 07:48 | |
*** Mikhail_D_ltp has quit IRC | 07:50 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 07:51 | |
*** k4n0 has joined #openstack-ironic | 07:58 | |
*** coolsvap is now known as coolsvap|afk | 08:00 | |
*** sysexit has quit IRC | 08:01 | |
*** Mikhail_D_ltp has quit IRC | 08:01 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 08:03 | |
*** coolsvap|afk is now known as coolsvap | 08:09 | |
*** derekh_ has joined #openstack-ironic | 08:17 | |
*** k4n0 has quit IRC | 08:20 | |
*** petertoft has joined #openstack-ironic | 08:22 | |
*** shausy has quit IRC | 08:24 | |
*** k4n0 has joined #openstack-ironic | 08:26 | |
*** lucasagomes has joined #openstack-ironic | 08:27 | |
*** sysexit has joined #openstack-ironic | 08:41 | |
*** Mikhail_D_ltp has quit IRC | 08:41 | |
*** pelix has joined #openstack-ironic | 08:44 | |
*** martyntaylor has joined #openstack-ironic | 08:44 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 08:45 | |
*** petertoft has quit IRC | 08:45 | |
*** romcheg has joined #openstack-ironic | 08:46 | |
*** Mikhail_D_ltp has quit IRC | 08:46 | |
*** k4n0 has quit IRC | 08:46 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 08:46 | |
*** petertoft has joined #openstack-ironic | 08:48 | |
*** matsuhas_ has quit IRC | 08:57 | |
openstackgerrit | Imre Farkas proposed a change to openstack/ironic: Fix workaround for the "device is busy" problem https://review.openstack.org/90126 | 08:58 |
*** petertoft has quit IRC | 08:59 | |
*** petertoft has joined #openstack-ironic | 09:00 | |
*** matsuhashi has joined #openstack-ironic | 09:12 | |
*** igordcard has joined #openstack-ironic | 09:17 | |
*** k4n0 has joined #openstack-ironic | 09:17 | |
*** nikunj2512 has joined #openstack-ironic | 09:19 | |
*** mkerrin has quit IRC | 09:26 | |
*** mkerrin has joined #openstack-ironic | 09:33 | |
*** matsuhashi has quit IRC | 09:43 | |
*** lazy_prince has quit IRC | 10:06 | |
*** nosnos has quit IRC | 10:26 | |
openstackgerrit | Sirushti Murugesan proposed a change to openstack/ironic-specs: Whole Disk Image Support https://review.openstack.org/97150 | 10:26 |
*** shausy has joined #openstack-ironic | 10:27 | |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Check whether specified FS is supported https://review.openstack.org/98102 | 10:32 |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Sync processutils from oslo code https://review.openstack.org/98342 | 10:32 |
*** nosnos has joined #openstack-ironic | 10:34 | |
*** k4n0 has quit IRC | 10:36 | |
*** coolsvap is now known as coolsvap|afk | 10:37 | |
*** nosnos has quit IRC | 10:39 | |
*** sseago has joined #openstack-ironic | 10:55 | |
*** poornima has joined #openstack-ironic | 11:08 | |
openstackgerrit | Sirushti Murugesan proposed a change to openstack/ironic-specs: Whole Disk Image Support https://review.openstack.org/97150 | 11:15 |
*** loki184 has quit IRC | 11:18 | |
openstackgerrit | jan grant proposed a change to openstack/ironic: WIP: Serialise paramiko requests. https://review.openstack.org/99626 | 11:24 |
*** poornima has quit IRC | 11:25 | |
*** viktors|afk is now known as viktors | 11:26 | |
*** rameshg87 has left #openstack-ironic | 11:29 | |
openstackgerrit | Mahalakshmi Balakrishnan proposed a change to openstack/ironic: Testing please ignore https://review.openstack.org/99911 | 11:37 |
*** lucasagomes is now known as lucas-hungry | 11:41 | |
*** Poornima has joined #openstack-ironic | 11:42 | |
*** foexle has joined #openstack-ironic | 11:53 | |
openstackgerrit | Imre Farkas proposed a change to openstack/ironic: Fix workaround for the "device is busy" problem https://review.openstack.org/90126 | 11:57 |
*** linggao has joined #openstack-ironic | 12:05 | |
openstackgerrit | Imre Farkas proposed a change to openstack/ironic-specs: More robust device status checking with fuser https://review.openstack.org/99605 | 12:09 |
*** vinbs_ has joined #openstack-ironic | 12:10 | |
*** vinbs has quit IRC | 12:11 | |
*** vinbs_ is now known as vinbs | 12:11 | |
openstackgerrit | A change was merged to openstack/ironic: Sync processutils from oslo code https://review.openstack.org/98342 | 12:17 |
*** vinbs_ has joined #openstack-ironic | 12:17 | |
*** nikunj2512 has quit IRC | 12:17 | |
*** vinbs has quit IRC | 12:19 | |
*** jdob has joined #openstack-ironic | 12:21 | |
*** vinbs_ has quit IRC | 12:21 | |
*** shausy has quit IRC | 12:27 | |
*** foexle has quit IRC | 12:32 | |
*** lucas-hungry is now known as lucasagomes | 12:43 | |
*** Poornima has quit IRC | 12:46 | |
openstackgerrit | Imre Farkas proposed a change to openstack/ironic-specs: DRAC power driver https://review.openstack.org/99352 | 12:52 |
*** vinbs has joined #openstack-ironic | 12:55 | |
*** vinbs has quit IRC | 12:59 | |
*** vinbs has joined #openstack-ironic | 13:06 | |
openstackgerrit | Phil Day proposed a change to openstack/ironic: Add clean shutdown parameters to power_off() https://review.openstack.org/99932 | 13:08 |
openstackgerrit | Imre Farkas proposed a change to openstack/ironic-specs: More robust device status checking with fuser https://review.openstack.org/99605 | 13:08 |
*** vinbs has quit IRC | 13:11 | |
*** vinbs has joined #openstack-ironic | 13:17 | |
NobodyCam | good morning iRonic ... TGIF!!!!! and its leaking water from the sky this morning | 13:19 |
romcheg | Morning NobodyCam! | 13:20 |
*** jdob has quit IRC | 13:20 | |
*** jdob has joined #openstack-ironic | 13:20 | |
NobodyCam | morning romcheg :) | 13:21 |
*** matty_dubs|gone is now known as matty_dubs | 13:23 | |
*** foexle has joined #openstack-ironic | 13:23 | |
NobodyCam | morning matty_dubs | 13:24 |
matty_dubs | Morning NobodyCam! | 13:25 |
NobodyCam | romcheg: russia is moving lots of military equipment in to UKraine... that is not a good sign | 13:25 |
*** blamar has quit IRC | 13:26 | |
matty_dubs | Yeah, that's scary :-\ | 13:27 |
*** reaper has quit IRC | 13:28 | |
NobodyCam | matty_dubs: you read http://inforesist.org/en/ ??? | 13:29 |
* matty_dubs hadn't seen that before; looks now | 13:29 | |
*** sysexit has quit IRC | 13:30 | |
matty_dubs | Just when it seemed like things were settling down, too. | 13:30 |
*** ndipanov has quit IRC | 13:33 | |
*** jdob has quit IRC | 13:34 | |
*** jdob has joined #openstack-ironic | 13:34 | |
openstackgerrit | Jarrod Johnson proposed a change to stackforge/pyghmi: Fix concurrent raw_command calls to Session https://review.openstack.org/99939 | 13:38 |
openstackgerrit | Jarrod Johnson proposed a change to stackforge/pyghmi: Fix concurrent raw_command calls to Session https://review.openstack.org/99939 | 13:39 |
romcheg | Morning matty_dubs | 13:45 |
romcheg | Don't worry guys, we're trying to finish that asap | 13:45 |
openstackgerrit | A change was merged to stackforge/pyghmi: Fix concurrent raw_command calls to Session https://review.openstack.org/99939 | 13:46 |
NobodyCam | :) | 13:46 |
romcheg | Thank you for your interest | 13:46 |
lucasagomes | morning all | 13:46 |
NobodyCam | morning lucasagomes :) | 13:46 |
*** jistr has joined #openstack-ironic | 13:51 | |
*** romcheg has quit IRC | 13:55 | |
*** vinbs has quit IRC | 13:57 | |
*** jistr has quit IRC | 14:06 | |
*** jistr has joined #openstack-ironic | 14:07 | |
*** jcoufal has quit IRC | 14:08 | |
*** lucasagomes has left #openstack-ironic | 14:08 | |
*** lucasagomes has joined #openstack-ironic | 14:08 | |
NobodyCam | Shrews: you around? | 14:09 |
*** blamar has joined #openstack-ironic | 14:11 | |
*** Kai14 has quit IRC | 14:11 | |
jroll | morning ironic | 14:16 |
jroll | ifarkas: around? | 14:16 |
NobodyCam | morning jroll :) | 14:17 |
jroll | ifarkas: I'd really love to see third-party testing on the drac driver :/ | 14:17 |
jroll | NobodyCam: morning :) | 14:17 |
jroll | NobodyCam: I've been almost two weeks without a toaster, I've never wanted a bagel so bad as I do right now :P | 14:18 |
NobodyCam | lol... I can offer you one of mine... but I'd have to snail mail it... night not bee that fresh | 14:19 |
matty_dubs | I thought you were offering to mail him one of your toasters | 14:20 |
jroll | lol | 14:20 |
NobodyCam | lol... hummm I only have one of those | 14:20 |
ifarkas | jroll, hi, yep, I'm here | 14:21 |
jroll | ifarkas: hi! would it be possible at all to do third-party tests for the drac driver? | 14:21 |
*** ndipanov has joined #openstack-ironic | 14:22 | |
ifarkas | jroll, there was a discussion on the mailing list about drivers that will not be third-party tested, so I though that it will go to a separate directory | 14:22 |
ifarkas | jroll, unfortunately I just have one server for dev but that's not enough for a testing infrastructure | 14:23 |
ifarkas | jroll, or do you have any idea how to solve this issue? | 14:23 |
*** reaper has joined #openstack-ironic | 14:24 | |
jroll | ifarkas: hmm, maybe you could mention something about how it will be third-party tested once we figure that out? idk. | 14:24 |
jroll | ifarkas: also, I think red hat may have a server or three :) | 14:24 |
NobodyCam | I suspect there is a department in dell that would lend a server to you if you told them I'm testnig openstack | 14:25 |
jroll | ^^ | 14:25 |
ifarkas | hmm | 14:25 |
jroll | but you'd also need a control plane | 14:25 |
ifarkas | that's not a bad idea... | 14:25 |
jroll | and only having one server would make for an awfully slow queue :) | 14:26 |
* jroll wonders if there are standalone drac devices for devel | 14:26 | |
jroll | scratch that, you'd probably want to run full tempest | 14:26 |
matty_dubs | Well the other thing is how this will scale | 14:26 |
ifarkas | jroll, yeah, the queue would be terrible | 14:26 |
matty_dubs | DRAC is one thing, but what if we also write IBM/Sun/Seamicro/whatever drivers? | 14:27 |
matty_dubs | I think it makes sense to at least start off with some 'test hardware not yet available' drivers | 14:27 |
ifarkas | jroll, do you know an estimate how many machines are required for a proper testing infra? | 14:27 |
jroll | ifarkas: probably 2 would be enough - one runs devstack/tempest, the other is your baremetal node that is being managed by ironic | 14:28 |
*** romcheg has joined #openstack-ironic | 14:28 | |
jroll | and devstack/tempest could just be a VM, even | 14:28 |
jroll | matty_dubs: right, that's totally fine, but I'd love to see third-party testing *eventually* | 14:28 |
NobodyCam | matty_dubs: thats the way guilt the mfg's in to providing the hardware | 14:29 |
matty_dubs | Sure | 14:29 |
matty_dubs | Haha | 14:29 |
jroll | ifarkas: I guess for now, I'd just like to see a note about it in the spec. even if that note is just "we would like to do third-party CI for this driver, but do not have sufficient hardware available at this time" | 14:29 |
*** ndipanov is now known as ndipanoff | 14:30 | |
ifarkas | jroll, fair enough. I will update it | 14:30 |
matty_dubs | So, my interest in this -- Red Hat has interest in writing an Ironic driver for the baremetal portion of NetApp filers. | 14:30 |
matty_dubs | They're definitely not going to give us a rack of NetApps to test on. | 14:30 |
jroll | ifarkas: thanks :) | 14:31 |
matty_dubs | So I want to find a good way to have some stuff available where dedicated test hardware isn't available. | 14:31 |
*** sysexit has joined #openstack-ironic | 14:31 | |
ifarkas | jroll, np ;-) | 14:32 |
jroll | added it in the review :) | 14:32 |
jroll | matty_dubs: that's... disappointing | 14:32 |
jroll | (disclaimer, I have no idea what a netapp is) | 14:32 |
matty_dubs | High-end SAN/NAS appliances | 14:33 |
jroll | oooo | 14:34 |
ifarkas | jroll, btw, what do you think about creating the separate driver class for each deploy driver as you proposed, but later in the deploy driver spec? | 14:34 |
matty_dubs | Not exactly a core thing everyone's going to wan to run, but some of our customers are interested in that. (Obviously the SAN/NAS functions don't belong in Ironic, but it's fundamentally a computer under the hood, so we can do power control, etc. for provisioning) | 14:35 |
jroll | ifarkas: well, today we combine each driver with the PXE driver to make a "full" driver | 14:36 |
jroll | ifarkas: like, people should be able to use the pxe driver and the fake driver alongside the drac power driver | 14:36 |
jroll | matty_dubs: right, software-defined datacenter :) | 14:36 |
NobodyCam | Mikhail_D_ltp: you around? | 14:37 |
ifarkas | jroll, the management interface is still missing, so pxe might not work if the boot device is not set network | 14:37 |
jroll | ifarkas: mmm, true. I forgot about the management interface :/ | 14:38 |
openstackgerrit | Imre Farkas proposed a change to openstack/ironic-specs: DRAC power driver https://review.openstack.org/99352 | 14:43 |
ifarkas | jroll ^ ;-) | 14:44 |
jroll | thanks :) | 14:48 |
*** blamar has quit IRC | 14:48 | |
Mikhail_D_ltp | NobodyCam: Hi! :) I still here :) | 14:53 |
NobodyCam | hey hey Mikhail_D_ltp | 14:54 |
NobodyCam | want to rebase https://review.openstack.org/#/c/66793 :-p | 14:54 |
NobodyCam | maybe we could even land it | 14:54 |
*** mdorman has joined #openstack-ironic | 14:55 | |
Mikhail_D_ltp | NobodyCam: Ok I'll rebase it tomorrow morning | 14:57 |
NobodyCam | :) tomorrow that saturday for you or sunday :-p | 14:57 |
Mikhail_D_ltp | saturday :) But it's no problem for me rebase it tomorrow))))) | 15:00 |
NobodyCam | :) hehehe Sweet ... | 15:00 |
*** rakesh_hs has quit IRC | 15:01 | |
*** dwalleck has joined #openstack-ironic | 15:01 | |
*** dwalleck has quit IRC | 15:02 | |
Mikhail_D_ltp | NobodyCam: I have to go. Bye! :) Have a good weekend :) | 15:02 |
*** dwalleck has joined #openstack-ironic | 15:03 | |
NobodyCam | you too Mikhail_D_ltp | 15:06 |
*** Mikhail_D_ltp has quit IRC | 15:08 | |
NobodyCam | lucasagomes: got a second to take a look at https://review.openstack.org/#/c/92819 | 15:10 |
NobodyCam | other cores too ^^^^^^ | 15:10 |
*** blamar has joined #openstack-ironic | 15:12 | |
romcheg | NobodyCam: -1ed :) | 15:14 |
romcheg | NobodyCam: Or you asked for something else? :-P | 15:15 |
NobodyCam | lol nope just a review | 15:18 |
NobodyCam | romcheg: the seamicro driver uses mock.mock | 15:20 |
lucasagomes | NobodyCam sure will do | 15:21 |
romcheg | NobodyCam: If I understand it right MagicMock allows to achieve the same thing by just applying it to a top-level object | 15:21 |
*** dwalleck_ has joined #openstack-ironic | 15:21 | |
NobodyCam | romcheg: would it be better to land as mock.mock and then put up a bug/patch to switch both to magicmock? | 15:23 |
romcheg | NobodyCam: sounds like an overkill. I'm still not 100% sure about that. Trying to check | 15:23 |
*** dwalleck has quit IRC | 15:25 | |
*** jistr has quit IRC | 15:27 | |
*** jistr has joined #openstack-ironic | 15:27 | |
*** annegentle has quit IRC | 15:29 | |
lucasagomes | NobodyCam, done | 15:32 |
*** eghobo has joined #openstack-ironic | 15:32 | |
lucasagomes | romcheg, I disagreed with that | 15:32 |
lucasagomes | I mean we are not using magic methods there, so I don't see the reason to use MagicMock | 15:32 |
lucasagomes | and bring more stuff into the tests when they are not needed | 15:32 |
*** eghobo has quit IRC | 15:33 | |
*** eghobo has joined #openstack-ironic | 15:33 | |
*** foexle has quit IRC | 15:33 | |
NobodyCam | lucasagomes: for a comment "corrects import order in ipminative.py file?" it is just moving the import | 15:34 |
lucasagomes | NobodyCam, sure yeah, just mention that on the commit message | 15:34 |
lucasagomes | it's doing a pep8 work there | 15:34 |
lucasagomes | by grouping imports | 15:34 |
NobodyCam | :) will update in a minute... but first quick walkies... brb | 15:36 |
lucasagomes | NobodyCam, ack :) | 15:36 |
*** rwsu has joined #openstack-ironic | 15:43 | |
romcheg | Gah… a mother in law is a pain in the *ss! | 15:48 |
*** krtaylor has quit IRC | 15:52 | |
NobodyCam | romcheg: thats just how mother's in-law are | 15:52 |
romcheg | NobodyCam: Sad but true | 15:52 |
NobodyCam | :-p | 15:52 |
lucasagomes | lol | 15:52 |
lucasagomes | +1 | 15:53 |
romcheg | Have to rush… | 15:53 |
romcheg | Otherwise my wedding might be canceled | 15:53 |
romcheg | Wish me +100 to diplomacy :) | 15:54 |
lucasagomes | heh good lucky! | 15:55 |
lucasagomes | luck* | 15:55 |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Mock pyghmi lib in unit tests if not present https://review.openstack.org/92819 | 15:55 |
NobodyCam | have a good weekend romcheg | 15:56 |
romcheg | You guys too! | 15:56 |
matty_dubs | Are you getting married this weekend? | 15:56 |
romcheg | I will be back later I suppose | 15:56 |
romcheg | matty_dubs: In a few weeks | 15:56 |
matty_dubs | romcheg: Congrats! | 15:56 |
NobodyCam | congratz romcheg | 15:56 |
lucasagomes | wow congrats :) | 15:57 |
romcheg | Need to be officially married for being able to take my partner with me | 15:57 |
romcheg | Thank you guys! | 15:59 |
*** todd_dsm has joined #openstack-ironic | 16:01 | |
*** matty_dubs is now known as matty_dubs|lunch | 16:03 | |
*** todd_dsm has quit IRC | 16:05 | |
*** krtaylor has joined #openstack-ironic | 16:07 | |
*** martyntaylor has quit IRC | 16:11 | |
openstackgerrit | Anusha Ramineni proposed a change to openstack/ironic-specs: iLO Power Driver for Ironic https://review.openstack.org/97455 | 16:12 |
*** derekh_ has quit IRC | 16:13 | |
*** vinbs has joined #openstack-ironic | 16:13 | |
*** ellenh has joined #openstack-ironic | 16:22 | |
*** dwalleck_ has quit IRC | 16:22 | |
*** dwalleck has joined #openstack-ironic | 16:23 | |
*** datajerk has quit IRC | 16:24 | |
*** comstud is now known as bearhands | 16:25 | |
*** viktors has quit IRC | 16:35 | |
devananda | g'morning, all | 16:36 |
lucasagomes | devananda, morning | 16:38 |
devananda | romcheg: good luck! | 16:40 |
*** todd_dsm has joined #openstack-ironic | 16:41 | |
NobodyCam | good morning devananda | 16:41 |
devananda | so quick update if anyone hasn't seen sdague's emails -- gate queue is STILL very far behind | 16:41 |
devananda | we should continue to only be approve important fixes and features, No little cleanup patches. | 16:41 |
devananda | cause every patch WE approve slows down other projects too | 16:42 |
devananda | even though ironic isn't an integrated project, we're in the same gate queue, which is VERY slow | 16:42 |
jroll | are we back in the usual gate now? | 16:43 |
devananda | jroll: we were never not in the gate | 16:45 |
JayF | they just removed our tempest stuff from voting iirc | 16:45 |
devananda | jroll: a) nova broke something so we couldn't land any patches for a week. that was fixed ~monday | 16:45 |
jroll | we had our own queue for some time yesterday | 16:45 |
devananda | jroll: b) as JayF just said, sdague made the gate-tempest-dsvm-virtual-ironic job non-voting, so that it is processed differently by zuul | 16:46 |
devananda | oh? | 16:46 |
jroll | NobodyCam: please verify I didn't dream that | 16:46 |
devananda | ooooh | 16:46 |
devananda | jroll: you may be right. i see that dib has its own queue now | 16:46 |
jroll | yep still there | 16:46 |
jroll | we share with dib | 16:47 |
devananda | gotcha | 16:47 |
jroll | quick, approve my patches and you'll see ;) | 16:47 |
devananda | so yea, sdague must have broken ironic out | 16:47 |
jroll | it is temporary, there was a conversatuon about it in infra yesterday | 16:48 |
*** datajerk has joined #openstack-ironic | 16:48 | |
devananda | i see | 16:48 |
devananda | adam_g: around? | 16:53 |
*** matty_dubs|lunch is now known as matty_dubs | 16:54 | |
lucasagomes | alright folks, I'm done for today :) | 16:56 |
lucasagomes | have a good night everybody | 16:56 |
lucasagomes | enjoy the weekend :) | 16:56 |
JayF | Sad that Dmitry isn't back yet :( | 16:57 |
*** lucasagomes is now known as lucas-dinner | 16:57 | |
*** hemna_ is now known as hemna | 16:58 | |
*** vinbs_ has joined #openstack-ironic | 16:58 | |
*** vinbs has quit IRC | 16:59 | |
*** vinbs_ is now known as vinbs | 16:59 | |
NobodyCam | nobodycam points to fungi's offical answer: (yesterday) | fungi > NobodyCam: is anything here ever permanent? it's a result of taking oslo cross-tests off those projects for the gate pipeline, which caused them to no longer have jobs in common with anything in the main integrated gate queue | 17:00 |
*** todd_dsm has quit IRC | 17:05 | |
*** harlowja_away is now known as harlowja | 17:06 | |
*** romcheg has quit IRC | 17:06 | |
*** pelix has quit IRC | 17:10 | |
*** rakesh_hs has joined #openstack-ironic | 17:11 | |
*** todd_dsm has joined #openstack-ironic | 17:12 | |
*** petertoft has quit IRC | 17:19 | |
*** davidlenwell is now known as davidlenwell_ | 17:20 | |
*** davidlenwell_ is now known as davidlenwell | 17:20 | |
devananda | lucas-dinner: if you are around at some point, could you remove your -2 from https://review.openstack.org/#/c/97447/ now? | 17:21 |
devananda | lucas-dinner: I think we need to look at hlind's patch series closely again, and see if we can land it ahead of nova landing theirs | 17:21 |
*** ndipanoff has quit IRC | 17:25 | |
devananda | NobodyCam: given that the ipmi timing issue is causing pain for folks, but the last patch I proposed can't merge until there's a devstack change | 17:29 |
devananda | which I proposed here https://review.openstack.org/#/c/99723/ | 17:30 |
devananda | NobodyCam: what do you think about me splitting our patches up into 3 and leaving the "raise DriverLoadError" part in the last patch | 17:30 |
devananda | then lading hte two that really fix ipmi timing | 17:30 |
NobodyCam | devananda: ++ and then land the block driver load after we can land the devstack patch | 17:32 |
NobodyCam | :) | 17:32 |
devananda | yes | 17:32 |
NobodyCam | yep i'd +2 that | 17:32 |
lucas-dinner | devananda, removing | 17:42 |
lucas-dinner | done | 17:43 |
devananda | thanks | 17:43 |
*** todd_dsm has quit IRC | 17:43 | |
*** todd_dsm has joined #openstack-ironic | 17:46 | |
devananda | lucas-dinner: on the mgmt interfaces, I think they're all good fromw hat i've reviewed, and would like to land them soon | 17:49 |
devananda | lucas-dinner: i just realized there's no spec, though. | 17:49 |
devananda | lucas-dinner: the bp page has a bunch of text that looks almost like a spec, but it was probably posted before we had the official specs repo | 17:50 |
*** todd_dsm has quit IRC | 17:51 | |
lucas-dinner | devananda, :( yeah that's true, I will write a spec for it | 17:52 |
devananda | lucas-dinner: thanks. hate to make more work for you :( | 17:52 |
lucas-dinner | but on monday (finished work today already) | 17:52 |
devananda | lucas-dinner: ack | 17:53 |
lucas-dinner | devananda, heh no problem | 17:53 |
* lucas-dinner writes it down | 17:53 | |
jroll | I fail to see how this breaks ironic: https://review.openstack.org/#/c/68942/14 | 17:54 |
jroll | or how phil knows that it broke ironic (can't remember where those tests were added) | 17:55 |
NobodyCam | hehe | 17:55 |
devananda | jroll: Shrews added those tests at sdague's suggestion, since the HostState.__init__ change broke our gate | 17:56 |
NobodyCam | devananda: is this something we should pick up again? https://review.openstack.org/#/c/79194 | 17:56 |
devananda | jroll: so adding two parameters to a method that our out of tree driver is using could potentially break ironic's virt driver | 17:56 |
jroll | devananda: but they are kwargs? | 17:56 |
devananda | jroll: in this case, i dont think it will -- they're optional, right? | 17:56 |
devananda | right | 17:56 |
jroll | yeah | 17:56 |
jroll | and it added to unit tests | 17:57 |
jroll | which passes afaict | 17:57 |
jroll | I can see why Shrews' unit tests might fail, though | 17:57 |
devananda | NobodyCam: probably | 17:57 |
jroll | s/might/would/ | 17:58 |
jroll | now /me is really confused | 17:58 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Enforce a minimum time between all IPMI commands https://review.openstack.org/96558 | 18:02 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Let ipmitool natively retry commands https://review.openstack.org/96902 | 18:02 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: ipmitool driver raises DriverLoadError https://review.openstack.org/99977 | 18:02 |
*** todd_dsm has joined #openstack-ironic | 18:02 | |
NobodyCam | oh so close to patch #100000 | 18:03 |
* jroll tries to time it | 18:03 | |
* NobodyCam wounders if there will be a prize for patch 100000, like your customer # blah... :-p | 18:04 | |
JayF | I have $20 on global-requirements-bot getting it :P | 18:05 |
NobodyCam | lol | 18:05 |
*** todd_dsm has quit IRC | 18:06 | |
*** todd_dsm has joined #openstack-ironic | 18:06 | |
adam_g | devananda, hey im here now. been at corvallis office today and struggling to get net access | 18:16 |
devananda | adam_g: hi! great, that's what I was checking -- i thought I saw an email saying you were down there | 18:16 |
NobodyCam | hey hey adam_g how are things going | 18:16 |
devananda | adam_g: have you been in touch with cody? he sent a separate email asking SpamapS and I to go down | 18:17 |
devananda | adam_g: also, if you need to pull me into something to help, please do | 18:17 |
adam_g | just getting setup with an overcloud to see what issues they are running into | 18:17 |
SpamapS | Nice, adam _and_ greg.. should get them sorted. | 18:18 |
* NobodyCam is also happy to help if needed | 18:19 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Allow noauth for Neutron https://review.openstack.org/98922 | 18:21 |
jroll | so I'm rebasing 84795 on top of 90233, but I don't want to submit 90233 again - is there a way to avoid that? or if I don't change 90233, will it not submit it? | 18:22 |
*** max_lobur1 has joined #openstack-ironic | 18:24 | |
devananda | jroll: there's an opportunistic rebase that gerrit often does | 18:24 |
devananda | jroll: which you can circumvent by "git review -R" | 18:24 |
* JayF putting that into his bag o'tricks | 18:24 | |
jroll | devananda: hmm | 18:25 |
jroll | devananda: it still says I'm submitting multiple commits :/ | 18:26 |
devananda | jroll: yes | 18:26 |
jroll | but maybe gerrit will reject it because no changes? | 18:26 |
jroll | ok | 18:26 |
devananda | it'll warn you no matter what | 18:26 |
jroll | ok | 18:26 |
jroll | thanks! | 18:26 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 18:26 |
jroll | nice | 18:26 |
devananda | :) | 18:27 |
* jroll tears this patch apart now | 18:27 | |
devananda | anyone looking for something to test? | 18:27 |
devananda | i have just the thing : | 18:27 |
*** max_lobur has quit IRC | 18:27 | |
devananda | this patch series https://review.openstack.org/#/c/99026/ | 18:27 |
devananda | should enable custom scheduler filters in Nova | 18:28 |
devananda | (or the compute-capabilities-filter) | 18:28 |
devananda | to key off of node.properties and/or node.extra | 18:28 |
devananda | which i think *everyone* wants | 18:28 |
devananda | but I dont think it works today | 18:28 |
jroll | that would be nice | 18:28 |
devananda | should let us do much more than just matching by cpu/ram/disk :) | 18:29 |
*** sysexit has quit IRC | 18:29 | |
devananda | so who's gonna test it? | 18:29 |
bearhands | hah | 18:29 |
bearhands | We could test it... *at some point* :) | 18:30 |
* bearhands wonders if that is helpful. | 18:30 | |
jroll | :P | 18:30 |
bearhands | I'll certainly take a look at these reviews tho | 18:30 |
devananda | bearhands: it's a cleanup of the patch that broke our gate last week | 18:31 |
bearhands | yeah | 18:31 |
bearhands | i've been following, even if it seems like i've been gone | 18:31 |
bearhands | :) | 18:31 |
devananda | :) | 18:31 |
NobodyCam | devananda: you up to adding a +1 to your patch https://review.openstack.org/#/c/92819 | 18:31 |
NobodyCam | just because I pushed up the last rev. | 18:32 |
devananda | NobodyCam: I think there's a problem in https://review.openstack.org/#/c/92819/5/ironic/tests/drivers/third_party_driver_mocks.py | 18:34 |
devananda | reload(sys.modules['ironic.drivers.modules.pyghmi']) | 18:34 |
devananda | i dont think that exists | 18:35 |
*** romcheg has joined #openstack-ironic | 18:35 | |
*** todd_dsm has quit IRC | 18:35 | |
NobodyCam | ipminative :-p | 18:35 |
NobodyCam | then also line 31 | 18:36 |
devananda | ? | 18:36 |
NobodyCam | sorry wrong file... :-p 53 | 18:37 |
NobodyCam | should that be ipminative too? | 18:37 |
devananda | no no | 18:37 |
devananda | that's fine | 18:37 |
NobodyCam | ack | 18:37 |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Mock pyghmi lib in unit tests if not present https://review.openstack.org/92819 | 18:38 |
NobodyCam | brb | 18:42 |
openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Add more INFO logging to ironic/drivers/modules https://review.openstack.org/99431 | 18:44 |
openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Add more INFO logging to ironic/common https://review.openstack.org/99495 | 18:45 |
*** petertoft has joined #openstack-ironic | 18:47 | |
*** sysexit has joined #openstack-ironic | 18:48 | |
*** reaper has quit IRC | 18:49 | |
NobodyCam | lifeless: you happen to online? | 18:55 |
* devananda lunches | 18:57 | |
*** ellenh has quit IRC | 18:57 | |
*** todd_dsm has joined #openstack-ironic | 18:58 | |
lifeless | 7am sat morning... | 18:59 |
NobodyCam | :( sorry for the ping... was going to ask about: https://review.openstack.org/#/c/98050 | 19:01 |
NobodyCam | just added a comment | 19:01 |
*** dwalleck has quit IRC | 19:02 | |
*** romcheg has quit IRC | 19:19 | |
*** romcheg has joined #openstack-ironic | 19:19 | |
*** sysexit has quit IRC | 19:23 | |
*** ellenh has joined #openstack-ironic | 19:30 | |
NobodyCam | anyone have time to review https://review.openstack.org/#/c/96902 & https://review.openstack.org/#/c/96558 .... Would love to start the landing before the weekend | 19:31 |
*** vinbs has quit IRC | 19:35 | |
*** todd_dsm has quit IRC | 19:43 | |
*** todd_dsm has joined #openstack-ironic | 19:47 | |
*** petertoft has quit IRC | 19:48 | |
*** jdob has quit IRC | 19:55 | |
*** jdob has joined #openstack-ironic | 19:55 | |
*** zul has joined #openstack-ironic | 19:59 | |
*** dwalleck has joined #openstack-ironic | 20:03 | |
*** ifarkas has quit IRC | 20:04 | |
*** jdob has quit IRC | 20:05 | |
*** jdob has joined #openstack-ironic | 20:05 | |
*** dwalleck has quit IRC | 20:06 | |
*** dwalleck has joined #openstack-ironic | 20:07 | |
*** todd_dsm has quit IRC | 20:09 | |
*** blamar has quit IRC | 20:09 | |
*** dwalleck_ has joined #openstack-ironic | 20:11 | |
*** dwalleck has quit IRC | 20:11 | |
*** rameshg87 has joined #openstack-ironic | 20:18 | |
*** jistr has quit IRC | 20:18 | |
openstackgerrit | Adam Gandelman proposed a change to openstack/ironic: Destroy instance to clear node state on failure https://review.openstack.org/99519 | 20:18 |
*** romcheg has quit IRC | 20:19 | |
*** todd_dsm has joined #openstack-ironic | 20:19 | |
NobodyCam | lifeless: (sorry for the Saturday ping, again, but you'll like this one) : fyi: check-tripleo-ironic-undercloud-precise SUCCESS in 1h 00m 25s (non-voting) | 20:23 |
NobodyCam | devananda: also fyi ^^^^^^^^^ | 20:24 |
*** todd_dsm has quit IRC | 20:26 | |
devananda | NobodyCam: \o/ | 20:26 |
NobodyCam | :) | 20:28 |
*** linggao has quit IRC | 20:30 | |
devananda | NobodyCam: think 96558 should have a unit test for the timing control its adding | 20:30 |
NobodyCam | lol I thought about that then figured it would just end up getting mocked at a later date with another speed up tests patch | 20:32 |
devananda | looks like there should be three tests: exec called on a new address; exec called and address was already poked in less than min_command_interval; exec called and address was poked more than min_command_interval time ago. | 20:32 |
devananda | we shouldn't actually sleep | 20:32 |
devananda | just mock the time.time() and time.sleep() calls | 20:32 |
devananda | ensure the method is actually calling sleep when we expect it to | 20:32 |
rameshg87 | devananda: NobodyCam: a request for reviews of some of ilo related design specs: https://review.openstack.org/#/c/97455/ https://review.openstack.org/#/c/97744/ :-) | 20:33 |
devananda | hi rameshg87 ! thanks for the ping. we've been focused on critical bugs and gate problems for the past two weeks | 20:33 |
rameshg87 | devananda, okay. hope we get some time of you guys soon :-) | 20:34 |
*** rameshg87 has left #openstack-ironic | 20:43 | |
*** ellenh has quit IRC | 20:43 | |
*** rakesh_hs has quit IRC | 20:45 | |
NobodyCam | devananda: I think I'm going to end up with four tests unless I misunderstand the first example | 20:48 |
devananda | NobodyCam: if address not in LAST_CMD_TIME | 20:49 |
devananda | NobodyCam: if address in ^ and we should sleep | 20:49 |
devananda | NobodyCam: if address in ^ and we should not sleep | 20:49 |
NobodyCam | then #4 call two different addresses with out called sleep | 20:49 |
devananda | ah | 20:50 |
NobodyCam | s/called/calling/ | 20:50 |
*** jdob has quit IRC | 20:50 | |
NobodyCam | startning them now | 20:50 |
NobodyCam | :-p Starting on them now :-p | 20:50 |
lifeless | NobodyCam: awesome | 20:55 |
lifeless | NobodyCam: is that with trunk everything? | 20:56 |
lifeless | NobodyCam: or are there patches to land for it ? | 20:56 |
*** ellenh has joined #openstack-ironic | 21:00 | |
*** sysexit has joined #openstack-ironic | 21:04 | |
NobodyCam | lifeless: it was the parted patch (and others Im sure) but every thing should be in trunk now | 21:05 |
NobodyCam | wipe label patch (which landed) fixed | 21:06 |
NobodyCam | it | 21:06 |
*** mgagne has quit IRC | 21:11 | |
lifeless | NobodyCam: ok so | 21:15 |
lifeless | NobodyCam: can you submit a patch to infra to swap the seed only ironic job and the undercloud precise one - that is, make the seed experimental (cause we're resource constrained) and run the undercloud one always ? | 21:16 |
lifeless | so we don't let it regress? | 21:16 |
*** Mikhail_D_ltp has joined #openstack-ironic | 21:17 | |
devananda | ++ | 21:17 |
*** mgagne has joined #openstack-ironic | 21:20 | |
*** mgagne is now known as Guest61486 | 21:20 | |
*** todd_dsm has joined #openstack-ironic | 21:27 | |
openstackgerrit | A change was merged to openstack/ironic: Add unique constraint to instance_uuid https://review.openstack.org/98120 | 21:32 |
NobodyCam | lifeless: that was the first pass should we run a few other test first? | 21:33 |
NobodyCam | that one took 19 + hours | 21:33 |
NobodyCam | (to get thru the queue) | 21:34 |
NobodyCam | brb | 21:39 |
*** todd_dsm has quit IRC | 21:49 | |
*** sysexit has quit IRC | 21:58 | |
devananda | it does look like we have a separate merge queue now | 21:58 |
devananda | no need to hold back merges now :) | 22:00 |
lifeless | NobodyCam: get the patch up:) | 22:03 |
lifeless | NobodyCam: by all means we run more tests before we land it | 22:03 |
*** harlowja has quit IRC | 22:03 | |
NobodyCam | lifeless: ack ... will get a patch toghether in Just a bit | 22:09 |
*** petertoft has joined #openstack-ironic | 22:10 | |
*** blamar has joined #openstack-ironic | 22:10 | |
*** petertoft has quit IRC | 22:16 | |
*** blamar has quit IRC | 22:24 | |
*** blamar has joined #openstack-ironic | 22:35 | |
*** igordcard has quit IRC | 22:37 | |
*** Guest61486 has quit IRC | 22:38 | |
*** mgagne has joined #openstack-ironic | 22:41 | |
*** mgagne is now known as Guest8031 | 22:41 | |
jroll | devananda / NobodyCam: would either of you like to land https://review.openstack.org/#/c/90233 ? :) | 22:46 |
JayF | https://review.openstack.org/#/c/90233/ needs one more +2 and a +A if someone wants to make jroll's life a little easier :) | 22:46 |
JayF | jroll: thunder-stealer! | 22:46 |
jroll | >.> | 22:46 |
JayF | <.< | 22:46 |
jroll | context: that's one of three patches my agent patch refactor depends on | 22:46 |
devananda | jroll: problem in the first file | 22:46 |
jroll | s/depends/will depend/ | 22:47 |
jroll | ? | 22:47 |
JayF | also https://review.openstack.org/#/c/99706/ easy +2+A for someone who isn't jroll (simple logging fix in the agent) | 22:47 |
devananda | jroll: nvm :) | 22:47 |
devananda | jroll: /me continues to review | 22:47 |
jroll | devananda: heh, ok :) | 22:47 |
jroll | thank you! | 22:47 |
*** matty_dubs is now known as matty_dubs|gone | 22:47 | |
*** matty_dubs|gone has quit IRC | 22:47 | |
jroll | lucas-dinner: I know you're probably afk, but I'm going to rebase your instance_info chain as it's still showing tests from broken gate, and I need to depend on it | 22:50 |
*** dwalleck_ has quit IRC | 22:50 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/96228 | 22:52 |
*** ellenh has quit IRC | 22:55 | |
*** blamar has quit IRC | 22:55 | |
*** ellenh has joined #openstack-ironic | 22:56 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/96263 | 22:57 |
*** igordcard has joined #openstack-ironic | 22:59 | |
*** Mikhail_D_ltp has quit IRC | 23:03 | |
devananda | jroll: so i'm close to being OK landing this | 23:03 |
devananda | jroll: but there's a little more refactoring i think needs to be done | 23:04 |
jroll | gah | 23:04 |
jroll | I can do that | 23:04 |
* jroll looks at review | 23:04 | |
jroll | I see a +2 with no comments :P | 23:04 |
devananda | jroll: it's friday. i'm feeling generous and happy to land this now :) | 23:04 |
jroll | devananda: what are you looking for in a future patch? | 23:05 |
jroll | :) | 23:05 |
jroll | awesome | 23:05 |
devananda | common.tftp is creating a file | 23:05 |
devananda | but never deleting it | 23:05 |
devananda | drivers.modules.pxe is doing the deletion | 23:05 |
jroll | aha | 23:05 |
devananda | that's not a clear API | 23:05 |
devananda | and going to make every other driver duplicate work, introduce bugs, etc | 23:05 |
jroll | right | 23:06 |
jroll | totally agree | 23:06 |
devananda | jroll: do you want to do another rev, or another patch? | 23:08 |
jroll | meh, either way it's going to be in my dependency tree | 23:08 |
jroll | probably just another rev right quick | 23:08 |
devananda | k k | 23:09 |
devananda | bbiaf | 23:10 |
jroll | cool, thank you | 23:10 |
*** mdorman has quit IRC | 23:12 | |
*** max_lobur1 has quit IRC | 23:13 | |
*** yjiang5 has joined #openstack-ironic | 23:16 | |
*** lucas-dinner has quit IRC | 23:37 | |
*** dwalleck has joined #openstack-ironic | 23:51 | |
*** dwalleck has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!