Wednesday, 2014-06-11

« Tuesday, 2014-06-10 Index Thursday, 2014-06-12 »
*** hemna has quit IRC00:27
*** matsuhashi has joined #openstack-ironic00:28
openstackgerritChris Krelle proposed a change to openstack/ironic: Let ipmitool natively retry commands  https://review.openstack.org/9690200:44
openstackgerritA change was merged to openstack/ironic: TaskManager: Only support single node locking  https://review.openstack.org/9141901:05
openstackgerritA change was merged to openstack/ironic: Remove 'node' parameter from the Console and Rescue interfaces  https://review.openstack.org/9109701:05
*** ellenh has quit IRC01:07
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements  https://review.openstack.org/9622801:32
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/8872201:32
openstackgerritOpenStack Proposal Bot proposed a change to openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/9626301:37
*** nosnos has joined #openstack-ironic01:46
openstackgerritA change was merged to openstack/ironic: Mock seamicroclient lib in unit tests if not present  https://review.openstack.org/9017402:21
openstackgerritA change was merged to openstack/ironic: Skip migrations test_walk_versions instead of pass  https://review.openstack.org/9850402:21
*** pcrews has joined #openstack-ironic02:37
*** klindgren_ is now known as klindgren02:43
*** gcb has joined #openstack-ironic02:44
*** radsy_ has joined #openstack-ironic03:08
*** radsy has quit IRC03:11
*** gcb has quit IRC03:12
*** radsy_ is now known as radsy03:13
*** vinbs has joined #openstack-ironic03:14
*** radsy has quit IRC03:15
*** radsy has joined #openstack-ironic03:15
*** gcb has joined #openstack-ironic03:24
*** harlowja is now known as harlowja_away03:24
*** nosnos has quit IRC03:33
*** nosnos has joined #openstack-ironic04:15
*** matsuhashi has quit IRC04:19
*** matsuhashi has joined #openstack-ironic04:19
openstackgerritA change was merged to openstack/ironic: Add retry logic to iscsiadm commands  https://review.openstack.org/9851004:22
*** matsuhashi has quit IRC04:23
*** ramineni has joined #openstack-ironic04:24
*** Mikhail_D_ltp has joined #openstack-ironic04:24
*** Haomeng has quit IRC04:26
*** dwalleck has joined #openstack-ironic04:27
*** matsuhashi has joined #openstack-ironic04:27
*** dwalleck has quit IRC04:28
*** dwalleck has joined #openstack-ironic04:29
*** coolsvap|afk is now known as coolsvap04:36
*** coolsvap is now known as coolsvap|afk04:46
*** coolsvap|afk is now known as coolsvap04:53
*** Mikhail_D_ltp has quit IRC05:03
*** lazy_prince has joined #openstack-ironic05:06
*** Haomeng has joined #openstack-ironic05:08
openstackgerritMichael Davies proposed a change to openstack/ironic: Improving unit tests for _do_sync_power_state  https://review.openstack.org/9927105:13
*** dwalleck_ has joined #openstack-ironic05:14
*** dwalleck has quit IRC05:14
*** rakesh_hs has joined #openstack-ironic05:20
*** dwalleck_ has quit IRC05:40
*** radsy has quit IRC05:41
*** lazy_prince has quit IRC05:43
*** lazy_prince has joined #openstack-ironic05:46
*** sysexit has joined #openstack-ironic05:47
*** lazy_prince has quit IRC05:49
*** dwalleck has joined #openstack-ironic05:49
*** lazy_prince has joined #openstack-ironic05:51
openstackgerritMichael Davies proposed a change to openstack/ironic: Improving unit tests for _do_sync_power_state  https://review.openstack.org/9927105:54
*** k4n0 has joined #openstack-ironic05:59
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/9606306:01
k4n0Hi Ironic06:02
*** lazy_prince has quit IRC06:04
*** lazy_prince has joined #openstack-ironic06:18
*** Mikhail_D_ltp has joined #openstack-ironic06:20
Mikhail_D_ltpGood morning Ironic! :)06:42
*** matsuhashi has quit IRC06:42
GheRiveromorning all06:43
*** matsuhashi has joined #openstack-ironic06:43
openstackgerritA change was merged to openstack/ironic: Remove 'fake' and 'ssh' drivers from default enabled list  https://review.openstack.org/8871106:44
*** matsuhashi has quit IRC06:47
mrdahi GheRivero and Mikhail_D_ltp06:48
*** matsuhashi has joined #openstack-ironic06:50
*** dwalleck has quit IRC06:50
*** jcoufal has joined #openstack-ironic06:51
*** Poornima has joined #openstack-ironic06:56
*** jistr has joined #openstack-ironic07:00
*** derekh_ has joined #openstack-ironic07:01
*** matsuhashi has quit IRC07:02
*** matsuhashi has joined #openstack-ironic07:03
*** viktors|afk is now known as viktors07:03
*** athomas has joined #openstack-ironic07:03
*** matsuhashi has quit IRC07:04
*** matsuhashi has joined #openstack-ironic07:04
*** romcheg has joined #openstack-ironic07:20
*** sysexit has quit IRC07:42
mrda'night all - see you tomorrow07:42
*** mrda is now known as mrda-away07:42
*** sysexit has joined #openstack-ironic07:45
*** max_lobur has joined #openstack-ironic08:04
*** pcrews has quit IRC08:05
*** pelix has joined #openstack-ironic08:19
*** lucasagomes has joined #openstack-ironic08:26
*** gcb has quit IRC08:38
*** romcheg has quit IRC08:45
*** igordcard has joined #openstack-ironic08:47
*** gcb has joined #openstack-ironic08:52
*** romcheg has joined #openstack-ironic08:56
*** athomas has quit IRC08:59
*** matsuhashi has quit IRC09:00
*** matsuhashi has joined #openstack-ironic09:01
*** martyntaylor has joined #openstack-ironic09:02
*** SpamapS has quit IRC09:10
*** SpamapS has joined #openstack-ironic09:11
*** SpamapS has joined #openstack-ironic09:11
openstackgerritGhe Rivero proposed a change to openstack/ironic-python-agent: Improve cache_image testing  https://review.openstack.org/9930109:17
*** max_lobur1 has joined #openstack-ironic09:33
*** max_lobur has quit IRC09:36
*** romcheg has quit IRC09:46
*** coolsvap is now known as coolsvap|afk09:50
*** jistr has quit IRC09:52
*** gcb has quit IRC09:54
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add iPXE support for Ironic  https://review.openstack.org/9931809:56
lucasagomesJoshNang, 90233 needs rebase (again) :/09:57
*** matsuhashi has quit IRC10:05
*** matsuhashi has joined #openstack-ironic10:06
*** matsuhashi has quit IRC10:06
*** matsuhashi has joined #openstack-ironic10:06
*** jistr has joined #openstack-ironic10:08
*** sysexit has quit IRC10:19
*** pradipta_away is now known as pradipta10:20
*** matsuhashi has quit IRC10:45
*** ramineni has left #openstack-ironic10:59
*** Poornima has quit IRC10:59
*** Poornima has joined #openstack-ironic11:00
*** rwsu_ has joined #openstack-ironic11:13
*** rwsu has quit IRC11:14
*** devananda has quit IRC11:17
*** devananda has joined #openstack-ironic11:17
*** JayF has quit IRC11:19
*** slamont has quit IRC11:19
*** JayF has joined #openstack-ironic11:19
*** JayF has quit IRC11:19
*** JayF has joined #openstack-ironic11:19
*** slamont has joined #openstack-ironic11:20
*** yuriyz has quit IRC11:21
vinbsHello Ironic :)11:22
GheRiverohi11:23
*** yuriyz has joined #openstack-ironic11:24
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add iPXE support for Ironic  https://review.openstack.org/9931811:37
openstackgerritGhe Rivero proposed a change to openstack/ironic: Imporve cache_image tests  https://review.openstack.org/9934311:38
*** lucasagomes is now known as lucas-hungry11:39
*** reaper has joined #openstack-ironic11:53
*** jgrimm has quit IRC11:55
*** romcheg has joined #openstack-ironic11:55
*** anteaya has quit IRC11:58
*** Poornima has quit IRC12:07
*** vinbs has quit IRC12:11
*** vinbs has joined #openstack-ironic12:15
*** Shrews has quit IRC12:16
*** jdob has joined #openstack-ironic12:16
*** Shrews has joined #openstack-ironic12:16
*** vinbs has quit IRC12:25
*** Shrews has quit IRC12:28
openstackgerritImre Farkas proposed a change to openstack/ironic-specs: DRAC power driver  https://review.openstack.org/9935212:28
*** Shrews has joined #openstack-ironic12:29
*** Alexei_9871 has joined #openstack-ironic12:36
*** nosnos has quit IRC12:36
*** anteaya has joined #openstack-ironic12:39
*** yuriyz has quit IRC12:40
*** yuriyz has joined #openstack-ironic12:41
*** pradipta is now known as pradipta_away12:41
*** nosnos has joined #openstack-ironic12:43
*** martyntaylor1 has joined #openstack-ironic12:44
*** martyntaylor has quit IRC12:45
*** nosnos has quit IRC12:47
*** martyntaylor has joined #openstack-ironic12:50
*** martyntaylor1 has quit IRC12:50
*** adam_g has quit IRC12:51
*** adam_g has joined #openstack-ironic12:52
*** lucas-hungry is now known as lucasagomes12:52
*** adam_g has quit IRC12:52
*** adam_g has joined #openstack-ironic12:52
*** romcheg has quit IRC12:53
ShrewsI am seriously tempted to submit changes to make ironic tests work on my mac12:53
*** rakesh_hs has quit IRC12:58
*** romcheg has joined #openstack-ironic12:58
*** jrist has quit IRC13:01
*** sysexit has joined #openstack-ironic13:02
*** jrist has joined #openstack-ironic13:02
*** jcoufal has quit IRC13:03
NobodyCamgood morning Ironic13:10
romchegGood morning NobodyCam!13:12
NobodyCammorning romcheg :)13:12
*** k4n0 has quit IRC13:17
*** matty_dubs|afk is now known as matty_dubs13:17
NobodyCamShrews: lol like the ipmitool password file tests13:18
*** romcheg has left #openstack-ironic13:19
Shrewsjroll: devananda: so, the reason i intentionally cause node.validate() to fail in 96498 is that it avoids mocking several other things (2 methods and 2 return values). But I see it as 6 in one, half a dozen in the other, so I'll post a new change with that.13:20
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Set instance default_ephemeral_device  https://review.openstack.org/9649813:22
Shrewsjroll: devananda: there ya go ^^^^13:22
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic-specs: iPXE boot  https://review.openstack.org/9882213:23
lucasagomesmorning Shrews NobodyCam romcheg13:23
*** rushiagr is now known as rushi13:25
Shrewslucasagomes: morning!13:26
yuriyzmorning Ironic13:26
* Shrews stabs new H402 check13:28
Shrewsoh, maybe it's not new. /me stabs anyway13:28
*** rloo has joined #openstack-ironic13:29
lucasagomesmorning yuriyz13:29
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Sync processutils from oslo code  https://review.openstack.org/9834213:30
*** jcoufal has joined #openstack-ironic13:31
*** reaper has quit IRC13:36
*** coolsvap|afk is now known as coolsvap13:38
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Sync processutils from oslo code  https://review.openstack.org/9834213:38
NobodyCammorning lucasagomes Shrews yuriyz13:42
ShrewsNobodyCam: morning13:43
* NobodyCam notes to always seat Shrews with the plastic knifes13:43
Shrewsyes, i often get quite stabby. especially while on caffeine13:44
* Shrews gets more coffee13:44
NobodyCamlol13:44
jrollmorning y'all :)13:48
jrollShrews: thanks for that, +1'd13:48
jrolllucasagomes: I'll rebase Josh's refactor today, he just went on PTO13:49
Shrewsjroll: np13:49
Shrewsand morning13:49
lucasagomesjroll, awesome! thanks13:49
NobodyCamgood morning jroll13:49
jrollhi NobodyCam :)13:49
jrolland with that /me goes afk for breakfast :)13:49
JoshNangjroll: thanks! otherwise i can get it during my layover13:54
*** pcrews has joined #openstack-ironic13:55
*** jistr has quit IRC13:59
*** romcheg has joined #openstack-ironic14:02
*** jistr has joined #openstack-ironic14:03
devanandag'morning, all14:05
devanandaShrews: what about the tests does not work on your mac?14:05
NobodyCamgood mornig devananda14:05
devanandaShrews: also, welcome back14:06
NobodyCamdevananda: this is common errors I see testing on my mac: http://paste.openstack.org/show/RCcwTRKpw32J9jyzEf4L/14:07
romchegMorning devananda!14:08
devanandaNobodyCam: Shrews: I fully support fixing that error on mac14:10
NobodyCamI keep meaning to14:10
lucasagomesdevananda, morning14:11
devanandaI dont know why we're using os.mknod() instead of eg. tempfile.NamedTemporaryFile(delete=False)14:11
Shrewsdevananda: use of mknod(), use of sendfile library14:12
devanandaah, yes I do - we need a reproducible name, so tempfile isn't going to work14:12
devanandai shouldn't say things like that right after getting up, lol14:12
Shrewsmknod() is easily fixed. the use of sendfile is not since it was intentionally chosen to speed up some stuff, iirc14:13
Shrewsso i gave up b/c EMOREIMPORTANTTHINGS14:14
devanandacool14:14
devanandaso hey, the gate queue is back to ~12hrs long14:14
*** dkehn_ has joined #openstack-ironic14:14
devanandalet's stop approving things14:14
*** ChanServ sets mode: +o devananda14:15
*** dkehn_ is now known as dkehnx14:15
rloodevananda: where are we at now, wrt what you'd like to get landed for J1?14:16
NobodyCammorning rloo :)14:16
devanandarloo: much better than we were on monday14:16
rloohello ironic'ers :)14:16
devanandalemme check the 'pad14:16
rloodevananda: wondering if we should be trying to get others reviewed/approved this week.14:16
lucasagomesyeha gate is pretty slow :( I approved two patches today still queued14:17
lucasagomeswon't approve more for today14:17
rlooNobodyCam: today will be your happy day, if Jenkins likes you ;)14:17
*** ifarkas_ has joined #openstack-ironic14:18
*** martyntaylor has quit IRC14:18
*** ifarkas has quit IRC14:18
lucasagomesheh14:18
lucasagomes+114:18
devanandalucasagomes: would you mind rebasing https://review.openstack.org/#/c/98120/14:21
lucasagomesdevananda, will do14:21
devanandalucasagomes: so we can see if jenkins runs the migration tests now that one of my fixes landed14:21
devanandathanks14:21
romchegqueue is quite long today as well14:22
romchegbut it seems to move forward14:22
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add unique constraint to instance_uuid  https://review.openstack.org/9812014:23
lucasagomesdone no merge conflicts :)14:23
Shrewsrloo: thx for the rebase in my absence yesterday14:23
openstackgerritChris Krelle proposed a change to openstack/ironic: Let ipmitool natively retry commands  https://review.openstack.org/9690214:24
* lucasagomes brb going to get a coffee14:24
NobodyCamyuriyz: great review TY14:24
rlooShrews: yw. When I volunteered to do it, I had been hoping it would be a trivial rebase, but it wasn't that trivial since I wasn't familiar with that code ;)14:24
rlooShrews: question about that. The commit sez 'Longer term, we should consider...'. How (or do we want to) track these longer-term things?14:25
NobodyCamdevananda: can you look at the comments I posted on 96902 and let me know if you agree, mainly the move the config options one!14:26
devanandarloo: bugs, usually14:27
devanandaromcheg: pls do not approve things right now14:28
romchegdevananda: Why not, the gates seem to work?14:28
devanandaromcheg: particularly any db migrations, since they are not tested upstream14:28
devanandaromcheg: no - gate is > 12 hours behind14:28
devanandaromcheg: see the room title :)14:29
rloodevananda, thx. I'll suggest to Shrews to do that ;)14:29
romchegdevananda: Whoops, room title was too far…….14:29
rloodevananda: what you want, is the ability to disable the approve button ;)14:30
Shrewsrloo: i'll open one  :)14:31
rloothx Shrews! I was going to mention in the review, but I won't now ;)14:31
devanandarloo: as far as J1 status, we had targeted a few things which aren't done yet -- https://launchpad.net/ironic/+milestone/juno-114:32
devanandawhich I will simply bump to j214:32
rloodevananda: haha. That was easy ;)14:33
devanandaMikhail_D_wk: hi! you assigned https://bugs.launchpad.net/ironic/+bug/1314954 to yourself a week ago, but I dont see any patch related to it yet. are you still working on it?14:34
lucasagomesdevananda, now that the instance_info spec was approved, mind approving that blueprint in the lp and assigning it to me? I think that people looking at the patches on devstack and tempest might feel more confortable if the bp linked with the patch is apprved14:40
*** reaper has joined #openstack-ironic14:41
devanandalucasagomes: ack, thx for the ping14:43
Shrewsrloo: https://bugs.launchpad.net/ironic/+bug/132893914:43
rloothx Shrews!14:43
devanandalucasagomes: done14:48
lucasagomesdevananda, awesome! thank you14:48
devanandaromcheg: are you able to reach mikhail today?14:52
*** ifarkas_ is now known as ifarkas14:52
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Improve GenericHardwareManager  https://review.openstack.org/9284714:52
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add hardware_utils  https://review.openstack.org/9239914:53
devanandalucasagomes: thoguhts on landing https://review.openstack.org/#/c/83788/ today (or trying to)? it was/is targeted to J1 ...14:54
devanandalucasagomes: also, the issue of "cant have <1G swap" continues to be raised, which I think has been pointed out as a problem for test environments where disk space is constrained14:56
lucasagomesdevananda, right, I'm fine landing this (will need to rebase it)14:56
lucasagomesrloo, have some concerns I think14:56
* lucasagomes re-reads the rloo review14:56
devanandai believe lifeless shared the same concern about minimum swap size14:56
lucasagomesrloo, so, fractions is not possible cause of the nova flavor14:57
lucasagomesdevananda, right14:57
rloolucasagomes: the nova flavor specifies things in MB right?14:57
lucasagomesdevananda, hmm swap is not mandatory14:57
devanandalucasagomes: true. it can be 014:57
lucasagomesrloo, yes,14:58
rloolucasagomes: and this patch is to change the units in ironic to GB, righ?14:58
*** romcheg1 has joined #openstack-ironic14:58
lucasagomesrloo, yup, in Ironic14:58
openstackgerritChris Krelle proposed a change to openstack/ironic: Enforce a minimum time between all IPMI commands  https://review.openstack.org/9655814:58
rloolucasagomes: so if someone specifies a flavor of 1 MB, they won't get 1MB, they'll get 1 GB. right?14:58
lucasagomesrloo, correct14:59
lucasagomesit does ceil round14:59
rloolucasagomes: is that the behavior we want?14:59
lucasagomesso we always round it up14:59
rloolucasagomes: is that obvious to the user?14:59
devanandalucasagomes: https://bugs.launchpad.net/ironic/+bug/1298362 is still assigned to you and marked InProgress. can you review it and see if it's really done?14:59
rloolucasagomes: I don't understand why we can't have GB fractions in ironic.14:59
lucasagomesrloo, based on the conversations we had in the past I think that was the expected behavior14:59
devanandarloo: not obvious at all. there's currently no feedback mechanism for that14:59
*** romcheg has quit IRC15:00
lucasagomesrloo, I could at least log a warning when rounding that up if it helps15:00
rloolucasagomes: I just want to make sure, because it isn't in the commit. Is everyone OK with min of 1 GB, even if flavor is < 1 GB?15:00
devanandalucasagomes: i dont think that's the right approach. the folks who create the flavor may not see the logs15:00
lucasagomesdevananda, oh I think it was in progress because of the partial-bug15:00
lucasagomesi;m not working on that so will remove the assigment15:00
NobodyCamthere a project called cloudkitty15:01
rloolucasagomes: personally, I don't think it is right because I haven't heard of any reason for putting a min of 1 GB, but if that's what you guys want, then fine. But then it needs to be documented or whatever.15:01
devanandalucasagomes: I see. that suggests it also wont be fixed by J1 then :)15:01
lucasagomesdevananda, right, but we still want that behavior?15:01
lucasagomesdevananda, yeah def no J1 (not from my part at least)15:01
rloolucasagomes: what if someone has some funky baremetal node (device) that has < 1 GB on it...15:02
lucasagomesrloo, 1 reason is consistence with the unit sizes15:02
devanandalucasagomes: re: 1GB swap, IIRC, when we first looked at this, we were storing it as integers. let's ask instead what behavior we expect15:02
lucasagomesrloo, root gb, ephemeral gb, swap mb15:02
*** ndipanov has quit IRC15:02
devanandathat ^ inconsistency is a nova artefact that I think Ironic does not need to replicate15:03
devanandahowever15:03
rloolucasagomes: I'm fine with changing the units from MB to GB, I just don't understand why you can't have eg 0.2 GB.15:03
*** ndipanov has joined #openstack-ironic15:03
devanandais there any practical reason to prevent fractional sizes?15:04
*** dkehn_ has joined #openstack-ironic15:04
lucasagomesdevananda, not that I'm aware, because the sizes in Ironic are stored in a dict15:05
lucasagomesonly the code needs to understand it when converting from gb to mb15:05
*** romcheg1 has quit IRC15:05
lucasagomesdon't think it's difficult, I can take a look at it if we agree that we are supporting fractions15:05
devanandaI think I may have said, just store it as an INT, because sometimes I'm lazy ...15:06
lucasagomesheh15:06
lucasagomesmaybe15:06
lucasagomeslemme take a look at it15:07
rloothx lucasagomes!15:07
lucasagomesrloo, thank u for suggestion/review :)15:07
*** dkehnx has quit IRC15:07
lucasagomesfor the*15:07
rloolucasagomes: :)15:10
*** jistr has quit IRC15:12
NobodyCamgah: E303 too many blank lines (3)15:13
NobodyCamdoh15:13
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Stop ipmitool.validate from touching the BMC  https://review.openstack.org/9912115:14
devanandaanother J1 High bug fix we didn't catch yesterday ^^15:15
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Stop ipmitool.validate from touching the BMC  https://review.openstack.org/9912115:16
*** dkehn_ is now known as dkehnx15:17
lucasagomesdevananda, looks straight forward, code lgtm15:19
lucasagomesafter reading about ipmi I see that everything that tries to touch it is automatically dangerous :(15:20
lucasagomesbtw, for those interested >> http://fish2.com/ipmi/ good info about ipmi (mostly security problems)15:20
*** jistr has joined #openstack-ironic15:23
*** mdorman has joined #openstack-ironic15:30
*** jcoufal has quit IRC15:38
*** jcoufal has joined #openstack-ironic15:38
openstackgerritChris Krelle proposed a change to openstack/ironic: Let ipmitool natively retry commands  https://review.openstack.org/9690215:39
Shrewsrloo: re: your comments on 96498, do you think it's acceptable to add the test for NOT setting default_ephemeral_device in the test_spawn() method?15:39
rlooShrews: sec, let me look.15:39
rlooShrews: the purist in me says that there should be two, one for the sets_default_ephemeral_device, and one that doesn't set... OTOH, I'm fine if you put that test/check in test_spawn. As long as others are fine and they should be ;)15:41
Shrewsrloo: so, adding a separate test would basically duplicate test_spawn(), so i thought that was a bit overkill15:42
rlooShrews: exactly. that's why I think it is fine!15:43
Shrewsgreat15:43
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Set instance default_ephemeral_device  https://review.openstack.org/9649815:43
rlooShrews: oh, you asked me *after* you had done it ;)15:43
Shrewsbut *before* i submitted it  :-P15:44
rlooShrews: ha ha.15:44
openstackgerritChris Krelle proposed a change to openstack/ironic: Enforce a minimum time between all IPMI commands  https://review.openstack.org/9655815:47
*** linggao has joined #openstack-ironic15:50
*** ndipanov has quit IRC15:54
*** martyntaylor has joined #openstack-ironic15:55
*** matty_dubs is now known as matty_dubs|lunch16:01
*** hemna_ is now known as hemna16:04
*** ndipanov has joined #openstack-ironic16:07
*** Haomeng has quit IRC16:07
*** romcheg has joined #openstack-ironic16:08
*** martyntaylor has left #openstack-ironic16:08
*** Haomeng has joined #openstack-ironic16:13
Mikhail_D_ltpdevananda: Hi! :) I have no progress on this bug, but I think that can add the `timeout` variable in method `execute` [1] and if it is transmitted kill process of after timeout. [1] https://github.com/openstack/oslo-incubator/blob/master/openstack/common/processutils.py#L8416:16
Mikhail_D_ltphttps://bugs.launchpad.net/ironic/+bug/131495416:16
*** ellenh has joined #openstack-ironic16:19
*** jistr has quit IRC16:19
*** derekh_ has quit IRC16:21
*** jcoufal has quit IRC16:23
*** romcheg has quit IRC16:24
*** Mikhail_D_ltp has quit IRC16:30
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Fractional sizes for root_gb and ephemeral_gb  https://review.openstack.org/9942616:36
lucasagomesrloo, devananda ^ plumbing for the swap work16:36
lucasagomesI will rebase the swap GB on top of that16:36
lucasagomesI tested and it works (deployed without going through nova, since it doesn't accept fractions in the flavor)16:37
* rloo looks16:38
devanandaMikhail_D_wk: ack. in the future, please dont self-assign bugs you are not working on16:38
*** ramineni has joined #openstack-ironic16:38
devanandaMikhail_D_wk: as far as adding a timeout variable, i'm not immediately seeing how you would implement that, but it sounds like a nice feature to propose to oslo16:39
*** harlowja_away is now known as harlowja16:53
*** Alexei_9871 has quit IRC16:55
Shrewsdevananda: so for bug 1316773, any preference on if we implement the retry logic in the client or tempest? also, i wonder if we should be setting the Retry-After header in the http response.16:56
NobodyCamShrews: I would think fixing in the client would be best16:57
*** viktors is now known as viktors|afk16:58
Shrewsactually, tempest is using a generic rest client. so i guess client & tempest are one in the same here. i guess the other alternative is to put something into ir-api to retry16:59
NobodyCamahh I was thinking client == ironicClient17:00
ShrewsNobodyCam: yeah, poorly phrased question. sorry17:01
devanandaShrews: good point17:02
*** matty_dubs|lunch is now known as matty_dubs17:03
devanandaShrews: so there are some short-term ways to mitigate this while the longer fix is done17:03
devanandaShrews: longer fix being the async api stuff, which i need to get back to at some point soon17:03
openstackgerritEllen Hui proposed a change to openstack/ironic: Add more INFO logging  https://review.openstack.org/9943117:11
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Use GB instead of MB for swap  https://review.openstack.org/8378817:11
*** Mikhail_D_ltp has joined #openstack-ironic17:12
*** rloo has quit IRC17:13
*** dguerri has quit IRC17:14
Shrewsdevananda: short-term ways being....  ??17:17
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Use GB instead of MB for swap  https://review.openstack.org/8378817:19
devanandaShrews: none that i really like, heh17:19
lucasagomesalright I will call it a day17:19
lucasagomeshave a good night everybody17:19
NobodyCamhave a good night lucasagomes17:19
devanandag'night lucasagomes !17:19
Shrewslater lucasagomes17:19
*** lucasagomes is now known as lucas-dinner17:19
*** eghobo has joined #openstack-ironic17:25
*** eguz has joined #openstack-ironic17:28
*** eguz has quit IRC17:29
*** eguz has joined #openstack-ironic17:29
openstackgerritRussell Haering proposed a change to openstack/ironic-python-agent: Fix HardwareManager loading order bug  https://review.openstack.org/9867817:29
*** dwalleck has joined #openstack-ironic17:30
openstackgerritRussell Haering proposed a change to openstack/ironic-python-agent: Fix HardwareManager loading order bug  https://review.openstack.org/9867817:31
Shrewslucas-dinner: Is there a reason why your patch to remove 'node' from the Console and Rescue interfaces did not remove node from the validate() methods?17:32
Shrewsor if anyone else can answer that in his absence ^^^^17:33
*** eghobo has quit IRC17:33
NobodyCamShrews: I believe there was, But I can not recall now17:34
devanandaShrews: i thought the patch had a comment about that17:34
Shrewsdevananda: looking for that now...17:35
*** lazy_prince has quit IRC17:35
Shrewsoh, it's in a separate patch17:35
Shrewsthat hasn't merged yet17:35
devananda:)17:37
*** dwalleck has quit IRC17:40
*** dwalleck has joined #openstack-ironic17:40
*** dwalleck has quit IRC17:41
*** eguz has quit IRC17:46
*** eghobo has joined #openstack-ironic17:47
*** eguz has joined #openstack-ironic17:48
*** rushi has quit IRC17:51
*** eghobo has quit IRC17:52
*** rushiagr has joined #openstack-ironic17:54
*** dwalleck has joined #openstack-ironic17:56
*** ramineni has quit IRC18:04
*** dwalleck has quit IRC18:05
*** dwalleck has joined #openstack-ironic18:07
*** dwalleck_ has joined #openstack-ironic18:08
openstackgerritJim Rollenhagen proposed a change to openstack/ironic-python-agent: Fix test_run_image  https://review.openstack.org/9943918:08
jrollsuper easy review if anyone wants one :)18:09
jroll(on IPA)18:09
*** Nisha has joined #openstack-ironic18:09
NishaHi Deva18:09
devanandaNisha: hi! on a call atm18:10
JayFjroll: gotta wait for the +V but lgtm18:10
jrollJayF: you don't have to wait for jenkins to put a review up :)18:10
NishaDeva: Ok. I will just put my query here and then you can send reply when call finishes18:11
jrolljust for +A, and even then, +A runs jenkins again18:11
JayFYou have to if the review is going to be a +2 :)18:11
JayFat least I prefer to wait18:11
jroll'have to' :P18:11
*** dwalleck has quit IRC18:11
NishaWe are working on some features for iLO driver features and intend to add some abstract methods to ManagementInterface. Do we need to submit a seperate blueprint for just standardizing those abstract methods or adding them under /opt/stack/ironic/ironic/drivers/base.py is sufficient?18:12
JayFIf it's going into ManagementInterface, I know at least I'd be interested to see a blueprint18:13
JayFidk what the 'right' answer is though18:13
NishaThe blueprint will be submitted for those features anyway18:13
jrollNisha: the 'right' answer is, it can be in the same blueprint18:14
jrollNisha: there's a section in the spec here: https://github.com/openstack/ironic-specs/blob/master/specs/template.rst#driver-api-impact18:14
jrollspec template*18:14
NishaYes i have seen ths18:15
NishaYou mean adding it in this section will cover the concern?18:16
jrollI guess it depends on what methods are being added18:16
jrollI would start with adding it in that section, and if reviewers feel that it should be a separate spec, that issue will be raised at spec review time18:17
jrolldoes that make sense?18:17
NishaYes sounds good18:18
NishaThanks fr the response18:18
jrollno problem :)18:18
*** rloo has joined #openstack-ironic18:21
*** ndipanov has quit IRC18:24
*** rloo has quit IRC18:26
*** rloo has joined #openstack-ironic18:26
*** eguz has quit IRC18:35
*** eghobo has joined #openstack-ironic18:36
*** pelix has quit IRC18:36
lifelessdevananda: hi yes, I don't believe in swap for most servers. 0 plox.18:36
NishaDeva: is this response for my query?18:38
NishaSorry, i missed reading18:38
rloo:q18:44
rloowhoops ;)18:44
* Shrews quits18:46
Shrews:)18:46
Shrewsthat would actually make a geeky resignation letter:   Dear boss, :q18:47
rlooShrews: but would your boss understand? ;)18:48
lifelessoh yes :)18:48
matty_dubsMine's an emacs user :'(18:48
Shrewsrloo: my boss is monty. he would't even have time to read it18:48
rlooShrews: ahh. In that case, a very short letter is better!18:50
*** romcheg has joined #openstack-ironic18:53
*** romcheg has left #openstack-ironic18:53
*** Nisha has quit IRC19:00
*** rloo has quit IRC19:09
*** rloo has joined #openstack-ironic19:10
*** rloo has quit IRC19:14
*** rloo has joined #openstack-ironic19:14
*** rloo has quit IRC19:14
*** rloo has joined #openstack-ironic19:15
*** sysexit has quit IRC19:24
NobodyCambrb19:24
*** rloo has quit IRC19:27
*** rloo has joined #openstack-ironic19:27
adam_gShrews, any reason not to? https://review.openstack.org/#/c/9946219:37
*** coolsvap is now known as coolsvap|afk19:43
NobodyCamok ... running into town for a few... bbaib19:45
*** ellenh has quit IRC19:54
Shrewsadam_g: i set that value in d-g config. no need to do it there20:00
Shrewsadam_g: https://review.openstack.org/#/c/94456/1/devstack-vm-gate.sh20:01
adam_gShrews, ah! cool :)20:01
jrolldevananda: random question: how would you feel about instrumenting ironic using statsd, similar to what swift does?20:09
JayFaweeks: ^ jroll stealing your thunder20:09
jroll:D20:10
aweeksheh20:10
aweeksno problem20:10
devanandajroll: aweeks: give me more details.20:13
devanandathere's already been much talk of emitting notifications such that something (eg ceilometer) can consume them20:13
devanandabut i'm not familiar with swift's statsd integratin20:13
aweeksdevananda: its not particularly complicated, just allows you to report metrics in addition to the normal log messages20:14
* aweeks gets the code20:14
devanandaShrews: that gets into the finer points of :q || :wq || :q!20:14
JayFI could imagine there being some pluggable way to emit metrics20:14
jrolldevananda: timing data, counters (how many times did x happen), etc20:14
JayFwe'd wanna use statsd, but others could ceilometer, graphite directly, or even some other propreitary format (like going into Rackspace Cloud Monitoring)20:15
devanandaperfect20:15
JayFbut that way you wouldn't vary /what/ you report by /how/ you report it20:15
devanandawere any of you in the ironic/ceilometer joint session?20:15
jrollidk if ceilometer can really handle this sort of thing20:15
JayFdevananda: I was :)20:15
devanandaJayF: o/520:15
JayFdevananda: jroll: I'm not sure ceilometer /wants/ to from what they said in their session20:15
jrollthis would be a metric shitton of notifications20:15
jrollright20:16
devanandaright, so20:16
JayFthey were talking about early-early filtering of stats20:16
devanandaceilometer doesn't want fan speed, cpu temp, etc20:16
JayFwhich operationally is a very, very bad idea20:16
devanandaBUT other folks in openstack-land definitely do want that20:16
JayFIf it can have a number, I want it on a graph somewhere20:16
jrolldevananda: I'm thinking software metrics. 'ipmi power status took 1.24 seconds' etc20:16
JayFI might not need it for 5 years, but when I do, I'll /really/ need it20:16
devanandaceilometer DOES want things like "ironic pwoered this machine on"20:16
devanandajroll: ah20:16
jrolldevananda: think log.debug :)20:17
aweeksdefinitely want to instrument all of the RPC calls20:17
devanandajroll: instrumentation != debugging20:17
devanandaso20:17
devanandathere's another project aiming to gather instrumentation & timing from all projects20:17
devanandaand make that data available for predictive capacity analysis20:17
jrolldevananda: sure, I mean in terms of verbosity20:18
devanandamirantis is leading it IIRC20:18
JayFHonestly, I think I'd still prefer a pluggable mechanism rather than a half-finished new project :/20:18
devananda++20:18
JayFstatsd works today, and is used by boatloads of people to ship off metrics to stuff like graphite20:19
aweekswe ought to be able to build something that would allow for back-ends to be swapped out20:19
JayFaweeks: sounds like you should write a spec about it ;)20:19
aweeksindeed20:20
devanandaaweeks: sounds like you volunteered :)20:20
aweeksyeah, I'm happy to work on it20:20
jroll\o/20:20
JayFaweeks: *honk* *honk* http://bit.ly/1ljQqEz20:20
aweekslol20:21
aweeksso, open a PR here? https://github.com/openstack/ironic-specs20:21
jrollnooooooooooooo20:21
jrollgerrit20:21
jrollsame process as ironic, different repo20:22
aweekskk20:22
jrollthe readme and template there outline what to write etc20:22
JayFaweeks: once you get one started, might want to get it added to the agenda for the next ironic meeting, so people will actually read and review it20:22
jrolls/one started/a review up/20:23
jrollbut yeah20:23
JayFif it's not in a repo || gerrit it doesn't exist20:23
jrollsure20:24
jrollaweeks: going to toss this out here: https://github.com/stackforge/stacktach20:25
jrollok, maybe that's not at all what I thought it was. ignore me.20:28
jrollmaybe.20:28
aweeksjroll: yeah20:29
Shrewsdevananda: i see those meanings as ":q - I'm quitting, but open for discussion", ":wq - I'm quitting, but wrapping things up before I leave", and ":q! - I'm quitting and burning down the building as I walk out."20:32
*** ellenh has joined #openstack-ironic20:33
*** Mikhail_D_ltp has quit IRC20:37
*** datajerk has quit IRC20:39
*** JoshNang has quit IRC20:39
*** tteggel has quit IRC20:39
*** datajerk has joined #openstack-ironic20:40
*** JoshNang has joined #openstack-ironic20:40
*** tteggel has joined #openstack-ironic20:41
jrolldevananda: would you mind putting dmitry's review board in the topic so new people can track it down easily? :) http://perm.ly/ironic-review-dashboard20:51
*** linggao has quit IRC20:55
*** rloo has quit IRC20:56
*** rloo has joined #openstack-ironic20:56
* NobodyCam is back20:56
devanandajroll: how about the etherpad?20:57
jrollwhich etherpad?20:57
jrollwhiteboard?20:57
devanandaya20:57
jrollthat works20:58
devanandacool20:58
jrolldone20:59
jrollthanks :)20:59
NobodyCamdevananda: when you have a free minute, I would love some pointers on correctly mocking ipmitool for testing20:59
*** jdob has quit IRC21:01
*** devananda changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic"21:02
* devananda does a little cleanup on the 'pad21:08
devanandaNobodyCam: not sure what you mean by mocking ipmitool21:09
NobodyCamas expected the ipmitool check on load is failing (see: http://logs.openstack.org/58/96558/17/check/gate-ironic-python27/0351cbc/console.html as example)21:10
*** beecee has quit IRC21:10
devanandayep21:11
devanandaoh that21:11
NobodyCamI started the mock here https://review.openstack.org/#/c/96902/11/ironic/tests/drivers/third_party_driver_mocks.py21:12
devanandaNobodyCam: ipmitool isn't an external library though21:12
*** rloo has quit IRC21:12
devanandait's a system binary21:12
*** mrda-away is now known as mrda21:13
mrdaMorning Ironic!21:13
*** rloo has joined #openstack-ironic21:13
devanandag'morning, mrda !21:13
devanandamrda: did I see that you're confirmed for the midcycle ?21:13
NobodyCammorning mrda21:13
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Replace mknod() with chmod()  https://review.openstack.org/9948421:13
mrdadevananda: as long as I can get a seat on a flight - the airlines are pretty full up :-/21:14
ShrewsNobodyCam: part1 ^^^^21:14
devanandamrda: ugh21:14
NobodyCamnice :)21:14
mrdabut I'm excited about midcycle - looking forward to seeing y'all again21:14
openstackgerritA change was merged to openstack/ironic-python-agent: Fix test_run_image  https://review.openstack.org/9943921:14
*** rloo_ has joined #openstack-ironic21:14
devanandamrda: i hope you make it-- excited to have you joni us!21:15
devanandamikal: hi! considering the close of J1, even though we've had very few reviews of the ironic driver spec, shall we start submitting the patches next week anyway?21:17
ShrewsNobodyCam: still not sure how to handle the use of the sendfile module. but one step at a time i guess21:17
NobodyCamyes ! I'll even say baby steps :)21:18
*** annegentle has quit IRC21:18
*** mat128 has quit IRC21:18
*** davidlenwell has quit IRC21:18
devanandaNobodyCam: gimme a min to mock this mock fo ryou21:18
NobodyCamdevananda: awesome ty :)21:18
*** mmitchell_ has joined #openstack-ironic21:18
*** rloo has quit IRC21:19
*** davidlenwell has joined #openstack-ironic21:19
*** rloo_ has quit IRC21:20
jrollNobodyCam: I would just mock execute(), not ipmitool itself :)21:20
*** rloo has joined #openstack-ironic21:20
mrdaNobodyCam: I was wondering if you could take a look at https://review.openstack.org/#/c/97693 alongside your patch https://review.openstack.org/#/c/85529  They both are proposing the same behaviour but n different places.  Just wondering how we should proceed so we end up with a consistent solution.21:22
NobodyCamhumm so basicly its api vs conductor21:28
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Replace mknod() with chmod()  https://review.openstack.org/9948421:29
*** dwalleck_ has quit IRC21:29
mrdaright, so your patch enforces the behaviour ongoing (if conditions are met) , whereas mine only does it at registration21:29
mrdaand mine addresses the latency concerns of TripleO (ie it'll happen straight up)21:29
*** annegentle has joined #openstack-ironic21:29
devanandahrm, why i dislike module-scoped variables. hard to test chagnes to them in unit tests concurrently21:30
devananda*yet another reason why ..21:30
*** dwalleck has joined #openstack-ironic21:30
devanandahow do I create a mock that passes "if my_mock is None"21:30
mrdabut we can mark my bug as a duplicate and abandon my patch if you think yours is sufficient21:30
NobodyCammrda: I'm thinking21:30
NobodyCamI kinda like the api side21:31
mrdarats :)21:31
NobodyCamwell its really the correct place to set that21:31
NobodyCamand I think the main benefit is the timming thing21:32
mrdaNobodyCam: Lucas had some general comments on my patch that you should read though regarding this behaviour.21:33
NobodyCamreading now21:33
NobodyCamahh where as in 85529 the conductor has already check the creds by getting the current power state21:36
mrdaright21:37
NobodyCams/check/checked/21:37
NobodyCamand he is correct that OOO is seting the state to off right away21:37
NobodyCams/OOO/tripleO/21:39
mrdaI'm not sure how to do a validate in my patch too, as it really belongs in conductor21:39
devanandaNobodyCam: i've side tracked myself trying to create a mock that evaluates true when compared to None21:39
devanandasorry, i'll get back to the actual task21:39
NobodyCamhehehe :-p21:39
*** rwsu_ has quit IRC21:39
NobodyCamya21:39
mrdaunless I do a new RPC *just* to validate21:40
*** ellenh has quit IRC21:40
mrdabut then I might as well do the database work conductor side too21:40
NobodyCamthe more I think about Lucas's comments I am tending to agree with him21:40
mrdaso my bug, which was raised as a result of TripleO latency issues, might need to be resolved as "WONTFIX"21:41
jrollmrda: does your patch actually have a timing impact? if the node is actually powered on, it will be powered off at periodic task time21:41
jroll(in both cases)21:42
*** dkehn has joined #openstack-ironic21:42
mrdajroll: correct, but TripleO's issue was the latency in that behaviour being enforced21:42
*** rwsu has joined #openstack-ironic21:42
jrollmrda: right, but you're just setting database state, it still will be turned off when the periodic task runs. I don't see how that changes the latency21:43
mrda...hence why the explicitly power off newly rgistered nodes, but wanted this to happen automagically inside ironic21:43
jrollor am I misunderstanding21:43
jrollright21:43
jrollI guess I mean compared to NobodyCam's patch21:43
devanandagah. anyone know how to mock a "if VAR is None" check inside a method being unit tested?21:43
devanandaif I mock VAR, it invariably evaluates to "not None"21:44
jrolldevananda: can you point me to the code you're trying to mock?21:44
*** dkehnx has quit IRC21:44
jrolldevananda: easy way out is to make a method that just returns that variable, and mock that method21:44
devanandajroll: https://review.openstack.org/#/c/96902/11/ironic/drivers/modules/ipmitool.py check_timing_support21:45
jroll(assuming you're still talking about the module-level variable21:45
jroll)21:45
devanandajroll: note the use of a module variable. it's easy to set that in the unit test21:45
devanandajroll: the problem is concurrency21:45
mrdaNobodyCam: how should we proceed?  Abandon my patch, link my bug to yours, and move on with your patch being designated as the OneTrueWay(tm)?21:45
devanandawhat if two unit tets try to modify that gloval var simultaneously? -- so we should mock it, great!21:46
devanandaexcept then it fails the "if TIMING_SUPPORT is None" check21:46
devanandaand we cant actually test it21:46
jrolldevananda: this is why we don't use globals :)21:46
devanandaright :)21:46
devanandawell21:46
devanandait'd work fine if we did "if VAR == None"21:46
jrollI understand why we are here21:46
devanandait's easy to mock the __eq__21:46
* devananda injects non-pep8-compliant use of "== None" with a comment21:47
jrolldevananda: https://gist.github.com/jimrollenhagen/9e98956e358d4f15298021:48
jrollis what I would probably do21:48
devanandajroll: ah, good idae21:50
jroll:)21:50
jrollsuper useful for time.time(), that's where I picked it up21:50
NobodyCammrda: yea I think lucas's point about giving the node a valid power state with out actually having checked would be why I would vote to do that in the conductor21:51
mrdaNobodyCam: thanks, I'll go down that path then.21:52
*** ellenh has joined #openstack-ironic21:55
*** romcheg has joined #openstack-ironic21:57
*** romcheg has quit IRC22:01
openstackgerritEllen Hui proposed a change to openstack/ironic: Add more INFO logging to ironic/drivers/modules  https://review.openstack.org/9943122:05
openstackgerritA change was merged to openstack/ironic-python-agent: Tries to advertise valid default IP  https://review.openstack.org/9698022:14
*** max_lobur1 has quit IRC22:21
openstackgerritEllen Hui proposed a change to openstack/ironic: Add more INFO logging to ironic/common  https://review.openstack.org/9949522:22
*** romcheg has joined #openstack-ironic22:24
*** matty_dubs is now known as matty_dubs|gone22:24
JayFellenh: ^^ congrats on becoming an Openstack ATC :)22:27
jroll\o/22:27
ellenhJayF: :D22:27
JayFellenh: that means you get to go to Paris for free!* (*: airfare and lodging and food not included)22:28
jroll(a little bit of food is included)22:28
NobodyCamlol I was just typing that22:28
mdormanthat food in atlanta has got to be about the worst i’ve ever eaten22:28
jrolllol22:29
jrollI ate there once22:29
devanandaJayF: Ithink your congradulations are slightly premature22:29
mdormanexcept those chicken cordon bleu balls were pretty tasty22:29
devanandaJayF: proposing a change != landing a change22:29
devanandathat said, ellenh does have a change in the merge queue right now, which could land today22:29
NobodyCam*thou ++ to who ever sponsored the coffee karts in atlanta22:29
jrolldevananda: https://review.openstack.org/9698022:30
jrollrather22:30
jroll15:14:50 openstackgerrit | A change was merged to openstack/ironic-python-agent: Tries to advertise valid default IP  https://review.openstack.org/9698022:30
mrdaNobodyCam: that was some of the best coffee I've had in the USofA :)22:30
NobodyCammrda: come to seattle!!!22:30
NobodyCamwe have good coffee22:30
jrollmrda: that's sad :P22:30
mrdaNobodyCam: One day I will!  That's one corner I haven't been too - just so long as it's not all Starbucks ;)22:31
mrdajroll: I hate to say it, but coffee in Australia is much better :P22:31
jrollheh22:32
*** dkehn has quit IRC22:32
NobodyCamlol we have lots of starbucks... but also many single owner shops too22:32
jrollmrda: you may not have had the right coffee22:32
NobodyCamprotland not to bad on my coffee list22:32
NobodyCamportland even22:32
mrdaNobodyCam: right! Midcycle.  I might have my first good coffee in the states!22:33
NobodyCam:)22:33
*** romcheg has quit IRC22:33
*** reaper has quit IRC22:34
openstackgerritEllen Hui proposed a change to openstack/ironic: Add more INFO logging to ironic/drivers/modules  https://review.openstack.org/9943122:48
devanandajroll: oh! right22:49
*** romcheg has joined #openstack-ironic22:51
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Let ipmitool natively retry commands  https://review.openstack.org/9690222:52
devanandaNobodyCam: ^^22:52
* NobodyCam looks22:52
NobodyCamahh oh neat-o22:53
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Stop ipmitool.validate from touching the BMC  https://review.openstack.org/9912122:53
devanandaHigh pri bug fix ^22:54
devanandathey kinda both are ...22:54
mrdadevananda: did you see my comment on review 96902 about refactoring the ipmitool code into an oslo library?  What do you think of that idea?22:55
JayFWhy would/should anything but Ironic use ipmitool?22:55
mrdanova-bm support22:56
jrollnooooo22:56
jrolldeprecate it22:56
JayF:(22:56
*** romcheg has quit IRC22:56
jroll(that's the goal of ironic, anyway)22:56
mrdacan't just forget about people who are already using it22:56
jrollright22:56
JayFI'll buy a pizza for both of them22:56
JayF:P22:56
mrdabut I agree - we want everyone to move to ironic :)22:56
jrollthat's why there's a migration plan22:56
jrollslash will be22:56
devanandamrda: so, deprecate it. seriously22:57
*** romcheg has joined #openstack-ironic22:58
devanandamrda: care and feeding during end of life is one thing. creating a new library which we intend, in the long (or mid) term to only have one consumer doesn't make sense22:58
devanandaheading out in a bit ... sorta here for another ~15 min22:59
mrdaok, thanks devananda - that's the direction I was looking for ;)22:59
devanandamrda: i've had frustratingly little traction geting anyone on nova team to review the ironic driver spec22:59
NobodyCambtw, great refactor on the tests ++22:59
devanandamrda: is taht something you might be able to help with?22:59
NobodyCamty22:59
devanandaNobodyCam: yvw23:00
mrdadevananda: I can try23:00
* mrda does a schoolrun, be back soon23:00
*** dwalleck has quit IRC23:01
devanandamrda: https://review.openstack.org/#/c/95024/4 fwiw23:01
devanandaup for 3 weeks now, with only a few nitpicks23:01
jrolldevananda: what's the difference between / and // ?23:02
jrolltotally blanking out here23:02
NobodyCamfloor math23:03
NobodyCam5/2=2.5 vs 5//2=223:03
jrolloh, right23:03
jrollthanks23:03
jrollwell, 5/2==2, 5.0/2==2.5 :)23:03
NobodyCam:-p23:04
devanandajroll: where?23:04
devanandaoh, ya23:04
jrollyeah, I've got it now, makes sense23:04
*** romcheg has quit IRC23:05
NobodyCamjroll: esp with lucas starting https://review.openstack.org/9942623:05
jrollyeah, I was looking at https://review.openstack.org/#/c/96902 though23:06
NobodyCami want 9.754 gb root23:06
NobodyCamya I could tell23:06
jrollI want 100% root23:06
jroll:)23:06
NobodyCamheheheh23:07
comstudr00t23:07
NobodyCamw00t23:07
openstackgerritJay Faulkner proposed a change to openstack/ironic-python-agent: Fix: partitions recently imaged not being detected  https://review.openstack.org/9950423:12
JayFjroll: https://review.openstack.org/#/c/99504/ this is based on my set -e removal patch, because it's in the same file23:12
JayFjroll: but my testing showed without the partprobe it doesn't work :(23:12
jroll... how did it work before?23:13
jrolloh, right, blkid wasn't there23:13
*** rloo has quit IRC23:13
jrollcool23:13
JayFyeah, and apparently parted sees the partitions even if partprobe isn't run23:13
*** rloo has joined #openstack-ironic23:13
NobodyCamomg....23:18
*** romcheg has joined #openstack-ironic23:19
NobodyCamhttp://paste.openstack.org/show/PgPMbdRnkssVCWZiE8vu/23:21
*** mdorman has quit IRC23:22
mrdaNobodyCam: lol23:23
*** romcheg has quit IRC23:23
NobodyCamits just sitting there23:24
* devananda finally goes out for food23:26
devanandasee ya'll tmw!23:26
NobodyCamhave a good night devananda23:26
NobodyCamwhat23:27
NobodyCamit just reset23:27
NobodyCamwtf23:27
*** radsy has joined #openstack-ironic23:36
*** lucas-dinner has quit IRC23:41
*** rloo has quit IRC23:43
*** rloo has joined #openstack-ironic23:43
*** rloo has quit IRC23:45
*** rloo has joined #openstack-ironic23:45
*** romcheg has joined #openstack-ironic23:47
*** romcheg has quit IRC23:51
*** rloo has quit IRC23:56
*** rloo has joined #openstack-ironic23:56
« Tuesday, 2014-06-10 Index Thursday, 2014-06-12 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!