Tuesday, 2014-06-03

jogodevananda: https://review.openstack.org/#/c/43913/00:00
jogois what it should do00:00
devanandajogo: https://github.com/openstack/ironic/blob/master/ironic/nova/virt/ironic/driver.py#L21500:02
devanandalooks like we already do that00:02
jogoyup awesome00:02
jogoI figured you did00:02
devanandacool00:02
jogobut just wanted to double check00:02
devanandajogo: much appreciated00:02
jogodevananda: can you give that patch a quick +100:02
devanandaadded my +100:02
jogosweet thanks00:03
devanandafwiw, we'll need the same patch on https://github.com/openstack/ironic/blob/master/ironic/nova/scheduler/ironic_host_manager.py now00:04
* devananda creates a new wiki page00:10
devanandahttps://wiki.openstack.org/wiki/Ironic/Drivers00:10
*** matsuhashi has quit IRC00:13
openstackgerritRussell Haering proposed a change to openstack/ironic: Log exceptions from deploy and tear_down  https://review.openstack.org/9731800:21
lifelessjogo: is host capabilities what lets vm and bm hypervisors co-exist in one scheduler domain ?00:57
*** ellenh has quit IRC01:00
*** ryanpetrello has joined #openstack-ironic01:05
ryanpetrellohey Ironic folks, anybody know what this keystoneclient failure’s about?01:06
ryanpetrellohttp://logs.openstack.org/44/94244/17/check/gate-pecan-tox-ironic-stable/8afac0e/console.html01:06
ryanpetrellolooks like it was resolved in https://bugs.launchpad.net/ironic/+bug/132465501:07
ryanpetrellomaybe it’s a candidate for backporting, as it’s breaking the pecan tests that are gating on ironic stable/icehouse01:08
devanandaryanpetrello: yep! that looks like it01:09
*** nosnos has joined #openstack-ironic01:09
ryanpetrelloI’ll submit a backport01:09
devanandaryanpetrello: tyvm01:09
ryanpetrellohrm01:15
ryanpetrelloin https://review.openstack.org/#/c/96576/101:15
ryanpetrelloare those config changes applicable to stable/icehouse?01:15
ryanpetrellothe original commit says, “Sample conf needed regenerated, also, due to changes."01:16
ryanpetrellobut I’m unsure what that has to do w/ the test change01:16
devanandaryanpetrello: the keystone change caused the options to change01:25
devanandaryanpetrello: so our unit tests started failing at the same time because of the sample config file check01:26
devanandaryanpetrello: you can regenerate it with tools/conf/generate_sample.sh01:26
devanandaryanpetrello: another solution -- even better actually01:26
devanandaryanpetrello: pin the version of keystoneclient on stable-icehouse01:26
devanandaryanpetrello: the problem is pulling a keystoneclient that's newer than the code in stable-icehouse01:27
devanandaok - heading out for dinner.... ttytm!01:27
ryanpetrellogood point01:27
jogolifeless: not really, host capabilities was an old way of getting info to the sheduler01:50
lifelessjogo: so whats its for now then, I mean?01:58
*** Poornima has joined #openstack-ironic02:09
*** rloo has quit IRC02:11
*** shakamunyi has quit IRC02:31
ryanpetrellodevananda: you sure the appropriate response here is to revert to a previous keystoneclient?02:35
ryanpetrelloit seems like the arguments in question have been that way for some time: https://github.com/openstack/python-keystoneclient/commit/3374e3c2fa30239a131c3815fea8c2694caca22602:36
openstackgerritA change was merged to stackforge/pyghmi: Fix IPv4 operations where v6only behavior is default  https://review.openstack.org/9733302:44
*** coolsvap|afk is now known as coolsvap03:13
jogolifeless: it doesn't do anything, dead code03:18
*** nosnos has quit IRC03:20
*** aswadrangnekar has joined #openstack-ironic03:27
*** eghobo has quit IRC03:47
lifelessjogo: so why the patch at all? Colour me confused.03:58
*** nosnos has joined #openstack-ironic04:00
*** k4n0 has joined #openstack-ironic04:11
jogolifeless: remove dead code so we don't confuse folks inthe  the future04:23
lifelessack04:24
*** sabah has joined #openstack-ironic04:29
*** eghobo has joined #openstack-ironic04:42
*** rameshg87 has joined #openstack-ironic04:47
*** harlowja is now known as harlowja_away04:48
*** JoshNang has quit IRC05:19
*** rakesh_hs has joined #openstack-ironic05:25
*** jcoufal has joined #openstack-ironic05:41
*** lazy_prince has joined #openstack-ironic05:55
*** coolsvap is now known as coolsvap|afk05:56
*** coolsvap|afk is now known as coolsvap06:01
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/9606306:03
*** sysexit has joined #openstack-ironic06:05
*** ccit has joined #openstack-ironic06:11
*** kevinbenton has quit IRC06:19
GheRiveromorning all06:21
openstackgerritChristian Berendt proposed a change to openstack/ironic: Test for membership should be 'not in'  https://review.openstack.org/9741206:23
*** radsy has quit IRC06:39
*** max_lobur has joined #openstack-ironic06:41
*** pradipta_away is now known as pradipta06:44
*** coolsvap is now known as coolsvap|afk06:57
*** coolsvap|afk is now known as coolsvap07:02
lifelessNobodyCam: still around ?07:05
*** eghobo has quit IRC07:18
*** romcheg has joined #openstack-ironic07:20
*** yuriyz has joined #openstack-ironic07:24
*** JoshNang has joined #openstack-ironic07:26
*** Mikhail_D_ltp has joined #openstack-ironic07:36
Mikhail_D_ltpGood morning all! :)07:39
romchegMornind Mikhail_D_ltp and everyone else!07:40
*** mrda is now known as mrda-away07:40
*** martyntaylor has joined #openstack-ironic07:41
*** jistr has joined #openstack-ironic08:03
*** ndipanov has joined #openstack-ironic08:07
*** sysexit has quit IRC08:08
dtantsur|afkmorning Ironic, morning Mikhail_D_ltp and romcheg!08:12
Mikhail_D_ltpdtantsur|afk: morning :)08:13
*** dtantsur|afk is now known as dtantsur08:13
*** derekh_ has joined #openstack-ironic08:20
*** coolsvap is now known as coolsvap|afk08:24
dtantsurromcheg, around?08:25
dtantsurromcheg, Mikhail_D_ltp, I would like to try land https://review.openstack.org/#/c/86536/ this morning08:25
*** lucasagomes has joined #openstack-ironic08:26
dtantsuroh, lucasagomes, hi! Maybe we'll use you, if romcheg is not around :)08:27
dtantsurI would like to try and land  https://review.openstack.org/#/c/86536/ this morning08:27
lucasagomesdtantsur, :) sure08:28
dtantsurlet us see, what we have there, while we're waiting for Jenkins08:28
lucasagomeswill review it08:28
dtantsurlucasagomes, my suggestion is to -1 only on something serious, while keeping nits for anything later08:30
dtantsuras this series is around for too long already :-/08:30
lucasagomesdtantsur, right, well we def need to change the commit message then08:31
lucasagomespart 2 is not merged08:31
dtantsurMikhail_D_ltp, ^^^08:31
lucasagomesmerging part 1 and part 3 but no part 2 is very awkward08:31
openstackgerritSandhya Balakrishnan proposed a change to openstack/ironic: Updates Ironic Guide with deployment information  https://review.openstack.org/9460408:32
lucasagomesdtantsur, what happened with part 2?08:33
dtantsurlucasagomes, it is around, but has lower priority08:33
lucasagomeswe can change the commit message for Mikhail_D_ltp if needed, I'm just trying to understand why the dependency was removed from p208:33
dtantsurlucasagomes, because this one touches nova driver08:33
lucasagomesah08:33
lucasagomesright makes sense08:33
*** max_lobur has quit IRC08:34
Mikhail_D_ltplucasagomes: Ok,  I'll change name for this patch :)08:34
lucasagomesMikhail_D_ltp, I know it's a kind of nit, but that would look very odd in the log08:35
dtantsurMikhail_D_ltp, test__stop_firewall is not converted. Is it possible to quickly convert as well?08:35
dtantsurMikhail_D_ltp, also don't remember, was it possible to convert test_list_instance_uuids?08:36
dtantsurlucasagomes, should we insist on these ^^^ ? I'm ok with fixing the remaining in one more patch08:37
lucasagomesdtantsur, yeah it's fine for me to have a following patch as well if needed08:37
lucasagomesif it's quick and u want to fix it in this patch I would be glad, but if not I'm ok with it as well08:38
dtantsurMikhail_D_ltp ^^^08:38
dtantsurbtw tests passed for me locally. hipe Jenkins will be ok as well08:38
dtantsur* hope even08:38
Mikhail_D_ltpdtantsur: yeah, I'm rebasing now.08:39
dtantsurMikhail_D_ltp, patch looks good to me. Let me know, when you fix what Lucas found, I'll +2 it.08:40
Mikhail_D_ltpOk :)08:40
*** sabah has quit IRC08:42
*** sysexit has joined #openstack-ironic08:44
*** coolsvap|afk is now known as coolsvap08:46
*** romcheg has quit IRC08:49
dtantsurrandom Jenkins failures become more and more annoying >_<08:55
*** Mikhail_D_ltp has quit IRC08:58
lucasagomesdtantsur, +1!!!!!!!08:58
dtantsurwe can't land 0-line patch for 2 days already...08:59
dtantsurlucasagomes, to top it all, we fixed only one kind of NodeLocked problems, we still have more possibility09:00
dtantsurMikhail_D_wk, how are things with the patch? As you see, we have troubles landing things due to random test failures...09:01
dtantsurlucasagomes, in the meanwhile, may I ask you for update on https://bugs.launchpad.net/ironic/+bug/1301279 ?09:03
dtantsurlucasagomes, ... and https://bugs.launchpad.net/ironic/+bug/130868009:04
*** Mikhail_D_ltp has joined #openstack-ironic09:04
lucasagomesdtantsur, yeah I saw ur comment I'm going to reply it09:05
*** yfujioka has joined #openstack-ironic09:05
dtantsurthanks a lot :)09:05
lucasagomesyesterday it was holiday here so I'm trying to catch up with everything yet09:05
* dtantsur is going to annoy people a lot this week ^_^09:05
lucasagomesheh no worries09:05
Mikhail_D_wkdtantsur: I'm a bit stuck with test_list_instance_uuids09:07
dtantsurMikhail_D_ltp, than skip it please. We can do it later09:08
Mikhail_D_wkок09:08
*** igordcard has joined #openstack-ironic09:09
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 2  https://review.openstack.org/8653609:11
dtantsurlucasagomes, ^^^09:13
lucasagomesMikhail_D_ltp, dtantsur cool will take a look in a min09:13
*** pelix has joined #openstack-ironic09:14
*** pradipta is now known as pradipta_away09:15
dtantsurlucasagomes, I'm ok, just approve, when you're ok with it as well09:15
lucasagomesdtantsur, Mikhail_D_ltp done, thanks for convertng the firewall test as well09:20
dtantsurthanks guys \o/09:20
dtantsurhope it gets merged eventually :D09:20
Mikhail_D_ltpThank you guys for review.09:22
*** shausy has joined #openstack-ironic09:38
*** ifarkas has joined #openstack-ironic09:46
openstackgerritHans Lindgren proposed a change to openstack/ironic: Fix host manager node detection logic  https://review.openstack.org/9744710:10
*** max_lobur has joined #openstack-ironic10:15
dtantsurMikhail_D_ltp, if you want to have some more tests refactoring, welcome here: https://bugs.launchpad.net/ironic/+bug/1325906 :)10:16
openstackgerritAnusha Ramineni proposed a change to openstack/ironic-specs: Add design spec for iLO Power Driver  https://review.openstack.org/9745510:17
*** romcheg has joined #openstack-ironic10:18
romchegdtantsur: Morning, sorry, meeting at the bank took longer than I expected10:22
dtantsur:)10:22
*** coolsvap is now known as coolsvap|afk10:24
dtantsurfolks, there was a discussion about paramiko and evenlet some time ago: https://bugs.launchpad.net/ironic/+bug/132178710:28
dtantsuranyone remembers the outcome?10:28
lucasagomesdtantsur, hmm I don't remember any real outcome, I remmeber the sahara project had the same problem10:32
lucasagomesand the way they solved was having the ssh commands in a subprocess or something like that10:32
lucasagomesdtantsur, https://review.openstack.org/4571610:32
dtantsurlucasagomes, thanks!10:33
dtantsurJoshNang, hi, could you fix status on https://bugs.launchpad.net/ironic/+bug/1308199 https://bugs.launchpad.net/ironic/+bug/1323781 and https://bugs.launchpad.net/ironic/+bug/1323783 ?10:39
dtantsurJoshNang, on the last meeting we decided not to keep bugs assigned w/o patch for more than 7 days. Also, assigned bugs should likely be "In Progress", not "New"10:40
*** takadayuiko has quit IRC10:43
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Implement security groups and firewall filtering methods  https://review.openstack.org/9646610:43
*** takadayuiko has joined #openstack-ironic10:51
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Return the HTTP Location for accepted requestes  https://review.openstack.org/9261610:53
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Return the HTTP Location for newly created resources  https://review.openstack.org/9261510:53
*** k4n0 has quit IRC11:02
NobodyCamGood morning Ironic11:05
lucasagomesmorning NobodyCam11:07
NobodyCamwe're in North platte Ne11:08
lucasagomesNobodyCam, :) nice! right in the middle of the coutry11:09
lucasagomesNobodyCam, where are you guys heading now?11:10
NobodyCamon cheyenne wyoming11:12
NobodyCamon to ..11:12
lucasagomes:)11:14
*** praefect has joined #openstack-ironic11:17
NobodyCamlol trying to get ahead of the really bad weather11:17
*** lucasagomes is now known as lucas-hungry11:22
*** rameshg87 has left #openstack-ironic11:23
NobodyCamopen quiestion.. do we support ipv6?11:25
dtantsurmorning NobodyCam11:25
NobodyCamgood morning dtantsur11:25
dtantsurNobodyCam, not yet, I guess11:25
NobodyCam:/11:26
dtantsurNobodyCam, there were some work on DevStack, IIRC11:26
dtantsuryou need it?11:26
NobodyCamwe will11:27
dtantsuroh11:27
*** dtantsur is now known as dtantsur|lunch11:28
NobodyCamhttp://www.weather.com/news/tornado-central/severe-weather-tracker-page11:30
NobodyCamwoo hoo, we in North Platte trying to make it to chenneye wy today11:30
NobodyCamand https://bugs.launchpad.net/ironic/+bug/132594211:33
*** matsuhashi has joined #openstack-ironic11:34
*** Poornima has quit IRC11:37
agordeevgood morning everyone!11:39
agordeevNobodyCam: dtantsur|lunch lucas-hungry :)11:39
NobodyCammorning agordeev11:40
*** lazy_prince has quit IRC11:47
*** Jatin360 has joined #openstack-ironic11:49
*** dtantsur|lunch is now known as dtantsur11:53
dtantsuragordeev, morning11:53
NobodyCamok going to start packing up. will be back once we land in Wy11:54
*** Jatin360 has quit IRC11:56
dtantsurNobodyCam, good luck! When you're back, could you please give status update on https://bugs.launchpad.net/ironic/+bug/1300589 ?12:00
*** romcheg1 has joined #openstack-ironic12:01
*** romcheg has quit IRC12:03
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 3  https://review.openstack.org/7325612:03
*** romcheg has joined #openstack-ironic12:04
*** romcheg1 has quit IRC12:05
*** jdob has joined #openstack-ironic12:20
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 1  https://review.openstack.org/6002512:29
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Old value 'updated_at' field returned after update  https://review.openstack.org/7543012:40
*** krtaylor has quit IRC12:45
*** radsy has joined #openstack-ironic12:46
*** radsy has joined #openstack-ironic12:46
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: PXE driver to validate the requested image in Glance  https://review.openstack.org/9671012:52
*** jcoufal has quit IRC12:52
*** jcoufal has joined #openstack-ironic12:53
*** lucas-hungry is now known as lucasagomes12:53
*** takadayuiko has quit IRC12:55
*** jistr has quit IRC12:57
*** praefect has quit IRC12:59
*** Alexei_987 has joined #openstack-ironic12:59
*** praefect has joined #openstack-ironic13:00
*** jistr has joined #openstack-ironic13:01
*** openstackgerrit has quit IRC13:06
*** openstackgerrit has joined #openstack-ironic13:07
*** rloo has joined #openstack-ironic13:09
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic-specs: Add instance_info field to Node model  https://review.openstack.org/9570113:10
*** matsuhashi has quit IRC13:12
*** nosnos has quit IRC13:12
*** rloo has quit IRC13:14
*** rloo has joined #openstack-ironic13:15
*** linggao has joined #openstack-ironic13:16
*** matty_dubs|gone is now known as matty_dubs13:23
*** rloo has quit IRC13:23
*** rloo has joined #openstack-ironic13:23
jrollmorning y'all13:24
jrolllucasagomes: around?13:24
romchegMorning jroll, lucasagomes!13:24
jrollheya romcheg13:25
*** rloo has quit IRC13:25
dtantsurmorning, jroll!13:25
jroll\o dtantsur13:25
sysexitmorning Ironic13:26
dtantsursysexit, morning13:26
*** rloo has joined #openstack-ironic13:26
lucasagomesmorning all13:26
lucasagomesjroll, hey yes13:26
jrollhey!13:26
lucasagomesI will brb for 2 min to get a cup of coffee13:26
jrollno worries13:26
jrollabout https://review.openstack.org/#/c/97361/13:26
sysexitSo I have a "pxe_ravello" driver that supports provisioning via PXE and power mgmt/console.  It can be found here: https://github.com/ravello/ironic/commit/dff1e3a220da13800c126db2f01bdeeaa0eda67213:27
jrollI don't think the option itself is confusing to users, but I think the behavior is13:27
sysexitQuestion is now, what to do with it? :)13:27
sysexitLast time there were some concerns adding drivers for non-physical hardware.13:28
jrolllucasagomes: imagine you don't know about the option, you register your nodes in ironic, and suddenly they power off13:28
jrolllucasagomes: especially in the context of upgrading from nova-bm13:28
jrollsysexit: nice! do you know about openstack's review process?13:29
linggaomorning Ironic.13:30
jrollhiya linggao13:30
dtantsursysexit, I guess you start with writing a spec and also determining, if it's possible to create CI for this method13:30
romchegMorning linggao!13:30
dtantsurmorning, linggao13:30
linggaoHi romcheg  jroll dtantsur13:30
linggaoI got the following error from Jekins for my patch "Requirement pyghmi>=0.6.11 does not match openstack/requirements value pyghmi>=0.5.8"13:31
*** shausy has quit IRC13:31
linggaodoes anyone know which project does openstack/requirements come from.13:32
sysexitjroll, dtantsur, I think I understand the review process. I've never submitted anything but I read the docs.13:32
linggaodevananda added it for me last year. I need to update it.13:32
romcheglinggao: https://github.com/openstack/requirements13:32
sysexitdtantsur, where can I find more info about the spec process?13:33
jrolllinggao: what patch? (also, don't get me started on the global requirements thing)13:33
romcheglinggao: you can find global-requirements.txt there13:33
*** jbjohnso has joined #openstack-ironic13:33
sysexitspec process seems to be in flux13:33
jrollsysexit: https://github.com/openstack/ironic-specs13:33
*** jgrimm has joined #openstack-ironic13:33
jrollsysexit: it's more solid at this point13:33
lucasagomesjroll, yeah I can see ur point, I will try to find the reasoning around that options I'm sure there were a bunch of chats about whether it should be the default behavior or not13:34
dtantsursysexit, this may help https://github.com/openstack/ironic-specs/blob/master/specs/template.rst13:34
linggaoromcheg, jroll. Yes, it is the global requirements. It took long time to get through13:34
jrollsysexit: as far as the actual review process etc, https://wiki.openstack.org/wiki/How_To_Contribute and https://wiki.openstack.org/wiki/Gerrit_Workflow13:34
jrolllucasagomes: cool. I'm fine with it staying as is, but it's something that surprised the heck out of me recently (and I even knew the option existed)13:35
sysexitjroll: thx - IIUC, the first thing is to write a spec, and then submit a Gerrit review request?13:35
sysexitThe spec, do I simply submit a PR against ironic-specs?13:36
sysexitOr that goes via Gerrit as well?13:36
dtantsursysexit, yes, via gerrit13:36
jrolllucasagomes: especially when initially deploying, and poking things manually to make sure everything works correctly, that default is painful13:36
sysexitOK, so two Gerrits :)13:36
sysexitFor the spec and for the impl.13:36
lucasagomesjroll, http://paste.openstack.org/show/82594/13:37
jrollsysexit: yeah, generally - submit a spec and a placeholder blueprint (https://blueprints.launchpad.net/ironic/) at the same time. once the spec is merged in gerrit, update the blueprint with a link to it. then put up the code patch, the spec will be approved and targeted to a release. then the code is reviewed.13:37
sysexitjroll, thx! ill do that13:38
jrolllucasagomes: ah yeah. I remember that.13:39
jroll<lifeless>      devananda: and the admin goes 'fuck yeah, automation'13:39
jrollI disagree13:39
lucasagomesright, as I pointed on that patch I'm not the guy with most hands on experience in the datacenter, but as we had a blueprint and discussions about it13:39
lucasagomesI thought that the current default was already sorted out13:40
jrollyeah, you make a fair point13:40
lucasagomesjroll, do you think that having a ML discussion about it would be better?13:40
jrollmaybe13:40
jrollI mean, I really don't care at this point13:40
lucasagomescause although we put that as default True, we don't have it documented anywhere apart from random IRC logs13:40
jrollbecause we now have that set to False in our automation :)13:41
jrollso it's settled for me13:41
lucasagomesright, I will just add lifeless and devananda to ur patch then and have them to take a look13:41
jrolljust - "think of the users!" is my mindset13:41
*** jistr has quit IRC13:41
lucasagomesgotcha13:41
jroll:P13:41
*** jistr has joined #openstack-ironic13:42
lucasagomesheh these conversations are kinda complicated heh there's no wrong or right I suppose.... some users will say "fuck yeah automation" others will be like "wtf"13:42
lucasagomesI guess13:43
lucasagomesheh13:43
jrollright13:43
jrollI already have scripts to power on/off all nodes13:43
jrollbecause I need them regardless13:43
jrollbut that may be unique to the 'long-running agent' model13:44
*** radsy has quit IRC13:49
*** shakamunyi has joined #openstack-ironic13:51
*** foexle has joined #openstack-ironic13:58
*** Isotopp has joined #openstack-ironic13:59
*** jdob_ has joined #openstack-ironic14:00
IsotoppHello. Is there some component or plugin that is part of ironic and that takes part of doing HP firmware updates,14:02
Isotoppsuch as ilo, disk controller firmware or bios flashes?14:02
*** praefect has quit IRC14:02
*** jcoufal has quit IRC14:03
Isotoppthat is, helps to automate the initial install of masses of new hardware whcih may or may not be up to date?14:03
*** linggao has quit IRC14:04
*** mat128 has joined #openstack-ironic14:05
dtantsurIsotopp, hi. I guess there's some work on ilo, see spec https://review.openstack.org/9745514:07
dtantsurnothing seems to be ready-to-use14:07
Isotoppthank you, i will have a look14:08
dtantsurFolks, it's hard to stop, and now I have a new version of dashboard, which satisfies me, and I hope will satisfy rloo and Shrews: http://perm.ly/ironic-review-dashboard14:09
dtantsur(and yes, it has a nice short link)14:09
dtantsurMind having a look?14:09
* matty_dubs starts a dashboard listing dtantsur's dashboards14:09
matty_dubs+1 for adding "My Patches Requiring Attention"14:10
rloodtantsur: so you added a 'Needs Reverify' section?14:10
romcheg+114:10
dtantsurrloo, that's one of the most important points. Also your patches include WIP. Also WIP+nonverified section in the end14:10
dtantsurand specs also include WIP (arguable)14:11
*** jdob_ has quit IRC14:11
dtantsurthat's also to address sdague's review comments14:11
rloodtantsur: looks good. I'm fine with it.14:12
dtantsurwow! at this rate we end up with one version only :)14:12
*** praefect has joined #openstack-ironic14:12
rloodtantsur: One thing I wondered. the 'Needs Approval' includes 'Needs one more +2' as well. It is fine with me as-is, just wondering if others understand it.14:12
rloodtantsur: are you telling me you like this too? :D14:13
dtantsurrloo, yes, it's my first version updated and I like it :)14:13
dtantsurrloo, I always assumed that +A requires +2 first14:14
rloodtantsur: well, +A requires two +2s first ;)14:15
*** praefect1 has joined #openstack-ironic14:15
rloodtantsur: there are cases where some reviews have two or more +2s and really only need the approval ;)14:15
rloodtantsur: anyway, i am fine the way it is. Just wanted to mention it.14:16
dtantsurrloo, well... yes, but I hope common sense will help in all these cases :)14:16
dtantsurok, I'll post this one for review14:16
*** praefect has quit IRC14:16
rloodtantsur: yup ;)14:17
*** pradipta_away is now known as pradipta14:23
*** praefect1 has quit IRC14:36
*** uberj has quit IRC14:39
openstackgerritVictor Sergeyev proposed a change to openstack/ironic: WIP: use paramiko channel to run ssh command  https://review.openstack.org/9752314:48
*** praefect has joined #openstack-ironic14:53
*** rakesh_hs has quit IRC14:55
*** rloo has quit IRC14:56
*** rloo has joined #openstack-ironic14:56
*** igordcard has quit IRC14:56
*** rloo has quit IRC14:57
openstackgerritAnusha Ramineni proposed a change to openstack/ironic-specs: iLO Power Driver for Ironic  https://review.openstack.org/9745514:57
*** rloo has joined #openstack-ironic14:57
*** rloo has quit IRC14:59
*** rloo has joined #openstack-ironic15:00
*** jcoufal has joined #openstack-ironic15:02
*** jcoufal has quit IRC15:03
*** jcoufal has joined #openstack-ironic15:03
*** rloo has quit IRC15:04
*** rloo has joined #openstack-ironic15:04
*** yfujioka has quit IRC15:08
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add/Update docstrings in the Nova Ironic Driver  https://review.openstack.org/9753615:16
*** jistr has quit IRC15:25
*** Mikhail_D_ltp has quit IRC15:26
*** romcheg has quit IRC15:29
*** rloo has quit IRC15:29
*** rloo has joined #openstack-ironic15:30
*** eghobo has joined #openstack-ironic15:44
*** romcheg has joined #openstack-ironic15:55
*** pradipta is now known as pradipta_away15:55
*** max_lobur has quit IRC15:56
*** matty_dubs is now known as matty_dubs|lunch15:57
*** derekh_ has quit IRC16:00
devanandamorning, all16:00
rloomorning devananda!16:02
*** martyntaylor has left #openstack-ironic16:02
*** jrist-afk is now known as jrist16:04
*** pelix has quit IRC16:08
*** pelix has joined #openstack-ironic16:09
devanandaIsotopp: hi! so there is the iLO driver work, specific to HP hardware, for out-of-band updates to firmware (eventually, I haven't seen any code for that yet). There is the IPA (ironic-python-agent) work, which aims to use an agent to do in-band updates of firmware, etc16:11
devananda*And there is ...16:11
dtantsurmorning, devananda16:12
dtantsurbrb16:12
*** dtantsur is now known as dtantsur|afk16:12
devanandadtantsur: ++ for putting "my patches needing attention" at the top16:12
dtantsur|afkdevananda, good! I got this merged to sdague's repo, will post to ML as well later16:13
*** pelix has quit IRC16:13
*** pelix has joined #openstack-ironic16:14
*** hemna has joined #openstack-ironic16:17
*** ellenh has joined #openstack-ironic16:18
*** Alexei_987 has quit IRC16:28
devanandagotta catch a ride, will bbi30m16:32
*** dwalleck has joined #openstack-ironic16:35
*** hemna has quit IRC16:43
*** harlowja_away is now known as harlowja16:45
*** dwalleck has quit IRC16:47
NobodyCamgood morning from cheyenne16:47
*** hemna has joined #openstack-ironic16:49
ryanpetrelloironic folks - any insight into the failure seen here? https://review.openstack.org/#/c/97475/16:49
rlooryanpetrello: i've seen a bunch failing but haven't looked into it. Some people have been doing a 'recheck bug 1325689' but i don't know if that helps or not.16:53
ryanpetrellookay, cool16:54
ryanpetrellolooks like there’s a bug for it16:54
ryanpetrellothanks!16:54
*** ramineni has joined #openstack-ironic16:56
lucasagomesmorning rloo devananda :)16:57
openstackgerritRuby Loo proposed a change to openstack/ironic: VendorPassthru.validate()s call _parse_driver_info  https://review.openstack.org/9755816:58
rloohi lucasagomes16:58
Isotoppdevananda: hi there. thanks. i will try to find all this and have a look at it16:58
Isotopp... tomorrow, though16:58
*** ifarkas has quit IRC17:02
*** lucasagomes is now known as lucas-dinner17:04
NobodyCammorning rloo lucas-dinner and devananda17:05
rloohiya NobodyCam in cheyenne ;)17:05
NobodyCam:)17:05
NobodyCamshould be out of tornado range now17:05
NobodyCamlol17:05
rloowhew!17:06
openstackgerritAnusha Ramineni proposed a change to openstack/ironic-specs: iLO Power Driver for Ironic  https://review.openstack.org/9745517:06
*** ramineni has left #openstack-ironic17:09
*** rloo has quit IRC17:12
*** rloo has joined #openstack-ironic17:12
*** rloo has quit IRC17:12
*** rloo has joined #openstack-ironic17:13
Shrewsdevananda: did you write this regex? b/c it's making my head hurt. https://github.com/openstack-infra/config/blob/master/modules/openstack_project/files/jenkins_job_builder/config/devstack-gate.yaml#L587-L60217:18
*** shakamunyi has quit IRC17:24
*** rloo has quit IRC17:24
*** rloo has joined #openstack-ironic17:24
*** matty_dubs|lunch is now known as matty_dubs17:27
*** jogo has left #openstack-ironic17:28
*** ellenh has quit IRC17:31
devanandaShrews: that's adam_g's handiwork :)17:38
*** eghobo has quit IRC17:39
openstackgerritRussell Haering proposed a change to openstack/ironic: Log exceptions from deploy and tear_down  https://review.openstack.org/9731817:39
Shrewsadam_g: to pick up our new advanced scenario tests, looks like i need to change the last regex to this?   r="$r tempest.scenario.test_baremetal_*"17:41
* Shrews not sure how one would test that17:42
*** zdin0bot has joined #openstack-ironic17:44
devanandaShrews: i'm not sure we /can/ test that today. do you have a patch for that change up? if so, we should ask in -infra17:45
*** rloo has quit IRC17:46
*** rloo has joined #openstack-ironic17:46
Shrewsdevananda: not yet. sean mentioned i needed to change it first before https://review.openstack.org/94439 can be merged17:46
Shrewsbut i need to run to a high school graduation now, so i can check with infra when i return17:47
devanandaShrews: ah, yep. sdague is right. change regex -> observe that the new tests in the patch run in the check queue -> make sure they pass -> land changes to tempest17:49
devanandaShrews: if we were to land the tempest changes /before/ making the change to infra, we could break our gate for a while17:50
devanandaif the tests didn't pass once they were enabled17:50
Shrewsdevananda: yeah. i just didn't know about that regex until today17:50
Shrewsanyway, bbl17:50
devanandaciao17:50
NobodyCamhave a good time Shrews17:51
adam_gShrews, you should be able to test that regex just passing it to testr17:51
adam_gtestr list-tests $REGEX17:51
NobodyCamwoo hoo we could be HOME as soon as Sunday!17:56
devanandaNobodyCam: \o/17:57
NobodyCam:)17:57
devanandaNobodyCam: also, you have email from me yesterday afternoon. do you have a minute to reply?17:58
NobodyCamoh devananda just fyi I am rebuilding my tox env as soon as I have the tests working I have the dont remake partitions when preserve_ephemeral is set patch ready to go17:59
devanandaack17:59
NobodyCamdevananda:  meetup timing email?18:01
*** ndipanov has quit IRC18:04
devanandaNobodyCam: ya18:04
NobodyCamdropped.. :-p18:12
NobodyCamyes I will :)18:12
*** ifarkas has joined #openstack-ironic18:13
NobodyCamdevananda: quick reply sent :-p18:20
NobodyCamwoo hoo py27: commands succeeded18:21
NobodyCam:-p18:21
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk  https://review.openstack.org/9313318:29
openstackgerritChris Krelle proposed a change to openstack/ironic: Rework make_partitions logic when preserve_ephemeral is set  https://review.openstack.org/9759018:31
NobodyCamlifeless: devananda: ^^^^^^18:31
NobodyCambrb18:33
*** zdin0bot has quit IRC18:36
*** romcheg has quit IRC18:36
*** max_lobur has joined #openstack-ironic18:42
NobodyCamoh so nice to yet another timezone closer to home18:49
*** rloo has quit IRC18:50
devanandaNobodyCam: did you see lifeless' previous comment on ^ ?18:50
devanandaon 9313318:50
*** rloo has joined #openstack-ironic18:51
*** sysexit has quit IRC18:53
*** sysexit has joined #openstack-ironic18:54
NobodyCamoh poop18:56
NobodyCamfixing :-p18:57
*** pelix has quit IRC19:00
*** jistr has joined #openstack-ironic19:02
*** derekh_ has joined #openstack-ironic19:02
*** rloo has quit IRC19:09
*** rloo has joined #openstack-ironic19:09
openstackgerritChris Krelle proposed a change to openstack/ironic: Rework make_partitions logic when preserve_ephemeral is set  https://review.openstack.org/9759019:09
devanandalucas-dinner: i'm not sure what this is doing yet, but it may be interesting for you re: json patch support in pecan -- https://github.com/stackforge/designate/blob/master/designate/api/v2/controllers/records.py#L10219:14
devanandahttps://github.com/stackforge/designate/blob/master/designate/api/v2/patches.py19:15
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk  https://review.openstack.org/9313319:18
NobodyCamok I think that should be right19:19
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk  https://review.openstack.org/9313319:20
* NobodyCam tries the change commit message via web interface19:21
NobodyCam:-p19:21
NobodyCamdevananda: lifeless: order should be correct now... 93133 depends on 9759019:21
NobodyCam:-19:21
*** rloo has quit IRC19:23
*** rloo has joined #openstack-ironic19:23
*** rloo has quit IRC19:23
*** rloo has joined #openstack-ironic19:24
NobodyCamdoh19:24
*** rloo has quit IRC19:25
*** rloo has joined #openstack-ironic19:25
* devananda gets lunch and relocates... back soon19:26
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk  https://review.openstack.org/9313319:26
NobodyCamand now with working test too19:27
NobodyCam:-p19:27
NobodyCamohh zuul gone nuts19:30
*** aswadrangnekar has left #openstack-ironic19:36
openstackgerritJay Faulkner proposed a change to openstack/ironic-python-agent: Allow configdrive partition to be precreated  https://review.openstack.org/9596919:46
JayFdtantsur|afk: ^ when you get a chance, addressed your comments there. LMK what you think. Also we all are appreciative of the review attention you've been giving IPA, so thanks :)19:47
NobodyCamdevananda: have you seen the comments on https://review.openstack.org/#/c/96558/11/ironic/drivers/modules/ipmitool.py19:47
JayFNobodyCam: those comments look like someone working under python 3, at least a lot of the comments are similar to the things I had to fix when trying to get py3 support for IPA (although it still doesn't work, because eventlet :X)19:48
NobodyCamahh19:48
JayFthat's just a guess though :)19:48
NobodyCamwhat I find odd id the comments seem to on code out side that patch19:49
NobodyCams/id/is/19:49
NobodyCamJayF: would you mind adding that as a comment to the patch so its logged there19:51
JayFIt's a wild guess, hence why mentioning it here instead of there :)19:51
JayFnot actual knowledge, just pattern matching :)19:51
NobodyCam:) ahhh19:51
*** ellenh has joined #openstack-ironic19:53
*** pbrooko has joined #openstack-ironic19:58
NobodyCambrb20:00
openstackgerritJay Faulkner proposed a change to openstack/ironic-python-agent: Readme should point to Openstack, not travis-ci  https://review.openstack.org/9761120:01
devanandaNobodyCam: looks like comments are meant for the dependent patch (mine)20:04
devanandaNobodyCam: also, we should really test those before landing them :p20:04
*** derekh_ has quit IRC20:08
NobodyCamdevananda: yes. :-p20:11
*** jcoufal has quit IRC20:15
*** ifarkas has quit IRC20:15
*** romcheg has joined #openstack-ironic20:19
*** jistr has quit IRC20:20
*** ellenh has quit IRC20:23
*** praefect has quit IRC20:33
*** jbjohnso has quit IRC20:39
*** ellenh has joined #openstack-ironic20:47
*** romcheg has left #openstack-ironic20:53
*** praefect has joined #openstack-ironic20:55
*** jdob has quit IRC21:00
*** igordcard has joined #openstack-ironic21:03
*** dhellmann has quit IRC21:11
*** dhellmann has joined #openstack-ironic21:13
*** Faizan has joined #openstack-ironic21:15
*** Faizan has quit IRC21:15
*** sysexit has quit IRC21:21
*** foexle has quit IRC21:25
openstackgerritlinggao proposed a change to openstack/ironic: Test fake console driver  https://review.openstack.org/9762921:28
openstackgerritRussell Haering proposed a change to openstack/ironic-python-agent: Add missing methods to base HardwareManager class  https://review.openstack.org/9763121:31
*** matty_dubs is now known as matty_dubs|gone21:32
*** mrda-away is now known as mrda21:58
mrdaMorning Ironic!22:02
NobodyCamgood morning mrda22:02
devanandamorning, mrda !22:06
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Mock seamicroclient lib in unit tests if not present  https://review.openstack.org/9017422:14
*** ccit has quit IRC22:23
*** hemna has quit IRC22:27
NobodyCamdevananda: is 96902 on your plate?22:28
devanandaNobodyCam: was just looking at that22:28
NobodyCam:) something about great minds and alike :-p22:29
devanandathoughts on support for older ipmitool?22:29
NobodyCamI thihk we should.22:30
NobodyCamthe first versions I put up had most of the logic to do the looking with in the code22:31
NobodyCami kinda think it worth taking the hit on code and looping but be able to support a wider (version) of ipmitool22:32
NobodyCams/looking/looping/22:33
devanandaNobodyCam: except ipmitool *does* that looping *anyway*22:33
devanandaeven if we don't pass the options22:33
devanandaso doing it the originally proposed way is actually sending more IPMI packets than it appears to be22:34
NobodyCam*if the ipmitool version supports it22:34
* NobodyCam is thinking of ways of autodetecting ipmi versions22:34
NobodyCam:-p22:35
devanandaNobodyCam: that's certainly possible, but i'm concerned about marking the bug fixed when it's not22:36
devanandafixed for older versions of ipmitool22:36
NobodyCamif we detected support for -N -R we could then set them and not loop22:37
NobodyCamourselfs22:37
NobodyCamsomething simple like ipmitool --help|grep '\-N'22:38
NobodyCamif found set -n / r else loop in code22:38
NobodyCamthat way we are "excluding" anyone22:40
NobodyCams/anyone/distro's/22:40
mrdaI think that makes sense.22:40
JayFI wish it wasn't considered reasonable to run old software that doesn't support things like the -N/-R options for ipmitool :(22:41
JayFsomeone else already fixed it and went through that effort, seems crazy that we have to fix it too22:41
NobodyCamJayF: and you cann't check the version number because I have a 2.86 something (i think) and the official is 1.8.??22:41
JayFlike I /understand/ but I wish a different design decision w/r/t those things in openstack in general :(22:42
NobodyCamwe could throw deprecated log message22:43
JayF+122:43
JayF'WARN: Deprecated, use a modern ipmitool you insensitive clod'22:43
NobodyCamyour ipmitool is OLD nag someone22:43
mrdaU12.04 has ipmitool version 1.8.11.dell19 which has no -N and -R.  Given this is still the Ubuntu people use for many things, we should detect if -N and -R are there for us to use.22:43
mrda(unfortunately)22:44
*** jgrimm has quit IRC22:44
*** hemna has joined #openstack-ironic22:44
* JayF checks trusty22:44
JayFFWIW debian 7 supports -N and -R as version '1.8.14' as reported by --help22:45
NobodyCamI believe .13 added it22:46
JayFas does Ubuntu 14.04 (trusty) 1.8.13 as reported by --help22:46
mrdaso22:46
mrdamuch22:46
mrdafail22:46
NobodyCambut then I have nobodycamAir:openstack NobodyCam$ ipmitool -V22:47
NobodyCamipmitool version 2.5b122:47
mrdamajor.minor.patch version numbering.  How do you add in -N and -R in a patch series?22:47
JayFSo I think checking for functionality, dropping a 'deprecated' message if it's missing is probably a good route to go22:48
JayFthen we use the deprecated message we throw to guilt ubuntu into putting 1.8.13+ into precise-updates ;022:48
NobodyCamJayF: and suse ans fedora 2022:49
NobodyCamfreebds, os x22:49
NobodyCam:-p22:49
JayFAre there two separate commands that can exist as 'ipmitool'?22:49
NobodyCamfreebsd*22:49
JayFthat's what seems like is happening in some of these cases22:49
NobodyCamthere is ipmitool22:50
NobodyCamand openipmi22:50
JayFThe one I have on OS X is vastly different than the one in my linux vms (which is why I only run ipmitool from my vm)22:50
JayFI think ipmitool is provided by openipmi in debian 7 and trusty22:50
JayFbecause apt-get install ipmitool installed openipmi as a dep (maybe ipmitool is a virtual package pointed at openipmi?)22:50
*** pbrooko has quit IRC22:51
NobodyCamdevananda: found a good link which I ofc don't have handy22:51
NobodyCamdevananda: do you have that link for ipmitool vs openipmi22:51
JayFif he posted it in here I'll check logs22:51
NobodyCambet it was22:52
JayFhttps://developer.apple.com/library/mac/documentation/Darwin/Reference/Manpages/man1/ipmitool.1.html vs http://linux.die.net/man/1/ipmitool22:52
NobodyCamI use a mac so I brew installed ipmitool then I just fiddle with my path to get the correct version22:53
JayFah so ipmitool as installed by brew is the newer one22:53
* JayF looks through the paths22:53
NobodyCamnobodycamAir:openstack NobodyCam$ /usr/local/bin/ipmitool -V22:54
NobodyCamipmitool version 1.8.1322:54
JayFaha22:54
JayFthat's very helpful, ty22:54
NobodyCam)22:55
JayFfwiw I checked fedora 20, it has 1.8.13 and supports -N -R22:56
devanandaNobodyCam: it's in the patch22:57
JayFdocker containers are great for this :) docker run -t -i stackbrew/distro:version /bin/bash ; install ipmitool, find the support22:57
NobodyCamok its darn near five, the rv park we are at has a BBQ place in the park (http://www.abbbq.com) so going to get food and beer :-p22:58
JayFenjoy, have a nice evening22:58
NobodyCamdevananda: doh22:59
NobodyCam:-p22:59
devanandaJayF: 1.8.13 on trusty has -N -R22:59
devanandaNobodyCam: have a good evening :)23:00
NobodyCamhehehe23:00
*** pcrews has joined #openstack-ironic23:00
* NobodyCam wants to be back to home base :-p23:00
* devananda adds a warning to the module load23:01
NobodyCamolpen is turning on the intertub service as of friday23:01
NobodyCamoh for the ipitool version check23:01
NobodyCamipmi tool23:01
NobodyCamthat would be perfect place23:02
NobodyCamthen WARN: Deprecated, you should use pymgi23:03
NobodyCamlol /me being evil would log the warn wiht every ipmitool validate call :-p23:09
NobodyCamwith even23:09
jrollpsh, log as critical23:10
*** rloo has quit IRC23:10
*** rloo has joined #openstack-ironic23:10
*** hemna has quit IRC23:10
NobodyCamlol23:10
devanandaJayF: not that i'm lazy, but do you guys want to fix up that patch?23:10
devanandaseems like you've got some opinions on it :)23:11
*** rloo_ has joined #openstack-ironic23:11
*** igordcard has quit IRC23:11
*** JayF_ has joined #openstack-ironic23:16
*** JayF has quit IRC23:17
*** JayF_ is now known as JayF23:18
*** EmilienM_ has joined #openstack-ironic23:19
*** dtantsur has joined #openstack-ironic23:20
*** rloo has quit IRC23:20
*** dtantsur|afk has quit IRC23:20
*** EmilienM has quit IRC23:20
*** EmilienM_ is now known as EmilienM23:20
devanandacatching a bus, bbl o/23:39
*** lucas-dinner has quit IRC23:51
openstackgerritJay Faulkner proposed a change to openstack/ironic-python-agent: Allow configdrive partition to be precreated  https://review.openstack.org/9596923:52
*** radsy has joined #openstack-ironic23:59
*** radsy has joined #openstack-ironic23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!