Monday, 2014-04-14

*** matsuhashi has joined #openstack-ironic00:01
*** shakamunyi has joined #openstack-ironic00:31
*** shakamunyi has quit IRC00:37
openstackgerritRussell Haering proposed a change to openstack/ironic-python-agent: Add a @sync_command() decorator  https://review.openstack.org/8714400:39
openstackgerritRussell Haering proposed a change to openstack/ironic-python-agent: Decorated commands no longer take command_name  https://review.openstack.org/8714700:50
*** derekh has quit IRC01:15
*** nosnos has joined #openstack-ironic01:41
*** Haomeng has joined #openstack-ironic02:27
*** coolsvap|afk is now known as coolsvap02:38
*** vkozhukalov has joined #openstack-ironic03:25
*** matsuhashi has quit IRC03:31
*** vkozhukalov has quit IRC03:41
*** nosnos has quit IRC03:49
*** eghobo has joined #openstack-ironic03:49
*** vkozhukalov has joined #openstack-ironic04:11
*** eghobo has quit IRC04:37
*** matsuhashi has joined #openstack-ironic04:38
*** eghobo has joined #openstack-ironic04:38
*** eguz has joined #openstack-ironic04:40
*** eghobo has quit IRC04:44
*** nosnos has joined #openstack-ironic04:48
*** rameshg87 has joined #openstack-ironic05:11
*** rameshg87 has left #openstack-ironic05:35
*** nosnos_ has joined #openstack-ironic05:36
*** nosnos has quit IRC05:36
*** radsy has quit IRC05:43
*** rameshg87 has joined #openstack-ironic05:44
*** zul has quit IRC05:46
*** rameshg87 has left #openstack-ironic05:49
*** matsuhas_ has joined #openstack-ironic06:00
*** zul has joined #openstack-ironic06:00
*** matsuhashi has quit IRC06:03
openstackgerritJenkins proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/8395606:07
*** Mikhail_D_ltp has joined #openstack-ironic06:14
*** max_lobur has joined #openstack-ironic06:26
*** nosnos has joined #openstack-ironic06:32
*** nosnos_ has quit IRC06:32
*** matsuhas_ has quit IRC06:37
*** matsuhashi has joined #openstack-ironic06:37
*** matsuhashi has quit IRC06:37
*** matsuhashi has joined #openstack-ironic06:38
*** Mikhail_D_ltp1 has joined #openstack-ironic06:45
*** vkozhukalov has quit IRC06:47
*** Mikhail_D_ltp has quit IRC06:49
*** romcheg has joined #openstack-ironic06:54
*** sabah has joined #openstack-ironic07:01
openstackgerritSandhya Balakrishnan proposed a change to openstack/ironic: Add Ironic User Guide  https://review.openstack.org/8334307:03
dtantsurMorning Ironic07:04
*** Mikhail_D_ltp1 has quit IRC07:07
Haomengdtantsur: morning:)07:08
*** engeepanoff has joined #openstack-ironic07:29
*** engeepanoff has quit IRC07:30
*** ndipanov has joined #openstack-ironic07:32
openstackgerritSandhya Balakrishnan proposed a change to openstack/ironic: Add Ironic User Guide  https://review.openstack.org/8334307:36
*** romcheg has joined #openstack-ironic07:36
*** ifarkas has joined #openstack-ironic07:44
*** dshulyak has joined #openstack-ironic07:46
*** max_lobur has quit IRC07:48
*** eguz has quit IRC07:50
*** jistr has joined #openstack-ironic08:02
Mikhail_D_wkGood morning folks! :)08:04
HaomengMikhail_D_wk: morning:)08:05
*** martyntaylor has joined #openstack-ironic08:14
*** mrda is now known as mrda_away08:14
*** Mikhail_D_wk has quit IRC08:16
*** athomas has joined #openstack-ironic08:17
*** Mikhail_D_wk has joined #openstack-ironic08:17
*** vkozhukalov has joined #openstack-ironic08:27
*** lucasagomes has joined #openstack-ironic08:28
*** ifarkas has quit IRC08:35
*** ifarkas has joined #openstack-ironic08:39
*** yuriyz has joined #openstack-ironic08:45
*** max_lobur has joined #openstack-ironic08:47
openstackgerritA change was merged to openstack/python-ironicclient: Documentation for contributors  https://review.openstack.org/8509608:53
openstackgerritAndrey Kurilin proposed a change to openstack/python-ironicclient: Sync latest code and reuse exceptions from oslo  https://review.openstack.org/7150008:54
*** vkozhukalov1 has joined #openstack-ironic08:59
*** vkozhukalov has quit IRC09:03
*** Mikhail_D_wk has quit IRC09:10
*** andreykurilin has joined #openstack-ironic09:16
*** sabah has quit IRC09:17
*** Mikhail_D_wk has joined #openstack-ironic09:21
*** derekh has joined #openstack-ironic09:21
*** romcheg has quit IRC09:44
*** JoshNang has quit IRC09:46
*** sabah has joined #openstack-ironic09:46
*** soren has quit IRC09:46
*** soren has joined #openstack-ironic09:47
*** matty_dubs|gone has quit IRC09:47
*** matty_dubs|gone has joined #openstack-ironic09:47
*** JoshNang has joined #openstack-ironic09:48
*** Mikhail_D_wk has quit IRC10:07
*** Mikhail_D_wk has joined #openstack-ironic10:07
openstackgerritA change was merged to openstack/ironic: Fix missed stopping of conductor service  https://review.openstack.org/8707510:12
*** romcheg has joined #openstack-ironic10:14
*** matsuhashi has quit IRC10:40
*** matsuhashi has joined #openstack-ironic10:41
openstackgerritSandhya Balakrishnan proposed a change to openstack/ironic: Add Ironic User Guide  https://review.openstack.org/8334310:43
*** matsuhashi has quit IRC10:50
*** matsuhas_ has joined #openstack-ironic10:52
*** coolsvap is now known as coolsvap|afk10:52
*** matsuhas_ has quit IRC11:00
*** matsuhas_ has joined #openstack-ironic11:04
*** matsuhas_ has quit IRC11:15
*** matsuhashi has joined #openstack-ironic11:16
*** Shrews has joined #openstack-ironic11:27
*** matsuhashi has quit IRC11:46
*** lucasagomes is now known as lucas-hungry11:51
*** matsuhashi has joined #openstack-ironic11:51
*** sabah has quit IRC11:52
*** sabah has joined #openstack-ironic12:00
*** nosnos has quit IRC12:01
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add self to validator method  https://review.openstack.org/8725412:05
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add FlowExtension  https://review.openstack.org/8541212:05
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Resolve circular import, introduce ExecuteCommandMixin  https://review.openstack.org/8634112:05
*** sabah has quit IRC12:10
*** matsuhashi has quit IRC12:29
*** matsuhashi has joined #openstack-ironic12:30
*** matsuhashi has quit IRC12:34
*** vkozhukalov has joined #openstack-ironic12:35
*** rloo has joined #openstack-ironic12:36
*** jdob has joined #openstack-ironic12:38
*** vkozhukalov1 has quit IRC12:38
*** matsuhashi has joined #openstack-ironic12:42
*** romcheg has quit IRC12:43
*** mdickson has joined #openstack-ironic12:44
*** rloo has quit IRC12:44
*** rloo has joined #openstack-ironic12:45
*** zul has quit IRC12:48
*** zul has joined #openstack-ironic12:51
*** lucas-hungry is now known as lucasagomes12:56
*** romcheg has joined #openstack-ironic12:59
NobodyCamgood morning Ironic13:04
agordeevgood morning13:05
agordeevNobodyCam: morning!13:05
yuriyzmorning agordeev, NobodyCam13:06
lucasagomesmorning NobodyCam agordeev yuriyz13:06
rlooMorning NobodyCam, afternoon yuriyz, agordeev, lucasagomes13:06
lucasagomesmorning rloo :)13:06
NobodyCammorning agordeev yuriyz and lucasagomes :)13:06
NobodyCamoh and rloo13:06
agordeevyuriyz, lucasagomes, rloo morning!13:06
*** matsuhashi has quit IRC13:06
*** blamar has joined #openstack-ironic13:07
NobodyCamtexas Has strange weather13:07
NobodyCamand it seems I need to go walkies in it ... brb13:07
lucasagomes:)13:09
lucasagomesNobodyCam, heh I ireland has a strange weather... I thought texas was like hmmm warm13:10
lucasagomesI think*13:10
*** matsuhas_ has joined #openstack-ironic13:10
NobodyCamlol.. it strange rain.13:11
NobodyCams/i/it's/13:11
lucasagomesheh I c13:11
*** florentflament has joined #openstack-ironic13:12
*** ndipanov has quit IRC13:14
NobodyCamoh happy happy joy joy .. seems I get to battle tmobile again...13:17
openstackgerritA change was merged to stackforge/pyghmi: Add discrete states for event log status sensors  https://review.openstack.org/8702313:17
openstackgerritA change was merged to stackforge/pyghmi: Gracefully flag unrecognized discrete sensor states  https://review.openstack.org/8702713:19
*** ndipanov has joined #openstack-ironic13:20
*** jbjohnso_ has joined #openstack-ironic13:21
*** lazy_prince has joined #openstack-ironic13:27
*** jgrimm has quit IRC13:30
*** matty_dubs|gone is now known as matty_dubs13:34
agordeevrussell_h: morning. are you around?13:40
*** matsuhas_ has quit IRC13:42
*** yuriyz has quit IRC13:43
*** linggao has joined #openstack-ironic13:52
*** matsuhashi has joined #openstack-ironic13:52
*** matsuhashi has quit IRC13:54
NobodyCambrb13:55
*** yuriyz has joined #openstack-ironic13:55
*** jgrimm has joined #openstack-ironic14:06
dtantsurMorning again :) Guys, have you ever encountered something like this: http://paste.openstack.org/show/75674/ ? It happens on invoking `ironic node-list`, does NOT happen for e.g. `nova list`. Instack, Fedora 20, Ironic RC114:07
dtantsurI tried to disable SSL for keystone, but nothing changed. Maybe I was doing it wrong...14:07
NobodyCamI have not seen that one14:08
*** rwsu has joined #openstack-ironic14:09
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add DriverFieldsFactory  https://review.openstack.org/8697114:09
lucasagomesdtantsur, hmm this one is new for me too14:10
dtantsurand it does not happen if I install Ironic from Git manually. Quite likely to be something configuration-specific, but even have no clues how to debug :(14:11
NobodyCamjust taking a quick look it seems like a keystone config issure14:12
dtantsurlucasagomes, NobodyCam: at least maybe you know, what is the proper way to disable everything SSL-related at all?14:12
dtantsurhopefully afterwards it would be easier to debug14:12
NobodyCamdtantsur: I would start by adding bebug=True to the ironic conf file14:14
dtantsuralready done14:14
*** dkehnx has quit IRC14:14
dtantsurthis is keystone.conf: http://paste.openstack.org/show/75676/ I guess, nothing suspicious14:14
NobodyCamare you using devtest or devstack?14:14
lucasagomesdtantsur, try to set auth_strategy=noauth in the ironic.conf14:19
dtantsurNobodyCam, it's instack, which is closer to devtest essentially14:19
dtantsurlucasagomes, will try, thanks14:19
dtantsurlucasagomes, ok, noauth works :)14:23
lucasagomesdtantsur, :)14:24
lucasagomesdtantsur, so the error might be coming from ks14:24
dtantsurlucasagomes, well... If I install Ironic manually, it works with Keystone14:25
dtantsurI still suspect something wrong with ironic rpms...14:25
NobodyCamseems like the ironic service is not getting registered with KS or something like that14:25
NobodyCamInvalid user token - rejecting request14:26
lucasagomesdtantsur, ah yeah14:26
dtantsurNobodyCam, how can I register it? What I did was service-create + endpoint-create (just like manually)14:26
lucasagomessomehting with the sertup14:26
lucasagomessetup*14:26
NobodyCamdt what do get with keystone service-list14:27
dtantsur| cfca1e6678c4480c81711984bce85985 |  ironic  |   baremetal   |  <-- seems ok14:28
NobodyCamdtantsur: in the past you sent there are two different tokens are you sure one is correct? just checking..14:30
*** ndipanov has quit IRC14:30
dtantsurNobodyCam, sorry for confusion, this is a copy-paste from two unrelated attempts14:31
dtantsurthis thing is I got a bit different results for them14:32
dtantsurthat's why I included both14:32
NobodyCamyaa14:33
NobodyCam*ahh14:33
NobodyCam:-p14:33
ShrewsNobodyCam: Yeehaw, Texarcana!14:38
*** stephenpearson has joined #openstack-ironic14:39
romchegMorning folks!14:40
dtantsurmorning romcheg14:41
romchegI'd like to give you an update: I'm currently working on some Rally benchmarks for Ironic14:41
NobodyCammornig Shrews :)14:41
NobodyCammorning romcheg14:41
romchegOn the last meeting devananda told that it would be nice to see our API's performance14:41
agordeevShrews, romcheg: morning14:41
romchegAlso there's no basic plumbing for Ironic in Rally so it needs to be done14:42
Shrewsagordeev: morning  :)14:42
* romcheg feels like working with tempest and CI again :)14:42
*** ndipanov has joined #openstack-ironic14:44
rloothx romcheg. Any numbers?14:48
romchegrloo: Not yet.14:48
rlooromcheg: was it as "simple" as the Rally person said it would be?14:49
romchegrloo: It seems to be quite easy for basic benchmarking14:49
romchegBut some plumbing has to be done before implementing that14:50
rlooromcheg: there's always a but ;)14:50
romchegI will try to show something today14:50
romchegrloo: exectly :)14:50
openstackgerritPablo Fernando Cargnelutti proposed a change to openstack/ironic: Overwriting node_is_available in IronicDriver  https://review.openstack.org/8421414:52
*** ifarkas has quit IRC14:54
agordeevhttps://review.openstack.org/#/c/73223/4/ironic/tests/drivers/test_ipmitool.py L274, Gotcha in mock library?14:54
agordeevMikhail_D_wk: ^14:54
Mikhail_D_wkagordeev: ah, thanks! :)15:02
*** lazy_prince has quit IRC15:05
*** yuriyz has quit IRC15:07
openstackgerritA change was merged to openstack/python-ironicclient: Sync cliutils from oslo  https://review.openstack.org/7241715:08
*** dwalleck has joined #openstack-ironic15:10
russell_hagordeev: hey, I am now15:11
russell_hagordeev: ah, I15:14
russell_her, I'm guessing I see what you wanted to talk about15:14
russell_hclever, I like it15:15
openstackgerritlinggao proposed a change to openstack/ironic: Support serial console access  https://review.openstack.org/6410015:17
agordeevrussell_h: hey, yup. Mostly about this -> https://review.openstack.org/#/c/87254/15:18
lucasagomesdtantsur, heh yeah that factory might be over complicated15:18
lucasagomesdtantsur, what you think about having a static factory() method in the DriverFieldsFactory class which would return the correct class for a given node?15:19
russell_hagordeev: added a comment on one minor thing15:20
dtantsurlucasagomes, I mostly prefer just functions to staticmethods, otherwise it makes sense15:20
lucasagomesdtantsur, ack, could be a factory function as well15:21
lucasagomesdtantsur, will update the patch15:21
openstackgerritPablo Fernando Cargnelutti proposed a change to openstack/ironic: Overwriting node_is_available in IronicDriver  https://review.openstack.org/8421415:21
russell_hagordeev: also +2ed https://review.openstack.org/#/c/86341/15:22
russell_hagordeev: all 3 look basically good to me excepting that I'd rather not call that param "self"15:23
russell_hI could be convinced otherwise15:24
russell_hanyway, going to be AFK for a bit15:24
agordeevrussell_h: reasonable, thanks!15:24
*** zul has quit IRC15:24
ShrewsSo apparently, while working from a cafe this morning, a fire has started behind my house and I have no power at home. Neighbor says it's under control now, but  I may not make the IRC meeting today. Heading home now to check it out.15:25
*** coolsvap|afk is now known as coolsvap15:25
*** zul has joined #openstack-ironic15:25
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Refactor the driver fields mapping  https://review.openstack.org/8697115:26
*** dkehn has joined #openstack-ironic15:29
*** chuck_ has joined #openstack-ironic15:31
*** zul has quit IRC15:31
*** chuck_ is now known as zul15:32
matty_dubsOh geez, hope everything is alright, Shrews15:33
NobodyCamieek, hope all is well Shrews15:34
*** dkehn is now known as dkehnx15:35
*** BadCub01 has joined #openstack-ironic15:38
*** BadCub01 has left #openstack-ironic15:42
*** BadCub01 has joined #openstack-ironic15:42
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add FlowExtension  https://review.openstack.org/8541215:51
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add self to validator method  https://review.openstack.org/8725415:51
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 2  https://review.openstack.org/7325615:52
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 3  https://review.openstack.org/8653615:52
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 1  https://review.openstack.org/7322315:52
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Get rid of the newline "\"  https://review.openstack.org/6679315:52
*** rloo has quit IRC15:55
*** rloo has joined #openstack-ironic15:56
*** rloo has quit IRC15:56
*** rloo has joined #openstack-ironic15:57
NobodyCambrb ... walkies time15:58
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add FlowExtension  https://review.openstack.org/8541216:02
*** coolsvap1 has joined #openstack-ironic16:02
*** zul has quit IRC16:02
*** eghobo has joined #openstack-ironic16:03
*** coolsvap1 has quit IRC16:03
*** dtantsur is now known as dtantsur|bbl16:04
*** zul has joined #openstack-ironic16:04
*** coolsvap1 has joined #openstack-ironic16:04
*** zul has quit IRC16:04
*** dwalleck has quit IRC16:07
*** coolsvap1 has quit IRC16:08
rlooHi Mikhail_D_wk: is this you? https://review.openstack.org/#/c/60025/2716:08
*** zul has joined #openstack-ironic16:08
*** newell_ has joined #openstack-ironic16:10
*** matty_dubs is now known as matty_dubs|lunch16:14
*** martyntaylor has left #openstack-ironic16:19
*** zdiN0bot has joined #openstack-ironic16:19
openstackgerritA change was merged to openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/8677416:24
*** dwalleck has joined #openstack-ironic16:24
devanandag'morning, all16:27
NobodyCamgood morning devananda :)16:27
rloomorning devananda.16:28
lucasagomesmorning devananda16:33
*** vkozhukalov has quit IRC16:34
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Cherry pick oslo rpc HA fixes  https://review.openstack.org/8731416:40
devanandai forgot to apply that fix to master when I did the backport to milestone-proposed ... this release is a learning process for us ...16:41
jrollmorning all :)16:42
devanandathough i should just pull the whole update from oslo, really16:42
NobodyCammorning jroll16:43
jroll\o16:43
*** dwalleck_ has joined #openstack-ironic16:48
*** dwalleck has quit IRC16:51
*** harlowja_away is now known as harlowja16:54
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Add version 1 of agent payload  https://review.openstack.org/8617316:54
*** jistr has quit IRC16:55
adam_gdwalleck_, ping16:56
dwalleck_adam_g: Here now. What's up?16:57
*** romcheg1 has joined #openstack-ironic16:57
*** romcheg has quit IRC16:57
adam_gdwalleck_, hey--so the ironic scenario tests are running in the gate but do not seem to be passing. i spent friday trying to get to the bottom of it but was unable to reproduce on my own instances. ive narrowed it to TFTP issues. wondering if you ran into anything similar in your own testing that i may be overlooking16:58
adam_gnodes power on, get DHCP but never hit the TFTP server.16:58
dwalleck_Hmm, I don't recall ever having that issue. Are you talking about the scenario you created, or are you having issues with the other nova scenarios?16:59
*** romcheg has joined #openstack-ironic17:00
adam_gdwalleck_, the baremetal scenario specifically.17:00
dwalleck_Hmm, weird then. Once I was able to deploy ironic correctly with devstack it was working pretty consistently. Let me check again with what I have setup now17:01
*** romcheg1 has quit IRC17:01
adam_gdwalleck_, yeah, same for me.17:02
dwalleck_Was there a sharp cutoff point where they stopped working? Or did it never work when run as the gate job?17:02
dwalleck_The only thing that would be different for the gate job is how/where it's deployed17:03
*** derekh has quit IRC17:03
adam_gdwalleck_, only seem to be failing in the gate job17:04
adam_gi've tried to reproduce the environment as close to devstack-gate as possible. will continue to try that today17:05
dwalleck_Well, I guess that it's good/bad that it can be narrowed down to that.17:05
*** zdiN0bot has quit IRC17:06
*** epim has joined #openstack-ironic17:07
*** zdiN0bot has joined #openstack-ironic17:07
NobodyCamMikhail_D_wk: still around?17:08
devanandaadam_g: what sort of TFTP issue?17:09
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Adding swift temp url support  https://review.openstack.org/8139117:09
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent  https://review.openstack.org/8479517:09
adam_gdevananda, no idea. it just mysteriously doesn't work. looking at logs, i see the dnsmasq config written out with port info, the server restarted, node comes up and gets an IP but no request ever makes it to TFTP17:09
dwalleck_adam_g: Can you point me to a failing run? The OpenStack Jenkins is melting my browser trying to load everything17:10
adam_gi think i've ruled out https://bugs.launchpad.net/ironic/+bug/1300589/comments/117:10
adam_gdwalleck_, http://logs.openstack.org/67/87067/1/experimental/check-tempest-dsvm-virtual-ironic-nv/afd80cc/17:10
*** lucasagomes is now known as lucas-afk17:10
devanandaadam_g: are you seeting the DHCP offer completion?17:10
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Bring agent deploy driver up to date with virt  https://review.openstack.org/8649017:11
adam_gdevananda, looks like it17:11
adam_ghttp://logs.openstack.org/67/87067/1/experimental/check-tempest-dsvm-virtual-ironic-nv/afd80cc/logs/syslog.txt.gz17:11
adam_gApr 12 03:50:4817:11
*** eghobo has quit IRC17:12
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Add lookup method to agent vendor mappings  https://review.openstack.org/8640217:12
*** eguz has joined #openstack-ironic17:12
*** eguz has quit IRC17:12
*** eghobo has joined #openstack-ironic17:13
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Bring agent deploy driver up to date with virt  https://review.openstack.org/8649017:13
NobodyCamany seen this from neutron before? http://paste.openstack.org/show/cUi0tHNzh69GyNa0EnQE/17:14
openstackgerritRussell Haering proposed a change to openstack/ironic-python-agent: Kill the build_agent function  https://review.openstack.org/8732717:15
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: sync RPC from oslo-incubator  https://review.openstack.org/8732817:16
dwalleck_adam_g: Not sure if this helps, but working backwards from Compute, it seems to barf when attaching the port: HTTPBadRequest: Couldn't apply patch '[{'path': '/extra/vif_port_id', 'op': 'remove'}]'. Reason: u'vif_port_id'17:17
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: sync RPC from oslo-incubator  https://review.openstack.org/8732817:17
adam_gdwalleck_, oh, interesting17:18
*** stephenpearson has quit IRC17:21
*** matty_dubs|lunch is now known as matty_dubs17:23
NobodyCamwe should prob do better at keeping in sync with oslo17:25
* NobodyCam hopes GheRivero_ will keep us on our toes17:25
*** max_lobur has quit IRC17:26
linggaoHi matty_dubs,  thanks for reviewing the console patch.  I'll fix the them after you do the testing on real hardware because the problems are minor. Is it okay with you?17:27
openstackgerritJarrod Johnson proposed a change to stackforge/pyghmi: Add version change sensor information  https://review.openstack.org/8733717:35
*** zdiN0bot has quit IRC17:36
*** zdiN0bot has joined #openstack-ironic17:36
* Shrews back... for as long as his laptop battery holds out17:42
openstackgerritRussell Haering proposed a change to openstack/ironic: Drivers may expose a top-level passthru API  https://review.openstack.org/8191917:42
JoshNangdwalleck_: got a sec? i've got some failing tempest tests and i'm not sure how to proceed17:46
dwalleck_JoshNang: Sure, whatcha got?17:46
JoshNangi'm wrapping some exceptions, so I'm guessing a test somewhere broke. https://review.openstack.org/#/c/73121/17:47
jrollJoshNang: did you and devananda ever talk about if IPA should be translated?17:47
russell_hjroll: JoshNang: JayF: https://review.openstack.org/#/c/86341/17:48
jrollJoshNang: I'm hesitant to +2 this before that talk happens: https://review.openstack.org/#/c/87047/17:48
JoshNangjroll: yup we did. leaning towards no17:48
dwalleck_Okay, taking a look. Hopefully something easy17:48
devanandajroll: we did, briefly.17:48
JoshNangdwalleck_: hopefully. where are the tempest tests stored?17:48
devanandajroll: my view is, user-facing strings should be translated, but IPA doesn't really have those17:49
jrolldevananda: I tend to agree - how about IPA errors that get bubbled back to the user? (not sure if those exist)17:49
dwalleck_The actual tests? http://github.com/openstack/tempest17:49
devanandajroll: operator/admin-facing string translation is quiestionable. it might make it easier for some operators, but OTOH, it is more difficult to google search for a translated LOG.error message17:49
devanandajroll: i'm not sure they exist either. BUT. even if they did, IPA won't -- at least not right now -- know what language to translate them to17:50
dwalleck_So I'm not sure any tests failed, but there were errors in the logs that it couldn't match to failures17:50
JoshNangdwalleck_: oooooo i didn't look deep enough in that repo. sweet.17:50
devanandajroll: the user lang is only exposed to python within the API service17:50
devanandajroll: that info does not, afaik, make it down to the conductor, and so it certainly doesn't make it to IPA17:50
dwalleck_http://logs.openstack.org/21/73121/5/check/check-tempest-dsvm-ironic/11afea4/console.html , look all the way at the bottom to after the test summary finishes17:50
devanandathat == http "Expect-language" header17:50
jrolldevananda: true. thanks.17:51
jrollI'm going to just go ahead and block that then17:51
JoshNangdwalleck_: gotcha. the ir-api ones are definitely from me changing the outputs/wrapping exceptions. not sure on swiftclient17:52
dwalleck_JoshNang: So the good news is that you didn't break a test. The bad news is that you may have broken something not tested =P17:52
JoshNangwoooo!17:52
JoshNangok, i can dig into this then. thanks for the help!17:53
dwalleck_no problem!17:53
*** coolsvap is now known as coolsvap|afk17:54
NobodyCamgrrr keep dropping17:55
*** vkozhukalov has joined #openstack-ironic17:56
NobodyCamgrrr18:03
*** dwalleck_ has quit IRC18:04
openstackgerritA change was merged to openstack/ironic: Cherry pick oslo rpc HA fixes  https://review.openstack.org/8731418:05
*** jdob_ has joined #openstack-ironic18:06
*** dwalleck has joined #openstack-ironic18:07
russell_hJayF: JoshNang: https://review.openstack.org/#/c/86201/18:07
JayFlooking18:08
jroll^ those two should just take a look at all current IPA patches :P18:08
JayFI think I have a vote on most of them already18:08
JayFI'll doublecheck18:08
jrollnope :P18:08
*** dwalleck has quit IRC18:09
openstackgerritA change was merged to openstack/ironic-python-agent: Resolve circular import, introduce ExecuteCommandMixin  https://review.openstack.org/8634118:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Sync oslo/config/generator  https://review.openstack.org/8734418:10
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Sync oslo/common/excutils  https://review.openstack.org/8734518:10
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Sync oslo logging  https://review.openstack.org/8734618:10
*** stevehuang has joined #openstack-ironic18:12
openstackgerritA change was merged to openstack/ironic-python-agent: Add self to validator method  https://review.openstack.org/8725418:12
openstackgerritA change was merged to openstack/ironic-python-agent: Kill the build_agent function  https://review.openstack.org/8732718:12
openstackgerritRussell Haering proposed a change to openstack/ironic: Fix conductor.manager test assertion order  https://review.openstack.org/8703518:13
JayFrussell_h: JoshNang: this needs a look too18:17
JayF^ https://review.openstack.org/#/c/86723/18:17
openstackgerritA change was merged to openstack/ironic-python-agent: Add FlowExtension  https://review.openstack.org/8541218:17
russell_hJayF: jroll: what happens if you dd a file into a partition too small for it?18:19
russell_hJayF: jroll: put differently, do we need to validate the size of this file?18:19
JayFI asked jroll about this18:19
JayFhe said nova had a cap of 64MB18:19
JayFand that's the size we're making the configdrive partition now18:20
JayFso it should be OK18:20
jrollthat18:20
jrollbut on that note18:20
jrollif nova's cap changes18:20
russell_hright18:20
jrollthen yeahhhh18:20
russell_hor someone isn't using nova18:20
JayFalso MiB vs MB18:20
jrollon that note, this partition is at the end of the drive18:22
jrollso I'd be shocked if dd did something weird18:22
jrollidk18:22
jrollwe could validate it I suppose18:22
JayFValidating it seems smart18:23
openstackgerritA change was merged to stackforge/pyghmi: Add version change sensor information  https://review.openstack.org/8733718:23
jrollJayF, russell_h, can one of you -1 that patch then?18:24
russell_hjroll: done18:24
jrollthanks18:24
openstackgerritJim Rollenhagen proposed a change to openstack/ironic-python-agent: Use configurable driver name in lookup URL  https://review.openstack.org/8620118:32
*** jdob has quit IRC18:33
openstackgerritJarrod Johnson proposed a change to stackforge/pyghmi: Add more missing sensor specific event information  https://review.openstack.org/8735118:34
*** pcargnel has joined #openstack-ironic18:38
comstudsigh18:41
NobodyCamcomstud: ?18:41
comstudIs there a hard rule about using decorators for mock patch?18:41
*** zdiN0bot has quit IRC18:42
comstudTo test properly, I want to patch specific methods on an object18:42
NobodyCamthats the way things are moving18:42
comstudnot a class or class method18:42
NobodyCambut I don't think we have a HARD rule.18:42
NobodyCamcomment as to why you did or didn't inthe commit message18:43
comstudyeah18:43
*** zdiN0bot has joined #openstack-ironic18:43
NobodyCammaybe also a NOTE: in the code18:43
NobodyCam:)18:43
comstudI think there's a tricky way I can do this.. but just checking first18:43
rloocomstud: +1 (in code)18:44
*** zdiN0bot has quit IRC18:47
openstackgerritA change was merged to openstack/ironic-python-agent: Use configurable driver name in lookup URL  https://review.openstack.org/8620118:48
*** zdiN0bot has joined #openstack-ironic18:49
*** agordeev2 has joined #openstack-ironic18:50
*** eguz has joined #openstack-ironic18:51
devanandaNobodyCam: spinning up a tripleo env on my desktop today, and just got: No valid host was found. Reason: No conductor service registered which supports driver null.18:54
devanandaNobodyCam: probably just something simple I missed...?18:54
NobodyCamdevananda: sounds like it18:54
NobodyCamI have not seen that error18:55
*** eghobo has quit IRC18:55
*** ifarkas has joined #openstack-ironic18:55
NobodyCamdid you actually run devtest.sh ?18:55
NobodyCamor manyally run thru th steps18:55
devanandaNobodyCam: no. following the steps18:55
devanandaNobodyCam: this happens during devtest_seed18:55
NobodyCamlooking18:56
*** dtantsur|bbl is now known as dtantsur18:57
*** lucas-afk is now known as lucasagomes18:57
*** mrda_away is now known as mrda18:58
NobodyCamdevananda node should be created with the power driver https://github.com/openstack/tripleo-incubator/blob/master/scripts/register-nodes#L4618:59
NobodyCammeeting?19:00
romcheg+19:00
devanandameeting time!19:00
lucasagomesdevananda, that's a new error, wondering how the node was created with the driver null19:00
*** zdiN0bot has quit IRC19:01
*** zdiN0bot has joined #openstack-ironic19:02
openstackgerritA change was merged to stackforge/pyghmi: Add more missing sensor specific event information  https://review.openstack.org/8735119:03
*** zdiN0bot has quit IRC19:06
*** vkozhukalov has quit IRC19:11
*** vkozhukalov has joined #openstack-ironic19:12
*** max_lobur has joined #openstack-ironic19:20
*** zdiN0bot has joined #openstack-ironic19:31
*** zdiN0bot has quit IRC19:33
*** zdiN0bot has joined #openstack-ironic19:33
*** pcargnel has quit IRC19:37
*** pcargnel_ has joined #openstack-ironic19:41
pcargnel_Hi, can someone could help me understand this one? https://bugs.launchpad.net/ironic/+bug/128478119:41
NobodyCamwe're in meeting right now19:43
NobodyCamcan you give us 2- moinutes19:43
NobodyCamminutes even19:43
NobodyCam2019:43
NobodyCam:-p19:43
pcargnel_no prob. thanks :)19:44
NobodyCam:)19:44
*** zdiN0bot has quit IRC19:47
adam_gdtantsur, ah! i think it may be iptables in devstack gate causing issues19:50
dtantsuradam_g quite possible19:51
dtantsuradam_g afaik IPv6 issue if Fedora-specific, you should not encounter it19:51
dtantsuradam_g, could you point, how I can try the test scenario? It's 10pm here, and my brain does not want to work at all :(19:53
adam_gdtantsur, #openstack-infra just confirmed that devstack-gate nodes have strict iptables rules applied to $HOST_IP, which is where the nodes are attempting to tftp from19:53
dtantsuraha, I see19:53
adam_gdtantsur, deploy devstack /w ironic.  in tempest.conf, make sure 'allow_tenant_isolation = False' and flavor_ref points to the correct baremetal flavor id19:54
adam_gdtantsur, then run the single scenario test (if you run the others you will have a bad time)19:54
adam_gdtantsur, i usually run it with nose...  'nosetests tempest/scenario/test_baremetal_basic_ops.py'19:54
dtantsurok, now it's time for me to finally figure out how tempest work :)19:54
* dtantsur is a new guy at openstack 19:54
dtantsuradam_g, thanks19:55
*** tatyana has joined #openstack-ironic20:00
NobodyCamgood meeting all20:00
NobodyCambrb20:01
lucasagomesJayF, anyhoo, a short tutorial about how u guys create the images now would be very appreciate20:01
JayFlucasagomes: there's a readme in the agent repo itself about imagebuild for coreos20:01
*** vkozhukalov has left #openstack-ironic20:01
jrolllucasagomes: https://github.com/openstack/ironic-python-agent/tree/master/imagebuild/coreos20:01
lucasagomesJayF, ah, cheers20:01
jrollit doesn't document dependencies but yeah20:01
lucasagomesjroll, thanks will take a look :)20:01
jroll:)20:01
lucasagomesjroll, np its grand20:01
*** gmatefi has joined #openstack-ironic20:01
JayFlucasagomes: but right now I'm pulling it out of a docker container and putting it into a systemd-nspawn container instead, since we don't want to be abstracted as much from the hardware20:01
lucasagomes+120:02
dtantsurWhat I also wanted to discuss is a lot of really large review requests (e.g. test refactoring) that can't be just merged, because any other change breaks them20:02
JayFlucasagomes: I'll make sure to update the docs as that changes, but I'll continue to abstract out the build commands into Makefile20:02
*** iron1 has joined #openstack-ironic20:02
dtantsurbut this can wait20:02
lucasagomesJayF, good stuff nspawn is cool! chroot on steroids  heh20:03
JayFyeah exactly20:03
lucasagomesaye... will eat something, it's late here and I'm pretty hungry20:04
lucasagomeshave a good night everyone!20:04
JayFlucasagomes: Have you built pxe images/ramdisks with coreos before? It's pretty great. You should look at how we're doing stuff20:04
JayFonce you've eaten and slept and things of that nature :)20:04
jrollnight lucas20:04
lucasagomesI will take a look at the agent stuff later/tomorrow20:04
JayFhave a nice day :)20:04
JayFthanks20:04
lucasagomesJayF, I haven't20:04
lucasagomeslooking fwd, tomororw I will give it a go20:04
jrolldevananda: so I understand the main answer about all of those agent patches is time; if there's anything at all I can do to enable that please let me know :)20:04
*** lucasagomes is now known as lucas-dinner20:05
dtantsurgood night, 10pm already20:05
matty_dubsSee ya, dtantsur20:05
adam_gcheers, dtantsur20:05
*** dtantsur is now known as dtantsur|zzzZZZz20:06
openstackgerritJarrod Johnson proposed a change to stackforge/pyghmi: Auto degrade sessions to operator in environments that forbid administrator  https://review.openstack.org/8737020:06
romchegadam_g: I've just thought to move our chat to tomorrow, because it's 11PM here and this can take much time20:06
*** ifarkas has quit IRC20:07
romchegadam_g: if you don't mind20:07
adam_gromcheg, no problem. i think it may be firewall related, actually. working on a test fix now20:07
russell_hanyone know if this is a real failure? http://logs.openstack.org/19/81919/7/check/check-tempest-dsvm-ironic/69dcb90/20:07
openstackgerritJarrod Johnson proposed a change to stackforge/pyghmi: Auto degrade sessions to operator when admin is forbidden  https://review.openstack.org/8737020:07
russell_h"EC2ResponseError: EC2ResponseError: 400 Bad Request"20:08
romchegadam_g: I hope it's firewall  or selinux. But if the problem still exists tomorrow, we can take a loot together. Two pairs of eyes is always better :)20:08
adam_gromcheg, definitely. have a good night!20:09
jbjohnso_take a loot tomorrow20:09
jbjohnso_guess that could be more profitable20:09
romchegGood night guys!20:09
romchegHave a nice day/evening20:09
openstackgerritJarrod Johnson proposed a change to stackforge/pyghmi: Auto degrade sessions to operator when admin is forbidden  https://review.openstack.org/8737020:10
jbjohnso_one thing about split personality, you always have someone to review your code20:11
*** BadCub01 has quit IRC20:15
matty_dubslinggao: Just tested 64100 in my environment; works A-OK!20:16
linggaomatty_dubs, thanks for testing it. Good to know it's working!20:16
jbjohnso_matty_dubs, speaking of serial console..20:17
jbjohnso_matty_dubs, https://www.youtube.com/watch?v=G_lDaktYnsQ20:17
linggaomatty_dubs, then I'll check in the fix for your comments.20:17
* matty_dubs readies +120:18
matty_dubsjbjohnso_: Ooh!20:18
*** gmatefi has quit IRC20:18
openstackgerritlinggao proposed a change to openstack/ironic: Support serial console access  https://review.openstack.org/6410020:21
jbjohnso_matty_dubs, the code is in the world now, open for mocking20:23
matty_dubsOoh, where?20:24
*** jdob has joined #openstack-ironic20:24
jbjohnso_matty_dubs, https://sourceforge.net/p/xcat/confluent/ci/master/tree/20:24
jbjohnso_I want the health resource showing the explanation for a 'bad' grade20:24
jrollwoohoo!20:25
jbjohnso_and then I'll probably move on to making it properly daemonize20:25
jbjohnso_and then packaging20:25
jbjohnso_currently it has the raw data to show, but I haven't defined a message object to hold it yet, got distracted by some other sutff20:25
matty_dubs"got distracted by some other stuff"20:26
matty_dubsThe story of my life20:26
matty_dubs;)20:27
jbjohnso_oh, and then I saw that if I tried to connect with a bad password, the automatic retries don't get attempted to see if the password got changed to match the server.  If the server changes password it does know to check immediately20:27
jbjohnso_oh, I also need to reuse the sdr object so that health is trivial to fetch20:27
matty_dubsCapability-wise, it looks pretty slick20:28
jbjohnso_taking 1.7 seconds to get health is tortuous20:29
jbjohnso_"health": {"value": "warning"}20:30
jbjohnso_the detail missing that I need to cram: {'badreadings': [{'name': 'SEL Fullness', 'imprecision': None, 'value': None, 'states': ['Event log nearly full'], 'health': 1, 'units': '', 'type': 'Event Log Disabled'}], 'health': 1}20:30
Shrewsdevananda: Whenever you have some time, please check out my comment on this: https://review.openstack.org/#/c/86993/120:31
Shrewsdevananda: open to any suggestions you may have re: complete code-path testing20:31
linggaodevananda, what makes more sense v1/node/uuid/console_info or v1/nodes/uuid/consoe given that PUT v1/nodes/uuid/states/consle turns console on and off?20:33
openstackgerritJay Faulkner proposed a change to openstack/ironic-python-agent: Minor fixes to image build  https://review.openstack.org/8737820:33
jbjohnso_matty_dubs, yes, that new terminal code is *worlds* better than shellinabox's20:33
linggaojbjohnso_, do you know that is the protocol used by shellinabox?20:35
linggaothat _> what20:35
jbjohnso_linggao, sure, http ;)20:35
linggaoI need to put the protocal name in the 'type' attribute for the console info.20:36
jbjohnso_specifically, I did do 'net' tab dissection of their behavior to replicate the server half when I thought I was going to be endorsing shellinabox's client js code20:36
linggaofor example: in nova, the type for vnc console is 'novnc'20:36
jbjohnso_I changed the way the implementation sends data to the server because shellinabox's was kind of weird...20:36
jbjohnso_when I switched to term.js and had to write the networking piece entirely anyway20:37
matty_dubsI haven't actually looked at how it works... I'm kinda afraid to ;)20:37
jbjohnso_matty_dubs, it *could* behave more quickly using websockets, but I stuck with Ajax because in my experience web sockets and proxies get weird and for text consoles the difference is not too bad20:38
jbjohnso_linggao, dunno if it has a name, just a particular JSON encoded scheme over http requests20:38
jbjohnso_linggao, nothing used outside of shellinabox itself20:39
jbjohnso_matty_dubs, the real smarts is in a quality vt100 javascript implementation.  That is magical.20:40
jbjohnso_thankfully, I didn't need those brains since term.js exists and is MIT licensed20:41
matty_dubs:)20:41
matty_dubsSometimes that is my favorite part of open-source -- being able to hook together pieces that people way smarter than me wrote and build something really neat20:42
jbjohnso_linggao, so I'd call it 'shellinabox' protocol I guess for lack of a better term20:42
jbjohnso_linggao, just like I'd call my interface 'confluent' protocol20:42
linggaojbjohnso_, I'll put shellinabox there in the type.20:43
jbjohnso_though in my case that's ambiguous, since there is an http based and non-http based variante to the same data20:43
jbjohnso_speaking of which, I might want some guidance on how openstack would ideally present my daemon with authentication data for a given console20:44
jbjohnso_today shellinabox doesn't pretect things at all, and confluent requires some sort of authentication20:45
jbjohnso_It could either be a way to authenticate 'users' or else a way for a particular user to request tokens to delegate console authentication and authorization20:47
linggaojbjohnso_, maybe the user part needs to be considered at highter level.20:51
openstackgerritA change was merged to openstack/ironic-python-agent: Minor fixes to image build  https://review.openstack.org/8737820:53
*** jdob_ has quit IRC20:56
jbjohnso_linggao, not sure I follow..20:58
*** tatyana has quit IRC20:58
linggaojbjohnso_, I am not sure I understand this part yet. I thought nova decides who gets what access.21:00
matty_dubslinggao: Oh, one more nit -- it's literally os.makedirs, not os.mkdirs (even though that makes more sense) -- https://docs.python.org/2/library/os.html#os.makedirs21:05
linggaomatty_dubs, let me fix it now..... Thanks.21:06
matty_dubslinggao: BTW, where are you located? The .cn in your email address made me think China, but you're online at US-like hours.21:09
linggaomatty_dubs, I am located in upstate New York.  I am working on the sjing's patch. The email address is hers.21:10
linggaoMaybe I should change the owner of this patch to make it clear :)21:10
matty_dubsHaha, oops... or I should learn to read ;)21:11
*** jbjohnso_ has quit IRC21:12
matty_dubsThough it'd probably be fair to add a Coauthored-By or whatever it is21:13
openstackgerritlinggao proposed a change to openstack/ironic: Support serial console access  https://review.openstack.org/6410021:13
linggaoyes, not sure how to do that.21:14
linggao:)21:14
matty_dubsHaha, ditto. Someone had recommended it back when I was working on this, but I ended up not adding a lot21:15
linggao:)21:15
*** jdob has quit IRC21:17
linggaoI have to go. good night matty_dubs, jbjohnso_ and all.21:18
matty_dubsG'night, linggao!21:19
*** linggao has quit IRC21:19
NobodyCamnight lifeless21:19
NobodyCamdoh sorry lifeless shaould have been linggao21:19
matty_dubsDid someone tell me it's a faux pas to -1/+1 before Jenkins?21:19
matty_dubsWell, a more literal question -- is that the case?21:20
lifelessNobodyCam: :P21:20
lifelessmatty_dubs: not really21:21
NobodyCamoh brb21:25
*** max_lobur has quit IRC21:25
openstackgerritPablo Fernando Cargnelutti proposed a change to openstack/ironic: Overwriting node_is_available in IronicDriver  https://review.openstack.org/8421421:26
openstackgerritlinggao proposed a change to openstack/ironic: Support serial console access  https://review.openstack.org/6410021:28
*** linggao has joined #openstack-ironic21:29
*** linggao has quit IRC21:29
devanandaanyone looking for a quick patch to write?21:33
*** dkehnx has quit IRC21:33
NobodyCamshould we ask why21:33
devanandacause ya'll like to write code? :)21:34
comstudi prefer time consuming patches21:37
rloodevananda. depends. when did you want it written by?21:39
rloodevananda. actually, re-read your question. no, I'm not looking ;)21:39
devanandarloo: :)21:40
rloo(feeling bad about all those unreviewed patches...)21:40
devanandarloo: as you should :)21:41
rlooha ha.21:41
NobodyCamwhat would this quick entail21:42
* devananda hacks together a quick patch21:42
NobodyCamgah s/quick/quck patch/21:42
rlooooo, a possible bite ;)21:42
*** dkehn_ has joined #openstack-ironic21:45
*** dkehn_ is now known as dkehnx21:46
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Add configdrive generation to Nova driver  https://review.openstack.org/8619221:50
*** chuck_ has joined #openstack-ironic21:50
openstackgerritChris Krelle proposed a change to openstack/ironic: Fix for tripleO undercloud gate tests DO NOT MERGE  https://review.openstack.org/8552921:50
*** zul has quit IRC21:51
*** chuck_ has quit IRC21:53
*** zul has joined #openstack-ironic21:53
openstackgerritRussell Haering proposed a change to openstack/ironic: Fix conductor.manager test assertion order  https://review.openstack.org/8703521:55
*** zul has quit IRC21:57
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Fix leaking DB details to API on error  https://review.openstack.org/7312121:57
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Support for v2 agent payloads  https://review.openstack.org/8698422:01
NobodyCambe back in a bit.22:05
openstackgerritRussell Haering proposed a change to openstack/ironic-python-agent: Organize agent extensions  https://review.openstack.org/8705722:09
matty_dubsI'm headed out as well. G'night, #openstack-ironic!22:10
devanandag'night!22:10
*** matty_dubs is now known as matty_dubs|gone22:11
NobodyCamnight matty_dubs|gone22:11
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add ephemeral support to nova.virt.ironic  https://review.openstack.org/8739622:16
*** zul has joined #openstack-ironic22:17
*** zul has quit IRC22:21
*** zul has joined #openstack-ironic22:21
openstackgerritRussell Haering proposed a change to openstack/ironic-python-agent: Add a @sync_command() decorator  https://review.openstack.org/8714422:22
Shrewsmatty_dubs|gone, lifeless: actually, i believe sdague sent an email out a while back asking for people to not +1/-1 reviews until jenkins had voted. not sure if that still applies22:23
*** athomas has quit IRC22:24
*** zul has quit IRC22:24
*** chuck_ has joined #openstack-ironic22:25
openstackgerritA change was merged to openstack/ironic-python-agent: Organize agent extensions  https://review.openstack.org/8705722:26
lifelessShrews: you certainly shouldn't +A things22:27
lifelessShrews: this was because you can +A things that failed validation and they go into the integrated gate, and then fail which is hugely disruptive.22:27
Shrewslifeless: i know, but i'm pretty sure his request was to NOT +1/-1. i no longer have the email though22:30
Shrewslikely not much of an issue now anyway22:30
JayFit's really hard to not want to vote on a review at all when you get half-day jenkins build wait times :)22:30
JayFalthough I wouldn't +A something until jenkins passed, ofc22:31
JayFjust seems crummy that the person would have to wait a long time for any feedback at all22:31
*** epim has quit IRC22:32
*** radsy has joined #openstack-ironic22:34
*** radsy has joined #openstack-ironic22:34
*** chuck_ is now known as zul22:34
*** derekh has joined #openstack-ironic22:39
*** epim has joined #openstack-ironic22:39
*** agordeev2 has quit IRC22:41
ShrewsJayF: i wouldn't worry about at this point. it was back when the gate was wedged all the time. i'm probably mis-remembering anyway22:42
*** pcargnel_ has quit IRC22:45
*** epim has quit IRC23:03
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Nova.virt.driver updates driver_info more correctly  https://review.openstack.org/8740723:09
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add ephemeral support to nova.virt.ironic  https://review.openstack.org/8739623:09
*** epim has joined #openstack-ironic23:09
*** epim has quit IRC23:10
russell_hrloo: fixed up https://review.openstack.org/#/c/87035/23:10
*** romcheg has quit IRC23:15
NobodyCamdevananda: line 276 https://review.openstack.org/#/c/87407/1/ironic/nova/virt/ironic/driver.py (white space)23:28
*** blamar has quit IRC23:31
*** lucas-dinner has quit IRC23:41
jrollhas anyone run into image_meta == {} in virt.ironic.driver.spawn? assuming image-show gives me valid info for my image id?23:45
devanandaShrews: hi! around?23:53
devanandajroll: that doesn't sound familiar to me, no23:54
jrollok, it may just be my glance setup23:54
jrollthanks23:54
devanandaNobodyCam: d'oh23:55
NobodyCam:) but ++ I like it :)23:58
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Nova.virt.driver updates driver_info more correctly  https://review.openstack.org/8740723:58
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Add ephemeral support to nova.virt.ironic  https://review.openstack.org/8739623:59
devanandai'm not sure if those will conflict with lucas' patch sets23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!