Thursday, 2014-03-27

adam_gwrong review heh00:00
adam_ghttps://review.openstack.org/#/c/81958/00:00
devanandaum00:00
devanandaso tempest already does taht i thought00:00
adam_gdevananda, does what?00:00
adam_gthe API tests in tempest do basic CRUD testing, with or withou the virt driver00:00
devanandaright00:01
adam_gdevananda, i'd like to have everything that scenario test running and passing with the rest of whats green in the results pasted above00:01
devanandaahh00:01
devanandasecond review00:01
devananda:)00:01
adam_gor at least 1) that scenario test 2) the tempest.api.baremetal.* tests00:02
adam_gwe can target just those easily with a regexp in devstack-gate-vm.sh00:02
devanandaadam_g: side note, it'd be great if you tag me in the reviews so I know about them :)00:02
devanandai don't follow all of devstack's review queue00:02
adam_gdevananda, im happy to. didn't know of such feature00:02
devanandaahh00:03
adam_goh there it00:03
* devananda points to "Add reviewer" button00:03
adam_g"Add Reviewer"00:03
adam_g:)00:03
devananda:)00:03
devanandathanks!00:03
adam_gdevananda, anyway, if that scenario test gets merged that gives us basic functional testing of a nova-driven provision00:04
adam_gwe can add an _advanced_ops if we want to test some of the things like ma addr update, etc00:04
adam_g*mac addr00:04
devanandaawesome00:04
devanandaso00:04
devanandathere's still a problem00:05
devanandaAIUI, if tempest is enabled -at-all- it will test any service it discovers00:05
adam_gthe issue with the other tests that are failing now are problems like parallel testing (can be turned off), incorrect tenants (random tenants created for each test. we need to spawn on tenant /w the same network as nodes)00:05
devanandait sounds like we need to prevent tempest running any of the nova tests while nova is using the virt.ironic driver00:06
devanandawhich we can't do00:06
adam_gdevananda, well, long term it would be great to be able to define feature requirements for individual tests--thats another conversation00:06
adam_gin the meantime00:06
adam_ghttp://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/devstack-vm-gate.sh#n33000:06
adam_gshould let us easily target specific tests, or blacklist others00:07
devanandainteresting00:07
devanandai didnt know about that00:07
adam_gdevananda, another possible reason why we dont have more green is the issues around deleting an instance that hasn't been fully provisioned on the ironic side00:10
adam_gits possible an early test boots something, it fails during provision, test deletes it and moves on.. meanwhile, ironic node is never freed and all subsequent tests can't boot instances00:11
devanandaadam_g: right00:12
devanandaadam_g: and the bit of reading in that log that I did suggests the conductor never got the do_node_deploy message at all00:13
adam_gdevananda, it could be the random tenant spawning the instance does not have appropriate config in neutron and the driver is dying during vif setup?00:14
devanandaadam_g: ahh. could be00:15
devanandaso an instance gets created and associated in ironic00:15
devanandabut the virt driver never makes it to deploy00:15
devanandataht seems likely00:15
devanandathen it tries to clean up, but ironic rejects taht request00:15
devanandaadam_g: looks like DEVSTACK_GATE_TEMPEST_REGEX is the way to go for now00:16
devanandaadam_g: do you know how to trigger the virtual-ironic job in tempest's queue?00:17
devanandait should be available in tempest/devstack/devstack-gate, just not running by default yet00:17
adam_gdevananda, oh looking closer at those logs, its using the wrong flavor00:17
adam_ghttp://logs.openstack.org/31/83231/1/check/check-tempest-dsvm-virtual-ironic/ff61a33/logs/screen-n-cpu.txt.gz?level=TRACE00:17
adam_ghttps://review.openstack.org/#/c/82703/00:18
*** matsuhashi has joined #openstack-ironic00:19
devanandayep00:20
* adam_g needs to run out for 20 mins back soon00:20
NobodyCam:) run fast00:20
NobodyCamhehehe00:20
devanandai will be wrapping up soon too00:21
NobodyCam:)00:21
NobodyCamI too will be doing the same shortly00:22
NobodyCamtrying to see why my compute_manager setting is not getting set.00:23
*** lucas-afk has quit IRC00:25
*** epim has quit IRC00:26
*** rloo has quit IRC00:36
*** rloo has joined #openstack-ironic00:37
*** rloo has quit IRC00:45
*** rloo has joined #openstack-ironic00:45
*** blamar has joined #openstack-ironic00:57
*** eghobo has quit IRC01:02
*** matsuhashi has quit IRC01:12
*** harlowja has quit IRC01:12
*** zigo has quit IRC01:12
*** zul has quit IRC01:12
*** jrist has quit IRC01:12
*** john-n-seattle has quit IRC01:12
*** Haomeng has quit IRC01:12
*** harlowja has joined #openstack-ironic01:17
*** rloo has quit IRC01:34
*** eghobo has joined #openstack-ironic01:41
*** nosnos has joined #openstack-ironic01:45
*** blamar has quit IRC01:45
*** eghobo has quit IRC01:45
*** matsuhashi has joined #openstack-ironic01:49
*** zigo has joined #openstack-ironic01:49
*** zul has joined #openstack-ironic01:49
*** jrist has joined #openstack-ironic01:49
*** john-n-seattle has joined #openstack-ironic01:49
*** hemna_ has quit IRC01:53
openstackgerritA change was merged to openstack/ironic: Do not use __builtin__ in python3  https://review.openstack.org/8014401:58
*** harlowja is now known as harlowja_away02:19
*** vkozhukalov has joined #openstack-ironic02:30
*** lifeless has joined #openstack-ironic02:30
lifelessNobodyCam: I enabled tlh for Ubuntu years ago02:34
lifelessNobodyCam: you should totally be able to do it02:35
*** lifeless has quit IRC02:35
*** harlowja_away is now known as harlowja02:37
*** matsuhashi has quit IRC02:37
*** matsuhashi has joined #openstack-ironic02:38
*** matsuhashi has quit IRC02:47
*** killer_prince has quit IRC02:50
*** Haomeng has joined #openstack-ironic02:51
*** killer_prince has joined #openstack-ironic02:51
*** lifeless has joined #openstack-ironic02:53
*** nosnos has quit IRC03:04
*** linggao has quit IRC03:05
*** linggao has joined #openstack-ironic03:30
*** blamar has joined #openstack-ironic03:35
*** blamar has quit IRC03:36
*** harlowja is now known as harlowja_away03:47
*** nosnos has joined #openstack-ironic03:48
*** matsuhashi has joined #openstack-ironic03:48
*** eghobo has joined #openstack-ironic04:20
*** saju_m has joined #openstack-ironic04:38
*** rameshg87 has joined #openstack-ironic04:40
*** matsuhashi has quit IRC04:45
*** matsuhas_ has joined #openstack-ironic04:49
*** matsuhas_ has quit IRC05:12
*** pradipta_away is now known as pradipta05:19
*** loki_ has joined #openstack-ironic05:25
*** matsuhashi has joined #openstack-ironic05:29
*** sabah has joined #openstack-ironic05:57
openstackgerritJenkins proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/8299306:07
*** saju_m has quit IRC06:07
*** killer_prince is now known as lazy_prince06:07
*** dwalleck has joined #openstack-ironic06:08
*** dwalleck has quit IRC06:08
*** vkozhukalov has quit IRC06:10
*** mrda is now known as mrda_away06:18
*** russellb has quit IRC06:32
*** killer_prince has joined #openstack-ironic06:36
*** saju_m has joined #openstack-ironic06:50
*** max_lobur has joined #openstack-ironic07:22
*** ndipanov has joined #openstack-ironic07:24
*** sabah has quit IRC07:26
*** max_lobur has quit IRC07:26
*** sirushti is now known as shortstop07:27
*** eghobo has quit IRC07:28
*** max_lobur has joined #openstack-ironic07:30
*** subah has joined #openstack-ironic07:30
*** subah has quit IRC07:32
*** sabah has joined #openstack-ironic07:34
*** vkozhukalov has joined #openstack-ironic07:38
openstackgerritSergey Lukjanov proposed a change to openstack/ironic: Start using oslosphinx theme for docs  https://review.openstack.org/8304307:41
*** jistr has joined #openstack-ironic07:47
*** russellb has joined #openstack-ironic07:47
*** greghaynes has quit IRC08:02
*** athomas has joined #openstack-ironic08:02
*** athomas has quit IRC08:05
*** greghaynes has joined #openstack-ironic08:07
*** ifarkas has joined #openstack-ironic08:15
*** sabah has quit IRC08:29
*** matsuhashi has quit IRC08:33
*** max_lobur has quit IRC08:34
*** saju_m has quit IRC08:43
*** nosnos has quit IRC08:43
*** mdurnosvistov_ has joined #openstack-ironic08:44
dtantsurMorning Ironic08:46
mdurnosvistov_dtantsur: morning :)08:50
mdurnosvistov_Morning all! ;)08:50
Haomengmorning all:)08:50
*** saju_m has joined #openstack-ironic08:55
*** saju_m has quit IRC09:16
*** max_lobur has joined #openstack-ironic09:17
*** max_lobur1 has joined #openstack-ironic09:17
*** sabah has joined #openstack-ironic09:20
openstackgerritAndrey Kurilin proposed a change to openstack/python-ironicclient: Sync cliutils from oslo  https://review.openstack.org/7241709:21
*** max_lobur has quit IRC09:21
*** derekh has joined #openstack-ironic09:24
openstackgerritAndrey Kurilin proposed a change to openstack/python-ironicclient: Sync cliutils from oslo  https://review.openstack.org/7241709:24
*** saju_m has joined #openstack-ironic09:27
lifelessadam_g: devananda: https://bugs.launchpad.net/ironic/+bug/1298274 may interest09:36
*** jistr has quit IRC09:38
*** matsuhashi has joined #openstack-ironic09:45
openstackgerritA change was merged to openstack/ironic: Fix strings post landing for c63e1d9f6  https://review.openstack.org/8304409:46
*** jistr has joined #openstack-ironic10:04
*** martyntaylor has joined #openstack-ironic10:04
*** saju_m has quit IRC10:24
*** EmilienM has quit IRC10:28
*** EmilienM has joined #openstack-ironic10:28
*** martyntaylor has quit IRC10:31
*** lazy_prince has quit IRC10:34
*** Manishanker has joined #openstack-ironic10:44
*** nosnos has joined #openstack-ironic10:44
*** martyntaylor has joined #openstack-ironic10:51
*** romcheg has joined #openstack-ironic11:04
*** matsuhashi has quit IRC11:07
openstackgerritSandhya Balakrishnan proposed a change to openstack/ironic: Ironic User Guide  https://review.openstack.org/8334311:11
*** saju_m has joined #openstack-ironic11:14
*** ifarkas has quit IRC11:18
*** sabah has quit IRC11:29
*** matsuhashi has joined #openstack-ironic11:32
*** saju_m has quit IRC11:33
*** saju_m has joined #openstack-ironic11:35
*** ifarkas has joined #openstack-ironic11:45
*** matsuhashi has quit IRC11:45
*** lynxman has quit IRC11:48
*** lynxman has joined #openstack-ironic11:48
*** athomas has joined #openstack-ironic12:00
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Get rid of modes. Introduce pluggable extensions  https://review.openstack.org/8308712:02
agordeevgood morning Ironic!12:05
*** matsuhashi has joined #openstack-ironic12:05
Shrewsagordeev: morning12:29
* Shrews is slow in responding until at least his 2nd cup of coffee12:30
*** jdob has joined #openstack-ironic12:30
agordeevShrews: morning :)12:31
jrollmorning agordeev :)12:32
romchegMorning follks!12:32
mdurnosvistov_agordeev: morning/afternoon =)12:32
mdurnosvistov_romcheg: morning!12:32
romchegGuys, I'm not familiar with building dos in OpenStack so I have a question about this patch https://review.openstack.org/#/c/83043/2/doc/source/conf.py12:33
jrollmorning all :)12:33
romchegI would appreciate if some one explains me where the oslosphinx theme is set to be used?12:33
*** martyntaylor has quit IRC12:33
romchegI can only see that theme settings were commented on L64-L6612:34
jrollagordeev: looking over this patch right now btw12:35
Shrewsromcheg: i believe that's all handled in pbr12:37
Shrewsromcheg: http://docs.openstack.org/developer/pbr/#sphinx-autodoc12:37
romchegShrews: Thanks I'll check that out12:37
*** rloo has joined #openstack-ironic12:42
*** matsuhashi has quit IRC12:45
*** matsuhashi has joined #openstack-ironic12:45
*** loki_ has quit IRC12:48
*** martyntaylor has joined #openstack-ironic12:49
*** killer_prince has quit IRC12:49
*** matsuhashi has quit IRC12:50
agordeevjroll: morning!12:55
agordeevromcheg: mdurnosvistov_ morning, guys!12:55
romchegMorning agordeev12:55
jrollagordeev: hey :)12:56
jrollagordeev: I've got one thing on your patch, trying to find the best way to explain it13:00
jrollthe tests happened to match the bug as well13:00
* jroll needs more coffee13:00
*** pradipta is now known as pradipta_away13:01
*** ifarkas has quit IRC13:02
agordeevjroll: what thing? let me know13:06
jrollagordeev: just put up a review13:07
jrollagordeev: I'm planning on working on some integration things today, so if we can get that merged this morning, I can (if everything else goes okay) get some real usage on it :)13:08
*** matty_dubs|gone is now known as matty_dubs13:15
jrollagordeev: by the wat, let me know if that doesn't make sense13:15
*** matsuhashi has joined #openstack-ironic13:18
*** matsuhashi has quit IRC13:25
*** matsuhashi has joined #openstack-ironic13:26
*** jistr has quit IRC13:26
*** matsuhashi has quit IRC13:26
*** matsuhashi has joined #openstack-ironic13:26
*** max_lobur1 has quit IRC13:28
*** mdurnosvistov has quit IRC13:28
openstackgerritAleksandr Gordeev proposed a change to openstack/ironic-python-agent: Get rid of modes. Introduce pluggable extensions  https://review.openstack.org/8308713:29
agordeevjroll: yup, you are right. It was a bug :) That tells the reason why i can't get access to ext.obj before13:30
jrollheh, yeah :)13:30
jrollchecking it out now13:31
jrolllgtm, thanks agordeev!13:31
*** mdurnosvistov has joined #openstack-ironic13:31
jrollas soon as jenkins gets done I'll +2 it13:32
*** blamar has joined #openstack-ironic13:32
*** jbjohnso_ has joined #openstack-ironic13:33
agordeevjroll: np, thanks for lightning fast reviewing :)13:34
jrollI do my best :)13:35
*** krtaylor has quit IRC13:35
jrolldoes anyone know how to watch a project for new reviews?13:36
openstackgerritA change was merged to openstack/ironic: Start using oslosphinx theme for docs  https://review.openstack.org/8304313:40
*** linggao has joined #openstack-ironic13:42
*** jistr has joined #openstack-ironic13:44
rloojroll. I think you can set it in your 'Settings' (at https://review.openstack.org/#/settings/projects)13:45
*** lucasagomes has joined #openstack-ironic13:46
*** Manishanker has left #openstack-ironic13:46
devanandamorning, all13:59
*** jdob has quit IRC14:01
rloohi devananda.14:01
linggaoGood morning devananda rloo14:01
*** zigo has quit IRC14:01
*** jdob has joined #openstack-ironic14:02
agordeevdevananda: morning!14:02
agordeevrloo linggao good morning!14:02
linggaoagordeev, good morning.14:02
rloohello linggao & agordeev :-)14:02
*** zigo has joined #openstack-ironic14:03
*** mtaylor has joined #openstack-ironic14:05
*** rameshg87 has left #openstack-ironic14:06
*** krtaylor has joined #openstack-ironic14:06
*** blamar has quit IRC14:06
*** blamar has joined #openstack-ironic14:06
*** mordred has quit IRC14:08
*** mtaylor has quit IRC14:08
*** mtaylor has joined #openstack-ironic14:08
*** mtaylor is now known as mordred14:08
NobodyCamgood morning Ironic says the man making coffee..14:10
agordeevNobodyCam: morning!14:10
NobodyCammorning agordee, rloo, linggao and devananda :)14:11
rloohiya NobodyCam!14:11
lucasagomesmorning NobodyCam rloo agordeev14:11
linggaoHi NobodyCam.14:12
lucasagomesmorning devananda linggao :)14:12
NobodyCamahh didn't see ya there lucasagomes :)14:12
lucasagomesno worries14:12
NobodyCam:)14:12
linggaoGood morning lucasagomes14:12
agordeevlucasagomes: morning!14:13
linggaolucasagomes, do you know if this doc is up to late or not? http://docs.openstack.org/developer/ironic/webapi/v1.html14:13
linggaolate->date14:13
lucasagomeslinggao, I think it's cause it's auto-generated14:14
linggaolucasagomes, that's great.  someone asked me and I was not sure.14:15
*** blamar has quit IRC14:17
*** blamar has joined #openstack-ironic14:17
*** max_lobur1 has joined #openstack-ironic14:19
*** blamar has quit IRC14:21
lucasagomesyup :D14:21
*** blamar has joined #openstack-ironic14:21
NobodyCam:) coffee started, kids quickly walked, /me dragged behind :-/14:27
rlooNobodyCam: you have to show them who's boss!14:28
NobodyCamI do...THay are :-p14:29
NobodyCamhehehe14:29
rloo:-)14:31
*** killer_prince has joined #openstack-ironic14:32
*** thehybridtech has joined #openstack-ironic14:33
NobodyCamoff the workers here at the park carries "cookies" (dob bones) they ran up to his golf cart and I wasn;t ready for it.. lol14:33
NobodyCams/off/ one of/14:33
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add DiskPartitioner  https://review.openstack.org/8339614:34
rlooha ha14:34
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Use DiskPartitioner  https://review.openstack.org/8339914:36
*** jgrimm has joined #openstack-ironic14:36
NobodyCamlucasagomes: what do you think about making a common dir under test for testing file in common? woth it or over kill?14:37
jrollrloo: thanks!14:37
rloojroll: yw14:38
lucasagomesNobodyCam, I think it's needed heh14:38
* NobodyCam goes bace to coffee.. as typing is not working well yet14:38
NobodyCamgah14:38
NobodyCam:)14:38
lucasagomesso the test dir structure looks like the ironic dir structure14:38
lucasagomestoday's a tad confusing14:38
lucasagomes(not a big deal tho)14:38
NobodyCamya.. I was looking for a test of one of the common files the over day and it ended up a bug hunt14:40
lucasagomeslol14:49
lucasagomesyeah14:49
openstackgerritA change was merged to openstack/ironic-python-agent: Get rid of modes. Introduce pluggable extensions  https://review.openstack.org/8308715:02
NobodyCambrb15:10
*** matsuhashi has quit IRC15:18
*** nosnos has quit IRC15:19
*** datajerk has quit IRC15:20
*** dhellmann_ is now known as dhellmann15:21
*** matty_dubs is now known as matty_dubs|czech15:26
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Use DiskPartitioner  https://review.openstack.org/8339915:31
rloolucasagomes: so we don't have any docn for the ironic CLI, right? something like http://docs.openstack.org/developer/python-keystoneclient/?15:35
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Use DiskPartitioner  https://review.openstack.org/8339915:35
lucasagomesrloo, no :(15:36
devanandalucasagomes: have you gotten API translations to work at all?15:36
devanandaI've been trying this morning with no success15:36
lucasagomesdevananda, to be honest I never tried15:36
devanandabased on https://review.openstack.org/#/c/74626/15:37
devanandabut still doesn't work15:37
devanandabut ... i may be doing it wrong15:37
lucasagomeshmm lemme try, finishing something before and then I will give it a go15:37
lucasagomesdevananda, there's anyone working on translation?15:38
devanandait might be worth trying on a system which already has default locale != en15:38
lucasagomesmaybe the strings are simply not translated to they fallback to english15:38
lucasagomesso they*15:38
devanandalucasagomes: yes - -https://www.transifex.com/projects/p/ironic/15:38
lucasagomesdevananda, ah wow! brazilian ptgz 46%!15:38
NobodyCamlucasagomes: also: #openstack-translation15:39
Shrewshow do we not have a Tagalog translation yet?????15:40
devanandaahhh15:40
devanandaso15:40
devanandai think something's broken with our transifex integration15:40
devanandathe translations exist in transifex but NOT in master (15:41
lucasagomesohh15:43
lucasagomesbrazilian ptgz is now 47% :) did my 1% contribution heh15:43
lucasagomesyay15:43
*** saju_m has quit IRC15:44
devanandahehe15:44
devanandaShrews: klingon. we need a klingon translation.15:44
lucasagomesHaomeng, ping re lazy translation, how did u test it?15:44
lucasagomesdevananda, +1!15:44
lucasagomesirish is not even listed there :(15:45
*** killer_prince is now known as lazy_prince15:45
NobodyCamthat the tlh I keep wanting15:47
*** ewindisch has quit IRC15:47
Shrewsdevananda: want an update on https://review.openstack.org/83105? or after coffee/other stuff?15:47
*** hemna_ has joined #openstack-ironic15:47
devanandammm, yes. also need moar coffee15:48
Shrewsdevananda: So, what I've put up is working like a champ under manual testing with devstack. get_available_nodes() is called by n-cpu every minute via a periodic task...15:49
Shrewsdevananda: I can kill the API server and watch it retry, and bring it up in between tries and it works again.15:49
ShrewsSo functionally, I'm feeling pretty confident.15:50
*** ewindisch has joined #openstack-ironic15:51
ShrewsI've limited the scope of changes in that review just for testing.15:51
devanandasounds good15:53
devanandaShrews: feel like adding a second patch, based on that, to do retry for things like delete?15:54
devanandaShrews: also, for reuse, I'd put IronicClientWrapper in its own file15:55
Shrewsdevananda: well, that brings up my next question: fully implementing this would change LOTS of areas of code. Should we implement this piecemeal, or as one large patch?15:55
Shrewss/LOTS of areas/LOTS of methods/15:56
devanandaoh, and retry_excs should have HTTPConflict too, I /think/15:56
ShrewsSince we don't really have unit tests, I'm not real comfortable with changing everything15:57
devanandaShrews: piecemeal is almost always easier on reviewers15:57
devanandayea15:57
devanandaand we dont have functional tests yet of this code either15:57
Shrewsdevananda: ++ on conflict15:57
devanandathough adam_g seems to be getting pretty close15:57
devanandaShrews: conflict should address teh "NodeLocked" exceptions15:57
devanandawhich will be a real issue in production where periodic-tasks in ir-cond are firing off15:57
devanandaoh, also15:58
devanandaShrews: take a look at my comment on https://review.openstack.org/#/c/82948/15:58
devanandai think i found why the client isn't handling some exceptions15:58
devanandalucasagomes: ^15:59
Shrewsdevananda: so, I'm just going to pick a handful of methods to change, test those through devstack, and open the review up15:59
devanandaShrews: ++15:59
Shrewsdevananda: i tried running the unit tests directly under nova using your tests from https://review.openstack.org/51328, but that didn't work and i jumped into using devstack before looking into that too much16:01
Shrewsjust fyi16:01
devanandadidn't work how?16:01
Shrewstestr threw up all over my laptop16:01
NobodyCamicky16:02
Shrewssome sort of long, undecipherable message that made me hide in a corner16:02
devanandahah16:02
devanandathat's usually a parse error16:02
rloojroll: do you remember the diagram you guys had at the midcycle meet-up?16:02
*** eghobo has joined #openstack-ironic16:03
lucasagomesdevananda, I think we shouldn't address Conflict16:03
lucasagomesNodeLocked is TemporaryFailure16:03
devanandalucasagomes: https://github.com/openstack/python-ironicclient/blob/master/ironicclient/exc.py16:03
devanandais incomplete16:03
jrollrloo: we had lots of diagrams :P I think the one you're looking for should be somewhere here: https://wiki.openstack.org/wiki/Ironic-python-agent#Architecture16:03
lucasagomesdevananda, ah16:04
lucasagomesright16:04
devanandawoops, bad link. should have had L150 in there16:04
devanandahttps://github.com/openstack/python-ironicclient/blob/master/ironicclient/exc.py#L15116:04
lucasagomesdevananda, I think there was a patch before to use exceptions from oslo to the clients16:04
devanandathe mapping is at the end of that file16:04
devanandayea, it wasn't based properly // never landed16:04
lucasagomesbut we hold it because it would affect the driver and consenquently the graduation16:04
lucasagomesbut now it might be good to land it16:04
lucasagomesright16:04
devanandalucasagomes: how would it help this situation?16:05
rloojroll: thx. I don't actually know which diagram, it was something you guys had written on the board. I didn't look :-(  I'll take what I can get though ;)16:06
jrollrloo: what sort of thing are you looking for?16:06
lucasagomeswell idk how complete is the oslo exceptions for the clients16:06
rloojroll: *any*, I'm desperate. Just joking. Trying to put together docn for ironic.16:07
jrollheh16:07
jrollrloo: I'm happy to draw things up if those don't suffice :)16:07
JayFJust let any of us know if there are questions or you want more :)16:08
rloojroll: deva had mentioned the diagram you guys drew. i think it might have had sequence/flow, so the IPA-Startup-Flow diagram might be useful, w/o the teeth part perhaps.16:08
jrollit says teeth? :/16:08
devanandarloo: sounds like you want a "what we have today" vs "what we're planning" diagram16:08
jrolloh, we changed that name16:09
* jroll edits16:09
NobodyCamrloo: hope i wasn't overly critical in my review16:09
rloodevananda: yeah, well, I want a 'what we will have when RC goes out' which should be similar to what we have today.16:09
devanandaright16:09
devanandaand IPA isn't part of that16:09
JayFNone of the agent stuff will be in icehouse at all16:09
*** epim has joined #openstack-ironic16:09
lucasagomesrloo, https://github.com/ifarkas/TuskarSummit2014March-Ironic/tree/master/images16:09
rloothx lucasagomes.16:10
rlooanyone want to try updating this: http://docs.openstack.org/admin-guide-cloud/content/conceptual-architecture.html?16:11
devanandahttps://github.com/ifarkas/TuskarSummit2014March-Ironic/blob/master/images/PXEandIPMIFlow.png is slightly misleading, IMHO16:11
rlooor how about adding ironic to this: http://docs.openstack.org/admin-guide-cloud/content/logical-architecture.html16:11
devanandalucasagomes: first two lines should be reflexive16:11
*** dshulyak has quit IRC16:11
*** dshulyak has joined #openstack-ironic16:11
lucasagomesdevananda, +116:12
lucasagomeswell I've the google docs files I can share it and we fix it there16:12
lucasagomesand export to png again16:12
lucasagomesor use another tool to recreate then16:12
devanandathere's also http://git.openstack.org/cgit/openstack/tripleo-incubator/tree/images16:13
lucasagomeshttps://www.draw.io/ looks quite good16:13
devanandawhich may or may not be out of date now16:13
rlooNobodyCam: nope, not overly critical. thx for the feedback.16:13
jrollrloo: updated https://dl.dropboxusercontent.com/u/363486/IPA-Startup-Flow.png16:13
NobodyCam:)16:14
*** epim_ has joined #openstack-ironic16:14
devanandarloo: right, so tripleo-incubator/tree/images still references nova baremetal ...16:15
devanandavery out of date16:15
lucasagomesdevananda, rloo NobodyCam I was looking at barbican docs, they are  quite good16:15
lucasagomeslook16:15
lucasagomeshttps://github.com/cloudkeep/barbican/wiki/Architecture16:15
NobodyCamlucasagomes: ya I did too16:15
devanandanice16:16
NobodyCamlooks like just what we were looking of from my initial read over16:16
*** epim has quit IRC16:16
*** epim_ is now known as epim16:16
rlooso do I have a volunteer to write up a user guide/architecture docn for ironic?16:17
* rloo can only hope16:17
lucasagomesmaybe everyone should help a bit with ^16:17
rlooyeah ;) Guess I'll put together a first stab at something, and I'll leave lots of room for everyone else to contribute ;)16:19
NobodyCam:) rloo that would be awesome. poke me and I'll throw in my 2 cents16:21
rlooNobodyCam: thx!16:21
romchegHi lucasagomes, NobodyCam, rloo, jroll, devananda, Shrews… there are so many of you :)16:22
lucasagomesromcheg, morning :)16:22
JayFGood morning.16:22
dtantsurlucasagomes, I'm getting InstanceDeployFailure: Failed to provision instance d90bf752-2cab-4414-9cc6-334ebf86078e: PXE driver failed to continue deployment.16:22
dtantsurin nova-scheduler journald logs16:22
lucasagomesrloo, cheers, I can try to give u a hand16:22
rloothx lucasagomes!16:23
lucasagomesdtantsur, right, anything on the ir-cond logs?16:23
romcheglucasagomes: I'm looking at https://review.openstack.org/#/c/83396/1/ironic/common/disk_partitioner.py this file right now and I have a question about initialisind start and end on L88 and L9016:23
NobodyCamhey hey romcheg :) nice to see you :)16:23
jrollmorning romcheg16:23
lucasagomesromcheg, sure what's the question?16:23
lucasagomesromcheg, end is the offset to the end of the last partition16:24
lucasagomesromcheg, which starts with 0 (disk empty), on the next interaction it will be 0 + part_size16:25
romchegIt looks odd to me. Why not just start=0; end=start+part['size']16:25
dtantsurlucasagomes, SSHException: Error reading SSH protocol bannerSecond simultaneous read on fileno 7 detected.  Unless you really know what you're doing, make sure that16:25
dtantsuronly one greenthread can read any particular socket.  Consider using a pools.Pool. If you do know what you're doing and want to disable this error, call eventlet.debug.hub_prevent_multiple_readers(False)16:25
lucasagomesso the start of the next partition is at the end of the previous16:25
dtantsurthe only error I found16:25
romchegMaybe I'm missing some logic there?16:25
lucasagomesromcheg, that logic works only for the first partition16:25
lucasagomesromcheg, the second one needs to start at the end of the first16:25
lucasagomesthird at the end of the second etc...16:25
romchegAh, right!16:26
lucasagomesdtantsur, oh eww16:26
lucasagomesdtantsur, right haven't seem it, maybe my env is too old16:27
lucasagomesI will try to recreate it16:27
romcheglucasagomes: sorry for the dumb question16:27
lucasagomesromcheg, it's not dumb :)16:27
Shrewsrloo: someone put up a first-pass user guide today16:27
* Shrews digs up review #16:27
Shrewshttps://review.openstack.org/8334316:28
rlooShrews: cool.16:28
* rloo takes a look16:29
* NobodyCam looks too16:29
lucasagomesdtantsur, ur on f20?16:29
*** athomas has quit IRC16:30
dtantsurlucasagomes, yes16:30
lucasagomesack16:30
openstackgerritJenkins proposed a change to openstack/ironic: Updated from global requirements  https://review.openstack.org/8347116:33
NobodyCambbt.... brb16:33
*** epim has quit IRC16:34
NobodyCampost bbt walkies.. bbiafm...16:40
*** zigo has quit IRC16:41
*** akrivoka has joined #openstack-ironic16:42
SpamapSDriverNotFound: FakeSeaMicroDriver17:01
SpamapSDriverNotFound: PXEAndSeaMicroDriver17:01
SpamapSAny ideas why that might happen?17:02
SpamapShttp://logs.openstack.org/59/81959/22/check-tripleo/check-tripleo-ironic-seed-precise/fb05cfd/ <-- test run showing this fail in seed_logs.tgz17:02
jrollSpamapS: I believe those are just warnings, but that happens when the seamicro deps are not installed17:02
JayFIs that the broken test?17:03
* JayF checks17:03
JayFah, so the one that's been failing for me is check-tripleo-ironic-undercloud-precise17:04
JayFidt that the seed one has been failing, but icbw17:04
SpamapSjroll: is there a bug open for that?17:04
SpamapSjroll: tracebacks in logs != warnings17:04
SpamapS(stevedore.extension): 2014-03-27 06:06:40,516 ERROR Could not load 'fake_seamicro': FakeSeaMicroDriver17:05
SpamapSERROR17:05
SpamapSdevananda: over here. ;)17:05
SpamapSdevananda: so error tracebacks in logs == High priority bug IMO.17:06
devanandalol17:06
devanandahi17:06
SpamapSas an admin that says to me "We have no idea what the program is doing now."17:06
SpamapShttps://review.openstack.org/#/c/81959/22 anyway.. I am having a hard time figuring out what these two failures are17:07
*** matty_dubs|czech is now known as matty_dubs|lunch17:07
jrollSpamapS: I'm not sure if there's a bug filed17:07
devanandaSpamapS: "these two failures"? do you mean anything aside from not loading teh SeaMicro drivers?17:08
*** harlowja_away is now known as harlowja17:08
devanandaSpamapS: so the root cause here is, this is how stevedore handles missing plugins17:09
SpamapSdevananda: the sea micro failures are just distracting17:09
devanandaSpamapS: if I don't raise an exception from within the plugin, stevedore is going to load it. and I need stevedore to *not* load it when a dependency is missing17:09
devanandaSpamapS: ok.w hat's the real problem?17:09
SpamapSdevananda: so you can't catch that exception? Anywhere?17:09
SpamapSdevananda: the real problem is what I can't figure out ;)17:10
devanandano, i cant17:10
SpamapSdevananda: bug in stevedore?17:10
devanandanotice what's logging it -- stevedore.extension17:10
devanandanot ironic17:10
SpamapSyeah I see that, so.. bug in stevedore?17:10
SpamapSThats a broken API IMO17:10
SpamapSplugins are nasty business.. you have to be able to handle failures gracefully.17:10
devanandathe exception raised at File "/opt/stack/new/ironic/ironic/drivers/pxe.py", line 102 is how ironic is supposed to signal stevedore17:10
devanandathat the plugin should not be loaded17:10
devanandadhellmann: ^17:10
* dhellmann reads scrollback17:11
devanandaI may be wrong :)17:11
dhellmannwhich extension manager is being used?17:11
SpamapSif that is how you say "don't load me" .. stevedore should probably not log it at ERROR17:11
devanandadhellmann: NameDispatch17:11
devanandahttps://github.com/openstack/ironic/blob/master/ironic/common/driver_factory.py#L4917:12
devanandand17:12
devanandahttps://github.com/openstack/ironic/blob/master/ironic/drivers/pxe.py#L10217:12
*** datajerk has joined #openstack-ironic17:13
dhellmannok17:13
dhellmannwhy don't you want the plugin loaded?17:14
devanandait's a third-party driver17:14
devanandathe required libraries for taht driver may not be present on the system17:14
devanandaSpamapS: one work around is to install said third-party libs, even though you guys won't need them17:15
dhellmannthe philosophy with stevedore is if the manager tries to load the plugin, it should load -- whether or not you can use it is an issue that can be evaluated later17:15
dhellmannwe are relying on that, for example, to get configuration settings from drivers17:15
devanandadhellmann: how would that be done when, eg. that module is missing a dependent library?17:16
SpamapSpretty normal for a plugin to be present but decline to load.17:16
dhellmannthe class registered as the plugin can report an exception when something tries to use it17:16
*** vkozhukalov has quit IRC17:16
devanandadhellmann: um... so that's going to break some other assumptions in ironic17:16
*** romcheg has quit IRC17:16
dhellmannSpamapS: it would work the way you want if you were using the DriverManager, but you're using a "load everything" manager17:17
*** romcheg has joined #openstack-ironic17:17
devanandaif the class loads, ironic-conductor assumes it's usable, and will advertise support for it17:17
devanandaafaik, we couldn't UNload it if it failed17:17
SpamapSFor instance, Asterisk has plugins for proprietary codecs, but you have to have a license for the proprietary codecs or they don't load.17:17
dhellmanndevananda: you can, after loading the plugins, ask them "are you ready to be used?" by invoking a method17:17
*** romcheg has quit IRC17:17
SpamapSdevananda: why aren't we using DriverManager ?17:17
dhellmannSpamapS: I'm aware of other usage patterns. I'm describing what is implemented.17:18
devanandaSpamapS: dunno. dhellmann, should we be using DriverManager?17:18
dhellmanndevananda: it sounds like you're using the manager you want -- maybe we should give you a way to adjust that log message level, or only log it if there is no error handler callback provided17:19
devanandadhellmann: oh, if I provide an error handler, then I could choose to squelch that particular exception?17:19
dhellmanndevananda: not now, but we could make it work that way17:19
devanandathat would work fine, since it's an ironicException I want to squelch anyway17:19
devanandaahh heh17:19
dhellmanndevananda: simple change, move the log message to an else clause on the existing if statement17:20
JayFThat sounds awesome, and I believe would help with IPA as well17:20
dhellmanndevananda: give me a sec17:20
SpamapSdhellmann: sorry for that. :) It seems that we are just in need of a merging of understanding, not learning new things in particular. ;)17:20
dhellmannSpamapS: agreed :-)17:20
devanandadhellmann: thanks much. I should apologize that I keep using stevedore in unexpected ways, but it's working great for them ;)17:21
*** romcheg has joined #openstack-ironic17:21
dhellmanndevananda: well, I expected to need to make changes, so don't apologize for pushing boundaries :-)17:22
lucasagomesromcheg, thanks for the reviews I will address them :)17:22
romcheglucasagomes: My pleasure to review some good code. And to -1 it then :-P17:23
lucasagomesromcheg, lol! \o/17:23
dhellmanndevananda, SpamapS : https://review.openstack.org/8350917:24
JayFThat's great, thanks!17:24
jrollthanks for that, dhellmann :)17:27
dhellmanndo you all have a bug associated with this? If so, I'd like to add it to oslo for tracking.17:29
devanandaSpamapS: ?17:30
devanandaif not, i'll file one17:30
dhellmannthanks17:30
SpamapSI did not file one yet no17:32
devanandak17:33
*** martyntaylor has quit IRC17:36
devanandadhellmann: think there's any likelyhood of that making it in soon, given FF / RC's?17:38
devanandadhellmann: *and into a release of stevedore17:38
dhellmannyeah, I'll try to get it to land today17:38
devanandaawesome17:38
devanandahttps://bugs.launchpad.net/ironic/+bug/129852917:38
dhellmannand do a release tomorrow if that happens17:38
*** zigo has joined #openstack-ironic17:39
NobodyCamhumm seed is booting but undercloud vm appears to not be getting and dhcp at all17:41
*** romcheg has quit IRC17:42
NobodyCamSpamapS: are you testing with the latest devtest patches? are you seeing that on the seed or undercloud?17:42
SpamapSNobodyCam: https://review.openstack.org/#/c/81959/2217:44
NobodyCamyep thats what I'm using17:45
NobodyCamSpamapS: is your undercloud booting?17:45
SpamapSNobodyCam: see the logs there17:47
SpamapSNobodyCam: I am not testing this17:47
SpamapSCI is17:47
NobodyCamack :)17:47
*** romcheg has joined #openstack-ironic17:54
lucasagomesaight I came to the office today so I'm heading back home now18:00
lucasagomeshave a g'night everyone18:00
NobodyCamhave a good night lucasagomes :)18:00
lucasagomesNobodyCam, devananda romcheg rloo, etc... night :)18:00
rloog'night lucasagomes!18:00
romchegBye lucasagomes18:00
romchegHave a good evening18:00
*** lucasagomes has quit IRC18:01
*** matty_dubs|lunch is now known as matty_dubs18:03
NobodyCamSpamapS: strange error in the console log. looks like it couldn't find the pm_type: http://logs.openstack.org/59/81959/22/check-tripleo/check-tripleo-ironic-seed-precise/fb05cfd/console.html#_2014-03-27_10_28_29_60218:04
SpamapSNobodyCam: agreed18:06
*** jistr has quit IRC18:07
hemna_devananda, ping18:10
devanandahemna_: sorta here. what's up18:16
*** blamar has quit IRC18:17
*** blamar has joined #openstack-ironic18:18
Shrewsanyone know what's up with nothing being scheduled for the Friday of the summit? http://openstacksummitmay2014atlanta.sched.org18:19
*** derekh has quit IRC18:19
hemna_devananda, I proposed as session for ironic boot from cinder for atlanta.  trying to coordinate with Wan-yen on it.18:19
devanandaShrews: it's staggered?18:20
devanandaShrews: mon-thu presentations. tues-fri design. I think.18:20
devanandahemna_: thanks!18:21
hemna_devananda, np.  I thought it would be useful to chat about it.18:21
devanandahemna_: fwiw, we only get 4 sessions, so they will probably have to be focused on the project's central needs during Juno18:21
hemna_devananda, ok18:21
hemna_maybe we can meet offline there then?18:21
devanandahemna_: one of them will probably be to address vendor support broadly18:22
hemna_4 sessions isn't very much :(18:22
devanandahemna_: BUT there's a lot of unconference space for more detailed discussions18:22
devanandahemna_: yea... incubated projects don't get much :(18:22
devanandaand it's all on tuesday18:22
devanandahemna_: actuallym, you should propose one to the cinder track18:22
hemna_dang ok.   when I get there I'll try and fill out an unconference room for it then18:23
hemna_devananda, from what I can tell, there isn't much that needs to be done in cinder for this to work.18:23
devanandahemna_: it's as much asbout cinder support as ironic support, and probably fits better in that project18:23
devanandahemna_: last time i talked with the cinder PTL, there was a lot missing in terms of a way to describe volumes18:23
devanandahemna_: genericaly enough that they could be used for ironic18:23
devanandabut that was at the last summit. maybe it's been done already :)18:24
hemna_ok I'll ping john about his thoughts on it then.   I think it can work w/o changes to Cinder, but he knows the internals better than I do.18:24
hemna_Ironic still has some major things to work on to config the node for boot from san.18:25
devanandahemna_: indeed it does18:25
devanandahemna_: there's two possible routes,a nd we need to define an API that supports both18:25
hemna_yah, at this point defining that API is probably a great start.18:25
devanandahemna_: configure BIOS via local channels in the ironic-python-agent || remote configuration via BMC18:26
devanandagotta step out for a few... bbs18:35
*** akrivoka has quit IRC18:41
*** epim has joined #openstack-ironic18:43
*** epim has quit IRC18:44
*** epim has joined #openstack-ironic18:44
*** ndipanov has quit IRC19:00
*** mdurnosvistov_ has quit IRC19:04
*** epim has quit IRC19:06
* devananda is back19:08
NobodyCamwb devananda19:08
devanandahaving difficulty figuring out why transifex is throwing up19:09
*** jdob has quit IRC19:09
*** jdob has joined #openstack-ironic19:09
NobodyCamdevananda: reading over lucas's ML thread on user creds, should we perpose a summit session on the topic?19:10
NobodyCamwe only have 4 sessions thou?19:10
devanandaNobodyCam: yes, only 4 40-minute sessions19:11
NobodyCam:(19:11
devanandaso they need to be very deliberate19:12
devanandawhat's critical to the project that can only be unblocked / addressed by the critical mass of folks there?19:12
devanandathere are *tons* of useful discussions that we should have19:12
NobodyCamya !19:12
devanandasee Summit Ideas @ https://etherpad.openstack.org/p/IronicWhiteBoard19:13
devanandaplease add to it19:13
devanandaor propose a talk19:13
devanandas/talk/session/19:14
devanandaand I'll condense things as needed19:14
devanandaif we end up with 20 sessions proposed, it's not a bad thing :)19:14
JayFdevananda: we have a proposal up to talk about the agent, that seems like it might be worthy of a slot?19:14
NobodyCam:)19:14
devanandaJayF: yes19:14
JayFah cool Jim must've already added that to the etherpad19:14
devanandaJayF: I'd prefer as much info ahead of time as possible in the BP/etherpad/session proposal19:15
devanandaJayF: i'll probably into the topic, then you guys should present the code layout / arch / etc, then open the remaining ~30 min for discussion19:16
devanandaJayF: also we should have clear goals to come out of the session19:16
devanandaso that the discussion stays on topic and results in action19:16
JayFHopefully that will be more than preseting code layout, I hope we can have a live prototype demo19:16
devanandaI think that was a shortcoming of my organization last time. we had 3 sessions of talking and then attempted to wrap it all together in the last session for "action items"19:17
jrollJayF: I proposed that session a few weeks back on summit.openstack.org19:17
devanandarather than having each session start with "here are the goals"19:17
jrollhence the link :P19:17
devanandaJayF: so. demo. It'll be great to have it working. But.19:18
devanandaJayF: the format of the design sessions is not to present / demo soemthing19:18
JayFyeah I didn't know it had been linked into the mentioned etherpad though19:18
JayFbut we should polish it up, come up with clear goals like deva said, before going to the summit19:18
JayFand hopefully we can talk about how it works while showing it working :)19:18
devanandaJayF: as long as the demo/presentation part is kept under, say, 10 minutes, it's probably OK19:19
JayFI understand, demo is secondary, but it's important to us as a proof of concept, that what we're trying to do works /then/ while we're talking about it rather than talking about what might be possible :)19:19
devanandaJayF: absolutely!19:19
JayFI like things that work more than I like ideas that might work :P19:19
devanandaJayF: it should totally be working AND you should totally demo it19:19
linggaodevananda, NobodyCam, talking about session,  have proposed 2 sessions.19:21
devanandaJayF: my point is about format of the summit sessions. considering that we, as a project, only have 4 x 40m slots in which to resolve discussions that require the whole group, a lengthy demo is not efficient use of that time19:21
JayFI get that. It's actually a bit shocking that such little time is able to be able to dedicate to the project19:21
JayFLike I guess I was expecting there to be more limitations on 'we need everyone' time vs 'ironic' time, but having not been to a summit that seems to be very wrong19:22
devanandaJayF: one of the challenges is that our 4 slots overlap with the cross-project day19:23
devanandaso actually19:23
openstackgerritAdam Gandelman proposed a change to openstack/ironic: Raise unexpected exceptions during destroy()  https://review.openstack.org/8294819:23
devanandasome of our core team will NEED to be in those sessions19:23
devanandaand not participate in our own design19:23
devanandaI've already done what I can about this, but been overruled19:23
NobodyCam:(19:23
NobodyCambrb19:24
devanandalinggao: hi! I'll be reviewing the sessions as we get closer to the summit. I expect that folks will continue to propose more19:24
linggaodevananda, NobodyCam, one is for chassis level functions and the other one is more hardware control functions.19:25
openstackgerritJim Rollenhagen proposed a change to openstack/ironic-python-agent: Fix URL for node lookup  https://review.openstack.org/8353919:25
devanandalinggao: if you've followed this discussion, you will hopefully understand why I will need to condense many sessions together, or push them to unconference space19:25
*** max_lobur1 has quit IRC19:25
linggaodevananda, sure. I just wonder should I start writing blueprint for them or should wait after the summit.19:26
devanandalinggao: please file BPs ahead of the sumit and link them to the proposals, if that is appropriate19:27
devanandalinggao: or reference an already existing BP if one exists19:27
openstackgerritAdam Gandelman proposed a change to openstack/ironic: Remove some obsolete settings from DevStack doc  https://review.openstack.org/8354019:28
linggaodevananda, sure. will do.19:28
*** GheRivero has quit IRC19:28
devanandaHaomeng: ping19:29
*** vkozhukalov has joined #openstack-ironic19:31
linggaoHe may be asleep :). It is 3 am for him.19:32
*** mtrisoline has joined #openstack-ironic19:32
openstackgerritJim Rollenhagen proposed a change to openstack/ironic-python-agent: Fix URL for node lookup  https://review.openstack.org/8353919:35
NobodyCamlinggao: I hope he is a 3 am :-p19:36
*** mtrisoline has left #openstack-ironic19:37
*** mriedem has joined #openstack-ironic19:39
*** mriedem has left #openstack-ironic19:39
linggaoNobodyCam, :)19:41
devanandaanyone looking for things to delve into?19:41
*** epim has joined #openstack-ironic19:44
Shrewswhy is check_uptodate.sh borking on the sample config from master?19:44
Shrewsi mean, how does that happen if it causes pep8 to fail?19:45
*** mtrisoline has joined #openstack-ironic19:46
*** GheRivero has joined #openstack-ironic19:46
mtrisolineIs it possible someone may be able to help me with updated docs? This seems out of date, I am trying to implement nova-baremetal as part of a requirment to use openstack. #openstack-nova pointed me here. https://wiki.openstack.org/wiki/Baremetal19:47
linggaodevananda,   I am looking for something to do.19:47
NobodyCamShrews: what is the error you are getting19:47
NobodyCamhi mtrisoline19:48
ShrewsNobodyCam: just that the sample is out of date. specifically: check_uptodate.sh: ironic.conf.sample is not up to date.19:48
NobodyCammtrisoline: you need nova-baremetal? not Ironic? we are working on replacing nova baremetal19:49
NobodyCamShrews: is there a diff?19:49
NobodyCamhave you pulled any patches, there was a hostname issue but I thought that was fixed awhile ago19:50
mtrisolineNobodyCam: I know, but I have to work off of Havana atm. Unless there is a way I can patch in Ironic.19:50
ShrewsNobodyCam: indeed. http://paste.openstack.org/show/74483/19:50
NobodyCammtrisoline: I would have to know a little more, Ironic does at this point have a working (deff not bug free, but working) nova driver19:51
mtrisolineO, I was not aware of that.,19:52
NobodyCamShrews: are your on master branch?19:53
NobodyCamShrews: I'll need to test that, going to be a minute19:53
NobodyCammtrisoline: do you use devtst or devstack at all?19:54
mtrisolineNobodyCam: Basically we want to replace our vmware with openstack and offer up IaaS internally to the company, but for production we run all our databases and hadoop clusters on bare metal. We were looking into the functionality to replace our kickstart setup with the baremetal functionality of openstack. Does that help?19:54
ShrewsNobodyCam: i am on master19:55
NobodyCammtrisoline: so at this point you have no openstack infrastructure19:56
ShrewsNobodyCam: HEAD is f1e70219:57
devanandalinggao: ok! which would you prefer -- writing new scheduler filters? debugging our jenkins' translation job19:57
mtrisolineNope just one baremetal node acting as a single controller and everything else virtualized w/in an old hypervisor, but I have 4 servers on the way on top of a few more that are being pulled from production to throw into a full dev environment for this.19:57
NobodyCamI would suggest looking at the TripleO stuff. https://github.com/openstack/tripleo-incubator19:57
openstackgerritA change was merged to openstack/ironic-python-agent: Fix URL for node lookup  https://review.openstack.org/8353919:57
devanandamtrisoline: I don't know how much the internal nova virt driver API has changed since Havana19:58
devanandamtrisoline: I suspect that will be the biggest area of potential conflict19:58
linggaodevananda, I prefer the first one.19:58
mtrisolineRight now in my dev environment I have everything else 100% working and functional.19:58
devanandahttps://bugs.launchpad.net/tripleo/+bug/129139619:59
mtrisolineOur existing setup works extremely well for the baremetal stuff, so I know I can push this off. I was just really trying to get this into my proof of concept. I definitely appreciate the info. I will look into the ironic driver in Havana.19:59
devanandaand see my comments on https://bugs.launchpad.net/ironic/+bug/129142019:59
devanandalinggao: ^19:59
rlooShrews, NobodyCam: wondering if this change has anything to do with it: https://review.openstack.org/#/c/83471/1/requirements.txt20:00
devanandaRohan (k4n0) said a week ago he was working on it, but i don't see any patches up20:00
devanandalinggao: description of what I think needs to be done -- https://bugs.launchpad.net/ironic/+bug/1291420/comments/320:00
linggaodavananda, ok. Let me read it.20:01
Shrewsrloo, NobodyCam: I mean, it has to be something with my environment, right? A change that doesn't pass the pep8 test would never get merged into master. This is new magic I do not yet comprehend.20:01
Shrewsperhaps i should rebuild the tox venv20:02
adam_gShrews, i was scratching my head similarly the other day. my  branch's sample was out of date, but so was masters?20:02
NobodyCamShrews: unless they changed the pep8 rules in mid landing of a patch20:02
NobodyCamShrews: ya :)20:02
*** harlowja is now known as harlowja_away20:03
NobodyCammtrisoline: are you getting a error (I may have missed seeing it)20:04
* Shrews rebuilds venv20:04
devanandaeek20:10
* devananda realizes we broke a unit test for seamicro20:10
*** mdurnosvistov_ has joined #openstack-ironic20:10
devanandaright. so this is interesting20:10
devanandaallow third-party drivers to load plugins not in requirements.txt (which we should do, cause, vendor stuff)20:10
devanandaand more sane handling of errors while loading said drivers20:11
devanandameans that we DONT actually test them. EVEN THE UNIT TESTS20:11
devanandamordred: thoughts on ^ ?20:12
NobodyCambrb20:13
JayFdevananda: should we have a separate test-requirements.txt which installs those 'unapproved dependencies' for testing purposes? Maybe even make a separate check job that checks with the vendor libs vs without?20:15
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Have stevedore convert DriverNotFound to a warning  https://review.openstack.org/8357220:16
devanandaJayF: probably. however. I don't know if -infra approves of such things, which is why I pinged mordred20:17
mrda_awayMorning all20:17
JayFdevananda: wdyt about lifeless's comments here? https://review.openstack.org/#/c/83231/ I gtg but would love to be able to see your comments on the review when I get back this evening, so I can work on it again.20:17
devanandaJayF: there's a larger discussion around such things for several projects20:17
NobodyCammorning mrda_away20:17
JayFIt's just strange that these ongoing conversations happen somewhere other than the ML tbh20:17
devanandaJayF: ah, right20:17
lifelessI didn't know there was a larger discussion20:18
devanandaby that i mean all the third-party testing support20:18
JayFlifeless: sorry, there are like two conversations happening simultaneously :) we were talking about seamicro not your comments.20:18
devanandawhich has been on the ML, IRC, and elsewhere20:18
lifelessohright20:18
JayFah, gotcha20:18
*** mrda_away is now known as mrda_20:19
devanandaJayF: w.r.t. lifeless' comments, I stand by my bug report (low-level messages shouldn't go into node.last_error)20:19
*** packet has joined #openstack-ironic20:19
devanandaJayF: and you need unit tests :)20:19
NobodyCammorning lifeless20:20
* JayF may need to learn how to write unit tests20:20
*** mrda_ has quit IRC20:20
*** jbjohnso_ has quit IRC20:20
JayFbut that's OK, I knew it was coming :) No time like the present20:20
devanandaJayF: also, i think you're missing a bunch of other parts of conductor.manager20:20
lifelessdevananda: its your call, but I'd really love it if you got fully involved in tripleo-cd ops before making it20:20
devanandaJayF: so this should have a a Partial-bug, not a Closes-bug, tag20:20
lifelessdevananda: because, wearing my ops hat, you're wrong :)20:21
devanandalifeless: I love it when I'm wrong :)20:21
JayFdevananda: I'll try to get more coverage of those error types, and get some tests in.20:21
JayFbbl20:21
devanandaJayF: thanks!20:21
devanandalifeless: if we assume the only consumer of ironic is a trusted operational team, then you'd be correct -- we should expose *all* the plubming20:22
devanandalifeless: but that assumption is incorrect20:22
openstackgerritMatt Wagner proposed a change to openstack/ironic: Add documentation for Ironic config file  https://review.openstack.org/8357720:23
lifelessdevananda: I didn't argue for exposing all the plumbing20:23
lifelessdevananda: so thats a straw man vs my actual position20:23
NobodyCamlifeless: quick sidetrack question.. have you seen any "Falied to resize filesystem" errors on the undercloud when deploying?20:23
devanandalifeless: ok. more precisely, exposing the low-level exception traces from drivers20:23
devanandalifeless: which could include eg. output from executils, ssh, sfdisk, or other nitty gritty bits of drivers that we don't control20:24
lifelessNobodyCam: yes, there's a bug open in diskimage-builder and ubuntu20:24
NobodyCam:) TY20:24
*** mrda_ has joined #openstack-ironic20:24
lifelessNobodyCam: and you can often work around by tweaking the 0.X multiplier in disk-image-create20:24
lifelessdevananda: yes but thats a driver concern20:25
*** mrda_ has left #openstack-ironic20:26
*** mrda_ has joined #openstack-ironic20:26
devanandalifeless: ahh20:27
* devananda looks for rloo's patch20:27
rloowhat patch?20:28
lifelessdevananda: and e.g. output from sfdisk is *useful* and not a security concern20:28
devanandarloo: iirc you were cleaning up the driver exception messages at one point20:28
devanandathis one20:29
devanandahttps://bugs.launchpad.net/ironic/+bug/126769320:29
rloodevananda: I think I was cleaning up the exceptions so they would all be IronicExceptions20:29
devanandayep20:29
rlooyeah, that one. Not necessarily the messages?20:29
* rloo scrolls back to understand context20:29
devanandalifeless: if drivers always caught exceptions from the tools they invoked, and then raised IronicExceptions with meaningful messages20:31
devanandalifeless: that would be something I think should be exposed in the API20:32
devanandalifeless: the issue is, right now, driver's aren't well policed about that.20:32
devanandalifeless: and I can understand how hiding too much is worse right now than showing too much, so if you agree with that ^ direction, I think we can punt on that until Juno.20:34
*** harlowja_away is now known as harlowja20:35
rloodevananda, if I understand, seems like we (or me I guess) should just clean up the exception msgs from the drivers, and leave the code in manager.py as is.20:35
lifelessdevananda: I think saying 'drivers raising other than IronicException is a bug regardless of whether the operation failed or not'20:35
lifelessdevananda: is valid - if thats a reasonable rephrase of your viewpoint I think we have consensus20:35
devanandalifeless: ++20:35
*** jbjohnso_ has joined #openstack-ironic20:35
devanandaor more precisely20:36
*** mrda_ is now known as mrda20:36
devanandanvm. good enough20:36
* devananda updates bug desc20:36
devanandaand closes the other20:37
devanandarloo: yep. so that's two things: make sure drivers are raising suitable user-visible strings, and make sure drivers are really careful not to allow exceptions (from the things they call) to propagate up20:38
rloodevananda: do you see those as two separate bugs, and/or do you want me to do them both in the same bug: 1267693?20:39
rlooI was so close too. Only had pxe.py to do, but now who knows what has changed. ha ha. ;)20:39
lifelessdevananda: point is to me that we should be able to get e.g. sfdisk output wrapped in IronicException - that would be ok right ?20:40
devanandalifeless: yes. if eg. the PXE driver captures the excutils exception,"sanitizes" it, and raises an IronicException (or subclass), that's fine20:41
*** EmilienM has quit IRC20:42
devanandalifeless: my objection and the reason for that bug was seeing full dumps from excutils in node.last_error20:42
linggaodevananda, I digged a bit on this defect (exact match filter), so the need is to write new filters under nova/schduler/filters,20:42
devanandalifeless: but I agree, this is a better solution20:42
linggaodevananda, the filters will make sure the host has nodes that match the flavor exactly.20:42
*** EmilienM has joined #openstack-ironic20:43
devanandarloo: I could go either way. (a) improve the try: handling in drivers, so nothing "slips through" (b) sanitize the low-level errors and use good, informative messages20:43
linggaodavananda, then overrides scheduler_default_filters CONF setting in ironic_host_manager.20:43
devanandarloo: if you feel that's worth two bugs, please open another20:43
linggaodavananda, am I on the right track?20:43
devanandalinggao: yes, except this seems off: "make sure the host has nodes"20:44
rloodevananda. I don't really care if it is two bugs or not ;) I'll just add a comment to the existing bug to remember to check/do that.20:44
devanandalinggao: the nova-scheduler is choosing a specific node, represented in nova as (host, hyperisor_hostname) or (host, node)20:44
devanandarloo: k k20:44
linggaodevananda, I am lost here. Is the scheduler choosing a compute host or choosing a baremetal node in our case?20:46
lifelessdevananda: so can we reword that bug ?20:47
devanandalinggao: both20:48
devanandalinggao: but for ironic, it does not matter which compute host the scheduler picks -- it only matters which node20:48
devanandalinggao: all compute hosts see the same pool of nodes20:49
linggaodevananda, so in the exact-match-filters, what items should be exactly match?20:51
*** mrda has quit IRC20:51
devanandalinggao: cpu, ram, disk20:51
devanandalifeless: i closed https://bugs.launchpad.net/ironic/+bug/1265587. how do you propose updating https://bugs.launchpad.net/ironic/+bug/126769320:52
devanandalifeless: i think the wording is already fairly close to your earlir suggestion20:52
linggaocpu of one of the baremetal nodes or cpu of the compute host?20:52
devanandalinggao: ironic node. the compute host is functionally not much more than a proxy20:53
*** mrda has joined #openstack-ironic20:54
linggaodevanand, I think I got it. I'll study more and work on it tomorrow.20:54
linggaodavananda, thanks.20:55
*** jdob has quit IRC20:55
*** romcheg has quit IRC20:55
NobodyCamhumm .. /me thinks he needs some food stuffs20:57
NobodyCambrb20:58
*** vkozhukalov has quit IRC20:59
lifelessdevananda: looking21:01
openstackgerritRuby Loo proposed a change to openstack/ironic: Install guide for Ironic  https://review.openstack.org/8164521:02
lifelessdevananda: looks fine to me21:02
devanandalifeless: :)21:02
*** derekh has joined #openstack-ironic21:03
*** romcheg has joined #openstack-ironic21:04
*** linggao has quit IRC21:04
*** linggao has joined #openstack-ironic21:05
*** linggao has quit IRC21:06
adam_gwhere/how was the nova driver being unit tested prior to it being merged into the ironic tree? this predates me and im having trouble finding traces of it in the nova or ironic trees21:08
lifelesstested?21:09
lifelessironic/nova/tests/ I think you'll find21:09
devanandayes ^21:09
adam_gdoh21:10
devanandaurgh! LP won't let me update this one bug! https://bugs.launchpad.net/ironic/+bug/1229324/+editstatus21:10
devanandaother bugs are fine...21:10
devanandathat one's been timing out since yesterday21:10
*** jbjohnso_ has quit IRC21:11
comstuddevananda: the edit screen loads for me21:11
comstudi dunno if you get that far or not21:11
devanandacomstud: edit loads for me, too21:12
comstudok21:12
devanandacomstud: "save" times out21:12
comstudWhat do you want changed? I can attempt, although I dunno if I'll even have perms21:12
devanandacomstud: thanks. status -> fix commit. importance -> wishilist21:12
NobodyCamdevananda: timesout for me21:12
devanandaheh21:12
comstudSorry, something just went wrong in Launchpad.21:13
comstudWe’ve recorded what happened, and we’ll fix it as soon as possible. Apologies for the inconvenience.21:13
comstudTrying again in a couple of minutes might work.21:13
devanandayea21:13
comstudheh21:13
devanandaso, that bug is broken21:13
*** florentflament has joined #openstack-ironic21:13
devanandayay!21:13
comstudfile a bug about the bug21:13
devanandahahaha21:13
NobodyCamlol my bug is not working :-p21:14
NobodyCamsounds like a bug to me21:14
NobodyCam:-/21:14
lifelessdevananda: can I describe a problem for you21:16
lifelessdevananda: when configuring Ironic, if there are no conductors running, we can't add nodes21:16
lifelessdevananda: but there's no API to see if conductors are running21:16
lifelessdevananda: analogous to nova service-list or neutron agent-list21:16
devanandalifeless: sure there is. ironic driver-lsit21:17
devananda*list21:17
lifelessahha21:17
lifelessthat was entirely unobvious21:17
lifelessthank you21:17
devananda:)21:17
devanandahmmm21:18
devanandathe CLI help text is not very helpful21:18
devananda"List drivers."21:18
lifelesssee ;)21:18
devanandalifeless: thoughts on how to "hide" the fake* drivers in a production install? do you see a reason not to do that?21:21
lifelessrequire a config option to enable them21:22
lifelessset that in devstack21:22
devanandahm21:22
devanandawould work21:22
*** mdurnosvistov_ has quit IRC21:26
*** derekh has quit IRC21:30
rloodevananda: why isn't https://bugs.launchpad.net/bugs/1298628 a python-ironicclient bug?21:35
devanandarloo: because I am opening lots of bugs and tagged it wrong :p21:37
rloodevananda: :-(21:37
devanandaactually21:37
lifelessoh I had a new failure for you21:37
devanandarloo: there, i moved it21:38
lifelessah you saw it21:38
rloodevananda. the person who takes that bug thanks you ;)21:38
rloodevananda. wrt docn, do you want a quick status?21:40
rloodevananda. forget it, I think it might be better to put the status in the etherpad. will do that later ;)21:40
devanandarloo: i think i'm fairly up on it, but ...21:40
devanandarloo: that's even better21:40
devanandaoh21:41
devanandaas a general reminder to folks (including myself)21:41
devanandaif you start an etherpad with interesting things in it21:41
devanandaplease reference it here: https://etherpad.openstack.org/p/IronicWhiteBoard21:41
rloodevananda. thx, good to know (or maybe I forgot...)21:42
*** tatyana has joined #openstack-ironic21:43
devanandalifeless: is there further action required based on the content of https://etherpad.openstack.org/p/ironic-nova-friction in the immediate future?21:43
lifelessdevananda: I suspect not21:50
NobodyCambrb21:50
lifelessdevananda: separately though we'll need a thing to stop ironic deploying to itself21:51
lifelessdevananda: this affects the hash ring21:51
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Fix seamicro validate() method definition  https://review.openstack.org/8359821:51
devanandalifeless: hah21:51
devanandalifeless: or at least deploying itself into the sme control plane21:51
*** epim has quit IRC21:52
lifelessdevananda: specifically the conductor shouldn't try to deploy an image to a node which it is running on21:52
devanandalifeless: if ironic and ironic' use different DB instances (and none of the enroled hw is duplicated) it should be OK21:52
devanandawait21:52
comstuddevananda: question for you re: object code in ironic when you have a minute21:52
devanandaironic won't deploy an image to a node that has an instance on it21:53
devanandalifeless: so i dont think taht's a problem. you need to delete the current instance first21:53
*** matty_dubs is now known as matty_dubs|gone21:53
devanandacomstud: shoot21:53
lifelessdevananda: nova rebuild21:53
comstuddevananda: There's a slight bug so I was going to put up a fix. It's related to the @base.remotable decorators... for example, on Node.save21:54
comstuddevananda: Do you ever intend to allow those to be proxied to anything?  I don't think they are needed in Ironic21:54
comstudin nova... they are used to force a save() to proxy over to nova-conductor to execute there.21:54
devanandalifeless: oh. you're thinking, "what if novarebuild of a ironic instance that ironic deployed"21:54
devanandalifeless: yea... that's fun. braincandy for another day :)21:55
lifelessdevananda: scenario: take three machines, deploy ironic on all of them using ironic from a fourth machine. uninstall ironic from the fourth machine. Now do 'nova rebuild' of one of those nodes.21:55
lifelessdevananda: this is the undercloud upgrade process :)21:55
devanandacomstud: well. hypothetically, rpcapi.update_node could be wrapped in @base.remotable21:56
lifelessdevananda: but equally, 'nova delete' on one, may turn itself off hard without cmopleting the delete.21:56
comstuddevananda: What service would you proxy it back to?21:56
devanandacomstud: i dont see any particular benefit to that. do you?21:56
devanandacomstud: conductor21:56
comstudfrom API?21:56
comstudI'm not sure I do21:56
devanandacomstud: yes. that's what we do now, we just didn't use @remotable21:57
comstudah21:57
comstudGotcha21:57
devanandawhen API needs to udpate a node, it calls rpcapi.update_node21:57
devanandaall the work happens in conductor21:57
comstudunder a lock I assume21:57
devanandaexactly21:57
devanandaand with some other handling21:57
comstudIf you wanted to use the proxy stuff built into objects...21:57
comstudthat would mean moving the locking into save()21:57
devanandacomstud: i would only want that to effect save() on the API side21:58
comstudright21:58
devanandai dunno if objects could do that?21:58
comstudSo, you could... a bit hackily maybe..21:58
comstudHow the indirection stuff works..21:58
*** eguz has joined #openstack-ironic21:58
comstudin conductor you'd have a object_action method21:58
devanandayea, i didn't dig into the indirection enough to grok it. seems needlessly complex for ironic's use case21:59
comstudit gets as args the object method to call with its args21:59
comstudyou could do it in there ahead of calling object.save()21:59
comstudyeah, that's what I'm thinking here21:59
comstudso I'm considering just removing the decorators22:00
*** tatyana has left #openstack-ironic22:00
comstudI'll give you a quick background on the issue I want to fix..22:00
comstudobjects are supposed to cache the context used on get()22:00
comstudsuch that you only need to do object.save()22:00
*** tatyana has joined #openstack-ironic22:00
devanandalifeless: right. i get the scenarios. need to map out the implications and interactions, and dont have the bandwidth right now22:00
comstudhowever, save() has a context arg... because unfrotunately RPC requires it...22:00
comstudbut it's only required if you have the decorator22:00
devanandacomstud: ahhh. i think this is a thing that's been annoying me for a while22:01
comstudthe bug right now is... the Node object doesn't store the context on get_by_uuid() and it should22:01
devanandayep22:01
devanandacomstud: please fix that :-D22:01
comstudI pointed jroll to a couple of diffs and am going to fix it22:01
comstudyeah22:01
devanandaawesome!22:01
lifelessdevananda: I think its fairly easy22:01
lifelessdevananda: monday perhaps ?22:01
comstudas a part of it.. I could remove the decorators to remove confusion :)22:01
comstudor I could just leave them.22:01
devanandalifeless: when the list of RC1 bugs reaches 0 :)22:02
lifelessdevananda: mmmm22:02
* devananda points out that we almost reached 0 today, and now it's up to 522:02
devanandahttps://launchpad.net/ironic/+milestone/icehouse-rc122:02
*** eguz has quit IRC22:02
comstudhah22:03
*** eghobo has quit IRC22:03
devanandalifeless: anything else you feel is reeeeealy important for icehouse, please file it and poke me to tag it22:03
*** eghobo has joined #openstack-ironic22:03
devanandalifeless: ya'll having tripleo start using ironic now is awesome but oh how I wish it had happened just one week earlier :)22:03
lifelessdevananda: so do I but people bandwidth is what it is22:07
NobodyCamso close22:07
devanandalifeless: indeed it is22:08
*** derekh has joined #openstack-ironic22:08
*** thehybridtech has quit IRC22:13
openstackgerritJosh Gachnang proposed a change to openstack/ironic-python-agent: Adding DynamicLoopingCall around lookup  https://review.openstack.org/8360422:19
*** tatyana has left #openstack-ironic22:25
devanandaJoshNang: take a look at https://review.openstack.org/#/c/83105/22:28
devanandaJoshNang: and https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L15422:29
devanandaJoshNang: maybe im totally wrong, but it might be neat to reuse some of this code eventually22:29
devanandaJoshNang: that's three places that are basically doing the same thing22:29
JoshNangdevananda: oh that's handy22:30
JoshNangnot sure how i missed the ipmitool one when grepping around to see how other people did this22:30
devanandaJoshNang: it landed this week ;)22:31
JoshNangha that'll do it22:31
devanandaspeaking of... Shrews -- you might want to incorporate some of that into the retry stuff you're working on, too (eventually)22:32
devanandaShrews: exponential back-off of retries, i mean22:32
JoshNangit seems like the main issue is not having a timeout on DynamicLoopingCall22:33
JoshNangor having a sub/replacement class that does ExponentialBackoffLoopingCall. seems like a very handy thing to have22:34
devanandaExponentialBackoffWithTimeout22:34
devanandaor such22:34
devanandaseems like a reasonable thing to add to oslo22:35
openstackgerritAlex Gaynor proposed a change to openstack/ironic-python-agent: Added PyPy env to tox.ini  https://review.openstack.org/8360522:35
JoshNangdefinitely. i'll add it to my to do list22:37
openstackgerritJosh Gachnang proposed a change to openstack/ironic-python-agent: Adding DynamicLoopingCall around lookup  https://review.openstack.org/8360422:45
openstackgerritJim Rollenhagen proposed a change to openstack/ironic-python-agent: Change argument name in service file  https://review.openstack.org/8360822:46
devanandaSpamapS: i believe this should fix the issue you ran into this morning, if you also pull the latest stevedore from trunk -- https://review.openstack.org/#/c/83572/22:46
SpamapSdevananda: you mean stevedore 0.15 ? ;)22:47
SpamapS(read the ML :)22:47
devanandaahh22:47
devanandayep22:47
devanandaand sure enough, it works22:47
devanandahttp://paste.openstack.org/show/74507/22:48
devananda:)22:48
devanandadhellmann: ^ tanks!22:48
devanandalifeless: NobodyCam: have a moment to review https://review.openstack.org/#/c/83572/ ?22:49
* NobodyCam clicks22:49
NobodyCamdevananda: +2'd I did not test as i'm in the middle of a devtest run.. so I used your paste :)23:02
devanandaack23:02
NobodyCamafternoon walkies bbaifm23:04
devanandalifeless: comment on https://review.openstack.org/#/c/66621/8 -- are you concerned about the performance cost of compiling a regex on every API request?23:05
jrolldevananda: I can't speak for lifeless, but it's a fairly simple regex and only two URLs it's compiling for23:09
jrollI was thinking about the same thing, but I think it's fairly negligible23:10
devanandahumm23:13
devanandajroll: so I just added a LOG line to auth_token to see when it's actually compiling the regex23:14
devanandaperhaps i've been staring at this screen for too long now23:14
NobodyCamwhy?23:14
devanandabut it's not logging23:14
*** eghobo has quit IRC23:15
jrolldevananda: is that middleware even installed?23:16
devanandathat's waht i'm wondering23:16
jrollI don't think it is23:16
jrollheh23:16
devanandaheh23:17
devanandaso what's this patch for? :)23:17
jrollfor fun, clearly23:17
jroll*should* we be using that middleware?23:17
*** romcheg has quit IRC23:18
jrolloh wait23:18
jrollthe acl hook uses the AuthTokenMiddleware23:18
devananda right23:18
jrollyeah, so it should be used23:20
devanandathe module is loaded23:20
devanandabut the class isn't isntantiated23:20
jrollit should be, with the default pecan config23:20
jrollenable_acl is True23:20
jrollacl.install() returns the wsgi app wrapped with AuthTokoenMiddleware23:21
jrolls/Tokoen/Token23:21
devanandaoh, sec23:22
openstackgerritA change was merged to openstack/ironic: Nova Ironic driver to set pxe_swap_mb in Ironic  https://review.openstack.org/8313123:22
devanandayea, it's late ...23:22
devanandaheh23:22
devanandawrong test env23:22
jrolllol23:22
devanandai had auth disabled in /taht/ env23:22
jrollright23:23
devanandatesting again23:23
jrolloh yeah, this shouldn't be compiling on every request23:23
jrolljust at setup time23:23
* jroll has also been staring too long23:23
jrollonly the match() is executed at request time23:24
devanandayea23:24
devanandaand it is23:24
devananda+A'd23:24
jrollnice23:24
devanandaok... with that, i'm done for a while23:25
* NobodyCam thinks devananda needs more tea (or coffee)23:25
NobodyCamlol23:25
devanandaNobodyCam: ++ !!!23:25
NobodyCam:)23:25
NobodyCamhave a good night devananda23:25
jrollnight deva23:25
devanandaNobodyCam: one last one for you -- since I dont want to push my own patch through23:26
devanandahttps://review.openstack.org/#/c/83598/23:26
NobodyCamcan we write a test that tests that our tests have run?23:28
lifelessdevananda: it compiles once23:28
NobodyCamI really tried to get another test into that one23:28
lifelessdevananda: which is why I was fine with it23:28
*** jgrimm has quit IRC23:28
*** packet has quit IRC23:29
openstackgerritA change was merged to openstack/ironic: Raise unexpected exceptions during destroy()  https://review.openstack.org/8294823:36
NobodyCamlifeless: question: can ironic reffer to itself as "an OpenStack project" or do we have to use "an Incubated OpenStack project"?? do you know?23:39
NobodyCamin say our user doc's23:40
NobodyCammordred: ^^^ would know the answer?23:40
mordredNobodyCam: I believe it's well within scope in your user docs to call yourself an OpenStack project23:43
mordredNobodyCam: you receive ATC credit for working on it - you are contributing to openstack in an approved program23:43
mordredIronic is not part of the Integrated Release23:43
NobodyCam:)23:43
mordredbut that does not make it a part of the OpenStack effort23:43
NobodyCamvery good... Thak you23:43
NobodyCamthank even :)23:44
jrolllooking at the nova driver23:48
jrollseems pretty hardcoded to the pxe driver23:48
jrollare we going to need to write another nova driver for the agent, or just abstract things out a bunch?23:49
*** early has quit IRC23:49
NobodyCamjroll: https://github.com/openstack/ironic/blob/master/ironic/nova/virt/ironic/ironic_driver_fields.py was attempting to deal with just that issue23:51
NobodyCamwhere are you seeing conflict23:51
jrollyeah23:51
jrollI saw pxe all over driver.py23:51
jrollbut didn't read close enough until now to see "if 'pxe' in node.driver"23:51
jrollso we can just add to that, I suppose23:52
NobodyCamwe tried not to pigon hole our self's into just pxe.. we may not have be secussful everywhere23:53
*** early has joined #openstack-ironic23:53
jrollheh23:53
NobodyCamsuccessful even23:53
jrolldon't worry, I'll make sure of that very soon :)23:53
NobodyCamdriver fields file23:54
jrollyeah23:54
jrollI'm going to implement the agent stuff as much as possible over the next few days / maybe a week23:54
*** stevehuang has quit IRC23:55
jrollNobodyCam: do you know, should cpu_arch be 'amd64' for 64-bit machines?23:55
jrollor something else23:55
NobodyCamyes23:56
jrollthanks23:56
*** Madasi has quit IRC23:57
NobodyCamjroll: i should it can be something else but the standard toolng uses amd6423:57
*** derekh has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!