Tuesday, 2014-03-25

openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Update Neutron if mac address of the port changed  https://review.openstack.org/7793900:02
*** Hefeweizen has joined #openstack-ironic00:02
lifelessNobodyCam: agrgghhgh00:02
devanandaok, I need to step away for a few hours... will try to be back late tonight to do a few more reviews00:02
NobodyCamlifeless: ahh looks like we need to add compute_manager to nova.conf in the nova elelmet too :)00:02
lifelessNobodyCam: yes  I have a patch for that00:02
NobodyCam:)00:03
openstackgerritlifeless proposed a change to openstack/ironic: Provide a new ComputeManager for Ironic  https://review.openstack.org/8263700:03
lifelessI was just testing it but it build nova-bm for some reason00:03
lifelesslet me push up00:03
openstackgerritJay Faulkner proposed a change to openstack/ironic: Set good defaults for heartbeat interval & timeout  https://review.openstack.org/8261500:04
NobodyCamlifeless: are building with DIB_REPOLOCATION_nova or _ironic to test these?00:04
NobodyCamim using ironic for the compute_manager paatch00:05
jrollhey, is there a documented way to mock out the waiting done in looping calls?00:07
jrollI'd like to speed up these 8 second seamicro tests :)00:08
jrollgoing to see what mocking out eventlet.greenthread.sleep does for me...00:10
*** epim has quit IRC00:10
lifelessNobodyCam: DIB_REPOLOCATION_ironic=https://review.openstack.org/openstack/ironic00:14
lifelessDIB_REPOREF_ironic=refs/changes/37/82637/300:14
NobodyCam:)00:15
*** openstack has joined #openstack-ironic00:19
lifelessperhaps /4 now :)00:21
NobodyCam:)00:21
lifelessyeah00:21
jrollNobodyCam: I've got a couple fixes to speed tests up - should those go in separate reviews or is one ok?00:22
jrollit's 3 changes, 4 lines total00:22
jrollbut those 3 are totally unrelated00:22
lifelessjroll: 3 changes :)00:22
NobodyCamjroll: they are all tests?00:22
lifelessjroll: GitCommitMessages is fairly clear on this00:23
jrollNobodyCam: yes, all in tests00:23
jrollI'll put up three reviews00:24
NobodyCamlifeless: is correct, but four lines, I would accept a single "Speeed up ironic tests." review00:24
NobodyCam:-p00:24
jrollok, one review it is :)00:25
jroll~30s -> ~12.5s00:25
* NobodyCam notes he ended his example with a . which would not pass pep800:25
jrollper environment00:25
jrollheh, yeah00:25
jrolloops, it's -2 +5, I underestimated :P00:26
jrollI'll put it up and if someone prefers, I'll break it out00:26
*** matsuhashi has joined #openstack-ironic00:26
NobodyCam:) jroll nice :) oh no over the limit 3 reviews00:26
NobodyCamlol00:26
jrolllol00:26
NobodyCamhehehe j/k00:26
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Speed up ironic tests  https://review.openstack.org/8268000:30
jrollNobodyCam: ^00:30
jrolland on that note, I'm off. have a good night all :)00:30
openstackgerritA change was merged to openstack/ironic: Pass no arguments to _wait_for_provision_state()  https://review.openstack.org/8266900:46
*** krtaylor has quit IRC01:07
*** krtaylor has joined #openstack-ironic01:11
*** krtaylor has quit IRC01:20
*** krtaylor has joined #openstack-ironic01:23
*** rwsu has quit IRC01:26
*** nosnos has joined #openstack-ironic01:29
*** matsuhashi has quit IRC01:30
*** matsuhashi has joined #openstack-ironic01:30
*** rwsu has joined #openstack-ironic01:42
openstackgerritlifeless proposed a change to openstack/ironic: Provide a new ComputeManager for Ironic  https://review.openstack.org/8263701:44
*** yonglihe_ has quit IRC01:56
*** yonglihe_ has joined #openstack-ironic01:59
*** rloo has quit IRC02:26
*** rloo has joined #openstack-ironic02:27
*** rloo has quit IRC02:28
*** rloo has joined #openstack-ironic02:29
lifelessdtantsur: I've seen HTTPInternalServerError' object has no attribute '__name__ now02:43
*** rloo has quit IRC02:51
openstackgerritDavid Shrewsbury proposed a change to openstack/ironic: Fix missed exception raise in _add_driver_fields  https://review.openstack.org/8270102:57
openstackgerritlifeless proposed a change to openstack/ironic: Provide a new ComputeManager for Ironic  https://review.openstack.org/8263703:00
*** matsuhashi has quit IRC03:12
*** nosnos has quit IRC03:29
*** matsuhashi has joined #openstack-ironic03:30
*** vkozhukalov has joined #openstack-ironic03:35
*** matsuhashi has quit IRC03:36
*** harlowja_ is now known as harlowja_away03:49
*** killer_prince is now known as lazy_prince04:06
*** matsuhashi has joined #openstack-ironic04:23
*** nosnos has joined #openstack-ironic04:25
*** lazy_prince2 has joined #openstack-ironic04:41
*** lazy_prince2 is now known as killer_prince04:41
*** rameshg87 has joined #openstack-ironic04:47
*** eghobo has joined #openstack-ironic05:01
*** tzumainn has quit IRC05:03
*** vkozhukalov has quit IRC05:05
*** matsuhashi has quit IRC05:14
*** vkozhukalov has joined #openstack-ironic05:15
*** matsuhashi has joined #openstack-ironic05:18
*** Manishanker has joined #openstack-ironic05:26
*** rameshg87 has quit IRC05:28
*** vkozhukalov has quit IRC05:39
*** pradipta_away is now known as pradipta06:00
*** mrda is now known as mrda_away06:08
openstackgerritJenkins proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/8272006:09
*** eghobo has quit IRC06:46
*** lsmola_ has quit IRC07:02
*** lsmola_ has joined #openstack-ironic07:03
*** vkozhukalov has joined #openstack-ironic07:03
*** eghobo has joined #openstack-ironic07:05
vkozhukalovmorning, all07:06
*** rameshg87 has joined #openstack-ironic07:08
*** romcheg has joined #openstack-ironic07:13
*** romcheg has quit IRC07:15
*** romcheg has joined #openstack-ironic07:17
*** saju_m has joined #openstack-ironic07:30
*** romcheg has quit IRC07:41
*** max_lobur has joined #openstack-ironic07:42
*** romcheg has joined #openstack-ironic07:44
*** ifarkas has joined #openstack-ironic07:48
*** eghobo has quit IRC07:54
*** romcheg has quit IRC07:57
*** killer_prince has quit IRC08:30
dtantsurMorning Ironic08:36
*** killer_prince has joined #openstack-ironic08:37
vkozhukalovdtantsur: morning08:40
openstackgerritYuriy Zveryanskyy proposed a change to openstack/ironic: Remove logging of exceptions from controller's methods  https://review.openstack.org/8126708:47
*** matsuhashi has quit IRC08:49
*** jistr has joined #openstack-ironic08:49
*** saju_m has quit IRC08:50
*** athomas has joined #openstack-ironic08:50
*** saju_m has joined #openstack-ironic08:52
*** jistr is now known as jistr|training08:54
openstackgerritYuriy Zveryanskyy proposed a change to openstack/ironic: Decrease running time of SeaMicro driver tests  https://review.openstack.org/8176308:55
*** matsuhashi has joined #openstack-ironic08:56
*** matsuhashi has quit IRC09:14
*** derekh has joined #openstack-ironic09:15
*** lucas-dinner is now known as lucasagomes09:17
*** matsuhashi has joined #openstack-ironic09:18
openstackgerritYuriy Zveryanskyy proposed a change to openstack/ironic: Update Neutron if mac address of the port changed  https://review.openstack.org/7793909:21
*** pradipta is now known as pradipta_away09:24
*** pradipta_away is now known as pradipta09:24
*** tzumainn has joined #openstack-ironic09:30
dtantsuragordeev, hi! After "Remove any lib/baremetal usage for ironic deploy" do we need to update localrc, i.e. BM_BUILD_DEPLOY_RAMDISK=True and BM_DEPLOY_FLAVOR=...?09:32
*** saju_m has quit IRC09:38
*** nosnos has quit IRC09:39
*** killer_prince has quit IRC09:49
agordeevdtantsur: hi, only if you need non-default setting. Otherwise there's no reason for updating them.09:55
*** tatyana has joined #openstack-ironic09:55
dtantsuragordeev, well, currently I have them as stated here: http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html (except for s/ubuntu/fedora/)09:55
*** saju_m has joined #openstack-ironic09:56
*** max_lobur has quit IRC10:00
agordeevdtantsur: there's no need of explisit IRONIC_VM_SPECS_RAM=512 (since it's default value). BM_BUILD_DEPLOY_RAMDISK, BM_DEPLOY_FLAVOR were renamed to IRONIC_BUILD_DEPLOY_RAMDISK (defaults to True) and IRONIC_DEPLOY_FLAVOR (defaults to "ubuntu deploy-ironic") respectively.10:01
dtantsuragordeev, thanks. I think quickstart should be updated as well..10:02
agordeevdtantsur: also, "-a amd64" is the default value too, so it was ommited as well10:02
dtantsuragordeev, what about IRONIC_VM_SPECS_DISK=10 ?10:03
agordeevdtantsur: yup, at least it should reference to actual environment variable, not old BM_*10:04
agordeevdtantsur: yeah, it defaults to 1010:05
*** matsuhashi has quit IRC10:08
*** matsuhashi has joined #openstack-ironic10:10
*** killer_prince has joined #openstack-ironic10:18
*** killer_prince has quit IRC10:29
*** pradipta is now known as pradipta_away10:32
*** athomas has quit IRC10:36
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Supports filtering port by address  https://review.openstack.org/8277310:42
*** romcheg has joined #openstack-ironic10:44
*** romcheg has left #openstack-ironic10:50
*** killer_prince has joined #openstack-ironic10:50
*** max_lobur has joined #openstack-ironic10:52
*** max_lobur1 has joined #openstack-ironic10:53
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Replace fixtures with mock in test_keystone.py  https://review.openstack.org/7970210:57
*** max_lobur has quit IRC10:57
*** saju_m has quit IRC11:07
*** saju_m has joined #openstack-ironic11:08
*** saju_m has quit IRC11:09
*** saju_m has joined #openstack-ironic11:15
*** athomas has joined #openstack-ironic11:22
*** athomas_ has joined #openstack-ironic11:26
*** athomas has quit IRC11:29
*** rameshg87 has left #openstack-ironic11:36
*** saju_m has quit IRC11:38
*** saju_m has joined #openstack-ironic11:38
*** jistr|training has quit IRC11:40
*** athomas has joined #openstack-ironic11:40
*** athomas_ has quit IRC11:41
*** jistr has joined #openstack-ironic11:41
*** jistr is now known as jistr|training11:41
*** ifarkas has quit IRC11:43
*** ifarkas_ has joined #openstack-ironic11:48
*** ifarkas_ has quit IRC11:50
*** ifarkas has joined #openstack-ironic11:51
*** harlowja_away has quit IRC12:03
*** matsuhashi has quit IRC12:16
*** linggao has joined #openstack-ironic12:20
*** matsuhashi has joined #openstack-ironic12:23
*** romcheg has joined #openstack-ironic12:30
*** zul has quit IRC12:38
*** zul has joined #openstack-ironic12:41
*** saju_m has quit IRC12:41
*** rloo has joined #openstack-ironic12:50
*** lucasagomes is now known as lucas-hungry12:51
*** saju_m has joined #openstack-ironic12:55
*** saju_m has quit IRC12:59
*** saju_m has joined #openstack-ironic13:00
*** matsuhashi has quit IRC13:03
*** saju_m has quit IRC13:04
*** saju_m has joined #openstack-ironic13:05
*** jbjohnso_ has joined #openstack-ironic13:05
*** saju_m has quit IRC13:09
*** saju_m has joined #openstack-ironic13:10
*** todd_dsm has joined #openstack-ironic13:20
*** ChanServ changes topic to "the gerrit event stream is currently hung, blocking all testing. troubleshooting is in progress (next update at 14:00 utc)"13:21
*** lazy_prince has quit IRC13:22
*** lazy_prince has joined #openstack-ironic13:23
*** matty_dubs|gone is now known as matty_dubs13:24
*** ChanServ changes topic to "OpenStack Bare Metal Provisioning | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic | Status: https://etherpad.openstack.org/p/IronicWhiteBoard"13:29
*** lucas-hungry is now known as lucasagomes13:33
*** killer_prince has quit IRC13:35
*** lazy_prince is now known as killer_prince13:35
NobodyCamgood morning Ironic13:58
agordeevNobodyCam: good morning!13:59
mdurnosvistovGood morning/afternoon NobodyCam and all! :)14:00
lucasagomesmorning all :)14:01
lucasagomesNobodyCam, http://lists.openstack.org/pipermail/openstack-dev/2014-March/030964.html14:01
NobodyCammorning agordeev mdurnosvistov lucasagomes14:03
*** jbjohnso_ has quit IRC14:05
NobodyCambrb morning walkies14:06
yuriyzmorning all14:09
lucasagomesmorning yuriyz14:10
NobodyCammorning yuriyz14:10
dtantsurHi Ironic. Getting to yesterdays problems: has anyone tried devstack + ironic patch on IPv6-enabled box (ubuntu, fedora, whatever)?14:16
dtantsurI'm trying to figure out the scope of problems I'm getting14:16
*** jbjohnso_ has joined #openstack-ironic14:20
jrollmorning all :)14:23
NobodyCammorning jroll14:24
NobodyCamdtantsur: I have been running dib built images which i beleieve have not turned off ip v6, but need to dbl chck that14:25
jrollthis looks like a "recheck no bug" to me, yeah? https://review.openstack.org/#/c/82680/14:27
jrolldown to only 8 rc1 bugs left :)14:32
romchegMorning NobodyCam, lucasagomes14:32
lucasagomesmorning romcheg  :)14:33
romchegand jroll14:33
NobodyCammorning romcheg14:33
jrollhey romcheg14:33
NobodyCamjroll: awesome14:33
romchegThe review session is planned to 3PM GMT isn't it?14:33
NobodyCam8:00 pst...14:33
NobodyCami think thats 1500 gmt14:34
jrollyep14:34
romchegtime zones are pain in the ass...14:34
NobodyCamromcheg: http://www.worldtimebuddy.com14:35
*** todd_dsm has quit IRC14:37
ShrewsNobodyCam: ooh, i like that14:37
*** todd_dsm has joined #openstack-ironic14:37
romchegwow, cool14:37
NobodyCamShrews: lol its the only way I can keep the time zone straght with the daylight saving always moving around14:38
NobodyCam:-p14:38
NobodyCamopen floor question: would it be bad to hyjack the horizon apache server for ipxe use? could it done, or nor even worth looking in to?14:40
*** todd_dsm has quit IRC14:40
romchegNobodyCam: i oppose that14:40
romchegA lot of big customers as I know do not use horizon14:41
romchegThey use their own web UI14:41
jrollvkozhukalov / agordeev : did you two see my wiki page updates? https://wiki.openstack.org/wiki/Ironic-python-agent14:41
jrollNobodyCam: -1 on that also. I would almost rather just document "set up an http server for ipxe use"14:42
jrolland if needed "image needs to be at $SOME_PATH"14:42
NobodyCamok... thats why I asked :)14:42
romchegEven is there's no custom ui that replaces horizon, sticking to it is not the best way to go14:43
NobodyCamhow would we get a image on to the http server?14:43
NobodyCamI agree it would have been a total hack14:43
jrollNobodyCam: our current method is wget from the build machine :P14:43
NobodyCamya so the conductor will require a http server to for ipxe?14:44
NobodyCamwe pull the image from glance14:45
romchegMaybe torrent tracker?14:45
NobodyCamif the http server is not on the conductor how will the image get to a location it can be served from14:45
NobodyCamthe conductor gets the image id to pull from glance14:46
devanandamorning, all14:46
NobodyCamgood morning devananda :)14:46
jrollmorning devananda14:46
romchegMorning devananda!14:46
romchegNobodyCam: there are two ways: we can either push the image to the web server (over scp for instance)14:47
jrollNobodyCam: in our environment, we just have our DHCP server also running apache, serving the agent image14:47
romchegNobodyCam: or we can give that node a command to put it on it's own14:48
jrollis the deploy ramdisk that ironic currently uses static?14:48
devanandajroll: yes14:48
jrollright - so it doesn't necessarily need to be served from glance14:48
devanandajroll: it's configurable per-node. but in practice, it's static14:48
jrollI understand that's optimal, but a standalone apache server would scale better than "download image to conductor and serve from there"14:49
devanandajroll: the image is cached and symlinked on conductor(s)14:49
devanandajroll: and it's very small today (~30MB) so it is almost guaranteed to be served from FS cache14:49
agordeevjroll: yup. Well done, great job on the wiki updates!14:49
devanandajroll: from a machine in some reasonable proximity to the node requesting it (rather than a potentially distant centralized apache service)14:50
NobodyCamdevananda: I started this as I was asked about ipxe serving images over http14:50
devanandajroll: and for concurrent deploys, it will scale as much as the conductors do. no need to scale something else (apache) too14:50
devanandaNobodyCam: never admit when you started it :p14:51
jrolldevananda: fair14:52
jrollagordeev: :)14:52
devanandajroll: i'm fairly resistant to add an external operational requirement to ironic when there isn't a really compeling reason to do so14:52
lucasagomesmorning devananda14:52
NobodyCamlol14:52
jrolldevananda: I know :)14:53
jrolljust making a suggestion based on what we're doing today for the much larger agent image14:53
devanandajroll: *nod*14:54
devanandajroll: fwiw, chaining to ipxe and pulling the larger image over HTTP(S) seems totally reasonable to me14:54
JoshNangmorning everyone!14:54
NobodyCammorning JoshNang14:55
*** Manishanker has left #openstack-ironic14:55
Shrewsyuriyz: vote changed! thanks for the explanation  :)14:55
*** jbjohnso_ has quit IRC14:57
devanandaI have several emails I should respond to ... and i'm still working on first cup'o'coffee...14:58
Shrewsdevananda: coffee has higher priority14:59
devanandalucasagomes: romcheg: max_lobur1: ya'll up for starting soon?14:59
NobodyCamI have to run to doctors this morning ... so I will miss the jam session14:59
romchegdevananda: +114:59
NobodyCamI will be back around 10 ish14:59
lucasagomesdevananda, yup15:00
jrollI'm ready whenever, currently mucking around with sound cards in debian :|15:00
devanandajroll: PM me your google hangout info15:01
JoshNangdevananda: can I join in as well?15:01
jrolloh, hangouts15:01
* jroll gets his laptop15:01
russell_hmorning15:02
devanandajroll: or not, up to you15:02
jrollnah, that's fine15:02
jrollmorning russell_h15:03
lucasagomesyeah, so if we start serving larger images via http (e.g ramdisk agent) we would need the http server, but idk if Ironic should do something about it, like starting/stopping the http server sounds like somehting out of our plate15:03
devanandahttps://plus.google.com/hangouts/_/7ecpiv2qebg86vb37ils8gcrb815:04
devanandahttps://etherpad.openstack.org/p/IronicReviewDay   <-- Scratch Pad15:05
*** jbjohnso_ has joined #openstack-ironic15:10
openstackgerritYuriy Zveryanskyy proposed a change to openstack/ironic: Update Neutron if mac address of the port changed  https://review.openstack.org/7793915:11
*** saju_m has quit IRC15:13
jrollShrews: are you working on https://bugs.launchpad.net/ironic/+bug/1295870 ?15:13
Shrewsjroll: i am15:14
jrollcool15:14
devanandahttps://review.openstack.org/#/c/80400/  vs  https://review.openstack.org/8266815:15
pquernalucasagomes: re: http server, we've been playing with using swift direct URLs w/ the temp sign key so they don't need additional auth;  keeps ironic out of the http server business.15:16
lucasagomespquerna, heh ack! thanks15:17
pquernaand as a bonus its a decent place to store 300mb images :x15:17
pquerna(and yeah, as devananda mentioned, we chain iPXE first, then have http)15:18
devanandaso this bug does not seem to have any progress15:20
devanandahttps://bugs.launchpad.net/ironic/+bug/129142015:20
devanandaanyone know the scheduler and want to take it?15:21
devanandaright, i'll toss a patch up in a minute15:22
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Run ipmi power status less aggressively  https://review.openstack.org/8266815:34
*** krtaylor has quit IRC15:42
mdurnosvistovdevananda: I can try to deal with this bug https://bugs.launchpad.net/ironic/+bug/129142015:42
rloodevananda: wrt https://review.openstack.org/#/c/82668/. don't know if you saw or not, but yuriy had a comment.15:43
devanandamdurnosvistov: I just replied on the bug -- if you want to work on it, great!15:45
devanandaI thought it would be simpler than it actually will be15:45
*** krtaylor has joined #openstack-ironic15:50
mdurnosvistovdevananda: If I have any questions  I ask you or someone else :)15:50
*** eghobo has joined #openstack-ironic15:52
*** eghobo has quit IRC15:52
*** eghobo has joined #openstack-ironic15:53
*** romcheg1 has joined #openstack-ironic15:57
*** killer_prince is now known as lazy_prince15:57
*** romcheg has quit IRC15:59
*** matty_dubs is now known as matty_dubs|lunch16:02
devanandaadam_g: around?16:04
notqwe're going to be working on deploying an openstack ironic cloud, going to start with deploying it with devstack to become more familiar with it. seems like a good place to start16:05
devanandanotq: ++16:05
notqi have some emails and cordination to do with monty taylor16:05
devanandanotq: see PM16:05
*** hemna_ has joined #openstack-ironic16:10
*** max_lobur1 has quit IRC16:11
devanandanotq: monty == mordred16:12
notqthanks16:13
devanandanotq: also https://etherpad.openstack.org/p/IronicAndDevstackAgain is our current walkthrough for using devstack16:13
notqgreat, i went to a similar link ot that and it was empty, i'll chcek that one16:13
devanandanotq: and lots of info here - http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack16:13
mordredwhat did I do?16:13
*** ifarkas has quit IRC16:22
*** vkozhukalov has quit IRC16:23
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Set good defaults for heartbeat interval & timeout  https://review.openstack.org/8261516:23
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Run ipmi power status less aggressively  https://review.openstack.org/8266816:40
openstackgerritJim Rollenhagen proposed a change to openstack/ironic: Avoid API root controller dependency on v1 dir  https://review.openstack.org/7891216:41
jrollg/b 6316:42
jrolloops16:42
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Run ipmi power status less aggressively  https://review.openstack.org/8266816:46
devanandahttps://review.openstack.org/#/c/81524 -- jroll, Shrews: either of you test that this actually loads those opts from the CONF file now?16:56
*** jistr|training has quit IRC16:58
rloodevananda: ^^ wrt 81524, i tested it.17:00
*** matty_dubs|lunch is now known as matty_dubs17:02
*** ifarkas has joined #openstack-ironic17:03
*** harlowja has joined #openstack-ironic17:03
*** romcheg has joined #openstack-ironic17:05
Shrewsdevananda: yes, though the periodic timer confuses me a bit, but that's my issue17:07
russell_hShrews: I think JayF has better fix for this that he's working on right now17:07
*** romcheg1 has quit IRC17:08
*** romcheg has quit IRC17:10
openstackgerritJay Faulkner proposed a change to openstack/ironic: Run periodic_task in a with a dynamic timer  https://review.openstack.org/8261517:10
JayFdevananda: https://review.openstack.org/82615 is the new fix to that heartbeat_timeout bug. I found the root cause of the bug, and it was in ironic common instead of oslo. See what you think.17:11
JayFJoshNang: ^ also relevant17:11
devanandaJayF: nice17:13
devanandaJayF: i'm looking at syncing the periodic_task.py code from oslo-incubator right now17:13
JayFYeah this is actually a really nasty bug, I'm kinda surprised it hasn't broken anyone's deployments. There's no way it would work reliably with that bug + the default configuration17:14
JayFthe intermittant failure that was documented for tests would almost certainly happen in a production environment occassionally as well, especially in periods of high load17:14
jrollJayF: it didn't break anyone's prod environment because nobody has a prod environment :)17:15
JayF/yet/.17:16
jrollright17:16
jrollI'm not saying it would not have broken it17:16
devanandayea, i think it would have definitely broken in prod17:16
devanandalooking at syncing olso-incubator periodic_task.py, but it's changed more than I want to sync right now17:17
devanandaand it sounds like with JayF 's fix, it's not needed to sync to fix that bug now17:17
*** ifarkas_ has joined #openstack-ironic17:20
openstackgerritA change was merged to openstack/ironic: Update Neutron if mac address of the port changed  https://review.openstack.org/7793917:25
*** dwalleck has joined #openstack-ironic17:35
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Run ipmi power status less aggressively  https://review.openstack.org/8266817:37
openstackgerritA change was merged to openstack/ironic: Updated from global requirements  https://review.openstack.org/7933417:45
*** epim has joined #openstack-ironic17:48
*** athomas has quit IRC17:49
*** tzumainn has quit IRC17:52
devanandalucasagomes: quick one for you: https://review.openstack.org/#/c/81763/17:53
lucasagomesdevananda, will take a look17:53
lucasagomesdevananda, btw17:53
jbjohnso_devananda, fyi, I'm currently cleaning up my console server for apache2 release17:53
adam_gdevananda, hey17:54
jbjohnso_well, publishing as apache2, it's still under development (needs a few corners addressed)17:55
*** derekh has quit IRC17:55
lucasagomesjbjohnso_, https://review.openstack.org/#/c/82146/17:56
jbjohnso_lucasagomes, hmm, need to look at that on pyghmi side..17:57
lucasagomesjbjohnso_, looks like a bug in pyghmi right?17:57
lucasagomesjbjohnso_, btw, forgot to show u: $yum search pyghmi... python-pyghmi.noarch : Python General Hardware Management Initiative (IPMI and others) :)17:58
jbjohnso_lucasagomes, so interesting, the root issue there is that HMAC17:58
openstackgerritA change was merged to openstack/ironic: Fix 'spacing' parameters for periodic tasks  https://review.openstack.org/8152417:59
jbjohnso_so pycrypto hmac is passed that value directly..17:59
jbjohnso_currently pyghmi does not process it..17:59
openstackgerritGhe Rivero proposed a change to openstack/ironic: Update SeaMicro to use MixinVendorInterface  https://review.openstack.org/7990318:00
lucasagomesjbjohnso_, right /me go look into the code18:00
jbjohnso_looking up the HMAC documentation18:00
jbjohnso_key (byte string)18:02
jbjohnso_so pycrypto is explicit that it should be a byte array...18:02
*** eguz has joined #openstack-ironic18:02
jbjohnso_hmm.. this is non trivial to address in a perfect way...18:05
lucasagomesjbjohnso_, ah eww18:05
jbjohnso_I'd not want the limitation tehy have, for example, where only ASCII is allowed...18:05
lucasagomes+118:05
lucasagomesthings will get yet more hairy with py318:05
lucasagomeswhere the default is unicode18:05
*** eghobo has quit IRC18:05
jbjohnso_actually, less perhaps18:06
jbjohnso_with py2, unicode strings are like aliens18:06
lucasagomesheh18:07
devanandaJayF: hi! Im' looking at https://review.openstack.org/#/c/82615/5/ironic/common/service.py18:07
jbjohnso_I have to ponder....18:07
devanandaJayF: it seems to me we dont need to change default periodic_interval at all18:07
devanandaJayF: using a dynamic timer (good catch!) it's actually doing what it should -- sleeping only until the next timer needs t orun,r ather than 60sec18:08
JayFdevananda: I believe we do, because otherwise the first run of a heartbeat will have to wait 60s before the timer is updated18:08
devanandanope18:08
JayFdevananda: i.e. tick just occurred, 59s left in the timer before next run, heartbeat is registered, it'll have to wait 59s before run_periodic_task is run again, and when that's run again, the next interval will be 10s18:09
devanandaJayF: so, i rebased on master. antoher patch addressed a similar issue. try it18:09
JayFdevananda: then what triggers the initial run_periodic_Task?18:09
devanandano, it's settign the timer to min(periodic_interval, time-to-next-job)18:09
devanandawhen I start the service, I see this:18:09
devananda2014-03-25 11:08:40.472 8468 DEBUG ironic.openstack.common.loopingcall [-] Dynamic looping call sleeping for 14.77 seconds _inner /opt/source/ironic/ironic/openstack/common/loopingcall.py:13218:09
devanandaso, i've set 474 heartbeat_interval=1518:10
devanandain my config file18:10
JayFhmm18:10
JayFare all the periodic tasks being registered before the periodic_task runs then?18:10
*** vkozhukalov has joined #openstack-ironic18:10
JayFer, before run_periodic_task is called18:10
devanandaand since 93b042c0be landed, it's honoured now18:10
devanandaJayF: i think they are _now_ :(18:11
devananda* :)18:11
devanandaJayF: your patch was probably correct prior to 93b042c0be landing18:11
jbjohnso_so unicode to byte array.. picking an encoding...18:11
JayFI can't find 93b042c0be?18:11
jbjohnso_perhaps if it is unicode, I'll just do UTF-818:12
devanandaJayF: https://review.openstack.org/#/c/81524/18:12
devanandamerged 13 min ago18:12
devanandahehe18:12
lucasagomesjbjohnso_, can't u use hmac from python lib?18:12
devanandaJayF: if I set periodic_interval really low, like 1s, it's unnecessarily chatty -- but it works. so I think we can safely leave teh default periodic_interval at 60s, and if someone chooses to set any periodic task's config'd interval less than that, it works now18:13
JayFOkay, I did see that was posted for review but don't understand how it related?18:13
devanandait changed the order in which options are loaded for the periodic_task decorators18:13
devanandaCONF is read before those modules are imported now, so they are created with the right values18:14
jbjohnso_lucasagomes, let me see why... I might have needed pycrpto for the crypt, but maybe hmac is different18:14
lucasagomesjbjohnso_, ack18:14
JayFdevananda: so the periodic_tasks are all configured and loaded /before/ the first run_periodic_task after that patch?18:14
JoshNangjbjohnso_: unrelated to the current discussion, but is it possible to drop the username/password requirement in pyghmi? it doesn't seem to be a strict requirement in the cli ipmitool18:14
jbjohnso_JoshNang, guess I could default the value to blank strings...18:15
devanandaJayF: afaict, yes18:16
JayFdevananda: okay cool, me and russell_h were talking about how to make that work and didn't have an answer. So nice that someone fixed up the other half. I'll remove the default change and the warning in the help right now18:17
JoshNangjbjohnso_: i think it is possible that some devices may not have a password initially18:17
devanandaJayF: ty18:17
jbjohnso_JoshNang, well at a low level, the value if not supplied is a byte string of zero length18:17
russell_hdevananda: wait, are you running JayF's patch when that log message is generated, or how are you getting a DynamicLoopingCall?18:17
jbjohnso_JoshNang, for network at least, KCS is a different beast18:18
jbjohnso_but I have nothing to really recommend pyghmi for over ipmitool or ipmicmd in the KCS case...18:18
devanandarussell_h: yes. I rebased his patch on current master18:18
russell_hah, gotcha, +118:18
JoshNangjbjohnso_: interesting. makes sense for the low level.18:18
openstackgerritJay Faulkner proposed a change to openstack/ironic: Run periodic_task in a with a dynamic timer  https://review.openstack.org/8261518:19
jbjohnso_lucasagomes, looks like I might be able to convert to hmac built in, but still need PyCrypto Cipher at the moment.. but no user/pass data goes direct into Cipher anyhow18:20
JayFdevananda: ^ there's the update, should be g2g18:20
lucasagomesjbjohnso_, nice! do you want me to open a bug for that?18:20
lucasagomesI think it's nice to keep track of the problem18:20
jbjohnso_lucasagomes, of course, I don't know if it will fix anything mind you18:20
lucasagomesjbjohnso_, ack18:20
jbjohnso_lucasagomes, let me try a unicode string in there real quick18:20
lucasagomesack18:21
jbjohnso_lucasagomes, python's built in hmac is no happier with unicode strings18:22
lucasagomes:(18:22
jbjohnso_lucasagomes, and you are right, it gets more fun in python 318:23
jbjohnso_>>> hmac.new('bob')18:23
jbjohnso_that fails in python 318:23
lucasagomeshah18:23
lucasagomesyeah because the default str type is unicode in py318:23
jbjohnso_>>> hmac.new(b'bob')18:24
jbjohnso_of course is all happy18:24
lucasagomesjbjohnso_, maybe we should make pyghmi more friendly and try to convert it to byte string18:24
lucasagomesand raise an exception if that fails18:24
lucasagomesother than ask for the user to convert it18:24
rlooJayF: wrt 82615, deva had a comment about not changing the doc string (I think he means the help=)18:25
*** shakamunyi has joined #openstack-ironic18:25
*** shakamunyi has quit IRC18:25
*** shakamunyi has joined #openstack-ironic18:26
*** shakamunyi has quit IRC18:26
NobodyCamdid I miss all the fun?18:26
rlooNobodyCam. Yawn. No :-)18:26
NobodyCamahh :-p18:26
NobodyCammorning rloo18:26
jbjohnso_NobodyCam, so I'll do... password.encode('utf-8')18:26
jbjohnso_unless byte string already..18:27
rlooNobodyCam: should almost be bagel time for you ;)18:27
NobodyCamlol almost... just got back from doctors :-p18:27
jbjohnso_lucasagomes, I meant18:27
lucasagomesjbjohnso_, right, sounds good to me :) thanks18:27
NobodyCammorning jbjohnso_ :)18:28
jbjohnso_NobodyCam, morning18:28
jbjohnso_lucasagomes, cool, works on python 2.618:29
lucasagomesjbjohnso_, :D awesome18:29
lucasagomesjbjohnso_, I don't know if u use six, but if you do u can also convert with six.binary_type()18:30
devanandarloo: correct. JayF -- I'd prefer you not change the doc / help string there18:31
jbjohnso_lucasagomes, yeah, actually, the only problem I can find is that bytearray didn't have it, so I'll just catch the attributeerror18:31
lucasagomesjbjohnso_, right18:32
rloodevananda: is that cuz of getting the strings translated?18:34
openstackgerritA change was merged to openstack/ironic: Fix missed exception raise in _add_driver_fields  https://review.openstack.org/8270118:34
devanandarloo: in principle, yes18:34
openstackgerritJarrod Johnson proposed a change to stackforge/pyghmi: Tolerate unicode strings as username and password  https://review.openstack.org/8289218:35
jbjohnso_lucasagomes, ^^18:35
jbjohnso_now to actually test it myself18:35
*** ifarkas_ has quit IRC18:35
lucasagomesjbjohnso_, great!18:36
lucasagomesthanks for that18:36
devanandarloo: https://www.transifex.com/projects/p/ironic/18:36
jbjohnso_lucasagomes, seems to work, could you have the submitter of the other patch try out the change to see if it makes that change superfluous?18:37
openstackgerritA change was merged to openstack/ironic: Decrease running time of SeaMicro driver tests  https://review.openstack.org/8176318:37
devanandarloo: as you can see, several languages actually have partial translations already. let's not make their jobs harder :)18:37
devanandaJayF: ^18:37
lucasagomesjbjohnso_, sure will ask him to give it another go with the fix in place18:37
devanandaJayF: going to do another iteration of your patch, or shall I? other than help=, I'm ready to approve it18:38
rloodevananda: cool. thx!18:39
NobodyCambrb18:44
lucasagomesaight! I think I'm done for today18:47
lucasagomeshave a good night everybody18:47
devanandag'night lucasagomes !18:48
*** lucasagomes is now known as lucas-afk18:48
jbjohnso_realizing I'll need to move my launchpad account18:49
jbjohnso_lenovo me will not have that email address18:50
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Run periodic_task in a with a dynamic timer  https://review.openstack.org/8261518:50
devanandajbjohnso_: gmail :)18:50
NobodyCamnight lucas-afk18:50
*** ifarkas_ has joined #openstack-ironic18:53
openstackgerritA change was merged to stackforge/pyghmi: Tolerate unicode strings as username and password  https://review.openstack.org/8289218:55
jbjohnso_devananda, btw, you interested in seeing the web widget for my console server? sadly the only screen sharing solution I am allowed to use is a java one... the console widgets do not require java of course18:55
devanandajbjohnso_: yes - but not today :)18:56
Shrewsdevananda, NobodyCam: any idea why, in the nova ironic driver, HTTPBadRequest is specifically ignored in some instances? One example here: https://github.com/openstack/ironic/blob/master/ironic/nova/virt/ironic/driver.py#L28918:56
*** mdurnosvistov_ has joined #openstack-ironic18:58
*** derekh has joined #openstack-ironic18:59
*** jistr has joined #openstack-ironic18:59
adam_gdevananda, missed your ping earlier this AM, sup?19:00
devanandaadam_g: it looks like neither nova.virt.ironic nor ironic.conductor.manager send any msg to neutron when deploying an instance19:04
devanandaadam_g: i haven't looked deeper yet but wondering if you knew off hand why networking works :)19:04
adam_guhm19:05
adam_g:)19:05
adam_gone sec19:05
devanandaalso, these could use a few more reviews // a core to ++  : https://review.openstack.org/#/c/82680/ and https://review.openstack.org/#/c/82668/ and https://review.openstack.org/#/c/81267/ and https://review.openstack.org/#/c/82615/19:06
*** tatyana has quit IRC19:07
openstackgerritA change was merged to stackforge/pyghmi: Fix missing delay_xmit argument breaking power wait requests  https://review.openstack.org/8256919:07
adam_gdevananda, AIUI, nova is doing the neutron orchestration and just passing the resulting infos via network_info to the driver, which is then patching the ironic port19:07
*** max_lobur has joined #openstack-ironic19:08
JayFdevananda: sorry about that, I intended to revert that docstring too and just missed it19:08
devanandaJayF: np19:09
adam_gdevananda, the pxe driver posts back to neutron to update its dhcp according to port19:09
adam_g(during deploy)19:09
devanandaadam_g: ah right. outside of the driver. so when the MAC changes, in theory, do we need to do more than tell neutron about that?19:10
devanandahopeflly not cause we landed it, heh19:10
adam_gdevananda, hmm19:11
adam_gdevananda, what was landed?19:11
devanandaadam_g: https://review.openstack.org/#/c/77939/19:12
adam_gdevananda, i'm not sure what is required to update an the mac addr of neutron port. i know it / OVS can be pretty strict about what traffic is allowed on a namespace19:13
adam_gdevananda, hmm. i would have thought neutron integration would be at the driver level?19:15
devanandaadam_g: considering that the VIF<->MAC relationship is set up by Nova today (even above nova.virt.ironic) ....19:16
*** dwalleck has quit IRC19:16
devanandaideally this should expose something back to nova, except, nova has no concept of changign the MAC of a VM19:17
devanandaadam_g: there should probably be a driver hook for it19:17
*** openstackgerrit has quit IRC19:18
devanandaShrews: hi! how's 1295870 going?19:18
*** max_lobur has quit IRC19:18
*** openstackgerrit has joined #openstack-ironic19:18
Shrewsdevananda: trying to resolve the various exception handling, thus the previous question19:18
Shrewsdevananda: but I don't even see HTTPBadRequest used *at all* in the ironicclient code, so I'm dismissing that exception's use19:19
Shrewsdevananda: testing will be the most difficult part  :(19:19
adam_gdevananda, i guess i dont fully grok the other driver use cases beyond the pxe_ssh stuff i've been poking at in devstack.  in terms of OVS, it only works because the VMs are booting on a bridge that has already been plugged into the correct namespace/VS/neutron net.  i dont see how neutron DHCP fits into more real world setups where we're booting real metal19:20
devanandaShrews: yea...19:20
devanandaadam_g: k. so there's two integration points for neutron19:21
devanandaShrews: i suspect that exception handling has something to do with: dont fail during _cleanup if someone else already ran it19:21
devanandaShrews: but IMBW19:21
devanandaShrews: copy into nova tree, run nova unit tests? :(19:22
openstackgerritA change was merged to openstack/ironic: Adds max retry limit to sync_power_state task  https://review.openstack.org/7742019:22
devanandaadam_g: 1) nova tells neutron about the node's MAC, associates with tenant network, neutron assigns IP, etc19:22
devanandaadam_g: 2) ironic tells neutron about the DHCP BOOTP options19:22
Shrewsdevananda: that's what I suspected as well, but if that exception is not even thrown...  meh, testing will reveal more hopefully19:22
devanandaadam_g: what we've got here is a third case, which IIRC came from lifeless originally, where the physical NIC has been changed and we need to inform neutron19:23
devanandaadam_g: nova lacks this concept because you dont change the NIC of a VM. so Ironic needed to tell neutron directly19:23
adam_gdevananda, right19:24
devanandaadam_g: but this is unrelated to whether the specific deploy driver uses DHCP BOOTP or not19:24
Shrewsdevananda: what's the cutoff date for I-release bug fixes?19:24
lifelesswhich BTW we had to do about 2 weeks ago to a real server19:24
devanandait should, in theory, trigger neutron's back-end to update that VIF to associate to the new MAC19:24
lifelesswe did it by DB surgery19:24
devanandalifeless: so the fix for that landed but we haven't really tested it ...19:25
lifelessI believe SpamapS will confirm (he did it) Was Not Fun19:25
devanandaShrews: RC is as-soon-as-i-say-go, basically19:25
devanandaShrews: but we can wait another week or two if really needed19:25
devanandaShrews: or we can back-port things19:25
*** zul has quit IRC19:26
adam_gi guess i need to be schooled on some more fundamental questions unrelated to the new feature, about DHCP BOOTP + PXE + neutron19:27
devanandaShrews: i didn't really answer your question. I'm aiming for RC1 by friday, at which point we'll open development for Juno. we can do back-ports until the actual release is cut a few weeks later.19:27
devanandalifeless: i saw your msg from ~2am that "it worked". we just landed a bunch of bug fixes today, and another 6 or so are still in flight19:28
adam_gShrews, i think the client needs an exception to handle that, which can be caught by the driver. see note @ http://git.openstack.org/cgit/openstack/ironic/tree/ironic/nova/virt/ironic/driver.py#n498   i was hitting a traceback /w a HTTPBadRequest from neutron API19:28
devanandalifeless: i'm seeing all the tripleo-ci stuff green on the patches, so i'm assuming taht means these fixes aren't breakign tripleo :)19:29
Shrewsdevananda: ok, that's what i wanted to know. this is turning out to be a significant enough change that friday may be rushing it19:29
devanandaShrews: that's what I suspected19:29
lifelessdevananda: ironic isn't fully tested in tripleo yet19:29
adam_gShrews, https://bugs.launchpad.net/ironic/+bug/129706319:29
lifelessdevananda: until we've landed the tie, tht, t-i patches and the ClusterComputeManager in ironic19:30
devanandaShrews: can you subdivide it meaningfully?19:30
lifelessdevananda: after *that* you'll get useful results from toci.19:30
*** zul has joined #openstack-ironic19:30
devanandalifeless: think we can do that today? :)19:30
lifelessask in the meeting in open chat19:30
devanandak19:30
Shrewsadam_g: i think you're referencing a different thing than me19:31
Shrewsdevananda: maybe. let me ponder over it19:32
lifelessShrews: got my slive battery this morning19:33
lifelessShrews: will run unplugged and drain them both to get a baseline today19:34
Shrewslifeless: awesome. please let me know how that works19:34
*** sphoorti has joined #openstack-ironic19:39
*** sphoorti has left #openstack-ironic19:40
Shrewsdevananda: So, one thing we can do is just cherry pick a few methods of IronicDriver to use the new code, and everything else remains the same. Then we can just test the crap out of those couple of code paths rather than the entire driver.19:46
ShrewsIt will be a mixed style, but slower integration may be prudent here.19:46
openstackgerritA change was merged to openstack/ironic: Avoid API root controller dependency on v1 dir  https://review.openstack.org/7891219:48
openstackgerritA change was merged to openstack/ironic: Update SeaMicro to use MixinVendorInterface  https://review.openstack.org/7990319:48
openstackgerritA change was merged to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/8272019:48
*** shakayumi has joined #openstack-ironic19:54
*** romcheg has joined #openstack-ironic19:56
*** shakamunyi has joined #openstack-ironic19:56
*** romcheg has left #openstack-ironic19:57
*** shakayumi has quit IRC19:58
jbjohnso_devananda, once I get console working, my next stop fyi was removing any requirement of needing to know mac address in order to pxe boot a node19:59
jbjohnso_devananda, also, support applying static ip config that need not require dhcp to give 'the' address, just 'a' address19:59
devanandajbjohnso_: a "default pxe image" would address that. the RS folks are working on it20:01
devanandajroll: ^20:01
devanandajbjohnso_: again, ditto for not requiring DHCP BOOTP to be updated dynamically. tehre's even a bug alraedy open about it (wishlist'd for the moment)20:02
jbjohnso_devananda, well, I'd be supporting UUID indicated boot parameters with or without cooperation of a dnsmasq or dhcp (unless we are on the same IP)20:03
jbjohnso_if on same IP, it would have to set a static config..20:03
*** shakamunyi has quit IRC20:03
jbjohnso_a static option to say 'let this guy handle it'20:03
jbjohnso_but first, console server20:04
*** derekh has quit IRC20:05
*** jistr has quit IRC20:06
*** shakamunyi has joined #openstack-ironic20:06
*** vkozhukalov has quit IRC20:28
notqran through until a connection error max retries exceeded for nova flavor-create baremetal20:28
NobodyCamnotq: devtest or devstack?20:29
notqdevstack20:30
lifelessjbjohnso_: BTW - lots of environments *really* don't want wildcard DHCP.20:30
lifelessjbjohnso_: its a huge feature for Ironic that it doesn't boot anything that plugs in20:30
lifelessjbjohnso_: so please don't make wildcard the default.20:30
NobodyCamack.. I'm prob more helpful with devtest.. but I can try and help20:30
NobodyCamwhats in n-compute20:31
jbjohnso_lifeless, well, historically for xCAT, we only 'went to town' if a 'discovery pool' was added20:31
lifelessjbjohnso_: sure, not trying to constraint the impl; just saying make it opt in20:31
jbjohnso_lifeless, but in this particular case, I was thinking the setup would default to PXE snooping only20:31
lifelessliterally the first question every DC ops folk who've deployed tripleo have asked me is 'will this break other DHCPing devices'20:31
jbjohnso_lifeless, so if you have a PXE attempt that is not defined, it is snooped, but no response sent20:31
jbjohnso_lifeless, if defined, then a dhcp response is still not sent20:32
jbjohnso_lifeless, anyway, I need to actually implement that, but I need to make console session logging configurable and have it auto-respond to cfg changes before I'm ready20:33
jbjohnso_and actually have it out with some copyright data20:33
linggaoHi devananda, I'd like to try this bug unless you have given it to someone else. https://bugs.launchpad.net/ironic/+bug/127933120:34
notqdoes devstack work where running stack.sh again does a reasonable resume?20:34
notqgoing to try to run the command manually and troubleshoot it20:35
JayFhttps://review.openstack.org/#/c/82680/ only needs one more core review to get tests sped up in Ironic, if someone has a moment or two20:35
adam_gnotq, is nova-api running?20:35
JayFlinggao: btw; that bug that you were inquiring about in the meeting --> https://review.openstack.org/#/c/82615/20:36
JayFlinggao: that's the patchset if you wanted to have a look. It's already got one +220:36
linggaoJayF thanks.20:36
openstackgerritRussell Haering proposed a change to openstack/ironic: Re-use hash rings across requests  https://review.openstack.org/8291520:40
notqi don't see any nova processes20:41
devanandanotq: you should unstack before calling stack a second time20:41
notqdevananda: thanks.20:42
linggaoJayF, good catch on the dynamic timer.20:48
JayFlinggao: ty, russell_h helped with finding it too20:49
openstackgerritlifeless proposed a change to openstack/ironic: Provide a new ComputeManager for Ironic  https://review.openstack.org/8263720:51
NobodyCamJayF: .2 long enough?20:52
*** mrda_away is now known as mrda20:52
notqthis time it says stack.sh completed. so good times.20:53
NobodyCamnotq: :)20:53
linggaodevananda, I'll take a look at bug 1279331. I have assined it to myself.20:54
openstackgerritlifeless proposed a change to openstack/ironic: Provide a new ComputeManager for Ironic  https://review.openstack.org/8263720:54
openstackgerritlifeless proposed a change to openstack/ironic: Provide a new ComputeManager for Ironic  https://review.openstack.org/8263720:55
devanandalinggao: this is going to be a substantial amount of work20:55
linggaooo20:55
linggaoCan you give me some insight?20:56
devanandai'm in meetings at the moment, so will respond sporadically20:56
devanandalinggao: the bug report has a lengty explanation of the involved components20:57
devanandalinggao: it will touch on the hash ring, conductor.manager, and driver code20:57
linggaodevananda, yes. I red it and looks like a periodic task needs to be added.20:58
linggaored/read20:58
devanandayep20:59
linggaodevananda, it looks like there are a lot of things needs to be done for that periodic task.  I need to get myself familiar with those and get your advice before coding.21:07
devanandalinggao: taking on a bug that complex may not be the best way to get familiar with it21:08
*** shakayumi has joined #openstack-ironic21:08
*** shakayumi has quit IRC21:09
linggao:-), I thought fixing bugs is a good way to learn the code.  Well, I will give it back if you are not comfortable with it.21:11
*** shakamunyi has quit IRC21:11
devanandalinggao: fixing bugs is a great way to learn code -- i'm just pointing out that that particular bug might be a bit much to take on at once by yourself21:14
*** max_lobur has joined #openstack-ironic21:14
linggaodevananda, I understand. :)21:14
*** ifarkas has quit IRC21:15
*** ifarkas_ has quit IRC21:16
*** max_lobur has quit IRC21:20
*** Shalmazar has joined #openstack-ironic21:20
NobodyCamRuntimeError: Broken toolchain: cannot link a simple C program21:22
NobodyCami wish it would sa which one!21:23
*** linggao has quit IRC21:23
NobodyCams/sa/say/21:24
*** Madasi has quit IRC21:29
*** Shalmazar is now known as Madasi21:32
*** Madasi is now known as Guest211621:33
*** jbjohnso_ has quit IRC21:33
*** matty_du1s has joined #openstack-ironic21:42
*** matty_dubs has quit IRC21:45
*** notq has quit IRC21:46
*** russellb has quit IRC21:47
*** Guest2116 has quit IRC21:47
*** zigo has quit IRC21:47
*** wendar has quit IRC21:47
*** Shalmazar has joined #openstack-ironic21:47
*** russellb has joined #openstack-ironic21:48
*** notq has joined #openstack-ironic21:49
*** wendar has joined #openstack-ironic21:49
NobodyCamdevananda: do we have any test on the class PeriodicService??21:49
*** zigo has joined #openstack-ironic21:49
devanandapossibly not21:50
devananda?21:50
NobodyCamI not seeing any :-p21:50
NobodyCamvirsh list21:51
NobodyCamww21:51
JayFWith blueprints, when you subscribe, what does it mean when you check 'participation essential'22:02
devanandaJayF: afaik, nothing really22:05
JayFcool then I'm checking it22:05
JayFnever seems like a good idea to be nonessential22:06
JayFexcept on snow days ;)22:06
NobodyCamJayF: spam you until you reply, maybe?22:06
openstackgerritA change was merged to openstack/ironic: Run ipmi power status less aggressively  https://review.openstack.org/8266822:18
NobodyCamdevananda: ^^^ first of the four.. just +a the last one22:20
NobodyCamappears to be afternoon walkies time brb22:24
devanandaawesome, ty22:24
JayFNobodyCam: what about https://review.openstack.org/#/c/82615/ ?22:25
openstackgerritA change was merged to openstack/ironic: Remove logging of exceptions from controller's methods  https://review.openstack.org/8126722:25
NobodyCamJayF: check zuul22:25
*** matty_du1s is now known as matty_dubs|gone22:26
JayFNobodyCam: I meant more that it needed an additional +2/+A... was fishing for a review ;)22:26
*** Shalmazar is now known as Madasi22:27
JayFdevananda: any further bugs I can assist with? I see all the ones from https://launchpad.net/ironic/+milestone/icehouse-rc1 are in progress or assigned to others22:34
devanandaJayF: hm.. take a look through the open bugs list then22:35
devanandaJayF: the rc1 list are the ones i've seen,a nd i try to go through the full list about once a week. another pair of eyes triaging bugs certainly wouldn't hurt22:36
devanandait's quite possible i missed something22:36
NobodyCamJayF: I +a'd it :)22:39
JayFwoo22:41
JayFNobodyCam: why doesn't it show up in gerrit then?22:41
NobodyCamchecks22:42
devanandahttps://review.openstack.org/#/c/82615/ doesn't show a +A22:43
JayFI guess I would've just expected to see your name up in the reviewers with a check22:43
devanandawoot - our review queue is down to a single page again!22:43
devanandai'm almost not sure if that's a good thing, lol22:44
JayFjust wait, once you get the floodgates opened for juno it'll start flowing :)22:44
JayFI know we'll have the agent driver coming in soon22:44
NobodyCamoh my bad... I had it left open because I couldnot believe a change that didn't break a test somewhere22:44
NobodyCami was side tracked looking for tests22:45
JayFNobodyCam: if anything that might be a sign of bad tests :x22:45
JayFor no tests at all22:45
NobodyCamJayF: saddly its the latter22:45
JayFYeah I def. ran all tests locally :) had to make a case-senstive mac partition to do it, haha22:46
NobodyCamyou've got our tests running on mac?22:48
NobodyCamhow you do it22:48
NobodyCami keep running into raise DistributionNotFound(req)  # XXX put more info here22:48
JayFNot /on/ mac directly22:48
JayFbut in a VM with my mac dir mounted via NFS22:49
NobodyCamoh :-p22:49
JayFbut I suspect it's possible on mac22:49
JayFyou just have to make a partition with Case Sensitivity22:49
JayFbecause there are apparently some libraries that differ only by capitalization, so without case senstivity, the imports are fubar'd22:49
NobodyCamok I approved that one22:49
NobodyCam:-p22:49
NobodyCamthought I had22:50
devanandai was about to ask, NobodyCam, how you planned on testing https://review.openstack.org/#/c/82615/7 anyway22:50
devanandaour unit tests shouldn't be testing functionality within an external lib (eg, dynamic_timer)22:50
devanandaI would be inclined to have a functional test (eg in tempest) for it22:51
NobodyCamyea, think they do need to be tested22:51
*** mdurnosvistov_ has quit IRC22:51
devanandaJayF: oh, this one https://bugs.launchpad.net/ironic/+bug/1265587 // https://review.openstack.org/#/c/64711/22:52
devanandaJayF: apparently assigned to me and i dropped the ball on the fix.22:52
JayFSure I'll see if I can pick it up22:53
devanandathanks22:53
* devananda steps away to find food and stretch legs22:53
NobodyCam:)22:58
* NobodyCam remembers to set DIB_REPOLOCATION this time22:59
openstackgerritA change was merged to openstack/ironic: Speed up ironic tests  https://review.openstack.org/8268022:59
*** epim has quit IRC23:01
* JayF watches his tests run gloriously fast on master23:01
JayFjroll++23:01
*** krtaylor has quit IRC23:23
lifelesscomstud: https://review.openstack.org/#/c/82637/ answered you23:24
lifelessdevananda: ^ is one of the now three patches left for direct Ironic support in tripleo-ci23:24
*** jgrimm has quit IRC23:25
devanandaack23:25
devanandalifeless: admittedly i dont quite follow your comment re: db-less scheduler23:26
devanandalifeless: pending comstud's reply, it lgtm23:27
openstackgerritA change was merged to openstack/ironic: Run periodic_task in a with a dynamic timer  https://review.openstack.org/8261523:27
NobodyCamlifeless: is my DIB_REPOREF_ironic=refs/changes/37/82637/9 still valid :)23:29
openstackgerritAdam Gandelman proposed a change to openstack/ironic: Raise unexpected exceptions during destroy()  https://review.openstack.org/8294823:50
*** lucas-afk has quit IRC23:52
NobodyCamahh nice chatch adam_g :)23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!