*** epim has quit IRC | 00:06 | |
*** mdenny has quit IRC | 00:08 | |
*** blamar has quit IRC | 00:10 | |
*** openstackgerrit has quit IRC | 00:24 | |
*** openstackgerrit has joined #openstack-ironic | 00:24 | |
*** ekarlso has quit IRC | 00:25 | |
*** ekarlso has joined #openstack-ironic | 00:25 | |
NobodyCam | brb | 00:39 |
---|---|---|
*** kui has quit IRC | 00:55 | |
*** blamar has joined #openstack-ironic | 01:03 | |
*** hemna is now known as hemnafk | 01:18 | |
Haomeng | morning Ironic:) | 01:39 |
*** kui has joined #openstack-ironic | 01:54 | |
*** kui has quit IRC | 01:55 | |
NobodyCam | mornig Haomeng : | 02:18 |
NobodyCam | :) | 02:19 |
Haomeng | NobodyCam: :) | 02:35 |
Haomeng | NobodyCam: nice Fri evening, and enjoy the weekend:) | 02:41 |
Haomeng | NobodyCam: maybe you are on Th, not Fr, sorry:) | 02:42 |
Haomeng | NobodyCam: :) | 02:42 |
*** hstimer has joined #openstack-ironic | 02:59 | |
hstimer | How ready/unready is ironic at this point? Is it good enough to experiment with? | 03:00 |
Haomeng | hstimer: almostly our functions are impemented, but I think it is not ready to use now, welcome | 03:08 |
Haomeng | hstimer: we have mail list you can check status | 03:09 |
Haomeng | hstimer: let me help you find it | 03:09 |
hstimer | :-) | 03:09 |
hstimer | Is MAAS a competitor to ironic? | 03:09 |
Haomeng | hstimer: maas? tripleo? | 03:11 |
Haomeng | which maas? | 03:11 |
hstimer | Ubuntu MAAS | 03:11 |
Haomeng | hstimer: http://lists.openstack.org/pipermail/openstack-dev/2013-December/022000.html this is our PTL Ironic Project update official mail, fyi | 03:12 |
Haomeng | hstimer: you can get your answer in this mail list | 03:13 |
hstimer | ok, thank you | 03:13 |
Haomeng | hstimer: welcome any time:) | 03:13 |
Haomeng | hstimer: Yes, MAAS is a generic Linux systems auto-deployment tool from bare metal, it is great, but I think ironic/tripleo is using for OpenStack self-deployment | 03:16 |
Haomeng | hstimer: how do you think about | 03:16 |
hstimer | Integration with openstack sounds good, but I don't know enough about MAAS or Ironic. | 03:17 |
Haomeng | hstimer: http://www.openstack.org/summit/openstack-summit-hong-kong-2013/session-videos/presentation/an-evaluation-of-openstack-deployment-frameworks | 03:17 |
Haomeng | hstimer: An OpenStack Summit Presentations - "An Evaluation of OpenStack Deployment Frameworks" | 03:18 |
hstimer | thank you, I'll take a look. | 03:18 |
Haomeng | hstimer: Ironic/Tripleo is special for OpenStack systems | 03:18 |
Haomeng | hstimer: ubuntu maas should be generic tool | 03:18 |
Haomeng | hstimer: this is my understanding:) | 03:18 |
hstimer | that is about as much as I know too | 03:19 |
Haomeng | hstimer: :) | 03:22 |
*** rloo has quit IRC | 03:33 | |
*** dguitarbite has joined #openstack-ironic | 03:35 | |
*** jcooley_ has joined #openstack-ironic | 04:17 | |
*** dguitarbite has left #openstack-ironic | 04:59 | |
*** urulama has joined #openstack-ironic | 05:03 | |
*** jcooley_ has quit IRC | 05:06 | |
*** jcooley_ has joined #openstack-ironic | 05:15 | |
*** vkozhukalov has joined #openstack-ironic | 05:30 | |
*** prekarat has joined #openstack-ironic | 05:53 | |
*** jcooley_ has quit IRC | 05:54 | |
*** jcooley_ has joined #openstack-ironic | 05:54 | |
*** jcooley_ has quit IRC | 05:59 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/61920 | 06:02 |
*** jcooley_ has joined #openstack-ironic | 06:02 | |
*** jcooley_ has quit IRC | 06:04 | |
*** jcooley_ has joined #openstack-ironic | 06:04 | |
*** jcooley_ has quit IRC | 06:19 | |
*** vkozhukalov has quit IRC | 06:21 | |
*** marty_ has joined #openstack-ironic | 07:46 | |
*** marty_ is now known as Guest30905 | 07:46 | |
*** hstimer has quit IRC | 07:50 | |
*** Guest30905 has quit IRC | 07:50 | |
*** vkozhukalov has joined #openstack-ironic | 07:52 | |
*** mdurnosvistov has joined #openstack-ironic | 07:53 | |
*** vkozhukalov has quit IRC | 08:02 | |
*** vkozhukalov has joined #openstack-ironic | 08:14 | |
*** rongze has joined #openstack-ironic | 08:29 | |
*** yuriyz has joined #openstack-ironic | 08:44 | |
*** mdurnosvistov has quit IRC | 08:51 | |
*** nosnos has joined #openstack-ironic | 08:55 | |
*** ifarkas has quit IRC | 09:05 | |
*** rongze has quit IRC | 09:05 | |
*** ifarkas has joined #openstack-ironic | 09:10 | |
*** derekh has joined #openstack-ironic | 09:16 | |
*** lucasagomes has joined #openstack-ironic | 09:19 | |
*** jistr has joined #openstack-ironic | 09:22 | |
*** romcheg has joined #openstack-ironic | 09:24 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add driver interfaces validation https://review.openstack.org/54593 | 09:26 |
lucasagomes | NobodyCam, 54593 rebased :) thanks | 09:28 |
*** rongze has joined #openstack-ironic | 09:34 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Check connectivity in SSH driver 'validate' method https://review.openstack.org/60876 | 09:35 |
*** Haomeng|2 has joined #openstack-ironic | 09:48 | |
*** Haomeng has quit IRC | 09:50 | |
*** nosnos has quit IRC | 09:51 | |
*** ndipanov has joined #openstack-ironic | 09:59 | |
*** mdurnosvistov has joined #openstack-ironic | 10:01 | |
*** martyntaylor has joined #openstack-ironic | 10:10 | |
*** max_lobur_afk is now known as max_lobur | 10:12 | |
*** martyntaylor has quit IRC | 10:15 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 10:18 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Node validations https://review.openstack.org/57495 | 10:24 |
*** martyntaylor has joined #openstack-ironic | 10:35 | |
*** prekarat has quit IRC | 10:57 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: API: Validate driver when creating/updating a node https://review.openstack.org/61960 | 10:59 |
*** rongze has quit IRC | 11:06 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Reworks Chassis validations https://review.openstack.org/57686 | 11:13 |
*** intersting has joined #openstack-ironic | 11:26 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Strip '/' from api_url string for PXE driver https://review.openstack.org/60205 | 11:29 |
*** romcheg1 has joined #openstack-ironic | 11:34 | |
*** rongze has joined #openstack-ironic | 11:38 | |
*** romcheg has quit IRC | 11:38 | |
*** rongze has quit IRC | 11:49 | |
*** romcheg has joined #openstack-ironic | 12:13 | |
*** rongze has joined #openstack-ironic | 12:15 | |
*** romcheg1 has quit IRC | 12:17 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Convert trycmd() to oslo's processutils https://review.openstack.org/61709 | 12:39 |
*** derekh has quit IRC | 13:26 | |
*** jdob has joined #openstack-ironic | 13:31 | |
*** rongze has quit IRC | 13:59 | |
*** vkozhukalov has quit IRC | 14:15 | |
*** blamar has quit IRC | 14:17 | |
*** lucasagomes has quit IRC | 14:19 | |
*** linggao has joined #openstack-ironic | 14:19 | |
*** matty_dubs|gone is now known as matty_dubs | 14:19 | |
*** jdob has quit IRC | 14:22 | |
*** jdob has joined #openstack-ironic | 14:25 | |
*** russellb is now known as rustlebee | 14:25 | |
NobodyCam | good morning iRonic | 14:26 |
*** jistr has quit IRC | 14:34 | |
*** jistr has joined #openstack-ironic | 14:36 | |
*** rongze has joined #openstack-ironic | 14:44 | |
*** hughsaunders has quit IRC | 14:46 | |
*** hughsaunders has joined #openstack-ironic | 14:46 | |
*** urulama has quit IRC | 14:47 | |
*** blamar has joined #openstack-ironic | 14:48 | |
max_lobur | morning Ironic! | 14:58 |
NobodyCam | morning max_lobur | 14:59 |
max_lobur | morning NobodyCam :) | 15:00 |
*** jcooley_ has joined #openstack-ironic | 15:00 | |
NobodyCam | :) | 15:00 |
max_lobur | a question to the everyone - does anybody use PyCharm for development? | 15:00 |
NobodyCam | not i | 15:01 |
max_lobur | I've recently contacted JetBrains and they said they're able to provide a free licence for a professional version of the 3rd gen PyCharm for the whole team if someone of core Devs will submit request form | 15:01 |
max_lobur | http://www.jetbrains.com/pycharm/ | 15:01 |
NobodyCam | i use TextWrangler | 15:02 |
max_lobur | http://www.jetbrains.com/eforms/openSourceRequest.action?licenseRequest=PCP05NS# this is a submission form | 15:02 |
max_lobur | if someone interested - welcome :) | 15:02 |
NobodyCam | max_lobur: yes there was a email some time back that they are offering that | 15:02 |
max_lobur | did they provide some terms for this? e.g. to mention somewhere in project wiki that we use pycharm.. Just interesting | 15:04 |
NobodyCam | I'd have to look it up. as I recall it was a 1 year linc. free of you are a atc for openstack | 15:06 |
max_lobur | ah I see | 15:06 |
*** rongze has quit IRC | 15:11 | |
yuriyz | Morning Ironic | 15:14 |
max_lobur | morning yuriyz | 15:15 |
NobodyCam | morning yuriyz | 15:15 |
*** jistr_ has joined #openstack-ironic | 15:16 | |
yuriyz | max_lobur, Openstack team has already PyCharm licence, please contact Andrew Melton (message 09/26/13 in maillist) | 15:18 |
sandeepr | morning ironic | 15:19 |
NobodyCam | good morning sandeepr | 15:19 |
sandeepr | or rather evening :) | 15:19 |
sandeepr | hey hey NobodyCam good morning | 15:19 |
*** jistr has quit IRC | 15:19 | |
NobodyCam | :) | 15:19 |
max_lobur | yuriyz, that's interesting, thanks! | 15:19 |
*** rwsu has joined #openstack-ironic | 15:31 | |
*** jcooley_ has quit IRC | 15:37 | |
*** jcooley_ has joined #openstack-ironic | 15:38 | |
*** rongze has joined #openstack-ironic | 15:39 | |
*** jcooley_ has quit IRC | 15:43 | |
*** jistr_ is now known as jistr | 15:45 | |
*** max_lobur is now known as max_lobur_afk | 15:54 | |
*** mdenny has joined #openstack-ironic | 16:02 | |
*** romcheg has quit IRC | 16:08 | |
*** jcooley_ has joined #openstack-ironic | 16:09 | |
*** ifarkas has quit IRC | 16:10 | |
*** rongze has quit IRC | 16:14 | |
*** jdob_ has joined #openstack-ironic | 16:15 | |
*** jdob has quit IRC | 16:15 | |
*** jdob_ is now known as jdob | 16:15 | |
*** rongze has joined #openstack-ironic | 16:21 | |
*** jcooley_ has quit IRC | 16:21 | |
*** jcooley_ has joined #openstack-ironic | 16:21 | |
*** jcooley_ has quit IRC | 16:25 | |
*** yuriyz has quit IRC | 16:32 | |
*** ndipanov has quit IRC | 16:33 | |
*** hughsaunders has quit IRC | 16:37 | |
*** openstackgerrit has quit IRC | 16:37 | |
*** Ghe_HPDiscover has quit IRC | 16:37 | |
*** hughsaunders_ has joined #openstack-ironic | 16:37 | |
*** ndipanov has joined #openstack-ironic | 16:37 | |
*** hughsaunders_ is now known as hughsaunders | 16:38 | |
*** openstackgerrit has joined #openstack-ironic | 16:38 | |
*** Ghe_HPDiscover has joined #openstack-ironic | 16:38 | |
*** romcheg has joined #openstack-ironic | 16:42 | |
*** lynxman has quit IRC | 16:44 | |
*** Ghe_HPDi1cover has joined #openstack-ironic | 16:45 | |
*** lynxman has joined #openstack-ironic | 16:49 | |
*** openstackgerrit has quit IRC | 16:49 | |
*** Ghe_HPDiscover has quit IRC | 16:49 | |
*** jcooley_ has joined #openstack-ironic | 16:55 | |
*** viktors has left #openstack-ironic | 16:56 | |
NobodyCam | Ghe_HPDi1cover: How goes Discover | 16:57 |
*** mdurnosvistov has quit IRC | 17:02 | |
*** martyntaylor has quit IRC | 17:04 | |
*** matty_dubs is now known as matty_dubs|lunch | 17:06 | |
*** jistr has quit IRC | 17:06 | |
*** jdob has quit IRC | 17:11 | |
NobodyCam | bbt ... brb | 17:11 |
*** hemna_ has joined #openstack-ironic | 17:12 | |
*** hemnafk has quit IRC | 17:14 | |
*** openstackgerrit has joined #openstack-ironic | 17:22 | |
openstackgerrit | dekehn proposed a change to openstack/ironic: Method to generate PXE options for Neutron ports https://review.openstack.org/60904 | 17:22 |
*** jdrumheller has joined #openstack-ironic | 17:25 | |
*** ndipanov has quit IRC | 17:27 | |
NobodyCam | post breakfast walkies... | 17:28 |
devananda | morning, all! | 17:29 |
NobodyCam | good morning devananda | 17:44 |
NobodyCam | dkehn: you around? | 17:47 |
devananda | NobodyCam: have you seed someone named dima or dshulyak appear in channel this week? | 17:47 |
dkehn | yes | 17:47 |
dkehn | NobodyCam: whats up | 17:48 |
NobodyCam | devananda: not that I recall. I can go back thru my log if needed | 17:48 |
NobodyCam | dkehn: just question on 60904 | 17:48 |
devananda | NobodyCam: i was hoping for some context on https://blueprints.launchpad.net/ironic/+spec/ironic-web-server | 17:48 |
dkehn | NobodyCam: shoot | 17:49 |
NobodyCam | _get_pxe_bootfile_name() just returns CONF.pxe.pxe_bootfile_name it appers to be used _dhcp_options_for_instance() which also uses CONF.pxe.tftp_server directly. just wounder why the _get_pxe_bootfile_name function vs just using CONF.pxe.pxe_bootfile_name directly in _dhcp_options_for_instance | 17:51 |
dkehn | NobodyCam: look again https://review.openstack.org/#/c/60904/7/ironic/drivers/modules/pxe.py, but in essense correct, this is a a 1st patch | 17:52 |
NobodyCam | devananda: are you sure that is the nick? | 17:57 |
*** mdurnosvistov has joined #openstack-ironic | 18:00 | |
NobodyCam | devananda: just looked at http://eavesdrop.openstack.org for the dates that BP was filed .. I do not see that nick also searched for "web" | 18:01 |
*** hemna_ is now known as hemna | 18:01 | |
NobodyCam | s/that nick/those nicks/ | 18:02 |
devananda | NobodyCam: thanks. i just poked dhellman and got an answer | 18:03 |
hemna | devananda, I'm working on the cinder BP today. I started it last night, but didn't get to fill it out much. | 18:04 |
hemna | I have an etherpad with most of my notes in it. | 18:05 |
*** harlowja has quit IRC | 18:05 | |
devananda | hemna: great! there's a spot in the BP to link to an external URL -- please put the etherpad link there | 18:07 |
hemna | will do | 18:08 |
devananda | hemna: it's OK if most of the details aren't in the actual BP then | 18:08 |
hemna | I'm working on a wiki page that will hopefully have all the details, at least from a high level | 18:08 |
hemna | as I still don't know the innards of ironic well enough yet | 18:08 |
*** matty_dubs|lunch is now known as matty_dubs | 18:19 | |
devananda | SpamapS: for later: http://docs-draft.openstack.org/54/60954/5/check/gate-ironic-docs/c589fc2/doc/build/html/webapi/v1.html | 18:24 |
*** harlowja has joined #openstack-ironic | 18:24 | |
NobodyCam | no lucas today? | 18:26 |
NobodyCam | devananda: got a free miunte to quiclky look over: https://review.openstack.org/#/c/61664/ | 18:26 |
devananda | NobodyCam: on a call right now. will look in a bit | 18:29 |
NobodyCam | :) | 18:31 |
*** rwsu has quit IRC | 18:32 | |
hemna | you really want to fill the log with debugging for every execute call? | 18:35 |
NobodyCam | hemna: on 61664? | 18:36 |
hemna | yah | 18:36 |
NobodyCam | it at debug level | 18:37 |
NobodyCam | so most of the op I know don't run production at debug level | 18:37 |
hemna | seems like something a dev would do for short term testing...but I guess Ironic is incubation :) | 18:37 |
*** rwsu has joined #openstack-ironic | 18:40 | |
SpamapS | devananda: ty, reading now :) | 18:52 |
NobodyCam | morning SpamapS :) | 18:55 |
SpamapS | devananda: nice and simple. Makes a lot of sense. :) | 18:59 |
devananda | SpamapS: glad to hear it :) | 18:59 |
devananda | SpamapS: that should land soon, I hope, at which point it'll be available at http://docs.openstack.org/developer/ironic/webapi/v1.html | 19:00 |
* NobodyCam thinks "heat stack-create" is taking longer now... or time is slowing down.. lol | 19:02 | |
*** rongze has quit IRC | 19:20 | |
*** hstimer has joined #openstack-ironic | 19:23 | |
NobodyCam | brb | 19:44 |
hemna | https://wiki.openstack.org/wiki/Ironic/blueprints/cinder-integration | 19:51 |
hemna | ok that's a quick first pass | 19:52 |
* devananda reviews | 20:00 | |
devananda | hemna: under workflow, item 1 | 20:01 |
devananda | "User asks Ironic to boot a node from a cinder volume (uuid) | 20:01 |
*** anniec has joined #openstack-ironic | 20:01 | |
hemna | k | 20:01 |
devananda | hemna: i think this should be: User asks Nova to create an instance with --boot-from-volume <uuid> | 20:01 |
hemna | ok, I wasn't sure what the right semantics were there | 20:02 |
hemna | so a user will still use nova to orchestrate with BM ? | 20:02 |
devananda | hemna: the entrypoint to booting an instance is still via Nova, yes | 20:02 |
hemna | nova calls ironic ? | 20:02 |
devananda | yep | 20:02 |
hemna | ok coolio | 20:02 |
devananda | hemna: fyi, https://review.openstack.org/#/c/51328/ | 20:03 |
devananda | hemna: we're adding a nova driver taht will replace the "baremetal" driver | 20:03 |
devananda | that takes care of the scheduling. it will technically be possible to deploy an instance without using Nova, but not encouraged | 20:04 |
hemna | ok cool | 20:04 |
hemna | updated the wiki page | 20:04 |
devananda | hemna: i'm not sure how you are using the BM acronym. it seems to mean a few different things | 20:06 |
hemna | ok | 20:06 |
hemna | I can clarify that | 20:06 |
hemna | BM to me means bare metal host | 20:06 |
* NobodyCam giggles | 20:06 | |
devananda | right | 20:06 |
devananda | so in Ironic, we just call that the "node" | 20:06 |
hemna | ok | 20:06 |
hemna | heh that's just my cinder bias | 20:07 |
*** harlowja has quit IRC | 20:07 | |
devananda | :) | 20:07 |
hemna | would you like me to change BM -> node ? | 20:07 |
devananda | can you fill in some details about what information is passed between services at each point? | 20:07 |
devananda | hemna: please :) | 20:07 |
hemna | ok will do | 20:07 |
hemna | I really appreciate the feedback | 20:07 |
devananda | eg, "passing in the connection information" -- what exactly is this info? | 20:07 |
hemna | ok sure | 20:07 |
devananda | hemna: it's a great start. one of the best BP's we've gotten so far | 20:09 |
hemna | ok cool. :) | 20:09 |
devananda | also, as i assume you already know, this doesn't exist yet: Ironic has an abstracted BIOS communication layer. | 20:10 |
hemna | ok removed BM | 20:10 |
devananda | unless there's a way to do the iSCSI/FC configuration via IPMI which I'm not aware of | 20:10 |
hemna | I'll work on filling in the details for the calls after lunch | 20:11 |
hemna | devananda, yah I assumed it doesn't exist yet | 20:11 |
devananda | hemna: cool. I'll try and take another look this afternoon; if I dont, I'll definitely look again next week. | 20:11 |
hemna | ok great thank you. | 20:12 |
hemna | If nothing else, it's a way to start the discussion process of what's needed. | 20:12 |
devananda | NobodyCam: want to poke at https://review.openstack.org/#/c/60954/ again? | 20:21 |
NobodyCam | sure... was just digging in to that error that you get with the nova driver | 20:22 |
devananda | hemna: exactly, and i suspect we'll have several discussions about it, particularly w.r.t. BIOS configuration | 20:22 |
NobodyCam | I am now getting it too | 20:22 |
devananda | NobodyCam: ahhh :( | 20:22 |
*** martyntaylor has joined #openstack-ironic | 20:23 | |
*** jcooley_ has quit IRC | 20:24 | |
NobodyCam | devananda: what is expected as :param marker: pagination marker for large data sets. int? page #, record #?,or ??? | 20:24 |
devananda | NobodyCam: the value returned in the previous result set | 20:25 |
devananda | NobodyCam: it is not an arbitrary user-settable value | 20:25 |
devananda | NobodyCam: I believe it will be the UUID of the last resource of the previous result set | 20:27 |
devananda | by default | 20:27 |
NobodyCam | :) | 20:27 |
devananda | but if you change the sort parameter, then the marker will be the value of that column instead of uuid ... I THINK ... | 20:28 |
openstackgerrit | A change was merged to openstack/ironic: Add driver interfaces validation https://review.openstack.org/54593 | 20:28 |
NobodyCam | do you have any thoughts on https://review.openstack.org/#/c/60876/ | 20:29 |
*** rongze has joined #openstack-ironic | 20:31 | |
devananda | NobodyCam: looks reasoanble to me, particularly considering ^ just landed | 20:31 |
devananda | NobodyCam: means that we can call the API to test that SSH driver actually works, instead of calling "nova boot" and having it fail | 20:32 |
*** anniec has quit IRC | 20:32 | |
NobodyCam | is that not called when changing driver info to | 20:32 |
NobodyCam | *too | 20:32 |
NobodyCam | so, in my case, I coud not even enter nodes with out my ssh host active | 20:33 |
NobodyCam | looking at port.py on 60954 | 20:34 |
NobodyCam | get_all and detail have the EXACT same doc string? | 20:35 |
devananda | humm | 20:35 |
*** rongze has quit IRC | 20:36 | |
NobodyCam | maybe add from collections to detail? | 20:37 |
*** jcooley_ has joined #openstack-ironic | 20:37 | |
devananda | NobodyCam: ironic.conductor.manager update_node() | 20:38 |
devananda | NobodyCam: i only see driver.power.validate() called if the node.instance_uuid is being set | 20:38 |
devananda | to prevent associating a powered-on node | 20:38 |
NobodyCam | oh you are right we talked about just tht b4 | 20:38 |
*** jcooley_ has quit IRC | 20:39 | |
devananda | :) | 20:40 |
NobodyCam | so just the comment on port | 20:40 |
NobodyCam | for 60954 | 20:41 |
NobodyCam | you want a comment on the review? | 20:41 |
*** anniec has joined #openstack-ironic | 20:42 | |
devananda | eh? | 20:42 |
NobodyCam | https://review.openstack.org/#/c/60954/5/ironic/api/controllers/v1/port.py | 20:43 |
NobodyCam | get_all and detail have the EXACT same doc string? | 20:43 |
NobodyCam | not that way for node or chassis | 20:43 |
devananda | huh | 20:44 |
*** romcheg has left #openstack-ironic | 20:45 | |
NobodyCam | see deg get_all and def detail here https://review.openstack.org/#/c/60954/5/ironic/api/controllers/v1/node.py and https://review.openstack.org/#/c/60954/5/ironic/api/controllers/v1/node.py | 20:46 |
NobodyCam | then look at https://review.openstack.org/#/c/60954/5/ironic/api/controllers/v1/port.py | 20:46 |
NobodyCam | the doc string in port.py is the exact same for both | 20:46 |
NobodyCam | s/deg/def/ | 20:47 |
devananda | NobodyCam: yea. i was just digging around to see if there was a functional difference. there is | 20:48 |
* devananda updates the patch -AGAIN- | 20:48 | |
NobodyCam | :-p sorry | 20:48 |
devananda | NobodyCam: please comment | 20:48 |
devananda | and gah, i really thought that would have been a simple, quick-to-merge patch .... | 20:49 |
devananda | also, i need to go make lunch in a bit | 20:49 |
NobodyCam | lol -1'd | 20:50 |
NobodyCam | :( | 20:50 |
*** vkozhukalov has joined #openstack-ironic | 20:51 | |
devananda | NobodyCam: heh. you commented on wrong file :p | 20:51 |
NobodyCam | ahhh | 20:51 |
NobodyCam | i did | 20:51 |
NobodyCam | updated | 20:52 |
NobodyCam | :-p | 20:53 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Fix auto-generated REST API formatting https://review.openstack.org/60954 | 20:55 |
devananda | fixed | 20:55 |
*** harlowja has joined #openstack-ironic | 20:56 | |
*** kui has joined #openstack-ironic | 20:56 | |
NobodyCam | I will +2 as soon as mr J is done | 20:56 |
devananda | tyvm | 20:56 |
NobodyCam | if it keeps lucas's +2 I will also +a | 20:57 |
NobodyCam | or I could just +a it.. :-p | 20:57 |
*** jcooley_ has joined #openstack-ironic | 21:05 | |
NobodyCam | brb while waiting on mr J | 21:09 |
devananda | it won't keep any of the prior votes | 21:27 |
devananda | because content changed (by just a few characters, but still) | 21:28 |
devananda | i would still +A it, if it werent' my patch ;) | 21:28 |
*** max_lobur has joined #openstack-ironic | 21:32 | |
*** vkozhukalov has quit IRC | 21:33 | |
*** jcooley_ has quit IRC | 21:41 | |
*** harlowja has quit IRC | 21:50 | |
*** jcooley_ has joined #openstack-ironic | 21:52 | |
*** vkozhukalov has joined #openstack-ironic | 21:54 | |
*** jcooley_ has quit IRC | 21:57 | |
*** harlowja has joined #openstack-ironic | 22:00 | |
*** jcooley_ has joined #openstack-ironic | 22:01 | |
*** anniec has quit IRC | 22:02 | |
NobodyCam | :-p | 22:03 |
NobodyCam | devananda: do we know if lucas is on vacation? | 22:05 |
*** matty_dubs is now known as matty_dubs|gone | 22:08 | |
devananda | NobodyCam: i do not know | 22:10 |
NobodyCam | i'll +a that patch | 22:10 |
NobodyCam | lucas gave it a +2 already | 22:10 |
NobodyCam | done | 22:14 |
NobodyCam | noted lucas already +2'd and you really on changed "with detail" | 22:15 |
NobodyCam | s/on/only/ | 22:15 |
devananda | sounds good :) | 22:16 |
*** harlowja has quit IRC | 22:16 | |
* NobodyCam is going to buy a new MOUSE this weekend | 22:17 | |
NobodyCam | and this error is quite odd | 22:19 |
*** harlowja has joined #openstack-ironic | 22:24 | |
*** jcooley_ has quit IRC | 22:25 | |
*** harlowja has quit IRC | 22:27 | |
*** harlowja has joined #openstack-ironic | 22:28 | |
*** vkozhukalov has quit IRC | 22:35 | |
*** max_lobur has quit IRC | 22:37 | |
*** kui has quit IRC | 22:39 | |
*** anniec has joined #openstack-ironic | 22:39 | |
*** kui has joined #openstack-ironic | 22:39 | |
NobodyCam | devananda: do you how to unapply a patch? | 22:41 |
NobodyCam | https://github.com/openstack/python-ironicclient/commit/1fd3fcf59548ca53ea742a140457daabd579fe72 | 22:41 |
devananda | we can revert it... | 22:43 |
*** linggao has quit IRC | 22:44 | |
*** docaedo has quit IRC | 22:50 | |
*** docaedo has joined #openstack-ironic | 22:52 | |
NobodyCam | brb | 23:05 |
*** anniec has left #openstack-ironic | 23:06 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Developer doc index page points to correct API docs https://review.openstack.org/60960 | 23:07 |
devananda | NobodyCam: ^ is very minor, needs another +2/a | 23:08 |
openstackgerrit | A change was merged to openstack/ironic: Fix auto-generated REST API formatting https://review.openstack.org/60954 | 23:16 |
NobodyCam | devananda: ^^^ | 23:16 |
devananda | \o/ | 23:16 |
NobodyCam | :) | 23:16 |
* NobodyCam can tell its friday | 23:16 | |
NobodyCam | lol | 23:16 |
*** anniec has joined #openstack-ironic | 23:19 | |
* NobodyCam loves the ablity to redeploy a dev/test env with heat stack-create | 23:22 | |
* devananda notices that a single "s" has prevented 59795 from merging | 23:24 | |
NobodyCam | ??? | 23:24 |
NobodyCam | silly 's' | 23:24 |
NobodyCam | print "Silly %s" % 's' | 23:25 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Improve method to get list of active conductors https://review.openstack.org/59795 | 23:25 |
devananda | well, it needed a rebase anyway ... | 23:27 |
*** blamar has quit IRC | 23:28 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Improve method to get list of active conductors https://review.openstack.org/59795 | 23:28 |
NobodyCam | LOL | 23:28 |
*** anniec has joined #openstack-ironic | 23:32 | |
*** jdrumheller has quit IRC | 23:33 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing of nodes to conductors https://review.openstack.org/58895 | 23:43 |
devananda | it's friday ... | 23:45 |
devananda | have a good weekend everyone :) | 23:45 |
hemna | w00t! | 23:46 |
NobodyCam | have a good weekend devananda | 23:47 |
NobodyCam | :) | 23:47 |
*** martyntaylor has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!