*** yfujioka has joined #openstack-ironic | 00:16 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/60972 | 00:17 |
---|---|---|
*** jcooley_ has joined #openstack-ironic | 00:17 | |
openstackgerrit | Jenkins proposed a change to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/60982 | 00:19 |
*** epim has joined #openstack-ironic | 00:20 | |
devananda | rloo: on https://review.openstack.org/#/c/59795/7/ironic/db/api.py, any other suggestions? | 00:26 |
devananda | i'm not keen on the current name either | 00:26 |
devananda | but it was all i thought of at the time .... | 00:27 |
*** rongze has quit IRC | 00:34 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Improve method to get list of active conductors https://review.openstack.org/59795 | 00:34 |
rloo | devananda: i'm not good with naming. but yes, get_active_driver_dict is clearer. | 00:38 |
devananda | great | 00:38 |
*** docaedo has quit IRC | 00:38 | |
rloo | devananda: so there are active drivers and non-active drivers? | 00:39 |
devananda | well... | 00:39 |
*** docaedo has joined #openstack-ironic | 00:39 | |
devananda | there can be non-active conductors | 00:39 |
rloo | yeah, I'm too literal sometimes. | 00:39 |
rloo | so if you were to describe what you're getting, what would you say? get drivers? get drivers from active conductors? | 00:40 |
rloo | what if you wanted drivers from non-active conductor? | 00:40 |
devananda | what determines a non-active conductor? | 00:40 |
devananda | one that previously was active, but has since timed out? | 00:40 |
rloo | i don't know. you tell me. I didn't use the term 'active conductor' :-) | 00:41 |
devananda | or one that was intentionally turned off -- and presumably deregistered itself on shutdown (I need to implement taht ....) | 00:41 |
rloo | if I recall from the code, it was 'previously active, but since timed out' | 00:41 |
devananda | correct | 00:41 |
devananda | the other is a case I'm wrestling with in my head | 00:41 |
devananda | the issue is mutlifold | 00:42 |
*** davidlenwell has joined #openstack-ironic | 00:42 | |
devananda | *multifaceted | 00:42 |
rloo | and a conductor that just dies... | 00:42 |
devananda | will eventually be considered timed out, yes | 00:42 |
rloo | i guess a dead conductor is taken care of cuz it timed out | 00:42 |
devananda | to answer your question | 00:43 |
rloo | a conductor that was turned off will also have timed out? | 00:43 |
devananda | 00:40:04 < rloo> so if you were to describe what you're getting, what would you say? get drivers? get drivers from active conductors? | 00:43 |
rloo | it doesn't, at least now, seem like you can get drivers from non-active conductors, right? | 00:43 |
rloo | so it is just get-drivers? | 00:43 |
devananda | i would say, what i really want is a list (or set) of the hostnames of all the conductors which are part of the hash ring that I am a part of | 00:44 |
rloo | well, i guess you can get from non-active conductors -- the ones that timed out but are still alive. | 00:44 |
devananda | where "I" == "the conductor issuing the query" | 00:44 |
rloo | the conductors that are part of the hash ring. what happens to a conductor that times out. is it part of the hash ring still? | 00:44 |
rloo | (I forgot if I saw it in the code or not.) | 00:45 |
devananda | in the proposal from lifeless, it would still be part of the hash ring, but it would be added to an "exclude" list | 00:45 |
devananda | https://etherpad.openstack.org/p/IronicConsistentHashingForInstances | 00:45 |
* lifeless perks up | 00:45 | |
devananda | for reference | 00:45 |
rloo | and I guess you don't want drivers from the excluded conductors? | 00:45 |
devananda | lifeless: hi! just chatting with rloo about the hash stuff. she's digging into my patch sets and the new revisions thereof. | 00:45 |
lifeless | cool | 00:46 |
*** davidlenwell_ has quit IRC | 00:46 | |
devananda | rloo: so it's not really the drivers i'm interested in | 00:46 |
devananda | it's the list (or set) of conductors | 00:46 |
devananda | if all conductors shared the same list of drivers, there would only need to be a single hash ring | 00:46 |
devananda | rloo: but since it is possible (and by design) for different cdr's to have different drivers, we need, effectively, one hash ring per driver | 00:47 |
lifeless | huh, why did https://review.openstack.org/#/c/59794/8 not land ? | 00:47 |
*** jcooley_ has quit IRC | 00:47 | |
devananda | lifeless: rebase clears the +A | 00:47 |
devananda | lifeless: rev 8 depended on something else | 00:47 |
lifeless | ok | 00:48 |
* lifeless resubmits it | 00:48 | |
devananda | lifeless: i split my series into two branches for simplicity. -- thanks! | 00:49 |
*** GheRiver1 has joined #openstack-ironic | 00:49 | |
*** openstack has joined #openstack-ironic | 00:49 | |
*** SpamapS has quit IRC | 00:49 | |
lifeless | devananda: we could do one ring and reprobe, but I agree, N rings is better. | 00:49 |
*** bigjools has quit IRC | 00:50 | |
devananda | lifeless: ack | 00:50 |
*** bigjools has joined #openstack-ironic | 00:50 | |
*** bigjools has joined #openstack-ironic | 00:50 | |
*** SpamapS has joined #openstack-ironic | 00:50 | |
rloo | lifeless seems to have a way with words. Maybe he can come up with a good name, devananda. | 00:50 |
devananda | lifeless: also, fwiw, i got some time to whiteboard with krow. he (surprisingly) liked almost all of this design. except for the heartbeat table | 00:50 |
*** jcooley_ has joined #openstack-ironic | 00:51 | |
lifeless | heh | 00:51 |
lifeless | thats good | 00:51 |
*** jcooley_ has quit IRC | 00:51 | |
openstackgerrit | A change was merged to openstack/ironic: Add config option for # of conductor replicas https://review.openstack.org/59794 | 00:51 |
devananda | and suggested we instead use TCP sockets between all the conductors to know when one dies. Not that we'd send anything across them... just keep them open... | 00:51 |
lifeless | mmm | 00:52 |
lifeless | and conductor to all APIs then, so that users can query? | 00:52 |
devananda | presumably. which is less than ideal. | 00:53 |
lifeless | or then you get into 'ask a random conductor whats up' | 00:53 |
devananda | yea, or something like that | 00:53 |
lifeless | but maybe that conductor has a different view to the other conductors | 00:53 |
lifeless | so you'd have to ask them all | 00:53 |
lifeless | It's an interesting take, but honestly - if we're going to reinvent presence, lets do that explicitly, or otherwise use a library to do it. | 00:54 |
devananda | *nod* | 00:54 |
devananda | pretty much my response -- neat idea, not sure it'll fit (it might) but it would be a lot to engineer well, for minimal returns right now | 00:54 |
lifeless | I mean, the heartbeat table is also a form of reinvention, but it's easier to write for now and we can revisit later to replac. | 00:54 |
devananda | indeed | 00:54 |
devananda | but it's a pretty standard way to invent this, with minimal work | 00:54 |
devananda | the hash is much more complex | 00:55 |
lifeless | actually | 00:56 |
lifeless | I think, technically, the hash is much simpler. | 00:57 |
*** GheRivero has quit IRC | 00:57 | |
lifeless | It doesn't interact with nearly as many variables outside our control. | 00:57 |
lifeless | Like network splits :) | 00:57 |
devananda | rloo, lifeless: if you two have time for one more review, https://review.openstack.org/#/c/58894/. I think I've addressed your comments | 00:57 |
lifeless | can one conductor run many drivers? | 00:57 |
devananda | lifeless: hmm. the hash by itself, yes. but when you consider the interaction with drivers to do take over, etc, it gets more interesting | 00:58 |
devananda | lifeless: absolutely | 00:58 |
devananda | lifeless: and conductors in the same cluster may have different drivers | 00:59 |
lifeless | devananda: I've -1'd https://review.openstack.org/#/c/59795/ | 00:59 |
lifeless | devananda: very minor fixes | 00:59 |
lifeless | devananda: I have a question for you in https://review.openstack.org/#/c/60954/ | 01:00 |
devananda | eg, this rack is driverA. that rack is driverB. another rack is a mix of C and D. two conductors per rack. all in the same AZ. -- I want to support that kind of topology. | 01:01 |
devananda | looking | 01:01 |
devananda | lifeless: see the commit message for explanation | 01:01 |
lifeless | devananda: can you file a bug on it then? And reference that bug (Related-Bug: # IIRC) in the commit ? | 01:02 |
devananda | lifeless: i know it breaks PEP. as it is, it breaks the sphinxcontrib-pecanwsme doc formatting. | 01:02 |
devananda | ack | 01:02 |
lifeless | devananda: because otherwise folk will 'fix it'. | 01:02 |
lifeless | devananda: also a comment on that docstring | 01:02 |
lifeless | # XXX (devananda) bug XYZ breaks this if formatted correctly. | 01:03 |
lifeless | devananda: thanks! | 01:03 |
lifeless | devananda: https://review.openstack.org/#/c/60904/ - You might want to see if you agree with my assessment w.r.t pxelinux.0 there. | 01:06 |
*** hemna has quit IRC | 01:10 | |
*** epim has quit IRC | 01:18 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Fix auto-generated REST API formatting https://review.openstack.org/60954 | 01:23 |
devananda | lifeless: on your comment, single conductor can serve many different arch, I presume you mean eg. i686, x86-64, and arm? | 01:25 |
devananda | lifeless: or do you mean linux + windows? | 01:25 |
lifeless | arch, not OS | 01:27 |
lifeless | and yes, ARM specifically | 01:27 |
devananda | right | 01:27 |
devananda | what would be different, exactly? | 01:27 |
*** nosnos has joined #openstack-ironic | 01:28 | |
lifeless | it wouldn't be pxelinux.0, AIUI. | 01:28 |
lifeless | I'm a little fuzzy here TBH | 01:29 |
lifeless | e.g. http://rsalveti.wordpress.com/2011/07/11/net-booting-with-tftp-and-pxe-with-pandaboard/ | 01:29 |
lifeless | U-Boot reads the same files as pxelinux.0 | 01:30 |
lifeless | https://bugs.launchpad.net/ubuntu/+source/u-boot-linaro/+bug/927781 | 01:31 |
lifeless | possibly we should have a separate driver for U-Boot | 01:32 |
lifeless | ? | 01:32 |
devananda | Don’t worry about the ‘filename “pxelinux.0″;’ line at the dhcpd.conf file, you can remove it. | 01:32 |
devananda | ??? | 01:32 |
lifeless | also https://bugs.launchpad.net/ubuntu/+source/cobbler/+bug/827681 | 01:32 |
devananda | I suspect U-boot and iPXE will be different drivers than PXE, yes | 01:33 |
devananda | however, if ARM supports (normal) PXE, but requires different config than i686/x8664, then there is some problem ... | 01:33 |
devananda | I don't think that pxe_bootfile_name should be set per node. it's shared between all the nodes taht use the PXE driver today. | 01:34 |
lifeless | so AIUI U-Boot lives in the firmware | 01:34 |
lifeless | and honours most of the pxe stuff except it doesn't download pxelinux.0, it just implements the things that that reads directly | 01:35 |
devananda | if ARM requires a different boot file, I would suggest a separate option in the PXE driver, eg, arm_pxe_bootfile_name | 01:35 |
lifeless | so you want the same config files, with the same format and same content | 01:35 |
devananda | and add a check to the pxe driver that changes its behavior if necessary, based on node metadata (eg, cpu arch) | 01:36 |
lifeless | devananda: what are the heuristics for determining when something should be config on disk vs config-in-the-driver vs config-in-the-ndeode? | 01:36 |
devananda | lifeless: where the source of knowledge of that thing resides | 01:36 |
devananda | eg, in this case, knowledge of what boot file this node uses is, IMO, not something the cloud admin should know (therefor not something s/he will set when enrolling the node) | 01:37 |
lifeless | ok; can I bother you to correct me in that review? | 01:38 |
lifeless | or would you like me to? | 01:38 |
devananda | np. if you agree, i'll write this up on the review | 01:39 |
lifeless | I need to think more about that heuristic | 01:39 |
devananda | great. I'd love a better one :) | 01:39 |
lifeless | I concede your concern about per-node | 01:39 |
lifeless | but wonder if that may be because we don't have an arch abstraction | 01:39 |
devananda | ah | 01:39 |
devananda | it may | 01:39 |
lifeless | I don't see how it really helps between disk-config and driver-config-in-db | 01:40 |
lifeless | both are set by the admin | 01:40 |
devananda | what is "disk cnofig" ? | 01:40 |
lifeless | foo.conf | 01:40 |
devananda | k | 01:40 |
devananda | what is "driver config in db" ? | 01:40 |
lifeless | I thought (IMBW) that driver objects could take parameters | 01:40 |
devananda | ahh! nope | 01:40 |
devananda | or not yet, at least, and not in any current BPs | 01:41 |
lifeless | /drivers/driver/properties-of-some-sort | 01:41 |
devananda | we can pass commands to drivers via vendor-passthru | 01:41 |
devananda | but there is no generalized way for drivers to store their own global config or status in a db | 01:41 |
lifeless | ok | 01:41 |
devananda | and doing that would require some synchronization between all the conductors that have said driver | 01:42 |
lifeless | so if there was a vendor driver that should backend onto some API | 01:42 |
lifeless | that would require a config file setting today ? | 01:42 |
devananda | yep | 01:42 |
lifeless | ok | 01:42 |
devananda | or per-node settings | 01:42 |
devananda | lifeless: replied | 01:49 |
lifeless | thanks | 01:49 |
devananda | thank you. tis a good point to raise | 01:50 |
*** rongze has joined #openstack-ironic | 01:51 | |
*** rongze has quit IRC | 01:51 | |
*** rongze has joined #openstack-ironic | 01:52 | |
*** rongze is now known as 36DABWUXY | 01:53 | |
*** rongze has joined #openstack-ironic | 01:53 | |
*** rongze is now known as 45PAAS1G1 | 01:53 | |
*** 45PAAS1G1 has quit IRC | 01:57 | |
*** jimjiang has quit IRC | 01:57 | |
*** jimjiang_ has quit IRC | 01:57 | |
*** jimjiang has joined #openstack-ironic | 01:58 | |
*** 36DABWUXY has quit IRC | 02:04 | |
*** rongze has joined #openstack-ironic | 02:04 | |
*** bigjools has quit IRC | 02:08 | |
*** rwsu has quit IRC | 02:12 | |
*** michchap_ has joined #openstack-ironic | 02:15 | |
*** michchap has quit IRC | 02:17 | |
*** rwsu has joined #openstack-ironic | 02:26 | |
*** prekarat has quit IRC | 02:31 | |
*** rongze_ has joined #openstack-ironic | 02:35 | |
*** rongze has quit IRC | 02:35 | |
*** vkozhukalov has joined #openstack-ironic | 02:49 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add prepare, clean_up, take_over methods to deploy https://review.openstack.org/58894 | 02:55 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Improve method to get list of active conductors https://review.openstack.org/59795 | 02:59 |
devananda | and on that note, I need to stop for the night! see ya'll tmw | 03:00 |
*** michchap has joined #openstack-ironic | 03:07 | |
*** michchap_ has quit IRC | 03:09 | |
*** michchap_ has joined #openstack-ironic | 03:20 | |
*** michchap has quit IRC | 03:23 | |
*** rloo has quit IRC | 03:46 | |
dkehn | lifeless: int eh review for https://review.openstack.org/#/c/60904/2/ironic/drivers/modules/pxe.py, when you say this should come out of the node driver dict, can you explain a bit more | 04:05 |
*** arata has joined #openstack-ironic | 04:25 | |
devananda | dkehn: he means, if you stored the pxe_bootfile_name per-node, it would be stored in the node.driver_info dict | 04:57 |
devananda | dkehn: but see my response to his comments | 04:57 |
* devananda returns to being afk | 04:57 | |
*** prekarat has joined #openstack-ironic | 05:01 | |
*** rongze_ has quit IRC | 05:34 | |
*** rongze has joined #openstack-ironic | 05:44 | |
*** rongze has quit IRC | 05:50 | |
*** rongze has joined #openstack-ironic | 05:59 | |
*** michchap_ has quit IRC | 06:00 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/59627 | 06:01 |
*** arata has left #openstack-ironic | 06:02 | |
*** arata has joined #openstack-ironic | 06:07 | |
*** vkozhukalov has quit IRC | 06:12 | |
*** GheRivero has joined #openstack-ironic | 06:13 | |
*** GheRivero has quit IRC | 06:13 | |
*** GheRiver1 has quit IRC | 06:14 | |
*** GheRivero has joined #openstack-ironic | 06:14 | |
*** GheRivero is now known as Ghe_HPDiscover | 06:15 | |
NobodyCam | you have to let us know how Discover is Ghe_HPDiscover | 06:16 |
*** jcooley_ has joined #openstack-ironic | 06:33 | |
*** rongze has quit IRC | 06:35 | |
*** rongze has joined #openstack-ironic | 06:38 | |
*** urulama has joined #openstack-ironic | 07:27 | |
*** ndipanov has quit IRC | 07:46 | |
*** ndipanov has joined #openstack-ironic | 07:47 | |
*** vkozhukalov has joined #openstack-ironic | 07:52 | |
*** ifarkas has joined #openstack-ironic | 07:56 | |
*** ndipanov has quit IRC | 07:58 | |
*** rongze has quit IRC | 07:59 | |
*** ndipanov has joined #openstack-ironic | 08:02 | |
*** rongze has joined #openstack-ironic | 08:05 | |
*** yfujioka has quit IRC | 08:11 | |
*** prekarat has quit IRC | 08:25 | |
*** prekarat has joined #openstack-ironic | 08:25 | |
*** tatyana has joined #openstack-ironic | 08:29 | |
openstackgerrit | Fengqian.gao proposed a change to stackforge/pyghmi: Add BMC bridge request extension https://review.openstack.org/60768 | 08:31 |
*** jcooley_ has quit IRC | 08:45 | |
*** ndipanov has quit IRC | 08:47 | |
*** ndipanov has joined #openstack-ironic | 09:00 | |
*** jistr has joined #openstack-ironic | 09:05 | |
*** derekh has joined #openstack-ironic | 09:09 | |
*** prekarat has quit IRC | 09:10 | |
*** rongze has quit IRC | 09:11 | |
*** rongze has joined #openstack-ironic | 09:15 | |
*** lucasagomes has joined #openstack-ironic | 09:23 | |
*** prekarat has joined #openstack-ironic | 09:25 | |
*** romcheg1 has joined #openstack-ironic | 09:43 | |
*** romcheg1 has left #openstack-ironic | 09:43 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rework patch validation on Ports https://review.openstack.org/56984 | 10:10 |
*** max_lobur_afk is now known as max_lobur | 10:15 | |
*** viktors has quit IRC | 10:33 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: GET /drivers to show a list of active conductors https://review.openstack.org/60216 | 10:33 |
*** viktors has joined #openstack-ironic | 10:48 | |
*** rongze has quit IRC | 10:52 | |
*** rongze has joined #openstack-ironic | 10:52 | |
*** rongze has quit IRC | 10:55 | |
*** arata has left #openstack-ironic | 11:01 | |
*** yuriyz has joined #openstack-ironic | 11:09 | |
*** prekarat has quit IRC | 11:16 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Handle DBDuplicateEntry on Ports with same address https://review.openstack.org/59955 | 11:21 |
*** mdenny has quit IRC | 11:23 | |
*** jcooley_ has joined #openstack-ironic | 11:28 | |
*** jcooley_ has quit IRC | 11:33 | |
*** rongze has joined #openstack-ironic | 11:41 | |
*** jimjiang has quit IRC | 11:46 | |
*** jimjiang has joined #openstack-ironic | 11:47 | |
*** rongze has quit IRC | 11:51 | |
*** arata has joined #openstack-ironic | 11:56 | |
*** rongze has joined #openstack-ironic | 11:56 | |
*** arata has quit IRC | 11:57 | |
*** lucasagomes is now known as lucas-hungry | 12:20 | |
*** nosnos has quit IRC | 12:29 | |
*** jcooley_ has joined #openstack-ironic | 12:29 | |
*** jcooley_ has quit IRC | 12:35 | |
romcheg | Hi all | 12:42 |
romcheg | lucas-hungry: are you around? | 12:42 |
Haomeng | morning all:) | 12:45 |
romcheg | Morning Haomeng | 12:52 |
romcheg | How are you? | 12:52 |
Haomeng | romcheg: find, thank you:) | 12:53 |
Haomeng | romcheg: fine | 12:53 |
*** mdurnosvistov has joined #openstack-ironic | 12:56 | |
*** linggao has joined #openstack-ironic | 13:17 | |
*** rongze_ has joined #openstack-ironic | 13:29 | |
*** jcooley_ has joined #openstack-ironic | 13:31 | |
*** rongze has quit IRC | 13:33 | |
*** jcooley_ has quit IRC | 13:36 | |
*** openstackgerrit has quit IRC | 13:37 | |
*** openstackgerrit has joined #openstack-ironic | 13:37 | |
*** jdob has joined #openstack-ironic | 13:43 | |
openstackgerrit | Alexandra Fomina proposed a change to openstack/python-ironicclient: Use improved exceptions functionality from Oslo https://review.openstack.org/60528 | 13:47 |
*** rongze_ has quit IRC | 13:48 | |
openstackgerrit | Alexandra Fomina proposed a change to openstack/python-ironicclient: Import exceptions functionality from Oslo https://review.openstack.org/60528 | 13:50 |
*** pleia2 has quit IRC | 14:07 | |
*** linggao has quit IRC | 14:08 | |
*** pleia2 has joined #openstack-ironic | 14:09 | |
*** jdob has quit IRC | 14:10 | |
*** viktors has left #openstack-ironic | 14:11 | |
openstackgerrit | Alexandra Fomina proposed a change to openstack/python-ironicclient: Import exceptions functionality from Oslo https://review.openstack.org/60528 | 14:17 |
*** rongze has joined #openstack-ironic | 14:23 | |
*** jdob has joined #openstack-ironic | 14:23 | |
*** rloo has joined #openstack-ironic | 14:27 | |
*** jcooley_ has joined #openstack-ironic | 14:32 | |
*** jcooley_ has quit IRC | 14:36 | |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Clean up duplicated change-building code in objects https://review.openstack.org/61143 | 14:56 |
NobodyCam | good morning iRonic | 15:03 |
*** jdob_ has joined #openstack-ironic | 15:13 | |
*** jdob has quit IRC | 15:13 | |
openstackgerrit | Alexandra Fomina proposed a change to openstack/python-ironicclient: Import exceptions functionality from Oslo https://review.openstack.org/60528 | 15:21 |
*** jdob_ has quit IRC | 15:29 | |
*** jdob has joined #openstack-ironic | 15:29 | |
*** rongze_ has joined #openstack-ironic | 15:39 | |
*** rongze has quit IRC | 15:40 | |
*** lucas-hungry is now known as lucasagomes | 15:42 | |
lucasagomes | romcheg, pong sorry for the delay | 15:42 |
lucasagomes | morning NobodyCam | 15:42 |
romcheg | Morning lucasagomes NobodyCam | 15:42 |
romcheg | I was about to drink some coffee | 15:43 |
romcheg | brb | 15:43 |
NobodyCam | good morning lucasagomes | 15:43 |
*** rongze_ has quit IRC | 15:43 | |
NobodyCam | morning romcheg | 15:43 |
yuriyz | Morning all | 15:46 |
NobodyCam | morning yuriyz | 15:46 |
lucasagomes | morning yuriyz | 15:48 |
*** linggao has joined #openstack-ironic | 15:48 | |
romcheg | lucasagomes, NobodyCam: Can you please take a look at https://review.openstack.org/#/c/53917/ | 15:51 |
romcheg | *at the last comment | 15:51 |
romcheg | What do you think? | 15:52 |
romcheg | imo we don't need that because afrer Ironic graduates incubation it will be added to general devstack jobs. | 15:53 |
*** urulama has quit IRC | 15:55 | |
lucasagomes | romcheg, right, I'm not expert in it, but I think it's grand as well. Also we could add those templates later on if needed | 15:55 |
*** lexx has joined #openstack-ironic | 15:57 | |
NobodyCam | romcheg: ya I dont see a issuse adding later | 15:58 |
NobodyCam | which we will have to do i subspect | 15:58 |
romcheg | I planned to configure Ironic to be installed by default after nomination to core projects | 15:59 |
NobodyCam | :) sweet | 15:59 |
lucasagomes | NobodyCam, do you think that, in the future we should be able to unprovision a node? | 16:03 |
* lucasagomes almost finishing the deploy trigger, so I want to make sure we can incorporate future changes w/o changing the interface as well | 16:04 | |
*** vkozhukalov has quit IRC | 16:05 | |
*** jcooley_ has joined #openstack-ironic | 16:06 | |
devananda | morning, all | 16:09 |
NobodyCam | lucasagomes: ??? yes we will need to unporvision a node | 16:09 |
NobodyCam | morning devananda | 16:09 |
lucasagomes | NobodyCam, :) | 16:09 |
romcheg | Morning devananda | 16:09 |
NobodyCam | :-p | 16:09 |
lucasagomes | just confirming, so I can do the right thing | 16:09 |
lucasagomes | devananda, morning | 16:09 |
yuriyz | Morning devananda | 16:09 |
NobodyCam | :) | 16:09 |
*** mdurnosvistov has quit IRC | 16:11 | |
devananda | romcheg: there is some chicken & egg problem which you may be seeing -- folks want ironic tested before graduation, but it can't be added to main jobs until after graduation | 16:11 |
NobodyCam | brb | 16:12 |
*** jistr has quit IRC | 16:16 | |
*** jcooley_ has quit IRC | 16:16 | |
yuriyz | devananda, now pyghmi driver supports only *power, *bootdev methods and consoles. Should it to be extended for sensors etc.? What do you think? | 16:17 |
*** jcooley_ has joined #openstack-ironic | 16:17 | |
devananda | yuriyz: yes | 16:17 |
yuriyz | agree | 16:17 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add trigger to start provisioning the node https://review.openstack.org/61160 | 16:18 |
devananda | linggao: ping ^^ | 16:18 |
*** lexx has quit IRC | 16:19 | |
devananda | yuriyz: i think Haomeng was starting on some of the ceilometer work | 16:20 |
devananda | lucasagomes: i figured you'd comment on lots of things in my fix-api-autodoc patch :) | 16:23 |
lucasagomes | devananda, hehe | 16:23 |
devananda | lucasagomes: I thought about just multi-lining everything, without adding any :param: lines, which would *just* fix the formatting but nothing else | 16:23 |
devananda | i agree that updating all the param names to be more consistent is A Good Thing | 16:24 |
devananda | just didnt feel like doing that at what, 7pm last night ;) | 16:24 |
lucasagomes | devananda, I see, although it's a good oportunity to make the params more consistent | 16:24 |
lucasagomes | hehe its grand | 16:24 |
*** ifarkas has quit IRC | 16:33 | |
*** jcooley_ has quit IRC | 16:40 | |
*** jcooley_ has joined #openstack-ironic | 16:40 | |
*** jcooley_ has quit IRC | 16:45 | |
devananda | lucasagomes: on PatchType, what do you think of how often validate_attrs is being called? | 16:56 |
devananda | comments posted | 16:59 |
lucasagomes | devananda, sorry for the delay, lemme take a look at the comments | 17:00 |
*** max_lobur is now known as max_lobur_afk | 17:10 | |
*** romcheg has quit IRC | 17:16 | |
*** lexx has joined #openstack-ironic | 17:19 | |
*** mdurnosvistov has joined #openstack-ironic | 17:23 | |
*** blamar has joined #openstack-ironic | 17:35 | |
*** rloo has quit IRC | 17:35 | |
*** blamar has left #openstack-ironic | 17:36 | |
NobodyCam | morning walkies. bbiafm | 17:41 |
*** jcooley_ has joined #openstack-ironic | 17:48 | |
*** jcooley_ has quit IRC | 17:50 | |
*** anniec has joined #openstack-ironic | 17:51 | |
devananda | rloo, yuriyz: I just posted comment on breaking-resource-locks based on our discussions yesterday | 17:51 |
devananda | going to untarget that blueprint | 17:51 |
*** lexx has quit IRC | 17:53 | |
*** lexx has joined #openstack-ironic | 18:05 | |
devananda | NobodyCam: https://review.openstack.org/#/c/59066/ could probably use your eyes some time | 18:08 |
* NobodyCam thats a look | 18:08 | |
NobodyCam | gah | 18:08 |
NobodyCam | takes even | 18:09 |
devananda | lucasagomes: is martyn around? | 18:10 |
*** mattray has joined #openstack-ironic | 18:12 | |
*** mattray has left #openstack-ironic | 18:13 | |
lucasagomes | devananda, apparently he's offline already, can't find him on the rh channels as well | 18:13 |
devananda | lucasagomes: ack, np. | 18:14 |
* devananda posts a comment on martyn's BP | 18:14 | |
NobodyCam | devananda: lucasagomes was there a bug for the pki token? | 18:15 |
devananda | NobodyCam: there was a blueprint for the "allow noauth in API service" | 18:15 |
devananda | NobodyCam: which I just closed, since taht approach was rejected | 18:15 |
devananda | I'm not aware of a bug specifically for the store-pki-token-on-disk | 18:16 |
lucasagomes | NobodyCam, not that I know, you talking about https://review.openstack.org/#/c/59066/? | 18:16 |
* lucasagomes reviews that patch | 18:16 | |
NobodyCam | nope, was thinking it was Public API requires authentication bug: 1221263 | 18:17 |
*** vkozhukalov has joined #openstack-ironic | 18:18 | |
NobodyCam | lucasagomes: I +2'd but did not +a as you are also reviewing | 18:18 |
lucasagomes | NobodyCam, thanks :) patch seems good, I'm just reading the previous comments to see if things were addressed | 18:19 |
devananda | Haomeng: replied to you on https://blueprints.launchpad.net/ironic/+spec/send-data-to-ceilometer | 18:22 |
openstackgerrit | A change was merged to openstack/ironic: Save PKI token in a file for PXE deploy ramdisk https://review.openstack.org/59066 | 18:25 |
NobodyCam | anyone know how to run just one test with tox | 18:25 |
NobodyCam | :-p | 18:25 |
devananda | testr run <test file or class name> | 18:26 |
devananda | but with tox? no | 18:26 |
lifeless | NobodyCam: tox -- testnameregex | 18:26 |
*** hemnafk is now known as hemna | 18:26 | |
NobodyCam | ahh -- TY lifeless | 18:26 |
*** jistr has joined #openstack-ironic | 18:26 | |
lucasagomes | lifeless, ahh great, didn't know that | 18:35 |
NobodyCam | and it works :) | 18:36 |
NobodyCam | lifeless' command not my test :-p | 18:36 |
NobodyCam | heheheh | 18:36 |
lucasagomes | I do like deva suggested, testr run ironic.tests... | 18:37 |
lucasagomes | anyway, I'm done for the day :) | 18:37 |
lucasagomes | have a good night everyone | 18:37 |
lifeless | lucasagomes: you don't need a full object path there | 18:37 |
lifeless | lucasagomes: testr takes a regex | 18:37 |
NobodyCam | have a good night lucasagomes | 18:37 |
lucasagomes | devananda, I will address the patchtype problem you pointed out tomorrow morning, thanks | 18:37 |
lucasagomes | lifeless, ahh, awesome. Lemme test it :D | 18:38 |
lucasagomes | indeed it does! good stuff :) lifeless thank u again | 18:40 |
lifeless | :) | 18:40 |
lucasagomes | g'night everyone | 18:41 |
*** lucasagomes has quit IRC | 18:41 | |
*** rloo has joined #openstack-ironic | 18:42 | |
*** viktors1 has joined #openstack-ironic | 18:44 | |
*** rloo has quit IRC | 18:44 | |
*** rloo has joined #openstack-ironic | 18:45 | |
*** rloo has quit IRC | 18:45 | |
*** rloo has joined #openstack-ironic | 18:45 | |
*** jcooley_ has joined #openstack-ironic | 18:47 | |
*** jcooley_ has quit IRC | 18:49 | |
*** tatyana has quit IRC | 18:49 | |
*** jcooley_ has joined #openstack-ironic | 18:49 | |
*** rloo has quit IRC | 18:51 | |
*** rloo has joined #openstack-ironic | 18:52 | |
*** jcooley_ has quit IRC | 18:53 | |
*** rloo has quit IRC | 18:53 | |
*** rloo has joined #openstack-ironic | 18:54 | |
*** jcooley_ has joined #openstack-ironic | 18:54 | |
*** anniec has quit IRC | 18:56 | |
*** rloo has quit IRC | 18:58 | |
*** rloo has joined #openstack-ironic | 18:58 | |
*** anniec has joined #openstack-ironic | 18:59 | |
*** jcooley_ has quit IRC | 19:02 | |
*** jcooley_ has joined #openstack-ironic | 19:07 | |
*** romcheg has joined #openstack-ironic | 19:15 | |
romcheg | NobodyCam: Are you around | 19:15 |
*** jcooley_ has quit IRC | 19:18 | |
romcheg | Or devananda :) | 19:20 |
devananda | romcheg: some discussion in #openstack-meeting that you would be interested in | 19:20 |
devananda | re tempest and infra testing | 19:21 |
romcheg | Will join now | 19:21 |
*** vetalll has joined #openstack-ironic | 19:21 | |
devananda | romcheg: tl;dr - mirantis folks also working on trove/tempest integration | 19:21 |
*** vetalll has quit IRC | 19:22 | |
devananda | romcheg: and anteaya volunteered to coordinate conversations between all the folks who are just starting to dogpile on testing the younger projects (ironic, trove, etc) | 19:22 |
romcheg | devananda: thanks | 19:22 |
*** vetalll has joined #openstack-ironic | 19:22 | |
devananda | romcheg: conversation over there now is also relevant to us :) | 19:24 |
romcheg | devananda: I just have an intern here who is trying to get familiar with openstack | 19:26 |
*** mordred has quit IRC | 19:26 | |
*** mordred has joined #openstack-ironic | 19:26 | |
romcheg | So meet vetalll | 19:26 |
romcheg | I think he can work on https://bugs.launchpad.net/ironic/+bug/1259346 this bug | 19:26 |
devananda | awesome | 19:27 |
vetalll | Hi all. | 19:27 |
devananda | probably best to take it one module at a time | 19:27 |
devananda | or module + relevant unit tests | 19:27 |
*** anniec has quit IRC | 19:27 | |
*** anniec has joined #openstack-ironic | 19:29 | |
vetalll | devananda: Can you please point me to the samples of the code that need to be rework. | 19:29 |
devananda | vetalll: all interfaces in here http://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/base.py | 19:30 |
devananda | vetalll: and all the classes which derive from them | 19:30 |
devananda | vetalll: reason is that the TaskManager object (http://git.openstack.org/cgit/openstack/ironic/tree/ironic/conductor/task_manager.py) contains the node(s) and all relevant port(s) already | 19:30 |
devananda | vetalll: so we do not need to pass the node separately | 19:31 |
devananda | vetalll: one thing to keep in mind, which is not yet very consistent in the code, is that a TaskManager may contain references to one or more nodes. | 19:31 |
devananda | there are tricks to allow easy access for single-node tasks: http://git.openstack.org/cgit/openstack/ironic/tree/ironic/conductor/task_manager.py#n144 | 19:32 |
vetalll | ok | 19:32 |
vetalll | devananda: Thanks, i will poke romcheg or you for some help if I need it. | 19:33 |
devananda | vetalll: great! and welcome to the team :) | 19:34 |
vetalll | Thanks. | 19:35 |
devananda | vetalll: also, please assign the bug to yourself | 19:37 |
anteaya | devananda romcheg no meeting for tempest, sdague would like contributors to be in #openstack-qa | 19:44 |
anteaya | romcheg: please join #openstack-qa | 19:44 |
devananda | vkozhukalov: ^ | 19:44 |
*** lexx has quit IRC | 19:51 | |
*** jcooley_ has joined #openstack-ironic | 19:53 | |
*** viktors1 has quit IRC | 19:54 | |
*** jcooley_ has quit IRC | 20:04 | |
*** anniec has quit IRC | 20:10 | |
*** jcooley_ has joined #openstack-ironic | 20:10 | |
*** jcooley_ has quit IRC | 20:11 | |
* NobodyCam looks for some food stuffs | 20:13 | |
*** jcooley_ has joined #openstack-ironic | 20:13 | |
*** jcooley_ has quit IRC | 20:16 | |
*** jcooley_ has joined #openstack-ironic | 20:19 | |
*** jistr has quit IRC | 20:25 | |
*** vetalll has quit IRC | 20:30 | |
*** jcooley_ has quit IRC | 20:31 | |
*** jcooley_ has joined #openstack-ironic | 20:31 | |
NobodyCam | brb | 20:34 |
*** jcooley_ has quit IRC | 20:36 | |
*** rloo has quit IRC | 20:41 | |
*** rloo has joined #openstack-ironic | 20:41 | |
*** rloo has quit IRC | 20:43 | |
*** rloo has joined #openstack-ironic | 20:44 | |
*** anniec has joined #openstack-ironic | 20:52 | |
*** vetalll has joined #openstack-ironic | 20:53 | |
devananda | mordred: question trailing out of the TC discussion -- what does "Project must use OpenStack task, defect and design tracker(s)" mean? | 21:01 |
mordred | devananda: launchpad, or whatever else we may decide to move to | 21:01 |
mordred | devananda: such as - you can't store your crap in github just because you like it in your neckbeardhole | 21:02 |
devananda | gotcha | 21:02 |
devananda | thanks | 21:02 |
mordred | I just said neckbeardhole | 21:02 |
*** romcheg has quit IRC | 21:03 | |
*** anniec has quit IRC | 21:03 | |
devananda | you did | 21:03 |
devananda | NobodyCam: something worth reading - https://review.openstack.org/#/c/59454/2/reference/incubation-integration-requirements | 21:03 |
devananda | i added it to our agenda for next week | 21:04 |
* NobodyCam looks | 21:04 | |
devananda | we need to grow our core review team | 21:04 |
NobodyCam | mordred: devananda: what is 'reasonably' in ** Project APIs should be reasonably stable | 21:07 |
devananda | heh | 21:08 |
mordred | NobodyCam: they are guidelines - whatever the TC thinks they are | 21:08 |
devananda | NobodyCam: when we stop breaking our v1 API. | 21:08 |
devananda | and start creating v2 :) | 21:08 |
NobodyCam | hehehehe | 21:08 |
*** kui has joined #openstack-ironic | 21:20 | |
NobodyCam | good morning kui | 21:23 |
kui | NobodyCam: Good afternoon | 21:23 |
NobodyCam | :) | 21:25 |
*** lexx has joined #openstack-ironic | 21:28 | |
devananda | NobodyCam: ever gotten "Error: unsupported option i386." from step 1 on http://docs.openstack.org/developer/tripleo-incubator/devtest_seed.html | 21:29 |
kui | NobodyCam: The wiki page https://wiki.openstack.org/wiki/Ironic#Using_Disk_Image_Builder is the latest, right ? | 21:29 |
*** jcooley_ has joined #openstack-ironic | 21:30 | |
NobodyCam | devananda: no | 21:30 |
NobodyCam | kui: should be pritty up to date | 21:30 |
NobodyCam | devananda: can you paste the error? | 21:30 |
NobodyCam | kui: found anything that looks like fun to jump in on? | 21:31 |
devananda | NobodyCam: that is the error | 21:34 |
kui | NobodyCam: No specific, I want to get feet wet first, then I will find one. | 21:35 |
*** anniec has joined #openstack-ironic | 21:36 | |
NobodyCam | devananda: from the sed command? | 21:36 |
NobodyCam | or boot seed | 21:36 |
devananda | NobodyCam: build seed | 21:37 |
devananda | er, boot-seed-vm | 21:37 |
NobodyCam | https://github.com/openstack/tripleo-incubator/blob/master/scripts/boot-seed-vm -a appers to be a valid option still | 21:37 |
devananda | right | 21:39 |
*** vetalll has quit IRC | 21:40 | |
NobodyCam | https://github.com/openstack/tripleo-incubator/blob/master/scripts/boot-seed-vm#L83 is there a "-a" | 21:41 |
*** kui has quit IRC | 21:41 | |
*** kui has joined #openstack-ironic | 21:41 | |
NobodyCam | kui: if you have any questions please don't hesitate to ask!! | 21:42 |
kui | NobodyCam: Thanks ;) | 21:44 |
NobodyCam | devananda: https://github.com/openstack/tripleo-incubator/blob/master/scripts/boot-seed-vm#L103-107 ... should catch anything with arch | 21:49 |
*** jdob has quit IRC | 21:52 | |
*** anniec has quit IRC | 21:53 | |
dkehn | devananda: this is referring to the comment last night about the node.driver_info comment, and your comments, at this point does the pxe._get_pxe_bootfile_name(instance_uuid) need to be moved | 21:54 |
devananda | dkehn: the comments were about whether the value of pxe_bootfile_name should be a CONF option or a node property | 21:57 |
devananda | dkehn: for now, it should stay a CONF option | 21:57 |
dkehn | devananda: agreed, then I'll leave the accessor where it is | 21:59 |
*** linggao has quit IRC | 22:01 | |
devananda | i need to step away for an hour or so... bbl | 22:02 |
*** anniec has joined #openstack-ironic | 22:02 | |
*** mdurnosvistov has quit IRC | 22:09 | |
*** rloo has quit IRC | 22:09 | |
*** lexx_ has joined #openstack-ironic | 22:09 | |
*** rloo has joined #openstack-ironic | 22:09 | |
*** rloo has quit IRC | 22:10 | |
*** rloo has joined #openstack-ironic | 22:11 | |
*** lexx has quit IRC | 22:11 | |
*** lexx_ has quit IRC | 22:15 | |
*** datajerk has quit IRC | 22:19 | |
*** lexx has joined #openstack-ironic | 22:27 | |
*** epim has joined #openstack-ironic | 22:28 | |
*** rloo has quit IRC | 22:31 | |
*** rloo has joined #openstack-ironic | 22:31 | |
*** jcooley_ has quit IRC | 22:34 | |
*** jcooley_ has joined #openstack-ironic | 22:34 | |
*** michchap has joined #openstack-ironic | 22:35 | |
*** michchap has quit IRC | 22:35 | |
*** derekh has quit IRC | 22:36 | |
*** michchap has joined #openstack-ironic | 22:36 | |
*** jcooley_ has quit IRC | 22:38 | |
*** epim has quit IRC | 22:47 | |
*** epim has joined #openstack-ironic | 23:02 | |
*** jcooley_ has joined #openstack-ironic | 23:05 | |
*** jcooley_ has quit IRC | 23:08 | |
*** jcooley_ has joined #openstack-ironic | 23:08 | |
kui | NobodyCam: hello | 23:09 |
NobodyCam | hey kui :) | 23:09 |
kui | NobodyCam: I encounter the same error as deva, and I find the root cause in boot-seed-vm | 23:10 |
kui | getopt -o hcna:o:s:b:e: -l use-existing-vm -n boot-seed-vm -- -a i386 ubuntu neutron-dhcp-agent | 23:10 |
kui | getopt -o ihcna:o:s:b:e: -l use-existing-vm -n boot-seed-vm -- -a i386 ubuntu neutron-dhcp-agent | 23:10 |
kui | In boot-seed-vm, there is a change in the latest commit, add "-i" opiton | 23:11 |
kui | the order of getopt output is changed, | 23:11 |
NobodyCam | ahh nice | 23:11 |
kui | If you are not looking it, I will file a bug to fix it. | 23:12 |
*** jcooley_ has quit IRC | 23:12 | |
NobodyCam | https://github.com/openstack/tripleo-incubator/commit/444c63128d0354c97d66a3bb5b8e23ea39633bbb | 23:12 |
NobodyCam | one sec | 23:13 |
NobodyCam | let me ask in OoO | 23:13 |
kui | Yes, it is the commit inducing the error. | 23:14 |
kui | -TEMP=`getopt -o hcna:o:s:b:e: -l use-existing-vm -n $SCRIPT_NAME -- "$@"` | 23:14 |
kui | +TEMP=`getopt -o hcnai:o:s:b:e: -l use-existing-vm -n $SCRIPT_NAME -- "$@"` | 23:14 |
kui | change to following order will resolve it. | 23:14 |
kui | getopt -o ihcna:o:s:b:e: -l use-existing-vm -n boot-seed-vm -- -a i386 ubuntu neutron-dhcp-agent | 23:14 |
kui | OK, waiting for OoO feedback. | 23:15 |
NobodyCam | I've asked in OoO | 23:17 |
NobodyCam | see if any one is around | 23:17 |
NobodyCam | what time is it there? | 23:17 |
devananda | kui: confirmed that fixes it | 23:18 |
NobodyCam | wb devananda | 23:18 |
NobodyCam | :-p | 23:18 |
devananda | kui: do you want to file bug & fix, or shall I? | 23:18 |
*** jcooley_ has joined #openstack-ironic | 23:18 | |
kui | devananda: sure, I will do it now. | 23:19 |
*** epim has quit IRC | 23:19 | |
NobodyCam | awesome ty kui | 23:19 |
kui | :) | 23:19 |
devananda | kui: thanks. let me know the bug # and I'll add comment | 23:19 |
kui | devananda: OK | 23:19 |
*** jcooley_ has quit IRC | 23:22 | |
*** jcooley_ has joined #openstack-ironic | 23:22 | |
NobodyCam | brb | 23:25 |
*** datajerk has joined #openstack-ironic | 23:27 | |
NobodyCam | back | 23:27 |
*** epim has joined #openstack-ironic | 23:28 | |
kui | devananda: Bug is filed: https://bugs.launchpad.net/tripleo/+bug/1259740 | 23:29 |
*** jcooley_ has quit IRC | 23:30 | |
*** epim has quit IRC | 23:30 | |
*** jcooley_ has joined #openstack-ironic | 23:30 | |
devananda | kui: bug is now triaged :) | 23:30 |
NobodyCam | very nice. detailed :) | 23:30 |
kui | ;) | 23:31 |
NobodyCam | kui: as you list a fix in the report you should file a patch :) | 23:31 |
devananda | patch will probably get merged pretty quickly, since it will be a single line change | 23:32 |
kui | NobodyCam: I'm doing it | 23:32 |
NobodyCam | great | 23:32 |
*** epim has joined #openstack-ironic | 23:34 | |
*** epim has quit IRC | 23:34 | |
*** jcooley_ has quit IRC | 23:35 | |
*** jcooley_ has joined #openstack-ironic | 23:37 | |
kui | https://review.openstack.org/61271 | 23:38 |
kui | devananda, NobodyCam, review is online | 23:38 |
devananda | kui: thanks much | 23:39 |
*** datajerk has quit IRC | 23:41 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/60972 | 23:41 |
*** epim has joined #openstack-ironic | 23:43 | |
*** jcooley_ has quit IRC | 23:44 | |
*** jcooley_ has joined #openstack-ironic | 23:44 | |
*** jcooley_ has quit IRC | 23:44 | |
*** jcooley_ has joined #openstack-ironic | 23:45 | |
openstackgerrit | Jenkins proposed a change to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/60982 | 23:45 |
devananda | kui: you'll need to rebase your patch to tripleo-incubator. it looks like a common dependency broke, hence the flood of Jenkins-proposed-a-change to all the projects | 23:49 |
kui | devananda: it the sphinx issue, a fix is in review: https://review.openstack.org/61274 | 23:50 |
devananda | yep | 23:50 |
*** michchap_ has joined #openstack-ironic | 23:53 | |
*** jcooley_ has quit IRC | 23:53 | |
*** jcooley_ has joined #openstack-ironic | 23:54 | |
*** michchap has quit IRC | 23:57 | |
*** jcooley_ has quit IRC | 23:58 | |
*** jcooley_ has joined #openstack-ironic | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!