| *** rongze has quit IRC | 00:00 | |
| *** jcooley_ has joined #openstack-ironic | 00:01 | |
| *** jcooley_ has quit IRC | 00:06 | |
| *** epim has quit IRC | 00:07 | |
| *** matsuhashi has joined #openstack-ironic | 00:12 | |
| *** epim has joined #openstack-ironic | 00:19 | |
| dkehn | NobodyCam: u around | 00:21 |
|---|---|---|
| dkehn | whne running the generate_sample.py what env must be there for it to work, running ./tools/conf/generate_sample.sh | 00:24 |
| dkehn | devananda: ^^^^^ | 00:25 |
| dkehn | the error I'm seeing is RuntimeError: Unable to import module ironic.api.app | 00:26 |
| dkehn | ok, nevermind I'm debugging it , no modeule named pecan | 00:32 |
| NobodyCam | :) hey dkehn | 00:55 |
| NobodyCam | didn't see your question | 00:56 |
| NobodyCam | woo hoo http://paste.openstack.org/show/eQ0aE48buiBznC5DbU2h/ | 00:58 |
| *** rloo has quit IRC | 01:16 | |
| *** nosnos has joined #openstack-ironic | 01:20 | |
| dkehn | NobodyCam: nevermind, I'm adding a little better error message to indicate the actual lib that is missing | 01:25 |
| NobodyCam | pip install /path/to/ironic/dir | 01:26 |
| *** rongze has joined #openstack-ironic | 01:26 | |
| NobodyCam | dkehn: also https://github.com/NoBodyCam/ironic-element | 01:27 |
| NobodyCam | bbiab | 01:28 |
| *** urulama has joined #openstack-ironic | 01:31 | |
| *** rongze has quit IRC | 01:31 | |
| *** sjing has joined #openstack-ironic | 01:31 | |
| openstackgerrit | A change was merged to openstack/ironic: Allow FakePower to return node objects power_state https://review.openstack.org/58333 | 01:32 |
| *** matsuhashi has quit IRC | 01:34 | |
| *** urulama has quit IRC | 01:35 | |
| devananda | dkehn: just create teh venv and then run it | 01:36 |
| devananda | dkehn: tox -e venv -- echo 'done' | 01:36 |
| dkehn | devananda: figured it out, added a bit of a finer granularity for the report of import error | 01:37 |
| dkehn | devananda: actually the module missing isn't in either the requirements.txt or the test-requirements.txt (pecan) | 01:38 |
| *** arata has joined #openstack-ironic | 01:39 | |
| *** matsuhashi has joined #openstack-ironic | 01:51 | |
| devananda | dkehn: what module is missing? | 02:04 |
| devananda | dkehn: and where are you getting the import error? | 02:05 |
| dkehn | devananda: pecan, qpid-python, eventlet.green.zmq | 02:05 |
| devananda | dkehn: requirements.txt:pecan>=0.2.0 | 02:05 |
| devananda | dkehn: requirements.txt:amqplib>=0.6.1 | 02:05 |
| dkehn | devananda: hmm, I ran the sudo pip install -r .... , something is up | 02:06 |
| dkehn | in my env | 02:06 |
| devananda | dkehn: what commands are you running // what is your environment? | 02:06 |
| devananda | dkehn: did you create the virtual env? | 02:06 |
| dkehn | no env really, letting the gnerate_sample.sh setup it | 02:06 |
| devananda | eh? | 02:07 |
| dkehn | nope | 02:07 |
| devananda | generate_sample.sh doesn't create an environment | 02:07 |
| devananda | it requires a venv | 02:07 |
| devananda | dkehn: run this: | 02:08 |
| dkehn | hmm, interesting, I don't rement runing in a venv when generating for nova or neutron, maybe forgot | 02:08 |
| devananda | tox -evenv -- echo 'done' | 02:08 |
| dkehn | got it | 02:08 |
| devananda | source .tox/venv/bin/activate | 02:08 |
| devananda | tools/conf/generate_sample.sh | 02:08 |
| devananda | deactivate | 02:08 |
| dkehn | yes, this is new | 02:08 |
| devananda | yep :) | 02:08 |
| devananda | ironic is a new project. we did some things differently | 02:09 |
| dkehn | getting into a venv to gnerate | 02:09 |
| dkehn | ok ok | 02:09 |
| *** rongze has joined #openstack-ironic | 02:09 | |
| *** arata has quit IRC | 02:12 | |
| *** michchap has quit IRC | 02:18 | |
| dkehn | devananda: here is my complete run: http://paste.openstack.org/show/54031/ | 02:21 |
| Haomeng | dkehn: this is odd | 02:24 |
| Haomeng | dkehn: what is your os, redhat? | 02:24 |
| Haomeng | dkehn: why qpid is used? | 02:24 |
| dkehn | devananda: this is a vm I've used for nova an neutron dev, maybe time for a fresh vm | 02:25 |
| Haomeng | dkehn: by default, it should be rabbit | 02:25 |
| dkehn | Haomeng: ubuntu | 02:25 |
| Haomeng | dkehn: ok, let me show you my steps, it works as well without any error message | 02:25 |
| dkehn | Haomeng: k | 02:25 |
| devananda | dkehn: yea, this is rather odd | 02:26 |
| Haomeng | dkehn: you can follow this steps - http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 02:26 |
| devananda | dkehn: do you have real config files in /etc/ ? | 02:26 |
| dkehn | devananda: yes | 02:27 |
| Haomeng | dkehn: and suggest you create new folder to git clone again and have try these steps again | 02:27 |
| devananda | dkehn: also, if you are trying to actually test _using_ ironic with neutron, you probably want NobodyCam's disk-image-builder elements | 02:27 |
| devananda | dkehn: ok. so your global config files are probably (somehow) conflicting with Ironic. why are you trying to generate a new sample config anyway? | 02:28 |
| dkehn | devananda: actually I'm just trying to add the dhcp_option in the pxe.py which caused a cfg option so gnerally you need to re-generate the sample, and thats what I was trying to do | 02:28 |
| devananda | dkehn: instead of just using the existing sample config | 02:28 |
| dkehn | devananda: I think its worth generating a fresh vm for this | 02:29 |
| devananda | ah | 02:29 |
| devananda | dkehn: yea, if you're just doing some dev on ironic -- and you dont need to have neutron, nova, etc in teh same VM -- then a fresh VM is the way to go | 02:29 |
| devananda | dkehn: when you're ready to test with all those things too, use NobodyCam's dib elements. it'll build all that into an image for you :) | 02:30 |
| dkehn | devananda: yeah I was jsut using a dev vm that I used for a bunch of other stuff, my bad | 02:30 |
| devananda | dkehn: i'm really curious now what conflicted! (but dont need to take up your time digging into it) | 02:30 |
| dkehn | devananda: I think for the time being I'll create another vm, and get this in, then move on to the neutron part | 02:31 |
| dkehn | thanks all | 02:31 |
| Haomeng | dkehn: welcome | 02:33 |
| *** jbjohnso has quit IRC | 02:41 | |
| *** epim has quit IRC | 02:51 | |
| *** matsuhashi has quit IRC | 03:00 | |
| *** prekarat has joined #openstack-ironic | 03:12 | |
| *** dguitarbite has joined #openstack-ironic | 03:15 | |
| *** dguitarbite has quit IRC | 03:22 | |
| *** prekarat has quit IRC | 03:25 | |
| *** arata has joined #openstack-ironic | 03:27 | |
| *** urulama has joined #openstack-ironic | 03:32 | |
| *** urulama has quit IRC | 03:36 | |
| *** dguitarbite has joined #openstack-ironic | 03:38 | |
| *** vkozhukalov has joined #openstack-ironic | 03:55 | |
| *** arata has left #openstack-ironic | 03:57 | |
| *** prekarat has joined #openstack-ironic | 04:00 | |
| *** prekarat has quit IRC | 04:02 | |
| *** prekarat has joined #openstack-ironic | 04:04 | |
| *** mihgen has joined #openstack-ironic | 04:06 | |
| *** matsuhashi has joined #openstack-ironic | 04:23 | |
| *** jcooley_ has joined #openstack-ironic | 04:30 | |
| *** vkozhukalov has quit IRC | 04:42 | |
| *** rongze has quit IRC | 04:48 | |
| *** vkozhukalov has joined #openstack-ironic | 04:55 | |
| *** rongze has joined #openstack-ironic | 05:18 | |
| *** rongze has quit IRC | 05:27 | |
| *** michchap has joined #openstack-ironic | 05:34 | |
| *** sjing has quit IRC | 05:40 | |
| *** sjing has joined #openstack-ironic | 05:42 | |
| *** jcooley_ has quit IRC | 05:59 | |
| *** jcooley_ has joined #openstack-ironic | 05:59 | |
| openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/58438 | 06:00 |
| *** jcooley_ has quit IRC | 06:05 | |
| zigo | I have a problem with ironic-dbsync: http://paste.debian.net/67973/ | 06:08 |
| zigo | What can I do to fix it? Is this known from you guys? | 06:08 |
| *** vkozhukalov has quit IRC | 06:09 | |
| Haomeng | zigo: ok, let me check | 06:09 |
| Haomeng | zigo: do you use latest code? | 06:10 |
| zigo | Haomeng: FYI, I'm packaging from 20131125 (2 days ago for me), commit sha256 e94e918589 | 06:10 |
| zigo | Haomeng: I could get latest version from today if you think there was some fixes since... | 06:10 |
| Haomeng | zigo: no, just think about if this is latest code issue or old issue | 06:11 |
| Haomeng | zigo: can you help to check /usr/lib/python2.7/dist-packages/ironic/db/sqlalchemy/migrate_repo folder files | 06:12 |
| zigo | Haomeng: Are you in China (with this kind of name...)? | 06:12 |
| Haomeng | zigo: yes, I am Chinese | 06:13 |
| Haomeng | zigo: :) | 06:13 |
| *** rongze has joined #openstack-ironic | 06:13 | |
| zigo | Haomeng: 我在郑州! :) | 06:13 |
| zigo | (though I'm French...) | 06:13 |
| Haomeng | zigo: looks like my IRC can not display Chinese chars | 06:13 |
| zigo | Haomeng: Which town are you in? | 06:13 |
| Haomeng | zigo: welcome | 06:13 |
| zigo | I'm in Zhengzhou. | 06:14 |
| Haomeng | zigo: In Beijing now, my hometown is JiLin | 06:14 |
| Haomeng | zigo: great | 06:14 |
| zigo | ls /usr/lib/python2.7/dist-packages/ironic/db/sqlalchemy/migrate_repo | 06:14 |
| zigo | __init__.py __init__.pyc manage.py manage.pyc versions | 06:14 |
| Haomeng | zigo: looks like this is IMPL.db_sync issue | 06:14 |
| Haomeng | can not find IPMI in migrate_repo | 06:15 |
| Haomeng | zigo: 2013-11-27 05:58:24.546 7943 TRACE ironic return IMPL.db_sync(version=version) | 06:15 |
| zigo | Right. | 06:15 |
| Haomeng | zigo: IMPL | 06:15 |
| Haomeng | not IPMI | 06:15 |
| zigo | You've been typing too many times "IPMI" I guess... :P :D | 06:16 |
| Haomeng | zigo: :) | 06:16 |
| zigo | So, what's the fix, any idea? | 06:16 |
| Haomeng | zigo: how about French? | 06:16 |
| Haomeng | zigo: have to check code - "/usr/lib/python2.7/dist-packages/migrate/versioning/repository.py" | 06:16 |
| Haomeng | zigo: exceptions.InvalidRepositoryError | 06:17 |
| Haomeng | to see why this exception | 06:17 |
| Haomeng | File "/usr/lib/python2.7/dist-packages/migrate/versioning/repository.py", line 98, in verify | 06:17 |
| zigo | Right. | 06:17 |
| Haomeng | zigo: these are not Ironic code | 06:18 |
| zigo | That's sqlalchemy-migrate... | 06:19 |
| Haomeng | zigo: it just checking Ironic File "/usr/lib/python2.7/dist-packages/migrate/versioning/repository.py", line 98, in verify | 06:19 |
| zigo | Haomeng: Is there a chance that you guys are testing with the latest version of that? | 06:19 |
| Haomeng | zigo: checking migrate_repo | 06:19 |
| zigo | I mean, I'm still running with sqlalchemy-migrate 0.7.x, the package hasn't been updated to 0.8.x | 06:19 |
| Haomeng | zigo: sure, let me have a try | 06:19 |
| Haomeng | zigo: to see if it can be recrated and debug it | 06:20 |
| zigo | Cool, thanks. | 06:20 |
| zigo | It's on my todo list to upgrade python-migrate in Debian anyway, but it would be good to know if that's the problem (so we can effectively fix the requirements.txt of Ironic). | 06:20 |
| devananda | Haomeng: it looks like https://review.openstack.org/#/c/53627/ just expired - you can revive the patch in the gerrit UI before submitting another revision | 06:20 |
| Haomeng | devananda: ok, thank you | 06:21 |
| Haomeng | devananda: so far, I still can not debug out the root cause of "why node.patch_json() isn't populating node.updated_at", maybe it is handled by conductor, but our unittest will mock conductor api I think | 06:22 |
| devananda | zigo: interesting error. what back end are you using (sqlite? mysql?) | 06:24 |
| zigo | MySQL | 06:24 |
| devananda | zigo: and things are configured with valid host, user, pass, etc in ironic.conf? | 06:24 |
| devananda | i would expect different error if not, but just asking anyway | 06:24 |
| zigo | devananda: Yup, it's been configured automatically by dbconfig-common in my package. | 06:25 |
| devananda | "in my package" -- please explain | 06:25 |
| zigo | devananda: I'm the Debian maintainer of OpenStack, I'm trying to package Ironic for Debian here! :) | 06:26 |
| devananda | oooh! | 06:26 |
| devananda | hi! :) | 06:26 |
| zigo | When installing ironic-common, the database is created automatically, and connection = is set with the values configured by dbconfig-common. | 06:27 |
| devananda | zigo: yep yep. makes sense now. | 06:27 |
| zigo | By the way, it'd be nice if you were using sql_connection rather than connection which only Keystone uses. | 06:27 |
| zigo | (but never mind, not important...) | 06:27 |
| devananda | at least in my local copy, here's the relevant snippet | 06:28 |
| devananda | http://paste.debian.net/67975/ | 06:28 |
| Haomeng | zigo: I think the issue is that your db is not sync with your Repository | 06:28 |
| Haomeng | devananda: yes, it is this Repository | 06:29 |
| Haomeng | devananda: InvalidRepositoryError | 06:29 |
| devananda | Haomeng: it's really a PathNotFound error | 06:29 |
| Haomeng | devananda: except exceptions.PathNotFoundError | 06:30 |
| Haomeng | devananda: yes | 06:30 |
| *** nosnos_ has joined #openstack-ironic | 06:30 | |
| Haomeng | zigo: can you help to run "ls /usr/lib/python2.7/dist-packages/ironic/db/sqlalchemy/migrate_repo/versions" | 06:31 |
| devananda | zigo: i'm hesitating asking why you're packaging Ironic for Debian when a) we're still in incubation, and b) I haven't officially tagged any releases yet | 06:31 |
| devananda | zigo: more out of curiousity about such things than anything -- i'm actually thrilled that you are looking at this :) | 06:31 |
| Haomeng | zigo: yes, it is better that we use ubuntu | 06:31 |
| Haomeng | zigo: we did not test with Debian I think | 06:32 |
| devananda | zigo: also, fwiw, Nova uses "connection=" | 06:33 |
| zigo | http://paste.debian.net/67976/ <--- Output of ls | 06:33 |
| Haomeng | zigo: looks fine, the files are there as well | 06:33 |
| zigo | devananda: I would like to have both Ironic and TrippleO ready in time for the first Icehouse release (eg: icehouse-1). | 06:34 |
| *** nosnos has quit IRC | 06:34 | |
| zigo | devananda: There's no other ways but to do it *now* before the release happens. | 06:34 |
| devananda | zigo: gotcha. Ironic probably wont' be functional by then, FYI | 06:35 |
| zigo | devananda: For sure, both TrippleO and Ironic are the most interesting incubating projects right now as well... | 06:35 |
| devananda | by functional I mean, you won't be able to configure nova with an "ironic" driver and say "nova boot ..." and have ironic do all the things | 06:35 |
| devananda | that baremetal driver can do today | 06:35 |
| zigo | devananda: Doesn't mater, I intend to also do some continuous integration at some point, that'd be a nice way for you guys to test it out for real. | 06:35 |
| devananda | zigo: awesome | 06:35 |
| devananda | zigo: yea, i'm happy to get all the packaging and release stuff lined up earlier. we're aiming for I-2 feature parity | 06:36 |
| devananda | so having this stuff squared now is great | 06:36 |
| zigo | You mean parity with nova-baremetal? | 06:36 |
| devananda | yes | 06:36 |
| zigo | Kewl! :) | 06:36 |
| devananda | at a minimum, we should be able to drive deployments with PXE and all that | 06:37 |
| Haomeng | zigo: what user you use to run ironic-dbsync | 06:38 |
| Haomeng | zigo: not sure if there is permision issue | 06:38 |
| zigo | Haomeng: Root user. | 06:38 |
| zigo | (since that's from the postinst script) | 06:38 |
| Haomeng | zigo: root is ok:) | 06:38 |
| zigo | I tried as root from the shell as well. | 06:38 |
| Haomeng | zigo: can you help to run sql "select * from migrate_version" to check your db current versions | 06:40 |
| Haomeng | zigo: mysql -uroot -pYOURPASSWORD | 06:40 |
| zigo | Nop, mysql --defaults-file=/etc/mysql/debian.cnf ! :) | 06:41 |
| Haomeng | zigo: then "use ironic" | 06:41 |
| zigo | # mysql --defaults-file=/etc/mysql/debian.cnf -D ironic -e "select * from migrate_version" | 06:41 |
| zigo | ERROR 1049 (42000): Unknown database 'ironic' | 06:41 |
| zigo | Woops! | 06:41 |
| zigo | Let me check for that. | 06:42 |
| zigo | Maybe this was my bad... | 06:42 |
| Haomeng | zigo: grep sql_connec /etc/ironic/ironic.conf | 06:42 |
| zigo | Ah no... | 06:42 |
| Haomeng | zigo: if there is no such ironic | 06:42 |
| Haomeng | zigo: database, have to create it before run ironic_dbsync | 06:42 |
| Haomeng | zigo: no problem:) | 06:43 |
| zigo | # mysql --defaults-file=/etc/mysql/debian.cnf -D ironicdb -e "select * from migrate_version" | 06:43 |
| zigo | ERROR 1146 (42S02) at line 1: Table 'ironicdb.migrate_version' doesn't exist | 06:43 |
| devananda | zigo: s/ironicdb/ironic/ | 06:43 |
| zigo | Haomeng: It's "<packagename>db" by default with what I do... | 06:43 |
| zigo | ironicdb is fine. | 06:43 |
| devananda | ahh | 06:43 |
| zigo | connection = mysql://ironic-common:XXXXXX@localhost/ironicdb <--- What I have. | 06:44 |
| Haomeng | zigo: ok, so db is fine | 06:45 |
| Haomeng | zigo: based on code logic - http://paste.debian.net/67975/ | 06:45 |
| zigo | What about it? | 06:46 |
| Haomeng | zigo: 3 require_found call, not sure which one has exception | 06:46 |
| Haomeng | zigo: can you debug with your env? | 06:46 |
| devananda | zigo: pip list | grep migrate | 06:46 |
| zigo | I can install pdb, yeah... | 06:46 |
| zigo | Though there's no such thing as any pip installed packages! :) | 06:46 |
| zigo | # dpkg -l python-migrate | 06:47 |
| zigo | ii python-migrate 0.7.2-3 | 06:47 |
| devananda | heh | 06:47 |
| devananda | ok. so that could be part of the issue | 06:47 |
| zigo | So, I need a greater sqlalchemy-migrate? | 06:48 |
| zigo | I can try to package it and go back to you guys. | 06:48 |
| Haomeng | zigo: add this line "import pdb;pdb.set_trace()" before "/usr/lib/python2.7/dist-packages/migrate/versioning/repository.py" line 93 | 06:48 |
| devananda | https://pypi.python.org/pypi/sqlalchemy-migrate | 06:48 |
| devananda | its been bumped to 0.8.2 recently | 06:48 |
| devananda | we merged some code, and are about to merge more, depending on that | 06:48 |
| zigo | devananda: Not in the requirements.txt at least! | 06:48 |
| devananda | eg, https://review.openstack.org/#/c/56516/11 | 06:49 |
| zigo | So that's what's missing... | 06:49 |
| zigo | Ok, let's stop here then, I'll try packaging python-imgrate 0.8.2, and let you know how it goes. | 06:49 |
| devananda | zigo: correct - not in requirements YET. the merged code shouldn't need it, but that patch does | 06:49 |
| devananda | wow | 06:51 |
| Haomeng | strange, my env is "sqlalchemy-migrate (0.7.2)", and run ironic_dbsync, no any issue:) | 06:51 |
| Haomeng | ood | 06:52 |
| Haomeng | odd | 06:52 |
| devananda | zigo: so i've had 0.8.1 locally and just downgraded to 0.7.2, now it's rather unhappy. let me rebuild my venv and see if this is just an artefact, or if we somehow broke compat and didn't notice | 06:52 |
| zigo | Ok. | 06:53 |
| zigo | I'm rather happy that this is the problem, it's easy to fix. Thanks for helping. | 06:54 |
| zigo | Will address the python-migrate package version issue. | 06:54 |
| Haomeng | zigo: welcome | 06:54 |
| devananda | zigo: any time | 06:54 |
| devananda | zigo: sqlalchemy-migrate 0.7.2 also breaks terribly for me locally. that's a problem alright | 06:59 |
| zigo | :) | 07:00 |
| *** matsuhashi has quit IRC | 07:05 | |
| *** matsuhashi has joined #openstack-ironic | 07:05 | |
| *** nosnos_ has quit IRC | 07:20 | |
| *** nosnos has joined #openstack-ironic | 07:21 | |
| *** urulama has joined #openstack-ironic | 07:23 | |
| *** prekarat has quit IRC | 07:54 | |
| *** matsuhashi has quit IRC | 08:01 | |
| *** matsuhashi has joined #openstack-ironic | 08:03 | |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Allow clean reservation at update node https://review.openstack.org/55549 | 08:04 |
| *** jistr has joined #openstack-ironic | 08:07 | |
| *** mihgen has quit IRC | 08:13 | |
| *** vkozhukalov has joined #openstack-ironic | 08:18 | |
| *** dguitarbite has quit IRC | 08:22 | |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Allow clean reservation at update node https://review.openstack.org/55549 | 08:22 |
| Haomeng | zigo: how about the progress, it working now? | 08:32 |
| zigo | Haomeng: Nop, doing something else right now. | 08:32 |
| Haomeng | zigo: ok:) | 08:32 |
| Haomeng | zigo: I just run devstack stack.sh and run ironic_dbsync with my ubuntu, no any migration issue | 08:34 |
| Haomeng | zigo: so if it is diffcult to fix/workaround, suggest you run these with ubuntu:) | 08:34 |
| Haomeng | zigo: I think we need to debug and find the root cause in your env | 08:35 |
| zigo | I'm maintaining packages in *debian*! :) | 08:35 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Allow clean reservation at update node https://review.openstack.org/55549 | 08:35 |
| Haomeng | zigo: ok, I can help you debug with your debian env if required:) | 08:38 |
| Haomeng | zigo: will support you:) | 08:38 |
| zigo | Haomeng: Sorry, but I need to fix this production problem first. | 08:38 |
| Haomeng | zigo: ok:) | 08:39 |
| Haomeng | zigo: ping me if you need helping from me:) | 08:39 |
| zigo | Thanks. | 08:40 |
| *** ndipanov has joined #openstack-ironic | 08:41 | |
| *** sjing has quit IRC | 08:41 | |
| Haomeng | zigo: :) | 08:42 |
| *** martyntaylor has joined #openstack-ironic | 08:42 | |
| *** mihgen has joined #openstack-ironic | 08:59 | |
| *** vkozhukalov has quit IRC | 09:02 | |
| *** jistr has quit IRC | 09:02 | |
| *** derekh has joined #openstack-ironic | 09:05 | |
| GheRivero | morning all | 09:05 |
| Haomeng | GheRivero: morning:) | 09:08 |
| *** romcheg has joined #openstack-ironic | 09:09 | |
| *** vkozhukalov has joined #openstack-ironic | 09:17 | |
| *** jistr has joined #openstack-ironic | 09:34 | |
| *** lucasagomes has joined #openstack-ironic | 09:37 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add driver interfaces validation https://review.openstack.org/54593 | 09:51 |
| *** matsuhashi has quit IRC | 09:51 | |
| *** ben_duyujie has joined #openstack-ironic | 09:52 | |
| *** matsuhas_ has joined #openstack-ironic | 09:55 | |
| *** max_lobur_afk is now known as max_lobur | 09:55 | |
| max_lobur | morning Ironic =) | 09:55 |
| openstackgerrit | A change was merged to openstack/ironic: Add tftp_server pattern in ironic.conf https://review.openstack.org/54891 | 10:00 |
| *** matsuhas_ has quit IRC | 10:11 | |
| *** matsuhashi has joined #openstack-ironic | 10:11 | |
| *** rongze has quit IRC | 10:21 | |
| *** vkozhukalov has quit IRC | 10:24 | |
| *** rongze_ has joined #openstack-ironic | 10:31 | |
| *** vkozhukalov has joined #openstack-ironic | 10:36 | |
| openstackgerrit | Max Lobur proposed a change to openstack/ironic: Do not allow API to expose error stacktrace https://review.openstack.org/58558 | 11:05 |
| *** rongze_ has quit IRC | 11:06 | |
| *** matsuhashi has quit IRC | 11:10 | |
| *** rongze has joined #openstack-ironic | 11:15 | |
| *** nosnos has quit IRC | 11:53 | |
| lucasagomes | whattaheck, idk if it's my enviroment or not: http://paste.openstack.org/show/54056/ | 12:22 |
| lucasagomes | updates works on the first request and then fail on the next | 12:23 |
| lucasagomes | and it keep going, work and the next fail | 12:23 |
| lucasagomes | have someone seen this as well/ | 12:28 |
| lucasagomes | ?* | 12:28 |
| *** romcheg has left #openstack-ironic | 12:36 | |
| *** lucasagomes is now known as lucas-hungry | 12:45 | |
| *** jistr is now known as jistr|eng | 12:49 | |
| *** jbjohnso has joined #openstack-ironic | 13:14 | |
| *** ben_duyujie has quit IRC | 13:19 | |
| openstackgerrit | Max Lobur proposed a change to openstack/ironic: Do not allow API to expose error stacktrace https://review.openstack.org/58558 | 13:40 |
| *** jdob has joined #openstack-ironic | 13:40 | |
| *** romcheg has joined #openstack-ironic | 13:41 | |
| *** romcheg has left #openstack-ironic | 13:50 | |
| *** lucas-hungry is now known as lucasagomes | 13:58 | |
| *** lucas has joined #openstack-ironic | 13:59 | |
| lucasagomes | max_lobur, r u using devstack to build ur dev enviroment? | 14:02 |
| lucasagomes | u asked me yesterday to test the authentication | 14:03 |
| lucasagomes | it's alright | 14:03 |
| lucasagomes | http://paste.openstack.org/show/54062/ | 14:03 |
| lucasagomes | I built my env again with the last devstack | 14:03 |
| max_lobur | hi lucasagomes | 14:10 |
| max_lobur | yes I'm using devstack | 14:10 |
| max_lobur | but didn't rebuild for a while | 14:10 |
| max_lobur | OK, I'll try to find the reason in my env. TY! | 14:11 |
| lucasagomes | might be that then :) my env was very old and problematic I built a new one now and things seems to be configured correctly | 14:11 |
| max_lobur | hehe =) | 14:11 |
| * lucasagomes still testing | 14:11 | |
| lucasagomes | I let u know if I find out something odd | 14:11 |
| max_lobur | yep, thanks | 14:11 |
| max_lobur | lucasagomes, have you tried to build stable/havana using devstack? does it work? | 14:13 |
| lucasagomes | you mean to test nova baremetal? because ironic doesn't have a havanna release | 14:14 |
| lucasagomes | but anyway, I haven't | 14:14 |
| max_lobur | yea, I mean every components from havana, and latest ironic | 14:15 |
| max_lobur | OK, I think I'll try | 14:15 |
| *** michchap has quit IRC | 14:15 | |
| lucasagomes | right, no I haven't but would be good to give it a whirl | 14:15 |
| lucasagomes | max_lobur, right, lemme know please | 14:15 |
| max_lobur | k | 14:16 |
| *** jdob has quit IRC | 14:20 | |
| *** jdob has joined #openstack-ironic | 14:20 | |
| *** jdob has quit IRC | 14:24 | |
| *** jdob has joined #openstack-ironic | 14:24 | |
| *** jistr|eng is now known as jistr | 14:32 | |
| *** jdob has quit IRC | 14:38 | |
| *** darrylms has joined #openstack-ironic | 14:40 | |
| *** jdob has joined #openstack-ironic | 14:52 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Add node-validate to cli https://review.openstack.org/58788 | 15:04 |
| *** yuriyz has joined #openstack-ironic | 15:10 | |
| *** rloo has joined #openstack-ironic | 15:18 | |
| NobodyCam | good morning Ironic | 15:23 |
| dkehn | morning | 15:23 |
| rloo | morning NobodyCam! | 15:23 |
| NobodyCam | morning dkehn rloo :) | 15:24 |
| *** prekarat has joined #openstack-ironic | 15:27 | |
| yuriyz | morning Ironic | 15:28 |
| NobodyCam | lucasagomes: good morning yuriyz | 15:28 |
| NobodyCam | lucasagomes: you happend to be around | 15:29 |
| lucasagomes | NobodyCam, morning! | 15:29 |
| lucasagomes | yes | 15:29 |
| NobodyCam | gah | 15:29 |
| lucasagomes | the validate stuff ^ | 15:29 |
| NobodyCam | yuriyz: Morning | 15:29 |
| NobodyCam | :) question about https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/utils.py#L50-L51 if you have a second | 15:29 |
| NobodyCam | morining lucasagomes too | 15:30 |
| lucasagomes | yes sure | 15:30 |
| NobodyCam | lucasagomes: if I pass http://paste.openstack.org/show/I7ChWj8lniAGkOFQcdpE/ | 15:33 |
| lucasagomes | NobodyCam, https://review.openstack.org/#/c/56984/12/ironic/api/controllers/v1/types.py I use the wsattr from wsme to make the 'op' and 'path' fields mandatory and check if 'op' is one of the valid operations (add, remove, replace) | 15:33 |
| NobodyCam | that check breaks | 15:33 |
| lucasagomes | NobodyCam, sounds like a bug then | 15:33 |
| lucasagomes | but I think it's something that the update_node() function on the conductor is doing | 15:34 |
| lucasagomes | lemme check | 15:34 |
| lucasagomes | or it fails on the validation of the patch? | 15:34 |
| lucasagomes | if it fails on the patch validation it shouldn't | 15:34 |
| *** urulama has quit IRC | 15:35 | |
| lucasagomes | NobodyCam, https://github.com/openstack/ironic/blob/9bc8279fa5a2dfc129f3cf5d049896d00babd4ca/ironic/conductor/manager.py#L138-L141 | 15:35 |
| lucasagomes | sorry, https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L138-L141 | 15:35 |
| NobodyCam | the odd this is if i remove the / from /instance_uuid it passes that checj but then faie the regex | 15:38 |
| NobodyCam | s/this/thing/ | 15:39 |
| *** vkozhukalov has quit IRC | 15:39 | |
| lucasagomes | hmm can you send me the output? | 15:41 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add driver interfaces validation https://review.openstack.org/54593 | 15:43 |
| devananda | morning, all | 15:45 |
| lucasagomes | NobodyCam, might be something on the update_node method of the conductor | 15:46 |
| lucasagomes | http://paste.openstack.org/show/54071/ | 15:46 |
| lucasagomes | devananda, morning | 15:46 |
| devananda | found something interesting last night | 15:46 |
| devananda | we managed to break compat with sqla-migrate 0.7.2 | 15:46 |
| NobodyCam | good morniong devananda | 15:46 |
| devananda | even though our requirements.txt says >= 0.7.2 | 15:46 |
| lucasagomes | devananda, ouch | 15:47 |
| NobodyCam | :( | 15:47 |
| devananda | yea. so i need to fix up my sync-db-from-oslo patch and update req.txt | 15:47 |
| lucasagomes | I see | 15:48 |
| *** jcooley_ has joined #openstack-ironic | 15:53 | |
| *** jistr has quit IRC | 16:03 | |
| *** michchap has joined #openstack-ironic | 16:08 | |
| devananda | lucasagomes: also got feedback from the oslo team regarding my fix to lockutils in that patch | 16:09 |
| devananda | so I'm going to test a different approach now | 16:09 |
| NobodyCam | lucasagomes: http://paste.openstack.org/show/LivqJwvo2G8X7qtLL2D5/ vs. http://paste.openstack.org/show/0ihoXWXdEviOuTnAuIMo/ (sorry big log file :-p) | 16:13 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 16:15 |
| openstackgerrit | Max Lobur proposed a change to openstack/ironic: Allow Pecan to use 'debuginfo' response field https://review.openstack.org/58807 | 16:15 |
| devananda | i'm not fond of changes this big ... but meh ... | 16:15 |
| devananda | mordred: what do you think of this change: https://review.openstack.org/#/c/56516/12/tox.ini | 16:15 |
| devananda | mordred: it's based on feedback from oslo team when I tried to undo some brokenness in their db/sqhalchemy/test_migrations.py code | 16:16 |
| lucasagomes | devananda, I see, lemme take a look at ur oslo patch to understand the problem better | 16:23 |
| lucasagomes | NobodyCam, http://paste.openstack.org/show/54081/ | 16:23 |
| lucasagomes | NobodyCam, I think that the problem with the first is because ur not sending a list of patches (ironic gets a list of patches) | 16:23 |
| lucasagomes | e.g [{"path": "/instance_uuid", "value": "dcac1dd0-15ab-4873-9980-ca8c86fe1426", "op": "replace"}] | 16:23 |
| lucasagomes | although urgh it should work anyway | 16:25 |
| NobodyCam | lucasagomes: http://paste.openstack.org/show/7crgmisHnNkJwldrUU9Q/ | 16:28 |
| NobodyCam | sorry grabbed the wrong one | 16:28 |
| *** mihgen has quit IRC | 16:32 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 16:37 |
| max_lobur | lucasagomes, could you please take a look https://github.com/openstack/ironic/blob/master/ironic/tests/api/test_root.py#L39 | 16:37 |
| max_lobur | it seems we have outdated tests | 16:37 |
| max_lobur | how do you think do we need to keep it in sync with actual resources? or maybe it's enough to test some of them | 16:38 |
| *** ndipanov is now known as ndipanov_gone | 16:41 | |
| max_lobur | I think if we want to keep it in sync we need to implement a check for extra resources, so anyone who adds new resource don't forget to update those test.. I can fix if needed | 16:41 |
| lucasagomes | max_lobur, i see yea now we added the driver resources there and it's not being tested https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/__init__.py#L114-L117 | 16:42 |
| max_lobur | yep, exactly | 16:42 |
| lucasagomes | yea just thikning hw it can be done, but having a check for that would be really great | 16:44 |
| lucasagomes | cause it's so easy to forget to test it once u add more resources | 16:44 |
| max_lobur | OK, I'll do, I have some ideas | 16:45 |
| max_lobur | yea, the test should shout that it's not updated, instead of silently passing all the time =) | 16:45 |
| lucasagomes | :D right | 16:46 |
| lucasagomes | maybe having a whitelist with all the fields that should be returned and it would complain if there's something extra there | 16:47 |
| max_lobur | yes, something like this data.keys() will carry all the resources | 16:47 |
| lucasagomes | yup | 16:48 |
| lucasagomes | it also returns other things that are auto generated | 16:48 |
| lucasagomes | links for e.g | 16:48 |
| max_lobur | hmm | 16:48 |
| max_lobur | so need to distinguish resources from other stuff | 16:48 |
| max_lobur | I'll take a look what we can | 16:49 |
| max_lobur | in general - do we need to fill a bug for such work? | 16:50 |
| devananda | lucasagomes: right, so the fix suggested by oslo devs didn't work. I'm goign to hack this patch in half so we can fix the sqla-migrate issue | 16:50 |
| lucasagomes | max_lobur, https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/__init__.py#L55-L71 | 16:50 |
| devananda | after i get coffee | 16:50 |
| devananda | :) | 16:50 |
| lucasagomes | devananda, right I think that ben is a redhat guy maybe worth pinging him on IRC and check if he have more suggestions for that problem, his irc name is bnemec | 16:53 |
| *** yuriyz has quit IRC | 16:54 | |
| max_lobur | lucasagomes, there are no drivers in __init__, is it OK? | 16:55 |
| max_lobur | in V1 | 16:55 |
| devananda | lucasagomes: thanks | 16:56 |
| lucasagomes | max_lobur, actually not we should have drivers there since it's a valid resource | 16:56 |
| lucasagomes | but you can see that today it's very manual | 16:56 |
| lucasagomes | so to add a resource we need to modify the resource, that class and tests | 16:56 |
| lucasagomes | modify the controller* | 16:57 |
| max_lobur | I see why we need to modify V1 and test, but why controller? | 16:58 |
| max_lobur | ahh, you mean to add some new resource | 16:58 |
| lucasagomes | yea | 16:58 |
| max_lobur | I see :) | 16:58 |
| lucasagomes | if we want to add some new resource we would need to modify all that pieces | 16:58 |
| lucasagomes | which hmm is not really ideal | 16:58 |
| max_lobur | ok, to fix that test we need also change V1 | 16:58 |
| lucasagomes | and 99,99% of chance that ur going to forget something | 16:58 |
| lucasagomes | yes, or the resource won't even appear to that test | 16:59 |
| * lucasagomes thinking if we could somehow generate the v1 attributes on the fly | 16:59 | |
| max_lobur | V1 and controller in the same file | 17:00 |
| max_lobur | it's easier to keep them in sync than update those test.. | 17:00 |
| max_lobur | *easier to remember | 17:00 |
| lucasagomes | yea, maybe the v1.convert method should receive a list of resource names and generate the links for them on the fly | 17:02 |
| lucasagomes | since they r the same | 17:02 |
| lucasagomes | there's a pattern there | 17:02 |
| max_lobur | https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/__init__.py#L79-L82 and what about this | 17:03 |
| max_lobur | it's different:) | 17:04 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Update ironic.conf.sample https://review.openstack.org/58642 | 17:04 |
| lucasagomes | max_lobur, ah, I mean links and media_types are not resources on the controller class | 17:05 |
| lucasagomes | but if u look at chassis, nodes and ports they are the resources on the controller class and on the convert method of v1 they r generated the same way | 17:05 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Bump required version of sqlalchemy-migrate https://review.openstack.org/58816 | 17:06 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync some db changes from Oslo https://review.openstack.org/58817 | 17:06 |
| devananda | ok -- now I'm really going to get coffee! | 17:06 |
| devananda | bbi30m | 17:06 |
| NobodyCam | sure | 17:06 |
| NobodyCam | hehehe | 17:06 |
| NobodyCam | :-p | 17:06 |
| *** prekarat has quit IRC | 17:09 | |
| max_lobur | lucasagomes, true | 17:09 |
| max_lobur | then it turns to be a good idea =) | 17:10 |
| max_lobur | I'll take a look tomorrow | 17:10 |
| max_lobur | I think it will be 2 patches - one to fix if for drivers, another for autogeneration | 17:11 |
| max_lobur | *fix it | 17:11 |
| lucasagomes | :D right, thanks for looking at it | 17:12 |
| max_lobur | Everyone have a nice day =) | 17:12 |
| lucasagomes | max_lobur, you too :) enjoy it | 17:12 |
| NobodyCam | you too max_lobur :) | 17:12 |
| *** max_lobur is now known as max_lobur_afk | 17:12 | |
| NobodyCam | seems it is post bbt walkies time. brb | 17:13 |
| NobodyCam | walkies done | 17:28 |
| *** vkozhukalov has joined #openstack-ironic | 17:29 | |
| lucasagomes | :D wb | 17:34 |
| NobodyCam | :) | 17:34 |
| *** urulama has joined #openstack-ironic | 17:35 | |
| *** urulama has quit IRC | 17:40 | |
| dkehn | NobodyCam: can you take a look http://paste.openstack.org/show/54088/ | 17:41 |
| * NobodyCam looks | 17:42 | |
| dkehn | NobodyCam: thx | 17:43 |
| NobodyCam | wow thats kinda odd | 17:44 |
| dkehn | NobodyCam: this is a freash vm , non tainted | 17:44 |
| dkehn | NobodyCam: | 17:46 |
| dkehn | [#openstack-iron] | 17:46 |
| dkehn | NobodyCam: http://paste.openstack.org/show/54089/ | 17:46 |
| dkehn | NobodyCam: at the bottom | 17:46 |
| NobodyCam | very strange | 17:48 |
| *** jcooley_ has quit IRC | 17:51 | |
| *** derekh has quit IRC | 17:53 | |
| devananda | back | 17:56 |
| NobodyCam | devananda: http://paste.openstack.org/show/xMi256Gmt58s82cx2NHB/ | 17:57 |
| devananda | NobodyCam: see PM? | 17:59 |
| *** romcheg1 has joined #openstack-ironic | 18:05 | |
| dkehn | NobodyCam: what is expected as the Ubuntu version, if there is an expectation | 18:07 |
| NobodyCam | dkehn: I use dib to build so I use 13.04 I think | 18:08 |
| dkehn | NobodyCam: I'm guessing I'm using a 12.10, I'm building from a seed that I created | 18:10 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Update ironic.conf.sample https://review.openstack.org/58642 | 18:11 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync some db changes from Oslo https://review.openstack.org/58817 | 18:11 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Bump required version of sqlalchemy-migrate https://review.openstack.org/58816 | 18:11 |
| devananda | lucasagomes: ^ | 18:11 |
| lucasagomes | devananda, cool, thanks I know it was a nit thing but it's better to keep it consistent | 18:11 |
| devananda | lucasagomes: absolutely | 18:12 |
| devananda | whole point of that patch was to make it consistent again, heh | 18:12 |
| lucasagomes | yup :D | 18:12 |
| * devananda wonders if we should create a periodic jenkins job to call generate_sample.sh | 18:12 | |
| * lucasagomes thinks its a good idea | 18:13 | |
| *** romcheg1 has left #openstack-ironic | 18:15 | |
| *** martyntaylor has quit IRC | 18:19 | |
| devananda | https://bugs.launchpad.net/ironic/+bug/1255621 | 18:21 |
| lucasagomes | :) | 18:29 |
| lucasagomes | ok I'm done for the day | 18:32 |
| lucasagomes | have a good night everyone | 18:32 |
| lucasagomes | ah NobodyCam btw, tomorrow lets talk about the node.deploy() method that you need | 18:33 |
| *** martyntaylor has joined #openstack-ironic | 18:33 | |
| lucasagomes | NobodyCam, I added the validation on today to the ironic and the client lib (https://review.openstack.org/#/c/54593/ https://review.openstack.org/#/c/58788/) take a look if that works for u | 18:33 |
| *** lucasagomes is now known as lucas-dinner | 18:34 | |
| NobodyCam | will do | 18:34 |
| NobodyCam | night lucas-dinner | 18:34 |
| openstackgerrit | A change was merged to openstack/ironic: Update ironic.conf.sample https://review.openstack.org/58642 | 18:41 |
| openstackgerrit | A change was merged to openstack/ironic: Sync common.context changes from olso https://review.openstack.org/58490 | 18:43 |
| openstackgerrit | A change was merged to openstack/ironic: Remove openstack.common.uuidutils https://review.openstack.org/58492 | 18:43 |
| devananda | max_lobur_afk: going to update 58807 ? | 18:43 |
| *** mihgen has joined #openstack-ironic | 19:05 | |
| *** jdob has quit IRC | 19:09 | |
| *** lucas-dinner has quit IRC | 19:17 | |
| *** jcooley_ has joined #openstack-ironic | 19:22 | |
| *** rloo has quit IRC | 19:25 | |
| *** epim has joined #openstack-ironic | 19:26 | |
| devananda | NobodyCam: consider the possibility of _not_ calling validate() before nova.driver.spawn() | 19:28 |
| devananda | NobodyCam: could you catch an error, eg if the SSH credentails are wrong, and back out? | 19:28 |
| NobodyCam | and I was just going to +2 https://review.openstack.org/#/c/58788/ | 19:30 |
| *** rongze has quit IRC | 19:30 | |
| devananda | NobodyCam: that one shouldn't land until https://review.openstack.org/#/c/54593/ | 19:30 |
| NobodyCam | i know .. not +a | 19:31 |
| devananda | :) | 19:31 |
| *** rongze has joined #openstack-ironic | 19:31 | |
| devananda | NobodyCam: i'm not sayng i dislike exposing /validate/ | 19:31 |
| devananda | NobodyCam: i actually think it's important -- see my comment on 54593 | 19:31 |
| devananda | NobodyCam: but i'm not sure it needs to be called before _every_single_spawn_ | 19:32 |
| NobodyCam | i kinda think we need both. validate to ensure the driver has everything it needs & and catch errors in the deploy | 19:34 |
| devananda | that doesn't make sense to me | 19:34 |
| devananda | if we're EAFP, then we dont need validate() in that code path | 19:34 |
| NobodyCam | ie ssh with valid user / pass ... mid deploy the password changes | 19:34 |
| devananda | there are a hundred other things that could go wrong mid-deploy, too, which we need to catch | 19:34 |
| devananda | so handling deploy failures => we need to | 19:35 |
| devananda | i think validate() is useful for the cloud admin to be able to ensure he's enrolled things correctly | 19:35 |
| NobodyCam | yes... validate , I thought, was like I'm ready to try a deploy. | 19:35 |
| devananda | eg, admin creates a bunch of nodes and populates all the data. how does he actually know the passwords are correct? -- he should validate() | 19:35 |
| NobodyCam | not i can deploy | 19:36 |
| devananda | right | 19:36 |
| NobodyCam | but I think it should be with every deploy | 19:36 |
| devananda | so i guess, i'm saying, if the nova scheduler has selected a node for a deployment,w e should assume it's already "ready" | 19:36 |
| *** rongze has quit IRC | 19:36 | |
| devananda | ++ | 19:36 |
| devananda | er, ignore the ++ | 19:36 |
| NobodyCam | lol | 19:37 |
| NobodyCam | ahh ok so the validate logic is in get_available_nodes | 19:39 |
| NobodyCam | so only nodes that "are ready to attempt to deploy" are presented to nova | 19:41 |
| openstackgerrit | A change was merged to openstack/ironic: Bump required version of sqlalchemy-migrate https://review.openstack.org/58816 | 19:42 |
| openstackgerrit | A change was merged to openstack/ironic: Import uuidutils unit tests from oslo https://review.openstack.org/58572 | 19:42 |
| *** jcooley_ has quit IRC | 19:49 | |
| *** urulama has joined #openstack-ironic | 19:51 | |
| devananda | lifeless: if you've got time for another review, i'd liek your eyes on https://review.openstack.org/#/c/58607/ | 19:55 |
| *** jcooley_ has joined #openstack-ironic | 19:58 | |
| *** rongze has joined #openstack-ironic | 20:01 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing common methods https://review.openstack.org/58607 | 20:03 |
| * NobodyCam gets some lunch.. brb | 20:05 | |
| *** rongze has quit IRC | 20:06 | |
| *** jcooley_ has quit IRC | 20:07 | |
| *** mihgen has quit IRC | 20:08 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add conductor_heartbeat_interval option https://review.openstack.org/58851 | 20:21 |
| *** vkozhukalov has quit IRC | 20:23 | |
| *** jcooley_ has joined #openstack-ironic | 20:23 | |
| *** mihgen has joined #openstack-ironic | 20:25 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing common methods https://review.openstack.org/58607 | 20:30 |
| *** rongze has joined #openstack-ironic | 20:31 | |
| devananda | lifeless, NobodyCam -- i think I just realized the hash_ring needs to be in ironic/common, because it's going to be used byu the API service as well | 20:34 |
| devananda | so that API knows where to route RPC messages to | 20:34 |
| lifeless | devananda: yes | 20:35 |
| *** urulama has quit IRC | 20:36 | |
| devananda | moved | 20:38 |
| devananda | wow, git review is being slow | 20:38 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement consistent hashing common methods https://review.openstack.org/58607 | 20:38 |
| lifeless | devananda: https://review.openstack.org/#/c/57829/ | 20:39 |
| lifeless | devananda: this is getting long in the tooth, wonder if you can eyeball it | 20:39 |
| devananda | lifeless: https://review.openstack.org/#/c/53627/ | 20:40 |
| *** rongze has quit IRC | 20:40 | |
| devananda | is the parent patch | 20:40 |
| devananda | actually, nvm, it's not | 20:40 |
| devananda | 57829 is just unit tests. the commit message is a bit misleading | 20:40 |
| devananda | lifeless: copyright header is optional, not required by openstack, AFAIK | 20:42 |
| devananda | lifeless: our employer requires it, but not all do | 20:42 |
| lifeless | devananda: I had a chat with infra about this | 20:43 |
| devananda | oh? | 20:43 |
| devananda | lifeless: https://wiki.openstack.org/wiki/LegalIssuesFAQ#Copyright_Headers | 20:43 |
| lifeless | early this week I asked in -infra | 20:44 |
| lifeless | it's not mandatory to have a copyright claim, but it is strongly encouraged | 20:45 |
| lifeless | devananda: anyhow, that patch I pointed you at is ready to go AFAICT | 20:49 |
| lifeless | devananda: it just seemed to have no other cores reviewing it | 20:50 |
| devananda | thanks. those fields aren't actually present in the API return yet | 20:52 |
| devananda | so it wasn't pressing | 20:52 |
| devananda | it looks like they have already beena dded to the client, actually | 20:52 |
| devananda | which is odd | 20:52 |
| devananda | yay for no tempest tests | 20:53 |
| *** rwsu has quit IRC | 20:57 | |
| openstackgerrit | A change was merged to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show https://review.openstack.org/57829 | 21:22 |
| *** rongze has joined #openstack-ironic | 21:34 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add conductor_heartbeat_interval option https://review.openstack.org/58851 | 21:35 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task https://review.openstack.org/56530 | 21:35 |
| *** mihgen has quit IRC | 21:36 | |
| *** rongze has quit IRC | 21:39 | |
| *** jbjohnso has quit IRC | 22:04 | |
| *** jcooley_ has quit IRC | 22:06 | |
| openstackgerrit | A change was merged to openstack/ironic: Implement consistent hashing common methods https://review.openstack.org/58607 | 22:27 |
| *** michchap has quit IRC | 22:30 | |
| *** rloo has joined #openstack-ironic | 22:31 | |
| *** michchap has joined #openstack-ironic | 22:33 | |
| *** rongze has joined #openstack-ironic | 22:35 | |
| *** rongze has quit IRC | 22:39 | |
| * NobodyCam goes for quick afternoon walkies.... brb | 22:43 | |
| rloo | devananda, yt? | 22:44 |
| rloo | devananda, scratch that ^^, no need to talk to you. I commented on the review instead. | 22:52 |
| devananda | rloo: hi | 22:54 |
| devananda | rloo: i see your comment. not sure, tbh | 22:54 |
| rloo | devananda: it was a tuple in one of your earlier patches, and I don't see how it could have changed to a list :-) | 22:55 |
| devananda | rloo: i think that was a mistake :) | 22:59 |
| devananda | rloo: http://docs.sqlalchemy.org/en/latest/orm/query.html#sqlalchemy.orm.query.Query.all | 22:59 |
| devananda | Return the results represented by this Query as a list | 22:59 |
| devananda | last line of our _paginate_query --> return query.all() | 22:59 |
| rloo | is that the outside list or the inside list? sorry, need to bring up the code. | 23:00 |
| devananda | rloo: the return from get_nodeinfo_list is a list | 23:00 |
| devananda | ah | 23:00 |
| devananda | so the question is, does that list contain tuples or lists | 23:00 |
| NobodyCam | and back | 23:01 |
| rloo | devananda: yes, sorry, I guess I wasn't clear. | 23:02 |
| devananda | rloo: no, you were. i'm being obtuse :) | 23:05 |
| rloo | devananda. you're probably just wishing for the Thanksgiving holiday to begin! I can barely review this any more, can't imagine it being easy to do revision after revision. | 23:05 |
| devananda | rloo: actually i'm working on the conductor's consistent hash methods | 23:06 |
| devananda | rloo: and this patch is a dependency :p | 23:06 |
| NobodyCam | rloo: ++ for Thanksgiving holiday to begin! | 23:06 |
| NobodyCam | heehhe | 23:07 |
| devananda | also, that :) | 23:07 |
| rloo | devananda: ahh. well, seems pretty close to having the patch finished! | 23:07 |
| rloo | NobodyCam. You put aside the xmas holiday cheer for a few days, eh? | 23:07 |
| NobodyCam | lol nope.. still have xmass music and egg nog | 23:08 |
| *** max_lobur_afk has quit IRC | 23:08 | |
| *** max_lobur_afk has joined #openstack-ironic | 23:09 | |
| devananda | rloo: tested in python CLI -- the result is a list of tuples | 23:09 |
| rloo | devananda: good! | 23:10 |
| *** jcooley_ has joined #openstack-ironic | 23:14 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement sync_power_state periodic task https://review.openstack.org/56530 | 23:16 |
| devananda | rloo: ^ :) | 23:16 |
| rloo | thx devananda! | 23:18 |
| devananda | rloo: thank you for catching that :) | 23:18 |
| rloo | devananda. yw! I'm not even going to look, I'm just going to +1 it. Argh, guess I ought to quickly look... | 23:19 |
| devananda | :p | 23:19 |
| rloo | devananda: nicely worded :-). have a great holiday. I'll 'talk' to you all next week! | 23:21 |
| *** jcooley_ has quit IRC | 23:21 | |
| *** rloo has left #openstack-ironic | 23:21 | |
| devananda | you too! | 23:26 |
| *** jbjohnso has joined #openstack-ironic | 23:34 | |
| *** rongze has joined #openstack-ironic | 23:36 | |
| *** rongze has quit IRC | 23:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!