*** matsuhashi has joined #openstack-ironic | 00:02 | |
*** michchap has quit IRC | 00:06 | |
*** michchap has joined #openstack-ironic | 00:06 | |
*** matsuhashi has quit IRC | 00:14 | |
*** matsuhashi has joined #openstack-ironic | 00:15 | |
*** matsuhashi has quit IRC | 00:15 | |
*** matsuhashi has joined #openstack-ironic | 00:15 | |
*** matsuhashi has quit IRC | 00:29 | |
*** matsuhashi has joined #openstack-ironic | 00:29 | |
*** matsuhashi has quit IRC | 00:34 | |
*** matsuhashi has joined #openstack-ironic | 01:11 | |
*** nosnos has joined #openstack-ironic | 01:24 | |
*** matsuhashi has quit IRC | 01:24 | |
*** matsuhashi has joined #openstack-ironic | 01:25 | |
*** matsuhas_ has joined #openstack-ironic | 01:29 | |
*** matsuhashi has quit IRC | 01:32 | |
*** matsuhas_ has quit IRC | 01:37 | |
*** matsuhashi has joined #openstack-ironic | 01:38 | |
*** matsuhas_ has joined #openstack-ironic | 01:45 | |
*** matsuhashi has quit IRC | 01:48 | |
*** michchap has quit IRC | 02:19 | |
*** michchap has joined #openstack-ironic | 02:22 | |
*** sjing has joined #openstack-ironic | 02:49 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Expose created_at/updated_at properties in the REST API https://review.openstack.org/53627 | 03:08 |
---|---|---|
*** matsuhas_ has quit IRC | 03:46 | |
*** matsuhashi has joined #openstack-ironic | 03:47 | |
*** ben_duyujie has joined #openstack-ironic | 03:48 | |
*** matsuhashi has quit IRC | 03:51 | |
*** matsuhashi has joined #openstack-ironic | 04:20 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Expose created_at/updated_at properties in the REST API https://review.openstack.org/53627 | 04:32 |
*** matsuhashi has quit IRC | 04:42 | |
*** matsuhashi has joined #openstack-ironic | 04:42 | |
*** prekarat has joined #openstack-ironic | 04:48 | |
*** sjing has quit IRC | 05:04 | |
*** sjing has joined #openstack-ironic | 05:05 | |
*** urulama has joined #openstack-ironic | 05:16 | |
*** urulama has quit IRC | 05:25 | |
*** urulama has joined #openstack-ironic | 05:35 | |
*** nosnos_ has joined #openstack-ironic | 05:36 | |
*** nosnos has quit IRC | 05:36 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/56744 | 06:00 |
*** coolsvap has joined #openstack-ironic | 06:49 | |
*** matsuhashi has quit IRC | 06:54 | |
*** max_lobur has joined #openstack-ironic | 06:54 | |
*** matsuhashi has joined #openstack-ironic | 06:56 | |
*** nosnos_ has quit IRC | 06:56 | |
*** nosnos has joined #openstack-ironic | 06:56 | |
GheRivero | morning Ironic! | 07:37 |
*** tatyana has joined #openstack-ironic | 07:37 | |
Haomeng | morning GheRivero | 07:42 |
*** michchap has quit IRC | 07:43 | |
*** michchap has joined #openstack-ironic | 07:43 | |
*** romcheg has joined #openstack-ironic | 07:47 | |
*** matsuhashi has quit IRC | 08:13 | |
*** matsuhashi has joined #openstack-ironic | 08:14 | |
*** matsuhashi has quit IRC | 08:15 | |
*** matsuhashi has joined #openstack-ironic | 08:15 | |
openstackgerrit | Ghe Rivero proposed a change to openstack/python-ironicclient: Comply with new hacking release https://review.openstack.org/56668 | 08:19 |
*** ndipanov has joined #openstack-ironic | 08:23 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Add power control to PXE driver https://review.openstack.org/50409 | 08:26 |
*** sjing has quit IRC | 08:36 | |
*** sjing has joined #openstack-ironic | 08:38 | |
*** tatyana has quit IRC | 08:39 | |
*** prekarat1 has joined #openstack-ironic | 08:40 | |
*** prekarat has quit IRC | 08:40 | |
*** tatyana has joined #openstack-ironic | 08:44 | |
*** sjing has quit IRC | 08:48 | |
*** jistr has joined #openstack-ironic | 08:57 | |
*** nosnos has quit IRC | 08:59 | |
*** nosnos has joined #openstack-ironic | 08:59 | |
*** nosnos has quit IRC | 09:03 | |
*** tatyana has quit IRC | 09:08 | |
*** lucasagomes has joined #openstack-ironic | 09:18 | |
openstackgerrit | A change was merged to openstack/python-ironicclient: Change id->uuid in ironic cli help messages https://review.openstack.org/55941 | 09:24 |
coolsvap | guys, I am facing same issue as https://bugs.launchpad.net/ironic/+bug/1241994 in one of my other projects | 09:32 |
coolsvap | can any1 help? | 09:32 |
*** prekarat has joined #openstack-ironic | 09:35 | |
*** prekarat1 has quit IRC | 09:35 | |
GheRivero | coolsvap: try installing requirements via pip. pip install -r requirements.txt | 09:35 |
coolsvap | GheRivero: let me check | 09:37 |
*** derekh has joined #openstack-ironic | 09:45 | |
*** romcheg has quit IRC | 09:45 | |
coolsvap | GheRivero: it was conflicting with another version present in my directory.. removed that directory and ran the above command it worked! | 09:47 |
coolsvap | Thx! | 09:48 |
*** romcheg has joined #openstack-ironic | 09:53 | |
*** matsuhashi has quit IRC | 09:55 | |
*** matsuhashi has joined #openstack-ironic | 09:56 | |
* max_lobur is away: AFK | 09:58 | |
* max_lobur is back (gone 00:00:05) | 09:58 | |
*** matsuhashi has quit IRC | 10:01 | |
*** matsuhashi has joined #openstack-ironic | 10:05 | |
*** ndipanov has quit IRC | 10:10 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Accessing a subresource that parent does not exist https://review.openstack.org/54742 | 10:10 |
*** tatyana has joined #openstack-ironic | 10:18 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rename parameters https://review.openstack.org/56894 | 10:24 |
*** ndipanov has joined #openstack-ironic | 10:26 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: API ports update for WSME 0.5b6 compliance https://review.openstack.org/56682 | 10:42 |
*** matsuhashi has quit IRC | 10:47 | |
*** matsuhashi has joined #openstack-ironic | 10:47 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: API ports update for WSME 0.5b6 compliance https://review.openstack.org/56682 | 10:50 |
*** matsuhashi has quit IRC | 10:52 | |
*** matsuhashi has joined #openstack-ironic | 10:54 | |
*** prekarat has quit IRC | 11:06 | |
*** michchap has quit IRC | 11:12 | |
*** matsuhashi has quit IRC | 11:13 | |
*** michchap has joined #openstack-ironic | 11:13 | |
*** matsuhashi has joined #openstack-ironic | 11:14 | |
*** matsuhashi has quit IRC | 11:19 | |
*** michchap has quit IRC | 11:22 | |
*** michchap has joined #openstack-ironic | 11:23 | |
*** matsuhashi has joined #openstack-ironic | 11:32 | |
*** ben_duyujie has quit IRC | 11:39 | |
*** coolsvap has quit IRC | 12:09 | |
*** michchap has quit IRC | 12:14 | |
*** michchap has joined #openstack-ironic | 12:15 | |
*** tatyana has quit IRC | 12:27 | |
*** tatyana has joined #openstack-ironic | 12:35 | |
*** urulama has quit IRC | 12:39 | |
*** coolsvap has joined #openstack-ironic | 12:55 | |
*** matsuhashi has quit IRC | 13:05 | |
*** matsuhashi has joined #openstack-ironic | 13:05 | |
*** rloo has joined #openstack-ironic | 13:31 | |
*** jistr has quit IRC | 13:41 | |
*** jbjohnso has joined #openstack-ironic | 13:41 | |
*** jistr has joined #openstack-ironic | 13:41 | |
*** jistr has quit IRC | 13:41 | |
*** jistr has joined #openstack-ironic | 13:41 | |
*** jdob has joined #openstack-ironic | 13:42 | |
*** jbjohnso has quit IRC | 13:51 | |
*** matsuhashi has quit IRC | 13:56 | |
*** matsuhashi has joined #openstack-ironic | 13:57 | |
*** matsuhas_ has joined #openstack-ironic | 13:58 | |
*** matsuhashi has quit IRC | 13:59 | |
*** jdob has quit IRC | 14:01 | |
*** jdob has joined #openstack-ironic | 14:01 | |
*** linggao has joined #openstack-ironic | 14:15 | |
*** yuriyz has joined #openstack-ironic | 14:40 | |
NobodyCam | gOod mOrning iRonic | 14:46 |
GheRivero | morning NobodyCam | 14:52 |
NobodyCam | hey hey ghe | 14:52 |
*** jistr has quit IRC | 14:53 | |
*** jistr has joined #openstack-ironic | 14:54 | |
lucasagomes | morning GheRivero NobodyCam | 14:56 |
*** matsuhas_ has quit IRC | 14:57 | |
*** matsuhashi has joined #openstack-ironic | 14:57 | |
GheRivero | lucasagomes: regarding your comment on https://review.openstack.org/#/c/56668/ | 14:57 |
max_lobur | morning Everyone | 14:57 |
lucasagomes | morning max_lobur | 14:59 |
lucasagomes | GheRivero, yea? Cause I've seen this http://docs.openstack.org/developer/hacking/#imports | 15:00 |
NobodyCam | mornign max_lobur and lucasagomes :) | 15:00 |
GheRivero | lifeless suggested going with the # noqa approach. In the first patch, I did it the way you suggested. Now I feel between two fires :( | 15:00 |
GheRivero | the other way is to use import_Exceptions list https://bugs.launchpad.net/hacking/+bug/1206189 | 15:00 |
lucasagomes | GheRivero, ouch... I see | 15:01 |
GheRivero | but i don't have an strong opinion about any of the approach | 15:02 |
lucasagomes | let's see how other projects are using it, cause idk, right now the exception list is not per project | 15:02 |
GheRivero | now it is :) | 15:02 |
lucasagomes | and testtools is not part of the exception list so | 15:02 |
lucasagomes | yea me neither | 15:02 |
lucasagomes | ah I see, fix released | 15:02 |
GheRivero | https://review.openstack.org/#/c/38851/ | 15:03 |
GheRivero | nova is using it | 15:03 |
*** matsuhashi has quit IRC | 15:04 | |
GheRivero | lifeless: ^ | 15:04 |
*** matsuhashi has joined #openstack-ironic | 15:04 | |
lucasagomes | in some tests on ironic we use matchers.HasLength. But yea let's see lifeless comments about it | 15:06 |
lucasagomes | I'm not sold on any sides as well | 15:06 |
*** datajerk has joined #openstack-ironic | 15:06 | |
*** datajerk has quit IRC | 15:07 | |
*** datajerk has joined #openstack-ironic | 15:07 | |
*** matsuhashi has quit IRC | 15:08 | |
*** rwsu-pto is now known as rwsu | 15:16 | |
NobodyCam | oh I need to do a expence report | 15:21 |
*** prekarat has joined #openstack-ironic | 15:23 | |
*** prekarat has quit IRC | 15:24 | |
*** prekarat has joined #openstack-ironic | 15:24 | |
NobodyCam | seems I also need to go walkies... brb | 15:33 |
*** romcheg1 has joined #openstack-ironic | 15:40 | |
*** romcheg has quit IRC | 15:41 | |
*** romcheg1 has quit IRC | 15:45 | |
*** romcheg has joined #openstack-ironic | 15:45 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Don't allow set reservation at update node https://review.openstack.org/55549 | 15:53 |
yuriyz | Morning/evening Ironic | 16:00 |
*** datajerk has quit IRC | 16:06 | |
NobodyCam | morning yuriyz | 16:07 |
*** romcheg has quit IRC | 16:28 | |
*** ben_duyujie has joined #openstack-ironic | 16:33 | |
*** ben_duyujie has quit IRC | 16:35 | |
*** mdenny has joined #openstack-ironic | 16:41 | |
*** jbjohnso has joined #openstack-ironic | 16:45 | |
*** datajerk has joined #openstack-ironic | 16:46 | |
devananda | morning, all | 16:49 |
NobodyCam | good morning devananda | 16:49 |
*** datajerk1 has joined #openstack-ironic | 16:50 | |
*** datajerk has quit IRC | 16:52 | |
NobodyCam | GheRivero: devananda I've been thinking about the dhcp and ironic I think I leaning to adding that to ironic and not just the pxe driver. Can you think of why we would want it only in the pxe driver? | 16:55 |
devananda | NobodyCam: sure. a deploy driver that used virtual media to control boot-from-network-volume wouldn't use DHCP at all | 16:57 |
devananda | or rather | 16:57 |
devananda | there are two parts to the DHCP | 16:57 |
devananda | associating the node's MAC to an IP allocated by neutron / nova-network, that is common, and that's done by Nova or Neutron anyway | 16:58 |
devananda | the DHCP IP that's outside the tenant network -- the one we use for iSCSI traffic to dd the image onto the node -- that is an artefact of PXE | 16:59 |
devananda | i haven't had coffee yet, so i may not be clearly differentiating between them | 16:59 |
NobodyCam | no no I thiink you are | 16:59 |
GheRivero | yeah, very clear | 17:00 |
NobodyCam | so we will need to add dhcp to the pxe driver so we can do the pxe iSCSI / DD | 17:02 |
GheRivero | so, is pxe the only driver requiring a dhcp service in the 'deployment' network? | 17:02 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rework patch validation on Ports https://review.openstack.org/56984 | 17:04 |
*** datajerk1 has quit IRC | 17:04 | |
NobodyCam | sounds like pxe is the only one that will use the "out of bound" ips | 17:04 |
GheRivero | true... I cannot think on anyother using it | 17:05 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Rework patch validation on Ports https://review.openstack.org/56984 | 17:05 |
NobodyCam | ya, I think deva was right. there will other ways of deploying things like the managment utility disk. but only pxe will need its own ip range | 17:06 |
*** jistr has quit IRC | 17:07 | |
NobodyCam | s/was/is/ | 17:07 |
NobodyCam | brb... quick walkies... :-p | 17:08 |
*** prekarat has quit IRC | 17:12 | |
lucasagomes | going home, will be back later for the meeting :) | 17:33 |
*** yuriyz has quit IRC | 17:33 | |
*** lucasagomes has quit IRC | 17:34 | |
*** harlowja has joined #openstack-ironic | 17:59 | |
*** derekh has quit IRC | 18:00 | |
NobodyCam | any topics for the agenda? | 18:04 |
*** jbjohnso has quit IRC | 18:11 | |
*** sandeepr has joined #openstack-ironic | 18:19 | |
sandeepr | morning, evenign ironic | 18:19 |
devananda | NobodyCam: just blueprints | 18:21 |
devananda | NobodyCam: I think we should go through the etherpad(s) and make sure everything's captgured in BPs | 18:21 |
*** coolsvap has quit IRC | 18:28 | |
NobodyCam | ahh good catch :) | 18:28 |
*** epim has joined #openstack-ironic | 18:29 | |
devananda | NobodyCam: in landing the oslo sync patchsets, https://review.openstack.org/#/c/56516/3 is possibly the biggest, and hasnt gotten any reviews yet | 18:33 |
devananda | NobodyCam: do you want to take a look? | 18:34 |
NobodyCam | ya will look now.. | 18:35 |
NobodyCam | devananda: do you recall the version sqlA version that we had the gate issue with? | 18:37 |
NobodyCam | devananda MIN_PKG_VERSION = dist_version.StrictVersion('0.7.3') | 18:37 |
devananda | it was 0.7.3-dev taht broke the matching, IIRC | 18:38 |
devananda | ahhh | 18:38 |
devananda | good catch | 18:38 |
NobodyCam | :) | 18:38 |
NobodyCam | devananda: question on lines 148,149 of https://review.openstack.org/#/c/56516/3/ironic/openstack/common/db/sqlalchemy/test_migrations.py | 18:45 |
NobodyCam | (along with other lines in that file) | 18:46 |
devananda | NobodyCam: ? | 18:46 |
NobodyCam | would i18N affect the reply | 18:46 |
devananda | NobodyCam: i would think so, but the place to fix that would be in oslo-incubator | 18:48 |
NobodyCam | :) ya.. | 18:48 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common.db.sqlalchemy changes from olso https://review.openstack.org/56516 | 18:49 |
*** lucasagomes has joined #openstack-ironic | 18:49 | |
NobodyCam | wb lucasagomes | 18:50 |
lucasagomes | NobodyCam, hey ya :) thanks | 18:52 |
lucasagomes | NobodyCam, btw, how are u? | 18:52 |
NobodyCam | doing good :) out of coffee atm.... debating a run to starbucks b4 meeting | 18:53 |
lucasagomes | hahaha | 18:53 |
lucasagomes | you've few minutes | 18:53 |
NobodyCam | devananda: need to run to starbucks befor meeting .. will continute review when I return | 18:54 |
NobodyCam | :) | 18:55 |
* devananda wonders how close NobodyCam is to starbucks // how fast he can run :) | 18:55 | |
lucasagomes | lol | 18:56 |
lifeless | GheRivero: lucasagomes: hi | 18:56 |
lifeless | matchers are meant to read like sentences | 18:57 |
lucasagomes | lifeless, hey :) | 18:57 |
lifeless | the design is for 'assertThat(subject, verb(object))' essentally | 18:57 |
lifeless | putting module names in there significantly impedes readability. | 18:57 |
openstackgerrit | A change was merged to openstack/ironic: sync common.config.generator from oslo https://review.openstack.org/56514 | 18:58 |
lucasagomes | lifeless, I see, well I'm ok with any implementation, but I'd like to have one that we could use everywhere | 18:58 |
lucasagomes | currently in ironic there's some tests using matchers.HasLength | 18:59 |
lucasagomes | but it's just a few so can be changed :) | 18:59 |
lifeless | lucasagomes: when I've suggested using HasLength I've always done so with the #noqa example. | 18:59 |
lucasagomes | lifeless, right. Cool, I'm happy with that then, I will submit a patch in Ironic to change it to use #noqa | 19:00 |
lucasagomes | and make sure we use that syntax on future tests | 19:00 |
openstackgerrit | A change was merged to openstack/ironic: sync common.context from oslo https://review.openstack.org/56515 | 19:00 |
GheRivero | the question is, we use #noqa or the import_exceptions feature in tox.ini? | 19:01 |
lifeless | I don't know; I was pointed at #noqa when I first asked about this, I think import_exceptions is new? | 19:01 |
GheRivero | new... 3 months, but only nova is using it | 19:02 |
GheRivero | adding to tox.ini there is no need to indicate the #noqa in every import | 19:02 |
lucasagomes | GheRivero, sounds good to me then, I would add to tox.ini | 19:03 |
lucasagomes | less verbose | 19:03 |
openstackgerrit | Ghe Rivero proposed a change to openstack/python-ironicclient: Comply with new hacking release https://review.openstack.org/56668 | 19:07 |
*** datajerk has joined #openstack-ironic | 19:10 | |
*** romcheg has joined #openstack-ironic | 19:10 | |
*** derekh has joined #openstack-ironic | 19:19 | |
*** datajerk has quit IRC | 19:22 | |
anteaya | does one of the libraries ironic uses hook into devstack and devstack-gate? | 19:25 |
NobodyCam | doh | 19:26 |
devananda | anteaya: we're in -meeting. also, i dont quite understand your question | 19:27 |
*** blamar has quit IRC | 19:28 | |
anteaya | sorry | 19:29 |
anteaya | jjohnson wrote a library in stackforge, does it hook into devstack tests? | 19:29 |
anteaya | no hurry | 19:29 |
devananda | anteaya: the pyghmi library? no. afaik, it's not tested by us, which makes me somewhat trepidacious about it | 19:31 |
anteaya | okay, thanks | 19:31 |
anteaya | yes pyghmi was what I was thinking of | 19:31 |
anteaya | sorry for my poor timing | 19:31 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Import HasLength object https://review.openstack.org/57026 | 19:43 |
*** datajerk has joined #openstack-ironic | 19:51 | |
*** ndipanov is now known as ndipanov_gone | 19:51 | |
NobodyCam | sorry I got the timing wrong | 20:00 |
NobodyCam | :-p | 20:00 |
lucasagomes | :) | 20:01 |
devananda | i jsut subscribe to openstack meeting gcal | 20:01 |
lucasagomes | I talk to you all tomorrow, I need to prepare something for dinner | 20:01 |
NobodyCam | :) | 20:01 |
lucasagomes | I'm starving | 20:01 |
lucasagomes | have a good night everyone | 20:01 |
devananda | lucasagomes: ack. g'night! | 20:01 |
NobodyCam | you too lucasagomes | 20:01 |
*** lucasagomes has quit IRC | 20:02 | |
devananda | romcheg: what time is good for you to be online to discuss RPC routing things? | 20:02 |
devananda | NobodyCam: I'm going to clean up the agenda a bit -- many pre-summit things that i think can be removed. k? | 20:02 |
NobodyCam | yea!!! | 20:03 |
linggao | Hi davadanda, has the ironic meeting is done already? | 20:05 |
NobodyCam | linggao: just finished | 20:05 |
linggao | NobodyCam, hmm, thought it started at 3pm EST. | 20:06 |
NobodyCam | lol I was cought by same thing | 20:06 |
NobodyCam | meeting times are posted in gmt | 20:06 |
devananda | Hmm, seems I should start sending meeting reminder emails again | 20:06 |
NobodyCam | no daylight saving for gmt | 20:06 |
NobodyCam | :-p | 20:07 |
linggao | ah, that is it. | 20:07 |
NobodyCam | lol devananda I think just a SMACK to those of us who were late is enought | 20:08 |
*** tatyana has quit IRC | 20:08 | |
NobodyCam | :-p | 20:08 |
linggao | I'll put the right time on my calendar. | 20:08 |
NobodyCam | :) | 20:08 |
linggao | I do not like day light saving time, very confusing. | 20:09 |
NobodyCam | and kindq point less at this stage in history | 20:09 |
linggao | yeah | 20:10 |
linggao | the worst is that the world does not change to daylight saving at the same day. | 20:11 |
linggao | it is quite ironic. :) | 20:12 |
NobodyCam | :-p | 20:12 |
romcheg | devananda: As soon as you get up and ready to start working :) | 20:14 |
devananda | romcheg: heh. I'll try to get up at a reasonably early hour, then :) | 20:15 |
NobodyCam | lol /me can call devananda at 6:00 when he gets up | 20:15 |
devananda | NobodyCam: ++ | 20:15 |
NobodyCam | lol | 20:15 |
devananda | NobodyCam: can you make me coffee too? | 20:16 |
romcheg | devananda: don't get up too early ;) | 20:16 |
NobodyCam | lol hummm ... almost.. I could do a remote deploy of coffee | 20:17 |
NobodyCam | may require some hardware on your end | 20:18 |
*** jdob has quit IRC | 20:29 | |
*** jdob has joined #openstack-ironic | 20:29 | |
* NobodyCam wanders away from keybord to look for some lunch | 20:30 | |
*** derekh has quit IRC | 20:36 | |
*** hemnafk is now known as hemna | 20:38 | |
*** jdob has quit IRC | 20:40 | |
*** jdob has joined #openstack-ironic | 20:40 | |
*** datajerk has quit IRC | 20:55 | |
*** datajerk has joined #openstack-ironic | 21:10 | |
*** datajerk has quit IRC | 21:19 | |
*** datajerk has joined #openstack-ironic | 21:23 | |
* NobodyCam steps outside for a minute | 21:25 | |
*** datajerk has quit IRC | 21:27 | |
NobodyCam | oh it is so nice out there | 21:30 |
*** linggao has quit IRC | 21:31 | |
*** tatyana has joined #openstack-ironic | 21:50 | |
*** blamar has joined #openstack-ironic | 21:50 | |
*** jdob has quit IRC | 21:54 | |
devananda | rebasing ... | 22:42 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: sync common.log from oslo https://review.openstack.org/56520 | 22:42 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: sync common.notifier.* from oslo https://review.openstack.org/56521 | 22:42 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: sync common.periodic_task from oslo https://review.openstack.org/56522 | 22:42 |
NobodyCam | rebasing what | 22:42 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: sync common.service from oslo https://review.openstack.org/56523 | 22:42 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Sync common utils from Oslo https://review.openstack.org/56517 | 22:42 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: sync common.local from oslo https://review.openstack.org/56518 | 22:42 |
NobodyCam | oh | 22:42 |
devananda | those :) | 22:42 |
*** romcheg has quit IRC | 23:01 | |
openstackgerrit | A change was merged to openstack/python-ironicclient: Comply with new hacking release https://review.openstack.org/56668 | 23:03 |
NobodyCam | devananda: you landing the oslo merges? | 23:04 |
devananda | NobodyCam: trying to. waiting for jenkins check,w hich seems slowtoday | 23:04 |
NobodyCam | :) | 23:04 |
devananda | NobodyCam: rloo's power state fix looks good to me. want to give it a read before we land it? | 23:04 |
NobodyCam | yep | 23:05 |
NobodyCam | lol how nit picky should we be | 23:07 |
rloo | NobodyCam: be very picky! | 23:08 |
NobodyCam | line #187 of | 23:08 |
NobodyCam | ironic/conductor/manager.py | 23:08 |
NobodyCam | :-p | 23:08 |
rloo | NobodyCam: ? | 23:09 |
NobodyCam | errored? | 23:09 |
rloo | oh wait, looking at wrong line i think. | 23:09 |
NobodyCam | your right I typoed | 23:10 |
NobodyCam | line 181 | 23:10 |
rloo | hmm, not sure which line? | 23:10 |
rloo | what would you like it to say? | 23:11 |
NobodyCam | errored | 23:11 |
NobodyCam | vs erred | 23:11 |
rloo | (NobodyCam: I copy/pasted what that deva guy wrote. but that's ok, i can put 'errored'.) | 23:12 |
devananda | :) | 23:12 |
NobodyCam | hehehe supper minor | 23:12 |
NobodyCam | don't bother | 23:12 |
devananda | rloo: that's what you get for copying off my homework! :) | 23:13 |
NobodyCam | :-p | 23:13 |
rloo | hmm, NobodyCam, are you sure the verb is 'errored'? Time for an English lesson. | 23:13 |
rloo | yeah, devananda, that's what I get for trying to get you to +2 my change. Ha ha. | 23:14 |
NobodyCam | asking google | 23:14 |
devananda | Oh | 23:14 |
devananda | oh. the question is erred vs errored? | 23:14 |
devananda | http://www.merriam-webster.com/dictionary/err | 23:15 |
rloo | NobodyCam: I don't use google;) I think erred is correct, http://www.thefreedictionary.com/erred. I'm not sure 'errored' is even a proper word. | 23:15 |
devananda | past tense of "err" | 23:15 |
devananda | err, to err, s/he erred, an error. | 23:16 |
NobodyCam | I think you are both right. I was wrong | 23:16 |
rloo | there you go. I copied the right person's homework. (Remind me not to copy NobodyCam's.) | 23:16 |
devananda | hehehehe | 23:16 |
NobodyCam | hehehehe | 23:16 |
NobodyCam | :) | 23:16 |
NobodyCam | :-p | 23:16 |
rloo | (phew.) | 23:16 |
rloo | NobodyCam. Seriously, I'm on vaca starting Wed, so if you have a few minutes to look it over today, that would give me time to do yet another update before I take off. | 23:17 |
NobodyCam | I'm looking now | 23:18 |
rloo | thx NobodyCam! I'll check in later for your comments; dinner time now. | 23:18 |
devananda | rloo: thanks for being patient with all the discussion around that bug/fix! | 23:20 |
devananda | rloo: in case I don't catch you tomorrow, I hope you have a great vacation :) | 23:20 |
NobodyCam | YEs.. and looks good. | 23:21 |
NobodyCam | looked at test coverage now | 23:21 |
NobodyCam | s/looked/looking/ | 23:21 |
NobodyCam | devananda: looks good to me. gota watch those assertNotEqual :-p | 23:31 |
NobodyCam | should I +A | 23:32 |
devananda | NobodyCam: yep | 23:32 |
NobodyCam | :) | 23:33 |
NobodyCam | Ruby Great Job! | 23:33 |
NobodyCam | rloo: ^^^^^ | 23:33 |
* NobodyCam goes walkies brb | 23:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!