| *** datajerk has joined #openstack-ironic | 01:16 | |
| *** michchap has joined #openstack-ironic | 01:26 | |
| *** michchap has quit IRC | 01:29 | |
| *** michchap has joined #openstack-ironic | 01:46 | |
| *** datajerk has quit IRC | 01:52 | |
| *** datajerk has joined #openstack-ironic | 01:57 | |
| *** michchap has quit IRC | 02:03 | |
| *** martyntaylor has joined #openstack-ironic | 03:08 | |
| *** datajerk has quit IRC | 04:00 | |
| *** martyntaylor1 has joined #openstack-ironic | 04:37 | |
| *** martyntaylor has quit IRC | 04:37 | |
| *** martyntaylor1 has quit IRC | 04:41 | |
| *** romcheg has joined #openstack-ironic | 04:43 | |
| *** romcheg has quit IRC | 04:46 | |
| *** datajerk has joined #openstack-ironic | 04:56 | |
| *** datajerk has quit IRC | 05:05 | |
| *** datajerk has joined #openstack-ironic | 05:57 | |
| *** datajerk has quit IRC | 06:01 | |
| *** martyntaylor has joined #openstack-ironic | 06:06 | |
| *** datajerk has joined #openstack-ironic | 06:28 | |
| *** datajerk has quit IRC | 06:32 | |
| *** datajerk has joined #openstack-ironic | 06:58 | |
| *** datajerk has quit IRC | 07:03 | |
| *** martyntaylor has quit IRC | 07:07 | |
| openstackgerrit | A change was merged to openstack/ironic: Add wrapper for keystone service catalog https://review.openstack.org/52601 | 07:07 |
|---|---|---|
| *** martyntaylor has joined #openstack-ironic | 07:07 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show https://review.openstack.org/53991 | 07:09 |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Change Port create API to EAFP https://review.openstack.org/54537 | 07:12 |
| *** datajerk has joined #openstack-ironic | 07:29 | |
| *** datajerk has quit IRC | 07:33 | |
| *** harlowja has quit IRC | 07:38 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: ipmitool SHOULD accept empty username/password https://review.openstack.org/54886 | 07:44 |
| *** harlowja has joined #openstack-ironic | 07:53 | |
| *** datajerk has joined #openstack-ironic | 08:00 | |
| *** datajerk has quit IRC | 08:05 | |
| *** datajerk has joined #openstack-ironic | 08:31 | |
| *** datajerk has quit IRC | 08:35 | |
| *** lifeless_ has joined #openstack-ironic | 08:55 | |
| *** lifeless has joined #openstack-ironic | 08:57 | |
| *** datajerk has joined #openstack-ironic | 09:01 | |
| *** datajerk has quit IRC | 09:05 | |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Allows unicode description for chassis https://review.openstack.org/54737 | 09:06 |
| *** martyntaylor has quit IRC | 09:23 | |
| *** martyntaylor has joined #openstack-ironic | 09:23 | |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Remove 'basestring' from objects utils https://review.openstack.org/55131 | 09:41 |
| *** martyntaylor has quit IRC | 09:52 | |
| *** martyntaylor has joined #openstack-ironic | 09:53 | |
| *** romcheg has joined #openstack-ironic | 09:56 | |
| *** romcheg has quit IRC | 10:03 | |
| *** martyntaylor has quit IRC | 10:03 | |
| *** martyntaylor has joined #openstack-ironic | 10:03 | |
| *** martyntaylor has quit IRC | 10:31 | |
| *** sjing has joined #openstack-ironic | 10:42 | |
| *** sjing has quit IRC | 12:17 | |
| *** sjing has joined #openstack-ironic | 13:03 | |
| *** jdob has joined #openstack-ironic | 13:19 | |
| *** bauzas has joined #openstack-ironic | 13:26 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Required fields on nodes https://review.openstack.org/53664 | 13:35 |
| *** datajerk has joined #openstack-ironic | 13:39 | |
| *** datajerk has quit IRC | 13:44 | |
| *** linggao has joined #openstack-ironic | 13:48 | |
| *** datajerk has joined #openstack-ironic | 13:51 | |
| *** jdob_ has joined #openstack-ironic | 13:52 | |
| *** jdob has quit IRC | 13:54 | |
| *** jdob_ is now known as jdob | 13:54 | |
| *** datajerk has quit IRC | 13:55 | |
| *** linggao_ has joined #openstack-ironic | 14:00 | |
| *** linggao_ has quit IRC | 14:02 | |
| *** linggao has quit IRC | 14:02 | |
| *** linggao_ has joined #openstack-ironic | 14:02 | |
| *** bauzas has quit IRC | 14:09 | |
| *** sjing has quit IRC | 14:10 | |
| *** bauzas has joined #openstack-ironic | 14:11 | |
| *** blamar has joined #openstack-ironic | 14:12 | |
| *** jbjohnso has joined #openstack-ironic | 14:14 | |
| *** martyntaylor has joined #openstack-ironic | 14:35 | |
| *** martyntaylor has left #openstack-ironic | 14:41 | |
| *** kobier has joined #openstack-ironic | 15:23 | |
| *** bauzas has quit IRC | 15:27 | |
| *** kobier has quit IRC | 15:40 | |
| *** linggao_ has quit IRC | 16:09 | |
| *** linggao has joined #openstack-ironic | 16:13 | |
| linggao | Hi max_lobur, | 16:20 |
| max_lobur | Hi linggao | 16:20 |
| linggao | one question on instance_uuid, /v1/nodes/?instance_uuid=<xxx> if no node has this intance_uuid, should we return an empty list or error? | 16:22 |
| linggao | I mean the REST API, | 16:23 |
| max_lobur | I think empty list will be consistent with other filters | 16:26 |
| max_lobur | so on the client | 16:27 |
| max_lobur | in show method | 16:27 |
| max_lobur | we could check if list is empty, and show the appropriate message to the user | 16:27 |
| max_lobur | but for REST API, since we semantically just applying a filter to the collection - IMO it should return an empty list | 16:28 |
| linggao | ok, I'll make the change accordingly. Currently, the REST API gives error saying 'Instance xxx could not be found" | 16:29 |
| max_lobur | hm | 16:29 |
| max_lobur | that's probably because of our db api. Because in DB API we have strict method get_node_by_instance | 16:32 |
| max_lobur | which is similar to get_node for example | 16:33 |
| max_lobur | it implements "one or error" behavior | 16:33 |
| linggao | yes, another thing is that get_node validates uuid first, get_node_by_instance does not. | 16:35 |
| max_lobur | yea. I think it should too, but not sure if we can to fix this in the same patch | 16:38 |
| max_lobur | so here is the problem | 16:41 |
| max_lobur | for collection filters we usually have something like get_nodes_by_chassis in DB API | 16:42 |
| max_lobur | but this time it's strict "one or error" | 16:42 |
| max_lobur | from one side it's consistent with DB - we can have only one node by instance id. also it's handy | 16:43 |
| linggao | yes, | 16:44 |
| max_lobur | from the other side it will be overhead for API classes | 16:44 |
| max_lobur | they would need to eat those exception to emulate that this was a usual collection query | 16:44 |
| linggao | that's because we put it in a collection | 16:44 |
| max_lobur | I'd rather change DB API than build workarounds.. | 16:46 |
| max_lobur | to get_nodes_by_instance_id | 16:46 |
| max_lobur | I think we should avoid such "strict get by a property" methods in db API since they cannot be reflected to REST concept | 16:48 |
| linggao | we need to bring this up to the team, but most folks are at Hong Kong Simmit. | 16:49 |
| linggao | summit | 16:49 |
| max_lobur | yea | 16:50 |
| max_lobur | those DB API was introduced by a separate patch.. | 16:50 |
| max_lobur | and I don't see any usages of this method except yours | 16:50 |
| max_lobur | and unit tests of course | 16:50 |
| max_lobur | I'm wondering if we will need a separate patch to update it | 16:51 |
| linggao | will get_node_by_instance be used in deployment process? | 16:52 |
| max_lobur | unfortunately I don't know. I searched ".get_node_by_instance(" string through the ironic project and found only unit tests | 16:53 |
| linggao | I like get_node_by _instance over get_nodes_by_instance because it should return one node. | 16:54 |
| max_lobur | I think for now you could eat those exception - create a new patch with workaround. And comment this workaround so we can bring this to the team and this will be visually clear that something wrong here. Anyway I left a few comments to you :P | 16:55 |
| max_lobur | yea, I like get_node_by_instance too, but if we will use it only in REST API classes it will make sence to refactor it | 16:57 |
| max_lobur | to be like get_nodes_by_chassis | 16:57 |
| linggao | anyway, I'll create a new patch for get_node_by_instance, through different exceptiions for different error, then the REST API will eat the "no node has this uuid" error and return an empty list. | 16:59 |
| linggao | through-> throw | 16:59 |
| max_lobur | yea | 16:59 |
| max_lobur | this will work in any case | 17:00 |
| linggao | yes, thanks max for your help. | 17:00 |
| max_lobur | sure, np =) | 17:00 |
| *** john-n-seattle1 has quit IRC | 18:17 | |
| *** john-n-seattle has joined #openstack-ironic | 18:26 | |
| *** harlowja has quit IRC | 18:58 | |
| linggao | anyone, I got "Authentication required" when using ironic REST APIs | 19:11 |
| linggao | any hint? | 19:11 |
| linggao | I reinstalled the openstack using devstack. | 19:11 |
| linggao | curl -X GET -H 'Content-Type:application/json' http://localhost:6385/v1/nodes/ | 19:15 |
| linggao | Authentication required | 19:15 |
| linggao | CLI works though. | 19:16 |
| *** anniec has joined #openstack-ironic | 21:40 | |
| *** jdob has quit IRC | 21:46 | |
| *** anniec has quit IRC | 21:47 | |
| *** harlowja has joined #openstack-ironic | 21:57 | |
| *** linggao has quit IRC | 22:07 | |
| NobodyCam | good morning from Hong Kong Ironic | 22:20 |
| *** jbjohnso has quit IRC | 22:30 | |
| *** harlowja has quit IRC | 22:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!