| *** openstack has joined #openstack-ironic | 22:47 | |
| neo_ | will get back to you NobodyCam after i do that. you dont suspect anything else wrong right? | 22:47 |
|---|---|---|
| NobodyCam | no every thing elese looks good | 22:50 |
| neo_ | thanks :) will get back to you in a bit. | 22:51 |
| neo_ | loong bit. | 22:51 |
| NobodyCam | neo_ are you working with CerealBox? | 22:51 |
| neo_ | yes we work in same team.... but different projects. | 22:51 |
| NobodyCam | ahhh :) ok | 22:51 |
| neo_ | we will buy you double beers | 22:52 |
| neo_ | :) | 22:52 |
| NobodyCam | lol | 22:52 |
| neo_ | thank you soo much. | 22:52 |
| NobodyCam | :) happy to help | 22:52 |
| NobodyCam | while you rebuild ... I'll brb | 22:53 |
| neo_ | sure, thanks :) | 22:54 |
| Haomeng | devananda:ping | 23:01 |
| Haomeng | NobodyCam: do you know if there is other fix for our Ironic Driver, I see this is canceled - https://review.openstack.org/#/c/51328/ | 23:03 |
| Haomeng | I like to see our Ironic driver | 23:03 |
| NobodyCam | hey Haomeng :) let me take a look | 23:08 |
| Haomeng | thank you | 23:08 |
| NobodyCam | ahh yes he forgot to mark that WIP | 23:09 |
| NobodyCam | it will be picked up again | 23:09 |
| NobodyCam | we are working on some things that needed to be fixed for that | 23:09 |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Support uniform MAC address with colons https://review.openstack.org/52761 | 23:10 |
| Haomeng | And letme check if it is existing in our Nova already | 23:12 |
| *** clarkb has joined #openstack-ironic | 23:12 | |
| NobodyCam | Haomeng: minor nit but can you add your name to the TODO so if there are questions we know who to ask | 23:12 |
| clarkb | NobodyCam: not sure if you noticed by openstack joined this channel, it is logged now | 23:12 |
| NobodyCam | clarkb: woo hoo the eavsdrop parch laneded | 23:13 |
| NobodyCam | landed even | 23:13 |
| clarkb | yeah I had to wait for a gap in meetings as adding channels currently requires a bot restart, we should fix that | 23:13 |
| NobodyCam | heheheh :) awesome Thank you clarkb | 23:14 |
| NobodyCam | Haomeng: lol looks like mr jenkins is going to force that. ./ironic/api/controllers/v1/port.py:160:15: H101 Use TODO(NAME) | 23:18 |
| Haomeng | :) | 23:19 |
| Haomeng | letme fix | 23:20 |
| Haomeng | I run flake8 in my local dev env, lookslike it cannot befound such todo validation | 23:21 |
| NobodyCam | you prob have h101 disabled | 23:22 |
| * clarkb chimes in. This is actually a big reason for using tox -r. It makes sure that you see what jenkins sees (there is still a small race between versions and stuff but that is minor) | 23:23 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Support uniform MAC address with colons https://review.openstack.org/52761 | 23:23 |
| Haomeng | yes, let me enable this option | 23:23 |
| NobodyCam | clarkb: Good point | 23:23 |
| clarkb | granted it is slower | 23:24 |
| Haomeng | shoud I add H101 into ./tox.ini? | 23:25 |
| clarkb | Haomeng: to ignore H101? I wouldn't do that, especially if ironic is currently passing that test | 23:27 |
| NobodyCam | I usaly add add to ignore | 23:28 |
| NobodyCam | there | 23:28 |
| NobodyCam | clarkb: :) | 23:28 |
| NobodyCam | ya not there | 23:28 |
| NobodyCam | it shouldbe enabled by default | 23:28 |
| Haomeng | I change code to" # TODO (whaom) - create a custom SQLAlchemy type like" | 23:28 |
| NobodyCam | :) | 23:28 |
| Haomeng | but for this round , still report 101: ./ironic/api/controllers/v1/port.py:160:15: H101 Use TODO(NAME) | 23:29 |
| Haomeng | any idea? | 23:29 |
| Haomeng | Not sure if additional space isnot required ? | 23:29 |
| clarkb | it may not like the space between TODO and the ( | 23:29 |
| Haomeng | ok | 23:29 |
| Haomeng | got | 23:29 |
| NobodyCam | :) | 23:29 |
| Haomeng | how to enable such 101 inmy local flake8 checking | 23:29 |
| Haomeng | thank you clarkb | 23:30 |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Support uniform MAC address with colons https://review.openstack.org/52761 | 23:31 |
| Haomeng | My local flake8 cannot check such 101 issue out | 23:31 |
| Haomeng | strange | 23:31 |
| Haomeng | One more question, I use devstack toenable our VIRT_DRIVER=baremetal and ENABLED_SERVICES="$ENABLED_SERVICES,baremetal", but the devstack failed | 23:34 |
| Haomeng | 2013-10-23 20:20:13 dnsmasq: unknown interface br99 | 23:34 |
| clarkb | Haomeng: how are you running flake8 and what version is it? | 23:34 |
| Haomeng | let me check flake8 version | 23:34 |
| clarkb | oh I know what the problem is | 23:35 |
| clarkb | you are running flake8 directly without the hacking plugin/extension installed probably | 23:35 |
| clarkb | (tox would take care of this) | 23:35 |
| Haomeng | root@ubuntu1:~/ironic# flake8 --version | 23:35 |
| Haomeng | 2.0 (pep8: 1.4.6, pyflakes: 0.7.3, mccabe: 0.2.1) | 23:35 |
| Haomeng | root@ubuntu1:~/ironic# | 23:35 |
| clarkb | yeah, I think you need to install hacking | 23:35 |
| Haomeng | clarkb: my flake8 is 2.0 | 23:35 |
| NobodyCam | failed how? | 23:36 |
| Haomeng | ok, just run "pip install hacking" right | 23:36 |
| clarkb | Haomeng: yes that should do it | 23:36 |
| Haomeng | Jenkins is not failed now, my local flake8 cannot check such todo issue out | 23:36 |
| Haomeng | clarkb: I installed 'hacking',now flake8 cancheck H101 issue,thankyou very much | 23:38 |
| Haomeng | thank you NobodyCam | 23:38 |
| NobodyCam | :) | 23:38 |
| clarkb | Haomeng: protip, install the test-requirements and requirements files to get the dependencies | 23:39 |
| * NobodyCam always heeds clarkb's tips | 23:40 | |
| clarkb | or use tox :) | 23:40 |
| Haomeng | yes,I have followed -http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 23:41 |
| Haomeng | maybe this doc missed 'hacking' in "Install prerequisites:" section | 23:42 |
| NobodyCam | :-p | 23:42 |
| NobodyCam | *(blush)* | 23:42 |
| Haomeng | or it missed in test-req , because I run "testr run" already | 23:43 |
| Haomeng | "testr init" will check test-requirement andinstall the reqlibs I think | 23:43 |
| Haomeng | should I fix this document issue? howdoyou think? | 23:43 |
| NobodyCam | Haomeng: that would be awesome | 23:44 |
| Haomeng | but not sure if I should add 'hacking' into "Install prerequisites:" section or add it into test-requirement ? | 23:45 |
| Haomeng | anyy comments? | 23:45 |
| clarkb | Haomeng: I think the install prerequisites section shouldn't have that third part | 23:46 |
| clarkb | it should have directions for installing system prereqs then rely on tox for testing | 23:46 |
| Haomeng | yes | 23:47 |
| Haomeng | clarkb, you mean we change tox? not sure how tofix | 23:48 |
| Haomeng | 'tox' is in current "Install prerequisites:" section | 23:49 |
| clarkb | Haomeng: tox is already in the docuemntation, just remove the stale bits about using easy_install to install noce and pip to install flake8 and friends | 23:49 |
| Haomeng | yes | 23:49 |
| clarkb | *nose | 23:49 |
| Haomeng | you mean I remove 'nose' to reinstall the dev env? | 23:49 |
| Haomeng | andhave a test? | 23:49 |
| clarkb | no you don't have to remove it, but you don't need to install it | 23:50 |
| clarkb | so that line in the documentation is old and not necessary | 23:50 |
| clarkb | it can just be removed, unless you guys are using nose? I think ironic forked from nova after it switched to testr | 23:50 |
| Haomeng | to remove "tox -evenv -- echo 'done'" this line? | 23:51 |
| Haomeng | yes Ironic use Nova env | 23:51 |
| Haomeng | I just want to fix thedocument to avoid other guys encounter such issue | 23:52 |
| Haomeng | I just follow the document tosetup dev env | 23:52 |
| Haomeng | will be backlater, to take care by baby:) | 23:52 |
| clarkb | Haomeng: https://git.openstack.org/cgit/openstack/ironic/tree/doc/source/dev/dev-quickstart.rst#n29 lines 29 and 30 | 23:53 |
| clarkb | those can be removed | 23:53 |
| clarkb | well 29 can be removed, 30 should be edit to just install tox | 23:53 |
| Haomeng | ok, thank you clarkb | 23:55 |
| Haomeng | will commit change and help me review:) | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!