| opendevreview | Merged openstack/project-config master: Fix wheel_volume values for centos stream wheel mirrors https://review.opendev.org/c/openstack/project-config/+/907150 | 05:05 |
|---|---|---|
| opendevreview | Jan Marchel proposed openstack/project-config master: Add new components to NebulOuS project: prediction-orchiestrator, exn-middleware, overlay-network-agent https://review.opendev.org/c/openstack/project-config/+/907060 | 09:54 |
| opendevreview | Jan Marchel proposed openstack/project-config master: Add new components to NebulOuS project: prediction-orchiestrator, exn-middleware, overlay-network-agent https://review.opendev.org/c/openstack/project-config/+/907060 | 10:12 |
| opendevreview | Merged openstack/pbr master: Use summary for the package summary https://review.opendev.org/c/openstack/pbr/+/906069 | 12:50 |
| *** ykarel__ is now known as ykarel | 14:04 | |
| fwiesel | Hello, how can I get a CI added to the "Third Party CI mail filter list"? According to the Wiki it would be contacting the Third Party Coordinators (https://review.opendev.org/admin/groups/440), but I am hesitant to write them directly. Also I've heard two of those people have left the openstack community years ago. | 14:47 |
| fungi | fwiesel: yes, i don't think any of them are around any longer. what project will you be performing testing for? maybe one of their maintainers would be interested in helping maintain the group going forward | 14:49 |
| frickler | fwiesel: on which wiki page did you find this? I'm not sure whether this is still relevant today | 14:54 |
| fwiesel | fungi: That would be for Nova (and soonish also Cinder). I've already asked in #openstack-nova and they send me here. | 14:57 |
| fwiesel | frickler: It's from here: https://docs.opendev.org/opendev/system-config/latest/third_party.html#creating-a-service-account . If it's not required, all the better. | 14:58 |
| fwiesel | To quote: It would also be a good idea to contact the Third Party Coordinators asking to add your account to the Third Party CI mail filter list. This is necessary to keep Gerrit from sending email messages every time an account comments on a patch. | 14:59 |
| clarkb | it is still a good idea | 15:00 |
| frickler | how does that work? the only reference in ACLs that I can see is for the opendev/sandbox repo | 15:02 |
| clarkb | frickler: it is an acl entry in All-Projects iirc | 15:04 |
| clarkb | `emailReviewers = deny group Third-Party CI` says our gerrit documentation in system-config | 15:05 |
| clarkb | https://review.opendev.org/admin/groups/0e4bf983f3754629fbc072bee2cbd39edb5de091,members this group owns the Third-Party CI group so any new volunteers should be added there (and they can clear out the old volunteers) | 15:08 |
| frickler | hmm, so I guess I can add myself as volunteer and clean things up a bit. fwiesel: what is the account name/id or email address for your CI? | 15:28 |
| fwiesel | frickler: The account name is sap-openstack-ci and the e-mail is (openstack-ci@sap.com) | 15:39 |
| frickler | fwiesel: thx, added | 15:43 |
| fwiesel | fricker: Thanks a lot! | 15:43 |
| d34dh0r53 | can someone please submit this: https://review.opendev.org/c/openstack/keystonemiddleware/+/751056?tab=change-view-tab-header-zuul-results-summary zuul isn't doing it for some reason | 16:40 |
| fungi | d34dh0r53: maybe start from a position of assuming there's a reason the change is unsubmittable? | 16:42 |
| fungi | in this case it's because the parent commit doesn't (and can't ever) exist on that branch | 16:43 |
| fungi | someone rebased the parent change but didn't rebase the rest of the relation chain | 16:43 |
| fungi | rebase those onto the branch tip and you should be able to approve them normally | 16:43 |
| fungi | in fact, there's nothing a zuul admin could do to "override" that situation, it really isn't able to be merged or even tested in that state because it's entirely disconnected from the target branch history by the revised parent | 16:44 |
| d34dh0r53 | ahh, thanks fungi | 16:46 |
| fungi | to be clear, the current patchset for 751056 has a parent commit which is patchset #2 of 751055, but 751055 was revised and patchset #3 was merged to the branch | 16:46 |
| d34dh0r53 | I should have looked first | 16:46 |
| d34dh0r53 | I just saw that it was submittable, but hadn't gone in yet | 16:46 |
| fungi | d34dh0r53: the red/pink "(Merged)" next to the parent change in the relation chain (top-right) is the giveaway. i agree gerrit's ui could use some improvement in making that more obvious | 16:47 |
| d34dh0r53 | oh, I didn't know that | 16:47 |
| fungi | d34dh0r53: also if you expand "SHOW ALL" on the top-left, it will show a "Parent" commit link and there's a circled "i" icon next to it which, if you hover over that, shows a tooltip that says "Not current - rebase possible" | 16:48 |
| fungi | again, way too subtle, but those are the clues i look for first when this happens | 16:48 |
| JayF | I had to spend a while explaining some portion of this to a new contributor yesterday. | 16:49 |
| d34dh0r53 | Are the gerrit colors documented somewhere? | 16:50 |
| fungi | if they are it'll be under https://review.opendev.org/Documentation/ somewhere | 16:50 |
| fungi | maybe https://review.opendev.org/Documentation/user-review-ui.html though it's rather light on detail | 16:51 |
| fungi | d34dh0r53: aha! it's "orange" apparently, according to https://review.opendev.org/Documentation/user-review-ui.html#related-changes | 16:52 |
| fungi | "If the relationship to submitted change falls under conditions described in Not current the status is orange" | 16:52 |
| fungi | and yes, the fact that it shows "(Submittable)" next to the current change in that situation seems rather misleading | 16:54 |
| d34dh0r53 | Yeah, that's what was really confusing | 16:55 |
| fungi | though the description of submittable does say "can be submitted when all of its ancestors are submitted" and technically one of its ancestors isn't submitted (a different revision of the same change was instead), so it's not wrong per se, but it would be nicer if they changed that | 16:55 |
| d34dh0r53 | I noticed that | 16:56 |
| clarkb | I think submittable in the UI refers to the vote states only | 16:57 |
| clarkb | and yes it is confusing | 16:57 |
| d34dh0r53 | thank you fungi, JayF and clarkb I've rebased on the parent change that was submitted and it's re-gating | 17:03 |
| fungi | d34dh0r53: awesome, glad we could help. let us know if you need anything else! | 17:03 |
| d34dh0r53 | will do | 17:04 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!