| *** gce108_ is now known as gce108 | 01:02 | |
| *** elodilles is now known as elodilles_pto | 06:49 | |
| *** jpena|off is now known as jpena | 08:37 | |
| opendevreview | Dr. Jens Harbott proposed openstack/project-config master: Fix approval check for post-review trigger https://review.opendev.org/c/openstack/project-config/+/877453 | 09:16 |
|---|---|---|
| opendevreview | Merged openstack/project-config master: Fix approval check for post-review trigger https://review.opendev.org/c/openstack/project-config/+/877453 | 09:38 |
| opendevreview | Artem Goncharov proposed openstack/project-config master: Add post-review pipeline reporting https://review.opendev.org/c/openstack/project-config/+/877458 | 10:37 |
| opendevreview | Merged openstack/project-config master: Add post-review pipeline reporting https://review.opendev.org/c/openstack/project-config/+/877458 | 10:58 |
| *** blarnath is now known as d34dh0r53 | 12:23 | |
| *** jpena is now known as jpena|off | 17:42 | |
| opendevreview | Ian Y. Choi proposed openstack/openstack-zuul-jobs master: Start translations for 2023.1 (Antelope) stable branch https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/877550 | 19:56 |
| gmann | clarkb: frickler: fungi: stable/2023.2 job template change is ready now https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/873051 | 20:13 |
| clarkb | gmann: small thing inline but +2'd anyway | 20:17 |
| fungi | oh, yeah inaccurate descriptions. good catch | 20:19 |
| gmann | fungi: clarkb: thanks, let me update as that complete line is not correct now because we use that template for stable branch also | 20:19 |
| opendevreview | Ghanshyam proposed openstack/openstack-zuul-jobs master: Prepare the 2023.2 cycle testing job template https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/873051 | 20:25 |
| gmann | clarkb: fungi ^^ updated | 20:26 |
| opendevreview | Jeremy Stanley proposed openstack/project-config master: Temporarily remove release docs semaphores https://review.opendev.org/c/openstack/project-config/+/877552 | 20:28 |
| opendevreview | Jeremy Stanley proposed openstack/project-config master: Revert "Temporarily remove release docs semaphores" https://review.opendev.org/c/openstack/project-config/+/877553 | 20:28 |
| fungi | gmann: the new patchset to 873051 seems to mix the edits with a rebase, so i can't easily compare it to the previous version. was there a reason to rebase it? in the future, rebasing and editing as separate revisions is helpful to reviewers so they won't need to reread your entire change | 20:41 |
| clarkb | fungi: if it was rebased the gerrit web ui is filtering that uout | 20:41 |
| clarkb | https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/873051/2..3/zuul.d/project-templates.yaml renders fine | 20:42 |
| fungi | yeah, it looks like the rebase didn't include new edits to that specific file, only to other files in the repo | 20:44 |
| clarkb | ah | 20:44 |
| fungi | so i was able to skip to the project-templates file and follow the updates in it at least | 20:44 |
| gmann | let me check | 20:45 |
| fungi | i guess the gerrit webui spotted that, while basic git shows all the differences | 20:45 |
| clarkb | I think gerrit knows the old and new sides only changed that file so you don't care about any other deltas that show up from merges/rebases | 20:45 |
| fungi | yes, it seems like it's an optimization applied by gerrit's ui | 20:46 |
| gmann | I rebase to avoid any conflict or get latest changes as it was last updated long back | 20:47 |
| clarkb | gmann: if the rebase is clean without conflict then you don't need the rebase and zuul will test with the merged result | 20:47 |
| clarkb | zuul does a lot of the heavy lifting to ensure that you only need to rebase to resolve conflicts that git is incapable of handling on its own | 20:48 |
| fungi | git review will check it for you when you're submitting the change and tell you if there's a conflict | 20:48 |
| fungi | and yeah, otherwise rebasing "just to update" is unnecessary when testing with zuul | 20:49 |
| fungi | the change will be automatically merged to the current branch state when jobs are run | 20:49 |
| fungi | but yeah, if you `git diff refs/changes/51/873051/2 refs/changes/51/873051/3` you'll see the differences gerrit's ui is filtering out | 20:50 |
| opendevreview | Merged openstack/openstack-zuul-jobs master: Prepare the 2023.2 cycle testing job template https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/873051 | 20:51 |
| clarkb | oh thats a good point. git-review also tries to help and tells you when a rebase is necessary. Otherwise just run git-review and it should be fine | 20:52 |
| gmann | sure | 20:56 |
| gmann | I usually check diff in UI and it filter out and if in same file it is lightly highlighted so we can know what is rebase change | 20:57 |
| gmann | but I agree that we can avoid rebase unless conflict | 20:57 |
| fungi | probably gertty could do some similar heuristics as the gerrit webui to not show interdiffs for files not changed by the revision selected, but today it's just straight git diff between the refs | 20:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!