| *** yadnesh|away is now known as yadnesh | 04:03 | |
| *** chandankumar is now known as chkumar|ruck | 04:41 | |
| *** akekane is now known as abhishekk | 05:07 | |
| *** yadnesh is now known as yadnesh|afk | 08:00 | |
| *** yadnesh|afk is now known as yadnesh | 08:30 | |
| *** jpena|off is now known as jpena | 08:37 | |
| *** jpena is now known as jpena|off | 08:38 | |
| *** jpena|off is now known as jpena | 08:38 | |
| *** dviroel|afk is now known as dviroel|rover | 11:06 | |
| *** rlandy|out is now known as rlandy | 11:14 | |
| *** frenzy_friday is now known as frenzy_friday|food | 12:38 | |
| opendevreview | Merged openstack/project-config master: Allow Designate cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863932 | 13:38 |
|---|---|---|
| opendevreview | Merged openstack/project-config master: Allow Octavia cores to toggle WIP state https://review.opendev.org/c/openstack/project-config/+/863934 | 13:38 |
| opendevreview | Merged openstack/project-config master: Releasing tripleo-ansible as PyPi deliverable https://review.opendev.org/c/openstack/project-config/+/866839 | 13:38 |
| opendevreview | Merged openstack/project-config master: ironic-release group for releasing+maint of bugfix https://review.opendev.org/c/openstack/project-config/+/866937 | 13:38 |
| opendevreview | Merged openstack/project-config master: Fix nodepool API ops Grafana graphs https://review.opendev.org/c/openstack/project-config/+/867054 | 13:56 |
| *** dasm|off is now known as dasm | 14:03 | |
| opendevreview | Ade Lee proposed openstack/project-config master: Add FIPS job for ubuntu https://review.opendev.org/c/openstack/project-config/+/867112 | 14:13 |
| *** dviroel|rover is now known as dviroel|rover|afk | 14:40 | |
| *** frenzy_friday|food is now known as frenzy_friday | 14:50 | |
| ade_lee__ | fungi, so - if I understand you correctly - I need to define a base job like I do in the patch above -- but to use this, I need to inherit from this job. | 14:50 |
| ade_lee__ | fungi, is there any way to avoid having to duplicate the entire inheritance stack? | 14:51 |
| ade_lee__ | for example - if I want to have a devstack gate for nova - the inheritance chain looks like tempest-full-py -> devstack-tempest -> devstack -> devstack-minimal -> devstack-base -> multinode | 14:53 |
| ade_lee__ | I guess what I could do is have multinode depend on my new job and invoke the subscription code conditionally with default being false | 14:54 |
| fungi | ade_lee__: it might work to have devstack-base inherit from the ua setup job and then make that inherit from multinode | 14:57 |
| fungi | multinode is part of zuul-jobs so changing its inheritance isn't really going to work i don't think | 14:58 |
| fungi | clarkb might have suggestions once he's around | 14:58 |
| *** yadnesh is now known as yadnesh|away | 16:17 | |
| clarkb | sorry slow start today | 16:27 |
| clarkb | I wouldn't chngae the low level base jobs like that. They are meant to be generic enough and fips doesn't fit that bill imo. | 16:28 |
| clarkb | you could add it to the devstack base jobs and make it conditional though | 16:28 |
| fungi | clarkb: inherit from it in devstack-base you mean? the playbook has to be in project-config so it can use the secret housed there | 16:40 |
| fungi | if so, that's what i was trying to suggest but i wasn't 100% sure it would work so just looking for confirmation we're on the right track | 16:41 |
| fungi | right now devstack:devstack-base inherits from zuul-jobs:multinode, so the idea would be to inject a new abstract job between them in the chain like devstack:devstack-base -> project-config:enable-ua -> zuul-jobs:multinode | 16:43 |
| fungi | though i'm not certain the enable-ua pre-run playbook would execute early enough if we wedge it in there | 16:44 |
| fungi | i don't recall where the current reboot happens for devstack fips jobs | 16:44 |
| clarkb | fungi: ya something like that should work assuming it is early enough for rebooting | 16:45 |
| clarkb | really the fips stuff already exists right? we just need to toggle ua on before the fips stuff attempts to run? | 16:46 |
| clarkb | in that case we need to identify specifically where fips is enabled in the stack and then look at enabling ua with a parent job before that | 16:47 |
| fungi | looks like it's in zuul-jobs:multinode-fips | 16:50 |
| clarkb | One option would be to just enable ua in that job | 16:52 |
| fungi | and also in zuul-jobs:unittests-fips | 16:52 |
| clarkb | oh but they are in zuul-jobs | 16:52 |
| fungi | how do we do that with the secret being in project-config though? | 16:52 |
| clarkb | I don't think you can and this presents a chicken and egg because we can't have zuul-jobs depend on anything out side of zuul-jobs | 16:53 |
| clarkb | you oculd modify things to do pass to parent secrets I suppose | 16:53 |
| clarkb | that might be acceptable in this instance? | 16:54 |
| fungi | oh, though maybe zuul-jobs:multinode-fips is a red herring. i don't see it actually getting inherited anywhere | 16:54 |
| fungi | looks like openstack-zuul-jobs:tempest-centos8-stream-fips directly includes the ensure-fips role | 16:56 |
| fungi | and inherits from tempest:devstack-tempest | 16:57 |
| clarkb | in thta case a new project-config:tempest-fips job is appropriate. It can enable ua and run ensure-fips. | 16:57 |
| clarkb | Then slot that between the existing inheritancy path | 16:58 |
| fungi | yep | 16:58 |
| fungi | so tempest:tempest-fips -> project-config:setup-ua -> tempest:devstack-tempest ? | 16:59 |
| clarkb | ya | 16:59 |
| fungi | er, i guess it would be more like project-config:tempest-ua | 16:59 |
| clarkb | it probably doesn't need to be specific to tempest in project-config actually | 16:59 |
| fungi | and then something similar for the unit test jobs in openstack-zuul-jobs | 16:59 |
| clarkb | since enabling ua should be the same steps whether it is tempest or a unittest | 17:00 |
| fungi | yeah, but how do you rectify the need for a different inheritance chain under it? | 17:00 |
| clarkb | oh right | 17:00 |
| fungi | the tempest jobs and unit test jobs don't really share ancestors | 17:00 |
| fungi | both jobs could still reuse the same playbook and role of course | 17:01 |
| fungi | but would need to be differentiated job defs because of having different ancestry | 17:01 |
| fungi | i suppose the role could even go in zuul/zuul-jobs it would just need to be included by a playbook in openstack/project-config | 17:04 |
| *** benj_78 is now known as benj_7 | 17:11 | |
| *** jpena is now known as jpena|off | 17:31 | |
| *** dviroel|rover|afk is now known as dviroel|rover | 18:05 | |
| *** dasm is now known as dasm|off | 21:13 | |
| *** dviroel|rover is now known as dviroel|out | 21:20 | |
| *** tosky is now known as Guest1527 | 22:34 | |
| *** tosky_ is now known as tosky | 22:34 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!