| *** rlandy|bbl is now known as rlandy|out | 00:02 | |
| clarkb | JayF: it was hacking that did it and yes | 00:30 |
|---|---|---|
| clarkb | I suspect that is starglinx actually wanting to check those rules | 00:30 |
| clarkb | but I asked them to not put them in zuul/zuul-jobs beacuse they are openstack specific (they come out of the openstack wiki) and zuul itself doesn't follow them | 00:30 |
| clarkb | anyway I think it is ok to have in an opesntack context and things can opt into using it, but I agree in general I'm not a fan | 00:30 |
| clarkb | better to gently guide people to improve their commit messages through example and review | 00:31 |
| clarkb | (one thing that I find particularly helpful in a commit message is answer the question "why?" and you can't capture that with a linter like this | 00:31 |
| JayF | I've always been of the opinion that if you can't enforce the standard of "What is this supposed to do?" being laid out in the commit message or associated metadata via code review... well you need to review code better! How do you know something does what it should unless you know what it's trying to do :D | 00:51 |
| fungi | equally important, or perhaps even more so, is to answer the "why" it's needed | 00:55 |
| fungi | explaining what a change does may be important if the implementation is not trivial, but that rarely means a reviewer will automatically intuit the reason for doing it | 00:56 |
| *** ysandeep|out is now known as ysandeep | 04:53 | |
| *** ysandeep is now known as ysandeep|ruck | 04:55 | |
| *** akahat|ruck is now known as akahat | 05:42 | |
| *** ysandeep|ruck is now known as ysandeep|lunch | 07:28 | |
| *** jpena|off is now known as jpena | 07:42 | |
| *** ysandeep|lunch is now known as ysandeep|ruck | 09:22 | |
| *** rlandy|out is now known as rlandy | 10:30 | |
| *** ysandeep|ruck is now known as ysandeep|brb | 10:51 | |
| *** ysandeep|brb is now known as ysandeep | 11:05 | |
| *** dviroel|afk is now known as dviroel | 11:26 | |
| *** ysandeep is now known as ysandeep|ruck | 12:30 | |
| *** dasm|off is now known as dasm | 14:26 | |
| opendevreview | Thiago Paiva Brito proposed openstack/openstack-zuul-jobs master: Adding git commit message guidelines check https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/848342 | 14:36 |
| opendevreview | Thiago Paiva Brito proposed openstack/openstack-zuul-jobs master: Adding git commit message guidelines check https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/848342 | 14:56 |
| opendevreview | Thiago Paiva Brito proposed openstack/openstack-zuul-jobs master: Adding git commit message guidelines check https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/848342 | 15:03 |
| *** dviroel is now known as dviroel|lunch | 15:25 | |
| opendevreview | Elvira García Ruiz proposed openstack/devstack-gate master: Replace old Neutron job name with new name https://review.opendev.org/c/openstack/devstack-gate/+/848463 | 15:31 |
| *** ysandeep|ruck is now known as ysandeep|dinner | 15:43 | |
| *** jpena is now known as jpena|off | 15:59 | |
| *** dviroel|lunch is now known as dviroel | 16:45 | |
| *** ysandeep|dinner is now known as ysandeep|out | 17:31 | |
| opendevreview | Thiago Paiva Brito proposed openstack/openstack-zuul-jobs master: Adding git commit message guidelines check https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/848342 | 17:41 |
| melwitt | dpawlik: hey, just saw the [tc] email on openstack-discuss about e-r coming back. is it going to be in the dashboards list in opensearch or somewhere else? | 19:20 |
| fungi | dasm is the one working on that, i think, so may also know what the plan is for where its ui will end up | 19:22 |
| melwitt | ah, thanks | 19:23 |
| fungi | frenzy_friday also may have some idea | 19:23 |
| dasm | melwitt: not sure yet where it's gonna be avail. but we'll def let everyone know | 19:32 |
| dpawlik | probably we will deploy the e-r dashboard on the same host as logscraper is. | 19:33 |
| dpawlik | so far we need to have working e-r, then we can think to deploy it | 19:33 |
| dpawlik | will be good to create some subdomain for it | 19:33 |
| dasm | indeed. atm, e-r doesn't work | 19:33 |
| fungi | i can certainly add a something.openstack.org for it when you're ready, just let me know | 19:34 |
| fungi | add to dns i mean | 19:34 |
| * dasm is thinly spread, so it takes some time | 19:34 | |
| dasm | fungi++ | 19:34 |
| fungi | i can definitely relate to that! | 19:34 |
| melwitt | gotcha, thanks! I might have misread the email a bit, thinking it was very imminent.. sorry bout that! | 19:36 |
| dpawlik | dasm: let me know if you need some help | 19:37 |
| dasm | dpawlik++ | 19:37 |
| dasm | melwitt: it's the idea to get it running asap. the day is too short, tho :) | 19:39 |
| melwitt | dasm: I understand :) looking forward to it. if there's any way I can help like reviews or anything, please lmk | 19:40 |
| dasm | first stop: https://review.opendev.org/q/project:opendev%252Felastic-recheck+status:open | 19:41 |
| dasm | :) | 19:41 |
| melwitt | got it! and funny a review from me to add a query 1.5 years ago is still there 😂 | 19:45 |
| dasm | :D | 19:45 |
| opendevreview | Thiago Paiva Brito proposed openstack/openstack-zuul-jobs master: Adding git commit message guidelines check https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/848342 | 20:25 |
| opendevreview | Thiago Paiva Brito proposed openstack/openstack-zuul-jobs master: Adding git commit message guidelines check https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/848342 | 20:33 |
| opendevreview | Thiago Paiva Brito proposed openstack/openstack-zuul-jobs master: Adding git commit message guidelines check https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/848342 | 20:44 |
| *** dasm is now known as dasm|off | 21:07 | |
| *** dasm|off is now known as dasm | 21:09 | |
| *** dasm is now known as Guest3965 | 21:10 | |
| *** Guest3965 is now known as dasm | 21:12 | |
| *** dasm is now known as dasm|off | 21:13 | |
| *** dasm|off is now known as dasm | 21:13 | |
| *** dasm is now known as dasm|off | 21:13 | |
| *** dviroel is now known as dviroel|afk | 21:40 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!