| *** rpittau|afk is now known as rpittau | 07:55 | |
| *** ykarel_ is now known as ykarel | 08:52 | |
| *** ykarel_ is now known as ykarel | 09:03 | |
| opendevreview | Andreas Jaeger proposed openstack/project-config master: Retire ara projects https://review.opendev.org/c/openstack/project-config/+/777675 | 10:44 |
|---|---|---|
| *** jcapitao is now known as jcapitao_lunch | 11:00 | |
| opendevreview | sean mooney proposed openstack/openstack-zuul-jobs master: add tex-gyre package for tgtermes.sty https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/802296 | 11:37 |
| *** jcapitao_lunch is now known as jcapitao | 12:33 | |
| smcginnis | Howdy infra folks. There have been open reviews for the openstack/bugdaystats repo since 2018. Checking group ACLs, only openstack-infra is still in the group. It's a low activity project, but if I can be added, happy to get things caught up there. | 13:46 |
| zul | I have a bunch of cherrypicks in a branch can I submit them all at once to gerrit and how? | 13:51 |
| smcginnis | zul: When you submit it, each commit will become a separate gerrit review. Order depends on whatever order the commits are stacked. The .gitreview file at the root of the repo should make sure the reviews are submitted to the right stable branch. | 14:02 |
| *** gibi is now known as gibi_pto | 14:03 | |
| zul | smcginnis: so i just run git review? | 14:05 |
| zul | https://pastebin.com/hWAn3PKr | 14:06 |
| smcginnis | zul: It looks like one of the commits is dependent on an abandones change - https://review.opendev.org/c/starlingx/gui/+/799540 | 14:11 |
| zul | ugh ok | 14:12 |
| smcginnis | But that's on master. Since you mentioned cherry-picks, I assumed you were trying to push changes to a stable branch, so not sure why the change on master matters. Make sure anything to stable has already been merged on master. | 14:12 |
| fungi | smcginnis: happy to add you to bugdaystats-core in a few minutes | 14:12 |
| smcginnis | Thanks fungi! | 14:13 |
| fungi | smcginnis: okay, i've added you to the bugdaystats groups in gerrit now. approve what you like | 14:24 |
| smcginnis | Thanks again! | 14:24 |
| fungi | any time | 14:25 |
| opendevreview | Stephen Finucane proposed openstack/openstack-zuul-jobs master: add tex-gyre package for tgtermes.sty https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/802296 | 14:41 |
| stephenfin | fungi: Who can we poke to get that ^ merged? Looks like it should fix the nova gate | 14:42 |
| fungi | any of the config-core reviewers can, i'll give it a quick onceover | 14:44 |
| fungi | stephenfin: is this related to the sphinx update thread on the ml? | 14:45 |
| stephenfin | both related in that the Sphinx update has broken things | 14:46 |
| stephenfin | but it's a different break | 14:46 |
| stephenfin | I hadn't seen that issue. Will take a look now | 14:46 |
| fungi | ahh, okay, mostly was looking for context. which pdf-docs job does it fix, have an example? https://zuul.opendev.org/t/openstack/builds?job_name=pdf-docs turns up nothing | 14:47 |
| stephenfin | https://zuul.opendev.org/t/openstack/build/e58c187bc90f43c8a2bb189a54c6175d/log/sphinx-build-pdf.log | 14:50 |
| stephenfin | that kind of failure | 14:50 |
| stephenfin | looking at https://zuul.opendev.org/t/openstack/status#openstack/nova, everything in the check queue is currently failing with that | 14:51 |
| fungi | got it, thanks for the context | 14:54 |
| fungi | have you confirmed via depends-on to 802296 that it fixes the problem? | 14:54 |
| fungi | or confirmed locally? | 14:54 |
| *** ykarel is now known as ykarel|away | 14:56 | |
| clarkb | considering its just a package install add I think we can approve it and sort out later if it doesn't fully fix things | 14:57 |
| fungi | yeah | 14:57 |
| clarkb | I need to find my keys to login and do that. Will get that done momentarily | 14:58 |
| fungi | i've added the relevant context from this discussion in a review comment | 15:00 |
| stephenfin | yeah, there are a couple of references to the package already too https://codesearch.opendev.org/?q=tex-gyre&i=nope&files=&excludeFiles=&repos= | 15:00 |
| stephenfin | Can set up a DNM patch to prove it out but it'll be an hour - running a meeting rn | 15:01 |
| fungi | stephenfin: no need, looks straightforward enough i think we'll just approve it and hope things improve | 15:01 |
| clarkb | ya I have approved it | 15:01 |
| fungi | stephenfin: i was mainly wondering if you had already confirmed it worked | 15:02 |
| opendevreview | Merged openstack/openstack-zuul-jobs master: add tex-gyre package for tgtermes.sty https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/802296 | 15:09 |
| sean-k-mooney | clarkb: fungi by the way i noticed that the docs job is not using the doc or pdf-docs bindep profiles to install the packages requried | 15:26 |
| sean-k-mooney | is that intentional | 15:26 |
| clarkb | sean-k-mooney: I'm assuming people added those tags to the repos but then never really officialized them in the jobs? But I don't know the history there | 15:27 |
| sean-k-mooney | i was orginally just going to add that package to the nova jobs then i noticed that we were not installing the packages with bindep | 15:27 |
| clarkb | My hunch is that people adding pdf jobs didn'twant to need to update every repo to tweak the deps just for pdf building so centralized it instead | 15:27 |
| sean-k-mooney | well the pdf docs requires a new tox env | 15:27 |
| clarkb | then later as people wanted to do the builds locally they updated bindep in the repos they care about | 15:28 |
| sean-k-mooney | to be defiend in each repo anyway | 15:28 |
| clarkb | but I wasn't super involved in that process other than to high encourage trimming of the deps list so taht we don't do 3GB of package installs every run | 15:28 |
| sean-k-mooney | i think we used to use the docs on in the past | 15:28 |
| sean-k-mooney | anyway hopefully that was enough to fix the job | 15:30 |
| sean-k-mooney | ok yes so https://zuul.opendev.org/t/openstack/build/ee1b813d633e4853ac92b0a0b2d6b088 now passed | 15:38 |
| fungi | i agree if there's a way to determine that the openstack-tox-docs job should build a pdf for a particular project then the job should probably install any packages included in the pdf-docs profile in bindep.txt | 15:47 |
| sean-k-mooney | right now it seams to be calling bindep but just with the base profile | 15:49 |
| sean-k-mooney | i did find a refrence to useint the compile and doc profile soemwhere but i forget where that was | 15:50 |
| clarkb | the compile profiel is used a lot in our docker image builds | 15:50 |
| sean-k-mooney | its was here https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/jobs.yaml#L690 | 15:52 |
| sean-k-mooney | it does not include pdf-docs however | 15:53 |
| sean-k-mooney | im also not sure that that is actully used when set | 15:53 |
| sean-k-mooney | i can see that the job does invoke bindep | 15:53 |
| sean-k-mooney | but it does not have all the packages i would expect based on the doc tag | 15:53 |
| sean-k-mooney | this is what was installed https://zuul.opendev.org/t/openstack/build/ee1b813d633e4853ac92b0a0b2d6b088/log/job-output.txt#450 | 15:54 |
| sean-k-mooney | well actully nova does not have much with doc and does not use compile | 15:55 |
| sean-k-mooney | so that might eb working but currently its not installing pdf-docs | 15:55 |
| sean-k-mooney | which i guess makes sense | 15:56 |
| sean-k-mooney | the only project that use pdf-docs in the bindep defienion are the ones where i added or fixed the pdf-doc gengeration | 15:57 |
| sean-k-mooney | and in does case i explitly used pdf-docs no doc for the deps to not install the pdf deps in the jobs that did not need them | 15:59 |
| fungi | so sounds like something we could standardize on (and document in the pti) | 15:59 |
| sean-k-mooney | we could although in this case it proably woudl not have prevented the issue since the new package we are installing was not in bindep anyway | 16:02 |
| sean-k-mooney | it was previously tranistivly instlaled by one of the other packages | 16:03 |
| sean-k-mooney | or the style was unused until the new sphinx was released | 16:03 |
| sean-k-mooney | the job started failing after a new sphinx release right? | 16:04 |
| fungi | according to stephenfin, yes | 16:09 |
| *** rlandy is now known as rlandy|ruck | 16:10 | |
| opendevreview | Riccardo Pittau proposed openstack/openstack-zuul-jobs master: Add template for lower-constraints on master branch only https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/802335 | 16:20 |
| smcginnis | Trying to clean up old reviews. If someone from infra-core has a minute, this should be an easy one to get out of the way - https://review.opendev.org/c/opendev/puppet-infra-cookiecutter/+/708452 | 16:30 |
| *** rpittau is now known as rpittau|afk | 16:37 | |
| fungi | smcginnis: thanks, though i have a feeling we can retire that as we don't intend to add more puppet modules for our infrastructure anyway | 16:51 |
| fungi | maybe worth discussing in #opendev whether we ought to consider retiring all the puppet-related stuff for opendev which isn't still in use | 16:51 |
| opendevreview | Merged openstack/project-config master: Retire ara projects https://review.opendev.org/c/openstack/project-config/+/777675 | 17:05 |
| clarkb | fungi: I did a pass at cleaning stuff out of system-config semi recently. Retiring the modules is probably a good idea too | 17:17 |
| opendevreview | Sean McGinnis proposed openstack/bugdaystats master: Fix pep8 tox environment https://review.opendev.org/c/openstack/bugdaystats/+/602864 | 18:37 |
| opendevreview | Sean McGinnis proposed openstack/bugdaystats master: Remove use of simplejson library https://review.opendev.org/c/openstack/bugdaystats/+/409166 | 18:37 |
| opendevreview | Merged openstack/bugdaystats master: Fix pep8 tox environment https://review.opendev.org/c/openstack/bugdaystats/+/602864 | 18:57 |
| opendevreview | Merged openstack/bugdaystats master: Remove use of simplejson library https://review.opendev.org/c/openstack/bugdaystats/+/409166 | 18:57 |
| opendevreview | Sean McGinnis proposed openstack/bugdaystats master: Introduce daily bug stats chart https://review.opendev.org/c/openstack/bugdaystats/+/372581 | 19:06 |
| opendevreview | Merged openstack/bugdaystats master: Introduce daily bug stats chart https://review.opendev.org/c/openstack/bugdaystats/+/372581 | 19:31 |
| opendevreview | Sean McGinnis proposed openstack/bugdaystats master: Update for py3 support https://review.opendev.org/c/openstack/bugdaystats/+/802391 | 19:53 |
| opendevreview | Merged openstack/bugdaystats master: Update for py3 support https://review.opendev.org/c/openstack/bugdaystats/+/802391 | 20:04 |
| *** prometheanfire is now known as Guest2352 | 22:56 | |
| *** ChanServ changes topic to "Discussion of OpenStack's Developer tooling and CI jobs | Discussion around infrastructure services now in #opendev" | 23:02 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!