Friday, 2021-01-29

*** zxiiro has quit IRC00:04
*** hashar has quit IRC00:05
*** jamesmcarthur has quit IRC00:16
*** jamesmcarthur has joined #openstack-infra00:17
*** snapiri has quit IRC00:18
*** snapiri has joined #openstack-infra00:18
*** fdegir5 has joined #openstack-infra00:19
*** jaicaa has quit IRC00:19
*** fdegir has quit IRC00:19
*** jaicaa has joined #openstack-infra00:19
*** abhishekk has quit IRC00:20
*** jamesmcarthur has quit IRC00:20
*** jamesmcarthur has joined #openstack-infra00:20
*** tosky has quit IRC00:23
*** rm_work has quit IRC00:37
*** logan- has quit IRC00:38
*** logan- has joined #openstack-infra00:40
*** dychen has joined #openstack-infra00:44
*** yamamoto_ has joined #openstack-infra00:45
*** yamamoto has quit IRC00:46
*** dchen has quit IRC00:47
*** tbachman has quit IRC00:49
*** tbachman has joined #openstack-infra00:49
*** dviroel has quit IRC00:52
*** zxiiro has joined #openstack-infra01:08
*** ttx has quit IRC01:11
*** Adri2000 has quit IRC01:11
*** larsks has quit IRC01:11
*** ttx has joined #openstack-infra01:12
*** Adri2000 has joined #openstack-infra01:12
*** larsks has joined #openstack-infra01:12
*** jistr has quit IRC01:13
*** jistr has joined #openstack-infra01:13
*** cyberpear has quit IRC01:13
*** mnaser has quit IRC01:13
*** thedac has quit IRC01:13
*** JanZerebecki[m] has quit IRC01:14
*** reed has quit IRC01:14
*** wolsen has quit IRC01:14
*** mordred has quit IRC01:15
*** thedac has joined #openstack-infra01:15
*** mnaser has joined #openstack-infra01:16
*** cyberpear has joined #openstack-infra01:16
*** Wasaac has quit IRC01:22
*** gyee has quit IRC01:22
*** Wasaac has joined #openstack-infra01:23
*** rm_work has joined #openstack-infra01:25
*** rm_work has quit IRC01:25
*** mordred has joined #openstack-infra01:44
*** JanZerebecki[m] has joined #openstack-infra01:45
*** wolsen has joined #openstack-infra01:46
*** dklyle has quit IRC01:51
*** rm_work has joined #openstack-infra02:01
*** JanZerebecki[m] has quit IRC02:03
*** wolsen has quit IRC02:04
*** mordred has quit IRC02:04
openstackgerritMerged openstack/project-config master: Add official-openstack-repo-jobs for openstack/glance-tempest-plugin  https://review.opendev.org/c/openstack/project-config/+/77195402:15
*** yamamoto_ has quit IRC02:15
*** yamamoto has joined #openstack-infra02:16
*** sshnaidm|ruck is now known as sshnaidm|off02:25
*** lxkong has quit IRC02:38
*** lxkong has joined #openstack-infra02:39
*** JanZerebecki[m] has joined #openstack-infra02:42
*** wolsen has joined #openstack-infra02:48
*** mordred has joined #openstack-infra02:48
*** zzzeek has quit IRC03:01
*** zzzeek has joined #openstack-infra03:02
*** rcernin has quit IRC03:27
*** nicolasbock_ has joined #openstack-infra03:30
*** Wasaac_ has joined #openstack-infra03:31
*** dpawlik1 has joined #openstack-infra03:32
*** ianw_ has joined #openstack-infra03:32
*** tobiash_ has joined #openstack-infra03:33
*** akahat has joined #openstack-infra03:33
*** Wasaac has quit IRC03:38
*** zbr has quit IRC03:38
*** nicolasbock has quit IRC03:38
*** dpawlik has quit IRC03:38
*** arxcruz has quit IRC03:38
*** jpena|off has quit IRC03:38
*** akahat|rover has quit IRC03:38
*** ianw has quit IRC03:38
*** beagles has quit IRC03:38
*** jlvillal has quit IRC03:38
*** tobiash has quit IRC03:38
*** ianw_ is now known as ianw03:38
*** Wasaac_ is now known as Wasaac03:38
*** nicolasbock_ is now known as nicolasbock03:38
*** jpena|off has joined #openstack-infra03:39
*** mordred has quit IRC03:40
*** rcernin has joined #openstack-infra03:41
*** psachin has joined #openstack-infra03:42
*** gouthamr has quit IRC03:43
*** zbr has joined #openstack-infra03:43
*** arxcruz has joined #openstack-infra03:43
*** beagles has joined #openstack-infra03:43
*** jlvillal has joined #openstack-infra03:43
*** mordred has joined #openstack-infra03:44
*** abhishekk has joined #openstack-infra03:58
*** zxiiro has quit IRC04:04
*** ykarel has joined #openstack-infra04:04
*** ricolin_ has joined #openstack-infra04:18
*** jamesmcarthur has quit IRC04:22
*** jamesmcarthur has joined #openstack-infra04:24
*** ykarel_ has joined #openstack-infra04:28
*** ykarel has quit IRC04:30
*** ykarel_ is now known as ykarel04:42
*** Ajohn has joined #openstack-infra04:43
*** ricolin_ has quit IRC05:03
*** vishalmanchanda has joined #openstack-infra05:03
*** Ajohn has quit IRC05:22
*** calbers_ has joined #openstack-infra05:45
*** calbers has quit IRC05:46
*** calbers_ is now known as calbers05:46
*** ykarel_ has joined #openstack-infra05:50
*** ykarel has quit IRC05:53
*** aarents has quit IRC05:57
*** ianw has quit IRC05:59
*** ykarel_ is now known as ykarel05:59
*** ianw has joined #openstack-infra06:01
*** lbragstad has quit IRC06:11
*** dchen has joined #openstack-infra06:15
*** lbragstad has joined #openstack-infra06:16
*** jamesmcarthur has quit IRC06:26
openstackgerritMerged openstack/project-config master: Preparation for tempest-horizon retirement  https://review.opendev.org/c/openstack/project-config/+/77237306:33
openstackgerritMerged openstack/project-config master: Add key editHashtags to normalize_acl script  https://review.opendev.org/c/openstack/project-config/+/77248406:41
openstackgerritMerged openstack/project-config master: Update neutron grafana dashboard  https://review.opendev.org/c/openstack/project-config/+/77264306:41
openstackgerritMerged openstack/project-config master: Remove Karbor projects from infra  https://review.opendev.org/c/openstack/project-config/+/76705706:41
openstackgerritMerged openstack/project-config master: Add rbd-iscsi-client to cinder project  https://review.opendev.org/c/openstack/project-config/+/77259606:44
*** dchen has quit IRC06:53
*** lbragstad has quit IRC07:14
*** lbragstad has joined #openstack-infra07:14
*** dpawlik1 is now known as dpawlik07:16
*** jcapitao has joined #openstack-infra07:16
*** gouthamr has joined #openstack-infra07:22
*** openstackgerrit has quit IRC07:23
*** xek__ has joined #openstack-infra07:25
*** dchen has joined #openstack-infra07:29
*** lpetrut has joined #openstack-infra07:30
*** eolivare has joined #openstack-infra07:30
*** ralonsoh has joined #openstack-infra07:39
*** ysandeep|away is now known as ysandeep07:45
*** hashar has joined #openstack-infra07:56
*** slaweq has joined #openstack-infra07:57
*** dchen has quit IRC07:58
*** amoralej|off is now known as amoralej08:04
*** slaweq has quit IRC08:10
*** slaweq has joined #openstack-infra08:14
*** sboyron has joined #openstack-infra08:21
*** benj_ has quit IRC08:22
*** jamesmcarthur has joined #openstack-infra08:27
*** jamesmcarthur has quit IRC08:31
*** sboyron has quit IRC08:34
*** tosky has joined #openstack-infra08:41
*** nightmare_unreal has joined #openstack-infra08:45
*** juslintek has joined #openstack-infra08:48
*** sboyron has joined #openstack-infra08:48
juslintekHi, is elastic IP the only single way to host multiple instances on a single IP?08:49
juslintekFor example I am renting AMD Ryzen 3600 6 cores (12 threads) with 64GB RAM and 2x512GB NVE SSD at hetzner and I have single IP. I want to host my clients projects there and do not want to puchase additional public IPs. As well planning on implementing stateless functions and so on. What is the best approach here?08:51
juslintekForgot to mention that kubernetes are going to be implemented as well in the future.08:52
*** rpittau|afk is now known as rpittau08:52
*** jpena|off is now known as jpena08:57
*** zzzeek has quit IRC09:01
*** rcernin has quit IRC09:02
*** yamamoto has quit IRC09:02
*** zzzeek has joined #openstack-infra09:03
*** lucasagomes has joined #openstack-infra09:07
*** gfidente has joined #openstack-infra09:09
*** rcernin has joined #openstack-infra09:21
*** derekh has joined #openstack-infra09:35
*** slaweq has quit IRC09:35
*** yamamoto has joined #openstack-infra09:38
*** slaweq has joined #openstack-infra09:43
*** psachin has quit IRC09:46
zbrwho can help tagging a new bindep release?09:47
*** yamamoto has quit IRC09:48
*** ociuhandu has joined #openstack-infra10:06
*** lxkong has quit IRC10:15
*** lxkong has joined #openstack-infra10:16
*** yamamoto has joined #openstack-infra10:19
*** rcernin has quit IRC10:23
*** zzzeek has quit IRC10:30
*** zzzeek has joined #openstack-infra10:32
*** aarents has joined #openstack-infra10:50
*** zzzeek has quit IRC10:54
*** zzzeek has joined #openstack-infra10:55
*** sboyron has quit IRC10:56
*** sboyron has joined #openstack-infra10:58
*** benj_ has joined #openstack-infra11:00
*** juslintek has quit IRC11:01
*** sshnaidm|off has quit IRC11:09
*** sshnaidm|off has joined #openstack-infra11:10
*** jcapitao is now known as jcapitao_lunch11:19
*** rcernin has joined #openstack-infra11:33
*** nightmare_unreal has quit IRC11:48
*** dviroel has joined #openstack-infra11:54
*** ociuhandu has quit IRC12:22
*** ociuhandu has joined #openstack-infra12:23
*** ociuhandu has quit IRC12:27
*** ociuhandu has joined #openstack-infra12:30
*** rcernin has quit IRC12:32
*** jpena is now known as jpena|lunch12:33
*** ociuhandu has quit IRC12:35
*** ociuhandu has joined #openstack-infra12:44
*** ociuhandu has quit IRC12:49
*** yamamoto has quit IRC12:53
*** stephenfin has quit IRC12:54
*** jcapitao_lunch is now known as jcapitao13:00
*** JanZerebecki[m] has quit IRC13:00
*** rm_work has quit IRC13:00
*** jamesdenton has quit IRC13:00
*** thedac has quit IRC13:00
*** cyberpear has quit IRC13:00
*** mnaser has quit IRC13:00
*** dychen has quit IRC13:00
*** jrosser has quit IRC13:00
*** Jeffrey4l has quit IRC13:00
*** JanZerebecki[m] has joined #openstack-infra13:01
*** rm_work has joined #openstack-infra13:01
*** jamesdenton has joined #openstack-infra13:01
*** cyberpear has joined #openstack-infra13:01
*** mnaser has joined #openstack-infra13:01
*** thedac has joined #openstack-infra13:01
*** dychen has joined #openstack-infra13:01
*** jrosser has joined #openstack-infra13:01
*** Jeffrey4l has joined #openstack-infra13:01
*** ociuhandu has joined #openstack-infra13:01
*** benj_ has quit IRC13:02
*** walshh_ has quit IRC13:02
*** wolsen has quit IRC13:02
*** zigo has quit IRC13:03
*** sorrison has quit IRC13:03
*** JanZerebecki[m] has quit IRC13:03
*** mordred has quit IRC13:03
*** wolsen has joined #openstack-infra13:03
*** zigo has joined #openstack-infra13:03
*** sorrison has joined #openstack-infra13:03
*** benj_ has joined #openstack-infra13:04
*** walshh_ has joined #openstack-infra13:04
*** cyberpear has quit IRC13:04
*** wolsen has quit IRC13:04
*** benj_ has quit IRC13:05
*** benj_ has joined #openstack-infra13:06
*** cyberpear has joined #openstack-infra13:06
*** ociuhandu has quit IRC13:08
*** ociuhandu has joined #openstack-infra13:08
*** ociuhandu has quit IRC13:08
*** ociuhandu has joined #openstack-infra13:09
*** ociuhandu has quit IRC13:14
*** yamamoto has joined #openstack-infra13:21
*** yamamoto has quit IRC13:26
*** zzzeek has quit IRC13:29
*** jpena|lunch is now known as jpena13:30
*** zzzeek has joined #openstack-infra13:31
*** mordred has joined #openstack-infra13:31
*** ociuhandu has joined #openstack-infra13:33
*** yamamoto has joined #openstack-infra13:37
*** ociuhandu has quit IRC13:38
*** amoralej is now known as amoralej|lunch13:42
*** sboyron has quit IRC13:44
*** mordred has quit IRC13:48
*** sboyron has joined #openstack-infra13:49
*** ociuhandu has joined #openstack-infra13:52
*** zzzeek has quit IRC13:52
*** zzzeek has joined #openstack-infra13:56
*** ociuhandu has quit IRC13:58
*** ociuhandu has joined #openstack-infra13:58
*** dychen has quit IRC13:59
*** ysandeep is now known as ysandeep|afk14:00
*** zzzeek has quit IRC14:02
*** zzzeek has joined #openstack-infra14:03
*** JanZerebecki[m] has joined #openstack-infra14:15
*** stephenfin has joined #openstack-infra14:22
*** hashar is now known as hasharAway14:24
*** sshnaidm|off has quit IRC14:27
*** sshnaidm|off has joined #openstack-infra14:27
zbrover 15s to get first response for auto-complete,... https://sbarnea.com/ss/Screen-Shot-2021-01-29-14-43-13.05.png14:44
zbrit was hard to convince people to do reviews, now is harder to even assign reviwers :(14:44
*** akahat is now known as akahat|rover14:45
*** amoralej|lunch is now known as amoralej14:48
*** mordred has joined #openstack-infra14:51
*** wolsen has joined #openstack-infra14:51
fungii wanted to get the release notes written up for bindep next since those have been missed in recent reviews as well, so that whatever summary needs to be written for the release announcement can just be committed to the repo since it's already set up for that, but got sidetracked trying to figure out the best way to rework ssh key addition in the git-review unit tests so we can get that release out14:56
*** yamamoto has quit IRC14:57
fungii've been trying to switch git-review testing to upload the client public key via the ssh cli, using the "gerrit code review" built-in superuser, but passing a username with spaces in it from python to an ssh command it turning out to be tricky14:57
fungii've tried every combination of escaping and quoting i can think of, but the shell still seems to tokenize the username on space separators and tries to make it into additional parameters14:58
melwittcould anyone please remind me what is it that is needed in jeepyb to enable gerrit-launchpad integration again for updating bugs?14:59
zbrfungi: i made a hackish release to tox-bindep to overcome lack of release, see https://github.com/tox-dev/tox-bindep/pull/6/files#diff-1738777692dba217b1150daa067ab8b9ec264cc8478e97beba280015273cec80R1915:00
*** jamesmcarthur has joined #openstack-infra15:01
zbrit works and is future proof :D15:01
fungimelwitt: the existing update-bug script in jeepyb wants to perform local mysql lookups on the gerrit server, and gerrit now uses a git-based database backend instead15:01
*** ociuhandu has quit IRC15:01
fungimelwitt: most likely paths forward are to adjust the script to use the gerrit rest api instead (and add credentials to make that possible), or write a nodeless zuul job which performs the same tasks so we can drop that part of jeepyb15:02
*** ociuhandu has joined #openstack-infra15:02
melwittfungi: a-ha, ok thanks. I was wondering if there was anything I could do to help with that15:03
fungimelwitt: one of those two things, probably... i think the challenge is we're going to need to give it elevated privileges if we still want it to be able to get the openid url for the change committer so it can be mapped to a launchpad account for bug reassignment15:06
fungithere is a rest api call which can get that data, but it needs special perms for the requesting user15:06
melwitthm ok. that's unfortunate15:08
*** ociuhandu has quit IRC15:08
*** ykarel has quit IRC15:11
*** ociuhandu has joined #openstack-infra15:11
fungizbr: if you have suggestions on how to keep a username with spaces from getting tokenized when plumbed through subprocess.Popen() and can mention them on https://review.opendev.org/772589 i'd be thrilled, otherwise we'll probably need to commit them in git15:11
fungino matter what i've tried, it still seems to want to interpret Code as the hostname15:12
*** ykarel has joined #openstack-infra15:12
*** ociuhandu has quit IRC15:16
fungizbr: i also reordered that stack so the missing git-review release notes can be merged first. i'll switch gears to writing the missing bindep release notes15:17
*** ociuhandu has joined #openstack-infra15:20
melwittfungi: do you suppose querying NoteDb could be another option for getting user external ids? https://gerrit-review.googlesource.com/Documentation/config-accounts.html15:21
*** ociuhandu has quit IRC15:21
*** ociuhandu has joined #openstack-infra15:22
*** __ministry1 has joined #openstack-infra15:24
*** __ministry1 has quit IRC15:25
zbrfungi: i do remeber that using shell=True/False has some side-effects on how args are processes (spliting or not)15:25
*** __ministry1 has joined #openstack-infra15:26
*** __ministry1 has quit IRC15:26
*** rpittau is now known as rpittau|afk15:27
zbri may have missed few things around sshkey, but why we do need to generate a key instead of re-using current user key only injecting it?15:30
zbri guess too many broken combinations, old gerrit not supporting modern keys, modern systems not support old keys.15:33
fungimelwitt: relying on internal implementation details of gerrit's notedb backend could put us back in the exact same situation relying on implementation details of its rdbms backend did, neither was considered a stable api by gerrit upstream15:37
melwittfungi: ack15:39
fungizbr: well, the user doesn't necessarily have a an available key the test could use (in the case of local testing it might be on a removeable fob or likely requires a passphrase to decrypt) so the test would need to make one anyway in that case, but that's not where the problem lies. we still have to get some public key into gerrit somehow for the uploads in the test to use, and the problem is gerrit15:39
fungichanged how it's storing those15:39
fungimelwitt: ^ another prime example of where that decision is biting us, actually15:39
melwittI see15:40
fungigit-review integration tests start a local gerrit and the bootstrapping process was previously adding the user directly to the database backend, but the last gerrit release where you could insert public ssh keys that way was 2.11, ages ago, so our git-review testing is stuck relying on very old gerrit versions which actually aren't even installable from upstream any longer due to relying on libraries15:41
fungiwhich have disappeared from maven15:41
melwitt:(15:42
fungiso i'm trying to work out how to at least switch the ssh key addition to using a stable api instead of db injection15:42
zbrthat should be the right way towards getting out of this situation15:42
*** dklyle has joined #openstack-infra15:47
clarkbfungi: to be fair those decisions were made well before gerrit had apis to do any of these interactions16:06
clarkbthen they added apis and removed all the backends :)16:06
fungiclarkb: yep, absolutely true, i expect if they'd had a stable api when we were writing these things we'd have chosen it16:08
*** sshnaidm|off has quit IRC16:09
fungidoesn't really change the result though, we've got things implemented against internal details which have changed, and we can hopefully minimize future pain by switching to a public api16:09
*** ykarel has quit IRC16:14
zbrfungi: i think the issue with your command is the newline, not the quoting.  https://zuul.opendev.org/t/openstack/build/abc418081c714387b3964b1dedfa9db316:14
*** sshnaidm|off has joined #openstack-infra16:14
*** lpetrut has quit IRC16:15
zbrmissing a chomp16:15
fungiooh, thanks i'll test a strip on the pubkey16:15
*** __ministry1 has joined #openstack-infra16:35
*** jamesmcarthur has quit IRC16:42
*** hasharAway is now known as hashar16:48
*** tobiash_ is now known as tobiash16:57
*** lucasagomes has quit IRC16:57
*** jamesmcarthur has joined #openstack-infra17:08
*** jamesmcarthur has quit IRC17:10
*** jamesmcarthur has joined #openstack-infra17:11
*** jamesmcarthur has quit IRC17:17
*** jamesmcarthur has joined #openstack-infra17:18
fungizbr: stripping the pubkey was a good call, i'm including that, but it doesn't stop the shell from trying to tokenize the spaced substrings of the ssh username, so i'm still fiddling with different approaches there17:20
clarkbfungi: is there something I can look at to be helpful?17:20
*** amoralej is now known as amoralej|off17:21
fungiclarkb: https://review.opendev.org/772589 is where i'm hacking on it17:21
*** __ministry1 has quit IRC17:22
fungicurrent approach is to push the pubkey via the cli after gerrit is booted, using the magic "Gerrit Code Review" built-in superuser account17:22
fungineed to call it via suexec since that account can't do anything which gets attributed to a real user account, but basically hoping this will let us bootstrap an initial ssh pubkey for a user on versions of gerrit which no longer track those in the relational db17:23
fungialternative would be to use the rest api to post the pubkey, since the account does have an http password at that point (unless we update to a new enough version that passwords get hashed, or that external ids move into notedb as well)17:24
clarkbfungi: is utils.run_cmd() doing a join on that set of *args?17:25
clarkbif so adding more quotes should help?17:26
clarkbor maybe push a list all the way down to subprocess (which is probably the more pythonic method)17:26
fungiit's passing the args list directly to subprocess.Popen()17:26
fungifwiw i've tried '"Gerrit Code Review"' and 'Gerrit\ Code\ Review' and various combinations of escaped quotes and so on17:27
fungipossible i need to force it to use a shell?17:27
fungiwe don't have that option plumbed but i can add it17:28
clarkbI wouldn't think so as the command should work without a shell17:29
clarkbfor the quoting workaroudn you would need a shell though17:29
clarkbbut the way this is written it should pass each of those list items as a different argv and be correct17:29
clarkbthe python docs even make a note of that: "while arguments that need quoting or backslash escaping when used in the shell (such as filenames containing spaces or the echo command shown above) are single list elements."17:31
clarkbfungi: is it possible that ssh itself is splitting on space there becuase space is an invalid unix username char?17:31
*** vishalmanchanda has quit IRC17:32
clarkbfungi: just as a sanity check I wrote a small bash script that echos its $0 - $4 and then wrote a function that is called with *args passed to Popen() and writes the stdout back again just to be sure we're clumping the argv as expected and yes seems to17:36
clarkbthat makes me suspect that maybe ssh is doing the argv parsing in a way we don't expect17:37
fungiexcept when i run that command from an actual shell it does work with the account name17:37
fungispaces and all17:37
fungiso something about the chain of how we're invoking it seems more likely to be at fault17:38
clarkbhrm17:38
clarkbfungi: maybe remove the ' '.join(args) from the exception so we can see the actual list passed to Popen17:38
fungii have to do -l "Gerrit Code Review" 127.0.0.1 or "Gerrit Code Review"@127.0.0.1 in the shell of course17:38
clarkbthe ' '.join(args) is lossy in this context17:39
fungiyeah, good call, will work on an upload with that. it's obviously not the cause, but it does make it harder to confirm what's going on is what we think is going on17:39
clarkbya17:39
clarkbnote there are two cases of that in run_cmd so get both :)17:40
fungid'oh, missed one of them, thanks ;)17:41
fungiokay, got both this tie17:42
fungitime17:42
*** ociuhandu has quit IRC17:48
*** ociuhandu has joined #openstack-infra17:48
*** ociuhandu has quit IRC17:53
*** Ajohn has joined #openstack-infra17:54
*** jpena is now known as jpena|off17:57
*** derekh has quit IRC18:00
*** ociuhandu has joined #openstack-infra18:06
*** gyee has joined #openstack-infra18:08
*** jamesmcarthur has quit IRC18:10
*** ociuhandu has quit IRC18:12
*** Ajohn has quit IRC18:16
clarkbfungi: '-l', 'Gerrit Code Review', '127.0.0.1', <- the relevant bit of the args18:18
clarkbthat looks correct18:18
clarkbfungi: maybe something about your shell is making it work when run manually18:19
clarkband ssh behaves differently if not interactive?18:19
*** ralonsoh has quit IRC18:19
*** ociuhandu has joined #openstack-infra18:19
*** ociuhandu has quit IRC18:20
*** ociuhandu has joined #openstack-infra18:20
fungii still suspect it's an artifact of subprocess.Popen() invoking the executable directly instead of using a shell18:21
fungiheading down that rabbit hole next18:21
fungishells do their own tokenization18:22
clarkbright but shells do effectively the same tokenization18:22
clarkb-l and 'Gerrit Code Review' end up in their own argv entries when ssh is called18:22
clarkband that shouldn't change between ssh with or without a shell18:22
fungiyeah, in theory, agreed18:23
*** jcapitao has quit IRC18:23
fungiwill try adding shell=True to the Popen() and seeing if it's also that way in practice18:23
*** ociuhandu has quit IRC18:25
fungidisappointing if so, but that will at least give us something to go on18:25
clarkb++18:25
*** jamesmcarthur has joined #openstack-infra18:40
*** eolivare has quit IRC18:41
*** jamesmcarthur has quit IRC18:45
*** hashar is now known as hasharDinner18:54
*** sboyron has quit IRC18:55
*** ociuhandu has joined #openstack-infra18:59
*** jamesmcarthur has joined #openstack-infra19:02
*** ociuhandu has quit IRC19:03
*** jamesmcarthur has quit IRC19:12
*** bnemec has quit IRC19:22
*** jamesmcarthur has joined #openstack-infra19:27
*** bnemec has joined #openstack-infra19:30
*** jamesmcarthur has quit IRC19:31
*** jamesmcarthur has joined #openstack-infra19:33
fungistruggling on how to plumb in shell=True when also passing **kwargs, but have temporarily just added a copy of the underlying function with shell=True and called that instead as a test19:39
*** jamesmcarthur has quit IRC19:39
fungii guess the right way to handle it is to set kwargs['shell'] = true before handing off kwargs?19:40
clarkbyup19:55
clarkbjust add it to kwargs manually19:55
*** rcernin has joined #openstack-infra20:09
*** tbachman has quit IRC20:13
*** tbachman has joined #openstack-infra20:14
fungii think i may be getting somewhere wrapping the username in shlex.quote()20:18
fungiso many other seemingly unrelated errors though it's hard to be sure20:18
fungithis is in combination with setting shell=True for that particular invocation20:19
*** auristor has quit IRC20:20
*** auristor has joined #openstack-infra20:22
*** rcernin has quit IRC20:44
*** slaweq has quit IRC20:59
funginew tactic... stick the username in an ssh config host block21:09
*** rcernin has joined #openstack-infra21:10
*** rcernin has quit IRC21:15
*** dwilde has joined #openstack-infra21:27
*** rcernin has joined #openstack-infra21:27
*** hasharDinner is now known as hashar21:50
*** ociuhandu has joined #openstack-infra22:09
*** yamamoto has joined #openstack-infra22:11
*** xek__ has quit IRC22:12
*** ociuhandu has quit IRC22:15
clarkbfungi: seems that worked but now fatal: user "test_user" not found22:17
*** yamamoto has quit IRC22:21
fungiyeah, i wonder if there's something incomplete about how it was added with gsql earlier22:23
fungimaybe i'll update it to add the user via the cli once gerrit's up too, not just its key22:24
*** yamamoto has joined #openstack-infra22:25
fungiif we do password generation in addition to that, we can also upgrade it past gerrit 2.13 at that point, i think22:25
fungibut that might be tricky if the password string is hardcoded into rest api tests22:26
clarkbfungi: I think you can set a value if privileged?22:29
clarkbwhihc would allow you to keep using a constsant22:29
fungioh, yeah maybe so in that case22:29
*** d34dh0r53 has quit IRC22:31
*** armax has quit IRC22:43
*** rcernin has quit IRC22:47
*** rcernin has joined #openstack-infra23:04
*** hashar has quit IRC23:13
*** rcernin has quit IRC23:19
tbachmanI just had a weird infra issue.23:19
tbachmanIt looks like the gate somehow picked up an old version of neutron stable/train23:19
tbachmanThe merge job for our group-based-policy stable/train patch failed. In looking over the failure (see https://b22f38c2e6d0d5fcacd8-75456213d5f2cff92fed567c22cafaae.ssl.cf1.rackcdn.com/772723/4/gate/openstack-tox-py27/cf68165/testr_results.html), it shows an exception that is missing the code that was merged here; https://review.opendev.org/c/openstack/neutron/+/771599/2/neutron/db/l3_db.py#55423:21
tbachmanI rechecked it - just curious if it happens again23:21
clarkbtbachman: looks like your unittest job was for a x/group-based-policy stable/train change. How is it pulling in neutron?23:25
tbachmanclarkb: we’re a consumer of neutron.23:25
clarkbtbachman: that behavior is likely going to come down to how your job is installed neutron23:25
fungiyeah, but how does the job install neutron23:25
clarkbright23:25
* tbachman goes to get link23:25
tbachmanclarkb: note that it passed the verify23:25
tbachmanjust a sec...23:25
fungilike from pypi or a remote git ref or using the local checkout zuul provides or...?23:26
tbachmanclarkb: fungi: https://opendev.org/x/group-based-policy/src/branch/stable/train/test-requirements.txt#L923:26
clarkbya thats just going to install whatever is latest on pypi23:26
tbachmanso, would you expect it to always pass or always fail?23:27
tbachmanb/c it passed the verify the day before23:27
fungiwhatever's latest on pypi which is supported by your python interpreter (assuming new enough pip to use python_requires metadata) and potentially filtered by a constraints file if you're applying one23:27
clarkbtbachman: I mean that will depend on whether or not the neutron code you're pulling works (and a bunch of other factors)23:27
clarkbtbachman: it might be worthwhile to look at both the check and gate log and see what pip reports it installed for neutron23:28
tbachmanclarkb: ack23:28
* tbachman goes digging23:28
fungia link to the build result would help, since we can see the exact command which is being used to install neutron23:28
clarkbneutron==15.3.1 <- i what your gate example above installed according to tox23:29
clarkbfungi: https://b22f38c2e6d0d5fcacd8-75456213d5f2cff92fed567c22cafaae.ssl.cf1.rackcdn.com/772723/4/gate/openstack-tox-py27/cf68165/job-output.txt23:29
fungioh, i see you linked one, checking it now23:29
tbachmanhttps://7f1d3bc811eac15dd3d0-a12e67e84744b622e6a13b507a2faa27.ssl.cf1.rackcdn.com/772723/4/gate/openstack-tox-py36/b77aa77/job-output.txt23:31
tbachmanIt also shows 15.3.123:31
clarkbnote that one of those jobs is python2.7 and the othe ris 3.623:31
clarkbwhich may also be related if it is a python 2 or 3 compatibility issue23:32
tbachmanYeah - I’m finding the pass for 3.623:32
tbachmanah23:32
tbachmanso, the pass in py36 was neutron==15.3.0,23:32
tbachmanhmmm23:32
tbachmandang23:32
fungiyeah, 15.3.1 seems to be the newest release of neutron for train23:32
tbachmanso I’m just guessing here that 15.3.0 doesn’t have the patch that broke us, 15.3.1 does, and 15.3.2 hasn’t been made yet (and would have the patch that fixes it again)23:33
fungilooks like that change merged after 15.3.123:33
tbachmanfungi: thanks!23:34
fungisince `git tag --contains 1b8f449` returns nothing for me23:34
tbachmanI guess I have to wait for 15.3.2 then23:34
tbachmanor change how we pull in neutron23:34
fungiso, yeah, you could push up a release request for neutron stable/train and get the neutron release liaison to ack it23:35
tbachman(until they publish 15.3.2 to pip)23:35
fungithat would probably not happen until monday at the earliest though23:35
tbachmank23:35
tbachmanI guess I’d assumed that publishing to pip was part of the merge gates23:36
fungibut making a release request in openstack is at least just a matter of running a quick script in openstack/releases and proposing the resulting diff as a change23:36
clarkbopenstack only publishes releases to pypi, not every change23:36
tbachmanclarkb: thx!23:36
tbachmank23:36
* tbachman goes to google how to create a release request 23:37
tbachmanclarkb: fungi: thanks for your help23:37
tbachman!23:37
tbachman(and quick response)23:37
fungitbachman: https://releases.openstack.org/reference/using.html#requesting-a-release23:37
* fungi is a meat-based search engine23:38
tbachmanlol23:38
tbachmanfungi: I was doing the same!23:38
tbachman(found the same link)23:38
fungii would ignore the part where it says "The stable  maintenance team, PTL, or release liaison for a project may request a release..."23:39
fungithey really only need to +1 it23:39
fungianyone technically can "request" it23:39
tbachmank23:39
fungithe release team even has a special job which runs every time someone leaves a comment to check whether it was from a valid liaison and flags it for them23:40
fungiso they can tell at a glance whether the request has been okayed23:40
tbachmank23:40
* tbachman runs off to eat 23:40
tbachmanThanks again!23:41
* fungi has pushed release requests plenty of times and then gone to beg for a liaison +1 in hopes that would be faster than asking them to find time to push up the request23:41
*** zzzeek has quit IRC23:48
*** zzzeek has joined #openstack-infra23:50
*** cloudnull has quit IRC23:52

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!