tmazur | #startmeeting horizon | 15:00 |
---|---|---|
opendevmeet | Meeting started Wed Apr 2 15:00:34 2025 UTC and is due to finish in 60 minutes. The chair is tmazur. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
tmazur | Hi everyone and welcome to the weekly meeting! | 15:00 |
ashigupt | o/ | 15:07 |
ashigupt | hello | 15:07 |
tmazur | Ok, let's start :) | 15:08 |
tmazur | Today's agenda is here: https://etherpad.opendev.org/p/horizon-release-priorities#L33 | 15:08 |
tmazur | #topic Notices | 15:09 |
tmazur | This week is R-0. Epoxy is released! | 15:09 |
tmazur | Thank you team for all your hard work! | 15:10 |
tmazur | Next week is PTG | 15:12 |
tmazur | https://etherpad.opendev.org/p/horizon-flamingo-ptg | 15:12 |
tmazur | I put together our schedule, so please take a look. If we want anything else to discuss, it's a perfect time now to add a topic to the etherpad | 15:13 |
ashigupt | sure , thanks Tatiana | 15:14 |
tmazur | Thanks ashigupt! | 15:14 |
tmazur | And just in case someone forgot to register, here's the PTG registration page: https://ptg.openinfra.org/ | 15:15 |
tmazur | #topic Open discussion | 15:16 |
tmazur | That's it from me for today. I am excited to see everyone next week at PTG! | 15:19 |
tmazur | Ok, let's wrap it up. See you all next week at PTG! | 15:24 |
tmazur | #endmeeting | 15:24 |
opendevmeet | Meeting ended Wed Apr 2 15:24:20 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:24 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2025/horizon.2025-04-02-15.00.html | 15:24 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2025/horizon.2025-04-02-15.00.txt | 15:24 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2025/horizon.2025-04-02-15.00.log.html | 15:24 |
ganso | tmazur: hi! so I've been trying to debug the issue, in my env I added logs to "static/app/core/openstack-service-api/keystone.service.js" to show some popups when the page loads, and the popups appear fine, but when trying to do the same on devstack, it doesn't pick up my modifications even after restarting apache2. Do you know whether I'm missing anything? | 17:31 |
ganso | tmazur: I tried editing both /opt/stack/horizon/openstack_dashboard/static/app/core/openstack-service-api/keystone.service.js and /opt/stack/horizon/static/app/core/openstack-service-api/keystone.service.js | 17:31 |
tmazur | ganso: did y run collectstatic? | 17:32 |
ganso | tmazur: I don't know what that is | 17:32 |
tmazur | Ok, so any changes we make in js files will not take effect until they are copied to horizon/static | 17:33 |
tmazur | The collectstatic procedure basically finds any changes in js and copies to static folder | 17:34 |
tmazur | And from there they are picked up, and you can see the changes in your browser | 17:35 |
ganso | tmazur: interesting, but doesn't the fact that I modified both paths already makes up for that? Like, apparently I modified the destination file as well | 17:35 |
tmazur | So that is why apache2 restart does nothing, your changes are not in static | 17:36 |
tmazur | Hmm | 17:36 |
tmazur | I would still suggest to run ./manage.py collectstatic | 17:38 |
ganso | https://www.irccloud.com/pastebin/X2VMnYC2/ | 17:41 |
tmazur | Ok, let me check on my environment | 17:42 |
ganso | looks like it is broken perhaps | 17:42 |
ganso | this is devstack on noble-dalmatian btw. I used the stable branch on devstack and my only local.conf change was to disable tempest | 17:44 |
tmazur | If you did changes directly in horizon/static, then they should be visible in your browser. Sorry for the silly question, did you restart your page properly? Maybe try to restart a browser too. | 17:46 |
tmazur | I have caracal. Let me try on dalmatian | 17:46 |
ganso | tmazur: I was running an incognito browser session, I always close the incognito window completely and create a new one to not have any cache (but I also tried CTRL+F5) | 17:48 |
tmazur | ganso: Yeah, just needed to check. I use the same, but sometimes I need to restart the browser to see changes | 17:49 |
ganso | tmazur: I solved the error above by doing: stack@devstack:~/horizon$ source /opt/stack/data/venv/bin/activate | 17:50 |
ganso | but then I got: 0 static files copied to '/opt/stack/horizon/static', 1891 unmodified. | 17:50 |
ganso | tmazur: I modified the file again in opt/stack/horizon/openstack_dashboard/../ by adding a space in my log line, re-run collectstatic, now it says 1 static file copied, so I closed the incognito, opened again, tried to open the roles page but my popups are still not appearing | 17:54 |
ganso | I don't know if I can F12 that page and look for my change since it is in static/app/core/openstack-service-api/keystone.service.js | 17:54 |
ganso | I don't see that in the network tab in firefox's debug (F12) | 17:55 |
ganso | for anyone interested, I found the culprit ^, the static files needed to be compressed: https://opendev.org/openstack/zun-ui/commit/e7cd67917888a821e2775dbe42d0e71780f2345f | 18:50 |
opendevreview | David Hill proposed openstack/horizon master: Fix KeyError when attaching ports to guests from RBAC networks. https://review.opendev.org/c/openstack/horizon/+/945987 | 20:21 |
opendevreview | David Hill proposed openstack/horizon master: Fix KeyError when attaching ports to guests from RBAC networks. https://review.opendev.org/c/openstack/horizon/+/945987 | 20:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!