| opendevreview | Jan Jasek proposed openstack/horizon master: pytest-based selenium tests add first image test https://review.opendev.org/c/openstack/horizon/+/892133 | 08:44 |
|---|---|---|
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Switch to PyMemcacheCache backend https://review.opendev.org/c/openstack/horizon/+/891828 | 10:44 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Switch to PyMemcacheCache backend https://review.opendev.org/c/openstack/horizon/+/891828 | 11:40 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Use an external compiler for scss files https://review.opendev.org/c/openstack/horizon/+/890403 | 11:51 |
| opendevreview | Jan Jasek proposed openstack/horizon master: pytest-based selenium tests add first image test https://review.opendev.org/c/openstack/horizon/+/892133 | 11:54 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Use an external compiler for scss files https://review.opendev.org/c/openstack/horizon/+/890403 | 12:02 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Switch to PyMemcacheCache backend https://review.opendev.org/c/openstack/horizon/+/891828 | 13:44 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Aug 23 15:00:09 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | o/ | 15:02 |
| vishalmanchanda | rdopiera: tmazur :hi, ping for horizon weekly meeting. | 15:03 |
| tmazur | o/ | 15:03 |
| vishalmanchanda | hello everyone | 15:04 |
| vishalmanchanda | let's start the meeting | 15:04 |
| vishalmanchanda | agenda of the meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L40 | 15:05 |
| vishalmanchanda | #topic Notices | 15:05 |
| vishalmanchanda | few announcements from my side for this week. | 15:05 |
| vishalmanchanda | First of all a gentle reminder about the schedule. | 15:05 |
| vishalmanchanda | This week is R-6 week. | 15:06 |
| vishalmanchanda | Next week is Feature freeze week, but horizon follows intermediary releases model. | 15:06 |
| rdopiera | o/ | 15:06 |
| vishalmanchanda | So we can merge patches till R-1 week(Sep 25 - Sep 29), but try to merge patches before R-3 week(Hard StringFreeze).so that translations of string can happen smoothly. | 15:07 |
| vishalmanchanda | Next week, we have to push a patch for Cycle Highlights. | 15:07 |
| vishalmanchanda | I will do that. | 15:07 |
| vishalmanchanda | moving to next announcement | 15:08 |
| vishalmanchanda | Tc is planning to make py 3.11 as voting in 2024.1 release. | 15:10 |
| vishalmanchanda | it is non-voting as of now. | 15:10 |
| vishalmanchanda | https://lists.openstack.org/pipermail/openstack-discuss/2023-August/034807.html | 15:10 |
| vishalmanchanda | As of now python 3.11 is failing in horizon | 15:11 |
| vishalmanchanda | https://zuul.opendev.org/t/openstack/build/05818346981e4b409f929fffd9435954/log/job-output.txt#32511-32519 | 15:11 |
| vishalmanchanda | basically few Volumebackup tests are failing, I will try to fix those failed tests. | 15:12 |
| vishalmanchanda | moving to next announcement | 15:13 |
| vishalmanchanda | As you may know, nomination of TC and PTL is started. | 15:14 |
| vishalmanchanda | So I am going to nominate myself for Horizon PTL for 2024.1 cycle. | 15:14 |
| vishalmanchanda | Please let me know if anyone else is also interested. | 15:15 |
| vishalmanchanda | that's all announcements from my side for this week. | 15:16 |
| vishalmanchanda | moving to the next topic | 15:16 |
| vishalmanchanda | #topic Release priorities | 15:16 |
| vishalmanchanda | rdopiera: I guess now CI will pass for PyMemcacheCache patch https://review.opendev.org/c/openstack/horizon/+/891828 | 15:17 |
| vishalmanchanda | just wondering if we should add a release note about switching to PyMemcacheCache with reason | 15:18 |
| vishalmanchanda | or no need of adding the release note? | 15:18 |
| vishalmanchanda | rdopiera: ^^ | 15:19 |
| rdopiera | vishalmanchanda: it doesn't pass | 15:19 |
| rdopiera | vishalmanchanda: I can't get it working for some reason | 15:19 |
| rdopiera | it keeps failing with ModuleNotFoundError | 15:19 |
| vishalmanchanda | ohh looking. | 15:20 |
| rdopiera | vishalmanchanda: it seems that the version that global requirements wants, 4.0.0, is no longer called 'memcache' from python import side | 15:21 |
| rdopiera | so the django code crashes | 15:21 |
| rdopiera | I will try with the django-pymemcache plugin | 15:22 |
| vishalmanchanda | rdopiera: ok. | 15:23 |
| vishalmanchanda | just looking at how other openstack project using it https://codesearch.openstack.org/?q=pymemcache&i=nope&literal=nope&files=&excludeFiles=&repos= | 15:24 |
| vishalmanchanda | rdopiera: for scss patch https://review.opendev.org/c/openstack/horizon/+/890403 , I think we may need to write a ansible task for that. | 15:26 |
| rdopiera | vishalmanchanda: is this possible that the integration and tempest tests have their own configuration where they configure memcached? | 15:26 |
| vishalmanchanda | rdopiera: yes. I think they have. | 15:26 |
| rdopiera | about the scss patch, when I went to check the name of the package on debian, I noticed that it's described as deprecated, and that sassc should be used instead. Unfrotunately, sassc has no --scss option. | 15:27 |
| rdopiera | do you know where that config is? | 15:27 |
| vishalmanchanda | rdopiera: config must be mentioned in these logs https://zuul.opendev.org/t/openstack/build/a1082efef2804b7193da8251df57e906/logs | 15:31 |
| rdopiera | thanks | 15:31 |
| rdopiera | I will look for that | 15:31 |
| vishalmanchanda | but I will check with my colleague and let you know the exact path. | 15:31 |
| rdopiera | answering your question, yes, we definitely would need to mention both the memcached and the scss changes in the release notes, however, I'm afraid to merge those pathes so late in the release cycle | 15:32 |
| -opendevstatus- NOTICE: Gerrit is going to be restarted to pick up a small config update. You will notice a short outage of the service. | 15:33 | |
| rdopiera | patches* | 15:33 |
| vishalmanchanda | we can discuss at that time once the patches are ready that we should merge it in this cycle or in next cycle. | 15:33 |
| rdopiera | yes | 15:34 |
| rdopiera | I'm also worried about the scss compiler being deprecated | 15:34 |
| vishalmanchanda | hmm. | 15:34 |
| rdopiera | perhaps we should convert our scss to sass at some point? | 15:34 |
| rdopiera | that will also let us use the mainstream bootstrap | 15:34 |
| rdopiera | fully automated conversion should be possible | 15:35 |
| vishalmanchanda | honestly I have no idea about scss. I will look into this asap and let you know about my finding. | 15:36 |
| rdopiera | in other news, the py3.11 failure is also due to an invalid regular expression in PySass | 15:38 |
| vishalmanchanda | ohh:( | 15:38 |
| rdopiera | I have a patch ready that monekypatches it | 15:39 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Add workaround for invalid regex in PySass https://review.opendev.org/c/openstack/horizon/+/892561 | 15:39 |
| rdopiera | here it is | 15:39 |
| rdopiera | it will fail pep8 now | 15:41 |
| rdopiera | but something along these lines should work | 15:42 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Add workaround for invalid regex in PySass https://review.opendev.org/c/openstack/horizon/+/892561 | 15:42 |
| rdopiera | sorry, mistake | 15:43 |
| vishalmanchanda | Can we fix this issue here https://github.com/Kronuz/pyScss ? | 15:43 |
| vishalmanchanda | and do a new release which we can use in horizon. | 15:43 |
| rdopiera | I think so | 15:44 |
| rdopiera | I assumed that since we have that monkeypatching file, we can't fix things | 15:44 |
| rdopiera | I will propose a pull request | 15:44 |
| vishalmanchanda | a patch is also purposed their https://github.com/Kronuz/pyScss/pull/426/commits/60414f5d573315a8458b5fbcdf69e5c648c44a9a | 15:44 |
| vishalmanchanda | I remember Ivan is also maintainer in that repo. | 15:45 |
| rdopiera | they seem to have unmerged prs from 2014... | 15:45 |
| vishalmanchanda | do you remember Ivan forked this repo we used that repo in horizon. | 15:46 |
| vishalmanchanda | https://pypi.org/project/pyScss/ | 15:48 |
| vishalmanchanda | rdopiera: we can check with Kronuz to add you maintainer in that repo | 15:49 |
| vishalmanchanda | I just noticed it is already fixed in pyScss https://github.com/Kronuz/pyScss/commit/73559d047706ccd4593cf6aa092de71f35164723 | 15:52 |
| rdopiera | I don't want to be a maintainer :-( | 15:52 |
| rdopiera | oh, cool | 15:52 |
| vishalmanchanda | just need to create a new release now. | 15:52 |
| vishalmanchanda | let's comment in that repo to request for a new release. | 15:52 |
| rdopiera | I will let the tests for the patch run anyways, because I want to see if 3.11 will pass with it | 15:56 |
| vishalmanchanda | yeah. let's see. | 15:57 |
| vishalmanchanda | we can merge that patch also, and once new version is released for pyScss. we can revert that later. | 15:58 |
| vishalmanchanda | sass not found. | 16:00 |
| vishalmanchanda | ok let's keep looking at these issues. | 16:01 |
| vishalmanchanda | thanks, everyone for joining. See you next week. | 16:02 |
| vishalmanchanda | #endmeeting | 16:02 |
| opendevmeet | Meeting ended Wed Aug 23 16:02:30 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:02 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-08-23-15.00.html | 16:02 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-08-23-15.00.txt | 16:02 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-08-23-15.00.log.html | 16:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!