opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNR] Test Gate CI job status https://review.opendev.org/c/openstack/horizon/+/882115 | 05:45 |
---|---|---|
vishalmanchanda | #startmeeting horizon | 15:00 |
opendevmeet | Meeting started Wed May 3 15:00:14 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
rdopiera | o/ | 15:04 |
tmazur | o/ | 15:04 |
vishalmanchanda | hello everyone | 15:04 |
vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39 | 15:04 |
vishalmanchanda | let's start the meeting | 15:04 |
vishalmanchanda | #topic Notices | 15:04 |
vishalmanchanda | First of all, a casual reminder about the schedule. This week is R-22 week. | 15:05 |
vishalmanchanda | Next week is Bobcat-1 milestone week. | 15:06 |
vishalmanchanda | For more info. about schedule please refer https://releases.openstack.org/bobcat/schedule.html | 15:06 |
vishalmanchanda | moving to next announcement | 15:07 |
vishalmanchanda | release team purposed a patch to move stable/rocky branch of horizon to EOL and we discuss this topic in the past and agreed with that. | 15:07 |
vishalmanchanda | So I +1ed on the patch https://review.opendev.org/c/openstack/releases/+/881626 | 15:08 |
vishalmanchanda | that's all announcement for this week from my side. | 15:08 |
vishalmanchanda | moving to next topic | 15:10 |
vishalmanchanda | #topic Release priorities | 15:10 |
vishalmanchanda | One update from my side on jQuery update. | 15:10 |
vishalmanchanda | The VM from where I am pushing jQuery update patches is not booting Up. | 15:11 |
vishalmanchanda | I tried to recover it, but looks like it will be difficult. | 15:11 |
vishalmanchanda | Lost some code changes which I done on that VM. | 15:12 |
vishalmanchanda | Anyway, I already set up a new devstack env. in another VM but am getting many error messages for angular in the browser 'Developer Tool' option. | 15:12 |
vishalmanchanda | Like this https://paste.openstack.org/show/b2v6zxyyuUKJSNNZpCOK/ | 15:13 |
vishalmanchanda | Can you check if you are also getting the same error messages. | 15:14 |
vishalmanchanda | Like If I try to Launch or create an instance I am seeing these errors although the instance was created without any issues. | 15:14 |
rdopiera | you can get your patches back from gerrit | 15:15 |
vishalmanchanda | no I have more code which I didn't push on Gerrit. | 15:16 |
rdopiera | oof | 15:16 |
vishalmanchanda | yup. | 15:16 |
rdopiera | that error looks like there is a spurious [ | 15:16 |
rdopiera | or maybe a missing ] | 15:16 |
vishalmanchanda | yes | 15:16 |
rdopiera | isn't "!--" a comment in html? | 15:17 |
vishalmanchanda | are you also getting those errors with the latest horizon code? | 15:17 |
rdopiera | I havent tried the latest code in a while, my env is broken at the moment | 15:17 |
rdopiera | I'm mostly working on backports right now | 15:17 |
vishalmanchanda | ok | 15:17 |
rdopiera | I will try and let you know tomorrow | 15:18 |
vishalmanchanda | thanks. | 15:18 |
vishalmanchanda | moving to next topic | 15:19 |
vishalmanchanda | setup tool bug https://bugs.launchpad.net/horizon/+bug/2007574 | 15:19 |
rdopiera | yup, \x3C!-- is <!-- which is start of a comment... | 15:19 |
vishalmanchanda | sorry what do you mean, is it due to some patch we merged recently? | 15:20 |
rdopiera | no idea, but I suspect that the parser is getting confused by this somehow | 15:21 |
vishalmanchanda | ok | 15:21 |
rdopiera | that setuptools bug should be fixed with that patch I submitted for xstatic | 15:22 |
vishalmanchanda | your patch is merged https://github.com/xstatic-py/xstatic/pull/11 | 15:22 |
vishalmanchanda | but I am not sure if it fixes the issue. | 15:22 |
rdopiera | yeah, I suppose we need to make a release and make horizon require that version? | 15:22 |
vishalmanchanda | I rechecked on Kolla patch https://review.opendev.org/c/openstack/kolla/+/876460 | 15:22 |
rdopiera | mnasiadka: do you think you could try with the xstatic version from master? | 15:23 |
vishalmanchanda | rdopiera: ok. I will cut a new release then and see. | 15:23 |
vishalmanchanda | rdopiera: yeah, that would be good if somehow we can test locally first. | 15:24 |
vishalmanchanda | rdopiera: we can drop a comment on https://review.opendev.org/c/openstack/kolla/+/876460 | 15:25 |
rdopiera | I meant a pypi release for xstatic | 15:25 |
vishalmanchanda | Ohh ok. | 15:26 |
rdopiera | I added a comment | 15:27 |
vishalmanchanda | rdopiera: Could you take care of the release thing for this pypi, if required. | 15:27 |
rdopiera | yeah, I will look into it | 15:28 |
vishalmanchanda | cool. | 15:28 |
vishalmanchanda | thanks | 15:28 |
vishalmanchanda | ok, one more thing I would like to discuss here. | 15:28 |
vishalmanchanda | I am seeing a lot of warnings in CI jobs like "Package would be ignored" , do we need to worry about this | 15:30 |
vishalmanchanda | see https://zuul.opendev.org/t/openstack/build/b965c032465549ed86ac2ed45670715c/log/job-output.txt#25810-25834 | 15:30 |
rdopiera | no idea, I haven't been paying attention to what new marvelous changes our python 3 overlords are making to pypi | 15:31 |
vishalmanchanda | ok. | 15:32 |
vishalmanchanda | that's all update from my side for this week. | 15:33 |
vishalmanchanda | moving to next topic | 15:33 |
vishalmanchanda | #topic open-discussion | 15:33 |
rdopiera | relevant: https://setuptools.pypa.io/en/latest/deprecated/distutils/sourcedist.html#specifying-the-files-to-distribute | 15:34 |
rdopiera | https://setuptools.pypa.io/en/latest/deprecated/distutils/setupscript.html#distutils-installing-package-data | 15:34 |
vishalmanchanda | thanks, will look in the documentations. | 15:35 |
vishalmanchanda | I just want to raise some awareness about bug https://bugs.launchpad.net/horizon/+bug/2018232 | 15:35 |
vishalmanchanda | It is a valid bug. | 15:35 |
rdopiera | looks like we just need to list those directories in https://github.com/openstack/horizon/blob/master/setup.cfg#L32 | 15:36 |
vishalmanchanda | rdopiera: ok got it. | 15:36 |
vishalmanchanda | tmazur: If you have time, please take a look at https://bugs.launchpad.net/horizon/+bug/2018232 | 15:37 |
tmazur | Looking | 15:38 |
vishalmanchanda | I fixed the bug partially like I handled the exception but still not able to see any entries in the Ui side and not seeing error after updating the code. | 15:38 |
tmazur | I don't have any env with trunks, so I'll need to deploy one and take a proper look | 15:39 |
vishalmanchanda | what about qos? | 15:39 |
tmazur | Same I'm afraid | 15:40 |
vishalmanchanda | I done some changes in the previous env. | 15:40 |
vishalmanchanda | ok. | 15:40 |
tmazur | It looks like my upgrade missed something | 15:41 |
vishalmanchanda | Please check if you have some time to look into those issues. I will also try again. | 15:41 |
tmazur | Simply because I didn't have an env to check. I'll start on the new env asap and take a look | 15:41 |
tmazur | Yeah | 15:41 |
vishalmanchanda | Thanks. | 15:42 |
vishalmanchanda | Does anyone have any other topic to discuss? | 15:42 |
vishalmanchanda | if no other topic to discuss, let's end this meeting | 15:46 |
vishalmanchanda | Thanks everyone for joining. | 15:47 |
tmazur | Thanks! | 15:47 |
vishalmanchanda | #endmeeting | 15:47 |
opendevmeet | Meeting ended Wed May 3 15:47:10 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:47 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-05-03-15.00.html | 15:47 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-05-03-15.00.txt | 15:47 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-05-03-15.00.log.html | 15:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!