| opendevreview | Merged openstack/horizon stable/wallaby: Fix instance error with attribute cells. https://review.opendev.org/c/openstack/horizon/+/870903 | 03:51 |
|---|---|---|
| opendevreview | Merged openstack/horizon master: Stability improvement of Instance tests https://review.opendev.org/c/openstack/horizon/+/881456 | 09:52 |
| opendevreview | Merged openstack/horizon master: Fix deprecation warning for jQuery.fn.keyup() event shorthand https://review.opendev.org/c/openstack/horizon/+/880239 | 09:52 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix deprecated use of 'jQuery.fn.change()' shorthand event https://review.opendev.org/c/openstack/horizon/+/881563 | 13:17 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix "jQuery.fn.submit() event shorthand is deprecated" warning https://review.opendev.org/c/openstack/horizon/+/881564 | 13:59 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix deprecated use of 'jQuery.fn.change()' shorthand event https://review.opendev.org/c/openstack/horizon/+/880071 | 14:14 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Apr 26 15:00:16 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| tmazur | o/ | 15:01 |
| vishalmanchanda | Hello everyone | 15:01 |
| vishalmanchanda | only two of us, anyway let's start the meeting. | 15:04 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L32 | 15:04 |
| vishalmanchanda | I have no announcements for this moving, so moving to Release priorities topic | 15:05 |
| vishalmanchanda | #topic Release priorities | 15:05 |
| rdopiera | o/ | 15:06 |
| vishalmanchanda | small update on jQuery migration | 15:06 |
| vishalmanchanda | First of all thank you rdopiera tmazur for quick approval on my patches. | 15:07 |
| vishalmanchanda | I am working on fixing few more jQuery deprecated function, will try to push them asap. | 15:07 |
| vishalmanchanda | moving to next thing. | 15:08 |
| vishalmanchanda | horizon doesn't support setuptools 67.3.1 | 15:09 |
| vishalmanchanda | https://bugs.launchpad.net/horizon/+bug/2007574 | 15:09 |
| vishalmanchanda | rdopiera: any update on this bug? | 15:09 |
| vishalmanchanda | I remember you were saying we just need to import xstatic packages in ``setup.py file``. | 15:10 |
| vishalmanchanda | https://github.com/openstack/horizon/blob/master/setup.py | 15:10 |
| rdopiera | vishalmanchanda: no, I forgot again, I will make a pull request after the meeting | 15:10 |
| vishalmanchanda | rdopiera: ok, thanks | 15:10 |
| rdopiera | vishalmanchanda: the problem for me is that my github account is set up on my personal computer not my work computer | 15:10 |
| rdopiera | so I forget about it by the time I get to it | 15:11 |
| rdopiera | sorry | 15:11 |
| vishalmanchanda | So we just need to do "from xstatic import pkg_resources" in setup.py file and this will fix the issue? | 15:12 |
| vishalmanchanda | Also, just curious it is the right way or some workaround to fix it. | 15:13 |
| vishalmanchanda | I mean, do we need to change anything on xstatic packages side, but we don't have people to do it? | 15:13 |
| rdopiera | no, we need 'import pkg_resources' in xstatic's setup.py | 15:14 |
| rdopiera | it's just a single pull request for a single package | 15:15 |
| vishalmanchanda | rdopiera: ok and we need to do it for all packages? | 15:15 |
| vishalmanchanda | maybe I will understand more once your patch is up. | 15:19 |
| vishalmanchanda | moving to next item | 15:20 |
| vishalmanchanda | Devstack team might update cirros version to 0.6.1 and due to this our integration job will start failing. | 15:21 |
| vishalmanchanda | https://review.opendev.org/c/openstack/devstack/+/881437 | 15:21 |
| rdopiera | vishalmanchanda: as I understand it, we only need it for the "xstatic" package itself | 15:22 |
| vishalmanchanda | rdopiera: ok | 15:23 |
| vishalmanchanda | I will push a patch to update cirros version for horizon-integration job. | 15:24 |
| vishalmanchanda | that's all update from my side for this week. | 15:25 |
| vishalmanchanda | #topic open-discussion | 15:26 |
| vishalmanchanda | Does anyone have any topic to discuss? | 15:26 |
| vishalmanchanda | If no other topic to discuss, let's end this meeting | 15:29 |
| rdopiera | https://github.com/xstatic-py/xstatic/pull/11 | 15:29 |
| vishalmanchanda | rdopiera: thanks, hope it fixes the issue. | 15:30 |
| vishalmanchanda | #endmeeting | 15:31 |
| opendevmeet | Meeting ended Wed Apr 26 15:31:23 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:31 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-26-15.00.html | 15:31 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-26-15.00.txt | 15:31 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-26-15.00.log.html | 15:31 |
| vishalmanchanda | rdopiera: Do we have to approve this pull request on github? | 15:32 |
| vishalmanchanda | I mean no changes required on gerrit? | 15:33 |
| rdopiera | I will wait for Thomas or Reimar to approve it | 15:33 |
| rdopiera | I can merge it myself if need be, but I would prefer them to know about it first | 15:34 |
| rdopiera | no changes in gerrit | 15:34 |
| vishalmanchanda | Looks like, I also have approve right. | 15:34 |
| rdopiera | everyone can approve on github | 15:35 |
| rdopiera | but not merge | 15:35 |
| vishalmanchanda | rdopiera: ohh, actually don't know much about github review🙂) | 15:35 |
| opendevreview | Merged openstack/horizon master: Fix deprecated use of 'jQuery.fn.blur()' shorthand event https://review.opendev.org/c/openstack/horizon/+/881364 | 16:55 |
| opendevreview | Merged openstack/horizon master: Fix deprecation warning for .removeAttr() https://review.opendev.org/c/openstack/horizon/+/880541 | 23:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!