opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test nodejs test job https://review.opendev.org/c/openstack/horizon/+/864081 | 05:58 |
---|---|---|
opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test nodejs test job https://review.opendev.org/c/openstack/horizon/+/864081 | 07:24 |
opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test nodejs test job https://review.opendev.org/c/openstack/horizon/+/864081 | 14:20 |
vishalmanchanda | #startmeeting horizon | 15:00 |
opendevmeet | Meeting started Wed Nov 9 15:00:12 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
rdopiera | o/ | 15:01 |
ganso | o/ | 15:01 |
vishalmanchanda | agenda of meeting can be found here | 15:01 |
vishalmanchanda | https://etherpad.opendev.org/p/horizon-release-priorities#L31 | 15:01 |
vishalmanchanda | There is not much update from my side for this week. | 15:02 |
vishalmanchanda | Directly moving to open-discussion | 15:02 |
vishalmanchanda | #topic open-discuss | 15:02 |
vishalmanchanda | #topic open-discussion | 15:03 |
vishalmanchanda | You may have noticed 'horizon-nodejs-test' job is failing | 15:03 |
vishalmanchanda | So please avoid rechecks until it is fixed. | 15:04 |
ganso | there's a request for re-reviews in the agenda | 15:05 |
vishalmanchanda | Looks like task to install chromium-browser is failed which causing the failure. | 15:05 |
vishalmanchanda | ganso: please wait. | 15:05 |
vishalmanchanda | Error logs https://zuul.opendev.org/t/openstack/build/afdcbc4bad4f421bbc7fec5614966d9f/log/job-output.txt#538 | 15:06 |
vishalmanchanda | If we skip that task, then job is passing. | 15:06 |
vishalmanchanda | See https://review.opendev.org/c/openstack/horizon/+/864081 | 15:07 |
vishalmanchanda | We are hitting this issue https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1927513 | 15:07 |
vishalmanchanda | I don't exactly what's changed from yesterday in CI which trigger the above bug. | 15:08 |
vishalmanchanda | Also, I can see most of horizon plugins and horizon uses firefox browser to run these jobs, So as a workaround we can skip install chromium-browser task for now. | 15:10 |
vishalmanchanda | https://codesearch.openstack.org/?q=browsers%3A&i=nope&literal=nope&files=karma.conf.js&excludeFiles=&repos= | 15:10 |
vishalmanchanda | rdopiera: tmazur :wdys? | 15:10 |
rdopiera | I have no idea why it is being installed in the first place. | 15:12 |
rdopiera | If it passes with the task skipped, I don't see a problem. | 15:12 |
tmazur | +1 | 15:12 |
vishalmanchanda | rdopiera: because in past we maybe use chromium as a browser. | 15:13 |
rdopiera | that must have been years ago | 15:13 |
rdopiera | our integration tests don't even all pass on chrome/chromium | 15:14 |
vishalmanchanda | ok I'll push a patch to remove/skip 'install chromium-browser' task. | 15:14 |
vishalmanchanda | rdopiera: yes. | 15:14 |
vishalmanchanda | ganso: now go ahead. | 15:15 |
ganso | vishalmanchanda: thanks! sorry about that, I had thought "open-discussion" was the last topic | 15:15 |
ganso | so just requesting for review two patches: | 15:15 |
ganso | https://review.opendev.org/c/openstack/horizon/+/863629 | 15:15 |
ganso | https://review.opendev.org/c/openstack/horizon/+/831035 | 15:16 |
ganso | vishalmanchanda has already reviewed (Thanks a lot!) | 15:16 |
ganso | so I'm hoping other core reviewers could please review when they have some time | 15:16 |
ganso | tmazur, amotoki, rdopiera ^ | 15:16 |
ganso | one is a backport, the other is a new patch (which already has +2) | 15:17 |
ganso | that's all | 15:17 |
vishalmanchanda | ganso: thanks for working on it. | 15:18 |
vishalmanchanda | rdopiera: tmazur : Do you have any topic to discuss? | 15:18 |
rdopiera | nothing from me | 15:18 |
tmazur | nothing from me | 15:18 |
vishalmanchanda | ok, if no more topic to discuss, let end this meeting. | 15:19 |
vishalmanchanda | thanks, everyone for joining. | 15:19 |
vishalmanchanda | See you next week. | 15:19 |
vishalmanchanda | #endmeeting | 15:19 |
opendevmeet | Meeting ended Wed Nov 9 15:19:48 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:19 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-11-09-15.00.html | 15:19 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-11-09-15.00.txt | 15:19 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-11-09-15.00.log.html | 15:19 |
opendevreview | Merged openstack/horizon stable/ussuri: Escape unicode characters when setting logout_reason cookie https://review.opendev.org/c/openstack/horizon/+/850826 | 17:05 |
opendevreview | Clark Boylan proposed openstack/horizon master: [DNM] Testing horizon jobs on Ubuntu jammy (22.04) https://review.opendev.org/c/openstack/horizon/+/861140 | 18:23 |
opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Make readonly metadata properties unable to edit https://review.opendev.org/c/openstack/horizon/+/864062 | 19:40 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!