| zigo | Hi team! Trove-dashboard is broken since https://review.opendev.org/c/openstack/horizon/+/816303 | 10:22 |
|---|---|---|
| zigo | Can someone help me repair it? | 10:22 |
| zigo | vishalmanchanda: ^ | 10:22 |
| zigo | Oh, master branch doesn't have the broken include, so it's probably already fixed ... | 10:24 |
| vishalmanchanda | zigo: looking | 10:25 |
| zigo | Looks like rc1 is missing this commit: https://review.opendev.org/c/openstack/trove-dashboard/+/833497 | 10:26 |
| zigo | vishalmanchanda: After the patch, it's looking better, but still some failures: | 10:31 |
| zigo | https://paste.opendev.org/show/bGGbsT40egOzjPNVmL4c/ | 10:31 |
| vishalmanchanda | zigo: where you see this error https://paste.opendev.org/show/bGGbsT40egOzjPNVmL4c/ | 10:35 |
| vishalmanchanda | zigo: patch link? | 10:35 |
| zigo | vishalmanchanda: That's when I build the Debian package for Trove-dashboard. | 10:36 |
| vishalmanchanda | zigo: ok let me try to run these tests on my env. | 10:37 |
| zigo | FYI, that's the last piece of the puzzle for me, all has been built, fixed, and uploaded ! :) | 10:37 |
| zigo | Looking deeper, it's probably only a test problem. | 10:39 |
| opendevreview | Merged openstack/horizon stable/wallaby: Change to a proper policy for Resume operation https://review.opendev.org/c/openstack/horizon/+/835132 | 10:40 |
| amotoki | zigo: I think you are right. It looks like a test-only problem. | 10:53 |
| amotoki | zigo: trove_dashboard/content/databases/workflows/create_instance.py SetNetworkAction instance_utils.network_field_data() calls openstack_dsahboard.api.neutron.network_list_for_tenant() | 10:54 |
| amotoki | correction: SetNetworkAction.populate_network_choices() calls openstack_dashboard.dashboards.project.instances.utils.network_field_data() | 10:55 |
| amotoki | and network_field_data() calls openstack_dsahboard.api.neutron.network_list_for_tenant() internally. | 10:55 |
| amotoki | api.neutron.network_list_for_tenant() was refactored during Yoga | 10:55 |
| amotoki | trove_dashboard mock relies on the internal of api.neutron.network_list_for_tenant() | 10:56 |
| amotoki | this is the cause of the failure. | 10:56 |
| amotoki | the test in trove_dashboard should api.neutron.network_list_for_tenant() at least. | 10:56 |
| amotoki | I don't have time to fix the test, but I believe this is the cause of the UT failure of trove-dashboard. | 10:56 |
| vishalmanchanda | removing https://github.com/openstack/trove-dashboard/blob/62cd08226b7e170e615f12f2cdc52e38351e3daf/trove_dashboard/content/database_backups/tests.py#L231-L232 | 10:57 |
| vishalmanchanda | will fix the issue | 10:57 |
| amotoki | vishalmanchanda: I am talking about the failure of test_create_simple_instance | 10:58 |
| vishalmanchanda | ok | 10:59 |
| amotoki | vishalmanchanda: dropping assertion just skips the test, so it is not surprising to pass the test. | 10:59 |
| amotoki | vishalmanchanda: this is about what you mentioned. | 10:59 |
| amotoki | vishalmanchanda: but my point above may be related to all failures, i.e., caused by the refactorig of api.neutron.network_list_for_tenant(). you are more faimiliar with it as you reviewed it in detail. | 11:01 |
| vishalmanchanda | amotoki: ok got your point. | 11:01 |
| ironfoot | Hi all, is it possible to enable the "Common Operating System Properties" for Images in horizon for users other than admin? I can't find any documentation about it. | 11:18 |
| ironfoot | Using the CLI, a regular user can see them. | 11:19 |
| zigo | vishalmanchanda: amotoki: I'll be removing trove_dashboard/content/database_backups/tests.py in the Debian package as a temporary measure. | 11:39 |
| vishalmanchanda | zigo: hi, what you have to do replace self.mock_network_list.assert_has_calls in failed unit tests with https://paste.opendev.org/show/b2tjmd4o4Khhqxn9ZZRL/ | 11:39 |
| vishalmanchanda | zigo: this will fix the unit tests | 11:39 |
| zigo | Ok, will try. | 11:39 |
| vishalmanchanda | zigo: let me push a quick patch to fix all failed unit tests. | 11:39 |
| zigo | Great, thanks. | 11:40 |
| zigo | Will wait for it. | 11:40 |
| vishalmanchanda | ironfoot: hi, I will check and let you know if find anything. probably depends on policy used I guess. | 11:45 |
| zigo | I also got this with senlin dashboard: https://paste.opendev.org/show/bi3Wg958LjKpjMb1dI2Z/ :/ | 11:46 |
| ironfoot | vishalmanchanda: thank you! | 11:46 |
| vishalmanchanda | zigo: fix for trove-dashboard unit test https://review.opendev.org/c/openstack/trove-dashboard/+/835617 | 12:15 |
| vishalmanchanda | zigo: Feel free to update commit-msg if needed. | 12:15 |
| zigo | Thanks, I'll let you know how it goes. (in a meeting right now) | 12:15 |
| vishalmanchanda | zigo: ok | 12:15 |
| vishalmanchanda | We already discussed all these issue in a weekly meeting | 12:17 |
| vishalmanchanda | You will also hit this one as well https://storyboard.openstack.org/#!/story/2009924 | 12:17 |
| vishalmanchanda | I will take a look at senlin-dashboard issue after some time | 12:18 |
| zigo | vishalmanchanda: FYI, trove-dashboard is now ok for me, thanks for your work. | 14:24 |
| vishalmanchanda | zigo: np | 14:25 |
| zigo | vishalmanchanda: Any idea about senlin-dashboard though ? https://paste.opendev.org/show/bi3Wg958LjKpjMb1dI2Z/ | 14:25 |
| vishalmanchanda | zigo: looking | 14:26 |
| vishalmanchanda | zigo: fixed senlin-dashbord in local env., pushing a patch soon. | 14:48 |
| zigo | When I click on "launch instance" I'm being de-logged ... http://shade.infomaniak.ch/out-8.ogv | 14:57 |
| vishalmanchanda | zigo: Patch to fix senlin-dashboard https://review.opendev.org/c/openstack/senlin-dashboard/+/835642 | 14:58 |
| zigo | Thanks, trying it out. | 14:58 |
| zigo | vishalmanchanda: Any idea what's going on ? (see video above) | 14:58 |
| vishalmanchanda | zigo: looks like policy issues. | 14:59 |
| zigo | Ah... which means? | 15:00 |
| zigo | Missing horizon policy file, maybe? :) | 15:00 |
| vishalmanchanda | zigo user not authorized to Launch instance that's why redirected to Login Page. | 15:01 |
| vishalmanchanda | that's my understanding from above video. | 15:02 |
| zigo | Hum ... with another horizon (victoria), it works well... | 15:02 |
| zigo | Though I tried plugging this Yoga horizon on a Victoria cloud, could that be the issue? | 15:03 |
| zigo | (usually, it's not ...) | 15:03 |
| zigo | Senlin-dashboard UT fix, gr8 ! :) | 15:03 |
| * zigo uploads it | 15:03 | |
| vishalmanchanda | zigo: Could you try any other operation like created image/network also keystone operations. | 15:06 |
| vishalmanchanda | create* | 15:06 |
| zigo | When I click on the "image" tab on the left, I'm being delogged as well ... | 15:09 |
| zigo | Not all the time, that's weird ... :/ | 15:11 |
| vishalmanchanda | on which horizon branch you trying this and Can you check and send HEAD of horizon repo by "git log"? | 15:12 |
| zigo | That's latest tag: 22.0.0 | 15:22 |
| vishalmanchanda | Could you try 22.1.0 just released https://review.opendev.org/c/openstack/releases/+/835461 | 15:23 |
| zigo | ok | 15:26 |
| zigo | After activating debug, I saw this: | 15:27 |
| zigo | WARNING django.request The request's session was deleted before the request completed. The user may have logged out in a concurrent request, for example.: /horizon/api/nova/flavors/ | 15:27 |
| zigo | Anyways, trying 22.1.0 | 15:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!