| hemanth_n | amotoki: or core reviewers, can you merge this patch https://review.opendev.org/c/openstack/horizon/+/829662 thanks! | 02:57 |
|---|---|---|
| amotoki | hemanth_n: we discussed it in this week horizon team meeting and if https://review.opendev.org/c/openstack/horizon/+/830630 lands soon we squash it into the backport. I am waiting for the master branch review for a while. If it takes time, we will land the backport as-is. | 03:02 |
| hemanth_n | amotoki: ack, sorry for noise without checking team meeting notes | 03:03 |
| amotoki | hemanth_n: np. I understand the issue that the resolve instance does not work is moree important than an small extra call, so we will decide it early next week. | 03:04 |
| opendevreview | Keigo Noha proposed openstack/horizon master: Change to a proper policy for Resume operation https://review.opendev.org/c/openstack/horizon/+/831903 | 08:42 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [WIP] Setup project template for nodejs v16 jobs https://review.opendev.org/c/openstack/horizon/+/831929 | 12:07 |
| amotoki | rdopiera: tmazur: could you review https://review.opendev.org/c/openstack/horizon/+/830630 ? | 17:10 |
| amotoki | rdopiera: tmazur: It is a follow-up of https://review.opendev.org/q/Id2f38acfc27cdf93cc4341422873e512aaff716a and I would like to squash it into the parent commit proposed for backport if it lands soon. | 17:10 |
| rdopiera | amotoki: I have one question on it. | 18:15 |
| rdopiera | amotoki: the way you pass flavors to a memoized function, makes it break the memoization | 18:16 |
| amotoki | rdopiera: thanks for catching it. very good point. I think the way is just to call self.get_flavors() from get_object(). | 18:48 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Avoid extra flavor_get in resize server form https://review.opendev.org/c/openstack/horizon/+/830630 | 19:29 |
| rdopiera | amotoki: thanks, that looks good | 19:31 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: WIP Add SYSTEM_SCOPE_SERVICES setting that hides panels https://review.opendev.org/c/openstack/horizon/+/818763 | 21:46 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Avoid extra flavor_get in resize server form https://review.opendev.org/c/openstack/horizon/+/830630 | 22:00 |
| rdopiera | amotoki: sorry, I got the wrong patch | 22:03 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: WIP Add SYSTEM_SCOPE_SERVICES setting that hides panels https://review.opendev.org/c/openstack/horizon/+/818763 | 22:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!