| amotoki | vishalmanchanda: ping | 07:00 |
|---|---|---|
| amotoki | vishalmanchanda: why do you request to mix a cleanup of config_driver with a flavor handling of resize_server? | 07:01 |
| amotoki | vishalmanchanda: both are completely different topics. I am surpurised you are mixing two things in a single commit. | 07:01 |
| amotoki | vishalmanchanda: https://review.opendev.org/c/openstack/horizon/+/808102/12/openstack_dashboard/dashboards/project/instances/tests.py#2193 | 07:02 |
| vishalmanchanda | amotoki: hi, I am suggesting to do that because we are doing changes in the similar files | 07:12 |
| amotoki | vishalmanchanda: similar file but totally different topics. Are you sitll suggesting mixing two thigns? | 07:12 |
| amotoki | vishalmanchanda: the resize fix is backport-able, but the config driver clean up cannot be backported. | 07:13 |
| amotoki | vishalmanchanda: mixing bakcport-able and non-backport-able changes is totally a bad idea. | 07:13 |
| vishalmanchanda | amotoki: just removed my -1, let's do it in a separate patch. | 07:13 |
| vishalmanchanda | amotoki: yeah make sense. | 07:13 |
| amotoki | vishalmanchanda: thanks | 07:14 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/808102 | 07:17 |
| amotoki | after 10min debug I succeeded to fix heat-dashbaord UT failure :-) | 09:52 |
| amotoki | it was really simple. | 09:52 |
| vishalmanchanda | Nice. | 09:53 |
| opendevreview | Merged openstack/horizon master: Add a unit test for the password change form https://review.opendev.org/c/openstack/horizon/+/828381 | 10:20 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Integration tests: Allow to run a specific test from tox https://review.opendev.org/c/openstack/horizon/+/829513 | 10:21 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Follow-up: Drop Django launch instance (part 2) https://review.opendev.org/c/openstack/horizon/+/829516 | 10:41 |
| amotoki | vishalmanchanda: ^^ another follow-up of dropping of django launch server you pointed out in the resize server review | 10:42 |
| vishalmanchanda | amotoki: thanks:) | 10:43 |
| *** josecastroleon__ is now known as josecastroleon | 12:36 | |
| ganso | vishalmanchanda: hi! could you please re-set the review-priority on https://review.opendev.org/c/openstack/horizon/+/806454 ? The latest patchset untoggled it :\ | 13:43 |
| vishalmanchanda | ganso: Done, also drop some comment on your latest P.S. | 13:44 |
| vishalmanchanda | ganso: thanks for reminder, forgot to drop these comment last week. | 13:46 |
| *** whoami-rajat__ is now known as whoami-rajat | 14:01 | |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Feb 16 15:00:21 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | hello everyone | 15:00 |
| rdopiera | o/ | 15:00 |
| e0ne | hi | 15:00 |
| tmazur | o/ | 15:01 |
| amotoki | o/ | 15:01 |
| vishalmanchanda | Let's start the meeting. | 15:01 |
| vishalmanchanda | Agenda for today meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities (at line 32) | 15:02 |
| vishalmanchanda | #topic Notices | 15:02 |
| vishalmanchanda | Few announcements from my side for this week | 15:02 |
| vishalmanchanda | Yoga Schedule reminder https://releases.openstack.org/yoga/schedule.html | 15:03 |
| vishalmanchanda | This week is R-5 week. | 15:03 |
| vishalmanchanda | Next week is feature freeze. | 15:04 |
| vishalmanchanda | So please take a look at bp patches. | 15:04 |
| vishalmanchanda | I also added review-priority flag for feature patches which we are targeting for Yoga cycle. | 15:04 |
| vishalmanchanda | https://review.opendev.org/q/label:Review-Priority%253D%252B1+status:open+project:openstack/horizon+ | 15:05 |
| vishalmanchanda | Please review them on priority if you have not done yet. | 15:05 |
| vishalmanchanda | moving to next announcement | 15:06 |
| amotoki | is not sure how the feature freeze and cycle-with-intermediary are related... | 15:06 |
| amotoki | precisely spekaing, the feature freeze is applied to cycle-with-rc model | 15:06 |
| amotoki | but it is up to our PTL :) | 15:07 |
| vishalmanchanda | amotoki: You mean we can accept feature patches even after R-5 week? | 15:08 |
| amotoki | vishalmanchanda: yes | 15:08 |
| vishalmanchanda | amotoki: Feature freeze exception I know | 15:08 |
| amotoki | from the point of view of our release model | 15:08 |
| amotoki | we use cycle-with-intemediary model | 15:09 |
| vishalmanchanda | but my thought is we have some bandwidth if a new added feature breaks anything. | 15:09 |
| vishalmanchanda | we can fix that issue. | 15:09 |
| amotoki | vishalmanchanda: yeah, it makes sense from different points like what you mentioned. | 15:10 |
| vishalmanchanda | next announcement is about Zed Cycle PTG. | 15:11 |
| vishalmanchanda | I have booked time slots and created a etherpad for Zed Cycle PTG. | 15:11 |
| vishalmanchanda | #link https://etherpad.opendev.org/p/horizon-zed-ptg | 15:12 |
| vishalmanchanda | I have booked the same Time Slots we used during last PTG's. | 15:12 |
| vishalmanchanda | I hope this works for everyone. | 15:13 |
| vishalmanchanda | I know it's going to conflict with cinder and neutron PTG. | 15:13 |
| vishalmanchanda | Please let me know before PTG if that time doesn't work for you, I will try to book other time slots. | 15:14 |
| vishalmanchanda | that's all announcement from my side for this week. | 15:15 |
| vishalmanchanda | If anyone have any announcement to make, please go ahead. | 15:15 |
| vishalmanchanda | ok nothing, moving to next topic. | 15:16 |
| vishalmanchanda | #topic Release priorities | 15:17 |
| vishalmanchanda | e0ne: a reminder for Ivan to release pyscss with https://github.com/Kronuz/pyScss/pull/411 fix | 15:18 |
| e0ne | I'm preparing it now. need to check if something more should be included | 15:18 |
| vishalmanchanda | e0ne: thanks:) | 15:19 |
| vishalmanchanda | there is nothing else added in this section. | 15:19 |
| vishalmanchanda | moving to next topic | 15:20 |
| vishalmanchanda | #topic Bug deputy report | 15:20 |
| vishalmanchanda | We have 3 new bugs reported from last week. | 15:20 |
| vishalmanchanda | first one looks invalid to me https://bugs.launchpad.net/horizon/+bug/1960887 | 15:22 |
| vishalmanchanda | I mean we have list of supported python version in setup.cfg | 15:23 |
| amotoki | I am not sure about the full context. it is related to libs we depend on. | 15:24 |
| vishalmanchanda | but we can add a parameter in our setup.cfg like done in other projects | 15:24 |
| amotoki | I have no strong opinion on this though | 15:24 |
| vishalmanchanda | https://opendev.org/openstack/cyborg/src/branch/master/setup.cfg#L9 | 15:24 |
| amotoki | does horizon 21.0.0 work ONLY with python >=3.6? | 15:25 |
| amotoki | If it depends on oslo lib(s) version, I am not sure whether it is the right decision that horizon adds such python version requirement. | 15:26 |
| amotoki | (note that I have not checked the full context on this bug) | 15:26 |
| vishalmanchanda | author of bug also suggesting to add a parameter which indicate horizon work with python >=3.6 | 15:28 |
| vishalmanchanda | I can see many openstack project use this in setup.cfg https://codesearch.openstack.org/?q=python_requires&i=nope&literal=nope&files=&excludeFiles=&repos= | 15:29 |
| vishalmanchanda | we can also follow the same. | 15:29 |
| vishalmanchanda | 2nd bug https://bugs.launchpad.net/horizon/+bug/1960834 | 15:30 |
| amotoki | I would like to note that oslo.i18n itself mentioned in the bug report does not have such requirements | 15:31 |
| amotoki | so I cannot have any suggestion right now | 15:32 |
| vishalmanchanda | just tried to reproduce the 2nd bug | 15:33 |
| vishalmanchanda | I am facing the same issue in my env. | 15:33 |
| vishalmanchanda | will take a look after the meeting | 15:34 |
| vishalmanchanda | 3rd bug is about updating JS libraries https://bugs.launchpad.net/horizon/+bug/1955556 | 15:36 |
| amotoki | I believe gibi's comment in #10 is the right assessment | 15:37 |
| zigo | vmarkov: Hi there! FYI, I'm backporting your patch here: https://review.opendev.org/c/openstack/horizon/+/808102 | 15:37 |
| zigo | to Xena, Wallaby and Victoria. I did already the backport to Xena and it's looking good. Once your patch gets merged, I can push the patch if you're ok with that ! | 15:37 |
| zigo | Your thoughts? | 15:37 |
| vishalmanchanda | amotoki: yes. | 15:38 |
| amotoki | zigo: could you wait for a while as we are in a team meeting time now? | 15:38 |
| zigo | Sorry, will do. | 15:39 |
| amotoki | zigo: I can help you on the backport as I am wokring on the fix together now. | 15:39 |
| * zigo didn't notice the meeting | 15:39 | |
| amotoki | zigo: np | 15:39 |
| amotoki | let's move back to the original topic on bug 1955556 | 15:40 |
| vishalmanchanda | I can update jQuery and jQuery Migrate version to latest one | 15:41 |
| vishalmanchanda | like I done for AngularJS in past | 15:41 |
| amotoki | vishalmanchanda: IiRC, we hit some problem when we tried to upgrade jquery-migate to the latest version | 15:42 |
| vishalmanchanda | but I need some help with make it work with horizon. | 15:42 |
| amotoki | I don't know what was the issue though | 15:42 |
| vishalmanchanda | If I am not wrong jQuery Migrate latest version is 3.3.2 | 15:44 |
| vishalmanchanda | https://github.com/jquery/jquery-migrate | 15:44 |
| vishalmanchanda | https://github.com/jquery/jquery | 15:45 |
| vishalmanchanda | jquery latest version is 3.6.0 | 15:45 |
| vishalmanchanda | wondering why we are not using latest version https://pypi.org/project/XStatic-jQuery/ | 15:47 |
| vishalmanchanda | anyway I will take a look at it after the meeting | 15:48 |
| amotoki | I would like to raise that https://review.opendev.org/c/openstack/requirements/+/773823 was merged once | 15:48 |
| amotoki | but I needed to revert it to the current version | 15:48 |
| amotoki | https://review.opendev.org/c/openstack/requirements/+/773823 | 15:48 |
| amotoki | the first URL should be https://review.opendev.org/c/openstack/requirements/+/772736 sorry | 15:49 |
| vishalmanchanda | ohh I remember we need to fix some warnings to make it work with horizon | 15:49 |
| vishalmanchanda | otherwise horizon-integration jobs fails that's why we revert it. | 15:49 |
| vishalmanchanda | hmm | 15:50 |
| vishalmanchanda | we have 10 mins. left | 15:50 |
| vishalmanchanda | Does anyone have any other topic to discuss. | 15:50 |
| amotoki | I hope we land fixes on django40 warnings | 15:51 |
| vishalmanchanda | ++ | 15:51 |
| amotoki | they aree not ciritical, but they annoys me a lot...... | 15:51 |
| vishalmanchanda | me too I use runserver for development | 15:52 |
| amotoki | another topic is the failure rate in our integration tests. | 15:53 |
| amotoki | I am not sure it is transient | 15:53 |
| amotoki | or we need to look into it with a high-priority topic | 15:53 |
| vishalmanchanda | there few integration tests which fails most of the time. | 15:54 |
| vishalmanchanda | ok if nothing else to discuss we can end this meeting. | 15:55 |
| vishalmanchanda | Thanks everyone for your contributions. | 15:56 |
| vishalmanchanda | See you next week. | 15:56 |
| vishalmanchanda | #endmeeting | 15:56 |
| opendevmeet | Meeting ended Wed Feb 16 15:56:42 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:56 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-16-15.00.html | 15:56 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-16-15.00.txt | 15:56 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-16-15.00.log.html | 15:56 |
| zigo | vmarkov: Around? | 16:25 |
| vishalmanchanda | zigo: hi, I don't see any issue in backporting https://review.opendev.org/c/openstack/horizon/+/808102 to stable branches. | 16:54 |
| vishalmanchanda | zigo: I can help with backport once patch in master branch lands. | 16:55 |
| opendevreview | Rodrigo Barbieri proposed openstack/horizon master: Implement pagination in admin/proj network tab https://review.opendev.org/c/openstack/horizon/+/806454 | 21:16 |
| *** prometheanfire is now known as Guest2 | 22:59 | |
| *** Guest2 is now known as prometheanfire | 23:05 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!