opendevreview | Sam Morrison proposed openstack/horizon master: Include the images name on the image detail page https://review.opendev.org/c/openstack/horizon/+/819943 | 02:48 |
---|---|---|
vishalmanchanda | #startmeeting horizon | 15:00 |
opendevmeet | vishalmanchanda: Error: Can't start another meeting, one is in progress. Use #endmeeting first. | 15:00 |
vishalmanchanda | #endmeeting | 15:00 |
opendevmeet | Meeting ended Wed Dec 1 15:00:54 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-11-17-15.00.html | 15:00 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-11-17-15.00.txt | 15:00 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-11-17-15.00.log.html | 15:00 |
vishalmanchanda | #startmeeting horizon | 15:01 |
opendevmeet | Meeting started Wed Dec 1 15:01:05 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
opendevmeet | The meeting name has been set to 'horizon' | 15:01 |
ganso | o/ | 15:01 |
vishalmanchanda | hi all | 15:01 |
amotoki | hi | 15:02 |
vishalmanchanda | let's wait for two more minutes if more people join us. | 15:02 |
vishalmanchanda | e0ne: tmazur :ping. | 15:04 |
tmazur | o/ | 15:04 |
e0ne | hi | 15:04 |
vishalmanchanda | ok let's start the meeting. | 15:04 |
vishalmanchanda | #topic Notices | 15:04 |
vishalmanchanda | This week is R-17. | 15:05 |
vishalmanchanda | Yoga Schedule https://releases.openstack.org/yoga/schedule.html | 15:05 |
vishalmanchanda | Next announcement is about runtime testing for Yoga cycle. | 15:06 |
vishalmanchanda | You may have noticed that now our unit tests are running with python3.9 version instead of python 3.6 | 15:06 |
vishalmanchanda | Python runtime for Yoga is updated and can be found here https://governance.openstack.org/tc/reference/runtimes/yoga.html#python-runtimes-for-yoga | 15:07 |
vishalmanchanda | So we can drop any references of python 3.6 in horizon. | 15:08 |
vishalmanchanda | I'll update that if noone push a patch for the same later this week. | 15:08 |
vishalmanchanda | that's all announcement from my side for this week, If anyone else have any announcement to make please go ahead. | 15:09 |
vishalmanchanda | moving to next topic | 15:10 |
vishalmanchanda | #topic release priorities | 15:10 |
vishalmanchanda | No update from my side for this topic. | 15:10 |
vishalmanchanda | Patches are up for few priorities item, please review them asap. | 15:11 |
vishalmanchanda | drooping the link of patches here. | 15:11 |
vishalmanchanda | System Scope support https://review.opendev.org/c/openstack/horizon/+/816368 | 15:11 |
vishalmanchanda | Drop Django based implementation for launch instance https://review.opendev.org/c/openstack/horizon/+/816303 | 15:12 |
vishalmanchanda | Drop Django 2.2 support https://review.opendev.org/c/openstack/horizon/+/817814 | 15:12 |
vishalmanchanda | e0ne: Did you get time to test django-saas-processor patch https://review.opendev.org/c/openstack/horizon/+/794809 ? | 15:14 |
e0ne | unfortunately, not. I'll do it asap | 15:14 |
vishalmanchanda | e0ne: thanks, if Material theme also works with that patch then it will be great:) | 15:15 |
vishalmanchanda | Next week I will pick another item(with no owner to work) from release priority etherpad. | 15:15 |
vishalmanchanda | moving to next topic | 15:15 |
vishalmanchanda | #topic Bug deputy report | 15:16 |
vishalmanchanda | there are two bugs for discussion for this week. | 15:16 |
vishalmanchanda | First one is https://bugs.launchpad.net/horizon/+bug/1913447 | 15:17 |
vishalmanchanda | Actually I am unable to reproduce this bug on master branch, need to check if still exits in stable branches. | 15:17 |
vishalmanchanda | I have reported this bug but now I am unable to reproduce it, So if anyone from the horizon team can verify if it still exits or not. | 15:19 |
amotoki | hmm... I hit this at least with Django 2.2. I am not sure it still exists with Django 3. | 15:19 |
vishalmanchanda | amotoki: tmazur : Could you check if you are able to reproduce it or not? | 15:19 |
amotoki | vishalmanchanda: how about with Django22? | 15:20 |
tmazur | Sure, will do | 15:20 |
amotoki | I haven't test it after migrating to django3. | 15:20 |
vishalmanchanda | amotoki: I haven't checked it with Django22, will try that. | 15:20 |
amotoki | at least in the era of django22 tox -e runserver was completely broken for AngularJS development. | 15:21 |
amotoki | I think you filed it when we used django 22 | 15:21 |
vishalmanchanda | yeah. | 15:21 |
vishalmanchanda | Please add your comment in bug summary if you able to reproduce it or not. | 15:22 |
vishalmanchanda | Next bug is https://bugs.launchpad.net/horizon/+bug/1951669 | 15:22 |
vishalmanchanda | we need to verify https://bugs.launchpad.net/horizon/+bug/1951669 if it is valid or not. | 15:23 |
vishalmanchanda | I will take a look at it tomorrow. | 15:24 |
vishalmanchanda | moving to next topic | 15:24 |
vishalmanchanda | #topic Open reviews | 15:25 |
vishalmanchanda | there are two patches with review request | 15:26 |
vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/806454 | 15:26 |
vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/805360 | 15:27 |
ganso | I just wanted to raise awareness of 806454 ^ . It is a quite drastic patch and changes the way the contents of the page are queried and rendered, so it pretty much breaks most of the tests and those need to be reworked, so I'd like some input and feedback if you agree with the direction before I invest more effort reworking the tests because otherwise they will have to be reworked again. The earlier review the better as it | 15:27 |
ganso | will still take some time for me to finish reworking the tests and it would be great if we could land this in yoga | 15:27 |
ganso | I know most people are busy with other things but the patch has been sitting a while, given we are around mid-Yoga cycle it could end up missing Yoga, as the final patch will be bigger with tests and will still need to be reviewed in time | 15:30 |
vishalmanchanda | ahh ganso is asking for review from long, actually gate is failing for this patch so I didn't take a look. | 15:30 |
ganso | vishalmanchanda: I didn't check gate because I'd assume it was failing due to the broken tests that need to reworked. I tested this patch in my env while I was working on it so I know it works (or at least did back then), so you could apply the patch in a working env and test to see how it renders the page | 15:31 |
vishalmanchanda | ganso: sure I will try your patch in my env. by tomorrow and will share some feedback. | 15:32 |
ganso | vishalmanchanda: thank you! | 15:32 |
vishalmanchanda | ganso: thanks for your patience. | 15:33 |
vishalmanchanda | Second review request is from nitish https://review.opendev.org/c/openstack/horizon/+/805360 | 15:33 |
vishalmanchanda | about Network QoS Policy rule | 15:34 |
vishalmanchanda | amotoki: JFYI patch which adds min. packet rate in python-neutronclient is merged last week. | 15:34 |
vishalmanchanda | https://review.opendev.org/c/openstack/python-neutronclient/+/812132 | 15:35 |
amotoki | yeah, I am aware of it, but I need to check the detail context including a new release of neutronclient. | 15:35 |
vishalmanchanda | amotoki: ok. | 15:36 |
vishalmanchanda | that is all from my side for this week, Do anyone have any other topic to discuss | 15:37 |
vishalmanchanda | Otherwise we can end this meeting. | 15:37 |
tmazur | e0ne: if you have some time, please take a look at this patch: https://review.opendev.org/c/openstack/horizon/+/800283 | 15:38 |
vishalmanchanda | ++ | 15:39 |
e0ne | tmazur: approved | 15:40 |
vishalmanchanda | Thanks everyone for joining. | 15:40 |
tmazur | e0ne: thank you! | 15:40 |
vishalmanchanda | See you next week. | 15:40 |
tmazur | Thanks everyone! | 15:40 |
vishalmanchanda | #endmeeting | 15:40 |
opendevmeet | Meeting ended Wed Dec 1 15:40:53 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:40 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-12-01-15.01.html | 15:40 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-12-01-15.01.txt | 15:40 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-12-01-15.01.log.html | 15:40 |
*** gmann is now known as gmann_afk | 17:34 | |
*** gmann_afk is now known as gmann | 18:53 | |
opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Integration tast navigation machinery for Angular pages https://review.opendev.org/c/openstack/horizon/+/819725 | 21:28 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!