| rosmaita | amotoki: around? | 01:48 |
|---|---|---|
| amotoki | rosmaita: hi | 01:49 |
| rosmaita | finally got the patch working and passing tests | 01:50 |
| rosmaita | vishal had some comments about the release note, let me know if you want me to revise it | 01:50 |
| amotoki | sure. I will review it soon after the current internal meeting finishes. | 01:51 |
| rosmaita | great! thanks | 01:51 |
| *** iurygregory_ is now known as iurygregory | 06:38 | |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 06:56 |
| opendevreview | Nitish Venkata Patcherla proposed openstack/horizon master: WIP: Add create rule operation to QoS Policy https://review.opendev.org/c/openstack/horizon/+/801020 | 06:59 |
| amotoki | vishalmanchanda: cinderclient patch is more than cinderclient v2 API support removal. It is now the drop of cinder v2 API support in horizon. | 07:06 |
| amotoki | vishalmanchanda: so I am updating the commit message and the release note. | 07:06 |
| amotoki | vishalmanchanda: if we limit the scope of the patch to make horizon work with the upcoming cinderclient release, it does not necessarily mean that cinder v2 API drop in horizon. | 07:07 |
| amotoki | vishalmanchanda: I am okay with dropping cinder v2 API support now but perhaps we are mixing two things (cinderclient 8.0.0 support and the removal of cinder v2 support) | 07:08 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Drop cinder v2 API support https://review.opendev.org/c/openstack/horizon/+/800814 | 07:10 |
| amotoki | rosmaita: ^ (what I wrote above) | 07:27 |
| rosmaita | amotoki: thanks for your update, i missed quite a few things. I agree with the update you made to the commit message, it summarizes what the patch does very nicely | 09:06 |
| rosmaita | i left a suggestion for updating the release note, but otherwise this patch LGTM and will unblock the cinderclient from removing the v2 classes | 09:08 |
| vishalmanchanda | amotoki: ok, got your point. | 09:15 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!