*** gyee has quit IRC | 00:56 | |
*** openstackgerrit has joined #openstack-horizon | 01:53 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Add Unit Test for cinder-user-facing messages https://review.opendev.org/750882 | 01:53 |
---|---|---|
*** rcernin has quit IRC | 02:26 | |
*** rcernin has joined #openstack-horizon | 02:50 | |
*** rcernin has quit IRC | 02:57 | |
*** rcernin has joined #openstack-horizon | 02:59 | |
*** rcernin has quit IRC | 02:59 | |
*** rcernin has joined #openstack-horizon | 03:00 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Relnote on disabling stripping leading/trailing spaces in password https://review.opendev.org/754254 | 03:04 |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Relnote on disabling stripping leading/trailing spaces in password https://review.opendev.org/754254 | 03:59 |
*** viks____ has joined #openstack-horizon | 06:37 | |
*** dklyle has quit IRC | 06:37 | |
*** jtomasek has joined #openstack-horizon | 06:58 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/754269 | 07:07 |
*** jtomasek_ has joined #openstack-horizon | 07:15 | |
*** jtomasek has quit IRC | 07:17 | |
*** rcernin has quit IRC | 07:39 | |
*** tosky has joined #openstack-horizon | 07:43 | |
openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/754269 | 07:49 |
*** kevko has joined #openstack-horizon | 08:14 | |
*** rcernin has joined #openstack-horizon | 08:40 | |
*** rcernin has quit IRC | 08:45 | |
*** e0ne has joined #openstack-horizon | 08:52 | |
*** ChanServ sets mode: +o e0ne | 08:52 | |
*** rcernin has joined #openstack-horizon | 09:33 | |
*** kevko has quit IRC | 09:55 | |
*** kevko has joined #openstack-horizon | 10:00 | |
*** kevko has quit IRC | 10:08 | |
*** kevko_ has joined #openstack-horizon | 10:08 | |
*** kevko_ has quit IRC | 10:08 | |
*** kevko has joined #openstack-horizon | 10:08 | |
*** rcernin has quit IRC | 10:10 | |
*** kevko_ has joined #openstack-horizon | 10:12 | |
*** kevko has quit IRC | 10:16 | |
*** kevko_ has quit IRC | 10:19 | |
*** rdopiera has joined #openstack-horizon | 10:21 | |
*** kevko has joined #openstack-horizon | 10:22 | |
*** kevko_ has joined #openstack-horizon | 10:23 | |
openstackgerrit | Merged openstack/horizon master: Add Unit Test for cinder-user-facing messages https://review.opendev.org/750882 | 10:23 |
openstackgerrit | Merged openstack/horizon master: Relnote on disabling stripping leading/trailing spaces in password https://review.opendev.org/754254 | 10:23 |
*** kevko has quit IRC | 10:27 | |
*** kevko_ has quit IRC | 10:28 | |
*** noonedeadpunk has quit IRC | 10:33 | |
*** noonedeadpunk has joined #openstack-horizon | 10:35 | |
*** kevko has joined #openstack-horizon | 10:36 | |
e0ne | FYI, https://review.opendev.org/#/c/754350/ - Horizon 18.6.0 and stable/victoria branch creation | 10:48 |
*** kevko has quit IRC | 11:26 | |
*** kevko has joined #openstack-horizon | 11:29 | |
*** rcernin has joined #openstack-horizon | 11:41 | |
*** kevko has quit IRC | 12:10 | |
*** kevko has joined #openstack-horizon | 12:10 | |
*** kevko_ has joined #openstack-horizon | 12:14 | |
*** kevko has quit IRC | 12:16 | |
*** kevko has joined #openstack-horizon | 12:16 | |
*** kevko_ has quit IRC | 12:18 | |
*** kevko has quit IRC | 12:24 | |
openstackgerrit | OpenStack Release Bot proposed openstack/horizon stable/victoria: Update .gitreview for stable/victoria https://review.opendev.org/754367 | 12:28 |
openstackgerrit | OpenStack Release Bot proposed openstack/horizon stable/victoria: Update TOX_CONSTRAINTS_FILE for stable/victoria https://review.opendev.org/754368 | 12:28 |
openstackgerrit | OpenStack Release Bot proposed openstack/horizon master: Update master for stable/victoria https://review.opendev.org/754369 | 12:28 |
openstackgerrit | OpenStack Release Bot proposed openstack/horizon master: Add Python3 wallaby unit tests https://review.opendev.org/754370 | 12:28 |
*** kevko has joined #openstack-horizon | 12:28 | |
*** jtomasek has joined #openstack-horizon | 12:33 | |
*** kevko has quit IRC | 12:34 | |
*** jtomasek_ has quit IRC | 12:36 | |
*** kevko has joined #openstack-horizon | 12:38 | |
*** kevko has quit IRC | 12:39 | |
*** kevko has joined #openstack-horizon | 12:39 | |
*** gmann is now known as gmann_pto | 12:41 | |
*** vinay_m has joined #openstack-horizon | 12:45 | |
vinay_m | https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/views.py#L154 | 12:47 |
vinay_m | hi all, if trying filter non api filters(which are not supported by api like flavor_name, image_name) | 12:48 |
vinay_m | over there trying to map to their respective id's | 12:49 |
vinay_m | that was scenario when trying from project tab | 12:49 |
vinay_m | but it was diff from admin tab https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/admin/instances/views.py#L155 | 12:51 |
vinay_m | for that id mapping , first trying to create a dict of tuples (name, id) and then passed to a function for that swaping with id and updating it in search_opt dict | 12:52 |
vinay_m | and that search_opts dict is passed to get filtered instances | 12:53 |
vinay_m | but in admin tab before mapping , call to get instances is happening and that instances are passed as a tuple obj along with self._get_images | 12:55 |
vinay_m | in here: https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/admin/instances/views.py#L156 | 12:55 |
*** vinay_m has quit IRC | 12:56 | |
*** vinay_m has joined #openstack-horizon | 12:56 | |
vinay_m | can anyone explain me , why it was done like that in admin tab | 12:56 |
*** rdopiera has quit IRC | 13:04 | |
*** dave-mccowan has joined #openstack-horizon | 13:14 | |
*** dave-mccowan has quit IRC | 13:20 | |
*** rcernin has quit IRC | 13:21 | |
*** tmazur has joined #openstack-horizon | 13:34 | |
openstackgerrit | Merged openstack/horizon stable/victoria: Update .gitreview for stable/victoria https://review.opendev.org/754367 | 13:49 |
openstackgerrit | Merged openstack/horizon master: Update master for stable/victoria https://review.opendev.org/754369 | 13:57 |
*** andrewbogott has joined #openstack-horizon | 14:01 | |
*** dklyle has joined #openstack-horizon | 14:18 | |
*** ChanServ sets mode: +o dklyle | 14:18 | |
*** dklyle sets mode: -o dklyle | 14:21 | |
*** andrewbogott has left #openstack-horizon | 14:37 | |
*** tkajinam has quit IRC | 15:00 | |
*** dklyle has quit IRC | 15:13 | |
*** dklyle has joined #openstack-horizon | 15:14 | |
*** ChanServ sets mode: +o dklyle | 15:14 | |
*** vinay_m has quit IRC | 15:18 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon master: Fix Jasmine Spec Runner for Django messages patch https://review.opendev.org/754434 | 15:39 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: DNR. Test Ironic cross-project job https://review.opendev.org/754440 | 15:41 |
tmazur | ping e0ne | 15:42 |
e0ne | tmazur: hi | 15:42 |
e0ne | tmazur: hm.. interesting.. will it work for plugins too? | 15:43 |
tmazur | e0ne hey take a look at this: https://review.opendev.org/754434 | 15:43 |
e0ne | tmazur: I've just understood that at least ironic-ui is broken https://review.opendev.org/754439 | 15:44 |
e0ne | tmazur: your fix looks good, but why we didn't face any issues on our CI? | 15:45 |
tmazur | I suppose the line should be added for jasmine.html in ironic-ui as well | 15:45 |
tmazur | Karma-jasmine feels just good with fixed karma.conf.js | 15:46 |
tmazur | But jasmine spec runner in browser needs additional fix at jasine.html | 15:46 |
e0ne | this line https://review.opendev.org/#/c/754439/1/ironic_ui/karma.conf.js@42 says that we don't need change in both jasmine.html and karma.conf.js | 15:47 |
e0ne | how do you run jasmine spec runner? | 15:47 |
tmazur | http://localhost:8000/jasmine/ | 15:48 |
tmazur | Can you run it for ironic-ui? | 15:50 |
e0ne | how to start it? | 15:50 |
e0ne | I usually use 'rox -e npm' for JS tests | 15:50 |
tmazur | start runserver first | 15:51 |
tmazur | tox -e runserver | 15:51 |
e0ne | tmazur: thanks | 15:52 |
e0ne | I didn't know about this | 15:53 |
tmazur | yw | 15:54 |
*** gyee has joined #openstack-horizon | 15:55 | |
e0ne | we definitely need to add this into the documentation | 15:57 |
tmazur | +1 | 16:01 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: DNR. Test Ironic cross-project job https://review.opendev.org/754440 | 16:41 |
*** e0ne has quit IRC | 16:45 | |
*** kevko has quit IRC | 18:00 | |
*** dklyle has quit IRC | 18:41 | |
*** dklyle has joined #openstack-horizon | 18:42 | |
*** ChanServ sets mode: +o dklyle | 18:42 | |
*** dklyle sets mode: -o dklyle | 18:52 | |
*** spatel has joined #openstack-horizon | 20:09 | |
*** spatel has quit IRC | 20:13 | |
*** jtomasek has quit IRC | 21:58 | |
*** tmazur has quit IRC | 22:52 | |
*** tosky has quit IRC | 22:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!