| *** tosky has quit IRC | 00:50 | |
| *** btully has joined #openstack-horizon | 01:08 | |
| *** btully has quit IRC | 01:12 | |
| *** vishalmanchanda has joined #openstack-horizon | 01:33 | |
| *** ianychoi_ has joined #openstack-horizon | 01:38 | |
| *** ianychoi has quit IRC | 01:40 | |
| *** xinranwang has joined #openstack-horizon | 02:58 | |
| *** gyee has quit IRC | 04:08 | |
| *** xinranwang has quit IRC | 06:07 | |
| openstackgerrit | Merged openstack/xstatic-bootstrap-scss master: Upgrade to 3.4.1 https://review.opendev.org/710865 | 07:35 |
|---|---|---|
| *** tesseract has joined #openstack-horizon | 07:51 | |
| *** jawad_axd has joined #openstack-horizon | 07:51 | |
| *** threestrands has quit IRC | 08:01 | |
| *** guilhermesp has quit IRC | 08:09 | |
| *** fyx has quit IRC | 08:09 | |
| *** Nizars has quit IRC | 08:09 | |
| *** Nizars has joined #openstack-horizon | 08:10 | |
| *** mnaser has quit IRC | 08:10 | |
| *** fyx has joined #openstack-horizon | 08:11 | |
| *** mnaser has joined #openstack-horizon | 08:11 | |
| *** guilhermesp has joined #openstack-horizon | 08:11 | |
| *** rpittau|afk is now known as rpittau | 08:11 | |
| *** tkajinam has quit IRC | 08:12 | |
| *** e0ne has joined #openstack-horizon | 08:16 | |
| *** ChanServ sets mode: +o e0ne | 08:16 | |
| *** tosky has joined #openstack-horizon | 08:21 | |
| *** btully has joined #openstack-horizon | 08:23 | |
| *** btully has quit IRC | 08:28 | |
| *** hrw has left #openstack-horizon | 08:31 | |
| *** rdopiera has joined #openstack-horizon | 08:31 | |
| *** yoctozepto has quit IRC | 09:07 | |
| amotoki | e0ne: hi, I was asked if a new horizon release is coming. pyscss issue was fixed in the horizon repo but it is not fixed in horizon plugins. | 09:09 |
| amotoki | e0ne: it is because horizon plugins tox job first installs a released version of horizon. | 09:10 |
| amotoki | e0ne: my question is whether we will move back to pyscss again as you are now a maintainer of pyscss. | 09:10 |
| *** yoctozepto0 has joined #openstack-horizon | 09:16 | |
| openstackgerrit | Oleksiy Petrenko proposed openstack/horizon master: Change horizon test runner to pytest https://review.opendev.org/711195 | 09:24 |
| *** yoctozepto9 has joined #openstack-horizon | 09:27 | |
| *** yoctozepto0 has quit IRC | 09:27 | |
| *** e0ne has quit IRC | 09:36 | |
| *** e0ne has joined #openstack-horizon | 09:36 | |
| *** ChanServ sets mode: +o e0ne | 09:36 | |
| *** vishalmanchanda has quit IRC | 10:03 | |
| *** vishalmanchanda has joined #openstack-horizon | 10:22 | |
| e0ne | amotoki: hi. I'm going to fix horizon to work with the latest pyscss before I release a new one | 10:31 |
| e0ne | amotoki: so it seems to be reasonable to release horizon with pyscss2 for now to unblock plugins | 10:31 |
| *** tesseract has quit IRC | 10:36 | |
| *** yoctozepto9 is now known as yoctozepto | 10:37 | |
| *** tesseract has joined #openstack-horizon | 10:42 | |
| *** tesseract has quit IRC | 10:46 | |
| *** tesseract has joined #openstack-horizon | 10:48 | |
| *** tesseract-RH has joined #openstack-horizon | 11:00 | |
| *** tesseract-RH has left #openstack-horizon | 11:02 | |
| *** tesseract has quit IRC | 11:03 | |
| amotoki | e0ne: okay, I will prepare a new release. thanks | 11:17 |
| e0ne | amotoki: np | 11:18 |
| *** rpittau is now known as rpittau|bbl | 11:30 | |
| vishalmanchanda | amotoki: hi around? | 11:38 |
| amotoki | vishalmanchanda: hi | 11:47 |
| vishalmanchanda | amotoki: hope you are fine. | 11:48 |
| vishalmanchanda | amotoki: any thoughts on this patch https://review.opendev.org/#/c/713752/ ? | 11:48 |
| amotoki | vishalmanchanda: what's the context? | 11:50 |
| -amotoki- is not in the work mode so he tends to be lazy | 11:50 | |
| vishalmanchanda | amotoki: I mean it is backported to stable/train to fix gate which i think is not correct. | 11:51 |
| *** dave-mccowan has joined #openstack-horizon | 11:53 | |
| amotoki | vishalmanchanda: why do you think it is not correct? what is the original gate failure? | 11:53 |
| vishalmanchanda | amotoki: 'openstack-tox-lower-constraints' job is failing in patch set 1 of this patch https://review.opendev.org/#/c/710211/ | 11:55 |
| vishalmanchanda | amotoki: when stable/train branch cut for Sahara-dashboard it doesn't support django2.2 | 11:58 |
| vishalmanchanda | but if this patch https://review.opendev.org/#/c/713752/ is merged then we are adding django2.2 support in stable branch which i think is wrong. | 11:59 |
| vishalmanchanda | amotoki: am i confusing you:( | 12:00 |
| amotoki | vishalmanchanda: if lower-constraints failure is the reason, what needs to be done first is to check why django 2.2 is installed in lower-constraints.txt | 12:00 |
| amotoki | s/lower-constraints.txt/l-c job/ | 12:01 |
| vishalmanchanda | amotoki: excatly. | 12:02 |
| amotoki | looking at the l-c job of https://review.opendev.org/#/c/710211/, django 2.2 was installed when installing sahara-dashboard itself | 12:02 |
| amotoki | See "-2" log of tox https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_da0/710211/1/check/openstack-tox-lower-constraints/da044c1/tox/lower-constraints-2.log | 12:02 |
| amotoki | this step is expected to install only sahara-dashboard | 12:03 |
| amotoki | but several other packages are installed. | 12:03 |
| amotoki | I wonder why horizon 18.0.0 was installed. | 12:04 |
| vishalmanchanda | amotoki: yeah. | 12:05 |
| amotoki | ah.... sahara-dashboard requirements.txt says horizon>=14.0.0.0b3, but lower-constraints.txt says horizon==14.0.0.0b2 | 12:05 |
| amotoki | lower-bound should match | 12:06 |
| vishalmanchanda | amotoki: ohh. | 12:06 |
| amotoki | that's the reason the latest horizon was installed. | 12:06 |
| vishalmanchanda | amotoki: thanks:) | 12:06 |
| amotoki | vishalmanchanda: regarding your comment in https://review.opendev.org/#/c/713752/, you commented ".... It is wrong..." without reason. I would suggest to add the reason of "wrong" together. | 12:08 |
| amotoki | vishalmanchanda: I wondered why it is wrong when I glanced it. | 12:08 |
| vishalmanchanda | amotoki: my bad:( | 12:09 |
| *** e0ne_ has joined #openstack-horizon | 12:20 | |
| *** e0ne has quit IRC | 12:21 | |
| amotoki | vishalmanchanda: commented in https://review.opendev.org/#/c/713752/ | 12:30 |
| vishalmanchanda | amotoki: thanks. | 12:31 |
| vishalmanchanda | amotoki: I have pushed a patch to fix it. Let's see if it works.... | 12:31 |
| vishalmanchanda | amotoki: it's worked:). | 12:35 |
| *** rpittau|bbl is now known as rpittau | 12:59 | |
| tosky | vishalmanchanda, amotoki: thanks for the details on https://review.opendev.org/#/c/713752/ - I didn't think that backporting the patch was wrong because horizon-openstack-tox-python3-django22 is executed also on horizon stable/train | 13:12 |
| tosky | so I thought it is supported | 13:12 |
| amotoki | tosky: backporting the usage of horizon non-primary-django jobs itself is no problem to me as long as it works, but it should be separated from a failure fix. | 13:21 |
| amotoki | tosky: that confused me | 13:21 |
| vishalmanchanda | amotoki: tosky: ok I will remove -1 from the patch. | 13:22 |
| vishalmanchanda | If it look fine to both of you. | 13:24 |
| tosky | amotoki: I backported all together because that patch fixed exactly the same issue in master back then | 13:24 |
| tosky | then I noticed that horizon started using horizon-openstack-tox-python3-django22 before branching train, so I though the change made sense in sahara-dashboard too | 13:24 |
| tosky | anyway, in order to merge anything I guess we need to wait for the py37 fix | 13:26 |
| amotoki | tosky: I think lower-constraints fix should be done separately. | 13:27 |
| amotoki | tosky: re: horizon-openstack-tox-python3-django22, horizon train supports django 2.2 but most horizon plugins do not. | 13:28 |
| tosky | sure, I will make sure that's going to happen; still we need to wait for the pyScss fix | 13:28 |
| amotoki | tosky: I am not sure we need to add django 2.2 support in horizon plugins after the release. | 13:28 |
| vishalmanchanda | amotoki: yeah this is reason of my -1. | 13:29 |
| amotoki | tosky: pyscss fix in stable branches needs another story than the master branch. | 13:29 |
| tosky | uh, as you prefer; in sahara's case, I think it is only a matter of merging https://review.opendev.org/#/c/713752/ , but I will follow your guidelines | 13:29 |
| vishalmanchanda | But now I have removed my remote. | 13:29 |
| vishalmanchanda | vote* | 13:30 |
| amotoki | tosky: I am fine to merge it because additional support of django 2.2 has no side effect. | 13:30 |
| amotoki | tosky: but the reason is not to fix lower-constrants job. | 13:31 |
| tosky | totally fine with that | 13:31 |
| amotoki | tosky: :) | 13:31 |
| amotoki | tosky: regarding stable branch failure with pyscss, we (especially e0ne and I) are exploring a way to minimize the impact. | 13:32 |
| tosky | sooo I will keep an eye on the pyscss fix for train | 13:33 |
| tosky | thanks! | 13:33 |
| amotoki | perhaps it would be to cut a new release of pyscss | 13:33 |
| amotoki | e0ne and hrw are now maintainers of pyscss and we can explore a better approach | 13:34 |
| amotoki | tosky: we will try to keep you up-to-date anyway :) | 13:34 |
| -amotoki- will be offline (or less active) | 13:35 | |
| tosky | thanks :) | 13:36 |
| *** dklyle has joined #openstack-horizon | 14:15 | |
| *** ChanServ sets mode: +o dklyle | 14:16 | |
| *** dklyle sets mode: -o dklyle | 14:16 | |
| *** jawad_axd has quit IRC | 15:31 | |
| *** jawad_axd has joined #openstack-horizon | 15:42 | |
| *** vishalmanchanda has quit IRC | 15:43 | |
| *** spatel has joined #openstack-horizon | 15:48 | |
| *** spatel has quit IRC | 15:51 | |
| *** btully has joined #openstack-horizon | 15:59 | |
| *** btully has quit IRC | 16:04 | |
| *** rdopiera has quit IRC | 17:05 | |
| *** gyee has joined #openstack-horizon | 17:19 | |
| *** pbing19 has joined #openstack-horizon | 17:30 | |
| *** rpittau is now known as rpittau|afk | 18:06 | |
| *** gyee has quit IRC | 18:44 | |
| *** gyee has joined #openstack-horizon | 18:51 | |
| *** pbing19 has quit IRC | 19:02 | |
| *** pbing19 has joined #openstack-horizon | 19:03 | |
| *** jawad_axd has quit IRC | 19:04 | |
| *** btully has joined #openstack-horizon | 19:37 | |
| *** btully has quit IRC | 19:42 | |
| *** gyee has quit IRC | 20:03 | |
| *** e0ne_ has quit IRC | 21:04 | |
| *** e0ne has joined #openstack-horizon | 21:08 | |
| *** ChanServ sets mode: +o e0ne | 21:08 | |
| *** e0ne has quit IRC | 21:22 | |
| *** gyee has joined #openstack-horizon | 22:00 | |
| *** zigo has quit IRC | 22:22 | |
| *** zigo has joined #openstack-horizon | 22:31 | |
| *** spatel has joined #openstack-horizon | 23:42 | |
| *** spatel has quit IRC | 23:46 | |
| *** vedup19 has joined #openstack-horizon | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!