| *** gyee has quit IRC | 00:42 | |
| *** Tianhao_Hu has joined #openstack-horizon | 01:20 | |
| *** spatel has joined #openstack-horizon | 01:24 | |
| *** tkajinam has quit IRC | 01:25 | |
| *** tkajinam has joined #openstack-horizon | 01:26 | |
| openstackgerrit | Merged openstack/horizon master: django22: Replace 'render_to_response' with 'render' https://review.opendev.org/678757 | 01:43 |
|---|---|---|
| openstackgerrit | Merged openstack/horizon master: django22: django.test.client.encode_multipart no longer accepts None https://review.opendev.org/678666 | 01:43 |
| *** early has quit IRC | 02:00 | |
| *** early has joined #openstack-horizon | 02:03 | |
| *** FlorianFa has quit IRC | 02:15 | |
| *** early has quit IRC | 02:15 | |
| *** early has joined #openstack-horizon | 02:16 | |
| *** FlorianFa has joined #openstack-horizon | 02:35 | |
| openstackgerrit | Gloria Gu proposed openstack/horizon master: Updated max-width to be dynamic for .member class https://review.opendev.org/681366 | 02:53 |
| openstackgerrit | Gloria Gu proposed openstack/horizon master: Updated max-width to be dynamic for .member class https://review.opendev.org/681366 | 02:55 |
| openstackgerrit | Merged openstack/horizon master: django22: Call 'is_safe_url' with 'allowed_hosts' https://review.opendev.org/678665 | 02:55 |
| *** spatel has quit IRC | 03:03 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: trivial: Remove vendored 'is_safe_url' function https://review.opendev.org/678669 | 03:33 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Make horizon-openstack-tox-python3-django22 voting https://review.opendev.org/681227 | 03:34 |
| *** samc-bbc has quit IRC | 03:45 | |
| *** samc-bbc has joined #openstack-horizon | 03:47 | |
| *** ianychoi_ has joined #openstack-horizon | 04:24 | |
| *** ianychoi has quit IRC | 04:27 | |
| *** dave-mccowan has quit IRC | 04:29 | |
| openstackgerrit | Merged openstack/horizon master: trivial: Add TODOs for remaining function-based views https://review.opendev.org/678658 | 04:40 |
| *** pcaruana has joined #openstack-horizon | 04:42 | |
| openstackgerrit | Merged openstack/horizon master: trivial: Remove 'cache_control' decorator https://review.opendev.org/678670 | 04:46 |
| openstackgerrit | Merged openstack/horizon master: trivial: Remove dead code https://review.opendev.org/678668 | 04:46 |
| openstackgerrit | Merged openstack/horizon master: trivial: Mark inner method as such https://review.opendev.org/678667 | 04:46 |
| *** pcaruana has quit IRC | 05:12 | |
| *** jtomasek has joined #openstack-horizon | 05:13 | |
| *** rcernin has quit IRC | 05:22 | |
| *** redrobot has quit IRC | 05:25 | |
| *** rcernin has joined #openstack-horizon | 05:38 | |
| *** rcernin has quit IRC | 05:51 | |
| *** Tianhao_Hu has joined #openstack-horizon | 06:05 | |
| *** rcernin has joined #openstack-horizon | 06:09 | |
| openstackgerrit | Merged openstack/horizon master: trivial: Remove vendored 'is_safe_url' function https://review.opendev.org/678669 | 06:14 |
| *** pcaruana has joined #openstack-horizon | 06:21 | |
| *** mlycka has joined #openstack-horizon | 06:40 | |
| *** awalende has joined #openstack-horizon | 07:08 | |
| *** tesseract has joined #openstack-horizon | 07:11 | |
| openstackgerrit | Merged openstack/horizon master: Make horizon-openstack-tox-python3-django22 voting https://review.opendev.org/681227 | 07:31 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: django22: release note and docs update https://review.opendev.org/681395 | 07:32 |
| *** rcernin has quit IRC | 07:38 | |
| *** e0ne has joined #openstack-horizon | 07:56 | |
| *** ChanServ sets mode: +o e0ne | 07:56 | |
| *** e0ne has quit IRC | 08:12 | |
| *** tkajinam has quit IRC | 08:27 | |
| *** jawad_axd has joined #openstack-horizon | 08:29 | |
| *** e0ne has joined #openstack-horizon | 08:40 | |
| *** ChanServ sets mode: +o e0ne | 08:40 | |
| *** priteau has joined #openstack-horizon | 08:53 | |
| *** shilpasd has joined #openstack-horizon | 09:03 | |
| *** ianychoi_ has quit IRC | 09:09 | |
| shilpasd | Hi All: can someone help me to understand test f/w in horizon | 09:09 |
| shilpasd | at https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/networks/ports/tests.py#L268 | 09:09 |
| *** rcernin has joined #openstack-horizon | 09:10 | |
| shilpasd | if i have self.request.user, it gives me django's AnonymousUser | 09:10 |
| shilpasd | but i am not getting where exactly this user is set in request in test case | 09:11 |
| shilpasd | can sombody help me to understand this further | 09:11 |
| mlycka | shilpasd: Hi. I'm not an expert on this in any sense of the word, but I'd look around for openstack_auth.utils::get_user() usage in test. I can see it used in a Request factory to set the user in openstack_dashboard.test.helpers and manipulated in TestCase in the same file. | 09:27 |
| *** rcernin has quit IRC | 09:41 | |
| shilpasd | mlycka: openstack_auth.utils::get_user(), returns backend.get_user(user_id) or models.AnonymousUser() | 09:42 |
| shilpasd | but in request where user is set that question still not getting it | 09:42 |
| shilpasd | in test case mentioned above, its returning AnonymousUser() | 09:43 |
| shilpasd | Actually i am working on test cases for https://review.opendev.org/#/c/679967/ | 09:44 |
| shilpasd | Here pending test is i want to verify functionality for user which is not a owner of network | 09:44 |
| *** Tianhao_Hu has quit IRC | 09:52 | |
| *** ianychoi has joined #openstack-horizon | 10:30 | |
| *** ianychoi has quit IRC | 10:45 | |
| *** ianychoi has joined #openstack-horizon | 10:45 | |
| *** shilpasd has quit IRC | 11:07 | |
| *** spsurya has joined #openstack-horizon | 11:58 | |
| *** dave-mccowan has joined #openstack-horizon | 12:04 | |
| *** awalende has quit IRC | 12:22 | |
| *** awalende has joined #openstack-horizon | 12:23 | |
| *** awalende has quit IRC | 12:27 | |
| amotoki | vishalmanchanda: I -1'ed your backport to stable/rocky https://review.opendev.org/#/c/681454/ and created a new backport with the original Change-Id in https://review.opendev.org/#/c/681454/ | 12:27 |
| amotoki | vishalmanchanda: if you have questions on the backport process, feel free to ask me. | 12:28 |
| vishalmanchanda | amotoki: no problem. Thanks for fixing it. | 12:28 |
| vishalmanchanda | amotoki: +1. | 12:28 |
| -amotoki- spent too much time on horizon this week and needs to spend other projects in the rest of the week :) | 12:29 | |
| *** happyhemant has joined #openstack-horizon | 12:30 | |
| *** awalende has joined #openstack-horizon | 12:34 | |
| amotoki | vishalmanchanda: you propose several backports. Have you looked thru the stable branch section of the project team guide? | 12:36 |
| *** awalende has quit IRC | 12:38 | |
| *** e0ne has quit IRC | 12:46 | |
| *** e0ne has joined #openstack-horizon | 12:52 | |
| *** ChanServ sets mode: +o e0ne | 12:52 | |
| e0ne | amotoki, vishalmanchanda, rdopiera: could you please review https://review.opendev.org/#/c/673807/ and the depended patch? it would be good to have it before FF | 13:23 |
| vishalmanchanda | e0ne: ok reviewing. | 13:35 |
| e0ne | vishalmanchanda: thanks | 13:36 |
| amotoki | e0ne: I will look at yours a bit later. btw, what are our pending "feature" reviews? (I know my defaults.py patches hit merge conflicts with dj22 patches....) | 13:46 |
| vishalmanchanda | amotoki: e0ne : Could you help in this patch https://review.opendev.org/#/c/678185/. | 13:47 |
| vishalmanchanda | so it can also land before feature freeze. | 13:48 |
| amotoki | e0ne: vishalmanchanda: can we collect "milestone-3 priorities" in https://etherpad.openstack.org/p/horizon-release-priorities? | 13:49 |
| e0ne | I'll do it right now | 13:49 |
| amotoki | e0ne: thanks. I will be back in an hour later. | 13:49 |
| *** redrobot has joined #openstack-horizon | 13:50 | |
| amotoki | I also proposed an update on grafana.o.o. https://review.opendev.org/#/c/681361/ | 13:53 |
| amotoki | the integration test job fails frequently and I'd like to know the failure rate | 13:53 |
| *** vkmc has joined #openstack-horizon | 13:54 | |
| vkmc | o/ | 13:54 |
| vkmc | hi folks, quick question, is there a configuration option to handle user access in horizon? | 13:55 |
| *** jawad_axd has quit IRC | 13:55 | |
| vkmc | say, I have a user vkmc in keystone that can interact with the APIs | 13:55 |
| vkmc | but I don't want vkmc to access the dashboard | 13:55 |
| vkmc | can I block the user 'vkmc'? | 13:55 |
| vkmc | amotoki, e0ne, maybe you have a quick answer for that ^ | 13:56 |
| -amotoki- is on train | 13:56 | |
| e0ne | vkmc: hi. AFAIR, we don't have such feature | 13:57 |
| vkmc | e0ne, k k | 13:57 |
| mlycka | vkmc: You can block access to different features using policy files | 13:57 |
| vkmc | I was reading this https://docs.openstack.org/horizon/latest/contributor/topics/policy.html | 13:57 |
| vkmc | mlycka, was about to bring it up :) | 13:57 |
| mlycka | Right right :) | 13:58 |
| vkmc | so... how a policy for that would look like? | 13:58 |
| mlycka | Therre should be some in openstack_dashboard/conf | 14:00 |
| mlycka | I'm not sure how complete that feature is though, unfortunately. | 14:00 |
| mlycka | There's also a permissions system for panels and such, but I'm not entirely sure how that works; I only brushed up against it and that was ages ago. | 14:03 |
| vkmc | hmm yeah, looking at that seems you can configure for the services itself | 14:03 |
| vkmc | not horizon | 14:03 |
| vkmc | services being nova, glance, cinder, keystone | 14:03 |
| mlycka | Right, but horizon will display and hide and enable and disable things based on those settings; they're similar, but they exist separately from the policy files used by the services themselves. | 14:04 |
| mlycka | The images panel, for example, should only be displayed to a user if he has 'get_images' in Horizon's glance.policy file. | 14:05 |
| mlycka | *glance_policy.json | 14:06 |
| *** BjoernT has joined #openstack-horizon | 14:17 | |
| e0ne | vishalmanchanda: I'll test your patch later tonight or will early morning tomorrow | 14:32 |
| *** priteau has quit IRC | 14:34 | |
| *** KeithMnemonic has joined #openstack-horizon | 14:35 | |
| KeithMnemonic | amotoki: or anyone else, is it possible to get a WF+1 here https://review.opendev.org/#/c/679859/ ? Thanks! | 14:37 |
| amotoki | KeithMnemonic: could you wait a bit as we are busy for milestone-3 of train release (i.e. feature freeze) and we run out of bw to review stable branches ..... | 14:39 |
| KeithMnemonic | ok that is fine, is next week a reasonable ETA? | 14:40 |
| amotoki | if no upstream development, backport reviews would be speedy but it would mean no backports :p | 14:40 |
| KeithMnemonic | i understand just looking for any estimates | 14:41 |
| mlycka | e0ne: amotoki: all: Hey, guys, I replied back into the thread on discuss. I'd really appreciate it if you could throw in your two cents. | 15:22 |
| *** gyee has joined #openstack-horizon | 15:23 | |
| amotoki | mlycka: we are in the team meeting at #openstack-meeting-alt | 15:24 |
| amotoki | mlycka: I know you are waiting our replies. only Radomir replied to your thread. | 15:26 |
| mlycka | amotoki: Yeah, no problem. I'd just like your opinions so that it doesn't just become me and Radomir exchanging opinions. | 15:26 |
| openstackgerrit | Merged openstack/horizon master: Remove unused 'not_list' template argument https://review.opendev.org/681034 | 15:27 |
| openstackgerrit | Merged openstack/horizon master: django22: release note and docs update https://review.opendev.org/681395 | 15:27 |
| *** e0ne has quit IRC | 15:42 | |
| *** e0ne has joined #openstack-horizon | 15:42 | |
| *** ChanServ sets mode: +o e0ne | 15:42 | |
| *** mlycka has quit IRC | 15:47 | |
| *** spatel has joined #openstack-horizon | 16:02 | |
| *** spatel has quit IRC | 16:07 | |
| vishalmanchanda | e0ne: will review your patch https://review.opendev.org/#/c/673807/ tomorrow morning. | 16:41 |
| e0ne | vishalmanchanda: thank you | 16:41 |
| vishalmanchanda | my lappy battery will run out | 16:41 |
| vishalmanchanda | and i forgot my charger in office. | 16:41 |
| e0ne | that's why I've got two chargers | 16:44 |
| openstackgerrit | Merged openstack/horizon master: PDF documentation build https://review.opendev.org/667968 | 16:53 |
| *** e0ne has quit IRC | 16:54 | |
| *** tesseract has quit IRC | 16:57 | |
| *** awalende has joined #openstack-horizon | 17:03 | |
| *** awalende has quit IRC | 17:07 | |
| *** spsurya has quit IRC | 17:32 | |
| *** e0ne has joined #openstack-horizon | 17:55 | |
| *** ChanServ sets mode: +o e0ne | 17:55 | |
| *** e0ne has quit IRC | 17:59 | |
| *** e0ne has joined #openstack-horizon | 18:17 | |
| *** ChanServ sets mode: +o e0ne | 18:17 | |
| *** early has quit IRC | 18:37 | |
| *** early has joined #openstack-horizon | 18:41 | |
| *** rdopiera has quit IRC | 19:32 | |
| *** vishalmanchanda has quit IRC | 19:48 | |
| *** e0ne has quit IRC | 20:06 | |
| *** BjoernT has quit IRC | 20:08 | |
| *** e0ne has joined #openstack-horizon | 20:15 | |
| *** ChanServ sets mode: +o e0ne | 20:15 | |
| *** e0ne has quit IRC | 20:16 | |
| *** e0ne has joined #openstack-horizon | 20:16 | |
| *** ChanServ sets mode: +o e0ne | 20:16 | |
| *** mvkr has quit IRC | 20:27 | |
| *** e0ne has quit IRC | 20:29 | |
| *** e0ne_ has joined #openstack-horizon | 20:29 | |
| *** mvkr has joined #openstack-horizon | 20:32 | |
| *** BjoernT has joined #openstack-horizon | 20:47 | |
| *** BjoernT has quit IRC | 20:51 | |
| *** BjoernT_ has joined #openstack-horizon | 20:51 | |
| *** rcernin has joined #openstack-horizon | 21:15 | |
| *** e0ne_ has quit IRC | 21:41 | |
| *** whoami-rajat has quit IRC | 22:11 | |
| *** threestrands has joined #openstack-horizon | 22:37 | |
| *** dtruong has quit IRC | 22:55 | |
| *** dtruong has joined #openstack-horizon | 22:55 | |
| *** tkajinam has joined #openstack-horizon | 23:04 | |
| *** BjoernT_ has quit IRC | 23:18 | |
| openstackgerrit | Gloria Gu proposed openstack/horizon master: Updated max-width to be dynamic for .member class https://review.opendev.org/681366 | 23:26 |
| *** BjoernT has joined #openstack-horizon | 23:39 | |
| *** BjoernT has quit IRC | 23:48 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!