| *** hoangcx has joined #openstack-horizon | 01:00 | |
| *** btully has joined #openstack-horizon | 01:08 | |
| *** btully has quit IRC | 01:13 | |
| *** dklyle has joined #openstack-horizon | 02:42 | |
| *** ChanServ sets mode: +o dklyle | 02:42 | |
| *** david-lyle has quit IRC | 02:43 | |
| *** dklyle has quit IRC | 02:43 | |
| *** dklyle has joined #openstack-horizon | 02:43 | |
| *** ChanServ sets mode: +o dklyle | 02:43 | |
| *** cshen has joined #openstack-horizon | 02:49 | |
| *** cshen has quit IRC | 02:53 | |
| *** btully has joined #openstack-horizon | 02:57 | |
| *** btully has quit IRC | 03:02 | |
| *** early has quit IRC | 03:18 | |
| *** Bhujay has joined #openstack-horizon | 03:18 | |
| *** Bhujay has quit IRC | 03:26 | |
| *** early has joined #openstack-horizon | 03:28 | |
| *** Bhujay has joined #openstack-horizon | 04:16 | |
| *** hoangcx has quit IRC | 05:00 | |
| *** hoangcx has joined #openstack-horizon | 05:00 | |
| *** hoonetorg has quit IRC | 05:22 | |
| *** e0ne has joined #openstack-horizon | 05:26 | |
| *** ChanServ sets mode: +o e0ne | 05:26 | |
| *** hoonetorg has joined #openstack-horizon | 05:39 | |
| *** hoangcx has quit IRC | 05:44 | |
| *** hoangcx has joined #openstack-horizon | 05:44 | |
| *** e0ne has quit IRC | 06:00 | |
| *** rdopiera has joined #openstack-horizon | 06:22 | |
| *** jtomasek has joined #openstack-horizon | 06:22 | |
| *** btully has joined #openstack-horizon | 06:34 | |
| *** btully has quit IRC | 06:39 | |
| *** e0ne has joined #openstack-horizon | 06:42 | |
| *** ChanServ sets mode: +o e0ne | 06:42 | |
| *** e0ne has quit IRC | 06:43 | |
| *** btully has joined #openstack-horizon | 06:44 | |
| *** pcaruana has joined #openstack-horizon | 06:46 | |
| *** cshen has joined #openstack-horizon | 06:50 | |
| *** rcernin has quit IRC | 07:05 | |
| *** btully has quit IRC | 07:25 | |
| *** cshen has quit IRC | 07:30 | |
| *** tosky has joined #openstack-horizon | 07:30 | |
| *** adriant has quit IRC | 07:59 | |
| *** adriant has joined #openstack-horizon | 07:59 | |
| *** e0ne has joined #openstack-horizon | 08:58 | |
| *** ChanServ sets mode: +o e0ne | 08:58 | |
| *** jpich has joined #openstack-horizon | 09:00 | |
| e0ne | amotoki: hi. is it OK if I merge backports to rocky or let's ping somebody else from our team and stable cores? | 09:23 |
|---|---|---|
| *** e0ne has quit IRC | 10:51 | |
| *** btully has joined #openstack-horizon | 10:59 | |
| *** btully has quit IRC | 11:03 | |
| *** Bhujay has quit IRC | 11:17 | |
| *** dave-mccowan has joined #openstack-horizon | 11:34 | |
| *** Bhujay has joined #openstack-horizon | 11:40 | |
| *** vmarkov has joined #openstack-horizon | 11:43 | |
| *** e0ne has joined #openstack-horizon | 11:47 | |
| *** ChanServ sets mode: +o e0ne | 11:47 | |
| *** Bhujay has quit IRC | 12:16 | |
| *** Bhujay has joined #openstack-horizon | 12:16 | |
| *** needssleep is now known as TheJulia | 12:23 | |
| vmarkov | Hi amotoki. Could you review my patch once again? All your propositions are implemented https://review.openstack.org/#/c/238189/23 | 13:04 |
| amotoki | e0ne: hi, I was busy in internal things today. I will re-check stable/rocky patches from now and let you know | 13:19 |
| amotoki | vmarkov: ack. I will review it soon. thanks for the patience. | 13:21 |
| vmarkov | Thanks! | 13:22 |
| amotoki | e0ne: all pending stable/rocky patches looks fine. We cross-checked them, so I am fine to merge them. I will +W to your patches from now. | 13:24 |
| amotoki | e0ne: btw, how about https://review.openstack.org/#/c/591161/ in the master branch? | 13:25 |
| amotoki | e0ne: Hopefully we can have more eyes on it though. | 13:27 |
| e0ne | rdopiera, dklyle: ^^ | 13:44 |
| e0ne | amotoki: I'll approve it if nobody else do it today | 13:45 |
| e0ne | amotoki: we're really close to the final RC | 13:45 |
| e0ne | rdopiera: thanks, Radomir! | 13:52 |
| rdopiera | np | 13:53 |
| rdopiera | e0ne: I have one potential security issue I'd like to briefly discuss | 13:54 |
| e0ne | rdopiera: sure | 13:54 |
| rdopiera | the problem is that we use internal keystone urls to select regions | 13:54 |
| rdopiera | which means that they are publicly available on the login form and in the cookie | 13:54 |
| e0ne | :( | 13:54 |
| e0ne | it would be good to fix it | 13:55 |
| rdopiera | which is a potential leak of security-sensitive information | 13:55 |
| rdopiera | I think we can instead just use numbers | 13:55 |
| rdopiera | for the first region, second region, etc. | 13:56 |
| e0ne | rdopiera: are you talking about https://github.com/openstack/horizon/blob/f5728eed7aacba37c73aec90a312a4a5a2a4e108/openstack_auth/forms.py#L110-L115? | 13:56 |
| rdopiera | yes | 13:57 |
| rdopiera | I made a bug: https://bugs.launchpad.net/django-openstack-auth/+bug/1787943 | 13:57 |
| openstack | Launchpad bug 1787943 in django-openstack-auth "Internal endpoint address revealed in a cookie" [Undecided,New] - Assigned to Radomir Dopieralski (deshipu) | 13:57 |
| rdopiera | (I first saw it in the cookie, then realized it's also in the form) | 13:57 |
| e0ne | can we just set OPENSTACK_KEYSTONE_URL to use public endpoint? | 13:59 |
| rdopiera | I'm not sure it will be available in the network in which horizon is installed | 14:00 |
| e0ne | hm... | 14:01 |
| rdopiera | using numbers will also reduce the size of the cookie :) | 14:01 |
| *** Bhujay has quit IRC | 14:02 | |
| e0ne | what is your proposal if horizon hasn't access to the private endpoints? | 14:03 |
| rdopiera | well, hidding public endpoints won't hurt | 14:07 |
| *** lblanchard has joined #openstack-horizon | 14:24 | |
| *** e0ne has quit IRC | 14:28 | |
| *** e0ne has joined #openstack-horizon | 14:35 | |
| *** ChanServ sets mode: +o e0ne | 14:35 | |
| e0ne | https://review.openstack.org/#/c/593629/ - cherry-pick to stable/rocky | 14:37 |
| *** r-daneel has joined #openstack-horizon | 14:37 | |
| *** rdopiera has quit IRC | 15:05 | |
| *** pcaruana has quit IRC | 15:11 | |
| *** cshen has joined #openstack-horizon | 15:15 | |
| *** ircuser-1 has joined #openstack-horizon | 15:20 | |
| *** gyee has joined #openstack-horizon | 15:38 | |
| *** mvkr has quit IRC | 15:46 | |
| *** cshen has quit IRC | 16:02 | |
| *** e0ne has quit IRC | 16:16 | |
| *** cshen has joined #openstack-horizon | 16:17 | |
| *** btully has joined #openstack-horizon | 16:25 | |
| *** btully has quit IRC | 16:30 | |
| *** itlinux has joined #openstack-horizon | 16:33 | |
| *** cshen has quit IRC | 16:54 | |
| *** e0ne has joined #openstack-horizon | 17:05 | |
| *** ChanServ sets mode: +o e0ne | 17:05 | |
| *** jpich has quit IRC | 17:05 | |
| *** cshen has joined #openstack-horizon | 17:07 | |
| *** e0ne has quit IRC | 17:15 | |
| *** vmarkov has quit IRC | 17:39 | |
| *** e0ne has joined #openstack-horizon | 17:42 | |
| *** ChanServ sets mode: +o e0ne | 17:42 | |
| *** e0ne has quit IRC | 17:51 | |
| *** r-daneel has quit IRC | 18:06 | |
| *** r-daneel has joined #openstack-horizon | 18:08 | |
| *** e0ne has joined #openstack-horizon | 18:14 | |
| *** ChanServ sets mode: +o e0ne | 18:14 | |
| *** cshen has quit IRC | 18:23 | |
| *** tsmith_ has joined #openstack-horizon | 18:30 | |
| *** ircuser-1 has quit IRC | 18:33 | |
| *** tsmith2 has quit IRC | 18:33 | |
| *** _Adary has quit IRC | 18:33 | |
| *** tsmith_ is now known as tsmith2 | 18:33 | |
| *** r-daneel has quit IRC | 18:37 | |
| *** r-daneel has joined #openstack-horizon | 18:37 | |
| *** e0ne has quit IRC | 18:42 | |
| *** itlinux has quit IRC | 18:49 | |
| *** e0ne has joined #openstack-horizon | 19:06 | |
| *** ChanServ sets mode: +o e0ne | 19:06 | |
| *** e0ne has quit IRC | 19:26 | |
| *** jtomasek has quit IRC | 19:36 | |
| *** r-daneel_ has joined #openstack-horizon | 19:45 | |
| *** r-daneel has quit IRC | 19:47 | |
| *** r-daneel_ is now known as r-daneel | 19:47 | |
| *** r-daneel_ has joined #openstack-horizon | 20:02 | |
| *** r-daneel has quit IRC | 20:03 | |
| *** r-daneel_ is now known as r-daneel | 20:03 | |
| *** btully has joined #openstack-horizon | 20:03 | |
| *** btully has quit IRC | 20:08 | |
| *** lblanchard has quit IRC | 20:16 | |
| *** jtomasek has joined #openstack-horizon | 20:21 | |
| *** jtomasek has quit IRC | 20:24 | |
| *** jtomasek has joined #openstack-horizon | 20:31 | |
| *** jtomasek has quit IRC | 20:34 | |
| *** r-daneel has quit IRC | 20:44 | |
| *** r-daneel has joined #openstack-horizon | 20:50 | |
| *** mvkr has joined #openstack-horizon | 20:51 | |
| *** rcernin has joined #openstack-horizon | 21:50 | |
| *** r-daneel has quit IRC | 22:24 | |
| *** tosky has quit IRC | 23:08 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!